Public report of jpablodrexler/jp-photo-manager, published 22 October 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Watchdog signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 22 October 2026, 09:17 UTC · Survey ID cd_145217cedd93447aa3baea25ff1a563e

jpablodrexler/jp-photo-manager

Measured 22 October 2026, 09:14 UTC, at code version dfcdee9

Bus factor: not measuredBoundary Type-Coupling: not measuredKnowledge freshness: not measured

Bus factor is not measured: One contributor carries this repository.

Boundary Type-Coupling is not measured: Bounded contexts not declared.

Knowledge freshness is not measured: Freshness signal contradicted by repo activity.

CAI score 54out of 100 At risk Down 8 since the last survey

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

Domain Modelling 88 Strong Architecture 83 Strong Code Health 71 Strong Production Readiness 64 Adequate Performance 60 Adequate Security and Compliance 51 Adequate Maturity 49 Weak

A medium codebase: 24,588 lines of product code in 6 projects, tests not counted · Estimated rebuild effort: about 0.6 person-years · Weakest lens: Maturity, 49

Findings by how serious they are

84 critical 431 serious 99 minor

7 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
22 October 2026, 09:14 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that implements it, and today Watchdog is the only one that does.

A critical security finding is open, such as a library with a known critical vulnerability or a password or key found in the code. The score itself is unchanged, but its band shows At risk until the finding is fixed. See the Security and Compliance lens.

The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

88of 92 dimensions measured by tools. The other 4 are advisory notes from an AI model, which explain the code but don't count towards the score.
598of 614 findings point to an exact file and line, so you can open each one in the code. The other 16 concern the repository as a whole, such as missing documentation.
92dimensions across 7 lenses, read from 24,588 lines of product code in 6 projects.
Chapters

Executive summary

jpablodrexler/jp-photo-manager scores 54 out of 100, but it is rated At risk while a critical security finding is open; the score itself is unchanged.

The weakest lens counts most in the score, and here that is Maturity, which scores 49 and is rated Weak. Its Documentation accuracy dimension scores 0 out of 10, and until that reaches 4, Maturity can't be rated higher than Adequate. The first actions are to resolve the 1 No ADRs found finding(s) in ADR Quality and to reconcile the README with reality: JPPhotoManagerWeb/README.md runs `bash scripts/complexity-report.sh`, but `scripts/complexity-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/dead-code-report.sh`, but `scripts/dead-code-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/auth-coverage-report.sh`, but `scripts/auth-coverage-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/coverage-report.sh`, but `scripts/coverage-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/mutation-report.sh`, but `scripts/mutation-report.sh` does not exist, and if Maturity rose to 70, the score would rise from 54 to about 59.

84 findings are critical: 26 in Static Analysis (SAST), 25 in Dependency Vulnerabilities, 11 in IaC & Container Security, nine in Domain ↔ infrastructure boundary, five in Captive dependencies, five in Explicit Debt, two in Project dependency cycles and one in Secrets (history).

Watchdog couldn't measure 7 dimensions in this code, among them Code Coverage, Test Reliability and Dependency Hygiene, so they are left out of the score. The product code is 24,588 lines, which would take an estimated 0.6 person-years, around €91,000, to rebuild.

Code Health 71 Strong Architecture 83 Strong Maturity 49 Weak, capped by Documentation accuracy Production Readiness 64 Adequate, capped by Security & performance tooling Security and Compliance 51 Adequate, capped by Static Analysis (SAST), Dependency Vulnerabilities, IaC & Container Security and Supply-chain Provenance & Signing Domain Modelling 88 Strong Performance 60 Adequate

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Maturity 49 · counts for 46%Security and Compliance 51 · counts for 25%Performance 60 · counts for 14%Production Readiness 64 · counts for 8%Code Health 71 · counts for 4%Architecture 83 · counts for 2%Domain Modelling 88 · counts for 1%

If Maturity rose from 49 to 70, the lowest score rated Strong, the score would rise from 54 to about 59.

Code composition: what the lines of code are
Business logic 6%Supporting code 10%Tests 85%
New since the last survey: 58 findings

These 58 critical or serious findings weren't in the previous survey, on 8 October 2026.

Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 43 findings

These 43 critical or serious findings were in the previous survey, on 8 October 2026, and are gone from this one.

  • Dependency Vulnerabilities · Critical CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · Critical CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · Critical CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · Critical CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
  • Dependency Vulnerabilities · High CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] JPPhotoManagerWeb/backend/pom.xml
  • Dependency Vulnerabilities · Medium CVE: REDACTED REDACTED
  • Dependency Vulnerabilities · Medium CVE: [GHSA redacted] REDACTED
  • Supply-chain Provenance & Signing REDACTED
Rebuild cost: about €91,000 · Estimate
Cost to rebuild€30,000 to €150,000, for 503 to 1,601 hours of work, about 0.6 person-years for 1 to 2 engineers
Difficulty of the problemHigh, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.8 at a score of 54. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 24,588 lines of product code
Comment linesThe estimate prices 24,486 lines. Comment lines count towards the size of 24,588 lines but aren't priced as work.

How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Resolve the 1 No ADRs found finding(s) in ADR Quality.
Raises the score by about 4 points · Low effort · ADR Quality
2
Reconcile the README with reality: JPPhotoManagerWeb/README.md runs `bash scripts/complexity-report.sh`, but `scripts/complexity-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/dead-code-report.sh`, but `scripts/dead-code-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/auth-coverage-report.sh`, but `scripts/auth-coverage-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/coverage-report.sh`, but `scripts/coverage-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/mutation-report.sh`, but `scripts/mutation-report.sh` does not exist.
Raises the score by about 5 points · Medium effort · Documentation accuracy
3
Record your significant design decisions.
Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Raises the score by about 3 points · Medium effort · Architecture documentation

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €91,000 to build again, about 0.6 person-years of work. Its weakest lens is Maturity, at 49 (Weak). Maturity is about how well the project explains and looks after itself, which decides whether a new developer, or a new supplier, can take over. Because the weakest lens counts most in the score, work on Maturity also moves the score most.
Based on: the rebuild estimate · the Maturity grade · how much each lens counts
What to do: Start with the Maturity actions in Top priorities.
If you do one thing first · First action
Resolve the 1 No ADRs found finding(s) in ADR Quality. Of all the actions in this report, it raises the score most for the work it takes: about 4 points for low effort, because it clears the 1 ADR Quality findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways — a layering smell or cycle. A clean layered graph has none.

arch JPPhotoManager.Application Application JPPhotoManager.Domain Domain JPPhotoManager.Application->JPPhotoManager.Domain JPPhotoManager.Common Common JPPhotoManager.Infrastructure Infrastructure JPPhotoManager.Infrastructure->JPPhotoManager.Common JPPhotoManager.Infrastructure->JPPhotoManager.Domain JPPhotoManager.UI UI JPPhotoManager.UI->JPPhotoManager.Application JPPhotoManager.UI->JPPhotoManager.Domain JPPhotoManager.UI->JPPhotoManager.Infrastructure

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

158 modules, with 243 dependencies between them. 2 loops run through 5 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 118 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 JPPhotoManagerWeb.frontend.src.app.core.models.asset_model2 JPPhotoManagerWeb.frontend.src.app.core.models.dialog_model3 JPPhotoManagerWeb.frontend.src.app.core.models.paginated-data_model4 JPPhotoManagerWeb.frontend.src.app.core.services.auth_service5 com.jpablodrexler.photomanager.domain.enums6 JPPhotoManager.Domain.Interfaces.Services7 JPPhotoManagerWeb.frontend.src.app.app_component8 JPPhotoManagerWeb.frontend.src.app.core.models.album_model9 JPPhotoManagerWeb.frontend.src.app.core.services.asset_service10 com.jpablodrexler.photomanager.domain.model11 com.jpablodrexler.photomanager.infrastructure.persistence.entity12 JPPhotoManager.Domain.Entities13 JPPhotoManagerWeb.frontend.src.app.core.services.album_service14 com.jpablodrexler.photomanager.application.dto15 com.jpablodrexler.photomanager.domain.port.in.catalog16 com.jpablodrexler.photomanager.domain.port.in.folder17 com.jpablodrexler.photomanager.domain.port.out18 com.jpablodrexler.photomanager.infrastructure.persistence.mapper19 JPPhotoManager.Domain20 JPPhotoManagerWeb.frontend.src.app.features.gallery.gallery_component21 com.jpablodrexler.photomanager.application.usecase.asset22 com.jpablodrexler.photomanager.application.usecase.convert23 com.jpablodrexler.photomanager.application.usecase.sync24 com.jpablodrexler.photomanager.application.usecase.user25 com.jpablodrexler.photomanager.infrastructure.persistence.adapter26 com.jpablodrexler.photomanager.infrastructure.service27 com.jpablodrexler.photomanager.infrastructure.web.dto.response28 JPPhotoManager.Domain.Interfaces.Repositories29 JPPhotoManager.Infrastructure.Services30 com.jpablodrexler.photomanager.config31 com.jpablodrexler.photomanager.infrastructure.batch32 com.jpablodrexler.photomanager.infrastructure.kafka33 com.jpablodrexler.photomanager.infrastructure.web.mapper34 JPPhotoManager.Application35 JPPhotoManager.Domain.Services36 JPPhotoManager.Infrastructure.Repositories37 com.jpablodrexler.photomanager.infrastructure.web.controller38 JPPhotoManager.UI.ViewModels39 JPPhotoManager.UI.Windows40 JPPhotoManager.UI.Controls
1 JPPhotoManagerWeb.frontend.src.app.core.models.asset_model
2 JPPhotoManagerWeb.frontend.src.app.core.models.dialog_model
3 JPPhotoManagerWeb.frontend.src.app.core.models.paginated-data_model
4 JPPhotoManagerWeb.frontend.src.app.core.services.auth_service
5 com.jpablodrexler.photomanager.domain.enums
6 JPPhotoManager.Domain.Interfaces.Services910
7 JPPhotoManagerWeb.frontend.src.app.app_component1
8 JPPhotoManagerWeb.frontend.src.app.core.models.album_model11
9 JPPhotoManagerWeb.frontend.src.app.core.services.asset_service61
10 com.jpablodrexler.photomanager.domain.model7
11 com.jpablodrexler.photomanager.infrastructure.persistence.entity3
12 JPPhotoManager.Domain.Entities1
13 JPPhotoManagerWeb.frontend.src.app.core.services.album_service4
14 com.jpablodrexler.photomanager.application.dto11
15 com.jpablodrexler.photomanager.domain.port.in.catalog1
16 com.jpablodrexler.photomanager.domain.port.in.folder2
17 com.jpablodrexler.photomanager.domain.port.out229
18 com.jpablodrexler.photomanager.infrastructure.persistence.mapper1416
19 JPPhotoManager.Domain3
20 JPPhotoManagerWeb.frontend.src.app.features.gallery.gallery_component211
21 com.jpablodrexler.photomanager.application.usecase.asset1632
22 com.jpablodrexler.photomanager.application.usecase.convert314
23 com.jpablodrexler.photomanager.application.usecase.sync314
24 com.jpablodrexler.photomanager.application.usecase.user35
25 com.jpablodrexler.photomanager.infrastructure.persistence.adapter22711516
26 com.jpablodrexler.photomanager.infrastructure.service17125
27 com.jpablodrexler.photomanager.infrastructure.web.dto.response23
28 JPPhotoManager.Domain.Interfaces.Repositories51
29 JPPhotoManager.Infrastructure.Services733
30 com.jpablodrexler.photomanager.config141
31 com.jpablodrexler.photomanager.infrastructure.batch51172
32 com.jpablodrexler.photomanager.infrastructure.kafka1161101
33 com.jpablodrexler.photomanager.infrastructure.web.mapper23220
34 JPPhotoManager.Application108175
35 JPPhotoManager.Domain.Services257710
36 JPPhotoManager.Infrastructure.Repositories2515
37 com.jpablodrexler.photomanager.infrastructure.web.controller1132531815
38 JPPhotoManager.UI.ViewModels12109
39 JPPhotoManager.UI.Windows31154
40 JPPhotoManager.UI.Controls21152
Uses a module listed above itPart of a loopThe module itself
1 JPPhotoManagerWeb.frontend.src.app.core.models.asset_model2 JPPhotoManagerWeb.frontend.src.app.core.models.dialog_model3 JPPhotoManagerWeb.frontend.src.app.core.models.paginated-data_model4 JPPhotoManagerWeb.frontend.src.app.core.services.auth_service5 com.jpablodrexler.photomanager.domain.enums6 JPPhotoManager.Domain.Interfaces.Services7 JPPhotoManagerWeb.frontend.src.app.app_component8 JPPhotoManagerWeb.frontend.src.app.core.models.album_model9 JPPhotoManagerWeb.frontend.src.app.core.services.asset_service10 com.jpablodrexler.photomanager.domain.model11 com.jpablodrexler.photomanager.infrastructure.persistence.entity12 JPPhotoManager.Domain.Entities13 JPPhotoManagerWeb.frontend.src.app.core.services.album_service14 com.jpablodrexler.photomanager.application.dto15 com.jpablodrexler.photomanager.domain.port.in.catalog16 com.jpablodrexler.photomanager.domain.port.in.folder17 com.jpablodrexler.photomanager.domain.port.out18 com.jpablodrexler.photomanager.infrastructure.persistence.mapper19 JPPhotoManager.Domain20 JPPhotoManagerWeb.frontend.src.app.features.gallery.gallery_component21 com.jpablodrexler.photomanager.application.usecase.asset22 com.jpablodrexler.photomanager.application.usecase.convert23 com.jpablodrexler.photomanager.application.usecase.sync24 com.jpablodrexler.photomanager.application.usecase.user25 com.jpablodrexler.photomanager.infrastructure.persistence.adapter26 com.jpablodrexler.photomanager.infrastructure.service27 com.jpablodrexler.photomanager.infrastructure.web.dto.response28 JPPhotoManager.Domain.Interfaces.Repositories29 JPPhotoManager.Infrastructure.Services30 com.jpablodrexler.photomanager.config31 com.jpablodrexler.photomanager.infrastructure.batch32 com.jpablodrexler.photomanager.infrastructure.kafka33 com.jpablodrexler.photomanager.infrastructure.web.mapper34 JPPhotoManager.Application35 JPPhotoManager.Domain.Services36 JPPhotoManager.Infrastructure.Repositories37 com.jpablodrexler.photomanager.infrastructure.web.controller38 JPPhotoManager.UI.ViewModels39 JPPhotoManager.UI.Windows40 JPPhotoManager.UI.ControlsJPPhotoManagerWeb.frontend.src.app.core.models.asset_model1JPPhotoManagerWeb.frontend.src.app.core.models.dialog_model2JPPhotoManagerWeb.frontend.src.app.core.models.paginated-data_model3JPPhotoManagerWeb.frontend.src.app.core.services.auth_service4com.jpablodrexler.photomanager.domain.enums5JPPhotoManager.Domain.Interfaces.Services6JPPhotoManagerWeb.frontend.src.app.app_component7JPPhotoManagerWeb.frontend.src.app.core.models.album_model8JPPhotoManagerWeb.frontend.src.app.core.services.asset_service9com.jpablodrexler.photomanager.domain.model10com.jpablodrexler.photomanager.infrastructure.persistence.entity11JPPhotoManager.Domain.Entities12JPPhotoManagerWeb.frontend.src.app.core.services.album_service13com.jpablodrexler.photomanager.application.dto14com.jpablodrexler.photomanager.domain.port.in.catalog15com.jpablodrexler.photomanager.domain.port.in.folder16com.jpablodrexler.photomanager.domain.port.out17com.jpablodrexler.photomanager.infrastructure.persistence.mapper18JPPhotoManager.Domain19JPPhotoManagerWeb.frontend.src.app.features.gallery.gallery_component20com.jpablodrexler.photomanager.application.usecase.asset21com.jpablodrexler.photomanager.application.usecase.convert22com.jpablodrexler.photomanager.application.usecase.sync23com.jpablodrexler.photomanager.application.usecase.user24com.jpablodrexler.photomanager.infrastructure.persistence.adapter25com.jpablodrexler.photomanager.infrastructure.service26com.jpablodrexler.photomanager.infrastructure.web.dto.response27JPPhotoManager.Domain.Interfaces.Repositories28JPPhotoManager.Infrastructure.Services29com.jpablodrexler.photomanager.config30com.jpablodrexler.photomanager.infrastructure.batch31com.jpablodrexler.photomanager.infrastructure.kafka32com.jpablodrexler.photomanager.infrastructure.web.mapper33JPPhotoManager.Application34JPPhotoManager.Domain.Services35JPPhotoManager.Infrastructure.Repositories36com.jpablodrexler.photomanager.infrastructure.web.controller37JPPhotoManager.UI.ViewModels38JPPhotoManager.UI.Windows39JPPhotoManager.UI.Controls40910111617314111222914163211163231431435227115161712523517331415117211611012322010817525771025151132531815121093115421152+118 more modules (most-connected shown)

At a glance — Code Health · 71% · Strong ·

The Good
D1 · .NET / C# Cyclomatic Complexity 8.8 D2 · .NET / C# Cognitive Complexity 8.4 D3 · .NET / C# God Classes 9.2 D4 · .NET / C# Code Duplication 9.1 GD1 · Repo Unfinished & placeholder code 9.8 IC1 · Repo Incompleteness & stubs 10.0 R1 · React / TS Type Safety 9.0 R10 · React / TS Code Duplication 7.6 R2 · React / TS Cyclomatic Complexity 9.9 R3 · React / TS Large Files 9.6 R7 · React / TS Dead Code 9.8 X1 · Repo Async correctness 10.0 X12 · Repo Unreachable branch 10.0 X13 · Repo Undrained process stream 10.0 X16 · Repo Unfloored truncation loop 10.0 X18 · Repo Disposal-pattern correctness 10.0 X19 · Repo Unrestored process-global state 10.0 X21 · Repo Side-effecting pattern guard 10.0 X22 · Repo Contradicted release guard 10.0 X23 · Repo Unguarded diagnostic materialisation 10.0 X25 · Repo Inert configuration knob 10.0 X26 · Repo Unsynchronised callback handoff 10.0 X27 · Repo Collection changed while being enumerated 10.0 X28 · Repo Index access outside its own emptiness guard 10.0 X29 · Repo Per-element action decided by a fixed element 10.0 X3 · Repo Exception handling 10.0 X30 · Repo Support guard that admits what it rejects 10.0 X32 · Repo Type resolved by simple name across every loaded assembly 10.0 X4 · Repo Structured logging 10.0 X5 · Repo Nullable reference types 8.4
The Bad
D17 · .NET / C# Explicit Debt 6.7
The Ugly
X2 · Repo Cancellation propagation 4.0 X20 · Repo Mistyped argument guard 4.8

At a glance — Architecture · 83% · Strong ·

The Good
D5 · .NET / C# Coupling 10.0 D6 · .NET / C# Cohesion (LCOM4) 9.6 D26 · .NET / C# Project Cohesion 10.0 D35 · .NET / C# Change Coupling 10.0 AX1 · Repo Captive dependencies 7.1 AX10 · Repo Code composition 8.3 AX2 · Repo Stateful singletons 7.1 AX3 · Repo Project dependency cycles 10.0 AX4 · Repo Dependency direction 10.0 AX5 · Repo Architecture & structure 10.0 AX6 · Repo Interface segregation 9.9 AX8 · Repo Test isolation 10.0 R9 · React / TS Circular Imports 10.0

At a glance — Maturity · 49% · Weak · gated by M4 ·

The Good
D15 · .NET / C# Churn × Complexity Hotspots 10.0 D19 · .NET / C# Documentation Quality 9.0 D21 · .NET / C# Naming Consistency 10.0 D24 · .NET / C# Comment Value 9.0 M1 · Repo Documentation (README) 8.3 M3 · Repo Folder & project structure 8.0
The Bad
M2 · Repo Architecture documentation 5.0
The Ugly
D20 · .NET / C# ADR Quality 0.0 M4 · Repo Documentation accuracy 0.0

At a glance — Readiness · 64% · Adequate · gated by P3 ·

The Good
D10 · .NET / C# Test Quality 10.0 D13 · .NET / C# Secret Scanning 10.0 D14 · .NET / C# License Compliance 10.0 P1 · Repo CI/CD gates 10.0 P2 · Repo Observability 10.0 P4 · Repo Deployment & Rollback 8.0 P5 · Repo DR & Backup 7.0 P6 · Repo Release Hygiene 8.0 P8 · Repo Schema migrations 10.0 R4 · React / TS Test Coverage 7.3 R6 · React / TS Tooling 10.0 R8 · React / TS Dependency Hygiene 10.0
The Bad
D9 · .NET / C# Test Distribution 5.4 R5 · React / TS Dependency Freshness 6.2
The Ugly
P3 · Repo Security & performance tooling 3.0

At a glance — Security · 51% · Adequate · gated by D29, D30, D31, D36 ·

The Good
D28 · .NET / C# Secrets (history) 9.0 D43 · .NET / C# Malicious Dependencies 10.0 D44 · .NET / C# Platform End-of-Life 10.0 X14 · Repo Bypassable address classification 10.0 X15 · Repo Unvalidated length from an untrusted reader 10.0 X17 · Repo Uncapped recursion over a caller-supplied document 10.0 X24 · Repo Document value interpolated into markup unescaped 10.0
The Bad
D40 · .NET / C# Network Egress Confinement 6.0 D41 · .NET / C# Kernel & Syscall Confinement 6.0
The Ugly
D29 · .NET / C# Static Analysis (SAST) 3.4 D30 · .NET / C# Dependency Vulnerabilities 0.0 D31 · .NET / C# IaC & Container Security 0.0 D36 · .NET / C# Supply-chain Provenance & Signing 0.0

At a glance — Domain Modelling · 88% · Strong ·

The Good
DM10 · Repo One transaction, one aggregate 9.6 DM11 · Repo Constructible invalid state 9.5 DM12 · Repo Ambient inputs in the domain 10.0 DM5 · Repo Encapsulated state 10.0 DM7 · Repo Repository granularity 10.0 DM8 · Repo Value-object opportunities 10.0 DM9 · Repo Scattered domain decisions 10.0
The Bad
DM6 · Repo Domain ↔ infrastructure boundary 6.8

At a glance — Performance · 60% · Adequate ·

The Bad
PF3 · Repo Async & latency hygiene 6.0

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A02:2025 — Security Misconfiguration244High / Critical
A03:2025 — Software Supply Chain Failures42High / Critical
A05:2025 — Injection37High / Critical
A07:2025 — Authentication Failures2High / Critical

Roadmap

First, reconcile the README to accurately reflect existing scripts and remove references to missing files. Next, address the 191 medium-severity IaC findings in backend, frontend, and grafana configurations, while simultaneously resolving the lack of Architecture Decision Records by documenting key design choices. Finally, improve latency hygiene by replacing synchronous APIs with their asynchronous counterparts in TypeScript and JavaScript code.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 1 No ADRs found finding(s) in ADR Quality.+4.5 ptsLowADR Quality
Reconcile the README with reality: JPPhotoManagerWeb/README.md runs `bash scripts/complexity-report.sh`, but `scripts/complexity-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/dead-code-report.sh`, but `scripts/dead-code-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/auth-coverage-report.sh`, but `scripts/auth-coverage-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/coverage-report.sh`, but `scripts/coverage-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/mutation-report.sh`, but `scripts/mutation-report.sh` does not exist.+4.5 ptsMediumDocumentation accuracy
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.+3.1 ptsMediumArchitecture documentation
Resolve the 4 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED.+1.3 ptsLowSupply-chain Provenance & Signing
Resolve the 1 No network policy finding(s) in Network Egress Confinement.+1.2 ptsLowNetwork Egress Confinement
Resolve the 8 No seccomp profile finding(s) in Kernel & Syscall Confinement — start with REDACTED, REDACTED, REDACTED.+1.2 ptsLowKernel & Syscall Confinement
TypeScript/JavaScript: use the promise APIs (fs/promises, a promisified child_process.execFile, the async zlib/crypto functions) and await them instead of the *Sync variants.+1.8 ptsMediumAsync & latency hygiene
Resolve the 5 WriteOnlyPrivateField finding(s) in Explicit Debt — start with ConvertAssetsService.cs (2), CatalogAssetsService.cs, SyncAssetsService.cs.+0.7 ptsLowExplicit Debt

File quality

Per-file score 0–10 — a quality signature. Of 72 files carrying findings, judged against the Production bar: 24% slop · 32% mixed · 44% near-clean.

FileScoreBandWorst signal
REDACTED0.2SlopSecrets (history): High secret: REDACTED
REDACTED0.9SlopStatic Analysis (SAST): High: REDACTED
REDACTED1.6SlopIaC & Container Security: High IaC: REDACTED
REDACTED1.6SlopIaC & Container Security: High IaC: REDACTED
REDACTED1.6SlopIaC & Container Security: High IaC: REDACTED
REDACTED1.6SlopIaC & Container Security: High IaC: REDACTED
REDACTED1.6SlopIaC & Container Security: High IaC: REDACTED
REDACTED1.6SlopIaC & Container Security: High IaC: REDACTED
REDACTED1.6SlopIaC & Container Security: High IaC: REDACTED
REDACTED1.6SlopIaC & Container Security: High IaC: REDACTED
REDACTED1.9SlopIaC & Container Security: High IaC: REDACTED
REDACTED2.3SlopStatic Analysis (SAST): High: REDACTED
JPPhotoManager/JPPhotoManager.Domain/Services/ConvertAssetsService.cs2.4SlopExplicit Debt: WriteOnlyPrivateField
REDACTED2.5SlopStatic Analysis (SAST): High: REDACTED
REDACTED3.4SlopIaC & Container Security: High IaC: REDACTED
JPPhotoManager/JPPhotoManager.Domain/Services/CatalogAssetsService.cs3.4SlopExplicit Debt: WriteOnlyPrivateField
REDACTED3.7SlopStatic Analysis (SAST): High: REDACTED
JPPhotoManager/JPPhotoManager.Domain/Services/SyncAssetsService.cs4.3MixedExplicit Debt: WriteOnlyPrivateField
JPPhotoManager/JPPhotoManager.UI/ViewModels/FindDuplicatedAssetsViewModel.cs4.9MixedExplicit Debt: WriteOnlyPrivateField
JPPhotoManager/JPPhotoManager.Domain/Services/MoveAssetsService.cs6.0MixedExplicit Debt: TodoComment

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 84

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 431

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 99

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 7

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 88 of 92 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 4 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.8 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 92 dimensions across the health lenses
D1D2D3D4D5D6D9D10D13D14D15D17D19D20D21D24D26D28D29D30D31D35D36D40D41D43D44AX1AX10AX2AX3AX4AX5AX6AX8DM10DM11DM12DM5DM6DM7DM8DM9GD1IC1M1M2M3M4P1P2P3P4P5P6P8PF3R1R10R2R3R4R5R6R7R8R9X1X12X13X14X15X16X17X18X19X2X20X21X22X23X24X25X26X27X28X29X3X30X32X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 598 of 614 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Watchdog duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivy · checkovSecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3 · 3.2.533✓ deterministic
LLM (sampled · advisory)Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurementLocal LLM◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 01a162e3-ffde-7529-87f4-c709de2497dd.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: the .NET half could not be measured — no coverage produced (collector absent, or test run exceeded the inline budget); the JavaScript/TypeScript half could not be measured — the JavaScript/TypeScript suite(s) run through a browser-driven runner the coverage collector does not drive — JPPhotoManagerWeb/frontend/ (cypress) — a gap in the analyzer, not something this repository is missing. This repository's production source spans both ecosystems, and no partial figure is published as if it were the whole: coverage is excluded from the score rather than counted as a near-zero. This is OUR limitation, not a defect in the repo. In the meantime, commit (or publish into the working tree) the lcov/Cobertura report your CI produces and the real number is read on the next scan. You can widen what we reach: optional: commit the lcov/Cobertura report your CI produces, and the real number is read on the next scan.
  • D10 Test Quality — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 175 test(s) behind this row are the ones the C# collector could read, and this repository also carries at least 247 test source file(s) (.java, .ts) that it cannot: it parses C# syntax and matches C# test attributes, so a vitest/jest/JUnit/pytest-style suite is invisible to it. Skipped tests, zero-assertion tests and the other quality signals on this row are UNMEASURED in that suite — their absence from the counts above is a gap in this analyzer's language coverage, not a finding that those tests are sound.
  • D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability NOT MEASURED: this repository's test suite spans .NET and JavaScript/TypeScript, and the JavaScript/TypeScript half could not be re-run — unit: measured (0 flaky); JavaScript/TypeScript (cypress component specs (e2e specs need the repository's own dev server and were not re-run; run in the analyzer image's Cypress, not the declared version) via `npm ci --ignore-scripts` in JPPhotoManagerWeb/frontend/): not included — the cypress run in JPPhotoManagerWeb/frontend/ produced no per-test report (TSError: ⨯ Unable to compile TypeScript:). No partial figure is published as if it were the whole: reliability is excluded from the score rather than counted as a near-zero.
  • D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability for the cypress suite in JPPhotoManagerWeb/frontend/ was NOT MEASURED: the cypress run in JPPhotoManagerWeb/frontend/ produced no per-test report (TSError: ⨯ Unable to compile TypeScript:). This is OUR limitation, not a defect in the repository, and the suite is excluded from the measurement rather than counted against it.
  • D12 Dependency Hygiene — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `dotnet list package` did not return usable output (restore or query failed); no outdated/vulnerable/deprecated data to assess. The tool said: `dotnet list package` exited 1 with no output.
  • D17 Explicit Debt — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 34 deducted marker(s) and the 1.6/KLoC density on this row were taken over this repository's .NET projects ALONE: .java (11,953 lines, 53% of production source), .ts (4,699 lines, 21% of production source) went unread, because every marker collector on this path is reached through a C# workspace. D17's marker collectors need a compiler we do not have for that language, so none of its nine marker kinds were read there. The debt in that source is UNMEASURED — its absence from the score above is a gap in this analyzer's language coverage, not a finding that the code carries none.
  • D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The loaded project set declares no packable project and no `.Contracts` project, so there is no intentionally-exposed surface for API consistency to be judged over.
  • D23 Boundary Type-Coupling — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Large codebase (22,593 production LoC in the .NET projects) with no declared bounded contexts — cross-boundary type coupling is unassessed Bounded contexts cannot be inferred from a codebase that is not physically organised by them (D-321), so with none declared there are no boundaries for the coupling pass to measure across. You can widen what we reach: name this codebase's bounded contexts (≥2 module groups, e.g. per subsystem) so cross-boundary type coupling can be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D27 Navigability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Navigability is taken over call sites whose callee resolved. For C# that population includes calls into referenced assemblies; for this language only calls declared inside the repository count, so the abstention threshold reads the repository's use of its standard library as a resolution failure. That is a limit of this analyzer, not a build problem in this repository.
  • D28 Secrets (history) — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. D28's config-credential rule (WD-SECRET-0002) parses each committed `.json` config as a document and reads credential-named values; `JPPhotoManager/JPPhotoManager.UI/appsettings.json` did not parse (JSON5, a template, several concatenated documents), so a credential bound there is UNMEASURED by that rule. gitleaks still scanned the same files as text.
  • D30 Dependency Vulnerabilities — measured, with a gap in what it reached — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan. 2 of 3 declared ecosystem(s) (npm,osv) WERE scanned and every vulnerability they reported is included in this result; nuget was not, so this dimension's score covers less than the dependency surface this repository declares, and nothing here is evidence that nuget is free of known-vulnerable dependencies.
  • D34 Knowledge Freshness — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. File-level freshness contradicts repo activity: 31 commits in the last 90 days, yet 26 of 26 significant files carry no living knowledge. Those two readings cannot both be true, so the per-file recency signal is treated as unreliable here and freshness is not scored for this run.
  • D39 IL Efficiency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. IL NOT MEASURED: the analyzer's own build of this repository failed for an ENVIRONMENT reason (exit 1) — MSBuild's engine or the CLR gave up, or our image does not carry the SDK band/targeting pack this repository needs. This is OUR limitation, not a defect in the repo, and it is not a statement that this repository fails to build. D18 owns the question of whether this repository builds; it was not answered here.
  • AXR1 Runtime accessibility — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Render strategy: boot via DockerCompose (REDACTED). compose up failed (exit 15 — the compose project is invalid) — error while interpolating services.backend.environment.JWT_SECRET: required variable JWT_SECRET is missing a value: Set JWT_SECRET in .env - run: openssl rand -base64 32; runtime evidence skipped.
  • ED5 Idempotency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check decides whether a handler's mutation is safe to re-run by recognising its persistence writes (a database save, a repository write, an event publish) and its guards. Those markers are .NET member names, so in this repository's language a write such as `repository.save(order)` is not recognised and a same-named call on an unrelated library type could be. The handlers were found; their idempotency was neither confirmed nor ruled out.
  • M3 Folder & project structure — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Whether the tests sit apart from production code is not visible here, because the suite is not in a form this pass reads. The test-separation credit is granted rather than withheld: this is a gap in the analyzer's language coverage, not a finding about the repository's tests. You can widen what we reach: keep the test surface somewhere a reader can find it without opening a binary — an exported/checked-in test source tree beside the production code makes the suite reviewable, diffable and discoverable by tooling.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
  • D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
  • D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
  • D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
  • D24 Comment Value: Comment value (WHY vs WHAT) is an LLM judgement over a bounded sample — it is advisory and cannot weigh a comment against the precise code change it was written to explain.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D40 Network Egress Confinement: Egress confinement is read from committed Kubernetes manifests — a policy applied out-of-band (cluster-default deny, a service mesh, or a cloud firewall/security group off-repo) is invisible, and a present NetworkPolicy is declared config, not proof the cluster admission-controller actually enforces it at runtime.
  • D41 Kernel & Syscall Confinement: Syscall/MAC confinement is read from committed manifests — a profile applied by a cluster-wide PodSecurity default or a mutating webhook off-repo isn't seen, and a declared seccomp/AppArmor profile is config presence, not proof the node's kernel actually loaded and enforced it.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a REDACTED (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • DM6 Domain ↔ infrastructure boundary: Infrastructure reached through a hand-rolled wrapper, a domain-named facade, reflection, or a string-keyed service locator resolves to a non-infra type and isn't seen; the body scan is symbol resolution over syntax, not full dataflow. A clean result means "no resolved infra reference in a domain body", not a proof of purity.
  • M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

The LLM boundary

LLM-set scores this run (4): D19, D21, D24, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.

Dimensions

D1 · Cyclomatic Complexity8.8 / 10Strong✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.8 / 10 · rule-coverage 100% · ceiling Prevented

5 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was StorageServiceAdapter.getExifMetadata at 32. A further 2 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being Asset.IdentifySupportedTags at 35 — they are counted neither in the figure above nor in this dimension's score. 2 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: JPPhotoManager/JPPhotoManager.Domain/Entities/Asset.cs (Asset.IdentifySupportedTags at 35), JPPhotoManagerWeb/frontend/scripts/cyclomatic-complexity.js (cyclomatic-complexity.computeComplexity::visit at 16). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

StorageServiceAdapter.getExifMetadata (cyclomatic 32)JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/StorageServiceAdapter.java:305
SocialMediaCropComponent.getHitArea (cyclomatic 21)JPPhotoManagerWeb/frontend/src/app/features/gallery/social-media-crop/social-media-crop.component.ts:234
MoveAssetsService.MoveAssets (cyclomatic 17)JPPhotoManager/JPPhotoManager.Domain/Services/MoveAssetsService.cs:28
a11y-report.main (cyclomatic 17)JPPhotoManagerWeb/frontend/scripts/a11y-report.js:83
MainWindow.Window_KeyDown (cyclomatic 16)JPPhotoManager/JPPhotoManager.UI/Windows/MainWindow.xaml.cs:78

What to do

  1. Bring the 5 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with StorageServiceAdapter.getExifMetadata (cyclomatic 32), SocialMediaCropComponent.getHitArea (cyclomatic 21), MoveAssetsService.MoveAssets (cyclomatic 17). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 5 together lifts Cyclomatic Complexity from 8.8 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
  2. Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity8.4 / 10Strong✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.4 / 10 · rule-coverage 100% · ceiling Prevented

9 method(s) exceeded the cognitive complexity threshold of 15; the worst was a11y-report.main at 34.

a11y-report.main (cognitive 34)JPPhotoManagerWeb/frontend/scripts/a11y-report.js:83
AssetRepository.GetAssets (cognitive 32)JPPhotoManager/JPPhotoManager.Infrastructure/Repositories/AssetRepository.cs:102
StorageServiceAdapter.getExifMetadata (cognitive 32)JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/StorageServiceAdapter.java:305
SyncAssetsService.Execute (cognitive 29)JPPhotoManager/JPPhotoManager.Domain/Services/SyncAssetsService.cs:47
ConvertAssetsService.Execute (cognitive 27)JPPhotoManager/JPPhotoManager.Domain/Services/ConvertAssetsService.cs:51

+ 4 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 9 bodies over 15 down to 15 or less in Cognitive Complexity — start with a11y-report.main (cognitive 34), AssetRepository.GetAssets (cognitive 32), StorageServiceAdapter.getExifMetadata (cognitive 32). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 9 together lifts Cognitive Complexity from 8.4 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
  2. Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes9.2 / 10Stronggated by 6 serious findings✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.2 / 10 · rule-coverage 100% · ceiling Prevented

6 god class(es) detected.

TooManyMethods: GalleryComponent · ×4JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:61
ClassTooLong: GalleryComponentJPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:61
FileTooLong: gallery/gallery.component.tsJPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts

What to do

  1. Resolve the 4 TooManyMethods finding(s) in God Classes — start with gallery.component.ts, AssetRepositoryImpl.java, MainWindow.xaml.cs. — One of this dimension's main actionable groups (4 warning-level).
  2. Resolve the 1 ClassTooLong finding(s) in God Classes — start with gallery.component.ts. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 FileTooLong finding(s) in God Classes — start with gallery.component.ts. — One of this dimension's main actionable groups (1 warning-level).
  4. Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication9.1 / 10Stronggated by 44 serious findings✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.1 / 10 · rule-coverage 100% · ceiling Verified

42 duplicated block group(s) detected. A further 2 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted. Measured on part of this repository only: .ts (21% of production source) was not exposed to THIS dimension's token comparison and is not in this count; duplication there is measured by R10 Code Duplication, the frontend lens's card running the same clone algorithm over the JS/TS token stream.

Duplicated block (9 lines × 2) · ×8JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/album/GetAlbumSummaryUseCaseImpl.java:26
Duplicated block (7 lines × 2) · ×6JPPhotoManager/JPPhotoManager.Domain/Services/CatalogAssetsService.cs:354
Duplicated block (5 lines × 2) · ×5JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/AuthController.java:84
Duplicated block (11 lines × 2) · ×4JPPhotoManager/JPPhotoManager.Domain/Entities/ConvertAssetsDirectoriesDefinition.cs:8
Duplicated block (10 lines × 2) · ×2JPPhotoManager/JPPhotoManager.Domain/Entities/ConvertAssetsDirectoriesDefinition.cs:40

+ 17 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 8 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with ConvertAssetsWindow.xaml.cs (3), GetAlbumSummaryUseCaseImpl.java, ConvertAssetsUseCaseImpl.java. — One of this dimension's main actionable groups (8 warning-level).
  2. Resolve the 6 Duplicated block (7 lines × 2) finding(s) in Code Duplication — start with CatalogAssetsService.cs, BulkAddTagUseCaseImpl.java, CatalogAssetItemProcessor.java. — One of this dimension's main actionable groups (6 warning-level).
  3. Resolve the 5 Duplicated block (5 lines × 2) finding(s) in Code Duplication — start with AuthController.java, ConvertAssetsConfiguration.cs, RevokeSessionUseCaseImpl.java. — One of this dimension's main actionable groups (5 warning-level).
  4. Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

6 projects, 0 dependency cycle(s), 0 unstable depended-on project(s).

Off the main sequence: JPPhotoManager.CommonJPPhotoManager/JPPhotoManager.Common/JPPhotoManager.Common.csproj:1

✓ On the Gold path — maintain.

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)9.6 / 10Stronggated by 3 serious findings✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.6 / 10 · rule-coverage 100% · ceiling Verified

3 of 82 classes have LCOM4 above 3.

Low cohesion: StorageServiceAdapter (LCOM4 11) · ×3JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/StorageServiceAdapter.java:46

What to do

  1. Resolve the 3 Low cohesion finding(s) in Cohesion (LCOM4) — start with StorageServiceAdapter.java, AppConfig.java, AssetController.java. — One of this dimension's main actionable groups (3 warning-level).
  2. Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D9 · Test Distribution5.4 / 10Adequate✓ Tool-verified

What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.

Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.4 / 10 · rule-coverage 100% · ceiling Documented

1969 test methods: 1268 unit, 0 integration, 0 BDD, 701 e2e. The JavaScript/TypeScript suite contributes 701 `it`/`test` case(s) across 68 test file(s) declaring at least one beside 175 .NET test method(s); its tier split is read from package names and paths only. The java suite(s) contribute 1093 test method(s), read from the language model's own test census — every XCTest `test…` method on an XCTestCase, every swift-testing `@Test` and every JUnit/TestNG `@Test`-annotated method, which is those frameworks' own discovery rule. Their tier split is INFERRED from the test target's name and path only, not declared.

What to do

  1. Improve Test Distribution — currently 5.4/10. — 1969 test methods: 1268 unit, 0 integration, 0 BDD, 701 e2e. The JavaScript/TypeScript suite contributes 701 `it`/`test` case(s) across 68 test file(s) declaring at least one beside 175 .NET test method(s); its tier split is read from package names and paths only. The java suite(s) contribute 1093 test method(s), read from the language model's own test census — every XCTest `test…` method on an XCTestCase, every swift-testing `@Test` and every JUnit/TestNG `@Test`-annotated method, which is those frameworks' own discovery rule. Their tier split is INFERRED from the test target's name and path only, not declared.

Detailed fixes: d9_recommendation.md.

D10 · Test Quality10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the tests truly assert behaviour rather than just running the code.

Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

1 skipped (1 with a documented reason), 0 zero-assertion, no mocking-framework packages referenced (hand-written doubles or no mocking) across 175 tests. Measured on the C# suite only — at least 247 test source file(s) (.java, .ts) went unread, so its test quality is unmeasured and is not in these counts.

Skipped (documented): GetLatestRelease_ReturnReleaseDataJPPhotoManager/JPPhotoManager.Tests/Integration/ReleaseAvailabilityServiceTests.cs:35

✓ On the Gold path — maintain.

Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 213 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 17 direct `PackageReference`(s), and 191 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots10.0 / 10Stronggated by 4 serious findings✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/StorageServiceAdapter.java (8×32=256) Repeated repair below the complexity floor: JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/MoveAssetsUseCaseImpl.java (3 of 5 changes were fixes); JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/recycle/PurgeAssetsUseCaseImpl.java (3 of 4 changes were fixes); JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/RenameAssetsUseCaseImpl.java (3 of 3 changes were fixes)

Repeated repair: JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/MoveAssetsUseCaseImpl.java · ×3JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/MoveAssetsUseCaseImpl.java:45
Hotspot: JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/StorageServiceAdapter.javaJPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/StorageServiceAdapter.java:305

What to do

  1. Resolve the 3 Repeated repair finding(s) in Churn × Complexity Hotspots — start with MoveAssetsUseCaseImpl.java, PurgeAssetsUseCaseImpl.java, RenameAssetsUseCaseImpl.java. — One of this dimension's main actionable groups (3 warning-level).
  2. Resolve the 1 Hotspot finding(s) in Churn × Complexity Hotspots — start with StorageServiceAdapter.java. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt6.7 / 10Adequate✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 6.7 / 10 · rule-coverage 100% · ceiling Prevented

34 deducted debt markers + 4 dead symbols across 5855 LoC in the .NET projects (1.6/KLoC) → score 6.7. Measured on the .NET source only: .java, .ts (74% of production source) was not read, and carries at least 0 uncounted task marker(s) in 0 file(s).

WriteOnlyPrivateField · ×5JPPhotoManager/JPPhotoManager.Domain/Services/CatalogAssetsService.cs:22
TodoComment · ×19JPPhotoManager/JPPhotoManager.Common/BitmapHelper.cs:47
CoverageExclusion · ×10JPPhotoManager/JPPhotoManager.UI/App.xaml.cs:24
Dead code: HasSameContent · ×4JPPhotoManager/JPPhotoManager.Domain/Interfaces/Services/IStorageService.cs:25

What to do

  1. Resolve the 5 WriteOnlyPrivateField finding(s) in Explicit Debt — start with ConvertAssetsService.cs (2), CatalogAssetsService.cs, SyncAssetsService.cs. — One of this dimension's main actionable groups (5 issue-level).
  2. Resolve the 19 TodoComment finding(s) in Explicit Debt — start with FolderNavigationControl.xaml.cs (4), MoveAssetsService.cs (3), CatalogAssetsService.cs (2). — One of this dimension's main actionable groups (19 warning-level).
  3. Resolve the 10 CoverageExclusion finding(s) in Explicit Debt — start with App.xaml.cs, FolderNavigationControl.xaml.cs, ThumbnailsUserControl.xaml.cs. — One of this dimension's main actionable groups (10 warning-level).
  4. Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation QualityExemplary◐ Sampled · advisory

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Documented

The repository's documentation is comprehensive: the READMEs for each tier are well written with usage examples, the architecture/Docs markdown files cover design decisions in depth, and XML-doc coverage across [JPPhotoManager.Domain](https://github.com/JPPhotoManagerWeb/docs/blob/main/XML-doc-coverage.md) is 1/155 (0.6%). The curl reference, Docker Compose setup, frontend technologies table, Kubernetes manifests, and backlog documents all serve their purpose without gaps in the outline. This is a top-quality architecture-design documentation set: the hexagonal-architecture spec documents exactly what it promises with structural invariants (domain/purity INV-1 through port/out/INV-10), goals/non-goals, and a detailed migration plan for each phase; there are no gaps in the outline shown by the clip. The visible content is exemplary of its scope — an architecture specification — and the absence of any clipped section means none of the outlined sections are omitted. (14 of 25 sampled documents could not be assessed: 1 of 3 evaluation groups failed.)

XML-doc coverage: JPPhotoManager.Domain · ×5JPPhotoManager/JPPhotoManager.Domain/JPPhotoManager.Domain.csproj

✓ On the Gold path — maintain.

Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Per-ADR judgment by language model at low temperature with two-pass stability; confidence is share of ADRs evaluated; enforcement-field presence detected deterministically. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs found

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming ConsistencyExemplary◐ Sampled · advisory

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Verified

0 naming inconsistencies across 200 sampled symbols.

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md.

D24 · Comment ValueExemplary◐ Sampled · advisory

What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).

Method: Judged by language model at low temperature (0.0-0.1) on deterministically sampled inline comments with surrounding code; findings verified back to sampled comments by substring match. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Documented

26 valuable / 0 redundant across 58 sampled comments.

✓ On the Gold path — maintain.

Detailed fixes: d24_recommendation.md.

D26 · Project Cohesion10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic, LLM-independent.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 of 6 projects flagged as possibly oversized/incoherent.

✓ On the Gold path — maintain.

Detailed fixes: d26_recommendation.md.

D28 · Secrets (history)9.0 / 10Adequategated by 1 critical finding✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 9.0 / 10 · rule-coverage 100% · ceiling Documented

1 finding(s): 0 critical, 1 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED
REDACTED

What to do

  1. Resolve the 1 High secret finding(s) in Secrets (history) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  2. Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

D29 · Static Analysis (SAST)3.4 / 10Weak✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 3.4 / 10 · rule-coverage 100% · ceiling Documented

37 finding(s): 0 critical, 26 high, 11 medium, 0 low. 23 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 2 file(s) — `JPPhotoManagerWeb/backend/scripts/license-report.sh` (lines 70–73), `JPPhotoManagerWeb/scripts/port-forward-k8s.sh` (line 61) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 2 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 1 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 issue-level).
  2. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  3. No action in Static Analysis (SAST) — all 23 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (23 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities0.0 / 10Critical✓ Tool-verified

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

33 finding(s): 3 critical, 22 high, 8 medium, 0 low. Partial dependency scan: 2 of 3 declared ecosystem(s) were scanned (npm,osv), and the findings above are real and complete for them. nuget was not scanned (nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan), so this is not the whole dependency surface and the result is reported at reduced confidence.

REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 22 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (22). — One of this dimension's main actionable groups (22 issue-level).
  2. Resolve the 7 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (7). — One of this dimension's main actionable groups (7 warning-level).
  3. Resolve the 3 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (3). — One of this dimension's main actionable groups (3 issue-level).

Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.

D31 · IaC & Container Security0.0 / 10Critical✓ Tool-verified

What it measures: Whether Dockerfiles / Terraform / Kubernetes config follow security best practices.

Method: IaC/container misconfiguration scan via trivy config (REDACTED/Terraform/K8s/Helm/CloudFormation); severity rules to 0-10 moderate normalizer. NotApplicable without manifests. Exhaustive, deterministic.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

244 finding(s): 0 critical, 11 high, 191 medium, 42 low.

REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 191 Medium IaC finding(s) in IaC & Container Security — start with REDACTED (24), REDACTED (24), REDACTED (24). — One of this dimension's main actionable groups (191 warning-level).
  2. Resolve the 11 High IaC finding(s) in IaC & Container Security — start with REDACTED (2), REDACTED, REDACTED. — One of this dimension's main actionable groups (11 issue-level).
  3. Resolve the 42 Low IaC finding(s) in IaC & Container Security — start with REDACTED (5), REDACTED (5), REDACTED (5). — One of this dimension's main actionable groups (42 recommendation-level).

Detailed fixes: d31_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling10.0 / 10Stronggated by 1 serious finding✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: AssetController.java↔asset.service.ts 80%

Change coupling: AssetController.java ↔ asset.service.tsJPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/AssetController.java:1

What to do

  1. Resolve the 1 Change coupling finding(s) in Change Coupling — start with AssetController.java. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D36 · Supply-chain Provenance & Signing0.0 / 10Critical✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

0/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 1 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 4 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (4 warning-level).
  2. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D40 · Network Egress Confinement6.0 / 10Adequate✓ Tool-verified

What it measures: Whether Kubernetes workloads restrict network EGRESS with a NetworkPolicy (or Cilium policy), limiting where a compromised pod can send data or reach a command-and-control server. Presence of committed egress-restricting policy, not runtime enforcement.

Method: Deterministic YAML-manifest inspection (no external tool, no Roslyn — language-agnostic): Kubernetes workloads gate applicability; credits a NetworkPolicy / Cilium policy that restricts egress (policyTypes: [Egress] / egress rules). Reward-leaning (neutral floor climbing to 10, never a deduction — baseline misconfigs stay with D31). Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.0 / 10 · rule-coverage 100% · ceiling Documented

0/2 network-egress controls present (network policy, egress restriction).

No network policy

What to do

  1. Resolve the 1 No network policy finding(s) in Network Egress Confinement. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d40_recommendation.md · top locations in Appendix A, every location in findings.md.

D41 · Kernel & Syscall Confinement6.0 / 10Adequate✓ Tool-verified

What it measures: Whether Kubernetes workloads confine the kernel boundary — a seccomp profile (RuntimeDefault/Localhost) plus an AppArmor/SELinux mandatory-access-control layer — shrinking the syscall attack surface a container escape would use. Presence of committed confinement config, not runtime enforcement.

Method: Deterministic YAML-manifest inspection (no external tool, no Roslyn): on Kubernetes workloads, credits a seccomp profile (RuntimeDefault/Localhost) and an AppArmor/SELinux MAC layer. Reward-leaning (neutral floor climbing to 10); NotApplicable without workloads. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.0 / 10 · rule-coverage 100% · ceiling Documented

0/8 workload(s) run every container under a seccomp profile; 0/8 declare an AppArmor/SELinux profile.

No seccomp profile · ×8REDACTED:50

What to do

  1. Resolve the 8 No seccomp profile finding(s) in Kernel & Syscall Confinement — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (8 recommendation-level).

Detailed fixes: d41_recommendation.md · top locations in Appendix A, every location in findings.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Scored apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. SCORED, not informational.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 7 platform declaration(s) and 14 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX1 · Captive dependencies7.1 / 10Strong✓ Tool-verified

Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.

Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.

  • `FolderRepository` is registered as a SINGLETON but its constructor takes `AppDbContext appDbContext`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `AppDbContext` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — JPPhotoManager/JPPhotoManager.Infrastructure/Repositories/FolderRepository.cs:11
  • `AssetRepository` is registered as a SINGLETON but its constructor takes `AppDbContext appDbContext`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `AppDbContext` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — JPPhotoManager/JPPhotoManager.Infrastructure/Repositories/AssetRepository.cs:28
  • `RecentTargetPathRepository` is registered as a SINGLETON but its constructor takes `AppDbContext appDbContext`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `AppDbContext` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — JPPhotoManager/JPPhotoManager.Infrastructure/Repositories/RecentTargetPathRepository.cs:11
  • `SyncAssetsConfigurationRepository` is registered as a SINGLETON but its constructor takes `AppDbContext appDbContext`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `AppDbContext` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — JPPhotoManager/JPPhotoManager.Infrastructure/Repositories/SyncAssetsConfigurationRepository.cs:11
  • `ConvertAssetsConfigurationRepository` is registered as a SINGLETON but its constructor takes `AppDbContext appDbContext`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `AppDbContext` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — JPPhotoManager/JPPhotoManager.Infrastructure/Repositories/ConvertAssetsConfigurationRepository.cs:11

What to do

  • Don't inject scoped/transient services into singletons; resolve them per-use via IServiceScopeFactory or a factory delegate, or align the lifetimes.
AX10 · Code composition8.3 / 10Strong✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

AX2 · Stateful singletons7.1 / 10Strong✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

  • `CatalogAssetsService` is a singleton (one shared instance) but mutates instance state outside any lock (_currentFolderPath; e.g. `_currentFolderPath` at line 96). — JPPhotoManager/JPPhotoManager.Domain/Services/CatalogAssetsService.cs:11
  • `Application` is a singleton (one shared instance) but mutates instance state outside any lock (_recentThumbnailsQueue; e.g. `_recentThumbnailsQueue` at line 88). — JPPhotoManager/JPPhotoManager.Application/Application.cs:10
  • `MainWindow` is a singleton (one shared instance) but mutates instance state outside any lock (_catalogTask; e.g. `_catalogTask` at line 483). This type is a UI view, so it is thread-CONFINED rather than locked: if every one of those mutations is reached only from the UI thread — directly, or marshalled back through the dispatcher — the confinement IS the synchronisation and there is nothing to add (do not take a lock on a view; that is how the UI thread deadlocks). Check the ones that are not: a handler for a background event that mutates before it marshals is a real race. — JPPhotoManager/JPPhotoManager.UI/Windows/MainWindow.xaml.cs:29
  • `ApplicationViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_appMode, _sortCriteria, _viewerZoom, _viewerPosition, _selectedAssets, _currentFolder; e.g. `_appMode` at line 64). — JPPhotoManager/JPPhotoManager.UI/ViewModels/ApplicationViewModel.cs:27
  • `CatalogAssetItemWriter` is a singleton (@Bean: the container shares one instance across every request thread) but mutates instance state outside any lock (cachedFolder; e.g. `cachedFolder` in `ensureFolderExists` at line 143). — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemWriter.java:35

What to do

  • Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
  • Java/Kotlin: keep container singletons stateless — move per-request data into locals or a request-scoped bean — or back the state with java.util.concurrent types (ConcurrentHashMap, AtomicInteger/AtomicReference), guard it with synchronized / a Lock (Kotlin: withLock), or mark a flag that is only ever overwritten volatile (@Volatile).
AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

  • The namespaces JPPhotoManager.Domain ↔ JPPhotoManager.Domain.Entities ↔ JPPhotoManager.Domain.Interfaces.Services depend on each other. The lightest dependency in the cycle is JPPhotoManager.Domain.Entities → JPPhotoManager.Domain.Interfaces.Services (JPPhotoManager.Domain.Entities.Asset → JPPhotoManager.Domain.Interfaces.Services.IStorageService, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — JPPhotoManager/JPPhotoManager.Domain/Entities/Asset.cs:1
  • The namespaces JPPhotoManager.UI.Controls ↔ JPPhotoManager.UI.Windows depend on each other. The lightest dependency in the cycle is JPPhotoManager.UI.Controls → JPPhotoManager.UI.Windows (JPPhotoManager.UI.Controls.ThumbnailsUserControl → JPPhotoManager.UI.Windows.ThumbnailSelectedEventHandler, 2 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — JPPhotoManager/JPPhotoManager.UI/Controls/ThumbnailsUserControl.xaml.cs:6

What to do

  • Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.
AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX5 · Architecture & structure10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.

Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.

AX6 · Interface segregation9.9 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

  • `IStorageService` declares 29 members: `GetParentDirectory`, `GetSubDirectories`, `GetRecursiveSubDirectories`, `ResolveDataDirectory`, `CreateDirectory`, `ReadObjectFromJsonFile`, `WriteObjectToJsonFile`, `DeleteFile`, `GetFileNames`, `GetFileNames`, `GetFileBytes`, `LoadBitmapImage`, `LoadBitmapImage`, `LoadBitmapImage`, `GetExifOrientation`, `GetImageRotation`, `HasSameContent`, `LoadBitmapImage`, `GetJpegBitmapImage`, `GetPngBitmapImage`, `GetDrives`, `FileExists`, `FileExists`, `FolderExists`, `CopyImage`, `MoveImage`, `GetFileInformation`, `InitializeDatabaseDirectory`, `InitializeBinaryFilesDirectory`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 29 declarations carry 24 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 24 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — JPPhotoManager/JPPhotoManager.Domain/Interfaces/Services/IStorageService.cs:7
  • `IApplication` declares 25 members: `GetAssets`, `LoadThumbnail`, `GetSyncAssetsConfiguration`, `SetSyncAssetsConfiguration`, `SyncAssetsAsync`, `GetConvertAssetsConfiguration`, `SetConvertAssetsConfiguration`, `ConvertAssetsAsync`, `CatalogAssetsAsync`, `SetAsWallpaper`, `GetDuplicatedAssets`, `DeleteAssets`, `GetAboutInformation`, `GetDrives`, `GetSubFolders`, `GetInitialFolder`, `GetCatalogCooldownMinutes`, `MoveAssets`, `LoadBitmapImage`, `FileExists`, `GetRecentTargetPaths`, `GetRootCatalogFolders`, `IsAlreadyRunning`, `CheckNewReleaseAsyc`, `ShrinkDatabase`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — JPPhotoManager/JPPhotoManager.Application/IApplication.cs:8
  • `AssetRepository` declares 34 abstract methods: `addTagToAsset`, `completeIfAllStagesFinished`, `count`, `countByCreationMonth`, `countByExtension`, `countByRating`, `countDeleted`, `countDuplicates`, `countTotal`, `deleteById`, `existsById`, `findAll`, `findAllById`, `findAllDeleted`, `findAllFilteredSortedByDateDesc`, `findByFileName`, `findByFolder`, `findByFolderAndFileName`, `findById`, `findDeleted`, `findDeletedBefore`, `findFiltered`, `findNotDeleted`, `findRecentAssets`, `findTopFoldersByAssetCount`, `hasTag`, `removeTagFromAsset`, `save`, `sumFileSize`, `sumFileSizeByFolder`, `updateExifCompletedAt`, `updateHash`, `updateProcessingStatus`, `updateThumbnail`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/domain/port/out/AssetRepository.java:18
  • `StoragePort` declares 20 abstract methods: `computeHash`, `convertPngToJpeg`, `copyFile`, `createDirectory`, `deleteFile`, `directoryExists`, `fileExists`, `generateThumbnail`, `getExifMetadata`, `getFileCreationDateTime`, `getFileModificationDateTime`, `getFileSize`, `getImageRotation`, `isAudioFile`, `isPlaylistFile`, `isVideoFile`, `listFiles`, `listSubDirectories`, `moveFile`, `readFileBytes`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/domain/port/out/StoragePort.java:10
  • `JpaAssetRepository` declares 32 abstract methods: `addTagToAsset`, `completeIfAllStagesFinished`, `countByCreationMonth`, `countByDeletedAtIsNotNull`, `countByDeletedAtIsNull`, `countByExtension`, `countByRating`, `countDuplicates`, `deleteByFolderAndFileName`, `existsByFolderAndFileName`, `findAllByIdWithFolder`, `findAllWithFolder`, `findByAlbumId`, `findByDeletedAtBefore`, `findByFileNameNotDeleted`, `findByFolder`, `findByFolderAndFileName`, `findByHashNotDeleted`, `findByIdWithFolder`, `findDeletedOrderByDeletedAtDesc`, `findDuplicateHashes`, `findNotDeleted`, `findRecentAssets`, `findTopFoldersByAssetCount`, `hasTag`, `removeTagFromAsset`, `sumFileSize`, `sumFileSizeByFolder`, `updateExifCompletedAt`, `updateHash`, `updateProcessingStatus`, `updateThumbnail`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/persistence/jpa/JpaAssetRepository.java:28

What to do

  • Split fat interfaces into focused role-interfaces so clients depend only on what they use.
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.

Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.

DM10 · One transaction, one aggregate9.6 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether a single operation mutates more than one aggregate root. An aggregate is a consistency boundary, so saving two together fuses them into one — the second's invariants come to depend on the first's transaction, and the pair can no longer be separated. Reads of other aggregates are not counted.

Method: Neutral body surface (DDD-gated): every method body scanned for repository WRITE calls (Add/Update/Save/Remove/Delete/Insert/Store and their async forms), keyed on the ARGUMENT type rather than the repository type — three `IRepository<T>` writes collapse to one repository but are three distinct aggregates. Reads (Get/Find/Load/Query) are excluded, so loading another aggregate for context never counts. Score is offending methods over methods that write at all. Deterministic.

  • `MoveAssetsUseCaseImpl.execute` saves `folderRepository`, `assetRepository` in a single operation. Each is its own consistency boundary, so committing them together makes the second's invariants depend on the first's transaction, holds a lock across both for the whole operation, and means the pair can no longer be separated — into different services, or different databases. Mutate one aggregate here and let the others follow from a domain event. — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/MoveAssetsUseCaseImpl.java:45
  • `CatalogAssetItemWriter.write` saves `Asset`, `AssetExif`, `AssetAudio` in a single operation. Each is its own consistency boundary, so committing them together makes the second's invariants depend on the first's transaction, holds a lock across both for the whole operation, and means the pair can no longer be separated — into different services, or different databases. Mutate one aggregate here and let the others follow from a domain event. — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemWriter.java:76

What to do

  • Mutate one aggregate per operation and let the others follow from a domain event — the second aggregate reaching consistency a moment later is the design, not a compromise.
DM11 · Constructible invalid state9.5 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether an aggregate can be constructed in a state its own rules forbid — a public constructor that takes a raw primitive, stores it, and validates nothing, with no factory beside it. A constructor taking only value objects is not counted: each parameter has already validated itself.

Method: Neutral surface (DDD-gated): each non-abstract entity/aggregate checked for a PUBLIC constructor taking at least one RAW PRIMITIVE parameter whose body contains no guard token (throw / Guard. / Ensure. / ArgumentException / CheckRule), on a type that also offers no static Create/Of/From/New factory. A constructor taking only value objects is never charged -- measured: 64 of 87 unguarded public constructors on the C# corpus take value objects only, so ignoring parameter types would be 73% false positives. One finding per entity. Deterministic.

  • `RecentTargetPathEntity`'s public constructor takes `path` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `RecentTargetPathEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/persistence/entity/RecentTargetPathEntity.java:20

What to do

  • Give each aggregate one way in that can refuse — a guarded constructor, value-object parameters that validate themselves, or a private constructor behind a factory that returns a failure.
DM12 · Ambient inputs in the domain10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether domain types receive the time and randomness their rules depend on, rather than reading the process clock or a global random source directly — an ambient read makes the rule it feeds untestable at the instant that matters and lets two reads inside one operation disagree.

Method: Roslyn (DDD-gated, C#/VB only): domain-layer types scanned for ambient reads — DateTime/DateTimeOffset.Now/UtcNow/Today, Random.Shared, new Random(), Stopwatch.GetTimestamp — resolved against the semantic model, with a comment/string-stripped token fallback only where resolution fails. Body reads are scored; field/property initialisers are surfaced unscored. Apply/When folds excluded (ES1 owns them). Deterministic, symbol-resolved.

  • `CatalogAssetsService` reads `DateTime.Now` inside `CreateAsset`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — JPPhotoManager/JPPhotoManager.Domain/Services/CatalogAssetsService.cs:345

What to do

  • Pass the instant into the domain method that needs it, or inject `TimeProvider` (BCL, .NET 8+) and read it there — then a test can choose the moment a rule is evaluated at.
DM5 · Encapsulated state10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether entities protect their state — private/init-only setters, and collections handed out as read-only views rather than the mutable backing collection — instead of exposing writable state that bypasses invariants. Softened when a rehydration framework (Marten/EF) is present.

Method: Roslyn (DDD-gated): entities scanned for publicly writable state — public setters, and (C#/VB) own mutable collections handed out through an auto-property, a public field or a bare-field expression getter, where a computed/copying getter is never charged. One finding per entity; score softened when Marten/EF rehydration frameworks present. Deterministic, framework-aware.

Coverage: Population: entities by convention; encapsulation (setter shape) checked exhaustively within the set.

DM6 · Domain ↔ infrastructure boundary6.8 / 10Adequate✓ Tool-verified

Other · Domain Modelling — Whether the domain layer stays free of infrastructure dependencies (EF/Marten/HTTP/ASP.NET) — the clean-architecture dependency rule.

Method: Roslyn (DDD-gated): domain-layer types scanned for infrastructure usage in member SIGNATURES and inside method/accessor BODIES — resolved calls and object-creations into EF/Marten/HTTP/Mongo/Redis/message-bus types (not just a namespace allowlist). Deterministic, symbol-resolved, exhaustive over domain-layer bodies, DDD-native.

Coverage: Domain layer identified by NAMESPACE heuristic; infrastructure then resolved by symbol in member SIGNATURES and method/accessor BODIES — rename the layer and the check evaporates.

  • `Asset` (domain layer) names `KeyAttribute` from `System.ComponentModel.DataAnnotations` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it. — JPPhotoManager/JPPhotoManager.Domain/Entities/Asset.cs:14
  • `Asset` (domain layer) names `NotMappedAttribute` from `System.ComponentModel.DataAnnotations.Schema` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it. (×2) — JPPhotoManager/JPPhotoManager.Domain/Entities/Asset.cs:28, JPPhotoManager/JPPhotoManager.Domain/Entities/Asset.cs:31
  • `ConvertAssetsDirectoriesDefinition` (domain layer) names `KeyAttribute` from `System.ComponentModel.DataAnnotations` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it. — JPPhotoManager/JPPhotoManager.Domain/Entities/ConvertAssetsDirectoriesDefinition.cs:11
  • `Folder` (domain layer) names `KeyAttribute` from `System.ComponentModel.DataAnnotations` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it. — JPPhotoManager/JPPhotoManager.Domain/Entities/Folder.cs:8
  • `Folder` (domain layer) names `NotMappedAttribute` from `System.ComponentModel.DataAnnotations.Schema` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it. (×2) — JPPhotoManager/JPPhotoManager.Domain/Entities/Folder.cs:12, JPPhotoManager/JPPhotoManager.Domain/Entities/Folder.cs:24
  • `RecentTargetPath` (domain layer) names `KeyAttribute` from `System.ComponentModel.DataAnnotations` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it. — JPPhotoManager/JPPhotoManager.Domain/Entities/RecentTargetPath.cs:7
  • `SyncAssetsDirectoriesDefinition` (domain layer) names `KeyAttribute` from `System.ComponentModel.DataAnnotations` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it. — JPPhotoManager/JPPhotoManager.Domain/Entities/SyncAssetsDirectoriesDefinition.cs:11

What to do

  • Invert domain→infrastructure dependencies: declare interfaces in the domain, implement them in infrastructure (Dependency Inversion).
DM7 · Repository granularity10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether repositories are per aggregate root (not per child entity) and keep the persistence query handle behind the contract, so the root's invariants can't be bypassed.

Method: Roslyn (DDD-gated): repository abstraction detection; repositories over non-aggregate-root entities flagged, and (C#/VB) repository INTERFACES whose members return a live persistence query handle (IQueryable/DbSet/IMongoQueryable) — implementations and specification evaluators are out of population by design, since composing a query internally is what an implementation is for. Deterministic, DDD-native.

Coverage: Population: repositories + aggregate roots by NAME convention; per-root repository rule checked within the set.

DM8 · Value-object opportunities10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether clusters of primitives that travel together (a missing value object) are extracted — a low-weight suggestion, LLM-confirmed when configured.

Method: Roslyn (DDD-gated): primitive parameter clusters recurring three or more times across signatures extracted, then confirmed by language model when configured. Advisory, low-weight.

DM9 · Scattered domain decisions10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether one domain rule is decided — or one measurement produced — in more than one place, rather than living on the type that owns it.

Method: Neutral body surface plus Roslyn (DDD-gated), two arms. DECISION (Roslyn only): a predicate over a domain type's members judged in two or more types, where none of those decisions live on the owning type — operands of comparisons and relational property patterns only, so a member merely passed as an argument is not judged. DERIVATION: a plain all-numeric carrier of ≥2 members, with no base type and exactly one constructor, CONSTRUCTED as the result of a method (returned or assigned, never inline as an argument) in two or more types other than its own — the same measurement produced twice, which centralising the judgement does not fix. DERIVATION runs on every language whose frontend declares the produced-or-passed fact per construction (Roslyn and the Java sidecar today); a target with only the derivation arm carries an engine gap naming the decision arm as not assessed, and a frontend that declares nothing keeps the dimension not measured rather than clean. Single-member rules, test code and generated code are out of population for both. Advisory.

GD1 · Unfinished & placeholder code9.8 / 10Exemplary✓ Tool-verified

Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.

Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.

  • A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×3) — JPPhotoManager/JPPhotoManager.UI/Converters/FileSizeConverter.cs:56, JPPhotoManager/JPPhotoManager.UI/Converters/PixelSizeConverter.cs:22, JPPhotoManager/JPPhotoManager.UI/Converters/VisibilityConverter.cs:15

What to do

  • Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
IC1 · Incompleteness & stubs10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

  • A test is skipped ("GitHub API integration test") — coverage that looks present but never runs in any gate. If it's an opt-in suite, document how it runs; otherwise re-enable or delete it. — JPPhotoManager/JPPhotoManager.Tests/Integration/ReleaseAvailabilityServiceTests.cs:35
  • A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). — JPPhotoManager/JPPhotoManager.UI/Windows/FolderNavigationWindow.xaml.cs:71

What to do

  • Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
M1 · Documentation (README)8.3 / 10Strong✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
  • Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
  • Add a README to the 1 of 6 project(s) that lack one — worth up to 0.3 pts.
M2 · Architecture documentation5.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
M3 · Folder & project structure8.0 / 10Strong✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

  • Production code isn't grouped under a src/ folder — it's spread across several top-level directories, so there's no one place that says 'this is the product'.

What to do

  • Group production code under src/ (or split deliberately, e.g. backend/ + frontend/) so production and tooling code aren't mixed at the root.
M4 · Documentation accuracy0.0 / 10Critical◐ Sampled · advisory

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

  • JPPhotoManagerWeb/README.md runs `bash scripts/complexity-report.sh`, but `scripts/complexity-report.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/README.md:38
  • JPPhotoManagerWeb/README.md runs `bash scripts/dead-code-report.sh`, but `scripts/dead-code-report.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/README.md:39
  • JPPhotoManagerWeb/README.md runs `bash scripts/auth-coverage-report.sh`, but `scripts/auth-coverage-report.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/README.md:41
  • JPPhotoManagerWeb/README.md runs `bash scripts/coverage-report.sh`, but `scripts/coverage-report.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/README.md:44
  • JPPhotoManagerWeb/README.md runs `bash scripts/mutation-report.sh`, but `scripts/mutation-report.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/README.md:48
  • JPPhotoManagerWeb/README.md runs `bash scripts/license-report.sh`, but `scripts/license-report.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/README.md:50
  • JPPhotoManagerWeb/README.md runs `bash scripts/sca-report.sh`, but `scripts/sca-report.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/README.md:51
  • JPPhotoManagerWeb/README.md names `SKILL.md`, but no file or folder `SKILL.md` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/README.md:57
  • docs/windows-dev-setup.md names Node.js 24, but the repository declares pinned 22. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/windows-dev-setup.md:164
  • JPPhotoManagerWeb/docs/authentication.md names `.env`, but no file or folder `.env` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/docs/authentication.md:176
  • JPPhotoManagerWeb/docs/authentication.md documents the environment variable `HOST_IMAGE_DIR_N`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/docs/authentication.md:222
  • JPPhotoManagerWeb/docs/backend.md names `application/service/PasswordValidationService`, but no file or folder `application/service/PasswordValidationService` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/docs/backend.md:307
  • JPPhotoManagerWeb/docs/docker-compose.md names `.env`, but no file or folder `.env` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/docs/docker-compose.md:20
  • JPPhotoManagerWeb/docs/docker-compose.md documents the environment variable `HOST_IMAGE_DIR_N`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/docs/docker-compose.md:25
  • JPPhotoManagerWeb/docs/docker-compose.md names `grafana/grafana`, but no file or folder `grafana/grafana` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/docs/docker-compose.md:85
  • JPPhotoManagerWeb/docs/kubernetes.md names `k8s/catalog-volumes.yaml`, but no file or folder `k8s/catalog-volumes.yaml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/docs/kubernetes.md:13
  • JPPhotoManagerWeb/docs/kubernetes.md runs `./scripts/build-and-deploy-k8s.sh`, but `scripts/build-and-deploy-k8s.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — JPPhotoManagerWeb/docs/kubernetes.md:46

What to do

  • Reconcile the README with reality: JPPhotoManagerWeb/README.md runs `bash scripts/complexity-report.sh`, but `scripts/complexity-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/dead-code-report.sh`, but `scripts/dead-code-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/auth-coverage-report.sh`, but `scripts/auth-coverage-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/coverage-report.sh`, but `scripts/coverage-report.sh` does not exist; JPPhotoManagerWeb/README.md runs `bash scripts/mutation-report.sh`, but `scripts/mutation-report.sh` does not exist.
P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

P2 · Observability10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

P3 · Security & performance tooling3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

What to do

  • The .NET analyzers are running but not blocking — tighten them (set <AnalysisMode>All</AnalysisMode>, or treat analyzer warnings as errors on CI) so a security/quality regression fails the build rather than scrolling past as a warning.
  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback8.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

What to do

  • Add an approval/environment gate (required reviewers / protection rules) before production promotion.
P5 · DR & Backup7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.

Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.

What to do

  • Document RTO/RPO and a tested restore procedure (a backup config alone isn't disaster recovery).
P6 · Release Hygiene8.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

  • The changelog this check read carries 2 versioned entries, against a bar of 3. Counted as either the distinct `x.y.z` versions it names (a link's target is not counted) or its version-shaped section headings (`## [1.2.0]`, `## V14.x.x`, `## Updates in 8.0.x`), whichever is the larger — so a log sectioned by minor series counts its sections, not its individual patch numbers. Entries recorded somewhere this check does not read — release notes generated at tag time from a generator config it did not recognise, or a log kept outside the repository — are not counted here, and this row is about what is re-findable in the tree rather than about how often you release.

What to do

  • Keep the changelog current — add a versioned entry (Keep-a-Changelog ## [x.y.z]) for each release so the history isn't a stub.
P8 · Schema migrations10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether EF Core schema changes go through versioned migrations rather than the un-evolvable EnsureCreated().

Method: Roslyn scan: EF Core DbContext for a versioned migrations directory versus bare EnsureCreated usage; off .NET, a file scan of dependency manifests, migration histories (Flyway, Liquibase, Alembic, Django, Rails, Prisma, TypeORM, Knex/Sequelize, golang-migrate, goose, Laravel, Doctrine, Diesel/sqlx) and schema auto-create in production source or config. Exhaustive, deterministic.

PF3 · Async & latency hygiene6.0 / 10Adequate✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

  • `fs.readFileSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. — JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:111
  • `fs.existsSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. (×2) — JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:116, JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:121
  • `execSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. (×2) — JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:119, JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:143
  • `fs.mkdirSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. — JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:184
  • `fs.writeFileSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs. — JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:186

What to do

  • TypeScript/JavaScript: use the promise APIs (fs/promises, a promisified child_process.execFile, the async zlib/crypto functions) and await them instead of the *Sync variants.
R1 · Type Safety9.0 / 10Strong✓ Tool-verified

React / JS · Code Health — How much of the frontend is typed TypeScript vs untyped JavaScript.

Method: Frontend file inventory: the share of typed TypeScript vs untyped JavaScript across the source tree. Deterministic, exhaustive over frontend files.

What to do

  • Migrate the remaining .js/.jsx files to TypeScript.
R10 · Code Duplication7.6 / 10Strong✓ Tool-verified

React / JS · Code Health — Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm over JS/TS tokens, D-386): a block is reported only where its copies still agree on most of their own identifiers and literals, or were renamed as they were pasted but kept most of their constants, and where the copies carry enough code to stand on their own or the copied extent reaches 30 lines — so a re-implementation sharing neither names nor values, and a small pasted declaration, are both found and deliberately not reported, and a clean R10 is not a claim that nothing was copied.

Method: Near-exact copy-pasted blocks of substantial extent across the frontend (the D4 clone algorithm run over JS/TS tokens). Masking finds the candidates; a block is reported when its copies still agree on most of their own identifiers and literals, or when a renamed copy still agrees on most of its constants, AND the copies carry enough code to stand on their own — or when the copied extent reaches 30 lines. So a re-implementation sharing neither names nor values, and a small pasted declaration, are deliberately not counted. Deterministic.

  • 5 duplicated blocks under JPPhotoManagerWeb/frontend/src/app/features/ have copies in at least two of the sibling directories admin, albums, convert, gallery, profile, recycle-bin (+1 more sibling(s) not listed) — 3 of them are reported below, and 2 are counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 5 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 5 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 5 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — JPPhotoManagerWeb/frontend/src/app/features/convert/convert.component.ts:1
  • JPPhotoManagerWeb/frontend/src/app/features/convert/convert.component.ts:1 · JPPhotoManagerWeb/frontend/src/app/features/sync/sync.component.ts:1 — these 2 files are line-for-line copies of one another — 77 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done. — JPPhotoManagerWeb/frontend/src/app/features/convert/convert.component.ts:1
  • JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:21 · JPPhotoManagerWeb/frontend/scripts/type-coverage-report.js:19 — the two spans are one implementation copied and then locally edited — 296 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:21
  • JPPhotoManagerWeb/frontend/scripts/license-compliance-report.js:21 · JPPhotoManagerWeb/frontend/scripts/sca-report.js:22 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. — JPPhotoManagerWeb/frontend/scripts/license-compliance-report.js:21
  • JPPhotoManagerWeb/frontend/scripts/code-coverage-report.js:71 · JPPhotoManagerWeb/frontend/scripts/complexity-report.js:39 · JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:53 · JPPhotoManagerWeb/frontend/scripts/type-coverage-report.js:46 — the 4 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. There is one copy in each of 4 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete. — JPPhotoManagerWeb/frontend/scripts/code-coverage-report.js:71
  • JPPhotoManagerWeb/frontend/src/app/features/gallery/exif-panel/exif-panel.component.ts:59 · JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:159 — the two spans are one implementation copied and then locally edited — 118 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — JPPhotoManagerWeb/frontend/src/app/features/gallery/exif-panel/exif-panel.component.ts:59
  • JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:139 · JPPhotoManagerWeb/frontend/scripts/mutation-report.js:119 — the two spans are one implementation copied and then locally edited — 116 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:139
  • JPPhotoManagerWeb/frontend/scripts/a11y-report.js:95 · JPPhotoManagerWeb/frontend/scripts/code-coverage-report.js:77 · JPPhotoManagerWeb/frontend/scripts/complexity-report.js:45 · JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:59 · +2 more site(s) not listed — the 6 copies are spread across 6 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/scripts/a11y-report.js:95
  • JPPhotoManagerWeb/frontend/scripts/bundle-size-report.js:122 · JPPhotoManagerWeb/frontend/scripts/dependency-staleness-report.js:109 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/scripts/bundle-size-report.js:122
  • JPPhotoManagerWeb/frontend/src/app/features/gallery/bulk-tag-dialog/bulk-tag-dialog.component.ts:89 · JPPhotoManagerWeb/frontend/src/app/features/gallery/bulk-tag-dialog/bulk-tag-dialog.component.ts:109 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/src/app/features/gallery/bulk-tag-dialog/bulk-tag-dialog.component.ts:89
  • JPPhotoManagerWeb/frontend/scripts/complexity-report.js:49 · JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:63 · JPPhotoManagerWeb/frontend/scripts/license-compliance-report.js:68 · JPPhotoManagerWeb/frontend/scripts/sca-report.js:71 · +1 more site(s) not listed — the 5 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. There is one copy in each of 5 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete. — JPPhotoManagerWeb/frontend/scripts/complexity-report.js:49
  • JPPhotoManagerWeb/frontend/src/app/core/services/convert.service.ts:6 · JPPhotoManagerWeb/frontend/src/app/core/services/sync.service.ts:6 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — JPPhotoManagerWeb/frontend/src/app/core/services/convert.service.ts:6
  • JPPhotoManagerWeb/frontend/src/app/features/gallery/exif-panel/exif-panel.component.ts:116 · JPPhotoManagerWeb/frontend/src/app/features/gallery/exif-panel/exif-panel.component.ts:130 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — JPPhotoManagerWeb/frontend/src/app/features/gallery/exif-panel/exif-panel.component.ts:116
  • JPPhotoManagerWeb/frontend/src/app/features/audio-player/audio-player.component.ts:15 · JPPhotoManagerWeb/frontend/src/app/shared/components/media-fullscreen-overlay/media-fullscreen-overlay.component.ts:25 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — JPPhotoManagerWeb/frontend/src/app/features/audio-player/audio-player.component.ts:15
  • JPPhotoManagerWeb/frontend/src/app/core/services/album.service.ts:6 · JPPhotoManagerWeb/frontend/src/app/core/services/search-preset.service.ts:6 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/src/app/core/services/album.service.ts:6
  • JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:238 · JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:430 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:238
  • JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:441 · JPPhotoManagerWeb/frontend/src/app/features/recycle-bin/recycle-bin.component.ts:53 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:441
  • JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:949 · JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:966 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:949
  • JPPhotoManagerWeb/frontend/scripts/license-compliance-report.js:95 · JPPhotoManagerWeb/frontend/scripts/sca-report.js:99 · JPPhotoManagerWeb/frontend/scripts/secrets-scan-report.js:108 — the 3 copies are spread across 3 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/scripts/license-compliance-report.js:95
  • JPPhotoManagerWeb/frontend/src/app/core/services/asset.service.ts:20 · JPPhotoManagerWeb/frontend/src/app/core/services/asset.service.ts:35 — the two spans are one implementation copied and then locally edited — 85 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — JPPhotoManagerWeb/frontend/src/app/core/services/asset.service.ts:20
  • JPPhotoManagerWeb/frontend/src/app/features/albums/albums.component.ts:53 · JPPhotoManagerWeb/frontend/src/app/features/convert/convert.component.ts:50 · JPPhotoManagerWeb/frontend/src/app/features/sync/sync.component.ts:50 — the 3 copies are spread across 3 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/src/app/features/albums/albums.component.ts:53
  • JPPhotoManagerWeb/frontend/src/app/features/audio-player/audio-player.component.ts:17 · JPPhotoManagerWeb/frontend/src/app/features/gallery/video-player/video-player.component.ts:27 · JPPhotoManagerWeb/frontend/src/app/shared/components/media-fullscreen-overlay/media-fullscreen-overlay.component.ts:27 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete. — JPPhotoManagerWeb/frontend/src/app/features/audio-player/audio-player.component.ts:17
  • JPPhotoManagerWeb/frontend/src/app/features/recycle-bin/recycle-bin.component.ts:69 · JPPhotoManagerWeb/frontend/src/app/features/recycle-bin/recycle-bin.component.ts:81 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/src/app/features/recycle-bin/recycle-bin.component.ts:69
  • JPPhotoManagerWeb/frontend/src/app/core/services/convert.service.ts:1 · JPPhotoManagerWeb/frontend/src/app/core/services/recycle-bin.service.ts:2 · JPPhotoManagerWeb/frontend/src/app/core/services/sync.service.ts:1 — the 3 copies are spread across 3 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — JPPhotoManagerWeb/frontend/src/app/core/services/convert.service.ts:1
  • JPPhotoManagerWeb/frontend/src/app/core/services/media-player.service.ts:88 · JPPhotoManagerWeb/frontend/src/app/core/services/media-player.service.ts:161 — the two spans are one implementation copied and then locally edited — 59 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — JPPhotoManagerWeb/frontend/src/app/core/services/media-player.service.ts:88
  • JPPhotoManagerWeb/frontend/src/app/features/albums/album-detail/album-detail.component.ts:65 · JPPhotoManagerWeb/frontend/src/app/features/albums/albums.component.ts:69 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — JPPhotoManagerWeb/frontend/src/app/features/albums/album-detail/album-detail.component.ts:65
  • JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:821 · JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:831 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:821
  • JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:110 · JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:119 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:110
  • JPPhotoManagerWeb/frontend/scripts/dependency-staleness-report.js:80 · JPPhotoManagerWeb/frontend/scripts/e2e-run-report.js:62 · JPPhotoManagerWeb/frontend/scripts/license-compliance-report.js:66 · JPPhotoManagerWeb/frontend/scripts/route-coverage-report.js:94 · +1 more site(s) not listed — the 5 copies are spread across 5 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/scripts/dependency-staleness-report.js:80
  • JPPhotoManagerWeb/frontend/scripts/a11y-report.js:166 · JPPhotoManagerWeb/frontend/scripts/bundle-size-report.js:131 · JPPhotoManagerWeb/frontend/scripts/dependency-staleness-report.js:118 — the 3 copies are spread across 3 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/scripts/a11y-report.js:166
  • JPPhotoManagerWeb/frontend/scripts/complexity-report.js:69 · JPPhotoManagerWeb/frontend/scripts/complexity-report.js:77 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — JPPhotoManagerWeb/frontend/scripts/complexity-report.js:69
  • JPPhotoManagerWeb/frontend/scripts/dependency-staleness-report.js:100 · JPPhotoManagerWeb/frontend/scripts/sca-report.js:89 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/scripts/dependency-staleness-report.js:100
  • JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:294 · JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:423 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. — JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:294
  • JPPhotoManagerWeb/frontend/src/app/features/profile/sessions/sessions.component.ts:46 · JPPhotoManagerWeb/frontend/src/app/features/profile/sessions/sessions.component.ts:69 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/src/app/features/profile/sessions/sessions.component.ts:46
  • JPPhotoManagerWeb/frontend/scripts/bundle-size-report.js:59 · JPPhotoManagerWeb/frontend/scripts/cyclomatic-complexity.js:22 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/scripts/bundle-size-report.js:59
  • JPPhotoManagerWeb/frontend/src/app/core/services/album.service.ts:22 · JPPhotoManagerWeb/frontend/src/app/core/services/asset.service.ts:116 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/src/app/core/services/album.service.ts:22
  • JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:303 · JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:370 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported. — JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:303
  • JPPhotoManagerWeb/frontend/scripts/bundle-size-report.js:24 · JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:111 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are. — JPPhotoManagerWeb/frontend/scripts/bundle-size-report.js:24

What to do

  • Act on each finding's own remediation rather than one rule: the move depends on what recurs. Where the copies are executable blocks, give the shared part one home and call it from each site; where they are declarations, a listing, a specialisation already delegating to its base, or one shape repeated per entity, there is no call site and the move is a shared type, a generated set or a factory — sometimes there is nothing to extract.
R2 · Cyclomatic Complexity9.9 / 10Exemplary✓ Tool-verified

React / JS · Code Health — Per-function cyclomatic/cognitive complexity from the token-level function scanner (D-386) — real branching, not a regex heuristic.

Method: Per-function cyclomatic/cognitive complexity from a token-level function scanner (real branching, not a regex heuristic), computed over every frontend function. Deterministic.

  • getHitArea has cyclomatic complexity 21 and cognitive complexity 10; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — JPPhotoManagerWeb/frontend/src/app/features/gallery/social-media-crop/social-media-crop.component.ts:234
  • main has cyclomatic complexity 17 and cognitive complexity 39; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — JPPhotoManagerWeb/frontend/scripts/a11y-report.js:83
  • resizeFromCorner has cyclomatic complexity 13 and cognitive complexity 12; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — JPPhotoManagerWeb/frontend/src/app/features/gallery/social-media-crop/social-media-crop.component.ts:190
  • functionName has cyclomatic complexity 12 and cognitive complexity 15; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — JPPhotoManagerWeb/frontend/scripts/cyclomatic-complexity.js:49
  • main has cyclomatic complexity 12 and cognitive complexity 15; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:109
  • createAlbum has cyclomatic complexity 11 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — JPPhotoManagerWeb/frontend/src/app/features/albums/albums.component.ts:78

What to do

  • Break down the listed branch-heavy functions; aim P95 cyclomatic ≤ 5.
R3 · Large Files9.6 / 10Exemplary✓ Tool-verified

React / JS · Code Health — How many source files exceed the large-file threshold.

Method: Components/modules exceeding the large-file threshold, counted exhaustively across the frontend source tree. Deterministic.

  • JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts has 907 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module. — JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:1

What to do

  • Split each oversized file along the responsibilities already in it, into smaller focused modules in the same package.
R4 · Test Coverage7.3 / 10Strong✓ Tool-verified

React / JS · Readiness — Static test reachability (D-386): the share of production files reachable from any test via the import graph — measured without running anything.

Method: Static test reachability: the share of production files reachable from any test via the import graph — measured without running anything. Deterministic.

  • No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one. (×19) — JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:1, JPPhotoManagerWeb/frontend/scripts/mutation-report.js:1, JPPhotoManagerWeb/frontend/scripts/a11y-report.js:1, …

What to do

  • Add tests that import the unreached modules (directly or through their public entry).
R5 · Dependency Freshness6.2 / 10Adequate✓ Tool-verified

React / JS · Readiness — How outdated the npm dependencies are (a maturity signal). JS/npm CVEs are scored separately in D30 (JS/npm Dependency Vulnerabilities).

Method: npm dependency staleness from manifest/registry metadata (a maturity signal; JS/npm CVEs are scored separately in D30, which answers dependency vulnerabilities for every ecosystem). Deterministic.

  • 38 outdated package(s); JS/npm CVEs scored in D30

What to do

  • Bump outdated dependencies to current versions to limit upgrade debt.
R6 · Tooling10.0 / 10Exemplary✓ Tool-verified

React / JS · Readiness — Whether the project wires up test, lint and typecheck — detected from each package.json script's COMMAND (eslint / tsc / vitest / jest / playwright), not just its name, and corroborated against CI-workflow invocations so a tool run only in CI still counts.

Method: package.json scanned for test/lint/typecheck script wiring. Deterministic presence check.

R7 · Dead Code9.8 / 10Exemplary✓ Tool-verified

React / JS · Code Health — Files unreachable from every application/tooling/test entry point, and exports nothing imports (module-graph reachability, D-386).

Method: Dead code: files unreachable from every application/tooling/test entry point plus exports nothing imports, via module-graph reachability. Deterministic, exhaustive over the import graph.

  • Unreachable from the 39 application, 21 tooling and 73 test entry point(s) detected in this repo. Gate removals on `npm run build` — an undetected custom entry would make these reachable.
  • no import path from any entry point (39 application, 21 tooling, 73 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make (×2) — JPPhotoManagerWeb/frontend/src/app/core/models/audio-metadata.model.ts, JPPhotoManagerWeb/frontend/src/app/core/models/tag.model.ts
  • Nothing imports this binding — it is safe to review for removal. (×3) — JPPhotoManagerWeb/frontend/src/app/core/models/album.model.ts:41, JPPhotoManagerWeb/frontend/src/app/core/models/analytics.model.ts:33, JPPhotoManagerWeb/frontend/src/app/core/models/asset.model.ts:40

What to do

  • Delete the dead files and unused exports — every line is maintenance cost and rebuild-estimate inflation with zero runtime value.
R8 · Dependency Hygiene10.0 / 10Exemplary✓ Tool-verified

React / JS · Readiness — npm dependency truthfulness (D-386): unused dependencies, imports not declared anywhere, and type-/test-only packages shipped as production deps.

Method: npm dependency truthfulness: unused dependencies, imports declared nowhere, and type-/test-only packages shipped as production deps — from the manifest + import graph. Deterministic.

R9 · Circular Imports10.0 / 10Exemplary✓ Tool-verified

React / JS · Architecture — Import cycles in the module graph (D-386) — files that can only be understood and changed together.

Method: Import cycles in the module graph, detected exhaustively over JS/TS imports (the same cycle detection as the .NET coupling dimension). Deterministic.

X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

X14 · Bypassable address classification10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.

Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.

X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.

Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.

Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

X19 · Unrestored process-global state10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

X2 · Cancellation propagation4.0 / 10Weak✓ Tool-verified

Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

  • Only 0/21 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
  • No CancellationToken parameter — this work can't be stopped early once started. (×21) — JPPhotoManager/JPPhotoManager.Domain/Services/CatalogAssetsService.cs:40, JPPhotoManager/JPPhotoManager.Domain/Services/ConvertAssetsService.cs:30, JPPhotoManager/JPPhotoManager.Domain/Services/NewReleaseNotificationService.cs:21, …

What to do

  • Thread a CancellationToken through async methods so work stops promptly on cancellation.
X20 · Mistyped argument guard4.8 / 10Weak✓ Tool-verified

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.

  • The guard on line 32 rejects `assets` and line 34 reports that rejection as `ArgumentNullException` — but the condition's own test `assets.Length == 0` is true of a value that is NOT null: it is satisfied by an EMPTY `assets`, and on that path `assets` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — JPPhotoManager/JPPhotoManager.Domain/Services/MoveAssetsService.cs:34
  • The guard on line 129 rejects `assets` and line 131 reports that rejection as `ArgumentNullException` — but the condition's own test `assets.Length == 0` is true of a value that is NOT null: it is satisfied by an EMPTY `assets`, and on that path `assets` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — JPPhotoManager/JPPhotoManager.Domain/Services/MoveAssetsService.cs:131

What to do

  • Each finding names the throw and the test in its own condition that is true of a NON-null value. Confirm from the two, then throw the exception that describes what was actually wrong: `ArgumentException` for a value that arrived empty, or the .NET 8 helpers that spell the whole guard in one line and pick the type for you — `ArgumentException.ThrowIfNullOrEmpty(s)` / `ThrowIfNullOrWhiteSpace(s)` for strings, `ArgumentNullException.ThrowIfNull(x)` followed by `ArgumentOutOfRangeException.ThrowIfZero(x.Count)` for a collection. Splitting the two conditions is usually clearer than picking one exception for both: they are different failures and the caller may want to handle them differently.
X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X22 · Contradicted release guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.

Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.

Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X26 · Unsynchronised callback handoff10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.

Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

X3 · Exception handling10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X32 · Type resolved by simple name across every loaded assembly10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a plugin lookup names the type it means — searching every assembly loaded into the process for a candidate whose SIMPLE name equals a string supplied at runtime, and taking the first one found, is decided by assembly LOAD ORDER rather than by this source, so the same name can resolve to a different type on the next run.

Method: Roslyn syntax only, no semantic model: every invocation of `First`/`FirstOrDefault`/`Single`/`SingleOrDefault` whose OWN expression subtree contains both a `GetAssemblies()` call and a `GetTypes()`/`GetExportedTypes()` call — a single-element pick out of every type loaded into the process. A nested selector in the same chain sees no `GetAssemblies()` in its own subtree and is outside the population, so one lookup counts once however many links its chain has. A finding additionally needs both remaining halves: the selector must be `First`/`FirstOrDefault` (`Single`/`SingleOrDefault` reports the ambiguity rather than resolving it, and is counted and never reported), and the chain must carry an `==` comparison of `<lambda parameter>.Name` against something that is not a literal. The receiver must be a plain identifier bound by one of the chain’s own lambdas, which places `assembly.GetName().Name == "X"` outside the rule by construction. One exemption: a `.Name` test joined by `&&` to a `FullName`/`AssemblyQualifiedName` test on the same identifier is spared; joined by `||` it is not. Deterministic, provable per finding. Advisory.

X4 · Structured logging10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

X5 · Nullable reference types8.4 / 10Strong✓ Tool-verified

Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • 4/5 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.

What to do

  • Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health71%StrongSolid.
Architecture83%StrongSolid.
Maturity49%Weak — gated by M4Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness64%Adequate — gated by P3Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security51%Adequate — gated by D29, D30, D31, D36Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Domain Modelling88%StrongStrongest area.
Performance60%AdequateAcceptable, with room to improve.
Unscored — 3 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • SC1 Supply-chain hygiene — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X10 Duplicated predicate — 2 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X7 Silent fallback defaults — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not included — 47 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No user-facing web UI (the repo is a library/CLI/worker/headless service) — accessibility is not applicable.
  • AC2 Forms & labels — No user-facing web UI (the repo is a library/CLI/worker/headless service) — accessibility is not applicable.
  • AC3 Page structure — No user-facing web UI (the repo is a library/CLI/worker/headless service) — accessibility is not applicable.
  • AC4 Keyboard semantics — No user-facing web UI (the repo is a library/CLI/worker/headless service) — accessibility is not applicable.
  • AC5 ARIA correctness — No user-facing web UI (the repo is a library/CLI/worker/headless service) — accessibility is not applicable.
  • AC6 Visual & motion safety — No user-facing web UI (the repo is a library/CLI/worker/headless service) — accessibility is not applicable.
  • AC7 A11y enforcement — No user-facing web UI (the repo is a library/CLI/worker/headless service) — accessibility is not applicable.
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • AXR1 Runtime accessibility — compose up failed (exit 15 — the compose project is invalid) — error while interpolating services.backend.environment.JWT_SECRET: required variable JWT_SECRET is missing a value: Set JWT_SECRET in .env - run: openssl rand -base64 32; runtime evidence skipped This is a statement about this run, not a statement about your application: nothing here says the surface is inaccessible, only that it was never rendered.
  • C1 Data Protection — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • C2 Access Controls — No access-control surface detected in the analyzed source — no web/app surface to authorize (no HTTP API or web-UI project) and no authorization code at all (no [Authorize]/policies, no imperative guard methods). Access control is therefore N/A here — this is a library/CLI, which is authorized by its CALLER, not by itself. If this codebase grows request handlers, the dimension reactivates and a default-deny posture is expected then.
  • C3 Audit Trail — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • C4 Data Retention — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • C5 Data-Subject Rights — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
  • D11 Test Reliability — Test reliability not measured — polyglot suite, one half not re-run
  • D12 Dependency Hygiene — Dependency hygiene not measured
  • D16 Bus Factor — bus factor 1 — one contributor carries this repository
  • D18 Solution Shape — D18 scores the shape of a C#/VB .NET solution, but this repository's production source is mostly .java, .ts, which the C#/VB workspace does not load — the projects that loaded are an immaterial minority, so solution shape was not assessed for this repository. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
  • D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
  • D23 Boundary Type-Coupling — Cross-context type coupling could not be assessed — this codebase's bounded contexts are neither declared nor inferable.
  • D25 ADR Conformance — no ADRs to check
  • D27 Navigability — D27 counts a call into the standard library or a dependency as unresolved for this repository's language (.java), so too few call sites counted as resolved to assess navigability. Not scored: this is a gap in the analyzer, not a verdict about this repository.
  • D32 Data Compliance (PII/GDPR) — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.
  • D34 Knowledge Freshness — knowledge concentrated in recent work — freshness signal contradicted by repo activity
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D39 IL Efficiency — IL not measured — the analyzer's build of the target did not succeed
  • D42 Runtime Threat Enforcement — The repository ships application workloads but no cluster-governance resources (CRDs, admission webhooks, or a committed policy engine). Runtime threat-detection (Falco/Tetragon) and admission control (Kyverno/OPA-Gatekeeper/PodSecurity) are cluster-OPERATOR controls owned by the platform, not shipped by an application repo/chart — nothing for this repo to assess.
  • D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
  • D8 Code Coverage — Coverage not measured — .NET and JavaScript/TypeScript suite
  • DM1 Aggregate boundaries — no aggregates detected — aggregate-boundary check not applicable
  • DM2 Strongly-typed ids — no id-bearing domain types detected — strongly-typed-id adoption not assessable
  • DM3 Integration-event coupling — no integration events detected — coupling check not applicable
  • DM4 Rich vs anemic model — no data-bearing entities detected — rich-vs-anemic model not assessable
  • ED1 Event-Driven — not scored — this repository shows only 1 of the 3 signals this lens looks for (2 event handler(s))
  • ED5 Idempotency — Not assessed, and this one is on us: 2 command handler(s) or message consumer(s) were found here, but this check does not yet recognise persistence writes in this repository's language. Idempotency was neither confirmed nor ruled out — this is a limit of the analyzer, not a finding about your code.
  • ES1 Event Sourcing — not scored — this repository shows only 1 of the 3 signals this lens looks for (an Axon event-sourcing framework (@Aggregate/@CommandHandler/@EventSourcingHandler annotations))
  • P12 CI test-gate honesty — Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
  • P7 Outbound HTTP resilience — not applicable — this isn't a service/API/worker
  • P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (JaCoCo XML — `mvn jacoco:report` or the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
  • PF1 Benchmark discipline — Performance is assessed only for perf-relevant repos — a packaged library, one that ships benchmarks, or one already using allocation-aware APIs. This repo isn't one, so the Performance lens is not applicable and is excluded from the score.
  • PF2 Allocation hygiene — Performance is assessed only for perf-relevant repos — a packaged library, one that ships benchmarks, or one already using allocation-aware APIs. This repo isn't one, so the Performance lens is not applicable and is excluded from the score.
  • R11 Import Boundaries — No recognizable feature-sliced/layered src layout — boundary rules not applicable.
  • S1 Web-Security Posture — No web surface detected in the analyzed source — no HTTP API or web-UI project (no controllers/minimal-API endpoints, no Razor/Blazor views) and no web middleware (HTTPS redirection, HSTS, security headers, cookies). Transport security, security headers, secure cookies, CSRF/input-validation and middleware-order controls are therefore N/A here — this is a library/CLI/worker, not a web app. Crypto hygiene was still checked and found nothing to flag. If this codebase becomes web-facing, the dimension reactivates automatically.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 84 finding(s)
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D30 · Dependency Vulnerabilities · High CVE · ×22
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D31 · IaC & Container Security · High IaC · ×11
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
DM6 · Domain ↔ infrastructure boundary · Domain depends on infrastructure · ×9
  • Domain depends on infrastructure: Asset JPPhotoManager/JPPhotoManager.Domain/Entities/Asset.cs:14 — `Asset` (domain layer) names `KeyAttribute` from `System.ComponentModel.DataAnnotations` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it.
  • Domain depends on infrastructure: Asset JPPhotoManager/JPPhotoManager.Domain/Entities/Asset.cs:28 — `Asset` (domain layer) names `NotMappedAttribute` from `System.ComponentModel.DataAnnotations.Schema` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it.
  • Domain depends on infrastructure: Asset JPPhotoManager/JPPhotoManager.Domain/Entities/Asset.cs:31 — `Asset` (domain layer) names `NotMappedAttribute` from `System.ComponentModel.DataAnnotations.Schema` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it.
  • Domain depends on infrastructure: ConvertAssetsDirectoriesDefinition JPPhotoManager/JPPhotoManager.Domain/Entities/ConvertAssetsDirectoriesDefinition.cs:11 — `ConvertAssetsDirectoriesDefinition` (domain layer) names `KeyAttribute` from `System.ComponentModel.DataAnnotations` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it.
  • Domain depends on infrastructure: Folder JPPhotoManager/JPPhotoManager.Domain/Entities/Folder.cs:8 — `Folder` (domain layer) names `KeyAttribute` from `System.ComponentModel.DataAnnotations` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it.
  • Domain depends on infrastructure: Folder JPPhotoManager/JPPhotoManager.Domain/Entities/Folder.cs:12 — `Folder` (domain layer) names `NotMappedAttribute` from `System.ComponentModel.DataAnnotations.Schema` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it.
  • Domain depends on infrastructure: Folder JPPhotoManager/JPPhotoManager.Domain/Entities/Folder.cs:24 — `Folder` (domain layer) names `NotMappedAttribute` from `System.ComponentModel.DataAnnotations.Schema` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it.
  • Domain depends on infrastructure: RecentTargetPath JPPhotoManager/JPPhotoManager.Domain/Entities/RecentTargetPath.cs:7 — `RecentTargetPath` (domain layer) names `KeyAttribute` from `System.ComponentModel.DataAnnotations` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it.
  • Domain depends on infrastructure: SyncAssetsDirectoriesDefinition JPPhotoManager/JPPhotoManager.Domain/Entities/SyncAssetsDirectoriesDefinition.cs:11 — `SyncAssetsDirectoriesDefinition` (domain layer) names `KeyAttribute` from `System.ComponentModel.DataAnnotations` — a persistence type (as an attribute). The domain should own a port and let an infrastructure adapter implement it.
AX1 · Captive dependencies · Captive dependency · ×5
  • Captive dependency: singleton FolderRepository captures scoped AppDbContext JPPhotoManager/JPPhotoManager.Infrastructure/Repositories/FolderRepository.cs:11 — `FolderRepository` is registered as a SINGLETON but its constructor takes `AppDbContext appDbContext`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `AppDbContext` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
  • Captive dependency: singleton AssetRepository captures scoped AppDbContext JPPhotoManager/JPPhotoManager.Infrastructure/Repositories/AssetRepository.cs:28 — `AssetRepository` is registered as a SINGLETON but its constructor takes `AppDbContext appDbContext`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `AppDbContext` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
  • Captive dependency: singleton RecentTargetPathRepository captures scoped AppDbContext JPPhotoManager/JPPhotoManager.Infrastructure/Repositories/RecentTargetPathRepository.cs:11 — `RecentTargetPathRepository` is registered as a SINGLETON but its constructor takes `AppDbContext appDbContext`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `AppDbContext` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
  • Captive dependency: singleton SyncAssetsConfigurationRepository captures scoped AppDbContext JPPhotoManager/JPPhotoManager.Infrastructure/Repositories/SyncAssetsConfigurationRepository.cs:11 — `SyncAssetsConfigurationRepository` is registered as a SINGLETON but its constructor takes `AppDbContext appDbContext`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `AppDbContext` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
  • Captive dependency: singleton ConvertAssetsConfigurationRepository captures scoped AppDbContext JPPhotoManager/JPPhotoManager.Infrastructure/Repositories/ConvertAssetsConfigurationRepository.cs:11 — `ConvertAssetsConfigurationRepository` is registered as a SINGLETON but its constructor takes `AppDbContext appDbContext`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `AppDbContext` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
D17 · Explicit Debt · WriteOnlyPrivateField · ×5
  • WriteOnlyPrivateField JPPhotoManager/JPPhotoManager.Domain/Services/CatalogAssetsService.cs:22 — private string _currentFolderPath — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField JPPhotoManager/JPPhotoManager.Domain/Services/ConvertAssetsService.cs:10 — private IAssetRepository _assetRepository — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField JPPhotoManager/JPPhotoManager.Domain/Services/SyncAssetsService.cs:9 — private IAssetRepository _assetRepository — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField JPPhotoManager/JPPhotoManager.Domain/Services/ConvertAssetsService.cs:14 — private IDirectoryComparer _directoryComparer — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
  • WriteOnlyPrivateField JPPhotoManager/JPPhotoManager.UI/ViewModels/FindDuplicatedAssetsViewModel.cs:13 — private List<List<Asset>> _duplicatedAssets — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
D30 · Dependency Vulnerabilities · Critical CVE · ×3
  • REDACTED
  • REDACTED
  • REDACTED
AX3 · Project dependency cycles · Namespace dependency cycle · ×2
  • Namespace dependency cycle JPPhotoManager/JPPhotoManager.Domain/Entities/Asset.cs:1 — The namespaces JPPhotoManager.Domain ↔ JPPhotoManager.Domain.Entities ↔ JPPhotoManager.Domain.Interfaces.Services depend on each other. The lightest dependency in the cycle is JPPhotoManager.Domain.Entities → JPPhotoManager.Domain.Interfaces.Services (JPPhotoManager.Domain.Entities.Asset → JPPhotoManager.Domain.Interfaces.Services.IStorageService, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
  • Namespace dependency cycle JPPhotoManager/JPPhotoManager.UI/Controls/ThumbnailsUserControl.xaml.cs:6 — The namespaces JPPhotoManager.UI.Controls ↔ JPPhotoManager.UI.Windows depend on each other. The lightest dependency in the cycle is JPPhotoManager.UI.Controls → JPPhotoManager.UI.Windows (JPPhotoManager.UI.Controls.ThumbnailsUserControl → JPPhotoManager.UI.Windows.ThumbnailSelectedEventHandler, 2 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D28 · Secrets (history) · High secret · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
Serious — 431 finding(s)
D31 · IaC & Container Security · Medium IaC · ×191
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • + 166 more in this group — see findings.md.
X2 · Cancellation propagation · Async method without CancellationToken · ×21
  • Async method without CancellationToken: CatalogAssetsAsync JPPhotoManager/JPPhotoManager.Domain/Services/CatalogAssetsService.cs:40 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: ExecuteAsync JPPhotoManager/JPPhotoManager.Domain/Services/ConvertAssetsService.cs:30 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: CheckNewReleaseAsync JPPhotoManager/JPPhotoManager.Domain/Services/NewReleaseNotificationService.cs:21 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: ExecuteAsync JPPhotoManager/JPPhotoManager.Domain/Services/SyncAssetsService.cs:26 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: SyncAssetsAsync JPPhotoManager/JPPhotoManager.Application/Application.cs:122 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: ConvertAssetsAsync JPPhotoManager/JPPhotoManager.Application/Application.cs:136 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: CatalogAssetsAsync JPPhotoManager/JPPhotoManager.Application/Application.cs:138 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: CheckNewReleaseAsyc JPPhotoManager/JPPhotoManager.Application/Application.cs:195 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: GoToFolder JPPhotoManager/JPPhotoManager.UI/Controls/ThumbnailsUserControl.xaml.cs:44 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: LoadAssetsWithPagination JPPhotoManager/JPPhotoManager.UI/Controls/ThumbnailsUserControl.xaml.cs:64 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: GetAssets JPPhotoManager/JPPhotoManager.UI/Controls/ThumbnailsUserControl.xaml.cs:96 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: CatalogAssets JPPhotoManager/JPPhotoManager.UI/ViewModels/ApplicationViewModel.cs:540 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: RunProcessAsync JPPhotoManager/JPPhotoManager.UI/ViewModels/ConvertAssetsViewModel.cs:61 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: RunProcessAsync JPPhotoManager/JPPhotoManager.UI/ViewModels/SyncAssetsViewModel.cs:61 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: RunButton_MouseLeftButtonDown JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs:124 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: RunProcess JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs:188 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Window_Loaded JPPhotoManager/JPPhotoManager.UI/Windows/MainWindow.xaml.cs:59 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: DoBackgroundWork JPPhotoManager/JPPhotoManager.UI/Windows/MainWindow.xaml.cs:474 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: CheckNewRelease JPPhotoManager/JPPhotoManager.UI/Windows/MainWindow.xaml.cs:495 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: RunButton_MouseLeftButtonDown JPPhotoManager/JPPhotoManager.UI/Windows/SyncAssetsWindow.xaml.cs:124 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: RunProcess JPPhotoManager/JPPhotoManager.UI/Windows/SyncAssetsWindow.xaml.cs:188 — No CancellationToken parameter — this work can't be stopped early once started.
D17 · Explicit Debt · TodoComment · ×19
  • TodoComment JPPhotoManager/JPPhotoManager.Common/BitmapHelper.cs:47 — // TODO: If the stream is disposed by a using block, the thumbnail is not shown. Find a way to dispose of the stream. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.Domain/Services/CatalogAssetsService.cs:51 — // TODO: Since the root folders to catalog are combined in the same list — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.Domain/Services/CatalogAssetsService.cs:183 — // TODO: This should be tested in a new test method, in which the non existent folder is explicitly added to the catalog. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.Domain/Services/ConvertAssetsService.cs:89 — // TODO: Could be parametrized. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.Domain/Services/MoveAssetsService.cs:61 — // TODO: IF THE DESTINATION FOLDER IS NEW, THE FOLDER NAVIGATION CONTROL SHOULD DISPLAY IT WHEN THE USER GOES BACK TO THE MAIN WINDOW. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.Domain/Services/MoveAssetsService.cs:77 — // TODO: Instead of just failing, should remove the file from the catalog. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.Domain/Services/MoveAssetsService.cs:111 — // TODO: Extend automated tests to evaluate recent target paths. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.Domain/Services/SyncAssetsService.cs:91 — // TODO: Detect and sync updated assets. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.Infrastructure/Services/UserConfigurationService.cs:204 — // TODO: Validate if some of the root folders are not valid or don't exist any longer. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.UI/App.xaml.cs:29 — // TODO: Add a global exception handler. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.UI/Controls/FolderNavigationControl.xaml.cs:190 — // TODO: THE SETTER DOESNT SEEM TO WORK. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.UI/Controls/FolderNavigationControl.xaml.cs:200 — // TODO: THE SETTER DOESNT SEEM TO WORK. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.UI/Controls/FolderNavigationControl.xaml.cs:204 — // TODO: SHOULD ASK THE USER IF HE WANTS TO SEE HIDDEN FOLDERS. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.UI/Controls/FolderNavigationControl.xaml.cs:241 — // TODO: SHOULD ASK THE USER IF HE WANTS TO SEE HIDDEN FOLDERS. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.UI/ViewModels/FindDuplicatedAssetsViewModel.cs:141 — // TODO: THE COUNTER DISPLAYED AT THE TOP OF THE SCREEN SHOULD BE UPDATED AS WELL BASED ON THE TOTAL OF DUPLICATED SETS WITH AT LEAST 2 VISIBLE ASSETS. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.UI/ViewModels/FindDuplicatedAssetsViewModel.cs:176 — // TODO: SHOULD DISPLAY A MESSAGE. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.UI/Windows/FindDuplicatedAssetsWindow.xaml.cs:47 — // TODO: IN THE LIST BOXES, IF THE FILENAME INCLUDES _ IT IS NOT BEING SHOWN. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.UI/Windows/FindDuplicatedAssetsWindow.xaml.cs:49 — // TODO: IF THE USER IS VIEWING THE FOLDER IN WHICH THE DUPLICATE WAS STORED, THE THUMBNAILS LIST WON'T REFRESH — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment JPPhotoManager/JPPhotoManager.UI/Windows/FolderNavigationWindow.xaml.cs:70 — // TODO: SHOULD VALIDATE IF THE PATH IS VALID. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
R4 · Test Coverage · No test reaches this file · ×19
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/mutation-report.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/a11y-report.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/cyclomatic-complexity.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/bundle-size-report.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/route-coverage-report.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/code-coverage-report.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/dependency-staleness-report.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/secrets-scan-report.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/e2e-run-report.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/sca-report.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/license-compliance-report.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/type-coverage-report.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/run-all-quality-reports.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/scripts/complexity-report.js:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/src/app/app.routes.ts:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/src/app/core/guards/auth.guard.ts:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
  • No test reaches this file JPPhotoManagerWeb/frontend/src/main.ts:1 — No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
D17 · Explicit Debt · CoverageExclusion · ×10
  • CoverageExclusion JPPhotoManager/JPPhotoManager.UI/App.xaml.cs:24 — class App — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion JPPhotoManager/JPPhotoManager.UI/Controls/FolderNavigationControl.xaml.cs:17 — class FolderNavigationControl — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion JPPhotoManager/JPPhotoManager.UI/Controls/ThumbnailsUserControl.xaml.cs:21 — class ThumbnailsUserControl — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion JPPhotoManager/JPPhotoManager.UI/Controls/ViewerUserControl.xaml.cs:17 — class ViewerUserControl — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion JPPhotoManager/JPPhotoManager.UI/Windows/AboutWindow.xaml.cs:13 — class AboutWindow — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs:17 — class ConvertAssetsWindow — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion JPPhotoManager/JPPhotoManager.UI/Windows/FindDuplicatedAssetsWindow.xaml.cs:15 — class DuplicatedAssetsWindow — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion JPPhotoManager/JPPhotoManager.UI/Windows/FolderNavigationWindow.xaml.cs:14 — class FolderNavigationWindow — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion JPPhotoManager/JPPhotoManager.UI/Windows/MainWindow.xaml.cs:29 — class MainWindow — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
  • CoverageExclusion JPPhotoManager/JPPhotoManager.UI/Windows/SyncAssetsWindow.xaml.cs:17 — class SyncAssetsWindow — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×8
  • Duplicated block (9 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/album/GetAlbumSummaryUseCaseImpl.java:26 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/album/GetAlbumSummaryUseCaseImpl.java:26-34 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/album/UpdateAlbumUseCaseImpl.java:30-38 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/album/GetAlbumSummaryUseCaseImpl.java:26` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (9 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/convert/ConvertAssetsUseCaseImpl.java:56 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/convert/ConvertAssetsUseCaseImpl.java:56-64 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/sync/SyncAssetsUseCaseImpl.java:58-66 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: the declarations holding them bind `def` to `ConvertDirectoriesDefinition` in one and `SyncDirectoriesDefinition` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (9 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:139 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:139-147 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java:190-198 — before extracting anything, compare `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java` and `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:139` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/kafka/AssetHashProcessor.java:53 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/kafka/AssetHashProcessor.java:53-61 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/kafka/AssetThumbnailProcessor.java:59-67 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/kafka/AssetHashProcessor.java:53` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs:73 — JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs:73-81 | JPPhotoManager/JPPhotoManager.UI/Windows/SyncAssetsWindow.xaml.cs:73-81 — before extracting anything, compare `JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs` and `JPPhotoManager/JPPhotoManager.UI/Windows/SyncAssetsWindow.xaml.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs:85 — JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs:85-93 | JPPhotoManager/JPPhotoManager.UI/Windows/SyncAssetsWindow.xaml.cs:85-93 — before extracting anything, compare `JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs` and `JPPhotoManager/JPPhotoManager.UI/Windows/SyncAssetsWindow.xaml.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs:97 — JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs:97-105 | JPPhotoManager/JPPhotoManager.UI/Windows/SyncAssetsWindow.xaml.cs:97-105 — before extracting anything, compare `JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs` and `JPPhotoManager/JPPhotoManager.UI/Windows/SyncAssetsWindow.xaml.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/convert/SaveConvertConfigUseCaseImpl.java:20 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/convert/SaveConvertConfigUseCaseImpl.java:20-28 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/sync/SaveSyncConfigUseCaseImpl.java:20-28 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: the declarations holding them bind `definitions` to `List<ConvertDirectoriesDefinition>` in one and `List<SyncDirectoriesDefinition>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D30 · Dependency Vulnerabilities · Medium CVE · ×7
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
PF3 · Async & latency hygiene · Sync-over-async blocking · ×7
  • Sync-over-async blocking JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:111 — `fs.readFileSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
  • Sync-over-async blocking JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:116 — `fs.existsSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
  • Sync-over-async blocking JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:119 — `execSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
  • Sync-over-async blocking JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:121 — `fs.existsSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
  • Sync-over-async blocking JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:143 — `execSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
  • Sync-over-async blocking JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:184 — `fs.mkdirSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
  • Sync-over-async blocking JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:186 — `fs.writeFileSync` in `main` blocks the event loop until it finishes — a blocking call inside async code stalls the event loop — every other request waits for as long as it runs.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×6
  • Duplicated block (7 lines × 2) JPPhotoManager/JPPhotoManager.Domain/Services/CatalogAssetsService.cs:354 — JPPhotoManager/JPPhotoManager.Domain/Services/CatalogAssetsService.cs:354-360 | JPPhotoManager/JPPhotoManager.Domain/Services/ConvertAssetsService.cs:80-86 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManager/JPPhotoManager.Domain/Services/CatalogAssetsService.cs:354` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkAddTagUseCaseImpl.java:52 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkAddTagUseCaseImpl.java:52-58 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkRemoveTagUseCaseImpl.java:56-62 — before extracting anything, compare `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkAddTagUseCaseImpl.java` and `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkRemoveTagUseCaseImpl.java` as WHOLE FILES: 84% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 3 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkAddTagUseCaseImpl.java:52` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:102 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:102-108 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java:175-181 — before extracting anything, compare `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java` and `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:102` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java:174` calls `assetId`, `getAssetId` and `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:101` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (7 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/ConvertController.java:67 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/ConvertController.java:67-73 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/SyncController.java:67-73 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (7 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/dto/request/CreateAlbumRequestDto.java:13 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/dto/request/CreateAlbumRequestDto.java:13-19 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/dto/request/UpdateAlbumRequestDto.java:13-19 — before extracting anything, compare `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/dto/request/CreateAlbumRequestDto.java` and `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/dto/request/UpdateAlbumRequestDto.java` as WHOLE FILES: 93% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/persistence/adapter/ConvertConfigRepositoryImpl.java:29 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/persistence/adapter/ConvertConfigRepositoryImpl.java:29-35 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/persistence/adapter/SyncConfigRepositoryImpl.java:29-35 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `definitions` to `List<ConvertDirectoriesDefinition>` in one and `List<SyncDirectoriesDefinition>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
AX2 · Stateful singletons · Stateful singleton · ×5
  • Stateful singleton: CatalogAssetsService JPPhotoManager/JPPhotoManager.Domain/Services/CatalogAssetsService.cs:11 — `CatalogAssetsService` is a singleton (one shared instance) but mutates instance state outside any lock (_currentFolderPath; e.g. `_currentFolderPath` at line 96).
  • Stateful singleton: Application JPPhotoManager/JPPhotoManager.Application/Application.cs:10 — `Application` is a singleton (one shared instance) but mutates instance state outside any lock (_recentThumbnailsQueue; e.g. `_recentThumbnailsQueue` at line 88).
  • Stateful singleton: MainWindow JPPhotoManager/JPPhotoManager.UI/Windows/MainWindow.xaml.cs:29 — `MainWindow` is a singleton (one shared instance) but mutates instance state outside any lock (_catalogTask; e.g. `_catalogTask` at line 483). This type is a UI view, so it is thread-CONFINED rather than locked: if every one of those mutations is reached only from the UI thread — directly, or marshalled back through the dispatcher — the confinement IS the synchronisation and there is nothing to add (do not take a lock on a view; that is how the UI thread deadlocks). Check the ones that are not: a handler for a background event that mutates before it marshals is a real race.
  • Stateful singleton: ApplicationViewModel JPPhotoManager/JPPhotoManager.UI/ViewModels/ApplicationViewModel.cs:27 — `ApplicationViewModel` is a singleton (one shared instance) but mutates instance state outside any lock (_appMode, _sortCriteria, _viewerZoom, _viewerPosition, _selectedAssets, _currentFolder; e.g. `_appMode` at line 64).
  • Stateful singleton: CatalogAssetItemWriter JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemWriter.java:35 — `CatalogAssetItemWriter` is a singleton (@Bean: the container shares one instance across every request thread) but mutates instance state outside any lock (cachedFolder; e.g. `cachedFolder` in `ensureFolderExists` at line 143).
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×5
  • Duplicated block (5 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/AuthController.java:84 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/AuthController.java:84-88 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/AuthController.java:106-110 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/AuthController.java:84` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (5 lines × 2) JPPhotoManager/JPPhotoManager.Domain/Entities/ConvertAssetsConfiguration.cs:13 — JPPhotoManager/JPPhotoManager.Domain/Entities/ConvertAssetsConfiguration.cs:13-17 | JPPhotoManager/JPPhotoManager.Domain/Entities/SyncAssetsConfiguration.cs:13-17 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (5 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/auth/RevokeSessionUseCaseImpl.java:57 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/auth/RevokeSessionUseCaseImpl.java:57-61 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/user/GetCurrentUserUseCaseImpl.java:20-24 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (5 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/album/DeleteAlbumUseCaseImpl.java:20 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/album/DeleteAlbumUseCaseImpl.java:20-24 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/search/DeleteSearchPresetUseCaseImpl.java:20-24 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (5 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/persistence/adapter/AssetRepositoryImpl.java:89 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/persistence/adapter/AssetRepositoryImpl.java:89-93 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/persistence/adapter/AssetRepositoryImpl.java:105-109 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D17 · Explicit Debt · Dead code · ×4
  • Dead code: HasSameContent JPPhotoManager/JPPhotoManager.Domain/Interfaces/Services/IStorageService.cs:25 — Method HasSameContent — Roslyn's SymbolFinder walked every project the solution loads, including JPPhotoManager.Domain, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: ReadFolders JPPhotoManager/JPPhotoManager.Infrastructure/Repositories/AssetRepository.cs:37 — Method ReadFolders — Roslyn's SymbolFinder walked every project the solution loads, including JPPhotoManager.Infrastructure, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: ReadAssets JPPhotoManager/JPPhotoManager.Infrastructure/Repositories/AssetRepository.cs:49 — Method ReadAssets — Roslyn's SymbolFinder walked every project the solution loads, including JPPhotoManager.Infrastructure, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
  • Dead code: GetFolderById JPPhotoManager/JPPhotoManager.Infrastructure/Repositories/FolderRepository.cs:66 — Method GetFolderById — Roslyn's SymbolFinder walked every project the solution loads, including JPPhotoManager.Infrastructure, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
D3 · God Classes · TooManyMethods · ×4
  • TooManyMethods: GalleryComponent JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:61 — TooManyMethods — 67 methods. The bar is 30 methods; this is 37 over it, 2.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: AssetRepositoryImpl JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/persistence/adapter/AssetRepositoryImpl.java:37 — TooManyMethods — 35 methods. The bar is 30 methods; this is 5 over it, 1.17× the bar. Most of these members implement out.AssetRepository (34 of 35 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
  • TooManyMethods: MainWindow JPPhotoManager/JPPhotoManager.UI/Windows/MainWindow.xaml.cs — TooManyMethods — 248 significant lines (blank, comment-only and punctuation-only lines excluded), 33 methods. The bar is 30 methods; this is 3 over it, 1.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: StorageService JPPhotoManager/JPPhotoManager.Infrastructure/Services/StorageService.cs — TooManyMethods — 95 significant lines (blank, comment-only and punctuation-only lines excluded), 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D36 · Supply-chain Provenance & Signing REDACTED · ×4
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×4
  • Duplicated block (11 lines × 2) JPPhotoManager/JPPhotoManager.Domain/Entities/ConvertAssetsDirectoriesDefinition.cs:8 — JPPhotoManager/JPPhotoManager.Domain/Entities/ConvertAssetsDirectoriesDefinition.cs:8-18 | JPPhotoManager/JPPhotoManager.Domain/Entities/SyncAssetsDirectoriesDefinition.cs:8-18 — before extracting anything, compare `JPPhotoManager/JPPhotoManager.Domain/Entities/ConvertAssetsDirectoriesDefinition.cs` and `JPPhotoManager/JPPhotoManager.Domain/Entities/SyncAssetsDirectoriesDefinition.cs` as WHOLE FILES: 96% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (11 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/AddTagToAssetUseCaseImpl.java:61 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/AddTagToAssetUseCaseImpl.java:61-71 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkAddTagUseCaseImpl.java:68-78 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/AddTagToAssetUseCaseImpl.java:61` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkRemoveTagUseCaseImpl.java:77 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkRemoveTagUseCaseImpl.java:77-87 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/RemoveTagFromAssetUseCaseImpl.java:65-75 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkRemoveTagUseCaseImpl.java:77` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/M3uPlaylistParserServiceAdapter.java:39 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/M3uPlaylistParserServiceAdapter.java:39-49 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/PlsPlaylistParserServiceAdapter.java:54-64 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/M3uPlaylistParserServiceAdapter.java:39` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
R10 · Code Duplication · Duplicated block (11 lines × 2 locations) · ×4
  • Duplicated block (11 lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/core/services/album.service.ts:6 — JPPhotoManagerWeb/frontend/src/app/core/services/album.service.ts:6 · JPPhotoManagerWeb/frontend/src/app/core/services/search-preset.service.ts:6 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
  • Duplicated block (11 lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:238 — JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:238 · JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:430 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
  • Duplicated block (11 lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:441 — JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:441 · JPPhotoManagerWeb/frontend/src/app/features/recycle-bin/recycle-bin.component.ts:53 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
  • Duplicated block (11 lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:949 — JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:949 · JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:966 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
R10 · Code Duplication · Duplicated block (7 lines × 2 locations) · ×4
  • Duplicated block (7 lines × 2 locations) JPPhotoManagerWeb/frontend/scripts/complexity-report.js:69 — JPPhotoManagerWeb/frontend/scripts/complexity-report.js:69 · JPPhotoManagerWeb/frontend/scripts/complexity-report.js:77 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2 locations) JPPhotoManagerWeb/frontend/scripts/dependency-staleness-report.js:100 — JPPhotoManagerWeb/frontend/scripts/dependency-staleness-report.js:100 · JPPhotoManagerWeb/frontend/scripts/sca-report.js:89 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
  • Duplicated block (7 lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:294 — JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:294 · JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:423 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/features/profile/sessions/sessions.component.ts:46 — JPPhotoManagerWeb/frontend/src/app/features/profile/sessions/sessions.component.ts:46 · JPPhotoManagerWeb/frontend/src/app/features/profile/sessions/sessions.component.ts:69 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
D15 · Churn × Complexity Hotspots · Repeated repair · ×3
  • Repeated repair: JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/MoveAssetsUseCaseImpl.java JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/MoveAssetsUseCaseImpl.java:45 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/MoveAssetsUseCaseImpl.java changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 6 (its worst body is MoveAssetsUseCaseImpl.execute at line 45), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Fix transaction gap, upload-retry race, N+1 query, and exception-handling consistency”; “Fix transactional integrity bugs in asset use cases”; “Fix security and data-integrity findings from code review”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-05-17..2026-08-15, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-05-17 18:04:01 -03:00' --until='2026-08-15 18:04:01 -03:00' --full-history --no-merges -- JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/MoveAssetsUseCaseImpl.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/recycle/PurgeAssetsUseCaseImpl.java JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/recycle/PurgeAssetsUseCaseImpl.java:31 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/recycle/PurgeAssetsUseCaseImpl.java changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is PurgeAssetsUseCaseImpl.execute at line 31), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Revert EXIF storage to Postgres JSONB and add Redis thumbnail cache”; “Fix transactional integrity bugs in asset use cases”; “Fix security and data-integrity findings from code review”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-05-17..2026-08-15, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-05-17 18:04:01 -03:00' --until='2026-08-15 18:04:01 -03:00' --full-history --no-merges -- JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/recycle/PurgeAssetsUseCaseImpl.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/RenameAssetsUseCaseImpl.java JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/RenameAssetsUseCaseImpl.java:145 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/RenameAssetsUseCaseImpl.java changed 3 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 10 (its worst body is RenameAssetsUseCaseImpl.checkFolderCollisions at line 145), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Fix rename silently overwriting an uncatalogued file at the destination”; “Fix transactional integrity bugs in asset use cases”; “Fix hexagonal architecture boundary violations in backend”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-05-17..2026-08-15, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-05-17 18:04:01 -03:00' --until='2026-08-15 18:04:01 -03:00' --full-history --no-merges -- JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/RenameAssetsUseCaseImpl.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D6 · Cohesion (LCOM4) · Low cohesion · ×3
  • Low cohesion: StorageServiceAdapter (LCOM4 11) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/StorageServiceAdapter.java:46 — StorageServiceAdapter's methods fall into 11 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 11 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: AppConfig (LCOM4 7) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/config/AppConfig.java:56 — AppConfig's methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: AssetController (LCOM4 7) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/AssetController.java:83 — AssetController's methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
GD1 · Unfinished & placeholder code · Unfinished stub · ×3
  • Unfinished stub — throws NotImplementedException JPPhotoManager/JPPhotoManager.UI/Converters/FileSizeConverter.cs:56 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException JPPhotoManager/JPPhotoManager.UI/Converters/PixelSizeConverter.cs:22 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException JPPhotoManager/JPPhotoManager.UI/Converters/VisibilityConverter.cs:15 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
R10 · Code Duplication · Duplicated block (10 lines × 3 locations) · ×3
  • Duplicated block (10 lines × 3 locations) JPPhotoManagerWeb/frontend/scripts/license-compliance-report.js:95 — JPPhotoManagerWeb/frontend/scripts/license-compliance-report.js:95 · JPPhotoManagerWeb/frontend/scripts/sca-report.js:99 · JPPhotoManagerWeb/frontend/scripts/secrets-scan-report.js:108 — the 3 copies are spread across 3 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
  • Duplicated block (10 lines × 3 locations) JPPhotoManagerWeb/frontend/src/app/features/albums/albums.component.ts:53 — JPPhotoManagerWeb/frontend/src/app/features/albums/albums.component.ts:53 · JPPhotoManagerWeb/frontend/src/app/features/convert/convert.component.ts:50 · JPPhotoManagerWeb/frontend/src/app/features/sync/sync.component.ts:50 — the 3 copies are spread across 3 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
  • Duplicated block (10 lines × 3 locations) JPPhotoManagerWeb/frontend/src/app/features/audio-player/audio-player.component.ts:17 — JPPhotoManagerWeb/frontend/src/app/features/audio-player/audio-player.component.ts:17 · JPPhotoManagerWeb/frontend/src/app/features/gallery/video-player/video-player.component.ts:27 · JPPhotoManagerWeb/frontend/src/app/shared/components/media-fullscreen-overlay/media-fullscreen-overlay.component.ts:27 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete.
R10 · Code Duplication · Duplicated block (6 lines × 2 locations) · ×3
  • Duplicated block (6 lines × 2 locations) JPPhotoManagerWeb/frontend/scripts/bundle-size-report.js:59 — JPPhotoManagerWeb/frontend/scripts/bundle-size-report.js:59 · JPPhotoManagerWeb/frontend/scripts/cyclomatic-complexity.js:22 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
  • Duplicated block (6 lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/core/services/album.service.ts:22 — JPPhotoManagerWeb/frontend/src/app/core/services/album.service.ts:22 · JPPhotoManagerWeb/frontend/src/app/core/services/asset.service.ts:116 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
  • Duplicated block (6 lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:303 — JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:303 · JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:370 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×2
  • Duplicated block (10 lines × 2) JPPhotoManager/JPPhotoManager.Domain/Entities/ConvertAssetsDirectoriesDefinition.cs:40 — JPPhotoManager/JPPhotoManager.Domain/Entities/ConvertAssetsDirectoriesDefinition.cs:40-49 | JPPhotoManager/JPPhotoManager.Domain/Entities/SyncAssetsDirectoriesDefinition.cs:40-49 — before extracting anything, compare `JPPhotoManager/JPPhotoManager.Domain/Entities/ConvertAssetsDirectoriesDefinition.cs` and `JPPhotoManager/JPPhotoManager.Domain/Entities/SyncAssetsDirectoriesDefinition.cs` as WHOLE FILES: 96% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (10 lines × 2) JPPhotoManager/JPPhotoManager.UI/ViewModels/ApplicationViewModel.cs:453 — JPPhotoManager/JPPhotoManager.UI/ViewModels/ApplicationViewModel.cs:453-462 | JPPhotoManager/JPPhotoManager.UI/ViewModels/ApplicationViewModel.cs:470-479 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManager/JPPhotoManager.UI/ViewModels/ApplicationViewModel.cs:453` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×2
  • Duplicated block (8 lines × 3) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java:74 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java:74-81 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java:102-109 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java:121-128 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (8 lines × 3) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/AssetController.java:470 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/AssetController.java:470-477 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/ConvertController.java:83-90 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/SyncController.java:83-90 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×2
  • Duplicated block (14 lines × 2) JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs:56 — JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs:56-69 | JPPhotoManager/JPPhotoManager.UI/Windows/SyncAssetsWindow.xaml.cs:56-69 — before extracting anything, compare `JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs` and `JPPhotoManager/JPPhotoManager.UI/Windows/SyncAssetsWindow.xaml.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (14 lines × 2) JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs:109 — JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs:109-122 | JPPhotoManager/JPPhotoManager.UI/Windows/SyncAssetsWindow.xaml.cs:109-122 — before extracting anything, compare `JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs` and `JPPhotoManager/JPPhotoManager.UI/Windows/SyncAssetsWindow.xaml.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
R10 · Code Duplication · Duplicated block (16 lines × 2 locations) · ×2
  • Duplicated block (16 lines × 2 locations) JPPhotoManagerWeb/frontend/scripts/bundle-size-report.js:122 — JPPhotoManagerWeb/frontend/scripts/bundle-size-report.js:122 · JPPhotoManagerWeb/frontend/scripts/dependency-staleness-report.js:109 — the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
  • Duplicated block (16 lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/features/gallery/bulk-tag-dialog/bulk-tag-dialog.component.ts:89 — JPPhotoManagerWeb/frontend/src/app/features/gallery/bulk-tag-dialog/bulk-tag-dialog.component.ts:89 · JPPhotoManagerWeb/frontend/src/app/features/gallery/bulk-tag-dialog/bulk-tag-dialog.component.ts:109 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (9 lines × 2 locations) · ×2
  • Duplicated block (9 lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/features/albums/album-detail/album-detail.component.ts:65 — JPPhotoManagerWeb/frontend/src/app/features/albums/album-detail/album-detail.component.ts:65 · JPPhotoManagerWeb/frontend/src/app/features/albums/albums.component.ts:69 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
  • Duplicated block (9 lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:821 — JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:821 · JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:831 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
X20 · Mistyped argument guard · Argument guard throws the exception its own condition disproves · ×2
  • Argument guard throws the exception its own condition disproves JPPhotoManager/JPPhotoManager.Domain/Services/MoveAssetsService.cs:34 — The guard on line 32 rejects `assets` and line 34 reports that rejection as `ArgumentNullException` — but the condition's own test `assets.Length == 0` is true of a value that is NOT null: it is satisfied by an EMPTY `assets`, and on that path `assets` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
  • Argument guard throws the exception its own condition disproves JPPhotoManager/JPPhotoManager.Domain/Services/MoveAssetsService.cs:131 — The guard on line 129 rejects `assets` and line 131 reports that rejection as `ArgumentNullException` — but the condition's own test `assets.Length == 0` is true of a value that is NOT null: it is satisfied by an EMPTY `assets`, and on that path `assets` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
D1 · Cyclomatic Complexity · StorageServiceAdapter.getExifMetadata (cyclomatic 32) · ×1
  • StorageServiceAdapter.getExifMetadata (cyclomatic 32) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/StorageServiceAdapter.java:305 — StorageServiceAdapter.getExifMetadata has cyclomatic complexity 32 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SocialMediaCropComponent.getHitArea (cyclomatic 21) · ×1
  • SocialMediaCropComponent.getHitArea (cyclomatic 21) JPPhotoManagerWeb/frontend/src/app/features/gallery/social-media-crop/social-media-crop.component.ts:234 — SocialMediaCropComponent.getHitArea has cyclomatic complexity 21 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · MoveAssetsService.MoveAssets (cyclomatic 17) · ×1
  • MoveAssetsService.MoveAssets (cyclomatic 17) JPPhotoManager/JPPhotoManager.Domain/Services/MoveAssetsService.cs:28 — MoveAssetsService.MoveAssets has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · a11y-report.main (cyclomatic 17) · ×1
  • a11y-report.main (cyclomatic 17) JPPhotoManagerWeb/frontend/scripts/a11y-report.js:83 — a11y-report.main has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MainWindow.Window_KeyDown (cyclomatic 16) · ×1
  • MainWindow.Window_KeyDown (cyclomatic 16) JPPhotoManager/JPPhotoManager.UI/Windows/MainWindow.xaml.cs:78 — MainWindow.Window_KeyDown has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D15 · Churn × Complexity Hotspots · Hotspot · ×1
  • Hotspot: JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/StorageServiceAdapter.java JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/StorageServiceAdapter.java:305 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/StorageServiceAdapter.java changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 32 in StorageServiceAdapter.getExifMetadata at line 305. 1 of those changes was a fix/bug commit, and the other 7 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-05-17..2026-08-15, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-05-17 18:04:01 -03:00' --until='2026-08-15 18:04:01 -03:00' --full-history --no-merges -- JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/StorageServiceAdapter.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D16 · Bus Factor · bus factor 1 · ×1
  • bus factor 1 — one contributor carries this repository — 2 contributor(s) have commits in this repository (automation and bot accounts excluded), but the commits of a single one of them cover most of its history — 84% of the 893 commit(s) sampled — so the number of people who actually carry it is 1. This is not the ambient state of a solo project: there ARE other contributors, and if the one who carries the repository becomes unavailable, the knowledge behind most of its history goes with them. Spread the next changes deliberately — have a second contributor review or pair on them — and write down the parts only one person can currently change.
D2 · Cognitive Complexity · a11y-report.main (cognitive 34) · ×1
  • a11y-report.main (cognitive 34) JPPhotoManagerWeb/frontend/scripts/a11y-report.js:83 — a11y-report.main has cognitive complexity 34 (threshold 15). Drivers by points: if/else 8 (16 pts), loops 5 (12 pts), ternaries 1 (3 pts), boolean chains 2, error handling 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AssetRepository.GetAssets (cognitive 32) · ×1
  • AssetRepository.GetAssets (cognitive 32) JPPhotoManager/JPPhotoManager.Infrastructure/Repositories/AssetRepository.cs:102 — AssetRepository.GetAssets has cognitive complexity 32 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · StorageServiceAdapter.getExifMetadata (cognitive 32) · ×1
  • StorageServiceAdapter.getExifMetadata (cognitive 32) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/StorageServiceAdapter.java:305 — StorageServiceAdapter.getExifMetadata has cognitive complexity 32 (threshold 15). Drivers by points: if/else 16 (17 pts), error handling 13, boolean chains 1, loops 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · SyncAssetsService.Execute (cognitive 29) · ×1
  • SyncAssetsService.Execute (cognitive 29) JPPhotoManager/JPPhotoManager.Domain/Services/SyncAssetsService.cs:47 — SyncAssetsService.Execute has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConvertAssetsService.Execute (cognitive 27) · ×1
  • ConvertAssetsService.Execute (cognitive 27) JPPhotoManager/JPPhotoManager.Domain/Services/ConvertAssetsService.cs:51 — ConvertAssetsService.Execute has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MoveAssetsService.MoveAssets (cognitive 26) · ×1
  • MoveAssetsService.MoveAssets (cognitive 26) JPPhotoManager/JPPhotoManager.Domain/Services/MoveAssetsService.cs:28 — MoveAssetsService.MoveAssets has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ApplicationViewModel.NotifyCatalogChange (cognitive 17) · ×1
  • ApplicationViewModel.NotifyCatalogChange (cognitive 17) JPPhotoManager/JPPhotoManager.UI/ViewModels/ApplicationViewModel.cs:446 — ApplicationViewModel.NotifyCatalogChange has cognitive complexity 17 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · MainWindow.MoveAssets (cognitive 17) · ×1
  • MainWindow.MoveAssets (cognitive 17) JPPhotoManager/JPPhotoManager.UI/Windows/MainWindow.xaml.cs:340 — MainWindow.MoveAssets has cognitive complexity 17 (threshold 15). Most of this is not in the body itself: 3 of the 17 points are its own statements and the rest belongs to one function literal inside it that branches (line 355). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
D2 · Cognitive Complexity · RenameAssetsUseCaseImpl.checkFolderCollisions (cognitive 16) · ×1
  • RenameAssetsUseCaseImpl.checkFolderCollisions (cognitive 16) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/RenameAssetsUseCaseImpl.java:145 — RenameAssetsUseCaseImpl.checkFolderCollisions has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (8 pts), loops 4 (6 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D3 · God Classes · ClassTooLong · ×1
  • ClassTooLong: GalleryComponent JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:61 — ClassTooLong — 647 significant lines (blank, comment-only and punctuation-only lines excluded), 67 methods. The bar is 400 significant lines; this is 247 over it, 1.62× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D3 · God Classes · FileTooLong · ×1
  • FileTooLong: gallery/gallery.component.ts JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts — FileTooLong — 734 significant lines (blank, comment-only and punctuation-only lines excluded), about 88% of them inside a single declaration: GalleryComponent (92-994). The bar is 500 significant lines; this is 234 over it, 1.47× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
D30 · Dependency Vulnerabilities · Medium vulnerability · ×1
  • REDACTED
D35 · Change Coupling · Change coupling · ×1
  • Change coupling: AssetController.java ↔ asset.service.ts JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/AssetController.java:1 — `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/controller/AssetController.java` and `JPPhotoManagerWeb/frontend/src/app/core/services/asset.service.ts` change together 80% of the time (8 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) and are written in DIFFERENT LANGUAGES, so no import can join them and they cannot be co-located into one unit — they compile and ship as separate artifacts. What binds them is a CONTRACT across that boundary — an event or message name, a route, a serialised shape — that each side currently spells out on its own, which is exactly why a change to one drags the other. Declare that contract once where both sides read it (a shared schema, a generated constants file, an interface-definition file) so a change on one side fails the other's build instead of drifting silently; where the surface is too small to be worth that, name the counterpart in a comment on both sides so the next reader finds it. There is nothing here to merge. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `a9e6895d` Remove pre-commit hook and fix Cypress Angular 19 lifecycle issue; `e40eeddd` Implement batch-rename feature (#17); `afd050f7` Add timeline view to gallery — run `git show` on any of them.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Near-duplicate member family (4 members, 15 shared lines) · ×1
  • Near-duplicate member family (4 members, 15 shared lines) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/AddTagToAssetUseCaseImpl.java:58 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/AddTagToAssetUseCaseImpl.java:58-74 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkAddTagUseCaseImpl.java:65-81 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkRemoveTagUseCaseImpl.java:74-90 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/RemoveTagFromAssetUseCaseImpl.java:62-78 — These 4 members are variants of one another: a block of 15 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (4 members, 50+ identical tokens) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:149 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:149-161 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:163-175 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java:200-212 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java:214-226 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Duplicated block (26–27 lines × 2) · ×1
  • Duplicated block (26–27 lines × 2) JPPhotoManager/JPPhotoManager.UI/Controls/FolderNavigationControl.xaml.cs:49 — JPPhotoManager/JPPhotoManager.UI/Controls/FolderNavigationControl.xaml.cs:49-75 | JPPhotoManager/JPPhotoManager.UI/Controls/FolderNavigationControl.xaml.cs:84-109 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManager/JPPhotoManager.UI/Controls/FolderNavigationControl.xaml.cs:49` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `e` to `FolderAddedEventArgs` in one and `FolderRemovedEventArgs` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (27 lines × 2) · ×1
  • Duplicated block (27 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/kafka/KafkaProgressListener.java:75 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/kafka/KafkaProgressListener.java:75-101 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/kafka/KafkaProgressListener.java:106-132 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `SyncProgressMessage` in one and `ConvertProgressMessage` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (20 lines × 2) · ×1
  • Duplicated block (20 lines × 2) JPPhotoManager/JPPhotoManager.Domain/Services/ConvertAssetsService.cs:130 — JPPhotoManager/JPPhotoManager.Domain/Services/ConvertAssetsService.cs:130-149 | JPPhotoManager/JPPhotoManager.Domain/Services/SyncAssetsService.cs:127-146 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManager/JPPhotoManager.Domain/Services/ConvertAssetsService.cs:130` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×1
  • Duplicated block (13 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/CropAssetUseCaseImpl.java:108 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/CropAssetUseCaseImpl.java:108-120 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/StorageServiceAdapter.java:219-231 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/StorageServiceAdapter.java:219` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (12 lines × 3) · ×1
  • Duplicated block (12 lines × 3) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:117 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:117-128 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/kafka/AssetExifProcessor.java:54-65 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java:152-163 — before extracting anything, compare `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java` and `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (11–12 lines × 2) · ×1
  • Duplicated block (11–12 lines × 2) JPPhotoManager/JPPhotoManager.Infrastructure/AppDbContext.cs:32 — JPPhotoManager/JPPhotoManager.Infrastructure/AppDbContext.cs:32-42 | JPPhotoManager/JPPhotoManager.UI/App.xaml.cs:69-80 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManager/JPPhotoManager.Infrastructure/AppDbContext.cs:32` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 4) · ×1
  • Duplicated block (9 lines × 4) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/AddTagToAssetUseCaseImpl.java:66 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/AddTagToAssetUseCaseImpl.java:66-74 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkAddTagUseCaseImpl.java:73-81 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkRemoveTagUseCaseImpl.java:82-90 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/RemoveTagFromAssetUseCaseImpl.java:70-78 — before extracting anything, compare `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkAddTagUseCaseImpl.java` and `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkRemoveTagUseCaseImpl.java` as WHOLE FILES: 84% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 3 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/AddTagToAssetUseCaseImpl.java:66` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7 lines × 4) · ×1
  • Duplicated block (7 lines × 4) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:155 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:155-161 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:169-175 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java:206-212 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java:220-226 — before extracting anything, compare `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java` and `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/service/CatalogFolderServiceAdapter.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:155` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×1
  • Duplicated block (7 lines × 3) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:55 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:55-61 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:73-79 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemProcessor.java:86-92 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
D4 · Code Duplication · Duplicated block (6 lines × 4) · ×1
  • Duplicated block (6 lines × 4) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/AddTagToAssetUseCaseImpl.java:59 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/AddTagToAssetUseCaseImpl.java:59-64 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkAddTagUseCaseImpl.java:66-71 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkRemoveTagUseCaseImpl.java:75-80 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/RemoveTagFromAssetUseCaseImpl.java:63-68 — before extracting anything, compare `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkAddTagUseCaseImpl.java` and `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/BulkRemoveTagUseCaseImpl.java` as WHOLE FILES: 84% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 3 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/tag/AddTagToAssetUseCaseImpl.java:59` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×1
  • Duplicated block (15 lines × 2) JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs:126 — JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs:126-140 | JPPhotoManager/JPPhotoManager.UI/Windows/SyncAssetsWindow.xaml.cs:126-140 — before extracting anything, compare `JPPhotoManager/JPPhotoManager.UI/Windows/ConvertAssetsWindow.xaml.cs` and `JPPhotoManager/JPPhotoManager.UI/Windows/SyncAssetsWindow.xaml.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×1
  • Duplicated block (6 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/persistence/mapper/AlbumEntityMapper.java:26 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/persistence/mapper/AlbumEntityMapper.java:26-31 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/persistence/mapper/SearchPresetEntityMapper.java:22-27 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/persistence/mapper/AlbumEntityMapper.java:26` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×1
  • Duplicated block (8 lines × 2) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/album/AddAssetsToAlbumUseCaseImpl.java:22 — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/album/AddAssetsToAlbumUseCaseImpl.java:22-29 | JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/album/RemoveAssetsFromAlbumUseCaseImpl.java:22-29 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
DM10 · One transaction, one aggregate · One operation mutates 2 aggregates · ×1
  • One operation mutates 2 aggregates: MoveAssetsUseCaseImpl.execute JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/application/usecase/asset/MoveAssetsUseCaseImpl.java:45 — `MoveAssetsUseCaseImpl.execute` saves `folderRepository`, `assetRepository` in a single operation. Each is its own consistency boundary, so committing them together makes the second's invariants depend on the first's transaction, holds a lock across both for the whole operation, and means the pair can no longer be separated — into different services, or different databases. Mutate one aggregate here and let the others follow from a domain event.
DM10 · One transaction, one aggregate · One operation mutates 3 aggregates · ×1
  • One operation mutates 3 aggregates: CatalogAssetItemWriter.write JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/batch/CatalogAssetItemWriter.java:76 — `CatalogAssetItemWriter.write` saves `Asset`, `AssetExif`, `AssetAudio` in a single operation. Each is its own consistency boundary, so committing them together makes the second's invariants depend on the first's transaction, holds a lock across both for the whole operation, and means the pair can no longer be separated — into different services, or different databases. Mutate one aggregate here and let the others follow from a domain event.
DM11 · Constructible invalid state · Constructible in an invalid state · ×1
  • Constructible in an invalid state: RecentTargetPathEntity JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/persistence/entity/RecentTargetPathEntity.java:20 — `RecentTargetPathEntity`'s public constructor takes `path` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `RecentTargetPathEntity` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
DM12 · Ambient inputs in the domain · Domain type reads the wall clock · ×1
  • Domain type reads the wall clock: CatalogAssetsService JPPhotoManager/JPPhotoManager.Domain/Services/CatalogAssetsService.cs:345 — `CatalogAssetsService` reads `DateTime.Now` inside `CreateAsset`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.
R10 · Code Duplication · Duplication concentrated across 7 sibling directories (5 clone groups) · ×1
  • Duplication concentrated across 7 sibling directories (5 clone groups) JPPhotoManagerWeb/frontend/src/app/features/convert/convert.component.ts:1 — 5 duplicated blocks under JPPhotoManagerWeb/frontend/src/app/features/ have copies in at least two of the sibling directories admin, albums, convert, gallery, profile, recycle-bin (+1 more sibling(s) not listed) — 3 of them are reported below, and 2 are counted here but not reported individually: those copies match on shape but no longer clear R10's bar for an individually reported row — either they kept neither their own names nor their values, or what was copied is too small to stand on its own (it reports near-exact duplication only, and only of substantial extent). What this row states is the concentration, which the detector measured over all 5 and which does not depend on how exactly each block's copies still match. That concentration is one structural fact, not 5 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 5 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
R10 · Code Duplication · Wholesale file copy (77 identical lines × 2 files) · ×1
  • Wholesale file copy (77 identical lines × 2 files) JPPhotoManagerWeb/frontend/src/app/features/convert/convert.component.ts:1 — JPPhotoManagerWeb/frontend/src/app/features/convert/convert.component.ts:1 · JPPhotoManagerWeb/frontend/src/app/features/sync/sync.component.ts:1 — these 2 files are line-for-line copies of one another — 77 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done.
R10 · Code Duplication · Duplicated block with local edits (44 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (44 matched lines × 2 locations) JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:21 — JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:21 · JPPhotoManagerWeb/frontend/scripts/type-coverage-report.js:19 — the two spans are one implementation copied and then locally edited — 296 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (28 lines × 2 locations) · ×1
  • Duplicated block (28 lines × 2 locations) JPPhotoManagerWeb/frontend/scripts/license-compliance-report.js:21 — JPPhotoManagerWeb/frontend/scripts/license-compliance-report.js:21 · JPPhotoManagerWeb/frontend/scripts/sca-report.js:22 — the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it.
R10 · Code Duplication · Duplicated block (22 lines × 4 locations) · ×1
  • Duplicated block (22 lines × 4 locations) JPPhotoManagerWeb/frontend/scripts/code-coverage-report.js:71 — JPPhotoManagerWeb/frontend/scripts/code-coverage-report.js:71 · JPPhotoManagerWeb/frontend/scripts/complexity-report.js:39 · JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:53 · JPPhotoManagerWeb/frontend/scripts/type-coverage-report.js:46 — the 4 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. There is one copy in each of 4 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete.
R10 · Code Duplication · Duplicated block with local edits (19 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (19 matched lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/features/gallery/exif-panel/exif-panel.component.ts:59 — JPPhotoManagerWeb/frontend/src/app/features/gallery/exif-panel/exif-panel.component.ts:59 · JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:159 — the two spans are one implementation copied and then locally edited — 118 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block with local edits (17 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (17 matched lines × 2 locations) JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:139 — JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:139 · JPPhotoManagerWeb/frontend/scripts/mutation-report.js:119 — the two spans are one implementation copied and then locally edited — 116 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (16 lines × 6 locations) · ×1
  • Duplicated block (16 lines × 6 locations) JPPhotoManagerWeb/frontend/scripts/a11y-report.js:95 — JPPhotoManagerWeb/frontend/scripts/a11y-report.js:95 · JPPhotoManagerWeb/frontend/scripts/code-coverage-report.js:77 · JPPhotoManagerWeb/frontend/scripts/complexity-report.js:45 · JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:59 · +2 more site(s) not listed — the 6 copies are spread across 6 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (15 lines × 5 locations) · ×1
  • Duplicated block (15 lines × 5 locations) JPPhotoManagerWeb/frontend/scripts/complexity-report.js:49 — JPPhotoManagerWeb/frontend/scripts/complexity-report.js:49 · JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:63 · JPPhotoManagerWeb/frontend/scripts/license-compliance-report.js:68 · JPPhotoManagerWeb/frontend/scripts/sca-report.js:71 · +1 more site(s) not listed — the 5 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. There is one copy in each of 5 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape — one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values — and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete.
R10 · Code Duplication · Duplicated block (14 lines × 2 locations) · ×1
  • Duplicated block (14 lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/core/services/convert.service.ts:6 — JPPhotoManagerWeb/frontend/src/app/core/services/convert.service.ts:6 · JPPhotoManagerWeb/frontend/src/app/core/services/sync.service.ts:6 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
R10 · Code Duplication · Duplicated block (13 lines × 2 locations) · ×1
  • Duplicated block (13 lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/features/gallery/exif-panel/exif-panel.component.ts:116 — JPPhotoManagerWeb/frontend/src/app/features/gallery/exif-panel/exif-panel.component.ts:116 · JPPhotoManagerWeb/frontend/src/app/features/gallery/exif-panel/exif-panel.component.ts:130 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
R10 · Code Duplication · Duplicated block (12 lines × 2 locations) · ×1
  • Duplicated block (12 lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/features/audio-player/audio-player.component.ts:15 — JPPhotoManagerWeb/frontend/src/app/features/audio-player/audio-player.component.ts:15 · JPPhotoManagerWeb/frontend/src/app/shared/components/media-fullscreen-overlay/media-fullscreen-overlay.component.ts:25 — the 2 copies are spread across 2 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
R10 · Code Duplication · Duplicated block with local edits (10 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (10 matched lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/core/services/asset.service.ts:20 — JPPhotoManagerWeb/frontend/src/app/core/services/asset.service.ts:20 · JPPhotoManagerWeb/frontend/src/app/core/services/asset.service.ts:35 — the two spans are one implementation copied and then locally edited — 85 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (10 lines × 2 locations) · ×1
  • Duplicated block (10 lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/features/recycle-bin/recycle-bin.component.ts:69 — JPPhotoManagerWeb/frontend/src/app/features/recycle-bin/recycle-bin.component.ts:69 · JPPhotoManagerWeb/frontend/src/app/features/recycle-bin/recycle-bin.component.ts:81 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (9 lines × 3 locations) · ×1
  • Duplicated block (9 lines × 3 locations) JPPhotoManagerWeb/frontend/src/app/core/services/convert.service.ts:1 — JPPhotoManagerWeb/frontend/src/app/core/services/convert.service.ts:1 · JPPhotoManagerWeb/frontend/src/app/core/services/recycle-bin.service.ts:2 · JPPhotoManagerWeb/frontend/src/app/core/services/sync.service.ts:1 — the 3 copies are spread across 3 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
R10 · Code Duplication · Duplicated block with local edits (9 matched lines × 2 locations) · ×1
  • Duplicated block with local edits (9 matched lines × 2 locations) JPPhotoManagerWeb/frontend/src/app/core/services/media-player.service.ts:88 — JPPhotoManagerWeb/frontend/src/app/core/services/media-player.service.ts:88 · JPPhotoManagerWeb/frontend/src/app/core/services/media-player.service.ts:161 — the two spans are one implementation copied and then locally edited — 59 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication · Duplicated block (8 lines × 2 locations) · ×1
  • Duplicated block (8 lines × 2 locations) JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:110 — JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:110 · JPPhotoManagerWeb/frontend/scripts/dead-code-report.js:119 — all 2 copies are in the same file, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (8 lines × 5 locations) · ×1
  • Duplicated block (8 lines × 5 locations) JPPhotoManagerWeb/frontend/scripts/dependency-staleness-report.js:80 — JPPhotoManagerWeb/frontend/scripts/dependency-staleness-report.js:80 · JPPhotoManagerWeb/frontend/scripts/e2e-run-report.js:62 · JPPhotoManagerWeb/frontend/scripts/license-compliance-report.js:66 · JPPhotoManagerWeb/frontend/scripts/route-coverage-report.js:94 · +1 more site(s) not listed — the 5 copies are spread across 5 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (7 lines × 3 locations) · ×1
  • Duplicated block (7 lines × 3 locations) JPPhotoManagerWeb/frontend/scripts/a11y-report.js:166 — JPPhotoManagerWeb/frontend/scripts/a11y-report.js:166 · JPPhotoManagerWeb/frontend/scripts/bundle-size-report.js:131 · JPPhotoManagerWeb/frontend/scripts/dependency-staleness-report.js:118 — the 3 copies are spread across 3 files, and the CITED SPAN is not a self-contained block — it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead — the whole function, component or branch these lines sit in — and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported.
R10 · Code Duplication · Duplicated block (5 lines × 2 locations) · ×1
  • Duplicated block (5 lines × 2 locations) JPPhotoManagerWeb/frontend/scripts/bundle-size-report.js:24 — JPPhotoManagerWeb/frontend/scripts/bundle-size-report.js:24 · JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:111 — the 2 copies are spread across 2 files, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct — and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal's entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins — a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are.
R2 · Cyclomatic Complexity · Complex function getHitArea (cyclomatic 21, cognitive 10) · ×1
  • Complex function getHitArea (cyclomatic 21, cognitive 10) JPPhotoManagerWeb/frontend/src/app/features/gallery/social-media-crop/social-media-crop.component.ts:234 — getHitArea has cyclomatic complexity 21 and cognitive complexity 10; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function main (cyclomatic 17, cognitive 39) · ×1
  • Complex function main (cyclomatic 17, cognitive 39) JPPhotoManagerWeb/frontend/scripts/a11y-report.js:83 — main has cyclomatic complexity 17 and cognitive complexity 39; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function resizeFromCorner (cyclomatic 13, cognitive 12) · ×1
  • Complex function resizeFromCorner (cyclomatic 13, cognitive 12) JPPhotoManagerWeb/frontend/src/app/features/gallery/social-media-crop/social-media-crop.component.ts:190 — resizeFromCorner has cyclomatic complexity 13 and cognitive complexity 12; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function functionName (cyclomatic 12, cognitive 15) · ×1
  • Complex function functionName (cyclomatic 12, cognitive 15) JPPhotoManagerWeb/frontend/scripts/cyclomatic-complexity.js:49 — functionName has cyclomatic complexity 12 and cognitive complexity 15; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function main (cyclomatic 12, cognitive 15) · ×1
  • Complex function main (cyclomatic 12, cognitive 15) JPPhotoManagerWeb/frontend/scripts/lighthouse-report.mjs:109 — main has cyclomatic complexity 12 and cognitive complexity 15; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R2 · Cyclomatic Complexity · Complex function createAlbum (cyclomatic 11, cognitive 13) · ×1
  • Complex function createAlbum (cyclomatic 11, cognitive 13) JPPhotoManagerWeb/frontend/src/app/features/albums/albums.component.ts:78 — createAlbum has cyclomatic complexity 11 and cognitive complexity 13; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
R3 · Large Files · JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts · ×1
  • JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts: 907 lines of code JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts:1 — JPPhotoManagerWeb/frontend/src/app/features/gallery/gallery.component.ts has 907 significant lines (blank lines excluded), over the 400-line bar, and contains logic — a file this long is usually several responsibilities in one module.
R5 · Dependency Freshness · Dependency Freshness · ×1
  • Dependency Freshness — 38 outdated package(s); JS/npm CVEs scored in D30
R7 · Dead Code · Dead file (~8 LoC) · ×1
  • Dead file (~8 LoC) JPPhotoManagerWeb/frontend/src/app/core/models/audio-metadata.model.ts — no import path from any entry point (39 application, 21 tooling, 73 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
R7 · Dead Code · Dead file (~3 LoC) · ×1
  • Dead file (~3 LoC) JPPhotoManagerWeb/frontend/src/app/core/models/tag.model.ts — no import path from any entry point (39 application, 21 tooling, 73 test roots considered), and no other file in the scanned tree imports it — nothing in-repo names this module at all, which is the strongest form of this claim the import graph can make
SC1 · Supply-chain hygiene · NuGet dependencies are not locked · ×1
  • NuGet dependencies are not locked — No packages.lock.json and no central package management — restores aren't reproducible or pinned (SSDF PW.4.4). Enable <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> (commit the lockfile) or adopt Directory.Packages.props. Advisory — never scored.
Minor — 92 finding(s)
D31 · IaC & Container Security · Low IaC · ×42
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • + 17 more in this group — see findings.md.
M4 · Documentation accuracy · README/code drift · ×17
  • README/code drift JPPhotoManagerWeb/README.md:38 — JPPhotoManagerWeb/README.md runs `bash scripts/complexity-report.sh`, but `scripts/complexity-report.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift JPPhotoManagerWeb/README.md:39 — JPPhotoManagerWeb/README.md runs `bash scripts/dead-code-report.sh`, but `scripts/dead-code-report.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift JPPhotoManagerWeb/README.md:41 — JPPhotoManagerWeb/README.md runs `bash scripts/auth-coverage-report.sh`, but `scripts/auth-coverage-report.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift JPPhotoManagerWeb/README.md:44 — JPPhotoManagerWeb/README.md runs `bash scripts/coverage-report.sh`, but `scripts/coverage-report.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift JPPhotoManagerWeb/README.md:48 — JPPhotoManagerWeb/README.md runs `bash scripts/mutation-report.sh`, but `scripts/mutation-report.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift JPPhotoManagerWeb/README.md:50 — JPPhotoManagerWeb/README.md runs `bash scripts/license-report.sh`, but `scripts/license-report.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift JPPhotoManagerWeb/README.md:51 — JPPhotoManagerWeb/README.md runs `bash scripts/sca-report.sh`, but `scripts/sca-report.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift JPPhotoManagerWeb/README.md:57 — JPPhotoManagerWeb/README.md names `SKILL.md`, but no file or folder `SKILL.md` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift docs/windows-dev-setup.md:164 — docs/windows-dev-setup.md names Node.js 24, but the repository declares pinned 22. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift JPPhotoManagerWeb/docs/authentication.md:176 — JPPhotoManagerWeb/docs/authentication.md names `.env`, but no file or folder `.env` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift JPPhotoManagerWeb/docs/authentication.md:222 — JPPhotoManagerWeb/docs/authentication.md documents the environment variable `HOST_IMAGE_DIR_N`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift JPPhotoManagerWeb/docs/backend.md:307 — JPPhotoManagerWeb/docs/backend.md names `application/service/PasswordValidationService`, but no file or folder `application/service/PasswordValidationService` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift JPPhotoManagerWeb/docs/docker-compose.md:20 — JPPhotoManagerWeb/docs/docker-compose.md names `.env`, but no file or folder `.env` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift JPPhotoManagerWeb/docs/docker-compose.md:25 — JPPhotoManagerWeb/docs/docker-compose.md documents the environment variable `HOST_IMAGE_DIR_N`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift JPPhotoManagerWeb/docs/docker-compose.md:85 — JPPhotoManagerWeb/docs/docker-compose.md names `grafana/grafana`, but no file or folder `grafana/grafana` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift JPPhotoManagerWeb/docs/kubernetes.md:13 — JPPhotoManagerWeb/docs/kubernetes.md names `k8s/catalog-volumes.yaml`, but no file or folder `k8s/catalog-volumes.yaml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift JPPhotoManagerWeb/docs/kubernetes.md:46 — JPPhotoManagerWeb/docs/kubernetes.md runs `./scripts/build-and-deploy-k8s.sh`, but `scripts/build-and-deploy-k8s.sh` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
D41 · Kernel & Syscall Confinement · No seccomp profile · ×8
  • No seccomp profile REDACTED:50 — The workload runs a container with no seccomp profile in force (neither RuntimeDefault nor a Localhost profile, on the container or the pod), so Kubernetes runs it Unconfined. Seccomp blocks the syscalls a container never needs, shrinking the kernel attack surface a container escape would use.
  • No seccomp profile REDACTED:24 — The workload runs a container with no seccomp profile in force (neither RuntimeDefault nor a Localhost profile, on the container or the pod), so Kubernetes runs it Unconfined. Seccomp blocks the syscalls a container never needs, shrinking the kernel attack surface a container escape would use.
  • No seccomp profile REDACTED:34 — The workload runs a container with no seccomp profile in force (neither RuntimeDefault nor a Localhost profile, on the container or the pod), so Kubernetes runs it Unconfined. Seccomp blocks the syscalls a container never needs, shrinking the kernel attack surface a container escape would use.
  • No seccomp profile REDACTED:39 — The workload runs a container with no seccomp profile in force (neither RuntimeDefault nor a Localhost profile, on the container or the pod), so Kubernetes runs it Unconfined. Seccomp blocks the syscalls a container never needs, shrinking the kernel attack surface a container escape would use.
  • No seccomp profile REDACTED:22 — The workload runs a container with no seccomp profile in force (neither RuntimeDefault nor a Localhost profile, on the container or the pod), so Kubernetes runs it Unconfined. Seccomp blocks the syscalls a container never needs, shrinking the kernel attack surface a container escape would use.
  • No seccomp profile REDACTED:23 — The workload runs a container with no seccomp profile in force (neither RuntimeDefault nor a Localhost profile, on the container or the pod), so Kubernetes runs it Unconfined. Seccomp blocks the syscalls a container never needs, shrinking the kernel attack surface a container escape would use.
  • No seccomp profile REDACTED:20 — The workload runs a container with no seccomp profile in force (neither RuntimeDefault nor a Localhost profile, on the container or the pod), so Kubernetes runs it Unconfined. Seccomp blocks the syscalls a container never needs, shrinking the kernel attack surface a container escape would use.
  • No seccomp profile REDACTED:20 — The workload runs a container with no seccomp profile in force (neither RuntimeDefault nor a Localhost profile, on the container or the pod), so Kubernetes runs it Unconfined. Seccomp blocks the syscalls a container never needs, shrinking the kernel attack surface a container escape would use.
AX6 · Interface segregation · Fat interface · ×5
  • Fat interface: IStorageService (29 members) JPPhotoManager/JPPhotoManager.Domain/Interfaces/Services/IStorageService.cs:7 — `IStorageService` declares 29 members: `GetParentDirectory`, `GetSubDirectories`, `GetRecursiveSubDirectories`, `ResolveDataDirectory`, `CreateDirectory`, `ReadObjectFromJsonFile`, `WriteObjectToJsonFile`, `DeleteFile`, `GetFileNames`, `GetFileNames`, `GetFileBytes`, `LoadBitmapImage`, `LoadBitmapImage`, `LoadBitmapImage`, `GetExifOrientation`, `GetImageRotation`, `HasSameContent`, `LoadBitmapImage`, `GetJpegBitmapImage`, `GetPngBitmapImage`, `GetDrives`, `FileExists`, `FileExists`, `FolderExists`, `CopyImage`, `MoveImage`, `GetFileInformation`, `InitializeDatabaseDirectory`, `InitializeBinaryFilesDirectory`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 29 declarations carry 24 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 24 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: IApplication (25 members) JPPhotoManager/JPPhotoManager.Application/IApplication.cs:8 — `IApplication` declares 25 members: `GetAssets`, `LoadThumbnail`, `GetSyncAssetsConfiguration`, `SetSyncAssetsConfiguration`, `SyncAssetsAsync`, `GetConvertAssetsConfiguration`, `SetConvertAssetsConfiguration`, `ConvertAssetsAsync`, `CatalogAssetsAsync`, `SetAsWallpaper`, `GetDuplicatedAssets`, `DeleteAssets`, `GetAboutInformation`, `GetDrives`, `GetSubFolders`, `GetInitialFolder`, `GetCatalogCooldownMinutes`, `MoveAssets`, `LoadBitmapImage`, `FileExists`, `GetRecentTargetPaths`, `GetRootCatalogFolders`, `IsAlreadyRunning`, `CheckNewReleaseAsyc`, `ShrinkDatabase`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: AssetRepository (34 abstract methods) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/domain/port/out/AssetRepository.java:18 — `AssetRepository` declares 34 abstract methods: `addTagToAsset`, `completeIfAllStagesFinished`, `count`, `countByCreationMonth`, `countByExtension`, `countByRating`, `countDeleted`, `countDuplicates`, `countTotal`, `deleteById`, `existsById`, `findAll`, `findAllById`, `findAllDeleted`, `findAllFilteredSortedByDateDesc`, `findByFileName`, `findByFolder`, `findByFolderAndFileName`, `findById`, `findDeleted`, `findDeletedBefore`, `findFiltered`, `findNotDeleted`, `findRecentAssets`, `findTopFoldersByAssetCount`, `hasTag`, `removeTagFromAsset`, `save`, `sumFileSize`, `sumFileSizeByFolder`, `updateExifCompletedAt`, `updateHash`, `updateProcessingStatus`, `updateThumbnail`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: StoragePort (20 abstract methods) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/domain/port/out/StoragePort.java:10 — `StoragePort` declares 20 abstract methods: `computeHash`, `convertPngToJpeg`, `copyFile`, `createDirectory`, `deleteFile`, `directoryExists`, `fileExists`, `generateThumbnail`, `getExifMetadata`, `getFileCreationDateTime`, `getFileModificationDateTime`, `getFileSize`, `getImageRotation`, `isAudioFile`, `isPlaylistFile`, `isVideoFile`, `listFiles`, `listSubDirectories`, `moveFile`, `readFileBytes`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: JpaAssetRepository (32 abstract methods) JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/persistence/jpa/JpaAssetRepository.java:28 — `JpaAssetRepository` declares 32 abstract methods: `addTagToAsset`, `completeIfAllStagesFinished`, `countByCreationMonth`, `countByDeletedAtIsNotNull`, `countByDeletedAtIsNull`, `countByExtension`, `countByRating`, `countDuplicates`, `deleteByFolderAndFileName`, `existsByFolderAndFileName`, `findAllByIdWithFolder`, `findAllWithFolder`, `findByAlbumId`, `findByDeletedAtBefore`, `findByFileNameNotDeleted`, `findByFolder`, `findByFolderAndFileName`, `findByHashNotDeleted`, `findByIdWithFolder`, `findDeletedOrderByDeletedAtDesc`, `findDuplicateHashes`, `findNotDeleted`, `findRecentAssets`, `findTopFoldersByAssetCount`, `hasTag`, `removeTagFromAsset`, `sumFileSize`, `sumFileSizeByFolder`, `updateExifCompletedAt`, `updateHash`, `updateProcessingStatus`, `updateThumbnail`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
X10 · Duplicated predicate · Duplicated predicate · ×2
  • Duplicated predicate JPPhotoManager/JPPhotoManager.Domain/Entities/ConvertAssetsDirectoriesDefinition.cs:22 — `(IsValidLocalPath(SourceDirectory) || IsValidRemotePath(SourceDirectory)) && (IsValidLocalPath(DestinationDirectory) || IsValidRemotePath(De…` appears character-identically in 2 files — JPPhotoManager/JPPhotoManager.Domain/Entities/ConvertAssetsDirectoriesDefinition.cs, JPPhotoManager/JPPhotoManager.Domain/Entities/SyncAssetsDirectoriesDefinition.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/dto/request/CreateAlbumRequestDto.java:14 — `filterJson == null || filterJson.search() != null || filterJson.dateFrom() != null || filterJson.dateTo() != null || filterJson.minRating() …` appears character-identically in 2 files — JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/dto/request/CreateAlbumRequestDto.java, JPPhotoManagerWeb/backend/src/main/java/com/jpablodrexler/photomanager/infrastructure/web/dto/request/UpdateAlbumRequestDto.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`.
D28 · Secrets (history) · Rotate the exposed credentials · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D40 · Network Egress Confinement · No network policy · ×1
  • No network policy — No Kubernetes NetworkPolicy (or Cilium policy) found. Without one, every pod can talk to every other pod and reach out to the internet by default. Add a default-deny policy and open only the flows you need.
IC1 · Incompleteness & stubs · Disabled test · ×1
  • Disabled test JPPhotoManager/JPPhotoManager.Tests/Integration/ReleaseAvailabilityServiceTests.cs:35 — A test is skipped ("GitHub API integration test") — coverage that looks present but never runs in any gate. If it's an opt-in suite, document how it runs; otherwise re-enable or delete it.
IC1 · Incompleteness & stubs · Commented-out code · ×1
  • Commented-out code JPPhotoManager/JPPhotoManager.UI/Windows/FolderNavigationWindow.xaml.cs:71 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M3 · Folder & project structure · No src/ separation · ×1
  • No src/ separation — Production code isn't grouped under a src/ folder — it's spread across several top-level directories, so there's no one place that says 'this is the product'.
P6 · Release Hygiene · Changelog looks stale/thin · ×1
  • Changelog looks stale/thin — The changelog this check read carries 2 versioned entries, against a bar of 3. Counted as either the distinct `x.y.z` versions it names (a link's target is not counted) or its version-shaped section headings (`## [1.2.0]`, `## V14.x.x`, `## Updates in 8.0.x`), whichever is the larger — so a log sectioned by minor series counts its sections, not its individual patch numbers. Entries recorded somewhere this check does not read — release notes generated at tag time from a generator config it did not recognise, or a log kept outside the repository — are not counted here, and this row is about what is re-findable in the tree rather than about how often you release.
R7 · Dead Code · Unused export 'AlbumAssetIdsRequest' · ×1
  • Unused export 'AlbumAssetIdsRequest' JPPhotoManagerWeb/frontend/src/app/core/models/album.model.ts:41 — Nothing imports this binding — it is safe to review for removal.
R7 · Dead Code · Unused export 'ChartSeries' · ×1
  • Unused export 'ChartSeries' JPPhotoManagerWeb/frontend/src/app/core/models/analytics.model.ts:33 — Nothing imports this binding — it is safe to review for removal.
R7 · Dead Code · Unused export 'RenameAssetsRequest' · ×1
  • Unused export 'RenameAssetsRequest' JPPhotoManagerWeb/frontend/src/app/core/models/asset.model.ts:40 — Nothing imports this binding — it is safe to review for removal.
X2 · Cancellation propagation · Not all async methods take a CancellationToken · ×1
  • Not all async methods take a CancellationToken — Only 0/21 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
X5 · Nullable reference types · Nullable reference types not enabled everywhere · ×1
  • Nullable reference types not enabled everywhere — 4/5 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
X7 · Silent fallback defaults · Silent fallback default in catch · ×1
  • Silent fallback default in catch JPPhotoManagerWeb/frontend/src/app/core/services/auth.service.ts:122 — `getStoredRole` swallows every exception into `return 'VIEWER'` — a data error becomes a silent behavior change with no trail. Log the failure or let it raise. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the handler or in the docstring, and the row stops firing.
Minor — 7 finding(s)
D19 · Documentation Quality · XML-doc coverage · ×5
  • XML-doc coverage: JPPhotoManager.Domain JPPhotoManager/JPPhotoManager.Domain/JPPhotoManager.Domain.csproj — JPPhotoManager.Domain: 1 % XML-doc coverage (1/155).
  • XML-doc coverage: JPPhotoManager.Infrastructure JPPhotoManager/JPPhotoManager.Infrastructure/JPPhotoManager.Infrastructure.csproj — JPPhotoManager.Infrastructure: 1 % XML-doc coverage (1/113).
  • XML-doc coverage: JPPhotoManager.Application JPPhotoManager/JPPhotoManager.Application/JPPhotoManager.Application.csproj — JPPhotoManager.Application: 3 % XML-doc coverage (1/29).
  • XML-doc coverage: JPPhotoManager.UI JPPhotoManager/JPPhotoManager.UI/JPPhotoManager.UI.csproj — JPPhotoManager.UI: 6 % XML-doc coverage (11/177).
  • XML-doc coverage: JPPhotoManager.Common JPPhotoManager/JPPhotoManager.Common/JPPhotoManager.Common.csproj — JPPhotoManager.Common: 0 % XML-doc coverage (0/13).
D10 · Test Quality · Skipped (documented) · ×1
  • Skipped (documented): GetLatestRelease_ReturnReleaseData JPPhotoManager/JPPhotoManager.Tests/Integration/ReleaseAvailabilityServiceTests.cs:35 — Skipped with a documented reason — a deferral, not lazy debt: GitHub API integration test
D5 · Coupling · Off the main sequence · ×1
  • Off the main sequence: JPPhotoManager.Common JPPhotoManager/JPPhotoManager.Common/JPPhotoManager.Common.csproj:1 — JPPhotoManager.Common: abstractness 0.00, instability 0.00, distance 1.00 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-fb9eed23d3d2437b87272bb839b88565/history.json --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-fb9eed23d3d2437b87272bb839b88565/tree.json --exit-code 0 --source .0artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/watchdog-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off .37artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesnuget—nuget: not applicable — nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan0—
D30 · Dependency Vulnerabilitiestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** . --skip-db-update33artifacts/raw/trivy-fs.json
D31 · IaC & Container Securitytrivy—trivy config --format json --quiet .244artifacts/raw/trivy-config.json
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — The repository ships application workloads but no cluster-governance resources (CRDs, admission webhooks, or a committed policy engine). Runtime threat-detection (Falco/Tetragon) and admission control (Kyverno/OPA-Gatekeeper/PodSecurity) are cluster-OPERATOR controls owned by the platform, not shipped by an application repo/chart — nothing for this repo to assess.0—
D43 · Malicious Dependenciestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** . --skip-db-update0artifacts/raw/trivy-fs.json

Run 01a162e3-ffde-7529-87f4-c709de2497dd · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Issues: 84 · Warnings: 431 · Recommendations: 92 · Info: 7 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 22-10-2026 @ 09:14 UTC.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md