Public report of jstedfast/MailKit, published 23 October 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Watchdog signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 23 October 2026, 11:12 UTC · Survey ID cd_8ca3be568502416997d6f8ec52b63cf9
jstedfast/MailKit
Measured 23 October 2026, 11:07 UTC, at code version e09e9cc
A regression is a drop of 0.5 points or more in the score, or of 2.5 or more out of 10 in a dimension, since the last survey.
Code coverage is not measured: No coverage collector is wired up.
Test reliability is not measured: The repo's test suite did not build.
Boundary Type-Coupling is not measured: Bounded contexts not declared.
IL efficiency is not measured: The target did not build.
CAI scoreWeak
CriticalWeakAdequateStrongExemplary
Down 2 since the last survey
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A large codebase: 117,232 lines of product code in 13 projects, tests not counted · Estimated rebuild effort: about 1.0 person-years · Weakest lens: Security and Compliance, 30
Findings by how serious they are
70 critical556 serious89 minor
6 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
23 October 2026, 11:07 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that
implements it, and today Watchdog is the only one that does.
The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
69of 73 dimensions measured by tools. The other 4 are advisory notes from an AI model, which explain the code but don't count towards the score.
697of 715 findings point to an exact file and line, so you can open each one in the code. The other 18 concern the repository as a whole, such as missing documentation.
73dimensions across 6 lenses, read from 117,232 lines of product code in 13 projects.
jstedfast/MailKit scores 46 out of 100 and is rated Weak, while five of its six lenses score higher still: Architecture at 93, rated Exemplary, Production Readiness at 81, rated Strong, and Code Health at 67, Performance at 60 and Maturity at 51, all rated Adequate.
The score is lower than those five because the weakest lens counts most, and here that is Security and Compliance, which scores 30 and is rated Weak. Its Cryptographic Hygiene dimension scores 0 out of 10, and until that reaches 4, Security and Compliance can't be rated higher than Adequate. The first actions are to store passwords with a salted KDF — `Microsoft.AspNetCore.Identity.PasswordHasher<T>`, `Rfc2898DeriveBytes` (PBKDF2), or BCrypt/Argon2 — and compare with `CryptographicOperations.FixedTimeEquals` and to strengthen data-at-rest protection: vault your keys (Azure Key Vault / AWS KMS / IDataProtector key ring) and encrypt the most sensitive columns (EF HasConversion encryption or provider-native column encryption) — partial coverage still leaves gaps, and if Security and Compliance rose to 70, the score would rise from 46 to about 59.
70 findings are critical: 32 in Static Analysis (SAST), 31 in Explicit Debt, three in Cryptographic Hygiene, one in Incompleteness & stubs, one in Project dependency cycles, one in Secret Scanning and one in Secrets (history).
Watchdog couldn't measure Dependency Hygiene and Runtime evidence locked — no reproducible boot in this code, so those dimensions are left out of the score. The product code is 117,232 lines, which would take an estimated 1.0 person-years, around €150,000, to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
If Security and Compliance rose from 30 to 70, the lowest score rated Strong, the score would rise from 46 to about 59.
Code composition: what the lines of code are
Business logic 23%Supporting code 24%Tests 52%Generated by tools 1%
New since the last survey: 161 findings
These 161 critical or serious findings weren't in the previous survey, on 9 October 2026. The first 100 are listed here, and the findings file in the download package lists them all.
Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.
Fixed since the last survey: 50 findings
These 50 critical or serious findings were in the previous survey, on 9 October 2026, and are gone from this one.
Cancellation propagation · Async method without CancellationToken: OpenAsync MailKit/Net/Imap/ImapFolder.cs
Cancellation propagation · Async method without CancellationToken: Reload samples/ImapClientDemo.Android/ImapClientDemo.Android/FoldersActivity.cs
Cancellation propagation · Async method without CancellationToken: IdleAsync samples/ImapIdle/ImapIdle/IdleClient.cs
Cancellation propagation · Async method without CancellationToken: RunAsync samples/ImapIdle/ImapIdle/IdleClient.cs
Exception handling · Swallowed exception (caught, then discarded) samples/ImapClientDemo/ImapClientDemo/MultipartRelatedImageContext.cs
Rebuild cost: about €150,000 · Estimate
Cost to rebuild
€49,000 to €250,000, for 816 to 2,642 hours of work, about 1.0 person-years for 1 to 2 engineers
Difficulty of the problem
Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.7 at a score of 46. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Large: 117,232 lines of product code
Comment lines
The estimate prices 41,701 lines. Comment lines count towards the size of 117,232 lines but aren't priced as work.
How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Store passwords with a salted KDF — `Microsoft.AspNetCore.Identity.PasswordHasher<T>`, `Rfc2898DeriveBytes` (PBKDF2), or BCrypt/Argon2 — and compare with `CryptographicOperations.FixedTimeEquals`.
(A fast/plain hash, or a client-hashed value stored and compared verbatim, is not password storage.) Start in `MailKit/Security/SaslMechanismCramMd5.cs:125`.
Strengthen data-at-rest protection: vault your keys (Azure Key Vault / AWS KMS / IDataProtector key ring) and encrypt the most sensitive columns (EF HasConversion encryption or provider-native column encryption) — partial coverage still leaves gaps.
Raises the score by about 9 points · Medium effort · Data Protection
3
Resolve the 1 No ADRs found finding(s) in ADR Quality.
Raises the score by about 4 points · Low effort · ADR Quality
Diagnosis: what the measurements show together
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €150,000 to build again, about 1.0 person-years of work. Its weakest lens is Security and Compliance, at 30 (Weak). Security and Compliance is about how well the product is protected, and how it handles personal data. Because the weakest lens counts most in the score, work on Security and Compliance also moves the score most.
Based on: the rebuild estimate · the Security and Compliance grade · how much each lens counts
What to do: Start with the Security and Compliance actions in Top priorities.
If you do one thing first · First action
Store passwords with a salted KDF — `Microsoft.AspNetCore.Identity.PasswordHasher<T>`, `Rfc2898DeriveBytes` (PBKDF2), or BCrypt/Argon2 — and compare with `CryptographicOperations.FixedTimeEquals`. Of all the actions in this report, it raises the score most for the work it takes: about 13 points for medium effort. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture — module dependency graph
Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways — a layering smell or cycle. A clean layered graph has none.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
12 modules, with 19 dependencies between them. One loop runs through 3 of the modules, marked above the diagonal.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
MailKit.Security uses MailKit.Security.Ntlm, so a change to MailKit.Security.Ntlm can break MailKit.Security, while a change to MailKit.Security can't break MailKit.Security.Ntlm.
Position
Below the diagonal: MailKit.Security uses a module listed above it, which is the healthy direction.
MailKit.Net.Proxy uses MailKit.Security, so a change to MailKit.Security can break MailKit.Net.Proxy, while a change to MailKit.Net.Proxy can't break MailKit.Security.
Position
Below the diagonal: MailKit.Net.Proxy uses a module listed above it, which is the healthy direction.
MailKit.Net.Imap uses MailKit.Search, so a change to MailKit.Search can break MailKit.Net.Imap, while a change to MailKit.Net.Imap can't break MailKit.Search.
Position
Below the diagonal: MailKit.Net.Imap uses a module listed above it, which is the healthy direction.
MailKit.Net.Imap uses MailKit.Security, so a change to MailKit.Security can break MailKit.Net.Imap, while a change to MailKit.Net.Imap can't break MailKit.Security.
Position
Below the diagonal: MailKit.Net.Imap uses a module listed above it, which is the healthy direction.
127 pairs of types, where a type in MailKit.Net.Imap uses a type in MailKit. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
MailKit.Net.Pop3 uses MailKit.Security, so a change to MailKit.Security can break MailKit.Net.Pop3, while a change to MailKit.Net.Pop3 can't break MailKit.Security.
Position
Below the diagonal: MailKit.Net.Pop3 uses a module listed above it, which is the healthy direction.
MailKit.Net.Smtp uses MailKit.Security, so a change to MailKit.Security can break MailKit.Net.Smtp, while a change to MailKit.Net.Smtp can't break MailKit.Security.
Position
Below the diagonal: MailKit.Net.Smtp uses a module listed above it, which is the healthy direction.
26 pairs of types, where a type in MailKit.Net.Smtp uses a type in MailKit. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A05:2025 — Injection
37
High / Critical
A03:2025 — Software Supply Chain Failures
4
Medium
A07:2025 — Authentication Failures
2
High / Critical
A01:2025 — Broken Access Control
1
Medium
Roadmap
Immediately secure credentials by implementing salted password hashing with constant-time comparison and strengthen data-at-rest protection by vaulting keys and encrypting sensitive columns. Concurrently, establish architectural governance by documenting significant design decisions in a dedicated ADR folder to resolve current gaps. Finally, enhance the repository's root README to clearly explain the project's purpose and provide runnable code examples for better onboarding.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Store passwords with a salted KDF — `Microsoft.AspNetCore.Identity.PasswordHasher<T>`, `Rfc2898DeriveBytes` (PBKDF2), or BCrypt/Argon2 — and compare with `CryptographicOperations.FixedTimeEquals`. (A fast/plain hash, or a client-hashed value stored and compared verbatim, is not password storage.) Start in `MailKit/Security/SaslMechanismCramMd5.cs:125`.
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Per-file score 0–10 — a quality signature. Of 95 files carrying findings, judged against the Production bar: 9% slop · 52% mixed · 39% near-clean.
File
Score
Band
Worst signal
REDACTED
1.0
Slop
Explicit Debt: EmptyCatchBlock
REDACTED
1.0
Slop
Explicit Debt: EmptyCatchBlock
MailKit/Net/Pop3/AsyncPop3Client.cs
2.4
Slop
Explicit Debt: EmptyCatchBlock
REDACTED
2.5
Slop
Static Analysis (SAST): High: REDACTED
MailKit/Net/Imap/ImapFolderFetch.cs
2.8
Slop
Explicit Debt: EmptyCatchBlock
MailKit/Net/Imap/ImapClient.cs
2.8
Slop
Explicit Debt: EmptyCatchBlock
MailKit/Net/Imap/AsyncImapClient.cs
2.8
Slop
Explicit Debt: EmptyCatchBlock
MailKit/Net/Smtp/AsyncSmtpClient.cs
2.8
Slop
Explicit Debt: EmptyCatchBlock
REDACTED
3.7
Slop
Static Analysis (SAST): High: REDACTED
REDACTED
4.0
Mixed
Static Analysis (SAST): Medium: REDACTED
REDACTED
4.4
Mixed
Secret Scanning: Leaked secret: REDACTED
REDACTED
4.4
Mixed
Static Analysis (SAST): High: REDACTED
REDACTED
4.5
Mixed
Static Analysis (SAST): High: REDACTED
REDACTED
4.9
Mixed
Static Analysis (SAST): Medium: REDACTED
MailKit/Security/SaslMechanism.cs
5.4
Mixed
Explicit Debt: EmptyCatchBlock
MailKit/Security/SslHandshakeException.cs
5.4
Mixed
Explicit Debt: EmptyCatchBlock
MailKit/CompressedStream.cs
5.8
Mixed
Explicit Debt: EmptyCatchBlock
UnitTests/Security/SaslMechanismNtlmTests.cs
5.8
Mixed
Explicit Debt: WriteOnlyPrivateField
MailKit/Net/Imap/ImapEngine.cs
6.0
Mixed
Explicit Debt: FixmeComment
MailKit/Net/Imap/ImapCommand.cs
6.0
Mixed
Explicit Debt: CommentedOutCode
How the grades work
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 70
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 556
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 89
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 6
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 69 of 73 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 4 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.9 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.
Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.
What we checked — 73 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 697 of 715 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D12 Dependency Hygiene — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `dotnet list package` did not return usable output (restore or query failed); no outdated/vulnerable/deprecated data to assess. The tool said: /usr/share/dotnet/sdk/10.0.400/NuGet.targets(521,5): error MSB3202: The project file "submodules/MimeKit/MimeKit/MimeKit.csproj" was not found. [MailKit.sln].
D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-maintainer repository — bus factor is not applicable (63 contributor(s) across 3808 commit(s) sampled, automation and bot accounts excluded). One of them holds 98% of the history; the other 62 hold 0% each on average, below the 5% at which there is somebody to hand the work to. That is a single maintainer with drive-by contributors, not a team whose knowledge has concentrated — so the bus factor is not applicable and there is nothing here for the owner to act on.
D17 Explicit Debt — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The C# workspace loaded this repository's projects but reported a load failure, and the dead-code reference search is unreliable over a graph that did not load cleanly, so it was skipped. The other debt markers on this row were read; dead symbols were not, and their absence from the score is not a finding that the code has none. First load diagnostic: Failure: Project file not found: 'submodules/MimeKit/MimeKit/MimeKit.csproj'.
D18 Solution Shape — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The repository declares git submodule(s) (submodules/MimeKit) that are not checked out in the tree the analyzer was given, and every compiler error is an unresolved reference (CS0246: The type or namespace name 'MimeKit' could not be found (are you missing a using directive or an assembly reference?); CS0246: The type or namespace name 'InternetAddressList' could not be found (are you missing a using directive or an assembly reference?); CS0246: The type or namespace name 'MailboxAddress' could not be found (are you missing a using directive or an assembly reference?); CS0246: The type or namespace name 'GroupAddress' could not be found (are you missing a using directive or an assembly reference?); CS0246: The type or namespace name 'MimeMessage' could not be found (are you missing a using directive or an assembly reference?)). Those types exist for anyone who cloned with `--recurse-submodules`, so this is an analyzer-input gap, NOT a code defect: Solution Shape is scored on structure and is NOT capped.
D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The loaded project set declares no packable project and no `.Contracts` project, so there is no intentionally-exposed surface for API consistency to be judged over.
D23 Boundary Type-Coupling — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Large codebase (117,155 production LoC in the .NET projects) with no declared bounded contexts — cross-boundary type coupling is unassessed Bounded contexts cannot be inferred from a codebase that is not physically organised by them (D-321), so with none declared there are no boundaries for the coupling pass to measure across. You can widen what we reach: name this codebase's bounded contexts (≥2 module groups, e.g. per subsystem) so cross-boundary type coupling can be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D39 IL Efficiency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. `dotnet build` exited 1 with a compiler/MSBuild diagnostic, so there were no assemblies to read IL from. The build itself is D18's row, with the ask; nothing further is charged here.
AXB1 Runtime evidence locked — no reproducible boot — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Subject: a native UI project (samples/ImapClientDemo.Android/ImapClientDemo.Android/AndroidManifest.xml). The Runtime Evidence tier boots an app only via docker-compose, an Aspire AppHost, a Dockerfile, an npm dev script, a web service's own toolchain entry point (cargo, go, dotnet, Python, Spring Boot), or an Android app's own Gradle wrapper (run on an emulator); an Apple or Flutter app needs a host it lacks. None applied, so no live runtime a11y/egress/header evidence was collected. You can widen what we reach: add a docker-compose.yml (or an Aspire AppHost) that brings the app up with its dependencies. Watchdog then boots it in an isolated sandbox and gathers real runtime evidence — you change nothing in your pipeline (no CI step, no SDK).
IC1 Incompleteness & stubs — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 42 further occurrence(s) are not listed individually; the score already reflects all 82.
P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
Package restore incomplete — third-party types were unresolved in part of the solution — NuGet restore did not complete for samples/ImapClientDemo/ImapClientDemo/ImapClientDemo.csproj, samples/ImapClientDemo.iOS/ImapClientDemo.iOS/ImapClientDemo.iOS.csproj, samples/ImapClientDemo.Android/ImapClientDemo.Android/ImapClientDemo.Android.csproj, so those projects were analysed with framework references only: every check keyed on a third-party type saw an error type there and reported nothing. Findings on those projects are a lower bound; run `dotnet restore` on them and rescan.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
D24 Comment Value: Comment value (WHY vs WHAT) is an LLM judgement over a bounded sample — it is advisory and cannot weigh a comment against the precise code change it was written to explain.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D32 Data Compliance (PII/GDPR): PII/GDPR signals are heuristic pattern matches in code — they flag likely handling concerns, not legal compliance, and cannot trace where data actually flows at runtime.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
The LLM boundary
LLM-set scores this run (4): D19, D21, D24, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
61 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was SaslMechanism.IsProhibited at 70. A further 11 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being ImapCommandException.ErrorType.get at 32 — they are counted neither in the figure above nor in this dimension's score. 5 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: MailKit/Net/Imap/ImapCommandException.cs (ImapCommandException.ErrorType.get at 32), MailKit/Net/Imap/ImapResponseCode.cs (ImapResponseCode.IsErrorByDefault at 24), MailKit/Net/ClientMetrics.cs (ClientMetrics.TryGetErrorType at 23), MailKit/Net/Smtp/SmtpCommandException.cs (SmtpCommandException.ErrorType.get at 18), MailKit/Security/Ntlm/NtlmTargetInfo.cs (NtlmTargetInfo.Decode at 16). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 56 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 2 bodies over 60 down to 60 or less in Cyclomatic Complexity — start with SaslMechanism.IsProhibited (cyclomatic 70), ImapFolder.BuildQuery (cyclomatic 66). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 2 together lifts Cyclomatic Complexity from 6.4 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 105 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 6 bodies over 60 down to 60 or less in Cognitive Complexity — start with ImapFolder.ParseSummaryItems (cognitive 105), ImapFolder.ParseSummaryItemsAsync (cognitive 105), ImapFolder.FetchStream (cognitive 90). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 6 together lifts Cognitive Complexity from 5.5 to about 6.2/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes9.3 / 10Stronggated by 31 serious findings✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 13 TooManyMethods finding(s) in God Classes — start with ImapFolder.cs, MailFolder.cs, ImapEngine.cs. — One of this dimension's main actionable groups (13 warning-level).
Resolve the 10 FileTooLong finding(s) in God Classes — start with ImapEngine.cs, ImapFolder.cs, ImapFolderFetch.cs. — One of this dimension's main actionable groups (10 warning-level).
Resolve the 7 MethodTooLong finding(s) in God Classes — start with ImapFolderFetch.cs (4), ImapEngine.cs (2), ImapFolderSearch.cs. — One of this dimension's main actionable groups (7 warning-level).
Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
171 duplicated block group(s) detected. A further 13 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.
+ 59 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 22 Duplicated block (10 lines × 2) finding(s) in Code Duplication — start with ImapFolderFetch.cs (9), ImapFolder.cs (3), ImapFolderAnnotations.cs. — One of this dimension's main actionable groups (22 warning-level).
Resolve the 16 Duplicated block (15 lines × 2) finding(s) in Code Duplication — start with ImapFolder.cs (4), AsyncPop3Client.cs (3), AsyncImapClient.cs (2). — One of this dimension's main actionable groups (16 warning-level).
Resolve the 14 Duplicated block (16 lines × 2) finding(s) in Code Duplication — start with REDACTED (4), ImapEngine.cs (3), AsyncPop3Client.cs. — One of this dimension's main actionable groups (14 warning-level).
Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 1 Low cohesion finding(s) in Cohesion (LCOM4) — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.
Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.
1179 test methods: 1179 unit, 0 integration, 0 BDD, 0 e2e.
✓ On the Gold path — maintain.
Detailed fixes: d9_recommendation.md.
Do you agree with this assessment?
D10 · Test Quality10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the tests truly assert behaviour rather than just running the code.
Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
Resolve the 1 Leaked secret finding(s) in Secret Scanning — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Enforce Secret Scanning in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d13_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 14 packages use a banned license. ★ DEPTH: every package graded here is one this repository's MSBuild projects declare as a direct `PackageReference` (16 declared), and nothing beyond them was reached — this is the DECLARATION-SITE set, NOT the transitive closure. .NET has no lockfile a checkout is guaranteed to carry and this pass grades an unrestored tree, so a banned licence that only a direct dependency's OWN dependencies pull in is outside this verdict, exactly as the JVM arm's declaration-site verdict is.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Resolve the 14 Hotspot finding(s) in Churn × Complexity Hotspots — start with ImapEngine.cs, REDACTED, ImapFolderSearch.cs. — One of this dimension's main actionable groups (14 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
101 deducted debt markers + unmeasured dead symbols across 117155 LoC in the .NET projects (0.6/KLoC) → score 8.9. Dead code not measured: the solution did not load cleanly, so the reference search was skipped.
+ 2 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 28 EmptyCatchBlock finding(s) in Explicit Debt — start with AsyncPop3Client.cs (5), REDACTED (5), CompressedStream.cs (3). — One of this dimension's main actionable groups (28 issue-level).
Resolve the 2 NoWarnInCsproj finding(s) in Explicit Debt — start with UnitTests.csproj, MailKit.csproj. — One of this dimension's main actionable groups (2 issue-level).
Resolve the 1 WriteOnlyPrivateField finding(s) in Explicit Debt — start with SaslMechanismNtlmTests.cs. — One of this dimension's main actionable groups (1 issue-level).
Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the solution is laid out in a sensible, conventional structure.
Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.
13 projects, 1961 source files, 162416 hand-written lines of code (117155 production / 45261 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), plus 506 generated (machine-written code — designer, scaffolded and tool-emitted files — excluded from quality), 3 inter-project edges (build NOT measured — `dotnet build` did not complete in the analyzer, so the build half of this dimension is unmeasured rather than failed: the score above rests on structure alone and is not capped. The diagnostics that stopped it are named under Limitations.) Measured across 6 solutions loaded as one workspace: `MailKit.sln`, `MailKit.Documentation.sln`, `samples/ImapClientDemo/ImapClientDemo.sln`, `samples/ImapClientDemo.iOS/ImapClientDemo.iOS.sln`, `samples/ImapClientDemo.Android/ImapClientDemo.Android.sln`, `samples/ImapIdle/ImapIdle.sln`.
Solution references a project that does not existMailKit.sln
Solution references 2 projects that do not existMailKit.Documentation.sln
What to do
Resolve the 1 Solution references a project that does not exist finding(s) in Solution Shape — start with MailKit.sln. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Solution references 2 projects that do not exist finding(s) in Solution Shape — start with MailKit.Documentation.sln. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d18_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.
The repository's root README is a single cohesive document that describes the MailKit project (its package names, latest releases, and MyGet feeds), provides an overview table of platforms/build status/static analysis, and lists all the sections present in the full document outline. It is clear but thin on content: it does not explain what MailKit is or what it does, nor does it show how to run any code (the only runnable block is a NuGet package line), so those are missing from the visible portion.
Improve Documentation Quality — currently 6.0/10. — The repository's root README is a single cohesive document that describes the MailKit project (its package names, latest releases, and MyGet feeds), provides an overview table of platforms/build status/static analysis, and lists all the sections present in the full document outline. It is clear but thin on content: it does not explain what MailKit is or what it does, nor does it show how to run any code (the only runnable block is a NuGet package line), so those are missing from the visible portion.
Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D20 · ADR Quality0.0 / 10Critical✓ Tool-verified
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Per-ADR judgment by language model at low temperature with two-pass stability; confidence is share of ADRs evaluated; enforcement-field presence detected deterministically. Advisory.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.
0 naming inconsistencies across 200 sampled symbols.
✓ On the Gold path — maintain.
Detailed fixes: d21_recommendation.md.
Do you agree with this assessment?
D24 · Comment ValueExemplary◐ Sampled · advisory
What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).
Method: Judged by language model at low temperature (0.0-0.1) on deterministically sampled inline comments with surrounding code; findings verified back to sampled comments by substring match. Advisory, sampled.
1 of 7 projects flagged as possibly oversized/incoherent.
Projects may be oversized for their cohesion
What to do
Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D27 · Navigability7.4 / 10Strong✓ Tool-verified
What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.
Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.
Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.
53 % of calls cross a namespace and 8 % go through an interface, but 83 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: large — vertical-slice locality expected.
What to do
Improve Navigability — currently 7.4/10. — 53 % of calls cross a namespace and 8 % go through an interface, but 83 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: large — vertical-slice locality expected.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
37 finding(s): 0 critical, 32 high, 5 medium, 0 low. 26 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 1 file(s) — `UnitTests/Net/Imap/ImapRequestCallbackTests.cs` — so no absence of findings in them is evidence of anything, and nothing in them was analysed. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. In 1 of those file(s) — `UnitTests/Net/Imap/ImapRequestCallbackTests.cs` — the break is at a TYPE DECLARATION (a C# primary constructor semgrep's grammar cannot parse), so the loss is wider than the named lines: rules scoped to that type see no type to scope to and are blind over its whole body, while rules matching statements keep working there. Absence of a type-scoped finding in those types is not evidence of anything. Separately, one or more rules could not re-parse an embedded snippet in 2 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
+ 1 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 4 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (4). — One of this dimension's main actionable groups (4 issue-level).
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
No action in Static Analysis (SAST) — all 26 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (26 issue-level, 0 of them charged here).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D32 · Data Compliance (PII/GDPR)9.0 / 10Stronggated by 1 serious finding✓ Tool-verified
What it measures: Likely personal-data (PII / GDPR) handling concerns — logging or storing data without safeguards.
Method: Heuristic PII/GDPR LEAK scan via semgrep across the repo, using Watchdog's own ruleset: personal data crossing a boundary it should not — reaching a log/console sink, a URL or query string, or unprotected browser storage. Matches map to severity and a 0-10 wide normalizer. A clean sweep is unscored rather than an unearned 10, and is a statement about the leak paths checked only — this dimension does not inventory the personal data a repository holds (the personal-data map and the C1-C5 compliance cards do that), so it never reports that a repository has no personal-data surface. Reported LOUDLY as a measurement gap if the ruleset is missing from the analyzer image. Exhaustive over the leak paths, advisory-leaning; degrades on parse failure.
Resolve the 1 REDACTED finding(s) in Data Compliance (PII/GDPR) — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d32_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
Every significant source file has living knowledge — recently and meaningfully worked. Counted over 224 of the 260 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 5 Change-coupling hub finding(s) in Change Coupling — start with SmtpCommandException.cs, Pop3CommandException.cs, ImapCommandException.cs. — One of this dimension's main actionable groups (5 warning-level).
Resolve the 1 Change coupling finding(s) in Change Coupling — start with HttpsProxyClient.cs. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (SECURITY.md or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.
Method: Vulnerability-disclosure policy read deterministically from the repo: a SECURITY.md (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 6 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
What to do
The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
The namespaces MailKit ↔ MailKit.Net.Proxy ↔ MailKit.Search depend on each other. The lightest dependency in the cycle is MailKit → MailKit.Net.Proxy (MailKit.IMailService → MailKit.Net.Proxy.IProxyClient, 2 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — MailKit/IMailService.cs:40
What to do
Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.
Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
`IMailFolder` declares 235 members: `SyncRoot`, `ParentFolder`, `Attributes`, `AnnotationAccess`, `AnnotationScopes`, `MaxAnnotationSize`, `PermanentFlags`, `PermanentKeywords`, `AcceptedFlags`, `AcceptedKeywords`, `DirectorySeparator`, `Access`, `IsNamespace`, `FullName`, `Name`, `Id`, `IsSubscribed`, `IsOpen`, `CanOpen`, `Exists`, `HighestModSeq`, `UidValidity`, `UidNext`, `AppendLimit`, `Size`, `DeletedCount`, `DeletedStorageSize`, `FirstUnread`, `Unread`, `Recent`, `Count`, `ThreadingAlgorithms`, `Supports`, `Open`, `OpenAsync`, `Open`, `OpenAsync`, `Close`, `CloseAsync`, `Create`, and 195 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 235 declarations carry 129 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 129 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — MailKit/IMailFolder.cs:49
`IMailService` declares 46 members: `SyncRoot`, `SslProtocols`, `ClientCertificates`, `CheckCertificateRevocation`, `ServerCertificateValidationCallback`, `LocalEndPoint`, `ProxyClient`, `AuthenticationMechanisms`, `IsAuthenticated`, `IsConnected`, `IsSecure`, `IsEncrypted`, `IsSigned`, `SslProtocol`, `SslCipherAlgorithm`, `SslCipherStrength`, `SslHashAlgorithm`, `SslHashStrength`, `SslKeyExchangeAlgorithm`, `SslKeyExchangeStrength`, `Timeout`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Disconnect`, and 6 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 46 declarations carry 32 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 32 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — MailKit/IMailService.cs:53
`IMailSpool` declares 40 members: `Count`, `SupportsUids`, `GetMessageCount`, `GetMessageCountAsync`, `GetMessageUid`, `GetMessageUidAsync`, `GetMessageUids`, `GetMessageUidsAsync`, `GetMessageSize`, `GetMessageSizeAsync`, `GetMessageSizes`, `GetMessageSizesAsync`, `GetMessageHeaders`, `GetMessageHeadersAsync`, `GetMessageHeaders`, `GetMessageHeadersAsync`, `GetMessageHeaders`, `GetMessageHeadersAsync`, `GetMessage`, `GetMessageAsync`, `GetMessages`, `GetMessagesAsync`, `GetMessages`, `GetMessagesAsync`, `GetStream`, `GetStreamAsync`, `GetStreams`, `GetStreamsAsync`, `GetStreams`, `GetStreamsAsync`, `DeleteMessage`, `DeleteMessageAsync`, `DeleteMessages`, `DeleteMessagesAsync`, `DeleteMessages`, `DeleteMessagesAsync`, `DeleteAllMessages`, `DeleteAllMessagesAsync`, `Reset`, `ResetAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 40 declarations carry 30 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 30 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — MailKit/IMailSpool.cs:42
`IMailStore` declares 25 members: `PersonalNamespaces`, `SharedNamespaces`, `OtherNamespaces`, `SupportsQuotas`, `ThreadingAlgorithms`, `Inbox`, `GetFolder`, `GetFolder`, `GetFolders`, `GetFoldersAsync`, `GetFolders`, `GetFoldersAsync`, `GetFolder`, `GetFolderAsync`, `GetMetadata`, `GetMetadataAsync`, `GetMetadata`, `GetMetadataAsync`, `GetMetadata`, `GetMetadataAsync`, `SetMetadata`, `SetMetadataAsync`, `Alert`, `FolderCreated`, `MetadataChanged`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 25 declarations carry 17 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 17 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — MailKit/IMailStore.cs:40
`IMessageSummary` declares 27 members: `Fields`, `Body`, `TextBody`, `HtmlBody`, `BodyParts`, `Attachments`, `PreviewText`, `Envelope`, `NormalizedSubject`, `Date`, `IsReply`, `Flags`, `Keywords`, `Annotations`, `Headers`, `InternalDate`, `SaveDate`, `Size`, `ModSeq`, `References`, `EmailId`, `ThreadId`, `UniqueId`, `Index`, `GMailMessageId`, `GMailThreadId`, `GMailLabels`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — MailKit/IMessageSummary.cs:49
`IImapClient` declares 16 members: `Capabilities`, `AppendLimit`, `InternationalizationLevel`, `Rights`, `IsIdle`, `Enable`, `EnableAsync`, `Identify`, `IdentifyAsync`, `Idle`, `IdleAsync`, `CreateIdleSession`, `Notify`, `NotifyAsync`, `DisableNotify`, `DisableNotifyAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — MailKit/Net/Imap/IImapClient.cs:38
`IImapFolder` declares 18 members under just 10 distinct name(s): `GetHeaders`, `GetHeadersAsync`, `GetHeaders`, `GetHeadersAsync`, `GetBodyPart`, `GetBodyPartAsync`, `GetBodyPart`, `GetBodyPartAsync`, `GetStreams`, `GetStreamsAsync`, `GetStreams`, `GetStreamsAsync`, `GetStreams`, `GetStreamsAsync`, `Search`, `SearchAsync`, `Sort`, `SortAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 18 separate responsibilities: a caller binds to 10 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 18 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — MailKit/Net/Imap/IImapFolder.cs:48
`IMailService` declares 48 members: `SyncRoot`, `SslProtocols`, `SslCipherSuitesPolicy`, `SslCipherSuite`, `ClientCertificates`, `CheckCertificateRevocation`, `ServerCertificateValidationCallback`, `LocalEndPoint`, `ProxyClient`, `AuthenticationMechanisms`, `IsAuthenticated`, `IsConnected`, `IsSecure`, `IsEncrypted`, `IsSigned`, `SslProtocol`, `SslCipherAlgorithm`, `SslCipherStrength`, `SslHashAlgorithm`, `SslHashStrength`, `SslKeyExchangeAlgorithm`, `SslKeyExchangeStrength`, `Timeout`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, and 8 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 48 declarations carry 34 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 34 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — MailKit/IMailService.cs:53
`IImapClient` declares 18 members: `Capabilities`, `AppendLimit`, `InternationalizationLevel`, `Rights`, `IsIdle`, `Compress`, `CompressAsync`, `Enable`, `EnableAsync`, `Identify`, `IdentifyAsync`, `Idle`, `IdleAsync`, `CreateIdleSession`, `Notify`, `NotifyAsync`, `DisableNotify`, `DisableNotifyAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — MailKit/Net/Imap/IImapClient.cs:38
`IMailService` declares 42 members: `SyncRoot`, `SslProtocols`, `SslCipherSuitesPolicy`, `SslCipherSuite`, `ClientCertificates`, `CheckCertificateRevocation`, `ServerCertificateValidationCallback`, `LocalEndPoint`, `ProxyClient`, `AuthenticationMechanisms`, `IsAuthenticated`, `IsConnected`, `IsSecure`, `IsEncrypted`, `IsSigned`, `SslProtocol`, `Timeout`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Disconnect`, `DisconnectAsync`, `NoOp`, `NoOpAsync`, `Connected`, and 2 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 42 declarations carry 28 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 28 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — MailKit/IMailService.cs:53
What to do
Split fat interfaces into focused role-interfaces so clients depend only on what they use.
Where the width is an overload set rather than separate responsibilities, collapse the overloads instead — segregating those relieves no caller.
Do you agree with this assessment?
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified
Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.
Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.
Do you agree with this assessment?
C1 · Data Protection3.5 / 10Weak✓ Tool-verified
Other · Security — Whether sensitive data is encrypted at rest and in transit and keys are vaulted.
Method: Roslyn plus filesystem scan: encryption presence (EF ColumnEncryption, key-vault references, HTTPS enforcement) and key-derivation KDF detection. Deterministic.
What to do
Strengthen data-at-rest protection: vault your keys (Azure Key Vault / AWS KMS / IDataProtector key ring) and encrypt the most sensitive columns (EF HasConversion encryption or provider-native column encryption) — partial coverage still leaves gaps.
Enforce HTTPS (UseHttpsRedirection / RequireHttpsMetadata) so data in transit is always encrypted.
Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×2) — MailKit/Net/Smtp/SmtpStream.cs:357, MailKit/Net/Smtp/SmtpStream.cs:447
What to do
Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
`Read` is a shipped member whose body only throws — and it is REACHED: MailKit/Net/Smtp/SmtpStream.cs:412 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — MailKit/Net/Smtp/SmtpStream.cs:357
Code inside a `#if false` block is permanently excluded from the build — disabled code that should be removed or restored. (×5) — MailKit/Net/Imap/ImapIdleContext.cs:99, MailKit/Net/Smtp/SmtpStream.cs:359, MailKit/Net/Smtp/SmtpStream.cs:449, …
`DefaultUpdate` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — MailKit/Net/Imap/ImapLiteral.cs:55
`ReadAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — MailKit/Net/Smtp/SmtpStream.cs:447
A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). (×32) — MailKit/Net/Imap/ImapCommand.cs:285, MailKit/Net/Imap/ImapCommand.cs:286, MailKit/Net/Imap/ImapCommand.cs:290, …
What to do
Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
What to do
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
Add a README to the 7 of 7 project(s) that lack one — worth up to 2 pts.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.
Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.
Production code isn't grouped under a src/ folder — it's spread across several top-level directories, so there's no one place that says 'this is the product'.
Only 3/7 projects share a common root namespace — the code's module identity is inconsistent.
What to do
Group production code under src/ (or split deliberately, e.g. backend/ + frontend/) so production and tooling code aren't mixed at the root.
Adopt a consistent root-namespace convention (a shared prefix, e.g. Acme.*); short project-file/directory names are fine as long as the RootNamespace is uniform.
Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).
Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.
README.md installs the package `MimeKit.Cryptography` (`dotnet add package MimeKit.Cryptography`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — README.md:218
What to do
Reconcile the README with reality: README.md installs the package `MimeKit.Cryptography` (`dotnet add package MimeKit.Cryptography`), but no project or props file references it.
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
Do you agree with this assessment?
P10 · Library API & versioning10.0 / 10Exemplary○ Nothing flagged
Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.
Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
What to do
Dependabot is configured but does not watch `github-actions`, `gitsubmodule` — add those `package-ecosystem` entries to REDACTED so those dependencies get the same automatic update and advisory pressure as the ones it already covers.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.
Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.
No benchmark suite was found by the two searches this check runs. FIRST, a BenchmarkDotNet package reference in any project file — every project the workspace loaded, plus a walk of project files on disk that never loaded, because a benchmark suite is exactly the project a partial load drops. SECOND, a script harness: a file whose name contains `benchmark` and ends `.py`, `.sh`, `.ps1`, `.bash`, `.rb`, `.js` or `.mjs`, credited ONLY when this repository's CI text also mentions benchmarks — a harness no pipeline runs is read as a fixture, deliberately. Neither search can see a benchmark suite in another ecosystem's idiom (a Go `testing.B` file, a JMH or criterion project, a pytest-benchmark run), so this is 'no benchmark found by those two searches', not a verdict that the repository has none. Where code is performance-sensitive, a benchmark guards against silent regressions — but it's a bonus here, not a deduction.
What to do
Add a benchmarking harness for the hot paths and run it in CI to catch regressions (for .NET, a BenchmarkDotNet project with [MemoryDiagnoser] to track allocations).
Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.
Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — in .NET Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit; off .NET, with comments and strings blanked, Go's sync.Pool, preallocated slices/maps, Grow, strconv.Append* and buf[:0] reuse; the JVM's NIO buffer views, MemorySegment, primitive collections, pools and literal presizes (plus Kotlin primitive arrays and value classes, Scala AnyVal and @specialized); Swift's reserveCapacity, ContiguousArray, withUnsafe* access and ~Copyable. Activated off .NET on the same floor (400 lines, and benchmarks or 8 uses); Rust and garbage-collected scripting languages are not applicable. Reward-only. Deterministic, syntax/text detection.
What to do
Raise allocation-aware density on the hot paths — currently 54 use(s) across 117,810 production line(s) (~0.5/1k). More Span/Memory, pooling (ArrayPool/ObjectPool), stackalloc and ValueTask on the allocation-heavy paths climbs this toward 10.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
5 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
`.GetAwaiter ().GetResult ()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×5) — MailKit/Net/Imap/ImapEngine.cs:3011, MailKit/Net/Imap/ImapEngine.cs:3039, MailKit/Net/Proxy/ProxyClient.cs:227, …
What to do
Make the call chain async end-to-end and await it — never block on a Task with .Wait()/.GetAwaiter().GetResult().
Other · Security — Cryptographic hygiene (weak hash/cipher, password key-derivation). This codebase has no web surface, so transport/header/cookie/CSRF controls are N/A and only crypto is scored. Outbound TLS (certificate validation, protocol version) is scored wherever it appears — a client verifies its peer whether or not it serves anything itself.
Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.
`md5.ComputeHash(…)` puts the password `password` through a fast general-purpose digest, so a stolen hash is guessed at billions of candidates a second whether or not it is salted — no key-derivation function (PBKDF2/scrypt/Argon2/bcrypt) stands between the password and the stored value. — MailKit/Security/SaslMechanismCramMd5.cs:125
`ServerCertificateValidationCallback` is assigned a callback that returns `true` unconditionally, so every TLS peer certificate is accepted — including one an attacker presents. Chain, expiry, revocation and hostname are all skipped, so an attacker on the network path can present any certificate and read or rewrite the traffic — the connection is encrypted to the attacker, not to the intended host. Delete the override and let the platform validate. If a specific self-signed or internally-issued certificate genuinely has to be trusted, pin THAT one — compare the presented certificate's public key or thumbprint against the expected value and return `false` for everything else — and scope it to the single handler that talks to that host rather than to the whole process. If the override exists only to get past a development certificate, gate it on a build configuration or an explicit opt-in setting so it cannot ship. — samples/ImapClientDemo.iOS/ImapClientDemo.iOS/LoginViewController.cs:84
MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses. (×10) — REDACTED:893, MailKit/Security/SaslMechanism.cs:69, MailKit/Security/SaslMechanismCramMd5.cs:124, …
A digest from `ComputeHash` (MD5/SHA1) is compared against an expected value here, and a mismatch rejects the input — so a collision-broken hash IS the integrity check. — MailKit/Security/SaslMechanismDigestMd5.cs:178
What to do
Store passwords with a salted KDF — `Microsoft.AspNetCore.Identity.PasswordHasher<T>`, `Rfc2898DeriveBytes` (PBKDF2), or BCrypt/Argon2 — and compare with `CryptographicOperations.FixedTimeEquals`. (A fast/plain hash, or a client-hashed value stored and compared verbatim, is not password storage.) Start in `MailKit/Security/SaslMechanismCramMd5.cs:125`.
Stop accepting every TLS certificate: remove the always-true validation callback so the platform verifies the chain, hostname and expiry. If one self-signed certificate must be trusted, pin it by public key or thumbprint on the single handler that needs it and reject all others — never process-wide.
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name. This repository constructs a collision-broken hash (MD5/SHA1) at 10 sites, not one: `REDACTED:893` (MD5), `MailKit/Security/SaslMechanism.cs:69` (MD5), `MailKit/Security/SaslMechanismCramMd5.cs:124` (MD5), `MailKit/Security/SaslMechanismCramMd5.cs:140` (MD5), `MailKit/Security/SaslMechanismCramMd5.cs:146` (MD5), `MailKit/Security/SaslMechanismDigestMd5.cs:484` (MD5), `MailKit/Security/SaslMechanismDigestMd5.cs:487` (MD5), `MailKit/Security/SaslMechanismDigestMd5.cs:505` (MD5), and 2 further site(s). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Verify integrity with SHA-256+ rather than MD5/SHA1: a collision-broken digest cannot establish that content matches what was expected, since an attacker able to influence the content can produce a colliding replacement. Where the content is downloaded or otherwise attacker-reachable, prefer an authenticated check — a signature over the digest, or the publisher's SHA-256 fetched over a channel the content itself does not come from. The gate is at `MailKit/Security/SaslMechanismDigestMd5.cs:178`.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process. (×5) — MailKit/Net/Imap/ImapEngine.cs:3011, MailKit/Net/Imap/ImapEngine.cs:3039, MailKit/Net/Proxy/ProxyClient.cs:227, …
`async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained. (×6) — samples/ImapClientDemo.iOS/ImapClientDemo.iOS/FoldersViewController.cs:49, samples/ImapClientDemo.iOS/ImapClientDemo.iOS/LoginViewController.cs:70, samples/ImapClientDemo.iOS/ImapClientDemo.iOS/MessageListViewController.cs:56, …
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.
Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.
Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.
Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.
Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
`MailService` declares a finalizer (line 101), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — REDACTED:101
`ProtocolLogger` is never created by `MailService` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 1697). Its declared type `IProtocolLogger` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed. — REDACTED:1697
`ImapClient` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `sslValidationInfo` itself (line 70), which makes that instance its own. But `sslValidationInfo` is named in none of the methods the disposal search covered: `Dispose` (line 2808) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`sslValidationInfo?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — MailKit/Net/Imap/ImapClient.cs:70
`ImapEngine` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `builder` itself (line 162), which makes that instance its own. But `builder` is named in none of the methods the disposal search covered: `Dispose` (line 4475), `Disconnect` (line 930) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`builder?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — MailKit/Net/Imap/ImapEngine.cs:162
`Pop3Client` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `sslValidationInfo` itself (line 77), which makes that instance its own. But `sslValidationInfo` is named in none of the methods the disposal search covered: `Dispose` (line 3392) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`sslValidationInfo?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — REDACTED:77
`SmtpClient` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `sslValidationInfo` itself (line 87), which makes that instance its own. But `sslValidationInfo` is named in none of the methods the disposal search covered: `Dispose` (line 2783), `Disconnect` (line 1743), `Disconnect` (line 1799) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`sslValidationInfo?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — REDACTED:87
`ProtocolLogger` declares a finalizer (line 104), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — MailKit/ProtocolLogger.cs:104
`MD4` declares a finalizer (line 71), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — MailKit/Security/Ntlm/MD4.cs:71
`RC4` declares a finalizer (line 47), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization. — MailKit/Security/Ntlm/RC4.cs:47
What to do
Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.
Only 247/276 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
No CancellationToken parameter — the body observes an ambient token instead (a field or a context object), so the work does stop on cancellation, but a caller cannot cancel this call independently of the owner that created that token. (×19) — MailKit/Net/Imap/ImapCommand.cs:694, MailKit/Net/Imap/ImapFolder.cs:319, MailKit/Net/Imap/ImapFolder.cs:2296, …
No CancellationToken parameter — this work can't be stopped early once started. (×9) — MailKit/Net/Imap/ImapEngine.cs:3304, samples/ImapClientDemo.iOS/ImapClientDemo.iOS/FoldersViewController.cs:65, samples/ImapClientDemo.iOS/ImapClientDemo.iOS/LoginViewController.cs:70, …
No CancellationToken parameter, and the token `ic.CancellationToken` carries reaches none of the calls here that take one — this work can't be stopped early once started. Pass `ic.CancellationToken` on, or take a CancellationToken. — MailKit/Net/Imap/ImapEngine.cs:3357
1 async method(s) await work their caller's cancellation cannot reach: a CancellationToken they hold (a parameter, or the one a framework-fixed signature carries) is never passed on, or the call is handed CancellationToken.None, default or an already-cancelled token. Forward the caller's token to that call.
Holds a CancellationToken but hands `CancellationToken.None` to the awaited call on this line, so the caller's cancellation never reaches that work. Pass the token on (or, where the work must outlive the caller, start it without awaiting it so the choice is visible). — MailKit/Net/Imap/ImapIdleSession.cs:342
What to do
Thread a CancellationToken through async methods so work stops promptly on cancellation.
Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.
Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.
Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.
Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.
Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×24) — MailKit/Net/Imap/AsyncImapClient.cs:849, MailKit/Net/Imap/AsyncImapClient.cs:850, MailKit/Net/Imap/AsyncImapClient.cs:851, …
An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else). — MailKit/Net/Imap/ImapFolderFetch.cs:2021
`catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. (×9) — MailKit/Net/Imap/ImapIdleContext.cs:129, REDACTED:2343, REDACTED:2505, …
`catch (NotSupportedException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — MailKit/TextEncodings.cs:42
What to do
Swallowed exception (empty catch)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X32 · Type resolved by simple name across every loaded assembly10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a plugin lookup names the type it means — searching every assembly loaded into the process for a candidate whose SIMPLE name equals a string supplied at runtime, and taking the first one found, is decided by assembly LOAD ORDER rather than by this source, so the same name can resolve to a different type on the next run.
Method: Roslyn syntax only, no semantic model: every invocation of `First`/`FirstOrDefault`/`Single`/`SingleOrDefault` whose OWN expression subtree contains both a `GetAssemblies()` call and a `GetTypes()`/`GetExportedTypes()` call — a single-element pick out of every type loaded into the process. A nested selector in the same chain sees no `GetAssemblies()` in its own subtree and is outside the population, so one lookup counts once however many links its chain has. A finding additionally needs both remaining halves: the selector must be `First`/`FirstOrDefault` (`Single`/`SingleOrDefault` reports the ambiguity rather than resolving it, and is counted and never reported), and the chain must carry an `==` comparison of `<lambda parameter>.Name` against something that is not a literal. The receiver must be a plain identifier bound by one of the chain’s own lambdas, which places `assembly.GetName().Name == "X"` outside the rule by construction. One exemption: a `.Name` test joined by `&&` to a `FullName`/`AssemblyQualifiedName` test on the same identifier is spared; joined by `||` it is not. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
4/5 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
~1.0 `!` suppressions per 1k syntax nodes — 237 suppression(s) across the 239353 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.
What to do
Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.
Do you agree with this assessment?
Reference — by lens
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 4 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
P12 CI test-gate honesty — 1 observation(s) recorded · Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
SC1 Supply-chain hygiene — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X10 Duplicated predicate — 25 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 4 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 4 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
C3 Audit Trail — Repo shows no audit-logging mechanism (IAuditable, an immutable audit log, an EF SaveChanges interceptor) for sensitive changes — absence of evidence is not evidence of a working control. Record an audit trail in code (or document where it lives) so this dimension can be scored.
C4 Data Retention — Repo shows no data-retention / TTL / cleanup mechanism for personal data — absence of evidence is not evidence of a working control. Define retention periods and a purge/cleanup job (or TTL) in code, or document where retention is enforced, so this dimension can be scored.
C5 Data-Subject Rights — Repo shows no corroborated data-subject-rights mechanism (erasure / export-portability / consent) tied to a subject id or GDPR vocabulary — absence of evidence is not evidence of a working control. Implement erasure, data export/portability and consent tracking over the subject's records.
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 40 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
AX1 Captive dependencies — no DI registrations detected
AX2 Stateful singletons — no singleton implementations detected
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB1 Runtime evidence locked — no reproducible boot — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
C2 Access Controls — No access-control surface detected in the analyzed source — no web/app surface to authorize (no HTTP API or web-UI project) and no authorization code at all (no [Authorize]/policies, no imperative guard methods). Access control is therefore N/A here — this is a library/CLI, which is authorized by its CALLER, not by itself. If this codebase grows request handlers, the dimension reactivates and a default-deny posture is expected then.
D11 Test Reliability — Test reliability NOT MEASURED: this repository did not build in our analyzer environment (a C#/MSBuild compiler error), so no test ever ran and flakiness could not be exercised. It is excluded from the score rather than counted as a defect. We did not read WHERE the failing diagnostic is, so this does not claim the fault is in your test code — a repository written for an older SDK band can compile for you and not for us. Run `dotnet build` on this commit: if it succeeds, the gap is ours and nothing here is a defect in your code.
D12 Dependency Hygiene — Dependency hygiene not measured
D16 Bus Factor — single-maintainer repository — bus factor is not applicable
D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
D23 Boundary Type-Coupling — Cross-context type coupling could not be assessed — this codebase's bounded contexts are neither declared nor inferable.
D25 ADR Conformance — no ADRs to check
D30 Dependency Vulnerabilities — nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D39 IL Efficiency — IL not measured — the target did not build
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D43 Malicious Dependencies — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).
D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
D8 Code Coverage — Coverage NOT MEASURED: `--collect:"XPlat Code Coverage"` names a data collector that ships in the `coverlet.collector` package, and this repository wires up none — no test project references it and no runsettings declares one. The absence of coverage here is therefore not evidence about the suite or about our analyzer environment: without a collector, `--collect` produces nothing even from a suite that builds and passes. Add a `coverlet.collector` PackageReference to the test project(s) (or commit the Cobertura/OpenCover/lcov report your CI produces) and real coverage will be measured. It is excluded from the score rather than counted as a near-zero defect.
DM1 Domain Modelling — not scored — this repository shows none of the 3 signals this lens looks for
ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
P2 Observability — This repo is a library, not a deployed service — it has no process to operate, so production observability (structured logging, tracing/metrics, health checks) is N/A. A library may log via an injected ILogger, but the absence of operational telemetry is not a defect here. If it grows a host (web API, worker), the dimension reactivates.
P7 Outbound HTTP resilience — not applicable — this isn't a service/API/worker
P8 Schema migrations — no EF Core usage detected
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Cobertura — `dotnet test --collect:"XPlat Code Coverage"` with a `coverlet.collector` PackageReference) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
X4 Structured logging — This check asks whether log calls keep a message's values apart from its text, which needs a logger that can carry them as fields. This repository's C# was read, and every log call in it goes through a logger that takes one finished message — its own wrapper, log4net, Console or Debug — so an interpolated message there loses nothing the API could have kept. Calls through Microsoft.Extensions.Logging, Serilog, NLog or ZLogger, or any logger with a message-template overload, would be judged.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
EmptyCatchBlock MailKit/CompressedStream.cs:407— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/CompressedStream.cs:408— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/CompressedStream.cs:409— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/Net/Imap/AsyncImapClient.cs:849— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/Net/Imap/AsyncImapClient.cs:850— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/Net/Imap/AsyncImapClient.cs:851— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/Net/Imap/ImapClient.cs:1788— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/Net/Imap/ImapClient.cs:1789— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/Net/Imap/ImapClient.cs:1790— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/Net/Imap/ImapFolderFetch.cs:2021— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/Net/Pop3/AsyncPop3Client.cs:74— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/Net/Pop3/AsyncPop3Client.cs:241— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/Net/Pop3/AsyncPop3Client.cs:660— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/Net/Pop3/AsyncPop3Client.cs:661— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/Net/Pop3/AsyncPop3Client.cs:662— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock REDACTED:649— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock REDACTED:978— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock REDACTED:1472— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock REDACTED:1473— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock REDACTED:1474— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/Net/Smtp/AsyncSmtpClient.cs:807— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/Net/Smtp/AsyncSmtpClient.cs:808— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock MailKit/Net/Smtp/AsyncSmtpClient.cs:809— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock REDACTED:1754— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock REDACTED:1755— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
NoWarnInCsproj — 12 warning codes suppressed in one element UnitTests/UnitTests.csproj:14— A single <NoWarn> suppresses 12 warning codes (1701;1702;CA1835;IDE0016;IDE0056;IDE0057;IDE0063;IDE0066;IDE0090;SYSLIB0011;NUnit2010;NUnit2045) in one stroke — one team-wide decision, not 12 independent debts. Review the set centrally rather than code-by-code; each code you can re-enable is one less blanket suppression. (Every code still counts toward the score and metrics.)
NoWarnInCsproj — 17 warning codes suppressed in one element MailKit/MailKit.csproj:33— A single <NoWarn> suppresses 17 warning codes (1701;1702;CA1068;CA1510;CA1512;CA1513;CA1835;CA2012;IDE0016;IDE0056;IDE0057;IDE0060;IDE0063;IDE0066;IDE0090;IDE0180;IDE0251) in one stroke — one team-wide decision, not 17 independent debts. Review the set centrally rather than code-by-code; each code you can re-enable is one less blanket suppression. (Every code still counts toward the score and metrics.)
Namespace dependency cycle MailKit/IMailService.cs:40— The namespaces MailKit ↔ MailKit.Net.Proxy ↔ MailKit.Search depend on each other. The lightest dependency in the cycle is MailKit → MailKit.Net.Proxy (MailKit.IMailService → MailKit.Net.Proxy.IProxyClient, 2 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
WriteOnlyPrivateField UnitTests/Security/SaslMechanismNtlmTests.cs:575— private byte[] ExampleNtlmV2AuthenticateMessageOriginal — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
Unfinished stub — throws NotImplementedException MailKit/Net/Smtp/SmtpStream.cs:357— `Read` is a shipped member whose body only throws — and it is REACHED: MailKit/Net/Smtp/SmtpStream.cs:412 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
S1 · Cryptographic Hygiene· Password hashing without a KDF · ×1
Password hashing without a KDF MailKit/Security/SaslMechanismCramMd5.cs:125— `md5.ComputeHash(…)` puts the password `password` through a fast general-purpose digest, so a stolen hash is guessed at billions of candidates a second whether or not it is salted — no key-derivation function (PBKDF2/scrypt/Argon2/bcrypt) stands between the password and the stored value.
TLS certificate validation disabled samples/ImapClientDemo.iOS/ImapClientDemo.iOS/LoginViewController.cs:84— `ServerCertificateValidationCallback` is assigned a callback that returns `true` unconditionally, so every TLS peer certificate is accepted — including one an attacker presents. Chain, expiry, revocation and hostname are all skipped, so an attacker on the network path can present any certificate and read or rewrite the traffic — the connection is encrypted to the attacker, not to the intended host. Delete the override and let the platform validate. If a specific self-signed or internally-issued certificate genuinely has to be trusted, pin THAT one — compare the presented certificate's public key or thumbprint against the expected value and return `false` for everything else — and scope it to the single handler that talks to that host rather than to the whole process. If the override exists only to get past a development certificate, gate it on a build configuration or an explicit opt-in setting so it cannot ship.
S1 · Cryptographic Hygiene· Weak hash is the integrity check · ×1
Weak hash is the integrity check MailKit/Security/SaslMechanismDigestMd5.cs:178— A digest from `ComputeHash` (MD5/SHA1) is compared against an expected value here, and a mismatch rejects the input — so a collision-broken hash IS the integrity check.
Swallowed exception (empty catch) MailKit/Net/Imap/AsyncImapClient.cs:849— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) MailKit/Net/Imap/AsyncImapClient.cs:850— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) MailKit/Net/Imap/AsyncImapClient.cs:851— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) MailKit/Net/Imap/ImapClient.cs:1788— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) MailKit/Net/Imap/ImapClient.cs:1789— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) MailKit/Net/Imap/ImapClient.cs:1790— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) MailKit/Net/Imap/ImapFolderFetch.cs:2021— An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
Swallowed exception (empty catch) MailKit/Net/Pop3/AsyncPop3Client.cs:74— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) MailKit/Net/Pop3/AsyncPop3Client.cs:241— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) MailKit/Net/Pop3/AsyncPop3Client.cs:660— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) MailKit/Net/Pop3/AsyncPop3Client.cs:661— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) MailKit/Net/Pop3/AsyncPop3Client.cs:662— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) REDACTED:649— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) REDACTED:978— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) REDACTED:1472— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) REDACTED:1473— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) REDACTED:1474— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) MailKit/Net/Smtp/AsyncSmtpClient.cs:807— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) MailKit/Net/Smtp/AsyncSmtpClient.cs:808— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) MailKit/Net/Smtp/AsyncSmtpClient.cs:809— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) REDACTED:1754— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) REDACTED:1755— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) REDACTED:1756— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) MailKit/Security/SaslMechanism.cs:334— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) MailKit/Security/SslHandshakeException.cs:273— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapFolder.cs:5164— MailKit/Net/Imap/ImapFolder.cs:5164-5173 | MailKit/Net/Imap/ImapFolder.cs:5417-5426 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:5164` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `MailKit/Net/Imap/ImapFolder.cs:5176` calls `Contains`, `Expunge`, `ExpungeRequest` and `MailKit/Net/Imap/ImapFolder.cs:5430` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapFolder.cs:5257— MailKit/Net/Imap/ImapFolder.cs:5257-5266 | MailKit/Net/Imap/ImapFolder.cs:5509-5518 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:5257` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `MailKit/Net/Imap/ImapFolder.cs:5269` calls `Contains`, `ExpungeAsync`, `ExpungeRequest` and `MailKit/Net/Imap/ImapFolder.cs:5522` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapFolder.cs:6630— MailKit/Net/Imap/ImapFolder.cs:6630-6639 | MailKit/Net/Imap/ImapFolder.cs:6656-6665 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:6630` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:2122— MailKit/Net/Imap/ImapFolderFetch.cs:2122-2131 | MailKit/Net/Imap/ImapFolderFetch.cs:2365-2374 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:2122` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapFolderAnnotations.cs:265— MailKit/Net/Imap/ImapFolderAnnotations.cs:265-274 | MailKit/Net/Imap/ImapFolderFlags.cs:752-761 — before extracting anything, compare `MailKit/Net/Imap/ImapFolderAnnotations.cs` and `MailKit/Net/Imap/ImapFolderFlags.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 48 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderAnnotations.cs:265` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `IStoreAnnotationsRequest` in one and `IStoreLabelsRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:2741— MailKit/Net/Imap/ImapFolderFetch.cs:2741-2750 | MailKit/Net/Imap/ImapFolderFetch.cs:3135-3144 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:2741` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:2830— MailKit/Net/Imap/ImapFolderFetch.cs:2830-2839 | MailKit/Net/Imap/ImapFolderFetch.cs:3224-3233 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:2830` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:2889— MailKit/Net/Imap/ImapFolderFetch.cs:2889-2898 | MailKit/Net/Imap/ImapFolderFetch.cs:3283-3292 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:2889` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:3529— MailKit/Net/Imap/ImapFolderFetch.cs:3529-3538 | MailKit/Net/Imap/ImapFolderFetch.cs:3665-3674 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:3529` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) MailKit/Net/Pop3/AsyncPop3Client.cs:437— MailKit/Net/Pop3/AsyncPop3Client.cs:437-446 | MailKit/Net/Pop3/AsyncPop3Client.cs:606-615 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Pop3/AsyncPop3Client.cs:437` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) MailKit/BodyPart.cs:670— MailKit/BodyPart.cs:670-679 | MailKit/BodyPart.cs:682-691 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `MailKit/BodyPart.cs:681` calls `TryParse` and `MailKit/BodyPart.cs:693` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 2) MailKit/Net/Imap/AsyncImapClient.cs:251— MailKit/Net/Imap/AsyncImapClient.cs:251-260 | MailKit/Net/Imap/ImapClient.cs:1094-1103 — before extracting anything, compare `MailKit/Net/Imap/AsyncImapClient.cs` and `MailKit/Net/Imap/ImapClient.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 104 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/AsyncImapClient.cs:251` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:4368— MailKit/Net/Imap/ImapFolderFetch.cs:4368-4377 | MailKit/Net/Imap/ImapFolderFetch.cs:4533-4542 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:4368` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:4432— MailKit/Net/Imap/ImapFolderFetch.cs:4432-4441 | MailKit/Net/Imap/ImapFolderFetch.cs:4596-4605 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:4432` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:4854— MailKit/Net/Imap/ImapFolderFetch.cs:4854-4863 | MailKit/Net/Imap/ImapFolderFetch.cs:5177-5186 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:4854` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:4924— MailKit/Net/Imap/ImapFolderFetch.cs:4924-4933 | MailKit/Net/Imap/ImapFolderFetch.cs:5246-5255 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:4924` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapFolderFlags.cs:556— MailKit/Net/Imap/ImapFolderFlags.cs:556-565 | MailKit/Net/Imap/ImapFolderFlags.cs:758-767 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `MailKit/Net/Imap/ImapFolderFlags.cs:755` calls `FormatIndexSet`, `Append` and `MailKit/Net/Imap/ImapFolderFlags.cs:554` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 2) REDACTED:1742— REDACTED:1742-1751 | REDACTED:2136-2145 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:1742` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (10 lines × 2) MailKit/Net/Proxy/Socks4Client.cs:226— MailKit/Net/Proxy/Socks4Client.cs:226-235 | MailKit/Net/Proxy/Socks4Client.cs:309-318 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Proxy/Socks4Client.cs:226` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) REDACTED:1510— REDACTED:1510-1519 | REDACTED:1699-1708 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:1510` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapEngine.cs:3594— MailKit/Net/Imap/ImapEngine.cs:3594-3603 | MailKit/Net/Imap/ImapEngine.cs:3618-3627 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapEngine.cs:3594` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) MailKit/Net/Imap/ImapFolderSearch.cs:821— MailKit/Net/Imap/ImapFolderSearch.cs:821-830 | MailKit/Net/Imap/ImapFolderSearch.cs:875-884 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderSearch.cs:821` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:410— MailKit/Net/Imap/ImapFolderFetch.cs:410-424 | MailKit/Net/Imap/ImapFolderFetch.cs:654-668 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:410` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) MailKit/Net/Imap/ImapEngine.cs:3869— MailKit/Net/Imap/ImapEngine.cs:3869-3883 | MailKit/Net/Imap/ImapEngine.cs:3928-3942 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapEngine.cs:3869` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) MailKit/Net/Imap/ImapFolder.cs:4914— MailKit/Net/Imap/ImapFolder.cs:4914-4928 | MailKit/Net/Imap/ImapFolder.cs:5014-5028 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:4914` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15 lines × 2) MailKit/Net/Imap/ImapFolder.cs:5691— MailKit/Net/Imap/ImapFolder.cs:5691-5705 | MailKit/Net/Imap/ImapFolder.cs:5790-5804 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:5691` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) MailKit/Net/Imap/ImapFolder.cs:5916— MailKit/Net/Imap/ImapFolder.cs:5916-5930 | MailKit/Net/Imap/ImapFolder.cs:6035-6049 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:5916` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) MailKit/Net/Pop3/AsyncPop3Client.cs:224— MailKit/Net/Pop3/AsyncPop3Client.cs:224-238 | REDACTED:961-975 — before extracting anything, compare `MailKit/Net/Pop3/AsyncPop3Client.cs` and `REDACTED` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Pop3/AsyncPop3Client.cs:224` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) MailKit/UniqueIdSet.cs:283— MailKit/UniqueIdSet.cs:283-297 | MailKit/UniqueIdSet.cs:340-354 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/UniqueIdSet.cs:283` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) MailKit/Net/Imap/AsyncImapClient.cs:783— MailKit/Net/Imap/AsyncImapClient.cs:783-797 | MailKit/Net/Imap/ImapClient.cs:1723-1737 — before extracting anything, compare `MailKit/Net/Imap/AsyncImapClient.cs` and `MailKit/Net/Imap/ImapClient.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 104 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/AsyncImapClient.cs:783` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) MailKit/Net/Imap/AsyncImapClient.cs:799— MailKit/Net/Imap/AsyncImapClient.cs:799-813 | MailKit/Net/Imap/ImapClient.cs:1739-1753 — before extracting anything, compare `MailKit/Net/Imap/AsyncImapClient.cs` and `MailKit/Net/Imap/ImapClient.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 104 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/AsyncImapClient.cs:799` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) MailKit/Net/Imap/ImapFolder.cs:6314— MailKit/Net/Imap/ImapFolder.cs:6314-6328 | MailKit/Net/Imap/ImapFolder.cs:6407-6421 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:6314` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15 lines × 2) MailKit/Net/Pop3/AsyncPop3Client.cs:595— MailKit/Net/Pop3/AsyncPop3Client.cs:595-609 | REDACTED:1408-1422 — before extracting anything, compare `MailKit/Net/Pop3/AsyncPop3Client.cs` and `REDACTED` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Pop3/AsyncPop3Client.cs:595` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) MailKit/Net/Pop3/AsyncPop3Client.cs:611— MailKit/Net/Pop3/AsyncPop3Client.cs:611-625 | REDACTED:1424-1438 — before extracting anything, compare `MailKit/Net/Pop3/AsyncPop3Client.cs` and `REDACTED` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Pop3/AsyncPop3Client.cs:611` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) MailKit/Net/Pop3/Pop3Stream.cs:1013— MailKit/Net/Pop3/Pop3Stream.cs:1013-1027 | MailKit/Net/Smtp/SmtpStream.cs:1018-1032 — before extracting anything, compare `MailKit/Net/Pop3/Pop3Stream.cs` and `MailKit/Net/Smtp/SmtpStream.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 160 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Pop3/Pop3Stream.cs:1013` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15 lines × 2) MailKit/Net/Proxy/HttpProxyClient.cs:192— MailKit/Net/Proxy/HttpProxyClient.cs:192-206 | MailKit/Net/Proxy/HttpProxyClient.cs:256-270 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Proxy/HttpProxyClient.cs:192` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) MailKit/Net/Smtp/AsyncSmtpClient.cs:757— MailKit/Net/Smtp/AsyncSmtpClient.cs:757-771 | REDACTED:1705-1719 — before extracting anything, compare `MailKit/Net/Smtp/AsyncSmtpClient.cs` and `REDACTED` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 108 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Smtp/AsyncSmtpClient.cs:757` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:361— MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:361-375 | MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:408-422 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Hotspot: MailKit/Net/Imap/ImapEngine.cs MailKit/Net/Imap/ImapEngine.cs:1985— MailKit/Net/Imap/ImapEngine.cs changed 17 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 50 in ImapEngine.ParseResponseCode at line 1985. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 14:13:53 -04:00' --until='2026-10-22 14:13:53 -04:00' --full-history --no-merges -- MailKit/Net/Imap/ImapEngine.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: REDACTED REDACTED:2348— REDACTED changed 10 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in SmtpClient.Prepare at line 2348. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 14:13:53 -04:00' --until='2026-10-22 14:13:53 -04:00' --full-history --no-merges -- REDACTED`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: MailKit/Net/Imap/ImapFolderSearch.cs MailKit/Net/Imap/ImapFolderSearch.cs:460— MailKit/Net/Imap/ImapFolderSearch.cs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 28 in ImapFolder.ParseESearchResults at line 460. 1 of those changes was a fix/bug commit, and the other 5 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 14:13:53 -04:00' --until='2026-10-22 14:13:53 -04:00' --full-history --no-merges -- MailKit/Net/Imap/ImapFolderSearch.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: MailKit/Net/Imap/ImapFolder.cs MailKit/Net/Imap/ImapFolder.cs:4500— MailKit/Net/Imap/ImapFolder.cs changed 11 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in ImapFolder.CreateAppendCommand at line 4500. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 14:13:53 -04:00' --until='2026-10-22 14:13:53 -04:00' --full-history --no-merges -- MailKit/Net/Imap/ImapFolder.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: MailKit/Net/Imap/ImapCommand.cs MailKit/Net/Imap/ImapCommand.cs:552— MailKit/Net/Imap/ImapCommand.cs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 26 in ImapCommand.Step at line 552. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 14:13:53 -04:00' --until='2026-10-22 14:13:53 -04:00' --full-history --no-merges -- MailKit/Net/Imap/ImapCommand.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: MailKit/Net/Imap/ImapClient.cs MailKit/Net/Imap/ImapClient.cs:354— MailKit/Net/Imap/ImapClient.cs changed 9 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in ImapClient.TryQueueEnableCommand at line 354. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 14:13:53 -04:00' --until='2026-10-22 14:13:53 -04:00' --full-history --no-merges -- MailKit/Net/Imap/ImapClient.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: MailKit/Net/Imap/ImapCommandException.cs MailKit/Net/Imap/ImapCommandException.cs:265— MailKit/Net/Imap/ImapCommandException.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 32 in ImapCommandException.ErrorType.get at line 265. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 14:13:53 -04:00' --until='2026-10-22 14:13:53 -04:00' --full-history --no-merges -- MailKit/Net/Imap/ImapCommandException.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: MailKit/BodyPart.cs MailKit/BodyPart.cs:608— MailKit/BodyPart.cs changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 38 in BodyPart.TryParse at line 608. 1 of those changes was a fix/bug commit, and the other 2 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 14:13:53 -04:00' --until='2026-10-22 14:13:53 -04:00' --full-history --no-merges -- MailKit/BodyPart.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: REDACTED REDACTED:959— REDACTED changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in Pop3Client.Authenticate at line 959. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 14:13:53 -04:00' --until='2026-10-22 14:13:53 -04:00' --full-history --no-merges -- REDACTED`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: MailKit/Net/Imap/AsyncImapClient.cs MailKit/Net/Imap/AsyncImapClient.cs:353— MailKit/Net/Imap/AsyncImapClient.cs changed 5 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in ImapClient.AuthenticateAsync at line 353. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 14:13:53 -04:00' --until='2026-10-22 14:13:53 -04:00' --full-history --no-merges -- MailKit/Net/Imap/AsyncImapClient.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: MailKit/Net/Imap/ImapResponseCode.cs MailKit/Net/Imap/ImapResponseCode.cs:748— MailKit/Net/Imap/ImapResponseCode.cs changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in ImapResponseCode.IsErrorByDefault at line 748. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 14:13:53 -04:00' --until='2026-10-22 14:13:53 -04:00' --full-history --no-merges -- MailKit/Net/Imap/ImapResponseCode.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: MailKit/Net/Smtp/SmtpStream.cs MailKit/Net/Smtp/SmtpStream.cs:494— MailKit/Net/Smtp/SmtpStream.cs changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in SmtpStream.ReadResponse at line 494. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 14:13:53 -04:00' --until='2026-10-22 14:13:53 -04:00' --full-history --no-merges -- MailKit/Net/Smtp/SmtpStream.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: MailKit/Net/Imap/ImapFolderFlags.cs MailKit/Net/Imap/ImapFolderFlags.cs:517— MailKit/Net/Imap/ImapFolderFlags.cs changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in ImapFolder.CreateStoreCommands at line 517. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 14:13:53 -04:00' --until='2026-10-22 14:13:53 -04:00' --full-history --no-merges -- MailKit/Net/Imap/ImapFolderFlags.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: MailKit/Net/Pop3/AsyncPop3Client.cs MailKit/Net/Pop3/AsyncPop3Client.cs:222— MailKit/Net/Pop3/AsyncPop3Client.cs changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in Pop3Client.AuthenticateAsync at line 222. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 14:13:53 -04:00' --until='2026-10-22 14:13:53 -04:00' --full-history --no-merges -- MailKit/Net/Pop3/AsyncPop3Client.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Duplicated block (16 lines × 2) MailKit/Net/Imap/ImapEngine.cs:2764— MailKit/Net/Imap/ImapEngine.cs:2764-2779 | MailKit/Net/Imap/ImapEngine.cs:2828-2843 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapEngine.cs:2764` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) REDACTED:965— REDACTED:965-980 | REDACTED:2417-2432 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 2) REDACTED:990— REDACTED:990-1005 | REDACTED:2442-2457 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 2) MailKit/Net/Pop3/AsyncPop3Client.cs:248— MailKit/Net/Pop3/AsyncPop3Client.cs:248-263 | REDACTED:985-1000 — before extracting anything, compare `MailKit/Net/Pop3/AsyncPop3Client.cs` and `REDACTED` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 61 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Pop3/AsyncPop3Client.cs:248` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 2) MailKit/Net/Imap/ImapEngine.cs:3790— MailKit/Net/Imap/ImapEngine.cs:3790-3805 | MailKit/Net/Imap/ImapEngine.cs:3831-3846 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapEngine.cs:3790` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note first that the copies are not typed on the same thing: the declarations holding them bind `command` to `out StringBuilder` in one and `StringBuilder` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (16 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:2317— MailKit/Net/Imap/ImapFolderFetch.cs:2317-2332 | MailKit/Net/Imap/ImapFolderFetch.cs:2560-2575 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:2317` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) MailKit/Net/Imap/ImapEngine.cs:837— MailKit/Net/Imap/ImapEngine.cs:837-852 | MailKit/Net/Imap/ImapEngine.cs:898-913 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapEngine.cs:837` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) MailKit/Net/Imap/ImapStream.cs:981— MailKit/Net/Imap/ImapStream.cs:981-996 | MailKit/Net/Pop3/Pop3Stream.cs:611-626 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapStream.cs:981` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) REDACTED:971— REDACTED:971-986 | REDACTED:996-1011 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:971` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 2) REDACTED:2423— REDACTED:2423-2438 | REDACTED:2448-2463 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:2423` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 2) MailKit/Net/Smtp/AsyncSmtpClient.cs:256— MailKit/Net/Smtp/AsyncSmtpClient.cs:256-271 | REDACTED:1103-1118 — before extracting anything, compare `MailKit/Net/Smtp/AsyncSmtpClient.cs` and `REDACTED` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 108 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Smtp/AsyncSmtpClient.cs:256` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) MailKit/Net/Imap/ImapClient.cs:2533— MailKit/Net/Imap/ImapClient.cs:2533-2548 | MailKit/Net/Imap/ImapFolder.cs:3314-3329 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapClient.cs:2533` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) MailKit/Net/Imap/ImapFolderFlags.cs:460— MailKit/Net/Imap/ImapFolderFlags.cs:460-475 | MailKit/Net/Imap/ImapFolderFlags.cs:889-904 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFlags.cs:460` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `IStoreFlagsRequest` in one and `IStoreLabelsRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (16 lines × 2) MailKit/Security/Ntlm/NtlmChallengeMessage.cs:154— MailKit/Security/Ntlm/NtlmChallengeMessage.cs:154-169 | MailKit/Security/Ntlm/NtlmChallengeMessage.cs:178-193 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
TooManyMethods: ImapFolder MailKit/Net/Imap/ImapFolder.cs— TooManyMethods — 5213 significant lines (blank, comment-only and punctuation-only lines excluded), 405 methods, declared across 5 files: Imap/ImapFolder.cs (205), Imap/ImapFolderFetch.cs (122), Imap/ImapFolderSearch.cs (55), Imap/ImapFolderFlags.cs (16), +1 more file(s). The bar is 30 methods; this is 375 over it, 13.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MailFolder MailKit/MailFolder.cs— TooManyMethods — 525 significant lines (blank, comment-only and punctuation-only lines excluded), 210 methods. The bar is 30 methods; this is 180 over it, 7.00× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ImapEngine MailKit/Net/Imap/ImapEngine.cs— TooManyMethods — 2138 significant lines (blank, comment-only and punctuation-only lines excluded), 123 methods. The bar is 30 methods; this is 93 over it, 4.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Pop3Client REDACTED— TooManyMethods — 1104 significant lines (blank, comment-only and punctuation-only lines excluded), 122 methods, declared across 2 files: REDACTED (82), Pop3/AsyncPop3Client.cs (40). The bar is 30 methods; this is 92 over it, 4.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: SmtpClient REDACTED— TooManyMethods — 1396 significant lines (blank, comment-only and punctuation-only lines excluded), 99 methods, declared across 2 files: REDACTED (74), Smtp/AsyncSmtpClient.cs (25). The bar is 30 methods; this is 69 over it, 3.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ImapClient MailKit/Net/Imap/ImapClient.cs— TooManyMethods — 1146 significant lines (blank, comment-only and punctuation-only lines excluded), 99 methods, declared across 2 files: Imap/ImapClient.cs (78), Imap/AsyncImapClient.cs (21). The bar is 30 methods; this is 69 over it, 3.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ImapUtils REDACTED— TooManyMethods — 1500 significant lines (blank, comment-only and punctuation-only lines excluded), 81 methods. The bar is 30 methods; this is 51 over it, 2.70× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
TooManyMethods: ImapStream MailKit/Net/Imap/ImapStream.cs— TooManyMethods — 490 significant lines (blank, comment-only and punctuation-only lines excluded), 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: SearchQuery MailKit/Search/SearchQuery.cs— TooManyMethods — 218 significant lines (blank, comment-only and punctuation-only lines excluded), 47 methods. The bar is 30 methods; this is 17 over it, 1.57× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MailSpool MailKit/MailSpool.cs— TooManyMethods — 47 significant lines (blank, comment-only and punctuation-only lines excluded), 41 methods. The bar is 30 methods; this is 11 over it, 1.37× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MailService REDACTED— TooManyMethods — 196 significant lines (blank, comment-only and punctuation-only lines excluded), 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Pop3Engine MailKit/Net/Pop3/Pop3Engine.cs— TooManyMethods — 347 significant lines (blank, comment-only and punctuation-only lines excluded), 32 methods. The bar is 30 methods; this is 2 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: SmtpStream MailKit/Net/Smtp/SmtpStream.cs— TooManyMethods — 329 significant lines (blank, comment-only and punctuation-only lines excluded), 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
DeadPreprocessorBranch MailKit/FetchRequest.cs:159— #if ENABLE_LAZY_PREVIEW_API — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch MailKit/IFetchRequest.cs:96— #if ENABLE_LAZY_PREVIEW_API — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch MailKit/Net/Imap/ImapFolderFetch.cs:882— #if ENABLE_LAZY_PREVIEW_API — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch MailKit/PreviewOptions.cs:28— #if ENABLE_LAZY_PREVIEW_API — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch UnitTests/Net/Imap/ImapFolderFetchTests.cs:1333— #if ENABLE_LAZY_PREVIEW_API — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch MailKit/Net/Imap/ImapIdleContext.cs:99— #if false — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch MailKit/Security/Ntlm/NtlmUtils.cs:135— #if false — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch MailKit/Security/Ntlm/NtlmUtils.cs:181— #if false — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch UnitTests/Security/Ntlm/NtlmTargetInfoTests.cs:43— #if false — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch UnitTests/Security/SaslMechanismNtlmTests.cs:52— #if false — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch MailKit/Net/Smtp/SmtpStream.cs:359— #if false // Note: this code will never get called as we always use ReadResponse() instead. — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch MailKit/Net/Smtp/SmtpStream.cs:449— #if false // Note: this code will never get called as we always use ReadResponse() instead. — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
TodoComment MailKit/Net/Imap/ImapFolderAnnotations.cs:83— // TODO: Do something with the AnnotateResponseCode if it exists?? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:82— // TODO: throw if Unicode && Oem are both unset? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment UnitTests/Net/Imap/ImapClientTests.cs:4907— // TODO: verify CONTEXT=SEARCH — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment UnitTests/Net/Imap/ImapClientTests.cs:5572— // TODO: verify CONTEXT=SEARCH — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment UnitTests/Net/Imap/ImapClientTests.cs:7190— // TODO: test MessageNew w/ headers — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment UnitTests/Net/Imap/ImapFolderTests.cs:425— // Rename - TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment UnitTests/Net/Pop3/Pop3ClientTests.cs:1303— // TODO: assert that the message is byte-identical to what we expect — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment UnitTests/Net/Pop3/Pop3ClientTests.cs:1381— // TODO: assert that the message is byte-identical to what we expect — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment UnitTests/Net/Pop3/Pop3ClientTests.cs:1456— // TODO: assert that the message is byte-identical to what we expect — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment UnitTests/Net/Pop3/Pop3ClientTests.cs:1531— // TODO: assert that the message is byte-identical to what we expect — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment UnitTests/Net/Pop3/Pop3ClientTests.cs:3388— // TODO: assert that the message is byte-identical to what we expect — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment UnitTests/Net/Pop3/Pop3ClientTests.cs:3466— // TODO: assert that the message is byte-identical to what we expect — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FileTooLong: Imap/ImapEngine.cs MailKit/Net/Imap/ImapEngine.cs— FileTooLong — 2200 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1700 over it, 4.40× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Imap/ImapFolder.cs MailKit/Net/Imap/ImapFolder.cs— FileTooLong — 2070 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1570 over it, 4.14× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Imap/ImapFolderFetch.cs MailKit/Net/Imap/ImapFolderFetch.cs— FileTooLong — 2007 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1507 over it, 4.01× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: REDACTED REDACTED— FileTooLong — 1556 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1056 over it, 3.11× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: REDACTED REDACTED— FileTooLong — 1104 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 604 over it, 2.21× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: REDACTED REDACTED— FileTooLong — 1033 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 533 over it, 2.07× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Imap/ImapFolderSearch.cs MailKit/Net/Imap/ImapFolderSearch.cs— FileTooLong — 1001 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 501 over it, 2.00× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Imap/ImapClient.cs MailKit/Net/Imap/ImapClient.cs— FileTooLong — 890 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 390 over it, 1.78× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: MailKit/MailFolder.cs MailKit/MailFolder.cs— FileTooLong — 535 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 35 over it, 1.07× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Imap/ImapStream.cs MailKit/Net/Imap/ImapStream.cs— FileTooLong — 504 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 4 over it, 1.01× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
Weak hash algorithm REDACTED:893— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm MailKit/Security/SaslMechanism.cs:69— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm MailKit/Security/SaslMechanismCramMd5.cs:124— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm MailKit/Security/SaslMechanismCramMd5.cs:140— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm MailKit/Security/SaslMechanismCramMd5.cs:146— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm MailKit/Security/SaslMechanismDigestMd5.cs:484— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm MailKit/Security/SaslMechanismDigestMd5.cs:487— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm MailKit/Security/SaslMechanismDigestMd5.cs:505— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm MailKit/Security/SaslMechanismDigestMd5.cs:512— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm MailKit/Security/SaslMechanismScramSha1.cs:108— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
X2 · Cancellation propagation· Async method without CancellationToken · ×10
Async method without CancellationToken: IterateAsync MailKit/Net/Imap/ImapEngine.cs:3304— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: RunAsync MailKit/Net/Imap/ImapEngine.cs:3357— No CancellationToken parameter, and the token `ic.CancellationToken` carries reaches none of the calls here that take one — this work can't be stopped early once started. Pass `ic.CancellationToken` on, or take a CancellationToken.
Async method without CancellationToken: LoadChildFolders samples/ImapClientDemo.iOS/ImapClientDemo.iOS/FoldersViewController.cs:65— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Login samples/ImapClientDemo.iOS/ImapClientDemo.iOS/LoginViewController.cs:70— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: LoadChildFolders samples/ImapClientDemo.Android/ImapClientDemo.Android/FoldersActivity.cs:83— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: buttonLogin_Click samples/ImapClientDemo.Android/ImapClientDemo.Android/LoginActivity.cs:61— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Reload samples/ImapClientDemo.Android/ImapClientDemo.Android/MessageListActivity.cs:73— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: RunAsync samples/ImapIdle/ImapIdle/IdleClientBase.cs:112— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: IdleAsync samples/ImapIdle/ImapIdle/IdleSessionClient.cs:86— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: IdleAsync samples/ImapIdle/ImapIdle/ManualIdleClient.cs:79— No CancellationToken parameter — this work can't be stopped early once started.
Swallowed exception (caught, then discarded) MailKit/Net/Imap/ImapIdleContext.cs:129— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) REDACTED:2343— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) REDACTED:2505— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) REDACTED:2559— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) MailKit/Net/NetworkStream.cs:152— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) MailKit/Net/Smtp/AsyncSmtpClient.cs:966— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) REDACTED:2287— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) MailKit/Net/SocketUtils.cs:98— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) MailKit/Security/SaslMechanism.cs:71— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) MailKit/TextEncodings.cs:42— `catch (NotSupportedException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Duplicated block (8 lines × 2) MailKit/Net/Imap/ImapEngine.cs:2274— MailKit/Net/Imap/ImapEngine.cs:2274-2281 | MailKit/Net/Imap/ImapEngine.cs:2624-2631 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:494— MailKit/Net/Imap/ImapFolderFetch.cs:494-501 | MailKit/Net/Imap/ImapFolderFetch.cs:738-745 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:494` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) REDACTED:1637— REDACTED:1637-1644 | REDACTED:2014-2021 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:1637` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) REDACTED:1728— REDACTED:1728-1735 | REDACTED:2121-2128 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:1728` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) MailKit/Net/Imap/ImapFolder.cs:6224— MailKit/Net/Imap/ImapFolder.cs:6224-6231 | MailKit/Net/Imap/ImapFolder.cs:6433-6440 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `ICopyRequest` in one and `IMoveRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (8 lines × 2) MailKit/Net/Imap/ImapFolderSearch.cs:1562— MailKit/Net/Imap/ImapFolderSearch.cs:1562-1569 | MailKit/Net/Imap/ImapFolderSearch.cs:1799-1806 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) REDACTED:1609— REDACTED:1609-1616 | REDACTED:1700-1707 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:3687— MailKit/Net/Imap/ImapFolderFetch.cs:3687-3694 | MailKit/Net/Imap/ImapFolderFetch.cs:3999-4006 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:3687` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `MailKit/Net/Imap/ImapFolderFetch.cs:3997` calls `ToString` and `MailKit/Net/Imap/ImapFolderFetch.cs:3684` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 2) MailKit/Net/Imap/ImapClient.cs:619— MailKit/Net/Imap/ImapClient.cs:619-626 | REDACTED:360-367 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) MailKit/Net/Imap/ImapFolder.cs:5700— MailKit/Net/Imap/ImapFolder.cs:5700-5706 | MailKit/Net/Imap/ImapFolder.cs:5925-5931 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `ICopyRequest` in one and `IMoveRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (7 lines × 2) MailKit/Net/Imap/ImapFolder.cs:5799— MailKit/Net/Imap/ImapFolder.cs:5799-5805 | MailKit/Net/Imap/ImapFolder.cs:6044-6050 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `ICopyRequest` in one and `IMoveRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (7 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:1440— MailKit/Net/Imap/ImapFolderFetch.cs:1440-1446 | MailKit/Net/Imap/ImapFolderFetch.cs:1658-1664 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) MailKit/Net/Imap/ImapFolderSearch.cs:795— MailKit/Net/Imap/ImapFolderSearch.cs:795-801 | MailKit/Net/Imap/ImapFolderSearch.cs:849-855 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderSearch.cs:795` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:435— MailKit/Net/Imap/ImapFolderFetch.cs:435-441 | MailKit/Net/Imap/ImapFolderFetch.cs:467-473 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:679— MailKit/Net/Imap/ImapFolderFetch.cs:679-685 | MailKit/Net/Imap/ImapFolderFetch.cs:711-717 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) MailKit/Security/Ntlm/NtlmChallengeMessage.cs:111— MailKit/Security/Ntlm/NtlmChallengeMessage.cs:111-117 | MailKit/Security/Ntlm/NtlmNegotiateMessage.cs:111-117 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Security/Ntlm/NtlmChallengeMessage.cs:111` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:336— MailKit/Net/Imap/ImapFolderFetch.cs:336-342 | MailKit/Net/Imap/ImapFolderFetch.cs:580-586 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:336` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (7 lines × 2) MailKit/Security/Ntlm/NtlmNegotiateMessage.cs:136— MailKit/Security/Ntlm/NtlmNegotiateMessage.cs:136-142 | MailKit/Security/Ntlm/NtlmNegotiateMessage.cs:143-149 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (17 lines × 2) MailKit/Net/Imap/ImapEngine.cs:2964— MailKit/Net/Imap/ImapEngine.cs:2964-2980 | MailKit/Net/Imap/ImapEngine.cs:3122-3138 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapEngine.cs:2964` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:2094— MailKit/Net/Imap/ImapFolderFetch.cs:2094-2110 | MailKit/Net/Imap/ImapFolderFetch.cs:2337-2353 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:2094` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:3781— MailKit/Net/Imap/ImapFolderFetch.cs:3781-3797 | MailKit/Net/Imap/ImapFolderFetch.cs:4080-4096 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (17 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:3852— MailKit/Net/Imap/ImapFolderFetch.cs:3852-3868 | MailKit/Net/Imap/ImapFolderFetch.cs:4148-4164 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (17 lines × 2) MailKit/Net/Imap/AsyncImapClient.cs:525— MailKit/Net/Imap/AsyncImapClient.cs:525-541 | MailKit/Net/Imap/ImapClient.cs:1458-1474 — before extracting anything, compare `MailKit/Net/Imap/AsyncImapClient.cs` and `MailKit/Net/Imap/ImapClient.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 104 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/AsyncImapClient.cs:525` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) MailKit/Net/Smtp/AsyncSmtpClient.cs:738— MailKit/Net/Smtp/AsyncSmtpClient.cs:738-754 | REDACTED:1686-1702 — before extracting anything, compare `MailKit/Net/Smtp/AsyncSmtpClient.cs` and `REDACTED` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 108 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Smtp/AsyncSmtpClient.cs:738` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) MailKit/Net/Imap/ImapClient.cs:1281— MailKit/Net/Imap/ImapClient.cs:1281-1297 | MailKit/Net/Imap/ImapClient.cs:1314-1333 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapClient.cs:1281` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `MailKit/Net/Imap/ImapClient.cs:1335` calls `SetError` and `MailKit/Net/Imap/ImapClient.cs:1298` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (17 lines × 2) MailKit/Net/Imap/ImapFolderFlags.cs:393— MailKit/Net/Imap/ImapFolderFlags.cs:393-409 | MailKit/Net/Imap/ImapFolderFlags.cs:822-838 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `IStoreFlagsRequest` in one and `IStoreLabelsRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
FixmeComment MailKit/Net/Imap/ImapEngine.cs:982— // FIXME: All callers expect CRLF to be trimmed, but many also want all trailing whitespace trimmed. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment MailKit/Net/Imap/ImapEngine.cs:1015— // FIXME: All callers expect CRLF to be trimmed, but many also want all trailing whitespace trimmed. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment MailKit/Net/Pop3/Pop3Engine.cs:385— // FIXME: All callers expect CRLF to be trimmed, but many also want all trailing whitespace trimmed. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment MailKit/Net/Pop3/Pop3Engine.cs:417— // FIXME: All callers expect CRLF to be trimmed, but many also want all trailing whitespace trimmed. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment UnitTests/BodyPartTests.cs:222— // FIXME: assert more stuff — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment UnitTests/Net/Imap/ImapUtilsTests.cs:1324— // FIXME: assert more stuff? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment UnitTests/Net/Imap/ImapUtilsTests.cs:1363— // FIXME: assert more stuff? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
MethodTooLong: ImapFolder.BuildQuery MailKit/Net/Imap/ImapFolderSearch.cs:112— MethodTooLong — BuildQuery runs 270 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 170 over it, 2.70× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ImapEngine.ParseResponseCode MailKit/Net/Imap/ImapEngine.cs:1985— MethodTooLong — ParseResponseCode runs 204 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 104 over it, 2.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ImapEngine.ParseResponseCodeAsync MailKit/Net/Imap/ImapEngine.cs:2335— MethodTooLong — ParseResponseCodeAsync runs 204 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 104 over it, 2.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ImapFolder.ParseSummaryItems MailKit/Net/Imap/ImapFolderFetch.cs:299— MethodTooLong — ParseSummaryItems runs 157 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 57 over it, 1.57× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ImapFolder.ParseSummaryItemsAsync MailKit/Net/Imap/ImapFolderFetch.cs:543— MethodTooLong — ParseSummaryItemsAsync runs 157 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 57 over it, 1.57× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ImapFolder.FetchStream MailKit/Net/Imap/ImapFolderFetch.cs:2091— MethodTooLong — FetchStream runs 151 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 51 over it, 1.51× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ImapFolder.FetchStreamAsync MailKit/Net/Imap/ImapFolderFetch.cs:2334— MethodTooLong — FetchStreamAsync runs 151 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 51 over it, 1.51× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×7
Members sharing a duplicated core (4 members, 50+ identical tokens) MailKit/Net/Imap/AsyncImapClient.cs:250— MailKit/Net/Imap/AsyncImapClient.cs:250-299 | MailKit/Net/Imap/AsyncImapClient.cs:354-465 | MailKit/Net/Imap/ImapClient.cs:1093-1145 | MailKit/Net/Imap/ImapClient.cs:1224-1338 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) MailKit/Net/Imap/ImapFolder.cs:5161— MailKit/Net/Imap/ImapFolder.cs:5161-5197 | MailKit/Net/Imap/ImapFolder.cs:5254-5290 | MailKit/Net/Imap/ImapFolder.cs:5414-5448 | MailKit/Net/Imap/ImapFolder.cs:5506-5540 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) MailKit/Net/Imap/ImapFolder.cs:6145— MailKit/Net/Imap/ImapFolder.cs:6145-6164 | MailKit/Net/Imap/ImapFolder.cs:6217-6236 | MailKit/Net/Imap/ImapFolder.cs:6313-6352 | MailKit/Net/Imap/ImapFolder.cs:6406-6445 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) REDACTED:964— REDACTED:964-986 | REDACTED:989-1011 | REDACTED:2416-2438 | REDACTED:2441-2463 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) MailKit/Net/Pop3/Pop3Stream.cs:828— MailKit/Net/Pop3/Pop3Stream.cs:828-874 | MailKit/Net/Pop3/Pop3Stream.cs:945-988 | MailKit/Net/Smtp/SmtpStream.cs:833-879 | MailKit/Net/Smtp/SmtpStream.cs:950-993 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) MailKit/Net/Proxy/ProxyClient.cs:213— MailKit/Net/Proxy/ProxyClient.cs:213-236 | MailKit/Net/Proxy/ProxyClient.cs:239-255 | MailKit/Net/Proxy/ProxyClient.cs:258-282 | MailKit/Net/Proxy/ProxyClient.cs:285-303 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) MailKit/Net/Smtp/AsyncSmtpClient.cs:208— MailKit/Net/Smtp/AsyncSmtpClient.cs:208-271 | MailKit/Net/Smtp/AsyncSmtpClient.cs:329-420 | REDACTED:1055-1118 | REDACTED:1196-1284 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Duplicated block (12 lines × 2) MailKit/Net/Imap/ImapClient.cs:1552— MailKit/Net/Imap/ImapClient.cs:1552-1563 | MailKit/Net/Imap/ImapClient.cs:1732-1743 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapClient.cs:1552` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) MailKit/Net/Imap/ImapFolder.cs:4350— MailKit/Net/Imap/ImapFolder.cs:4350-4361 | MailKit/Net/Imap/ImapFolder.cs:4462-4473 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:4350` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) REDACTED:1298— REDACTED:1298-1309 | REDACTED:1349-1360 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) REDACTED:1231— REDACTED:1231-1242 | REDACTED:1417-1428 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:1231` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `REDACTED:1227` calls `ConnectNetwork` and `REDACTED:1416` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:318— MailKit/Net/Imap/ImapFolderFetch.cs:318-329 | MailKit/Net/Imap/ImapFolderFetch.cs:562-573 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:318` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) MailKit/Net/Imap/ImapFolder.cs:4883— MailKit/Net/Imap/ImapFolder.cs:4883-4894 | MailKit/Net/Imap/ImapFolder.cs:4983-4994 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:4883` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) MailKit/Net/Imap/ImapFolder.cs:4900— MailKit/Net/Imap/ImapFolder.cs:4900-4911 | MailKit/Net/Imap/ImapFolder.cs:5000-5011 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:4900` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:441— MailKit/Net/Imap/ImapFolderFetch.cs:441-454 | MailKit/Net/Imap/ImapFolderFetch.cs:685-698 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (14 lines × 2) MailKit/Net/Imap/ImapFolder.cs:5885— MailKit/Net/Imap/ImapFolder.cs:5885-5898 | MailKit/Net/Imap/ImapFolder.cs:6004-6017 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:5885` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 2) MailKit/Net/Imap/ImapEngine.cs:3887— MailKit/Net/Imap/ImapEngine.cs:3887-3900 | MailKit/Net/Imap/ImapEngine.cs:3946-3959 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapEngine.cs:3887` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) MailKit/Net/Imap/ImapEngine.cs:2942— MailKit/Net/Imap/ImapEngine.cs:2942-2955 | MailKit/Net/Imap/ImapEngine.cs:3100-3113 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapEngine.cs:2942` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) REDACTED:2459— REDACTED:2459-2472 | REDACTED:2485-2498 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:2459` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) MailKit/Net/Imap/ImapFolder.cs:6333— MailKit/Net/Imap/ImapFolder.cs:6333-6346 | MailKit/Net/Imap/ImapFolder.cs:6426-6439 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:6333` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Sync-over-async blocking — 5 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking MailKit/Net/Imap/ImapEngine.cs:3011— `.GetAwaiter ().GetResult ()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking MailKit/Net/Imap/ImapEngine.cs:3039— `.GetAwaiter ().GetResult ()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking MailKit/Net/Proxy/ProxyClient.cs:227— `.GetAwaiter ().GetResult ()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking MailKit/Net/Proxy/ProxyClient.cs:272— `.GetAwaiter ().GetResult ()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking MailKit/Net/SocketUtils.cs:144— `.GetAwaiter ().GetResult ()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
async void method: ViewDidLoad samples/ImapClientDemo.iOS/ImapClientDemo.iOS/FoldersViewController.cs:49— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: Login samples/ImapClientDemo.iOS/ImapClientDemo.iOS/LoginViewController.cs:70— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: ViewDidLoad samples/ImapClientDemo.iOS/ImapClientDemo.iOS/MessageListViewController.cs:56— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: OnCreate samples/ImapClientDemo.Android/ImapClientDemo.Android/FoldersActivity.cs:46— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: buttonLogin_Click samples/ImapClientDemo.Android/ImapClientDemo.Android/LoginActivity.cs:61— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
async void method: OnCreate samples/ImapClientDemo.Android/ImapClientDemo.Android/MessageListActivity.cs:47— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
Change-coupling hub: SmtpCommandException.cs → ImapProtocolException.cs, Pop3ProtocolException.cs, SmtpProtocolException.cs, ProtocolException.cs MailKit/Net/Smtp/SmtpCommandException.cs— `MailKit/Net/Smtp/SmtpCommandException.cs` changes together with 4 other files — `MailKit/Net/Imap/ImapProtocolException.cs`, `MailKit/Net/Pop3/Pop3ProtocolException.cs`, `MailKit/Net/Smtp/SmtpProtocolException.cs`, `MailKit/ProtocolException.cs` — none of which declares a dependency on it: one file is the hub of 4 separate couplings, not 4 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 4.
Change-coupling hub: Pop3CommandException.cs → Pop3ProtocolException.cs, SmtpProtocolException.cs, ProtocolException.cs MailKit/Net/Pop3/Pop3CommandException.cs— `MailKit/Net/Pop3/Pop3CommandException.cs` changes together with 3 other files — `MailKit/Net/Pop3/Pop3ProtocolException.cs`, `MailKit/Net/Smtp/SmtpProtocolException.cs`, `MailKit/ProtocolException.cs` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
Change-coupling hub: ImapCommandException.cs → ImapProtocolException.cs, Pop3ProtocolException.cs, ProtocolException.cs MailKit/Net/Imap/ImapCommandException.cs— `MailKit/Net/Imap/ImapCommandException.cs` changes together with 3 other files — `MailKit/Net/Imap/ImapProtocolException.cs`, `MailKit/Net/Pop3/Pop3ProtocolException.cs`, `MailKit/ProtocolException.cs` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
Change-coupling hub: SaslException.cs → FolderNotFoundException.cs, ImapCommandException.cs, ImapProtocolException.cs, Pop3CommandException.cs, Pop3ProtocolException.cs, SmtpCommandException.cs, SmtpProtocolException.cs MailKit/Security/SaslException.cs— `MailKit/Security/SaslException.cs` changes together with 7 other files — `MailKit/FolderNotFoundException.cs`, `MailKit/Net/Imap/ImapCommandException.cs`, `MailKit/Net/Imap/ImapProtocolException.cs`, `MailKit/Net/Pop3/Pop3CommandException.cs`, `MailKit/Net/Pop3/Pop3ProtocolException.cs`, `MailKit/Net/Smtp/SmtpCommandException.cs`, `MailKit/Net/Smtp/SmtpProtocolException.cs` — none of which declares a dependency on it: one file is the hub of 7 separate couplings, not 7 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 7.
Change-coupling hub: CommandException.cs → ImapProtocolException.cs, Pop3ProtocolException.cs, SmtpProtocolException.cs, ProtocolException.cs MailKit/CommandException.cs— `MailKit/CommandException.cs` changes together with 4 other files — `MailKit/Net/Imap/ImapProtocolException.cs`, `MailKit/Net/Pop3/Pop3ProtocolException.cs`, `MailKit/Net/Smtp/SmtpProtocolException.cs`, `MailKit/ProtocolException.cs` — none of which declares a dependency on it: one file is the hub of 4 separate couplings, not 4 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 4.
Duplicated block (19 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:377— MailKit/Net/Imap/ImapFolderFetch.cs:377-395 | MailKit/Net/Imap/ImapFolderFetch.cs:621-639 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:377` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) MailKit/Net/Imap/ImapFolder.cs:5179— MailKit/Net/Imap/ImapFolder.cs:5179-5197 | MailKit/Net/Imap/ImapFolder.cs:5430-5448 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:5179` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `MailKit/Net/Imap/ImapFolder.cs:5176` calls `Contains`, `Expunge`, `ExpungeRequest` and `MailKit/Net/Imap/ImapFolder.cs:5428` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (19 lines × 2) MailKit/Net/Imap/ImapFolder.cs:5272— MailKit/Net/Imap/ImapFolder.cs:5272-5290 | MailKit/Net/Imap/ImapFolder.cs:5522-5540 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:5272` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `MailKit/Net/Imap/ImapFolder.cs:5269` calls `Contains`, `ExpungeAsync`, `ExpungeRequest` and `MailKit/Net/Imap/ImapFolder.cs:5520` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (19 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:1284— MailKit/Net/Imap/ImapFolderFetch.cs:1284-1302 | MailKit/Net/Imap/ImapFolderFetch.cs:1380-1398 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:1284` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) MailKit/Net/Pop3/Pop3Stream.cs:473— MailKit/Net/Pop3/Pop3Stream.cs:473-491 | MailKit/Net/Pop3/Pop3Stream.cs:577-595 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Pop3/Pop3Stream.cs:473` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) REDACTED:1218— REDACTED:1218-1226 | REDACTED:1275-1283 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) MailKit/Net/Imap/ImapCommand.cs:554— MailKit/Net/Imap/ImapCommand.cs:554-562 | MailKit/Net/Imap/ImapCommand.cs:696-704 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapCommand.cs:554` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:232— MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:232-241 | MailKit/Security/Ntlm/NtlmNegotiateMessage.cs:108-116 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:232` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) MailKit/Net/NetworkStream.cs:120— MailKit/Net/NetworkStream.cs:120-128 | MailKit/Net/Proxy/ProxyClient.cs:202-210 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9 lines × 2) MailKit/Net/Pop3/Pop3Stream.cs:1130— MailKit/Net/Pop3/Pop3Stream.cs:1130-1138 | MailKit/Net/Smtp/SmtpStream.cs:1142-1150 — before extracting anything, compare `MailKit/Net/Pop3/Pop3Stream.cs` and `MailKit/Net/Smtp/SmtpStream.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 160 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) MailKit/Net/Imap/ImapFolderAnnotations.cs:63— MailKit/Net/Imap/ImapFolderAnnotations.cs:63-67 | MailKit/Net/Imap/ImapFolderAnnotations.cs:271-275 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `MailKit/Net/Imap/ImapFolderAnnotations.cs:268` calls `FormatIndexSet`, `Append` and `MailKit/Net/Imap/ImapFolderAnnotations.cs:61` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 2) MailKit/Net/Imap/ImapFolderAnnotations.cs:63— MailKit/Net/Imap/ImapFolderAnnotations.cs:63-67 | MailKit/Net/Imap/ImapFolderFlags.cs:556-560 — before extracting anything, compare `MailKit/Net/Imap/ImapFolderAnnotations.cs` and `MailKit/Net/Imap/ImapFolderFlags.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 48 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `IStoreAnnotationsRequest` in one and `IStoreLabelsRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (5 lines × 2) MailKit/Net/Imap/ImapFolderSearch.cs:1551— MailKit/Net/Imap/ImapFolderSearch.cs:1551-1555 | MailKit/Net/Imap/ImapFolderSearch.cs:1758-1762 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) MailKit/Net/Imap/AsyncImapClient.cs:712— MailKit/Net/Imap/AsyncImapClient.cs:712-716 | MailKit/Net/Pop3/AsyncPop3Client.cs:524-528 — before extracting anything, compare `MailKit/Net/Imap/AsyncImapClient.cs` and `MailKit/Net/Pop3/AsyncPop3Client.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 79 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) MailKit/Net/Imap/ImapClient.cs:1656— MailKit/Net/Imap/ImapClient.cs:1656-1660 | REDACTED:1338-1342 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
IC1 · Incompleteness & stubs· Dead `#if false` region · ×5
Dead `#if false` region MailKit/Net/Imap/ImapIdleContext.cs:99— Code inside a `#if false` block is permanently excluded from the build — disabled code that should be removed or restored.
Dead `#if false` region MailKit/Net/Smtp/SmtpStream.cs:359— Code inside a `#if false` block is permanently excluded from the build — disabled code that should be removed or restored.
Dead `#if false` region MailKit/Net/Smtp/SmtpStream.cs:449— Code inside a `#if false` block is permanently excluded from the build — disabled code that should be removed or restored.
Dead `#if false` region MailKit/Security/Ntlm/NtlmUtils.cs:135— Code inside a `#if false` block is permanently excluded from the build — disabled code that should be removed or restored.
Dead `#if false` region MailKit/Security/Ntlm/NtlmUtils.cs:181— Code inside a `#if false` block is permanently excluded from the build — disabled code that should be removed or restored.
Sync-over-async (deadlock risk) MailKit/Net/Imap/ImapEngine.cs:3011— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) MailKit/Net/Imap/ImapEngine.cs:3039— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) MailKit/Net/Proxy/ProxyClient.cs:227— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) MailKit/Net/Proxy/ProxyClient.cs:272— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) MailKit/Net/SocketUtils.cs:144— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Duplicated block (21 lines × 2) REDACTED:1786— REDACTED:1786-1806 | REDACTED:1876-1896 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:1786` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (21 lines × 2) MailKit/Net/Imap/ImapCommand.cs:659— MailKit/Net/Imap/ImapCommand.cs:659-679 | MailKit/Net/Imap/ImapCommand.cs:801-821 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapCommand.cs:659` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (21 lines × 2) MailKit/Net/Imap/ImapFolderFlags.cs:191— MailKit/Net/Imap/ImapFolderFlags.cs:191-211 | MailKit/Net/Imap/ImapFolderFlags.cs:620-640 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFlags.cs:191` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `IStoreFlagsRequest` in one and `IStoreLabelsRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (21 lines × 2) MailKit/Net/Imap/ImapFolderFlags.cs:263— MailKit/Net/Imap/ImapFolderFlags.cs:263-283 | MailKit/Net/Imap/ImapFolderFlags.cs:692-712 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFlags.cs:263` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `IStoreFlagsRequest` in one and `IStoreLabelsRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
X18 · Disposal-pattern correctness· Finalizer on a type that owns no unmanaged resource · ×4
Finalizer on a type that owns no unmanaged resource REDACTED:101— `MailService` declares a finalizer (line 101), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
Finalizer on a type that owns no unmanaged resource MailKit/ProtocolLogger.cs:104— `ProtocolLogger` declares a finalizer (line 104), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
Finalizer on a type that owns no unmanaged resource MailKit/Security/Ntlm/MD4.cs:71— `MD4` declares a finalizer (line 71), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
Finalizer on a type that owns no unmanaged resource MailKit/Security/Ntlm/RC4.cs:47— `RC4` declares a finalizer (line 47), but nothing in the type is unmanaged: no `IntPtr`/`UIntPtr` or pointer field, no `SafeHandle`, no `HandleRef`, no `extern`/`DllImport` member and no `Marshal`/`GCHandle`/`NativeMemory` use. A finalizer can only release what the garbage collector cannot, so on a purely-managed type it releases nothing and costs something: every instance is put on the finalizer queue, survives at least one extra collection, and is then finalized on a thread that is NOT the disposing one — where the managed objects it touches may already have been finalized themselves. Delete the finalizer (and the `GC.SuppressFinalize` that exists to defuse it); if a handle is added later, wrap it in a `SafeHandle`, which brings its own correct finalization.
X18 · Disposal-pattern correctness· Owned disposable field is never released · ×4
Owned disposable field is never released MailKit/Net/Imap/ImapClient.cs:70— `ImapClient` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `sslValidationInfo` itself (line 70), which makes that instance its own. But `sslValidationInfo` is named in none of the methods the disposal search covered: `Dispose` (line 2808) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`sslValidationInfo?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Owned disposable field is never released MailKit/Net/Imap/ImapEngine.cs:162— `ImapEngine` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `builder` itself (line 162), which makes that instance its own. But `builder` is named in none of the methods the disposal search covered: `Dispose` (line 4475), `Disconnect` (line 930) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`builder?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Owned disposable field is never released REDACTED:77— `Pop3Client` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `sslValidationInfo` itself (line 77), which makes that instance its own. But `sslValidationInfo` is named in none of the methods the disposal search covered: `Dispose` (line 3392) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`sslValidationInfo?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Owned disposable field is never released REDACTED:87— `SmtpClient` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `sslValidationInfo` itself (line 87), which makes that instance its own. But `sslValidationInfo` is named in none of the methods the disposal search covered: `Dispose` (line 2783), `Disconnect` (line 1743), `Disconnect` (line 1799) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`sslValidationInfo?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Duplicated block (25 lines × 2) MailKit/Net/Imap/AsyncImapClient.cs:355— MailKit/Net/Imap/AsyncImapClient.cs:355-379 | MailKit/Net/Imap/ImapClient.cs:1225-1249 — before extracting anything, compare `MailKit/Net/Imap/AsyncImapClient.cs` and `MailKit/Net/Imap/ImapClient.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 104 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/AsyncImapClient.cs:355` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (25 lines × 2) MailKit/Net/Smtp/AsyncSmtpClient.cs:396— MailKit/Net/Smtp/AsyncSmtpClient.cs:396-420 | REDACTED:1260-1284 — before extracting anything, compare `MailKit/Net/Smtp/AsyncSmtpClient.cs` and `REDACTED` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 108 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Smtp/AsyncSmtpClient.cs:396` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (25 lines × 2) MailKit/UniqueIdSet.cs:300— MailKit/UniqueIdSet.cs:300-324 | MailKit/UniqueIdSet.cs:357-381 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/UniqueIdSet.cs:300` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) MailKit/Net/Imap/ImapFolder.cs:6146— MailKit/Net/Imap/ImapFolder.cs:6146-6158 | MailKit/Net/Imap/ImapFolder.cs:6218-6230 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:1592— MailKit/Net/Imap/ImapFolderFetch.cs:1592-1604 | MailKit/Net/Imap/ImapFolderFetch.cs:1815-1827 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:1592` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (13 lines × 2) REDACTED:1990— REDACTED:1990-2002 | REDACTED:2097-2109 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:1990` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 6) MailKit/Net/Imap/AsyncImapClient.cs:625— MailKit/Net/Imap/AsyncImapClient.cs:625-631 | MailKit/Net/Imap/AsyncImapClient.cs:794-800 | MailKit/Net/Pop3/AsyncPop3Client.cs:437-443 | MailKit/Net/Pop3/AsyncPop3Client.cs:606-612 | MailKit/Net/Smtp/AsyncSmtpClient.cs:579-585 | MailKit/Net/Smtp/AsyncSmtpClient.cs:751-757 — before extracting anything, compare `MailKit/Net/Imap/AsyncImapClient.cs` and `MailKit/Net/Pop3/AsyncPop3Client.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 79 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/AsyncImapClient.cs:625` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 6) MailKit/Net/Imap/ImapFolder.cs:4468— MailKit/Net/Imap/ImapFolder.cs:4468-4474 | MailKit/Net/Imap/ImapFolder.cs:5799-5805 | MailKit/Net/Imap/ImapFolder.cs:6044-6050 | MailKit/Net/Imap/ImapFolderAnnotations.cs:221-227 | MailKit/Net/Imap/ImapFolderFlags.cs:264-270 | MailKit/Net/Imap/ImapFolderFlags.cs:693-699 — before extracting anything, compare `MailKit/Net/Imap/ImapFolderAnnotations.cs` and `MailKit/Net/Imap/ImapFolderFlags.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 48 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `IExpungeRequest` in one and `ICopyRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (7 lines × 6) MailKit/Net/Imap/ImapFolderAnnotations.cs:337— MailKit/Net/Imap/ImapFolderAnnotations.cs:337-343 | MailKit/Net/Imap/ImapFolderAnnotations.cs:408-414 | MailKit/Net/Imap/ImapFolderFlags.cs:393-399 | MailKit/Net/Imap/ImapFolderFlags.cs:459-465 | MailKit/Net/Imap/ImapFolderFlags.cs:822-828 | MailKit/Net/Imap/ImapFolderFlags.cs:888-894 — before extracting anything, compare `MailKit/Net/Imap/ImapFolderAnnotations.cs` and `MailKit/Net/Imap/ImapFolderFlags.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 48 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `IStoreAnnotationsRequest` in one and `IStoreFlagsRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (45 lines × 2) MailKit/BodyPart.cs:322— MailKit/BodyPart.cs:322-366 | MailKit/Envelope.cs:371-415 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (45 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:2158— MailKit/Net/Imap/ImapFolderFetch.cs:2158-2202 | MailKit/Net/Imap/ImapFolderFetch.cs:2401-2445 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:2158` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (29 lines × 2) MailKit/Net/Smtp/AsyncSmtpClient.cs:330— MailKit/Net/Smtp/AsyncSmtpClient.cs:330-358 | REDACTED:1197-1225 — before extracting anything, compare `MailKit/Net/Smtp/AsyncSmtpClient.cs` and `REDACTED` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 108 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Smtp/AsyncSmtpClient.cs:330` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (29 lines × 2) MailKit/Net/Imap/ImapClient.cs:1732— MailKit/Net/Imap/ImapClient.cs:1732-1760 | REDACTED:1417-1445 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapClient.cs:1732` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23 lines × 2) MailKit/Net/Imap/ImapEngine.cs:1678— MailKit/Net/Imap/ImapEngine.cs:1678-1700 | MailKit/Net/Imap/ImapEngine.cs:1773-1795 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapEngine.cs:1678` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23 lines × 2) MailKit/Net/Imap/ImapStream.cs:275— MailKit/Net/Imap/ImapStream.cs:275-297 | MailKit/Net/Pop3/Pop3Stream.cs:273-295 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapStream.cs:275` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (22 lines × 2) MailKit/Net/Imap/AsyncImapClient.cs:400— MailKit/Net/Imap/AsyncImapClient.cs:400-421 | MailKit/Net/Imap/ImapClient.cs:1273-1294 — before extracting anything, compare `MailKit/Net/Imap/AsyncImapClient.cs` and `MailKit/Net/Imap/ImapClient.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 104 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/AsyncImapClient.cs:400` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (22 lines × 2) MailKit/Net/Smtp/AsyncSmtpClient.cs:240— MailKit/Net/Smtp/AsyncSmtpClient.cs:240-261 | MailKit/Net/Smtp/AsyncSmtpClient.cs:380-401 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Smtp/AsyncSmtpClient.cs:240` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20 lines × 2) MailKit/Net/Imap/AsyncImapClient.cs:612— MailKit/Net/Imap/AsyncImapClient.cs:612-631 | MailKit/Net/Pop3/AsyncPop3Client.cs:424-443 — before extracting anything, compare `MailKit/Net/Imap/AsyncImapClient.cs` and `MailKit/Net/Pop3/AsyncPop3Client.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 79 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/AsyncImapClient.cs:612` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20 lines × 2) MailKit/Net/Imap/ImapClient.cs:1541— MailKit/Net/Imap/ImapClient.cs:1541-1560 | REDACTED:1220-1239 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapClient.cs:1541` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:3698— MailKit/Net/Imap/ImapFolderFetch.cs:3698-3715 | MailKit/Net/Imap/ImapFolderFetch.cs:4010-4027 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:3698` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 2) MailKit/Net/Pop3/Pop3Engine.cs:462— MailKit/Net/Pop3/Pop3Engine.cs:462-479 | MailKit/Net/Pop3/Pop3Engine.cs:497-514 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Pop3/Pop3Engine.cs:462` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 3) MailKit/Net/Imap/AsyncImapClient.cs:810— MailKit/Net/Imap/AsyncImapClient.cs:810-820 | MailKit/Net/Pop3/AsyncPop3Client.cs:622-632 | MailKit/Net/Smtp/AsyncSmtpClient.cs:769-779 — before extracting anything, compare `MailKit/Net/Imap/AsyncImapClient.cs` and `MailKit/Net/Pop3/AsyncPop3Client.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 79 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/AsyncImapClient.cs:810` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 3) MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:434— MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:434-444 | MailKit/Security/Ntlm/NtlmChallengeMessage.cs:196-206 | MailKit/Security/Ntlm/NtlmNegotiateMessage.cs:153-163 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:434` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 3) MailKit/Net/Imap/AsyncImapClient.cs:623— MailKit/Net/Imap/AsyncImapClient.cs:623-631 | MailKit/Net/Imap/AsyncImapClient.cs:792-800 | MailKit/Net/Pop3/AsyncPop3Client.cs:435-443 — before extracting anything, compare `MailKit/Net/Imap/AsyncImapClient.cs` and `MailKit/Net/Pop3/AsyncPop3Client.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 79 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/AsyncImapClient.cs:623` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 3) MailKit/Net/Imap/ImapClient.cs:1552— MailKit/Net/Imap/ImapClient.cs:1552-1560 | MailKit/Net/Imap/ImapClient.cs:1732-1740 | REDACTED:1231-1239 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapClient.cs:1552` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) MailKit/Net/Imap/ImapEngine.cs:2240— MailKit/Net/Imap/ImapEngine.cs:2240-2245 | MailKit/Net/Imap/ImapEngine.cs:2590-2595 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapEngine.cs:2240` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) MailKit/Net/Smtp/AsyncSmtpClient.cs:977— MailKit/Net/Smtp/AsyncSmtpClient.cs:977-982 | REDACTED:2443-2448 — before extracting anything, compare `MailKit/Net/Smtp/AsyncSmtpClient.cs` and `REDACTED` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 108 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Smtp/AsyncSmtpClient.cs:977` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8–10 lines × 2) MailKit/Security/Ntlm/MD4.cs:226— MailKit/Security/Ntlm/MD4.cs:226-235 | MailKit/Security/Ntlm/MD4.cs:236-243 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8–10 lines × 2) MailKit/Security/Ntlm/MD4.cs:244— MailKit/Security/Ntlm/MD4.cs:244-253 | MailKit/Security/Ntlm/MD4.cs:254-261 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Unfinished stub — throws NotImplementedException MailKit/Net/Smtp/SmtpStream.cs:357— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException MailKit/Net/Smtp/SmtpStream.cs:447— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
SaslMechanism.IsProhibited (cyclomatic 70) MailKit/Security/SaslMechanism.cs:711— SaslMechanism.IsProhibited has cyclomatic complexity 70 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
ImapFolder.BuildQuery (cyclomatic 66) MailKit/Net/Imap/ImapFolderSearch.cs:112— ImapFolder.BuildQuery has cyclomatic complexity 66 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
ImapEngine.ParseResponseCode (cyclomatic 50) MailKit/Net/Imap/ImapEngine.cs:1985— ImapEngine.ParseResponseCode has cyclomatic complexity 50 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (ImapEngine.ParseResponseCodeAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapEngine.ParseResponseCodeAsync (cyclomatic 50) MailKit/Net/Imap/ImapEngine.cs:2335— ImapEngine.ParseResponseCodeAsync has cyclomatic complexity 50 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (ImapEngine.ParseResponseCode) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapFolder.FormatSummaryItems (cyclomatic 45) MailKit/Net/Imap/ImapFolderFetch.cs:810— ImapFolder.FormatSummaryItems has cyclomatic complexity 45 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapFolder.ParseSummaryItems (cyclomatic 41) MailKit/Net/Imap/ImapFolderFetch.cs:299— ImapFolder.ParseSummaryItems has cyclomatic complexity 41 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (ImapFolder.ParseSummaryItemsAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapFolder.ParseSummaryItemsAsync (cyclomatic 41) MailKit/Net/Imap/ImapFolderFetch.cs:543— ImapFolder.ParseSummaryItemsAsync has cyclomatic complexity 41 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (ImapFolder.ParseSummaryItems) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
BodyPart.TryParse (cyclomatic 38) MailKit/BodyPart.cs:608— BodyPart.TryParse has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapFolder.FetchStream (cyclomatic 38) MailKit/Net/Imap/ImapFolderFetch.cs:2091— ImapFolder.FetchStream has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (ImapFolder.FetchStreamAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapFolder.FetchStreamAsync (cyclomatic 38) MailKit/Net/Imap/ImapFolderFetch.cs:2334— ImapFolder.FetchStreamAsync has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (ImapFolder.FetchStream) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapEngine.ProcessUntaggedResponse (cyclomatic 33) MailKit/Net/Imap/ImapEngine.cs:2912— ImapEngine.ProcessUntaggedResponse has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (ImapEngine.ProcessUntaggedResponseAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapEngine.ProcessUntaggedResponseAsync (cyclomatic 33) MailKit/Net/Imap/ImapEngine.cs:3070— ImapEngine.ProcessUntaggedResponseAsync has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (ImapEngine.ProcessUntaggedResponse) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
AnnotationEntry.Parse (cyclomatic 30) MailKit/AnnotationEntry.cs:424— AnnotationEntry.Parse has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapFolder.ParseESearchResults (cyclomatic 28) MailKit/Net/Imap/ImapFolderSearch.cs:460— ImapFolder.ParseESearchResults has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (ImapFolder.ParseESearchResultsAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapFolder.ParseESearchResultsAsync (cyclomatic 28) MailKit/Net/Imap/ImapFolderSearch.cs:613— ImapFolder.ParseESearchResultsAsync has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (ImapFolder.ParseESearchResults) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapFolder.QueueSearchCommand (cyclomatic 27) MailKit/Net/Imap/ImapFolderSearch.cs:1037— ImapFolder.QueueSearchCommand has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Pop3AuthenticationSecretDetector.DetectUserPassSecrets (cyclomatic 27) MailKit/Net/Pop3/Pop3AuthenticationSecretDetector.cs:202— Pop3AuthenticationSecretDetector.DetectUserPassSecrets has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapCommand.Step (cyclomatic 26) MailKit/Net/Imap/ImapCommand.cs:552— ImapCommand.Step has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (ImapCommand.StepAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapCommand.StepAsync (cyclomatic 26) MailKit/Net/Imap/ImapCommand.cs:694— ImapCommand.StepAsync has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (ImapCommand.Step) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapUtils.ParseInternalDate (cyclomatic 26) REDACTED:152— ImapUtils.ParseInternalDate has cyclomatic complexity 26 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
SmtpAuthenticationSecretDetector.DetectSecrets (cyclomatic 26) MailKit/Net/Smtp/SmtpAuthenticationSecretDetector.cs:72— SmtpAuthenticationSecretDetector.DetectSecrets has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MessageThreader.GetThreadableSubject (cyclomatic 25) MailKit/MessageThreader.cs:516— MessageThreader.GetThreadableSubject has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapFolder.QueueSortCommand (cyclomatic 25) MailKit/Net/Imap/ImapFolderSearch.cs:1729— ImapFolder.QueueSortCommand has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DigestChallenge.Parse (cyclomatic 25) MailKit/Security/SaslMechanismDigestMd5.cs:351— DigestChallenge.Parse has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Envelope.TryParse (cyclomatic 23) MailKit/Envelope.cs:528— Envelope.TryParse has cyclomatic complexity 23 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ImapAuthenticationSecretDetector.DetectAuthSecrets (cyclomatic 23) MailKit/Net/Imap/ImapAuthenticationSecretDetector.cs:119— ImapAuthenticationSecretDetector.DetectAuthSecrets has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapSearchQueryOptimizer.Reduce (cyclomatic 23) MailKit/Net/Imap/ImapSearchQueryOptimizer.cs:34— ImapSearchQueryOptimizer.Reduce has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Pop3AuthenticationSecretDetector.DetectAuthSecrets (cyclomatic 23) MailKit/Net/Pop3/Pop3AuthenticationSecretDetector.cs:133— Pop3AuthenticationSecretDetector.DetectAuthSecrets has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AnnotationEntry.ValidatePath (cyclomatic 22) MailKit/AnnotationEntry.cs:112— AnnotationEntry.ValidatePath has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ImapEngine.ProcessCapabilityToken (cyclomatic 22) MailKit/Net/Imap/ImapEngine.cs:1470— ImapEngine.ProcessCapabilityToken has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ImapToken.Create (cyclomatic 22) MailKit/Net/Imap/ImapToken.cs:126— ImapToken.Create has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapUtils.AddFolderAttribute (cyclomatic 22) REDACTED:553— ImapUtils.AddFolderAttribute has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SaslMechanismScramBase.Challenge (cyclomatic 22) MailKit/Security/SaslMechanismScramBase.cs:301— SaslMechanismScramBase.Challenge has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UniqueIdSet.TryParse (cyclomatic 22) MailKit/UniqueIdSet.cs:914— UniqueIdSet.TryParse has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapEventGroup.Format (cyclomatic 21) MailKit/Net/Imap/ImapEventGroup.cs:118— ImapEventGroup.Format has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapFolder.ProcessResponseCodes (cyclomatic 21) MailKit/Net/Imap/ImapFolder.cs:235— ImapFolder.ProcessResponseCodes has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapFolder.QueueCreateCommand (cyclomatic 21) MailKit/Net/Imap/ImapFolder.cs:982— ImapFolder.QueueCreateCommand has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Pop3Engine.ParseCapaResponse (cyclomatic 21) MailKit/Net/Pop3/Pop3Engine.cs:679— Pop3Engine.ParseCapaResponse has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SslHandshakeException.Create (cyclomatic 21) MailKit/Security/SslHandshakeException.cs:119— SslHandshakeException.Create has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MultipartRelatedImageContext.HtmlTagCallback (cyclomatic 21) samples/ImapClientDemo/ImapClientDemo/MultipartRelatedImageContext.cs:61— MultipartRelatedImageContext.HtmlTagCallback has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MessageThreader.GroupBySubject (cyclomatic 20) MailKit/MessageThreader.cs:263— MessageThreader.GroupBySubject has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapCommand.ImapCommand.ctor (cyclomatic 20) MailKit/Net/Imap/ImapCommand.cs:143— ImapCommand.ImapCommand.ctor has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapEngine.GetStatusQuery (cyclomatic 20) MailKit/Net/Imap/ImapEngine.cs:4122— ImapEngine.GetStatusQuery has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SmtpClient.Prepare (cyclomatic 20) REDACTED:2348— SmtpClient.Prepare has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MessageThreader.CreateIdTable (cyclomatic 19) MailKit/MessageThreader.cs:151— MessageThreader.CreateIdTable has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapAuthenticationSecretDetector.SkipLoginToken (cyclomatic 19) MailKit/Net/Imap/ImapAuthenticationSecretDetector.cs:241— ImapAuthenticationSecretDetector.SkipLoginToken has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapFolder.CreateStoreCommands (cyclomatic 19) MailKit/Net/Imap/ImapFolderFlags.cs:92— ImapFolder.CreateStoreCommands has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapFolder.TryCreateStoreCommand (cyclomatic 19) MailKit/Net/Imap/ImapFolderFlags.cs:285— ImapFolder.TryCreateStoreCommand has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Pop3AuthenticationSecretDetector.DetectSecrets (cyclomatic 18) MailKit/Net/Pop3/Pop3AuthenticationSecretDetector.cs:285— Pop3AuthenticationSecretDetector.DetectSecrets has cyclomatic complexity 18 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
Pop3Stream.Read (cyclomatic 18) MailKit/Net/Pop3/Pop3Stream.cs:380— Pop3Stream.Read has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SmtpStream.ReadResponse (cyclomatic 18) MailKit/Net/Smtp/SmtpStream.cs:494— SmtpStream.ReadResponse has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BodyPart.TryParse (cyclomatic 17) MailKit/BodyPart.cs:433— BodyPart.TryParse has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Envelope.TryParse (cyclomatic 17) MailKit/Envelope.cs:463— Envelope.TryParse has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapAuthenticationSecretDetector.SkipLiteralToken (cyclomatic 17) MailKit/Net/Imap/ImapAuthenticationSecretDetector.cs:188— ImapAuthenticationSecretDetector.SkipLiteralToken has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapClient.TryQueueEnableCommand (cyclomatic 17) MailKit/Net/Imap/ImapClient.cs:354— ImapClient.TryQueueEnableCommand has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ImapEngine.DetectQuirksMode (cyclomatic 17) MailKit/Net/Imap/ImapEngine.cs:759— ImapEngine.DetectQuirksMode has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ImapFolder.BuildSortOrder (cyclomatic 17) MailKit/Net/Imap/ImapFolderSearch.cs:411— ImapFolder.BuildSortOrder has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapUtils.FormatIndexSet (cyclomatic 17) REDACTED:262— ImapUtils.FormatIndexSet has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapAuthenticationSecretDetector.DetectSecrets (cyclomatic 16) MailKit/Net/Imap/ImapAuthenticationSecretDetector.cs:355— ImapAuthenticationSecretDetector.DetectSecrets has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
EnvelopeAddress.ToMailboxAddress (cyclomatic 16) REDACTED:2170— EnvelopeAddress.ToMailboxAddress has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
Pop3AuthenticationSecretDetector.DetectApopSecrets (cyclomatic 16) MailKit/Net/Pop3/Pop3AuthenticationSecretDetector.cs:84— Pop3AuthenticationSecretDetector.DetectApopSecrets has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D11 · Test Reliability· Test reliability not measured · ×1
Test reliability not measured — test suite did not build — Test reliability NOT MEASURED: this repository did not build in our analyzer environment (a C#/MSBuild compiler error), so no test ever ran and flakiness could not be exercised. It is excluded from the score rather than counted as a defect. We did not read WHERE the failing diagnostic is, so this does not claim the fault is in your test code — a repository written for an older SDK band can compile for you and not for us. Run `dotnet build` on this commit: if it succeeds, the gap is ours and nothing here is a defect in your code.
D18 · Solution Shape· Solution references a project that does not exist · ×1
Solution references a project that does not exist MailKit.sln— `MailKit.sln` declares 1 project file(s) that are missing from the tree (`submodules/MimeKit/MimeKit/MimeKit.csproj`). A solution-level restore or build fails on a dangling reference, so anyone building the solution rather than an individual project is blocked. Delete the stale entry from the solution, or restore the missing project file.
D18 · Solution Shape· Solution references 2 projects that do not exist · ×1
Solution references 2 projects that do not exist MailKit.Documentation.sln— `MailKit.Documentation.sln` declares 2 project file(s) that are missing from the tree (`submodules/MimeKit/MimeKit.Cryptography/MimeKit.Cryptography.csproj`, `submodules/MimeKit/MimeKit/MimeKit.csproj`). A solution-level restore or build fails on a dangling reference, so anyone building the solution rather than an individual project is blocked. Delete the stale entry from the solution, or restore the missing project file.
ImapFolder.ParseSummaryItems (cognitive 105) MailKit/Net/Imap/ImapFolderFetch.cs:299— ImapFolder.ParseSummaryItems has cognitive complexity 105 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function. This shape REPEATS in the file: one other method here (ImapFolder.ParseSummaryItemsAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapFolder.ParseSummaryItemsAsync (cognitive 105) MailKit/Net/Imap/ImapFolderFetch.cs:543— ImapFolder.ParseSummaryItemsAsync has cognitive complexity 105 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function. This shape REPEATS in the file: one other method here (ImapFolder.ParseSummaryItems) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapFolder.FetchStream (cognitive 90) MailKit/Net/Imap/ImapFolderFetch.cs:2091— ImapFolder.FetchStream has cognitive complexity 90 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapFolder.FetchStreamAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapFolder.FetchStreamAsync (cognitive 90) MailKit/Net/Imap/ImapFolderFetch.cs:2334— ImapFolder.FetchStreamAsync has cognitive complexity 90 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapFolder.FetchStream) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
BodyPart.TryParse (cognitive 69) MailKit/BodyPart.cs:608— BodyPart.TryParse has cognitive complexity 69 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapFolder.FormatSummaryItems (cognitive 68) MailKit/Net/Imap/ImapFolderFetch.cs:810— ImapFolder.FormatSummaryItems has cognitive complexity 68 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapEngine.ProcessUntaggedResponse (cognitive 56) MailKit/Net/Imap/ImapEngine.cs:2912— ImapEngine.ProcessUntaggedResponse has cognitive complexity 56 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function. This shape REPEATS in the file: one other method here (ImapEngine.ProcessUntaggedResponseAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapEngine.ProcessUntaggedResponseAsync (cognitive 56) MailKit/Net/Imap/ImapEngine.cs:3070— ImapEngine.ProcessUntaggedResponseAsync has cognitive complexity 56 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function. This shape REPEATS in the file: one other method here (ImapEngine.ProcessUntaggedResponse) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapFolder.ParseESearchResults (cognitive 56) MailKit/Net/Imap/ImapFolderSearch.cs:460— ImapFolder.ParseESearchResults has cognitive complexity 56 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapFolder.ParseESearchResultsAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapFolder.ParseESearchResultsAsync (cognitive 56) MailKit/Net/Imap/ImapFolderSearch.cs:613— ImapFolder.ParseESearchResultsAsync has cognitive complexity 56 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapFolder.ParseESearchResults) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapEngine.ParseResponseCode (cognitive 54) MailKit/Net/Imap/ImapEngine.cs:1985— ImapEngine.ParseResponseCode has cognitive complexity 54 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapEngine.ParseResponseCodeAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapEngine.ParseResponseCodeAsync (cognitive 54) MailKit/Net/Imap/ImapEngine.cs:2335— ImapEngine.ParseResponseCodeAsync has cognitive complexity 54 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapEngine.ParseResponseCode) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
AnnotationEntry.Parse (cognitive 52) MailKit/AnnotationEntry.cs:424— AnnotationEntry.Parse has cognitive complexity 52 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SslHandshakeException.Create (cognitive 49) MailKit/Security/SslHandshakeException.cs:119— SslHandshakeException.Create has cognitive complexity 49 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapCommand.Step (cognitive 44) MailKit/Net/Imap/ImapCommand.cs:552— ImapCommand.Step has cognitive complexity 44 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapCommand.StepAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapCommand.StepAsync (cognitive 44) MailKit/Net/Imap/ImapCommand.cs:694— ImapCommand.StepAsync has cognitive complexity 44 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapCommand.Step) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapToken.Create (cognitive 44) MailKit/Net/Imap/ImapToken.cs:126— ImapToken.Create has cognitive complexity 44 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UniqueIdSet.TryParse (cognitive 44) MailKit/UniqueIdSet.cs:914— UniqueIdSet.TryParse has cognitive complexity 44 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Pop3AuthenticationSecretDetector.DetectUserPassSecrets (cognitive 43) MailKit/Net/Pop3/Pop3AuthenticationSecretDetector.cs:202— Pop3AuthenticationSecretDetector.DetectUserPassSecrets has cognitive complexity 43 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MultipartRelatedImageContext.HtmlTagCallback (cognitive 42) samples/ImapClientDemo/ImapClientDemo/MultipartRelatedImageContext.cs:61— MultipartRelatedImageContext.HtmlTagCallback has cognitive complexity 42 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
MessageThreader.GetThreadableSubject (cognitive 41) MailKit/MessageThreader.cs:516— MessageThreader.GetThreadableSubject has cognitive complexity 41 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapEngine.UpdateNamespaces (cognitive 41) MailKit/Net/Imap/ImapEngine.cs:1646— ImapEngine.UpdateNamespaces has cognitive complexity 41 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapEngine.UpdateNamespacesAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapEngine.UpdateNamespacesAsync (cognitive 41) MailKit/Net/Imap/ImapEngine.cs:1741— ImapEngine.UpdateNamespacesAsync has cognitive complexity 41 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapEngine.UpdateNamespaces) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapFolder.QueueSearchCommand (cognitive 41) MailKit/Net/Imap/ImapFolderSearch.cs:1037— ImapFolder.QueueSearchCommand has cognitive complexity 41 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapFolder.QueueSortCommand (cognitive 41) MailKit/Net/Imap/ImapFolderSearch.cs:1729— ImapFolder.QueueSortCommand has cognitive complexity 41 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SmtpAuthenticationSecretDetector.DetectSecrets (cognitive 38) MailKit/Net/Smtp/SmtpAuthenticationSecretDetector.cs:72— SmtpAuthenticationSecretDetector.DetectSecrets has cognitive complexity 38 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SmtpStream.ReadResponse (cognitive 38) MailKit/Net/Smtp/SmtpStream.cs:494— SmtpStream.ReadResponse has cognitive complexity 38 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SaslMechanismScramBase.Challenge (cognitive 37) MailKit/Security/SaslMechanismScramBase.cs:301— SaslMechanismScramBase.Challenge has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapAuthenticationSecretDetector.DetectAuthSecrets (cognitive 36) MailKit/Net/Imap/ImapAuthenticationSecretDetector.cs:119— ImapAuthenticationSecretDetector.DetectAuthSecrets has cognitive complexity 36 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Pop3AuthenticationSecretDetector.DetectAuthSecrets (cognitive 36) MailKit/Net/Pop3/Pop3AuthenticationSecretDetector.cs:133— Pop3AuthenticationSecretDetector.DetectAuthSecrets has cognitive complexity 36 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DigestChallenge.Parse (cognitive 36) MailKit/Security/SaslMechanismDigestMd5.cs:351— DigestChallenge.Parse has cognitive complexity 36 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessageThreader.CreateIdTable (cognitive 35) MailKit/MessageThreader.cs:151— MessageThreader.CreateIdTable has cognitive complexity 35 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RenderMessageCommand.DownloadBodyPart (cognitive 35) samples/ImapClientDemo/ImapClientDemo/MainWindow.cs:128— RenderMessageCommand.DownloadBodyPart has cognitive complexity 35 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
SaslMechanism.IsProhibited (cognitive 34) MailKit/Security/SaslMechanism.cs:711— SaslMechanism.IsProhibited has cognitive complexity 34 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
ImapAuthenticationSecretDetector.SkipLoginToken (cognitive 32) MailKit/Net/Imap/ImapAuthenticationSecretDetector.cs:241— ImapAuthenticationSecretDetector.SkipLoginToken has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapCommand.ImapCommand.ctor (cognitive 32) MailKit/Net/Imap/ImapCommand.cs:143— ImapCommand.ImapCommand.ctor has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SmtpClient.Prepare (cognitive 32) REDACTED:2348— SmtpClient.Prepare has cognitive complexity 32 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ImapFolder.BuildQuery (cognitive 31) MailKit/Net/Imap/ImapFolderSearch.cs:112— ImapFolder.BuildQuery has cognitive complexity 31 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
Pop3Stream.Read (cognitive 31) MailKit/Net/Pop3/Pop3Stream.cs:380— Pop3Stream.Read has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapEventGroup.Format (cognitive 30) MailKit/Net/Imap/ImapEventGroup.cs:118— ImapEventGroup.Format has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BodyPartCollection.IndexOf (cognitive 29) MailKit/BodyPartCollection.cs:207— BodyPartCollection.IndexOf has cognitive complexity 29 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
Pop3Engine.ParseCapaResponse (cognitive 29) MailKit/Net/Pop3/Pop3Engine.cs:679— Pop3Engine.ParseCapaResponse has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapUtils.FormatIndexSet (cognitive 28) REDACTED:262— ImapUtils.FormatIndexSet has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessageSummary.TryGetMessageBody (cognitive 27) MailKit/MessageSummary.cs:173— MessageSummary.TryGetMessageBody has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ByteArrayBuilder.Equals (cognitive 26) MailKit/ByteArrayBuilder.cs:99— ByteArrayBuilder.Equals has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapEngine.ProcessCapabilityToken (cognitive 26) MailKit/Net/Imap/ImapEngine.cs:1470— ImapEngine.ProcessCapabilityToken has cognitive complexity 26 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
ImapFolder.TryQueueGetSubfoldersCommand (cognitive 26) MailKit/Net/Imap/ImapFolder.cs:1618— ImapFolder.TryQueueGetSubfoldersCommand has cognitive complexity 26 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
SmtpClient.AuthenticateAsync (cognitive 26) MailKit/Net/Smtp/AsyncSmtpClient.cs:328— SmtpClient.AuthenticateAsync has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapEngine.GetStatusQuery (cognitive 25) MailKit/Net/Imap/ImapEngine.cs:4122— ImapEngine.GetStatusQuery has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UniqueIdSet.BinaryInsertAscending (cognitive 25) MailKit/UniqueIdSet.cs:269— UniqueIdSet.BinaryInsertAscending has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (UniqueIdSet.BinaryInsertDescending) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
UniqueIdSet.BinaryInsertDescending (cognitive 25) MailKit/UniqueIdSet.cs:326— UniqueIdSet.BinaryInsertDescending has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (UniqueIdSet.BinaryInsertAscending) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
Envelope.TryParse (cognitive 24) MailKit/Envelope.cs:528— Envelope.TryParse has cognitive complexity 24 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
Envelope.TryParse (cognitive 23) MailKit/Envelope.cs:463— Envelope.TryParse has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapEncoding.Decode (cognitive 23) MailKit/Net/Imap/ImapEncoding.cs:45— ImapEncoding.Decode has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapEngine.QueueGetFoldersCommand (cognitive 23) MailKit/Net/Imap/ImapEngine.cs:4172— ImapEngine.QueueGetFoldersCommand has cognitive complexity 23 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
SmtpClient.Authenticate (cognitive 23) REDACTED:1195— SmtpClient.Authenticate has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ProtocolLogger.Log (cognitive 23) MailKit/ProtocolLogger.cs:228— ProtocolLogger.Log has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AnnotationAttribute.ValidateName (cognitive 22) MailKit/AnnotationAttribute.cs:151— AnnotationAttribute.ValidateName has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessageThreader.GroupBySubject (cognitive 22) MailKit/MessageThreader.cs:263— MessageThreader.GroupBySubject has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapClient.AuthenticateAsync (cognitive 22) MailKit/Net/Imap/AsyncImapClient.cs:353— ImapClient.AuthenticateAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapAuthenticationSecretDetector.SkipLiteralToken (cognitive 22) MailKit/Net/Imap/ImapAuthenticationSecretDetector.cs:188— ImapAuthenticationSecretDetector.SkipLiteralToken has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapClient.Authenticate (cognitive 22) MailKit/Net/Imap/ImapClient.cs:1223— ImapClient.Authenticate has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapFolder.ProcessResponseCodes (cognitive 22) MailKit/Net/Imap/ImapFolder.cs:235— ImapFolder.ProcessResponseCodes has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapFolder.CreateStoreCommands (cognitive 22) MailKit/Net/Imap/ImapFolderFlags.cs:92— ImapFolder.CreateStoreCommands has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapFolder.TryCreateStoreCommand (cognitive 22) MailKit/Net/Imap/ImapFolderFlags.cs:285— ImapFolder.TryCreateStoreCommand has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ClientCommandPipeline.MainLoop (cognitive 22) samples/ImapClientDemo/ImapClientDemo/ClientCommandPipeline.cs:55— ClientCommandPipeline.MainLoop has cognitive complexity 22 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
AnnotationEntry.ValidatePath (cognitive 21) MailKit/AnnotationEntry.cs:112— AnnotationEntry.ValidatePath has cognitive complexity 21 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
BodyPart.TryParse (cognitive 21) MailKit/BodyPart.cs:433— BodyPart.TryParse has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapUtils.AddFolderAttribute (cognitive 21) REDACTED:553— ImapUtils.AddFolderAttribute has cognitive complexity 21 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
Pop3Client.AuthenticateAsync (cognitive 21) MailKit/Net/Pop3/AsyncPop3Client.cs:222— Pop3Client.AuthenticateAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Pop3AuthenticationSecretDetector.DetectApopSecrets (cognitive 21) MailKit/Net/Pop3/Pop3AuthenticationSecretDetector.cs:84— Pop3AuthenticationSecretDetector.DetectApopSecrets has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Pop3Client.Authenticate (cognitive 21) REDACTED:959— Pop3Client.Authenticate has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SocketUtils.Connect (cognitive 21) MailKit/Net/SocketUtils.cs:111— SocketUtils.Connect has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SaslMechanismDigestMd5.Challenge (cognitive 21) MailKit/Security/SaslMechanismDigestMd5.cs:134— SaslMechanismDigestMd5.Challenge has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UniqueIdSet.BinarySearch (cognitive 21) MailKit/UniqueIdSet.cs:220— UniqueIdSet.BinarySearch has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Envelope.Encode (cognitive 20) MailKit/Envelope.cs:241— Envelope.Encode has cognitive complexity 20 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
NtlmAuthenticateMessage.ComputeNtlmV2 (cognitive 20) MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:269— NtlmAuthenticateMessage.ComputeNtlmV2 has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapEncoding.Encode (cognitive 19) MailKit/Net/Imap/ImapEncoding.cs:107— ImapEncoding.Encode has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapFolder.QueueCreateCommand (cognitive 19) MailKit/Net/Imap/ImapFolder.cs:982— ImapFolder.QueueCreateCommand has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapFolder.CreateMultiAppendCommand (cognitive 19) MailKit/Net/Imap/ImapFolder.cs:4761— ImapFolder.CreateMultiAppendCommand has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapUtils.ParseInternalDate (cognitive 19) REDACTED:152— ImapUtils.ParseInternalDate has cognitive complexity 19 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
ImapUtils.ParseBody (cognitive 19) REDACTED:1933— ImapUtils.ParseBody has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapUtils.ParseBodyAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapUtils.ParseBodyAsync (cognitive 19) REDACTED:2040— ImapUtils.ParseBodyAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapUtils.ParseBody) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
UniqueIdSet.EnumerateRanges (cognitive 19) MailKit/UniqueIdSet.cs:863— UniqueIdSet.EnumerateRanges has cognitive complexity 19 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
ImapClient.PostConnectAsync (cognitive 18) MailKit/Net/Imap/AsyncImapClient.cs:476— ImapClient.PostConnectAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapAuthenticationSecretDetector.DetectSecrets (cognitive 18) MailKit/Net/Imap/ImapAuthenticationSecretDetector.cs:355— ImapAuthenticationSecretDetector.DetectSecrets has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapClient.PostConnect (cognitive 18) MailKit/Net/Imap/ImapClient.cs:1409— ImapClient.PostConnect has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapFolder.CreateStoreCommands (cognitive 18) MailKit/Net/Imap/ImapFolderFlags.cs:517— ImapFolder.CreateStoreCommands has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapFolder.TryCreateStoreCommand) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapFolder.TryCreateStoreCommand (cognitive 18) MailKit/Net/Imap/ImapFolderFlags.cs:714— ImapFolder.TryCreateStoreCommand has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapFolder.CreateStoreCommands) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapIdleSession.WaitForChanges (cognitive 18) MailKit/Net/Imap/ImapIdleSession.cs:232— ImapIdleSession.WaitForChanges has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapUtils.ParseFolderList (cognitive 18) REDACTED:672— ImapUtils.ParseFolderList has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapUtils.ParseFolderListAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapUtils.ParseFolderListAsync (cognitive 18) REDACTED:759— ImapUtils.ParseFolderListAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapUtils.ParseFolderList) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapUtils.ParseMultipart (cognitive 18) REDACTED:1571— ImapUtils.ParseMultipart has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapUtils.ParseMultipartAsync) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ImapUtils.ParseMultipartAsync (cognitive 18) REDACTED:1662— ImapUtils.ParseMultipartAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ImapUtils.ParseMultipart) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
Pop3AuthenticationSecretDetector.DetectSecrets (cognitive 18) MailKit/Net/Pop3/Pop3AuthenticationSecretDetector.cs:285— Pop3AuthenticationSecretDetector.DetectSecrets has cognitive complexity 18 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
BodyPart.TryParse (cognitive 17) MailKit/BodyPart.cs:368— BodyPart.TryParse has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Envelope.TryParse (cognitive 17) MailKit/Envelope.cs:417— Envelope.TryParse has cognitive complexity 17 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
ImapSearchQueryOptimizer.Reduce (cognitive 17) MailKit/Net/Imap/ImapSearchQueryOptimizer.cs:34— ImapSearchQueryOptimizer.Reduce has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapStream.TryReadQuotedString (cognitive 17) MailKit/Net/Imap/ImapStream.cs:551— ImapStream.TryReadQuotedString has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BodyPart.TryParse (cognitive 16) MailKit/BodyPart.cs:320— BodyPart.TryParse has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Envelope.TryParse (cognitive 16) MailKit/Envelope.cs:369— Envelope.TryParse has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CapabilityNameTable.AddKeyword (cognitive 16) MailKit/Net/CapabilityNameTable.cs:96— CapabilityNameTable.AddKeyword has cognitive complexity 16 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ImapAuthenticationSecretDetector.DetectLoginSecrets (cognitive 16) MailKit/Net/Imap/ImapAuthenticationSecretDetector.cs:319— ImapAuthenticationSecretDetector.DetectLoginSecrets has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapClient.TryQueueEnableCommand (cognitive 16) MailKit/Net/Imap/ImapClient.cs:354— ImapClient.TryQueueEnableCommand has cognitive complexity 16 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ImapClient.TryQueueGetMetadataCommand (cognitive 16) MailKit/Net/Imap/ImapClient.cs:2517— ImapClient.TryQueueGetMetadataCommand has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapEngine.DetectQuirksMode (cognitive 16) MailKit/Net/Imap/ImapEngine.cs:759— ImapEngine.DetectQuirksMode has cognitive complexity 16 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ImapEngine.UpdateSimpleStatusValue (cognitive 16) MailKit/Net/Imap/ImapEngine.cs:2679— ImapEngine.UpdateSimpleStatusValue has cognitive complexity 16 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
ImapFolder.BuildSortOrder (cognitive 16) MailKit/Net/Imap/ImapFolderSearch.cs:411— ImapFolder.BuildSortOrder has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UniqueIdSet.Append (cognitive 16) MailKit/UniqueIdSet.cs:383— UniqueIdSet.Append has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UniqueIdSet.Remove (cognitive 16) MailKit/UniqueIdSet.cs:524— UniqueIdSet.Remove has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ClassTooLong: ImapCommand MailKit/Net/Imap/ImapCommand.cs— ClassTooLong — 404 significant lines (blank, comment-only and punctuation-only lines excluded), 18 methods. The bar is 400 significant lines; this is 4 over it, 1.01× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
Change coupling: HttpsProxyClient.cs ↔ REDACTED MailKit/Net/Proxy/HttpsProxyClient.cs:1— `MailKit/Net/Proxy/HttpsProxyClient.cs` and `REDACTED` change together 64% of the time (7 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `2feaec3c` Update documentation for v5 and build docs from net10.0; `26fa25a5` Renamed MailKit.Net.SslStream to ExtendedSslStream; `7d2fe06c` Code quality improvements — run `git show` on any of them.
Near-duplicate member pair (146 shared lines) MailKit/Net/Imap/ImapFolderFetch.cs:2092— MailKit/Net/Imap/ImapFolderFetch.cs:2092-2332 | MailKit/Net/Imap/ImapFolderFetch.cs:2335-2575 — These two members are variants of one another: 146 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
Near-duplicate member pair (75 shared lines) MailKit/Net/Imap/ImapFolderFetch.cs:300— MailKit/Net/Imap/ImapFolderFetch.cs:300-541 | MailKit/Net/Imap/ImapFolderFetch.cs:544-785 — These two members are variants of one another: 75 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
Near-duplicate member pair (39 shared lines) MailKit/Net/Imap/ImapFolder.cs:4882— MailKit/Net/Imap/ImapFolder.cs:4882-4928 | MailKit/Net/Imap/ImapFolder.cs:4982-5028 — These two members are variants of one another: 39 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication· Members sharing a duplicated core (12 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (12 members, 50+ identical tokens) MailKit/Net/Imap/ImapFolder.cs:4318— MailKit/Net/Imap/ImapFolder.cs:4318-4368 | MailKit/Net/Imap/ImapFolder.cs:4430-4480 | MailKit/Net/Imap/ImapFolder.cs:5671-5717 | MailKit/Net/Imap/ImapFolder.cs:5770-5816 | MailKit/Net/Imap/ImapFolder.cs:5884-5942 | MailKit/Net/Imap/ImapFolder.cs:6003-6061 | MailKit/Net/Imap/ImapFolderAnnotations.cs:140-163 | MailKit/Net/Imap/ImapFolderAnnotations.cs:217-240 | MailKit/Net/Imap/ImapFolderFlags.cs:188-211 | MailKit/Net/Imap/ImapFolderFlags.cs:260-283 | MailKit/Net/Imap/ImapFolderFlags.cs:617-640 | MailKit/Net/Imap/ImapFolderFlags.cs:689-712 — These 12 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 12 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 12 times.
D4 · Code Duplication· Members sharing a duplicated core (6 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (6 members, 50+ identical tokens) MailKit/Net/Imap/ImapFolderAnnotations.cs:336— MailKit/Net/Imap/ImapFolderAnnotations.cs:336-353 | MailKit/Net/Imap/ImapFolderAnnotations.cs:407-424 | MailKit/Net/Imap/ImapFolderFlags.cs:392-409 | MailKit/Net/Imap/ImapFolderFlags.cs:458-475 | MailKit/Net/Imap/ImapFolderFlags.cs:821-838 | MailKit/Net/Imap/ImapFolderFlags.cs:887-904 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
D4 · Code Duplication· Members sharing a duplicated core (5 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (5 members, 50+ identical tokens) MailKit/Net/Imap/ImapFolderAnnotations.cs:40— MailKit/Net/Imap/ImapFolderAnnotations.cs:40-76 | MailKit/Net/Imap/ImapFolderAnnotations.cs:243-283 | MailKit/Net/Imap/ImapFolderFlags.cs:286-343 | MailKit/Net/Imap/ImapFolderFlags.cs:518-568 | MailKit/Net/Imap/ImapFolderFlags.cs:715-772 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
Duplicated block (102–103 lines × 3) MailKit/StoreAnnotationsRequest.cs:67— MailKit/StoreAnnotationsRequest.cs:67-168 | MailKit/StoreFlagsRequest.cs:141-243 | MailKit/StoreLabelsRequest.cs:106-208 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/StoreAnnotationsRequest.cs:67` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (79 lines × 2) MailKit/CopyRequest.cs:66— MailKit/CopyRequest.cs:66-144 | MailKit/MoveRequest.cs:66-144 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (77 lines × 2) MailKit/ICopyRequest.cs:40— MailKit/ICopyRequest.cs:40-116 | MailKit/IMoveRequest.cs:40-116 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (58 lines × 2) MailKit/Net/Imap/ImapFolderFetch.cs:2207— MailKit/Net/Imap/ImapFolderFetch.cs:2207-2264 | MailKit/Net/Imap/ImapFolderFetch.cs:2450-2507 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderFetch.cs:2207` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (54 lines × 2) MailKit/Net/Imap/ImapEngine.cs:2177— MailKit/Net/Imap/ImapEngine.cs:2177-2230 | MailKit/Net/Imap/ImapEngine.cs:2527-2580 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapEngine.cs:2177` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (44 lines × 2) MailKit/Net/Imap/ImapFolderSearch.cs:536— MailKit/Net/Imap/ImapFolderSearch.cs:536-579 | MailKit/Net/Imap/ImapFolderSearch.cs:689-732 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderSearch.cs:536` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (40 lines × 2) MailKit/Net/Pop3/Pop3Stream.cs:829— MailKit/Net/Pop3/Pop3Stream.cs:829-868 | MailKit/Net/Smtp/SmtpStream.cs:834-873 — before extracting anything, compare `MailKit/Net/Pop3/Pop3Stream.cs` and `MailKit/Net/Smtp/SmtpStream.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 160 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Pop3/Pop3Stream.cs:829` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (37 lines × 2) MailKit/Net/Pop3/Pop3Stream.cs:946— MailKit/Net/Pop3/Pop3Stream.cs:946-982 | MailKit/Net/Smtp/SmtpStream.cs:951-987 — before extracting anything, compare `MailKit/Net/Pop3/Pop3Stream.cs` and `MailKit/Net/Smtp/SmtpStream.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 160 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Pop3/Pop3Stream.cs:946` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (34 lines × 3) MailKit/Net/Imap/ImapFolder.cs:4522— MailKit/Net/Imap/ImapFolder.cs:4522-4555 | MailKit/Net/Imap/ImapFolder.cs:5060-5093 | MailKit/Net/Imap/ImapFolder.cs:5303-5336 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:4522` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `IAppendRequest` in one and `IReplaceRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (31 lines × 2) MailKit/Net/Pop3/Pop3Stream.cs:701— MailKit/Net/Pop3/Pop3Stream.cs:701-731 | MailKit/Net/Smtp/SmtpStream.cs:649-679 — before extracting anything, compare `MailKit/Net/Pop3/Pop3Stream.cs` and `MailKit/Net/Smtp/SmtpStream.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 160 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (27–30 lines × 2) REDACTED:1079— REDACTED:1079-1108 | REDACTED:1239-1265 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:1079` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (27 lines × 2) MailKit/Net/Imap/AsyncImapClient.cs:792— MailKit/Net/Imap/AsyncImapClient.cs:792-818 | MailKit/Net/Pop3/AsyncPop3Client.cs:604-630 — before extracting anything, compare `MailKit/Net/Imap/AsyncImapClient.cs` and `MailKit/Net/Pop3/AsyncPop3Client.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 79 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/AsyncImapClient.cs:792` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23 lines × 3) MailKit/Net/Imap/ImapClient.cs:1342— MailKit/Net/Imap/ImapClient.cs:1342-1364 | REDACTED:1040-1062 | REDACTED:1288-1310 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapClient.cs:1342` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23–24 lines × 2) MailKit/Net/SocketUtils.cs:115— MailKit/Net/SocketUtils.cs:115-138 | MailKit/Net/SocketUtils.cs:179-201 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/SocketUtils.cs:115` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (22 lines × 3) MailKit/Net/Imap/ImapClient.cs:255— MailKit/Net/Imap/ImapClient.cs:255-276 | REDACTED:255-276 | REDACTED:622-643 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapClient.cs:255` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (22–23 lines × 2) MailKit/Net/Imap/ImapClient.cs:1099— MailKit/Net/Imap/ImapClient.cs:1099-1120 | MailKit/Net/Imap/ImapClient.cs:1245-1267 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `MailKit/Net/Imap/ImapClient.cs:1122` calls `StartNetworkOperation` and `MailKit/Net/Imap/ImapClient.cs:1269` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (19–20 lines × 2) MailKit/Net/Imap/AsyncImapClient.cs:256— MailKit/Net/Imap/AsyncImapClient.cs:256-274 | MailKit/Net/Imap/AsyncImapClient.cs:375-394 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `MailKit/Net/Imap/AsyncImapClient.cs:276` calls `StartNetworkOperation` and `MailKit/Net/Imap/AsyncImapClient.cs:396` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (17–20 lines × 2) MailKit/Net/Imap/AsyncImapClient.cs:408— MailKit/Net/Imap/AsyncImapClient.cs:408-424 | MailKit/Net/Imap/AsyncImapClient.cs:441-460 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/AsyncImapClient.cs:408` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `MailKit/Net/Imap/AsyncImapClient.cs:462` calls `SetError` and `MailKit/Net/Imap/AsyncImapClient.cs:425` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (15–16 lines × 2) MailKit/Security/SaslMechanismOAuth2.cs:138— MailKit/Security/SaslMechanismOAuth2.cs:138-152 | MailKit/Security/SaslMechanismOAuthBearer.cs:188-203 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Security/SaslMechanismOAuth2.cs:138` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (15 lines × 4) MailKit/Net/Pop3/Pop3Stream.cs:835— MailKit/Net/Pop3/Pop3Stream.cs:835-849 | MailKit/Net/Pop3/Pop3Stream.cs:951-965 | MailKit/Net/Smtp/SmtpStream.cs:840-854 | MailKit/Net/Smtp/SmtpStream.cs:956-970 — before extracting anything, compare `MailKit/Net/Pop3/Pop3Stream.cs` and `MailKit/Net/Smtp/SmtpStream.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 160 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Pop3/Pop3Stream.cs:835` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `MailKit/Net/Pop3/Pop3Stream.cs:834` calls `Get` and `MailKit/Net/Pop3/Pop3Stream.cs:950` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14–15 lines × 2) MailKit/Net/Imap/ImapEngine.cs:3554— MailKit/Net/Imap/ImapEngine.cs:3554-3568 | MailKit/Net/Imap/ImapEngine.cs:4040-4053 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12–13 lines × 2) MailKit/Net/Pop3/Pop3Stream.cs:1078— MailKit/Net/Pop3/Pop3Stream.cs:1078-1090 | MailKit/Net/Smtp/SmtpStream.cs:1085-1096 — before extracting anything, compare `MailKit/Net/Pop3/Pop3Stream.cs` and `MailKit/Net/Smtp/SmtpStream.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 160 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Pop3/Pop3Stream.cs:1078` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 5) MailKit/Net/Imap/ImapClient.cs:1554— MailKit/Net/Imap/ImapClient.cs:1554-1560 | MailKit/Net/Imap/ImapClient.cs:1734-1740 | REDACTED:1233-1239 | REDACTED:1419-1425 | REDACTED:1699-1705 — there are 5 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapClient.cs:1554` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 4) MailKit/Net/Proxy/ProxyClient.cs:215— MailKit/Net/Proxy/ProxyClient.cs:215-222 | MailKit/Net/Proxy/ProxyClient.cs:240-247 | MailKit/Net/Proxy/ProxyClient.cs:260-267 | MailKit/Net/Proxy/ProxyClient.cs:286-293 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Proxy/ProxyClient.cs:215` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 4) MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:371— MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:371-381 | MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:383-393 | MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:395-405 | MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:407-417 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11 lines × 2) MailKit/Net/Imap/ImapFolderFlags.cs:326— MailKit/Net/Imap/ImapFolderFlags.cs:326-336 | MailKit/Net/Imap/ImapFolderFlags.cs:755-765 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `IStoreFlagsRequest` in one and `IStoreLabelsRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 6) MailKit/Net/Imap/ImapFolderAnnotations.cs:141— MailKit/Net/Imap/ImapFolderAnnotations.cs:141-149 | MailKit/Net/Imap/ImapFolderAnnotations.cs:218-226 | MailKit/Net/Imap/ImapFolderFlags.cs:189-197 | MailKit/Net/Imap/ImapFolderFlags.cs:261-269 | MailKit/Net/Imap/ImapFolderFlags.cs:618-626 | MailKit/Net/Imap/ImapFolderFlags.cs:690-698 — before extracting anything, compare `MailKit/Net/Imap/ImapFolderAnnotations.cs` and `MailKit/Net/Imap/ImapFolderFlags.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 48 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolderAnnotations.cs:141` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `IStoreAnnotationsRequest` in one and `IStoreFlagsRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (7 lines × 4) MailKit/Net/Imap/ImapFolder.cs:5164— MailKit/Net/Imap/ImapFolder.cs:5164-5170 | MailKit/Net/Imap/ImapFolder.cs:5257-5263 | MailKit/Net/Imap/ImapFolder.cs:5417-5423 | MailKit/Net/Imap/ImapFolder.cs:5509-5515 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `MailKit/Net/Imap/ImapFolder.cs:5164` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9–10 lines × 3) MailKit/Net/Imap/ImapFolderAnnotations.cs:266— MailKit/Net/Imap/ImapFolderAnnotations.cs:266-275 | MailKit/Net/Imap/ImapFolderFlags.cs:325-333 | MailKit/Net/Imap/ImapFolderFlags.cs:753-762 — before extracting anything, compare `MailKit/Net/Imap/ImapFolderAnnotations.cs` and `MailKit/Net/Imap/ImapFolderFlags.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 48 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `request` to `IStoreAnnotationsRequest` in one and `IStoreFlagsRequest` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (8–9 lines × 2) MailKit/Security/Ntlm/MD4.cs:262— MailKit/Security/Ntlm/MD4.cs:262-270 | MailKit/Security/Ntlm/MD4.cs:271-278 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 3) MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:236— MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:236-241 | MailKit/Security/Ntlm/NtlmChallengeMessage.cs:111-116 | MailKit/Security/Ntlm/NtlmNegotiateMessage.cs:111-116 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
Duplicated block (4–6 lines × 3) MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:423— MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:423-431 | MailKit/Security/Ntlm/NtlmChallengeMessage.cs:172-175 | MailKit/Security/Ntlm/NtlmNegotiateMessage.cs:131-136 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `MailKit/Security/Ntlm/NtlmChallengeMessage.cs:168` calls `BlockCopy` and `MailKit/Security/Ntlm/NtlmAuthenticateMessage.cs:423` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Low cohesion: MailService (LCOM4 7) REDACTED:52— MailService's methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Coverage not measured — no coverage collector is wired up — Coverage NOT MEASURED: `--collect:"XPlat Code Coverage"` names a data collector that ships in the `coverlet.collector` package, and this repository wires up none — no test project references it and no runsettings declares one. The absence of coverage here is therefore not evidence about the suite or about our analyzer environment: without a collector, `--collect` produces nothing even from a suite that builds and passes. Add a `coverlet.collector` PackageReference to the test project(s) (or commit the Cobertura/OpenCover/lcov report your CI produces) and real coverage will be measured. It is excluded from the score rather than counted as a near-zero defect.
IC1 · Incompleteness & stubs· Empty method body · ×1
Empty method body — does nothing with its inputs MailKit/Net/Imap/ImapLiteral.cs:55— `DefaultUpdate` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
Unfinished stub — throws NotImplementedException MailKit/Net/Smtp/SmtpStream.cs:447— `ReadAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
P12 · CI test-gate honesty· Coverage collected but not gated · ×1
Coverage collected but not gated — CI collects a coverage report but no step enforces a minimum — coverage could halve and CI stays green. Add a step that fails the build when coverage drops below a floor (your coverage tool's minimum-threshold flag, or a coverage-gate action) so the number guards something. What was searched, so you can tell an absence from a miss: this repository's CI files AND its coverage configuration — the well-known coverage and test-runner config files, read at the repository root and inside workspace package directories two levels down, so a floor declared beside the tests rather than in the pipeline is credited — matched against the threshold settings this check knows by name. A floor set in your coverage service's web UI rather than in a committed file, or under a setting whose name is not one of those, is not seen here.
SC1 · Supply-chain hygiene· NuGet dependencies are not locked · ×1
NuGet dependencies are not locked — No packages.lock.json and no central package management — restores aren't reproducible or pinned (SSDF PW.4.4). Enable <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> (commit the lockfile) or adopt Directory.Packages.props. Advisory — never scored.
X18 · Disposal-pattern correctness· Disposes a dependency it does not own · ×1
Disposes a dependency it does not own REDACTED:1697— `ProtocolLogger` is never created by `MailService` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 1697). Its declared type `IProtocolLogger` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed.
Async call defeats the CancellationToken: WaitForChangesAsync MailKit/Net/Imap/ImapIdleSession.cs:342— Holds a CancellationToken but hands `CancellationToken.None` to the awaited call on this line, so the caller's cancellation never reaches that work. Pass the token on (or, where the work must outlive the caller, start it without awaiting it so the choice is visible).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:285— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:286— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:290— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:291— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:292— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:296— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:297— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:298— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:310— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:315— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:316— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:317— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:319— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:320— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:323— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:324— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:327— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:329— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:332— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:334— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:335— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:342— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapCommand.cs:343— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapEngine.cs:1992— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code MailKit/Net/Imap/ImapEngine.cs:1995— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Duplicated predicate MailKit/Net/Pop3/AsyncPop3Client.cs:69— `!engine.Capabilities.Contains (Pop3Capability.UIDL) && (probed & ProbedCapabilities.UIDL) == 0` appears character-identically in 2 files — MailKit/Net/Pop3/AsyncPop3Client.cs, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/Net/Imap/ImapClient.cs:1360— `IPAddress.TryParse (host, out var ip) && ip.AddressFamily == AddressFamily.InterNetworkV6` appears character-identically in 3 files — MailKit/Net/Imap/ImapClient.cs, REDACTED, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/AccessRights.cs:229— `arrayIndex < 0 || arrayIndex + Count > array.Length` appears character-identically in 2 files — MailKit/AccessRights.cs, MailKit/BodyPartCollection.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/UniqueIdRange.cs:274— `arrayIndex < 0 || arrayIndex > (array.Length - Count)` appears character-identically in 2 files — MailKit/UniqueIdRange.cs, MailKit/UniqueIdSet.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/Net/Smtp/AsyncSmtpClient.cs:982— `bdat || Capabilities.Contains (SmtpCapability.Size) || state.Request.TransferProgress != null` appears character-identically in 2 files — MailKit/Net/Smtp/AsyncSmtpClient.cs, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/DuplexStream.cs:163— `count < 0 || count > (buffer.Length - offset)` appears character-identically in 6 files — MailKit/CompressedStream.cs, MailKit/DuplexStream.cs, MailKit/Net/Imap/ImapStream.cs, MailKit/Net/Pop3/Pop3Stream.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/Net/Imap/AsyncImapClient.cs:370— `cred == null || !SaslMechanism.TryCreate (authmech, encoding, cred, out sasl)` appears character-identically in 6 files — MailKit/Net/Imap/AsyncImapClient.cs, MailKit/Net/Imap/ImapClient.cs, MailKit/Net/Pop3/AsyncPop3Client.cs, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/Net/Imap/AsyncImapClient.cs:260— `engine.Capabilities.Contains (ImapCapability.SaslIR) && mechanism.SupportsInitialResponse` appears character-identically in 2 files — MailKit/Net/Imap/AsyncImapClient.cs, MailKit/Net/Imap/ImapClient.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/Net/Imap/AsyncImapClient.cs:379— `engine.Capabilities.Contains (ImapCapability.SaslIR) && sasl.SupportsInitialResponse` appears character-identically in 2 files — MailKit/Net/Imap/AsyncImapClient.cs, MailKit/Net/Imap/ImapClient.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/Net/Pop3/AsyncPop3Client.cs:233— `engine.Capabilities.Contains (Pop3Capability.Apop) && (cred = credentials.GetCredential (saslUri, "APOP")) != null` appears character-identically in 2 files — MailKit/Net/Pop3/AsyncPop3Client.cs, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/Net/Imap/ImapClient.cs:620— `engine.IsConnected && engine.Stream.CanTimeout` appears character-identically in 2 files — MailKit/Net/Imap/ImapClient.cs, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/Net/Imap/ImapClient.cs:692— `engine.IsSecure && (engine.Stream.Stream is SslStream sslStream)` appears character-identically in 2 files — MailKit/Net/Imap/ImapClient.cs, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/Net/Imap/ImapClient.cs:666— `engine.IsSecure && (engine.Stream.Stream is SslStream sslStream) && sslStream.IsEncrypted` appears character-identically in 2 files — MailKit/Net/Imap/ImapClient.cs, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/Net/Imap/ImapClient.cs:677— `engine.IsSecure && (engine.Stream.Stream is SslStream sslStream) && sslStream.IsSigned` appears character-identically in 2 files — MailKit/Net/Imap/ImapClient.cs, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/BodyPart.cs:331— `index + 3 <= text.Length && IsNIL (text, index)` appears character-identically in 2 files — MailKit/BodyPart.cs, MailKit/Envelope.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/Net/Imap/ImapAuthenticationSecretDetector.cs:365— `index < endIndex && buffer[index] != (byte) ' '` appears character-identically in 2 files — MailKit/Net/Imap/ImapAuthenticationSecretDetector.cs, MailKit/Net/Pop3/Pop3AuthenticationSecretDetector.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/Net/Imap/ImapAuthenticationSecretDetector.cs:132— `index < endIndex && buffer[index] != (byte) ' ' && buffer[index] != (byte) '\r'` appears character-identically in 3 files — MailKit/Net/Imap/ImapAuthenticationSecretDetector.cs, MailKit/Net/Pop3/Pop3AuthenticationSecretDetector.cs, MailKit/Net/Smtp/SmtpAuthenticationSecretDetector.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/Net/Imap/ImapAuthenticationSecretDetector.cs:162— `index < endIndex && buffer[index] != (byte) '\r'` appears character-identically in 3 files — MailKit/Net/Imap/ImapAuthenticationSecretDetector.cs, MailKit/Net/Pop3/Pop3AuthenticationSecretDetector.cs, MailKit/Net/Smtp/SmtpAuthenticationSecretDetector.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/Net/Pop3/Pop3AuthenticationSecretDetector.cs:71— `index < endIndex && commandIndex < command.Length` appears character-identically in 2 files — MailKit/Net/Pop3/Pop3AuthenticationSecretDetector.cs, MailKit/Net/Smtp/SmtpAuthenticationSecretDetector.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate REDACTED:156— `index < text.Length && char.IsWhiteSpace (text[index])` appears character-identically in 3 files — REDACTED, MailKit/Net/Pop3/Pop3Engine.cs, MailKit/Security/SaslMechanismDigestMd5.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/BodyPart.cs:280— `index < text.Length && text[index] == ' '` appears character-identically in 2 files — MailKit/BodyPart.cs, MailKit/Envelope.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/BodyPart.cs:287— `index < text.Length && text[index] >= '0' && text[index] <= '9'` appears character-identically in 2 files — MailKit/BodyPart.cs, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/BodyPart.cs:620— `index >= text.Length || text[index] != '('` appears character-identically in 2 files — MailKit/BodyPart.cs, MailKit/Envelope.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/BodyPart.cs:405— `index >= text.Length || text[index] != ')'` appears character-identically in 2 files — MailKit/BodyPart.cs, MailKit/Envelope.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate MailKit/Security/Ntlm/MD4.cs:347— `inputCount < 0 || inputOffset > inputBuffer.Length - inputCount` appears character-identically in 2 files — MailKit/Security/Ntlm/MD4.cs, MailKit/Security/Ntlm/RC4.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Fat interface: IMailFolder (235 members) MailKit/IMailFolder.cs:49— `IMailFolder` declares 235 members: `SyncRoot`, `ParentFolder`, `Attributes`, `AnnotationAccess`, `AnnotationScopes`, `MaxAnnotationSize`, `PermanentFlags`, `PermanentKeywords`, `AcceptedFlags`, `AcceptedKeywords`, `DirectorySeparator`, `Access`, `IsNamespace`, `FullName`, `Name`, `Id`, `IsSubscribed`, `IsOpen`, `CanOpen`, `Exists`, `HighestModSeq`, `UidValidity`, `UidNext`, `AppendLimit`, `Size`, `DeletedCount`, `DeletedStorageSize`, `FirstUnread`, `Unread`, `Recent`, `Count`, `ThreadingAlgorithms`, `Supports`, `Open`, `OpenAsync`, `Open`, `OpenAsync`, `Close`, `CloseAsync`, `Create`, and 195 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 235 declarations carry 129 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 129 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IMailService (46 members) MailKit/IMailService.cs:53— `IMailService` declares 46 members: `SyncRoot`, `SslProtocols`, `ClientCertificates`, `CheckCertificateRevocation`, `ServerCertificateValidationCallback`, `LocalEndPoint`, `ProxyClient`, `AuthenticationMechanisms`, `IsAuthenticated`, `IsConnected`, `IsSecure`, `IsEncrypted`, `IsSigned`, `SslProtocol`, `SslCipherAlgorithm`, `SslCipherStrength`, `SslHashAlgorithm`, `SslHashStrength`, `SslKeyExchangeAlgorithm`, `SslKeyExchangeStrength`, `Timeout`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Disconnect`, and 6 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 46 declarations carry 32 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 32 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IMailSpool (40 members) MailKit/IMailSpool.cs:42— `IMailSpool` declares 40 members: `Count`, `SupportsUids`, `GetMessageCount`, `GetMessageCountAsync`, `GetMessageUid`, `GetMessageUidAsync`, `GetMessageUids`, `GetMessageUidsAsync`, `GetMessageSize`, `GetMessageSizeAsync`, `GetMessageSizes`, `GetMessageSizesAsync`, `GetMessageHeaders`, `GetMessageHeadersAsync`, `GetMessageHeaders`, `GetMessageHeadersAsync`, `GetMessageHeaders`, `GetMessageHeadersAsync`, `GetMessage`, `GetMessageAsync`, `GetMessages`, `GetMessagesAsync`, `GetMessages`, `GetMessagesAsync`, `GetStream`, `GetStreamAsync`, `GetStreams`, `GetStreamsAsync`, `GetStreams`, `GetStreamsAsync`, `DeleteMessage`, `DeleteMessageAsync`, `DeleteMessages`, `DeleteMessagesAsync`, `DeleteMessages`, `DeleteMessagesAsync`, `DeleteAllMessages`, `DeleteAllMessagesAsync`, `Reset`, `ResetAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 40 declarations carry 30 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 30 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IMailStore (25 members) MailKit/IMailStore.cs:40— `IMailStore` declares 25 members: `PersonalNamespaces`, `SharedNamespaces`, `OtherNamespaces`, `SupportsQuotas`, `ThreadingAlgorithms`, `Inbox`, `GetFolder`, `GetFolder`, `GetFolders`, `GetFoldersAsync`, `GetFolders`, `GetFoldersAsync`, `GetFolder`, `GetFolderAsync`, `GetMetadata`, `GetMetadataAsync`, `GetMetadata`, `GetMetadataAsync`, `GetMetadata`, `GetMetadataAsync`, `SetMetadata`, `SetMetadataAsync`, `Alert`, `FolderCreated`, `MetadataChanged`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 25 declarations carry 17 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 17 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IMessageSummary (27 members) MailKit/IMessageSummary.cs:49— `IMessageSummary` declares 27 members: `Fields`, `Body`, `TextBody`, `HtmlBody`, `BodyParts`, `Attachments`, `PreviewText`, `Envelope`, `NormalizedSubject`, `Date`, `IsReply`, `Flags`, `Keywords`, `Annotations`, `Headers`, `InternalDate`, `SaveDate`, `Size`, `ModSeq`, `References`, `EmailId`, `ThreadId`, `UniqueId`, `Index`, `GMailMessageId`, `GMailThreadId`, `GMailLabels`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IImapClient (16 members) MailKit/Net/Imap/IImapClient.cs:38— `IImapClient` declares 16 members: `Capabilities`, `AppendLimit`, `InternationalizationLevel`, `Rights`, `IsIdle`, `Enable`, `EnableAsync`, `Identify`, `IdentifyAsync`, `Idle`, `IdleAsync`, `CreateIdleSession`, `Notify`, `NotifyAsync`, `DisableNotify`, `DisableNotifyAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IImapFolder (18 members) MailKit/Net/Imap/IImapFolder.cs:48— `IImapFolder` declares 18 members under just 10 distinct name(s): `GetHeaders`, `GetHeadersAsync`, `GetHeaders`, `GetHeadersAsync`, `GetBodyPart`, `GetBodyPartAsync`, `GetBodyPart`, `GetBodyPartAsync`, `GetStreams`, `GetStreamsAsync`, `GetStreams`, `GetStreamsAsync`, `GetStreams`, `GetStreamsAsync`, `Search`, `SearchAsync`, `Sort`, `SortAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 18 separate responsibilities: a caller binds to 10 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 18 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IMailService (48 members) MailKit/IMailService.cs:53— `IMailService` declares 48 members: `SyncRoot`, `SslProtocols`, `SslCipherSuitesPolicy`, `SslCipherSuite`, `ClientCertificates`, `CheckCertificateRevocation`, `ServerCertificateValidationCallback`, `LocalEndPoint`, `ProxyClient`, `AuthenticationMechanisms`, `IsAuthenticated`, `IsConnected`, `IsSecure`, `IsEncrypted`, `IsSigned`, `SslProtocol`, `SslCipherAlgorithm`, `SslCipherStrength`, `SslHashAlgorithm`, `SslHashStrength`, `SslKeyExchangeAlgorithm`, `SslKeyExchangeStrength`, `Timeout`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, and 8 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 48 declarations carry 34 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 34 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IImapClient (18 members) MailKit/Net/Imap/IImapClient.cs:38— `IImapClient` declares 18 members: `Capabilities`, `AppendLimit`, `InternationalizationLevel`, `Rights`, `IsIdle`, `Compress`, `CompressAsync`, `Enable`, `EnableAsync`, `Identify`, `IdentifyAsync`, `Idle`, `IdleAsync`, `CreateIdleSession`, `Notify`, `NotifyAsync`, `DisableNotify`, `DisableNotifyAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IMailService (42 members) MailKit/IMailService.cs:53— `IMailService` declares 42 members: `SyncRoot`, `SslProtocols`, `SslCipherSuitesPolicy`, `SslCipherSuite`, `ClientCertificates`, `CheckCertificateRevocation`, `ServerCertificateValidationCallback`, `LocalEndPoint`, `ProxyClient`, `AuthenticationMechanisms`, `IsAuthenticated`, `IsConnected`, `IsSecure`, `IsEncrypted`, `IsSigned`, `SslProtocol`, `Timeout`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Connect`, `ConnectAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Authenticate`, `AuthenticateAsync`, `Disconnect`, `DisconnectAsync`, `NoOp`, `NoOpAsync`, `Connected`, and 2 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 42 declarations carry 28 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 28 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Silent fallback default on parse failure MailKit/Net/Imap/ImapEngine.cs:1949— `GetResponseCodeType` falls back to `ImapResponseCodeType.Unknown` when `ResponseCodeTypes.TryGetValue (atom, out var type)` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default on parse failure REDACTED:2068— `ProcessListResponse` returns `Task.CompletedTask` when `long.TryParse (tokens[1], NumberStyles.None, CultureInfo.InvariantCulture, out l…` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default in catch MailKit/Security/SaslMechanismNegotiateBase.cs:404— `CheckSupported` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch AotCompatibility/Program.cs:51— `Main` swallows every exception into `return -1;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
No ADRs found — No ADRs found. The recognised ADR directories in this tree were read — `rfc` — and none of their files is a decision record (a README, index or template page does not count). What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`.
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion — 1 of 7 project(s) overshoot their size bounds, lowering Project Cohesion to 7.1/10. The most over is `MailKit(netstandard2.0)` (114428 LoC, 234 public types across 7 namespaces). Review these for cohesion — split a project that spans unrelated responsibilities.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation· No architecture diagram/doc · ×1
No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
No src/ separation — Production code isn't grouped under a src/ folder — it's spread across several top-level directories, so there's no one place that says 'this is the product'.
README/code drift README.md:218— README.md installs the package `MimeKit.Cryptography` (`dotnet add package MimeKit.Cryptography`), but no project or props file references it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
PF1 · Benchmark discipline· No performance benchmarks · ×1
No performance benchmarks — No benchmark suite was found by the two searches this check runs. FIRST, a BenchmarkDotNet package reference in any project file — every project the workspace loaded, plus a walk of project files on disk that never loaded, because a benchmark suite is exactly the project a partial load drops. SECOND, a script harness: a file whose name contains `benchmark` and ends `.py`, `.sh`, `.ps1`, `.bash`, `.rb`, `.js` or `.mjs`, credited ONLY when this repository's CI text also mentions benchmarks — a harness no pipeline runs is read as a fixture, deliberately. Neither search can see a benchmark suite in another ecosystem's idiom (a Go `testing.B` file, a JMH or criterion project, a pytest-benchmark run), so this is 'no benchmark found by those two searches', not a verdict that the repository has none. Where code is performance-sensitive, a benchmark guards against silent regressions — but it's a bonus here, not a deduction.
X2 · Cancellation propagation· Not all async methods take a CancellationToken · ×1
Not all async methods take a CancellationToken — Only 247/276 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
X2 · Cancellation propagation· Some async methods drop the CancellationToken they accept · ×1
Some async methods drop the CancellationToken they accept — 1 async method(s) await work their caller's cancellation cannot reach: a CancellationToken they hold (a parameter, or the one a framework-fixed signature carries) is never passed on, or the call is handed CancellationToken.None, default or an already-cancelled token. Forward the caller's token to that call.
Nullable reference types not enabled everywhere — 4/5 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
Null-forgiving operator (`!`) suppressions reduce the NRT score — ~1.0 `!` suppressions per 1k syntax nodes — 237 suppression(s) across the 239353 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
nuget: not applicable — nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan
trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
none (no readable dependency manifest): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).
0
—
Run 01a16871-c42d-7f19-94d5-39291f5376f0 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Appendix C — Personal-data map
Every field, property and record parameter whose name is conventional personal data — 6 field(s) across 2 categories, each with an exact repo-relative file:line. This is the data inventory a compliance review starts from — right-to-erasure, retention, minimisation. Detected by NAME, from the C# syntax tree, with a deliberately specific identifier classifier — the same one the C1–C5 compliance cards use to decide whether personal data is present, so CardDefinition or FileName don't trip. Two caveats stated rather than glossed: those cards additionally require corroboration (a persistence/account signal, or two distinct PII categories) that this inventory deliberately does not, so it lists more than they gate on; and D32 Data Compliance shares nothing with it — that dimension is a separate semgrep ruleset for personal data leaking into logs, URLs and browser storage, and a clean D32 result says nothing about this list. Informational — it feeds no score.
Issues: 70 · Warnings: 556 · Recommendations: 84 · Info: 5 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 23-10-2026 @ 11:07 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.