Public report of lfz233002072/tools, published 22 October 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Watchdog signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 22 October 2026, 03:08 UTC · Survey ID cd_414f8b3b8fa946e5ae3fb9c91180bebb
lfz233002072/tools
Measured 22 October 2026, 03:07 UTC, at code version 1926783
Code coverage is not measured: No coverage collector is wired up.
Test reliability is not measured: No test run produced results.
CAI scoreProvisionalDown 8 since the last survey
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A medium codebase: 24,727 lines of product code in 2 projects, tests not counted · Estimated rebuild effort: about 0.2 person-years · Weakest lens: Production Readiness, 20
Findings by how serious they are
41 critical252 serious80 minor
9 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
22 October 2026, 03:07 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that
implements it, and today Watchdog is the only one that does.
The code didn't build, so the score is provisional
Watchdog couldn't build the code: the build stopped with 6 errors. The dimensions that need a working build, such as complexity, duplication and dead code, were measured on an incomplete picture of the code, so their grades and the score are provisional. Fix the build errors and run the survey again for a final score. The first errors: CS1056: Unexpected character '�'; CS1001: Identifier expected
The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
56of 60 dimensions measured by tools. The other 4 are advisory notes from an AI model, which explain the code but don't count towards the score.
356of 373 findings point to an exact file and line, so you can open each one in the code. The other 17 concern the repository as a whole, such as missing documentation.
60dimensions across 5 lenses, read from 24,727 lines of product code in 2 projects.
lfz233002072/tools scores 32 out of 100 and is rated Provisional, while three of its five lenses score higher still: Architecture at 82, Maturity at 47, and Code Health at 47. The score is provisional because the code didn't build, so the ratings may change once it does.
The score is lower than those three because the weakest lens counts most, and here that is Production Readiness, which scores 20 and is rated Critical. The project has no secret scanning results and no CI/CD gates, so its REDACTED Scanning and CI/CD gates dimensions score 0 out of 10, and until those reach 4, Production Readiness can't be rated higher than Adequate. Resolving the 2 leaked secrets and adding a CI workflow that builds and runs the test suite on every push or PR are therefore the first actions, and if Production Readiness rose to 70, the score would rise from 32 to about 42.
Forty-one findings are critical: 10 empty catch blocks and 10 write-only private fields in the explicit debt, 10 SQL injection vulnerabilities and 3 quoted interpolation into SQL literals in static analysis, 2 namespace dependency cycles, 2 leaked secrets, 2 insecure binary formatter deserializations, 1 secret in the history, and 1 cryptographic key material that is a compile-time constant. The leaked secrets should be checked and replaced if they are real, and the CI workflow should be added to prevent security regressions from landing.
Watchdog couldn't measure dependency hygiene because it is not measured, license compliance because the license collector did not produce a result, IL efficiency because the analyzer's build of the target did not succeed, and platform end-of-life because the repository declares no platform this pass reads. The product code is 24,727 lines, which would take an estimated 0.2 person-years, around €31,000, to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.
Fixed since the last survey: 14 findings
These 14 critical or serious findings were in the previous survey, on 7 October 2026, and are gone from this one.
Exception handling · Swallowed exception (caught, then discarded) REDACTED
Exception handling · Swallowed exception (caught, then discarded) REDACTED
Exception handling · Swallowed exception (caught, then discarded) REDACTED
Exception handling · Swallowed exception (caught, then discarded) REDACTED
Exception handling · Swallowed exception (caught, then discarded) Lfz.Core/Security/Cryptography/StringDECHelper.cs
Exception handling · Swallowed exception (caught, then discarded) Lfz.Core/Security/Cryptography/StringDECHelper.cs
Exception handling · Swallowed exception (caught, then discarded) Lfz.Core/Security/Cryptography/DESHelper.cs
Exception handling · Swallowed exception (caught, then discarded) Lfz.Core/Security/Cryptography/DESHelper.cs
Exception handling · Swallowed exception (caught, then discarded) Lfz.Core/Utitlies/NetMailUtils.cs
Exception handling · Swallowed exception (caught, then discarded) REDACTED
Exception handling · Swallowed exception (caught, then discarded) REDACTED
Exception handling · Swallowed exception (caught, then discarded) REDACTED
Exception handling · Swallowed exception (caught, then discarded) REDACTED
Exception handling · Swallowed exception (caught, then discarded) REDACTED
Rebuild cost: about €31,000 · Estimate
Cost to rebuild
€10,000 to €52,000, for 169 to 549 hours of work, about 0.2 person-years for one engineer
Difficulty of the problem
Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.7 at a score of 32. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Medium: 24,727 lines of product code, of which 29% is declarations and boilerplate, 26% straight logic and 45% logic with branches
Comment lines
The estimate prices 16,180 lines. Comment lines count towards the size of 24,727 lines but aren't priced as work.
How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Resolve the 2 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED, REDACTED.
Raises the score by about 13 points · Low effort · REDACTED Scanning
2
Add a CI workflow that builds and runs the test suite on every push/PR.
Raises the score by about 6 points · Medium effort · CI/CD gates
3
Run what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
If you do one thing first · First action
Fix the build. The code didn't build, so the dimensions that need a working build were measured on an incomplete picture of the code, and every grade in this report is provisional. Once the build works, the next survey gives a final score. The compiler's first errors: CS1056: Unexpected character '�'; CS1001: Identifier expected
Based on: Solution Shape
Where the investment is most exposed · Value at risk
This code would cost about €31,000 to build again, about 0.2 person-years of work. Its weakest lens is Production Readiness, at 20 (Critical). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
Architecture — module dependency graph
Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways — a layering smell or cycle. A clean layered graph has none.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
34 modules, with 43 dependencies between them. 2 loops run through 4 of the modules, marked above the diagonal.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
Lfz.Data.RawSql uses Lfz.Collections, so a change to Lfz.Collections can break Lfz.Data.RawSql, while a change to Lfz.Data.RawSql can't break Lfz.Collections.
Position
Below the diagonal: Lfz.Data.RawSql uses a module listed above it, which is the healthy direction.
Lfz.Data.RawSql uses System.ComponentModel.DataAnnotations.Schema, so a change to System.ComponentModel.DataAnnotations.Schema can break Lfz.Data.RawSql, while a change to Lfz.Data.RawSql can't break System.ComponentModel.DataAnnotations.Schema.
Position
Below the diagonal: Lfz.Data.RawSql uses a module listed above it, which is the healthy direction.
Lfz.Security.Cryptography uses Lfz.Logging, so a change to Lfz.Logging can break Lfz.Security.Cryptography, while a change to Lfz.Security.Cryptography can't break Lfz.Logging.
Position
Below the diagonal: Lfz.Security.Cryptography uses a module listed above it, which is the healthy direction.
Lfz.Data.Nh.Conventions uses Lfz.Data.RawSql, so a change to Lfz.Data.RawSql can break Lfz.Data.Nh.Conventions, while a change to Lfz.Data.Nh.Conventions can't break Lfz.Data.RawSql.
Position
Below the diagonal: Lfz.Data.Nh.Conventions uses a module listed above it, which is the healthy direction.
Lfz.Data.Nh.Providers uses Lfz.Logging, so a change to Lfz.Logging can break Lfz.Data.Nh.Providers, while a change to Lfz.Data.Nh.Providers can't break Lfz.Logging.
Position
Below the diagonal: Lfz.Data.Nh.Providers uses a module listed above it, which is the healthy direction.
Lfz.Data.Nh.Providers uses Lfz.Data.RawSql, so a change to Lfz.Data.RawSql can break Lfz.Data.Nh.Providers, while a change to Lfz.Data.Nh.Providers can't break Lfz.Data.RawSql.
Position
Below the diagonal: Lfz.Data.Nh.Providers uses a module listed above it, which is the healthy direction.
29→34 Lfz.Data.Nh.Providers uses Lfz.Data.Nhpart of a loop✕
Connections
1 pair of types, where a type in Lfz.Data.Nh.Providers uses a type in Lfz.Data.Nh.
Lfz.Data.Nh.Providers uses Lfz.Data.Nh, so a change to Lfz.Data.Nh can break Lfz.Data.Nh.Providers, while a change to Lfz.Data.Nh.Providers can't break Lfz.Data.Nh.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Lfz.Data.Nh uses Lfz.Data.Nh.Providers, so a change to Lfz.Data.Nh.Providers can break Lfz.Data.Nh, while a change to Lfz.Data.Nh can't break Lfz.Data.Nh.Providers.
Position
Below the diagonal: Lfz.Data.Nh uses a module listed above it, which is the healthy direction.
At a glance — Code Health · 47% · Weak · gated by D18, X1 ·
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A05:2025 — Injection
22
High / Critical
A07:2025 — Authentication Failures
4
High / Critical
Roadmap
Immediately resolve the two leaked secrets and replace all weak cryptographic hashes with secure alternatives to eliminate critical vulnerabilities. Establish a CI pipeline that builds and tests every change, integrating static analysis and security scanning to prevent regressions. Finally, address the ten SQL injection findings identified in the static analysis to harden the application's data access layer.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 2 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED, REDACTED.
Run what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name. This repository constructs a collision-broken hash (MD5/SHA1) at 6 sites, not one: `Lfz.Core/Security/Cryptography/StringDECHelper.cs:192` (MD5CryptoServiceProvider), `Lfz.Core/Security/Cryptography/StringDECHelper.cs:210` (MD5CryptoServiceProvider), `Lfz.Core/Security/Cryptography/TripleDESHelper.cs:81` (MD5CryptoServiceProvider), `Lfz.Core/Security/Cryptography/TripleDESHelper.cs:114` (MD5CryptoServiceProvider), `REDACTED:226` (SHA1CryptoServiceProvider), `Lfz.Core/Utitlies/Utils.cs:1003` (MD5CryptoServiceProvider). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 41
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 252
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 80
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 9
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 56 of 60 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 4 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.8 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.
Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.
What we checked — 60 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 356 of 373 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability NOT MEASURED: the test run produced no results for any test tier, so no test ever ran and flakiness could not be exercised. The cause could not be attributed, so it is excluded from the score rather than read as an absence of tests.
D12 Dependency Hygiene — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `dotnet list package` did not return usable output (restore or query failed); no outdated/vulnerable/deprecated data to assess. The tool said: `dotnet list package` exited 1 with no output.
D14 License Compliance — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. License scan produced no result — the tool ran but wrote no JSON report (no package reference resolved); the offline NuGet fallback resolved nothing.
D15 Churn × Complexity Hotspots — measured, with a gap in what it reached — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Git history depth insufficient — this repository has 6 commit(s), too few for a reliable trend signal. The clone is complete, so there is no deeper history to fetch: the signal returns as the project accumulates history.
D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Too few commits for a meaningful bus factor (6 commit(s) sampled, fewer than the 50 this dimension needs before a bus factor means anything).
D17 Explicit Debt — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The C# workspace loaded this repository's projects but reported a load failure, and the dead-code reference search is unreliable over a graph that did not load cleanly, so it was skipped. The other debt markers on this row were read; dead symbols were not, and their absence from the score is not a finding that the code has none. First load diagnostic: Failure: Msbuild failed when processing the file 'Lfz.Core/Lfz.Core.NET4.csproj' with message: Could not find rule set file "AllRules.ruleset".
D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The loaded project set declares no packable project and no `.Contracts` project, so there is no intentionally-exposed surface for API consistency to be judged over.
D28 Secrets (history) — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. D28's config-credential rule (WD-SECRET-0002) parses each committed `.json` config as a document and reads credential-named values; `Lfz.Core/Config/RunConfig.json` did not parse (JSON5, a template, several concatenated documents), so a credential bound there is UNMEASURED by that rule. gitleaks still scanned the same files as text.
D32 Data Compliance (PII/GDPR) — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `Lfz.Core/Enums/ChoseYesOrNo.cs`, `Lfz.Core/Enums/Hr/HrDepartmentType.cs`, `Lfz.Core/Enums/Hr/HrEnum.cs`, `Lfz.Core/Enums/Sex.cs` produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
D34 Knowledge Freshness — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Too few commits to judge knowledge freshness (6 commit(s) sampled).
D35 Change Coupling — measured, with a gap in what it reached — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Git history depth insufficient — this repository has 6 commit(s), too few for a reliable change-coupling signal. The clone is complete, so there is no deeper history to fetch: the signal returns as the project accumulates history.
D39 IL Efficiency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. IL NOT MEASURED: the analyzer's own build of this repository failed for an ENVIRONMENT reason (exit 1) — MSBuild's engine or the CLR gave up, or our image does not carry the SDK band/targeting pack this repository needs. This is OUR limitation, not a defect in the repo, and it is not a statement that this repository fails to build. D18 owns the question of whether this repository builds; it was not answered here.
D44 Platform End-of-Life — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This dimension reads a project's own statement about the platform it runs on: a TargetFramework in a .NET project file, a .nvmrc or .python-version, a capped requires-python, a Rust toolchain file or Cargo.toml rust-version, a .go-version, .java-version, .ruby-version, .tool-versions or .sdkmanrc, a go.mod go directive, a Maven or Gradle Java level or toolchain, a Gemfile's ruby directive, a mix.exs elixir requirement, a rebar.config minimum_otp_vsn, a pubspec.yaml SDK constraint, a build.sbt scalaVersion, or a framework major pinned by a dependency constraint. This repository carries none of them, so nothing about its platform was established. That is a gap in this analyzer's coverage, NOT a finding that the platform is supported — a language whose runtime is declared elsewhere (Package.swift, a Dockerfile) is simply not read here yet.
IC1 Incompleteness & stubs — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 14 further occurrence(s) are not listed individually; the score already reflects all 54.
X18 Disposal-pattern correctness — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 1 further occurrence(s) are not listed individually; the score already reflects all 41.
X3 Exception handling — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 1 further occurrence(s) are not listed individually; the score already reflects all 41.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
D24 Comment Value: Comment value (WHY vs WHAT) is an LLM judgement over a bounded sample — it is advisory and cannot weigh a comment against the precise code change it was written to explain.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
The LLM boundary
LLM-set scores this run (4): D19, D21, D24, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
14 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was AppUnitity.KillProcess at 29. A further 1 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being WebHelper.IsStaticResource at 17 — they are counted neither in the figure above nor in this dimension's score.
+ 9 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 14 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with AppUnitity.KillProcess (cyclomatic 29), Utils.GetDiffValue (cyclomatic 29), DatabaseInitialise.GetDataType (cyclomatic 28). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 14 together lifts Cyclomatic Complexity from 8.2 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Stand up a CI pipeline, then gate Cyclomatic Complexity in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 24 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 29 bodies over 15 down to 15 or less in Cognitive Complexity — start with Utils.TableConvertToList (cognitive 67), Utils.GetDiffValue (cognitive 50), WebHelper.ModifyQueryString (cognitive 47). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 29 together lifts Cognitive Complexity from 6.4 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Stand up a CI pipeline, then gate Cognitive Complexity in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes9.4 / 10Stronggated by 4 serious findings✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 3 TooManyMethods finding(s) in God Classes — start with Utils.cs, REDACTED, RedisBase.cs. — One of this dimension's main actionable groups (3 warning-level).
Resolve the 1 FileTooLong finding(s) in God Classes — start with Utils.cs. — One of this dimension's main actionable groups (1 warning-level).
Stand up a CI pipeline, then gate God Classes in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
49 duplicated block group(s) detected. A further 3 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.
+ 19 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 7 Duplicated block (14 lines × 2) finding(s) in Code Duplication — start with DbHelperMySQL.cs (4), REDACTED, RSACryption.cs. — One of this dimension's main actionable groups (7 warning-level).
Resolve the 5 Duplicated block (12 lines × 2) finding(s) in Code Duplication — start with TripleDESHelper.cs, ApiHttpClient.cs, REDACTED. — One of this dimension's main actionable groups (5 warning-level).
Resolve the 5 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with RSACryption.cs (2), DbHelperMySQL.cs, HttpListenServiceBase.cs. — One of this dimension's main actionable groups (5 warning-level).
Stand up a CI pipeline, then gate Code Duplication in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.
Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.
4 test methods: 4 unit, 0 integration, 0 BDD, 0 e2e.
✓ On the Gold path — maintain.
Detailed fixes: d9_recommendation.md.
Do you agree with this assessment?
D10 · Test Quality10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the tests truly assert behaviour rather than just running the code.
Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.
0 skipped, 3 zero-assertion, no mocking-framework packages referenced (hand-written doubles or no mocking) across 4 tests (1 harness-style project(s) excluded from the assertion penalty).
No direct assertions: TestMethod1 · ×3Lfz.Core.Tests/UnitTest1.cs:14
✓ On the Gold path — maintain.
Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
Resolve the 2 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 issue-level).
Stand up a CI pipeline, then gate REDACTED Scanning in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d13_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
38 deducted debt markers + unmeasured dead symbols across 24727 LoC in the .NET projects (0.9/KLoC) → score 8.2. Dead code not measured: the solution did not load cleanly, so the reference search was skipped.
Resolve the 10 EmptyCatchBlock finding(s) in Explicit Debt — start with Utils.cs (2), Utils.partial.cs (2), CollectionExtensions.cs. — One of this dimension's main actionable groups (10 issue-level).
Resolve the 10 WriteOnlyPrivateField finding(s) in Explicit Debt — start with MySqlDataServicesProvider.cs, SqlServerDataServicesProvider.cs, SqlCeDataServicesProvider.cs. — One of this dimension's main actionable groups (10 issue-level).
Resolve the 16 CommentedOutCode finding(s) in Explicit Debt — start with PDFEngine.cs (8), RawSqlRepository.cs (2), DbHelperMySQL.cs. — One of this dimension's main actionable groups (16 warning-level).
Stand up a CI pipeline, then gate Explicit Debt in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D18 · Solution Shape3.0 / 10Weak✓ Tool-verified
What it measures: Whether the solution is laid out in a sensible, conventional structure.
Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.
2 projects, 211 source files, 24838 hand-written lines of code (24727 production / 111 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), 1 inter-project edges (build failed).
Build failed
What to do
Resolve the 1 Build failed finding(s) in Solution Shape. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d18_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.
This single README.md is a repository-level overview of the tools directory, listing each subdirectory (Caching, CQRS, Configuration, Data, File IO, Logging, ActiveMQ, Socket, REST API, Security, Services, WCF, Utilities) and its purpose with short descriptions. It names every listed subdirectory but does not explain what the entire project is or how to use it as a whole — an overview section would state the tools' role and the main directory they belong to (the README itself). The document also lacks installation/build/usage examples and contribution guidance, so those fall under the root-level missing-... categories.
Resolve the 3 Documentation finding(s) in Documentation Quality — start with README.md (3). — One of this dimension's main actionable groups (3 recommendation-level).
Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.
6 naming inconsistencies across 200 sampled symbols.
The namespace 'Lfz.Utitlies' contains a typo ('Utitlies' instead of 'Utilities'). Furthermore, the types within this namespace have inconsistent naming conventions: some are plural nouns (Utils, Options), some are singular nouns (TypeParse, ExportEngine), and some are descriptive phrases (DigitToMoneyText, AppUnitity). 'AppUnitity' also appears to be a typo for 'AppUtility' or 'AppUnit'.
Inconsistent spelling of 'Serializer'. The field 'serializater' uses the incorrect 'z' spelling, while other parts of the codebase (e.g., 'XmlSerializer' in System namespace) use the correct 's'. Additionally, the field name 'serializater' is a typo for 'serializer'.
Typo in method name 'GetDiffMoneths'. 'Moneths' is a misspelling of 'Months'.
Inconsistent spelling of 'Convention'. The type 'ReferenceConvention' uses the correct spelling, but the class 'PropertyConvertion' (likely intended to be 'PropertyConvention' or 'PropertyConverter') uses 'Convertion' which is a typo for 'Conversion' or 'Converter'. If it is a convention, it should be 'PropertyConvention'.
Typo in class name 'ConsoleLoger'. It should be 'ConsoleLogger'.
+ 1 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 1 The namespace 'Lfz.Utitlies' contains a typo ('Utitlies' instead of… finding(s) in Naming Consistency. — One of this dimension's main actionable groups (1 recommendation-level).
Resolve the 1 Inconsistent spelling of 'Serializer'. The field 'serializater' uses the… finding(s) in Naming Consistency. — One of this dimension's main actionable groups (1 recommendation-level).
Resolve the 1 Typo in method name 'GetDiffMoneths'. 'Moneths' is a misspelling of… finding(s) in Naming Consistency. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D24 · Comment ValueStrong◐ Sampled · advisory
What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).
Method: Judged by language model at low temperature (0.0-0.1) on deterministically sampled inline comments with surrounding code; findings verified back to sampled comments by substring match. Advisory, sampled.
44 valuable / 2 redundant across 200 sampled comments; 4 shown with locations.
misleading comment · ×2REDACTED:153
redundant comment · ×2REDACTED:479
What to do
Resolve the 2 misleading comment finding(s) in Comment Value — start with REDACTED (2). — One of this dimension's main actionable groups (2 recommendation-level).
Resolve the 2 redundant comment finding(s) in Comment Value — start with REDACTED (2). — One of this dimension's main actionable groups (2 recommendation-level).
Detailed fixes: d24_recommendation.md · top locations in Appendix A, every location in findings.md.
1 of 2 projects flagged as possibly oversized/incoherent.
Projects may be oversized for their cohesion
What to do
Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D27 · Navigability8.1 / 10Strong✓ Tool-verified
What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.
Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.
Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.
80 % of calls cross a namespace and 8 % go through an interface, but 86 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: medium — clean/modular boundaries expected.
Resolve the 1 Pass-through layer finding(s) in Navigability — start with ICacheSerializater.cs. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d27_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
1 finding(s): 0 critical, 1 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.
REDACTED
REDACTED
What to do
Resolve the 1 REDACTED finding(s) in Secrets (history) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
22 finding(s): 0 critical, 15 high, 7 medium, 0 low. semgrep hit a parse error in 4 file(s) — `Lfz.Core/Enums/ChoseYesOrNo.cs` (lines 8–9), `Lfz.Core/Enums/Hr/HrDepartmentType.cs` (lines 12–16, line 20), `Lfz.Core/Enums/Hr/HrEnum.cs` (lines 17–61, line 65, lines 78–90, …), `Lfz.Core/Enums/Sex.cs` (lines 8–9) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
+ 2 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 10 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (10). — One of this dimension's main actionable groups (10 issue-level).
Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (3). — One of this dimension's main actionable groups (3 issue-level).
Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 issue-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
What to do
The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
The namespaces Lfz.Config ↔ Lfz.IO depend on each other. The lightest dependency in the cycle is Lfz.Config → Lfz.IO (Lfz.Config.DefaultConfigFileManager → Lfz.IO.IStorageProvider, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — REDACTED:5
The namespaces Lfz.Data.Nh ↔ Lfz.Data.Nh.Providers depend on each other. The lightest dependency in the cycle is Lfz.Data.Nh → Lfz.Data.Nh.Providers (Lfz.Data.Nh.SessionFactoryHolder → Lfz.Data.Nh.Providers.IDataServicesProviderFactory, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — Lfz.Core/Data/Nh/SessionFactoryHolder.cs:4
What to do
Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.
Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.
Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
`IWebHelper` declares 18 members: `GetUrlReferrer`, `UrlEncode`, `GetCurrentIpAddress`, `GetThisPageUrl`, `GetThisPageUrl`, `IsCurrentConnectionSecured`, `ServerVariables`, `GetStoreHost`, `GetStoreLocation`, `GetStoreLocation`, `IsStaticResource`, `MapPath`, `ModifyQueryString`, `RemoveQueryString`, `QueryString`, `RestartAppDomain`, `IsRequestBeingRedirected`, `GetParamValueByName`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 18 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — Lfz.Core/IWebHelper.cs:8
`IRawSqlRepository<T>` declares 21 members under just 15 distinct name(s): `GetFirstOrDefault`, `Logger`, `FormatModel`, `FormatModel`, `GetPaged`, `GetModel`, `GetList`, `Count`, `Exists`, `Exists`, `Create`, `Create`, `Update`, `Update`, `Update`, `Delete`, `Delete`, `DeleteByField`, `ExecuteScalar`, `Execute`, `ExecuteDataSet`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 21 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 21 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — Lfz.Core/Data/IRawSqlRepository.cs:13
`IRepository<T>` declares 18 members under just 14 distinct name(s): `CurrentDbContext`, `Commit`, `Create`, `Update`, `CreateOrUpdate`, `Delete`, `Delete`, `Get`, `Get`, `GetAll`, `Table`, `Count`, `Exists`, `Fetch`, `Fetch`, `Fetch`, `GetPaged`, `ExecuteSql`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 18 separate responsibilities: a caller binds to 14 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 18 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — Lfz.Core/Data/IRepository.cs:14
`INhRepository<T>` declares 16 members under just 12 distinct name(s): `Create`, `Update`, `Delete`, `Delete`, `Copy`, `Flush`, `Get`, `Get`, `Table`, `GetNamedQuery`, `Count`, `Fetch`, `Fetch`, `Fetch`, `GetPaged`, `Exists`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 12 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — Lfz.Core/Data/Nh/INhRepository.cs:10
`IBusinessService<TElement>` declares 22 members: `PrimaryKey`, `SearchService`, `TableName`, `BuildCreateSql`, `BuildUpdateSql`, `GetByKey`, `Delete`, `Get`, `Delete`, `Get`, `Get`, `DeleteByKey`, `Exists`, `ExcuteSql`, `CreateOrUpdate`, `Create`, `Update`, `GetList`, `ToDictionary`, `GetPaged`, `Format`, `GetDictionary`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 22 declarations carry 19 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 19 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — Lfz.Core/Data/RawSql/IBusinessService.cs:11
`IRawSqlSearchService` declares 19 members: `GetPropertyInfos`, `DbProviderConfig`, `GetPaged`, `GetByKey`, `GetModel`, `GetModel`, `Delete`, `DeleteByKey`, `GetList`, `GetListWithSingleValue`, `GetSingleObject`, `GetSingle`, `Count`, `Exists`, `ExcuteSql`, `Query`, `QueryTable`, `Format`, `GetDictionary`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 19 declarations carry 18 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 18 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — Lfz.Core/Data/RawSql/IRawSqlSearchService.cs:25
What to do
Split fat interfaces into focused role-interfaces so clients depend only on what they use.
Where the width is an overload set rather than separate responsibilities, collapse the overloads instead — segregating those relieves no caller.
Do you agree with this assessment?
C1 · Data Protection3.5 / 10Weak✓ Tool-verified
Other · Security — Whether sensitive data is encrypted at rest and in transit and keys are vaulted.
Method: Roslyn plus filesystem scan: encryption presence (EF ColumnEncryption, key-vault references, HTTPS enforcement) and key-derivation KDF detection. Deterministic.
What to do
Strengthen data-at-rest protection: vault your keys (Azure Key Vault / AWS KMS / IDataProtector key ring) and encrypt the most sensitive columns (EF HasConversion encryption or provider-native column encryption) — partial coverage still leaves gaps.
Enforce HTTPS (UseHttpsRedirection / RequireHttpsMetadata) so data in transit is always encrypted.
Do you agree with this assessment?
C2 · Access Controls7.0 / 10Strong✓ Tool-verified
Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.
Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.
Authorization IS enforced here (by an auth-gate middleware that short-circuits unauthorized requests) — this is NOT a claim that the code is unprotected. What's missing is a NAMED rule set: the middleware encodes the access rules inline, so the rules can't be listed, reviewed or tested apart from the middleware body that applies them. Recommendation, not a defect.
What to do
Name the access rules — give each one a named predicate/policy object your middleware consults, so the rule set can be reviewed and unit-tested independently of the pipeline that enforces it.
Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×2) — Lfz.Core/Data/Nh/Providers/AbstractDataServicesProvider.cs:99, Lfz.Core/Data/Nh/Providers/AbstractDataServicesProvider.cs:104
What to do
Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
`FillEntity` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — Lfz.Core/Data/Repository.cs:368
A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). (×38) — Lfz.Core/Data/DbHelperMySQL.cs:696, Lfz.Core/Data/DbHelperMySQL.cs:697, REDACTED:121, …
3 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers). — Lfz.Core/Draw/LineEquation.cs:106
What to do
Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
The root README is 43 words, against a bar of 120. Of the three newcomer-critical sections this check looks for by heading, it found no a build/run or getting-started section, no a testing section, no an architecture or project-map section. Sections are matched on HEADING text only, so material written under a heading this check does not recognise — or with no heading at all — is not seen and this row may understate what the document covers.
What to do
Expand the README with getting-started, architecture overview and a project map.
Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
Add a README to the 2 of 2 project(s) that lack one — worth up to 2 pts.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).
Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.
Do you agree with this assessment?
P1 · CI/CD gates0.0 / 10Critical✓ Tool-verified
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, …) — changes aren't gated by an automated build/test.
What to do
Add a CI workflow that builds and runs the test suite on every push/PR.
Do you agree with this assessment?
P2 · Observability7.0 / 10Strong✓ Tool-verified
Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.
For more than a log file, an `ActivitySource`/`EventSource` the user can switch on gives you a structured trace to attach to a bug report. A health-check endpoint does not apply here: nothing orchestrates or load-balances a binary the user launches.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) — this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
What to do
Run what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.
Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.
No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
What to do
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
Other · Security — Cryptographic hygiene (weak hash/cipher, password key-derivation). This codebase has no web surface, so transport/header/cookie/CSRF controls are N/A and only crypto is scored.
Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.
MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses. (×6) — REDACTED:226, Lfz.Core/Security/Cryptography/StringDECHelper.cs:192, Lfz.Core/Security/Cryptography/StringDECHelper.cs:210, …
`KEY_64` is the symmetric cipher key and is a compile-time constant, so the secret this operation depends on is published with the source. A key that ships with the source is not secret: every contributor, fork, mirror and released binary carries it, so anyone holding the repository can decrypt what any installation encrypted, and there is no way to invalidate what was already protected because every deployment built from this source shares the value. Where the constant is a password salt the consequence differs but is no smaller — one global salt means precomputation amortises across every installation, which is the property salting exists to destroy. Read the value from configuration, an environment variable or a secrets manager at startup and FAIL FAST when it is absent, so a missing key stops the process instead of silently falling back to a shared default; treat the committed value as disclosed and rotate it rather than only deleting the line. For a salt, generate a fresh random one per password and store it alongside the hash. — Lfz.Core/Security/Cryptography/StringDECHelper.cs:18
This type encrypts through `SymmetricAlgorithm`, whose every cipher mode (CBC/ECB/OFB/CFB/CTS) is unauthenticated, and no keyed MAC or AEAD cipher appears anywhere in it — so nothing establishes that the ciphertext it produced is the ciphertext it later reads back. Encryption alone provides confidentiality, not integrity: unauthenticated CBC is MALLEABLE, and an attacker who can modify stored or transmitted ciphertext can flip chosen plaintext bits in the following block by flipping ciphertext bits in the preceding one, without ever knowing the key. Where the decrypt path reports failure differently for a padding error than for a downstream one — a broad `catch` that returns null is the usual spelling — the same construction also answers the attacker's questions, which is the padding-oracle shape that recovers plaintext outright. Prefer an AEAD cipher: `AesGcm` or `ChaCha20Poly1305` authenticate the ciphertext as part of encrypting it, and give you an associated-data slot for the surrounding context. Where the format cannot change, MAC it with encrypt-then-MAC — HMAC-SHA256 over the IV and the ciphertext together, with a key derived separately from the encryption key — and verify that tag with `CryptographicOperations.FixedTimeEquals` BEFORE decrypting anything. (×7) — Lfz.Core/Security/Tencent/Cryptography.cs:108, Lfz.Core/Security/Cryptography/DESHelper.cs:47, Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:46, …
This encryption's initialisation vector is a compile-time constant, so every message encrypted under the same key gets the same IV. An IV is not a secret and does not have to be one — its whole job is to be DIFFERENT each time, so that encrypting the same plaintext twice does not produce the same ciphertext. Fix it and CBC becomes an equality oracle: the mode XORs the IV into the first plaintext block and chains from there, so two messages encrypted with the same key and IV produce byte-identical ciphertext for exactly as long as their plaintexts agree. An observer who can see two ciphertexts — a repository of encrypted config files, a database column, a backup — learns that two records match and how many blocks in they diverge, without the key and without breaking anything. The same defect under a counter-based mode is worse and not recoverable by comparison: CTR and GCM XOR the plaintext against a keystream determined by the key and nonce, so a repeated nonce leaks the XOR of the two plaintexts outright, and under GCM it also forfeits the authentication key. Generate the IV with a cryptographic RNG for each message — `RandomNumberGenerator.Fill(iv)` in .NET, `crypto.randomBytes(16)` in Node — and write it alongside the ciphertext (prepending the block is the usual spelling); the receiver reads it back from there. Deriving the IV from the key material is the specific trap to avoid: it looks like rigour and produces a constant, because the derivation's inputs do not change between messages. (×2) — Lfz.Core/Security/Cryptography/DESHelper.cs:29, Lfz.Core/Security/Cryptography/StringDECHelper.cs:18
DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes. (×14) — Lfz.Core/Security/Tencent/Cryptography.cs:98, Lfz.Core/Security/Cryptography/DESHelper.cs:45, Lfz.Core/Security/Cryptography/DESHelper.cs:72, …
What to do
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name. This repository constructs a collision-broken hash (MD5/SHA1) at 6 sites, not one: `Lfz.Core/Security/Cryptography/StringDECHelper.cs:192` (MD5CryptoServiceProvider), `Lfz.Core/Security/Cryptography/StringDECHelper.cs:210` (MD5CryptoServiceProvider), `Lfz.Core/Security/Cryptography/TripleDESHelper.cs:81` (MD5CryptoServiceProvider), `Lfz.Core/Security/Cryptography/TripleDESHelper.cs:114` (MD5CryptoServiceProvider), `REDACTED:226` (SHA1CryptoServiceProvider), `Lfz.Core/Utitlies/Utils.cs:1003` (MD5CryptoServiceProvider). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Load cryptographic key and salt material from configuration, an environment variable or a secrets manager rather than fixing it in the source, and fail fast at startup when it is absent — a default that silently works is the one that reaches production. Rotate anything already committed: it must be treated as disclosed. Salts should be generated per password and stored with the hash, never shared across installations.
Authenticate ciphertext, do not just encrypt it: move to an AEAD cipher (`AesGcm`, `ChaCha20Poly1305`), or where the wire format is fixed, add encrypt-then-MAC with HMAC-SHA256 over IV+ciphertext under a separately derived key and verify the tag with `CryptographicOperations.FixedTimeEquals` before decrypting. Unauthenticated CBC is malleable, and a decrypt path that distinguishes padding failures from other failures is a padding oracle. This repository constructs symmetric encryption whose ciphertext nothing authenticates at 7 sites, not one: `Lfz.Core/Security/Cryptography/DESHelper.cs:47` (CBC or another CipherMode member), `Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:46` (CBC or another CipherMode member), `Lfz.Core/Security/Cryptography/StringDECHelper.cs:43` (CBC or another CipherMode member), `Lfz.Core/Security/Cryptography/StringDECHelper.cs:79` (CBC or another CipherMode member), `Lfz.Core/Security/Cryptography/TripleDESHelper.cs:92` (CBC or another CipherMode member), `Lfz.Core/Security/Tencent/Cryptography.cs:108` (CBC or another CipherMode member), `Lfz.Core/Security/Tencent/Cryptography.cs:137` (CBC or another CipherMode member). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Generate a fresh random IV for every encryption with `RandomNumberGenerator.Fill` and store or transmit it next to the ciphertext, rather than fixing it in the source or deriving it from the key material — a derived IV is constant, because its inputs do not vary between messages. An IV need not be secret, only unpredictable and unique per message; under CTR/GCM a repeated nonce is catastrophic rather than merely leaky. This repository constructs an initialisation vector that does not vary per message at 2 sites, not one: `Lfz.Core/Security/Cryptography/DESHelper.cs:29` (a compile-time constant), `Lfz.Core/Security/Cryptography/StringDECHelper.cs:18` (a compile-time constant). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Replace DES/3DES (and bare RijndaelManaged) with AES-GCM via `Aes.Create()`. This repository constructs a broken or deprecated cipher at 14 sites, not one: `Lfz.Core/Security/Cryptography/DESHelper.cs:45` (DESCryptoServiceProvider), `Lfz.Core/Security/Cryptography/DESHelper.cs:72` (DESCryptoServiceProvider), `REDACTED:34` (RijndaelManaged), `Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:45` (DESCryptoServiceProvider), `Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:81` (DESCryptoServiceProvider), `Lfz.Core/Security/Cryptography/StringDECHelper.cs:31` (DESCryptoServiceProvider), `Lfz.Core/Security/Cryptography/StringDECHelper.cs:67` (DESCryptoServiceProvider), `Lfz.Core/Security/Cryptography/StringDECHelper.cs:108` (DESCryptoServiceProvider), and 6 further site(s). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout. (×13) — Lfz.Core/WebApi/ApiHttpClient.cs:61, Lfz.Core/WebApi/ApiHttpClient.cs:84, Lfz.Core/WebApi/ApiHttpClient.cs:106, …
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.
Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.
Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.
Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.
Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
`cmd` is a `MySqlCommand`, which implements `IDisposable`, and it is created here (line 149). Every use of it in `ExecuteSqlTran` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cmd = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Data/DbHelperMySQL.cs:149
`cmd` is a `MySqlCommand`, which implements `IDisposable`, and it is created here (line 345). Every use of it in `ExecuteReader` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cmd = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Data/DbHelperMySQL.cs:345
`command` is a `MySqlDataAdapter`, which implements `IDisposable`, and it is created here (line 371). Every use of it in `Query` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var command = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Data/DbHelperMySQL.cs:371
`command` is a `MySqlDataAdapter`, which implements `IDisposable`, and it is created here (line 397). Every use of it in `Query` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var command = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Data/DbHelperMySQL.cs:397
`cmd` is a `SqlCommand`, which implements `IDisposable`, and it is created here (line 384). Every use of it in `ExecuteReader` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cmd = …;`), which releases it at the end of the scope on every path including a throw. — REDACTED:384
`aes` is a `RijndaelManaged`, which implements `IDisposable`, and it is created here (line 98). Every use of it in `AES_encrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var aes = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Tencent/Cryptography.cs:98
`aes` is a `RijndaelManaged`, which implements `IDisposable`, and it is created here (line 126). Every use of it in `AES_encrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var aes = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Tencent/Cryptography.cs:126
`aes` is a `RijndaelManaged`, which implements `IDisposable`, and it is created here (line 197). Every use of it in `AES_decrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var aes = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Tencent/Cryptography.cs:197
`rsa` is a `RSACryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 28). Every use of it in `RSAKey` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var rsa = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/RSACryption.cs:28
`rsa` is a `RSACryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 54). Every use of it in `RSAEncrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var rsa = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/RSACryption.cs:54
`rsa` is a `RSACryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 74). Every use of it in `RSAEncrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var rsa = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/RSACryption.cs:74
`rsa` is a `RSACryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 90). Every use of it in `RSADecrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var rsa = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/RSACryption.cs:90
`rsa` is a `RSACryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 104). Every use of it in `RSADecrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var rsa = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/RSACryption.cs:104
`MD5` is a `HashAlgorithm`, which implements `IDisposable`, and it is created here (line 123). Every use of it in `GetHash` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var MD5 = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/RSACryption.cs:123
`MD5` is a `HashAlgorithm`, which implements `IDisposable`, and it is created here (line 137). Every use of it in `GetHash` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var MD5 = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/RSACryption.cs:137
`MD5` is a `HashAlgorithm`, which implements `IDisposable`, and it is created here (line 151). Every use of it in `GetHash` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var MD5 = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/RSACryption.cs:151
`MD5` is a `HashAlgorithm`, which implements `IDisposable`, and it is created here (line 165). Every use of it in `GetHash` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var MD5 = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/RSACryption.cs:165
`des` is a `DESCryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 31). Every use of it in `Encrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var des = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/StringDECHelper.cs:31
`cs` is a `CryptoStream`, which implements `IDisposable`, and it is created here (line 43). Every use of it in `Encrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cs = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/StringDECHelper.cs:43
`des` is a `DESCryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 67). Every use of it in `Encrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var des = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/StringDECHelper.cs:67
`cs` is a `CryptoStream`, which implements `IDisposable`, and it is created here (line 79). Every use of it in `Encrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cs = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/StringDECHelper.cs:79
`des` is a `DESCryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 108). Every use of it in `Decrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var des = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/StringDECHelper.cs:108
`cs` is a `CryptoStream`, which implements `IDisposable`, and it is created here (line 122). Every use of it in `Decrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cs = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/StringDECHelper.cs:122
`des` is a `DESCryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 149). Every use of it in `Decrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var des = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/StringDECHelper.cs:149
`cs` is a `CryptoStream`, which implements `IDisposable`, and it is created here (line 163). Every use of it in `Decrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cs = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/StringDECHelper.cs:163
`crypto` is a `MD5CryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 210). Every use of it in `Hash` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var crypto = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/StringDECHelper.cs:210
`objDESCrypto` is a `TripleDESCryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 80). Every use of it in `Encrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var objDESCrypto = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/TripleDESHelper.cs:80
`dCSP` is a `DESCryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 45). Every use of it in `EncryptDES` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var dCSP = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/DESHelper.cs:45
`cStream` is a `CryptoStream`, which implements `IDisposable`, and it is created here (line 47). Every use of it in `EncryptDES` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cStream = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/DESHelper.cs:47
`DCSP` is a `DESCryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 72). Every use of it in `DecryptDES` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var DCSP = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/DESHelper.cs:72
`cStream` is a `CryptoStream`, which implements `IDisposable`, and it is created here (line 74). Every use of it in `DecryptDES` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cStream = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/DESHelper.cs:74
`fin` is a `FileStream`, which implements `IDisposable`, and it is created here (line 35). Every use of it in `EncryptData` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var fin = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:35
`des` is a `DES`, which implements `IDisposable`, and it is created here (line 45). Every use of it in `EncryptData` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var des = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:45
`encStream` is a `CryptoStream`, which implements `IDisposable`, and it is created here (line 46). Every use of it in `EncryptData` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var encStream = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:46
`fin` is a `FileStream`, which implements `IDisposable`, and it is created here (line 71). Every use of it in `DecryptData` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var fin = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:71
`des` is a `DES`, which implements `IDisposable`, and it is created here (line 81). Every use of it in `DecryptData` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var des = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:81
`encStream` is a `CryptoStream`, which implements `IDisposable`, and it is created here (line 82). Every use of it in `DecryptData` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var encStream = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:82
`cs` is a `CryptoStream`, which implements `IDisposable`, and it is created here (line 81). Every use of it in `Encrypto` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cs = …;`), which releases it at the end of the scope on every path including a throw. — REDACTED:81
`sr` is a `StreamReader`, which implements `IDisposable`, and it is created here (line 101). Every use of it in `Decrypto` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var sr = …;`), which releases it at the end of the scope on every path including a throw. — REDACTED:101
`client` is a `SmtpClient`, which implements `IDisposable`, and it is created here (line 119). Every use of it in `Send` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var client = …;`), which releases it at the end of the scope on every path including a throw. — Lfz.Core/Utitlies/NetMailUtils.cs:119
What to do
Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.
Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.
Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.
Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.
Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
`throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack. (×21) — Lfz.Core/Data/DbHelperMySQL.cs:112, Lfz.Core/Data/DbHelperMySQL.cs:134, Lfz.Core/Data/DbHelperMySQL.cs:197, …
`catch (System.Security.SecurityException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — Lfz.Core/CommonHelper.cs:175
`throw ex;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack. (×2) — Lfz.Core/Config/SerializationHelper.cs:135, Lfz.Core/Config/SerializationHelper.cs:166
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×10) — Lfz.Core/Utitlies/AppUnitity.cs:196, Lfz.Core/Utitlies/Utils.PropertyAssignment.cs:269, Lfz.Core/Utitlies/Utils.WinForm.cs:125, …
`catch (FormatException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — Lfz.Core/Utitlies/DigitToMoneyText.cs:193
`catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. (×4) — Lfz.Core/Utitlies/UrlOper.cs:172, Lfz.Core/Utitlies/Utils.WinForm.cs:34, Lfz.Core/Utitlies/Utils.WinForm.cs:52, …
`catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — Lfz.Core/Utitlies/Utils.cs:950
What to do
Rethrow loses stack trace (`throw ex;`)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X32 · Type resolved by simple name across every loaded assembly10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a plugin lookup names the type it means — searching every assembly loaded into the process for a candidate whose SIMPLE name equals a string supplied at runtime, and taking the first one found, is decided by assembly LOAD ORDER rather than by this source, so the same name can resolve to a different type on the next run.
Method: Roslyn syntax only, no semantic model: every invocation of `First`/`FirstOrDefault`/`Single`/`SingleOrDefault` whose OWN expression subtree contains both a `GetAssemblies()` call and a `GetTypes()`/`GetExportedTypes()` call — a single-element pick out of every type loaded into the process. A nested selector in the same chain sees no `GetAssemblies()` in its own subtree and is outside the population, so one lookup counts once however many links its chain has. A finding additionally needs both remaining halves: the selector must be `First`/`FirstOrDefault` (`Single`/`SingleOrDefault` reports the ambiguity rather than resolving it, and is counted and never reported), and the chain must carry an `==` comparison of `<lambda parameter>.Name` against something that is not a literal. The receiver must be a plain identifier bound by one of the chain’s own lambdas, which places `assembly.GetName().Name == "X"` outside the rule by construction. One exemption: a `.Name` test joined by `&&` to a `FullName`/`AssemblyQualifiedName` test on the same identifier is spared; joined by `||` it is not. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.
Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.
Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it. (×5) — Lfz.Core/Rest/HttpContextExtension.cs:26, Lfz.Core/Network/UdpSyncListenReceviceService.cs:127, Lfz.Core/Network/UdpSyncListenReceviceService.cs:146, …
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Unscored — 1 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
X10 Duplicated predicate — 4 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 5 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
C3 Audit Trail — Repo shows no audit-logging mechanism (IAuditable, an immutable audit log, an EF SaveChanges interceptor) for sensitive changes — absence of evidence is not evidence of a working control. Record an audit trail in code (or document where it lives) so this dimension can be scored.
C4 Data Retention — Repo shows no data-retention / TTL / cleanup mechanism for personal data — absence of evidence is not evidence of a working control. Define retention periods and a purge/cleanup job (or TTL) in code, or document where retention is enforced, so this dimension can be scored.
C5 Data-Subject Rights — Repo shows no corroborated data-subject-rights mechanism (erasure / export-portability / consent) tied to a subject id or GDPR vocabulary — absence of evidence is not evidence of a working control. Implement erasure, data export/portability and consent tracking over the subject's records.
P4 Deployment & Rollback — not evidenced — no deploy/rollback/approval signal in the repo; absence of evidence is not evidence of a manual release
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 52 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
AX1 Captive dependencies — no DI registrations detected
AX2 Stateful singletons — no singleton implementations detected
AX4 Dependency direction — not applicable to a CQRS architecture (the inward-dependency rule is for layered/clean styles)
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — no test/production split to check
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB1 Runtime evidence locked — no reproducible boot — This repository has nothing the runtime tiers could boot or serve — no markup, no UI framework or web-server dependency, no UI component source, no native UI project and no API definition — nothing here is a surface to boot — so runtime a11y/egress/header evidence has no subject here. Not applicable: this is neither a gap in the scan nor a finding about your code.
D11 Test Reliability — Test reliability not measured — no test run produced results
D12 Dependency Hygiene — Dependency hygiene not measured
D14 License Compliance — Licence collector did not produce a result
D16 Bus Factor — too few commits for a meaningful bus factor
D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
D23 Boundary Type-Coupling — single shared-core project — no cross-context coupling to assess
D25 ADR Conformance — no ADRs to check
D30 Dependency Vulnerabilities — nuget: `dotnet list package --vulnerable` could not read this solution's dependency graph — it reported an error for at least one project and returned no package data at all (typically a packages.config / non-PackageReference project, which the command cannot read). An unreadable dependency graph is not a clean one; migrate the project(s) to PackageReference to enable this scan
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D32 Data Compliance (PII/GDPR) — 4 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D34 Knowledge Freshness — too few commits to judge knowledge freshness
D36 Supply-chain Provenance & Signing — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .circleci, .buildkite, .woodpecker, .teamcity, .gitlab-ci.yml, .travis.yml, bitbucket-pipelines.yml, .drone.yml, .cirrus.yml, .woodpecker.yml, appveyor.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, .azuredevops/, Jenkinsfile); there is no build to attest provenance for.
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D39 IL Efficiency — IL not measured — the analyzer's build of the target did not succeed
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D43 Malicious Dependencies — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).
D44 Platform End-of-Life — Platform end-of-life not assessed — this repository declares no platform this pass reads
D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
D8 Code Coverage — Coverage NOT MEASURED: `--collect:"XPlat Code Coverage"` names a data collector that ships in the `coverlet.collector` package, and this repository wires up none — no test project references it and no runsettings declares one. The absence of coverage here is therefore not evidence about the suite or about our analyzer environment: without a collector, `--collect` produces nothing even from a suite that builds and passes. Add a `coverlet.collector` PackageReference to the test project(s) (or commit the Cobertura/OpenCover/lcov report your CI produces) and real coverage will be measured. It is excluded from the score rather than counted as a near-zero defect.
DM1 Domain Modelling — not scored — this repository shows none of the 3 signals this lens looks for
ED1 Event-Driven — not scored — this repository shows only 1 of the 3 signals this lens looks for (4 CQRS handler(s))
ED5 Idempotency — 4 mutating command handler(s)/consumer(s) detected, but none exposes a recognised handler entry method — idempotency not assessed
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
P12 CI test-gate honesty — no CI workflow found
P7 Outbound HTTP resilience — not applicable — this isn't a service/API/worker
P8 Schema migrations — no EF Core usage detected
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Cobertura — `dotnet test --collect:"XPlat Code Coverage"` with a `coverlet.collector` PackageReference) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
PF1 Benchmark discipline — Performance is assessed only for perf-relevant repos — a packaged library, one that ships benchmarks, or one already using allocation-aware APIs. This repo isn't one, so the Performance lens is not applicable and is excluded from the score.
PF2 Allocation hygiene — Performance is assessed only for perf-relevant repos — a packaged library, one that ships benchmarks, or one already using allocation-aware APIs. This repo isn't one, so the Performance lens is not applicable and is excluded from the score.
PF3 Async & latency hygiene — Performance is assessed only for perf-relevant repos — a packaged library, one that ships benchmarks, or one already using allocation-aware APIs. This repo isn't one, so the Performance lens is not applicable and is excluded from the score.
X2 Cancellation propagation — no async method does work a token could cancel
X5 Nullable reference types — no NRT-eligible projects
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
EmptyCatchBlock Lfz.Core/Collections/CollectionExtensions.cs:271— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock Lfz.Core/Network/TcpListenServiceBase.cs:143— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock Lfz.Core/Utitlies/AppUnitity.cs:196— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock REDACTED:347— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock Lfz.Core/Utitlies/Utils.PropertyAssignment.cs:269— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock Lfz.Core/Utitlies/Utils.WinForm.cs:125— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock Lfz.Core/Utitlies/Utils.cs:565— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock Lfz.Core/Utitlies/Utils.cs:1047— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock Lfz.Core/Utitlies/Utils.partial.cs:343— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock Lfz.Core/Utitlies/Utils.partial.cs:522— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
WriteOnlyPrivateField Lfz.Core/Data/Nh/Providers/MySqlDataServicesProvider.cs:9— private string _dataFolder — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField Lfz.Core/Data/Nh/Providers/SqlServerDataServicesProvider.cs:6— private string _dataFolder — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField Lfz.Core/Data/Nh/Providers/SqlCeDataServicesProvider.cs:14— private string _connectionString — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField Lfz.Core/Data/Nh/SessionFactoryHolder.cs:34— private FileCacheManager<NHibernate.Cfg.Configuration> _cacheManager — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField Lfz.Core/Data/Nh/SessionInterceptor.cs:14— private ISession _session — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField Lfz.Core/Media/WavPlayer.cs:34— private ConcurrentDictionary<string, byte[]> _fileByteses — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField Lfz.Core/Network/HttpListenServiceBase.cs:56— private int _receiveBufferSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField Lfz.Core/Network/TcpListenServiceBase.cs:52— private int _receiveBufferSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField Lfz.Core/Network/TcpClientService.cs:31— private int _maxRecBufSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField Lfz.Core/Wcf/SelfHostWcfService.cs:29— private Type _implementedContract — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
Namespace dependency cycle REDACTED:5— The namespaces Lfz.Config ↔ Lfz.IO depend on each other. The lightest dependency in the cycle is Lfz.Config → Lfz.IO (Lfz.Config.DefaultConfigFileManager → Lfz.IO.IStorageProvider, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle Lfz.Core/Data/Nh/SessionFactoryHolder.cs:4— The namespaces Lfz.Data.Nh ↔ Lfz.Data.Nh.Providers depend on each other. The lightest dependency in the cycle is Lfz.Data.Nh → Lfz.Data.Nh.Providers (Lfz.Data.Nh.SessionFactoryHolder → Lfz.Data.Nh.Providers.IDataServicesProviderFactory, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
S1 · Cryptographic Hygiene· Cryptographic key material is a compile-time constant · ×1
Cryptographic key material is a compile-time constant Lfz.Core/Security/Cryptography/StringDECHelper.cs:18— `KEY_64` is the symmetric cipher key and is a compile-time constant, so the secret this operation depends on is published with the source. A key that ships with the source is not secret: every contributor, fork, mirror and released binary carries it, so anyone holding the repository can decrypt what any installation encrypted, and there is no way to invalidate what was already protected because every deployment built from this source shares the value. Where the constant is a password salt the consequence differs but is no smaller — one global salt means precomputation amortises across every installation, which is the property salting exists to destroy. Read the value from configuration, an environment variable or a secrets manager at startup and FAIL FAST when it is absent, so a missing key stops the process instead of silently falling back to a shared default; treat the committed value as disclosed and rotate it rather than only deleting the line. For a salt, generate a fresh random one per password and store it alongside the hash.
Serious — 252 finding(s)
X18 · Disposal-pattern correctness· Disposable created and abandoned in the method that made it · ×40
Disposable created and abandoned in the method that made it Lfz.Core/Data/DbHelperMySQL.cs:149— `cmd` is a `MySqlCommand`, which implements `IDisposable`, and it is created here (line 149). Every use of it in `ExecuteSqlTran` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cmd = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Data/DbHelperMySQL.cs:345— `cmd` is a `MySqlCommand`, which implements `IDisposable`, and it is created here (line 345). Every use of it in `ExecuteReader` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cmd = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Data/DbHelperMySQL.cs:371— `command` is a `MySqlDataAdapter`, which implements `IDisposable`, and it is created here (line 371). Every use of it in `Query` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var command = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Data/DbHelperMySQL.cs:397— `command` is a `MySqlDataAdapter`, which implements `IDisposable`, and it is created here (line 397). Every use of it in `Query` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var command = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it REDACTED:384— `cmd` is a `SqlCommand`, which implements `IDisposable`, and it is created here (line 384). Every use of it in `ExecuteReader` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cmd = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Tencent/Cryptography.cs:98— `aes` is a `RijndaelManaged`, which implements `IDisposable`, and it is created here (line 98). Every use of it in `AES_encrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var aes = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Tencent/Cryptography.cs:126— `aes` is a `RijndaelManaged`, which implements `IDisposable`, and it is created here (line 126). Every use of it in `AES_encrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var aes = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Tencent/Cryptography.cs:197— `aes` is a `RijndaelManaged`, which implements `IDisposable`, and it is created here (line 197). Every use of it in `AES_decrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var aes = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/RSACryption.cs:28— `rsa` is a `RSACryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 28). Every use of it in `RSAKey` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var rsa = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/RSACryption.cs:54— `rsa` is a `RSACryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 54). Every use of it in `RSAEncrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var rsa = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/RSACryption.cs:74— `rsa` is a `RSACryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 74). Every use of it in `RSAEncrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var rsa = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/RSACryption.cs:90— `rsa` is a `RSACryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 90). Every use of it in `RSADecrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var rsa = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/RSACryption.cs:104— `rsa` is a `RSACryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 104). Every use of it in `RSADecrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var rsa = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/RSACryption.cs:123— `MD5` is a `HashAlgorithm`, which implements `IDisposable`, and it is created here (line 123). Every use of it in `GetHash` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var MD5 = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/RSACryption.cs:137— `MD5` is a `HashAlgorithm`, which implements `IDisposable`, and it is created here (line 137). Every use of it in `GetHash` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var MD5 = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/RSACryption.cs:151— `MD5` is a `HashAlgorithm`, which implements `IDisposable`, and it is created here (line 151). Every use of it in `GetHash` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var MD5 = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/RSACryption.cs:165— `MD5` is a `HashAlgorithm`, which implements `IDisposable`, and it is created here (line 165). Every use of it in `GetHash` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var MD5 = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/StringDECHelper.cs:31— `des` is a `DESCryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 31). Every use of it in `Encrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var des = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/StringDECHelper.cs:43— `cs` is a `CryptoStream`, which implements `IDisposable`, and it is created here (line 43). Every use of it in `Encrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cs = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/StringDECHelper.cs:67— `des` is a `DESCryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 67). Every use of it in `Encrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var des = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/StringDECHelper.cs:79— `cs` is a `CryptoStream`, which implements `IDisposable`, and it is created here (line 79). Every use of it in `Encrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cs = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/StringDECHelper.cs:108— `des` is a `DESCryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 108). Every use of it in `Decrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var des = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/StringDECHelper.cs:122— `cs` is a `CryptoStream`, which implements `IDisposable`, and it is created here (line 122). Every use of it in `Decrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cs = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/StringDECHelper.cs:149— `des` is a `DESCryptoServiceProvider`, which implements `IDisposable`, and it is created here (line 149). Every use of it in `Decrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var des = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it Lfz.Core/Security/Cryptography/StringDECHelper.cs:163— `cs` is a `CryptoStream`, which implements `IDisposable`, and it is created here (line 163). Every use of it in `Decrypt` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var cs = …;`), which releases it at the end of the scope on every path including a throw.
Rethrow loses stack trace (`throw ex;`) Lfz.Core/Data/DbHelperMySQL.cs:112— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) Lfz.Core/Data/DbHelperMySQL.cs:134— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) Lfz.Core/Data/DbHelperMySQL.cs:197— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) Lfz.Core/Data/DbHelperMySQL.cs:235— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) Lfz.Core/Data/DbHelperMySQL.cs:266— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) Lfz.Core/Data/DbHelperMySQL.cs:304— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) Lfz.Core/Data/DbHelperMySQL.cs:332— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) Lfz.Core/Data/DbHelperMySQL.cs:354— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) Lfz.Core/Data/DbHelperMySQL.cs:435— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) Lfz.Core/Data/DbHelperMySQL.cs:668— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) Lfz.Core/Data/DbHelperMySQL.cs:692— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) REDACTED:181— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) REDACTED:219— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) REDACTED:275— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) REDACTED:306— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) REDACTED:343— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) REDACTED:371— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) REDACTED:393— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) REDACTED:473— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) REDACTED:508— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) REDACTED:533— `throw e;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) Lfz.Core/Config/SerializationHelper.cs:135— `throw ex;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Rethrow loses stack trace (`throw ex;`) Lfz.Core/Config/SerializationHelper.cs:166— `throw ex;` resets the exception's stack trace to this line, hiding where it really came from. Use a bare `throw;` to preserve the original stack.
Weak cipher Lfz.Core/Security/Tencent/Cryptography.cs:98— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Weak cipher Lfz.Core/Security/Cryptography/DESHelper.cs:45— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Weak cipher Lfz.Core/Security/Cryptography/DESHelper.cs:72— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Weak cipher REDACTED:34— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Weak cipher Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:45— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Weak cipher Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:81— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Weak cipher Lfz.Core/Security/Cryptography/StringDECHelper.cs:31— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Weak cipher Lfz.Core/Security/Cryptography/StringDECHelper.cs:67— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Weak cipher Lfz.Core/Security/Cryptography/StringDECHelper.cs:108— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Weak cipher Lfz.Core/Security/Cryptography/StringDECHelper.cs:149— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Weak cipher Lfz.Core/Security/Cryptography/TripleDESHelper.cs:80— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Weak cipher Lfz.Core/Security/Cryptography/TripleDESHelper.cs:113— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Weak cipher Lfz.Core/Security/Tencent/Cryptography.cs:126— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Weak cipher Lfz.Core/Security/Tencent/Cryptography.cs:197— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Sync-over-async (deadlock risk) through `.Result` Lfz.Core/WebApi/ApiHttpClient.cs:61— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` Lfz.Core/WebApi/ApiHttpClient.cs:84— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` Lfz.Core/WebApi/ApiHttpClient.cs:106— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` Lfz.Core/WebApi/ApiHttpClient.cs:129— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` Lfz.Core/WebApi/ApiHttpClient.cs:130— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` Lfz.Core/WebApi/ApiHttpClient.cs:165— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` Lfz.Core/WebApi/ApiHttpClient.cs:166— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` Lfz.Core/WebApi/ApiHttpClient.cs:205— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` Lfz.Core/WebApi/ApiHttpClient.cs:206— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` Lfz.Core/WebApi/ApiHttpClient.cs:239— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` Lfz.Core/WebApi/ApiHttpClient.cs:240— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` Lfz.Core/WebApi/ApiHttpClient.cs:279— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` Lfz.Core/WebApi/ApiHttpClient.cs:280— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Swallowed exception (empty catch) Lfz.Core/Utitlies/AppUnitity.cs:196— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) Lfz.Core/Utitlies/Utils.PropertyAssignment.cs:269— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) Lfz.Core/Utitlies/Utils.WinForm.cs:125— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) Lfz.Core/Network/TcpListenServiceBase.cs:143— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) Lfz.Core/Collections/CollectionExtensions.cs:271— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) Lfz.Core/Utitlies/Utils.cs:565— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) Lfz.Core/Utitlies/Utils.cs:1047— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) REDACTED:347— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) Lfz.Core/Utitlies/Utils.partial.cs:343— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) Lfz.Core/Utitlies/Utils.partial.cs:522— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Duplicated block (14 lines × 2) Lfz.Core/Data/DbHelperMySQL.cs:315— Lfz.Core/Data/DbHelperMySQL.cs:315-328 | REDACTED:354-367 — before extracting anything, compare `Lfz.Core/Data/DbHelperMySQL.cs` and `REDACTED` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (14 lines × 2) Lfz.Core/Data/DbHelperMySQL.cs:652— Lfz.Core/Data/DbHelperMySQL.cs:652-665 | REDACTED:492-505 — before extracting anything, compare `Lfz.Core/Data/DbHelperMySQL.cs` and `REDACTED` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `cmdParms` to `params MySqlParameter[]` in one and `params SqlParameter[]` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (14 lines × 2) Lfz.Core/Data/DbHelperMySQL.cs:481— Lfz.Core/Data/DbHelperMySQL.cs:481-494 | Lfz.Core/Data/DbHelperMySQL.cs:551-564 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Data/DbHelperMySQL.cs:481` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) Lfz.Core/Data/DbHelperMySQL.cs:220— Lfz.Core/Data/DbHelperMySQL.cs:220-233 | Lfz.Core/Data/DbHelperMySQL.cs:288-301 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Lfz.Core/Data/DbHelperMySQL.cs:303` calls `Close` and `Lfz.Core/Data/DbHelperMySQL.cs:235` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14 lines × 2) REDACTED:260— REDACTED:260-273 | REDACTED:327-340 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `REDACTED:342` calls `Close` and `REDACTED:275` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14 lines × 2) Lfz.Core/Security/Cryptography/RSACryption.cs:200— Lfz.Core/Security/Cryptography/RSACryption.cs:200-213 | Lfz.Core/Security/Cryptography/RSACryption.cs:243-256 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Security/Cryptography/RSACryption.cs:200` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Lfz.Core/Security/Cryptography/RSACryption.cs:242` calls `FromBase64String` and `Lfz.Core/Security/Cryptography/RSACryption.cs:198` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14 lines × 2) Lfz.Core/Network/HttpListenServiceBase.cs:255— Lfz.Core/Network/HttpListenServiceBase.cs:255-268 | Lfz.Core/Network/TcpListenServiceBase.cs:265-278 — before extracting anything, compare `Lfz.Core/Network/HttpListenServiceBase.cs` and `Lfz.Core/Network/TcpListenServiceBase.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
S1 · Cryptographic Hygiene· Ciphertext is encrypted but not authenticated · ×7
Ciphertext is encrypted but not authenticated Lfz.Core/Security/Tencent/Cryptography.cs:108— This type encrypts through `SymmetricAlgorithm`, whose every cipher mode (CBC/ECB/OFB/CFB/CTS) is unauthenticated, and no keyed MAC or AEAD cipher appears anywhere in it — so nothing establishes that the ciphertext it produced is the ciphertext it later reads back. Encryption alone provides confidentiality, not integrity: unauthenticated CBC is MALLEABLE, and an attacker who can modify stored or transmitted ciphertext can flip chosen plaintext bits in the following block by flipping ciphertext bits in the preceding one, without ever knowing the key. Where the decrypt path reports failure differently for a padding error than for a downstream one — a broad `catch` that returns null is the usual spelling — the same construction also answers the attacker's questions, which is the padding-oracle shape that recovers plaintext outright. Prefer an AEAD cipher: `AesGcm` or `ChaCha20Poly1305` authenticate the ciphertext as part of encrypting it, and give you an associated-data slot for the surrounding context. Where the format cannot change, MAC it with encrypt-then-MAC — HMAC-SHA256 over the IV and the ciphertext together, with a key derived separately from the encryption key — and verify that tag with `CryptographicOperations.FixedTimeEquals` BEFORE decrypting anything.
Ciphertext is encrypted but not authenticated Lfz.Core/Security/Cryptography/DESHelper.cs:47— This type encrypts through `SymmetricAlgorithm`, whose every cipher mode (CBC/ECB/OFB/CFB/CTS) is unauthenticated, and no keyed MAC or AEAD cipher appears anywhere in it — so nothing establishes that the ciphertext it produced is the ciphertext it later reads back. Encryption alone provides confidentiality, not integrity: unauthenticated CBC is MALLEABLE, and an attacker who can modify stored or transmitted ciphertext can flip chosen plaintext bits in the following block by flipping ciphertext bits in the preceding one, without ever knowing the key. Where the decrypt path reports failure differently for a padding error than for a downstream one — a broad `catch` that returns null is the usual spelling — the same construction also answers the attacker's questions, which is the padding-oracle shape that recovers plaintext outright. Prefer an AEAD cipher: `AesGcm` or `ChaCha20Poly1305` authenticate the ciphertext as part of encrypting it, and give you an associated-data slot for the surrounding context. Where the format cannot change, MAC it with encrypt-then-MAC — HMAC-SHA256 over the IV and the ciphertext together, with a key derived separately from the encryption key — and verify that tag with `CryptographicOperations.FixedTimeEquals` BEFORE decrypting anything.
Ciphertext is encrypted but not authenticated Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:46— This type encrypts through `SymmetricAlgorithm`, whose every cipher mode (CBC/ECB/OFB/CFB/CTS) is unauthenticated, and no keyed MAC or AEAD cipher appears anywhere in it — so nothing establishes that the ciphertext it produced is the ciphertext it later reads back. Encryption alone provides confidentiality, not integrity: unauthenticated CBC is MALLEABLE, and an attacker who can modify stored or transmitted ciphertext can flip chosen plaintext bits in the following block by flipping ciphertext bits in the preceding one, without ever knowing the key. Where the decrypt path reports failure differently for a padding error than for a downstream one — a broad `catch` that returns null is the usual spelling — the same construction also answers the attacker's questions, which is the padding-oracle shape that recovers plaintext outright. Prefer an AEAD cipher: `AesGcm` or `ChaCha20Poly1305` authenticate the ciphertext as part of encrypting it, and give you an associated-data slot for the surrounding context. Where the format cannot change, MAC it with encrypt-then-MAC — HMAC-SHA256 over the IV and the ciphertext together, with a key derived separately from the encryption key — and verify that tag with `CryptographicOperations.FixedTimeEquals` BEFORE decrypting anything.
Ciphertext is encrypted but not authenticated Lfz.Core/Security/Cryptography/StringDECHelper.cs:43— This type encrypts through `SymmetricAlgorithm`, whose every cipher mode (CBC/ECB/OFB/CFB/CTS) is unauthenticated, and no keyed MAC or AEAD cipher appears anywhere in it — so nothing establishes that the ciphertext it produced is the ciphertext it later reads back. Encryption alone provides confidentiality, not integrity: unauthenticated CBC is MALLEABLE, and an attacker who can modify stored or transmitted ciphertext can flip chosen plaintext bits in the following block by flipping ciphertext bits in the preceding one, without ever knowing the key. Where the decrypt path reports failure differently for a padding error than for a downstream one — a broad `catch` that returns null is the usual spelling — the same construction also answers the attacker's questions, which is the padding-oracle shape that recovers plaintext outright. Prefer an AEAD cipher: `AesGcm` or `ChaCha20Poly1305` authenticate the ciphertext as part of encrypting it, and give you an associated-data slot for the surrounding context. Where the format cannot change, MAC it with encrypt-then-MAC — HMAC-SHA256 over the IV and the ciphertext together, with a key derived separately from the encryption key — and verify that tag with `CryptographicOperations.FixedTimeEquals` BEFORE decrypting anything.
Ciphertext is encrypted but not authenticated Lfz.Core/Security/Cryptography/StringDECHelper.cs:79— This type encrypts through `SymmetricAlgorithm`, whose every cipher mode (CBC/ECB/OFB/CFB/CTS) is unauthenticated, and no keyed MAC or AEAD cipher appears anywhere in it — so nothing establishes that the ciphertext it produced is the ciphertext it later reads back. Encryption alone provides confidentiality, not integrity: unauthenticated CBC is MALLEABLE, and an attacker who can modify stored or transmitted ciphertext can flip chosen plaintext bits in the following block by flipping ciphertext bits in the preceding one, without ever knowing the key. Where the decrypt path reports failure differently for a padding error than for a downstream one — a broad `catch` that returns null is the usual spelling — the same construction also answers the attacker's questions, which is the padding-oracle shape that recovers plaintext outright. Prefer an AEAD cipher: `AesGcm` or `ChaCha20Poly1305` authenticate the ciphertext as part of encrypting it, and give you an associated-data slot for the surrounding context. Where the format cannot change, MAC it with encrypt-then-MAC — HMAC-SHA256 over the IV and the ciphertext together, with a key derived separately from the encryption key — and verify that tag with `CryptographicOperations.FixedTimeEquals` BEFORE decrypting anything.
Ciphertext is encrypted but not authenticated Lfz.Core/Security/Cryptography/TripleDESHelper.cs:92— This type encrypts through `SymmetricAlgorithm`, whose every cipher mode (CBC/ECB/OFB/CFB/CTS) is unauthenticated, and no keyed MAC or AEAD cipher appears anywhere in it — so nothing establishes that the ciphertext it produced is the ciphertext it later reads back. Encryption alone provides confidentiality, not integrity: unauthenticated CBC is MALLEABLE, and an attacker who can modify stored or transmitted ciphertext can flip chosen plaintext bits in the following block by flipping ciphertext bits in the preceding one, without ever knowing the key. Where the decrypt path reports failure differently for a padding error than for a downstream one — a broad `catch` that returns null is the usual spelling — the same construction also answers the attacker's questions, which is the padding-oracle shape that recovers plaintext outright. Prefer an AEAD cipher: `AesGcm` or `ChaCha20Poly1305` authenticate the ciphertext as part of encrypting it, and give you an associated-data slot for the surrounding context. Where the format cannot change, MAC it with encrypt-then-MAC — HMAC-SHA256 over the IV and the ciphertext together, with a key derived separately from the encryption key — and verify that tag with `CryptographicOperations.FixedTimeEquals` BEFORE decrypting anything.
Ciphertext is encrypted but not authenticated Lfz.Core/Security/Tencent/Cryptography.cs:137— This type encrypts through `SymmetricAlgorithm`, whose every cipher mode (CBC/ECB/OFB/CFB/CTS) is unauthenticated, and no keyed MAC or AEAD cipher appears anywhere in it — so nothing establishes that the ciphertext it produced is the ciphertext it later reads back. Encryption alone provides confidentiality, not integrity: unauthenticated CBC is MALLEABLE, and an attacker who can modify stored or transmitted ciphertext can flip chosen plaintext bits in the following block by flipping ciphertext bits in the preceding one, without ever knowing the key. Where the decrypt path reports failure differently for a padding error than for a downstream one — a broad `catch` that returns null is the usual spelling — the same construction also answers the attacker's questions, which is the padding-oracle shape that recovers plaintext outright. Prefer an AEAD cipher: `AesGcm` or `ChaCha20Poly1305` authenticate the ciphertext as part of encrypting it, and give you an associated-data slot for the surrounding context. Where the format cannot change, MAC it with encrypt-then-MAC — HMAC-SHA256 over the IV and the ciphertext together, with a key derived separately from the encryption key — and verify that tag with `CryptographicOperations.FixedTimeEquals` BEFORE decrypting anything.
Swallowed exception (caught, then discarded) Lfz.Core/CommonHelper.cs:175— `catch (System.Security.SecurityException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) Lfz.Core/Utitlies/DigitToMoneyText.cs:193— `catch (FormatException)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) Lfz.Core/Utitlies/UrlOper.cs:172— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) Lfz.Core/Utitlies/Utils.WinForm.cs:34— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) Lfz.Core/Utitlies/Utils.WinForm.cs:52— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) Lfz.Core/Utitlies/Utils.cs:950— `catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Swallowed exception (caught, then discarded) REDACTED:1084— `catch` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.
Weak hash algorithm REDACTED:226— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm Lfz.Core/Security/Cryptography/StringDECHelper.cs:192— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm Lfz.Core/Security/Cryptography/StringDECHelper.cs:210— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm Lfz.Core/Security/Cryptography/TripleDESHelper.cs:81— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm Lfz.Core/Security/Cryptography/TripleDESHelper.cs:114— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm Lfz.Core/Utitlies/Utils.cs:1003— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Duplicated block (12 lines × 2) Lfz.Core/Security/Cryptography/TripleDESHelper.cs:78— Lfz.Core/Security/Cryptography/TripleDESHelper.cs:78-89 | Lfz.Core/Security/Cryptography/TripleDESHelper.cs:111-122 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Security/Cryptography/TripleDESHelper.cs:78` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) Lfz.Core/WebApi/ApiHttpClient.cs:63— Lfz.Core/WebApi/ApiHttpClient.cs:63-74 | Lfz.Core/WebApi/ApiHttpClient.cs:86-97 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/WebApi/ApiHttpClient.cs:63` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) REDACTED:102— REDACTED:102-113 | REDACTED:224-235 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) Lfz.Core/Media/WavPlayer.cs:94— Lfz.Core/Media/WavPlayer.cs:94-105 | Lfz.Core/Media/WavPlayer.cs:123-134 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Media/WavPlayer.cs:94` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) Lfz.Core/Security/Cryptography/RSACryption.cs:181— Lfz.Core/Security/Cryptography/RSACryption.cs:181-192 | Lfz.Core/Security/Cryptography/RSACryption.cs:222-233 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Security/Cryptography/RSACryption.cs:222` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (9 lines × 2) Lfz.Core/Security/Cryptography/RSACryption.cs:221— Lfz.Core/Security/Cryptography/RSACryption.cs:221-229 | Lfz.Core/Security/Cryptography/RSACryption.cs:242-250 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Lfz.Core/Security/Cryptography/RSACryption.cs:252` calls `ToBase64String` and `Lfz.Core/Security/Cryptography/RSACryption.cs:231` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9 lines × 2) Lfz.Core/Data/DbHelperMySQL.cs:183— Lfz.Core/Data/DbHelperMySQL.cs:183-191 | Lfz.Core/Data/DbHelperMySQL.cs:214-222 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Data/DbHelperMySQL.cs:183` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) Lfz.Core/Network/HttpListenServiceBase.cs:135— Lfz.Core/Network/HttpListenServiceBase.cs:135-143 | Lfz.Core/Network/TcpListenServiceBase.cs:118-126 — before extracting anything, compare `Lfz.Core/Network/HttpListenServiceBase.cs` and `Lfz.Core/Network/TcpListenServiceBase.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9 lines × 2) Lfz.Core/Utitlies/Utils.PropertyAssignment.cs:125— Lfz.Core/Utitlies/Utils.PropertyAssignment.cs:125-133 | Lfz.Core/Utitlies/Utils.PropertyAssignment.cs:160-168 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Utitlies/Utils.PropertyAssignment.cs:125` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) Lfz.Core/Security/Cryptography/RSACryption.cs:285— Lfz.Core/Security/Cryptography/RSACryption.cs:285-294 | Lfz.Core/Security/Cryptography/RSACryption.cs:336-344 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Lfz.Core/Security/Cryptography/RSACryption.cs:346` calls `FromBase64String` and `Lfz.Core/Security/Cryptography/RSACryption.cs:296` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (18 lines × 2) Lfz.Core/Data/DbHelperMySQL.cs:188— Lfz.Core/Data/DbHelperMySQL.cs:188-205 | Lfz.Core/Data/DbHelperMySQL.cs:257-274 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Data/DbHelperMySQL.cs:188` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 2) Lfz.Core/Data/DbHelperMySQL.cs:43— Lfz.Core/Data/DbHelperMySQL.cs:43-60 | Lfz.Core/Data/DbHelperMySQL.cs:70-87 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Data/DbHelperMySQL.cs:43` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 2) Lfz.Core/Data/DbHelperMySQL.cs:291— Lfz.Core/Data/DbHelperMySQL.cs:291-308 | Lfz.Core/Data/DbHelperMySQL.cs:319-336 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Data/DbHelperMySQL.cs:291` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 2) REDACTED:330— REDACTED:330-347 | REDACTED:358-375 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:330` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) Lfz.Core/Redis/RedisBase.cs:404— Lfz.Core/Redis/RedisBase.cs:404-410 | Lfz.Core/Redis/RedisBase.cs:428-434 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Redis/RedisBase.cs:404` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) Lfz.Core/Security/Cryptography/StringDECHelper.cs:112— Lfz.Core/Security/Cryptography/StringDECHelper.cs:112-118 | Lfz.Core/Security/Cryptography/StringDECHelper.cs:153-159 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) Lfz.Core/Security/Cryptography/StringDECHelper.cs:191— Lfz.Core/Security/Cryptography/StringDECHelper.cs:191-197 | Lfz.Core/Utitlies/Utils.cs:1002-1008 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Utitlies/Utils.cs:1002` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Lfz.Core/Utitlies/Utils.cs:1001` calls `IsNullOrEmpty` and `Lfz.Core/Security/Cryptography/StringDECHelper.cs:190` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) Lfz.Core/Utitlies/Utils.partial.cs:166— Lfz.Core/Utitlies/Utils.partial.cs:166-172 | Lfz.Core/Utitlies/Utils.partial.cs:193-200 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Utitlies/Utils.partial.cs:166` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Lfz.Core/Utitlies/Utils.partial.cs:192` calls `ToString`, `TryParse` and `Lfz.Core/Utitlies/Utils.partial.cs:166` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
TooManyMethods: Utils Lfz.Core/Utitlies/Utils.cs— TooManyMethods — 1015 significant lines (blank, comment-only and punctuation-only lines excluded), 94 methods, declared across 5 files: Utitlies/Utils.cs (51), Utitlies/Utils.partial.cs (31), Utitlies/Utils.WinForm.cs (7), Utitlies/Utils.PropertyAssignment.cs (4), +1 more file(s). The bar is 30 methods; this is 64 over it, 3.13× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
TooManyMethods: TypeParse REDACTED— TooManyMethods — 326 significant lines (blank, comment-only and punctuation-only lines excluded), 82 methods. The bar is 30 methods; this is 52 over it, 2.73× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
TooManyMethods: RedisBase Lfz.Core/Redis/RedisBase.cs— TooManyMethods — 418 significant lines (blank, comment-only and punctuation-only lines excluded), 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
Duplicated block (17 lines × 2) Lfz.Core/Security/Cryptography/StringDECHelper.cs:121— Lfz.Core/Security/Cryptography/StringDECHelper.cs:121-137 | Lfz.Core/Security/Cryptography/StringDECHelper.cs:162-178 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Security/Cryptography/StringDECHelper.cs:121` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) Lfz.Core/Network/HttpListenServiceBase.cs:183— Lfz.Core/Network/HttpListenServiceBase.cs:183-199 | Lfz.Core/Network/TcpListenServiceBase.cs:190-206 — before extracting anything, compare `Lfz.Core/Network/HttpListenServiceBase.cs` and `Lfz.Core/Network/TcpListenServiceBase.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (17 lines × 2) Lfz.Core/Security/Cryptography/RSACryption.cs:264— Lfz.Core/Security/Cryptography/RSACryption.cs:264-280 | Lfz.Core/Security/Cryptography/RSACryption.cs:289-305 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Security/Cryptography/RSACryption.cs:289` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) Lfz.Core/Data/DbHelperMySQL.cs:218— Lfz.Core/Data/DbHelperMySQL.cs:218-232 | REDACTED:258-272 — before extracting anything, compare `Lfz.Core/Data/DbHelperMySQL.cs` and `REDACTED` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (15 lines × 2) Lfz.Core/Security/Cryptography/StringDECHelper.cs:42— Lfz.Core/Security/Cryptography/StringDECHelper.cs:42-56 | Lfz.Core/Security/Cryptography/StringDECHelper.cs:78-92 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (15 lines × 2) REDACTED:329— REDACTED:329-343 | REDACTED:344-358 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13 lines × 2) Lfz.Core/Data/DbHelperMySQL.cs:288— Lfz.Core/Data/DbHelperMySQL.cs:288-300 | REDACTED:327-339 — before extracting anything, compare `Lfz.Core/Data/DbHelperMySQL.cs` and `REDACTED` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (13 lines × 2) Lfz.Core/Redis/RedisBase.cs:859— Lfz.Core/Redis/RedisBase.cs:859-871 | Lfz.Core/Redis/RedisBase.cs:887-899 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Redis/RedisBase.cs:859` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 2) Lfz.Core/Utitlies/Utils.cs:915— Lfz.Core/Utitlies/Utils.cs:915-927 | REDACTED:276-288 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
TodoComment Lfz.Core/Data/Nh/SessionFactoryHolder.cs:120— //TODO 缓存配置实现 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment Lfz.Core/Network/HttpListenServiceBase.cs:379— //TODO ReceviceCompleted��Ҫ����ʵ�� — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×2
Members sharing a duplicated core (4 members, 50+ identical tokens) Lfz.Core/Security/Cryptography/RSACryption.cs:179— Lfz.Core/Security/Cryptography/RSACryption.cs:179-192 | Lfz.Core/Security/Cryptography/RSACryption.cs:196-213 | Lfz.Core/Security/Cryptography/RSACryption.cs:217-233 | Lfz.Core/Security/Cryptography/RSACryption.cs:237-256 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) Lfz.Core/Security/Cryptography/RSACryption.cs:262— Lfz.Core/Security/Cryptography/RSACryption.cs:262-280 | Lfz.Core/Security/Cryptography/RSACryption.cs:283-305 | Lfz.Core/Security/Cryptography/RSACryption.cs:308-330 | Lfz.Core/Security/Cryptography/RSACryption.cs:333-357 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Duplicated block (12 lines × 3) Lfz.Core/Data/DbHelperMySQL.cs:223— Lfz.Core/Data/DbHelperMySQL.cs:223-234 | Lfz.Core/Data/DbHelperMySQL.cs:291-302 | Lfz.Core/Data/DbHelperMySQL.cs:319-330 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Data/DbHelperMySQL.cs:223` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Lfz.Core/Data/DbHelperMySQL.cs:303` calls `Close` and `Lfz.Core/Data/DbHelperMySQL.cs:235` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12 lines × 3) REDACTED:263— REDACTED:263-274 | REDACTED:330-341 | REDACTED:358-369 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:263` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `REDACTED:342` calls `Close` and `REDACTED:275` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Unfinished stub — throws NotImplementedException Lfz.Core/Data/Nh/Providers/AbstractDataServicesProvider.cs:99— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException Lfz.Core/Data/Nh/Providers/AbstractDataServicesProvider.cs:104— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
S1 · Cryptographic Hygiene· The encryption IV is the same for every message · ×2
The encryption IV is the same for every message Lfz.Core/Security/Cryptography/DESHelper.cs:29— This encryption's initialisation vector is a compile-time constant, so every message encrypted under the same key gets the same IV. An IV is not a secret and does not have to be one — its whole job is to be DIFFERENT each time, so that encrypting the same plaintext twice does not produce the same ciphertext. Fix it and CBC becomes an equality oracle: the mode XORs the IV into the first plaintext block and chains from there, so two messages encrypted with the same key and IV produce byte-identical ciphertext for exactly as long as their plaintexts agree. An observer who can see two ciphertexts — a repository of encrypted config files, a database column, a backup — learns that two records match and how many blocks in they diverge, without the key and without breaking anything. The same defect under a counter-based mode is worse and not recoverable by comparison: CTR and GCM XOR the plaintext against a keystream determined by the key and nonce, so a repeated nonce leaks the XOR of the two plaintexts outright, and under GCM it also forfeits the authentication key. Generate the IV with a cryptographic RNG for each message — `RandomNumberGenerator.Fill(iv)` in .NET, `crypto.randomBytes(16)` in Node — and write it alongside the ciphertext (prepending the block is the usual spelling); the receiver reads it back from there. Deriving the IV from the key material is the specific trap to avoid: it looks like rigour and produces a constant, because the derivation's inputs do not change between messages.
The encryption IV is the same for every message Lfz.Core/Security/Cryptography/StringDECHelper.cs:18— This encryption's initialisation vector is a compile-time constant, so every message encrypted under the same key gets the same IV. An IV is not a secret and does not have to be one — its whole job is to be DIFFERENT each time, so that encrypting the same plaintext twice does not produce the same ciphertext. Fix it and CBC becomes an equality oracle: the mode XORs the IV into the first plaintext block and chains from there, so two messages encrypted with the same key and IV produce byte-identical ciphertext for exactly as long as their plaintexts agree. An observer who can see two ciphertexts — a repository of encrypted config files, a database column, a backup — learns that two records match and how many blocks in they diverge, without the key and without breaking anything. The same defect under a counter-based mode is worse and not recoverable by comparison: CTR and GCM XOR the plaintext against a keystream determined by the key and nonce, so a repeated nonce leaks the XOR of the two plaintexts outright, and under GCM it also forfeits the authentication key. Generate the IV with a cryptographic RNG for each message — `RandomNumberGenerator.Fill(iv)` in .NET, `crypto.randomBytes(16)` in Node — and write it alongside the ciphertext (prepending the block is the usual spelling); the receiver reads it back from there. Deriving the IV from the key material is the specific trap to avoid: it looks like rigour and produces a constant, because the derivation's inputs do not change between messages.
AppUnitity.KillProcess (cyclomatic 29) Lfz.Core/Utitlies/AppUnitity.cs:159— AppUnitity.KillProcess has cyclomatic complexity 29 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
Utils.GetDiffValue (cyclomatic 29) Lfz.Core/Utitlies/Utils.PropertyAssignment.cs:25— Utils.GetDiffValue has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DatabaseInitialise.GetDataType (cyclomatic 28) REDACTED:451— DatabaseInitialise.GetDataType has cyclomatic complexity 28 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
RawSqlSearchService.Format (cyclomatic 27) Lfz.Core/Data/RawSql/RawSqlSearchService.cs:301— RawSqlSearchService.Format has cyclomatic complexity 27 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DigitToMoneyText.ConvertIntegral (cyclomatic 26) Lfz.Core/Utitlies/DigitToMoneyText.cs:271— DigitToMoneyText.ConvertIntegral has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Utils.TableConvertToList (cyclomatic 26) Lfz.Core/Utitlies/Utils.partial.cs:436— Utils.TableConvertToList has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Utils.SetValue (cyclomatic 24) Lfz.Core/Utitlies/Utils.PropertyAssignment.cs:192— Utils.SetValue has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
WebHelper.ModifyQueryString (cyclomatic 20) REDACTED:297— WebHelper.ModifyQueryString has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DigitToMoneyText.ConvertNumber (cyclomatic 18) Lfz.Core/Utitlies/DigitToMoneyText.cs:92— DigitToMoneyText.ConvertNumber has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BusinessService.BuildUpdateSql (cyclomatic 17) Lfz.Core/Data/RawSql/BusinessService.cs:114— BusinessService.BuildUpdateSql has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DatabaseInitialise.AddOrAlterColumn (cyclomatic 17) REDACTED:199— DatabaseInitialise.AddOrAlterColumn has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ExportEngine.ExportToBytes (cyclomatic 17) Lfz.Core/Utitlies/ExportEngine.cs:225— ExportEngine.ExportToBytes has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (ExportEngine.ExportToExcel) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ExportEngine.ExportToExcel (cyclomatic 17) Lfz.Core/Utitlies/ExportEngine.cs:406— ExportEngine.ExportToExcel has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (ExportEngine.ExportToBytes) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
Utils.GetCompareValue (cyclomatic 17) Lfz.Core/Utitlies/Utils.PropertyAssignment.cs:152— Utils.GetCompareValue has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Build failed — The target solution did not build cleanly (errors: 6), which caps Solution Shape at 3/10 — the most basic shape signal is that it compiles. First errors: CS1056: Unexpected character '�'; CS1001: Identifier expected.
Utils.TableConvertToList (cognitive 67) Lfz.Core/Utitlies/Utils.partial.cs:436— Utils.TableConvertToList has cognitive complexity 67 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Utils.GetDiffValue (cognitive 50) Lfz.Core/Utitlies/Utils.PropertyAssignment.cs:25— Utils.GetDiffValue has cognitive complexity 50 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
WebHelper.ModifyQueryString (cognitive 47) REDACTED:297— WebHelper.ModifyQueryString has cognitive complexity 47 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
Utils.SetValue (cognitive 46) Lfz.Core/Utitlies/Utils.PropertyAssignment.cs:192— Utils.SetValue has cognitive complexity 46 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DigitToMoneyText.ConvertNumber (cognitive 45) Lfz.Core/Utitlies/DigitToMoneyText.cs:92— DigitToMoneyText.ConvertNumber has cognitive complexity 45 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DigitToMoneyText.ConvertIntegral (cognitive 39) Lfz.Core/Utitlies/DigitToMoneyText.cs:271— DigitToMoneyText.ConvertIntegral has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Utils.GetSubString (cognitive 33) Lfz.Core/Utitlies/Utils.cs:727— Utils.GetSubString has cognitive complexity 33 (threshold 15). Of this number, 30 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
RawSqlSearchService.Format (cognitive 30) Lfz.Core/Data/RawSql/RawSqlSearchService.cs:301— RawSqlSearchService.Format has cognitive complexity 30 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
WebHelper.RemoveQueryString (cognitive 30) REDACTED:393— WebHelper.RemoveQueryString has cognitive complexity 30 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
BusinessService.BuildUpdateSql (cognitive 27) Lfz.Core/Data/RawSql/BusinessService.cs:114— BusinessService.BuildUpdateSql has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RawSqlSearchService.GetDictionary (cognitive 25) Lfz.Core/Data/RawSql/RawSqlSearchService.cs:361— RawSqlSearchService.GetDictionary has cognitive complexity 25 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
Utils.GetCompareValue (cognitive 25) Lfz.Core/Utitlies/Utils.PropertyAssignment.cs:152— Utils.GetCompareValue has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DatabaseInitialise.CreateTable (cognitive 24) REDACTED:125— DatabaseInitialise.CreateTable has cognitive complexity 24 (threshold 15). Of this number, 23 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DbHelperMySql.ExecuteSqlTran (cognitive 23) Lfz.Core/Data/DbHelperMySQL.cs:479— DbHelperMySql.ExecuteSqlTran has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HttpListenServiceBase.ProcessReceive (cognitive 23) Lfz.Core/Network/HttpListenServiceBase.cs:276— HttpListenServiceBase.ProcessReceive has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PropertyConvertion.Apply (cognitive 22) Lfz.Core/Data/Nh/Conventions/RecordTableNameConvention.cs:82— PropertyConvertion.Apply has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BusinessService.CreateOrUpdate (cognitive 22) Lfz.Core/Data/RawSql/BusinessService.cs:236— BusinessService.CreateOrUpdate has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DatabaseInitialise.AddOrAlterColumn (cognitive 22) REDACTED:199— DatabaseInitialise.AddOrAlterColumn has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HttpListenContext.HttpListenContext.ctor (cognitive 22) Lfz.Core/Network/HttpListenContext.cs:32— HttpListenContext.HttpListenContext.ctor has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExportEngine.ExportToBytes (cognitive 21) Lfz.Core/Utitlies/ExportEngine.cs:225— ExportEngine.ExportToBytes has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ExportEngine.ExportToExcel) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ExportEngine.ExportToExcel (cognitive 21) Lfz.Core/Utitlies/ExportEngine.cs:406— ExportEngine.ExportToExcel has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ExportEngine.ExportToBytes) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
Utils.GetDiffValue (cognitive 20) Lfz.Core/Utitlies/Utils.PropertyAssignment.cs:120— Utils.GetDiffValue has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Utils.UpdatePropertiesValue (cognitive 19) Lfz.Core/Utitlies/Utils.partial.cs:317— Utils.UpdatePropertiesValue has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RawSqlSearchService.GetPaged (cognitive 18) Lfz.Core/Data/RawSql/RawSqlSearchService.cs:38— RawSqlSearchService.GetPaged has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActiveMQPoolConnectionManager.GetPoolConnection (cognitive 17) Lfz.Core/Mq/ActiveMQ/ActiveMQPoolConnectionManager.cs:42— ActiveMQPoolConnectionManager.GetPoolConnection has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Utils.InIPArray (cognitive 17) Lfz.Core/Utitlies/Utils.cs:386— Utils.InIPArray has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Utils.GetSpell (cognitive 17) Lfz.Core/Utitlies/Utils.cs:1103— Utils.GetSpell has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UrlOper.GetDomain (cognitive 16) Lfz.Core/Utitlies/UrlOper.cs:117— UrlOper.GetDomain has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Utils.GetUnicodeSubString (cognitive 16) Lfz.Core/Utitlies/Utils.cs:685— Utils.GetUnicodeSubString has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FileTooLong: Utitlies/Utils.cs Lfz.Core/Utitlies/Utils.cs— FileTooLong — 546 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 46 over it, 1.09× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D4 · Code Duplication· Members sharing a duplicated core (8 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (8 members, 50+ identical tokens) Lfz.Core/Data/DbHelperMySQL.cs:182— Lfz.Core/Data/DbHelperMySQL.cs:182-205 | Lfz.Core/Data/DbHelperMySQL.cs:213-243 | Lfz.Core/Data/DbHelperMySQL.cs:251-274 | Lfz.Core/Data/DbHelperMySQL.cs:283-308 | Lfz.Core/Data/DbHelperMySQL.cs:310-336 | REDACTED:253-283 | REDACTED:322-347 | REDACTED:349-375 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
Duplicated block (39 lines × 2) Lfz.Core/Utitlies/ExportEngine.cs:238— Lfz.Core/Utitlies/ExportEngine.cs:238-276 | Lfz.Core/Utitlies/ExportEngine.cs:430-468 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Utitlies/ExportEngine.cs:238` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (35–38 lines × 2) Lfz.Core/Data/IRepository.cs:92— Lfz.Core/Data/IRepository.cs:92-126 | Lfz.Core/Data/Nh/INhRepository.cs:79-116 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (28 lines × 2) Lfz.Core/Data/DbHelperMySQL.cs:565— Lfz.Core/Data/DbHelperMySQL.cs:565-592 | Lfz.Core/Data/DbHelperMySQL.cs:613-640 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Data/DbHelperMySQL.cs:565` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (27–28 lines × 2) Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:33— Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:33-59 | Lfz.Core/Security/Cryptography/FileCryptoHelper.cs:69-96 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (20–21 lines × 2) Lfz.Core/Security/Cryptography/RSACryption.cs:310— Lfz.Core/Security/Cryptography/RSACryption.cs:310-330 | Lfz.Core/Security/Cryptography/RSACryption.cs:338-357 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Security/Cryptography/RSACryption.cs:338` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Lfz.Core/Security/Cryptography/RSACryption.cs:338` calls `FromBase64String` and `Lfz.Core/Security/Cryptography/RSACryption.cs:310` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (15 lines × 3) Lfz.Core/Data/RawSql/BusinessService.cs:238— Lfz.Core/Data/RawSql/BusinessService.cs:238-252 | Lfz.Core/Data/RawSql/BusinessService.cs:305-319 | Lfz.Core/Data/RawSql/BusinessService.cs:348-362 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Lfz.Core/Data/RawSql/BusinessService.cs:253` calls `Exists` and `Lfz.Core/Data/RawSql/BusinessService.cs:364` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7–12 lines × 2) Lfz.Core/Data/RawSql/RawSqlSearchService.cs:84— Lfz.Core/Data/RawSql/RawSqlSearchService.cs:84-95 | Lfz.Core/Data/RawSqlRepository.cs:125-131 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 2) REDACTED:137— REDACTED:137-146 | REDACTED:204-213 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 3) Lfz.Core/Security/Cryptography/RSACryption.cs:198— Lfz.Core/Security/Cryptography/RSACryption.cs:198-207 | Lfz.Core/Security/Cryptography/RSACryption.cs:221-229 | Lfz.Core/Security/Cryptography/RSACryption.cs:242-250 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Lfz.Core/Security/Cryptography/RSACryption.cs:242` calls `FromBase64String` and `Lfz.Core/Security/Cryptography/RSACryption.cs:198` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 2) Lfz.Core/Utitlies/Utils.partial.cs:285— Lfz.Core/Utitlies/Utils.partial.cs:285-292 | Lfz.Core/Utitlies/Utils.partial.cs:321-328 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Lfz.Core/Utitlies/Utils.partial.cs:285` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 4) Lfz.Core/Security/Cryptography/RSACryption.cs:181— Lfz.Core/Security/Cryptography/RSACryption.cs:181-188 | Lfz.Core/Security/Cryptography/RSACryption.cs:200-207 | Lfz.Core/Security/Cryptography/RSACryption.cs:222-229 | Lfz.Core/Security/Cryptography/RSACryption.cs:243-250 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Lfz.Core/Security/Cryptography/RSACryption.cs:209` calls `ToBase64String` and `Lfz.Core/Security/Cryptography/RSACryption.cs:190` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 2) Lfz.Core/Collections/PageOfDatatable.cs:95— Lfz.Core/Collections/PageOfDatatable.cs:95-100 | Lfz.Core/Collections/PageOfItems.cs:111-116 — before extracting anything, compare `Lfz.Core/Collections/PageOfDatatable.cs` and `Lfz.Core/Collections/PageOfItems.cs` as WHOLE FILES: 82% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) Lfz.Core/Utitlies/Utils.cs:90— Lfz.Core/Utitlies/Utils.cs:90-94 | Lfz.Core/Utitlies/Utils.cs:96-100 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Coverage not measured — no coverage collector is wired up — Coverage NOT MEASURED: `--collect:"XPlat Code Coverage"` names a data collector that ships in the `coverlet.collector` package, and this repository wires up none — no test project references it and no runsettings declares one. The absence of coverage here is therefore not evidence about the suite or about our analyzer environment: without a collector, `--collect` produces nothing even from a suite that builds and passes. Add a `coverlet.collector` PackageReference to the test project(s) (or commit the Cobertura/OpenCover/lcov report your CI produces) and real coverage will be measured. It is excluded from the score rather than counted as a near-zero defect.
IC1 · Incompleteness & stubs· Empty method body · ×1
Empty method body — does nothing with its inputs Lfz.Core/Data/Repository.cs:368— `FillEntity` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
Commented-out code Lfz.Core/Data/DbHelperMySQL.cs:696— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/DbHelperMySQL.cs:697— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code REDACTED:121— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code REDACTED:537— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code REDACTED:538— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/Nh/Providers/AbstractDataServicesProvider.cs:133— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/Nh/Providers/AbstractDataServicesProvider.partial.cs:25— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/Nh/Providers/SqlCeDataServicesProvider.cs:55— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/Nh/Providers/SqlCeDataServicesProvider.cs:56— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/Nh/Providers/SqlCeDataServicesProvider.cs:63— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/Nh/Providers/SqlCeDataServicesProvider.cs:66— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/Nh/Providers/SqlCeDataServicesProvider.cs:69— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/RawSql/RawSqlSearchService.cs:342— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/RawSqlRepository.cs:137— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/RawSqlRepository.cs:140— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/RawSqlRepository.cs:141— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/RawSqlRepository.cs:143— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/RawSqlRepository.cs:145— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/Repository.cs:254— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/Repository.cs:265— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/Repository.cs:276— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/Schema/StringLengthAttribute.cs:21— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/Schema/StringLengthAttribute.cs:40— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Data/Schema/StringLengthAttribute.cs:45— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code Lfz.Core/Draw/LineEquation.cs:106— 3 consecutive lines of code sit inside a `/* … */` block — a block of code switched off rather than removed, which rots and confuses. Delete it (version control remembers).
Fat interface: IWebHelper (18 members) Lfz.Core/IWebHelper.cs:8— `IWebHelper` declares 18 members: `GetUrlReferrer`, `UrlEncode`, `GetCurrentIpAddress`, `GetThisPageUrl`, `GetThisPageUrl`, `IsCurrentConnectionSecured`, `ServerVariables`, `GetStoreHost`, `GetStoreLocation`, `GetStoreLocation`, `IsStaticResource`, `MapPath`, `ModifyQueryString`, `RemoveQueryString`, `QueryString`, `RestartAppDomain`, `IsRequestBeingRedirected`, `GetParamValueByName`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 18 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IRawSqlRepository<T> (21 members) Lfz.Core/Data/IRawSqlRepository.cs:13— `IRawSqlRepository<T>` declares 21 members under just 15 distinct name(s): `GetFirstOrDefault`, `Logger`, `FormatModel`, `FormatModel`, `GetPaged`, `GetModel`, `GetList`, `Count`, `Exists`, `Exists`, `Create`, `Create`, `Update`, `Update`, `Update`, `Delete`, `Delete`, `DeleteByField`, `ExecuteScalar`, `Execute`, `ExecuteDataSet`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 21 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 21 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IRepository<T> (18 members) Lfz.Core/Data/IRepository.cs:14— `IRepository<T>` declares 18 members under just 14 distinct name(s): `CurrentDbContext`, `Commit`, `Create`, `Update`, `CreateOrUpdate`, `Delete`, `Delete`, `Get`, `Get`, `GetAll`, `Table`, `Count`, `Exists`, `Fetch`, `Fetch`, `Fetch`, `GetPaged`, `ExecuteSql`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 18 separate responsibilities: a caller binds to 14 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 18 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: INhRepository<T> (16 members) Lfz.Core/Data/Nh/INhRepository.cs:10— `INhRepository<T>` declares 16 members under just 12 distinct name(s): `Create`, `Update`, `Delete`, `Delete`, `Copy`, `Flush`, `Get`, `Get`, `Table`, `GetNamedQuery`, `Count`, `Fetch`, `Fetch`, `Fetch`, `GetPaged`, `Exists`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 12 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IBusinessService<TElement> (22 members) Lfz.Core/Data/RawSql/IBusinessService.cs:11— `IBusinessService<TElement>` declares 22 members: `PrimaryKey`, `SearchService`, `TableName`, `BuildCreateSql`, `BuildUpdateSql`, `GetByKey`, `Delete`, `Get`, `Delete`, `Get`, `Get`, `DeleteByKey`, `Exists`, `ExcuteSql`, `CreateOrUpdate`, `Create`, `Update`, `GetList`, `ToDictionary`, `GetPaged`, `Format`, `GetDictionary`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 22 declarations carry 19 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 19 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IRawSqlSearchService (19 members) Lfz.Core/Data/RawSql/IRawSqlSearchService.cs:25— `IRawSqlSearchService` declares 19 members: `GetPropertyInfos`, `DbProviderConfig`, `GetPaged`, `GetByKey`, `GetModel`, `GetModel`, `Delete`, `DeleteByKey`, `GetList`, `GetListWithSingleValue`, `GetSingleObject`, `GetSingle`, `Count`, `Exists`, `ExcuteSql`, `Query`, `QueryTable`, `Format`, `GetDictionary`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 19 declarations carry 18 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 18 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Interpolated log message defeats structured logging Lfz.Core/Rest/HttpContextExtension.cs:26— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging Lfz.Core/Network/UdpSyncListenReceviceService.cs:127— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging Lfz.Core/Network/UdpSyncListenReceviceService.cs:146— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging Lfz.Core/Network/TcpClientService.cs:104— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging Lfz.Core/Network/TcpClientService.cs:158— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Duplicated predicate Lfz.Core/Data/DbHelperMySQL.cs:44— `(Object.Equals(obj, null)) || (Object.Equals(obj, System.DBNull.Value))` appears character-identically in 2 files — Lfz.Core/Data/DbHelperMySQL.cs, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate Lfz.Core/Data/DbHelperMySQL.cs:746— `(parameter.Direction == ParameterDirection.InputOutput || parameter.Direction == ParameterDirection.Input) && (parameter.Value == null)` appears character-identically in 2 files — Lfz.Core/Data/DbHelperMySQL.cs, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate Lfz.Core/Network/UdpSyncListenReceviceService.cs:162— `e.BytesTransferred > 0 && e.SocketError == SocketError.Success` appears character-identically in 2 files — Lfz.Core/Network/TcpListenServiceBase.cs, Lfz.Core/Network/UdpSyncListenReceviceService.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate Lfz.Core/Data/RawSql/RawSqlSearchService.cs:89— `reader.Tables.Count >= 2 && reader.Tables[1].Rows.Count > 0` appears character-identically in 2 files — Lfz.Core/Data/RawSql/RawSqlSearchService.cs, Lfz.Core/Data/RawSqlRepository.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
No direct assertions: TestMethod1 Lfz.Core.Tests/UnitTest1.cs:14— No conventional assertion call was detected, and 3 of 4 tests in `Lfz.Core.Tests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
No direct assertions: RunconfigTest Lfz.Core.Tests/UnitTest1.cs:27— No conventional assertion call was detected, and 3 of 4 tests in `Lfz.Core.Tests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
No direct assertions: TestHelperInitConfig Lfz.Core.Tests/UnitTest1.cs:39— No conventional assertion call was detected, and 3 of 4 tests in `Lfz.Core.Tests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
Documentation: no project overview README.md— The opening paragraph states 'C# 工具箱，提供Socket（TCP、UDP协议）、Redis、activemq、数据库访问等技术的封装实现' but does not explain what the project is or how to use it as a whole. Add an overview section stating the tools directory's purpose and where each subdirectory lives (e.g. 'The repository houses a C# utility box covering network, database, messaging, and IO components.')
Documentation: no installation or build instructions README.md— No installation/build/usage instructions for the tools. Add an install section describing how to add the project as a NuGet package or import it directly.
Documentation: no usage examples README.md— Usage examples are absent and the document does not show commands typed in a shell block. Provide usage snippets for each subdirectory (e.g. 'How to create a Redis cache or start an ActiveMQ broker').
misleading comment REDACTED:153— "put this method is try-catch as described here http://www.nopcommerce.com/boards/t/21356/multi-store-roadmap-lets-discuss-update-done.aspx?p=6#90196" — Link to the actual code path; the comment points at a board thread and an unrelated method.
misleading comment REDACTED:278— "hosted" — Remove - MapPath returns HostingEnvironment.MapPath, not 'hosted' or any string.
redundant comment REDACTED:479— "medium trust" — Delete - TryWriteWebConfig() is a call site; the medium-trust rationale is already in the comment line.
redundant comment REDACTED:506— "endResponse" — Remove - Redirect with endResponse is obvious from the flag, not documented WHY it's set to true.
C2 · Access Controls· No named authorization policies · ×1
No named authorization policies — Authorization IS enforced here (by an auth-gate middleware that short-circuits unauthorized requests) — this is NOT a claim that the code is unprotected. What's missing is a NAMED rule set: the middleware encodes the access rules inline, so the rules can't be listed, reviewed or tested apart from the middleware body that applies them. Recommendation, not a defect.
D21 · Naming Consistency· The namespace 'Lfz.Utitlies' contains a typo ('Utitlies' instead of 'Utilities'). Furthermore, the types within this namespace have inconsistent naming conventions · ×1
The namespace 'Lfz.Utitlies' contains a typo ('Utitlies' instead of 'Utilities'). Furthermore, the types within this namespace have inconsistent naming conventions: some are plural nouns (Utils, Options), some are singular nouns (TypeParse, ExportEngine), and some are descriptive phrases (DigitToMoneyText, AppUnitity). 'AppUnitity' also appears to be a typo for 'AppUtility' or 'AppUnit'. — Fix the namespace typo to 'Lfz.Utilities'. Standardize type names within the namespace to follow a consistent pattern (e.g., all singular nouns like 'TypeParser', 'Exporter', 'OptionsManager'). Fix 'AppUnitity' to 'AppUtility' or similar. (symbols: Type: public Lfz.Utitlies.TypeParse, Type: public Lfz.Utitlies.Utils, Type: public Lfz.Utitlies.NetMailUtils, Type: public Lfz.Utitlies.ExportEngine<T>, Type: public Lfz.Utitlies.DigitToMoneyText, Type: public Lfz.Utitlies.Options, Type: public Lfz.Utitlies.UrlOper, Type: public Lfz.Utitlies.AppUnitity)
D21 · Naming Consistency· Inconsistent spelling of 'Serializer'. The field 'serializater' uses the incorrect 'z' spelling, while other parts of the codebase (e.g., 'XmlSerializer' in System namespace) use the correct 's'. Additionally, the field name 'serializater' is a typo for 'serializer'. · ×1
Inconsistent spelling of 'Serializer'. The field 'serializater' uses the incorrect 'z' spelling, while other parts of the codebase (e.g., 'XmlSerializer' in System namespace) use the correct 's'. Additionally, the field name 'serializater' is a typo for 'serializer'. — Rename the field to 'serializer' and ensure the type name is 'ICacheSerializer' (if custom) or use the standard 'ISerializer'. (symbols: Field: private ICacheSerializater Lfz.Config.JsonConfigHelper.serializater, Method: public string Lfz.Utitlies.Utils.GetCustomDescription<T>())
D21 · Naming Consistency· Typo in method name 'GetDiffMoneths'. 'Moneths' is a misspelling of 'Months'. · ×1
Typo in method name 'GetDiffMoneths'. 'Moneths' is a misspelling of 'Months'. — Rename to 'GetDiffMonths'. (symbols: Method: public int Lfz.Utitlies.TypeParse.GetDiffMoneths(System.DateTime, System.DateTime), Method: public DateTime Lfz.Utitlies.TypeParse.GetBeginningWeek(System.DateTime, int))
D21 · Naming Consistency· Inconsistent spelling of 'Convention'. The type 'ReferenceConvention' uses the correct spelling, but the class 'PropertyConvertion' (likely intended to be 'PropertyConvention' or 'PropertyConverter') uses 'Convertion' which is a typo for 'Conversion' or 'Converter'. If it is a convention, it should be 'PropertyConvention'. · ×1
Inconsistent spelling of 'Convention'. The type 'ReferenceConvention' uses the correct spelling, but the class 'PropertyConvertion' (likely intended to be 'PropertyConvention' or 'PropertyConverter') uses 'Convertion' which is a typo for 'Conversion' or 'Converter'. If it is a convention, it should be 'PropertyConvention'. — Rename 'PropertyConvertion' to 'PropertyConvention' (if it implements a convention) or 'PropertyConverter' (if it converts properties). (symbols: Field: private IDbProviderConfig Lfz.Data.Nh.Conventions.PropertyConvertion._config, Type: public Lfz.Data.Nh.Conventions.ReferenceConvention)
D21 · Naming Consistency· Typo in class name 'ConsoleLoger'. It should be 'ConsoleLogger'. · ×1
Typo in class name 'ConsoleLoger'. It should be 'ConsoleLogger'. — Rename 'ConsoleLoger' to 'ConsoleLogger'. (symbols: Method: public void Lfz.Logging.ConsoleLoger.Log(Lfz.Logging.LogLevel, string, System.Exception), Method: public void Lfz.Logging.ILogger.Log(Lfz.Logging.LogLevel, string, System.Exception))
D21 · Naming Consistency· Inconsistent capitalization of 'Password'. 'MailServerPassWord' uses camelCase for the second word ('Word'), while standard C# property naming conventions typically use PascalCase for public properties ('MailServerPassword'). 'KEY_64' is a constant, so its naming is acceptable, but the inconsistency in 'PassWord' vs standard 'Password' is notable. · ×1
Inconsistent capitalization of 'Password'. 'MailServerPassWord' uses camelCase for the second word ('Word'), while standard C# property naming conventions typically use PascalCase for public properties ('MailServerPassword'). 'KEY_64' is a constant, so its naming is acceptable, but the inconsistency in 'PassWord' vs standard 'Password' is notable. — Rename 'MailServerPassWord' to 'MailServerPassword'. (symbols: Property: public string Lfz.Utitlies.NetMailUtils.MailServerPassWord, Field: public string Lfz.Security.Cryptography.StringDECHelper.KEY_64)
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion — 1 of 2 project(s) overshoot their size bounds, lowering Project Cohesion to 0.0/10. The most over is `Lfz.Core.NET4` (24727 LoC, 270 public types across 34 namespaces). Review these for cohesion — draw the boundary inside the assembly first (group each responsibility into its own namespace/folder and keep the cross-boundary members internal), since splitting a published assembly moves types between packages and breaks consumers.
Pass-through layer Lfz.Core/Caching/ICacheSerializater.cs:45— DefaultCacheSerializater: all 3 public methods forward their arguments unchanged to SerializationHelper and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call SerializationHelper directly, or give the layer a job.
D28 · Secrets (history)· Rotate the exposed credentials · ×1
Thin README — The root README is 43 words, against a bar of 120. Of the three newcomer-critical sections this check looks for by heading, it found no a build/run or getting-started section, no a testing section, no an architecture or project-map section. Sections are matched on HEADING text only, so material written under a heading this check does not recognise — or with no heading at all — is not seen and this row may understate what the document covers.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation· No architecture diagram/doc · ×1
No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
No SAST — No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) — this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
nuget: not applicable — nuget: `dotnet list package --vulnerable` could not read this solution's dependency graph — it reported an error for at least one project and returned no package data at all (typically a packages.config / non-PackageReference project, which the command cannot read). An unreadable dependency graph is not a clean one; migrate the project(s) to PackageReference to enable this scan
trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 4 file(s) — `Lfz.Core/Enums/ChoseYesOrNo.cs`, `Lfz.Core/Enums/Hr/HrDepartmentType.cs`, `Lfz.Core/Enums/Hr/HrEnum.cs`, `Lfz.Core/Enums/Sex.cs` — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
provenance: not applicable — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .circleci, .buildkite, .woodpecker, .teamcity, .gitlab-ci.yml, .travis.yml, bitbucket-pipelines.yml, .drone.yml, .cirrus.yml, .woodpecker.yml, appveyor.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, .azuredevops/, Jenkinsfile); there is no build to attest provenance for.
disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
none (no readable dependency manifest): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).
0
—
Run 01a16194-6333-7ac8-b65e-440d0d27b38a · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Appendix C — Personal-data map
Every field, property and record parameter whose name is conventional personal data — 2 field(s) across 1 category, each with an exact repo-relative file:line. This is the data inventory a compliance review starts from — right-to-erasure, retention, minimisation. Detected by NAME, from the C# syntax tree, with a deliberately specific identifier classifier — the same one the C1–C5 compliance cards use to decide whether personal data is present, so CardDefinition or FileName don't trip. Two caveats stated rather than glossed: those cards additionally require corroboration (a persistence/account signal, or two distinct PII categories) that this inventory deliberately does not, so it lists more than they gate on; and D32 Data Compliance shares nothing with it — that dimension is a separate semgrep ruleset for personal data leaking into logs, URLs and browser storage, and a clean D32 result says nothing about this list. Informational — it feeds no score.
Issues: 41 · Warnings: 252 · Recommendations: 79 · Info: 1 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 22-10-2026 @ 03:07 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.