Public report of morganstanley/optimus-cirrus, published 21 October 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Watchdog signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 21 October 2026, 14:03 UTC · Survey ID cd_329c89e288e44d7ab459ba87f3cbb997

morganstanley/optimus-cirrus

Measured 21 October 2026, 13:56 UTC, at code version ed0aab2

Knowledge freshness: not measured

Knowledge freshness is not measured: History too condensed to judge knowledge freshness.

CAI score 50out of 100 Weak
CriticalWeakAdequateStrongExemplary
Up 3 since the last survey

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

Domain Modelling 100 Exemplary Architecture 90 Adequate Performance 82 Strong Security and Compliance 69 Adequate Accessibility 57 Adequate Code Health 56 Adequate Maturity 48 Weak Production Readiness 43 Weak

A very large codebase: 537,190 lines of product code in 1 project, tests not counted · Estimated rebuild effort: about 4.7 person-years · Weakest lens: Production Readiness, 43

Findings by how serious they are

7 critical 2185 serious 113 minor

15 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
21 October 2026, 13:56 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that implements it, and today Watchdog is the only one that does.

The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

63of 67 dimensions measured by tools. The other 4 are advisory notes from an AI model, which explain the code but don't count towards the score.
2293of 2305 findings point to an exact file and line, so you can open each one in the code. The other 12 concern the repository as a whole, such as missing documentation.
67dimensions across 8 lenses, read from 537,190 lines of product code in 1 project.
Chapters

Executive summary

morganstanley/optimus-cirrus scores 50 out of 100 and is rated Weak, while six of its eight lenses score higher still: Domain Modelling at 100, rated Exemplary, Architecture at 90, Security and Compliance at 69, Accessibility at 57 and Code Health at 56, all rated Adequate, and Performance at 82, rated Strong.

The score is lower than those six because the weakest lens counts most, and here that is Production Readiness, which scores 43 and is rated Weak. Its CI/CD gates dimension scores 0 out of 10, and until that reaches 4, Production Readiness can't be rated higher than Adequate. The first actions are to add a CI workflow that builds and runs the test suite on every push/PR and to run what this repository's stack ships: scalafix or scapegoat — or `semgrep --config=auto`, which runs on any language — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing, and if Production Readiness rose to 70, the score would rise from 50 to about 55.

Seven findings are critical: six in Static Analysis (SAST) and one in Page structure.

Watchdog couldn't measure 13 dimensions in this code, among them Code Coverage, Test Reliability and Dependency Hygiene, so they are left out of the score. The product code is 537,190 lines, which would take an estimated 4.7 person-years, around €680,000, to rebuild.

Code Health 56 Adequate, capped by Nullable reference types Architecture 90 Adequate, capped by Project Cohesion Maturity 48 Weak, capped by Architecture documentation Production Readiness 43 Weak, capped by CI/CD gates and Security & performance tooling Security and Compliance 69 Adequate, capped by Static Analysis (SAST) Domain Modelling 100 ★ Exemplary Accessibility 57 Adequate Performance 82 Strong

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Production Readiness 43 · counts for 45%Maturity 48 · counts for 25%Code Health 56 · counts for 14%Accessibility 57 · counts for 8%Security and Compliance 69 · counts for 4%Performance 82 · counts for 2%Architecture 90 · counts for 1%Domain Modelling 100 · counts for 1%

If Production Readiness rose from 43 to 70, the lowest score rated Strong, the score would rise from 50 to about 55.

Code composition: what the lines of code are
Product code 99%Tests 1%
New since the last survey: 11 findings

These 11 critical or serious findings weren't in the previous survey, on 6 October 2026.

  • Web-Security Posture · Weak hash algorithm optimus/platform/projects/core/src/main/scala/msjava/MSUuidGenerator.scala
  • Web-Security Posture · Weak hash algorithm optimus/platform/projects/dal_client/src/main/scala/optimus/session/utils/ClientEnvironment.scala
  • Web-Security Posture · Weak hash algorithm optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala
  • Web-Security Posture · Weak hash algorithm optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala
  • Web-Security Posture · Weak hash algorithm optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMProxyGenerator.scala
  • Web-Security Posture · Weak hash algorithm optimus/platform/projects/utils/src/main/scala/optimus/utils/HashUtil.scala
  • Web-Security Posture · Weak hash algorithm REDACTED
  • Web-Security Posture · Weak hash algorithm REDACTED
  • Web-Security Posture · Weak hash algorithm REDACTED
  • Visual & motion safety · Focus outline removed in CSS without a :focus replacement optimus/platform/projects/core/src/main/resources/css/gridprofiler.css
  • Visual & motion safety · Focus outline removed in CSS without a :focus replacement optimus/buildtool/projects/htmlreport/src/main/resources/org/gradle/reporting/base-style.css

Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 13 findings

These 13 critical or serious findings were in the previous survey, on 6 October 2026, and are gone from this one.

  • Exception handling · Swallowed exception (empty catch) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeUI.scala
  • Exception handling · Swallowed exception (empty catch) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeTimeLineView.scala
  • Exception handling · Swallowed exception (caught, then discarded) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/GraphConsole.scala
  • Exception handling · Swallowed exception (caught, then discarded) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/persistence/protocol/InstanceFactory.scala
  • Exception handling · Swallowed exception (caught, then discarded) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/StagingComponent.scala
  • Exception handling · Swallowed exception (empty catch) optimus/platform/projects/utils/src/main/scala/optimus/platform/IO.scala
  • Exception handling · Swallowed exception (caught, then discarded) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/os/linux/redhat/RedHat.java
  • Exception handling · Swallowed exception (empty catch) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/process/LogOnlyUncaughtExceptionHandler.java
  • Exception handling · Swallowed exception (empty catch) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/process/LogAndExitUncaughtExceptionHandler.java
  • Exception handling · Swallowed exception (caught, then discarded) optimus/silverking/projects/silverking_utils/src/main/java/com/ms/silverking/net/IPAddrUtil.java
  • Exception handling · Swallowed exception (caught, then discarded) optimus/silverking/projects/silverking_utils/src/main/java/com/ms/silverking/os/linux/proc/ProcReader.java
  • Exception handling · Swallowed exception (caught, then discarded) optimus/stratosphere/bootstrap/src/main/java/optimus/stratosphere/bootstrap/config/StratosphereConfig.java
  • Exception handling · Swallowed exception (empty catch) optimus/stratosphere/common/src/main/scala/optimus/stratosphere/utils/ProcessUtils.scala
Rebuild cost: about €680,000 · Estimate
Cost to rebuild€230,000 to €1,100,000, for 3,777 to 11,982 hours of work, about 4.7 person-years for 2 to 9 engineers
Difficulty of the problemHigh, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.7 at a score of 50. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeVery large: 537,190 lines of product code

How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Add a CI workflow that builds and runs the test suite on every push/PR.
Raises the score by about 5 points · Medium effort · CI/CD gates
2
Run what this repository's stack ships: scalafix or scapegoat — or `semgrep --config=auto`, which runs on any language — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.
Raises the score by about 5 points · Medium effort · Security & performance tooling
3
Resolve the 4 Documentation finding(s) in Documentation Quality.
Raises the score by about 3 points · Low effort · Documentation Quality

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €680,000 to build again, about 4.7 person-years of work. Its weakest lens is Production Readiness, at 43 (Weak). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Add a CI workflow that builds and runs the test suite on every push/PR. Of all the actions in this report, it raises the score most for the work it takes: about 5 points for medium effort. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 7.5 out of 10. Code at that level is slower to change than clean code, and Watchdog estimates the extra work at 2% to 5% on every change. The history of the code shows how much it changes: about 14,617 lines over the last 90 days, which is about 59,280 lines a year. At that pace, the extra work comes to an estimated 3 to 19.8 engineer-days a year, and it grows as more code changes.
How this is estimated: The number of changed lines is measured from the history of the code. The rest rests on two assumptions of Watchdog's own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change; and an engineer changes 150 to 400 lines in a day. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4) · the code's change history
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

1496 modules, with 6426 dependencies between them. 16 loops run through 429 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 1456 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 optimus.platform.dsi.bitemporal.MessagesPublishCommandBase2 optimus.platform.versioning.FieldType3 optimus.platform.versioning.RegisteredFieldType4 optimus.profiler.Filter5 scalaxb.compiler6 optimus.platform.relational.tree7 optimus.platform.storable8 optimus.platform.dal.pubsub9 optimus.platform.dsi.bitemporal.proto10 optimus.platform.relational.data.tree11 optimus.platform.relational12 optimus.platform.dsi.protobufutils13 optimus.platform.dsi.bitemporal14 optimus.platform.dal.config15 optimus.platform.dal16 optimus.platform.util17 optimus.graph.tracking18 optimus.platform.pickling19 optimus.entity20 optimus.graph21 optimus.graph.diagnostics22 optimus.buildtool.format23 optimus.platform24 optimus.buildtool.trace25 optimus.buildtool.utils26 optimus.buildtool.files27 optimus.buildtool.artifacts28 optimus.buildtool.config29 optimus.platform.dsi.expressions30 optimus.platform.dsi.expressions.TypeCode31 optimus.config.spray.json32 optimus.breadcrumbs.crumbs.Properties33 optimus.buildtool.runconf.compile34 optimus.breadcrumbs35 optimus.breadcrumbs.crumbs36 optimus.breadcrumbs.crumbs.KnownEvents37 optimus.buildtool.runconf.compile.Types38 msjava.slf4jutils.scalalog39 optimus.platform.relational.dal.core40 optimus.profiler.ui
1 optimus.platform.dsi.bitemporal.MessagesPublishCommandBase1
2 optimus.platform.versioning.FieldType1
3 optimus.platform.versioning.RegisteredFieldType12
4 optimus.profiler.Filter113
5 scalaxb.compiler121
6 optimus.platform.relational.tree42324442063375
7 optimus.platform.storable2539281323114732628213711
8 optimus.platform.dal.pubsub832057163226111123171
9 optimus.platform.dsi.bitemporal.proto51710152201402124222122261
10 optimus.platform.relational.data.tree31112921322119
11 optimus.platform.relational8126448111334941362258
12 optimus.platform.dsi.protobufutils1516311136814434134311
13 optimus.platform.dsi.bitemporal8313914311125245233259191563131119287
14 optimus.platform.dal.config8103522433
15 optimus.platform.dal44286763582191275623431414543153791
16 optimus.platform.util15293511434111713524327743
17 optimus.graph.tracking1818732623735114133622
18 optimus.platform.pickling1460709201231817161425141
19 optimus.entity229629731211163
20 optimus.graph1783116553164210233628594322122282
21 optimus.graph.diagnostics739281113445821702
22 optimus.buildtool.format251737313131761131184
23 optimus.platform2637691211332101411111219172181471
24 optimus.buildtool.trace1319381151726331765
25 optimus.buildtool.utils16364243143444512018942
26 optimus.buildtool.files101739155141448
27 optimus.buildtool.artifacts75251111652685
28 optimus.buildtool.config34114441022621312961
29 optimus.platform.dsi.expressions7114111131413132631
30 optimus.platform.dsi.expressions.TypeCode27
31 optimus.config.spray.json259314
32 optimus.breadcrumbs.crumbs.Properties434126415
33 optimus.buildtool.runconf.compile101219114831343
34 optimus.breadcrumbs4913413312241
35 optimus.breadcrumbs.crumbs3147111063628
36 optimus.breadcrumbs.crumbs.KnownEvents11
37 optimus.buildtool.runconf.compile.Types1161
38 msjava.slf4jutils.scalalog13125
39 optimus.platform.relational.dal.core8142492305322211622
40 optimus.profiler.ui354684511313513992
Uses a module listed above itPart of a loopThe module itself
1 optimus.platform.dsi.bitemporal.MessagesPublishCommandBase2 optimus.platform.versioning.FieldType3 optimus.platform.versioning.RegisteredFieldType4 optimus.profiler.Filter5 scalaxb.compiler6 optimus.platform.relational.tree7 optimus.platform.storable8 optimus.platform.dal.pubsub9 optimus.platform.dsi.bitemporal.proto10 optimus.platform.relational.data.tree11 optimus.platform.relational12 optimus.platform.dsi.protobufutils13 optimus.platform.dsi.bitemporal14 optimus.platform.dal.config15 optimus.platform.dal16 optimus.platform.util17 optimus.graph.tracking18 optimus.platform.pickling19 optimus.entity20 optimus.graph21 optimus.graph.diagnostics22 optimus.buildtool.format23 optimus.platform24 optimus.buildtool.trace25 optimus.buildtool.utils26 optimus.buildtool.files27 optimus.buildtool.artifacts28 optimus.buildtool.config29 optimus.platform.dsi.expressions30 optimus.platform.dsi.expressions.TypeCode31 optimus.config.spray.json32 optimus.breadcrumbs.crumbs.Properties33 optimus.buildtool.runconf.compile34 optimus.breadcrumbs35 optimus.breadcrumbs.crumbs36 optimus.breadcrumbs.crumbs.KnownEvents37 optimus.buildtool.runconf.compile.Types38 msjava.slf4jutils.scalalog39 optimus.platform.relational.dal.core40 optimus.profiler.uioptimus.platform.dsi.bitemporal.MessagesPublishCommandBase1optimus.platform.versioning.FieldType2optimus.platform.versioning.RegisteredFieldType3optimus.profiler.Filter4scalaxb.compiler5optimus.platform.relational.tree6optimus.platform.storable7optimus.platform.dal.pubsub8optimus.platform.dsi.bitemporal.proto9optimus.platform.relational.data.tree10optimus.platform.relational11optimus.platform.dsi.protobufutils12optimus.platform.dsi.bitemporal13optimus.platform.dal.config14optimus.platform.dal15optimus.platform.util16optimus.graph.tracking17optimus.platform.pickling18optimus.entity19optimus.graph20optimus.graph.diagnostics21optimus.buildtool.format22optimus.platform23optimus.buildtool.trace24optimus.buildtool.utils25optimus.buildtool.files26optimus.buildtool.artifacts27optimus.buildtool.config28optimus.platform.dsi.expressions29optimus.platform.dsi.expressions.TypeCode30optimus.config.spray.json31optimus.breadcrumbs.crumbs.Properties32optimus.buildtool.runconf.compile33optimus.breadcrumbs34optimus.breadcrumbs.crumbs35optimus.breadcrumbs.crumbs.KnownEvents36optimus.buildtool.runconf.compile.Types37msjava.slf4jutils.scalalog38optimus.platform.relational.dal.core39optimus.profiler.ui4011121131214232444206337525392813231147326282137118320571632261111231715171015220140212422212226131112921322119812644811133494136225815163111368144341343118313914311125245233259191563131119287810352243344286763582191275623431414543153791152935114341117135243277431818732623735114133622146070920123181716142514122962973121116317831165531642102336285943221222827392811134458217022517373131317611311842637691211332101411111219172181471131938115172633176516364243143444512018942101739155141448752511116526853411444102262131296171141111314131326312725931443412641510121911483134349134133122413147111063628111161131258142492305322211622354684511313513992+1456 more modules (most-connected shown)

At a glance — Code Health · 56% · Adequate · gated by X5 ·

The Good
D3 · Scala God Classes 8.6 D4 · Scala Code Duplication 9.5 D17 · Scala Explicit Debt 9.8 GD1 · Repo Unfinished & placeholder code 10.0 IC1 · Repo Incompleteness & stubs 7.2 X1 · Repo Async correctness 10.0 X12 · Repo Unreachable branch 10.0 X13 · Repo Undrained process stream 10.0 X16 · Repo Unfloored truncation loop 10.0 X19 · Repo Unrestored process-global state 10.0 X20 · Repo Mistyped argument guard 10.0 X21 · Repo Side-effecting pattern guard 10.0 X22 · Repo Contradicted release guard 10.0 X23 · Repo Unguarded diagnostic materialisation 7.8 X25 · Repo Inert configuration knob 10.0 X26 · Repo Unsynchronised callback handoff 10.0 X27 · Repo Collection changed while being enumerated 8.0 X28 · Repo Index access outside its own emptiness guard 10.0 X29 · Repo Per-element action decided by a fixed element 10.0 X30 · Repo Support guard that admits what it rejects 10.0
The Bad
D1 · Scala Cyclomatic Complexity 5.7 D2 · Scala Cognitive Complexity 5.1 X18 · Repo Disposal-pattern correctness 5.3 X3 · Repo Exception handling 7.0 X4 · Repo Structured logging 5.4
The Ugly
X5 · Repo Nullable reference types 2.0

At a glance — Architecture · 90% · Adequate · gated by D26 ·

The Good
D6 · Scala Cohesion (LCOM4) 9.6 D35 · Scala Change Coupling 10.0 AX10 · Repo Code composition 9.5 AX2 · Repo Stateful singletons 10.0 AX3 · Repo Project dependency cycles 10.0 AX4 · Repo Dependency direction 10.0 AX5 · Repo Architecture & structure 10.0 AX6 · Repo Interface segregation 9.9
The Ugly
D26 · Scala Project Cohesion 0.0

At a glance — Maturity · 48% · Weak · gated by M2 ·

The Good
D15 · Scala Churn × Complexity Hotspots 9.9 D19 · Scala Documentation Quality 7.0 D21 · Scala Naming Consistency 10.0 M3 · Repo Folder & project structure 8.0 M4 · Repo Documentation accuracy 10.0
The Bad
M1 · Repo Documentation (README) 6.0
The Ugly
M2 · Repo Architecture documentation 0.0

At a glance — Readiness · 43% · Weak · gated by P1, P3 ·

The Good
D9 · Scala Test Distribution 10.0 D13 · Scala Secret Scanning 10.0 P2 · Repo Observability 10.0
The Ugly
P1 · Repo CI/CD gates 0.0 P3 · Repo Security & performance tooling 0.0

At a glance — Security · 69% · Adequate · gated by D29 ·

The Good
D28 · Scala Secrets (history) 10.0 S1 · Repo Web-Security Posture 8.0 X14 · Repo Bypassable address classification 10.0
The Bad
X24 · Repo Document value interpolated into markup unescaped 5.1
The Ugly
D29 · Scala Static Analysis (SAST) 2.0 X15 · Repo Unvalidated length from an untrusted reader 2.7 X17 · Repo Uncapped recursion over a caller-supplied document 3.5

At a glance — Domain Modelling · 100% · Exemplary ·

The Good
DM1 · Repo Aggregate boundaries 10.0 DM10 · Repo One transaction, one aggregate 10.0 DM12 · Repo Ambient inputs in the domain 10.0 DM6 · Repo Domain ↔ infrastructure boundary 10.0 DM8 · Repo Value-object opportunities 10.0 DM9 · Repo Scattered domain decisions 10.0

At a glance — Accessibility · 57% · Adequate ·

The Good
AC2 · Repo Forms & labels 10.0 AC5 · Repo ARIA correctness 10.0
The Bad
AC3 · Repo Page structure 5.0
The Ugly
AC6 · Repo Visual & motion safety 4.3 AC7 · Repo A11y enforcement 4.0

At a glance — Performance · 82% · Strong ·

The Good
PF3 · Repo Async & latency hygiene 10.0
The Bad
PF2 · Repo Allocation hygiene 6.8

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A05:2025 — Injection17High / Critical

Roadmap

First, establish a CI pipeline that builds the code and runs the test suite on every push to ensure basic stability. Integrate security and performance checks, such as semgrep, into this workflow so that regressions fail the build immediately. Simultaneously, document key architectural decisions in a dedicated folder and address existing documentation quality issues. Finally, update the README with a clear quick-start guide to help new contributors get up to speed.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Add a CI workflow that builds and runs the test suite on every push/PR.+5.4 ptsMediumCI/CD gates
Run what this repository's stack ships: scalafix or scapegoat — or `semgrep --config=auto`, which runs on any language — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.+5.4 ptsMediumSecurity & performance tooling
Resolve the 4 Documentation finding(s) in Documentation Quality.+2.6 ptsLowDocumentation Quality
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.+3.4 ptsMediumArchitecture documentation
Add a build/run (quick start) section to the root README — the first thing a newcomer needs.+2.2 ptsMediumDocumentation (README)
On Scala 3, add `-Yexplicit-nulls` to `scalacOptions` so `String` and `String | Null` mean different things, and type each Java API's result as nullable where it can return null; on Scala 2 (or as a first step), enable WartRemover's `Null` wart (`wartremoverErrors += Wart.Null`) or Scalafix's `DisableSyntax.noNulls = true` so the code holds absence in `Option`. Then pay the assertions down rather than adding to them: each `.nn` is a null the compiler could not rule out — wrap the Java value in `Option(…)` at the boundary, pattern-match on `null` once there, or change the API so the null cannot arrive; an `unsafeNulls` import switches the checking off for everything after it.+1.2 ptsMediumNullable reference types
Group production code under src/ (or split deliberately, e.g. backend/ + frontend/) so production and tooling code aren't mixed at the root.+1.0 ptsMediumFolder & project structure
Enforce accessibility in the toolchain your project already uses: assert accessibility in your UI test suite with your toolkit's own matcher (Flutter `meetsGuideline`, Espresso `AccessibilityChecks`, XCTest `performAccessibilityAudit`), then gate that test in CI so a regression blocks the merge.+0.9 ptsMediumA11y enforcement

File quality

Per-file score 0–10 — a quality signature. Of 756 files carrying findings, judged against the Production bar: 0% slop · 52% mixed · 48% near-clean.

FileScoreBandWorst signal
REDACTED4.5MixedStatic Analysis (SAST): Medium: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): High: REDACTED
optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALBinder.scala5.5MixedCyclomatic Complexity: DALBinder.bindWhere (cyclomatic 18)
optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala5.5MixedCognitive Complexity: OptimusSeq.zipAll (cognitive 33)
optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/rewrite/RewriteComponent.scala5.5MixedCognitive Complexity: AnyFormatted.transform (cognitive 31)
REDACTED5.8MixedStatic Analysis (SAST): High: REDACTED
optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeTreeTable.scala5.9MixedCyclomatic Complexity: NodeTreeTable.getTreeSelector (cyclomatic 16)
optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala5.9MixedCognitive Complexity: OptimusSeq.zipAll (cognitive 33)
optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala5.9MixedCognitive Complexity: OptimusArraysSeq.map (cognitive 31)
optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala6.0MixedExplicit Debt: TodoComment
optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala6.0MixedExplicit Debt: TodoComment
optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala6.0MixedExplicit Debt: TodoComment
optimus/platform/projects/dal_core/src/main/scala/optimus/platform/bitemporal/BitemporalSpaceImpl.scala6.0MixedExplicit Debt: XxxComment
optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AsyncGraphComponent.scala6.0MixedExplicit Debt: TodoComment
optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/EmbeddableComponent.scala6.0MixedExplicit Debt: TodoComment
optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/provider/PropertyInfoProvider.scala6.0MixedExplicit Debt: TodoComment
optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PredicatePushdownOptimizer.scala6.0MixedExplicit Debt: TodoComment
optimus/platform/projects/core/src/main/scala/optimus/config/NodeCacheConfigs.scala6.0MixedExplicit Debt: TodoComment
optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincCompiler.scala6.0MixedExplicit Debt: HackComment
optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/CommandProtoSerialization.scala6.0MixedExplicit Debt: TodoComment

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 7

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 2185

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 113

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 15

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 63 of 67 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 4 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.7 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 67 dimensions across the health lenses
D1D2D3D4D6D9D13D15D17D19D21D26D28D29D35AC2AC3AC5AC6AC7AX10AX2AX3AX4AX5AX6DM1DM10DM12DM6DM8DM9GD1IC1M1M2M3M4P1P2P3PF2PF3S1X1X12X13X14X15X16X17X18X19X20X21X22X23X24X25X26X27X28X29X3X30X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 2293 of 2305 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Watchdog duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic
LLM (sampled · advisory)Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurementLocal LLM◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 01a15ebf-5f57-7592-8d21-951e46fa80e0.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.scala) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo. To have real coverage read, produce a coverage report in a standard format (`addSbtPlugin("org.scoverage" % "sbt-scoverage" % "<version>")` in `project/plugins.sbt`, then `sbt clean coverage test coverageReport`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures. You can widen what we reach: optional: produce a coverage report in a standard format (`addSbtPlugin("org.scoverage" % "sbt-scoverage" % "<version>")` in `project/plugins.sbt`, then `sbt clean coverage test coverageReport`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures — then the real number is read on the next scan.
  • D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.scala) but the built-in reliability runner does not support this repository's ecosystem, so flakiness couldn't be assessed. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
  • D12 Dependency Hygiene — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. No dependency manifest this pass reads for hygiene (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems)) was found in this repository, so no package was assessed. Zero packages read is NOT a clean dependency tree, so this is NOT SCORED — a gap in the analyzer, not a verdict about this repository. This row is about dependency HYGIENE — outdated, deprecated or unmaintained direct dependencies; known CVEs in the same dependency graph are a separate question, reported under D30 wherever the manifest is OSV-readable.
  • D14 License Compliance — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Not scored — no dependency manifest this pass reads for licence data (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems)) was found in this repository, so it declares no third-party dependency closure to grade. A gap in the analyzer, NOT a finding that this repository's licences are compliant: a manifest in an ecosystem outside that list, or third-party code copied into the tree, is not read — so this dimension asserts nothing about this repository's licensing in either direction.
  • D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-maintainer repository — bus factor is not applicable (2 contributor(s) across 61 commit(s) sampled, automation and bot accounts excluded). One of them holds 98% of the history; the other 1 hold 2% each on average, below the 5% at which there is somebody to hand the work to. That is a single maintainer with drive-by contributors, not a team whose knowledge has concentrated — so the bus factor is not applicable and there is nothing here for the owner to act on.
  • D20 ADR Quality — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. The ADR expectation is gated on whether a repository ships a deployable product. Our repo-kind classifier reads .NET project files and the host and package markers of the other ecosystems it knows (a Go `package main`, a Cargo binary, a package.json `bin`, `start` script or application dev server such as Vite or Next, Python console scripts or a Django/WSGI entry point, a Spring Boot / WAR / Gradle application build, a Rack or Rails app, a Composer project, an OTP release or escript, a Dockerfile, a Procfile, a Platform.sh `.platform/routes.yaml`, and the corresponding published-package manifests, including an OTP `*.app.src`, a Drupal module's `*.info` and a Claude Code `.claude-plugin/plugin.json`), and found none here, so we could not tell what kind of repository this is and did not assess its ADR log. This is a gap in our analyzer, not a finding about this repository.
  • D22 Internal API Consistency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is an ADMISSION gap, not an environment fault: no published-package marker D22 reads admitted any project here. D22 DOES collect the public API of every language in this tree, and admits a project only when its manifest makes that ecosystem's publication act in a form the marker recognises — so what is missing is not a collector but an admission rule for the publication act this repository makes, if it makes one. The remedy is a better discriminator for that marker — not a collector, and no change to the scan image can close it. The marker's rules are measured to refuse applications, so one refused repository is the rule working as calibrated; several are the evidence that it is too strict. For npm the surface is what a published package.json's entry points (exports, main, module, types) export, followed through the source; an entry that names build output the tree does not commit (dist/, build/) is not followed back to source, because only a tsconfig outDir/rootDir pair states that mapping and a bundler's input lives in executable configuration this engine does not evaluate.
  • D27 Navigability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Navigability is taken over call sites whose callee resolved. For C# that population includes calls into referenced assemblies; for this language only calls declared inside the repository count, so the abstention threshold reads the repository's use of its standard library as a resolution failure. That is a limit of this analyzer, not a build problem in this repository.
  • D32 Data Compliance (PII/GDPR) — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/reporter/HtmlReporter.scala`, `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/trace/ObtTracer.scala`, `optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ExtensionConfigurationCompiler.scala`, `optimus/platform/projects/core/src/main/scala/optimus/config/scoped/json/JsonScopedConfiguration.scala`, `optimus/platform/projects/core/src/main/scala/optimus/core/CoreAPI.scala`, … (+26 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • D34 Knowledge Freshness — git history too condensed for a reliable signal — The history looks squashed or freshly imported, so per-file ownership reflects those commits rather than real maintenance. This dimension is reported as a low-confidence advisory and is not scored.
  • D44 Platform End-of-Life — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This dimension reads a project's own statement about the platform it runs on: a TargetFramework in a .NET project file, a .nvmrc or .python-version, a capped requires-python, a Rust toolchain file or Cargo.toml rust-version, a .go-version, .java-version, .ruby-version, .tool-versions or .sdkmanrc, a go.mod go directive, a Maven or Gradle Java level or toolchain, a Gemfile's ruby directive, a mix.exs elixir requirement, a rebar.config minimum_otp_vsn, a pubspec.yaml SDK constraint, a build.sbt scalaVersion, or a framework major pinned by a dependency constraint. This repository carries none of them, so nothing about its platform was established. That is a gap in this analyzer's coverage, NOT a finding that the platform is supported — a language whose runtime is declared elsewhere (Package.swift, a Dockerfile) is simply not read here yet.
  • AX1 Captive dependencies — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads Microsoft.Extensions.DependencyInjection registrations in C# and Spring beans in Java/Kotlin only, and this repository's container is Guice and Spring (Scala), whose lifetimes are not modelled yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • AXB1 Runtime evidence locked — no reproducible boot — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Subject: 4 markup document(s) — HTML, Razor, JSX, Vue, Svelte or server templates. The Runtime Evidence tier boots an app only via docker-compose, an Aspire AppHost, a Dockerfile, an npm dev script, a web service's own toolchain entry point (cargo, go, dotnet, Python, Spring Boot), or an Android app's own Gradle wrapper (run on an emulator); an Apple or Flutter app needs a host it lacks. None applied, so no live runtime a11y/egress/header evidence was collected. You can widen what we reach: add a docker-compose.yml (or an Aspire AppHost) that brings the app up with its dependencies. Watchdog then boots it in an isolated sandbox and gathers real runtime evidence — you change nothing in your pipeline (no CI step, no SDK).
  • C1 Data Protection — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These personal data controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks personal data controls.
  • C2 Access Controls — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • M3 Folder & project structure — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Whether the tests sit apart from production code is not visible here, because the suite is not in a form this pass reads. The test-separation credit is granted rather than withheld: this is a gap in the analyzer's language coverage, not a finding about the repository's tests. You can widen what we reach: keep the test surface somewhere a reader can find it without opening a binary — an exported/checked-in test source tree beside the production code makes the suite reviewable, diffable and discoverable by tooling.
  • P5 DR & Backup — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found. Whether there is anything here to recover could NOT be determined: persistence is detected from deployment/container manifests and from dependency manifests, and neither was readable by this pass, so a data store this code opens directly — a file, an embedded database — would not be visible to it. The blindness is this analyzer's, not a finding that the repository holds no data. You can widen what we reach: keep the deployment/container manifest or a dependency manifest in this repository — or a link to the ops repo that holds the DR evidence — so the persistence probe has something to read.
  • X3 Exception handling — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 13 further occurrence(s) are not listed individually; the score already reflects all 53.
  • X4 Structured logging — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 187 further occurrence(s) are not listed individually; the score already reflects all 227.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
  • D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
  • AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
  • AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
  • AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
  • AC7 A11y enforcement: Enforcement is scored from in-repo config/CI evidence only — an a11y gate enforced in external tooling with no in-repo trace can't be credited, and a configured linter is presence, not proof the rules actually run or block a merge.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • DM6 Domain ↔ infrastructure boundary: Infrastructure reached through a hand-rolled wrapper, a domain-named facade, reflection, or a string-keyed service locator resolves to a non-infra type and isn't seen; the body scan is symbol resolution over syntax, not full dataflow. A clean result means "no resolved infra reference in a domain body", not a proof of purity.
  • M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.

The LLM boundary

LLM-set scores this run (4): D19, D21, D26, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.

Dimensions

D1 · Cyclomatic Complexity5.7 / 10Adequate✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.7 / 10 · rule-coverage 100% · ceiling Prevented

200 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was AdjustAST.transformStorableTemplate at 134. A further 43 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being ResultSerializer.deserialize at 68 — they are counted neither in the figure above nor in this dimension's score. 28 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/macros/VersioningMacroUtils.scala (trees.registeredFieldType at 58), optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/Feature.scala (Feature.fromValue at 49), optimus/platform/projects/dal_core/src/main/scala/optimus/dsi/base/DSITxn.scala (DSITxn.actionToSourceGroup at 35), optimus/platform/projects/platform/src/main/scala/optimus/platform/dsi/accelerated/AcceleratedInfoConversions.scala (AcceleratedInfoConversions.convertToRegisterFieldType at 34), optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/persistence/protocol/QueryMethod.scala (QueryMethodNumberMap.getNumberByQueryMethod at 32), and 23 more not listed here. They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

OptimusSeqUtils.mapConserve (cyclomatic 23) · ×2optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqUtils.scala:29
AdjustAST.transformStorableTemplate (cyclomatic 134)optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:790
OptimusRefchecks.traverse (cyclomatic 90)optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:799
AutoAsync.transformSafe (cyclomatic 89)optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala:1641
OptimusRefchecks.checkDefDef (cyclomatic 89)optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:317

+ 194 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 6 bodies over 60 down to 60 or less in Cyclomatic Complexity — start with AdjustAST.transformStorableTemplate (cyclomatic 134), OptimusRefchecks.traverse (cyclomatic 90), AutoAsync.transformSafe (cyclomatic 89). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 6 together lifts Cyclomatic Complexity from 5.7 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
  2. Stand up a CI pipeline, then gate Cyclomatic Complexity in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity5.1 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.1 / 10 · rule-coverage 100% · ceiling Prevented

525 method(s) exceeded the cognitive complexity threshold of 15; the worst was AdjustAST.transformStorableTemplate at 231.

OptimusSeqUtils.mapConserve (cognitive 57) · ×2optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqUtils.scala:29
OptimusSeq.zipAll (cognitive 33) · ×2optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:509
InfoDumper.dump (cognitive 32) · ×2optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/InfoDumper.scala:73
OptimusArraysSeq.sliceSafe (cognitive 20) · ×2optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:343
OptimusArraySeq.filter0 (cognitive 19) · ×2optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:81

+ 510 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 8 bodies over 120 down to 120 or less in Cognitive Complexity — start with AdjustAST.transformStorableTemplate (cognitive 231), TopologyRingCreator.allocateSubPolicyMember (cognitive 177), SerializedKeyBasedIndexOptimizer.handleSelect (cognitive 175). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 8 together lifts Cognitive Complexity from 5.1 to about 5.8/10, projected with the scoring formula itself and assuming each lands exactly at 120; a cleaner split scores higher.
  2. Stand up a CI pipeline, then gate Cognitive Complexity in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes8.6 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.6 / 10 · rule-coverage 100% · ceiling Prevented

206 god class(es) detected.

TooManyMethods: Tracer · ×94optimus/platform/projects/dal_core/src/main/scala/optimus/dsi/trace/Tracer.scala:50
FileTooLong: bitemporal/Command.scala · ×79optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/Command.scala
ClassTooLong: AdjustASTComponent · ×20optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:52
MethodTooLong: NodeMenu.create · ×13optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeMenu.scala:103

What to do

  1. Resolve the 94 TooManyMethods finding(s) in God Classes — start with Utils.scala (2), BigDecimal.scala (2), QueryMacros.scala (2). — One of this dimension's main actionable groups (94 warning-level).
  2. Resolve the 79 FileTooLong finding(s) in God Classes — start with Command.scala, RelationColumnType.scala, ProductFormatsInstances.scala. — One of this dimension's main actionable groups (79 warning-level).
  3. Resolve the 20 ClassTooLong finding(s) in God Classes — start with AdjustASTComponent.scala, RewriteComponent.scala, DHTRingManager.java. — One of this dimension's main actionable groups (20 warning-level).
  4. Stand up a CI pipeline, then gate God Classes in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication9.5 / 10Stronggated by 559 serious findings✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.5 / 10 · rule-coverage 100% · ceiling Verified

526 duplicated block group(s) detected. A further 33 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted. 24 of the 559 are in trees this repository does not ship — vendored, example/demo, fixture and benchmark code — and are ranked below the shipped groups rather than excluded from them: the duplication there is real and is still counted in this dimension's score. The dimensions that publish a production-file census leave those trees out of theirs, so this count is deliberately drawn over the wider population.

Duplicated block (8 lines × 2) · ×49optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/scope/sources/ElectronCompilationSources.scala:35
Duplicated block (9 lines × 2) · ×41optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/bsp/BspBuilder.scala:201
Duplicated block (6 lines × 2) · ×40optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:57
Duplicated block (5 lines × 2) · ×39optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:347
Duplicated block (7 lines × 2) · ×33optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncElectronCompiler.scala:123

+ 129 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 49 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with DefaultBinder.scala (4), OptimusDoubleSeq.scala (3), ASMDynamicObjectGenerator.scala (3). — One of this dimension's main actionable groups (49 warning-level).
  2. Resolve the 41 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with OptimusSeqSmall.scala (3), OptimusDoubleSeq.scala (2), OptimusSeqArrays.scala (2). — One of this dimension's main actionable groups (41 warning-level).
  3. Resolve the 40 Duplicated block (6 lines × 2) finding(s) in Code Duplication — start with OptimusSeqSmall.scala (6), OptimusSeq.scala (3), NodeTaskTransformer.java (2). — One of this dimension's main actionable groups (40 warning-level).
  4. Stand up a CI pipeline, then gate Code Duplication in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)9.6 / 10Stronggated by 26 serious findings✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.6 / 10 · rule-coverage 100% · ceiling Verified

26 of 758 classes have LCOM4 above 3.

Low cohesion: OptimusSeq (LCOM4 12) · ×26optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:303

What to do

  1. Resolve the 26 Low cohesion finding(s) in Cohesion (LCOM4) — start with OptimusSeq.scala (2), DALBinder.scala (2), PropertyNode.scala. — One of this dimension's main actionable groups (26 warning-level).
  2. Stand up a CI pipeline, then gate Cohesion (LCOM4) in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.

Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

2 test methods: 2 unit, 0 integration, 0 BDD, 0 e2e. The Scala suite contributes 2 test case(s) across 1 file(s) in a test source set declaring at least one — every `test("…")`, `it("…")`, `property("…")` and `"…" in {…}` registration and every JUnit `@Test`, which is how munit, ScalaTest, utest, ZIO Test and specs2 declare a case; a case registered under a computed name is not counted, so this is a floor. Its tier split is INFERRED from paths and file names, except sbt's src/it source set, which the build declares.

✓ On the Gold path — maintain.

Detailed fixes: d9_recommendation.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D15 · Churn × Complexity Hotspots9.9 / 10Stronggated by 5 serious findings✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/PersistBlock.scala (4×33=132); optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PropertyMapProtoSerialization.scala (3×30=90); optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/zookeeper/BreadcrumbsZkClient.scala (2×18=36)

Hotspot: optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/PersistBlock.scala · ×5optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/PersistBlock.scala:538

What to do

  1. Resolve the 5 Hotspot finding(s) in Churn × Complexity Hotspots — start with PersistBlock.scala, PropertyMapProtoSerialization.scala, BreadcrumbsZkClient.scala. — One of this dimension's main actionable groups (5 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt9.8 / 10Stronggated by 536 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Prevented

536 deducted task-comment markers across 537190 LoC (0.1/KLoC) → score 9.8. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×511optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/app/OptimusBuildToolCmdLine.scala:795
HackComment · ×13optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincCompiler.scala:121
XxxComment · ×12optimus/platform/projects/alarms/src/main/scala/optimus/tools/scalacplugins/entity/reporter/OptimusAlarms.scala:657

What to do

  1. Resolve the 511 TodoComment finding(s) in Explicit Debt — start with Settings.java (10), SimpleHashMap.java (10), IntHashMap.java (10). — One of this dimension's main actionable groups (511 warning-level).
  2. Resolve the 13 HackComment finding(s) in Explicit Debt — start with MsIvyRepository.scala (2), RegexConfiguration.scala (2), ZincCompiler.scala. — One of this dimension's main actionable groups (13 warning-level).
  3. Resolve the 12 XxxComment finding(s) in Explicit Debt — start with NotificationEntry.scala (3), BitemporalSpaceImpl.scala (2), OptimusAlarms.scala. — One of this dimension's main actionable groups (12 warning-level).
  4. Stand up a CI pipeline, then gate Explicit Debt in it to reach Verified (currently Documented). — This repository has no CI pipeline, so there is nothing to add a gate to yet — the pipeline comes first. Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation QualityStrong◐ Sampled · advisory

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Strong / 10 · rule-coverage 100% · ceiling Documented

The repository's READMEs are mostly excellent: the root README gives an overview and links to contributing guidelines, talks, and a LICENSE file; each directory README documents its own tier (e.g. the rest OBT module README is focused on that subdirectory). The architecture/design docs are thin but present for the project, and there is one unstructured shell-block example in the root README ('We have published all the code used to compile the Optimus Build Tool (OBT)') which would be flagged as missing-usage if it were tagged. However, the visible content is clear and complete for its scope.

Documentation: no project overview · ×4

What to do

  1. Resolve the 4 Documentation finding(s) in Documentation Quality. — One of this dimension's main actionable groups (4 recommendation-level).

Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming ConsistencyExemplary◐ Sampled · advisory

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Verified

0 naming inconsistencies across 0 sampled symbols.

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md.

D26 · Project Cohesion0.0 / 10Critical✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic, LLM-independent.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

1 of 1 build units (checkout) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion

What to do

  1. Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D28 · Secrets (history)10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

gitleaks scanned the full history AND the current working tree and found no secrets.

✓ On the Gold path — maintain.

Detailed fixes: d28_recommendation.md.

D29 · Static Analysis (SAST)2.0 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 2.0 / 10 · rule-coverage 100% · ceiling Documented

17 finding(s): 0 critical, 6 high, 11 medium, 0 low. semgrep hit a parse error in 49 file(s) — `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/postbuilders/installer/component/TestplanInstaller.scala`, `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/postbuilders/installer/component/testplans/GroupJsonModel.scala`, `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/reporter/HtmlReporter.scala`, `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/trace/ObtTracer.scala`, `optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ExtensionConfigurationCompiler.scala`, … (+44 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 4 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2), REDACTED. — One of this dimension's main actionable groups (3 issue-level).
  2. Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (3). — One of this dimension's main actionable groups (3 issue-level).
  3. Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (3). — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No strong hidden change-coupling between production files.

✓ On the Gold path — maintain.

Detailed fixes: d35_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AC2 · Forms & labels10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.

Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

AC3 · Page structure5.0 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.

Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en"). — optimus/platform/projects/core/src/main/resources/html/gridprofiler.html:1
  • No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. — optimus/platform/projects/core/src/main/resources/html/gridprofiler.html:1

What to do

  • Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
AC5 · ARIA correctness10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.

Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

AC6 · Visual & motion safety4.3 / 10Weak✓ Tool-verified

Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.

Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.

Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • `.toggleBtn` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — optimus/platform/projects/core/src/main/resources/css/gridprofiler.css:63
  • `ul.tabLinks a` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — optimus/buildtool/projects/htmlreport/src/main/resources/org/gradle/reporting/base-style.css:93

What to do

  • Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
AC7 · A11y enforcement4.0 / 10Weak✓ Tool-verified

Other · Accessibility — Whether accessibility is ENFORCED in the toolchain — an accessibility checker configured over the markup (an a11y lint rule set, e.g. eslint-plugin-jsx-a11y or vuejs-accessibility where the project lints JavaScript) and an automated accessibility assertion wired into tests or CI (axe/pa11y/Lighthouse or an equivalent) — on the Documented→Verified→Prevented ladder.

Method: Repo config/CI scan: an accessibility checker configured over the markup (an a11y lint rule set such as eslint-plugin-jsx-a11y / vuejs-accessibility where JavaScript is linted) and an automated accessibility assertion in tests or CI (axe/pa11y/Lighthouse or equivalent), graded on the Documented→Verified→Prevented rungs. Deterministic, presence/rung detection.

Coverage: Population: the repository's own tooling configuration — lint config, test and CI files — NOT the markup. It is read for a configured accessibility checker and an automated accessibility assertion (axe/pa11y/Lighthouse, or a native-toolkit equivalent), and it credits an INVOCATION, never a mention: a licence filename, an import comment or a doc reference earns no rung. Enforcement configured entirely outside the repository leaves no evidence here and cannot be credited.

  • No accessibility enforcement found — no accessibility linting at author time and no automated accessibility check in tests or CI. Add your UI toolkit's own accessibility assertion to the test suite (Flutter `meetsGuideline`, Espresso `AccessibilityChecks`, XCTest `performAccessibilityAudit`), then gate that test in the pipeline. What was searched, so you can tell an absence from a miss: the 4 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.

What to do

  • Enforce accessibility in the toolchain your project already uses: assert accessibility in your UI test suite with your toolkit's own matcher (Flutter `meetsGuideline`, Espresso `AccessibilityChecks`, XCTest `performAccessibilityAudit`), then gate that test in CI so a regression blocks the merge.
AX10 · Code composition9.5 / 10Exemplary✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

What to do

  • The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
AX2 · Stateful singletons10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX5 · Architecture & structure10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.

Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.

AX6 · Interface segregation9.9 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

  • `KVClient<K>` declares 16 abstract methods under just 12 distinct name(s): `batchContains`, `batchGet`, `batchPut`, `batchRemove`, `contains`, `contains`, `get`, `get`, `getLargeValue`, `put`, `put`, `putLargeValue`, `remove`, `remove`, `removeTransientKeyspace`, `streamingGet`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 12 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — optimus/dht/projects/client3/src/main/java/optimus/dht/client/api/kv/KVClient.java:24
  • `MSNetAdminManagerImpl` declares 24 abstract methods: `addAdminCommand`, `addAdminCommand`, `addAlias`, `addListener`, `getAddressInfo`, `getAdminCommand`, `getAdminCommandStore`, `getConnectionCount`, `getEntity`, `getInterceptListener`, `handleSubscribeRequest`, `handleTapRequest`, `handleUnsubscribeRequest`, `isEntityRegistered`, `isServerListening`, `listEntities`, `registerEntity`, `removeAdminCommand`, `removeAdminCommands`, `removeListener`, `serverShutdown`, `setAccessDecisionManager`, `setInterceptListener`, `unregisterEntity`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 24 declarations carry 23 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 23 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/admin/MSNetAdminManagerImpl.java:20
  • `MSNetProtocolConnectionConfiguration` declares 62 abstract methods: `afterPropertiesSet`, `getAnonymousAuthentication`, `getAsyncReading`, `getBackupAddresses`, `getBindAddress`, `getCallbackExecutor`, `getConnectionId`, `getConnectionName`, `getEstablishers`, `getHostPort`, `getKeepAlive`, `getKerberos`, `getKerberosEncryption`, `getLoop`, `getMaxDisconnects`, `getMaxRetries`, `getMaxRetryTime`, `getPlainConnectionConfiguration`, `getProtocol`, `getReceiveBufferSize`, `getRetryFlag`, `getRetryTime`, `getSendBufferSize`, `getSocketFactory`, `getStreamBufferSizeLimit`, `getStreamCallbackExecutor`, `getStreamListenerQueuesize`, `getTapping`, `getTcpNoDelay`, `getWriteListThreshold`, `init`, `isInitialized`, `isSkipHostPortValidation`, `setAnonymousAuthentication`, `setAsyncReading`, `setBackupAddresses`, `setBindAddress`, `setCallbackExecutor`, `setConnectionName`, `setEstablishers`, and 22 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/internal/MSNetProtocolConnectionConfiguration.java:23
  • `MSNetConnection` declares 46 abstract methods: `addListener`, `asyncSend`, `asyncSend`, `close`, `connect`, `connect`, `connectTime`, `disableReading`, `enableReading`, `getAddress`, `getAuthContext`, `getBackupAddress`, `getInfoMessage`, `getLocalAddress`, `getMaxDisconnects`, `getMaxRetries`, `getMaxRetryTime`, `getName`, `getNetLoop`, `getPrimaryAddress`, `getRetryFlag`, `getRetryTime`, `getState`, `getTapping`, `isConnected`, `isEstablished`, `isReadingEnabled`, `removeListener`, `reparent`, `send`, `send`, `setAddress`, `setBackupAddress`, `setMaxDisconnects`, `setMaxRetries`, `setMaxRetryTime`, `setName`, `setPrimaryAddress`, `setRetryFlag`, `setRetryTime`, and 6 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 46 declarations carry 41 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 41 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetConnection.java:17
  • `MSNetLoopImpl` declares 20 abstract methods: `addLoopListener`, `callbackAfterDelay`, `callbackAfterDelay`, `callbackAt`, `callbackAt`, `callbackPeriodically`, `callbackPeriodically`, `cancelCallback`, `getContinueLoop`, `getLoopErrorHandler`, `isLooping`, `loop`, `quit`, `registerChannel`, `removeLoopListener`, `setCallbackTag`, `setContinueLoop`, `setLoopErrorHandler`, `unregisterChannel`, `wakeup`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 20 declarations carry 17 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 17 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetLoopImpl.java:16
  • `MSNetTCPServer` declares 26 abstract methods: `addEstablisherFactory`, `addListener`, `establisherFactoryIterator`, `getAddress`, `getConnection`, `getName`, `getStateListeners`, `getUserContext`, `getUserContexts`, `hasConnection`, `isListening`, `manageConnection`, `openConnection`, `removeConnection`, `removeEstablisherFactory`, `removeStateListener`, `reparentConnection`, `setAddress`, `setAdminManager`, `setMessageHandler`, `setName`, `setStartupFailurePolicy`, `setStreamHandler`, `start`, `start`, `stop`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 26 declarations carry 25 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 25 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetTCPServer.java:20
  • `LeaderElector` declares 18 abstract methods under just 15 distinct name(s): `abdicate`, `close`, `getCandidates`, `getData`, `getLeaderId`, `getLeaders`, `getListener`, `getMaxLeaders`, `isLeader`, `setData`, `setListener`, `start`, `waitForInitialization`, `waitForInitialization`, `waitForLeaderLoss`, `waitForLeaderLoss`, `waitForLeadership`, `waitForLeadership`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 18 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 18 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/zkapi/leader/LeaderElector.java:19
  • `DHTSession` declares 19 abstract methods under just 14 distinct name(s): `close`, `createNamespace`, `createNamespace`, `deleteNamespace`, `getDefaultGetOptions`, `getDefaultNamespaceOptions`, `getDefaultPutOptions`, `getDefaultWaitOptions`, `getNamespace`, `getNamespaceCreationOptions`, `getServer`, `isServerTraceEnabled`, `openAsyncNamespacePerspective`, `openAsyncNamespacePerspective`, `openAsyncNamespacePerspective`, `openSyncNamespacePerspective`, `openSyncNamespacePerspective`, `openSyncNamespacePerspective`, `recoverNamespace`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 19 separate responsibilities: a caller binds to 14 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 19 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/DHTSession.java:28
  • `Tracer` declares 21 abstract methods: `getStringTraceId`, `issueForwardTraceID`, `onAuthorizationFailure`, `onBothDequeueAndAsyncSendRetrievalResult`, `onBothHandleRetrievalRequest`, `onBothReceiveRequest`, `onForceReap`, `onInternalRetry`, `onKeysReap`, `onLocalEnqueueRetrievalResult`, `onLocalHandleRetrievalRequest`, `onLocalReap`, `onPreambleMismatch`, `onProxyHandleRetrievalResponse`, `onProxyHandleRetrievalResultComplete`, `onProxyHandleRetrievalResultFailed`, `onProxyHandleRetrievalResultIncomplete`, `onQueueLengthInterval`, `onSegmentReap`, `onSegmentRollover`, `setAliasMap`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/trace/Tracer.java:27
  • `TopologyRing` declares 20 abstract methods: `clone`, `cloneEmpty`, `containsNode`, `freeze`, `getMemberNodes`, `getNodeByID`, `getNodeClass`, `getNodeRegions`, `getNodeRegionsFiltered`, `getNodeRegionsSorted`, `getOwnedFraction`, `getOwnedRingspace`, `getStoragePolicyName`, `getTotalWeight`, `getWeight`, `numMemberNodes`, `pointOwnedByNode`, `releaseToNode`, `removeEntry`, `simplify`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/TopologyRing.java:29
  • `Stopwatch` declares 19 abstract methods: `getElapsedMillis`, `getElapsedMillisLong`, `getElapsedNanos`, `getElapsedSeconds`, `getElapsedSecondsBD`, `getName`, `getSplitMillis`, `getSplitMillisLong`, `getSplitNanos`, `getSplitSeconds`, `getSplitSecondsBD`, `getState`, `isRunning`, `isStopped`, `reset`, `start`, `stop`, `toStringElapsed`, `toStringSplit`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/time/Stopwatch.java:31
  • `GraphMBean` declares 40 abstract members: `getConsoleFlag`, `clearCache`, `go`, `profilerResetAll`, `setFlag`, `resetWaits`, `getNativeAllocation`, `getNativeWatermark`, `setNativeWatermark`, `clearAllCaches`, `clearAllCachesWithLocal`, `getSSRoots`, `resetProfileData`, `getProfileData`, `getLiveReaderTaskInfo`, `collectProfile`, `getCache`, `profileCacheMemory`, `profileCacheMemory`, `getSchedulerProfileEntry`, `getStallTimes`, `getMemory`, `saveProfile`, `getInvalidates`, `getTrackingScenarioInfo`, `getWaits`, `showGraphConsole`, `setTraceMode`, `getTraceMode`, `getTrace`, `getSummaryTable`, `gc`, `clearCacheAndTracking`, `resetSStackRoots`, `getFullSchedulerState`, `infoDump`, `asyncProfilerCommand`, `asyncProfilerStart`, `asyncProfilerStop`, `asyncProfilerStatus`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. Those 40 declarations carry 39 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 39 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/platform/projects/core/src/main/scala/optimus/graph/GraphMBean.scala:61
  • `EntityResolver` declares 23 abstract members: `findEntity`, `findEntity$queued`, `findEntity$newNode`, `findEntityOption`, `findEntityOption$queued`, `findEntityOption$newNode`, `findByReference`, `findByReference$queued`, `findByReference$newNode`, `findByIndex`, `findByIndex$queued`, `findByIndex$newNode`, `findByIndexInRange`, `findByIndexInRange$queued`, `findByIndexInRange$newNode`, `findByIndexWithEref`, `findByIndexWithEref$queued`, `findByIndexWithEref$newNode`, `enumerateKeysWithRtt`, `enumerateKeysWithRtt$queued`, `enumerateKeysWithRtt$newNode`, `translateMarkers`, `equivalentTo`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/platform/projects/core/src/main/scala/optimus/platform/dal/EntityResolver.scala:36
  • `PickledPropertiesApi[R]` declares 22 abstract members: `isEmpty`, `hashCode`, `knownSize`, `size`, `contains`, `keys`, `values`, `iterator`, `get`, `apply`, `mapProps`, `map`, `removeAll`, `++`, `remove`, `+`, `+`, `getOrElse`, `isDefinedAt`, `matches`, `keySet`, `asMap`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. Those 22 declarations carry 21 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 21 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/platform/projects/core/src/main/scala/optimus/platform/pickling/PickledProperties.scala:28
  • `RuntimeConfiguration` declares 18 abstract members: `env`, `rootID`, `mode`, `instance`, `specificPropertyMap`, `getProperties`, `getAllProperties`, `getString`, `getInt`, `getBoolean`, `getInstant`, `getStringList`, `getByteVector`, `get`, `getAttributes`, `getStringListWithAttributes`, `withOverride`, `withOverrides`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/platform/projects/core_config/src/main/scala/optimus/config/RuntimeConfiguration.scala:41
  • `TraceableAsyncOp[K, V]` declares 17 abstract members under just 5 distinct name(s): `retrieveWithTrace`, `getWithTrace`, `getWithTrace`, `getWithTrace`, `getWithTrace`, `putWithTrace`, `putWithTrace`, `putWithTrace`, `putWithTrace`, `invalidateWithTrace`, `invalidateWithTrace`, `invalidateWithTrace`, `invalidateWithTrace`, `waitForWithTrace`, `waitForWithTrace`, `waitForWithTrace`, `waitForWithTrace`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 5 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — optimus/platform/projects/dal_core/src/main/scala/optimus/dal/silverking/client/TraceableNamespacePerspective.scala:35
  • `TraceableSyncOp[K, V]` declares 19 abstract members under just 5 distinct name(s): `retrieveWithTrace`, `retrieveWithTrace`, `retrieveWithTrace`, `getWithTrace`, `getWithTrace`, `getWithTrace`, `getWithTrace`, `putWithTrace`, `putWithTrace`, `putWithTrace`, `putWithTrace`, `invalidateWithTrace`, `invalidateWithTrace`, `invalidateWithTrace`, `invalidateWithTrace`, `waitForWithTrace`, `waitForWithTrace`, `waitForWithTrace`, `waitForWithTrace`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 19 separate responsibilities: a caller binds to 5 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 19 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — optimus/platform/projects/dal_core/src/main/scala/optimus/dal/silverking/client/TraceableNamespacePerspective.scala:61
  • `BitemporalSpace[T]` declares 20 abstract members: `latestTxTime`, `all`, `onTxTime`, `beforeTxTime`, `onValidTime`, `onValidInterval`, `adjacentToValidTime`, `at`, `updateInterval`, `insertPoint`, `correctPoint`, `invalidatePoint`, `revertPoint`, `filterCurrentTS`, `map`, `updateMultiple`, `updateIntervals`, `performRawActions`, `execute`, `maxTimeSliceCount`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/bitemporal/BitemporalSpace.scala:21
  • `ZkUtilsProvider` declares 22 abstract members: `getZkEnv`, `getRootContext`, `getRootContext`, `getRootContext`, `getRootContext`, `getRootContextAndEnv`, `getRootContextAndEnv`, `getRootContextForUriAuthority`, `getContextForConfig`, `devContext`, `devContextNoKerberos`, `qaContext`, `qaContextNoKerberos`, `prodContext`, `prodContextNoKerberos`, `prodContextWithoutGuard`, `qaContextWithoutGuard`, `parseInstant`, `parseKnownZkEnv`, `isCloud`, `isEnv`, `isTestMode`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. Those 22 declarations carry 18 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 18 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/platform/projects/dal_environment/src/main/scala/optimus/platform/runtime/ZkUtilsProvider.scala:24
  • `ClassInfo` declares 26 abstract members: `isTrait`, `isAbstract`, `isObject`, `isEvent`, `isEmbeddable`, `isEntity`, `isMeta`, `isEnumeration`, `isJavaEnumeration`, `isOption`, `isKnowable`, `isCollection`, `isMap`, `isKnownNonStorable`, `localName`, `directParents`, `parents`, `selfAndParents`, `children`, `directChildren`, `fields`, `fullName`, `className`, `typeArgs`, `classSymbol`, `piiElements`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/platform/projects/platform/src/main/scala/optimus/platform/util/dalschema/ClassInfo.scala:39
  • `QueryProvider` declares 62 abstract members: `permitTableScan`, `entitledOnly`, `map`, `flatMap`, `filter`, `groupBy`, `groupBy`, `aggregateBy`, `aggregateBy`, `aggregateByUntyped`, `mapValues`, `innerJoin`, `leftOuterJoin`, `rightOuterJoin`, `fullOuterJoin`, `on`, `on`, `onNatural`, `withLeftDefault`, `withRightDefault`, `withLeftDefaultNatural`, `withRightDefaultNatural`, `union`, `merge`, `difference`, `untype`, `extend`, `shapeTo`, `extendTyped`, `extendTypedValue`, `replace`, `replaceValue`, `extendTypedOrReplaceValue`, `sortBy`, `arrange`, `distinct`, `reduce`, `foldLeft`, `aggregate`, `aggregate`, and 22 more. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. Those 62 declarations carry 51 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 51 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/platform/projects/priql/src/main/scala/optimus/platform/QueryProvider.scala:30
  • `Operator[T]` declares 17 abstract members: `ltArray`, `ltSingle`, `gtArray`, `gtSingle`, `eqArray`, `eqSingle`, `plusArray`, `plusSingle`, `minusArray`, `minusSingle`, `mulArray`, `mulSingle`, `divArray`, `divSingle`, `moduloArray`, `moduloSingle`, `generateNewColumnValues`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:829
  • `FieldReader` declares 22 abstract members: `readValue`, `readOptionValue`, `readBoolean`, `readOptionBoolean`, `readByte`, `readOptionByte`, `readChar`, `readOptionChar`, `readShort`, `readOptionShort`, `readInt`, `readOptionInt`, `readLong`, `readOptionLong`, `readFloat`, `readOptionFloat`, `readDouble`, `readOptionDouble`, `readString`, `readOptionString`, `isNone`, `pickledInputStream`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/FieldReader.scala:17

What to do

  • Split fat interfaces into focused role-interfaces so clients depend only on what they use.
  • Where the width is an overload set rather than separate responsibilities, collapse the overloads instead — segregating those relieves no caller.
DM1 · Aggregate boundaries10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether aggregates reference each other by identity (id) rather than by direct object reference — the core DDD consistency-boundary rule.

Method: Roslyn (DDD-gated): aggregate roots identified by convention; each aggregate field checked for direct references to other aggregates versus id-only. Deterministic, DDD-native.

Coverage: Population: aggregate roots identified by AggregateRoot/IAggregateRoot base/interface NAME convention; reference-by-identity then checked exhaustively within that set — a root not using those names is invisible.

DM10 · One transaction, one aggregate10.0 / 10Exemplary○ Nothing flagged

Other · Domain Modelling — Whether a single operation mutates more than one aggregate root. An aggregate is a consistency boundary, so saving two together fuses them into one — the second's invariants come to depend on the first's transaction, and the pair can no longer be separated. Reads of other aggregates are not counted.

Method: Neutral body surface (DDD-gated): every method body scanned for repository WRITE calls (Add/Update/Save/Remove/Delete/Insert/Store and their async forms), keyed on the ARGUMENT type rather than the repository type — three `IRepository<T>` writes collapse to one repository but are three distinct aggregates. Reads (Get/Find/Load/Query) are excluded, so loading another aggregate for context never counts. Score is offending methods over methods that write at all. Deterministic.

DM12 · Ambient inputs in the domain10.0 / 10Exemplary○ Nothing flagged

Other · Domain Modelling — Whether domain types receive the time and randomness their rules depend on, rather than reading the process clock or a global random source directly — an ambient read makes the rule it feeds untestable at the instant that matters and lets two reads inside one operation disagree.

Method: Roslyn (DDD-gated, C#/VB only): domain-layer types scanned for ambient reads — DateTime/DateTimeOffset.Now/UtcNow/Today, Random.Shared, new Random(), Stopwatch.GetTimestamp — resolved against the semantic model, with a comment/string-stripped token fallback only where resolution fails. Body reads are scored; field/property initialisers are surfaced unscored. Apply/When folds excluded (ES1 owns them). Deterministic, symbol-resolved.

DM6 · Domain ↔ infrastructure boundary10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether the domain layer stays free of infrastructure dependencies (EF/Marten/HTTP/ASP.NET) — the clean-architecture dependency rule.

Method: Roslyn (DDD-gated): domain-layer types scanned for infrastructure usage in member SIGNATURES and inside method/accessor BODIES — resolved calls and object-creations into EF/Marten/HTTP/Mongo/Redis/message-bus types (not just a namespace allowlist). Deterministic, symbol-resolved, exhaustive over domain-layer bodies, DDD-native.

Coverage: Domain layer identified by NAMESPACE heuristic; infrastructure then resolved by symbol in member SIGNATURES and method/accessor BODIES — rename the layer and the check evaporates.

DM8 · Value-object opportunities10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether clusters of primitives that travel together (a missing value object) are extracted — a low-weight suggestion, LLM-confirmed when configured.

Method: Roslyn (DDD-gated): primitive parameter clusters recurring three or more times across signatures extracted, then confirmed by language model when configured. Advisory, low-weight.

DM9 · Scattered domain decisions10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether one domain rule is decided — or one measurement produced — in more than one place, rather than living on the type that owns it.

Method: Neutral body surface plus Roslyn (DDD-gated), two arms. DECISION (Roslyn only): a predicate over a domain type's members judged in two or more types, where none of those decisions live on the owning type — operands of comparisons and relational property patterns only, so a member merely passed as an argument is not judged. DERIVATION: a plain all-numeric carrier of ≥2 members, with no base type and exactly one constructor, CONSTRUCTED as the result of a method (returned or assigned, never inline as an argument) in two or more types other than its own — the same measurement produced twice, which centralising the judgement does not fix. DERIVATION runs on every language whose frontend declares the produced-or-passed fact per construction (Roslyn and the Java sidecar today); a target with only the derivation arm carries an engine gap naming the decision arm as not assessed, and a frontend that declares nothing keeps the dimension not measured rather than clean. Single-member rules, test code and generated code are out of population for both. Advisory.

GD1 · Unfinished & placeholder code10.0 / 10Exemplary✓ Tool-verified

Other · Code Health — Unreviewed-generation residue in this repository's Scala: methods whose whole body is still `???` or a "not implemented" throw where nothing overrides them, and placeholder text (lorem ipsum, changeme/replace_me…) left in strings of non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.

Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.

  • `contentHash` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. (×2) — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincVirtualFiles.scala:104, optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincVirtualFiles.scala:115
  • `input` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincVirtualFiles.scala:105
  • `pluginShouldHaveReplacedThis` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — optimus/platform/projects/core/src/main/scala/optimus/core/CoreSupport.scala:28
  • `await` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — optimus/platform/projects/core/src/main/scala/optimus/core/NodeFutureSystem.scala:19
  • `mapperNode` is a shipped member whose whole body is still NotImplementedError, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — optimus/platform/projects/core/src/main/scala/optimus/graph/AsyncPipeline.scala:389
  • `of` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — optimus/platform/projects/priql/src/main/scala/optimus/platform/RelationKeys.scala:273
  • `extractSignature` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — optimus/platform/projects/talks/src/main/scala/scala/days/live/ScalaDaysDemo.scala:56
  • `doCompile` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface. — optimus/platform/projects/talks/src/main/scala/scala/days/live/ScalaDaysDemo.scala:57

What to do

  • Finish or delete the members whose body is still `???` or a "not implemented" throw where nothing overrides them, and replace placeholder text before shipping.
IC1 · Incompleteness & stubs7.2 / 10Strong✓ Tool-verified

Other · Code Health — Unfinished work detected by code SHAPE, not keywords, in this repository's Scala: methods whose body is `???` or only throws a "not implemented" error, methods that take inputs and return a constant or do nothing, dead `if (false)` branches, and skeleton classes most of whose methods are holes.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

  • `contentHash` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincVirtualFiles.scala:104, optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincVirtualFiles.scala:115
  • `input` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincVirtualFiles.scala:105
  • `initAuth` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/auth/CrumbsAuthProvider.scala:23
  • `pluginShouldHaveReplacedThis` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — optimus/platform/projects/core/src/main/scala/optimus/core/CoreSupport.scala:28
  • `await` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — optimus/platform/projects/core/src/main/scala/optimus/core/NodeFutureSystem.scala:19
  • `mapperNode` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — optimus/platform/projects/core/src/main/scala/optimus/graph/AsyncPipeline.scala:389
  • `report` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/GraphDiagnostics.scala:49
  • `apply` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:385
  • `push` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — optimus/platform/projects/platform/src/main/scala/optimus/platform/ReplDsl.scala:46
  • `of` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — optimus/platform/projects/priql/src/main/scala/optimus/platform/RelationKeys.scala:273
  • `extractSignature` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — optimus/platform/projects/talks/src/main/scala/scala/days/live/ScalaDaysDemo.scala:56
  • `doCompile` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface. — optimus/platform/projects/talks/src/main/scala/scala/days/live/ScalaDaysDemo.scala:57
  • `await` has an empty body — confirm it's an intentional no-op and not an unfinished method. — optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/GraphDiagnostics.scala:51
  • `ensureLoadedIfEnabled` has an empty body — confirm it's an intentional no-op and not an unfinished method. — optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/sampling/SamplingProfiler.scala:590
  • `setup` has an empty body — confirm it's an intentional no-op and not an unfinished method. — optimus/platform/projects/platform/src/main/scala/optimus/platform/OptimusApp.scala:683

What to do

  • Finish or delete the unfinished stubs (functions that throw "not implemented", or whose body is empty or a bare constant) — they are dead surface that looks live.
  • Clear the softer debt: re-enable or delete `ignore`d and `pending` tests, decide whether each empty method or UnsupportedOperationException is deliberate (and say so in a comment), and replace a bare `// scalastyle:off` or `@nowarn` with targeted, justified suppressions.
M1 · Documentation (README)6.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
  • Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
M2 · Architecture documentation0.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
  • No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
  • Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
M3 · Folder & project structure8.0 / 10Strong✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

  • Production code isn't grouped under a src/ folder — it all sits under optimus/, so the conventional src/ boundary between the product and its tooling isn't drawn.

What to do

  • Group production code under src/ (or split deliberately, e.g. backend/ + frontend/) so production and tooling code aren't mixed at the root.
M4 · Documentation accuracy10.0 / 10Exemplary◐ Sampled · advisory

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

P1 · CI/CD gates0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

  • No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, …) — changes aren't gated by an automated build/test.

What to do

  • Add a CI workflow that builds and runs the test suite on every push/PR.
P2 · Observability10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add scalafix or scapegoat (or `semgrep --config=auto`, which runs on any language) — this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.

What to do

  • Run what this repository's stack ships: scalafix or scapegoat — or `semgrep --config=auto`, which runs on any language — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
PF2 · Allocation hygiene6.8 / 10Adequate✓ Tool-verified

Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.

Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — in .NET Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit; off .NET, with comments and strings blanked, Go's sync.Pool, preallocated slices/maps, Grow, strconv.Append* and buf[:0] reuse; the JVM's NIO buffer views, MemorySegment, primitive collections, pools and literal presizes (plus Kotlin primitive arrays and value classes, Scala AnyVal and @specialized); Swift's reserveCapacity, ContiguousArray, withUnsafe* access and ~Copyable. Activated off .NET on the same floor (400 lines, and benchmarks or 8 uses); Rust and garbage-collected scripting languages are not applicable. Reward-only. Deterministic, syntax/text detection.

What to do

  • Raise allocation-aware density on the hot paths — currently 965 use(s) across 572,309 production line(s) (~1.7/1k). More of the idioms below on the allocation-heavy paths climbs this toward 10.
  • Java: on hot paths, work through buffer views (ByteBuffer/LongBuffer slices, MemorySegment) instead of copies, avoid boxing with primitive collections (fastutil, Eclipse Collections, HPPC, Trove), presize collections and StringBuilders, and pool expensive buffers (Netty's pooled allocator, commons-pool).
  • Scala: on hot paths, make small wrappers value classes (extends AnyVal), @specialized generic code over primitives, use primitive collections, and presize builders.
PF3 · Async & latency hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

S1 · Web-Security Posture8.0 / 10Strong✓ Tool-verified

Other · Security — Read from this repository's Scala source and the Java beside it: cryptographic hygiene (weak hash or cipher, key material fixed in the source) and outbound TLS (certificate validation, protocol version) — facts about code that hold whether or not it serves anything itself. This repository serves no HTTP of its own — no HTTP-server artifact (akka-http, pekko-http, http4s, Play, Finagle, zio-http, cask, Scalatra, a tapir server, Jetty, Undertow, …) outside test scope in its build, and no server package imported or server bound in its production source — so HTTPS enforcement, HSTS, cookie flags and input validation are N/A here, as they are for a C# library or worker.

Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.

  • MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`MessageDigest.getInstance("SHA-256")`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call. (×9) — optimus/platform/projects/core/src/main/scala/msjava/MSUuidGenerator.scala:36, optimus/platform/projects/dal_client/src/main/scala/optimus/session/utils/ClientEnvironment.scala:127, optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:490, …

What to do

  • Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (xxhash, murmurhash) where it only derives an identifier such as a cache key. This repository constructs a collision-broken hash (MD5/SHA1) at 9 sites, not one: `optimus/platform/projects/core/src/main/scala/msjava/MSUuidGenerator.scala:36` (MessageDigest.getInstance("SHA-1")), `optimus/platform/projects/dal_client/src/main/scala/optimus/session/utils/ClientEnvironment.scala:127` (MessageDigest.getInstance("SHA-1")), `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:490` (MessageDigest.getInstance("SHA-1")), `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:456` (MessageDigest.getInstance("SHA-1")), `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMProxyGenerator.scala:610` (MessageDigest.getInstance("SHA-1")), `optimus/platform/projects/utils/src/main/scala/optimus/utils/HashUtil.scala:22` (MessageDigest.getInstance("SHA-1")), `REDACTED:37` (MessageDigest.getInstance("MD5")), `REDACTED:30` (MessageDigest.getInstance("SHA-1")), and 1 further site(s). Each is a separate decision — fixing only the line this row cites leaves the others in place.
X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

X14 · Bypassable address classification10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.

Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.

X15 · Unvalidated length from an untrusted reader2.7 / 10Weak✓ Tool-verified

Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.

Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.

  • `entryLength` is read from the bytes being parsed at line 378 (`readInt`), then used to size an `Array.ofDim` at line 379 — and nowhere in its scope is `entryLength` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `entryLength` against the bytes actually remaining and a maximum the format allows before allocating. — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dal/DALCache.scala:379
  • `length` is read from the bytes being parsed at line 306 (`getInt`), then used to size a `new byte[]` at line 311 — and nowhere in its scope is `length` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `length` against the bytes actually remaining and a maximum the format allows before allocating. — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoPutMessageGroup.java:311

What to do

  • Each finding names the read that takes the length from the input and the site that spends it, and states that the value is never compared in between. Confirm from the two, then bound the length against the remaining stream before using it.
X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X17 · Uncapped recursion over a caller-supplied document3.5 / 10Weak✓ Tool-verified

Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.

Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.

  • `EventCauseJsonProtocol.read` is public and takes `value: JsValue` from its caller, and it calls itself at line 422 with a piece of `value`, not as a tail call the compiler turns into a loop — and nowhere in `EventCauseJsonProtocol.read` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. On the JVM's default 1 MB thread stack a walk like this one throws `StackOverflowError` from about 500–2,000 levels on a cold first call and 6,000–17,000 once warmed up (OpenJDK 21 and 25), while `ujson.read`, Jackson's `readTree` before 2.15 and circe before 0.14.16 accept any nesting (2,000,000 levels from 4 MB) and circe 0.14.16 accepts 4,096 — on a cold JVM even play-json's cap of 1,000 is past the point the walk fails. `StackOverflowError` is not `NonFatal`: `Try`, `case NonFatal(e)` and `recover` do not stop it, and in a `Future` on the global execution context it leaves the future forever incomplete. Thread a depth argument through `EventCauseJsonProtocol.read` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/crumbs/Properties.scala:422

What to do

  • Each finding names the externally-callable member that accepts the document and the self-call that descends, and states that no depth parameter or counter exists anywhere in the walk. Confirm from the two, then thread a depth argument through the walk and reject documents past a fixed maximum, or rewrite it with an explicit stack.
X18 · Disposal-pattern correctness5.3 / 10Adequate✓ Tool-verified

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

  • `Files.list(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.iterator` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Files.list(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`. (×6) — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/postbuilders/installer/component/fingerprintdiffing/BuildArtifactComparatorApp.scala:60, optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/oci/ImageBuilder.scala:865, optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/rubbish/ArtifactRecency.scala:163, …
  • `Files.walk(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.iterator` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Files.walk(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`. (×3) — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/rubbish/RubbishTidyer.scala:53, optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/heartbeat/WatcherProcess.scala:327, optimus/platform/projects/utils/src/main/scala/optimus/utils/FileUtils.scala:174
  • `Files.find(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.iterator` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Files.find(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`. — optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/files/InstallPathBuilder.scala:381
  • `Files.walk(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and it is held in `stream`, and every later use of `stream` in its block reads a member through it — it is never returned, passed, stored, captured by a lambda, reassigned or released, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Files.walk(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`. — optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/kafka/PlexCleaner.scala:213
  • `new JarFile(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and it is held in `jar`, and every later use of `jar` in its block reads a member through it — it is never returned, passed, stored, captured by a lambda, reassigned or released, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(new JarFile(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`. — optimus/platform/projects/utils/src/main/scala/optimus/platform/utils/ClassPathUtils.scala:127

What to do

  • Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
X19 · Unrestored process-global state10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

X20 · Mistyped argument guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `NullPointerException` (Java, Kotlin, Scala), `ArgumentError.notNull` (Dart) or `ArgumentNullException` (F#'s `nullArg`) tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X22 · Contradicted release guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.

Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation7.8 / 10Strong✓ Tool-verified

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

  • `debug` at line 410 is called with an argument built by `parts.map(_.toString).mkString("…")` (line 410), whose cost grows with the collection it walks. Scala evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: the logger takes a built `String` (SLF4J, Akka/Pekko `LoggingAdapter`, `context.log`), and there is no `isDebugEnabled`/`isTraceEnabled` test and no debug flag. — optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/files/InstallPathBuilder.scala:410
  • `debug` at line 419 is called with an argument built by `parts.mkString("…")` (line 420), whose cost grows with the collection it walks. Scala evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: the logger takes a built `String` (SLF4J, Akka/Pekko `LoggingAdapter`, `context.log`), and there is no `isDebugEnabled`/`isTraceEnabled` test and no debug flag. — optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/files/InstallPathBuilder.scala:419
  • `debug` at line 610 is called with an argument built by `Thread.currentThread.getStackTrace.toSeq.mkString("…")` (line 610), whose cost grows with the collection it walks. Scala evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: the logger takes a built `String` (SLF4J, Akka/Pekko `LoggingAdapter`, `context.log`), and there is no `isDebugEnabled`/`isTraceEnabled` test and no debug flag. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:610
  • `debug` at line 503 is called with an argument built by `destinations.mkString("…")` (line 503), whose cost grows with the collection it walks. Scala evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: the logger takes a built `String` (SLF4J, Akka/Pekko `LoggingAdapter`, `context.log`), and there is no `isDebugEnabled`/`isTraceEnabled` test and no debug flag. — optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/sampling/SamplingProfiler.scala:503

What to do

  • In Scala, put the construction behind the logger's own check (`if (log.isDebugEnabled)`), or log through a logger that takes the message by name or by macro and so builds it only when the level is on — scala-logging's `LazyLogging`/`StrictLogging` (`logger.debug(s"rows: ${rows.mkString(", ")}")` expands to that check), log4s or log4cats. Interpolating into an `s"…"` is not the fix on SLF4J or Akka's `LoggingAdapter`: their `debug` takes a `String`, so the interpolation and every `mkString` inside it run before the call is entered.
X24 · Document value interpolated into markup unescaped5.1 / 10Adequate✓ Tool-verified

Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.

Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.

  • `g.title` is text this program did not author, and it is written into the text of an element through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:44
  • `html` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. (×3) — optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:51, optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:245, optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:276
  • `title` is text this program did not author, and it is written into an unquoted attribute through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. HTML text encoding does not help in an unquoted attribute — whitespace ends it; quote the attribute and encode the value. (×3) — optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:66, optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:83, optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:214
  • `btnId` is text this program did not author, and it is written into a quoted attribute value through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. (×3) — optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:67, optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:184, optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:215
  • `rowId` is text this program did not author, and it is written into a script or style context through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. A script or style context needs its own escaping (or a JSON serialiser that escapes `<`); better, pass the value through a data attribute. (×3) — optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:68, optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:185, optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:216
  • `linkId` is text this program did not author, and it is written into a quoted attribute value through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:70
  • `e.module` is text this program did not author, and it is written into the text of an element through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:72
  • `topDisplayFrame` is text this program did not author, and it is written into the text of an element through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:73
  • `rowId` is text this program did not author, and it is written into a quoted attribute value through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. (×3) — optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:76, optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:193, optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:223
  • `desc[idx]` is text this program did not author, and it is written into the text of an element through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. (×2) — optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:79, optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:226
  • `violation.owner` is text this program did not author, and it is written into the text of an element through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. (×2) — optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:188, optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:219
  • `violation.frame` is text this program did not author, and it is written into the text of an element through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. (×2) — optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:189, optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:220
  • `inner_tbodyId` is text this program did not author, and it is written into a quoted attribute value through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:196
  • `owner` is text this program did not author, and it is written into a quoted attribute value through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup. — optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:240

What to do

  • Each finding names the expression, the attribute it lands in and the line. Confirm the value's origin from the read this analyzer traced, then escape it at the sink or validate it against the shape the attribute accepts before interpolating.
X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X26 · Unsynchronised callback handoff10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.

Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated8.0 / 10Strong✓ Tool-verified

Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen. Whether a `for` comprehension or `foreach` leaves the mutable collection it is walking alone — an `ArrayBuffer` or `ListBuffer` counts its changes and its iterator checks the count, an `ArrayDeque` (and `mutable.Queue`/`mutable.Stack`) is walked by index up to its starting length, and a `java.util` collection walked through `asScala` is fail-fast, so a body that adds to or removes from the very collection the loop is walking makes a later step throw `ConcurrentModificationException` (`IndexOutOfBoundsException` for a deque) and the remaining elements are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

  • `this.threads` is enumerated directly, and line 542 calls `this.threads.add(…)` inside the loop body — a structural change to a `ArrayList`. The loop's hidden iterator is fail-fast, so its next `next()` throws `ConcurrentModificationException`: every pass that reaches this call ends the loop by exception instead of by running out of elements, and the remaining elements are never seen. — optimus/platform/projects/core/src/main/scala/optimus/graph/OGTraceReader.java:541

What to do

  • Each finding names the two spans that cannot both stand — the enhanced `for` source, and the call inside the body that structurally changes that same collection. Confirm from those two, then pick one: remove through the iterator itself (`Iterator<T> it = c.iterator(); … it.remove();`) or replace the loop with `c.removeIf(…)`; iterate a copy (`for (T x : new ArrayList<>(c))`); collect what needs changing and apply it after the loop; or — where the loop was only ever meant to act on the first match — `break` immediately after the mutation, which is the one shape that is already safe. In Scala: Each finding names the two lines that cannot both stand — the loop over the collection, and the call inside its body that changes it. Confirm from those two, then pick one: change the collection in one call instead of in the loop (`b.filterInPlace(keep)`, `b --= toRemove`); walk a snapshot (`for (x <- b.toList)`, `b.clone().foreach`); build a new collection (`val kept = b.filter(keep)`) instead of editing the one being walked; or — where only the first match was ever meant — leave the walk straight after the change (`boundary.break()`, `return`), which is the one shape that is already safe.
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

X3 · Exception handling7.0 / 10Adequate✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • `case NonFatal(_)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×7) — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/bsp/BSPTraceListener.scala:294, optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincCompilerFactory.scala:121, optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/crumbs/Properties.scala:596, …
  • `case NonFatal(e)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ResolverDefinition.scala:95
  • `case _: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×7) — optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/compile/ExternalCache.scala:70, optimus/platform/projects/core/src/main/scala/optimus/graph/TweakTargetImpl.scala:53, optimus/platform/projects/core/src/main/scala/optimus/graph/TweakTargetImpl.scala:86, …
  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×9) — optimus/platform/projects/core/src/main/scala/optimus/graph/OGSchedulerContext.java:900, optimus/platform/projects/core/src/main/scala/optimus/graph/ScenarioStackShared.scala:178, optimus/platform/projects/core/src/main/scala/optimus/platform/util/DiagnosticUtil.scala:51, …
  • `case _: Throwable` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×9) — optimus/platform/projects/core/src/main/scala/optimus/graph/GraphEvents.scala:40, optimus/platform/projects/core/src/main/scala/optimus/platform/relational/tree/TypeInfo.scala:314, optimus/platform/projects/core/src/main/scala/optimus/platform/stats/AppStatsControl.scala:181, …
  • `case ex: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×2) — optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:212, optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:218
  • `case NonFatal(ex)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dsi/protobufutils/DALProtoClient.scala:66
  • `catch (Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — optimus/platform/projects/entityagent/src/main/java/optimus/ClassMonitorInjector.java:222
  • `case t: Throwable` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×3) — optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/EntityPlugin.scala:49, optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:523, optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/AsyncProfilerIntegration.scala:506

What to do

  • Swallowed exception (caught, then discarded)
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X4 · Structured logging5.4 / 10Adequate✓ Tool-verified

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

  • `warn` at line 64 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/oci/ImageBuilderDelegate.scala:64
  • `error` at line 89 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/resolvers/WebDependencyResolver.scala:89
  • `warn` at line 339 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ScopeDefinitionCompiler.scala:339
  • `info` at line 27 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/DiagnosticApp.scala:27
  • `info` at line 39 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/DiagnosticApp.scala:39
  • `error` at line 135 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/ChainedID.scala:135
  • `debug` at line 138 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:138
  • `warn` at line 166 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:166
  • `debug` at line 247 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:247
  • `debug` at line 269 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:269
  • `debug` at line 317 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:317
  • `info` at line 332 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:332
  • `info` at line 444 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:444
  • `debug` at line 527 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:527
  • `warn` at line 599 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:599
  • `debug` at line 610 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:610
  • `debug` at line 626 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:626
  • `info` at line 710 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:710
  • `debug` at line 731 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:731
  • `debug` at line 738 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:738
  • `debug` at line 760 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:760
  • `info` at line 772 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:772
  • `info` at line 777 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:777
  • `info` at line 799 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:799
  • `warn` at line 984 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:984
  • `warn` at line 985 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:985
  • `trace` at line 993 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.trace("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:993
  • `info` at line 1034 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:1034
  • `warn` at line 1082 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:1082
  • `warn` at line 1085 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:1085
  • `info` at line 1095 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:1095
  • `info` at line 1119 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:1119
  • `debug` at line 1136 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:1136
  • `info` at line 1147 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:1147
  • `info` at line 1152 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:1152
  • `warn` at line 22 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/crumbs/CrumbValidator.scala:22
  • `info` at line 58 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/filter/Filters.scala:58
  • `info` at line 63 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/filter/Filters.scala:63
  • `info` at line 69 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/filter/Filters.scala:69
  • `info` at line 78 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix. — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/filter/Filters.scala:78

What to do

  • Interpolated log message defeats structured logging
X5 · Nullable reference types2.0 / 10Critical✓ Tool-verified

Other · Code Health — Whether Scala's null is held to the type system and not undermined by assertions — a file compiled with `-Yexplicit-nulls` is one where `String` excludes null and `String | Null` admits it, a file under WartRemover's `Null` wart or Scalafix's `DisableSyntax.noNulls` is one whose code cannot write `null` and must say `Option`, and each `.nn`, `import scala.language.unsafeNulls` or null-lint suppression is the author overruling that.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • No build over this repository's 2252 Scala product file(s) passes `-Yexplicit-nulls`, enables WartRemover's `Null` wart or runs Scalafix's `DisableSyntax.noNulls`, so every reference type admits null and nothing reports a `null` written into the code or returned from a Java API — the first one to reach a method call is a `NullPointerException`. `Option` by convention is a habit no tool here holds the code to.

What to do

  • On Scala 3, add `-Yexplicit-nulls` to `scalacOptions` so `String` and `String | Null` mean different things, and type each Java API's result as nullable where it can return null; on Scala 2 (or as a first step), enable WartRemover's `Null` wart (`wartremoverErrors += Wart.Null`) or Scalafix's `DisableSyntax.noNulls = true` so the code holds absence in `Option`. Then pay the assertions down rather than adding to them: each `.nn` is a null the compiler could not rule out — wrap the Java value in `Option(…)` at the boundary, pattern-match on `null` once there, or change the API so the null cannot arrive; an `unsafeNulls` import switches the checking off for everything after it.

WCAG coverage — what static analysis assessed

Statically assessed 10 of 55 WCAG 2.2 Level A/AA success criteria (18%; ≈20% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 45 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).

DimensionWCAG 2.2 A/AA criteriaCoverage
AC2 · Forms & labels1.3.1, 3.3.2, 4.1.2Partial signal
AC3 · Page structure1.4.4, 2.2.1, 2.4.1, 2.4.2, 3.1.1, 4.1.2Partial signal
AC5 · ARIA correctness4.1.2Partial signal
AC6 · Visual & motion safety1.4.3, 2.4.7Partial — literal CSS only
AC7 · A11y enforcementenforcement — no page criterionEnforcement posture (process)

Not statically assessed — these 45 Level A/AA criteria need runtime or manual evaluation (WCAG-EM): 1.1.1, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.4.1, 1.4.2, 1.4.5, 1.4.10, 1.4.11, 1.4.12, 1.4.13, 2.1.1, 2.1.2, 2.1.4, 2.2.2, 2.3.1, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.11, 2.5.1, 2.5.2, 2.5.3, 2.5.4, 2.5.7, 2.5.8, 3.1.2, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.6, 3.3.1, 3.3.3, 3.3.4, 3.3.7, 3.3.8, 4.1.3.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health56%Adequate — gated by X5Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Architecture90%Adequate — gated by D26Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Maturity48%Weak — gated by M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness43%Weak — gated by P1, P3Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security69%Adequate — gated by D29Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Domain Modelling100%ExemplaryStrongest area.
Accessibility57%AdequateAcceptable, with room to improve.
Performance82%StrongSolid.
Unscored — 2 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • X10 Duplicated predicate — 25 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X7 Silent fallback defaults — 8 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 3 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • P4 Deployment & Rollback — not evidenced — no deploy/rollback/approval signal in the repo; absence of evidence is not evidence of a manual release
  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
  • P6 Release Hygiene — not evidenced — no changelog, version stamp or semver release tag in the repo
Not included — 57 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No image/media element found in the parsed markup — AC1 not applicable here.
  • AC4 Keyboard semantics — No interactive element found in the parsed markup — AC4 not applicable here.
  • AX1 Captive dependencies — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — no test/production split to check
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB1 Runtime evidence locked — no reproducible boot — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C3 Audit Trail — No personal data detected in a persisted data model — no PII-named column (email, first_name, date_of_birth, phone_number, …) or stored credential on a Slick table or in a SQL migration's CREATE TABLE or ALTER TABLE — and no database client (Slick, Doobie, Quill, ScalikeJDBC, Anorm, Skunk, a MongoDB or Cassandra driver, JDBC) imported either, so this repository keeps no sensitive data whose changes an audit trail would record. If it does (through a store configured outside this repository, for instance), the trail belongs to wherever that data is stored.
  • C4 Data Retention — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Slick table or in a SQL migration's CREATE TABLE or ALTER TABLE — and no database or data-store client (Slick, Doobie, Quill, ScalikeJDBC, Anorm, Skunk, JDBC, MongoDB, Cassandra, …) imported either, so this repository keeps no personal data whose lifetime a retention limit would bound.
  • C5 Data-Subject Rights — No personal data detected in a persisted data model — no PII-named field (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a Slick table or in a SQL migration's CREATE TABLE or ALTER TABLE — and no database or data-store client (Slick, Doobie, Quill, ScalikeJDBC, Anorm, Skunk, JDBC, MongoDB, Cassandra, …) imported either, so this repository keeps no personal data for a data subject to erase, export or consent over.
  • D10 Test Quality — ~3649 lines of test source are present (.scala) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D11 Test Reliability — Test reliability not included — no .scala test runner
  • D12 Dependency Hygiene — Dependency hygiene not measured — no supported dependency manifest was read
  • D14 License Compliance — No dependency manifest found — no declared dependency closure to grade for licences
  • D16 Bus Factor — single-maintainer repository — bus factor is not applicable
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D20 ADR Quality — Repository kind not determined
  • D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
  • D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ projects each declaring an entity of their own. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — No inline comments to assess — comment value is not applicable here.
  • D25 ADR Conformance — no ADRs to check
  • D27 Navigability — D27 counts a call into the standard library or a dependency as unresolved for this repository's language (.scala), so too few call sites counted as resolved to assess navigability. Not scored: this is a gap in the analyzer, not a verdict about this repository.
  • D30 Dependency Vulnerabilities — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — 31 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D34 Knowledge Freshness — history too condensed to judge knowledge freshness
  • D36 Supply-chain Provenance & Signing — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .circleci, .buildkite, .woodpecker, .teamcity, .gitlab-ci.yml, .travis.yml, bitbucket-pipelines.yml, .drone.yml, .cirrus.yml, .woodpecker.yml, appveyor.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, .azuredevops/, Jenkinsfile); there is no build to attest provenance for.
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D43 Malicious Dependencies — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).
  • D44 Platform End-of-Life — Platform end-of-life not assessed — this repository declares no platform this pass reads
  • D5 Coupling — Not applicable — no manifest declares this repository's modules, and its source holds 1 production component(s), so there is no coupling BETWEEN modules to measure. (Its test and non-production components are not part of the shipped graph.)
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • DM11 Constructible invalid state — no entities detected — construction-time invariants not assessable
  • DM2 Strongly-typed ids — no id-bearing domain types detected — strongly-typed-id adoption not assessable
  • DM3 Integration-event coupling — no integration events detected — coupling check not applicable
  • DM4 Rich vs anemic model — no data-bearing entities detected — rich-vs-anemic model not assessable
  • DM5 Encapsulated state — no domain entities found — DM5 grades how entities protect their state, and this repository declares none
  • DM7 Repository granularity — no repository abstraction detected (e.g. uses a document session)
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • P12 CI test-gate honesty — no CI workflow found
  • P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the JVM, JavaScript/TypeScript source, so there is no service whose uptime a failing dependency could take down
  • P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
  • P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (`addSbtPlugin("org.scoverage" % "sbt-scoverage" % "<version>")` in `project/plugins.sbt`, then `sbt clean coverage test coverageReport`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
  • PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a pom.xml, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
  • X2 Cancellation propagation — no C# was loaded; this repository's Scala and Java were read, and no request in it can be cancelled by a caller — a Scala request takes no token: a Future cannot be cancelled, and cats-effect, ZIO and Monix interrupt the fiber that made the request from outside the call, not through a parameter; a Java request off Android takes no token: it is cancelled through the handle it returns (Future.cancel, Call.cancel, a Disposable), ambiently (io.grpc.Context) or by interrupting its thread, not through a parameter
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 7 finding(s)
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
AC3 · Page structure · <html> without a lang · ×1
  • <html> without a lang optimus/platform/projects/core/src/main/resources/html/gridprofiler.html:1 — The page declares no language, so assistive tech can't pick the right pronunciation. Add lang (e.g. lang="en").
Serious — 2185 finding(s)
D17 · Explicit Debt · TodoComment · ×511
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/app/OptimusBuildToolCmdLine.scala:795 — // TODO (OPTIMUS-56087) rename Overlord references
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/app/OptimusBuildToolCmdLine.scala:818 — // TODO (OPTIMUS-56086) rename Train references
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/bsp/StructureBuilder.scala:53 — // TODO (OPTIMUS-47169): to be really efficient we could write to a custom output stream which hashes the bytes as they arrive and then throws them away
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/bsp/BuildServerProtocolService.scala:431 — // TODO (OPTIMUS-61422): apply interpreter options
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/bsp/BspSyncer.scala:226 — // TODO (OPTIMUS-61423): Implement the classpath logic from scalacOptions() for pythonpaths
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/bsp/BspSyncer.scala:231 — // TODO (OPTIMUS-61422): replace Nil with interpreter options if we have any, from structure.resolvedScope
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/postbuilders/installer/component/TestplanInstaller.scala:387 — // TODO (OPTIMUS-79609): make fatal
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/postbuilders/installer/component/BundleRunConfsInstaller.scala:137 — // TODO (OPTIMUS-39958): this sorting by mtime fails to take reuse into account
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/postbuilders/installer/component/testplans/Changes.scala:50 — // TODO (OPTIMUS-70267): Rework this as part of restructuring contract testing logic
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/postinstallers/apprunner/PostInstallAppRunner.scala:40 — // TODO (OPTIMUS-65156): Remove when elf parsing issues are understood.
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/cache/dht/AsyncGraphLargeValueClient.scala:79 — // TODO (OPTIMUS-66613) implement retry logic
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/RegexScanner.scala:85 — // TODO (OPTIMUS-42169): this probably could be made faster / less memory-intensive by running the regexen
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincVirtualFiles.scala:160 — // TODO (OPTIMUS-38945): We should use OBT's artifact hashes here.
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/setup/ObtProgressReporter.scala:60 — // TODO (OPTIMUS-45208): Remove this once Global.Run.compileFiles is changed
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/generators/PodcastGenerator.scala:94 — // TODO (OPTIMUS-77939) read the config value for the source set name here,
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/generators/PodcastGenerator.scala:125 — // TODO (OPTIMUS-77939): get schema from config
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/generators/AnyBufGenerator.scala:166 — // TODO (OPTIMUS-79166): Remove `allowEmpty = true` once we have a better solution for
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/generators/sandboxed/SandboxedInputsImpl.scala:136 — // TODO (OPTIMUS-79166): Remove `allowEmpty = true` once we have a better solution for
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/oci/ImageBuilder.scala:405 — // TODO (OPTIMUS-30564): sort by rough topological order?
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/scope/CompilationScope.scala:249 — // TODO (OPTIMUS-25547): Remove this distinctLast when we understand the
  • TodoComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/scope/sources/RunconfCompilationSources.scala:319 — // TODO (OPTIMUS-37134): a test that this picks up all that is needed
  • TodoComment optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/config/NamingConventions.scala:73 — // TODO (OPTIMUS-58921): remove this hardcoded string root once we removed duplications from optimus/artifactory-deps
  • TodoComment optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/config/DependencyDefinition.scala:237 — // TODO (OPTIMUS-37398): this will likely be desirous of includes/excludes and such
  • TodoComment optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/config/CopyFilesConfiguration.scala:54 — // TODO (OPTIMUS-35296): the install version should really come from the OBT file!
  • TodoComment optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ScopeDefinitionCompiler.scala:393 — // TODO (OPTIMUS-58917): clean up special case that allow maven release frontier depends on mavenOnly modules
  • + 486 more in this group — see findings.md.
D3 · God Classes · TooManyMethods · ×94
  • TooManyMethods: Tracer optimus/platform/projects/dal_core/src/main/scala/optimus/dsi/trace/Tracer.scala:50 — TooManyMethods — 176 methods. The bar is 30 methods; this is 146 over it, 5.87× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: AdvancedUtils optimus/platform/projects/core/src/main/scala/optimus/platform/AdvancedUtils.scala:75 — TooManyMethods — 136 methods. The bar is 30 methods; this is 106 over it, 4.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GridProfiler optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfiler.scala:114 — TooManyMethods — 112 methods. The bar is 30 methods; this is 82 over it, 3.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: TypedUtils optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/TypedUtils.scala:160 — TooManyMethods — 96 methods. The bar is 30 methods; this is 66 over it, 3.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: AsyncBase optimus/platform/projects/core/src/main/scala/optimus/platform/Async.scala:206 — TooManyMethods — 94 methods. The bar is 30 methods; this is 64 over it, 3.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: CoreAPI optimus/platform/projects/core/src/main/scala/optimus/core/CoreAPI.scala:163 — TooManyMethods — 84 methods. The bar is 30 methods; this is 54 over it, 2.80× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: UntypedUtils optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/UntypedUtils.scala:22 — TooManyMethods — 82 methods. The bar is 30 methods; this is 52 over it, 2.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: EntityResolverReadImpl optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/EntityResolverReadImpl.scala:190 — TooManyMethods — 78 methods. The bar is 30 methods; this is 48 over it, 2.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: OptimusBuildToolImpl optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/app/OptimusBuildToolImpl.scala:149 — TooManyMethods — 72 methods. The bar is 30 methods; this is 42 over it, 2.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: SilverKingZooKeeperClient optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/zookeeper/SilverKingZooKeeperClient.java:50 — TooManyMethods — 66 methods. The bar is 30 methods; this is 36 over it, 2.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: DefaultQueryProvider optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/DefaultQueryProvider.scala:26 — TooManyMethods — 64 methods. The bar is 30 methods; this is 34 over it, 2.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: AppStats optimus/platform/projects/core/src/main/scala/optimus/platform/stats/AppStats.scala:104 — TooManyMethods — 61 methods. The bar is 30 methods; this is 31 over it, 2.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PluginUtils optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/PluginUtils.scala:25 — TooManyMethods — 56 methods. The bar is 30 methods; this is 26 over it, 1.87× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: NPTable optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NPTable.scala:58 — TooManyMethods — 55 methods. The bar is 30 methods; this is 25 over it, 1.83× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: EvaluationContext optimus/platform/projects/core/src/main/scala/optimus/platform/EvaluationContext.scala:29 — TooManyMethods — 53 methods. The bar is 30 methods; this is 23 over it, 1.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: RingRegion optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/ring/RingRegion.java:26 — TooManyMethods — 53 methods. The bar is 30 methods; this is 23 over it, 1.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Utils optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/utils/Utils.scala:66 — TooManyMethods — 52 methods. The bar is 30 methods; this is 22 over it, 1.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: DebuggerUI optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/DebuggerUI.scala:48 — TooManyMethods — 52 methods. The bar is 30 methods; this is 22 over it, 1.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: BigDecimal optimus/platform/projects/scala_compat/src/main/scala-2.13/scala/math/BigDecimal.scala:394 — TooManyMethods — 52 methods. The bar is 30 methods; this is 22 over it, 1.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Utils optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:29 — TooManyMethods — 51 methods. The bar is 30 methods; this is 21 over it, 1.70× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: InstrumentationConfig optimus/platform/projects/entityagent/src/main/java/optimus/debug/InstrumentationConfig.java:37 — TooManyMethods — 50 methods. The bar is 30 methods; this is 20 over it, 1.67× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: RingEntry optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingEntry.java:37 — TooManyMethods — 49 methods. The bar is 30 methods; this is 19 over it, 1.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: InstrumentationCmds optimus/platform/projects/entityagent/src/main/java/optimus/debug/InstrumentationCmds.java:39 — TooManyMethods — 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Breadcrumbs optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:144 — TooManyMethods — 47 methods. The bar is 30 methods; this is 17 over it, 1.57× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: NodeTimeLine optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeTimeLine.scala:127 — TooManyMethods — 47 methods. The bar is 30 methods; this is 17 over it, 1.57× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • + 69 more in this group — see findings.md.
D3 · God Classes · FileTooLong · ×79
  • FileTooLong: bitemporal/Command.scala optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/Command.scala — FileTooLong — 1852 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1352 over it, 3.70× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: relational/RelationColumnType.scala optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala — FileTooLong — 1694 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1194 over it, 3.39× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: json/ProductFormatsInstances.scala optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala — FileTooLong — 1615 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1115 over it, 3.23× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: proto/GetCommandProtoSerialization.scala optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala — FileTooLong — 1479 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 979 over it, 2.96× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: platform/NodeFunction.scala optimus/platform/projects/core/src/main/scala/optimus/platform/NodeFunction.scala — FileTooLong — 1464 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 964 over it, 2.93× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: entity/AutoAsyncComponent.scala optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala — FileTooLong — 1402 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 902 over it, 2.80× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: entity/AdjustASTComponent.scala optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala — FileTooLong — 1119 significant lines (blank, comment-only and punctuation-only lines excluded), about 97% of them inside a single declaration: AdjustASTComponent (52-1637). The bar is 500 significant lines; this is 619 over it, 2.24× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: ap/StackAnalysis.scala optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala — FileTooLong — 1115 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 615 over it, 2.23× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: crumbs/Properties.scala optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/crumbs/Properties.scala — FileTooLong — 1111 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 611 over it, 2.22× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: format/ScopeDefinitionCompiler.scala optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ScopeDefinitionCompiler.scala — FileTooLong — 1088 significant lines (blank, comment-only and punctuation-only lines excluded), about 90% of them inside a single declaration: ScopeDefinitionCompiler (73-1389). The bar is 500 significant lines; this is 588 over it, 2.18× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: translation/DefaultBinder.scala optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala — FileTooLong — 1074 significant lines (blank, comment-only and punctuation-only lines excluded), about 97% of them inside a single declaration: DefaultBinder (39-1355). The bar is 500 significant lines; this is 574 over it, 2.15× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: toporing/TopologyRingCreator.java optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/TopologyRingCreator.java — FileTooLong — 1032 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 532 over it, 2.06× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: artifacts/Artifacts.scala optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/artifacts/Artifacts.scala — FileTooLong — 1029 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 529 over it, 2.06× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: trace/Tracer.scala optimus/platform/projects/dal_core/src/main/scala/optimus/dsi/trace/Tracer.scala — FileTooLong — 1013 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 513 over it, 2.03× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: dal/EntityResolverReadImpl.scala optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/EntityResolverReadImpl.scala — FileTooLong — 974 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 474 over it, 1.95× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: app/OptimusBuildToolImpl.scala optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/app/OptimusBuildToolImpl.scala — FileTooLong — 966 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 466 over it, 1.93× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: platform/AdvancedUtils.scala optimus/platform/projects/core/src/main/scala/optimus/platform/AdvancedUtils.scala — FileTooLong — 945 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 445 over it, 1.89× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: gridprofiler/GridProfiler.scala optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfiler.scala — FileTooLong — 936 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 436 over it, 1.87× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: entity/TypedUtils.scala optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/TypedUtils.scala — FileTooLong — 914 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 414 over it, 1.83× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: rewrite/RewriteComponent.scala optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/rewrite/RewriteComponent.scala — FileTooLong — 908 significant lines (blank, comment-only and punctuation-only lines excluded), about 98% of them inside a single declaration: RewriteComponent (33-1255). The bar is 500 significant lines; this is 408 over it, 1.82× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: relational/DefaultQueryProvider.scala optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/DefaultQueryProvider.scala — FileTooLong — 885 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 385 over it, 1.77× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: compile/Compiler.scala optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/compile/Compiler.scala — FileTooLong — 846 significant lines (blank, comment-only and punctuation-only lines excluded), about 83% of them inside a single declaration: Compiler (175-1132). The bar is 500 significant lines; this is 346 over it, 1.69× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: graph/PluginSupport.scala optimus/platform/projects/platform/src/main/scala/optimus/graph/PluginSupport.scala — FileTooLong — 843 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 343 over it, 1.69× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: config/NodeCacheConfigs.scala optimus/platform/projects/core/src/main/scala/optimus/config/NodeCacheConfigs.scala — FileTooLong — 842 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 342 over it, 1.68× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: breadcrumbs/Breadcrumbs.scala optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala — FileTooLong — 841 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 341 over it, 1.68× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • + 54 more in this group — see findings.md.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×49
  • Duplicated block (8 lines × 2) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/scope/sources/ElectronCompilationSources.scala:35 — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/scope/sources/ElectronCompilationSources.scala:35-42 | optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/scope/sources/WebCompilationSources.scala:35-42 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/scope/sources/ElectronCompilationSources.scala:35` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OSeq.scala:42 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OSeq.scala:42-49 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OSeq.scala:45-52 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OSeq.scala` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OSeq.scala:42` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:212 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:212-219 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala:233-240 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 153 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (8 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:235 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:235-242 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala:256-263 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 153 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (8 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:286 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:286-293 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:245-252 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (8 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:376 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:376-383 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:323-330 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:376` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/ThreadStatUtil.scala:220 — optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/ThreadStatUtil.scala:220-227 | optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/ThreadStatUtil.scala:256-263 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/ThreadStatUtil.scala:220` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (8 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/graph/experimental/ExperimentalAsyncIterator2.scala:104 — optimus/platform/projects/core/src/main/scala/optimus/graph/experimental/ExperimentalAsyncIterator2.scala:104-111 | optimus/platform/projects/core/src/main/scala/optimus/graph/experimental/ExperimentalAsyncIterator2.scala:538-545 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/graph/experimental/ExperimentalAsyncIterator2.scala:104` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/dsi/cli/ZkStoreUtils.scala:110 — optimus/platform/projects/dal_core/src/main/scala/optimus/dsi/cli/ZkStoreUtils.scala:110-117 | optimus/platform/projects/dal_core/src/main/scala/optimus/dsi/cli/ZkStoreUtils.scala:160-168 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PubSubProtoSerialization.scala:313 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PubSubProtoSerialization.scala:313-320 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PubSubProtoSerialization.scala:383-390 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PubSubProtoSerialization.scala:313` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) optimus/platform/projects/entityplugin/src/main/scala/optimus/entityplugin/pretyper/CompanionMethodsGenerator.scala:313 — optimus/platform/projects/entityplugin/src/main/scala/optimus/entityplugin/pretyper/CompanionMethodsGenerator.scala:313-320 | optimus/platform/projects/entityplugin/src/main/scala/optimus/entityplugin/pretyper/CompanionMethodsGenerator.scala:333-340 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2) optimus/platform/projects/platform/src/main/scala/optimus/graph/PluginSupport.scala:143 — optimus/platform/projects/platform/src/main/scala/optimus/graph/PluginSupport.scala:143-150 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/SerializedKeyBuilder.scala:77-84 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/platform/src/main/scala/optimus/graph/PluginSupport.scala:143` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/Query.scala:646 — optimus/platform/projects/priql/src/main/scala/optimus/platform/Query.scala:646-653 | optimus/platform/projects/priql/src/main/scala/optimus/platform/Query.scala:676-683 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/Query.scala:646` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:981 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:981-988 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1510-1517 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (8 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1657 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1657-1664 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1834-1841 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1657` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:156 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:156-163 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:66-73 — before extracting anything, compare `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala` and `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 107 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (8 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:406 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:406-413 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:366-373 — before extracting anything, compare `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala` and `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 107 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (8 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:481 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:481-488 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:442-449 — before extracting anything, compare `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala` and `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 107 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (8 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:595 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:595-602 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALBinder.scala:373-380 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:595` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:707 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:707-714 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:793-800 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:707` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:1228 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:1228-1235 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALBinder.scala:137-144 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:1228` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/formatter/Formatters.scala:118 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/formatter/Formatters.scala:118-125 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/formatter/Formatters.scala:169-176 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/formatter/Formatters.scala:118` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/MultiRelationElementRemover.scala:136 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/MultiRelationElementRemover.scala:136-143 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/MultiRelationElementRemover.scala:167-174 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:156 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:156-163 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:213-220 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:156` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (8 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PredicatePushdownOptimizer.scala:131 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PredicatePushdownOptimizer.scala:131-138 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PredicatePushdownOptimizer.scala:161-168 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PredicatePushdownOptimizer.scala:131` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • + 24 more in this group — see findings.md.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×41
  • Duplicated block (9 lines × 2) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/bsp/BspBuilder.scala:201 — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/bsp/BspBuilder.scala:201-209 | optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/utils/Utils.scala:324-332 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (9 lines × 2) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ElectronConfigurationCompiler.scala:34 — optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ElectronConfigurationCompiler.scala:34-42 | optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/WebConfigurationCompiler.scala:32-40 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ElectronConfigurationCompiler.scala:34` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `origin` to `ObtFile): Result[Option[ElectronConfiguration]] = Result.tryWith(origin` in one and `ObtFile): Result[Option[WebConfiguration]] = Result.tryWith(origin` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ElectronConfigurationCompiler.scala:33` calls `stringListOrEmpty` and `optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/WebConfigurationCompiler.scala:31` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (9 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:194 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:194-202 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala:173-181 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:311 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:311-319 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:267-275 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:406 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:406-414 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:350-358 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:406` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/platform/CovariantSet.scala:158 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/platform/CovariantSet.scala:158-166 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/platform/CovariantSet.scala:84-92 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (9 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/graph/CorePluginSupport.scala:27 — optimus/platform/projects/core/src/main/scala/optimus/graph/CorePluginSupport.scala:27-35 | optimus/platform/projects/core/src/main/scala/optimus/graph/PropertyNode.scala:105-113 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:136 — optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:136-144 | optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:167-175 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:136` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EventCommandProtoSerialization.scala:55 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EventCommandProtoSerialization.scala:55-63 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EventCommandProtoSerialization.scala:87-95 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (9 lines × 2) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/TypedUtils.scala:1019 — optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/TypedUtils.scala:1019-1027 | optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/StagingPluginDefinitions.scala:134-142 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (9 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:477 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:477-485 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:492-500 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:477` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:487 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:487-495 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMProxyGenerator.scala:606-615 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:487` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReducer.scala:73 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReducer.scala:73-81 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchReducer.scala:47-55 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReducer.scala:73` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PicklerSelector.scala:325 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PicklerSelector.scala:325-333 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PicklerSelector.scala:337-345 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (9 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PredicatePushdownOptimizer.scala:146 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PredicatePushdownOptimizer.scala:146-154 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PredicatePushdownOptimizer.scala:176-184 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PredicatePushdownOptimizer.scala:146` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:436 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:436-444 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala:480-488 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 153 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:447` calls `apply` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala:490` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (9 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:528 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:528-536 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala:569-577 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 153 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (9 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:226 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:226-234 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:224-232 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 252 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (9 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:182 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:182-190 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:156-164 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (9 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:191 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:191-199 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:165-173 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (9 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:229 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:229-237 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:195-203 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (9 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/graph/Node.scala:598 — optimus/platform/projects/core/src/main/scala/optimus/graph/Node.scala:598-606 | optimus/platform/projects/core/src/main/scala/optimus/graph/PropertyNode.scala:500-508 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (9 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:112 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:112-120 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchReferenceReducer.scala:119-127 — before extracting anything, compare `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala` and `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchReferenceReducer.scala` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (9 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALBinder.scala:91 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALBinder.scala:91-99 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/FullTextSearchBinder.scala:69-77 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (9 lines × 2) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:429 — optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:429-437 | optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:578-586 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:429` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `entries` to `List<KVEntry<K>>` in one and `List<K>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • + 16 more in this group — see findings.md.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×40
  • Duplicated block (6 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:57 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:57-62 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:57-62 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 252 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:57` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:378 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:378-383 | optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:393-398 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:378` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/temporalSurface/impl/TemporalContexts.scala:78 — optimus/platform/projects/dal_client/src/main/scala/optimus/platform/temporalSurface/impl/TemporalContexts.scala:78-83 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/temporalSurface/impl/TemporalContexts.scala:114-119 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/dal_client/src/main/scala/optimus/platform/temporalSurface/impl/TemporalContexts.scala:78` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:167 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:167-172 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:405-410 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:167` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/RangeQuery.scala:240 — optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/RangeQuery.scala:240-245 | optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/RangeQuery.scala:290-295 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/RangeQuery.scala:240` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/DefaultQueryProvider.scala:496 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/DefaultQueryProvider.scala:496-501 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/DefaultQueryProvider.scala:532-537 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (6 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/excel/ExcelSource.scala:118 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/excel/ExcelSource.scala:118-123 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/excel/ExcelSource.scala:144-149 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (6 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/formatter/Formatters.scala:216 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/formatter/Formatters.scala:216-221 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/formatter/Formatters.scala:385-390 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (6 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/tree/LegacyMethodElements.scala:213 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/tree/LegacyMethodElements.scala:213-218 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/tree/LegacyMethodElements.scala:305-310 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (6 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReducer.scala:60 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReducer.scala:60-65 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchReducer.scala:38-43 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReducer.scala:60` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/SpecialElementRewriter.scala:112 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/SpecialElementRewriter.scala:112-118 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/SpecialElementRewriter.scala:141-146 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/SpecialElementRewriter.scala:112` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (6 lines × 2) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/bsp/BspBuilder.scala:194 — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/bsp/BspBuilder.scala:194-199 | optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/utils/Utils.scala:316-321 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (6 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:208 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:208-213 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala:187-192 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:32 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:32-37 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:32-37 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 252 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:241 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:241-246 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:207-212 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:259 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:259-264 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:219-224 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:265 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:265-270 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:225-230 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:271 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:271-276 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:231-236 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:277 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:277-282 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:237-242 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:339 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:339-344 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:287-292 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/graph/GraphMBean.scala:132 — optimus/platform/projects/core/src/main/scala/optimus/graph/GraphMBean.scala:132-137 | optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/UIProfiler.scala:52-58 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (6 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/graph/gcmonitor/HeapUsageMb.scala:74 — optimus/platform/projects/core/src/main/scala/optimus/graph/gcmonitor/HeapUsageMb.scala:74-79 | optimus/platform/projects/utils/src/main/scala/optimus/utils/GCUtils.scala:105-110 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/utils/src/main/scala/optimus/utils/GCUtils.scala:105` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (6 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/ExpressionPriQLFormatter.scala:213 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/ExpressionPriQLFormatter.scala:213-218 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/ExpressionSqlFormatter.scala:108-113 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (6 lines × 2) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/GroupMergeDialog.scala:117 — optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/GroupMergeDialog.scala:117-122 | optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeProfiler.scala:678-683 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/GroupMergeDialog.scala:117` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (6 lines × 2) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/controls/GroupByButton.scala:114 — optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/controls/GroupByButton.scala:114-119 | optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/controls/ProfilerTasks.scala:71-76 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • + 15 more in this group — see findings.md.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×39
  • Duplicated block (5 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:347 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:347-351 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:295-299 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:347` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:354 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:354-358 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:302-306 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:354` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:361 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:361-365 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:309-313 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:361` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:368 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:368-372 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:316-320 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:368` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/platform/ImmutableArray.scala:43 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/platform/ImmutableArray.scala:43-47 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/platform/ImmutableArray.scala:42-46 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/platform/ImmutableArray.scala:43` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/platform/ImmutableArray.scala:90 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/platform/ImmutableArray.scala:90-94 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/platform/ImmutableArray.scala:90-94 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/platform/ImmutableArray.scala:90` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:390 — optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:390-394 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:403-407 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:390` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:457 — optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:457-461 | optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:469-473 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:457` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:201 — optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:201-205 | optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:393-397 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (5 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:114 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:114-118 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:120-124 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/excel/ExcelSource.scala:60 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/excel/ExcelSource.scala:60-64 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/excel/ExcelSource.scala:84-88 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableRewriter.scala:386 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableRewriter.scala:386-390 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableRewriter.scala:413-417 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableRewriter.scala:386` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableRewriter.scala:396 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableRewriter.scala:396-400 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableRewriter.scala:423-427 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableRewriter.scala:396` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/tree/LegacyMethodElements.scala:104 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/tree/LegacyMethodElements.scala:104-108 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/tree/LegacyMethodElements.scala:149-153 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:168 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:168-172 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALBinder.scala:276-281 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:168` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PicklerSelector.scala:133 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PicklerSelector.scala:133-137 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PicklerSelector.scala:221-225 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PicklerSelector.scala:133` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALRegisteredIndexBinder.scala:101 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALRegisteredIndexBinder.scala:101-105 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALRegisteredIndexBinder.scala:143-147 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALRegisteredIndexBinder.scala:101` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:102 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:102-106 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala:81-85 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (5 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:170 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:170-174 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:145-149 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (5 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:185 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:185-189 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:155-159 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (5 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:190 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:190-194 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:160-164 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (5 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:195 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:195-199 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:165-169 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (5 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:200 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:200-204 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:170-174 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (5 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:254 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:254-258 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:214-218 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (5 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/platform/ImmutableArray.scala:65 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/platform/ImmutableArray.scala:65-69 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/platform/ImmutableArray.scala:63-67 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • + 14 more in this group — see findings.md.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×33
  • Duplicated block (7 lines × 2) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncElectronCompiler.scala:123 — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncElectronCompiler.scala:123-129 | optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncWebCompiler.scala:126-132 — before extracting anything, compare `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncElectronCompiler.scala` and `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncWebCompiler.scala` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncElectronCompiler.scala:123` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncElectronCompiler.scala:133 — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncElectronCompiler.scala:133-139 | optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncWebCompiler.scala:137-143 — before extracting anything, compare `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncElectronCompiler.scala` and `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncWebCompiler.scala` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncElectronCompiler.scala:133` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:349 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:349-355 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:346-352 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 252 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:349` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:161 — optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:161-167 | optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:192-199 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:161` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:560 — optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:560-566 | optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:590-596 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:560` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/platform/inputs/loaders/NodeInputMap.scala:282 — optimus/platform/projects/core/src/main/scala/optimus/platform/inputs/loaders/NodeInputMap.scala:282-288 | optimus/platform/projects/core/src/main/scala/optimus/platform/inputs/loaders/NodeInputMap.scala:324-330 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/platform/inputs/loaders/NodeInputMap.scala:282` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/platform/relational/tree/QueryTreeComparer.scala:149 — optimus/platform/projects/core/src/main/scala/optimus/platform/relational/tree/QueryTreeComparer.scala:149-155 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/ExpressionComparer.scala:176-182 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (7 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/ExpressionAtlasSearchFormatter.scala:27 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/ExpressionAtlasSearchFormatter.scala:27-33 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/ExpressionPriQLFormatter.scala:132-138 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/ExpressionAtlasSearchFormatter.scala:27` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:350 — optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:350-356 | optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/PluginUtils.scala:271-277 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:350` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (7 lines × 2) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala:1198 — optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala:1198-1204 | optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala:1215-1221 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala:1198` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala:1213` calls `val`, `pred_get` and `optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala:1196` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (7 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/DefaultQueryProvider.scala:1065 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/DefaultQueryProvider.scala:1065-1071 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/DefaultQueryProvider.scala:1080-1086 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (7 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:404 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:404-410 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:450-456 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:404` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALFormatter.scala:127 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALFormatter.scala:127-133 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchLanguage.scala:78-84 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALFormatter.scala:127` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (7 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALLanguage.scala:61 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALLanguage.scala:61-67 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/pubsub/PubSubLanguage.scala:65-71 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALLanguage.scala:61` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/PostTyperCodingStandardsComponent.scala:249 — optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/PostTyperCodingStandardsComponent.scala:249-255 | optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/rewrite/RewriteComponent.scala:1004-1010 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/PostTyperCodingStandardsComponent.scala:249` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) optimus/buildtool/projects/core/src/main/scala/optimus/buildtool/runconf/RunConf.scala:111 — optimus/buildtool/projects/core/src/main/scala/optimus/buildtool/runconf/RunConf.scala:111-117 | optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/Template.scala:64-70 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (7 lines × 2) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/utils/PathUtils.scala:64 — optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/utils/PathUtils.scala:64-70 | optimus/platform/projects/core/src/main/scala/optimus/config/InstallPathLocator.scala:274-280 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (7 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:137 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:137-143 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala:116-122 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (7 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:174 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:174-180 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:148-154 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (7 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:160 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:160-166 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:135-141 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (7 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:324 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:324-330 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:280-286 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (7 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/ScalarSubqueryRewriter.scala:129 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/ScalarSubqueryRewriter.scala:129-135 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/tree/DbQueryTreeComparer.scala:96-102 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/ScalarSubqueryRewriter.scala:129` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (7 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:88 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:88-94 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:62-68 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (7 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/serialization/QueryBuilder.scala:715 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/serialization/QueryBuilder.scala:715-721 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/serialization/QueryBuilder.scala:740-746 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/DALProvider.scala:339 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/DALProvider.scala:339-345 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/DALProvider.scala:350-356 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/DALProvider.scala:339` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • + 8 more in this group — see findings.md.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×32
  • Duplicated block (10 lines × 2) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/cache/dht/AsyncGraphLargeValueClient.scala:68 — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/cache/dht/AsyncGraphLargeValueClient.scala:68-77 | optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/cache/dht/AsyncGraphLargeValueClient.scala:88-97 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/cache/dht/AsyncGraphLargeValueClient.scala:68` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/cache/dht/AsyncGraphLargeValueClient.scala:78` calls `incrementAndGet` and `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/cache/dht/AsyncGraphLargeValueClient.scala:98` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (10 lines × 2) optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/compile/Compiler.scala:986 — optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/compile/Compiler.scala:986-995 | optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/compile/Compiler.scala:1030-1039 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (10 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:224 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:224-233 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala:209-218 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 165 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (10 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfilerData.scala:216 — optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfilerData.scala:216-225 | optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfilerData.scala:267-276 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfilerData.scala:216` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:585 — optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:585-594 | optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:614-623 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:585` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:992 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:992-1001 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1015-1024 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:992` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Variance.scala:66 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Variance.scala:66-75 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Variance.scala:179-188 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (10 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/excel/ExcelMultiRelation.scala:259 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/excel/ExcelMultiRelation.scala:259-268 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/excel/ExcelMultiRelation.scala:273-282 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (10 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:123 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:123-132 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchReferenceReducer.scala:130-139 — before extracting anything, compare `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala` and `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchReferenceReducer.scala` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (10 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala:323 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala:323-332 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchLanguage.scala:182-191 — before extracting anything, compare `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala` and `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchLanguage.scala` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala:323` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALFormatter.scala:135 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALFormatter.scala:135-144 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchLanguage.scala:86-95 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALFormatter.scala:135` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALRegisteredIndexBinder.scala:88 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALRegisteredIndexBinder.scala:88-97 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALRegisteredIndexBinder.scala:126-135 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALRegisteredIndexBinder.scala:88` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OSeq.scala:114 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OSeq.scala:114-123 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OSeq.scala:119-128 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OSeq.scala` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (10 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:113 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:113-122 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala:92-101 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (10 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:151 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:151-160 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala:169-178 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 153 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (10 lines × 2) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/messages/MessagesNotificationStream.scala:636 — optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/messages/MessagesNotificationStream.scala:636-645 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/pubsub/NotificationMessageHandler.scala:435-444 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (10 lines × 2) optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:93 — optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:93-102 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:283-292 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:93` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/DHTKeyCuckooBase.java:166 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/DHTKeyCuckooBase.java:166-175 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/CuckooBase.java:178-187 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/DHTKeyCuckooBase.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/CuckooBase.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 46 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (10 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/RegionTreePruner.java:71 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/RegionTreePruner.java:71-80 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/RegionTreePruner.java:99-108 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `node` to `NonLeafChecksumNode` in one and `LeafChecksumNode` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (10 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java:62 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java:62-71 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingInfo.java:50-59 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingInfo.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (10 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/RingCurTargetTool.java:113 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/RingCurTargetTool.java:113-122 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/meta/ExclusionFileMonitor.java:109-118 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/RingCurTargetTool.java:113` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ChainedIdSerialization.java:56 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ChainedIdSerialization.java:56-65 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ChainedIdSerialization.java:73-82 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (10 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/numeric/StatSeries.java:193 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/numeric/StatSeries.java:193-202 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/numeric/StatSeries.java:217-226 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (10 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:55 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:55-64 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java:50-59 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 105 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/DHTConfigurationWatcher.java:61 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/DHTConfigurationWatcher.java:61-70 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/DHTMetaWatcher.java:83-92 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • + 7 more in this group — see findings.md.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×31
  • Swallowed exception (caught, then discarded) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/bsp/BSPTraceListener.scala:294 — `case NonFatal(_)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincCompilerFactory.scala:121 — `case NonFatal(_)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ResolverDefinition.scala:95 — `case NonFatal(e)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/compile/ExternalCache.scala:70 — `case _: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/crumbs/Properties.scala:596 — `case NonFatal(_)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/breadcrumbs/src/main/scala/optimus/platform/util/Version.scala:94 — `case NonFatal(_)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/core/src/main/scala/optimus/graph/TweakTargetImpl.scala:53 — `case _: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/core/src/main/scala/optimus/graph/TweakTargetImpl.scala:86 — `case _: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/core/src/main/scala/optimus/graph/GraphEvents.scala:40 — `case _: Throwable` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/core/src/main/scala/optimus/platform/relational/tree/TypeInfo.scala:314 — `case _: Throwable` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/core/src/main/scala/optimus/platform/relational/tree/MethodPosition.scala:30 — `case _: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:212 — `case ex: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:218 — `case ex: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/AppStatsControl.scala:181 — `case _: Throwable` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/AppStatsAllocationCounts.scala:47 — `case _: Throwable` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dsi/protobufutils/DALProtoClient.scala:66 — `case NonFatal(ex)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/ProtoFileProperties.scala:38 — `case _: Throwable` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/ProtoFileProperties.scala:78 — `case NonFatal(_)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/entityagent/src/main/java/optimus/ClassMonitorInjector.java:222 — `catch (Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/EntityPlugin.scala:49 — `case t: Throwable` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:336 — `case _: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:449 — `case _: Throwable` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:523 — `case t: Throwable` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:1262 — `case _: Exception` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/AsyncProfilerIntegration.scala:506 — `case t: Throwable` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • + 6 more in this group — see findings.md.
X24 · Document value interpolated into markup unescaped · Untrusted text written into markup unescaped · ×27
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:44 — `g.title` is text this program did not author, and it is written into the text of an element through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:51 — `html` is text this program did not author, and it is written into the text of an element through `innerHTML` with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:66 — `title` is text this program did not author, and it is written into an unquoted attribute through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. HTML text encoding does not help in an unquoted attribute — whitespace ends it; quote the attribute and encode the value.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:67 — `btnId` is text this program did not author, and it is written into a quoted attribute value through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:68 — `rowId` is text this program did not author, and it is written into a script or style context through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. A script or style context needs its own escaping (or a JSON serialiser that escapes `<`); better, pass the value through a data attribute.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:70 — `linkId` is text this program did not author, and it is written into a quoted attribute value through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:72 — `e.module` is text this program did not author, and it is written into the text of an element through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:73 — `topDisplayFrame` is text this program did not author, and it is written into the text of an element through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:76 — `rowId` is text this program did not author, and it is written into a quoted attribute value through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:79 — `desc[idx]` is text this program did not author, and it is written into the text of an element through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:83 — `title` is text this program did not author, and it is written into an unquoted attribute through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. HTML text encoding does not help in an unquoted attribute — whitespace ends it; quote the attribute and encode the value.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:184 — `btnId` is text this program did not author, and it is written into a quoted attribute value through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:185 — `rowId` is text this program did not author, and it is written into a script or style context through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. A script or style context needs its own escaping (or a JSON serialiser that escapes `<`); better, pass the value through a data attribute.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:188 — `violation.owner` is text this program did not author, and it is written into the text of an element through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:189 — `violation.frame` is text this program did not author, and it is written into the text of an element through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:193 — `rowId` is text this program did not author, and it is written into a quoted attribute value through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:196 — `inner_tbodyId` is text this program did not author, and it is written into a quoted attribute value through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:214 — `title` is text this program did not author, and it is written into an unquoted attribute through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. HTML text encoding does not help in an unquoted attribute — whitespace ends it; quote the attribute and encode the value.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:215 — `btnId` is text this program did not author, and it is written into a quoted attribute value through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:216 — `rowId` is text this program did not author, and it is written into a script or style context through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. A script or style context needs its own escaping (or a JSON serialiser that escapes `<`); better, pass the value through a data attribute.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:219 — `violation.owner` is text this program did not author, and it is written into the text of an element through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:220 — `violation.frame` is text this program did not author, and it is written into the text of an element through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:223 — `rowId` is text this program did not author, and it is written into a quoted attribute value through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:226 — `desc[idx]` is text this program did not author, and it is written into the text of an element through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • Untrusted text written into markup unescaped optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:240 — `owner` is text this program did not author, and it is written into a quoted attribute value through markup built here with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework's escaping output, or sanitise it if it must stay markup.
  • + 2 more in this group — see findings.md.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×26
  • Duplicated block (11 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:145 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:145-155 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala:124-134 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (11 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:237 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:237-247 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala:221-231 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 165 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:249` calls `collect` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala:232` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:78 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:78-88 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:66-76 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (11 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:476 — optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:476-486 | optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:505-515 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/platform/NodeResult.scala:476` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (11 lines × 2) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:42 — optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:42-52 | optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:134-144 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (11 lines × 2) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:89 — optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:89-99 | optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:181-191 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (11 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/RelationKeys.scala:166 — optimus/platform/projects/priql/src/main/scala/optimus/platform/RelationKeys.scala:166-176 | optimus/platform/projects/priql/src/main/scala/optimus/platform/RelationKeys.scala:232-242 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (11 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/ScalarSubqueryRewriter.scala:24 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/ScalarSubqueryRewriter.scala:24-34 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/SpecialElementRewriter.scala:39-49 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (11 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/excel/ExcelSource.scala:65 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/excel/ExcelSource.scala:65-75 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/excel/ExcelSource.scala:89-99 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/excel/ExcelSource.scala:65` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:204 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:204-214 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:261-271 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:204` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:344 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:344-354 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:365-375 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:344` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALBinder.scala:261 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALBinder.scala:261-271 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALBinder.scala:281-291 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALBinder.scala:261` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:249 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:249-259 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala:270-280 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 153 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (11 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:266 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:266-276 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala:287-297 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 153 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (11 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:196 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:196-206 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala:181-191 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 165 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (11 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:207 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:207-217 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala:192-202 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 165 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (11 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/platform/pickling/PropertyMapOutputStream.scala:339 — optimus/platform/projects/core/src/main/scala/optimus/platform/pickling/PropertyMapOutputStream.scala:339-349 | optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/filter/Condition.scala:517-527 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (11 lines × 2) optimus/platform/projects/scala_compat/src/main/scala-2.12/optimus/scalacompat/repl/ScalaRepl.scala:262 — optimus/platform/projects/scala_compat/src/main/scala-2.12/optimus/scalacompat/repl/ScalaRepl.scala:262-272 | optimus/platform/projects/scala_compat/src/main/scala-2.13/optimus/scalacompat/repl/ScalaRepl.scala:264-274 — before extracting anything, compare `optimus/platform/projects/scala_compat/src/main/scala-2.12/optimus/scalacompat/repl/ScalaRepl.scala` and `optimus/platform/projects/scala_compat/src/main/scala-2.13/optimus/scalacompat/repl/ScalaRepl.scala` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 68 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (11 lines × 2) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/callback/InternalCallbackRegistry.java:189 — optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/callback/InternalCallbackRegistry.java:189-199 | optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/callback/InternalCallbackRegistry.java:225-235 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/callback/InternalCallbackRegistry.java:189` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/stream/KVClientEstablishedStreamHandlerV1.java:122 — optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/stream/KVClientEstablishedStreamHandlerV1.java:122-132 | optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/stream/KVClientEstablishedStreamHandlerV1.java:156-166 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/stream/KVClientEstablishedStreamHandlerV1.java:122` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:67 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:67-77 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java:62-72 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 105 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (11 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:105 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:105-115 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java:101-111 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 105 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:105` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:137 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:137-147 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java:139-149 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:137` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (11 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java:359 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java:359-369 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java:255-265 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 71 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform03/relational/Data.scala:157 — optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform03/relational/Data.scala:157-167 | optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform03/relational/Data.scala:170-180 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • + 1 more in this group — see findings.md.
D6 · Cohesion (LCOM4) · Low cohesion · ×26
  • Low cohesion: OptimusSeq (LCOM4 12) optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:303 — OptimusSeq's methods fall into 12 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 12 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: OptimusSeq (LCOM4 11) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:307 — OptimusSeq's methods fall into 11 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 11 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: PropertyNode (LCOM4 11) optimus/platform/projects/core/src/main/scala/optimus/graph/PropertyNode.scala:120 — PropertyNode's methods fall into 11 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 11 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: OptimusCompositeLeaderElectorClient (LCOM4 10) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/runtime/OptimusCompositeLeaderElectorClient.scala:148 — OptimusCompositeLeaderElectorClient's methods fall into 10 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 10 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: BitBucket (LCOM4 7) optimus/platform/projects/bitbucket-utils/src/main/scala/optimus/rest/bitbucket/BitBucket.scala:21 — BitBucket's methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: GitLogImpl (LCOM4 6) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/utils/GitLog.scala:140 — GitLogImpl's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: DependencyTrackerRoot (LCOM4 6) optimus/platform/projects/core/src/main/scala/optimus/graph/tracking/DependencyTrackerRoot.scala:46 — DependencyTrackerRoot's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: RangeQuery (LCOM4 6) optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/RangeQuery.scala:62 — RangeQuery's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: DebugPrintFormatter (LCOM4 6) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/debugPrint/DebugPrintFormatter.scala:33 — DebugPrintFormatter's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: DALBinder (LCOM4 6) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALBinder.scala:40 — DALBinder's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: DALFormatterBase (LCOM4 6) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALFormatterBase.scala:23 — DALFormatterBase's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: AbstractBitemporalSpace (LCOM4 5) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/bitemporal/BitemporalSpaceImpl.scala:41 — AbstractBitemporalSpace's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: HotspotsTable (LCOM4 5) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/HotspotsTable.scala:733 — HotspotsTable's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: DbQueryTreeReducerBase (LCOM4 5) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/DbQueryTreeReducerBase.scala:42 — DbQueryTreeReducerBase's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: Staging (LCOM4 5) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/StagingComponent.scala:51 — Staging's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: ExtensionFilterFileVisitor (LCOM4 4) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/files/WorkspaceSourceRoot.scala:61 — ExtensionFilterFileVisitor's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: OptimusArraysSeq (LCOM4 4) optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:44 — OptimusArraysSeq's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: DefaultQueueMonitor (LCOM4 4) optimus/platform/projects/core/src/main/scala/optimus/graph/tracking/monitoring/QueueMonitor.scala:45 — DefaultQueueMonitor's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: DALEntityFlavor (LCOM4 4) optimus/platform/projects/core/src/main/scala/optimus/platform/storable/EntityFlavor.scala:158 — DALEntityFlavor's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: PubSubDsiProxy (LCOM4 4) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/RemoteDSIProxy.scala:602 — PubSubDsiProxy's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: TypeInfoBase (LCOM4 4) optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/TypeInfoApiBase.scala:37 — TypeInfoBase's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: NodeProfiler (LCOM4 4) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeProfiler.scala:144 — NodeProfiler's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: NodeTreeTable (LCOM4 4) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeTreeTable.scala:308 — NodeTreeTable's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: DALAccReducer (LCOM4 4) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReducer.scala:40 — DALAccReducer's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: DALBinder (LCOM4 4) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALBinder.scala:39 — DALBinder's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • + 1 more in this group — see findings.md.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×22
  • Duplicated block (12 lines × 2) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/generators/PodcastGenerator.scala:235 — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/generators/PodcastGenerator.scala:235-246 | optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/generators/PodcastGenerator.scala:270-281 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/generators/PodcastGenerator.scala:235` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:166 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:166-177 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala:145-156 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (12 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:180 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:180-191 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala:159-170 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (12 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:490 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:490-501 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala:531-542 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 153 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:490` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:207 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:207-218 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:181-192 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:207` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:225 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:225-236 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:199-210 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:225` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:263 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:263-274 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:237-248 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:263` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfilerData.scala:144 — optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfilerData.scala:144-155 | optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfilerData.scala:167-178 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfilerData.scala:144` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:1774 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:1774-1785 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:1814-1825 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (12 lines × 2) optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/PersistentEntityCondition.scala:154 — optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/PersistentEntityCondition.scala:154-165 | optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/PersistentEntityCondition.scala:171-182 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/PersistentEntityCondition.scala:154` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/CountDistinctMerger.scala:28 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/CountDistinctMerger.scala:28-39 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/CountDistinctMerger.scala:43-54 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/CountDistinctMerger.scala:28` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:514 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:514-525 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:606-617 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:514` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableProvider.scala:329 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableProvider.scala:329-340 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableProvider.scala:358-369 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableProvider.scala:329` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableRewriter.scala:272 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableRewriter.scala:272-283 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableRewriter.scala:315-326 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (12 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/EntityProviderPersistenceSerializer.scala:41 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/EntityProviderPersistenceSerializer.scala:41-52 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/EventProviderPersistenceSerializer.scala:41-52 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/EntityProviderPersistenceSerializer.scala:41` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:42 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:42-53 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java:37-48 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 105 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (12 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:137 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:137-148 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:157-168 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:149` calls `info` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:170` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (12 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ChainedIdSerialization.java:58 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ChainedIdSerialization.java:58-69 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoSkTraceIdSerialize.java:100-111 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (12 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/meta/WeightsZK.java:124 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/meta/WeightsZK.java:124-135 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/meta/WeightsZK.java:143-154 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (12 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:383 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:383-394 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:255-266 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/AbsNanosVersionProvider.java:35 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/AbsNanosVersionProvider.java:35-46 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/RelNanosVersionProvider.java:35-46 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetTCPSocketBuffer.java:294 — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetTCPSocketBuffer.java:294-305 | optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetTCPSocketBuffer.java:340-351 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetTCPSocketBuffer.java:294` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D3 · God Classes · ClassTooLong · ×20
  • ClassTooLong: AdjustASTComponent optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:52 — ClassTooLong — 1087 significant lines (blank, comment-only and punctuation-only lines excluded), 1 methods. The bar is 400 significant lines; this is 687 over it, 2.72× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: RewriteComponent optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/rewrite/RewriteComponent.scala:33 — ClassTooLong — 893 significant lines (blank, comment-only and punctuation-only lines excluded), 1 methods. The bar is 400 significant lines; this is 493 over it, 2.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: DHTRingManager optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:73 — ClassTooLong — 677 significant lines (blank, comment-only and punctuation-only lines excluded), 40 methods. The bar is 400 significant lines; this is 277 over it, 1.69× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: DefaultKVClient optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:69 — ClassTooLong — 665 significant lines (blank, comment-only and punctuation-only lines excluded), 20 methods. The bar is 400 significant lines; this is 265 over it, 1.66× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: PersistentAsyncServer optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/PersistentAsyncServer.java:38 — ClassTooLong — 631 significant lines (blank, comment-only and punctuation-only lines excluded), 36 methods. The bar is 400 significant lines; this is 231 over it, 1.58× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: AsyncDispatcherBasePatch optimus/platform/projects/platform/src/main/scala/msjava/logbackutils/async/internal/AsyncDispatcherBasePatch.java:48 — ClassTooLong — 589 significant lines (blank, comment-only and punctuation-only lines excluded), 34 methods. The bar is 400 significant lines; this is 189 over it, 1.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: NamespaceOptions optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/NamespaceOptions.java:27 — ClassTooLong — 534 significant lines (blank, comment-only and punctuation-only lines excluded), 42 methods. The bar is 400 significant lines; this is 134 over it, 1.34× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: RingRegion optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/ring/RingRegion.java:26 — ClassTooLong — 497 significant lines (blank, comment-only and punctuation-only lines excluded), 53 methods. The bar is 400 significant lines; this is 97 over it, 1.24× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: InstrumentationConfig optimus/platform/projects/entityagent/src/main/java/optimus/debug/InstrumentationConfig.java:37 — ClassTooLong — 487 significant lines (blank, comment-only and punctuation-only lines excluded), 50 methods. The bar is 400 significant lines; this is 87 over it, 1.22× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: RetrievalOptions optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/RetrievalOptions.java:30 — ClassTooLong — 486 significant lines (blank, comment-only and punctuation-only lines excluded), 35 methods. The bar is 400 significant lines; this is 86 over it, 1.22× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: RingTree optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingTree.java:51 — ClassTooLong — 485 significant lines (blank, comment-only and punctuation-only lines excluded), 27 methods. The bar is 400 significant lines; this is 85 over it, 1.21× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: ClassMonitorInjector optimus/platform/projects/entityagent/src/main/java/optimus/ClassMonitorInjector.java:87 — ClassTooLong — 478 significant lines (blank, comment-only and punctuation-only lines excluded), 41 methods. The bar is 400 significant lines; this is 78 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: SilverKingZooKeeperClient optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/zookeeper/SilverKingZooKeeperClient.java:50 — ClassTooLong — 474 significant lines (blank, comment-only and punctuation-only lines excluded), 66 methods. The bar is 400 significant lines; this is 74 over it, 1.19× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: WaitOptions optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/WaitOptions.java:31 — ClassTooLong — 462 significant lines (blank, comment-only and punctuation-only lines excluded), 29 methods. The bar is 400 significant lines; this is 62 over it, 1.16× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: DHTSessionImpl optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/DHTSessionImpl.java:80 — ClassTooLong — 457 significant lines (blank, comment-only and punctuation-only lines excluded), 47 methods. The bar is 400 significant lines; this is 57 over it, 1.14× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: PropertyInfoProvider optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/provider/PropertyInfoProvider.scala:49 — ClassTooLong — 452 significant lines (blank, comment-only and punctuation-only lines excluded), 0 methods. The bar is 400 significant lines; this is 52 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: DefaultConnectionsManager optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/transport/DefaultConnectionsManager.java:87 — ClassTooLong — 423 significant lines (blank, comment-only and punctuation-only lines excluded), 8 methods. The bar is 400 significant lines; this is 23 over it, 1.06× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: DHTClientBuilder optimus/dht/projects/client3/src/main/java/optimus/dht/client/api/DHTClientBuilder.java:86 — ClassTooLong — 422 significant lines (blank, comment-only and punctuation-only lines excluded), 36 methods. The bar is 400 significant lines; this is 22 over it, 1.06× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: DiagnosticSettings optimus/platform/projects/entityagent/src/main/java/optimus/graph/DiagnosticSettings.java:29 — ClassTooLong — 422 significant lines (blank, comment-only and punctuation-only lines excluded), 20 methods. The bar is 400 significant lines; this is 22 over it, 1.06× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: DistInputs optimus/platform/projects/inputs/src/main/java/optimus/platform/inputs/registry/parameters/DistInputs.java:23 — ClassTooLong — 406 significant lines (blank, comment-only and punctuation-only lines excluded), 1 methods. The bar is 400 significant lines; this is 6 over it, 1.02× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×18
  • Duplicated block (13 lines × 2) optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/compile/Compiler.scala:1002 — optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/compile/Compiler.scala:1002-1014 | optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/compile/Compiler.scala:1048-1060 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/compile/Compiler.scala:1002` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:357 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:357-369 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:354-366 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 252 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:357` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:442 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:442-454 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:448-460 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 252 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:442` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:461 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:461-473 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:466-478 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 252 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:461` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:357 — optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:357-369 | optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/PluginUtils.scala:278-290 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:357` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Variance.scala:125 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Variance.scala:125-137 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Variance.scala:154-166 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Variance.scala:125` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala:305 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala:305-317 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchLanguage.scala:163-175 — before extracting anything, compare `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala` and `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchLanguage.scala` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala:305` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:80 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:80-92 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala:59-71 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (13 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:123 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala:123-135 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala:102-114 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusCanBuildFrom.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusCanBuildFrom.scala` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (13 lines × 2) optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:386 — optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:386-398 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:430-442 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:386` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/ActiveRetrievalListeners.java:205 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/ActiveRetrievalListeners.java:205-217 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/ActiveRetrievalListeners.java:222-234 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/ActiveRetrievalListeners.java:222` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/AsyncRetrievalOperationImpl.java:355 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/AsyncRetrievalOperationImpl.java:355-367 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/AsyncRetrievalOperationImpl.java:642-654 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/AsyncRetrievalOperationImpl.java:355` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:233 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:233-245 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:157-169 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:233` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:231` calls `debug` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:155` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (13 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingTreeBuilder.java:97 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingTreeBuilder.java:97-109 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingTreeBuilder.java:184-196 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingTreeBuilder.java:97` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/analysis/netstat/MultiTraceToCSV.java:58 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/analysis/netstat/MultiTraceToCSV.java:58-70 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/analysis/netstat/TraceToCSV.java:52-64 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/analysis/netstat/MultiTraceToCSV.java:58` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoErrorResponseMessageGroup.java:31 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoErrorResponseMessageGroup.java:31-43 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoOpResponseMessageGroup.java:31-43 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoErrorResponseMessageGroup.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoOpResponseMessageGroup.java` as WHOLE FILES: 87% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoErrorResponseMessageGroup.java:31` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (13 lines × 2) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/util/internal/SystemPropertyUtils.java:159 — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/util/internal/SystemPropertyUtils.java:159-171 | optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/util/internal/SystemPropertyUtils.java:195-207 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/util/internal/SystemPropertyUtils.java:159` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `defaultValue` to `int` in one and `long` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (13 lines × 2) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/zkapi/ZkaDirectoryWatcher.java:199 — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/zkapi/ZkaDirectoryWatcher.java:199-211 | optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/zkapi/leader/internal/ZkaLeaderSubscriber.java:334-346 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×15
  • Members sharing a duplicated core (4 members, 50+ identical tokens) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:139 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:139-161 | optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:252-275 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala:124-146 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala:234-257 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:201 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:201-218 | optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:238-256 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:175-192 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:212-229 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:219 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:219-236 | optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:257-274 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:193-210 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:231-248 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:450 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:450-466 | optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:468-489 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:421-436 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:438-455 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/ZipIterator.scala:34 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/ZipIterator.scala:34-45 | optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/ZipIterator.scala:89-100 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/ZipIterator.scala:34-45 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/ZipIterator.scala:89-100 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1157 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1157-1165 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1333-1341 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1685-1693 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1862-1870 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:37 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:37-44 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:73-80 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:109-116 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:145-152 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:46 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:46-59 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:82-95 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:118-131 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:154-167 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:37 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:37-44 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:73-80 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:109-116 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:145-152 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:46 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:46-59 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:82-95 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:118-131 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:154-167 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:513 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:513-550 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:605-696 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:706-781 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:792-827 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:227 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:227-245 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:154-169 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java:221-239 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java:156-174 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java:84 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java:84-97 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DebugKey.java:161-174 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingInfo.java:106-119 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingIntegrityCheck.java:251-264 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:95 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:95-131 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:174-209 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/management/MetaToolModuleBase.java:129-163 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/meta/WeightsZK.java:88-120 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform/DALExample.scala:93 — optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform/DALExample.scala:93-108 | optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform/DALExample.scala:110-121 | optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform/DALExample.scala:123-136 | optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform/DALExample.scala:138-154 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D17 · Explicit Debt · HackComment · ×13
  • HackComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincCompiler.scala:121 — // HACK: Convert Paths to Strings and back again, to ensure we purely have paths from the default — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
  • HackComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/resolvers/MsIvyRepository.scala:42 — // hack for SBT putting infos in properties — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
  • HackComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/resolvers/MsIvyRepository.scala:393 — // hack for SBT putting infos in properties — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
  • HackComment optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/scope/sources/RunconfCompilationSources.scala:251 — // hacky - only include the first path for each scope (on the assumption that it's the linux one), to avoid — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
  • HackComment optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/config/RegexConfiguration.scala:33 — // hack for spray-json which can't deal with extra non-ctor fields — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
  • HackComment optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/config/RegexConfiguration.scala:63 — // hack for spray-json which can't deal with extra non-ctor fields — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
  • HackComment optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/config/ForbiddenDependencyConfiguration.scala:40 — // hack for spray-json which can't deal with extra non-ctor fields — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
  • HackComment optimus/platform/projects/core/src/main/scala/optimus/config/NodeCacheConfigs.scala:578 — // hacky — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
  • HackComment optimus/platform/projects/core/src/main/scala/optimus/platform/NodeFunction.scala:1701 — // allowIllegalOverrideOfInitialRuntimeEnvironment HACK!!!!! — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
  • HackComment optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/EntityResolverReadImpl.scala:1118 — // HACK: toSet, need to keep the result collection during the dataAccess transform result into Map — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
  • HackComment optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/DefaultPicklers.scala:49 — // HACK? What if the outer pickling stream has an Entity -> EntityRef context? — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
  • HackComment optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/RangeQuery.scala:68 — // hack around for type parameter that historical API needed — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
  • HackComment optimus/platform/projects/utils/src/main/scala/optimus/utils/CollectionUtils.scala:325 — // hack against scala/bug#10418 (fixed in 2.13 only) — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
D3 · God Classes · MethodTooLong · ×13
  • MethodTooLong: NodeMenu.create optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeMenu.scala:103 — MethodTooLong — create runs 277 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 177 over it, 2.77× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: OptimusBuildToolImpl.trackingBuilder optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/app/OptimusBuildToolImpl.scala:1008 — MethodTooLong — trackingBuilder runs 169 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 69 over it, 1.69× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: StratosphereConfig.<init> optimus/stratosphere/bootstrap/src/main/java/optimus/stratosphere/bootstrap/config/StratosphereConfig.java:139 — MethodTooLong — <init> runs 149 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 49 over it, 1.49× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: RingTree.merge optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingTree.java:416 — MethodTooLong — merge runs 145 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 45 over it, 1.45× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: NodeTaskAdapter.visitMethod optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:281 — MethodTooLong — visitMethod runs 140 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 40 over it, 1.40× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: TPDMaskAdapter.visitMethod optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:91 — MethodTooLong — visitMethod runs 132 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 32 over it, 1.32× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DependencyWatcher.build optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/DependencyWatcher.java:147 — MethodTooLong — build runs 128 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 28 over it, 1.28× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: IncomingBufferedData.readFromChannel optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java:104 — MethodTooLong — readFromChannel runs 128 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 28 over it, 1.28× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DaemonStateZK.waitForQuorumState optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/DaemonStateZK.java:275 — MethodTooLong — waitForQuorumState runs 125 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 25 over it, 1.25× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DALRegisteredIndexBinder.handleFuncCall optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALRegisteredIndexBinder.scala:30 — MethodTooLong — handleFuncCall runs 112 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 12 over it, 1.12× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: AbstractSegment.retrieve optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/AbstractSegment.java:125 — MethodTooLong — retrieve runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ProtoPutMessageGroup.addValue optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoPutMessageGroup.java:349 — MethodTooLong — addValue runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PersistentAsyncServer.createConnection optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/PersistentAsyncServer.java:559 — MethodTooLong — createConnection runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D17 · Explicit Debt · XxxComment · ×12
  • XxxComment optimus/platform/projects/alarms/src/main/scala/optimus/tools/scalacplugins/entity/reporter/OptimusAlarms.scala:657 — // lazy val XFUNC_WITH_HANDLE = error0(XXX, OptimusPhases.REF_CHECKS, "@handle cannot be @xFunc") — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment optimus/platform/projects/core/src/main/scala/optimus/platform/relational/tree/TypeInfo.scala:665 — // XXX Filter out overridden methods in nominal types — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/EventSerializer.scala:54 — // XXX CANNOT DO THIS. JVM/CLASSLOADER-WIDE STATE CANNOT DEPEND ON RUNTIME ENVIRONMENT!!! — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/EntityResolverReadImpl.scala:1054 — // XXX Revisit semantics of TemporalContext: we're explicitly overriding the vt, — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment optimus/platform/projects/dal_core/src/main/scala/optimus/dsi/notification/NotificationEntry.scala:91 — // XXX: collect all use case of ResetState — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment optimus/platform/projects/dal_core/src/main/scala/optimus/dsi/notification/NotificationEntry.scala:115 — // XXX: If we expand txTime to [txTime, Inf), the following fields contains all fields of a PersistentEntity. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment optimus/platform/projects/dal_core/src/main/scala/optimus/dsi/notification/NotificationEntry.scala:455 — // XXX: Assumption: entity references are only used for client side cache removal, and types are only used for — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment optimus/platform/projects/dal_core/src/main/scala/optimus/platform/bitemporal/BitemporalSpaceImpl.scala:230 — // XXX use unsorted timeseries — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment optimus/platform/projects/dal_core/src/main/scala/optimus/platform/bitemporal/BitemporalSpaceImpl.scala:233 — // XXX 'actions' can ever be empty? if so, the assert in the ctor of UpdateResult will fail — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/CommandProtoSerialization.scala:351 — // must not get here. XXX Better hierarchy: SerializableCommand <: Command — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/TreeDuplicator.scala:23 — // XXX: file bug report with TypeSafe to either remove duplicator (it's not used in stock scalac) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • XxxComment optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusNames.scala:190 — // XXX Get rid of after PickledInputStream API is rationalized not to have temporalContext for events — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×12
  • Duplicated block (14 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/formatter/Formatters.scala:128 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/formatter/Formatters.scala:128-141 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/formatter/Formatters.scala:179-192 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/formatter/Formatters.scala:128` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/util/DependencyTransformer.scala:54 — optimus/platform/projects/priql/src/main/scala/optimus/platform/util/DependencyTransformer.scala:54-67 | optimus/platform/projects/priql/src/main/scala/optimus/platform/util/DependencyTransformer.scala:110-123 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/util/DependencyTransformer.scala:54` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:58 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:58-71 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java:63-76 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (14 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:114 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:114-127 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/meta/WeightsZK.java:104-117 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:114` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/meta/ExclusionZKBase.java:54 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/meta/ExclusionZKBase.java:54-67 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/meta/SuspectZKBase.java:46-59 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (14 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java:273 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java:273-286 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/NewIncomingBufferedData.java:227-240 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/NewIncomingBufferedData.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 108 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java:271` calls `debug` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/NewIncomingBufferedData.java:226` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (14 lines × 2) optimus/silverking/projects/silverking_utils/src/main/java/com/ms/silverking/util/ArrayUtil.java:53 — optimus/silverking/projects/silverking_utils/src/main/java/com/ms/silverking/util/ArrayUtil.java:53-66 | optimus/silverking/projects/silverking_utils/src/main/java/com/ms/silverking/util/ArrayUtil.java:73-86 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `a` to `T[]` in one and `byte[]` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (14 lines × 2) optimus/silverking/projects/silverking_utils/src/main/java/com/ms/silverking/util/ArrayUtil.java:186 — optimus/silverking/projects/silverking_utils/src/main/java/com/ms/silverking/util/ArrayUtil.java:186-199 | optimus/silverking/projects/silverking_utils/src/main/java/com/ms/silverking/util/ArrayUtil.java:206-219 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking_utils/src/main/java/com/ms/silverking/util/ArrayUtil.java:186` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java:78 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java:78-91 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java:98-111 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 71 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 2) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetTCPConnection.java:1869 — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetTCPConnection.java:1869-1882 | optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetTCPConnection.java:1899-1912 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetTCPConnection.java:1869` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (14 lines × 2) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetTCPConnection.java:2131 — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetTCPConnection.java:2131-2144 | optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetTCPConnection.java:2167-2180 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 2) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/zkapi/leader/internal/ZkaLeaderSubscriber.java:157 — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/zkapi/leader/internal/ZkaLeaderSubscriber.java:157-170 | optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/zkapi/pubsub/ZkaServiceSubscriber.java:98-111 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
X18 · Disposal-pattern correctness · Disposable created and abandoned in the function that made it · ×12
  • Disposable created and abandoned in the function that made it optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/postbuilders/installer/component/fingerprintdiffing/BuildArtifactComparatorApp.scala:60 — `Files.list(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.iterator` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Files.list(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
  • Disposable created and abandoned in the function that made it optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/oci/ImageBuilder.scala:865 — `Files.list(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.iterator` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Files.list(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
  • Disposable created and abandoned in the function that made it optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/rubbish/RubbishTidyer.scala:53 — `Files.walk(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.iterator` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Files.walk(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
  • Disposable created and abandoned in the function that made it optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/rubbish/ArtifactRecency.scala:163 — `Files.list(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.iterator` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Files.list(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
  • Disposable created and abandoned in the function that made it optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/files/InstallPathBuilder.scala:381 — `Files.find(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.iterator` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Files.find(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
  • Disposable created and abandoned in the function that made it optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/utils/OsUtils.scala:137 — `Files.list(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.iterator` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Files.list(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
  • Disposable created and abandoned in the function that made it optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/heartbeat/WatcherProcess.scala:327 — `Files.walk(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.iterator` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Files.walk(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
  • Disposable created and abandoned in the function that made it optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/kafka/PlexCleaner.scala:213 — `Files.walk(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and it is held in `stream`, and every later use of `stream` in its block reads a member through it — it is never returned, passed, stored, captured by a lambda, reassigned or released, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Files.walk(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
  • Disposable created and abandoned in the function that made it optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/sampling/ChildProcessSampling.scala:130 — `Files.list(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.iterator` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Files.list(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
  • Disposable created and abandoned in the function that made it optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/sampling/BaseSamplers.scala:129 — `Files.list(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.iterator` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Files.list(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
  • Disposable created and abandoned in the function that made it optimus/platform/projects/utils/src/main/scala/optimus/platform/utils/ClassPathUtils.scala:127 — `new JarFile(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and it is held in `jar`, and every later use of `jar` in its block reads a member through it — it is never returned, passed, stored, captured by a lambda, reassigned or released, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(new JarFile(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
  • Disposable created and abandoned in the function that made it optimus/platform/projects/utils/src/main/scala/optimus/utils/FileUtils.scala:174 — `Files.walk(…)` opens something that has to be given back — a file descriptor, a socket, a directory handle — and its only use reads `.iterator` through it and drops it, so this expression both creates the value and is the last place that can release it, and does not. Every call leaks one more open handle until the collector happens to reach it: `Too many open files` under load, and on Windows a file that cannot be replaced or deleted while it is held. Open it with `scala.util.Using.resource(Files.walk(…)) { r => … }`, which releases it on every path including a throw, or hold it and call `.close()` in a `finally`.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×10
  • Duplicated block (16 lines × 2) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncElectronCompiler.scala:97 — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncElectronCompiler.scala:97-112 | optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncWebCompiler.scala:99-114 — before extracting anything, compare `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncElectronCompiler.scala` and `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncWebCompiler.scala` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (16 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:415 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:415-430 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:375-390 — before extracting anything, compare `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala` and `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 107 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:415` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (16 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/LambdaCompiler.scala:253 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/LambdaCompiler.scala:253-268 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/LambdaCompiler.scala:399-414 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (16 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:893 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:893-908 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:970-985 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:893` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:786 — optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:786-801 | optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:974-989 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:786` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (16 lines × 2) optimus/platform/projects/entityagent/src/main/java/optimus/deps/DynamicDependencyDiscoveryInstrumentation.java:108 — optimus/platform/projects/entityagent/src/main/java/optimus/deps/DynamicDependencyDiscoveryInstrumentation.java:108-123 | optimus/platform/projects/entityagent/src/main/java/optimus/deps/DynamicDependencyDiscoveryInstrumentation.java:139-154 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/entityagent/src/main/java/optimus/deps/DynamicDependencyDiscoveryInstrumentation.java:108` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/serialization/ByteArraySerDes.java:38 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/serialization/ByteArraySerDes.java:38-53 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/serialization/RawByteArraySerDes.java:39-54 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/serialization/ByteArraySerDes.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/serialization/RawByteArraySerDes.java` as WHOLE FILES: 83% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (16 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:41 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:41-56 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java:46-61 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (16 lines × 2) REDACTED:23 — REDACTED:23-38 | REDACTED:23-38 — before extracting anything, compare `REDACTED` and `REDACTED` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (16 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:324 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:324-339 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/NewIncomingBufferedData.java:244-259 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/NewIncomingBufferedData.java` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 157 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×9
  • Duplicated block (17 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:505 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:505-521 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala:546-562 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 153 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:505` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfilerData.scala:192 — optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfilerData.scala:192-208 | optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfilerData.scala:220-236 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfilerData.scala:192` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:241 — optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:241-257 | optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:356-372 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:241` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) optimus/platform/projects/platform/src/main/scala/optimus/platform/temporalSurface/TemporalSurfaceMatchers.scala:517 — optimus/platform/projects/platform/src/main/scala/optimus/platform/temporalSurface/TemporalSurfaceMatchers.scala:517-533 | optimus/platform/projects/platform/src/main/scala/optimus/platform/temporalSurface/TemporalSurfaceMatchers.scala:581-597 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/platform/src/main/scala/optimus/platform/temporalSurface/TemporalSurfaceMatchers.scala:517` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:383 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:383-399 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:415-431 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:383` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/LambdaCompiler.scala:627 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/LambdaCompiler.scala:627-643 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/LambdaCompiler.scala:677-693 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/LambdaCompiler.scala:627` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingInfo.java:82 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingInfo.java:82-98 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingIntegrityCheck.java:227-243 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingInfo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingIntegrityCheck.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (17 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/PersistentAsyncServer.java:599 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/PersistentAsyncServer.java:599-615 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/PersistentAsyncServer.java:667-683 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/PersistentAsyncServer.java:599` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (17 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ClassParser.java:331 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ClassParser.java:331-347 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ObjectDefParser2.java:274-290 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ClassParser.java:331` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
GD1 · Unfinished & placeholder code · Unfinished stub · ×9
  • Unfinished stub — body is `???` optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincVirtualFiles.scala:104 — `contentHash` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincVirtualFiles.scala:105 — `input` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincVirtualFiles.scala:115 — `contentHash` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` optimus/platform/projects/core/src/main/scala/optimus/core/CoreSupport.scala:28 — `pluginShouldHaveReplacedThis` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` optimus/platform/projects/core/src/main/scala/optimus/core/NodeFutureSystem.scala:19 — `await` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is NotImplementedError optimus/platform/projects/core/src/main/scala/optimus/graph/AsyncPipeline.scala:389 — `mapperNode` is a shipped member whose whole body is still NotImplementedError, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` optimus/platform/projects/priql/src/main/scala/optimus/platform/RelationKeys.scala:273 — `of` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` optimus/platform/projects/talks/src/main/scala/scala/days/live/ScalaDaysDemo.scala:56 — `extractSignature` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is `???` optimus/platform/projects/talks/src/main/scala/scala/days/live/ScalaDaysDemo.scala:57 — `doCompile` is a shipped member whose whole body is still `???`, and nothing in the repository overrides it — generated scaffolding that was never completed. Implement it or remove the dead surface.
IC1 · Incompleteness & stubs · Unfinished stub · ×9
  • Unfinished stub — body is ??? / NotImplementedError optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincVirtualFiles.scala:104 — `contentHash` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincVirtualFiles.scala:105 — `input` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincVirtualFiles.scala:115 — `contentHash` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError optimus/platform/projects/core/src/main/scala/optimus/core/CoreSupport.scala:28 — `pluginShouldHaveReplacedThis` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError optimus/platform/projects/core/src/main/scala/optimus/core/NodeFutureSystem.scala:19 — `await` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError optimus/platform/projects/core/src/main/scala/optimus/graph/AsyncPipeline.scala:389 — `mapperNode` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError optimus/platform/projects/priql/src/main/scala/optimus/platform/RelationKeys.scala:273 — `of` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError optimus/platform/projects/talks/src/main/scala/scala/days/live/ScalaDaysDemo.scala:56 — `extractSignature` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — body is ??? / NotImplementedError optimus/platform/projects/talks/src/main/scala/scala/days/live/ScalaDaysDemo.scala:57 — `doCompile` is a shipped method whose whole body is `???` (or throws NotImplementedError), and nothing in the repository overrides it — scaffolding that was never completed. Implement it or remove the dead surface.
S1 · Web-Security Posture · Weak hash algorithm · ×9
  • Weak hash algorithm optimus/platform/projects/core/src/main/scala/msjava/MSUuidGenerator.scala:36 — MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`MessageDigest.getInstance("SHA-256")`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
  • Weak hash algorithm optimus/platform/projects/dal_client/src/main/scala/optimus/session/utils/ClientEnvironment.scala:127 — MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`MessageDigest.getInstance("SHA-256")`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
  • Weak hash algorithm optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:490 — MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`MessageDigest.getInstance("SHA-256")`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
  • Weak hash algorithm optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:456 — MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`MessageDigest.getInstance("SHA-256")`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
  • Weak hash algorithm optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMProxyGenerator.scala:610 — MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`MessageDigest.getInstance("SHA-256")`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
  • Weak hash algorithm optimus/platform/projects/utils/src/main/scala/optimus/utils/HashUtil.scala:22 — MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`MessageDigest.getInstance("SHA-256")`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
  • Weak hash algorithm REDACTED:37 — MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`MessageDigest.getInstance("SHA-256")`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
  • Weak hash algorithm REDACTED:30 — MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`MessageDigest.getInstance("SHA-256")`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
  • Weak hash algorithm REDACTED:30 — MD5/SHA1 is computed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ (`MessageDigest.getInstance("SHA-256")`) for content integrity, or a KDF (bcrypt/Argon2/scrypt) for password storage. If it only derives a non-security identifier (a cache key, an avatar URL, an ETag), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as xxhash or murmurhash says it in code — since the algorithm alone cannot distinguish the two uses. Where a protocol this code does not own fixes the digest (a k-anonymity range query, a legacy signature format), the protocol decides; say so beside the call.
X3 · Exception handling · Swallowed exception (empty catch) · ×9
  • Swallowed exception (empty catch) optimus/platform/projects/core/src/main/scala/optimus/graph/OGSchedulerContext.java:900 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) optimus/platform/projects/core/src/main/scala/optimus/graph/ScenarioStackShared.scala:178 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) optimus/platform/projects/core/src/main/scala/optimus/platform/util/DiagnosticUtil.scala:51 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) optimus/platform/projects/core/src/main/scala/optimus/platform/util/DiagnosticUtil.scala:64 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) REDACTED:418 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/heartbeat/WatcherProcess.scala:162 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/kafka/CrumbPlexer.scala:282 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) optimus/platform/projects/instrumentation/src/main/scala/optimus/platform/util/InfoDump.scala:56 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/DebuggerUI.scala:451 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
D4 · Code Duplication · Duplicated block (20 lines × 2) · ×8
  • Duplicated block (20 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/ZipIterator.scala:102 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/ZipIterator.scala:102-121 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/ZipIterator.scala:102-121 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/ZipIterator.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/ZipIterator.scala` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (20 lines × 2) optimus/platform/projects/core_macro/src/main/scala/optimus/utils/MacroUtils.scala:188 — optimus/platform/projects/core_macro/src/main/scala/optimus/utils/MacroUtils.scala:188-207 | optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/TypedUtils.scala:1124-1143 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core_macro/src/main/scala/optimus/utils/MacroUtils.scala:188` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (20 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:276 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:276-295 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:301-320 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (20 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:587 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:587-606 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:613-632 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (20 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:707 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:707-726 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:733-752 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (20 lines × 2) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:307 — optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:307-326 | optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:747-766 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:307` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (20 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ClassParser.java:217 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ClassParser.java:217-236 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ClassParser.java:267-286 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ClassParser.java:217` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (20 lines × 2) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/util/internal/SystemPropertyUtils.java:138 — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/util/internal/SystemPropertyUtils.java:138-157 | optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/util/internal/SystemPropertyUtils.java:174-193 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/util/internal/SystemPropertyUtils.java:138` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `defaultValue` to `int` in one and `long` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×8
  • Duplicated block (18 lines × 2) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/cpp/gcc/GccCompiler.scala:78 — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/cpp/gcc/GccCompiler.scala:78-95 | optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/cpp/vc/VcCompiler.scala:69-86 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/cpp/gcc/GccCompiler.scala:78` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:65 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:65-82 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:65-82 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 252 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (18 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:27 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:27-44 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:25-42 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (18 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/ZipIterator.scala:47 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/ZipIterator.scala:47-64 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/ZipIterator.scala:47-64 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/ZipIterator.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/ZipIterator.scala` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (18 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/SingletonProjectionRewriter.scala:90 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/SingletonProjectionRewriter.scala:90-107 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/LinkageSubqueryRewriter.scala:110-127 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (18 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALBinder.scala:261 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALBinder.scala:261-278 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/sampling/DALSamplingReducer.scala:122-139 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: the declarations holding them bind `s` to `: others) = method.methodArgs val source = super.visitElement(s.param) val projection = convertToSequence(source) if ((projection eq null) || ((projection.select.orderBy ne null) && projection.select.orderBy.nonEmpty)` in one and `: nArg :: _) = method.methodArgs val source = super.visitElement(s.param) val projection = convertToSequence(source) if ((projection eq null) || (projection.select.take ne null)` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (18 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:545 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:545-563 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:658-675 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:545` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (18 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java:222 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java:222-239 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java:157-174 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 71 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×8
  • Duplicated block (15 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:62 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:62-76 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:50-64 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (15 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/DbQueryTreeReducerBase.scala:283 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/DbQueryTreeReducerBase.scala:283-297 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/pubsub/ClientSideFilterRewriter.scala:46-60 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (15 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableProvider.scala:610 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableProvider.scala:610-624 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/internal/RelationalUtils.scala:283-297 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/internal/RelationalUtils.scala:283` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccExecutionProvider.scala:89 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccExecutionProvider.scala:89-103 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/FullTextSearchExecutionProvider.scala:74-88 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccExecutionProvider.scala:89` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccExecutionProvider.scala:104` calls `Linkage`, `temporalityMap` and `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/FullTextSearchExecutionProvider.scala:89` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (15 lines × 2) optimus/platform/projects/entityagent/src/main/java/optimus/CollectionInjector.java:197 — optimus/platform/projects/entityagent/src/main/java/optimus/CollectionInjector.java:197-211 | optimus/platform/projects/entityagent/src/main/java/optimus/CollectionInjector.java:230-244 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/entityagent/src/main/java/optimus/CollectionInjector.java:197` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:84 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:84-98 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:94-108 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 40 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (15 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:211 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:211-225 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java:205-219 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 105 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:211` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (15 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:420 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:420-434 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java:394-408 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 105 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:420` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `key` to `DHTKey` in one and `int` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:435` calls `of`, `toString` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java:409` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (21 lines × 2) · ×7
  • Duplicated block (21 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OSeq.scala:65 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OSeq.scala:65-85 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OSeq.scala:70-90 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OSeq.scala` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (21 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:248 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:248-268 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:246-266 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 252 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:248` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (21 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PubSubProtoSerialization.scala:289 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PubSubProtoSerialization.scala:289-309 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PubSubProtoSerialization.scala:358-378 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PubSubProtoSerialization.scala:289` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (21 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:485 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:485-505 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:509-529 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (21 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/EntityMultiRelation.scala:793 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/EntityMultiRelation.scala:793-813 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/EntityMultiRelation.scala:833-853 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/EntityMultiRelation.scala:793` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (21 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/DHTKeyCuckooBase.java:220 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/DHTKeyCuckooBase.java:220-240 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/CuckooBase.java:250-270 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/DHTKeyCuckooBase.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/CuckooBase.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 46 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/DHTKeyCuckooBase.java:220` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (21 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/BZip2.java:90 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/BZip2.java:90-110 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/Zip.java:70-90 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/BZip2.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/Zip.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/BZip2.java:90` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×7
  • Duplicated block (19 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:140 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:140-158 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala:125-143 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 165 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (19 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:493 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:493-511 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:459-477 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (19 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/Command.scala:777 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/Command.scala:777-795 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/ExpressionSqlFormatter.scala:370-388 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/Command.scala:777` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (19 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:84 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:84-102 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:275-293 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:84` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (19 lines × 2) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala:376 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala:376-394 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchLanguage.scala:210-228 — before extracting anything, compare `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala` and `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchLanguage.scala` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala:376` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (19 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:73 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:73-91 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java:78-96 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:73` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (19 lines × 2) optimus/silverking/projects/silverking_utils/src/main/java/com/ms/silverking/io/StreamUtil.java:191 — optimus/silverking/projects/silverking_utils/src/main/java/com/ms/silverking/io/StreamUtil.java:191-209 | optimus/silverking/projects/silverking_utils/src/main/java/com/ms/silverking/io/StreamUtil.java:228-246 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking_utils/src/main/java/com/ms/silverking/io/StreamUtil.java:191` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D15 · Churn × Complexity Hotspots · Hotspot · ×5
  • Hotspot: optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/PersistBlock.scala optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/PersistBlock.scala:538 — optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/PersistBlock.scala changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 33 in AbstractPersistBlock.closeAndCreateAsserts at line 538. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2025-09-25..2025-12-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-09-25 12:09:27 -05:00' --until='2025-12-24 12:09:27 -05:00' --full-history --no-merges -- optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/PersistBlock.scala`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PropertyMapProtoSerialization.scala optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PropertyMapProtoSerialization.scala:59 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PropertyMapProtoSerialization.scala changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 30 in ProtoPickleSerializer.propertiesToProto at line 59. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2025-09-25..2025-12-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-09-25 12:09:27 -05:00' --until='2025-12-24 12:09:27 -05:00' --full-history --no-merges -- optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PropertyMapProtoSerialization.scala`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/zookeeper/BreadcrumbsZkClient.scala optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/zookeeper/BreadcrumbsZkClient.scala:263 — optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/zookeeper/BreadcrumbsZkClient.scala changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in BreadcrumbsPropertyConfigurer.implFromConfig0 at line 263. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2025-09-25..2025-12-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-09-25 12:09:27 -05:00' --until='2025-12-24 12:09:27 -05:00' --full-history --no-merges -- optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/zookeeper/BreadcrumbsZkClient.scala`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: optimus/platform/projects/core/src/main/scala/optimus/platform/Scenario.scala optimus/platform/projects/core/src/main/scala/optimus/platform/Scenario.scala:445 — optimus/platform/projects/core/src/main/scala/optimus/platform/Scenario.scala changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in Scenario.validate at line 445. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2025-09-25..2025-12-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-09-25 12:09:27 -05:00' --until='2025-12-24 12:09:27 -05:00' --full-history --no-merges -- optimus/platform/projects/core/src/main/scala/optimus/platform/Scenario.scala`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/ValueTreeTable.scala optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/ValueTreeTable.scala:127 — optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/ValueTreeTable.scala changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in ValueViewRow.extractValues at line 127. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2025-09-25..2025-12-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2025-09-25 12:09:27 -05:00' --until='2025-12-24 12:09:27 -05:00' --full-history --no-merges -- optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/ValueTreeTable.scala`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×5
  • Duplicated block (8 lines × 3) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:681 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:681-688 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:697-704 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:720-727 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:681` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 3) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1181 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1181-1188 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1709-1716 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1886-1893 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (8 lines × 3) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/StandardDeviation.scala:40 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/StandardDeviation.scala:40-47 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/StandardDeviation.scala:102-109 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/StandardDeviation.scala:165-172 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/StandardDeviation.scala:40` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 3) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:764 — optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:764-771 | optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:848-855 | optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:950-957 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:764` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `entries` to `List<K>` in one and `List<KVLargeEntry<K>>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (8 lines × 3) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/management/aws/MultiInstanceStarter.java:74 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/management/aws/MultiInstanceStarter.java:74-81 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/management/aws/MultiInstanceStopper.java:72-79 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/management/aws/MultiInstanceTerminator.java:74-82 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (26 lines × 2) · ×4
  • Duplicated block (26 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:515 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:515-540 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:518-543 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 252 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:515` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (26 lines × 2) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:734 — optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:734-759 | optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:896-921 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:734` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (26 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/PrimarySecondaryIPListPair.java:107 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/PrimarySecondaryIPListPair.java:107-132 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/PrimarySecondaryListPair.java:129-154 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/PrimarySecondaryIPListPair.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/PrimarySecondaryListPair.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 44 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/PrimarySecondaryIPListPair.java:107` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `p0` to `PrimarySecondaryIPListPair` in one and `PrimarySecondaryListPair` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (26 lines × 2) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/scv/SecureCredentialsVault.java:110 — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/scv/SecureCredentialsVault.java:110-135 | optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/scv/SecureCredentialsVault.java:152-177 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/scv/SecureCredentialsVault.java:110` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (22 lines × 2) · ×4
  • Duplicated block (22 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:186 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:186-207 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:184-205 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 252 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:186` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (22 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:50 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:50-71 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala:36-57 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 165 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (22 lines × 2) optimus/platform/projects/platform/src/main/scala/optimus/platform/Apars.scala:172 — optimus/platform/projects/platform/src/main/scala/optimus/platform/Apars.scala:172-193 | optimus/platform/projects/platform/src/main/scala/optimus/platform/Apars.scala:218-239 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/platform/src/main/scala/optimus/platform/Apars.scala:172` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (22 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/numeric/StatSeries.java:145 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/numeric/StatSeries.java:145-166 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/numeric/StatSeries.java:169-190 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (9 lines × 3) · ×4
  • Duplicated block (9 lines × 3) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:126 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:126-134 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALReferenceReducer.scala:185-193 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchReferenceReducer.scala:133-141 — before extracting anything, compare `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala` and `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALReferenceReducer.scala` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
  • Duplicated block (9 lines × 3) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:313 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:313-321 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java:279-287 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/NewIncomingBufferedData.java:233-241 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 94 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:313` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 3) optimus/dht/projects/common3/src/main/java/optimus/dht/common/util/transport/ByteArrayMessageStream.java:59 — optimus/dht/projects/common3/src/main/java/optimus/dht/common/util/transport/ByteArrayMessageStream.java:59-67 | optimus/dht/projects/common3/src/main/java/optimus/dht/common/util/transport/ByteArraysMessageStream.java:79-87 | optimus/dht/projects/common3/src/main/java/optimus/dht/common/util/transport/ByteBuffersMessageStream.java:76-84 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
  • Duplicated block (9 lines × 3) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/serialization/IntegerSerDes.java:36 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/serialization/IntegerSerDes.java:36-44 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/serialization/LongSerDes.java:36-44 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/serialization/ShortSerDes.java:36-44 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (5 lines × 4) · ×4
  • Duplicated block (5 lines × 4) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:40 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:40-44 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:76-80 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:112-116 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:148-152 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:40` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 4) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:40 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:40-44 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:76-80 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:112-116 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:148-152 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:40` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 4) optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1244 — optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1244-1248 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1366-1370 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1535-1539 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1754-1758 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (5 lines × 4) optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform/DALExample.scala:96 — optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform/DALExample.scala:96-100 | optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform/DALExample.scala:113-117 | optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform/DALExample.scala:125-129 | optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform/DALExample.scala:140-144 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×4
  • Duplicated block (6 lines × 3) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:233 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:233-238 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java:227-232 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java:162-167 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntArrayCuckoo.java` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 105 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntArrayDHTKeyCuckoo.java:233` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 3) optimus/platform/projects/entityagent/src/main/java/optimus/deps/OptimusDependencyDiscoveryClassVisitor.java:41 — optimus/platform/projects/entityagent/src/main/java/optimus/deps/OptimusDependencyDiscoveryClassVisitor.java:41-46 | optimus/platform/projects/entityagent/src/main/java/optimus/deps/OptimusDependencyDiscoveryFieldVisitor.java:40-45 | optimus/platform/projects/entityagent/src/main/java/optimus/deps/OptimusDependencyDiscoveryMethodVisitor.java:58-63 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/entityagent/src/main/java/optimus/deps/OptimusDependencyDiscoveryClassVisitor.java:41` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 3) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/DHTKeyEntryBase.java:45 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/DHTKeyEntryBase.java:45-50 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/common/SimpleKey.java:72-77 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/MessageGroupKeyEntry.java:66-71 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 3) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java:113 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java:113-118 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DebugKey.java:183-188 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingInfo.java:128-133 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingInfo.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Duplicated block (30 lines × 2) · ×3
  • Duplicated block (30 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:89 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:89-118 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:88-117 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 252 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:89` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (30 lines × 2) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:56 — optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:56-85 | optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:148-177 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:56` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (30 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:353 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:353-382 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:313-342 — before extracting anything, compare `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala` and `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 107 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:353` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (27 lines × 2) · ×3
  • Duplicated block (27 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:387 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:387-413 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:420-446 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (27 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:183 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:183-209 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/management/MetaToolModuleBase.java:137-163 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:183` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (27 lines × 2) optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform03/relational/Data.scala:245 — optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform03/relational/Data.scala:245-271 | optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform03/relational/Data.scala:277-303 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform03/relational/Data.scala:245` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (25 lines × 2) · ×3
  • Duplicated block (25 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:148 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:148-172 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:122-146 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (25 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/DependencyWatcher.java:354 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/DependencyWatcher.java:354-378 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/ManagerModeDependencyWatcher.java:246-270 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/DependencyWatcher.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/ManagerModeDependencyWatcher.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 44 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (25 lines × 2) optimus/dht/projects/common3/src/main/java/optimus/dht/common/api/kv/KVRequestType.java:25 — optimus/dht/projects/common3/src/main/java/optimus/dht/common/api/kv/KVRequestType.java:25-49 | optimus/dht/projects/common3/src/main/java/optimus/dht/common/api/kv/KVResponseType.java:22-46 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (16–17 lines × 2) · ×3
  • Duplicated block (16–17 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:470 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:470-486 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:439-454 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:488` calls `collect` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:455` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (16–17 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:164 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:164-179 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:233-249 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:164` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16–17 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/fsm/IntegerToIntegerMapElement.java:40 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/fsm/IntegerToIntegerMapElement.java:40-55 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/fsm/KeyToIntegerMapElement.java:41-57 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (14 lines × 3) · ×3
  • Duplicated block (14 lines × 3) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/TableColumns.scala:290 — optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/TableColumns.scala:290-303 | optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/TableColumns.scala:351-364 | optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/TableColumns.scala:414-427 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/TableColumns.scala:290` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 3) optimus/platform/projects/core/src/main/scala/intellij/only/DoNotUseIJCompileTimeEntityInjectedImplementation.scala:36 — optimus/platform/projects/core/src/main/scala/intellij/only/DoNotUseIJCompileTimeEntityInjectedImplementation.scala:36-49 | optimus/platform/projects/core/src/main/scala/intellij/only/DoNotUseIJNodeFunctionConversions.scala:21-56 | optimus/platform/projects/scala_compat/src/main/scala-2.12/optimus/scalacompat/collection/DummyTraversable.scala:21-75 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (14 lines × 3) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:114 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:114-127 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:194-207 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/management/MetaToolModuleBase.java:148-161 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:114` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13 lines × 4) · ×3
  • Duplicated block (13 lines × 4) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:47 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:47-59 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:83-95 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:119-131 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Max.scala:155-167 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (13 lines × 4) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:47 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:47-59 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:83-95 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:119-131 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Min.scala:155-167 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (13 lines × 4) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java:85 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java:85-97 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DebugKey.java:162-174 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingInfo.java:107-119 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingIntegrityCheck.java:252-264 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingInfo.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×3
  • Duplicated block (10 lines × 3) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:239 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:239-248 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:541-550 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:672-681 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/FunctionFormatter.scala:239` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 3) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:143 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:143-152 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:200-209 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:257-266 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (10 lines × 3) optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:163 — optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:163-172 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:202-211 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:242-251 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:163` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 4) · ×3
  • Duplicated block (9 lines × 4) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:146 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:146-154 | optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:259-268 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala:131-139 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala:241-250 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 165 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:146` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 4) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:221 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:221-229 | optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:259-267 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:195-203 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:233-241 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:221` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 4) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/ZipIterator.scala:37 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/ZipIterator.scala:37-45 | optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/ZipIterator.scala:92-100 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/ZipIterator.scala:37-45 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/ZipIterator.scala:92-100 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/ZipIterator.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/ZipIterator.scala` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 47 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/ZipIterator.scala:37` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7–8 lines × 2) · ×3
  • Duplicated block (7–8 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/platform/relational/AbstractLambdaReifier.scala:342 — optimus/platform/projects/core/src/main/scala/optimus/platform/relational/AbstractLambdaReifier.scala:342-348 | optimus/platform/projects/core/src/main/scala/optimus/platform/relational/AbstractLambdaReifier.scala:351-358 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/platform/relational/AbstractLambdaReifier.scala:351` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (7–8 lines × 2) optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/RangeQuery.scala:257 — optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/RangeQuery.scala:257-264 | optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/RangeQuery.scala:313-319 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/RangeQuery.scala:257` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (7–8 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/DefaultQueryProvider.scala:428 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/DefaultQueryProvider.scala:428-434 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/DefaultQueryProvider.scala:493-500 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×3
  • Duplicated block (7 lines × 3) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/TableColumns.scala:260 — optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/TableColumns.scala:260-266 | optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/TableColumns.scala:320-327 | optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/TableColumns.scala:383-390 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/TableColumns.scala:260` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 3) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:532 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:532-538 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:555-561 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:578-584 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:532` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 3) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:157 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:157-163 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALReferenceReducer.scala:217-223 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchReferenceReducer.scala:163-169 — before extracting anything, compare `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala` and `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALReferenceReducer.scala` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:157` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:164` calls `FuncElement`, `List`, `bindMember` and `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchReferenceReducer.scala:170` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (5 lines × 3) · ×3
  • Duplicated block (5 lines × 3) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/StandardDeviation.scala:55 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/StandardDeviation.scala:55-59 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/StandardDeviation.scala:117-121 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/StandardDeviation.scala:180-184 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/StandardDeviation.scala:55` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 3) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableRewriter.scala:233 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableRewriter.scala:233-237 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableRewriter.scala:276-280 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableRewriter.scala:319-323 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (5 lines × 3) optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:199 — optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:199-203 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:239-243 | optimus/platform/projects/entityagent/src/main/java/optimus/debug/InstrumentationInjectorAdapter.java:195-199 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart.
IC1 · Incompleteness & stubs · Empty method body · ×3
  • Empty method body — does nothing with its inputs optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/auth/CrumbsAuthProvider.scala:23 — `initAuth` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
  • Empty method body — does nothing with its inputs optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/GraphDiagnostics.scala:49 — `report` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
  • Empty method body — does nothing with its inputs optimus/platform/projects/platform/src/main/scala/optimus/platform/ReplDsl.scala:46 — `push` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
AC6 · Visual & motion safety · Focus outline removed in CSS without a · ×2
  • Focus outline removed in CSS without a :focus replacement optimus/platform/projects/core/src/main/resources/css/gridprofiler.css:63 — `.toggleBtn` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
  • Focus outline removed in CSS without a :focus replacement optimus/buildtool/projects/htmlreport/src/main/resources/org/gradle/reporting/base-style.css:93 — `ul.tabLinks a` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
D1 · Cyclomatic Complexity · OptimusSeqUtils.mapConserve (cyclomatic 23) · ×2
  • OptimusSeqUtils.mapConserve (cyclomatic 23) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqUtils.scala:29 — OptimusSeqUtils.mapConserve has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
  • OptimusSeqUtils.mapConserve (cyclomatic 23) optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqUtils.scala:31 — OptimusSeqUtils.mapConserve has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D2 · Cognitive Complexity · OptimusSeqUtils.mapConserve (cognitive 57) · ×2
  • OptimusSeqUtils.mapConserve (cognitive 57) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqUtils.scala:29 — OptimusSeqUtils.mapConserve has cognitive complexity 57 (threshold 15). Drivers by points: if/else 18 (46 pts), loops 2 (6 pts), boolean chains 3, match/switch 1 (2 pts) (nesting depth added 33). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
  • OptimusSeqUtils.mapConserve (cognitive 57) optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqUtils.scala:31 — OptimusSeqUtils.mapConserve has cognitive complexity 57 (threshold 15). Drivers by points: if/else 18 (46 pts), loops 2 (6 pts), boolean chains 3, match/switch 1 (2 pts) (nesting depth added 33). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OptimusSeq.zipAll (cognitive 33) · ×2
  • OptimusSeq.zipAll (cognitive 33) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:509 — OptimusSeq.zipAll has cognitive complexity 33 (threshold 15). Drivers by points: if/else 11 (23 pts), loops 2 (6 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
  • OptimusSeq.zipAll (cognitive 33) optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:513 — OptimusSeq.zipAll has cognitive complexity 33 (threshold 15). Drivers by points: if/else 11 (23 pts), loops 2 (6 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InfoDumper.dump (cognitive 32) · ×2
  • InfoDumper.dump (cognitive 32) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/InfoDumper.scala:73 — InfoDumper.dump has cognitive complexity 32 (threshold 15). Drivers by points: if/else 10 (21 pts), loops 2 (5 pts), error handling 1 (3 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 17). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function. This shape REPEATS in the file: one other method here (InfoDumper.dump) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
  • InfoDumper.dump (cognitive 32) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/InfoDumper.scala:247 — InfoDumper.dump has cognitive complexity 32 (threshold 15). Drivers by points: if/else 10 (21 pts), loops 2 (5 pts), error handling 1 (3 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 17). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function. This shape REPEATS in the file: one other method here (InfoDumper.dump) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · OptimusArraysSeq.sliceSafe (cognitive 20) · ×2
  • OptimusArraysSeq.sliceSafe (cognitive 20) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:343 — OptimusArraysSeq.sliceSafe has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (15 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
  • OptimusArraysSeq.sliceSafe (cognitive 20) optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:318 — OptimusArraysSeq.sliceSafe has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (15 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OptimusArraySeq.filter0 (cognitive 19) · ×2
  • OptimusArraySeq.filter0 (cognitive 19) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:81 — OptimusArraySeq.filter0 has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (13 pts), boolean chains 3, loops 3 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
  • OptimusArraySeq.filter0 (cognitive 19) optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala:67 — OptimusArraySeq.filter0 has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (13 pts), boolean chains 3, loops 3 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Builder1D.result (cognitive 18) · ×2
  • Builder1D.result (cognitive 18) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:109 — Builder1D.result has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (9 pts), loops 2 (4 pts), boolean chains 3, match/switch 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
  • Builder1D.result (cognitive 18) optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala:127 — Builder1D.result has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (9 pts), loops 2 (4 pts), boolean chains 3, match/switch 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OptimusSeq.tabulate (cognitive 16) · ×2
  • OptimusSeq.tabulate (cognitive 16) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:84 — OptimusSeq.tabulate has cognitive complexity 16 (threshold 15). Drivers by points: loops 3 (10 pts), if/else 4 (5 pts), match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
  • OptimusSeq.tabulate (cognitive 16) optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:83 — OptimusSeq.tabulate has cognitive complexity 16 (threshold 15). Drivers by points: loops 3 (10 pts), if/else 4 (5 pts), match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · OptimusArraysSeq.equals (cognitive 16) · ×2
  • OptimusArraysSeq.equals (cognitive 16) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:95 — OptimusArraysSeq.equals has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (7 pts), boolean chains 5, loops 2 (3 pts), match/switch 1 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
  • OptimusArraysSeq.equals (cognitive 16) optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:69 — OptimusArraysSeq.equals has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (7 pts), boolean chains 5, loops 2 (3 pts), match/switch 1 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Edited copy of a member (23 corresponding lines) · ×2
  • Edited copy of a member (23 corresponding lines) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:347 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:347-369 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:344-366 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (23 corresponding lines) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/numeric/StatSeries.java:192 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/numeric/StatSeries.java:192-214 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/numeric/StatSeries.java:216-238 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (26 corresponding lines) · ×2
  • Edited copy of a member (26 corresponding lines) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:510 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:510-540 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:513-543 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (26 corresponding lines) optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform03/relational/Data.scala:93 — optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform03/relational/Data.scala:93-119 | optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform03/relational/Data.scala:121-146 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (41 lines × 2) · ×2
  • Duplicated block (41 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/ProfilerTimings.scala:156 — optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/ProfilerTimings.scala:156-196 | optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/ProfilerTimings.scala:246-286 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/ProfilerTimings.scala:156` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (41 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/RedBlackSupport.scala:25 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/RedBlackSupport.scala:25-65 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/RedBlackSupport.scala:25-65 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/RedBlackSupport.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/RedBlackSupport.scala` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/RedBlackSupport.scala:25` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (29–33 lines × 2) · ×2
  • Duplicated block (29–33 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:318 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:318-346 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:375-407 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:318` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (29–33 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:282 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:282-310 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:335-367 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:282` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (24 lines × 2) · ×2
  • Duplicated block (24 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OSeq.scala:88 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OSeq.scala:88-111 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OSeq.scala:93-116 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OSeq.scala` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (24 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:39 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:39-62 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:115-138 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (21–22 lines × 2) · ×2
  • Duplicated block (21–22 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:487 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:487-508 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:491-511 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 252 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:487` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (21–22 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:403 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:403-424 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:375-395 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (15–16 lines × 2) · ×2
  • Duplicated block (15–16 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:451 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:451-466 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:422-436 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (15–16 lines × 2) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/util/internal/SystemPropertyUtils.java:101 — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/util/internal/SystemPropertyUtils.java:101-116 | optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/util/internal/SystemPropertyUtils.java:121-135 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/base/util/internal/SystemPropertyUtils.java:101` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `defaultValue` to `int` in one and `long` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (14–15 lines × 2) · ×2
  • Duplicated block (14–15 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:288 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:288-301 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala:305-319 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 153 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (14–15 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/LightLinkedBlockingQueue.java:145 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/LightLinkedBlockingQueue.java:145-158 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/LightLinkedBlockingQueue.java:174-188 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/LightLinkedBlockingQueue.java:145` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12–13 lines × 2) · ×2
  • Duplicated block (12–13 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:244 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:244-256 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:218-229 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:244` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12–13 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/StringUtil.java:103 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/StringUtil.java:103-114 | optimus/silverking/projects/silverking_utils/src/main/java/com/ms/silverking/text/CoreStringUtil.java:142-154 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/StringUtil.java:103` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 3) · ×2
  • Duplicated block (12 lines × 3) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Variance.scala:97 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Variance.scala:97-108 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Variance.scala:125-136 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Variance.scala:154-165 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/aggregation/Variance.scala:125` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 3) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:62 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:62-73 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALReferenceReducer.scala:70-81 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchReferenceReducer.scala:66-77 — before extracting anything, compare `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala` and `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALReferenceReducer.scala` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:62` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (10 lines × 4) · ×2
  • Duplicated block (10 lines × 4) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:202 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:202-211 | optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:239-248 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:176-185 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:213-222 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:202` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 4) optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:297 — optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:297-306 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:349-358 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:394-403 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:438-447 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:297` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 4) · ×2
  • Duplicated block (8 lines × 4) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:451 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:451-458 | optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:472-479 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:422-429 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:441-448 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:451` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 4) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1158 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1158-1165 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1334-1341 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1686-1693 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:1863-1870 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (7 lines × 4) · ×2
  • Duplicated block (7 lines × 4) optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:118 — optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:118-124 | optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:127-133 | optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:137-143 | optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:148-154 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:125` calls `Tuple7` and `optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:144` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (7 lines × 4) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:525 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:525-531 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:617-623 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:712-718 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:798-804 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:525` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (6–7 lines × 2) · ×2
  • Duplicated block (6–7 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/config/NodeCacheConfigs.scala:717 — optimus/platform/projects/core/src/main/scala/optimus/config/NodeCacheConfigs.scala:717-722 | optimus/platform/projects/core/src/main/scala/optimus/config/NodeCacheConfigs.scala:769-775 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/config/NodeCacheConfigs.scala:717` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (6–7 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:565 — optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:565-571 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:658-663 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:663` calls `args` and `optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:571` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6 lines × 5) · ×2
  • Duplicated block (6 lines × 5) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:239 — optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:239-244 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:278-283 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:328-333 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:382-387 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:443-448 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:239` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:284` calls `unpickle` and `optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:245` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (6 lines × 5) optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:110 — optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:110-115 | optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:118-123 | optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:127-132 | optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:137-142 | optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:148-153 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:116` calls `Tuple6` and `optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:133` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (31 lines × 2) · ×2
  • Duplicated block (31 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/proto/ExpressionDecoder.scala:194 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/proto/ExpressionDecoder.scala:194-224 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/proto/ExpressionEncoder.scala:233-263 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (31 lines × 2) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/message/KVValueResponse.java:28 — optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/message/KVValueResponse.java:28-58 | optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/message/KVValueStreamResponse.java:27-57 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `responses` to `List<KVLargeValue>` in one and `List<KVStreamValue<S>>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (16–18 lines × 2) · ×2
  • Duplicated block (16–18 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java:140 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java:140-155 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java:212-229 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java:140` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (16–18 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/DHTMetaReader.java:128 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/DHTMetaReader.java:128-143 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/DHTMetaWatcher.java:217-234 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (11 lines × 3) · ×2
  • Duplicated block (11 lines × 3) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:346 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:346-356 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java:318-328 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/NewIncomingBufferedData.java:266-276 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 94 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:346` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java:317` calls `bufferToString` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:345` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 3) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/LightLinkedBlockingQueue.java:109 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/LightLinkedBlockingQueue.java:109-119 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/LightLinkedBlockingQueue.java:142-152 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/LightLinkedBlockingQueue.java:171-181 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/LightLinkedBlockingQueue.java:109` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
X15 · Unvalidated length from an untrusted reader · Length read from the parsed input is spent without ever being bounded · ×2
  • Length read from the parsed input is spent without ever being bounded optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dal/DALCache.scala:379 — `entryLength` is read from the bytes being parsed at line 378 (`readInt`), then used to size an `Array.ofDim` at line 379 — and nowhere in its scope is `entryLength` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `entryLength` against the bytes actually remaining and a maximum the format allows before allocating.
  • Length read from the parsed input is spent without ever being bounded optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoPutMessageGroup.java:311 — `length` is read from the bytes being parsed at line 306 (`getInt`), then used to size a `new byte[]` at line 311 — and nowhere in its scope is `length` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `length` against the bytes actually remaining and a maximum the format allows before allocating.
AC3 · Page structure · Page without a main landmark · ×1
  • Page without a main landmark optimus/platform/projects/core/src/main/resources/html/gridprofiler.html:1 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
AC7 · A11y enforcement · Accessibility enforcement below the top rung · ×1
  • Accessibility enforcement below the top rung — No accessibility enforcement found — no accessibility linting at author time and no automated accessibility check in tests or CI. Add your UI toolkit's own accessibility assertion to the test suite (Flutter `meetsGuideline`, Espresso `AccessibilityChecks`, XCTest `performAccessibilityAudit`), then gate that test in the pipeline. What was searched, so you can tell an absence from a miss: the 4 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.
D1 · Cyclomatic Complexity · AdjustAST.transformStorableTemplate (cyclomatic 134) · ×1
  • AdjustAST.transformStorableTemplate (cyclomatic 134) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:790 — AdjustAST.transformStorableTemplate has cyclomatic complexity 134 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OptimusRefchecks.traverse (cyclomatic 90) · ×1
  • OptimusRefchecks.traverse (cyclomatic 90) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:799 — OptimusRefchecks.traverse has cyclomatic complexity 90 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · AutoAsync.transformSafe (cyclomatic 89) · ×1
  • AutoAsync.transformSafe (cyclomatic 89) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala:1641 — AutoAsync.transformSafe has cyclomatic complexity 89 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · OptimusRefchecks.checkDefDef (cyclomatic 89) · ×1
  • OptimusRefchecks.checkDefDef (cyclomatic 89) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:317 — OptimusRefchecks.checkDefDef has cyclomatic complexity 89 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TypeOps.fieldType (cyclomatic 88) · ×1
  • TypeOps.fieldType (cyclomatic 88) optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:49 — TypeOps.fieldType has cyclomatic complexity 88 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · StandardsTraverser.checkApplication (cyclomatic 62) · ×1
  • StandardsTraverser.checkApplication (cyclomatic 62) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/PostTyperCodingStandardsComponent.scala:274 — StandardsTraverser.checkApplication has cyclomatic complexity 62 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AbstractBitemporalSpace.unsafeMultipleUpdate (cyclomatic 55) · ×1
  • AbstractBitemporalSpace.unsafeMultipleUpdate (cyclomatic 55) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/bitemporal/BitemporalSpaceImpl.scala:307 — AbstractBitemporalSpace.unsafeMultipleUpdate has cyclomatic complexity 55 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · DefaultBinder.handleFuncCall (cyclomatic 51) · ×1
  • DefaultBinder.handleFuncCall (cyclomatic 51) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:72 — DefaultBinder.handleFuncCall has cyclomatic complexity 51 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · SimpleCodeMotion.transform (cyclomatic 50) · ×1
  • SimpleCodeMotion.transform (cyclomatic 50) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AsyncGraphComponent.scala:879 — SimpleCodeMotion.transform has cyclomatic complexity 50 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SerializedKeyBasedIndexOptimizer.handleSelect (cyclomatic 49) · ×1
  • SerializedKeyBasedIndexOptimizer.handleSelect (cyclomatic 49) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/SerializedKeyBasedIndexOptimizer.scala:48 — SerializedKeyBasedIndexOptimizer.handleSelect has cyclomatic complexity 49 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · EmbeddableTransformer.handleClassDef (cyclomatic 48) · ×1
  • EmbeddableTransformer.handleClassDef (cyclomatic 48) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/EmbeddableComponent.scala:105 — EmbeddableTransformer.handleClassDef has cyclomatic complexity 48 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ProductFormats.unmangle (cyclomatic 48) · ×1
  • ProductFormats.unmangle (cyclomatic 48) optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormats.scala:99 — ProductFormats.unmangle has cyclomatic complexity 48 (threshold 15). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D1 · Cyclomatic Complexity · Convertor.transform (cyclomatic 46) · ×1
  • Convertor.transform (cyclomatic 46) optimus/platform/projects/core/src/main/scala/optimus/platform/relational/AbstractLambdaReifier.scala:213 — Convertor.transform has cyclomatic complexity 46 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · JoinColumnView.createNewArray (cyclomatic 46) · ×1
  • JoinColumnView.createNewArray (cyclomatic 46) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:191 — JoinColumnView.createNewArray has cyclomatic complexity 46 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PropertyInfoTyper.infoType (cyclomatic 45) · ×1
  • PropertyInfoTyper.infoType (cyclomatic 45) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/provider/PropertyInfoProvider.scala:495 — PropertyInfoTyper.infoType has cyclomatic complexity 45 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DALRegisteredIndexBinder.handleFuncCall (cyclomatic 44) · ×1
  • DALRegisteredIndexBinder.handleFuncCall (cyclomatic 44) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALRegisteredIndexBinder.scala:30 — DALRegisteredIndexBinder.handleFuncCall has cyclomatic complexity 44 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · AdjustAST.transformSafe (cyclomatic 43) · ×1
  • AdjustAST.transformSafe (cyclomatic 43) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:1393 — AdjustAST.transformSafe has cyclomatic complexity 43 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PredicatePushdownOptimizer.handleSelect (cyclomatic 43) · ×1
  • PredicatePushdownOptimizer.handleSelect (cyclomatic 43) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PredicatePushdownOptimizer.scala:112 — PredicatePushdownOptimizer.handleSelect has cyclomatic complexity 43 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · JavaOpts.filterJavaRuntimeOptions (cyclomatic 40) · ×1
  • JavaOpts.filterJavaRuntimeOptions (cyclomatic 40) optimus/buildtool/projects/core/src/main/scala/optimus/buildtool/utils/JavaOpts.scala:220 — JavaOpts.filterJavaRuntimeOptions has cyclomatic complexity 40 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · NodeCacheConfigsParser.parseWithPropertyConfigs (cyclomatic 39) · ×1
  • NodeCacheConfigsParser.parseWithPropertyConfigs (cyclomatic 39) optimus/platform/projects/core/src/main/scala/optimus/config/NodeCacheConfigs.scala:944 — NodeCacheConfigsParser.parseWithPropertyConfigs has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ConstantNominator.traverse (cyclomatic 39) · ×1
  • ConstantNominator.traverse (cyclomatic 39) optimus/platform/projects/core/src/main/scala/optimus/platform/relational/AbstractLambdaReifier.scala:504 — ConstantNominator.traverse has cyclomatic complexity 39 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · PicklerSelector.getPickler (cyclomatic 39) · ×1
  • PicklerSelector.getPickler (cyclomatic 39) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PicklerSelector.scala:68 — PicklerSelector.getPickler has cyclomatic complexity 39 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · PicklerSelector.getUnpickler (cyclomatic 39) · ×1
  • PicklerSelector.getUnpickler (cyclomatic 39) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PicklerSelector.scala:148 — PicklerSelector.getUnpickler has cyclomatic complexity 39 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · OptimusRefchecks.checkKeyOrIndex (cyclomatic 38) · ×1
  • OptimusRefchecks.checkKeyOrIndex (cyclomatic 38) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:196 — OptimusRefchecks.checkKeyOrIndex has cyclomatic complexity 38 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · TopologyRingCreator.allocateSubPolicyMember (cyclomatic 38) · ×1
  • TopologyRingCreator.allocateSubPolicyMember (cyclomatic 38) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/TopologyRingCreator.java:1023 — TopologyRingCreator.allocateSubPolicyMember has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · IncomingBufferedData.readFromChannel (cyclomatic 37) · ×1
  • IncomingBufferedData.readFromChannel (cyclomatic 37) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java:104 — IncomingBufferedData.readFromChannel has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SelectorController.doSelection (cyclomatic 37) · ×1
  • SelectorController.doSelection (cyclomatic 37) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/SelectorController.java:166 — SelectorController.doSelection has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ZincCompiler.compile (cyclomatic 34) · ×1
  • ZincCompiler.compile (cyclomatic 34) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincCompiler.scala:92 — ZincCompiler.compile has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ErrorResultSerializer.deserialize (cyclomatic 34) · ×1
  • ErrorResultSerializer.deserialize (cyclomatic 34) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/CommandProtoSerialization.scala:54 — ErrorResultSerializer.deserialize has cyclomatic complexity 34 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing. This is NOT this file's highest cyclomatic complexity: ResultSerializer.deserialize (cyclomatic 68) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · StratosphereConfig.<init> (cyclomatic 34) · ×1
  • StratosphereConfig.<init> (cyclomatic 34) optimus/stratosphere/bootstrap/src/main/java/optimus/stratosphere/bootstrap/config/StratosphereConfig.java:139 — StratosphereConfig.<init> has cyclomatic complexity 34 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · AbstractSegment.retrieve (cyclomatic 34) · ×1
  • AbstractSegment.retrieve (cyclomatic 34) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/AbstractSegment.java:125 — AbstractSegment.retrieve has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AbstractPersistBlock.closeAndCreateAsserts (cyclomatic 33) · ×1
  • AbstractPersistBlock.closeAndCreateAsserts (cyclomatic 33) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/PersistBlock.scala:538 — AbstractPersistBlock.closeAndCreateAsserts has cyclomatic complexity 33 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · AsyncGraph.transformSafe (cyclomatic 33) · ×1
  • AsyncGraph.transformSafe (cyclomatic 33) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AsyncGraphComponent.scala:543 — AsyncGraph.transformSafe has cyclomatic complexity 33 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · OptimusExportInfo.buildMetadataMap (cyclomatic 33) · ×1
  • OptimusExportInfo.buildMetadataMap (cyclomatic 33) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusExportInfoComponent.scala:137 — OptimusExportInfo.buildMetadataMap has cyclomatic complexity 33 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · ProtoPickleSerializer.protoToProperties (cyclomatic 32) · ×1
  • ProtoPickleSerializer.protoToProperties (cyclomatic 32) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PropertyMapProtoSerialization.scala:393 — ProtoPickleSerializer.protoToProperties has cyclomatic complexity 32 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · SubqueryMerger.canMergeWithFrom (cyclomatic 31) · ×1
  • SubqueryMerger.canMergeWithFrom (cyclomatic 31) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/RedundantSubqueryRemover.scala:99 — SubqueryMerger.canMergeWithFrom has cyclomatic complexity 31 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · InstrumentationInjector.transform (cyclomatic 31) · ×1
  • InstrumentationInjector.transform (cyclomatic 31) optimus/platform/projects/entityagent/src/main/java/optimus/debug/InstrumentationInjector.java:46 — InstrumentationInjector.transform has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · NodeMenu.create (cyclomatic 29) · ×1
  • NodeMenu.create (cyclomatic 29) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeMenu.scala:103 — NodeMenu.create has cyclomatic complexity 29 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · DALProvider.knownProjectorToLambda (cyclomatic 29) · ×1
  • DALProvider.knownProjectorToLambda (cyclomatic 29) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/DALProvider.scala:281 — DALProvider.knownProjectorToLambda has cyclomatic complexity 29 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ClassParser.valueForDef (cyclomatic 29) · ×1
  • ClassParser.valueForDef (cyclomatic 29) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ClassParser.java:292 — ClassParser.valueForDef has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · JvmDependenciesLoader.load (cyclomatic 28) · ×1
  • JvmDependenciesLoader.load (cyclomatic 28) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/dependencies/JvmDependenciesLoader.scala:122 — JvmDependenciesLoader.load has cyclomatic complexity 28 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · ScopeDefinitionCompiler.checkScopes (cyclomatic 28) · ×1
  • ScopeDefinitionCompiler.checkScopes (cyclomatic 28) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ScopeDefinitionCompiler.scala:311 — ScopeDefinitionCompiler.checkScopes has cyclomatic complexity 28 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · NotificationStreamImpl.handlePubSubResult (cyclomatic 28) · ×1
  • NotificationStreamImpl.handlePubSubResult (cyclomatic 28) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/pubsub/NotificationStreamImpl.scala:235 — NotificationStreamImpl.handlePubSubResult has cyclomatic complexity 28 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ContextualChecker.traverse (cyclomatic 28) · ×1
  • ContextualChecker.traverse (cyclomatic 28) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/refchecks/ContextualChecks.scala:73 — ContextualChecker.traverse has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ExcelReaderIterable.convertItemValue (cyclomatic 28) · ×1
  • ExcelReaderIterable.convertItemValue (cyclomatic 28) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/excel/ExcelMultiRelation.scala:186 — ExcelReaderIterable.convertItemValue has cyclomatic complexity 28 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · SpecialElementRewriter.handleConditional (cyclomatic 28) · ×1
  • SpecialElementRewriter.handleConditional (cyclomatic 28) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/SpecialElementRewriter.scala:84 — SpecialElementRewriter.handleConditional has cyclomatic complexity 28 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · PersistentAsyncServer.createConnection (cyclomatic 28) · ×1
  • PersistentAsyncServer.createConnection (cyclomatic 28) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/PersistentAsyncServer.java:559 — PersistentAsyncServer.createConnection has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CopyDynamic.extract (cyclomatic 27) · ×1
  • CopyDynamic.extract (cyclomatic 27) optimus/platform/projects/platform/src/main/scala/optimus/platform/internal/CopyMethodMacros.scala:27 — CopyDynamic.extract has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DefaultBinder.bindJoin (cyclomatic 27) · ×1
  • DefaultBinder.bindJoin (cyclomatic 27) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:1039 — DefaultBinder.bindJoin has cyclomatic complexity 27 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · RelationalUtils.convertItemValue (cyclomatic 27) · ×1
  • RelationalUtils.convertItemValue (cyclomatic 27) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/internal/RelationalUtils.scala:78 — RelationalUtils.convertItemValue has cyclomatic complexity 27 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ExpressionChecker.handleFuncCall (cyclomatic 27) · ×1
  • ExpressionChecker.handleFuncCall (cyclomatic 27) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala:334 — ExpressionChecker.handleFuncCall has cyclomatic complexity 27 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · TopologyRingCreator.doAllocation (cyclomatic 27) · ×1
  • TopologyRingCreator.doAllocation (cyclomatic 27) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/TopologyRingCreator.java:774 — TopologyRingCreator.doAllocation has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BackgroundProcess._startWithRetry (cyclomatic 26) · ×1
  • BackgroundProcess._startWithRetry (cyclomatic 26) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/utils/process/BackgroundProcess.scala:58 — BackgroundProcess._startWithRetry has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ExperimentalAsyncIterator2.buf (cyclomatic 26) · ×1
  • ExperimentalAsyncIterator2.buf (cyclomatic 26) optimus/platform/projects/core/src/main/scala/optimus/graph/experimental/ExperimentalAsyncIterator2.scala:62 — ExperimentalAsyncIterator2.buf has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AsyncGraph.transformFuncArgumentToNodeByName (cyclomatic 26) · ×1
  • AsyncGraph.transformFuncArgumentToNodeByName (cyclomatic 26) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AsyncGraphComponent.scala:283 — AsyncGraph.transformFuncArgumentToNodeByName has cyclomatic complexity 26 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · NodeSynthesis.transformRawNodeDef (cyclomatic 26) · ×1
  • NodeSynthesis.transformRawNodeDef (cyclomatic 26) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/NodeSynthesis.scala:61 — NodeSynthesis.transformRawNodeDef has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CleanName.prettyFrameName (cyclomatic 26) · ×1
  • CleanName.prettyFrameName (cyclomatic 26) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:528 — CleanName.prettyFrameName has cyclomatic complexity 26 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · NodeDiGraphReader.read (cyclomatic 26) · ×1
  • NodeDiGraphReader.read (cyclomatic 26) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/utils/NodeDiGraphReader.scala:51 — NodeDiGraphReader.read has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · IncomingMessageGroup.readFromChannel (cyclomatic 26) · ×1
  • IncomingMessageGroup.readFromChannel (cyclomatic 26) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:145 — IncomingMessageGroup.readFromChannel has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · NewIncomingBufferedData.readFromChannel (cyclomatic 26) · ×1
  • NewIncomingBufferedData.readFromChannel (cyclomatic 26) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/NewIncomingBufferedData.java:98 — NewIncomingBufferedData.readFromChannel has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Compiler.validateTestProperties (cyclomatic 25) · ×1
  • Compiler.validateTestProperties (cyclomatic 25) optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/compile/Compiler.scala:872 — Compiler.validateTestProperties has cyclomatic complexity 25 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · BsonByteArraySerialization.writeAny (cyclomatic 25) · ×1
  • BsonByteArraySerialization.writeAny (cyclomatic 25) optimus/platform/projects/dal_core/src/main/scala/optimus/dsi/serialization/bson/BSONByteArraySerialization.scala:174 — BsonByteArraySerialization.writeAny has cyclomatic complexity 25 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · AutoAsync.checkAndRewriteCombinator (cyclomatic 25) · ×1
  • AutoAsync.checkAndRewriteCombinator (cyclomatic 25) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala:742 — AutoAsync.checkAndRewriteCombinator has cyclomatic complexity 25 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · OptimusDALRefChecks.checkAccelerated (cyclomatic 25) · ×1
  • OptimusDALRefChecks.checkAccelerated (cyclomatic 25) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:156 — OptimusDALRefChecks.checkAccelerated has cyclomatic complexity 25 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · KDBSerializerImpl.serializeList (cyclomatic 25) · ×1
  • KDBSerializerImpl.serializeList (cyclomatic 25) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/persistence/protocol/KDBSerializer.scala:248 — KDBSerializerImpl.serializeList has cyclomatic complexity 25 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · CrumbMerger.process (cyclomatic 24) · ×1
  • CrumbMerger.process (cyclomatic 24) optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/graph/CrumbMerger.scala:137 — CrumbMerger.process has cyclomatic complexity 24 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · AI.to$newNode (cyclomatic 24) · ×1
  • AI.to$newNode (cyclomatic 24) optimus/platform/projects/core/src/main/scala/optimus/graph/AsyncIterator.scala:146 — AI.to$newNode has cyclomatic complexity 24 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · RequestSender.sendBatch (cyclomatic 24) · ×1
  • RequestSender.sendBatch (cyclomatic 24) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dsi/protobufutils/RequestSender.scala:182 — RequestSender.sendBatch has cyclomatic complexity 24 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ReflectivePicklingImpl.unpickleFill (cyclomatic 24) · ×1
  • ReflectivePicklingImpl.unpickleFill (cyclomatic 24) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/ReflectivePicklingImpl.scala:156 — ReflectivePicklingImpl.unpickleFill has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TTTableCellRender.getTextOnSetValue (cyclomatic 24) · ×1
  • TTTableCellRender.getTextOnSetValue (cyclomatic 24) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NPTableRenderer.scala:184 — TTTableCellRender.getTextOnSetValue has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PostMacroRewriter.handleFuncCall (cyclomatic 24) · ×1
  • PostMacroRewriter.handleFuncCall (cyclomatic 24) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/PostMacroRewriter.scala:105 — PostMacroRewriter.handleFuncCall has cyclomatic complexity 24 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · DefaultBinder.bindContains (cyclomatic 24) · ×1
  • DefaultBinder.bindContains (cyclomatic 24) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:347 — DefaultBinder.bindContains has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DbQueryTreeComparer.compare (cyclomatic 24) · ×1
  • DbQueryTreeComparer.compare (cyclomatic 24) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/tree/DbQueryTreeComparer.scala:23 — DbQueryTreeComparer.compare has cyclomatic complexity 24 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · DALFormatter.handleFuncCall (cyclomatic 24) · ×1
  • DALFormatter.handleFuncCall (cyclomatic 24) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALFormatter.scala:123 — DALFormatter.handleFuncCall has cyclomatic complexity 24 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · GeneralAPICheck.checkAnnotationProperties (cyclomatic 24) · ×1
  • GeneralAPICheck.checkAnnotationProperties (cyclomatic 24) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/GeneralAPICheckComponent.scala:366 — GeneralAPICheck.checkAnnotationProperties has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · StandardsTraverser.checkDefDef (cyclomatic 24) · ×1
  • StandardsTraverser.checkDefDef (cyclomatic 24) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/PostTyperCodingStandardsComponent.scala:201 — StandardsTraverser.checkDefDef has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LoomAdapter.enrichMethod (cyclomatic 24) · ×1
  • LoomAdapter.enrichMethod (cyclomatic 24) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/LoomAdapter.java:270 — LoomAdapter.enrichMethod has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · EntityAgentTransformer.transform (cyclomatic 24) · ×1
  • EntityAgentTransformer.transform (cyclomatic 24) optimus/platform/projects/entityagent/src/main/java/optimus/EntityAgent.java:102 — EntityAgentTransformer.transform has cyclomatic complexity 24 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · DaemonStateZK.waitForQuorumState (cyclomatic 24) · ×1
  • DaemonStateZK.waitForQuorumState (cyclomatic 24) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/DaemonStateZK.java:275 — DaemonStateZK.waitForQuorumState has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · RingTree.merge (cyclomatic 24) · ×1
  • RingTree.merge (cyclomatic 24) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingTree.java:416 — RingTree.merge has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ClassParser.objectToString (cyclomatic 24) · ×1
  • ClassParser.objectToString (cyclomatic 24) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ClassParser.java:496 — ClassParser.objectToString has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Parser.tokens (cyclomatic 23) · ×1
  • Parser.tokens (cyclomatic 23) optimus/buildtool/projects/core/src/main/scala/optimus/buildtool/utils/parser/Parser.scala:56 — Parser.tokens has cyclomatic complexity 23 (threshold 15). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D1 · Cyclomatic Complexity · DependencyLoader.loadLibrary (cyclomatic 23) · ×1
  • DependencyLoader.loadLibrary (cyclomatic 23) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/dependencies/DependencyLoader.scala:95 — DependencyLoader.loadLibrary has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OptimusDALRefChecks.traverse (cyclomatic 23) · ×1
  • OptimusDALRefChecks.traverse (cyclomatic 23) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:449 — OptimusDALRefChecks.traverse has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OptimusIteratorLinter.traverse (cyclomatic 23) · ×1
  • OptimusIteratorLinter.traverse (cyclomatic 23) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/refchecks/IteratorUsage.scala:124 — OptimusIteratorLinter.traverse has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DynamicObjSortRule.compareLeftRight (cyclomatic 23) · ×1
  • DynamicObjSortRule.compareLeftRight (cyclomatic 23) optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/dynamic/DynamicObjectRelationUtils.scala:56 — DynamicObjSortRule.compareLeftRight has cyclomatic complexity 23 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · RelationColumnView.executeBinaryExpression (cyclomatic 23) · ×1
  • RelationColumnView.executeBinaryExpression (cyclomatic 23) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:461 — RelationColumnView.executeBinaryExpression has cyclomatic complexity 23 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · LoomAdapter.forwardQueuedMethods (cyclomatic 23) · ×1
  • LoomAdapter.forwardQueuedMethods (cyclomatic 23) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/LoomAdapter.java:483 — LoomAdapter.forwardQueuedMethods has cyclomatic complexity 23 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · StandardBuilder.buildScopes (cyclomatic 22) · ×1
  • StandardBuilder.buildScopes (cyclomatic 22) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/StandardBuilder.scala:143 — StandardBuilder.buildScopes has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · UpstreamArtifacts.distinctArtifacts (cyclomatic 22) · ×1
  • UpstreamArtifacts.distinctArtifacts (cyclomatic 22) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/scope/UpstreamArtifacts.scala:35 — UpstreamArtifacts.distinctArtifacts has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SummonImpl.summon (cyclomatic 22) · ×1
  • SummonImpl.summon (cyclomatic 22) optimus/platform/projects/core/src/main/scala/optimus/platform/relational/tree/TypeInfo.scala:527 — SummonImpl.summon has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DSIClient.executeCommandsWithRetry (cyclomatic 22) · ×1
  • DSIClient.executeCommandsWithRetry (cyclomatic 22) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/DSIClient.scala:236 — DSIClient.executeCommandsWithRetry has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AutoAsync.opaque (cyclomatic 22) · ×1
  • AutoAsync.opaque (cyclomatic 22) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala:324 — AutoAsync.opaque has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · StackAnalysis.buildStackTrees (cyclomatic 22) · ×1
  • StackAnalysis.buildStackTrees (cyclomatic 22) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:1230 — StackAnalysis.buildStackTrees has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · RelationColumnView.get (cyclomatic 22) · ×1
  • RelationColumnView.get (cyclomatic 22) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:46 — RelationColumnView.get has cyclomatic complexity 22 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ColumnOrdering.compare (cyclomatic 22) · ×1
  • ColumnOrdering.compare (cyclomatic 22) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:2379 — ColumnOrdering.compare has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AsyncRetrievalOperationImpl.resultReceived (cyclomatic 22) · ×1
  • AsyncRetrievalOperationImpl.resultReceived (cyclomatic 22) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/AsyncRetrievalOperationImpl.java:386 — AsyncRetrievalOperationImpl.resultReceived has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SimpleRetrievalOperation.update (cyclomatic 22) · ×1
  • SimpleRetrievalOperation.update (cyclomatic 22) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/protocol/SimpleRetrievalOperation.java:74 — SimpleRetrievalOperation.update has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TopologyParser._parse (cyclomatic 22) · ×1
  • TopologyParser._parse (cyclomatic 22) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/topology/TopologyParser.java:37 — TopologyParser._parse has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ScopeDefinitionCompiler.loadScope (cyclomatic 21) · ×1
  • ScopeDefinitionCompiler.loadScope (cyclomatic 21) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ScopeDefinitionCompiler.scala:901 — ScopeDefinitionCompiler.loadScope has cyclomatic complexity 21 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · GridProfiler.getCSV (cyclomatic 21) · ×1
  • GridProfiler.getCSV (cyclomatic 21) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfiler.scala:1147 — GridProfiler.getCSV has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TraceReporter.traceEntity (cyclomatic 21) · ×1
  • TraceReporter.traceEntity (cyclomatic 21) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/temporalSurface/impl/TemporalContextTrace.scala:255 — TraceReporter.traceEntity has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ProtoPickleSerializer.protoToSlottedBuffer (cyclomatic 21) · ×1
  • ProtoPickleSerializer.protoToSlottedBuffer (cyclomatic 21) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PropertyMapProtoSerialization.scala:201 — ProtoPickleSerializer.protoToSlottedBuffer has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: ProtoPickleSerializer.propertiesToProto (cyclomatic 30) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · QueryBinder.bindMember (cyclomatic 21) · ×1
  • QueryBinder.bindMember (cyclomatic 21) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/mapping/QueryBinder.scala:44 — QueryBinder.bindMember has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ComparisonRewriter.handleBinaryExpression (cyclomatic 21) · ×1
  • ComparisonRewriter.handleBinaryExpression (cyclomatic 21) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/ComparisonRewriter.scala:41 — ComparisonRewriter.handleBinaryExpression has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · SelectorController.processKeyChangeRequest (cyclomatic 21) · ×1
  • SelectorController.processKeyChangeRequest (cyclomatic 21) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/SelectorController.java:354 — SelectorController.processKeyChangeRequest has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MultiSourceDependency.expandDependencyDefinitions (cyclomatic 20) · ×1
  • MultiSourceDependency.expandDependencyDefinitions (cyclomatic 20) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/dependencies/MultiSourceDependencies.scala:98 — MultiSourceDependency.expandDependencyDefinitions has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · Show.prettyTreeInternal (cyclomatic 20) · ×1
  • Show.prettyTreeInternal (cyclomatic 20) optimus/platform/projects/core_macro/src/main/scala/optimus/utils/MacroUtils.scala:430 — Show.prettyTreeInternal has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · EntityOps.buildEntityChangeFromSpace (cyclomatic 20) · ×1
  • EntityOps.buildEntityChangeFromSpace (cyclomatic 20) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/EntityEventView.scala:599 — EntityOps.buildEntityChangeFromSpace has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PubSubStreamManager.handlePubSubResult (cyclomatic 20) · ×1
  • PubSubStreamManager.handlePubSubResult (cyclomatic 20) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/pubsub/PubSubStreamManager.scala:129 — PubSubStreamManager.handlePubSubResult has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ProtoPickleSerializer.protoToArraySeq (cyclomatic 20) · ×1
  • ProtoPickleSerializer.protoToArraySeq (cyclomatic 20) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PropertyMapProtoSerialization.scala:290 — ProtoPickleSerializer.protoToArraySeq has cyclomatic complexity 20 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline. This is NOT this file's highest cyclomatic complexity: ProtoPickleSerializer.propertiesToProto (cyclomatic 30) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · InstrumentationInjectorAdapter.visitMethod (cyclomatic 20) · ×1
  • InstrumentationInjectorAdapter.visitMethod (cyclomatic 20) optimus/platform/projects/entityagent/src/main/java/optimus/debug/InstrumentationInjectorAdapter.java:98 — InstrumentationInjectorAdapter.visitMethod has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SpinningTransferQueue.xfer (cyclomatic 20) · ×1
  • SpinningTransferQueue.xfer (cyclomatic 20) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/SpinningTransferQueue.java:566 — SpinningTransferQueue.xfer has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MultiSourceDependenciesLoader.loadJvmDepsIvyConfigurations (cyclomatic 19) · ×1
  • MultiSourceDependenciesLoader.loadJvmDepsIvyConfigurations (cyclomatic 19) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/dependencies/MultiSourceDependenciesLoader.scala:73 — MultiSourceDependenciesLoader.loadJvmDepsIvyConfigurations has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · NodeName.cleanNodeClassName (cyclomatic 19) · ×1
  • NodeName.cleanNodeClassName (cyclomatic 19) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/NodeName.scala:83 — NodeName.cleanNodeClassName has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DependencyTrackerQueue.registerOrEnqueueAction (cyclomatic 19) · ×1
  • DependencyTrackerQueue.registerOrEnqueueAction (cyclomatic 19) optimus/platform/projects/core/src/main/scala/optimus/graph/tracking/DependencyTrackerQueue.scala:206 — DependencyTrackerQueue.registerOrEnqueueAction has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PickledComparator.compare (cyclomatic 19) · ×1
  • PickledComparator.compare (cyclomatic 19) optimus/platform/projects/core/src/main/scala/optimus/platform/pickling/PropertyMapOutputStream.scala:244 — PickledComparator.compare has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · QueryTreeComparer.compare (cyclomatic 19) · ×1
  • QueryTreeComparer.compare (cyclomatic 19) optimus/platform/projects/core/src/main/scala/optimus/platform/relational/tree/QueryTreeComparer.scala:20 — QueryTreeComparer.compare has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · AppStats.accumulateImpl (cyclomatic 19) · ×1
  • AppStats.accumulateImpl (cyclomatic 19) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/AppStats.scala:384 — AppStats.accumulateImpl has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AdjustAST.addPropsToModuleDef (cyclomatic 19) · ×1
  • AdjustAST.addPropsToModuleDef (cyclomatic 19) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:224 — AdjustAST.addPropsToModuleDef has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · DefaultBinder.bindFlatMap (cyclomatic 19) · ×1
  • DefaultBinder.bindFlatMap (cyclomatic 19) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:605 — DefaultBinder.bindFlatMap has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · IterableProvider.removeDuplicatedRowsBasedOnKey (cyclomatic 19) · ×1
  • IterableProvider.removeDuplicatedRowsBasedOnKey (cyclomatic 19) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableProvider.scala:516 — IterableProvider.removeDuplicatedRowsBasedOnKey has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · NettyEstablishedChannelHandler.processWrite (cyclomatic 19) · ×1
  • NettyEstablishedChannelHandler.processWrite (cyclomatic 19) optimus/dht/projects/common3/src/main/java/optimus/dht/common/internal/transport/NettyEstablishedChannelHandler.java:263 — NettyEstablishedChannelHandler.processWrite has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · EntityAgent.premain (cyclomatic 19) · ×1
  • EntityAgent.premain (cyclomatic 19) optimus/platform/projects/entityagent/src/main/java/optimus/EntityAgent.java:242 — EntityAgent.premain has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ProtoPutMessageGroup.addValue (cyclomatic 19) · ×1
  • ProtoPutMessageGroup.addValue (cyclomatic 19) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoPutMessageGroup.java:349 — ProtoPutMessageGroup.addValue has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SpinningTransferQueue.unsplice (cyclomatic 19) · ×1
  • SpinningTransferQueue.unsplice (cyclomatic 19) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/SpinningTransferQueue.java:847 — SpinningTransferQueue.unsplice has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ZincProfiler.logAndTraceProfileStats (cyclomatic 18) · ×1
  • ZincProfiler.logAndTraceProfileStats (cyclomatic 18) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincProfiler.scala:70 — ZincProfiler.logAndTraceProfileStats has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · RunconfCompilationSources.hashedSources (cyclomatic 18) · ×1
  • RunconfCompilationSources.hashedSources (cyclomatic 18) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/scope/sources/RunconfCompilationSources.scala:215 — RunconfCompilationSources.hashedSources has cyclomatic complexity 18 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · ModuleSetDefinition.validate (cyclomatic 18) · ×1
  • ModuleSetDefinition.validate (cyclomatic 18) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ModuleSetDefinition.scala:241 — ModuleSetDefinition.validate has cyclomatic complexity 18 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · ScopeDefinitionCompiler.loadInheritableScopeDefinition (cyclomatic 18) · ×1
  • ScopeDefinitionCompiler.loadInheritableScopeDefinition (cyclomatic 18) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ScopeDefinitionCompiler.scala:693 — ScopeDefinitionCompiler.loadInheritableScopeDefinition has cyclomatic complexity 18 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · Compiler.validateAndAssignParents (cyclomatic 18) · ×1
  • Compiler.validateAndAssignParents (cyclomatic 18) optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/compile/Compiler.scala:576 — Compiler.validateAndAssignParents has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · BreadcrumbsPropertyConfigurer.implFromConfig0 (cyclomatic 18) · ×1
  • BreadcrumbsPropertyConfigurer.implFromConfig0 (cyclomatic 18) optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/zookeeper/BreadcrumbsZkClient.scala:263 — BreadcrumbsPropertyConfigurer.implFromConfig0 has cyclomatic complexity 18 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · GroupingNodeBatcherSchedulerPluginBase.adapt (cyclomatic 18) · ×1
  • GroupingNodeBatcherSchedulerPluginBase.adapt (cyclomatic 18) optimus/platform/projects/core/src/main/scala/optimus/graph/NodeBatcherSchedulerPlugin.scala:598 — GroupingNodeBatcherSchedulerPluginBase.adapt has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GraphSamplers.provide (cyclomatic 18) · ×1
  • GraphSamplers.provide (cyclomatic 18) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/sampling/GraphSamplers.scala:38 — GraphSamplers.provide has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · Utils.jsonToString (cyclomatic 18) · ×1
  • Utils.jsonToString (cyclomatic 18) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:735 — Utils.jsonToString has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · EstablishSessionResultSerializer.deserialize (cyclomatic 18) · ×1
  • EstablishSessionResultSerializer.deserialize (cyclomatic 18) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:778 — EstablishSessionResultSerializer.deserialize has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OptimusConstructorsComponent.tryMakeCtor (cyclomatic 18) · ×1
  • OptimusConstructorsComponent.tryMakeCtor (cyclomatic 18) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusConstructorsComponent.scala:161 — OptimusConstructorsComponent.tryMakeCtor has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · RedirectAccessors.valBackingFields (cyclomatic 18) · ×1
  • RedirectAccessors.valBackingFields (cyclomatic 18) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/RedirectAccessorsComponent.scala:327 — RedirectAccessors.valBackingFields has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TraceExplorer.writeCsvDot (cyclomatic 18) · ×1
  • TraceExplorer.writeCsvDot (cyclomatic 18) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/TraceExplorer.scala:141 — TraceExplorer.writeCsvDot has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DALBinder.bindWhere (cyclomatic 18) · ×1
  • DALBinder.bindWhere (cyclomatic 18) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALBinder.scala:321 — DALBinder.bindWhere has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ConditionOptimizer.optimizeProjection (cyclomatic 18) · ×1
  • ConditionOptimizer.optimizeProjection (cyclomatic 18) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALBinder.scala:479 — ConditionOptimizer.optimizeProjection has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · StagingPlugin.processCommonOption (cyclomatic 18) · ×1
  • StagingPlugin.processCommonOption (cyclomatic 18) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/StagingPlugin.scala:63 — StagingPlugin.processCommonOption has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · DynamicDependencyDiscoveryMethodVisitor.visitMethodInsn (cyclomatic 18) · ×1
  • DynamicDependencyDiscoveryMethodVisitor.visitMethodInsn (cyclomatic 18) optimus/platform/projects/entityagent/src/main/java/optimus/deps/DynamicDependencyDiscoveryMethodVisitor.java:38 — DynamicDependencyDiscoveryMethodVisitor.visitMethodInsn has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · Dynamic.getType (cyclomatic 18) · ×1
  • Dynamic.getType (cyclomatic 18) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/compiler/OpcodeHandlers.java:197 — Dynamic.getType has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AwaitStackManagement.maybeSaveAwaitStack (cyclomatic 18) · ×1
  • AwaitStackManagement.maybeSaveAwaitStack (cyclomatic 18) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/AwaitStackManagement.java:261 — AwaitStackManagement.maybeSaveAwaitStack has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DirectoryInMemory.largeUpdate (cyclomatic 18) · ×1
  • DirectoryInMemory.largeUpdate (cyclomatic 18) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/skfs/dir/DirectoryInMemory.java:210 — DirectoryInMemory.largeUpdate has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DependencyWatcher.build (cyclomatic 18) · ×1
  • DependencyWatcher.build (cyclomatic 18) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/DependencyWatcher.java:147 — DependencyWatcher.build has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Itr.advance (cyclomatic 18) · ×1
  • Itr.advance (cyclomatic 18) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/SpinningTransferQueue.java:767 — Itr.advance has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · QueueingConnection.writeAllPending_locked (cyclomatic 18) · ×1
  • QueueingConnection.writeAllPending_locked (cyclomatic 18) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/QueueingConnection.java:112 — QueueingConnection.writeAllPending_locked has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BuildSummaryRecorder.logStats (cyclomatic 17) · ×1
  • BuildSummaryRecorder.logStats (cyclomatic 17) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/trace/BuildSummaryRecorder.scala:141 — BuildSummaryRecorder.logStats has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · Formatter.formatValue (cyclomatic 17) · ×1
  • Formatter.formatValue (cyclomatic 17) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ObtFileFormatter.scala:105 — Formatter.formatValue has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · TwkResolver.nextInCurrent (cyclomatic 17) · ×1
  • TwkResolver.nextInCurrent (cyclomatic 17) optimus/platform/projects/core/src/main/scala/optimus/graph/TwkResolver.scala:145 — TwkResolver.nextInCurrent has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DependencyTrackerQueue.afterActionCompleted (cyclomatic 17) · ×1
  • DependencyTrackerQueue.afterActionCompleted (cyclomatic 17) optimus/platform/projects/core/src/main/scala/optimus/graph/tracking/DependencyTrackerQueue.scala:288 — DependencyTrackerQueue.afterActionCompleted has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · stateManager.checkInvariants (cyclomatic 17) · ×1
  • stateManager.checkInvariants (cyclomatic 17) optimus/platform/projects/core/src/main/scala/optimus/graph/tracking/DependencyTrackerQueue.scala:95 — stateManager.checkInvariants has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Scenario.validate (cyclomatic 17) · ×1
  • Scenario.validate (cyclomatic 17) optimus/platform/projects/core/src/main/scala/optimus/platform/Scenario.scala:445 — Scenario.validate has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Utils.pathMatches (cyclomatic 17) · ×1
  • Utils.pathMatches (cyclomatic 17) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:502 — Utils.pathMatches has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · HtmlInterpreters.nodeToHtmlString (cyclomatic 17) · ×1
  • HtmlInterpreters.nodeToHtmlString (cyclomatic 17) optimus/platform/projects/core/src/main/scala/optimus/platform/util/html/HtmlComponent.scala:85 — HtmlInterpreters.nodeToHtmlString has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TemporalMatching.matches (cyclomatic 17) · ×1
  • TemporalMatching.matches (cyclomatic 17) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/Grouping.scala:36 — TemporalMatching.matches has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · EstablishSessionResultSerializer.serialize (cyclomatic 17) · ×1
  • EstablishSessionResultSerializer.serialize (cyclomatic 17) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:854 — EstablishSessionResultSerializer.serialize has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing. This is NOT this file's highest cyclomatic complexity: ServiceDiscoveryElementSerializer.deserialize (cyclomatic 18) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · AdjustAST.transformBackedDef (cyclomatic 17) · ×1
  • AdjustAST.transformBackedDef (cyclomatic 17) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:572 — AdjustAST.transformBackedDef has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · AdjustAST.transformAccelerated (cyclomatic 17) · ×1
  • AdjustAST.transformAccelerated (cyclomatic 17) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:729 — AdjustAST.transformAccelerated has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · ClassifierTransformer.transformSafe (cyclomatic 17) · ×1
  • ClassifierTransformer.transformSafe (cyclomatic 17) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/ClassifierComponent.scala:64 — ClassifierTransformer.transformSafe has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · NodeLift.nodeLift (cyclomatic 17) · ×1
  • NodeLift.nodeLift (cyclomatic 17) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/NodeLiftComponent.scala:93 — NodeLift.nodeLift has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OptimusDALRefChecks.checkParamAccessors (cyclomatic 17) · ×1
  • OptimusDALRefChecks.checkParamAccessors (cyclomatic 17) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:54 — OptimusDALRefChecks.checkParamAccessors has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OptimusRefchecks.checkParamAccessors (cyclomatic 17) · ×1
  • OptimusRefchecks.checkParamAccessors (cyclomatic 17) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:146 — OptimusRefchecks.checkParamAccessors has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · RedirectAccessors.rewriteWithValBackingFields (cyclomatic 17) · ×1
  • RedirectAccessors.rewriteWithValBackingFields (cyclomatic 17) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/RedirectAccessorsComponent.scala:237 — RedirectAccessors.rewriteWithValBackingFields has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · NodeClassBuilder.addPropertyNodeMethods (cyclomatic 17) · ×1
  • NodeClassBuilder.addPropertyNodeMethods (cyclomatic 17) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/TypedNodeClassGenerator.scala:181 — NodeClassBuilder.addPropertyNodeMethods has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · TypedUtils.checkOwnership (cyclomatic 17) · ×1
  • TypedUtils.checkOwnership (cyclomatic 17) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/TypedUtils.scala:1029 — TypedUtils.checkOwnership has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · ExpressionElementHelper.modulo (cyclomatic 17) · ×1
  • ExpressionElementHelper.modulo (cyclomatic 17) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/internal/ExpressionElementHelper.scala:106 — ExpressionElementHelper.modulo has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators. This shape REPEATS in the file: 3 other methods here (ExpressionElementHelper.minus, ExpressionElementHelper.mul, ExpressionElementHelper.plus) have the same decision points, in the same order, at the same nesting depths — so this is one pattern written 4 times rather than 4 independent problems. Splitting this body alone leaves the other 3 exactly as they are. Where these are variations on one operation, the change that clears all 4 is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared. This is NOT this file's highest cyclomatic complexity: ExpressionElementHelper.executeExpression (cyclomatic 20) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · ExpressionElementHelper.minus (cyclomatic 17) · ×1
  • ExpressionElementHelper.minus (cyclomatic 17) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/internal/ExpressionElementHelper.scala:129 — ExpressionElementHelper.minus has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators. This shape REPEATS in the file: 3 other methods here (ExpressionElementHelper.modulo, ExpressionElementHelper.mul, ExpressionElementHelper.plus) have the same decision points, in the same order, at the same nesting depths — so this is one pattern written 4 times rather than 4 independent problems. Splitting this body alone leaves the other 3 exactly as they are. Where these are variations on one operation, the change that clears all 4 is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared. This is NOT this file's highest cyclomatic complexity: ExpressionElementHelper.executeExpression (cyclomatic 20) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · ExpressionElementHelper.mul (cyclomatic 17) · ×1
  • ExpressionElementHelper.mul (cyclomatic 17) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/internal/ExpressionElementHelper.scala:152 — ExpressionElementHelper.mul has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators. This shape REPEATS in the file: 3 other methods here (ExpressionElementHelper.modulo, ExpressionElementHelper.minus, ExpressionElementHelper.plus) have the same decision points, in the same order, at the same nesting depths — so this is one pattern written 4 times rather than 4 independent problems. Splitting this body alone leaves the other 3 exactly as they are. Where these are variations on one operation, the change that clears all 4 is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared. This is NOT this file's highest cyclomatic complexity: ExpressionElementHelper.executeExpression (cyclomatic 20) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · ExpressionElementHelper.plus (cyclomatic 17) · ×1
  • ExpressionElementHelper.plus (cyclomatic 17) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/internal/ExpressionElementHelper.scala:179 — ExpressionElementHelper.plus has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators. This shape REPEATS in the file: 3 other methods here (ExpressionElementHelper.modulo, ExpressionElementHelper.minus, ExpressionElementHelper.mul) have the same decision points, in the same order, at the same nesting depths — so this is one pattern written 4 times rather than 4 independent problems. Splitting this body alone leaves the other 3 exactly as they are. Where these are variations on one operation, the change that clears all 4 is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared. This is NOT this file's highest cyclomatic complexity: ExpressionElementHelper.executeExpression (cyclomatic 20) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
D1 · Cyclomatic Complexity · DALFormatter.handleBinaryExpression (cyclomatic 17) · ×1
  • DALFormatter.handleBinaryExpression (cyclomatic 17) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALFormatter.scala:58 — DALFormatter.handleBinaryExpression has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · DALBinder.handleFuncCall (cyclomatic 17) · ×1
  • DALBinder.handleFuncCall (cyclomatic 17) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALBinder.scala:78 — DALBinder.handleFuncCall has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · AbstractAPICheck.visit (cyclomatic 17) · ×1
  • AbstractAPICheck.visit (cyclomatic 17) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/GeneralAPICheckComponent.scala:145 — AbstractAPICheck.visit has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · StandardsTraverser.traverse (cyclomatic 17) · ×1
  • StandardsTraverser.traverse (cyclomatic 17) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/PostTyperCodingStandardsComponent.scala:132 — StandardsTraverser.traverse has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · InstrumentationInjectorMethodVisitor.injectMethodPrefix (cyclomatic 17) · ×1
  • InstrumentationInjectorMethodVisitor.injectMethodPrefix (cyclomatic 17) optimus/platform/projects/entityagent/src/main/java/optimus/debug/InstrumentationInjectorMethodVisitor.java:41 — InstrumentationInjectorMethodVisitor.injectMethodPrefix has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · QueueingConnection.sendAsynchronous (cyclomatic 17) · ×1
  • QueueingConnection.sendAsynchronous (cyclomatic 17) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/QueueingConnection.java:246 — QueueingConnection.sendAsynchronous has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AbstractImageBuilder.processPath (cyclomatic 16) · ×1
  • AbstractImageBuilder.processPath (cyclomatic 16) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/oci/ImageBuilder.scala:836 — AbstractImageBuilder.processPath has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PythonDependenciesLoader.loadAllDependencies (cyclomatic 16) · ×1
  • PythonDependenciesLoader.loadAllDependencies (cyclomatic 16) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/dependencies/PythonDependenciesLoader.scala:123 — PythonDependenciesLoader.loadAllDependencies has cyclomatic complexity 16 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · TemporalSource.translateMarkers (cyclomatic 16) · ×1
  • TemporalSource.translateMarkers (cyclomatic 16) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/internal/TemporalSource.scala:37 — TemporalSource.translateMarkers has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · NodeLift.transformSafe (cyclomatic 16) · ×1
  • NodeLift.transformSafe (cyclomatic 16) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/NodeLiftComponent.scala:165 — NodeLift.transformSafe has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OptimusExportInfo.extractMetaParams (cyclomatic 16) · ×1
  • OptimusExportInfo.extractMetaParams (cyclomatic 16) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusExportInfoComponent.scala:372 — OptimusExportInfo.extractMetaParams has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OptimusRefchecks.checkValidParent (cyclomatic 16) · ×1
  • OptimusRefchecks.checkValidParent (cyclomatic 16) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:613 — OptimusRefchecks.checkValidParent has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OptimusTask.runtimeConfig (cyclomatic 16) · ×1
  • OptimusTask.runtimeConfig (cyclomatic 16) optimus/platform/projects/platform/src/main/scala/optimus/platform/OptimusTask.scala:163 — OptimusTask.runtimeConfig has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · NodeTreeTable.getTreeSelector (cyclomatic 16) · ×1
  • NodeTreeTable.getTreeSelector (cyclomatic 16) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeTreeTable.scala:214 — NodeTreeTable.getTreeSelector has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · Typer.handleBinaryExpression (cyclomatic 16) · ×1
  • Typer.handleBinaryExpression (cyclomatic 16) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/Typer.scala:114 — Typer.handleBinaryExpression has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · QueryBinder.bindUntypedMember (cyclomatic 16) · ×1
  • QueryBinder.bindUntypedMember (cyclomatic 16) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/mapping/QueryBinder.scala:118 — QueryBinder.bindUntypedMember has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · DefaultBinder.bindAggregate1 (cyclomatic 16) · ×1
  • DefaultBinder.bindAggregate1 (cyclomatic 16) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:836 — DefaultBinder.bindAggregate1 has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DALEntityBitemporalSpaceLanguage.canBeWhere (cyclomatic 16) · ×1
  • DALEntityBitemporalSpaceLanguage.canBeWhere (cyclomatic 16) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/deltaquery/DALEntityBitemporalSpaceReducer.scala:75 — DALEntityBitemporalSpaceLanguage.canBeWhere has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · JsonPrinter.printString (cyclomatic 16) · ×1
  • JsonPrinter.printString (cyclomatic 16) optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/JsonPrinter.scala:53 — JsonPrinter.printString has cyclomatic complexity 16 (threshold 15). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D1 · Cyclomatic Complexity · StandardsTraverser.checkSelection (cyclomatic 16) · ×1
  • StandardsTraverser.checkSelection (cyclomatic 16) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/PostTyperCodingStandardsComponent.scala:64 — StandardsTraverser.checkSelection has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DefaultServerConnectionsManager.nodesRegistryChanged (cyclomatic 16) · ×1
  • DefaultServerConnectionsManager.nodesRegistryChanged (cyclomatic 16) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/servers/DefaultServerConnectionsManager.java:344 — DefaultServerConnectionsManager.nodesRegistryChanged has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · InstrumentationInjectorMethodVisitor.onMethodExit (cyclomatic 16) · ×1
  • InstrumentationInjectorMethodVisitor.onMethodExit (cyclomatic 16) optimus/platform/projects/entityagent/src/main/java/optimus/debug/InstrumentationInjectorMethodVisitor.java:137 — InstrumentationInjectorMethodVisitor.onMethodExit has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · LCompiler.transform (cyclomatic 16) · ×1
  • LCompiler.transform (cyclomatic 16) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/compiler/LCompiler.java:146 — LCompiler.transform has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SingleWriterConsistentWrite.update (cyclomatic 16) · ×1
  • SingleWriterConsistentWrite.update (cyclomatic 16) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/protocol/SingleWriterConsistentWrite.java:41 — SingleWriterConsistentWrite.update has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · IORelay.run (cyclomatic 16) · ×1
  • IORelay.run (cyclomatic 16) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/io/IORelay.java:137 — IORelay.run has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LWTThread.activeMultiple (cyclomatic 16) · ×1
  • LWTThread.activeMultiple (cyclomatic 16) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/thread/lwt/LWTThread.java:160 — LWTThread.activeMultiple has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D2 · Cognitive Complexity · AdjustAST.transformStorableTemplate (cognitive 231) · ×1
  • AdjustAST.transformStorableTemplate (cognitive 231) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:790 — AdjustAST.transformStorableTemplate has cognitive complexity 231 (threshold 15). Drivers by points: if/else 89 (172 pts), boolean chains 39, match/switch 13 (20 pts) (nesting depth added 90). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TopologyRingCreator.allocateSubPolicyMember (cognitive 177) · ×1
  • TopologyRingCreator.allocateSubPolicyMember (cognitive 177) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/TopologyRingCreator.java:1023 — TopologyRingCreator.allocateSubPolicyMember has cognitive complexity 177 (threshold 15). Drivers by points: if/else 33 (148 pts), loops 6 (24 pts), error handling 1 (4 pts), boolean chains 1 (nesting depth added 136). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SerializedKeyBasedIndexOptimizer.handleSelect (cognitive 175) · ×1
  • SerializedKeyBasedIndexOptimizer.handleSelect (cognitive 175) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/SerializedKeyBasedIndexOptimizer.scala:48 — SerializedKeyBasedIndexOptimizer.handleSelect has cognitive complexity 175 (threshold 15). Drivers by points: if/else 34 (92 pts), match/switch 16 (76 pts), boolean chains 4, loops 1 (3 pts) (nesting depth added 120). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ScopeDefinitionCompiler.loadInheritableScopeDefinition (cognitive 153) · ×1
  • ScopeDefinitionCompiler.loadInheritableScopeDefinition (cognitive 153) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ScopeDefinitionCompiler.scala:693 — ScopeDefinitionCompiler.loadInheritableScopeDefinition has cognitive complexity 153 (threshold 15). Drivers by points: loops 17 (153 pts) (nesting depth added 136). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · CrumbMerger.process (cognitive 142) · ×1
  • CrumbMerger.process (cognitive 142) optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/graph/CrumbMerger.scala:137 — CrumbMerger.process has cognitive complexity 142 (threshold 15). Drivers by points: loops 12 (79 pts), if/else 10 (61 pts), boolean chains 2 (nesting depth added 118). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · StandardsTraverser.checkApplication (cognitive 140) · ×1
  • StandardsTraverser.checkApplication (cognitive 140) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/PostTyperCodingStandardsComponent.scala:274 — StandardsTraverser.checkApplication has cognitive complexity 140 (threshold 15). Drivers by points: if/else 35 (66 pts), match/switch 16 (53 pts), boolean chains 19, loops 1 (2 pts) (nesting depth added 69). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AutoAsync.transformSafe (cognitive 132) · ×1
  • AutoAsync.transformSafe (cognitive 132) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala:1641 — AutoAsync.transformSafe has cognitive complexity 132 (threshold 15). Drivers by points: if/else 35 (63 pts), boolean chains 37, match/switch 12 (32 pts) (nesting depth added 48). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · OptimusRefchecks.checkDefDef (cognitive 125) · ×1
  • OptimusRefchecks.checkDefDef (cognitive 125) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:317 — OptimusRefchecks.checkDefDef has cognitive complexity 125 (threshold 15). Drivers by points: if/else 47 (70 pts), boolean chains 28, loops 8 (17 pts), match/switch 5 (10 pts) (nesting depth added 37). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PredicatePushdownOptimizer.handleSelect (cognitive 119) · ×1
  • PredicatePushdownOptimizer.handleSelect (cognitive 119) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PredicatePushdownOptimizer.scala:112 — PredicatePushdownOptimizer.handleSelect has cognitive complexity 119 (threshold 15). Drivers by points: if/else 31 (72 pts), match/switch 13 (45 pts), boolean chains 2 (nesting depth added 73). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · IncomingBufferedData.readFromChannel (cognitive 108) · ×1
  • IncomingBufferedData.readFromChannel (cognitive 108) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java:104 — IncomingBufferedData.readFromChannel has cognitive complexity 108 (threshold 15). Drivers by points: if/else 40 (103 pts), error handling 1 (2 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 65). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TopologyRingCreator.doAllocation (cognitive 107) · ×1
  • TopologyRingCreator.doAllocation (cognitive 107) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/TopologyRingCreator.java:774 — TopologyRingCreator.doAllocation has cognitive complexity 107 (threshold 15). Drivers by points: if/else 22 (89 pts), loops 4 (10 pts), match/switch 1 (7 pts), boolean chains 1 (nesting depth added 79). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WorkspaceDefinition.load (cognitive 105) · ×1
  • WorkspaceDefinition.load (cognitive 105) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/WorkspaceDefinition.scala:47 — WorkspaceDefinition.load has cognitive complexity 105 (threshold 15). Drivers by points: loops 14 (105 pts) (nesting depth added 91). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · OptimusRefchecks.traverse (cognitive 105) · ×1
  • OptimusRefchecks.traverse (cognitive 105) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:799 — OptimusRefchecks.traverse has cognitive complexity 105 (threshold 15). Drivers by points: if/else 29 (55 pts), boolean chains 31, match/switch 9 (19 pts) (nesting depth added 36). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · JvmDependenciesLoader.load (cognitive 96) · ×1
  • JvmDependenciesLoader.load (cognitive 96) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/dependencies/JvmDependenciesLoader.scala:122 — JvmDependenciesLoader.load has cognitive complexity 96 (threshold 15). Drivers by points: loops 19 (74 pts), if/else 9 (19 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 66). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · ScopeDefinitionCompiler.loadScope (cognitive 93) · ×1
  • ScopeDefinitionCompiler.loadScope (cognitive 93) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ScopeDefinitionCompiler.scala:901 — ScopeDefinitionCompiler.loadScope has cognitive complexity 93 (threshold 15). Drivers by points: loops 12 (78 pts), if/else 10 (11 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 69). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · JoinColumnView.createNewArray (cognitive 92) · ×1
  • JoinColumnView.createNewArray (cognitive 92) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:191 — JoinColumnView.createNewArray has cognitive complexity 92 (threshold 15). Drivers by points: if/else 46 (73 pts), match/switch 10 (19 pts) (nesting depth added 36). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · TypeOps.fieldType (cognitive 89) · ×1
  • TypeOps.fieldType (cognitive 89) optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/VersioningUtilsBase.scala:49 — TypeOps.fieldType has cognitive complexity 89 (threshold 15). Drivers by points: if/else 55, boolean chains 32, match/switch 1 (2 pts) (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · Convertor.transform (cognitive 85) · ×1
  • Convertor.transform (cognitive 85) optimus/platform/projects/core/src/main/scala/optimus/platform/relational/AbstractLambdaReifier.scala:213 — Convertor.transform has cognitive complexity 85 (threshold 15). Drivers by points: if/else 27 (51 pts), match/switch 10 (28 pts), boolean chains 6 (nesting depth added 42). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SimpleCodeMotion.transform (cognitive 84) · ×1
  • SimpleCodeMotion.transform (cognitive 84) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AsyncGraphComponent.scala:879 — SimpleCodeMotion.transform has cognitive complexity 84 (threshold 15). Drivers by points: if/else 31 (61 pts), boolean chains 15, match/switch 4 (6 pts), loops 1 (2 pts) (nesting depth added 33). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EmbeddableTransformer.handleClassDef (cognitive 78) · ×1
  • EmbeddableTransformer.handleClassDef (cognitive 78) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/EmbeddableComponent.scala:105 — EmbeddableTransformer.handleClassDef has cognitive complexity 78 (threshold 15). Drivers by points: if/else 31 (60 pts), boolean chains 12, match/switch 5 (6 pts) (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PropertyInfoTyper.infoType (cognitive 76) · ×1
  • PropertyInfoTyper.infoType (cognitive 76) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/provider/PropertyInfoProvider.scala:495 — PropertyInfoTyper.infoType has cognitive complexity 76 (threshold 15). Drivers by points: if/else 40 (65 pts), boolean chains 9, match/switch 2 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReflectivePicklingImpl.unpickleFill (cognitive 74) · ×1
  • ReflectivePicklingImpl.unpickleFill (cognitive 74) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/ReflectivePicklingImpl.scala:156 — ReflectivePicklingImpl.unpickleFill has cognitive complexity 74 (threshold 15). Drivers by points: if/else 29 (61 pts), match/switch 2 (7 pts), boolean chains 3, error handling 1 (3 pts) (nesting depth added 39). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · AbstractSegment.retrieve (cognitive 74) · ×1
  • AbstractSegment.retrieve (cognitive 74) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/AbstractSegment.java:125 — AbstractSegment.retrieve has cognitive complexity 74 (threshold 15). Drivers by points: if/else 23 (61 pts), boolean chains 10, match/switch 1 (3 pts) (nesting depth added 40). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · DaemonStateZK.waitForQuorumState (cognitive 74) · ×1
  • DaemonStateZK.waitForQuorumState (cognitive 74) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/DaemonStateZK.java:275 — DaemonStateZK.waitForQuorumState has cognitive complexity 74 (threshold 15). Drivers by points: if/else 21 (57 pts), error handling 2 (7 pts), ternaries 2 (6 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 46). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · IncomingMessageGroup.readFromChannel (cognitive 74) · ×1
  • IncomingMessageGroup.readFromChannel (cognitive 74) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:145 — IncomingMessageGroup.readFromChannel has cognitive complexity 74 (threshold 15). Drivers by points: if/else 27 (69 pts), error handling 1 (2 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 44). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NewIncomingBufferedData.readFromChannel (cognitive 74) · ×1
  • NewIncomingBufferedData.readFromChannel (cognitive 74) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/NewIncomingBufferedData.java:98 — NewIncomingBufferedData.readFromChannel has cognitive complexity 74 (threshold 15). Drivers by points: if/else 28 (69 pts), error handling 1 (2 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 43). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SelectorController.doSelection (cognitive 74) · ×1
  • SelectorController.doSelection (cognitive 74) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/SelectorController.java:166 — SelectorController.doSelection has cognitive complexity 74 (threshold 15). Drivers by points: if/else 23 (57 pts), boolean chains 15, loops 1 (2 pts) (nesting depth added 35). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ClassParser.objectToString (cognitive 72) · ×1
  • ClassParser.objectToString (cognitive 72) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ClassParser.java:496 — ClassParser.objectToString has cognitive complexity 72 (threshold 15). Drivers by points: if/else 22 (53 pts), error handling 5 (17 pts), boolean chains 1, loops 1 (nesting depth added 43). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · AdjustAST.transformSafe (cognitive 69) · ×1
  • AdjustAST.transformSafe (cognitive 69) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:1393 — AdjustAST.transformSafe has cognitive complexity 69 (threshold 15). Drivers by points: if/else 26 (52 pts), match/switch 4 (12 pts), boolean chains 5 (nesting depth added 34). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · PersistentAsyncServer.createConnection (cognitive 67) · ×1
  • PersistentAsyncServer.createConnection (cognitive 67) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/PersistentAsyncServer.java:559 — PersistentAsyncServer.createConnection has cognitive complexity 67 (threshold 15). Drivers by points: if/else 19 (50 pts), error handling 4 (8 pts), boolean chains 6, ternaries 1 (2 pts), loops 1 (nesting depth added 36). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AbstractBitemporalSpace.unsafeMultipleUpdate (cognitive 64) · ×1
  • AbstractBitemporalSpace.unsafeMultipleUpdate (cognitive 64) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/bitemporal/BitemporalSpaceImpl.scala:307 — AbstractBitemporalSpace.unsafeMultipleUpdate has cognitive complexity 64 (threshold 15). Drivers by points: match/switch 14 (27 pts), if/else 14 (26 pts), boolean chains 11 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ColumnOrdering.compare (cognitive 64) · ×1
  • ColumnOrdering.compare (cognitive 64) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:2379 — ColumnOrdering.compare has cognitive complexity 64 (threshold 15). Drivers by points: if/else 23 (61 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 39). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DefaultBinder.handleFuncCall (cognitive 64) · ×1
  • DefaultBinder.handleFuncCall (cognitive 64) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:72 — DefaultBinder.handleFuncCall has cognitive complexity 64 (threshold 15). Drivers by points: if/else 19 (31 pts), match/switch 9 (21 pts), boolean chains 12 (nesting depth added 24). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · SpecialElementRewriter.handleConditional (cognitive 63) · ×1
  • SpecialElementRewriter.handleConditional (cognitive 63) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/SpecialElementRewriter.scala:84 — SpecialElementRewriter.handleConditional has cognitive complexity 63 (threshold 15). Drivers by points: match/switch 14 (35 pts), if/else 21 (27 pts), boolean chains 1 (nesting depth added 27). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · NodeDiGraphReader.read (cognitive 62) · ×1
  • NodeDiGraphReader.read (cognitive 62) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/utils/NodeDiGraphReader.scala:51 — NodeDiGraphReader.read has cognitive complexity 62 (threshold 15). Drivers by points: if/else 21 (52 pts), boolean chains 5, match/switch 1 (4 pts), loops 1 (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActiveRetrievalListeners.receivedRetrievalResponse (cognitive 62) · ×1
  • ActiveRetrievalListeners.receivedRetrievalResponse (cognitive 62) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/ActiveRetrievalListeners.java:186 — ActiveRetrievalListeners.receivedRetrievalResponse has cognitive complexity 62 (threshold 15). Drivers by points: if/else 15 (39 pts), loops 5 (23 pts) (nesting depth added 42). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · EntityOps.buildEntityChangeFromSpace (cognitive 61) · ×1
  • EntityOps.buildEntityChangeFromSpace (cognitive 61) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/EntityEventView.scala:599 — EntityOps.buildEntityChangeFromSpace has cognitive complexity 61 (threshold 15). Drivers by points: if/else 21 (32 pts), match/switch 9 (26 pts), boolean chains 3 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NodeCacheConfigsParser.parseWithPropertyConfigs (cognitive 60) · ×1
  • NodeCacheConfigsParser.parseWithPropertyConfigs (cognitive 60) optimus/platform/projects/core/src/main/scala/optimus/config/NodeCacheConfigs.scala:944 — NodeCacheConfigsParser.parseWithPropertyConfigs has cognitive complexity 60 (threshold 15). Drivers by points: if/else 30 (46 pts), match/switch 8 (11 pts), boolean chains 3 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RunconfCompilationSources.hashedSources (cognitive 59) · ×1
  • RunconfCompilationSources.hashedSources (cognitive 59) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/scope/sources/RunconfCompilationSources.scala:215 — RunconfCompilationSources.hashedSources has cognitive complexity 59 (threshold 15). Drivers by points: loops 10 (32 pts), if/else 13 (24 pts), match/switch 2 (3 pts) (nesting depth added 34). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · DALBinder.bindWhere (cognitive 59) · ×1
  • DALBinder.bindWhere (cognitive 59) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALBinder.scala:321 — DALBinder.bindWhere has cognitive complexity 59 (threshold 15). Drivers by points: if/else 23 (46 pts), match/switch 3 (9 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ExpressionChecker.handleFuncCall (cognitive 58) · ×1
  • ExpressionChecker.handleFuncCall (cognitive 58) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala:334 — ExpressionChecker.handleFuncCall has cognitive complexity 58 (threshold 15). Drivers by points: match/switch 11 (31 pts), if/else 24 (25 pts), boolean chains 2 (nesting depth added 21). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ZincCompiler.compile (cognitive 57) · ×1
  • ZincCompiler.compile (cognitive 57) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincCompiler.scala:92 — ZincCompiler.compile has cognitive complexity 57 (threshold 15). Drivers by points: if/else 25 (39 pts), loops 3 (6 pts), boolean chains 4, error handling 4, match/switch 3 (4 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SpinningTransferQueue.xfer (cognitive 57) · ×1
  • SpinningTransferQueue.xfer (cognitive 57) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/SpinningTransferQueue.java:566 — SpinningTransferQueue.xfer has cognitive complexity 57 (threshold 15). Drivers by points: if/else 10 (35 pts), ternaries 2 (10 pts), loops 3 (8 pts), boolean chains 4 (nesting depth added 38). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · JavaOpts.filterJavaRuntimeOptions (cognitive 55) · ×1
  • JavaOpts.filterJavaRuntimeOptions (cognitive 55) optimus/buildtool/projects/core/src/main/scala/optimus/buildtool/utils/JavaOpts.scala:220 — JavaOpts.filterJavaRuntimeOptions has cognitive complexity 55 (threshold 15). Drivers by points: if/else 28 (38 pts), boolean chains 16, match/switch 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NodeName.cleanNodeClassName (cognitive 55) · ×1
  • NodeName.cleanNodeClassName (cognitive 55) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/NodeName.scala:83 — NodeName.cleanNodeClassName has cognitive complexity 55 (threshold 15). Drivers by points: if/else 18 (42 pts), loops 2 (8 pts), boolean chains 5 (nesting depth added 30). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · CopyDynamic.extract (cognitive 55) · ×1
  • CopyDynamic.extract (cognitive 55) optimus/platform/projects/platform/src/main/scala/optimus/platform/internal/CopyMethodMacros.scala:27 — CopyDynamic.extract has cognitive complexity 55 (threshold 15). Drivers by points: if/else 20 (44 pts), boolean chains 8, loops 1 (2 pts), match/switch 1 (nesting depth added 25). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DefaultBinder.bindFlatMap (cognitive 55) · ×1
  • DefaultBinder.bindFlatMap (cognitive 55) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:605 — DefaultBinder.bindFlatMap has cognitive complexity 55 (threshold 15). Drivers by points: if/else 19 (37 pts), match/switch 4 (13 pts), boolean chains 5 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DefaultBinder.bindAggregate1 (cognitive 55) · ×1
  • DefaultBinder.bindAggregate1 (cognitive 55) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:836 — DefaultBinder.bindAggregate1 has cognitive complexity 55 (threshold 15). Drivers by points: if/else 21 (44 pts), match/switch 3 (10 pts), boolean chains 1 (nesting depth added 30). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · TopologyParser._parse (cognitive 54) · ×1
  • TopologyParser._parse (cognitive 54) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/topology/TopologyParser.java:37 — TopologyParser._parse has cognitive complexity 54 (threshold 15). Drivers by points: match/switch 4 (27 pts), if/else 7 (20 pts), loops 2 (5 pts), error handling 2 (nesting depth added 39). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DefaultBinder.bindWhere (cognitive 52) · ×1
  • DefaultBinder.bindWhere (cognitive 52) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:552 — DefaultBinder.bindWhere has cognitive complexity 52 (threshold 15). Drivers by points: if/else 20 (40 pts), match/switch 3 (9 pts), loops 1 (3 pts) (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GridProfiler.getCSV (cognitive 51) · ×1
  • GridProfiler.getCSV (cognitive 51) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfiler.scala:1147 — GridProfiler.getCSV has cognitive complexity 51 (threshold 15). Drivers by points: if/else 20 (35 pts), loops 6 (11 pts), match/switch 1 (4 pts), boolean chains 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProductFormats.unmangle (cognitive 50) · ×1
  • ProductFormats.unmangle (cognitive 50) optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormats.scala:99 — ProductFormats.unmangle has cognitive complexity 50 (threshold 15). Drivers by points: if/else 16 (26 pts), boolean chains 21, match/switch 1 (3 pts) (nesting depth added 12). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D2 · Cognitive Complexity · ExcelReaderIterable.convertItemValue (cognitive 49) · ×1
  • ExcelReaderIterable.convertItemValue (cognitive 49) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/excel/ExcelMultiRelation.scala:186 — ExcelReaderIterable.convertItemValue has cognitive complexity 49 (threshold 15). Drivers by points: if/else 25, match/switch 12 (24 pts) (nesting depth added 12). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · LoomAdapter.enrichMethod (cognitive 49) · ×1
  • LoomAdapter.enrichMethod (cognitive 49) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/LoomAdapter.java:270 — LoomAdapter.enrichMethod has cognitive complexity 49 (threshold 15). Drivers by points: if/else 17 (43 pts), boolean chains 5, loops 1 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UpstreamArtifacts.distinctArtifacts (cognitive 48) · ×1
  • UpstreamArtifacts.distinctArtifacts (cognitive 48) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/scope/UpstreamArtifacts.scala:35 — UpstreamArtifacts.distinctArtifacts has cognitive complexity 48 (threshold 15). Drivers by points: if/else 16 (33 pts), match/switch 4 (10 pts), loops 3 (4 pts), boolean chains 1 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DependencyLoader.loadLibrary (cognitive 48) · ×1
  • DependencyLoader.loadLibrary (cognitive 48) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/dependencies/DependencyLoader.scala:95 — DependencyLoader.loadLibrary has cognitive complexity 48 (threshold 15). Drivers by points: if/else 18 (27 pts), loops 7 (16 pts), match/switch 2 (3 pts), boolean chains 2 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BackgroundProcess._startWithRetry (cognitive 47) · ×1
  • BackgroundProcess._startWithRetry (cognitive 47) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/utils/process/BackgroundProcess.scala:58 — BackgroundProcess._startWithRetry has cognitive complexity 47 (threshold 15). Drivers by points: if/else 15 (28 pts), match/switch 8 (17 pts), boolean chains 2 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DSIClient.executeCommandsWithRetry (cognitive 47) · ×1
  • DSIClient.executeCommandsWithRetry (cognitive 47) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/DSIClient.scala:236 — DSIClient.executeCommandsWithRetry has cognitive complexity 47 (threshold 15). Drivers by points: if/else 20 (35 pts), match/switch 5 (12 pts) (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OptimusRefchecks.checkKeyOrIndex (cognitive 47) · ×1
  • OptimusRefchecks.checkKeyOrIndex (cognitive 47) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:196 — OptimusRefchecks.checkKeyOrIndex has cognitive complexity 47 (threshold 15). Drivers by points: if/else 13 (21 pts), boolean chains 20, match/switch 4 (6 pts) (nesting depth added 10). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DefaultBinder.bindContains (cognitive 47) · ×1
  • DefaultBinder.bindContains (cognitive 47) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:347 — DefaultBinder.bindContains has cognitive complexity 47 (threshold 15). Drivers by points: if/else 19 (33 pts), boolean chains 7, match/switch 3 (7 pts) (nesting depth added 18). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · StratosphereConfig.<init> (cognitive 47) · ×1
  • StratosphereConfig.<init> (cognitive 47) optimus/stratosphere/bootstrap/src/main/java/optimus/stratosphere/bootstrap/config/StratosphereConfig.java:139 — StratosphereConfig.<init> has cognitive complexity 47 (threshold 15). Drivers by points: if/else 29 (37 pts), boolean chains 5, loops 1 (3 pts), error handling 2 (nesting depth added 10). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · AsyncRetrievalOperationImpl.resultReceived (cognitive 47) · ×1
  • AsyncRetrievalOperationImpl.resultReceived (cognitive 47) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/AsyncRetrievalOperationImpl.java:386 — AsyncRetrievalOperationImpl.resultReceived has cognitive complexity 47 (threshold 15). Drivers by points: if/else 21 (41 pts), boolean chains 3, error handling 1 (2 pts), ternaries 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SimpleRetrievalOperation.update (cognitive 47) · ×1
  • SimpleRetrievalOperation.update (cognitive 47) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/protocol/SimpleRetrievalOperation.java:74 — SimpleRetrievalOperation.update has cognitive complexity 47 (threshold 15). Drivers by points: if/else 19 (41 pts), boolean chains 3, match/switch 1 (3 pts) (nesting depth added 24). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · SpinningTransferQueue.unsplice (cognitive 47) · ×1
  • SpinningTransferQueue.unsplice (cognitive 47) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/SpinningTransferQueue.java:847 — SpinningTransferQueue.unsplice has cognitive complexity 47 (threshold 15). Drivers by points: if/else 10 (34 pts), loops 2 (7 pts), boolean chains 6 (nesting depth added 29). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ModuleSetDefinition.validate (cognitive 46) · ×1
  • ModuleSetDefinition.validate (cognitive 46) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ModuleSetDefinition.scala:241 — ModuleSetDefinition.validate has cognitive complexity 46 (threshold 15). Drivers by points: loops 14 (41 pts), if/else 5 (nesting depth added 27). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · StackAnalysis.buildStackTrees (cognitive 46) · ×1
  • StackAnalysis.buildStackTrees (cognitive 46) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:1230 — StackAnalysis.buildStackTrees has cognitive complexity 46 (threshold 15). Drivers by points: if/else 21 (34 pts), loops 2 (6 pts), error handling 1 (3 pts), boolean chains 2, match/switch 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Typer.phase2Matches (cognitive 45) · ×1
  • Typer.phase2Matches (cognitive 45) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/Typer.scala:578 — Typer.phase2Matches has cognitive complexity 45 (threshold 15). Drivers by points: if/else 13 (42 pts), boolean chains 2, loops 1 (nesting depth added 29). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ContextualChecker.traverse (cognitive 44) · ×1
  • ContextualChecker.traverse (cognitive 44) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/refchecks/ContextualChecks.scala:73 — ContextualChecker.traverse has cognitive complexity 44 (threshold 15). Drivers by points: if/else 17 (28 pts), match/switch 6 (12 pts), boolean chains 4 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NodeMenu.create (cognitive 44) · ×1
  • NodeMenu.create (cognitive 44) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeMenu.scala:103 — NodeMenu.create has cognitive complexity 44 (threshold 15). Drivers by points: if/else 33 (34 pts), boolean chains 3, match/switch 3, error handling 1 (2 pts), loops 1 (2 pts) (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · DefaultBinder.bindJoin (cognitive 44) · ×1
  • DefaultBinder.bindJoin (cognitive 44) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:1039 — DefaultBinder.bindJoin has cognitive complexity 44 (threshold 15). Drivers by points: if/else 14 (22 pts), match/switch 9 (19 pts), boolean chains 3 (nesting depth added 18). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · NettyEstablishedChannelHandler.processWrite (cognitive 44) · ×1
  • NettyEstablishedChannelHandler.processWrite (cognitive 44) optimus/dht/projects/common3/src/main/java/optimus/dht/common/internal/transport/NettyEstablishedChannelHandler.java:263 — NettyEstablishedChannelHandler.processWrite has cognitive complexity 44 (threshold 15). Drivers by points: if/else 16 (37 pts), loops 3 (5 pts), boolean chains 2 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StandardBuilder.buildScopes (cognitive 43) · ×1
  • StandardBuilder.buildScopes (cognitive 43) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/StandardBuilder.scala:143 — StandardBuilder.buildScopes has cognitive complexity 43 (threshold 15). Drivers by points: if/else 19 (22 pts), match/switch 9 (19 pts), boolean chains 1, error handling 1 (nesting depth added 13). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · Scenario.validate (cognitive 43) · ×1
  • Scenario.validate (cognitive 43) optimus/platform/projects/core/src/main/scala/optimus/platform/Scenario.scala:445 — Scenario.validate has cognitive complexity 43 (threshold 15). Drivers by points: if/else 14 (32 pts), match/switch 2 (7 pts), boolean chains 3, loops 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AutoAsync.opaque (cognitive 43) · ×1
  • AutoAsync.opaque (cognitive 43) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala:324 — AutoAsync.opaque has cognitive complexity 43 (threshold 15). Drivers by points: if/else 16 (33 pts), boolean chains 8, match/switch 1 (2 pts) (nesting depth added 18). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · OptimusIteratorLinter.traverse (cognitive 43) · ×1
  • OptimusIteratorLinter.traverse (cognitive 43) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/refchecks/IteratorUsage.scala:124 — OptimusIteratorLinter.traverse has cognitive complexity 43 (threshold 15). Drivers by points: if/else 11 (23 pts), match/switch 5 (14 pts), boolean chains 6 (nesting depth added 21). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · StandardsTraverser.checkDefDef (cognitive 43) · ×1
  • StandardsTraverser.checkDefDef (cognitive 43) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/PostTyperCodingStandardsComponent.scala:201 — StandardsTraverser.checkDefDef has cognitive complexity 43 (threshold 15). Drivers by points: if/else 14 (25 pts), boolean chains 11, match/switch 2 (4 pts), loops 1 (3 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · QueueingConnection.writeAllPending_locked (cognitive 43) · ×1
  • QueueingConnection.writeAllPending_locked (cognitive 43) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/QueueingConnection.java:112 — QueueingConnection.writeAllPending_locked has cognitive complexity 43 (threshold 15). Drivers by points: if/else 14 (34 pts), ternaries 1 (4 pts), error handling 1 (3 pts), boolean chains 1, loops 1 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OptimusArraysSeq.map (cognitive 42) · ×1
  • OptimusArraysSeq.map (cognitive 42) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:282 — OptimusArraysSeq.map has cognitive complexity 42 (threshold 15). Drivers by points: if/else 12 (36 pts), loops 2 (5 pts), boolean chains 1 (nesting depth added 27). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · AsyncGraph.transformSafe (cognitive 42) · ×1
  • AsyncGraph.transformSafe (cognitive 42) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AsyncGraphComponent.scala:543 — AsyncGraph.transformSafe has cognitive complexity 42 (threshold 15). Drivers by points: if/else 13 (19 pts), match/switch 5 (10 pts), boolean chains 7, loops 2 (6 pts) (nesting depth added 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · LambdaEmitter.emitFuncCall (cognitive 42) · ×1
  • LambdaEmitter.emitFuncCall (cognitive 42) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/LambdaCompiler.scala:749 — LambdaEmitter.emitFuncCall has cognitive complexity 42 (threshold 15). Drivers by points: if/else 16 (38 pts), match/switch 2 (3 pts), boolean chains 1 (nesting depth added 23). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ClassParser.valueForDef (cognitive 42) · ×1
  • ClassParser.valueForDef (cognitive 42) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ClassParser.java:292 — ClassParser.valueForDef has cognitive complexity 42 (threshold 15). Drivers by points: if/else 20 (27 pts), boolean chains 9, error handling 2 (6 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ExperimentalAsyncIterator2.buf (cognitive 41) · ×1
  • ExperimentalAsyncIterator2.buf (cognitive 41) optimus/platform/projects/core/src/main/scala/optimus/graph/experimental/ExperimentalAsyncIterator2.scala:62 — ExperimentalAsyncIterator2.buf has cognitive complexity 41 (threshold 15). Drivers by points: if/else 27 (36 pts), boolean chains 2, match/switch 1 (2 pts), loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AppStats.accumulateImpl (cognitive 41) · ×1
  • AppStats.accumulateImpl (cognitive 41) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/AppStats.scala:384 — AppStats.accumulateImpl has cognitive complexity 41 (threshold 15). Drivers by points: if/else 12 (32 pts), match/switch 2 (7 pts), boolean chains 2 (nesting depth added 25). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · OptimusDALRefChecks.checkAccelerated (cognitive 41) · ×1
  • OptimusDALRefChecks.checkAccelerated (cognitive 41) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:156 — OptimusDALRefChecks.checkAccelerated has cognitive complexity 41 (threshold 15). Drivers by points: if/else 19 (25 pts), boolean chains 8, match/switch 5 (8 pts) (nesting depth added 9). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · DefaultServerConnectionsManager.nodesRegistryChanged (cognitive 41) · ×1
  • DefaultServerConnectionsManager.nodesRegistryChanged (cognitive 41) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/servers/DefaultServerConnectionsManager.java:344 — DefaultServerConnectionsManager.nodesRegistryChanged has cognitive complexity 41 (threshold 15). Drivers by points: if/else 12 (34 pts), loops 3 (5 pts), match/switch 1 (2 pts) (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProtoPutMessageGroup.addValue (cognitive 41) · ×1
  • ProtoPutMessageGroup.addValue (cognitive 41) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoPutMessageGroup.java:349 — ProtoPutMessageGroup.addValue has cognitive complexity 41 (threshold 15). Drivers by points: if/else 22 (36 pts), error handling 1 (3 pts), boolean chains 2 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GroupingNodeBatcherSchedulerPluginBase.adapt (cognitive 40) · ×1
  • GroupingNodeBatcherSchedulerPluginBase.adapt (cognitive 40) optimus/platform/projects/core/src/main/scala/optimus/graph/NodeBatcherSchedulerPlugin.scala:598 — GroupingNodeBatcherSchedulerPluginBase.adapt has cognitive complexity 40 (threshold 15). Drivers by points: if/else 19 (33 pts), error handling 2 (4 pts), boolean chains 3 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProtoPickleSerializer.protoToSlottedBuffer (cognitive 40) · ×1
  • ProtoPickleSerializer.protoToSlottedBuffer (cognitive 40) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PropertyMapProtoSerialization.scala:201 — ProtoPickleSerializer.protoToSlottedBuffer has cognitive complexity 40 (threshold 15). Drivers by points: if/else 14 (26 pts), match/switch 2 (7 pts), loops 2 (5 pts), boolean chains 2 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LWTThread.activeMultiple (cognitive 40) · ×1
  • LWTThread.activeMultiple (cognitive 40) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/thread/lwt/LWTThread.java:160 — LWTThread.activeMultiple has cognitive complexity 40 (threshold 15). Drivers by points: loops 5 (14 pts), if/else 7 (13 pts), error handling 4 (12 pts), boolean chains 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AppStatsPool.get (cognitive 39) · ×1
  • AppStatsPool.get (cognitive 39) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/AppStatsPool.scala:136 — AppStatsPool.get has cognitive complexity 39 (threshold 15). Drivers by points: if/else 12 (32 pts), match/switch 1 (5 pts), boolean chains 2 (nesting depth added 24). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · TraceReporter.traceEntity (cognitive 39) · ×1
  • TraceReporter.traceEntity (cognitive 39) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/temporalSurface/impl/TemporalContextTrace.scala:255 — TraceReporter.traceEntity has cognitive complexity 39 (threshold 15). Drivers by points: match/switch 9 (24 pts), if/else 12 (15 pts) (nesting depth added 18). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · OptimusExportInfo.buildMetadataMap (cognitive 39) · ×1
  • OptimusExportInfo.buildMetadataMap (cognitive 39) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusExportInfoComponent.scala:137 — OptimusExportInfo.buildMetadataMap has cognitive complexity 39 (threshold 15). Drivers by points: if/else 21 (22 pts), match/switch 8 (9 pts), boolean chains 8 (nesting depth added 2). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · CleanName.prettyFrameName (cognitive 39) · ×1
  • CleanName.prettyFrameName (cognitive 39) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:528 — CleanName.prettyFrameName has cognitive complexity 39 (threshold 15). Drivers by points: if/else 19 (24 pts), boolean chains 8, loops 3 (5 pts), error handling 1 (2 pts) (nesting depth added 8). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · RingTree.project (cognitive 39) · ×1
  • RingTree.project (cognitive 39) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingTree.java:209 — RingTree.project has cognitive complexity 39 (threshold 15). Drivers by points: if/else 10 (25 pts), loops 4 (14 pts) (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MultiSourceDependenciesLoader.loadJvmDepsIvyConfigurations (cognitive 38) · ×1
  • MultiSourceDependenciesLoader.loadJvmDepsIvyConfigurations (cognitive 38) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/dependencies/MultiSourceDependenciesLoader.scala:73 — MultiSourceDependenciesLoader.loadJvmDepsIvyConfigurations has cognitive complexity 38 (threshold 15). Drivers by points: if/else 18 (21 pts), loops 4 (10 pts), match/switch 5 (7 pts) (nesting depth added 11). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · AdjustAST.addPropsToModuleDef (cognitive 38) · ×1
  • AdjustAST.addPropsToModuleDef (cognitive 38) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:224 — AdjustAST.addPropsToModuleDef has cognitive complexity 38 (threshold 15). Drivers by points: if/else 20 (25 pts), match/switch 5 (8 pts), boolean chains 5 (nesting depth added 8). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · TTTableCellRender.getTextOnSetValue (cognitive 38) · ×1
  • TTTableCellRender.getTextOnSetValue (cognitive 38) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NPTableRenderer.scala:184 — TTTableCellRender.getTextOnSetValue has cognitive complexity 38 (threshold 15). Drivers by points: if/else 23 (36 pts), boolean chains 1, match/switch 1 (nesting depth added 13). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DefaultBinder.bindAggregate2 (cognitive 38) · ×1
  • DefaultBinder.bindAggregate2 (cognitive 38) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:932 — DefaultBinder.bindAggregate2 has cognitive complexity 38 (threshold 15). Drivers by points: if/else 17 (37 pts), match/switch 1 (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · InstrumentationInjector.transform (cognitive 38) · ×1
  • InstrumentationInjector.transform (cognitive 38) optimus/platform/projects/entityagent/src/main/java/optimus/debug/InstrumentationInjector.java:46 — InstrumentationInjector.transform has cognitive complexity 38 (threshold 15). Drivers by points: if/else 20 (28 pts), boolean chains 9, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RawRetrievalResult.setStoredValue (cognitive 38) · ×1
  • RawRetrievalResult.setStoredValue (cognitive 38) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/common/RawRetrievalResult.java:86 — RawRetrievalResult.setStoredValue has cognitive complexity 38 (threshold 15). Drivers by points: if/else 14 (33 pts), error handling 1 (4 pts), boolean chains 1 (nesting depth added 22). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · RingTree.merge (cognitive 38) · ×1
  • RingTree.merge (cognitive 38) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingTree.java:416 — RingTree.merge has cognitive complexity 38 (threshold 15). Drivers by points: if/else 17 (31 pts), loops 2 (3 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · KDBSerializerImpl.deserializeObjectList (cognitive 37) · ×1
  • KDBSerializerImpl.deserializeObjectList (cognitive 37) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/persistence/protocol/KDBSerializer.scala:372 — KDBSerializerImpl.deserializeObjectList has cognitive complexity 37 (threshold 15). Drivers by points: if/else 10 (24 pts), loops 4 (10 pts), boolean chains 3 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NamespaceOptionsClientBase.getNamespacePropertiesWithTimeout (cognitive 37) · ×1
  • NamespaceOptionsClientBase.getNamespacePropertiesWithTimeout (cognitive 37) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/common/NamespaceOptionsClientBase.java:374 — NamespaceOptionsClientBase.getNamespacePropertiesWithTimeout has cognitive complexity 37 (threshold 15). Drivers by points: if/else 13 (33 pts), loops 1 (4 pts) (nesting depth added 23). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Utils.pathMatches (cognitive 36) · ×1
  • Utils.pathMatches (cognitive 36) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:502 — Utils.pathMatches has cognitive complexity 36 (threshold 15). Drivers by points: if/else 11 (23 pts), loops 2 (7 pts), boolean chains 6 (nesting depth added 17). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · NodeLift.nodeLift (cognitive 36) · ×1
  • NodeLift.nodeLift (cognitive 36) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/NodeLiftComponent.scala:93 — NodeLift.nodeLift has cognitive complexity 36 (threshold 15). Drivers by points: if/else 15 (25 pts), match/switch 3 (7 pts), boolean chains 4 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PropertyInfoTransformer.transform (cognitive 36) · ×1
  • PropertyInfoTransformer.transform (cognitive 36) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/provider/PropertyInfoProvider.scala:639 — PropertyInfoTransformer.transform has cognitive complexity 36 (threshold 15). Drivers by points: if/else 7 (14 pts), match/switch 3 (13 pts), loops 2 (9 pts) (nesting depth added 24). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ClassPathUtils.expandClasspath (cognitive 36) · ×1
  • ClassPathUtils.expandClasspath (cognitive 36) optimus/platform/projects/utils/src/main/scala/optimus/platform/utils/ClassPathUtils.scala:118 — ClassPathUtils.expandClasspath has cognitive complexity 36 (threshold 15). Drivers by points: if/else 9 (25 pts), error handling 1 (5 pts), loops 1 (4 pts), boolean chains 2 (nesting depth added 23). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · MultiSourceDependenciesLoader.load (cognitive 35) · ×1
  • MultiSourceDependenciesLoader.load (cognitive 35) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/dependencies/MultiSourceDependenciesLoader.scala:224 — MultiSourceDependenciesLoader.load has cognitive complexity 35 (threshold 15). Drivers by points: loops 7 (23 pts), if/else 7 (8 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 19). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · ScopeDefinitionCompiler.checkScopes (cognitive 35) · ×1
  • ScopeDefinitionCompiler.checkScopes (cognitive 35) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ScopeDefinitionCompiler.scala:311 — ScopeDefinitionCompiler.checkScopes has cognitive complexity 35 (threshold 15). Drivers by points: if/else 11 (14 pts), boolean chains 12, match/switch 9 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SummonImpl.summon (cognitive 35) · ×1
  • SummonImpl.summon (cognitive 35) optimus/platform/projects/core/src/main/scala/optimus/platform/relational/tree/TypeInfo.scala:527 — SummonImpl.summon has cognitive complexity 35 (threshold 15). Drivers by points: if/else 16 (22 pts), match/switch 4 (7 pts), boolean chains 4, loops 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AppStatsControl.controlFromParams (cognitive 35) · ×1
  • AppStatsControl.controlFromParams (cognitive 35) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/AppStatsControl.scala:90 — AppStatsControl.controlFromParams has cognitive complexity 35 (threshold 15). Drivers by points: if/else 15 (29 pts), loops 2 (4 pts), error handling 1 (2 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DALFormatter.handleFuncCall (cognitive 35) · ×1
  • DALFormatter.handleFuncCall (cognitive 35) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALFormatter.scala:123 — DALFormatter.handleFuncCall has cognitive complexity 35 (threshold 15). Drivers by points: if/else 21 (24 pts), match/switch 3 (7 pts), boolean chains 4 (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ActivePutListeners.receivedPutResponse (cognitive 35) · ×1
  • ActivePutListeners.receivedPutResponse (cognitive 35) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/ActivePutListeners.java:136 — ActivePutListeners.receivedPutResponse has cognitive complexity 35 (threshold 15). Drivers by points: if/else 12 (24 pts), loops 3 (11 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ScopeDefinitionCompiler.loadScopeDeps (cognitive 34) · ×1
  • ScopeDefinitionCompiler.loadScopeDeps (cognitive 34) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ScopeDefinitionCompiler.scala:585 — ScopeDefinitionCompiler.loadScopeDeps has cognitive complexity 34 (threshold 15). Drivers by points: if/else 17 (27 pts), match/switch 2 (5 pts), boolean chains 2 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TwkResolver.nextInCurrent (cognitive 34) · ×1
  • TwkResolver.nextInCurrent (cognitive 34) optimus/platform/projects/core/src/main/scala/optimus/graph/TwkResolver.scala:145 — TwkResolver.nextInCurrent has cognitive complexity 34 (threshold 15). Drivers by points: if/else 17 (30 pts), boolean chains 3, match/switch 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DependencyTrackerQueue.afterActionCompleted (cognitive 34) · ×1
  • DependencyTrackerQueue.afterActionCompleted (cognitive 34) optimus/platform/projects/core/src/main/scala/optimus/graph/tracking/DependencyTrackerQueue.scala:288 — DependencyTrackerQueue.afterActionCompleted has cognitive complexity 34 (threshold 15). Drivers by points: if/else 18 (30 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Utils.strSplit (cognitive 34) · ×1
  • Utils.strSplit (cognitive 34) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:65 — Utils.strSplit has cognitive complexity 34 (threshold 15). Drivers by points: if/else 12 (31 pts), loops 1 (3 pts) (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · DALRegisteredIndexBinder.handleFuncCall (cognitive 34) · ×1
  • DALRegisteredIndexBinder.handleFuncCall (cognitive 34) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALRegisteredIndexBinder.scala:30 — DALRegisteredIndexBinder.handleFuncCall has cognitive complexity 34 (threshold 15). Drivers by points: match/switch 9 (19 pts), if/else 9, boolean chains 6 (nesting depth added 10). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · HotCodeReplaceTransformer.scanForClassJarUpdates (cognitive 34) · ×1
  • HotCodeReplaceTransformer.scanForClassJarUpdates (cognitive 34) optimus/platform/projects/entityagent/src/main/java/optimus/HotCodeReplaceTransformer.java:253 — HotCodeReplaceTransformer.scanForClassJarUpdates has cognitive complexity 34 (threshold 15). Drivers by points: if/else 5 (21 pts), loops 3 (7 pts), ternaries 1 (6 pts) (nesting depth added 25). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ActiveClientOperationTable.checkOpForTimeouts (cognitive 34) · ×1
  • ActiveClientOperationTable.checkOpForTimeouts (cognitive 34) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/ActiveClientOperationTable.java:121 — ActiveClientOperationTable.checkOpForTimeouts has cognitive complexity 34 (threshold 15). Drivers by points: if/else 12 (32 pts), boolean chains 2 (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · SingleWriterConsistentWrite.update (cognitive 34) · ×1
  • SingleWriterConsistentWrite.update (cognitive 34) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/protocol/SingleWriterConsistentWrite.java:41 — SingleWriterConsistentWrite.update has cognitive complexity 34 (threshold 15). Drivers by points: if/else 12 (30 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RegexScanner.scanLines (cognitive 33) · ×1
  • RegexScanner.scanLines (cognitive 33) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/RegexScanner.scala:233 — RegexScanner.scanLines has cognitive complexity 33 (threshold 15). Drivers by points: if/else 15 (32 pts), loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · XSDiffer.tweaksEqual (cognitive 33) · ×1
  • XSDiffer.tweaksEqual (cognitive 33) optimus/platform/projects/core/src/main/scala/optimus/graph/RecordingScenario.scala:275 — XSDiffer.tweaksEqual has cognitive complexity 33 (threshold 15). Drivers by points: if/else 17 (31 pts), loops 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ScenarioStack.writeHtml (cognitive 33) · ×1
  • ScenarioStack.writeHtml (cognitive 33) optimus/platform/projects/core/src/main/scala/optimus/platform/ScenarioStack.scala:307 — ScenarioStack.writeHtml has cognitive complexity 33 (threshold 15). Drivers by points: if/else 16 (31 pts), boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClassifierTransformer.transformSafe (cognitive 33) · ×1
  • ClassifierTransformer.transformSafe (cognitive 33) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/ClassifierComponent.scala:64 — ClassifierTransformer.transformSafe has cognitive complexity 33 (threshold 15). Drivers by points: if/else 14 (24 pts), boolean chains 5, match/switch 2 (4 pts) (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · RedirectAccessors.valBackingFields (cognitive 33) · ×1
  • RedirectAccessors.valBackingFields (cognitive 33) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/RedirectAccessorsComponent.scala:327 — RedirectAccessors.valBackingFields has cognitive complexity 33 (threshold 15). Drivers by points: if/else 21 (29 pts), boolean chains 3, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SubqueryMerger.canMergeWithFrom (cognitive 33) · ×1
  • SubqueryMerger.canMergeWithFrom (cognitive 33) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/RedundantSubqueryRemover.scala:99 — SubqueryMerger.canMergeWithFrom has cognitive complexity 33 (threshold 15). Drivers by points: boolean chains 18, if/else 14 (15 pts) (nesting depth added 1). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · SyncController.checkUpstreamDependencies (cognitive 33) · ×1
  • SyncController.checkUpstreamDependencies (cognitive 33) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/SyncController.java:253 — SyncController.checkUpstreamDependencies has cognitive complexity 33 (threshold 15). Drivers by points: if/else 12 (31 pts), loops 1 (2 pts) (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · DirectoryInMemory.largeUpdate (cognitive 33) · ×1
  • DirectoryInMemory.largeUpdate (cognitive 33) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/skfs/dir/DirectoryInMemory.java:210 — DirectoryInMemory.largeUpdate has cognitive complexity 33 (threshold 15). Drivers by points: if/else 14 (22 pts), ternaries 3 (7 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PythonDependenciesLoader.loadAllDependencies (cognitive 32) · ×1
  • PythonDependenciesLoader.loadAllDependencies (cognitive 32) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/dependencies/PythonDependenciesLoader.scala:123 — PythonDependenciesLoader.loadAllDependencies has cognitive complexity 32 (threshold 15). Drivers by points: loops 11 (22 pts), if/else 7 (10 pts) (nesting depth added 14). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · RequestSender.sendBatch (cognitive 32) · ×1
  • RequestSender.sendBatch (cognitive 32) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dsi/protobufutils/RequestSender.scala:182 — RequestSender.sendBatch has cognitive complexity 32 (threshold 15). Drivers by points: if/else 18 (21 pts), error handling 4, match/switch 3 (4 pts), boolean chains 2, loops 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · QueryTemporalityResolver.resolveQueryTemporality (cognitive 32) · ×1
  • QueryTemporalityResolver.resolveQueryTemporality (cognitive 32) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/temporalSurface/impl/QueryTemporalityResolver.scala:51 — QueryTemporalityResolver.resolveQueryTemporality has cognitive complexity 32 (threshold 15). Drivers by points: if/else 12 (24 pts), match/switch 3 (8 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NodeSynthesis.transformRawNodeDef (cognitive 32) · ×1
  • NodeSynthesis.transformRawNodeDef (cognitive 32) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/NodeSynthesis.scala:61 — NodeSynthesis.transformRawNodeDef has cognitive complexity 32 (threshold 15). Drivers by points: if/else 12 (19 pts), boolean chains 7, match/switch 4 (6 pts) (nesting depth added 9). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · OptimusRefchecks.checkValidParent (cognitive 32) · ×1
  • OptimusRefchecks.checkValidParent (cognitive 32) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:613 — OptimusRefchecks.checkValidParent has cognitive complexity 32 (threshold 15). Drivers by points: if/else 9 (24 pts), boolean chains 7, loops 1 (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · RedirectAccessors.rewriteWithValBackingFields (cognitive 32) · ×1
  • RedirectAccessors.rewriteWithValBackingFields (cognitive 32) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/RedirectAccessorsComponent.scala:237 — RedirectAccessors.rewriteWithValBackingFields has cognitive complexity 32 (threshold 15). Drivers by points: if/else 14 (26 pts), boolean chains 5, match/switch 1 (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · EntityAgentTransformer.transform (cognitive 32) · ×1
  • EntityAgentTransformer.transform (cognitive 32) optimus/platform/projects/entityagent/src/main/java/optimus/EntityAgent.java:102 — EntityAgentTransformer.transform has cognitive complexity 32 (threshold 15). Drivers by points: if/else 19 (23 pts), boolean chains 3, error handling 1 (3 pts), ternaries 1 (3 pts) (nesting depth added 8). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ScopeDefinitionCompiler.loadInheritableCppBuild (cognitive 31) · ×1
  • ScopeDefinitionCompiler.loadInheritableCppBuild (cognitive 31) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ScopeDefinitionCompiler.scala:1170 — ScopeDefinitionCompiler.loadInheritableCppBuild has cognitive complexity 31 (threshold 15). Drivers by points: if/else 11 (18 pts), match/switch 3 (7 pts), loops 2 (5 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OptimusArraysSeq.map (cognitive 31) · ×1
  • OptimusArraysSeq.map (cognitive 31) optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:256 — OptimusArraysSeq.map has cognitive complexity 31 (threshold 15). Drivers by points: if/else 10 (27 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 18). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · TraceExplorer.writeCsvDot (cognitive 31) · ×1
  • TraceExplorer.writeCsvDot (cognitive 31) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/TraceExplorer.scala:141 — TraceExplorer.writeCsvDot has cognitive complexity 31 (threshold 15). Drivers by points: if/else 17 (29 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AnyFormatted.transform (cognitive 31) · ×1
  • AnyFormatted.transform (cognitive 31) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/rewrite/RewriteComponent.scala:1051 — AnyFormatted.transform has cognitive complexity 31 (threshold 15). Drivers by points: if/else 14 (21 pts), match/switch 5 (10 pts) (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · NettyEstablishedChannelHandler.channelRead (cognitive 31) · ×1
  • NettyEstablishedChannelHandler.channelRead (cognitive 31) optimus/dht/projects/common3/src/main/java/optimus/dht/common/internal/transport/NettyEstablishedChannelHandler.java:116 — NettyEstablishedChannelHandler.channelRead has cognitive complexity 31 (threshold 15). Drivers by points: if/else 12 (28 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BlockFolding.reduce (cognitive 31) · ×1
  • BlockFolding.reduce (cognitive 31) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/compiler/BlockFolding.java:32 — BlockFolding.reduce has cognitive complexity 31 (threshold 15). Drivers by points: if/else 7 (18 pts), loops 3 (12 pts), boolean chains 1 (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · AsyncPutOperationImpl.createMessagesForIncomplete (cognitive 31) · ×1
  • AsyncPutOperationImpl.createMessagesForIncomplete (cognitive 31) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/AsyncPutOperationImpl.java:187 — AsyncPutOperationImpl.createMessagesForIncomplete has cognitive complexity 31 (threshold 15). Drivers by points: if/else 9 (29 pts), boolean chains 1, loops 1 (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · CentralConvergenceController.syncRegion (cognitive 31) · ×1
  • CentralConvergenceController.syncRegion (cognitive 31) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/CentralConvergenceController.java:406 — CentralConvergenceController.syncRegion has cognitive complexity 31 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 4 (15 pts), boolean chains 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DHTRingManager.setTarget (cognitive 31) · ×1
  • DHTRingManager.setTarget (cognitive 31) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:448 — DHTRingManager.setTarget has cognitive complexity 31 (threshold 15). Drivers by points: if/else 13 (23 pts), error handling 4 (8 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · IORelay.run (cognitive 31) · ×1
  • IORelay.run (cognitive 31) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/io/IORelay.java:137 — IORelay.run has cognitive complexity 31 (threshold 15). Drivers by points: if/else 8 (21 pts), error handling 3 (5 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClassParser.createConstructorArgs (cognitive 31) · ×1
  • ClassParser.createConstructorArgs (cognitive 31) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ClassParser.java:238 — ClassParser.createConstructorArgs has cognitive complexity 31 (threshold 15). Drivers by points: if/else 8 (17 pts), error handling 3 (12 pts), boolean chains 1, loops 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ZincProfiler.logAndTraceProfileStats (cognitive 30) · ×1
  • ZincProfiler.logAndTraceProfileStats (cognitive 30) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincProfiler.scala:70 — ZincProfiler.logAndTraceProfileStats has cognitive complexity 30 (threshold 15). Drivers by points: if/else 18 (22 pts), loops 3 (6 pts), match/switch 1 (2 pts) (nesting depth added 8). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · DeploymentScriptProcessor.generateContent (cognitive 30) · ×1
  • DeploymentScriptProcessor.generateContent (cognitive 30) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/processors/DeploymentScriptProcessor.scala:101 — DeploymentScriptProcessor.generateContent has cognitive complexity 30 (threshold 15). Drivers by points: loops 6 (21 pts), match/switch 2 (7 pts), if/else 2 (nesting depth added 20). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · WorkspaceStructure.loadModuleStructure (cognitive 30) · ×1
  • WorkspaceStructure.loadModuleStructure (cognitive 30) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/WorkspaceStructure.scala:236 — WorkspaceStructure.loadModuleStructure has cognitive complexity 30 (threshold 15). Drivers by points: loops 8 (20 pts), if/else 9, boolean chains 1 (nesting depth added 12). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · Utils.strNextInteger (cognitive 30) · ×1
  • Utils.strNextInteger (cognitive 30) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:195 — Utils.strNextInteger has cognitive complexity 30 (threshold 15). Drivers by points: if/else 15 (23 pts), error handling 2 (4 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EstablishSessionResultSerializer.deserialize (cognitive 30) · ×1
  • EstablishSessionResultSerializer.deserialize (cognitive 30) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:778 — EstablishSessionResultSerializer.deserialize has cognitive complexity 30 (threshold 15). Drivers by points: if/else 16 (24 pts), match/switch 2 (6 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Visitor.findFirstDifference (cognitive 30) · ×1
  • Visitor.findFirstDifference (cognitive 30) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/recipes/CompareNodeDiffs.scala:289 — Visitor.findFirstDifference has cognitive complexity 30 (threshold 15). Drivers by points: if/else 13 (25 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SubqueryMerger.handleSelect (cognitive 30) · ×1
  • SubqueryMerger.handleSelect (cognitive 30) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/RedundantSubqueryRemover.scala:174 — SubqueryMerger.handleSelect has cognitive complexity 30 (threshold 15). Drivers by points: if/else 11 (21 pts), match/switch 2 (4 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 13). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · BreakoutToIteratorOp.transform (cognitive 30) · ×1
  • BreakoutToIteratorOp.transform (cognitive 30) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/rewrite/RewriteComponent.scala:569 — BreakoutToIteratorOp.transform has cognitive complexity 30 (threshold 15). Drivers by points: if/else 8 (19 pts), match/switch 3 (9 pts), boolean chains 2 (nesting depth added 17). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · Dynamic.getType (cognitive 30) · ×1
  • Dynamic.getType (cognitive 30) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/compiler/OpcodeHandlers.java:197 — Dynamic.getType has cognitive complexity 30 (threshold 15). Drivers by points: if/else 17 (30 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SelectorController.processKeyChangeRequest (cognitive 30) · ×1
  • SelectorController.processKeyChangeRequest (cognitive 30) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/SelectorController.java:354 — SelectorController.processKeyChangeRequest has cognitive complexity 30 (threshold 15). Drivers by points: if/else 11 (20 pts), boolean chains 5, error handling 2 (4 pts), match/switch 1 (nesting depth added 11). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DependencyTrackerQueue.registerOrEnqueueAction (cognitive 29) · ×1
  • DependencyTrackerQueue.registerOrEnqueueAction (cognitive 29) optimus/platform/projects/core/src/main/scala/optimus/graph/tracking/DependencyTrackerQueue.scala:206 — DependencyTrackerQueue.registerOrEnqueueAction has cognitive complexity 29 (threshold 15). Drivers by points: if/else 17 (24 pts), boolean chains 5 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AsyncGraph.transformFuncArgumentToNodeByName (cognitive 29) · ×1
  • AsyncGraph.transformFuncArgumentToNodeByName (cognitive 29) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AsyncGraphComponent.scala:283 — AsyncGraph.transformFuncArgumentToNodeByName has cognitive complexity 29 (threshold 15). Drivers by points: if/else 16 (18 pts), match/switch 4 (7 pts), boolean chains 3, error handling 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · NodeClassBuilder.addPropertyNodeMethods (cognitive 29) · ×1
  • NodeClassBuilder.addPropertyNodeMethods (cognitive 29) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/TypedNodeClassGenerator.scala:181 — NodeClassBuilder.addPropertyNodeMethods has cognitive complexity 29 (threshold 15). Drivers by points: if/else 16 (25 pts), boolean chains 4 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RelationalUtils.convertItemValue (cognitive 29) · ×1
  • RelationalUtils.convertItemValue (cognitive 29) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/internal/RelationalUtils.scala:78 — RelationalUtils.convertItemValue has cognitive complexity 29 (threshold 15). Drivers by points: if/else 9 (15 pts), match/switch 3 (5 pts), error handling 2 (4 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · Graph.dijkstra (cognitive 29) · ×1
  • Graph.dijkstra (cognitive 29) optimus/platform/projects/versioning_runtime/src/main/scala/optimus/platform/versioning/Graph.scala:91 — Graph.dijkstra has cognitive complexity 29 (threshold 15). Drivers by points: if/else 8 (17 pts), loops 3 (9 pts), boolean chains 3 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LoomAdapter.forwardQueuedMethods (cognitive 29) · ×1
  • LoomAdapter.forwardQueuedMethods (cognitive 29) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/LoomAdapter.java:483 — LoomAdapter.forwardQueuedMethods has cognitive complexity 29 (threshold 15). Drivers by points: if/else 14 (18 pts), boolean chains 6, ternaries 2 (3 pts), loops 2 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · OffsetListBase.getOffset_linear (cognitive 29) · ×1
  • OffsetListBase.getOffset_linear (cognitive 29) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/OffsetListBase.java:117 — OffsetListBase.getOffset_linear has cognitive complexity 29 (threshold 15). Drivers by points: if/else 11 (25 pts), boolean chains 3, loops 1 (nesting depth added 14). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · RingConfigWatcher.newVersion (cognitive 29) · ×1
  • RingConfigWatcher.newVersion (cognitive 29) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/meta/RingConfigWatcher.java:78 — RingConfigWatcher.newVersion has cognitive complexity 29 (threshold 15). Drivers by points: if/else 9 (17 pts), error handling 2 (6 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MsIvyRepository.findNoInverval (cognitive 28) · ×1
  • MsIvyRepository.findNoInverval (cognitive 28) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/resolvers/MsIvyRepository.scala:334 — MsIvyRepository.findNoInverval has cognitive complexity 28 (threshold 15). Drivers by points: loops 6 (18 pts), if/else 4 (10 pts) (nesting depth added 18). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · BuildSummaryRecorder.logStats (cognitive 28) · ×1
  • BuildSummaryRecorder.logStats (cognitive 28) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/trace/BuildSummaryRecorder.scala:141 — BuildSummaryRecorder.logStats has cognitive complexity 28 (threshold 15). Drivers by points: if/else 24, boolean chains 2, match/switch 1 (2 pts) (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ForbiddenDependencyConfigurationCompiler.loadForbiddenDependency (cognitive 28) · ×1
  • ForbiddenDependencyConfigurationCompiler.loadForbiddenDependency (cognitive 28) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ForbiddenDependencyConfigurationCompiler.scala:44 — ForbiddenDependencyConfigurationCompiler.loadForbiddenDependency has cognitive complexity 28 (threshold 15). Drivers by points: loops 7 (28 pts) (nesting depth added 21). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · EntityInfoComponent.transformInfo (cognitive 28) · ×1
  • EntityInfoComponent.transformInfo (cognitive 28) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/EntityInfoComponent.scala:143 — EntityInfoComponent.transformInfo has cognitive complexity 28 (threshold 15). Drivers by points: if/else 12 (22 pts), boolean chains 4, match/switch 1 (2 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReflectionHelper.typeString (cognitive 28) · ×1
  • ReflectionHelper.typeString (cognitive 28) optimus/platform/projects/platform/src/main/scala/optimus/platform/util/dalschema/ReflectionHelper.scala:183 — ReflectionHelper.typeString has cognitive complexity 28 (threshold 15). Drivers by points: if/else 13 (23 pts), match/switch 2 (5 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AwaitStackManagement.maybeSaveAwaitStack (cognitive 28) · ×1
  • AwaitStackManagement.maybeSaveAwaitStack (cognitive 28) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/AwaitStackManagement.java:261 — AwaitStackManagement.maybeSaveAwaitStack has cognitive complexity 28 (threshold 15). Drivers by points: if/else 8 (17 pts), boolean chains 6, loops 3 (5 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActiveRetrievalListeners.currentRetrievalSet (cognitive 28) · ×1
  • ActiveRetrievalListeners.currentRetrievalSet (cognitive 28) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/ActiveRetrievalListeners.java:131 — ActiveRetrievalListeners.currentRetrievalSet has cognitive complexity 28 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 4 (11 pts), error handling 1 (3 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AbstractSegment.getResolvedOffset (cognitive 28) · ×1
  • AbstractSegment.getResolvedOffset (cognitive 28) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/AbstractSegment.java:265 — AbstractSegment.getResolvedOffset has cognitive complexity 28 (threshold 15). Drivers by points: if/else 12 (26 pts), boolean chains 2 (nesting depth added 14). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · DependencyWatcher.build (cognitive 28) · ×1
  • DependencyWatcher.build (cognitive 28) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/DependencyWatcher.java:147 — DependencyWatcher.build has cognitive complexity 28 (threshold 15). Drivers by points: if/else 11 (15 pts), error handling 6 (9 pts), boolean chains 2, ternaries 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SpinningTransferQueue.tryAppend (cognitive 28) · ×1
  • SpinningTransferQueue.tryAppend (cognitive 28) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/SpinningTransferQueue.java:615 — SpinningTransferQueue.tryAppend has cognitive complexity 28 (threshold 15). Drivers by points: if/else 7 (12 pts), ternaries 2 (7 pts), loops 2 (5 pts), boolean chains 4 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OptimusBuildToolImpl.standardBuilder (cognitive 27) · ×1
  • OptimusBuildToolImpl.standardBuilder (cognitive 27) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/app/OptimusBuildToolImpl.scala:1013 — OptimusBuildToolImpl.standardBuilder has cognitive complexity 27 (threshold 15). Drivers by points: if/else 24 (26 pts), boolean chains 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · PropertyNode.writePrettyString (cognitive 27) · ×1
  • PropertyNode.writePrettyString (cognitive 27) optimus/platform/projects/core/src/main/scala/optimus/graph/PropertyNode.scala:360 — PropertyNode.writePrettyString has cognitive complexity 27 (threshold 15). Drivers by points: if/else 10 (15 pts), error handling 2 (7 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ShapeKey.equals (cognitive 27) · ×1
  • ShapeKey.equals (cognitive 27) optimus/platform/projects/core/src/main/scala/optimus/platform/pickling/Shape.scala:104 — ShapeKey.equals has cognitive complexity 27 (threshold 15). Drivers by points: if/else 10 (21 pts), loops 1 (4 pts), boolean chains 1, match/switch 1 (nesting depth added 14). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · OptimusDALRefChecks.checkParamAccessors (cognitive 27) · ×1
  • OptimusDALRefChecks.checkParamAccessors (cognitive 27) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:54 — OptimusDALRefChecks.checkParamAccessors has cognitive complexity 27 (threshold 15). Drivers by points: if/else 7 (15 pts), boolean chains 7, match/switch 2 (5 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OptimusRefchecks.checkParamAccessors (cognitive 27) · ×1
  • OptimusRefchecks.checkParamAccessors (cognitive 27) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:146 — OptimusRefchecks.checkParamAccessors has cognitive complexity 27 (threshold 15). Drivers by points: if/else 7 (15 pts), boolean chains 7, match/switch 2 (5 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CrumbParser.flatten (cognitive 27) · ×1
  • CrumbParser.flatten (cognitive 27) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/FastCrumbParser.scala:53 — CrumbParser.flatten has cognitive complexity 27 (threshold 15). Drivers by points: if/else 10 (21 pts), error handling 1 (3 pts), boolean chains 1, loops 1, match/switch 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NodeTimeLine.wallTimeRange (cognitive 27) · ×1
  • NodeTimeLine.wallTimeRange (cognitive 27) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeTimeLine.scala:75 — NodeTimeLine.wallTimeRange has cognitive complexity 27 (threshold 15). Drivers by points: if/else 6 (18 pts), loops 4 (6 pts), match/switch 1 (3 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GeneralAPICheck.checkAnnotationProperties (cognitive 27) · ×1
  • GeneralAPICheck.checkAnnotationProperties (cognitive 27) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/GeneralAPICheckComponent.scala:366 — GeneralAPICheck.checkAnnotationProperties has cognitive complexity 27 (threshold 15). Drivers by points: if/else 12 (16 pts), boolean chains 6, match/switch 4 (5 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StandardsTraverser.checkSelection (cognitive 27) · ×1
  • StandardsTraverser.checkSelection (cognitive 27) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/PostTyperCodingStandardsComponent.scala:64 — StandardsTraverser.checkSelection has cognitive complexity 27 (threshold 15). Drivers by points: if/else 8 (20 pts), boolean chains 7 (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Block.updatePhiTypes (cognitive 27) · ×1
  • Block.updatePhiTypes (cognitive 27) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/compiler/Block.java:128 — Block.updatePhiTypes has cognitive complexity 27 (threshold 15). Drivers by points: if/else 9 (19 pts), loops 4 (6 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Parser.tokens (cognitive 26) · ×1
  • Parser.tokens (cognitive 26) optimus/buildtool/projects/core/src/main/scala/optimus/buildtool/utils/parser/Parser.scala:56 — Parser.tokens has cognitive complexity 26 (threshold 15). Drivers by points: if/else 15 (18 pts), boolean chains 3, loops 3, match/switch 2 (nesting depth added 3). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D2 · Cognitive Complexity · EmbeddableUnpickler.unpickle$queued (cognitive 26) · ×1
  • EmbeddableUnpickler.unpickle$queued (cognitive 26) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/EmbeddablePicklers.scala:268 — EmbeddableUnpickler.unpickle$queued has cognitive complexity 26 (threshold 15). Drivers by points: if/else 6 (11 pts), match/switch 3 (6 pts), loops 2 (5 pts), error handling 2 (4 pts) (nesting depth added 13). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DALCacheImpl.load (cognitive 26) · ×1
  • DALCacheImpl.load (cognitive 26) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dal/DALCache.scala:321 — DALCacheImpl.load has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (18 pts), error handling 1 (5 pts), boolean chains 3 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AutoAsync.checkAndRewriteCombinator (cognitive 26) · ×1
  • AutoAsync.checkAndRewriteCombinator (cognitive 26) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala:742 — AutoAsync.checkAndRewriteCombinator has cognitive complexity 26 (threshold 15). Drivers by points: if/else 10 (17 pts), match/switch 4 (7 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InfoDumpUtils.drain (cognitive 26) · ×1
  • InfoDumpUtils.drain (cognitive 26) optimus/platform/projects/instrumentation/src/main/scala/optimus/platform/util/InfoDump.scala:59 — InfoDumpUtils.drain has cognitive complexity 26 (threshold 15). Drivers by points: if/else 12 (24 pts), error handling 1 (2 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SamplingProfilerSwitch.configure (cognitive 26) · ×1
  • SamplingProfilerSwitch.configure (cognitive 26) optimus/platform/projects/platform/src/main/scala/optimus/graph/diagnostics/sampling/SamplingProfilerSwitch.scala:120 — SamplingProfilerSwitch.configure has cognitive complexity 26 (threshold 15). Drivers by points: if/else 10 (18 pts), error handling 2 (4 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DynamicObjSortRule.compareLeftRight (cognitive 26) · ×1
  • DynamicObjSortRule.compareLeftRight (cognitive 26) optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/dynamic/DynamicObjectRelationUtils.scala:56 — DynamicObjSortRule.compareLeftRight has cognitive complexity 26 (threshold 15). Drivers by points: if/else 19 (25 pts), match/switch 1 (nesting depth added 6). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · CompareNodeDiffs.compareArgs (cognitive 26) · ×1
  • CompareNodeDiffs.compareArgs (cognitive 26) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/recipes/CompareNodeDiffs.scala:213 — CompareNodeDiffs.compareArgs has cognitive complexity 26 (threshold 15). Drivers by points: if/else 12 (23 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TreeTableCellRenderer.getTableCellRendererComponent (cognitive 26) · ×1
  • TreeTableCellRenderer.getTableCellRendererComponent (cognitive 26) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NPTableRenderer.scala:302 — TreeTableCellRenderer.getTableCellRendererComponent has cognitive complexity 26 (threshold 15). Drivers by points: if/else 15 (25 pts), match/switch 1 (nesting depth added 10). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · NodeTimeLine.drawCounters (cognitive 26) · ×1
  • NodeTimeLine.drawCounters (cognitive 26) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeTimeLine.scala:575 — NodeTimeLine.drawCounters has cognitive complexity 26 (threshold 15). Drivers by points: if/else 10 (22 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · KDBSerializerImpl.serializeList (cognitive 26) · ×1
  • KDBSerializerImpl.serializeList (cognitive 26) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/persistence/protocol/KDBSerializer.scala:248 — KDBSerializerImpl.serializeList has cognitive complexity 26 (threshold 15). Drivers by points: loops 12 (24 pts), if/else 1, match/switch 1 (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DALBinder.handleFuncCall (cognitive 26) · ×1
  • DALBinder.handleFuncCall (cognitive 26) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALBinder.scala:78 — DALBinder.handleFuncCall has cognitive complexity 26 (threshold 15). Drivers by points: match/switch 7 (19 pts), if/else 7 (nesting depth added 12). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · GeneralAPICheck.checkUndesiredProperties (cognitive 26) · ×1
  • GeneralAPICheck.checkUndesiredProperties (cognitive 26) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/GeneralAPICheckComponent.scala:303 — GeneralAPICheck.checkUndesiredProperties has cognitive complexity 26 (threshold 15). Drivers by points: if/else 10 (18 pts), match/switch 2 (6 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RewriteTypingTransformer.skipWhitespaceAndComments (cognitive 26) · ×1
  • RewriteTypingTransformer.skipWhitespaceAndComments (cognitive 26) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/rewrite/RewriteComponent.scala:337 — RewriteTypingTransformer.skipWhitespaceAndComments has cognitive complexity 26 (threshold 15). Drivers by points: if/else 12 (20 pts), boolean chains 3, loops 1 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · KVClientEstablishedStreamHandlerV1.processNonStreamGet (cognitive 26) · ×1
  • KVClientEstablishedStreamHandlerV1.processNonStreamGet (cognitive 26) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/stream/KVClientEstablishedStreamHandlerV1.java:152 — KVClientEstablishedStreamHandlerV1.processNonStreamGet has cognitive complexity 26 (threshold 15). Drivers by points: if/else 5 (11 pts), ternaries 3 (10 pts), loops 2 (5 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Itr.advance (cognitive 26) · ×1
  • Itr.advance (cognitive 26) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/SpinningTransferQueue.java:767 — Itr.advance has cognitive complexity 26 (threshold 15). Drivers by points: if/else 12 (17 pts), boolean chains 4, loops 2 (3 pts), ternaries 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PythonDependenciesLoader.fromConfig (cognitive 25) · ×1
  • PythonDependenciesLoader.fromConfig (cognitive 25) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/dependencies/PythonDependenciesLoader.scala:55 — PythonDependenciesLoader.fromConfig has cognitive complexity 25 (threshold 15). Drivers by points: loops 8 (16 pts), if/else 6 (8 pts), match/switch 1 (nesting depth added 10). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · ConcurrentAggregatorNode.getAndRunNextIteration (cognitive 25) · ×1
  • ConcurrentAggregatorNode.getAndRunNextIteration (cognitive 25) optimus/platform/projects/core/src/main/scala/optimus/graph/SequenceNode.scala:146 — ConcurrentAggregatorNode.getAndRunNextIteration has cognitive complexity 25 (threshold 15). Drivers by points: if/else 11 (20 pts), error handling 1 (4 pts), loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · stateManager.checkInvariants (cognitive 25) · ×1
  • stateManager.checkInvariants (cognitive 25) optimus/platform/projects/core/src/main/scala/optimus/graph/tracking/DependencyTrackerQueue.scala:95 — stateManager.checkInvariants has cognitive complexity 25 (threshold 15). Drivers by points: if/else 9 (18 pts), boolean chains 7 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Scenario.nestWithFlatten (cognitive 25) · ×1
  • Scenario.nestWithFlatten (cognitive 25) optimus/platform/projects/core/src/main/scala/optimus/platform/Scenario.scala:236 — Scenario.nestWithFlatten has cognitive complexity 25 (threshold 15). Drivers by points: if/else 8 (15 pts), loops 3 (8 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OptimusDALRefChecks.traverse (cognitive 25) · ×1
  • OptimusDALRefChecks.traverse (cognitive 25) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:449 — OptimusDALRefChecks.traverse has cognitive complexity 25 (threshold 15). Drivers by points: if/else 8 (16 pts), boolean chains 8, match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · PersistentEntityCondition.parseCondition (cognitive 25) · ×1
  • PersistentEntityCondition.parseCondition (cognitive 25) optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/PersistentEntityCondition.scala:133 — PersistentEntityCondition.parseCondition has cognitive complexity 25 (threshold 15). Drivers by points: match/switch 7 (18 pts), if/else 7 (nesting depth added 11). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · NodeTreeTable.getTreeSelector (cognitive 25) · ×1
  • NodeTreeTable.getTreeSelector (cognitive 25) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeTreeTable.scala:214 — NodeTreeTable.getTreeSelector has cognitive complexity 25 (threshold 15). Drivers by points: if/else 14 (18 pts), boolean chains 6, loops 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · IterableProvider.removeDuplicatedRowsBasedOnKey (cognitive 25) · ×1
  • IterableProvider.removeDuplicatedRowsBasedOnKey (cognitive 25) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/IterableProvider.scala:516 — IterableProvider.removeDuplicatedRowsBasedOnKey has cognitive complexity 25 (threshold 15). Drivers by points: loops 6 (10 pts), if/else 7 (9 pts), boolean chains 5, match/switch 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EntityTreeReducer.bindWhere (cognitive 25) · ×1
  • EntityTreeReducer.bindWhere (cognitive 25) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/EntityMultiRelation.scala:766 — EntityTreeReducer.bindWhere has cognitive complexity 25 (threshold 15). Drivers by points: if/else 8 (14 pts), match/switch 4 (9 pts), error handling 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PubSubReducer.handleProjection (cognitive 25) · ×1
  • PubSubReducer.handleProjection (cognitive 25) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/pubsub/PubSubReducer.scala:40 — PubSubReducer.handleProjection has cognitive complexity 25 (threshold 15). Drivers by points: if/else 8 (16 pts), match/switch 4 (7 pts), loops 1 (2 pts) (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · NamespaceOptionsClientBase.storeNamespaceProperties (cognitive 25) · ×1
  • NamespaceOptionsClientBase.storeNamespaceProperties (cognitive 25) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/common/NamespaceOptionsClientBase.java:205 — NamespaceOptionsClientBase.storeNamespaceProperties has cognitive complexity 25 (threshold 15). Drivers by points: if/else 9 (19 pts), error handling 2 (4 pts), boolean chains 1, loops 1 (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · QueueingConnection.sendAsynchronous (cognitive 25) · ×1
  • QueueingConnection.sendAsynchronous (cognitive 25) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/QueueingConnection.java:246 — QueueingConnection.sendAsynchronous has cognitive complexity 25 (threshold 15). Drivers by points: if/else 14 (21 pts), boolean chains 4 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BspSyncer.sources (cognitive 24) · ×1
  • BspSyncer.sources (cognitive 24) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/bsp/BspSyncer.scala:173 — BspSyncer.sources has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (20 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ScopeDefinitionCompiler.expandAllCustomScopes (cognitive 24) · ×1
  • ScopeDefinitionCompiler.expandAllCustomScopes (cognitive 24) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ScopeDefinitionCompiler.scala:137 — ScopeDefinitionCompiler.expandAllCustomScopes has cognitive complexity 24 (threshold 15). Drivers by points: loops 5 (15 pts), if/else 7 (8 pts), boolean chains 1 (nesting depth added 11). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · AdvancedUtils.ensureHeapAvailable (cognitive 24) · ×1
  • AdvancedUtils.ensureHeapAvailable (cognitive 24) optimus/platform/projects/core/src/main/scala/optimus/platform/AdvancedUtils.scala:329 — AdvancedUtils.ensureHeapAvailable has cognitive complexity 24 (threshold 15). Drivers by points: if/else 13 (20 pts), boolean chains 2, error handling 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Utils.tblWidths (cognitive 24) · ×1
  • Utils.tblWidths (cognitive 24) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:662 — Utils.tblWidths has cognitive complexity 24 (threshold 15). Drivers by points: if/else 10 (17 pts), boolean chains 4, loops 1 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NodeLift.transformSafe (cognitive 24) · ×1
  • NodeLift.transformSafe (cognitive 24) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/NodeLiftComponent.scala:165 — NodeLift.transformSafe has cognitive complexity 24 (threshold 15). Drivers by points: if/else 11 (19 pts), boolean chains 4, match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · NodeClassBuilder.mkNodeClass (cognitive 24) · ×1
  • NodeClassBuilder.mkNodeClass (cognitive 24) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/TypedNodeClassGenerator.scala:102 — NodeClassBuilder.mkNodeClass has cognitive complexity 24 (threshold 15). Drivers by points: if/else 15 (19 pts), boolean chains 5 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · StackAnalysis.extractInterestingStacks (cognitive 24) · ×1
  • StackAnalysis.extractInterestingStacks (cognitive 24) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:1589 — StackAnalysis.extractInterestingStacks has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (15 pts), loops 2 (5 pts), match/switch 1 (2 pts), boolean chains 1, error handling 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SamplingProfiler.publish (cognitive 24) · ×1
  • SamplingProfiler.publish (cognitive 24) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/sampling/SamplingProfiler.scala:432 — SamplingProfiler.publish has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (14 pts), match/switch 2 (5 pts), loops 3 (4 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OrderByRewriter.rebindOrderings (cognitive 24) · ×1
  • OrderByRewriter.rebindOrderings (cognitive 24) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/OrderByRewriter.scala:113 — OrderByRewriter.rebindOrderings has cognitive complexity 24 (threshold 15). Drivers by points: match/switch 4 (12 pts), if/else 5 (9 pts), boolean chains 2, loops 1 (nesting depth added 12). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ExpressionChecker.handleFuncCall (cognitive 24) · ×1
  • ExpressionChecker.handleFuncCall (cognitive 24) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchLanguage.scala:193 — ExpressionChecker.handleFuncCall has cognitive complexity 24 (threshold 15). Drivers by points: if/else 10 (11 pts), match/switch 4 (10 pts), boolean chains 3 (nesting depth added 7). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · Util.findInstancesStateWithKeyPair (cognitive 24) · ×1
  • Util.findInstancesStateWithKeyPair (cognitive 24) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/management/aws/Util.java:304 — Util.findInstancesStateWithKeyPair has cognitive complexity 24 (threshold 15). Drivers by points: if/else 3 (12 pts), loops 3 (6 pts), match/switch 1 (4 pts), boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TopologyRingCreator.createNextRegion (cognitive 24) · ×1
  • TopologyRingCreator.createNextRegion (cognitive 24) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/TopologyRingCreator.java:464 — TopologyRingCreator.createNextRegion has cognitive complexity 24 (threshold 15). Drivers by points: if/else 11 (18 pts), loops 2 (4 pts), boolean chains 1, error handling 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SpinningTransferQueue.awaitMatch (cognitive 24) · ×1
  • SpinningTransferQueue.awaitMatch (cognitive 24) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/SpinningTransferQueue.java:654 — SpinningTransferQueue.awaitMatch has cognitive complexity 24 (threshold 15). Drivers by points: if/else 10 (19 pts), boolean chains 3, loops 1, ternaries 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SourceSync.syncScopeArtifacts (cognitive 23) · ×1
  • SourceSync.syncScopeArtifacts (cognitive 23) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/postbuilders/sourcesync/SourceSync.scala:48 — SourceSync.syncScopeArtifacts has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (20 pts), match/switch 1 (3 pts) (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · AsyncCppCompilerImpl.artifact (cognitive 23) · ×1
  • AsyncCppCompilerImpl.artifact (cognitive 23) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncCppCompiler.scala:86 — AsyncCppCompilerImpl.artifact has cognitive complexity 23 (threshold 15). Drivers by points: match/switch 4 (12 pts), if/else 7 (10 pts), boolean chains 1 (nesting depth added 11). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · MultiSourceDependency.expandDependencyDefinitions (cognitive 23) · ×1
  • MultiSourceDependency.expandDependencyDefinitions (cognitive 23) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/dependencies/MultiSourceDependencies.scala:98 — MultiSourceDependency.expandDependencyDefinitions has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (11 pts), match/switch 5 (9 pts), boolean chains 3 (nesting depth added 6). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · AI.to$newNode (cognitive 23) · ×1
  • AI.to$newNode (cognitive 23) optimus/platform/projects/core/src/main/scala/optimus/graph/AsyncIterator.scala:146 — AI.to$newNode has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (10 pts), boolean chains 5, match/switch 4 (5 pts), loops 2 (3 pts) (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GraphSamplers.provide (cognitive 23) · ×1
  • GraphSamplers.provide (cognitive 23) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/sampling/GraphSamplers.scala:38 — GraphSamplers.provide has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (12 pts), loops 4 (6 pts), match/switch 3 (5 pts) (nesting depth added 5). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · NodeStackSampler.start (cognitive 23) · ×1
  • NodeStackSampler.start (cognitive 23) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/sampling/StackRecorder.scala:131 — NodeStackSampler.start has cognitive complexity 23 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 3 (8 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DependencyTrackerRoot.getOrCreateScenario (cognitive 23) · ×1
  • DependencyTrackerRoot.getOrCreateScenario (cognitive 23) optimus/platform/projects/core/src/main/scala/optimus/graph/tracking/DependencyTrackerRoot.scala:223 — DependencyTrackerRoot.getOrCreateScenario has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (16 pts), match/switch 2 (5 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProtoPickleSerializer.protoToArraySeq (cognitive 23) · ×1
  • ProtoPickleSerializer.protoToArraySeq (cognitive 23) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PropertyMapProtoSerialization.scala:290 — ProtoPickleSerializer.protoToArraySeq has cognitive complexity 23 (threshold 15). Drivers by points: loops 9 (17 pts), if/else 3 (4 pts), boolean chains 1, match/switch 1 (nesting depth added 9). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · EntityInfoTransformer.transformSafe (cognitive 23) · ×1
  • EntityInfoTransformer.transformSafe (cognitive 23) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/EntityInfoComponent.scala:422 — EntityInfoTransformer.transformSafe has cognitive complexity 23 (threshold 15). Drivers by points: if/else 10 (18 pts), match/switch 2 (3 pts), boolean chains 2 (nesting depth added 9). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · OptimusDALRefChecks.checkAccDefDef (cognitive 23) · ×1
  • OptimusDALRefChecks.checkAccDefDef (cognitive 23) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:104 — OptimusDALRefChecks.checkAccDefDef has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (13 pts), match/switch 3 (9 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Visitor.evaluateGraphOf (cognitive 23) · ×1
  • Visitor.evaluateGraphOf (cognitive 23) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/recipes/concurrency/ConcurrencyTracing.scala:302 — Visitor.evaluateGraphOf has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (19 pts), loops 3, boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ScalarSubqueryRewriter.handleScalar (cognitive 23) · ×1
  • ScalarSubqueryRewriter.handleScalar (cognitive 23) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/ScalarSubqueryRewriter.scala:38 — ScalarSubqueryRewriter.handleScalar has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 5, match/switch 2 (4 pts) (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DefaultInstanceFactory.createInstance (cognitive 23) · ×1
  • DefaultInstanceFactory.createInstance (cognitive 23) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/persistence/protocol/InstanceFactory.scala:46 — DefaultInstanceFactory.createInstance has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (13 pts), error handling 1 (5 pts), loops 1 (4 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Staging.transform (cognitive 23) · ×1
  • Staging.transform (cognitive 23) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/StagingComponent.scala:163 — Staging.transform has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (17 pts), match/switch 2 (5 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InstrumentationInjectorAdapter.visitMethod (cognitive 23) · ×1
  • InstrumentationInjectorAdapter.visitMethod (cognitive 23) optimus/platform/projects/entityagent/src/main/java/optimus/debug/InstrumentationInjectorAdapter.java:98 — InstrumentationInjectorAdapter.visitMethod has cognitive complexity 23 (threshold 15). Drivers by points: if/else 13 (14 pts), boolean chains 7, ternaries 1 (2 pts) (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · LoomAdapter.setupNodeAndLambdaCalls (cognitive 23) · ×1
  • LoomAdapter.setupNodeAndLambdaCalls (cognitive 23) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/LoomAdapter.java:175 — LoomAdapter.setupNodeAndLambdaCalls has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 3 (9 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DHTRingManager.syncData (cognitive 23) · ×1
  • DHTRingManager.syncData (cognitive 23) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:575 — DHTRingManager.syncData has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (17 pts), error handling 3 (6 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RingIntegrityCheck.checkIntegrity (cognitive 23) · ×1
  • RingIntegrityCheck.checkIntegrity (cognitive 23) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingIntegrityCheck.java:128 — RingIntegrityCheck.checkIntegrity has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (18 pts), loops 3 (5 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SingleWriterConsistentStorageEntryState.updateState (cognitive 23) · ×1
  • SingleWriterConsistentStorageEntryState.updateState (cognitive 23) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/protocol/SingleWriterConsistentStorageEntryState.java:75 — SingleWriterConsistentStorageEntryState.updateState has cognitive complexity 23 (threshold 15). Drivers by points: if/else 13 (23 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RingTreeBuilder.buildMaps (cognitive 23) · ×1
  • RingTreeBuilder.buildMaps (cognitive 23) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingTreeBuilder.java:122 — RingTreeBuilder.buildMaps has cognitive complexity 23 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 2 (7 pts), boolean chains 1 (nesting depth added 14). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ObtExternalLookup.lookupAnalyzedClass (cognitive 22) · ×1
  • ObtExternalLookup.lookupAnalyzedClass (cognitive 22) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/setup/ObtExternalHooks.scala:167 — ObtExternalLookup.lookupAnalyzedClass has cognitive complexity 22 (threshold 15). Drivers by points: loops 4 (10 pts), if/else 5 (6 pts), match/switch 3 (6 pts) (nesting depth added 10). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · MsIvyXml.dependencies (cognitive 22) · ×1
  • MsIvyXml.dependencies (cognitive 22) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/resolvers/MsIvyXml.scala:73 — MsIvyXml.dependencies has cognitive complexity 22 (threshold 15). Drivers by points: loops 5 (15 pts), match/switch 1 (6 pts), if/else 1 (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · ProcessorConfigurationCompiler.load (cognitive 22) · ×1
  • ProcessorConfigurationCompiler.load (cognitive 22) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ProcessorConfigurationCompiler.scala:40 — ProcessorConfigurationCompiler.load has cognitive complexity 22 (threshold 15). Drivers by points: loops 5 (15 pts), if/else 2 (7 pts) (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · SSCacheID.mayContainTweakAffecting (cognitive 22) · ×1
  • SSCacheID.mayContainTweakAffecting (cognitive 22) optimus/platform/projects/core/src/main/scala/optimus/graph/CacheIDs.scala:283 — SSCacheID.mayContainTweakAffecting has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (14 pts), loops 2 (6 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NodeBatcherSchedulerPlugin.adapt (cognitive 22) · ×1
  • NodeBatcherSchedulerPlugin.adapt (cognitive 22) optimus/platform/projects/core/src/main/scala/optimus/graph/NodeBatcherSchedulerPlugin.scala:516 — NodeBatcherSchedulerPlugin.adapt has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (18 pts), boolean chains 3, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AdaptedNodesOfOnePlugin.removeCollectedOrCompleted (cognitive 22) · ×1
  • AdaptedNodesOfOnePlugin.removeCollectedOrCompleted (cognitive 22) optimus/platform/projects/core/src/main/scala/optimus/graph/SchedulerPlugin.scala:256 — AdaptedNodesOfOnePlugin.removeCollectedOrCompleted has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 3, loops 2 (3 pts), error handling 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GridProfiler.aggregateFromDist (cognitive 22) · ×1
  • GridProfiler.aggregateFromDist (cognitive 22) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfiler.scala:671 — GridProfiler.aggregateFromDist has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 4 (7 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UTrackNode.onChildCompleted (cognitive 22) · ×1
  • UTrackNode.onChildCompleted (cognitive 22) optimus/platform/projects/core/src/main/scala/optimus/graph/tracking/UserNodeTracker.scala:283 — UTrackNode.onChildCompleted has cognitive complexity 22 (threshold 15). Drivers by points: if/else 11 (14 pts), error handling 2 (4 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · TemporalSource.translateMarkers (cognitive 22) · ×1
  • TemporalSource.translateMarkers (cognitive 22) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/internal/TemporalSource.scala:37 — TemporalSource.translateMarkers has cognitive complexity 22 (threshold 15). Drivers by points: if/else 12 (15 pts), boolean chains 5, error handling 1 (2 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · OptimusExportInfo.extractMetaParams (cognitive 22) · ×1
  • OptimusExportInfo.extractMetaParams (cognitive 22) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusExportInfoComponent.scala:372 — OptimusExportInfo.extractMetaParams has cognitive complexity 22 (threshold 15). Drivers by points: if/else 12 (16 pts), match/switch 3 (4 pts), boolean chains 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StackNode.pushSelfTimesToLeaves (cognitive 22) · ×1
  • StackNode.pushSelfTimesToLeaves (cognitive 22) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:843 — StackNode.pushSelfTimesToLeaves has cognitive complexity 22 (threshold 15). Drivers by points: if/else 7 (18 pts), loops 1 (3 pts), match/switch 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ComparisonResultTabbedPane.setResultTableRows (cognitive 22) · ×1
  • ComparisonResultTabbedPane.setResultTableRows (cognitive 22) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/CompareOgtracePanel.scala:116 — ComparisonResultTabbedPane.setResultTableRows has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (17 pts), match/switch 3 (5 pts) (nesting depth added 10). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · NodeSelectorComboBox.init (cognitive 22) · ×1
  • NodeSelectorComboBox.init (cognitive 22) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/controls/NodeFilterComboBox.scala:73 — NodeSelectorComboBox.init has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (15 pts), error handling 2 (6 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · QueryMacros.on (cognitive 22) · ×1
  • QueryMacros.on (cognitive 22) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/QueryMacros.scala:277 — QueryMacros.on has cognitive complexity 22 (threshold 15). Drivers by points: if/else 10 (15 pts), match/switch 4 (6 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Typer.handleBinaryExpression (cognitive 22) · ×1
  • Typer.handleBinaryExpression (cognitive 22) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/Typer.scala:114 — Typer.handleBinaryExpression has cognitive complexity 22 (threshold 15). Drivers by points: if/else 12 (20 pts), boolean chains 1, match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · CsvEntityReaderIterable.createObject (cognitive 22) · ×1
  • CsvEntityReaderIterable.createObject (cognitive 22) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/csv/CsvMultiRelation.scala:200 — CsvEntityReaderIterable.createObject has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (15 pts), match/switch 2 (5 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DALProvider.knownProjectorToLambda (cognitive 22) · ×1
  • DALProvider.knownProjectorToLambda (cognitive 22) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/DALProvider.scala:281 — DALProvider.knownProjectorToLambda has cognitive complexity 22 (threshold 15). Drivers by points: match/switch 7 (15 pts), if/else 7 (nesting depth added 8). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DALExecutionProvider.get (cognitive 22) · ×1
  • DALExecutionProvider.get (cognitive 22) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALExecutionProvider.scala:112 — DALExecutionProvider.get has cognitive complexity 22 (threshold 15). Drivers by points: if/else 7 (10 pts), match/switch 4 (8 pts), boolean chains 4 (nesting depth added 7). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · SparseUtils.backupIgnoredFiles (cognitive 22) · ×1
  • SparseUtils.backupIgnoredFiles (cognitive 22) optimus/stratosphere/common/src/main/scala/optimus/stratosphere/sparse/SparseUtils.scala:191 — SparseUtils.backupIgnoredFiles has cognitive complexity 22 (threshold 15). Drivers by points: if/else 11 (16 pts), error handling 2 (6 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConsistentHashRing.removeServer (cognitive 22) · ×1
  • ConsistentHashRing.removeServer (cognitive 22) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/servers/ConsistentHashRing.java:87 — ConsistentHashRing.removeServer has cognitive complexity 22 (threshold 15). Drivers by points: if/else 7 (19 pts), loops 2 (3 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BspSyncer.buildTargets (cognitive 21) · ×1
  • BspSyncer.buildTargets (cognitive 21) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/bsp/BspSyncer.scala:70 — BspSyncer.buildTargets has cognitive complexity 21 (threshold 15). Drivers by points: if/else 13 (14 pts), match/switch 4 (6 pts), boolean chains 1 (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · DependencyInstallPathResolver.locationIndependentClasspath (cognitive 21) · ×1
  • DependencyInstallPathResolver.locationIndependentClasspath (cognitive 21) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/files/RuntimeDependencyPathResolver.scala:59 — DependencyInstallPathResolver.locationIndependentClasspath has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (17 pts), match/switch 2 (3 pts), boolean chains 1 (nesting depth added 9). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · RuleFilterConfigurationCompiler.loadFilter (cognitive 21) · ×1
  • RuleFilterConfigurationCompiler.loadFilter (cognitive 21) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/RuleFilterConfigurationCompiler.scala:109 — RuleFilterConfigurationCompiler.loadFilter has cognitive complexity 21 (threshold 15). Drivers by points: loops 6 (21 pts) (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · Compiler.validateAndAssignParents (cognitive 21) · ×1
  • Compiler.validateAndAssignParents (cognitive 21) optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/compile/Compiler.scala:576 — Compiler.validateAndAssignParents has cognitive complexity 21 (threshold 15). Drivers by points: if/else 14, match/switch 3 (4 pts), boolean chains 3 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · HttpTailer.processContentAndScheduleRangeFetch (cognitive 21) · ×1
  • HttpTailer.processContentAndScheduleRangeFetch (cognitive 21) optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/util/HttpTailer.scala:61 — HttpTailer.processContentAndScheduleRangeFetch has cognitive complexity 21 (threshold 15). Drivers by points: if/else 10 (15 pts), error handling 3 (4 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OptimusDoubleSeq.map (cognitive 21) · ×1
  • OptimusDoubleSeq.map (cognitive 21) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:283 — OptimusDoubleSeq.map has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (17 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NestedCancellationScope.cancelInternal (cognitive 21) · ×1
  • NestedCancellationScope.cancelInternal (cognitive 21) optimus/platform/projects/core/src/main/scala/optimus/graph/CancellationScope.scala:219 — NestedCancellationScope.cancelInternal has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 2 (6 pts), error handling 1 (4 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConvertByNameToByValueNode.onChildCompleted (cognitive 21) · ×1
  • ConvertByNameToByValueNode.onChildCompleted (cognitive 21) optimus/platform/projects/core/src/main/scala/optimus/graph/ConvertByNameToByValueNode.scala:131 — ConvertByNameToByValueNode.onChildCompleted has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (13 pts), match/switch 1 (4 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LegacyGCMonitor.onHeapAboveThreshold (cognitive 21) · ×1
  • LegacyGCMonitor.onHeapAboveThreshold (cognitive 21) optimus/platform/projects/core/src/main/scala/optimus/graph/LegacyGCMonitor.scala:208 — LegacyGCMonitor.onHeapAboveThreshold has cognitive complexity 21 (threshold 15). Drivers by points: if/else 11 (21 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GroupingNodeBatcherSchedulerPluginBase.add2BatchNode (cognitive 21) · ×1
  • GroupingNodeBatcherSchedulerPluginBase.add2BatchNode (cognitive 21) optimus/platform/projects/core/src/main/scala/optimus/graph/NodeBatcherSchedulerPlugin.scala:676 — GroupingNodeBatcherSchedulerPluginBase.add2BatchNode has cognitive complexity 21 (threshold 15). Drivers by points: if/else 13 (20 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Profiler.resolveLocation (cognitive 21) · ×1
  • Profiler.resolveLocation (cognitive 21) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/pgo/Profiler.scala:98 — Profiler.resolveLocation has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (15 pts), loops 1 (3 pts), boolean chains 2, match/switch 1 (nesting depth added 9). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · AbstractPersistBlock.closeAndCreateAsserts (cognitive 21) · ×1
  • AbstractPersistBlock.closeAndCreateAsserts (cognitive 21) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/PersistBlock.scala:538 — AbstractPersistBlock.closeAndCreateAsserts has cognitive complexity 21 (threshold 15). Drivers by points: if/else 10, match/switch 4 (6 pts), boolean chains 5 (nesting depth added 2). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ExpressionSqlFormatter.visitSelect (cognitive 21) · ×1
  • ExpressionSqlFormatter.visitSelect (cognitive 21) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/expressions/ExpressionSqlFormatter.scala:189 — ExpressionSqlFormatter.visitSelect has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (15 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AdjustAST.transformAccelerated (cognitive 21) · ×1
  • AdjustAST.transformAccelerated (cognitive 21) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:729 — AdjustAST.transformAccelerated has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (13 pts), match/switch 4 (5 pts), boolean chains 3 (nesting depth added 6). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · OptimusExportInfo.gen (cognitive 21) · ×1
  • OptimusExportInfo.gen (cognitive 21) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusExportInfoComponent.scala:445 — OptimusExportInfo.gen has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (17 pts), boolean chains 2, loops 1, match/switch 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AsyncProfilerIntegration.ensureLoadedIfEnabled (cognitive 21) · ×1
  • AsyncProfilerIntegration.ensureLoadedIfEnabled (cognitive 21) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/AsyncProfilerIntegration.scala:114 — AsyncProfilerIntegration.ensureLoadedIfEnabled has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (17 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · InfoDumpUtils.execute (cognitive 21) · ×1
  • InfoDumpUtils.execute (cognitive 21) optimus/platform/projects/instrumentation/src/main/scala/optimus/platform/util/InfoDump.scala:278 — InfoDumpUtils.execute has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (19 pts), boolean chains 1, match/switch 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DebuggerUI.minimumScenarioOf (cognitive 21) · ×1
  • DebuggerUI.minimumScenarioOf (cognitive 21) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/DebuggerUI.scala:336 — DebuggerUI.minimumScenarioOf has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 2 (7 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ColumnProjector.visitElement (cognitive 21) · ×1
  • ColumnProjector.visitElement (cognitive 21) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/ColumnProjector.scala:52 — ColumnProjector.visitElement has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (12 pts), match/switch 2 (6 pts), boolean chains 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ComparisonRewriter.handleBinaryExpression (cognitive 21) · ×1
  • ComparisonRewriter.handleBinaryExpression (cognitive 21) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/ComparisonRewriter.scala:41 — ComparisonRewriter.handleBinaryExpression has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (14 pts), match/switch 2 (5 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EntityTreeReducerCommon.buildMemberRef (cognitive 21) · ×1
  • EntityTreeReducerCommon.buildMemberRef (cognitive 21) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/EntityMultiRelation.scala:628 — EntityTreeReducerCommon.buildMemberRef has cognitive complexity 21 (threshold 15). Drivers by points: match/switch 3 (10 pts), if/else 5 (8 pts), boolean chains 3 (nesting depth added 10). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DALFormatter.handleBinaryExpression (cognitive 21) · ×1
  • DALFormatter.handleBinaryExpression (cognitive 21) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALFormatter.scala:58 — DALFormatter.handleBinaryExpression has cognitive complexity 21 (threshold 15). Drivers by points: if/else 11 (13 pts), boolean chains 8 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · EntityAgent.premain (cognitive 21) · ×1
  • EntityAgent.premain (cognitive 21) optimus/platform/projects/entityagent/src/main/java/optimus/EntityAgent.java:242 — EntityAgent.premain has cognitive complexity 21 (threshold 15). Drivers by points: if/else 14 (16 pts), ternaries 2, boolean chains 1, error handling 1, loops 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ProtoRegionList.merge (cognitive 21) · ×1
  • ProtoRegionList.merge (cognitive 21) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/ProtoRegionList.java:332 — ProtoRegionList.merge has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (18 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CPUtils.constructorMatches (cognitive 21) · ×1
  • CPUtils.constructorMatches (cognitive 21) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/CPUtils.java:72 — CPUtils.constructorMatches has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (18 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClassParser.createConstructorArgsFromParams (cognitive 21) · ×1
  • ClassParser.createConstructorArgsFromParams (cognitive 21) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ClassParser.java:200 — ClassParser.createConstructorArgsFromParams has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (12 pts), error handling 2 (8 pts), loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClassParser.<init> (cognitive 21) · ×1
  • ClassParser.<init> (cognitive 21) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ClassParser.java:57 — ClassParser.<init> has cognitive complexity 21 (threshold 15). Drivers by points: if/else 15 (18 pts), error handling 2, boolean chains 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · AsyncScalaCompiler.doCompilation (cognitive 20) · ×1
  • AsyncScalaCompiler.doCompilation (cognitive 20) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncScalaCompiler.scala:213 — AsyncScalaCompiler.doCompilation has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (15 pts), match/switch 2 (4 pts), error handling 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · MsIvyArtifactSource.matchingPublications (cognitive 20) · ×1
  • MsIvyArtifactSource.matchingPublications (cognitive 20) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/resolvers/MsIvyRepository.scala:171 — MsIvyArtifactSource.matchingPublications has cognitive complexity 20 (threshold 15). Drivers by points: match/switch 5 (12 pts), boolean chains 4, if/else 3 (4 pts) (nesting depth added 8). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ScopeDefinitionCompiler.loadCustomScopesDefinitions (cognitive 20) · ×1
  • ScopeDefinitionCompiler.loadCustomScopesDefinitions (cognitive 20) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ScopeDefinitionCompiler.scala:853 — ScopeDefinitionCompiler.loadCustomScopesDefinitions has cognitive complexity 20 (threshold 15). Drivers by points: loops 5 (9 pts), if/else 5, error handling 1 (3 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 7). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · CrumbMerger.merge (cognitive 20) · ×1
  • CrumbMerger.merge (cognitive 20) optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/graph/CrumbMerger.scala:220 — CrumbMerger.merge has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (15 pts), loops 2 (5 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BreadcrumbsPropertyConfigurer.implFromConfig0 (cognitive 20) · ×1
  • BreadcrumbsPropertyConfigurer.implFromConfig0 (cognitive 20) optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/zookeeper/BreadcrumbsZkClient.scala:263 — BreadcrumbsPropertyConfigurer.implFromConfig0 has cognitive complexity 20 (threshold 15). Drivers by points: loops 4 (6 pts), error handling 5, if/else 4, match/switch 3 (4 pts), boolean chains 1 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProfilerTimings.timeCurrentMillis (cognitive 20) · ×1
  • ProfilerTimings.timeCurrentMillis (cognitive 20) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/ProfilerTimings.scala:109 — ProfilerTimings.timeCurrentMillis has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 4, boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ProfilerTimings.timeNanoTime) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · ProfilerTimings.timeNanoTime (cognitive 20) · ×1
  • ProfilerTimings.timeNanoTime (cognitive 20) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/ProfilerTimings.scala:199 — ProfilerTimings.timeNanoTime has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 4, boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ProfilerTimings.timeCurrentMillis) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · ExperimentalAsyncIterator2.force$newNode (cognitive 20) · ×1
  • ExperimentalAsyncIterator2.force$newNode (cognitive 20) optimus/platform/projects/core/src/main/scala/optimus/graph/experimental/ExperimentalAsyncIterator2.scala:317 — ExperimentalAsyncIterator2.force$newNode has cognitive complexity 20 (threshold 15). Drivers by points: if/else 11 (18 pts), match/switch 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConstantNominator.traverse (cognitive 20) · ×1
  • ConstantNominator.traverse (cognitive 20) optimus/platform/projects/core/src/main/scala/optimus/platform/relational/AbstractLambdaReifier.scala:504 — ConstantNominator.traverse has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (11 pts), boolean chains 6, match/switch 2 (3 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AppStatsBasics.doTraitProbe (cognitive 20) · ×1
  • AppStatsBasics.doTraitProbe (cognitive 20) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/AppStats.scala:996 — AppStatsBasics.doTraitProbe has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (16 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FilteredStreamEvent.getFilteredEvent (cognitive 20) · ×1
  • FilteredStreamEvent.getFilteredEvent (cognitive 20) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/pubsub/NotificationMessageHandler.scala:106 — FilteredStreamEvent.getFilteredEvent has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (15 pts), match/switch 3 (5 pts) (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · NotificationMessageHandler.replaceReferenceOnlyNotifications (cognitive 20) · ×1
  • NotificationMessageHandler.replaceReferenceOnlyNotifications (cognitive 20) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/pubsub/NotificationMessageHandler.scala:237 — NotificationMessageHandler.replaceReferenceOnlyNotifications has cognitive complexity 20 (threshold 15). Drivers by points: match/switch 3 (9 pts), if/else 4 (7 pts), error handling 1 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · AdjustAST.transformBackedDef (cognitive 20) · ×1
  • AdjustAST.transformBackedDef (cognitive 20) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AdjustASTComponent.scala:572 — AdjustAST.transformBackedDef has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (12 pts), boolean chains 5, match/switch 2 (3 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · AsyncTraverser.traverse (cognitive 20) · ×1
  • AsyncTraverser.traverse (cognitive 20) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AsyncTransformers.scala:26 — AsyncTraverser.traverse has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (14 pts), loops 1 (4 pts), boolean chains 1, match/switch 1 (nesting depth added 11). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ClassifierComponent.nodeAttachment (cognitive 20) · ×1
  • ClassifierComponent.nodeAttachment (cognitive 20) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/ClassifierComponent.scala:138 — ClassifierComponent.nodeAttachment has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (12 pts), boolean chains 7, match/switch 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · NodeClassBuilder.addFuncMethod (cognitive 20) · ×1
  • NodeClassBuilder.addFuncMethod (cognitive 20) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/TypedNodeClassGenerator.scala:296 — NodeClassBuilder.addFuncMethod has cognitive complexity 20 (threshold 15). Drivers by points: match/switch 4 (12 pts), if/else 8 (nesting depth added 8). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · WatcherProcess.dump (cognitive 20) · ×1
  • WatcherProcess.dump (cognitive 20) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/heartbeat/WatcherProcess.scala:222 — WatcherProcess.dump has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (13 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OptimusTask.runtimeConfig (cognitive 20) · ×1
  • OptimusTask.runtimeConfig (cognitive 20) optimus/platform/projects/platform/src/main/scala/optimus/platform/OptimusTask.scala:163 — OptimusTask.runtimeConfig has cognitive complexity 20 (threshold 15). Drivers by points: if/else 13 (16 pts), match/switch 2 (3 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · GraphConsole.init (cognitive 20) · ×1
  • GraphConsole.init (cognitive 20) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/GraphConsole.scala:368 — GraphConsole.init has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (19 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TableColumnFlags.parsedFilter (cognitive 20) · ×1
  • TableColumnFlags.parsedFilter (cognitive 20) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/TableColumns.scala:186 — TableColumnFlags.parsedFilter has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 2 (4 pts), boolean chains 2, error handling 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NodeGraphReducer.compressedGraphV1 (cognitive 20) · ×1
  • NodeGraphReducer.compressedGraphV1 (cognitive 20) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/utils/NodeGraphReducer.scala:38 — NodeGraphReducer.compressedGraphV1 has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (18 pts), loops 1 (2 pts) (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ASMGeneratorUtils.convert (cognitive 20) · ×1
  • ASMGeneratorUtils.convert (cognitive 20) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMGeneratorUtils.scala:68 — ASMGeneratorUtils.convert has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (19 pts), boolean chains 1 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · QueryBinder.bindMember (cognitive 20) · ×1
  • QueryBinder.bindMember (cognitive 20) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/mapping/QueryBinder.scala:44 — QueryBinder.bindMember has cognitive complexity 20 (threshold 15). Drivers by points: match/switch 6 (11 pts), if/else 5 (6 pts), boolean chains 3 (nesting depth added 6). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · Tabulator.format (cognitive 20) · ×1
  • Tabulator.format (cognitive 20) optimus/platform/projects/utils/src/main/scala/optimus/utils/Tabulator.scala:26 — Tabulator.format has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (10 pts), loops 4 (9 pts), match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · BatchOperationTemplate.handleInfraFailures (cognitive 20) · ×1
  • BatchOperationTemplate.handleInfraFailures (cognitive 20) optimus/dht/projects/client3/src/main/java/optimus/dht/client/api/replication/BatchOperationTemplate.java:311 — BatchOperationTemplate.handleInfraFailures has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (16 pts), match/switch 1 (2 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AsyncOperationImpl.setResult (cognitive 20) · ×1
  • AsyncOperationImpl.setResult (cognitive 20) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/AsyncOperationImpl.java:170 — AsyncOperationImpl.setResult has cognitive complexity 20 (threshold 15). Drivers by points: if/else 11 (20 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RetrievalOptionsComparator.compare (cognitive 20) · ×1
  • RetrievalOptionsComparator.compare (cognitive 20) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/RetrievalOptionsComparator.java:23 — RetrievalOptionsComparator.compare has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (20 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DHTRingManager.recoverData (cognitive 20) · ×1
  • DHTRingManager.recoverData (cognitive 20) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:915 — DHTRingManager.recoverData has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (13 pts), error handling 3 (7 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TreeMatcher.match (cognitive 20) · ×1
  • TreeMatcher.match (cognitive 20) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/TreeMatcher.java:22 — TreeMatcher.match has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (14 pts), loops 3 (5 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BaseRetrievalOperation.processInitialMessageGroupEntry (cognitive 20) · ×1
  • BaseRetrievalOperation.processInitialMessageGroupEntry (cognitive 20) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/protocol/BaseRetrievalOperation.java:60 — BaseRetrievalOperation.processInitialMessageGroupEntry has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (15 pts), error handling 1 (4 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LooseConsistencyWrite.update (cognitive 20) · ×1
  • LooseConsistencyWrite.update (cognitive 20) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/protocol/LooseConsistencyWrite.java:44 — LooseConsistencyWrite.update has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (20 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RingRegion.intersectionType (cognitive 20) · ×1
  • RingRegion.intersectionType (cognitive 20) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/ring/RingRegion.java:467 — RingRegion.intersectionType has cognitive complexity 20 (threshold 15). Drivers by points: if/else 14 (18 pts), boolean chains 2 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · RingTree.cleanupList (cognitive 20) · ×1
  • RingTree.cleanupList (cognitive 20) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingTree.java:639 — RingTree.cleanupList has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (17 pts), loops 1 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TopologyRingCreator.nextRegion (cognitive 20) · ×1
  • TopologyRingCreator.nextRegion (cognitive 20) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/TopologyRingCreator.java:286 — TopologyRingCreator.nextRegion has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (15 pts), match/switch 1 (3 pts), boolean chains 1, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TopologyRingCreator.swap (cognitive 20) · ×1
  • TopologyRingCreator.swap (cognitive 20) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/TopologyRingCreator.java:376 — TopologyRingCreator.swap has cognitive complexity 20 (threshold 15). Drivers by points: if/else 14 (20 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClassParser.parseSet (cognitive 20) · ×1
  • ClassParser.parseSet (cognitive 20) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ClassParser.java:663 — ClassParser.parseSet has cognitive complexity 20 (threshold 15). Drivers by points: if/else 11 (19 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TestplanInstaller.prepareFor (cognitive 19) · ×1
  • TestplanInstaller.prepareFor (cognitive 19) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/postbuilders/installer/component/TestplanInstaller.scala:298 — TestplanInstaller.prepareFor has cognitive complexity 19 (threshold 15). Drivers by points: if/else 12 (17 pts), match/switch 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AbstractImageBuilder.processPath (cognitive 19) · ×1
  • AbstractImageBuilder.processPath (cognitive 19) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/oci/ImageBuilder.scala:836 — AbstractImageBuilder.processPath has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (12 pts), boolean chains 5, match/switch 2 (nesting depth added 5). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ScenarioStack.getParentTrackingNode (cognitive 19) · ×1
  • ScenarioStack.getParentTrackingNode (cognitive 19) optimus/platform/projects/core/src/main/scala/optimus/platform/ScenarioStack.scala:1013 — ScenarioStack.getParentTrackingNode has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (11 pts), loops 2 (5 pts), boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DSIClient.computeRedirectionImpact (cognitive 19) · ×1
  • DSIClient.computeRedirectionImpact (cognitive 19) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/DSIClient.scala:356 — DSIClient.computeRedirectionImpact has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (12 pts), match/switch 2 (4 pts), boolean chains 3 (nesting depth added 6). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ReflectiveEntityPicklingImpl.prepareMeta (cognitive 19) · ×1
  • ReflectiveEntityPicklingImpl.prepareMeta (cognitive 19) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/ReflectivePicklingImpl.scala:330 — ReflectiveEntityPicklingImpl.prepareMeta has cognitive complexity 19 (threshold 15). Drivers by points: if/else 13 (17 pts), match/switch 1 (2 pts) (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · EntityTraceMsg.buildEntityTraceMsgFromString (cognitive 19) · ×1
  • EntityTraceMsg.buildEntityTraceMsgFromString (cognitive 19) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/temporalSurface/impl/TemporalContextTrace.scala:171 — EntityTraceMsg.buildEntityTraceMsgFromString has cognitive complexity 19 (threshold 15). Drivers by points: if/else 14 (19 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TypedUtils.checkOwnership (cognitive 19) · ×1
  • TypedUtils.checkOwnership (cognitive 19) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/TypedUtils.scala:1029 — TypedUtils.checkOwnership has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (11 pts), boolean chains 5, match/switch 2 (3 pts) (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BundleDiffStat.apply (cognitive 19) · ×1
  • BundleDiffStat.apply (cognitive 19) optimus/platform/projects/git-utils/src/main/scala/optimus/git/diffstat/GitDiffStat.scala:76 — BundleDiffStat.apply has cognitive complexity 19 (threshold 15). Drivers by points: if/else 13 (18 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · BaseSamplers.provide (cognitive 19) · ×1
  • BaseSamplers.provide (cognitive 19) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/sampling/BaseSamplers.scala:157 — BaseSamplers.provide has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (11 pts), match/switch 3 (7 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProfilerUI.getNodeStacks (cognitive 19) · ×1
  • ProfilerUI.getNodeStacks (cognitive 19) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ProfilerUI.scala:67 — ProfilerUI.getNodeStacks has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (14 pts), boolean chains 3, loops 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NPTreeNodeExt.expandTree (cognitive 19) · ×1
  • NPTreeNodeExt.expandTree (cognitive 19) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/extensions/NPTreeNodeExt.scala:49 — NPTreeNodeExt.expandTree has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (12 pts), match/switch 1 (4 pts), boolean chains 2, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NPTreeNodeExt.openTo (cognitive 19) · ×1
  • NPTreeNodeExt.openTo (cognitive 19) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/extensions/NPTreeNodeExt.scala:122 — NPTreeNodeExt.openTo has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (16 pts), boolean chains 2, loops 1 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · HotspotsTable.afterUpdateList (cognitive 19) · ×1
  • HotspotsTable.afterUpdateList (cognitive 19) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/HotspotsTable.scala:1066 — HotspotsTable.afterUpdateList has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 3 (6 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TreeTableCellRenderer.click (cognitive 19) · ×1
  • TreeTableCellRenderer.click (cognitive 19) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NPTableRenderer.scala:414 — TreeTableCellRenderer.click has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (17 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NodeTimeLine.drawDistributedEvents (cognitive 19) · ×1
  • NodeTimeLine.drawDistributedEvents (cognitive 19) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeTimeLine.scala:856 — NodeTimeLine.drawDistributedEvents has cognitive complexity 19 (threshold 15). Drivers by points: if/else 15 (16 pts), boolean chains 2, loops 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ElementFactoryEx.andAlso (cognitive 19) · ×1
  • ElementFactoryEx.andAlso (cognitive 19) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/LambdaReifier.scala:93 — ElementFactoryEx.andAlso has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (16 pts), match/switch 2 (3 pts) (nesting depth added 7). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident. This shape REPEATS in the file: one other method here (ElementFactoryEx.orElse) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · ElementFactoryEx.orElse (cognitive 19) · ×1
  • ElementFactoryEx.orElse (cognitive 19) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/LambdaReifier.scala:110 — ElementFactoryEx.orElse has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (16 pts), match/switch 2 (3 pts) (nesting depth added 7). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident. This shape REPEATS in the file: one other method here (ElementFactoryEx.andAlso) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · ASMProxyGenerator.defineGetters (cognitive 19) · ×1
  • ASMProxyGenerator.defineGetters (cognitive 19) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMProxyGenerator.scala:182 — ASMProxyGenerator.defineGetters has cognitive complexity 19 (threshold 15). Drivers by points: if/else 18, match/switch 1. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · DefaultBinder.bindSelect (cognitive 19) · ×1
  • DefaultBinder.bindSelect (cognitive 19) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:513 — DefaultBinder.bindSelect has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (12 pts), match/switch 2 (4 pts), boolean chains 3 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DefaultBinder.bindGroupBy (cognitive 19) · ×1
  • DefaultBinder.bindGroupBy (cognitive 19) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:706 — DefaultBinder.bindGroupBy has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (11 pts), match/switch 3 (8 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UnusedColumnRemover.handleSelect (cognitive 19) · ×1
  • UnusedColumnRemover.handleSelect (cognitive 19) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/UnusedColumnRemover.scala:58 — UnusedColumnRemover.handleSelect has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (15 pts), boolean chains 3, loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · KDBSerializerImpl.serializeObjectList (cognitive 19) · ×1
  • KDBSerializerImpl.serializeObjectList (cognitive 19) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/persistence/protocol/KDBSerializer.scala:206 — KDBSerializerImpl.serializeObjectList has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (10 pts), loops 2 (5 pts), boolean chains 4 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NilaryOverride.transform (cognitive 19) · ×1
  • NilaryOverride.transform (cognitive 19) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/rewrite/RewriteComponent.scala:1025 — NilaryOverride.transform has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (16 pts), boolean chains 2, match/switch 1 (nesting depth added 9). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · Traversablish.traverseEither (cognitive 19) · ×1
  • Traversablish.traverseEither (cognitive 19) optimus/platform/projects/utils/src/main/scala/optimus/utils/MiscUtils.scala:362 — Traversablish.traverseEither has cognitive complexity 19 (threshold 15). Drivers by points: match/switch 4 (10 pts), if/else 3 (5 pts), loops 2 (4 pts) (nesting depth added 10). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DirectoryOpts.copyTo (cognitive 19) · ×1
  • DirectoryOpts.copyTo (cognitive 19) optimus/stratosphere/common/src/main/scala/optimus/stratosphere/filesanddirs/DirectoryOpts.scala:111 — DirectoryOpts.copyTo has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (19 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Block.updateHeadLabel (cognitive 19) · ×1
  • Block.updateHeadLabel (cognitive 19) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/compiler/Block.java:230 — Block.updateHeadLabel has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (18 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LCompiler.loadConfigFrom (cognitive 19) · ×1
  • LCompiler.loadConfigFrom (cognitive 19) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/compiler/LCompiler.java:118 — LCompiler.loadConfigFrom has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (16 pts), boolean chains 2, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NamespacePerspectiveOptionsImpl.keyCreatorFor (cognitive 19) · ×1
  • NamespacePerspectiveOptionsImpl.keyCreatorFor (cognitive 19) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/NamespacePerspectiveOptionsImpl.java:91 — NamespacePerspectiveOptionsImpl.keyCreatorFor has cognitive complexity 19 (threshold 15). Drivers by points: match/switch 5 (10 pts), if/else 8 (9 pts) (nesting depth added 6). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · BaseStorageOperation.processInitialMessageGroupEntry (cognitive 19) · ×1
  • BaseStorageOperation.processInitialMessageGroupEntry (cognitive 19) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/protocol/BaseStorageOperation.java:53 — BaseStorageOperation.processInitialMessageGroupEntry has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (12 pts), loops 2 (7 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · gridprofiler.hotspotsTable (cognitive 19) · ×1
  • gridprofiler.hotspotsTable (cognitive 19) optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:138 — gridprofiler.hotspotsTable has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GccUtils.copyToSandbox (cognitive 18) · ×1
  • GccUtils.copyToSandbox (cognitive 18) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/cpp/gcc/GccUtils.scala:27 — GccUtils.copyToSandbox has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (18 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TruncatingIndexBasedZipOps.updateExtraTimestamps (cognitive 18) · ×1
  • TruncatingIndexBasedZipOps.updateExtraTimestamps (cognitive 18) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/utils/TruncatingIndexBasedZipOps.scala:139 — TruncatingIndexBasedZipOps.updateExtraTimestamps has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (14 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 8). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D2 · Cognitive Complexity · Formatter.formatValue (cognitive 18) · ×1
  • Formatter.formatValue (cognitive 18) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ObtFileFormatter.scala:105 — Formatter.formatValue has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (9 pts), boolean chains 3, loops 2 (3 pts), match/switch 2 (3 pts) (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ConvertByNameToByValueNode.workOnScenario (cognitive 18) · ×1
  • ConvertByNameToByValueNode.workOnScenario (cognitive 18) optimus/platform/projects/core/src/main/scala/optimus/graph/ConvertByNameToByValueNode.scala:91 — ConvertByNameToByValueNode.workOnScenario has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (12 pts), error handling 1 (3 pts), boolean chains 2, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LegacyGCMonitor.timeBasedStrategy (cognitive 18) · ×1
  • LegacyGCMonitor.timeBasedStrategy (cognitive 18) optimus/platform/projects/core/src/main/scala/optimus/graph/LegacyGCMonitor.scala:288 — LegacyGCMonitor.timeBasedStrategy has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (14 pts), boolean chains 4 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AdaptedNodesOfOnePlugin.randomNode (cognitive 18) · ×1
  • AdaptedNodesOfOnePlugin.randomNode (cognitive 18) optimus/platform/projects/core/src/main/scala/optimus/graph/SchedulerPlugin.scala:364 — AdaptedNodesOfOnePlugin.randomNode has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (13 pts), boolean chains 3, loops 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ScenarioStack.getTrackingNodeID (cognitive 18) · ×1
  • ScenarioStack.getTrackingNodeID (cognitive 18) optimus/platform/projects/core/src/main/scala/optimus/platform/ScenarioStack.scala:989 — ScenarioStack.getTrackingNodeID has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (15 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TypeInfoUtils.extractJavaType (cognitive 18) · ×1
  • TypeInfoUtils.extractJavaType (cognitive 18) optimus/platform/projects/core/src/main/scala/optimus/platform/relational/tree/TypeInfo.scala:63 — TypeInfoUtils.extractJavaType has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (7 pts), error handling 2 (6 pts), match/switch 2 (5 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AppStatsProfiler.jsonSegment (cognitive 18) · ×1
  • AppStatsProfiler.jsonSegment (cognitive 18) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/AppStatsProfiler.scala:70 — AppStatsProfiler.jsonSegment has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 1 (5 pts), match/switch 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VersioningServerManager.version (cognitive 18) · ×1
  • VersioningServerManager.version (cognitive 18) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dsi/protobufutils/VersioningServerManager.scala:129 — VersioningServerManager.version has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (14 pts), match/switch 1 (3 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WriteBusinessEvent.logDisplay (cognitive 18) · ×1
  • WriteBusinessEvent.logDisplay (cognitive 18) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/Command.scala:366 — WriteBusinessEvent.logDisplay has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (10 pts), match/switch 4 (8 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProtoPickleSerializer.protoToProperties (cognitive 18) · ×1
  • ProtoPickleSerializer.protoToProperties (cognitive 18) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/PropertyMapProtoSerialization.scala:393 — ProtoPickleSerializer.protoToProperties has cognitive complexity 18 (threshold 15). Drivers by points: if/else 12 (16 pts), boolean chains 1, match/switch 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EmbeddableTransformer.buildEquals (cognitive 18) · ×1
  • EmbeddableTransformer.buildEquals (cognitive 18) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/EmbeddableComponent.scala:274 — EmbeddableTransformer.buildEquals has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (12 pts), match/switch 2 (4 pts), boolean chains 1, error handling 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OptimusDALRefChecks.checkFullTextSearchType (cognitive 18) · ×1
  • OptimusDALRefChecks.checkFullTextSearchType (cognitive 18) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusDALRefChecks.scala:390 — OptimusDALRefChecks.checkFullTextSearchType has cognitive complexity 18 (threshold 15). Drivers by points: if/else 11 (13 pts), boolean chains 3, match/switch 1 (2 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · TypedNodeSynthesis.genStoredPropertyLoad (cognitive 18) · ×1
  • TypedNodeSynthesis.genStoredPropertyLoad (cognitive 18) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/TypedNodeSynthesis.scala:380 — TypedNodeSynthesis.genStoredPropertyLoad has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (16 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AsyncProfilerIntegration.command (cognitive 18) · ×1
  • AsyncProfilerIntegration.command (cognitive 18) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/AsyncProfilerIntegration.scala:185 — AsyncProfilerIntegration.command has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (16 pts), error handling 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AsyncProfilerSampler.snap (cognitive 18) · ×1
  • AsyncProfilerSampler.snap (cognitive 18) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/sampling/AsyncProfilerSampler.scala:90 — AsyncProfilerSampler.snap has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (13 pts), boolean chains 4, error handling 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TemporalContextDeserializer.helper (cognitive 18) · ×1
  • TemporalContextDeserializer.helper (cognitive 18) optimus/platform/projects/platform/src/main/scala/optimus/platform/dsi/bitemporal/proto/TemporalContextDeserializer.scala:34 — TemporalContextDeserializer.helper has cognitive complexity 18 (threshold 15). Drivers by points: if/else 15 (18 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · CompanionTypeInfoBase.getStoredVal (cognitive 18) · ×1
  • CompanionTypeInfoBase.getStoredVal (cognitive 18) optimus/platform/projects/platform/src/main/scala/optimus/platform/versioning/TypeInfoApiBase.scala:151 — CompanionTypeInfoBase.getStoredVal has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (9 pts), match/switch 2 (5 pts), boolean chains 4 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Visitor.enqueue (cognitive 18) · ×1
  • Visitor.enqueue (cognitive 18) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/recipes/concurrency/ConcurrencyTracing.scala:204 — Visitor.enqueue has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (16 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NodeTimeLine.drawSelectedNodes (cognitive 18) · ×1
  • NodeTimeLine.drawSelectedNodes (cognitive 18) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeTimeLine.scala:324 — NodeTimeLine.drawSelectedNodes has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DynamicObjectJavaProxy.invoke (cognitive 18) · ×1
  • DynamicObjectJavaProxy.invoke (cognitive 18) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/AbstractDynamicObject.scala:141 — DynamicObjectJavaProxy.invoke has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9, boolean chains 5, match/switch 2 (4 pts) (nesting depth added 2). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · QueryBinder.bindUntypedMember (cognitive 18) · ×1
  • QueryBinder.bindUntypedMember (cognitive 18) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/mapping/QueryBinder.scala:118 — QueryBinder.bindUntypedMember has cognitive complexity 18 (threshold 15). Drivers by points: match/switch 5 (9 pts), if/else 6 (8 pts), boolean chains 1 (nesting depth added 6). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · CrossApplyRewriter.handleJoin (cognitive 18) · ×1
  • CrossApplyRewriter.handleJoin (cognitive 18) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/CrossApplyRewriter.scala:20 — CrossApplyRewriter.handleJoin has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (13 pts), boolean chains 3, match/switch 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RedundantColumnRemover.handleSelect (cognitive 18) · ×1
  • RedundantColumnRemover.handleSelect (cognitive 18) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/RedundantColumnRemover.scala:26 — RedundantColumnRemover.handleSelect has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (9 pts), match/switch 3 (6 pts), loops 1 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConditionOptimizer.optimizeProjection (cognitive 18) · ×1
  • ConditionOptimizer.optimizeProjection (cognitive 18) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALBinder.scala:479 — ConditionOptimizer.optimizeProjection has cognitive complexity 18 (threshold 15). Drivers by points: if/else 11 (14 pts), match/switch 2 (3 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · StagingPlugin.processCommonOption (cognitive 18) · ×1
  • StagingPlugin.processCommonOption (cognitive 18) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/StagingPlugin.scala:63 — StagingPlugin.processCommonOption has cognitive complexity 18 (threshold 15). Drivers by points: if/else 18. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ZookeeperRegistryObserver.processCuratorConnectionStateChanged (cognitive 18) · ×1
  • ZookeeperRegistryObserver.processCuratorConnectionStateChanged (cognitive 18) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/registry/ZookeeperRegistryObserver.java:247 — ZookeeperRegistryObserver.processCuratorConnectionStateChanged has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (13 pts), error handling 2 (4 pts), match/switch 1 (nesting depth added 7). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · RingIterator.hasNext (cognitive 18) · ×1
  • RingIterator.hasNext (cognitive 18) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/servers/ConsistentHashRing.java:162 — RingIterator.hasNext has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 2 (3 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DefaultServerConnectionsManager.serverConnected (cognitive 18) · ×1
  • DefaultServerConnectionsManager.serverConnected (cognitive 18) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/servers/DefaultServerConnectionsManager.java:170 — DefaultServerConnectionsManager.serverConnected has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (15 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DefaultServerConnectionsManager.serverDisconnectedOrFailed (cognitive 18) · ×1
  • DefaultServerConnectionsManager.serverDisconnectedOrFailed (cognitive 18) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/servers/DefaultServerConnectionsManager.java:221 — DefaultServerConnectionsManager.serverDisconnectedOrFailed has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (15 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · NettyInitialClientHandler.processInitialServerMessage (cognitive 18) · ×1
  • NettyInitialClientHandler.processInitialServerMessage (cognitive 18) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/transport/NettyInitialClientHandler.java:126 — NettyInitialClientHandler.processInitialServerMessage has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (11 pts), ternaries 5, error handling 1, loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InstrumentationInjectorMethodVisitor.injectMethodPrefix (cognitive 18) · ×1
  • InstrumentationInjectorMethodVisitor.injectMethodPrefix (cognitive 18) optimus/platform/projects/entityagent/src/main/java/optimus/debug/InstrumentationInjectorMethodVisitor.java:41 — InstrumentationInjectorMethodVisitor.injectMethodPrefix has cognitive complexity 18 (threshold 15). Drivers by points: if/else 15 (16 pts), boolean chains 2 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · InstrumentationInjectorMethodVisitor.onMethodExit (cognitive 18) · ×1
  • InstrumentationInjectorMethodVisitor.onMethodExit (cognitive 18) optimus/platform/projects/entityagent/src/main/java/optimus/debug/InstrumentationInjectorMethodVisitor.java:137 — InstrumentationInjectorMethodVisitor.onMethodExit has cognitive complexity 18 (threshold 15). Drivers by points: if/else 14 (15 pts), boolean chains 3 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · LCompiler.transform (cognitive 18) · ×1
  • LCompiler.transform (cognitive 18) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/compiler/LCompiler.java:146 — LCompiler.transform has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (10 pts), boolean chains 3, loops 1 (2 pts), ternaries 1 (2 pts), error handling 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · Regenerator.write (cognitive 18) · ×1
  • Regenerator.write (cognitive 18) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/compiler/Regenerator.java:195 — Regenerator.write has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AwaitStackManagement.awaitStack (cognitive 18) · ×1
  • AwaitStackManagement.awaitStack (cognitive 18) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/AwaitStackManagement.java:345 — AwaitStackManagement.awaitStack has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 3 (5 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClassMonitorInjector.transform (cognitive 18) · ×1
  • ClassMonitorInjector.transform (cognitive 18) optimus/platform/projects/entityagent/src/main/java/optimus/ClassMonitorInjector.java:317 — ClassMonitorInjector.transform has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (12 pts), boolean chains 3, loops 1 (2 pts), error handling 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · NamespaceOptionsClientBase.getNamespacePropertiesAndTryAutoCreate (cognitive 18) · ×1
  • NamespaceOptionsClientBase.getNamespacePropertiesAndTryAutoCreate (cognitive 18) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/common/NamespaceOptionsClientBase.java:467 — NamespaceOptionsClientBase.getNamespacePropertiesAndTryAutoCreate has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (14 pts), error handling 1 (4 pts) (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ProtoValueMessageGroup.addValue (cognitive 18) · ×1
  • ProtoValueMessageGroup.addValue (cognitive 18) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoValueMessageGroup.java:58 — ProtoValueMessageGroup.addValue has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 2, error handling 1 (2 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Histogram.parse (cognitive 18) · ×1
  • Histogram.parse (cognitive 18) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/numeric/Histogram.java:139 — Histogram.parse has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (10 pts), error handling 1 (4 pts), loops 3, boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VirtualizedJavaCompiler.compilerOutput (cognitive 17) · ×1
  • VirtualizedJavaCompiler.compilerOutput (cognitive 17) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncJmhCompiler.scala:317 — VirtualizedJavaCompiler.compilerOutput has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (11 pts), error handling 2 (4 pts), match/switch 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OptimusInfo.applyConfig (cognitive 17) · ×1
  • OptimusInfo.applyConfig (cognitive 17) optimus/platform/projects/core/src/main/scala/optimus/entity/EntityInfo.scala:62 — OptimusInfo.applyConfig has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 2 (3 pts), match/switch 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Profiler.t_sstack_usage (cognitive 17) · ×1
  • Profiler.t_sstack_usage (cognitive 17) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/pgo/Profiler.scala:333 — Profiler.t_sstack_usage has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (12 pts), error handling 1 (2 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ProfilingEventStatistics.processProfiledEvent (cognitive 17) · ×1
  • ProfilingEventStatistics.processProfiledEvent (cognitive 17) optimus/platform/projects/core/src/main/scala/optimus/graph/tracking/ProfilingEventStatistics.scala:125 — ProfilingEventStatistics.processProfiledEvent has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (14 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AdvancedUtils.evaluateIn$newNode (cognitive 17) · ×1
  • AdvancedUtils.evaluateIn$newNode (cognitive 17) optimus/platform/projects/core/src/main/scala/optimus/platform/AdvancedUtils.scala:897 — AdvancedUtils.evaluateIn$newNode has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (15 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ScenarioStack.createChildInternal (cognitive 17) · ×1
  • ScenarioStack.createChildInternal (cognitive 17) optimus/platform/projects/core/src/main/scala/optimus/platform/ScenarioStack.scala:499 — ScenarioStack.createChildInternal has cognitive complexity 17 (threshold 15). Drivers by points: if/else 11 (15 pts), boolean chains 2 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Utils.jsonToString (cognitive 17) · ×1
  • Utils.jsonToString (cognitive 17) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:735 — Utils.jsonToString has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (15 pts), match/switch 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Utils.jsonSplit (cognitive 17) · ×1
  • Utils.jsonSplit (cognitive 17) optimus/platform/projects/core/src/main/scala/optimus/platform/stats/Utils.scala:860 — Utils.jsonSplit has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · HtmlInterpreters.nodeToHtmlString (cognitive 17) · ×1
  • HtmlInterpreters.nodeToHtmlString (cognitive 17) optimus/platform/projects/core/src/main/scala/optimus/platform/util/html/HtmlComponent.scala:85 — HtmlInterpreters.nodeToHtmlString has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (12 pts), match/switch 2 (3 pts), boolean chains 2 (nesting depth added 7). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DSIResolver.serverTime (cognitive 17) · ×1
  • DSIResolver.serverTime (cognitive 17) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/AbstractEntityResolver.scala:259 — DSIResolver.serverTime has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (13 pts), boolean chains 2, match/switch 2 (nesting depth added 6). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DALDSIExecutor.doExecuteQuery (cognitive 17) · ×1
  • DALDSIExecutor.doExecuteQuery (cognitive 17) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/DSIExecutor.scala:112 — DALDSIExecutor.doExecuteQuery has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (11 pts), match/switch 3 (5 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EntityResolverWriteImpl.executeAndRetryAppEvent (cognitive 17) · ×1
  • EntityResolverWriteImpl.executeAndRetryAppEvent (cognitive 17) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/EntityResolverWriteImpl.scala:138 — EntityResolverWriteImpl.executeAndRetryAppEvent has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (12 pts), match/switch 2 (3 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClientRequestContextImpl.addCommandResults (cognitive 17) · ×1
  • ClientRequestContextImpl.addCommandResults (cognitive 17) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dsi/protobufutils/MessageContexts.scala:222 — ClientRequestContextImpl.addCommandResults has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (16 pts), boolean chains 1 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · Tracer.flushTrace (cognitive 17) · ×1
  • Tracer.flushTrace (cognitive 17) optimus/platform/projects/dal_core/src/main/scala/optimus/dsi/trace/Tracer.scala:148 — Tracer.flushTrace has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10, match/switch 3 (4 pts), boolean chains 3 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · CombApply.apply (cognitive 17) · ×1
  • CombApply.apply (cognitive 17) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AutoAsyncComponent.scala:527 — CombApply.apply has cognitive complexity 17 (threshold 15). Drivers by points: if/else 12 (16 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RedirectAccessors.generateArgsMethods (cognitive 17) · ×1
  • RedirectAccessors.generateArgsMethods (cognitive 17) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/RedirectAccessorsComponent.scala:459 — RedirectAccessors.generateArgsMethods has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (11 pts), boolean chains 4, match/switch 1 (2 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TypedTreeCopier.inject (cognitive 17) · ×1
  • TypedTreeCopier.inject (cognitive 17) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/TypedUtils.scala:1217 — TypedTreeCopier.inject has cognitive complexity 17 (threshold 15). Drivers by points: if/else 11 (16 pts), match/switch 1 (nesting depth added 5). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · RecordingStateMachine.run (cognitive 17) · ×1
  • RecordingStateMachine.run (cognitive 17) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/AsyncProfilerIntegration.scala:692 — RecordingStateMachine.run has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (8 pts), match/switch 3 (8 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CleanName.cleanName (cognitive 17) · ×1
  • CleanName.cleanName (cognitive 17) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:618 — CleanName.cleanName has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (10 pts), loops 2 (4 pts), boolean chains 3 (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · StackAnalysis.stackMemoize (cognitive 17) · ×1
  • StackAnalysis.stackMemoize (cognitive 17) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:1142 — StackAnalysis.stackMemoize has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (16 pts), boolean chains 1 (nesting depth added 9). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · RangeQuery.convertToQuery (cognitive 17) · ×1
  • RangeQuery.convertToQuery (cognitive 17) optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/RangeQuery.scala:230 — RangeQuery.convertToQuery has cognitive complexity 17 (threshold 15). Drivers by points: match/switch 7 (13 pts), if/else 4 (nesting depth added 6). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · RangeQuery.convertToKey (cognitive 17) · ×1
  • RangeQuery.convertToKey (cognitive 17) optimus/platform/projects/platform/src/main/scala/optimus/platform/relational/reactive/RangeQuery.scala:287 — RangeQuery.convertToKey has cognitive complexity 17 (threshold 15). Drivers by points: match/switch 7 (13 pts), if/else 4 (nesting depth added 6). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · MatchTable.getMatchTableForClassMetas (cognitive 17) · ×1
  • MatchTable.getMatchTableForClassMetas (cognitive 17) optimus/platform/projects/platform/src/main/scala/optimus/platform/temporalSurface/MatchTable.scala:210 — MatchTable.getMatchTableForClassMetas has cognitive complexity 17 (threshold 15). Drivers by points: if/else 11 (15 pts), boolean chains 1, loops 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ConcurrentMultiSet.remove (cognitive 17) · ×1
  • ConcurrentMultiSet.remove (cognitive 17) optimus/platform/projects/platform/src/main/scala/optimus/platform/temporalSurface/cache/ConcurrentMultiSet.scala:78 — ConcurrentMultiSet.remove has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (16 pts), match/switch 1 (nesting depth added 6). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · CmdLineTokenizer.transition (cognitive 17) · ×1
  • CmdLineTokenizer.transition (cognitive 17) optimus/platform/projects/platform/src/main/scala/optimus/platform/util/CmdLineTokenizer.scala:35 — CmdLineTokenizer.transition has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (10 pts), match/switch 4 (7 pts) (nesting depth added 7). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ConcurrencyTracing.groupGraphEntryPoints (cognitive 17) · ×1
  • ConcurrencyTracing.groupGraphEntryPoints (cognitive 17) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/recipes/concurrency/ConcurrencyTracing.scala:369 — ConcurrencyTracing.groupGraphEntryPoints has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (12 pts), loops 3 (5 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Visitor.executeNode (cognitive 17) · ×1
  • Visitor.executeNode (cognitive 17) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/recipes/concurrency/ConcurrencyTracing.scala:266 — Visitor.executeNode has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 2, loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · HotspotsTable.initPopupMenu (cognitive 17) · ×1
  • HotspotsTable.initPopupMenu (cognitive 17) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/HotspotsTable.scala:794 — HotspotsTable.initPopupMenu has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9, boolean chains 5, loops 2 (3 pts) (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · NodeTimeLine.drawThreadHorizontalLines (cognitive 17) · ×1
  • NodeTimeLine.drawThreadHorizontalLines (cognitive 17) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/NodeTimeLine.scala:741 — NodeTimeLine.drawThreadHorizontalLines has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ValueTreeTable.fieldExpander (cognitive 17) · ×1
  • ValueTreeTable.fieldExpander (cognitive 17) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/ValueTreeTable.scala:327 — ValueTreeTable.fieldExpander has cognitive complexity 17 (threshold 15). Drivers by points: error handling 1 (4 pts), if/else 2 (4 pts), match/switch 1 (4 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PostMacroRewriter.handleMemberRef (cognitive 17) · ×1
  • PostMacroRewriter.handleMemberRef (cognitive 17) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/PostMacroRewriter.scala:53 — PostMacroRewriter.handleMemberRef has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (8 pts), match/switch 4 (7 pts), boolean chains 2 (nesting depth added 4). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · OrderByRewriter.handleSelect (cognitive 17) · ×1
  • OrderByRewriter.handleSelect (cognitive 17) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/OrderByRewriter.scala:45 — OrderByRewriter.handleSelect has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (11 pts), boolean chains 6 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ExpressionElementHelper.modulo (cognitive 17) · ×1
  • ExpressionElementHelper.modulo (cognitive 17) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/internal/ExpressionElementHelper.scala:106 — ExpressionElementHelper.modulo has cognitive complexity 17 (threshold 15). Drivers by points: boolean chains 9, if/else 8. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators. This shape REPEATS in the file: 3 other methods here (ExpressionElementHelper.minus, ExpressionElementHelper.mul, ExpressionElementHelper.plus) have the same decision points, in the same order, at the same nesting depths — so this is one pattern written 4 times rather than 4 independent problems. Splitting this body alone leaves the other 3 exactly as they are. Where these are variations on one operation, the change that clears all 4 is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · ExpressionElementHelper.minus (cognitive 17) · ×1
  • ExpressionElementHelper.minus (cognitive 17) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/internal/ExpressionElementHelper.scala:129 — ExpressionElementHelper.minus has cognitive complexity 17 (threshold 15). Drivers by points: boolean chains 9, if/else 8. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators. This shape REPEATS in the file: 3 other methods here (ExpressionElementHelper.modulo, ExpressionElementHelper.mul, ExpressionElementHelper.plus) have the same decision points, in the same order, at the same nesting depths — so this is one pattern written 4 times rather than 4 independent problems. Splitting this body alone leaves the other 3 exactly as they are. Where these are variations on one operation, the change that clears all 4 is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · ExpressionElementHelper.mul (cognitive 17) · ×1
  • ExpressionElementHelper.mul (cognitive 17) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/internal/ExpressionElementHelper.scala:152 — ExpressionElementHelper.mul has cognitive complexity 17 (threshold 15). Drivers by points: boolean chains 9, if/else 8. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators. This shape REPEATS in the file: 3 other methods here (ExpressionElementHelper.modulo, ExpressionElementHelper.minus, ExpressionElementHelper.plus) have the same decision points, in the same order, at the same nesting depths — so this is one pattern written 4 times rather than 4 independent problems. Splitting this body alone leaves the other 3 exactly as they are. Where these are variations on one operation, the change that clears all 4 is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · ExpressionElementHelper.plus (cognitive 17) · ×1
  • ExpressionElementHelper.plus (cognitive 17) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/internal/ExpressionElementHelper.scala:179 — ExpressionElementHelper.plus has cognitive complexity 17 (threshold 15). Drivers by points: boolean chains 9, if/else 8. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators. This shape REPEATS in the file: 3 other methods here (ExpressionElementHelper.modulo, ExpressionElementHelper.minus, ExpressionElementHelper.mul) have the same decision points, in the same order, at the same nesting depths — so this is one pattern written 4 times rather than 4 independent problems. Splitting this body alone leaves the other 3 exactly as they are. Where these are variations on one operation, the change that clears all 4 is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · RelTreeDecoder.decodeMemberRef (cognitive 17) · ×1
  • RelTreeDecoder.decodeMemberRef (cognitive 17) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/persistence/protocol/RelTreeDecoder.scala:119 — RelTreeDecoder.decodeMemberRef has cognitive complexity 17 (threshold 15). Drivers by points: if/else 12 (17 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ImportShadow.transform (cognitive 17) · ×1
  • ImportShadow.transform (cognitive 17) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/rewrite/RewriteComponent.scala:1126 — ImportShadow.transform has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (9 pts), boolean chains 4, match/switch 2 (4 pts) (nesting depth added 6). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · GCMemoryPoolSizes.fromMap (cognitive 17) · ×1
  • GCMemoryPoolSizes.fromMap (cognitive 17) optimus/dht/projects/common3/src/main/java/optimus/dht/common/util/monitoring/gc/GCMemoryPoolSizes.java:48 — GCMemoryPoolSizes.fromMap has cognitive complexity 17 (threshold 15). Drivers by points: if/else 13 (16 pts), loops 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · Parser.parse (cognitive 17) · ×1
  • Parser.parse (cognitive 17) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/compiler/Parser.java:76 — Parser.parse has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (14 pts), boolean chains 2, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AsyncKeyedOperationImpl.checkForCompletion (cognitive 17) · ×1
  • AsyncKeyedOperationImpl.checkForCompletion (cognitive 17) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/AsyncKeyedOperationImpl.java:226 — AsyncKeyedOperationImpl.checkForCompletion has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DHTClient.openSession (cognitive 17) · ×1
  • DHTClient.openSession (cognitive 17) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/DHTClient.java:116 — DHTClient.openSession has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (11 pts), error handling 4 (6 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · RingIntegrityCheck.main (cognitive 17) · ×1
  • RingIntegrityCheck.main (cognitive 17) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingIntegrityCheck.java:364 — RingIntegrityCheck.main has cognitive complexity 17 (threshold 15). Drivers by points: if/else 12, boolean chains 3, error handling 2. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ParallelSSHBase.sshCmd (cognitive 17) · ×1
  • ParallelSSHBase.sshCmd (cognitive 17) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/pssh/ParallelSSHBase.java:145 — ParallelSSHBase.sshCmd has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 2 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MavenPomInstaller.pomDescriptor (cognitive 16) · ×1
  • MavenPomInstaller.pomDescriptor (cognitive 16) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/postbuilders/installer/component/MavenPomInstaller.scala:61 — MavenPomInstaller.pomDescriptor has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 2 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AbstractImageBuilder.analyzeDependencies (cognitive 16) · ×1
  • AbstractImageBuilder.analyzeDependencies (cognitive 16) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/oci/ImageBuilder.scala:627 — AbstractImageBuilder.analyzeDependencies has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (11 pts), match/switch 3 (4 pts), boolean chains 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · MavenUtils.downloadUrl (cognitive 16) · ×1
  • MavenUtils.downloadUrl (cognitive 16) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/resolvers/MavenUtils.scala:108 — MavenUtils.downloadUrl has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (8 pts), match/switch 3 (7 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · CountingTrace.logStatus (cognitive 16) · ×1
  • CountingTrace.logStatus (cognitive 16) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/trace/CountingTrace.scala:138 — CountingTrace.logStatus has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MemoryThrottle.throttleIfLowMem$NF (cognitive 16) · ×1
  • MemoryThrottle.throttleIfLowMem$NF (cognitive 16) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/trace/MemoryThrottle.scala:102 — MemoryThrottle.throttleIfLowMem$NF has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (12 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Hashing._hashFileInputStream (cognitive 16) · ×1
  • Hashing._hashFileInputStream (cognitive 16) optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/utils/Hashing.scala:374 — Hashing._hashFileInputStream has cognitive complexity 16 (threshold 15). Drivers by points: if/else 12 (14 pts), error handling 1 (2 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · NodeCacheConfigs.remapTwkIds (cognitive 16) · ×1
  • NodeCacheConfigs.remapTwkIds (cognitive 16) optimus/platform/projects/core/src/main/scala/optimus/config/NodeCacheConfigs.scala:537 — NodeCacheConfigs.remapTwkIds has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (15 pts), match/switch 1 (nesting depth added 6). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · RecordedTweakables.writeHtml (cognitive 16) · ×1
  • RecordedTweakables.writeHtml (cognitive 16) optimus/platform/projects/core/src/main/scala/optimus/graph/RecordingScenario.scala:158 — RecordedTweakables.writeHtml has cognitive complexity 16 (threshold 15). Drivers by points: loops 3 (9 pts), if/else 4 (7 pts) (nesting depth added 9). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · RecordingTweakableListener.onTweakableNodeUsedBy (cognitive 16) · ×1
  • RecordingTweakableListener.onTweakableNodeUsedBy (cognitive 16) optimus/platform/projects/core/src/main/scala/optimus/graph/RecordingScenario.scala:452 — RecordingTweakableListener.onTweakableNodeUsedBy has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CollectionAggregatorNode.initializeLoopReporting (cognitive 16) · ×1
  • CollectionAggregatorNode.initializeLoopReporting (cognitive 16) optimus/platform/projects/core/src/main/scala/optimus/graph/SequenceNode.scala:399 — CollectionAggregatorNode.initializeLoopReporting has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (13 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TweakableListener.checkAndSetParent (cognitive 16) · ×1
  • TweakableListener.checkAndSetParent (cognitive 16) optimus/platform/projects/core/src/main/scala/optimus/graph/TweakableListener.scala:47 — TweakableListener.checkAndSetParent has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DefaultStallDetector.detectStalls (cognitive 16) · ×1
  • DefaultStallDetector.detectStalls (cognitive 16) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/StallDetector.scala:243 — DefaultStallDetector.detectStalls has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GridProfiler.statistics (cognitive 16) · ×1
  • GridProfiler.statistics (cognitive 16) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfiler.scala:866 — GridProfiler.statistics has cognitive complexity 16 (threshold 15). Drivers by points: loops 3 (6 pts), if/else 2 (5 pts), match/switch 1 (5 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GridProfilerData.pop (cognitive 16) · ×1
  • GridProfilerData.pop (cognitive 16) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/gridprofiler/GridProfilerData.scala:427 — GridProfilerData.pop has cognitive complexity 16 (threshold 15). Drivers by points: loops 3 (9 pts), if/else 3 (7 pts) (nesting depth added 10). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · StackRecorder.recordAndAdjustTiming (cognitive 16) · ×1
  • StackRecorder.recordAndAdjustTiming (cognitive 16) optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/sampling/StackRecorder.scala:294 — StackRecorder.recordAndAdjustTiming has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DependencyTrackerQueue.scheduleAction (cognitive 16) · ×1
  • DependencyTrackerQueue.scheduleAction (cognitive 16) optimus/platform/projects/core/src/main/scala/optimus/graph/tracking/DependencyTrackerQueue.scala:447 — DependencyTrackerQueue.scheduleAction has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (12 pts), error handling 2 (4 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Scenario._topTweaksAreEqual (cognitive 16) · ×1
  • Scenario._topTweaksAreEqual (cognitive 16) optimus/platform/projects/core/src/main/scala/optimus/platform/Scenario.scala:322 — Scenario._topTweaksAreEqual has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (10 pts), boolean chains 6 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ScenarioStack.getNode (cognitive 16) · ×1
  • ScenarioStack.getNode (cognitive 16) optimus/platform/projects/core/src/main/scala/optimus/platform/ScenarioStack.scala:1115 — ScenarioStack.getNode has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (14 pts), boolean chains 2 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · TypeDescriptor.getMethod (cognitive 16) · ×1
  • TypeDescriptor.getMethod (cognitive 16) optimus/platform/projects/core/src/main/scala/optimus/platform/relational/tree/TypeDescriptor.scala:142 — TypeDescriptor.getMethod has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (11 pts), boolean chains 5 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · TypeInfo.cast (cognitive 16) · ×1
  • TypeInfo.cast (cognitive 16) optimus/platform/projects/core/src/main/scala/optimus/platform/relational/tree/TypeInfo.scala:323 — TypeInfo.cast has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (10 pts), boolean chains 6 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · MessagesProtoClient.onMessage (cognitive 16) · ×1
  • MessagesProtoClient.onMessage (cognitive 16) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/dal/messages/MessagesProtoClient.scala:329 — MessagesProtoClient.onMessage has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (10 pts), match/switch 1 (4 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TemporalSurfaceCachedDataAccess.refineClassInfo (cognitive 16) · ×1
  • TemporalSurfaceCachedDataAccess.refineClassInfo (cognitive 16) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/temporalSurface/impl/TemporalSurfaceCacheManagerImpl.scala:64 — TemporalSurfaceCachedDataAccess.refineClassInfo has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (15 pts), match/switch 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EstablishSessionSerializer.deserialize (cognitive 16) · ×1
  • EstablishSessionSerializer.deserialize (cognitive 16) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:692 — EstablishSessionSerializer.deserialize has cognitive complexity 16 (threshold 15). Drivers by points: if/else 15, match/switch 1. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · DSIQueryTemporalitySerialization.getTemporality (cognitive 16) · ×1
  • DSIQueryTemporalitySerialization.getTemporality (cognitive 16) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/TemporalitySerialization.scala:24 — DSIQueryTemporalitySerialization.getTemporality has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (13 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · AutomaticBrokerResolution.resolveSpecificDalInstance (cognitive 16) · ×1
  • AutomaticBrokerResolution.resolveSpecificDalInstance (cognitive 16) optimus/platform/projects/dal_environment/src/main/scala/optimus/platform/dal/servicediscovery/AutomaticBrokerResolution.scala:62 — AutomaticBrokerResolution.resolveSpecificDalInstance has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (12 pts), match/switch 2 (4 pts) (nesting depth added 9). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · KeyGenerator.checkKey (cognitive 16) · ×1
  • KeyGenerator.checkKey (cognitive 16) optimus/platform/projects/entityplugin/src/main/scala/optimus/entityplugin/pretyper/CompanionMethodsGenerator.scala:27 — KeyGenerator.checkKey has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AsyncGraph.asyncCall (cognitive 16) · ×1
  • AsyncGraph.asyncCall (cognitive 16) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/AsyncGraphComponent.scala:104 — AsyncGraph.asyncCall has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (10 pts), boolean chains 3, match/switch 1 (3 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · OptimusConstructorsComponent.getOrComputeLoomLambdasWithCN (cognitive 16) · ×1
  • OptimusConstructorsComponent.getOrComputeLoomLambdasWithCN (cognitive 16) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusConstructorsComponent.scala:336 — OptimusConstructorsComponent.getOrComputeLoomLambdasWithCN has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (8 pts), loops 2 (6 pts), boolean chains 1, match/switch 1 (nesting depth added 9). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · OptimusRefchecks.checkInheritedVal (cognitive 16) · ×1
  • OptimusRefchecks.checkInheritedVal (cognitive 16) optimus/platform/projects/entityplugin/src/main/scala/optimus/tools/scalacplugins/entity/OptimusRefchecks.scala:702 — OptimusRefchecks.checkInheritedVal has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 9, if/else 4 (7 pts) (nesting depth added 3). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · SampledTimersExtractor.analyse (cognitive 16) · ×1
  • SampledTimersExtractor.analyse (cognitive 16) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/SampledTimersExtractor.scala:148 — SampledTimersExtractor.analyse has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (11 pts), loops 2 (4 pts), match/switch 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StackAnalysis.pruneLeaves (cognitive 16) · ×1
  • StackAnalysis.pruneLeaves (cognitive 16) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:1355 — StackAnalysis.pruneLeaves has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 2 (4 pts), boolean chains 1, match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · StackAnalysis.mergeAllocationsIntoLive (cognitive 16) · ×1
  • StackAnalysis.mergeAllocationsIntoLive (cognitive 16) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:1429 — StackAnalysis.mergeAllocationsIntoLive has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CrumbRecordParser.unwrap (cognitive 16) · ×1
  • CrumbRecordParser.unwrap (cognitive 16) optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/kafka/CrumbPlexer.scala:295 — CrumbRecordParser.unwrap has cognitive complexity 16 (threshold 15). Drivers by points: loops 4 (14 pts), if/else 2 (nesting depth added 10). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · MetricsTable.init (cognitive 16) · ×1
  • MetricsTable.init (cognitive 16) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/GridProfilerTable.scala:148 — MetricsTable.init has cognitive complexity 16 (threshold 15). Drivers by points: loops 3 (6 pts), if/else 2 (5 pts), match/switch 1 (5 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TableColumnTime.parsedFilter (cognitive 16) · ×1
  • TableColumnTime.parsedFilter (cognitive 16) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/TableColumns.scala:259 — TableColumnTime.parsedFilter has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (10 pts), boolean chains 3, loops 1 (2 pts), error handling 1 (nesting depth added 2). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages. This shape REPEATS in the file: 2 other methods here (TableColumnCount.parsedFilter, TableColumnLong.parsedFilter) have the same decision points, in the same order, at the same nesting depths — so this is one pattern written 3 times rather than 3 independent problems. Splitting this body alone leaves the other 2 exactly as they are. Where these are variations on one operation, the change that clears all 3 is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · TableColumnCount.parsedFilter (cognitive 16) · ×1
  • TableColumnCount.parsedFilter (cognitive 16) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/TableColumns.scala:319 — TableColumnCount.parsedFilter has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (10 pts), boolean chains 3, loops 1 (2 pts), error handling 1 (nesting depth added 2). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages. This shape REPEATS in the file: 2 other methods here (TableColumnTime.parsedFilter, TableColumnLong.parsedFilter) have the same decision points, in the same order, at the same nesting depths — so this is one pattern written 3 times rather than 3 independent problems. Splitting this body alone leaves the other 2 exactly as they are. Where these are variations on one operation, the change that clears all 3 is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · TableColumnLong.parsedFilter (cognitive 16) · ×1
  • TableColumnLong.parsedFilter (cognitive 16) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/ui/TableColumns.scala:382 — TableColumnLong.parsedFilter has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (10 pts), boolean chains 3, loops 1 (2 pts), error handling 1 (nesting depth added 2). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages. This shape REPEATS in the file: 2 other methods here (TableColumnTime.parsedFilter, TableColumnCount.parsedFilter) have the same decision points, in the same order, at the same nesting depths — so this is one pattern written 3 times rather than 3 independent problems. Splitting this body alone leaves the other 2 exactly as they are. Where these are variations on one operation, the change that clears all 3 is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · NodeDiGraphWriter.hasPath (cognitive 16) · ×1
  • NodeDiGraphWriter.hasPath (cognitive 16) optimus/platform/projects/platform_profiler/src/main/scala/optimus/profiler/utils/NodeDiGraphWriter.scala:198 — NodeDiGraphWriter.hasPath has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ScalaBasedDynamicObjectFactory.apply (cognitive 16) · ×1
  • ScalaBasedDynamicObjectFactory.apply (cognitive 16) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/AbstractDynamicObject.scala:58 — ScalaBasedDynamicObjectFactory.apply has cognitive complexity 16 (threshold 15). Drivers by points: match/switch 6 (15 pts), if/else 1 (nesting depth added 9). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · PostMacroRewriter.handleFuncCall (cognitive 16) · ×1
  • PostMacroRewriter.handleFuncCall (cognitive 16) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/PostMacroRewriter.scala:105 — PostMacroRewriter.handleFuncCall has cognitive complexity 16 (threshold 15). Drivers by points: match/switch 5 (10 pts), if/else 5, boolean chains 1 (nesting depth added 5). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · QueryMacros.rewriteAnonClassDef (cognitive 16) · ×1
  • QueryMacros.rewriteAnonClassDef (cognitive 16) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/QueryMacros.scala:501 — QueryMacros.rewriteAnonClassDef has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 7, if/else 4 (5 pts), match/switch 2 (4 pts) (nesting depth added 3). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · Typer.promote (cognitive 16) · ×1
  • Typer.promote (cognitive 16) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/Typer.scala:444 — Typer.promote has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (15 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DefaultBinder.bindTake (cognitive 16) · ×1
  • DefaultBinder.bindTake (cognitive 16) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/translation/DefaultBinder.scala:1156 — DefaultBinder.bindTake has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (16 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MultiRelationElementRemover.handleAggregate (cognitive 16) · ×1
  • MultiRelationElementRemover.handleAggregate (cognitive 16) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/MultiRelationElementRemover.scala:72 — MultiRelationElementRemover.handleAggregate has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (9 pts), match/switch 3 (7 pts) (nesting depth added 6). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · DictionaryProxy.proxyEquals (cognitive 16) · ×1
  • DictionaryProxy.proxyEquals (cognitive 16) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/persistence/protocol/DictionaryProxy.scala:40 — DictionaryProxy.proxyEquals has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (10 pts), loops 1 (4 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EntityMultiRelation.verifyInClauseExpression (cognitive 16) · ×1
  • EntityMultiRelation.verifyInClauseExpression (cognitive 16) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/EntityMultiRelation.scala:208 — EntityMultiRelation.verifyInClauseExpression has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (8 pts), match/switch 4 (8 pts) (nesting depth added 6). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · PicklerSelector.getPickler (cognitive 16) · ×1
  • PicklerSelector.getPickler (cognitive 16) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/PicklerSelector.scala:68 — PicklerSelector.getPickler has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 1, match/switch 1 (nesting depth added 5). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ByteArrayBasedParserInput.nextUtf8Char (cognitive 16) · ×1
  • ByteArrayBasedParserInput.nextUtf8Char (cognitive 16) optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/JsonParser.scala:325 — ByteArrayBasedParserInput.nextUtf8Char has cognitive complexity 16 (threshold 15). Drivers by points: if/else 13 (16 pts) (nesting depth added 3). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
D2 · Cognitive Complexity · MapValuesRewriter.transform (cognitive 16) · ×1
  • MapValuesRewriter.transform (cognitive 16) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/rewrite/RewriteComponent.scala:805 — MapValuesRewriter.transform has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (12 pts), match/switch 2 (3 pts), boolean chains 1 (nesting depth added 6). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ProcedureSyntax.transform (cognitive 16) · ×1
  • ProcedureSyntax.transform (cognitive 16) optimus/platform/projects/stagingplugin/src/main/scala/optimus/tools/scalacplugins/entity/rewrite/RewriteComponent.scala:929 — ProcedureSyntax.transform has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (15 pts), match/switch 1 (nesting depth added 6). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · SparseUtils.sparseOpen (cognitive 16) · ×1
  • SparseUtils.sparseOpen (cognitive 16) optimus/stratosphere/common/src/main/scala/optimus/stratosphere/sparse/SparseUtils.scala:33 — SparseUtils.sparseOpen has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (8 pts), match/switch 3 (7 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · DynamicDependencyDiscoveryMethodVisitor.visitMethodInsn (cognitive 16) · ×1
  • DynamicDependencyDiscoveryMethodVisitor.visitMethodInsn (cognitive 16) optimus/platform/projects/entityagent/src/main/java/optimus/deps/DynamicDependencyDiscoveryMethodVisitor.java:38 — DynamicDependencyDiscoveryMethodVisitor.visitMethodInsn has cognitive complexity 16 (threshold 15). Drivers by points: match/switch 4 (9 pts), if/else 3 (7 pts) (nesting depth added 9). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · Parser.handleOp (cognitive 16) · ×1
  • Parser.handleOp (cognitive 16) optimus/platform/projects/entityagent/src/main/java/optimus/graph/loom/compiler/Parser.java:331 — Parser.handleOp has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (9 pts), boolean chains 5, loops 1 (2 pts) (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · SystemExitGetOsInfo.isAllowedExit (cognitive 16) · ×1
  • SystemExitGetOsInfo.isAllowedExit (cognitive 16) optimus/platform/projects/entityagent/src/main/java/optimus/systemexit/SystemExitGetOsInfo.java:156 — SystemExitGetOsInfo.isAllowedExit has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 3 (6 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AsyncDispatcherBasePatch.emitQueueFullWarning (cognitive 16) · ×1
  • AsyncDispatcherBasePatch.emitQueueFullWarning (cognitive 16) optimus/platform/projects/platform/src/main/scala/msjava/logbackutils/async/internal/AsyncDispatcherBasePatch.java:324 — AsyncDispatcherBasePatch.emitQueueFullWarning has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (8 pts), ternaries 3 (7 pts), error handling 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AsyncDispatcherBasePatch.write (cognitive 16) · ×1
  • AsyncDispatcherBasePatch.write (cognitive 16) optimus/platform/projects/platform/src/main/scala/msjava/logbackutils/async/internal/AsyncDispatcherBasePatch.java:621 — AsyncDispatcherBasePatch.write has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (13 pts), loops 1 (3 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ActivePutListeners.currentPutSet (cognitive 16) · ×1
  • ActivePutListeners.currentPutSet (cognitive 16) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/ActivePutListeners.java:104 — ActivePutListeners.currentPutSet has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (9 pts), loops 3 (7 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AsyncPutOperationImpl.debugTimeout (cognitive 16) · ×1
  • AsyncPutOperationImpl.debugTimeout (cognitive 16) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/AsyncPutOperationImpl.java:438 — AsyncPutOperationImpl.debugTimeout has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 3 (4 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · StorageFormat.writeToBuf (cognitive 16) · ×1
  • StorageFormat.writeToBuf (cognitive 16) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/StorageFormat.java:59 — StorageFormat.writeToBuf has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (15 pts), ternaries 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PutOptions.equals (cognitive 16) · ×1
  • PutOptions.equals (cognitive 16) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/PutOptions.java:587 — PutOptions.equals has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (15 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ObjectDefParser2.parseFromObjDefFormat (cognitive 16) · ×1
  • ObjectDefParser2.parseFromObjDefFormat (cognitive 16) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ObjectDefParser2.java:261 — ObjectDefParser2.parseFromObjDefFormat has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (12 pts), error handling 1 (3 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GroupingPausingBaseWorker.addWorkForGrouping (cognitive 16) · ×1
  • GroupingPausingBaseWorker.addWorkForGrouping (cognitive 16) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/thread/lwt/GroupingPausingBaseWorker.java:110 — GroupingPausingBaseWorker.addWorkForGrouping has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (16 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · gridprofiler.layoutRow (cognitive 16) · ×1
  • gridprofiler.layoutRow (cognitive 16) optimus/platform/projects/core/src/main/resources/js/gridprofiler.js:12 — gridprofiler.layoutRow has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (9 pts), ternaries 2 (6 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Near-duplicate member family (3 members, 25 shared lines) · ×1
  • Near-duplicate member family (3 members, 25 shared lines) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:57 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:57-86 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALReferenceReducer.scala:65-94 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchReferenceReducer.scala:61-90 — These 3 members are variants of one another: a block of 25 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 3 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 3 times.
D4 · Code Duplication · Near-duplicate member pair (49 shared lines) · ×1
  • Near-duplicate member pair (49 shared lines) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:36 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/IntBufferDHTKeyCuckoo.java:36-91 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/collection/cuckoo/IntBufferCuckoo.java:41-96 — These two members are variants of one another: 49 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (46 shared lines) · ×1
  • Near-duplicate member pair (46 shared lines) optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:92 — optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:92-253 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:282-449 — These two members are variants of one another: 46 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Near-duplicate member pair (30 shared lines) · ×1
  • Near-duplicate member pair (30 shared lines) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncElectronCompiler.scala:76 — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncElectronCompiler.scala:76-164 | optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/AsyncWebCompiler.scala:75-168 — These two members are variants of one another: 30 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Edited copy of a member (35 corresponding lines) · ×1
  • Edited copy of a member (35 corresponding lines) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:84 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:84-118 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:83-117 — These two members are one piece of code written twice and then edited apart: 35 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (28 corresponding lines) · ×1
  • Edited copy of a member (28 corresponding lines) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:37 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:37-65 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:113-141 — These two members are one piece of code written twice and then edited apart: 28 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (16 corresponding lines) · ×1
  • Edited copy of a member (16 corresponding lines) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala:302 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALLanguage.scala:302-317 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchLanguage.scala:160-175 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Members sharing a duplicated core (21 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (21 members, 50+ identical tokens) optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:52 — optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:52-65 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:77-92 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:106-123 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:138-157 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:173-194 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:211-234 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:252-277 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:296-323 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:353-382 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:426-457 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:505-538 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:589-624 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:678-715 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:772-811 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:871-912 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:977-1020 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1088-1133 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1204-1251 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1325-1394 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1493-1565 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1711-1786 — These 21 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 21 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 21 times.
D4 · Code Duplication · Members sharing a duplicated core (14 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (14 members, 50+ identical tokens) optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:143 — optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:143-152 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:162-172 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:182-193 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:203-215 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:226-239 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:250-264 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:287-302 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:326-342 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:367-384 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:410-428 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:455-474 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:502-522 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:551-572 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:644-666 — These 14 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 14 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 14 times.
D4 · Code Duplication · Members sharing a duplicated core (8 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (8 members, 50+ identical tokens) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:144 — optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:144-155 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:168-187 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:201-222 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:237-260 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:276-301 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:326-353 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:380-409 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:441-472 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
D4 · Code Duplication · Members sharing a duplicated core (7 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (7 members, 50+ identical tokens) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:67 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:67-88 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:143-165 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:159-180 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:205-237 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:272-308 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:397-415 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:1715-1747 — These 7 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
D4 · Code Duplication · Members sharing a duplicated core (6 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (6 members, 50+ identical tokens) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:170 — optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:170-180 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:191-202 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:214-226 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:239-252 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:266-280 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:295-310 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
D4 · Code Duplication · Members sharing a duplicated core (5 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (5 members, 50+ identical tokens) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:299 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:299-439 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:441-470 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:265-399 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:401-431 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMProxyGenerator.scala:460-528 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication · Duplicated block (79 lines × 2) · ×1
  • Duplicated block (79 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqUtils.scala:39 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqUtils.scala:39-117 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqUtils.scala:41-119 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqUtils.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqUtils.scala` as WHOLE FILES: 96% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqUtils.scala:39` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (52 lines × 2) · ×1
  • Duplicated block (52 lines × 2) optimus/platform/projects/scala_compat/src/main/scala-2.12/optimus/scalacompat/repl/ScalaRepl.scala:82 — optimus/platform/projects/scala_compat/src/main/scala-2.12/optimus/scalacompat/repl/ScalaRepl.scala:82-133 | optimus/platform/projects/scala_compat/src/main/scala-2.13/optimus/scalacompat/repl/ScalaRepl.scala:75-126 — before extracting anything, compare `optimus/platform/projects/scala_compat/src/main/scala-2.12/optimus/scalacompat/repl/ScalaRepl.scala` and `optimus/platform/projects/scala_compat/src/main/scala-2.13/optimus/scalacompat/repl/ScalaRepl.scala` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 68 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (42 lines × 2) · ×1
  • Duplicated block (42 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:96 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:96-137 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:70-111 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (40 lines × 2) · ×1
  • Duplicated block (40 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:82 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:82-121 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala:68-107 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 165 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (35 lines × 2) · ×1
  • Duplicated block (35 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:110 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:110-144 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala:128-162 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusDoubleSeq.scala` as WHOLE FILES: this scan already matched 12 separate duplicated blocks between them, totalling at least 153 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (33 lines × 2) · ×1
  • Duplicated block (33 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/ArrangeHelper.scala:62 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/inmemory/ArrangeHelper.scala:62-94 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/internal/RelationalUtils.scala:331-363 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (30–31 lines × 2) · ×1
  • Duplicated block (30–31 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:344 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:344-374 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:319-348 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (29 lines × 2) · ×1
  • Duplicated block (29 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:284 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:284-312 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:257-285 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (25–26 lines × 2) · ×1
  • Duplicated block (25–26 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:120 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:120-145 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:119-143 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 252 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (1–25 lines × 16) · ×1
  • Duplicated block (1–25 lines × 16) optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:446 — optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:446-446 | optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:450-450 | optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:454-454 | optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:458-458 | optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:460-461 | optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:463-463 | optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:465-466 | optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:468-484 | optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:487-504 | optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:507-525 | optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:528-547 | optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:550-570 | optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:573-594 | optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:597-619 | optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:622-645 | optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:648-672 — all 16 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:446` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:446` calls `target$withNode` and `optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:484` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (23 lines × 2) · ×1
  • Duplicated block (23 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:253 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala:253-275 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala:235-257 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArray.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArray.scala` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 165 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (17–22 lines × 3) · ×1
  • Duplicated block (17–22 lines × 3) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:423 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:423-439 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:454-470 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMProxyGenerator.scala:507-528 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:423` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (20–22 lines × 2) · ×1
  • Duplicated block (20–22 lines × 2) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:412 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:412-431 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:460-481 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/pivot/PivotTableMacros.scala:412` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (19–21 lines × 4) · ×1
  • Duplicated block (19–21 lines × 4) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:325 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:325-343 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:384-404 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:289-307 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:344-364 — before extracting anything, compare `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala` and `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 107 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:325` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (21 lines × 3) · ×1
  • Duplicated block (21 lines × 3) optimus/platform/projects/platform/src/main/scala/optimus/platform/Apars.scala:129 — optimus/platform/projects/platform/src/main/scala/optimus/platform/Apars.scala:129-149 | optimus/platform/projects/platform/src/main/scala/optimus/platform/Apars.scala:170-190 | optimus/platform/projects/platform/src/main/scala/optimus/platform/Apars.scala:216-236 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/platform/src/main/scala/optimus/platform/Apars.scala:129` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (19–20 lines × 2) · ×1
  • Duplicated block (19–20 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:429 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:429-448 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala:401-419 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqArrays.scala` as WHOLE FILES: this scan already matched 22 separate duplicated blocks between them, totalling at least 355 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqArrays.scala:429` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13–16 lines × 3) · ×1
  • Duplicated block (13–16 lines × 3) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:449 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:449-461 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala:410-422 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMProxyGenerator.scala:501-516 — before extracting anything, compare `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala` and `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMKeyGenerator.scala` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 107 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/asm/ASMDynamicObjectGenerator.scala:449` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (14–15 lines × 3) · ×1
  • Duplicated block (14–15 lines × 3) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:472 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:472-486 | optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala:412-425 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala:419-432 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeq.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeq.scala` as WHOLE FILES: this scan already matched 16 separate duplicated blocks between them, totalling at least 252 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusDoubleSeq.scala:472` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11–13 lines × 3) · ×1
  • Duplicated block (11–13 lines × 3) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:78 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:78-88 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:155-165 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:1735-1747 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:78` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13 lines × 3) · ×1
  • Duplicated block (13 lines × 3) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:74 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:74-86 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALReferenceReducer.scala:82-94 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/DALFullTextSearchReferenceReducer.scala:78-90 — before extracting anything, compare `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala` and `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALReferenceReducer.scala` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/accelerated/DALAccReferenceReducer.scala:74` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11–13 lines × 2) · ×1
  • Duplicated block (11–13 lines × 2) optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/cpp/gcc/GccLinker.scala:70 — optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/cpp/gcc/GccLinker.scala:70-80 | optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/cpp/vc/VcLinker.scala:73-85 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/cpp/gcc/GccLinker.scala:70` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (2–13 lines × 4) · ×1
  • Duplicated block (2–13 lines × 4) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:165 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:165-166 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:212-224 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:279-291 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:403-404 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:165` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:212` calls `At`, `setTxTime`, `toProto` and `optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:165` does not — after which the two agree again for 5 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (11–12 lines × 2) · ×1
  • Duplicated block (11–12 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:92 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:92-103 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:79-89 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala` as WHOLE FILES: this scan already matched 26 separate duplicated blocks between them, totalling at least 181 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSmall.scala:105` calls `collect` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSmall.scala:90` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (8–11 lines × 9) · ×1
  • Duplicated block (8–11 lines × 9) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:203 — optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:203-213 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:224-234 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:245-255 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:267-277 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:288-298 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:309-319 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:330-340 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:350-360 | optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:369-376 — all 9 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:203` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (9–10 lines × 2) · ×1
  • Duplicated block (9–10 lines × 2) optimus/platform/projects/core/src/main/scala/optimus/graph/NodeBatcherSchedulerPlugin.scala:755 — optimus/platform/projects/core/src/main/scala/optimus/graph/NodeBatcherSchedulerPlugin.scala:755-763 | optimus/platform/projects/core/src/main/scala/optimus/graph/NodeBatcherSchedulerPlugin.scala:809-818 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/core/src/main/scala/optimus/graph/NodeBatcherSchedulerPlugin.scala:755` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7–8 lines × 14) · ×1
  • Duplicated block (7–8 lines × 14) optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:144 — optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:144-151 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:163-169 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:183-189 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:204-210 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:227-233 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:251-257 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:288-294 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:327-333 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:368-374 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:411-417 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:456-462 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:503-509 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:552-558 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:645-651 — all 14 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:169` calls `args` and `optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:151` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (8 lines × 6) · ×1
  • Duplicated block (8 lines × 6) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:171 — optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:171-178 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:192-199 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:215-222 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:240-247 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:267-274 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:296-303 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:200` calls `pickle` and `optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TuplePicklers.scala:179` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6–8 lines × 2) · ×1
  • Duplicated block (6–8 lines × 2) optimus/platform/projects/dal_core/src/main/scala/optimus/dal/silverking/SkUtils.scala:83 — optimus/platform/projects/dal_core/src/main/scala/optimus/dal/silverking/SkUtils.scala:83-90 | optimus/platform/projects/dal_core/src/main/scala/optimus/dal/silverking/SkUtils.scala:96-101 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/dal_core/src/main/scala/optimus/dal/silverking/SkUtils.scala:83` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (7 lines × 19) · ×1
  • Duplicated block (7 lines × 19) optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:114 — optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:114-120 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:147-153 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:183-189 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:222-228 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:264-270 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:309-315 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:367-373 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:441-447 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:521-527 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:606-612 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:696-702 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:791-797 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:891-897 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:998-1004 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1110-1116 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1227-1233 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1349-1355 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1518-1524 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1737-1743 — all 19 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:114` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (6–7 lines × 8) · ×1
  • Duplicated block (6–7 lines × 8) optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:295 — optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:295-301 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:334-339 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:375-380 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:418-423 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:463-468 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:510-515 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:559-564 | optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:652-657 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:339` calls `args` and `optimus/platform/projects/core/src/main/scala/optimus/graph/loom/LNodeFunction.scala:301` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (4–7 lines × 8) · ×1
  • Duplicated block (4–7 lines × 8) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:148 — optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:148-151 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:177-183 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:211-217 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:248-254 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:288-294 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:339-345 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:394-400 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:456-462 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:148` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:218` calls `unpickle`, `s` and `optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:184` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6–7 lines × 6) · ×1
  • Duplicated block (6–7 lines × 6) optimus/platform/projects/platform/src/main/scala/optimus/platform/dsi/accelerated/AcceleratedInfoConversions.scala:90 — optimus/platform/projects/platform/src/main/scala/optimus/platform/dsi/accelerated/AcceleratedInfoConversions.scala:90-96 | optimus/platform/projects/platform/src/main/scala/optimus/platform/dsi/accelerated/AcceleratedInfoConversions.scala:99-105 | optimus/platform/projects/platform/src/main/scala/optimus/platform/dsi/accelerated/AcceleratedInfoConversions.scala:109-115 | optimus/platform/projects/platform/src/main/scala/optimus/platform/dsi/accelerated/AcceleratedInfoConversions.scala:120-126 | optimus/platform/projects/platform/src/main/scala/optimus/platform/dsi/accelerated/AcceleratedInfoConversions.scala:132-138 | optimus/platform/projects/platform/src/main/scala/optimus/platform/dsi/accelerated/AcceleratedInfoConversions.scala:145-150 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/platform/src/main/scala/optimus/platform/dsi/accelerated/AcceleratedInfoConversions.scala:90` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (6 lines × 20) · ×1
  • Duplicated block (6 lines × 20) optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:84 — optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:84-89 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:114-119 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:147-152 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:183-188 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:222-227 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:264-269 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:309-314 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:367-372 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:441-446 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:521-526 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:606-611 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:696-701 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:791-796 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:891-896 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:998-1003 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1110-1115 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1227-1232 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1349-1354 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1518-1523 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1737-1742 — all 20 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:84` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (3–6 lines × 7) · ×1
  • Duplicated block (3–6 lines × 7) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:71 — optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:71-76 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:148-153 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:163-165 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:209-211 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:276-278 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:401-403 | optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:1731-1733 — there are 7 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 7 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:71` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/EnumerateCommandProtoSerialization.scala:76` calls `TxTime`, `setTxTime`, `toProto` and `optimus/platform/projects/dal_core/src/main/scala/optimus/platform/dsi/bitemporal/proto/GetCommandProtoSerialization.scala:165` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (5 lines × 21) · ×1
  • Duplicated block (5 lines × 21) optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:52 — optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:52-56 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:77-81 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:106-110 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:138-142 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:173-177 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:211-215 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:252-256 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:296-300 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:353-357 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:426-430 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:505-509 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:589-593 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:678-682 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:772-776 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:871-875 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:977-981 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1088-1092 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1204-1208 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1325-1329 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1493-1497 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1711-1715 — all 21 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:52` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (5 lines × 14) · ×1
  • Duplicated block (5 lines × 14) optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:316 — optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:316-320 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:374-378 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:448-452 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:528-532 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:613-617 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:703-707 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:798-802 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:898-902 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1005-1009 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1117-1121 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1234-1238 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1356-1360 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1525-1529 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1744-1748 — all 14 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
D4 · Code Duplication · Duplicated block (5 lines × 9) · ×1
  • Duplicated block (5 lines × 9) optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:708 — optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:708-712 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:803-807 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:903-907 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1010-1014 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1122-1126 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1239-1243 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1361-1365 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1530-1534 | optimus/platform/projects/spray_json/src/main/scala/optimus/config/spray/json/ProductFormatsInstances.scala:1749-1753 — all 9 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
D4 · Code Duplication · Duplicated block (5 lines × 6) · ×1
  • Duplicated block (5 lines × 6) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:203 — optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:203-207 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:239-243 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:278-282 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:328-332 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:382-386 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:443-447 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:203` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:244` calls `unpickle` and `optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:208` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (4–5 lines × 3) · ×1
  • Duplicated block (4–5 lines × 3) optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:346 — optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:346-349 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:401-405 | optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:463-467 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:468` calls `unpickle`, `s` and `optimus/platform/projects/dal_client/src/main/scala/optimus/platform/pickling/TupleUnpicklers.scala:350` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (67 lines × 2) · ×1
  • Duplicated block (67 lines × 2) optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSupport.scala:15 — optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSupport.scala:15-81 | optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSupport.scala:15-81 — before extracting anything, compare `optimus/platform/projects/collections/src/main/scala-2.12/optimus/collection/OptimusSeqSupport.scala` and `optimus/platform/projects/collections/src/main/scala-2.13/optimus/collection/OptimusSeqSupport.scala` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (36 lines × 2) · ×1
  • Duplicated block (36 lines × 2) optimus/platform/projects/core/src/main/scala/intellij/only/DoNotUseIJNodeFunctionConversions.scala:21 — optimus/platform/projects/core/src/main/scala/intellij/only/DoNotUseIJNodeFunctionConversions.scala:21-56 | optimus/platform/projects/scala_compat/src/main/scala-2.12/optimus/scalacompat/collection/DummyTraversable.scala:21-75 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (57 lines × 3) · ×1
  • Duplicated block (57 lines × 3) optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALMappingEntityFactory.scala:38 — optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALMappingEntityFactory.scala:38-94 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/fullTextSearch/FullTextSearchMappingEntityFactory.scala:41-109 | optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/pubsub/PubSubMappingEntityFactory.scala:37-123 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/priql_dal/src/main/scala/optimus/platform/relational/dal/core/DALMappingEntityFactory.scala:38` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (39 lines × 2) · ×1
  • Duplicated block (39 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:227 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:227-265 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/NewIncomingBufferedData.java:139-177 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/NewIncomingBufferedData.java` as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 157 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:227` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (31 lines × 3) · ×1
  • Duplicated block (31 lines × 3) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:258 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:258-288 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java:209-239 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/NewIncomingBufferedData.java:170-200 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 94 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java:240` calls `debug` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:289` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (24–25 lines × 3) · ×1
  • Duplicated block (24–25 lines × 3) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:233 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:233-257 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java:182-205 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/NewIncomingBufferedData.java:145-169 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 94 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (20–23 lines × 2) · ×1
  • Duplicated block (20–23 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/BZip2.java:44 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/BZip2.java:44-66 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/Zip.java:39-58 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/BZip2.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/Zip.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/BZip2.java:44` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (18 lines × 3) · ×1
  • Duplicated block (18 lines × 3) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:362 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:362-379 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java:331-348 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/NewIncomingBufferedData.java:279-296 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/IncomingBufferedData.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 94 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/IncomingMessageGroup.java:362` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (11–17 lines × 2) · ×1
  • Duplicated block (11–17 lines × 2) optimus/platform/projects/msnet-ssl/src/main/java/msjava/msnet/MSNetSSLSocket.java:183 — optimus/platform/projects/msnet-ssl/src/main/java/msjava/msnet/MSNetSSLSocket.java:183-199 | optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetSSLSocket.java:126-136 — before extracting anything, compare `optimus/platform/projects/msnet-ssl/src/main/java/msjava/msnet/MSNetSSLSocket.java` and `optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetSSLSocket.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 54 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (15 lines × 3) · ×1
  • Duplicated block (15 lines × 3) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/PersistentAsyncServer.java:598 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/PersistentAsyncServer.java:598-612 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/PersistentAsyncServer.java:639-653 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/PersistentAsyncServer.java:666-680 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/PersistentAsyncServer.java:598` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13–15 lines × 2) · ×1
  • Duplicated block (13–15 lines × 2) optimus/platform/projects/platform/src/main/scala/msjava/logbackutils/async/internal/AsyncDispatcherBasePatch.java:395 — optimus/platform/projects/platform/src/main/scala/msjava/logbackutils/async/internal/AsyncDispatcherBasePatch.java:395-407 | optimus/platform/projects/platform/src/main/scala/msjava/logbackutils/async/internal/AsyncDispatcherBasePatch.java:419-433 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/platform/src/main/scala/msjava/logbackutils/async/internal/AsyncDispatcherBasePatch.java:395` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12–14 lines × 4) · ×1
  • Duplicated block (12–14 lines × 4) optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:171 — optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:171-183 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:210-223 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:357-368 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:402-413 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:171` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (12 lines × 8) · ×1
  • Duplicated block (12 lines × 8) optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:112 — optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:112-123 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:140-151 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:167-178 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:206-217 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:301-312 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:327-338 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:353-364 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:398-409 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:112` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:111` calls `visitLocalVariable` and `optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:139` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (8–12 lines × 3) · ×1
  • Duplicated block (8–12 lines × 3) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/BZip2.java:123 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/BZip2.java:123-131 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/Snappy.java:69-80 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/Zip.java:103-110 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/BZip2.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/Zip.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 56 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/compression/BZip2.java:123` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8–12 lines × 2) · ×1
  • Duplicated block (8–12 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingEntry.java:460 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingEntry.java:460-471 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/SingleRing.java:293-300 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingEntry.java:460` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10–11 lines × 2) · ×1
  • Duplicated block (10–11 lines × 2) optimus/dht/projects/client3/src/main/java/optimus/dht/client/api/replication/BatchOperationTemplate.java:329 — optimus/dht/projects/client3/src/main/java/optimus/dht/client/api/replication/BatchOperationTemplate.java:329-338 | optimus/dht/projects/client3/src/main/java/optimus/dht/client/api/replication/BatchOperationTemplate.java:403-413 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/dht/projects/client3/src/main/java/optimus/dht/client/api/replication/BatchOperationTemplate.java:403` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8–11 lines × 2) · ×1
  • Duplicated block (8–11 lines × 2) optimus/platform/projects/msnet-ssl/src/main/java/msjava/msnet/MSNetSSLSocket.java:167 — optimus/platform/projects/msnet-ssl/src/main/java/msjava/msnet/MSNetSSLSocket.java:167-177 | optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetSSLSocket.java:115-122 — before extracting anything, compare `optimus/platform/projects/msnet-ssl/src/main/java/msjava/msnet/MSNetSSLSocket.java` and `optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetSSLSocket.java` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 54 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (7–11 lines × 2) · ×1
  • Duplicated block (7–11 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:722 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:722-728 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:753-763 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:722` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (9–11 lines × 2) · ×1
  • Duplicated block (9–11 lines × 2) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingTreeBuilder.java:247 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingTreeBuilder.java:247-255 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/TopologyRingCreator.java:1570-1580 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingTreeBuilder.java:256` calls `parse` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/TopologyRingCreator.java:1580` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (8–9 lines × 5) · ×1
  • Duplicated block (8–9 lines × 5) optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:94 — optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:94-101 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:146-154 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:284-291 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:307-314 | optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:333-340 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:94` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:102` calls `visitVarInsn`, `visitIntInsn` and `optimus/platform/projects/entityagent/src/main/java/optimus/NodeTaskTransformer.java:155` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6–7 lines × 4) · ×1
  • Duplicated block (6–7 lines × 4) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:721 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:721-726 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:745-751 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:752-758 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:853-858 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:720` calls `info` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:851` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (6 lines × 6) · ×1
  • Duplicated block (6 lines × 6) optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:324 — optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:324-329 | optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:428-433 | optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:577-582 | optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:764-769 | optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:848-853 | optimus/dht/projects/client3/src/main/java/optimus/dht/client/internal/kv/DefaultKVClient.java:950-955 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `entries` to `List<K>` in one and `List<KVEntry<K>>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (25 lines × 3) · ×1
  • Duplicated block (25 lines × 3) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/InvalidationException.java:21 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/InvalidationException.java:21-45 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/PutException.java:26-50 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/PutExceptionImpl.java:28-52 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/InvalidationException.java:21` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (20 lines × 5) · ×1
  • Duplicated block (20 lines × 5) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/NamespaceCreationException.java:19 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/NamespaceCreationException.java:19-38 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/NamespaceLinkException.java:18-37 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/NamespaceModificationException.java:20-39 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/SnapshotExceptionImpl.java:17-36 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/impl/SyncRequestExceptionImpl.java:17-36 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 5 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (18 lines × 7) · ×1
  • Duplicated block (18 lines × 7) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/common/CorruptValueException.java:19 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/common/CorruptValueException.java:19-36 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/common/TimeoutException.java:15-32 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/IneligibleServerException.java:15-32 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/InvalidRingException.java:16-33 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/code/ConstraintViolationException.java:17-34 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/text/ObjectDefParseException.java:16-33 | optimus/silverking/projects/silverking_utils/src/main/java/com/ms/silverking/util/PropertyException.java:18-35 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 7 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 7 times.
D4 · Code Duplication · Duplicated block (20 lines × 6) · ×1
  • Duplicated block (20 lines × 6) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/common/NamespacePropertiesDeleteException.java:15 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/common/NamespacePropertiesDeleteException.java:15-34 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/common/NamespacePropertiesOperationException.java:15-34 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/common/NamespacePropertiesPutException.java:15-34 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/common/NamespacePropertiesRetrievalException.java:15-34 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/code/PanicException.java:16-35 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/util/IncomparableException.java:18-37 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 6 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 6 times.
D4 · Code Duplication · Duplicated block (6 lines × 4) · ×1
  • Duplicated block (6 lines × 4) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java:99 — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java:99-104 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DebugKey.java:176-181 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingInfo.java:121-126 | optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingIntegrityCheck.java:266-271 — before extracting anything, compare `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/ComputeRingStats.java` and `optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/RingInfo.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 35 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Edited copy of a member (27 corresponding lines) · ×1
  • Edited copy of a member (27 corresponding lines) optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform03/relational/Data.scala:234 — optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform03/relational/Data.scala:234-271 | optimus/platform/projects/examples_platform/src/main/scala/optimus/examples/platform03/relational/Data.scala:273-303 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (15–19 lines × 3) · ×1
  • Duplicated block (15–19 lines × 3) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/internal/MSNetConnectingLock.java:175 — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/internal/MSNetConnectingLock.java:175-189 | optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/internal/MSNetConnectingLock.java:255-270 | optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/internal/MSNetConnectingLock.java:288-306 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
IC1 · Incompleteness & stubs · Hollow method · ×1
  • Hollow method — returns a constant without doing the work optimus/platform/projects/core/src/main/scala/optimus/platform/Tweak.scala:385 — `apply` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
P1 · CI/CD gates · No CI pipeline · ×1
  • No CI pipeline — No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, …) — changes aren't gated by an automated build/test.
X17 · Uncapped recursion over a caller-supplied document · Recursive walk over a caller-supplied document has no depth cap · ×1
  • Recursive walk over a caller-supplied document has no depth cap optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/crumbs/Properties.scala:422 — `EventCauseJsonProtocol.read` is public and takes `value: JsValue` from its caller, and it calls itself at line 422 with a piece of `value`, not as a tail call the compiler turns into a loop — and nowhere in `EventCauseJsonProtocol.read` is there a depth parameter, a descent counter, or any other cap. The walk therefore spends one stack frame per LEVEL of the value it is handed, so the nesting of the caller's document — not this code — decides how deep the stack goes. On the JVM's default 1 MB thread stack a walk like this one throws `StackOverflowError` from about 500–2,000 levels on a cold first call and 6,000–17,000 once warmed up (OpenJDK 21 and 25), while `ujson.read`, Jackson's `readTree` before 2.15 and circe before 0.14.16 accept any nesting (2,000,000 levels from 4 MB) and circe 0.14.16 accepts 4,096 — on a cold JVM even play-json's cap of 1,000 is past the point the walk fails. `StackOverflowError` is not `NonFatal`: `Try`, `case NonFatal(e)` and `recover` do not stop it, and in a `Future` on the global execution context it leaves the future forever incomplete. Thread a depth argument through `EventCauseJsonProtocol.read` and reject the value past a fixed maximum, or rewrite the descent with an explicit stack.
X27 · Collection changed while being enumerated · Collection is structurally changed while it is being enumerated · ×1
  • Collection is structurally changed while it is being enumerated optimus/platform/projects/core/src/main/scala/optimus/graph/OGTraceReader.java:541 — `this.threads` is enumerated directly, and line 542 calls `this.threads.add(…)` inside the loop body — a structural change to a `ArrayList`. The loop's hidden iterator is fail-fast, so its next `next()` throws `ConcurrentModificationException`: every pass that reaches this call ends the loop by exception instead of by running out of elements, and the remaining elements are never seen.
Minor — 113 finding(s)
X4 · Structured logging · Interpolated log message defeats structured logging · ×40
  • Interpolated log message defeats structured logging optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/oci/ImageBuilderDelegate.scala:64 — `warn` at line 64 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/resolvers/WebDependencyResolver.scala:89 — `error` at line 89 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ScopeDefinitionCompiler.scala:339 — `warn` at line 339 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/DiagnosticApp.scala:27 — `info` at line 27 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/buildtool/projects/runconf/src/main/scala/optimus/buildtool/runconf/DiagnosticApp.scala:39 — `info` at line 39 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/ChainedID.scala:135 — `error` at line 135 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.error("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:138 — `debug` at line 138 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:166 — `warn` at line 166 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:247 — `debug` at line 247 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:269 — `debug` at line 269 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:317 — `debug` at line 317 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:332 — `info` at line 332 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:444 — `info` at line 444 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:527 — `debug` at line 527 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:599 — `warn` at line 599 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:610 — `debug` at line 610 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:626 — `debug` at line 626 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:710 — `info` at line 710 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:731 — `debug` at line 731 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:738 — `debug` at line 738 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:760 — `debug` at line 760 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.debug("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:772 — `info` at line 772 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:777 — `info` at line 777 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:799 — `info` at line 799 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.info("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • Interpolated log message defeats structured logging optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:984 — `warn` at line 984 is handed an interpolated string as its message through SLF4J, so the logger receives one finished string — the values in it cannot be queried, filtered or aggregated as fields, every occurrence reads as a different message, and the string is built even when the level is filtered out. Pass a constant pattern and the values beside it instead: `log.warn("Order {} moved to {}", orderId, status)`, which keeps the pattern and its arguments apart on the event for a structured encoder (logstash-logback-encoder, OpenTelemetry), or `log.atInfo().addKeyValue("order_id", orderId).log("order moved")` with SLF4J 2's fluent API. scala-logging's `LazyLogging` logger takes an `s"…"` message apart into that pattern at compile time, so switching to it is also a fix.
  • + 15 more in this group — see findings.md.
X10 · Duplicated predicate · Duplicated predicate · ×25
  • Duplicated predicate optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/PrimarySecondaryIPListPair.java:127 — `!primaryOwners.contains(node) && !secondaryOwners.contains(node)` appears character-identically in 2 files — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/PrimarySecondaryIPListPair.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/PrimarySecondaryListPair.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/Connection.java:568 — `AsyncGlobals.debug && debug && log.isDebugEnabled()` appears character-identically in 2 files — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/Connection.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/SelectorController.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/OutgoingMessageGroup.java:149 — `AsyncGlobals.debug && log.isDebugEnabled()` appears character-identically in 3 files — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/OutgoingMessageGroup.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/OutgoingBufferedData.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/OutgoingByteBuffer.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/thread/lwt/BaseWorker.java:181 — `LWTConstants.enableLogging && log.isDebugEnabled()` appears character-identically in 2 files — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/thread/lwt/BaseWorker.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/thread/lwt/LWTPoolImpl.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java:117 — `Objects.nonNull(cloudKe) && Objects.nonNull(serverConfigKe)` appears character-identically in 3 files — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/ClassVarsZK.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/management/MetaToolModuleBase.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/meta/WeightsZK.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java:705 — `creationTime < 0 && attemptIndex < zkReadAttempts` appears character-identically in 2 files — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/daemon/storage/convergence/management/DHTRingManager.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/meta/RingConfigWatcher.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingEntry.java:470 — `curEntry.getRegion().isContiguousWith(nextEntry.getRegion()) && curEntry.getPrimaryOwnersSet().equals(nextEntry.getPrimaryOwnersSet()) && cu…` appears character-identically in 2 files — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/RingEntry.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/SingleRing.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/platform/projects/entityagent/src/main/java/optimus/junit/CachingJunitRunnerInjector.java:121 — `failedState || loader == null || skipName(className)` appears character-identically in 2 files — optimus/platform/projects/entityagent/src/main/java/optimus/junit/CachingJunitRunnerInjector.java, optimus/platform/projects/entityagent/src/main/java/optimus/junit/OptimusTestWorkerClientInjector.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/DaemonStateZK.java:202 — `ke.getCause() != null && NoNodeException.class.isAssignableFrom(ke.getCause().getClass())` appears character-identically in 3 files — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/DaemonStateZK.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/RingHealthZK.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/meta/RingStateZK.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/DHTKeyEntryBase.java:49 — `lsl == oKey.getLSL() && msl == oKey.getMSL()` appears character-identically in 3 files — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/DHTKeyEntryBase.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/common/SimpleKey.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/MessageGroupKeyEntry.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/SimpleSessionEstablishmentTimeoutController.java:106 — `maxAttempts == o.maxAttempts && attemptRelativeTimeoutMillis == o.attemptRelativeTimeoutMillis && maxRelativeTimeoutMillis == o.maxRelativeT…` appears character-identically in 2 files — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/SimpleSessionEstablishmentTimeoutController.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/net/async/SimpleNewConnectionTimeoutController.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/TimeAndVersionRetentionPolicy.java:86 — `mode == other.mode && minVersions == other.minVersions && timeSpanSeconds == other.timeSpanSeconds` appears character-identically in 2 files — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/TimeAndVersionRetentionPolicy.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/ValidOrTimeAndVersionRetentionPolicy.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/platform/projects/msnet-ssl/src/main/java/msjava/msnet/MSNetSSLSocket.java:154 — `noPreviousMessage && rawBuffer.size() != 0` appears character-identically in 2 files — optimus/platform/projects/msnet-ssl/src/main/java/msjava/msnet/MSNetSSLSocket.java, optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetSSLSocket.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/platform/projects/core/src/main/scala/optimus/graph/cache/NCPolicyComposite.java:213 — `obj == null || getClass() != obj.getClass()` appears character-identically in 2 files — optimus/platform/projects/core/src/main/scala/optimus/graph/cache/NCPolicyComposite.java, optimus/platform/projects/inputs/src/main/java/optimus/platform/inputs/loaders/JavaNodeInputStorage.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoPutForwardMessageGroup.java:99 — `opSize == 1 || compressedValueSize >= dedicatedBufferSizeThreshold` appears character-identically in 2 files — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoPutForwardMessageGroup.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/net/ProtoValueMessageGroup.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/platform/projects/scala_compat/src/main/scala-2.12/optimus/scalacompat/collection/CanEqual.java:31 — `p1.length() == p2.length() && p1.hashCode() == p2.hashCode()` appears character-identically in 2 files — optimus/platform/projects/scala_compat/src/main/scala-2.12/optimus/scalacompat/collection/CanEqual.java, optimus/platform/projects/scala_compat/src/main/scala-2.13/optimus/scalacompat/collection/CanEqual.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/PrimarySecondaryIPListPair.java:80 — `primaryOwners.contains(node) || secondaryOwners.contains(node)` appears character-identically in 2 files — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/PrimarySecondaryIPListPair.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/PrimarySecondaryListPair.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/platform/projects/scala_compat/src/main/scala-2.12/optimus/scalacompat/collection/CanEqual.java:25 — `size1 == -1 || size2 == -1 || size1 == size2` appears character-identically in 2 files — optimus/platform/projects/scala_compat/src/main/scala-2.12/optimus/scalacompat/collection/CanEqual.java, optimus/platform/projects/scala_compat/src/main/scala-2.13/optimus/scalacompat/collection/CanEqual.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/platform/projects/msnet-ssl/src/main/java/msjava/msnet/MSNetSSLSocket.java:202 — `socketState == SSLSocketState.HANDSHAKE_COMPLETED && write.getNumBytesInMessage() == write.getNumBytesProcessed()` appears character-identically in 2 files — optimus/platform/projects/msnet-ssl/src/main/java/msjava/msnet/MSNetSSLSocket.java, optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetSSLSocket.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/platform/projects/msnet-ssl/src/main/java/msjava/msnet/MSNetSSLSocket.java:167 — `socketState == SSLSocketState.READY_FOR_ENCRYPTING && buf.size() != 0` appears character-identically in 2 files — optimus/platform/projects/msnet-ssl/src/main/java/msjava/msnet/MSNetSSLSocket.java, optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetSSLSocket.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/dht/projects/digest/src/main/java/appmw/dht/digest/Blake2bSafe.java:150 — `this.buffer != null && this.buffer.length == Spec.block_bytes` appears character-identically in 2 files — optimus/dht/projects/digest/src/main/java/appmw/dht/digest/Blake2bSafe.java, optimus/dht/projects/digest/src/main/java/appmw/dht/digest/Blake2bUnsafe.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/SingleDHTKeyToKeyMap.java:40 — `this.dhtKey != null && KeyUtil.equal(this.dhtKey, (DHTKey) dhtKey)` appears character-identically in 2 files — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/SingleDHTKeyToKeyMap.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/SingleKeyToDHTKeyMap.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/dht/projects/digest/src/main/java/appmw/dht/digest/Blake2bSafe.java:151 — `this.h != null && this.h.length == 8 && this.t != null && this.t.length == 2 && this.f != null && this.f.length == 2 && this.m != null && th…` appears character-identically in 2 files — optimus/dht/projects/digest/src/main/java/appmw/dht/digest/Blake2bSafe.java, optimus/dht/projects/digest/src/main/java/appmw/dht/digest/Blake2bUnsafe.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/SingleDHTKeyToKeyMap.java:45 — `this.key != null && key.equals(this.key)` appears character-identically in 2 files — optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/SingleDHTKeyToKeyMap.java, optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/collection/SingleKeyToDHTKeyMap.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetProtocolTCPConnection.java:448 — `timeoutScheduler != null && timeoutScheduler.isTimeoutSet()` appears character-identically in 2 files — optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetProtocolTCPConnection.java, optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetTCPConnection.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
AX6 · Interface segregation · Fat interface · ×23
  • Fat interface: KVClient<K> (16 abstract methods) optimus/dht/projects/client3/src/main/java/optimus/dht/client/api/kv/KVClient.java:24 — `KVClient<K>` declares 16 abstract methods under just 12 distinct name(s): `batchContains`, `batchGet`, `batchPut`, `batchRemove`, `contains`, `contains`, `get`, `get`, `getLargeValue`, `put`, `put`, `putLargeValue`, `remove`, `remove`, `removeTransientKeyspace`, `streamingGet`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 12 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
  • Fat interface: MSNetAdminManagerImpl (24 abstract methods) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/admin/MSNetAdminManagerImpl.java:20 — `MSNetAdminManagerImpl` declares 24 abstract methods: `addAdminCommand`, `addAdminCommand`, `addAlias`, `addListener`, `getAddressInfo`, `getAdminCommand`, `getAdminCommandStore`, `getConnectionCount`, `getEntity`, `getInterceptListener`, `handleSubscribeRequest`, `handleTapRequest`, `handleUnsubscribeRequest`, `isEntityRegistered`, `isServerListening`, `listEntities`, `registerEntity`, `removeAdminCommand`, `removeAdminCommands`, `removeListener`, `serverShutdown`, `setAccessDecisionManager`, `setInterceptListener`, `unregisterEntity`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 24 declarations carry 23 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 23 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: MSNetProtocolConnectionConfiguration (62 abstract methods) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/internal/MSNetProtocolConnectionConfiguration.java:23 — `MSNetProtocolConnectionConfiguration` declares 62 abstract methods: `afterPropertiesSet`, `getAnonymousAuthentication`, `getAsyncReading`, `getBackupAddresses`, `getBindAddress`, `getCallbackExecutor`, `getConnectionId`, `getConnectionName`, `getEstablishers`, `getHostPort`, `getKeepAlive`, `getKerberos`, `getKerberosEncryption`, `getLoop`, `getMaxDisconnects`, `getMaxRetries`, `getMaxRetryTime`, `getPlainConnectionConfiguration`, `getProtocol`, `getReceiveBufferSize`, `getRetryFlag`, `getRetryTime`, `getSendBufferSize`, `getSocketFactory`, `getStreamBufferSizeLimit`, `getStreamCallbackExecutor`, `getStreamListenerQueuesize`, `getTapping`, `getTcpNoDelay`, `getWriteListThreshold`, `init`, `isInitialized`, `isSkipHostPortValidation`, `setAnonymousAuthentication`, `setAsyncReading`, `setBackupAddresses`, `setBindAddress`, `setCallbackExecutor`, `setConnectionName`, `setEstablishers`, and 22 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: MSNetConnection (46 abstract methods) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetConnection.java:17 — `MSNetConnection` declares 46 abstract methods: `addListener`, `asyncSend`, `asyncSend`, `close`, `connect`, `connect`, `connectTime`, `disableReading`, `enableReading`, `getAddress`, `getAuthContext`, `getBackupAddress`, `getInfoMessage`, `getLocalAddress`, `getMaxDisconnects`, `getMaxRetries`, `getMaxRetryTime`, `getName`, `getNetLoop`, `getPrimaryAddress`, `getRetryFlag`, `getRetryTime`, `getState`, `getTapping`, `isConnected`, `isEstablished`, `isReadingEnabled`, `removeListener`, `reparent`, `send`, `send`, `setAddress`, `setBackupAddress`, `setMaxDisconnects`, `setMaxRetries`, `setMaxRetryTime`, `setName`, `setPrimaryAddress`, `setRetryFlag`, `setRetryTime`, and 6 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 46 declarations carry 41 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 41 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: MSNetLoopImpl (20 abstract methods) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetLoopImpl.java:16 — `MSNetLoopImpl` declares 20 abstract methods: `addLoopListener`, `callbackAfterDelay`, `callbackAfterDelay`, `callbackAt`, `callbackAt`, `callbackPeriodically`, `callbackPeriodically`, `cancelCallback`, `getContinueLoop`, `getLoopErrorHandler`, `isLooping`, `loop`, `quit`, `registerChannel`, `removeLoopListener`, `setCallbackTag`, `setContinueLoop`, `setLoopErrorHandler`, `unregisterChannel`, `wakeup`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 20 declarations carry 17 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 17 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: MSNetTCPServer (26 abstract methods) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/msnet/MSNetTCPServer.java:20 — `MSNetTCPServer` declares 26 abstract methods: `addEstablisherFactory`, `addListener`, `establisherFactoryIterator`, `getAddress`, `getConnection`, `getName`, `getStateListeners`, `getUserContext`, `getUserContexts`, `hasConnection`, `isListening`, `manageConnection`, `openConnection`, `removeConnection`, `removeEstablisherFactory`, `removeStateListener`, `reparentConnection`, `setAddress`, `setAdminManager`, `setMessageHandler`, `setName`, `setStartupFailurePolicy`, `setStreamHandler`, `start`, `start`, `stop`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 26 declarations carry 25 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 25 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: LeaderElector (18 abstract methods) optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/zkapi/leader/LeaderElector.java:19 — `LeaderElector` declares 18 abstract methods under just 15 distinct name(s): `abdicate`, `close`, `getCandidates`, `getData`, `getLeaderId`, `getLeaders`, `getListener`, `getMaxLeaders`, `isLeader`, `setData`, `setListener`, `start`, `waitForInitialization`, `waitForInitialization`, `waitForLeaderLoss`, `waitForLeaderLoss`, `waitForLeadership`, `waitForLeadership`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 18 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 18 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
  • Fat interface: DHTSession (19 abstract methods) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/client/DHTSession.java:28 — `DHTSession` declares 19 abstract methods under just 14 distinct name(s): `close`, `createNamespace`, `createNamespace`, `deleteNamespace`, `getDefaultGetOptions`, `getDefaultNamespaceOptions`, `getDefaultPutOptions`, `getDefaultWaitOptions`, `getNamespace`, `getNamespaceCreationOptions`, `getServer`, `isServerTraceEnabled`, `openAsyncNamespacePerspective`, `openAsyncNamespacePerspective`, `openAsyncNamespacePerspective`, `openSyncNamespacePerspective`, `openSyncNamespacePerspective`, `openSyncNamespacePerspective`, `recoverNamespace`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 19 separate responsibilities: a caller binds to 14 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 19 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
  • Fat interface: Tracer (21 abstract methods) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/dht/trace/Tracer.java:27 — `Tracer` declares 21 abstract methods: `getStringTraceId`, `issueForwardTraceID`, `onAuthorizationFailure`, `onBothDequeueAndAsyncSendRetrievalResult`, `onBothHandleRetrievalRequest`, `onBothReceiveRequest`, `onForceReap`, `onInternalRetry`, `onKeysReap`, `onLocalEnqueueRetrievalResult`, `onLocalHandleRetrievalRequest`, `onLocalReap`, `onPreambleMismatch`, `onProxyHandleRetrievalResponse`, `onProxyHandleRetrievalResultComplete`, `onProxyHandleRetrievalResultFailed`, `onProxyHandleRetrievalResultIncomplete`, `onQueueLengthInterval`, `onSegmentReap`, `onSegmentRollover`, `setAliasMap`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: TopologyRing (20 abstract methods) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/cloud/toporing/TopologyRing.java:29 — `TopologyRing` declares 20 abstract methods: `clone`, `cloneEmpty`, `containsNode`, `freeze`, `getMemberNodes`, `getNodeByID`, `getNodeClass`, `getNodeRegions`, `getNodeRegionsFiltered`, `getNodeRegionsSorted`, `getOwnedFraction`, `getOwnedRingspace`, `getStoragePolicyName`, `getTotalWeight`, `getWeight`, `numMemberNodes`, `pointOwnedByNode`, `releaseToNode`, `removeEntry`, `simplify`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: Stopwatch (19 abstract methods) optimus/silverking/projects/silverking/src/main/java/com/ms/silverking/time/Stopwatch.java:31 — `Stopwatch` declares 19 abstract methods: `getElapsedMillis`, `getElapsedMillisLong`, `getElapsedNanos`, `getElapsedSeconds`, `getElapsedSecondsBD`, `getName`, `getSplitMillis`, `getSplitMillisLong`, `getSplitNanos`, `getSplitSeconds`, `getSplitSecondsBD`, `getState`, `isRunning`, `isStopped`, `reset`, `start`, `stop`, `toStringElapsed`, `toStringSplit`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: GraphMBean (40 abstract members) optimus/platform/projects/core/src/main/scala/optimus/graph/GraphMBean.scala:61 — `GraphMBean` declares 40 abstract members: `getConsoleFlag`, `clearCache`, `go`, `profilerResetAll`, `setFlag`, `resetWaits`, `getNativeAllocation`, `getNativeWatermark`, `setNativeWatermark`, `clearAllCaches`, `clearAllCachesWithLocal`, `getSSRoots`, `resetProfileData`, `getProfileData`, `getLiveReaderTaskInfo`, `collectProfile`, `getCache`, `profileCacheMemory`, `profileCacheMemory`, `getSchedulerProfileEntry`, `getStallTimes`, `getMemory`, `saveProfile`, `getInvalidates`, `getTrackingScenarioInfo`, `getWaits`, `showGraphConsole`, `setTraceMode`, `getTraceMode`, `getTrace`, `getSummaryTable`, `gc`, `clearCacheAndTracking`, `resetSStackRoots`, `getFullSchedulerState`, `infoDump`, `asyncProfilerCommand`, `asyncProfilerStart`, `asyncProfilerStop`, `asyncProfilerStatus`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. Those 40 declarations carry 39 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 39 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: EntityResolver (23 abstract members) optimus/platform/projects/core/src/main/scala/optimus/platform/dal/EntityResolver.scala:36 — `EntityResolver` declares 23 abstract members: `findEntity`, `findEntity$queued`, `findEntity$newNode`, `findEntityOption`, `findEntityOption$queued`, `findEntityOption$newNode`, `findByReference`, `findByReference$queued`, `findByReference$newNode`, `findByIndex`, `findByIndex$queued`, `findByIndex$newNode`, `findByIndexInRange`, `findByIndexInRange$queued`, `findByIndexInRange$newNode`, `findByIndexWithEref`, `findByIndexWithEref$queued`, `findByIndexWithEref$newNode`, `enumerateKeysWithRtt`, `enumerateKeysWithRtt$queued`, `enumerateKeysWithRtt$newNode`, `translateMarkers`, `equivalentTo`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: PickledPropertiesApi[R] (22 abstract members) optimus/platform/projects/core/src/main/scala/optimus/platform/pickling/PickledProperties.scala:28 — `PickledPropertiesApi[R]` declares 22 abstract members: `isEmpty`, `hashCode`, `knownSize`, `size`, `contains`, `keys`, `values`, `iterator`, `get`, `apply`, `mapProps`, `map`, `removeAll`, `++`, `remove`, `+`, `+`, `getOrElse`, `isDefinedAt`, `matches`, `keySet`, `asMap`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. Those 22 declarations carry 21 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 21 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: RuntimeConfiguration (18 abstract members) optimus/platform/projects/core_config/src/main/scala/optimus/config/RuntimeConfiguration.scala:41 — `RuntimeConfiguration` declares 18 abstract members: `env`, `rootID`, `mode`, `instance`, `specificPropertyMap`, `getProperties`, `getAllProperties`, `getString`, `getInt`, `getBoolean`, `getInstant`, `getStringList`, `getByteVector`, `get`, `getAttributes`, `getStringListWithAttributes`, `withOverride`, `withOverrides`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: TraceableAsyncOp[K, V] (17 abstract members) optimus/platform/projects/dal_core/src/main/scala/optimus/dal/silverking/client/TraceableNamespacePerspective.scala:35 — `TraceableAsyncOp[K, V]` declares 17 abstract members under just 5 distinct name(s): `retrieveWithTrace`, `getWithTrace`, `getWithTrace`, `getWithTrace`, `getWithTrace`, `putWithTrace`, `putWithTrace`, `putWithTrace`, `putWithTrace`, `invalidateWithTrace`, `invalidateWithTrace`, `invalidateWithTrace`, `invalidateWithTrace`, `waitForWithTrace`, `waitForWithTrace`, `waitForWithTrace`, `waitForWithTrace`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 5 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
  • Fat interface: TraceableSyncOp[K, V] (19 abstract members) optimus/platform/projects/dal_core/src/main/scala/optimus/dal/silverking/client/TraceableNamespacePerspective.scala:61 — `TraceableSyncOp[K, V]` declares 19 abstract members under just 5 distinct name(s): `retrieveWithTrace`, `retrieveWithTrace`, `retrieveWithTrace`, `getWithTrace`, `getWithTrace`, `getWithTrace`, `getWithTrace`, `putWithTrace`, `putWithTrace`, `putWithTrace`, `putWithTrace`, `invalidateWithTrace`, `invalidateWithTrace`, `invalidateWithTrace`, `invalidateWithTrace`, `waitForWithTrace`, `waitForWithTrace`, `waitForWithTrace`, `waitForWithTrace`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 19 separate responsibilities: a caller binds to 5 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 19 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
  • Fat interface: BitemporalSpace[T] (20 abstract members) optimus/platform/projects/dal_core/src/main/scala/optimus/platform/bitemporal/BitemporalSpace.scala:21 — `BitemporalSpace[T]` declares 20 abstract members: `latestTxTime`, `all`, `onTxTime`, `beforeTxTime`, `onValidTime`, `onValidInterval`, `adjacentToValidTime`, `at`, `updateInterval`, `insertPoint`, `correctPoint`, `invalidatePoint`, `revertPoint`, `filterCurrentTS`, `map`, `updateMultiple`, `updateIntervals`, `performRawActions`, `execute`, `maxTimeSliceCount`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: ZkUtilsProvider (22 abstract members) optimus/platform/projects/dal_environment/src/main/scala/optimus/platform/runtime/ZkUtilsProvider.scala:24 — `ZkUtilsProvider` declares 22 abstract members: `getZkEnv`, `getRootContext`, `getRootContext`, `getRootContext`, `getRootContext`, `getRootContextAndEnv`, `getRootContextAndEnv`, `getRootContextForUriAuthority`, `getContextForConfig`, `devContext`, `devContextNoKerberos`, `qaContext`, `qaContextNoKerberos`, `prodContext`, `prodContextNoKerberos`, `prodContextWithoutGuard`, `qaContextWithoutGuard`, `parseInstant`, `parseKnownZkEnv`, `isCloud`, `isEnv`, `isTestMode`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. Those 22 declarations carry 18 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 18 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: ClassInfo (26 abstract members) optimus/platform/projects/platform/src/main/scala/optimus/platform/util/dalschema/ClassInfo.scala:39 — `ClassInfo` declares 26 abstract members: `isTrait`, `isAbstract`, `isObject`, `isEvent`, `isEmbeddable`, `isEntity`, `isMeta`, `isEnumeration`, `isJavaEnumeration`, `isOption`, `isKnowable`, `isCollection`, `isMap`, `isKnownNonStorable`, `localName`, `directParents`, `parents`, `selfAndParents`, `children`, `directChildren`, `fields`, `fullName`, `className`, `typeArgs`, `classSymbol`, `piiElements`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: QueryProvider (62 abstract members) optimus/platform/projects/priql/src/main/scala/optimus/platform/QueryProvider.scala:30 — `QueryProvider` declares 62 abstract members: `permitTableScan`, `entitledOnly`, `map`, `flatMap`, `filter`, `groupBy`, `groupBy`, `aggregateBy`, `aggregateBy`, `aggregateByUntyped`, `mapValues`, `innerJoin`, `leftOuterJoin`, `rightOuterJoin`, `fullOuterJoin`, `on`, `on`, `onNatural`, `withLeftDefault`, `withRightDefault`, `withLeftDefaultNatural`, `withRightDefaultNatural`, `union`, `merge`, `difference`, `untype`, `extend`, `shapeTo`, `extendTyped`, `extendTypedValue`, `replace`, `replaceValue`, `extendTypedOrReplaceValue`, `sortBy`, `arrange`, `distinct`, `reduce`, `foldLeft`, `aggregate`, `aggregate`, and 22 more. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. Those 62 declarations carry 51 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 51 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: Operator[T] (17 abstract members) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/RelationColumnType.scala:829 — `Operator[T]` declares 17 abstract members: `ltArray`, `ltSingle`, `gtArray`, `gtSingle`, `eqArray`, `eqSingle`, `plusArray`, `plusSingle`, `minusArray`, `minusSingle`, `mulArray`, `mulSingle`, `divArray`, `divSingle`, `moduloArray`, `moduloSingle`, `generateNewColumnValues`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: FieldReader (22 abstract members) optimus/platform/projects/priql/src/main/scala/optimus/platform/relational/data/FieldReader.scala:17 — `FieldReader` declares 22 abstract members: `readValue`, `readOptionValue`, `readBoolean`, `readOptionBoolean`, `readByte`, `readOptionByte`, `readChar`, `readOptionChar`, `readShort`, `readOptionShort`, `readInt`, `readOptionInt`, `readLong`, `readOptionLong`, `readFloat`, `readOptionFloat`, `readDouble`, `readOptionDouble`, `readString`, `readOptionString`, `isNone`, `pickledInputStream`. Counted over its ABSTRACT members — a `def` with no body or a `val`/`var` with no initializer, once per signature; concrete members, private and protected members, and members of a companion `object` are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
X7 · Silent fallback defaults · Silent fallback default in catch · ×7
  • Silent fallback default in catch optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/bsp/BSPTraceListener.scala:294 — `uri` swallows every exception into `"file://no-file"` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch case or in the Scaladoc, and the row stops firing.
  • Silent fallback default in catch optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/compilers/zinc/ZincCompilerFactory.scala:121 — `readScalaVersion` swallows every exception into `"unknown"` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch case or in the Scaladoc, and the row stops firing.
  • Silent fallback default in catch optimus/platform/projects/core/src/main/scala/optimus/graph/GraphEvents.scala:40 — `getEnv` swallows every exception into `"N/A"` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch case or in the Scaladoc, and the row stops firing.
  • Silent fallback default in catch optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/AsyncProfilerIntegration.scala:506 — `internalStats` swallows every exception into `Map.empty` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch case or in the Scaladoc, and the row stops firing.
  • Silent fallback default in catch optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/ap/StackAnalysis.scala:1262 — `getSID` (in `buildStackTrees`) swallows every exception into `0L` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch case or in the Scaladoc, and the row stops firing.
  • Silent fallback default in catch optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/zkapi/internal/ZkaResourceContext.java:387 — `getSessionId` swallows every exception into `return -1` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the Javadoc, and the row stops firing.
  • Silent fallback default in catch optimus/platform/projects/oss-utils/shadow/msjava/src/main/resources/msjava/zkapi/ZkaPathContext.java:427 — `getSessionId` swallows every exception into `return 0` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the Javadoc, and the row stops firing.
D19 · Documentation Quality · Documentation · ×4
  • Documentation: no project overview — The root README begins with a welcome banner and links to contributing guidelines but does not state what Optimus Cirrus is or what it does (e.g. whether it is the OBT tool, an infrastructure set, or something else). State the project's purpose in one sentence above the welcome banner so readers can find it without scanning.
  • Documentation: no installation or build instructions — The root README links to CONTRIBUTING.md but provides no installation/build/dependency instructions for the repository. Add a short install section (e.g. 'Clone, add the OBT dependency, and run') under the welcome banner.
  • Documentation: no usage examples — The root README describes what the project does but contains no shell or command-line example showing how to run it. Add a one-command usage block (e.g. 'cargo build && cargo run') under the welcome banner.
  • Documentation: no contributor guidance — The README links to CONTRIBUTING.md but does not state what the repository expects of contributors or how to get started. Add a short contributing section (e.g. 'How to run tests, add a new module, and submit a PR') under the welcome banner.
X23 · Unguarded diagnostic materialisation · Diagnostic log message is built whether or not it is wanted · ×4
  • Diagnostic log message is built whether or not it is wanted optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/files/InstallPathBuilder.scala:410 — `debug` at line 410 is called with an argument built by `parts.map(_.toString).mkString("…")` (line 410), whose cost grows with the collection it walks. Scala evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: the logger takes a built `String` (SLF4J, Akka/Pekko `LoggingAdapter`, `context.log`), and there is no `isDebugEnabled`/`isTraceEnabled` test and no debug flag.
  • Diagnostic log message is built whether or not it is wanted optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/files/InstallPathBuilder.scala:419 — `debug` at line 419 is called with an argument built by `parts.mkString("…")` (line 420), whose cost grows with the collection it walks. Scala evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: the logger takes a built `String` (SLF4J, Akka/Pekko `LoggingAdapter`, `context.log`), and there is no `isDebugEnabled`/`isTraceEnabled` test and no debug flag.
  • Diagnostic log message is built whether or not it is wanted optimus/platform/projects/breadcrumbs/src/main/scala/optimus/breadcrumbs/Breadcrumbs.scala:610 — `debug` at line 610 is called with an argument built by `Thread.currentThread.getStackTrace.toSeq.mkString("…")` (line 610), whose cost grows with the collection it walks. Scala evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: the logger takes a built `String` (SLF4J, Akka/Pekko `LoggingAdapter`, `context.log`), and there is no `isDebugEnabled`/`isTraceEnabled` test and no debug flag.
  • Diagnostic log message is built whether or not it is wanted optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/sampling/SamplingProfiler.scala:503 — `debug` at line 503 is called with an argument built by `destinations.mkString("…")` (line 503), whose cost grows with the collection it walks. Scala evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because debug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: the logger takes a built `String` (SLF4J, Akka/Pekko `LoggingAdapter`, `context.log`), and there is no `isDebugEnabled`/`isTraceEnabled` test and no debug flag.
IC1 · Incompleteness & stubs · Empty method body · ×3
  • Empty method body optimus/platform/projects/core/src/main/scala/optimus/graph/diagnostics/GraphDiagnostics.scala:51 — `await` has an empty body — confirm it's an intentional no-op and not an unfinished method.
  • Empty method body optimus/platform/projects/instrumentation/src/main/scala/optimus/graph/diagnostics/sampling/SamplingProfiler.scala:590 — `ensureLoadedIfEnabled` has an empty body — confirm it's an intentional no-op and not an unfinished method.
  • Empty method body optimus/platform/projects/platform/src/main/scala/optimus/platform/OptimusApp.scala:683 — `setup` has an empty body — confirm it's an intentional no-op and not an unfinished method.
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1
  • Projects may be oversized for their cohesion — 1 of 1 project(s) overshoot their size bounds, lowering Project Cohesion to 0.0/10. The most over is `(repository root)` (529281 LoC, 11599 module-visible types across 705 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation · No architecture diagram/doc · ×1
  • No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
M3 · Folder & project structure · No src/ separation · ×1
  • No src/ separation — Production code isn't grouped under a src/ folder — it all sits under optimus/, so the conventional src/ boundary between the product and its tooling isn't drawn.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST — No static application security testing detected. For this repository's stack, add scalafix or scapegoat (or `semgrep --config=auto`, which runs on any language) — this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
X5 · Nullable reference types · Scala's null is not held to the type system everywhere · ×1
  • Scala's null is not held to the type system everywhere — No build over this repository's 2252 Scala product file(s) passes `-Yexplicit-nulls`, enables WartRemover's `Null` wart or runs Scalafix's `DisableSyntax.noNulls`, so every reference type admits null and nothing reports a `null` written into the code or returned from a Java API — the first one to reach a method call is a `NullPointerException`. `Option` by convention is a habit no tool here holds the code to.
X7 · Silent fallback defaults · Silent fallback default on parse failure · ×1
  • Silent fallback default on parse failure optimus/stratosphere/bootstrap/src/main/java/optimus/stratosphere/bootstrap/config/StratosphereChannelsConfig.java:131 — `loadAutoIncludeMappings` returns `0` when `NumberFormatException` is thrown, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the Javadoc, and the row stops firing.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-89755b22972c44d98c2ea44abb6096d7/history.json --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-89755b22972c44d98c2ea44abb6096d7/tree.json --exit-code 0 --source .0artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/watchdog-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off .17artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesnone (no readable dependency manifest)—none (no readable dependency manifest): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).0—
D31 · IaC & Container Securitytrivy—trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.0—
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 31 file(s) — `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/builders/reporter/HtmlReporter.scala`, `optimus/buildtool/projects/app/src/main/scala/optimus/buildtool/trace/ObtTracer.scala`, `optimus/buildtool/projects/format/src/main/scala/optimus/buildtool/format/ExtensionConfigurationCompiler.scala`, `optimus/platform/projects/core/src/main/scala/optimus/config/scoped/json/JsonScopedConfiguration.scala`, `optimus/platform/projects/core/src/main/scala/optimus/core/CoreAPI.scala`, … (+26 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D36 · Supply-chain Provenance & Signingprovenance—provenance: not applicable — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .circleci, .buildkite, .woodpecker, .teamcity, .gitlab-ci.yml, .travis.yml, bitbucket-pipelines.yml, .drone.yml, .cirrus.yml, .woodpecker.yml, appveyor.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, .azuredevops/, Jenkinsfile); there is no build to attest provenance for.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciesnone (no readable dependency manifest)—none (no readable dependency manifest): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).0—

Run 01a15ebf-5f57-7592-8d21-951e46fa80e0 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Issues: 7 · Warnings: 2185 · Recommendations: 113 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 21-10-2026 @ 13:56 UTC.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md