{"$schema":"https://json.schemastore.org/sarif-2.1.0.json","version":"2.1.0","runs":[{"tool":{"driver":{"name":"codehealth","informationUri":"https://codehealth.canine.dev","rules":[{"id":"D1","name":"Cyclomatic Complexity","shortDescription":{"text":"Cyclomatic Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D1"},{"id":"D2","name":"Cognitive Complexity","shortDescription":{"text":"Cognitive Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D2"},{"id":"D3","name":"God Classes","shortDescription":{"text":"God Classes"},"helpUri":"https://codehealth.canine.dev/dimensions/D3"},{"id":"D4","name":"Code Duplication","shortDescription":{"text":"Code Duplication"},"helpUri":"https://codehealth.canine.dev/dimensions/D4"},{"id":"D5","name":"Coupling","shortDescription":{"text":"Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D5"},{"id":"D6","name":"Cohesion (LCOM4)","shortDescription":{"text":"Cohesion (LCOM4)"},"helpUri":"https://codehealth.canine.dev/dimensions/D6"},{"id":"D9","name":"Test Distribution","shortDescription":{"text":"Test Distribution"},"helpUri":"https://codehealth.canine.dev/dimensions/D9"},{"id":"D11","name":"Test Reliability","shortDescription":{"text":"Test Reliability"},"helpUri":"https://codehealth.canine.dev/dimensions/D11"},{"id":"D13","name":"Secret Scanning","shortDescription":{"text":"Secret Scanning"},"helpUri":"https://codehealth.canine.dev/dimensions/D13","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"]}},{"id":"D15","name":"Churn \u00D7 Complexity Hotspots","shortDescription":{"text":"Churn \u00D7 Complexity Hotspots"},"helpUri":"https://codehealth.canine.dev/dimensions/D15"},{"id":"D17","name":"Explicit Debt","shortDescription":{"text":"Explicit Debt"},"helpUri":"https://codehealth.canine.dev/dimensions/D17"},{"id":"D20","name":"ADR Quality","shortDescription":{"text":"ADR Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D20"},{"id":"D21","name":"Naming Consistency","shortDescription":{"text":"Naming Consistency"},"helpUri":"https://codehealth.canine.dev/dimensions/D21"},{"id":"D22","name":"Internal API Consistency","shortDescription":{"text":"Internal API Consistency"},"helpUri":"https://codehealth.canine.dev/dimensions/D22"},{"id":"D26","name":"Project Cohesion","shortDescription":{"text":"Project Cohesion"},"helpUri":"https://codehealth.canine.dev/dimensions/D26"},{"id":"D28","name":"Secrets (history)","shortDescription":{"text":"Secrets (history)"},"helpUri":"https://codehealth.canine.dev/dimensions/D28","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"]}},{"id":"D29","name":"Static Analysis (SAST)","shortDescription":{"text":"Static Analysis (SAST)"},"helpUri":"https://codehealth.canine.dev/dimensions/D29","relationships":[{"target":{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-89","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-94","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-77","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-79","CWE-89","CWE-78","CWE-94","CWE-77"]}},{"id":"D30","name":"Dependency Vulnerabilities","shortDescription":{"text":"Dependency Vulnerabilities"},"helpUri":"https://codehealth.canine.dev/dimensions/D30","relationships":[{"target":{"id":"CWE-1395","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-937","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-1395","CWE-937"]}},{"id":"D34","name":"Knowledge Freshness","shortDescription":{"text":"Knowledge Freshness"},"helpUri":"https://codehealth.canine.dev/dimensions/D34"},{"id":"D35","name":"Change Coupling","shortDescription":{"text":"Change Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D35"},{"id":"D36","name":"Supply-chain Provenance \u0026 Signing","shortDescription":{"text":"Supply-chain Provenance \u0026 Signing"},"helpUri":"https://codehealth.canine.dev/dimensions/D36","relationships":[{"target":{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-494","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-1357","CWE-494"]}},{"id":"D43","name":"Malicious Dependencies","shortDescription":{"text":"Malicious Dependencies"},"helpUri":"https://codehealth.canine.dev/dimensions/D43","relationships":[{"target":{"id":"CWE-506","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-506"]}},{"id":"AX10","name":"Code composition","shortDescription":{"text":"Code composition"},"helpUri":"https://codehealth.canine.dev/dimensions/AX10"},{"id":"AX3","name":"Project dependency cycles","shortDescription":{"text":"Project dependency cycles"},"helpUri":"https://codehealth.canine.dev/dimensions/AX3"},{"id":"AX4","name":"Dependency direction","shortDescription":{"text":"Dependency direction"},"helpUri":"https://codehealth.canine.dev/dimensions/AX4"},{"id":"AX9","name":"CQS / query purity","shortDescription":{"text":"CQS / query purity"},"helpUri":"https://codehealth.canine.dev/dimensions/AX9"},{"id":"AXB1","name":"Runtime evidence locked \u2014 no reproducible boot","shortDescription":{"text":"Runtime evidence locked \u2014 no reproducible boot"},"helpUri":"https://codehealth.canine.dev/dimensions/AXB1"},{"id":"M1","name":"Documentation (README)","shortDescription":{"text":"Documentation (README)"},"helpUri":"https://codehealth.canine.dev/dimensions/M1"},{"id":"M2","name":"Architecture documentation","shortDescription":{"text":"Architecture documentation"},"helpUri":"https://codehealth.canine.dev/dimensions/M2"},{"id":"M3","name":"Folder \u0026 project structure","shortDescription":{"text":"Folder \u0026 project structure"},"helpUri":"https://codehealth.canine.dev/dimensions/M3"},{"id":"M4","name":"Documentation accuracy","shortDescription":{"text":"Documentation accuracy"},"helpUri":"https://codehealth.canine.dev/dimensions/M4"},{"id":"P1","name":"CI/CD gates","shortDescription":{"text":"CI/CD gates"},"helpUri":"https://codehealth.canine.dev/dimensions/P1"},{"id":"P10","name":"Library API \u0026 versioning","shortDescription":{"text":"Library API \u0026 versioning"},"helpUri":"https://codehealth.canine.dev/dimensions/P10"},{"id":"P12","name":"CI test-gate honesty","shortDescription":{"text":"CI test-gate honesty"},"helpUri":"https://codehealth.canine.dev/dimensions/P12"},{"id":"P2","name":"Observability","shortDescription":{"text":"Observability"},"helpUri":"https://codehealth.canine.dev/dimensions/P2"},{"id":"P3","name":"Security \u0026 performance tooling","shortDescription":{"text":"Security \u0026 performance tooling"},"helpUri":"https://codehealth.canine.dev/dimensions/P3"},{"id":"P4","name":"Deployment \u0026 Rollback","shortDescription":{"text":"Deployment \u0026 Rollback"},"helpUri":"https://codehealth.canine.dev/dimensions/P4"},{"id":"P6","name":"Release Hygiene","shortDescription":{"text":"Release Hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/P6"},{"id":"PF3","name":"Async \u0026 latency hygiene","shortDescription":{"text":"Async \u0026 latency hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/PF3"},{"id":"X10","name":"Duplicated predicate","shortDescription":{"text":"Duplicated predicate"},"helpUri":"https://codehealth.canine.dev/dimensions/X10"},{"id":"X32","name":"Type resolved by simple name across every loaded assembly","shortDescription":{"text":"Type resolved by simple name across every loaded assembly"},"helpUri":"https://codehealth.canine.dev/dimensions/X32"},{"id":"X6","name":"Hand-rolled structured-format parsing","shortDescription":{"text":"Hand-rolled structured-format parsing"},"helpUri":"https://codehealth.canine.dev/dimensions/X6"},{"id":"X7","name":"Silent fallback defaults","shortDescription":{"text":"Silent fallback defaults"},"helpUri":"https://codehealth.canine.dev/dimensions/X7"},{"id":"X9","name":"Subsumed condition operand","shortDescription":{"text":"Subsumed condition operand"},"helpUri":"https://codehealth.canine.dev/dimensions/X9"}]}},"results":[{"ruleId":"D1","level":"warning","message":{"text":"samply::windows::etw_gecko::process_trace (cyclomatic 72): samply::windows::etw_gecko::process_trace has cyclomatic complexity 72 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_gecko.rs"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b8c7242cc694e38ac9e67a64636cabb4d6ac897250c575dcf7040ccd56820a1"}},{"ruleId":"D1","level":"warning","message":{"text":"samply::windows::coreclr::handle_coreclr_event (cyclomatic 37): samply::windows::coreclr::handle_coreclr_event has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/coreclr.rs"},"region":{"startLine":353}}}],"partialFingerprints":{"codehealthFindingId/v1":"265e6129edfca1e7e7354541964cf95b468b99ee9cc5c7a3aa62649fe18612c3"}},{"ruleId":"D1","level":"warning","message":{"text":"FileResolver::get_candidate_paths_for_debug_file (cyclomatic 37): FileResolver::get_candidate_paths_for_debug_file has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/file_resolver.rs"},"region":{"startLine":481}}}],"partialFingerprints":{"codehealthFindingId/v1":"7cae26ea8ac0d5a510677a97d30fdc728a775589469083425f4c877e58ae1675"}},{"ruleId":"D1","level":"warning","message":{"text":"samply::import::perf::convert_impl (cyclomatic 34): samply::import::perf::convert_impl has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/import/perf.rs"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"49d624b814faa03b211e91e80fe2de4733e7e3709a4cfc6f5375072d8ec0884a"}},{"ruleId":"D1","level":"warning","message":{"text":"etw_reader::write_property (cyclomatic 32): etw_reader::write_property has cyclomatic complexity 32 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":337}}}],"partialFingerprints":{"codehealthFindingId/v1":"b799bafc38aa0f5e4443884a1c4887f558094988ad1a272576e9bd05ac20d902"}},{"ruleId":"D1","level":"warning","message":{"text":"samply::windows::etw_reader::write_property (cyclomatic 32): samply::windows::etw_reader::write_property has cyclomatic complexity 32 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/mod.rs"},"region":{"startLine":337}}}],"partialFingerprints":{"codehealthFindingId/v1":"b087ed680177cf8e2141be481f0f2a24cef458d587484a55633b621c151705bf"}},{"ruleId":"D1","level":"warning","message":{"text":"samply::linux::profiler::run_profiler (cyclomatic 30): samply::linux::profiler::run_profiler has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux/profiler.rs"},"region":{"startLine":530}}}],"partialFingerprints":{"codehealthFindingId/v1":"b5e0d1db895c7263c1b53396999fb17d5ec38bcb12cbf058af92f141630b6f0c"}},{"ruleId":"D1","level":"warning","message":{"text":"wholesym_addr2line::main (cyclomatic 28): wholesym_addr2line::main has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym-addr2line/src/main.rs"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"41b2b837191afec85739af0da408907cd91285a322d6de009771c9ebb8026256"}},{"ruleId":"D1","level":"warning","message":{"text":"Converter::add_module_to_process (cyclomatic 24): Converter::add_module_to_process has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":1317}}}],"partialFingerprints":{"codehealthFindingId/v1":"2298f7b4c74c7792c22f3252c9cf14aae76fabb9ed95d86c3f7869da04005677"}},{"ruleId":"D1","level":"warning","message":{"text":"samply::mac::profiler::run (cyclomatic 21): samply::mac::profiler::run has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/profiler.rs"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"c13538d5da4597202ab5f2bd281b6f720648c1e480a2e7c2c35f578028463a45"}},{"ruleId":"D1","level":"warning","message":{"text":"Sampler::run (cyclomatic 20): Sampler::run has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/sampler.rs"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"56681cc94d2d835dd92c1da4e70cb4377d3857b4f5e9a80733985e74df34af39"}},{"ruleId":"D1","level":"warning","message":{"text":"PerfBuilder::open (cyclomatic 18): PerfBuilder::open has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux/perf_event.rs"},"region":{"startLine":230}}}],"partialFingerprints":{"codehealthFindingId/v1":"2ccf510c78d72dedbcaf4cf7cc44135b12636f6b27dfe349fe88ff230b844bd9"}},{"ruleId":"D1","level":"warning","message":{"text":"samply::linux::profiler::run (cyclomatic 18): samply::linux::profiler::run has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux/profiler.rs"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"eaf1d8a608bed1fb18ecbcb4ce994ce323632741052d04345a7008f39b0384d9"}},{"ruleId":"D1","level":"warning","message":{"text":"Converter::get_sample_stack (cyclomatic 17): Converter::get_sample_stack has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":616}}}],"partialFingerprints":{"codehealthFindingId/v1":"4762b84106cd093fcbccb01ea2cf51d905b03923959795cc3e892346fa5e1892"}},{"ruleId":"D1","level":"warning","message":{"text":"Parser::find_property_size (cyclomatic 16): Parser::find_property_size has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":175}}}],"partialFingerprints":{"codehealthFindingId/v1":"0d349ecfaf413c89cdee277f7fb7d15f242837b0e1e12fbb9b0511b20c9205d5"}},{"ruleId":"D1","level":"warning","message":{"text":"Parser::find_property_size (cyclomatic 16): Parser::find_property_size has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/parser.rs"},"region":{"startLine":175}}}],"partialFingerprints":{"codehealthFindingId/v1":"cbe828244d6ed9966cf293fe37913bbcaa9aee1fad4b302e81c223e18fbfe09d"}},{"ruleId":"D1","level":"warning","message":{"text":"samply::linux::profiler::init_profiler (cyclomatic 16): samply::linux::profiler::init_profiler has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux/profiler.rs"},"region":{"startLine":370}}}],"partialFingerprints":{"codehealthFindingId/v1":"61e8932157d7b38e6eddecd628faa93993436d8755ab6fff8127ffb35463e0fa"}},{"ruleId":"D1","level":"warning","message":{"text":"SymbolList::new (cyclomatic 16): SymbolList::new has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/symbol_map_object.rs"},"region":{"startLine":194}}}],"partialFingerprints":{"codehealthFindingId/v1":"dbb800eb65b4d7da42e17df082d578f8f847834f4480a1244da1058a8ad885ea"}},{"ruleId":"D2","level":"warning","message":{"text":"wholesym_addr2line::main (cognitive 99): wholesym_addr2line::main has cognitive complexity 99 (threshold 15). Drivers by points: if/else 33 (91 pts), loops 2 (6 pts), boolean chains 2 (nesting depth added 62). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym-addr2line/src/main.rs"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd146c44264935e58aeb6e15dc9f5e415cf1a6012d7302203763ee0ea1aeeba8"}},{"ruleId":"D2","level":"warning","message":{"text":"samply::windows::etw_gecko::process_trace (cognitive 93): samply::windows::etw_gecko::process_trace has cognitive complexity 93 (threshold 15). Drivers by points: if/else 43 (87 pts), loops 1 (3 pts), match/switch 2 (3 pts) (nesting depth added 47). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_gecko.rs"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"265cf3c7f511f4ba1cfcbbdcf654c93df3576ea5be843dbcd588545c25779e08"}},{"ruleId":"D2","level":"warning","message":{"text":"FileResolver::get_candidate_paths_for_debug_file (cognitive 66): FileResolver::get_candidate_paths_for_debug_file has cognitive complexity 66 (threshold 15). Drivers by points: if/else 28 (52 pts), loops 4 (10 pts), boolean chains 4 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/file_resolver.rs"},"region":{"startLine":481}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4ddb08002b58c638a4095e773a5bab285cf6c1bb47d5b9a11da0116c3ee7cba"}},{"ruleId":"D2","level":"warning","message":{"text":"samply::import::perf::convert_impl (cognitive 57): samply::import::perf::convert_impl has cognitive complexity 57 (threshold 15). Drivers by points: if/else 21 (40 pts), match/switch 5 (13 pts), boolean chains 2, loops 2 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/import/perf.rs"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"57e7555aadc07b05b764c1346965795707906fd17365290bcb0f6bbe08c47a5c"}},{"ruleId":"D2","level":"warning","message":{"text":"samply::windows::coreclr::handle_coreclr_event (cognitive 45): samply::windows::coreclr::handle_coreclr_event has cognitive complexity 45 (threshold 15). Drivers by points: if/else 16 (38 pts), match/switch 4 (6 pts), boolean chains 1 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/coreclr.rs"},"region":{"startLine":353}}}],"partialFingerprints":{"codehealthFindingId/v1":"74f835057152404aeace5f315144218296ce3a429d4e7af3805368c205e674b4"}},{"ruleId":"D2","level":"warning","message":{"text":"Converter::add_module_to_process (cognitive 42): Converter::add_module_to_process has cognitive complexity 42 (threshold 15). Drivers by points: if/else 20 (34 pts), match/switch 4 (7 pts), boolean chains 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":1317}}}],"partialFingerprints":{"codehealthFindingId/v1":"c6c910ffd6ae9a247cc8fd31372e9fc57a9c6df761a08d52ff6f59b805873a9d"}},{"ruleId":"D2","level":"warning","message":{"text":"Sampler::run (cognitive 42): Sampler::run has cognitive complexity 42 (threshold 15). Drivers by points: if/else 15 (31 pts), loops 5 (7 pts), match/switch 2 (4 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/sampler.rs"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"bad66005581f7498c19d19a10b8064ca96eff5208d84d60e9b807b20996b1a50"}},{"ruleId":"D2","level":"warning","message":{"text":"samply::linux::profiler::run_profiler (cognitive 38): samply::linux::profiler::run_profiler has cognitive complexity 38 (threshold 15). Drivers by points: if/else 13 (23 pts), match/switch 6 (12 pts), boolean chains 2, loops 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux/profiler.rs"},"region":{"startLine":530}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f96af516f2f643946d8c46114f43deeac3ba574eabf0618dd6566e429a7a3e2"}},{"ruleId":"D2","level":"warning","message":{"text":"etw_reader::write_property (cognitive 37): etw_reader::write_property has cognitive complexity 37 (threshold 15). Drivers by points: if/else 14 (25 pts), match/switch 4 (9 pts), loops 1 (3 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":337}}}],"partialFingerprints":{"codehealthFindingId/v1":"27a1ada2cb039fd7daeecfc4162dbe921108e671c408bf49e869ccc9a4e5d75f"}},{"ruleId":"D2","level":"warning","message":{"text":"samply::windows::etw_reader::write_property (cognitive 37): samply::windows::etw_reader::write_property has cognitive complexity 37 (threshold 15). Drivers by points: if/else 14 (25 pts), match/switch 4 (9 pts), loops 1 (3 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/mod.rs"},"region":{"startLine":337}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c06425b939ae5aa55546e1c7e32437c789f705a41e0ce726b8253a9d0f1483f"}},{"ruleId":"D2","level":"warning","message":{"text":"samply::mac::profiler::run (cognitive 37): samply::mac::profiler::run has cognitive complexity 37 (threshold 15). Drivers by points: if/else 8 (23 pts), match/switch 6 (13 pts), loops 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/profiler.rs"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c02109f48ebe0081b4409ec25658bf9e013780ad4345a642df01ac7acb9c916"}},{"ruleId":"D2","level":"warning","message":{"text":"samply::linux::profiler::init_profiler (cognitive 31): samply::linux::profiler::init_profiler has cognitive complexity 31 (threshold 15). Drivers by points: if/else 11 (23 pts), match/switch 4 (6 pts), loops 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux/profiler.rs"},"region":{"startLine":370}}}],"partialFingerprints":{"codehealthFindingId/v1":"36c2bdd3f2ec789519b13ab43df6b0d904adc66b685e071d8a0ebda11cd66bb8"}},{"ruleId":"D2","level":"warning","message":{"text":"Converter::get_sample_stack (cognitive 29): Converter::get_sample_stack has cognitive complexity 29 (threshold 15). Drivers by points: if/else 7 (13 pts), match/switch 3 (9 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":616}}}],"partialFingerprints":{"codehealthFindingId/v1":"622483a6d6608ad4049baf88d12f21b3c3d92a871454a94dde807833baa29749"}},{"ruleId":"D2","level":"warning","message":{"text":"TaskProfiler::sample_impl (cognitive 29): TaskProfiler::sample_impl has cognitive complexity 29 (threshold 15). Drivers by points: if/else 10 (25 pts), loops 2, match/switch 1 (2 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/task_profiler.rs"},"region":{"startLine":348}}}],"partialFingerprints":{"codehealthFindingId/v1":"ebb130dfcd105436b3bf99722fbded74f9a46bd0ca6e6e490ea47617e18ebc5d"}},{"ruleId":"D2","level":"warning","message":{"text":"samply_symbols::elf::compute_function_addresses_elf (cognitive 29): samply_symbols::elf::compute_function_addresses_elf has cognitive complexity 29 (threshold 15). Drivers by points: if/else 8 (23 pts), match/switch 4 (5 pts), loops 1 (nesting depth added 16). Of this number, 28 points are the body\u0027s own statements and 1 belongs to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/elf.rs"},"region":{"startLine":393}}}],"partialFingerprints":{"codehealthFindingId/v1":"8391396fd1223bcbe84517f3361caf5d00620027f8227cc9975407a4ba19262d"}},{"ruleId":"D2","level":"warning","message":{"text":"ObjectSymbolMapInner::try_lookup_external_impl (cognitive 28): ObjectSymbolMapInner::try_lookup_external_impl has cognitive complexity 28 (threshold 15). Drivers by points: match/switch 6 (14 pts), if/else 4 (12 pts), loops 1 (2 pts) (nesting depth added 17). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/symbol_map_object.rs"},"region":{"startLine":685}}}],"partialFingerprints":{"codehealthFindingId/v1":"22162f5ac6bc8c798033c59bab9fb1b225fff59d58faf9e1fea74f2b1f3b374b"}},{"ruleId":"D2","level":"warning","message":{"text":"TaskProfiler::new (cognitive 26): TaskProfiler::new has cognitive complexity 26 (threshold 15). Drivers by points: if/else 10 (20 pts), match/switch 3 (5 pts), loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/task_profiler.rs"},"region":{"startLine":123}}}],"partialFingerprints":{"codehealthFindingId/v1":"7451b5f9373a58a81202c781ccae5abcaaf7bc0edddad5c7a1dfcca3e715b681"}},{"ruleId":"D2","level":"warning","message":{"text":"JitCategoryManager::classify_jit_symbol (cognitive 23): JitCategoryManager::classify_jit_symbol has cognitive complexity 23 (threshold 15). Drivers by points: if/else 13 (21 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/shared/jit_category_manager.rs"},"region":{"startLine":284}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd460bbd25db8b23b439021da831aba509c3fd22cbbf4a78a7fe0806eceff778"}},{"ruleId":"D2","level":"warning","message":{"text":"PerfGroup::consume_events (cognitive 22): PerfGroup::consume_events has cognitive complexity 22 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 5 (10 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux/perf_group.rs"},"region":{"startLine":224}}}],"partialFingerprints":{"codehealthFindingId/v1":"42b8c1e384d82a79bbcc72ce0f98a16e726828ae79ada3d74377a714fffba2f6"}},{"ruleId":"D2","level":"warning","message":{"text":"samply::linux::profiler::run (cognitive 21): samply::linux::profiler::run has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (11 pts), match/switch 6 (8 pts), boolean chains 1, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux/profiler.rs"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"842a366c67d4413f7cbd50a03143d9d59f1fbe7fadc4a7125cf1f175bb505613"}},{"ruleId":"D2","level":"warning","message":{"text":"ResponseFrame::serialize (cognitive 21): ResponseFrame::serialize has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (21 pts) (nesting depth added 14). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-api/src/symbolicate/response_json.rs"},"region":{"startLine":205}}}],"partialFingerprints":{"codehealthFindingId/v1":"eca03165b8eb725f8fab7cb6f6758d63deb8c45c0c1d8ca2910edf177b3efc10"}},{"ruleId":"D2","level":"warning","message":{"text":"ElfLoad::provide (cognitive 20): ElfLoad::provide has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (12 pts), match/switch 4 (8 pts) (nesting depth added 8). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/elf.rs"},"region":{"startLine":628}}}],"partialFingerprints":{"codehealthFindingId/v1":"72a397318b541ff7bdb7d3fa185266ca07989dcc809ac14ecd08a9cb4d46a12f"}},{"ruleId":"D2","level":"warning","message":{"text":"FileResolver::get_candidate_paths_for_binary (cognitive 20): FileResolver::get_candidate_paths_for_binary has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (12 pts), loops 3 (7 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/file_resolver.rs"},"region":{"startLine":735}}}],"partialFingerprints":{"codehealthFindingId/v1":"62f890cc0fa6fc6ec5c4c6d45480c050bc27fbb2478d8104db24a4a0883cfb2a"}},{"ruleId":"D2","level":"warning","message":{"text":"TraceEventInfoRaw::property_map_info (cognitive 19): TraceEventInfoRaw::property_map_info has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 1 (4 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/etw_types.rs"},"region":{"startLine":146}}}],"partialFingerprints":{"codehealthFindingId/v1":"e4b7714a40a6d501e973dc28d4390d5aaa8d9ede982b0f64831a13dc32a2aa8e"}},{"ruleId":"D2","level":"warning","message":{"text":"Parser::find_property_size (cognitive 19): Parser::find_property_size has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (13 pts), match/switch 2 (5 pts), boolean chains 1 (nesting depth added 11). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":175}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f12b13311428eef2ed21cdbf029f5f776e08d2cdd996eadd0383bb08b648d0a"}},{"ruleId":"D2","level":"warning","message":{"text":"Parser::try_parse (cognitive 19): Parser::try_parse has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (18 pts), boolean chains 1 (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":321}}}],"partialFingerprints":{"codehealthFindingId/v1":"120d1b851922b15ad59ef6cea15b80ac19712bd3ed2d6a4ebc165e7a87fa9a1c"}},{"ruleId":"D2","level":"warning","message":{"text":"SingleJitDumpProcessor::process_pending_records (cognitive 19): SingleJitDumpProcessor::process_pending_records has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (14 pts), match/switch 2 (4 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/shared/jitdump_manager.rs"},"region":{"startLine":143}}}],"partialFingerprints":{"codehealthFindingId/v1":"b5b7d19d6288acf5377caf83385ada3b875b33c2f48fc6250d56156bc47a7b24"}},{"ruleId":"D2","level":"warning","message":{"text":"TraceEventInfoRaw::property_map_info (cognitive 19): TraceEventInfoRaw::property_map_info has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 1 (4 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/etw_types.rs"},"region":{"startLine":146}}}],"partialFingerprints":{"codehealthFindingId/v1":"17d3a283bd4e7feae7829870ff05d7fb459120be23007146130dd4219151a25f"}},{"ruleId":"D2","level":"warning","message":{"text":"Parser::find_property_size (cognitive 19): Parser::find_property_size has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (13 pts), match/switch 2 (5 pts), boolean chains 1 (nesting depth added 11). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/parser.rs"},"region":{"startLine":175}}}],"partialFingerprints":{"codehealthFindingId/v1":"001f54d62a3687ded8f248c631da8717181e8dac60877392b5ac4f551727c66d"}},{"ruleId":"D2","level":"warning","message":{"text":"Parser::try_parse (cognitive 19): Parser::try_parse has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (18 pts), boolean chains 1 (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/parser.rs"},"region":{"startLine":321}}}],"partialFingerprints":{"codehealthFindingId/v1":"bc7bcfae28331d7f276df9e08c9a82655a34210881fc0e40255ae0b8a6e2676f"}},{"ruleId":"D2","level":"warning","message":{"text":"FatArchiveMember::match_score_for_disambiguator (cognitive 19): FatArchiveMember::match_score_for_disambiguator has cognitive complexity 19 (threshold 15). Drivers by points: if/else 8 (12 pts), match/switch 3 (7 pts) (nesting depth added 8). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/macho.rs"},"region":{"startLine":134}}}],"partialFingerprints":{"codehealthFindingId/v1":"65d30e2e422aa0552966a35eb1f1e2953d57c220080ec02dd1678219c0fc69b5"}},{"ruleId":"D2","level":"warning","message":{"text":"etw_reader::enumerate_trace_guids_ex (cognitive 18): etw_reader::enumerate_trace_guids_ex has cognitive complexity 18 (threshold 15). Drivers by points: if/else 2 (8 pts), loops 3 (8 pts), match/switch 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":530}}}],"partialFingerprints":{"codehealthFindingId/v1":"02f15921505e01f54d93f743faf18d01d9e6dc6446aeecd1d814911ce420ebb0"}},{"ruleId":"D2","level":"warning","message":{"text":"PerfBuilder::open (cognitive 18): PerfBuilder::open has cognitive complexity 18 (threshold 15). Drivers by points: if/else 15 (16 pts), boolean chains 1, match/switch 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux/perf_event.rs"},"region":{"startLine":230}}}],"partialFingerprints":{"codehealthFindingId/v1":"c8cbbbfa0afd8acd586713e3888e78030fcac69f4410c19bdc4cea268e732b21"}},{"ruleId":"D2","level":"warning","message":{"text":"ProfileContext::handle_cswitch (cognitive 18): ProfileContext::handle_cswitch has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (17 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profile_context.rs"},"region":{"startLine":1569}}}],"partialFingerprints":{"codehealthFindingId/v1":"95ef14b7fd12d7c2ee0981e51844f0e9137c5f5dce7d589ae49c6823b66ad4e9"}},{"ruleId":"D2","level":"warning","message":{"text":"samply::windows::etw_reader::enumerate_trace_guids_ex (cognitive 18): samply::windows::etw_reader::enumerate_trace_guids_ex has cognitive complexity 18 (threshold 15). Drivers by points: if/else 2 (8 pts), loops 3 (8 pts), match/switch 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/mod.rs"},"region":{"startLine":530}}}],"partialFingerprints":{"codehealthFindingId/v1":"a6f9100155494c9bb89a5568315a5823c39af20e7cd2f5a8a44ca77755e47f62"}},{"ruleId":"D2","level":"warning","message":{"text":"ObjectSymbolMapInner::lookup_sync (cognitive 18): ObjectSymbolMapInner::lookup_sync has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (12 pts), match/switch 2 (4 pts), loops 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/symbol_map_object.rs"},"region":{"startLine":825}}}],"partialFingerprints":{"codehealthFindingId/v1":"88deeda5bcee75b4f5bf4c0b753af9459e2ce5579574c4f6d5bbc1b551436f01"}},{"ruleId":"D2","level":"warning","message":{"text":"wholesym::load_helpers::load_binary_for_library_info (cognitive 18): wholesym::load_helpers::load_binary_for_library_info has cognitive complexity 18 (threshold 15). Drivers by points: if/else 3 (9 pts), match/switch 3 (6 pts), boolean chains 2, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/load_helpers.rs"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"8fbe9164cdb3b5c748c62039fb75cfb11a8d70dfe796530634bf6f524139a3c0"}},{"ruleId":"D2","level":"warning","message":{"text":"Converter::handle_context_switch (cognitive 17): Converter::handle_context_switch has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (16 pts), match/switch 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":850}}}],"partialFingerprints":{"codehealthFindingId/v1":"77fea962342265a5617b80d1a76557ca14cb72e5bfed997e45c4bbb37cf3c907"}},{"ruleId":"D2","level":"warning","message":{"text":"Converter::add_kernel_module (cognitive 17): Converter::add_kernel_module has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (11 pts), match/switch 3 (4 pts), boolean chains 2 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":1154}}}],"partialFingerprints":{"codehealthFindingId/v1":"52350de7724de858f02d6774b00f41e0b3ff6069ede9735e7b5eff82a0fd06be"}},{"ruleId":"D2","level":"warning","message":{"text":"QuotaManager::list_existing_files_sync (cognitive 17): QuotaManager::list_existing_files_sync has cognitive complexity 17 (threshold 15). Drivers by points: match/switch 3 (8 pts), if/else 2 (6 pts), loops 2 (3 pts) (nesting depth added 10). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-quota-manager/src/quota_manager.rs"},"region":{"startLine":139}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d270ec24d7f32ac07021c02d0b2adcdb6127dc64dad7b94e8acc6e6461493e0"}},{"ruleId":"D2","level":"warning","message":{"text":"AsyncGzipDecoder::poll_read (cognitive 17): AsyncGzipDecoder::poll_read has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (10 pts), match/switch 2 (5 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/async_gzip_decoder.rs"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"9fdc75fa1b1b10e2c0905b6082cd88cdd13211db46eeda466ad5e52de30ae6d5"}},{"ruleId":"D2","level":"warning","message":{"text":"Parser::try_parse (cognitive 16): Parser::try_parse has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 2 (nesting depth added 8). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":384}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae9a7a1c38b4e7aeea8bb77e7cfafd08121614c480696e68e7366e98ad5618cc"}},{"ruleId":"D2","level":"warning","message":{"text":"FrameInterner::create_tables (cognitive 16): FrameInterner::create_tables has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (13 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fxprof-processed-profile/src/frame_table.rs"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"286fca77a1771c4f69d7573d19e05c84686df1c9ef7c86b762c3a35a083cfe41"}},{"ruleId":"D2","level":"warning","message":{"text":"SimpleperfSymbolTables::new (cognitive 16): SimpleperfSymbolTables::new has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (12 pts), match/switch 1 (2 pts), boolean chains 1, loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":1736}}}],"partialFingerprints":{"codehealthFindingId/v1":"90152133f6c790b54861a2e7ada367d10a0c0a97957c1b1e1532610d9b7688f4"}},{"ruleId":"D2","level":"warning","message":{"text":"Parser::try_parse (cognitive 16): Parser::try_parse has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 2 (nesting depth added 8). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/parser.rs"},"region":{"startLine":384}}}],"partialFingerprints":{"codehealthFindingId/v1":"57c50d37b84e5e3785796cf5f2c4acea20ee89b9b8dfc14282593fe82d12b755"}},{"ruleId":"D2","level":"warning","message":{"text":"samply_symbols::demangle_ocaml::demangle (cognitive 16): samply_symbols::demangle_ocaml::demangle has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (12 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/demangle_ocaml.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"0624565afc39a3f061f975b58ffda8580157397473704f408772212485e1fad1"}},{"ruleId":"D2","level":"warning","message":{"text":"wholesym::downloader::consume_stream_and_write_to_file (cognitive 16): wholesym::downloader::consume_stream_and_write_to_file has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 3 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/downloader.rs"},"region":{"startLine":504}}}],"partialFingerprints":{"codehealthFindingId/v1":"d16b2449830e0439ae1672076875154ce87d0407148f7655195a4bf9ba7e0e8c"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/mach_sys.rs: FileTooLong \u2014 7198 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 6698 over it, 14.40\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_sys.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c6bacbce3f0edca58ac359310666a90a1fc5d89746769dcdedd4e7c351b180ea"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: samply::windows::etw_gecko::process_trace: FunctionTooLong \u2014 samply::windows::etw_gecko::process_trace runs 368 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 268 over it, 3.68\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_gecko.rs"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"41f8c3879235e282c1ccabf5eaa80d1f886a6b0c3f0f1d3b690f4e554536041f"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyFields: __darwin_x86_avx512_state64: TooManyFields \u2014 97 stored fields. The bar is 30 stored fields; this is 67 over it, 3.23\u00D7 the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member \u2014 each reader then names only the group it uses."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_sys.rs"},"region":{"startLine":2670}}}],"partialFingerprints":{"codehealthFindingId/v1":"a698f2ed2d0e6f2a372c7b5e1c80b518a493f725bfe7cdd5c9a451ee004531a5"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: windows/profile_context.rs: FileTooLong \u2014 1519 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), about 72% of them inside a single declaration: ProfileContext (2 blocks, 440-2070). The bar is 500 significant lines; this is 1019 over it, 3.04\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profile_context.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"12b1bf54c3691ddfc99096ddb1a778221ff3e3b847486e85430e73b5f49b7dcb"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: Converter: ClassTooLong \u2014 1105 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), 29 methods, 2 blocks, lines 64-1704. The bar is 400 significant lines; this is 705 over it, 2.76\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ef18033fca41ad25d21de3454da5903e517dd8e5a37a6bd6cbc214fbf15ef36"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: ProfileContext: ClassTooLong \u2014 1087 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), 46 methods, 2 blocks, lines 440-2070. The bar is 400 significant lines; this is 687 over it, 2.72\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profile_context.rs"},"region":{"startLine":440}}}],"partialFingerprints":{"codehealthFindingId/v1":"df0d378b74c4a1ae4bf61cfaaff0a5337d7ad46710f305865503bbf76a0c2ea8"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: linux_shared/converter.rs: FileTooLong \u2014 1357 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), about 81% of them inside a single declaration: Converter (2 blocks, 64-1704). The bar is 500 significant lines; this is 857 over it, 2.71\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"2c3169265165a8969823ac5e1be4d648a94e15edd653037de03e71f2038471ab"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: Profile: TooManyMethods \u2014 69 methods. The bar is 30 methods; this is 39 over it, 2.30\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fxprof-processed-profile/src/profile.rs"},"region":{"startLine":211}}}],"partialFingerprints":{"codehealthFindingId/v1":"11b565782f365680a54e3c46d431a7bbdaffa09817aea0f3afd9cc2eb632ce03"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyFields: __darwin_i386_avx512_state: TooManyFields \u2014 57 stored fields. The bar is 30 stored fields; this is 27 over it, 1.90\u00D7 the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member \u2014 each reader then names only the group it uses."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_sys.rs"},"region":{"startLine":2263}}}],"partialFingerprints":{"codehealthFindingId/v1":"aacde724a4d45696d416063d0468c1b7678e580d6800e9096bec63ca755875bf"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyFields: __darwin_x86_avx_state64: TooManyFields \u2014 57 stored fields. The bar is 30 stored fields; this is 27 over it, 1.90\u00D7 the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member \u2014 each reader then names only the group it uses."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_sys.rs"},"region":{"startLine":2608}}}],"partialFingerprints":{"codehealthFindingId/v1":"8396d91a2c03147ed6513966df6f9e1edcfe2428788e60da53d93def09d391e4"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: Profile: ClassTooLong \u2014 753 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), 69 methods, 2 blocks, lines 211-1603. The bar is 400 significant lines; this is 353 over it, 1.88\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fxprof-processed-profile/src/profile.rs"},"region":{"startLine":211}}}],"partialFingerprints":{"codehealthFindingId/v1":"86aca6cab436952e8432c7c405e43907d2b967cd2cb3a5890158296306776846"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: samply::windows::coreclr::handle_coreclr_event: FunctionTooLong \u2014 samply::windows::coreclr::handle_coreclr_event runs 183 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 83 over it, 1.83\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/coreclr.rs"},"region":{"startLine":353}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4b8ff0f209891087bb1f991a02e453319d81d60c8ad5eb9e20da3cbe533f28e"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: Converter.add_module_to_process: MethodTooLong \u2014 add_module_to_process runs 176 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 76 over it, 1.76\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":1317}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2af5456034e2b7c3dc64136e833c54b4be672528312fd3e19e793b96e515e2d"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: wholesym_addr2line::main: FunctionTooLong \u2014 wholesym_addr2line::main runs 171 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 71 over it, 1.71\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym-addr2line/src/main.rs"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"8dc7c2d5d9ad35b09606b0326127a718ad0239961b84060cc677a72af2946d81"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/profile.rs: FileTooLong \u2014 851 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), about 88% of them inside a single declaration: Profile (2 blocks, 211-1603). The bar is 500 significant lines; this is 351 over it, 1.70\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fxprof-processed-profile/src/profile.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"dafdff2b5c5ad648ed0b4beaebbe0d98b14f8f556fea44b992096f5535095010"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: breakpad/index.rs: FileTooLong \u2014 814 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 314 over it, 1.63\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/breakpad/index.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"ceb33f50dbe9d99d2b63bd0f1e0fa71afcae12834a0293044de5cc117f185448"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/file_resolver.rs: FileTooLong \u2014 780 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 280 over it, 1.56\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/file_resolver.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"2ea9621d9dcfd485b473d77ea5bc6751401078685021694436aba8af1057e3d5"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: ProfileContext: TooManyMethods \u2014 46 methods. The bar is 30 methods; this is 16 over it, 1.53\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profile_context.rs"},"region":{"startLine":440}}}],"partialFingerprints":{"codehealthFindingId/v1":"727c9364b884bb6ad7dbf6611d9a9fe24717ac3aeeb30a4824a7456631740cc3"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyFields: task_vm_info: TooManyFields \u2014 46 stored fields. The bar is 30 stored fields; this is 16 over it, 1.53\u00D7 the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member \u2014 each reader then names only the group it uses."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_sys.rs"},"region":{"startLine":3345}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0b1d8511ac1c4bf3043a1fbb2d19c0e838918e1aebe4db4a7e0713f761d23b3"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: mac/mach_ipc.rs: FileTooLong \u2014 754 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 254 over it, 1.51\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/mach_ipc.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae438f0f9bb326cf0729084e0656a2aeeeedcca6c2f617d59c1c402ca76a3aca"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: TaskProfiler.new: MethodTooLong \u2014 new runs 146 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 46 over it, 1.46\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/task_profiler.rs"},"region":{"startLine":123}}}],"partialFingerprints":{"codehealthFindingId/v1":"55751823ff1d72505cf1ae43838988362b4f4af85b139c72362c8bbca2aad1ba"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/symbol_map_object.rs: FileTooLong \u2014 686 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 186 over it, 1.37\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/symbol_map_object.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fae50ef03f4283b5d1adfb23bebcebddff5e32a926636f7da56b1b4d9fb6899"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyFields: __darwin_i386_avx_state: TooManyFields \u2014 41 stored fields. The bar is 30 stored fields; this is 11 over it, 1.37\u00D7 the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member \u2014 each reader then names only the group it uses."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_sys.rs"},"region":{"startLine":2217}}}],"partialFingerprints":{"codehealthFindingId/v1":"76a540f0dc0c3b362d380b6d321022b87ff1b7d1fc8e1d9429dd9b517cdeff57"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/elf.rs: FileTooLong \u2014 675 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 175 over it, 1.35\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/elf.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"26ad2824db1b05ee8903cdcb615acfcb3396e8b50bc4c0dc2080c8b2169a98b2"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyFields: __darwin_x86_float_state64: TooManyFields \u2014 40 stored fields. The bar is 30 stored fields; this is 10 over it, 1.33\u00D7 the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member \u2014 each reader then names only the group it uses."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_sys.rs"},"region":{"startLine":2563}}}],"partialFingerprints":{"codehealthFindingId/v1":"5688bd3bd9ca315bc1fc059ea3d162adc9e2281ad084db9e146e6093e7fb88c6"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: mac/proc_maps.rs: FileTooLong \u2014 622 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 122 over it, 1.24\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/proc_maps.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"a2680cc0a04cafcc9bd73b12bdc0eb91225ae3a03a00f3f7219df80487a68a15"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: Sampler.run: MethodTooLong \u2014 run runs 122 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 22 over it, 1.22\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/sampler.rs"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"a95926fc9b6fbfb534e7080c53960e904d404c7dbcc4fff1c84a34e76e41fa88"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: samply::mac::profiler::run: FunctionTooLong \u2014 samply::mac::profiler::run runs 120 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 20 over it, 1.20\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/profiler.rs"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"372f984193407a3bfb2f52528b5b16a67649aaf8eb478e10856e2b0e62a1537b"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: mac/task_profiler.rs: FileTooLong \u2014 596 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), about 75% of them inside a single declaration: TaskProfiler (2 blocks, 100-697). The bar is 500 significant lines; this is 96 over it, 1.19\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/task_profiler.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"36bee8eae6a93234288e4283868e4c3897057d68d374f72c09f6b1f91ad3a9c5"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/lib.rs: FileTooLong \u2014 586 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 86 over it, 1.17\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"gecko_profile/src/lib.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"313c4453aa8de72f30e67911e453c09933a576172e735040388820c1b7b4b573"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: ElfLoad.provide: MethodTooLong \u2014 provide runs 117 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 17 over it, 1.17\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/elf.rs"},"region":{"startLine":628}}}],"partialFingerprints":{"codehealthFindingId/v1":"90427c90d00ecc2f67b31a7497cfa6506490f4b32ea0d3a6b0b2a3f5a113e65f"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: FileResolver.get_candidate_paths_for_debug_file: MethodTooLong \u2014 get_candidate_paths_for_debug_file runs 115 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 15 over it, 1.15\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/file_resolver.rs"},"region":{"startLine":481}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a7ee7f8d724c73bdd31a7b1d698b5ffd69d53d76e6d72edf93a2e6b421792d8"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: TaskProfiler: ClassTooLong \u2014 449 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), 9 methods, 2 blocks, lines 100-697. The bar is 400 significant lines; this is 49 over it, 1.12\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/task_profiler.rs"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"03cac91fa29cab46c615465b298776428523ff42f33cf4605dae4d7615940492"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: PerfBuilder.open: MethodTooLong \u2014 open runs 112 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 12 over it, 1.12\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux/perf_event.rs"},"region":{"startLine":230}}}],"partialFingerprints":{"codehealthFindingId/v1":"17aed21c85b0b87dbe07f32f430b705ec021690cb1ff077cffa663084ae9f7f2"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/custom_schemas.rs: FileTooLong \u2014 539 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 39 over it, 1.08\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/custom_schemas.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"36c5f322bc6eccc501553cc8669f8b42bf9c444e352c527ec7898bdc7f7b9244"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: etw_reader/custom_schemas.rs: FileTooLong \u2014 539 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 39 over it, 1.08\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/custom_schemas.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"9b1934550ae77a05298ceb8d07e20932e68d88e8172845bda50aa049d249f7f4"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: Error.from: MethodTooLong \u2014 from runs 107 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 7 over it, 1.07\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/mach_ipc.rs"},"region":{"startLine":938}}}],"partialFingerprints":{"codehealthFindingId/v1":"9eece0f73b32fd01de9315fc5dab0e2e8403e9866db93a1980f6656c12d0f98d"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyFields: __darwin_i386_float_state: TooManyFields \u2014 32 stored fields. The bar is 30 stored fields; this is 2 over it, 1.07\u00D7 the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member \u2014 each reader then names only the group it uses."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_sys.rs"},"region":{"startLine":2180}}}],"partialFingerprints":{"codehealthFindingId/v1":"8984fd33e5525998ea8cf20ca0a95207eee9ad9a6c50eed356f770cb3e967dd8"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/macho.rs: FileTooLong \u2014 509 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 9 over it, 1.02\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/macho.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ab9351129f19ca2cd420a057318f2e83bfd78e5ab69a11080e4f7c339214b43"}},{"ruleId":"D4","level":"warning","message":{"text":"Near-duplicate member pair (103 shared lines): etw-reader/src/lib.rs:342-483 | samply/src/windows/etw_reader/mod.rs:342-483 \u2014 These two members are variants of one another: 103 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members\u0027 grain \u2014 factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":342}}}],"partialFingerprints":{"codehealthFindingId/v1":"f99826c317fa2ece2f328ab4bf690340cfeb92f75cf05155fa30c76f415298d6"}},{"ruleId":"D4","level":"warning","message":{"text":"Near-duplicate member pair (67 shared lines): etw-reader/src/lib.rs:234-314 | samply/src/windows/etw_reader/mod.rs:234-314 \u2014 These two members are variants of one another: 67 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members\u0027 grain \u2014 factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":234}}}],"partialFingerprints":{"codehealthFindingId/v1":"e557819dfb3026fab79397e92d5abdd338ab74afddc5a727d9303bd2c017c64b"}},{"ruleId":"D4","level":"warning","message":{"text":"Near-duplicate member pair (53 shared lines): etw-reader/src/lib.rs:530-586 | samply/src/windows/etw_reader/mod.rs:530-586 \u2014 These two members are variants of one another: 53 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members\u0027 grain \u2014 factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":530}}}],"partialFingerprints":{"codehealthFindingId/v1":"2f51af68499bd64637f3c8800d45f1fda08bac46b494bf4f6f3867f730668fc8"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (36 corresponding lines): samply-mac-preload/src/mach_sys.rs:1868-1903 | samply-mac-preload/src/mach_sys.rs:2085-2144 \u2014 These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_sys.rs"},"region":{"startLine":1868}}}],"partialFingerprints":{"codehealthFindingId/v1":"947a14344a05dd9805983eb0e560f8b088d5388a02873cdd481c0f94f108e982"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (38 corresponding lines): etw-reader/src/parser.rs:505-542 | samply/src/windows/etw_reader/parser.rs:505-542 \u2014 These two members are one piece of code written twice and then edited apart: 38 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":505}}}],"partialFingerprints":{"codehealthFindingId/v1":"5fb0b699a0e728ddba0c11358bcf10c53c710c4f498dc4ee1d9682f858ff5743"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (14 members, 50\u002B identical tokens): etw-reader/src/custom_schemas.rs:173-186 | etw-reader/src/custom_schemas.rs:284-297 | etw-reader/src/custom_schemas.rs:510-523 | etw-reader/src/custom_schemas.rs:664-677 | etw-reader/src/custom_schemas.rs:758-771 | etw-reader/src/custom_schemas.rs:817-830 | etw-reader/src/custom_schemas.rs:876-889 | samply/src/windows/etw_reader/custom_schemas.rs:173-186 | samply/src/windows/etw_reader/custom_schemas.rs:284-297 | samply/src/windows/etw_reader/custom_schemas.rs:510-523 | samply/src/windows/etw_reader/custom_schemas.rs:664-677 | samply/src/windows/etw_reader/custom_schemas.rs:758-771 | samply/src/windows/etw_reader/custom_schemas.rs:817-830 | samply/src/windows/etw_reader/custom_schemas.rs:876-889 \u2014 These 14 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 14 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 14 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/custom_schemas.rs"},"region":{"startLine":173}}}],"partialFingerprints":{"codehealthFindingId/v1":"d8a13d6ee30a17c440221f06b2cc21b623c858787140040dbaf8ce6e01b01a14"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (14 members, 50\u002B identical tokens): samply-mac-preload/src/mach_sys.rs:400-415 | samply-mac-preload/src/mach_sys.rs:542-553 | samply-mac-preload/src/mach_sys.rs:603-618 | samply-mac-preload/src/mach_sys.rs:680-699 | samply-mac-preload/src/mach_sys.rs:761-780 | samply-mac-preload/src/mach_sys.rs:842-861 | samply-mac-preload/src/mach_sys.rs:923-942 | samply-mac-preload/src/mach_sys.rs:1004-1023 | samply-mac-preload/src/mach_sys.rs:1085-1104 | samply-mac-preload/src/mach_sys.rs:1154-1169 | samply-mac-preload/src/mach_sys.rs:1219-1234 | samply-mac-preload/src/mach_sys.rs:1284-1299 | samply-mac-preload/src/mach_sys.rs:2428-2451 | samply-mac-preload/src/mach_sys.rs:2501-2517 \u2014 These 14 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 14 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 14 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_sys.rs"},"region":{"startLine":400}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba60fe58cbac6747887d0b6525bbf8f52a3a4f1932b79714f5eaa12f7303b514"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): etw-reader/src/custom_schemas.rs:86-99 | etw-reader/src/custom_schemas.rs:421-434 | samply/src/windows/etw_reader/custom_schemas.rs:86-99 | samply/src/windows/etw_reader/custom_schemas.rs:421-434 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/custom_schemas.rs"},"region":{"startLine":86}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d4a521731684f30a9e85e0444ad07967fc7190f591c3dbe6e4f68adf4039b44"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (4 members, 50\u002B identical tokens): samply/src/linux_shared/converter.rs:247-382 | samply/src/linux_shared/converter.rs:387-453 | samply/src/linux_shared/converter.rs:458-540 | samply/src/linux_shared/converter.rs:546-595 \u2014 These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":247}}}],"partialFingerprints":{"codehealthFindingId/v1":"e39cb570fa13a21ff9e2d1eaa53101308f2740bb9385df0f6133671d1db2a089"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (58 lines \u00D7 2): etw-reader/src/tdh.rs:71-128 | samply/src/windows/etw_reader/tdh.rs:71-128 \u2014 before extracting anything, compare \u0060etw-reader/src/tdh.rs\u0060 and \u0060samply/src/windows/etw_reader/tdh.rs\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 100 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/tdh.rs"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"0828363659ca43c70ba295c0f414df10b201464a24ca9df80074407b299f5cd7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (51 lines \u00D7 2): etw-reader/src/parser.rs:176-226 | samply/src/windows/etw_reader/parser.rs:176-226 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":176}}}],"partialFingerprints":{"codehealthFindingId/v1":"923397ec11ae6192ced0e7340844645b9de04e56e0cea235211d93699b6c8678"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (46 lines \u00D7 2): etw-reader/src/lib.rs:343-388 | samply/src/windows/etw_reader/mod.rs:343-388 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":343}}}],"partialFingerprints":{"codehealthFindingId/v1":"52526b2d81f7dc687458d8e2223e9d518654ad5b7dcae27eca032792bc8a8dbe"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (40\u201344 lines \u00D7 2): samply/src/shared/context_switch.rs:91-134 | samply/src/shared/context_switch.rs:141-180 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/shared/context_switch.rs"},"region":{"startLine":91}}}],"partialFingerprints":{"codehealthFindingId/v1":"43b9688c9b83d56ce92d4983bd621133842830081f221337a4d04efff7a32461"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (43 lines \u00D7 2): samply-mac-preload/src/mach_ipc.rs:561-603 | samply/src/mac/mach_ipc.rs:885-927 \u2014 before extracting anything, compare \u0060samply-mac-preload/src/mach_ipc.rs\u0060 and \u0060samply/src/mac/mach_ipc.rs\u0060 as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_ipc.rs"},"region":{"startLine":561}}}],"partialFingerprints":{"codehealthFindingId/v1":"b3f4975d1a5f79b6cfaccf3445008c6cd7b1aa699e1f0ab5094ffb1c004cf1ed"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (42 lines \u00D7 2): etw-reader/src/tdh_types.rs:74-115 | samply/src/windows/etw_reader/tdh_types.rs:74-115 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/tdh_types.rs"},"region":{"startLine":74}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce803f39617af93e1f6ef3971cc39bdbca2ce0ac3fa1b9ed3c9145fe6f5c7655"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (37 lines \u00D7 2): etw-reader/src/lib.rs:260-296 | samply/src/windows/etw_reader/mod.rs:260-296 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":260}}}],"partialFingerprints":{"codehealthFindingId/v1":"23eed638963c0d97742c9c5762431abce2d6646518484292fe84858fd0ead7c3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (34 lines \u00D7 2): etw-reader/src/schema.rs:69-102 | samply/src/windows/etw_reader/schema.rs:69-102 \u2014 before extracting anything, compare \u0060etw-reader/src/schema.rs\u0060 and \u0060samply/src/windows/etw_reader/schema.rs\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 78 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/schema.rs"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"23a4fee397ae75e999fffbf259e9214f78f67a54ae6bca41e88ceb7d98eedbfb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (33 lines \u00D7 2): etw-reader/src/lib.rs:554-586 | samply/src/windows/etw_reader/mod.rs:554-586 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":554}}}],"partialFingerprints":{"codehealthFindingId/v1":"35965f2ecd5eea56f954c50946a5b0edc15f61b588ebe2472992a58d46e11ac7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (31 lines \u00D7 2): etw-reader/src/parser.rs:385-415 | samply/src/windows/etw_reader/parser.rs:385-415 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":385}}}],"partialFingerprints":{"codehealthFindingId/v1":"9517979d5934f6ea830b9cb051412bb557af7c317ecec7dac09e7c11a6807e8f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (29 lines \u00D7 2): etw-reader/src/parser.rs:234-262 | samply/src/windows/etw_reader/parser.rs:234-262 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":234}}}],"partialFingerprints":{"codehealthFindingId/v1":"24148c3c4e01a0d86ee866ebdf1072d5a785068503f263935ba62e8760fdd486"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25 lines \u00D7 2): etw-reader/src/lib.rs:504-528 | samply/src/windows/etw_reader/mod.rs:504-528 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":504}}}],"partialFingerprints":{"codehealthFindingId/v1":"38e12f2a9176794548e1fda5b34e3c81398886e92db478c5e2ca2d811c68e4f9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25 lines \u00D7 2): etw-reader/src/parser.rs:322-346 | samply/src/windows/etw_reader/parser.rs:322-346 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":322}}}],"partialFingerprints":{"codehealthFindingId/v1":"5e9721b7f65d1713aa0292ae1fdf6b2b47680faca7d7d3b10d2fd78506082fe7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25 lines \u00D7 2): etw-reader/src/parser.rs:547-571 | samply/src/windows/etw_reader/parser.rs:547-571 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":547}}}],"partialFingerprints":{"codehealthFindingId/v1":"266e1d89ae79920d9d528c51d174e5fad75e22360337d82f6a1cd570c3af65e7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25 lines \u00D7 2): etw-reader/src/schema.rs:191-215 | samply/src/windows/etw_reader/schema.rs:191-215 \u2014 before extracting anything, compare \u0060etw-reader/src/schema.rs\u0060 and \u0060samply/src/windows/etw_reader/schema.rs\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 78 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/schema.rs"},"region":{"startLine":191}}}],"partialFingerprints":{"codehealthFindingId/v1":"c9891cd88d1869202c9c8cc1562658f31042d2a04f42639c3e30ea71076cecba"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22\u201325 lines \u00D7 2): samply/src/main.rs:88-109 | samply/src/main.rs:130-154 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/main.rs"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"6e879328633fa5d10fe18124b7ce8140e97005662c7cc15ea008ab85f16f7c91"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (24 lines \u00D7 2): etw-reader/src/parser.rs:293-316 | samply/src/windows/etw_reader/parser.rs:293-316 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":293}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a4b726f40daf06bf316d964187d7af064f8bbb9e27037caa8e7d96e262c5ad5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (24 lines \u00D7 2): samply/src/windows/profile_context.rs:884-907 | samply/src/windows/profile_context.rs:938-961 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profile_context.rs"},"region":{"startLine":884}}}],"partialFingerprints":{"codehealthFindingId/v1":"a7481e79e1f992813170d32826cfd27d0f8bc3470bed4f7c667a96bf4d59b995"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23 lines \u00D7 2): etw-reader/src/lib.rs:589-611 | samply/src/windows/etw_reader/mod.rs:589-611 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":589}}}],"partialFingerprints":{"codehealthFindingId/v1":"bccecd624dd83bc3cbd1a0e603fc0e56bf5b134bab60aafc1325db68d1526404"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): etw-reader/src/lib.rs:459-480 | samply/src/windows/etw_reader/mod.rs:459-480 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":459}}}],"partialFingerprints":{"codehealthFindingId/v1":"7e3db458596c76ffb94e6a37fb2cd490abb8eb660c5587b9a3e483d310afdcd1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): etw-reader/src/tdh.rs:25-46 | samply/src/windows/etw_reader/tdh.rs:25-46 \u2014 before extracting anything, compare \u0060etw-reader/src/tdh.rs\u0060 and \u0060samply/src/windows/etw_reader/tdh.rs\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 100 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/tdh.rs"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"91554e5e8feb05cc26bcc91cfaf53b302c4d2e40e582ac5da274fda8ce4d4805"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21 lines \u00D7 2): etw-reader/src/parser.rs:481-501 | samply/src/windows/etw_reader/parser.rs:481-501 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":481}}}],"partialFingerprints":{"codehealthFindingId/v1":"d20413fc34a385426723b8d319c1d362a0f062620a64e9206f15982f7ec470d5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): etw-reader/src/sddl.rs:34-53 | samply/src/windows/etw_reader/sddl.rs:34-53 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/sddl.rs"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"89a61cbb88e94ef216fa68795330530412e452b428c12200ad7436602fd2cf5c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): etw-reader/src/tdh.rs:49-68 | samply/src/windows/etw_reader/tdh.rs:49-68 \u2014 before extracting anything, compare \u0060etw-reader/src/tdh.rs\u0060 and \u0060samply/src/windows/etw_reader/tdh.rs\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 100 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/tdh.rs"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"2f0e8747d6876f3738841c6de317e67044a4473eff7a5c1591f239b1f162eaad"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19\u201320 lines \u00D7 2): samply/src/windows/profile_context.rs:754-772 | samply/src/windows/profile_context.rs:822-841 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profile_context.rs"},"region":{"startLine":754}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f94491d9a8e60c24419503624d27bbe3aedd0eca6f50faec32c4e33f7e81c81"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): etw-reader/src/parser.rs:506-524 | samply/src/windows/etw_reader/parser.rs:506-524 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":506}}}],"partialFingerprints":{"codehealthFindingId/v1":"423288fe7599839735683a4d3461e0c82f86146695e0a574606d4cb5abdccf02"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): etw-reader/src/utils.rs:14-32 | samply/src/windows/etw_reader/utils.rs:14-32 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/utils.rs"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"82e364e513cd32a64d0b1f1c0b193615936799ae2d98c0cfc18b228457046916"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2): etw-reader/src/lib.rs:403-420 | samply/src/windows/etw_reader/mod.rs:403-420 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":403}}}],"partialFingerprints":{"codehealthFindingId/v1":"aa90519bbb5db2f592db0e1cf5b24939fc0f4fc2f3b36d187794df7e18211571"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2): etw-reader/src/parser.rs:420-437 | samply/src/windows/etw_reader/parser.rs:420-437 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":420}}}],"partialFingerprints":{"codehealthFindingId/v1":"ab399249b98835382d5a274a7988d827dfb52950f6bff26414e4147d2d17a05a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2): samply/src/linux/profiler.rs:637-654 | samply/src/linux/profiler.rs:658-675 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux/profiler.rs"},"region":{"startLine":637}}}],"partialFingerprints":{"codehealthFindingId/v1":"7092ac673181858d3dcd80c6ed6eda0202bebf16bfcefd590263d04086591441"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): etw-reader/src/lib.rs:236-252 | samply/src/windows/etw_reader/mod.rs:236-252 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":236}}}],"partialFingerprints":{"codehealthFindingId/v1":"f712f85d02447aab5a0ce8f55f74e18af1e4221067e0f934f76939ee0e7cbcb2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): etw-reader/src/etw_types.rs:214-229 | samply/src/windows/etw_reader/etw_types.rs:214-229 \u2014 before extracting anything, compare \u0060etw-reader/src/etw_types.rs\u0060 and \u0060samply/src/windows/etw_reader/etw_types.rs\u0060 as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 77 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/etw_types.rs"},"region":{"startLine":214}}}],"partialFingerprints":{"codehealthFindingId/v1":"988cbb2fac980a413e1f90d47f095e7ee17b672010f817385c5ce6c88d15cd44"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): etw-reader/src/lib.rs:130-145 | samply/src/windows/etw_reader/mod.rs:130-145 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":130}}}],"partialFingerprints":{"codehealthFindingId/v1":"626638765696127c9cf9a1fb92085d2301713be18b5c878181bf9a9156619c2a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13\u201316 lines \u00D7 2): samply/src/linux_shared/converter.rs:393-408 | samply/src/linux_shared/converter.rs:505-517 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":393}}}],"partialFingerprints":{"codehealthFindingId/v1":"fbb19f093ca3d656b490d8fda2b1498a945f7a6c2f955421d6b387e0eb8b2433"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 4): samply/src/linux_shared/converter.rs:262-276 | samply/src/linux_shared/converter.rs:391-405 | samply/src/linux_shared/converter.rs:503-517 | samply/src/linux_shared/converter.rs:554-568 \u2014 all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":262}}}],"partialFingerprints":{"codehealthFindingId/v1":"e92d21828735f7930bdf4320256ff13c4a09c01857a69776228a53388872a0a4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): etw-reader/src/lib.rs:321-335 | samply/src/windows/etw_reader/mod.rs:321-335 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":321}}}],"partialFingerprints":{"codehealthFindingId/v1":"9fcc3e1f40fc85fe07a92ef7f9f394001dc86ec51cb4dd85e88e2780350bb5a2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): etw-reader/src/parser.rs:528-542 | samply/src/windows/etw_reader/parser.rs:528-542 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":528}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf927155eda1e95ec7352e5e00a5476baf8a5cbbbe8b79736f1cdc16b1ad88c1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): samply/src/linux_shared/converter.rs:1390-1404 | samply/src/linux_shared/converter.rs:1557-1571 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":1390}}}],"partialFingerprints":{"codehealthFindingId/v1":"1de1807d43485c60f62a968a208e5906768f303ee2190315c7eb32e095cf4ed0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): samply/src/windows/profile_context.rs:909-923 | samply/src/windows/profile_context.rs:977-991 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profile_context.rs"},"region":{"startLine":909}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd79fc3c5c9be9aa9076772c14f4e13d4bf5551111b149fd503a98211c203503"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): etw-reader/src/property.rs:38-51 | samply/src/windows/etw_reader/property.rs:38-51 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/property.rs"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"1035df758a9139a614f69c8d7499e3e4887ee94e0eb8e2c2125119e542a9e418"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13\u201314 lines \u00D7 2): samply/src/linux_shared/converter.rs:886-898 | samply/src/windows/profile_context.rs:1631-1644 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":886}}}],"partialFingerprints":{"codehealthFindingId/v1":"add6752bf7b3210821056d34215bc4a64f2cd6fa528c6889e4d4f96b749d56e6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): etw-reader/src/etw_types.rs:269-281 | samply/src/windows/etw_reader/etw_types.rs:269-281 \u2014 before extracting anything, compare \u0060etw-reader/src/etw_types.rs\u0060 and \u0060samply/src/windows/etw_reader/etw_types.rs\u0060 as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 77 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/etw_types.rs"},"region":{"startLine":269}}}],"partialFingerprints":{"codehealthFindingId/v1":"72b040b7a636c416a467193c337915ea9328fa1fab99ec912e47958a3226e2cc"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): etw-reader/src/lib.rs:298-310 | samply/src/windows/etw_reader/mod.rs:298-310 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":298}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f491b5b1a739e44c6cc4136dc0d7c0bab5cf462fc2478b5ed6e4b7b75f97566"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): etw-reader/src/lib.rs:540-552 | samply/src/windows/etw_reader/mod.rs:540-552 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":540}}}],"partialFingerprints":{"codehealthFindingId/v1":"bbd2f7da44898a1b9438daf412509da6dd15e1ac69a7a910978cdf7495407d70"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): etw-reader/src/parser.rs:351-363 | samply/src/windows/etw_reader/parser.rs:351-363 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":351}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a392271c66a2a064ec01516b86071ea3160fb2f32987a5b0784f36882e7d3ba"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): etw-reader/src/parser.rs:368-380 | samply/src/windows/etw_reader/parser.rs:368-380 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":368}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7c90728f51f9f90e9e2823dd00ef2bbbd6f5338b388ae7d8e7ea65064a65342"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): etw-reader/src/parser.rs:442-454 | samply/src/windows/etw_reader/parser.rs:442-454 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":442}}}],"partialFingerprints":{"codehealthFindingId/v1":"99a1212c15125063d056022f458c722ec5d921d41d8fad3f7c8e8c0320546458"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): samply/src/linux_shared/process_threads.rs:119-131 | samply/src/linux_shared/processes.rs:215-227 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/process_threads.rs"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"8984eef94257c778dd9889976a45c448f80087c1218a15e4e11fca24e75660c0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 14): etw-reader/src/custom_schemas.rs:175-186 | etw-reader/src/custom_schemas.rs:286-297 | etw-reader/src/custom_schemas.rs:512-523 | etw-reader/src/custom_schemas.rs:666-677 | etw-reader/src/custom_schemas.rs:760-771 | etw-reader/src/custom_schemas.rs:819-830 | etw-reader/src/custom_schemas.rs:878-889 | samply/src/windows/etw_reader/custom_schemas.rs:175-186 | samply/src/windows/etw_reader/custom_schemas.rs:286-297 | samply/src/windows/etw_reader/custom_schemas.rs:512-523 | samply/src/windows/etw_reader/custom_schemas.rs:666-677 | samply/src/windows/etw_reader/custom_schemas.rs:760-771 | samply/src/windows/etw_reader/custom_schemas.rs:819-830 | samply/src/windows/etw_reader/custom_schemas.rs:878-889 \u2014 there are 14 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 14 sites; resolving a subset leaves the remainder to drift apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/custom_schemas.rs"},"region":{"startLine":175}}}],"partialFingerprints":{"codehealthFindingId/v1":"3fccccd6698be7412f4e5d8a052d2abbc31f5613aeffff6bb3b50e922686a83d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 4): etw-reader/src/custom_schemas.rs:88-99 | etw-reader/src/custom_schemas.rs:423-434 | samply/src/windows/etw_reader/custom_schemas.rs:88-99 | samply/src/windows/etw_reader/custom_schemas.rs:423-434 \u2014 there are 4 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/custom_schemas.rs"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"6dd5ea3919b59cc9e6ad592bfdda8548ad88495cae62337d9bd0c2e15ad1cbb9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): etw-reader/src/lib.rs:156-167 | samply/src/windows/etw_reader/mod.rs:156-167 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":156}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c74a7d179ca3f5d2134bcedc2efeb6538edc7c7db7b42bd5c5f2e0d2ea99c00"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): etw-reader/src/lib.rs:390-401 | samply/src/windows/etw_reader/mod.rs:390-401 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":390}}}],"partialFingerprints":{"codehealthFindingId/v1":"b43667accf40ba62b6af9dde7d9fd390b4a12d377dfd8a258380db7c445d3617"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): samply/src/import/perf.rs:250-261 | samply/src/linux/profiler.rs:596-607 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/import/perf.rs"},"region":{"startLine":250}}}],"partialFingerprints":{"codehealthFindingId/v1":"52dc0a98149a96edcae5fae622dc1579cce636995b302c208cdbccac0fcbf84f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): samply-symbols/src/breakpad/index.rs:945-956 | samply/src/linux_shared/kernel_symbols.rs:143-154 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/breakpad/index.rs"},"region":{"startLine":945}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c23262b7afef62c125350527c8cb77d3d253d71425b683fef1cc68306752c99"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): samply-mac-preload/src/mach_ipc.rs:500-511 | samply/src/mac/mach_ipc.rs:817-828 \u2014 before extracting anything, compare \u0060samply-mac-preload/src/mach_ipc.rs\u0060 and \u0060samply/src/mac/mach_ipc.rs\u0060 as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_ipc.rs"},"region":{"startLine":500}}}],"partialFingerprints":{"codehealthFindingId/v1":"325822f0d4a88698488301b957d51b4a62a872477418c3cfc1e868702e424091"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11\u201312 lines \u00D7 2): samply/src/shared/per_cpu.rs:46-57 | samply/src/shared/per_cpu.rs:73-83 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/shared/per_cpu.rs"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a801f67251da9b8c39e70e4a73ccfc6de07b14256a8bd99c7def52b85187fbc"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): samply-quota-manager/src/quota_manager.rs:260-271 | samply-quota-manager/src/quota_manager.rs:278-289 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-quota-manager/src/quota_manager.rs"},"region":{"startLine":260}}}],"partialFingerprints":{"codehealthFindingId/v1":"5507fadf1be2c11c55d6c7ebb1d562489a71446001ea39e5897c10c42441c8a5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): wholesym/src/file_resolver.rs:1021-1032 | wholesym/src/file_resolver.rs:1042-1053 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/file_resolver.rs"},"region":{"startLine":1021}}}],"partialFingerprints":{"codehealthFindingId/v1":"2fc29e740b2fab3c740ca6031572356016598e35dcd57cf906add1276c8fb54d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): wholesym/src/file_resolver.rs:1177-1188 | wholesym/src/file_resolver.rs:1198-1209 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/file_resolver.rs"},"region":{"startLine":1177}}}],"partialFingerprints":{"codehealthFindingId/v1":"9014385f0ec20e7dc6559ea78a429614e3945d4ba153cfd639780ba10362067b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 3): wholesym/src/file_resolver.rs:1220-1230 | wholesym/src/file_resolver.rs:1240-1250 | wholesym/src/file_resolver.rs:1255-1265 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/file_resolver.rs"},"region":{"startLine":1220}}}],"partialFingerprints":{"codehealthFindingId/v1":"6c7007b309880b42317e9c4abed1270449845dcb29b7891f4e272a6f8c7459a7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): samply-mac-preload/src/mach_ipc.rs:397-407 | samply/src/mac/mach_ipc.rs:422-432 \u2014 before extracting anything, compare \u0060samply-mac-preload/src/mach_ipc.rs\u0060 and \u0060samply/src/mac/mach_ipc.rs\u0060 as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_ipc.rs"},"region":{"startLine":397}}}],"partialFingerprints":{"codehealthFindingId/v1":"959323a4c054cb1a12d690f57bcc091c5489c7a5417a64c426fc5daf492d1ba7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): samply-mac-preload/src/mach_ipc.rs:264-274 | samply/src/mac/mach_ipc.rs:603-613 \u2014 before extracting anything, compare \u0060samply-mac-preload/src/mach_ipc.rs\u0060 and \u0060samply/src/mac/mach_ipc.rs\u0060 as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_ipc.rs"},"region":{"startLine":264}}}],"partialFingerprints":{"codehealthFindingId/v1":"5027c94ac1fb4400f39fc3736664b46ecf2c5937f568a60fb898bea6b72a6531"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9\u201310 lines \u00D7 14): samply-mac-preload/src/mach_sys.rs:401-409 | samply-mac-preload/src/mach_sys.rs:543-552 | samply-mac-preload/src/mach_sys.rs:604-612 | samply-mac-preload/src/mach_sys.rs:681-689 | samply-mac-preload/src/mach_sys.rs:762-770 | samply-mac-preload/src/mach_sys.rs:843-851 | samply-mac-preload/src/mach_sys.rs:924-932 | samply-mac-preload/src/mach_sys.rs:1005-1013 | samply-mac-preload/src/mach_sys.rs:1086-1094 | samply-mac-preload/src/mach_sys.rs:1155-1163 | samply-mac-preload/src/mach_sys.rs:1220-1228 | samply-mac-preload/src/mach_sys.rs:1285-1293 | samply-mac-preload/src/mach_sys.rs:2429-2437 | samply-mac-preload/src/mach_sys.rs:2502-2511 \u2014 all 14 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_sys.rs"},"region":{"startLine":401}}}],"partialFingerprints":{"codehealthFindingId/v1":"70966feddb7b95ea7782ef12567a317cccd3edaa9b1c1b886cf843410e60d090"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): etw-reader/src/etw_types.rs:150-159 | samply/src/windows/etw_reader/etw_types.rs:150-159 \u2014 before extracting anything, compare \u0060etw-reader/src/etw_types.rs\u0060 and \u0060samply/src/windows/etw_reader/etw_types.rs\u0060 as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 77 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/etw_types.rs"},"region":{"startLine":150}}}],"partialFingerprints":{"codehealthFindingId/v1":"e7b9a6d58b6c81b3450945417e56734186fdd6b812f25c2c6f74c5cabe2feb8f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): fxprof-processed-profile/src/string_table.rs:23-32 | gecko_profile/src/lib.rs:816-825 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fxprof-processed-profile/src/string_table.rs"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"6af3fa32916fcaba169bd79b88b7b895e9c7d5330ee49e5030e805651393621e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): samply-api/src/source/mod.rs:128-137 | samply-api/src/symbolicate/mod.rs:198-207 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-api/src/source/mod.rs"},"region":{"startLine":128}}}],"partialFingerprints":{"codehealthFindingId/v1":"2328620c99021062f4de347e5bab3586d51bbd240997e6a2bad12e13bcd0e5ab"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): samply-mac-preload/src/mach_sys.rs:1869-1878 | samply-mac-preload/src/mach_sys.rs:2086-2095 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_sys.rs"},"region":{"startLine":1869}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b06190cc04518290deb566b1c3a6743b11e98d47e8e73b6be157fe7c1717c76"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9\u201310 lines \u00D7 2): wholesym/src/file_resolver.rs:651-660 | wholesym/src/file_resolver.rs:766-774 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/file_resolver.rs"},"region":{"startLine":651}}}],"partialFingerprints":{"codehealthFindingId/v1":"ee0bd6ae98a7c1f39e299feba64423e08c6877b1e891c565880f512837b4f931"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 14): samply-mac-preload/src/mach_sys.rs:407-415 | samply-mac-preload/src/mach_sys.rs:545-553 | samply-mac-preload/src/mach_sys.rs:610-618 | samply-mac-preload/src/mach_sys.rs:691-699 | samply-mac-preload/src/mach_sys.rs:772-780 | samply-mac-preload/src/mach_sys.rs:853-861 | samply-mac-preload/src/mach_sys.rs:934-942 | samply-mac-preload/src/mach_sys.rs:1015-1023 | samply-mac-preload/src/mach_sys.rs:1096-1104 | samply-mac-preload/src/mach_sys.rs:1161-1169 | samply-mac-preload/src/mach_sys.rs:1226-1234 | samply-mac-preload/src/mach_sys.rs:1291-1299 | samply-mac-preload/src/mach_sys.rs:2443-2451 | samply-mac-preload/src/mach_sys.rs:2508-2517 \u2014 all 14 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_sys.rs"},"region":{"startLine":407}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd7c4245be721ca99871ff356cad651b90d22a74a2934e0bbf1415e5ce837caf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): etw-reader/src/schema.rs:160-168 | samply/src/windows/etw_reader/schema.rs:160-168 \u2014 before extracting anything, compare \u0060etw-reader/src/schema.rs\u0060 and \u0060samply/src/windows/etw_reader/schema.rs\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 78 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/schema.rs"},"region":{"startLine":160}}}],"partialFingerprints":{"codehealthFindingId/v1":"8078af96f24f51076dab238c95e3d43ad75415eafd43095085787ea92eb3a259"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8\u20139 lines \u00D7 2): samply/src/mac/task_profiler.rs:432-439 | samply/src/mac/task_profiler.rs:622-630 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/task_profiler.rs"},"region":{"startLine":432}}}],"partialFingerprints":{"codehealthFindingId/v1":"960c6009f2d72881aabe4db32ef1dccd26001b90a96d2400efa771595b474e85"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): samply/src/windows/etw_reader/utils.rs:70-78 | samply/src/windows/etw_reader/utils.rs:83-91 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/utils.rs"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b5bd3c4d5bd96e20949bff843dd8d4dbee00c568036fd49a8f0b55d5328a30b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): samply-mac-preload/src/lib.rs:122-130 | samply-mac-preload/src/lib.rs:140-148 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/lib.rs"},"region":{"startLine":122}}}],"partialFingerprints":{"codehealthFindingId/v1":"c5b517ea28a498b4793538245de2ac08044bf14b7bc2bb7dd5b9b7e6ce08defb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): samply-mac-preload/src/mach_sys.rs:1895-1903 | samply-mac-preload/src/mach_sys.rs:2136-2144 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_sys.rs"},"region":{"startLine":1895}}}],"partialFingerprints":{"codehealthFindingId/v1":"af9c704ecb390d3b431ce3122ccce901965fe9334c57f20a947b433288b19e85"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 3): wholesym/src/file_resolver.rs:1064-1071 | wholesym/src/file_resolver.rs:1081-1088 | wholesym/src/file_resolver.rs:1115-1122 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/file_resolver.rs"},"region":{"startLine":1064}}}],"partialFingerprints":{"codehealthFindingId/v1":"d67358ddb6107470e462c376b0af9440897056f0dd19ccc53ffaaede25010160"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): etw-reader/src/etw_types.rs:289-296 | samply/src/windows/etw_reader/etw_types.rs:289-296 \u2014 before extracting anything, compare \u0060etw-reader/src/etw_types.rs\u0060 and \u0060samply/src/windows/etw_reader/etw_types.rs\u0060 as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 77 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/etw_types.rs"},"region":{"startLine":289}}}],"partialFingerprints":{"codehealthFindingId/v1":"0034b00a71cf74c1585b9f9f4ae06f38a1950b3e62a451f9a1509c5a05066e02"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): etw-reader/src/lib.rs:87-94 | samply/src/windows/etw_reader/mod.rs:87-94 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"1afcb6aaa2b0bd8e0390f6a46971491a332a889d005a8616aa8b246bef57155b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): samply/src/linux_shared/process_threads.rs:149-156 | samply/src/linux_shared/process_threads.rs:195-202 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/process_threads.rs"},"region":{"startLine":149}}}],"partialFingerprints":{"codehealthFindingId/v1":"8f53d49f9dbbfd0cc24cdd3dbdd9188c43e13ea56bf216ea3ec0097db980457f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): wholesym/src/breakpad.rs:191-198 | wholesym/src/debuginfod.rs:112-119 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/breakpad.rs"},"region":{"startLine":191}}}],"partialFingerprints":{"codehealthFindingId/v1":"8cf4ad3d3cbf59d17b4f96108a3a237a42b334b450123f50c20b37e0b4f06058"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): etw-reader/src/lib.rs:531-537 | samply/src/windows/etw_reader/mod.rs:531-537 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":531}}}],"partialFingerprints":{"codehealthFindingId/v1":"596faf8e6e257b8fa7da9cbdf701259a418b7b0e0d3872f867ef3c144c05566c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): etw-reader/src/parser.rs:622-628 | samply/src/windows/etw_reader/parser.rs:622-628 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":622}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c3afb31360037ba90b4414feebc628045931868747d58e2cccb364fb323eb43"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): etw-reader/src/utils.rs:66-72 | etw-reader/src/utils.rs:77-83 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/utils.rs"},"region":{"startLine":66}}}],"partialFingerprints":{"codehealthFindingId/v1":"98a10d9a7222c34e49a85594cfaaa716e9008479841a5f290fdcb1da2c1aa300"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): samply-symbols/src/breakpad/index.rs:98-104 | samply-symbols/src/breakpad/index.rs:112-118 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/breakpad/index.rs"},"region":{"startLine":98}}}],"partialFingerprints":{"codehealthFindingId/v1":"098df99a9b21d792e4107125acc581453d3d92b2b0d91538b257349ce32ce60b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): etw-reader/src/lib.rs:76-81 | samply/src/windows/etw_reader/mod.rs:76-81 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"162011801046c6f338c0795c2b227a9c5df852b95e37a36a45c746a169562e62"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): samply/src/linux_shared/vdso.rs:13-18 | wholesym/src/vdso.rs:8-13 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/vdso.rs"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"d292d2e2b13a1b9f2c7026f9272e0b80805b5639dd4298e00ba41d002a58e440"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): samply-symbols/src/symbol_map_string_interner.rs:109-114 | samply-symbols/src/symbol_map_string_interner.rs:127-132 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/symbol_map_string_interner.rs"},"region":{"startLine":109}}}],"partialFingerprints":{"codehealthFindingId/v1":"43f39514ea99e6e3b669420cac2e2acb2fd5ed847d5c5967aadf08c8d2c91760"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): etw-reader/src/etw_types.rs:298-302 | samply/src/windows/etw_reader/etw_types.rs:298-302 \u2014 before extracting anything, compare \u0060etw-reader/src/etw_types.rs\u0060 and \u0060samply/src/windows/etw_reader/etw_types.rs\u0060 as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 77 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/etw_types.rs"},"region":{"startLine":298}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd59e2758a15e71554a4c2137e76f6fbd12af5ba196575ddce5bd778d540fee5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): etw-reader/src/lib.rs:435-439 | samply/src/windows/etw_reader/mod.rs:435-439 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":435}}}],"partialFingerprints":{"codehealthFindingId/v1":"c48f650fe8b4004e67558fd27e8514d97c317026122f123e4b303c3d1c4d0d88"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): etw-reader/src/parser.rs:617-621 | samply/src/windows/etw_reader/parser.rs:617-621 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":617}}}],"partialFingerprints":{"codehealthFindingId/v1":"3315facb6a57ca2a65293407dc1a81a2e2fa1cd8fbab594d0bf292e99889c6ee"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): samply-symbols/src/symbol_map_object.rs:534-538 | samply/src/linux_shared/svma_file_range.rs:55-59 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/symbol_map_object.rs"},"region":{"startLine":534}}}],"partialFingerprints":{"codehealthFindingId/v1":"5aa9da67d943ed36fd2e60e9367499f2d92ed3e835f530a3fcd49e623daa0831"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): etw-reader/src/etw_types.rs:25-30 | samply/src/windows/etw_reader/etw_types.rs:25-30 \u2014 before extracting anything, compare \u0060etw-reader/src/etw_types.rs\u0060 and \u0060samply/src/windows/etw_reader/etw_types.rs\u0060 as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 77 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/etw_types.rs"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"643626b2b8f744b59a1149c922519ded4bd05027970474e59806c46dc69e9b05"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): etw-reader/src/etw_types.rs:83-91 | samply/src/windows/etw_reader/etw_types.rs:83-91 \u2014 before extracting anything, compare \u0060etw-reader/src/etw_types.rs\u0060 and \u0060samply/src/windows/etw_reader/etw_types.rs\u0060 as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 77 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/etw_types.rs"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"847f7e419ccf8a0e6ec4b68509957974d7588f93e48f7af52663f87da502f52d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): etw-reader/src/etw_types.rs:304-313 | samply/src/windows/etw_reader/etw_types.rs:304-313 \u2014 before extracting anything, compare \u0060etw-reader/src/etw_types.rs\u0060 and \u0060samply/src/windows/etw_reader/etw_types.rs\u0060 as WHOLE FILES: this scan already matched 8 separate duplicated blocks between them, totalling at least 77 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/etw_types.rs"},"region":{"startLine":304}}}],"partialFingerprints":{"codehealthFindingId/v1":"22d6447d2228d6bc68be642ee882b9a541b34c8b61d4571729f21e0c8c19d161"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): etw-reader/src/lib.rs:113-120 | samply/src/windows/etw_reader/mod.rs:113-120 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":113}}}],"partialFingerprints":{"codehealthFindingId/v1":"9a405f2c53f3a169757a9b18cb2ac0366ef5564b7981f85f5a50696db55d50ca"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): etw-reader/src/parser.rs:131-140 | samply/src/windows/etw_reader/parser.rs:131-140 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":131}}}],"partialFingerprints":{"codehealthFindingId/v1":"ebb49cd3b4210f19b1e6ac75e432260c0d50094da09a2d980f50e271a9cd9baa"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): etw-reader/src/parser.rs:632-637 | samply/src/windows/etw_reader/parser.rs:632-637 \u2014 before extracting anything, compare \u0060etw-reader/src/parser.rs\u0060 and \u0060samply/src/windows/etw_reader/parser.rs\u0060 as WHOLE FILES: this scan already matched 17 separate duplicated blocks between them, totalling at least 325 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":632}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a2409da20f5dcd15cb232edd1ca9711fbfb8366eb8ca72db59c335929b25dc9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): etw-reader/src/schema.rs:235-244 | samply/src/windows/etw_reader/schema.rs:235-244 \u2014 before extracting anything, compare \u0060etw-reader/src/schema.rs\u0060 and \u0060samply/src/windows/etw_reader/schema.rs\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 78 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/schema.rs"},"region":{"startLine":235}}}],"partialFingerprints":{"codehealthFindingId/v1":"4ecd5693871283b29964c32bac79fa70c826c8d81f7c1c5a9cb88cdecacbf286"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): etw-reader/src/utils.rs:58-63 | samply/src/windows/etw_reader/utils.rs:62-67 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/utils.rs"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"edb87dfcdbccf715bb3f024b80b8c19fb3da376462a30f375325fe77653683c1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 3): samply/src/linux_shared/process_threads.rs:210-216 | samply/src/mac/task_profiler.rs:786-792 | samply/src/windows/profile_context.rs:2204-2210 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/process_threads.rs"},"region":{"startLine":210}}}],"partialFingerprints":{"codehealthFindingId/v1":"d83ffb14e060b3e0bffc4fd15c5baa776f9e3f707010ea19b9c20f65432718c8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): samply-symbols/src/symbol_map_object.rs:476-484 | samply/src/linux_shared/svma_file_range.rs:15-23 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/symbol_map_object.rs"},"region":{"startLine":476}}}],"partialFingerprints":{"codehealthFindingId/v1":"cab923dd73e01464dee898ea3ba1e68e603e829f52b746d08d3c60679722c955"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): samply-symbols/src/symbol_map_object.rs:486-494 | samply/src/linux_shared/svma_file_range.rs:25-33 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/symbol_map_object.rs"},"region":{"startLine":486}}}],"partialFingerprints":{"codehealthFindingId/v1":"36b5b96231ff6d8920fde3c99745e7d747b66315affbfdbd3fa0d51095f1ff0d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): samply/src/linux_shared/vdso.rs:21-30 | wholesym/src/vdso.rs:16-25 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/vdso.rs"},"region":{"startLine":21}}}],"partialFingerprints":{"codehealthFindingId/v1":"d9315586dbfdaad8bdc61fef49d2ac2300c0dc134d1631df25a75cd286e31cac"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): samply-mac-preload/src/mach_ipc.rs:113-118 | samply/src/mac/mach_ipc.rs:143-148 \u2014 before extracting anything, compare \u0060samply-mac-preload/src/mach_ipc.rs\u0060 and \u0060samply/src/mac/mach_ipc.rs\u0060 as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_ipc.rs"},"region":{"startLine":113}}}],"partialFingerprints":{"codehealthFindingId/v1":"fa4e96510a1f411a6630aa49ca9c4b8b548c3030525b5d42156ef4ed173f6675"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): samply-mac-preload/src/mach_ipc.rs:297-309 | samply/src/mac/mach_ipc.rs:348-360 \u2014 before extracting anything, compare \u0060samply-mac-preload/src/mach_ipc.rs\u0060 and \u0060samply/src/mac/mach_ipc.rs\u0060 as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_ipc.rs"},"region":{"startLine":297}}}],"partialFingerprints":{"codehealthFindingId/v1":"c6321c23a1c732f16437e4f6e347638001ded6a8b57a16a6da9a71a40cab3bec"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 4): samply-symbols/src/symbol_map_object.rs:911-915 | samply-symbols/src/symbol_map_object.rs:917-921 | samply-symbols/src/windows.rs:320-324 | samply-symbols/src/windows.rs:326-330 \u2014 there are 4 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/symbol_map_object.rs"},"region":{"startLine":911}}}],"partialFingerprints":{"codehealthFindingId/v1":"6218c1cc1881c0a1a35f147af190317a6f25abdccb6190d2139adb46330bc8b2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): samply/src/linux_shared/process.rs:336-346 | samply/src/windows/profile_context.rs:347-357 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/process.rs"},"region":{"startLine":336}}}],"partialFingerprints":{"codehealthFindingId/v1":"36a658016d7d2e6eeb6eb068fe9467dc807015bbf4a4613a9c965b78d36e2ff4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): samply/src/windows/coreclr.rs:595-604 | samply/src/windows/coreclr.rs:648-659 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/coreclr.rs"},"region":{"startLine":595}}}],"partialFingerprints":{"codehealthFindingId/v1":"f159551d2a605134edc1599e94e4196f81530f931a74dc6b9b1dede3b73685ac"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): samply-symbols/src/breakpad/index.rs:1027-1033 | samply-symbols/src/breakpad/index.rs:1038-1044 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/breakpad/index.rs"},"region":{"startLine":1027}}}],"partialFingerprints":{"codehealthFindingId/v1":"433a40e84f69d0c3c740e2a84a233fa1c1b733226164087f9f787bd7d82d13b6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): fxprof-processed-profile/src/native_symbols.rs:179-185 | fxprof-processed-profile/src/stack_table.rs:148-153 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fxprof-processed-profile/src/native_symbols.rs"},"region":{"startLine":179}}}],"partialFingerprints":{"codehealthFindingId/v1":"27db224d4740951a66b31e9376727d4bcae337991d069768a8c136a49b25c7e3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): samply-symbols/src/breakpad/symbol_map.rs:81-85 | samply-symbols/src/elf.rs:187-191 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/breakpad/symbol_map.rs"},"region":{"startLine":81}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d6c9a7bf898b43ebadac6e6ac6c23711170fd12b2f38c6127c095961977b683"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 3): samply/src/mac/process_launcher.rs:207-211 | samply/src/mac/process_launcher.rs:215-219 | samply/src/mac/process_launcher.rs:223-227 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/process_launcher.rs"},"region":{"startLine":207}}}],"partialFingerprints":{"codehealthFindingId/v1":"849e2c56148a37c9a645d3104c7f23baac6f31f75e3ea165e9b64c89e0814efb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): etw-reader/src/lib.rs:492-501 | samply/src/windows/etw_reader/mod.rs:492-501 \u2014 before extracting anything, compare \u0060etw-reader/src/lib.rs\u0060 and \u0060samply/src/windows/etw_reader/mod.rs\u0060 as WHOLE FILES: this scan already matched 20 separate duplicated blocks between them, totalling at least 346 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":492}}}],"partialFingerprints":{"codehealthFindingId/v1":"711332bcd6674dd2a41d76535725bfa4dd19c3562c142f17c63f238147b7d660"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): samply-mac-preload/src/mach_ipc.rs:367-371 | samply/src/mac/mach_ipc.rs:395-399 \u2014 before extracting anything, compare \u0060samply-mac-preload/src/mach_ipc.rs\u0060 and \u0060samply/src/mac/mach_ipc.rs\u0060 as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/mach_ipc.rs"},"region":{"startLine":367}}}],"partialFingerprints":{"codehealthFindingId/v1":"f4c30b71debe8a45380cec86591388d9ca41d01c680443f97938b341e34fc26a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): samply-mac-preload/src/lib.rs:132-136 | samply-mac-preload/src/lib.rs:150-154 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-mac-preload/src/lib.rs"},"region":{"startLine":132}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6b42cf8d785dbb85ed488208339badad8c2e32b0ac1e070cad3a5ebf1494c16"}},{"ruleId":"D5","level":"warning","message":{"text":"Off the main sequence: samply-quota-manager: samply-quota-manager: abstractness 0.00, instability 0.00, distance 1.00 \u2014 zone of pain \u2014 concrete and depended on by 1 project(s), so it\u0027s rigid to change."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"3de3187707c4e5df8ec58c9db5adc3a91f1f6c5126be72eef963811dcfaf575e"}},{"ruleId":"D5","level":"warning","message":{"text":"Off the main sequence: fxprof-processed-profile: fxprof-processed-profile: abstractness 0.09, instability 0.00, distance 0.91 \u2014 zone of pain \u2014 concrete and depended on by 1 project(s), so it\u0027s rigid to change."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"b953850ebf2f9f49a906a91e22b69d5c7ae614d50cfe7da931fb7bc06dbec5b1"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: SymbolManagerConfig (LCOM4 13): SymbolManagerConfig\u0027s methods fall into 13 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 13 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/config.rs"},"region":{"startLine":11}}}],"partialFingerprints":{"codehealthFindingId/v1":"04bc1a24a34b9a00f19cd43740f520da31be24ffa86cf74066eec47b8bda37c4"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: samply-symbols/src/symbol_map_object.rs: samply-symbols/src/symbol_map_object.rs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in SymbolList::new at line 194. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-24..2026-09-22, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-06-24 16:24:55 -04:00\u0027 --until=\u00272026-09-22 16:24:55 -04:00\u0027 --full-history --no-merges -- samply-symbols/src/symbol_map_object.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/symbol_map_object.rs"},"region":{"startLine":194}}}],"partialFingerprints":{"codehealthFindingId/v1":"273d875631dedfa6db2a9789d01a5829dcb78fec5143b3aa45197af84b58ef1d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO I don\u0027t know what the true cutoff is. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/examples/log-stacks.rs"},"region":{"startLine":14}}}],"partialFingerprints":{"codehealthFindingId/v1":"10cc06cbe73be712972cae66edf143293824d4f3fd7593ee3252ce0c84e5983c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Make sure is aligned \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/utils.rs"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"2cf3e256ac4dca5062be2e67c82a68b700a6cb11de75df57ee0024c9d3e76d9d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Make sure is aligned \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/utils.rs"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"20c1fed02c4ce0fdb7f2ad12ffd4c3a369b8a412ca62e4fffa09a8696e30e7f4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Make sure is aligned \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/utils.rs"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"370ebc0e992465be82660cddad8033da1886608977774a918178826ed166e10a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Make sure is aligned \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/utils.rs"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a7187f773277c017a71ec500e8faf6ec69e93541be93bbe6f069b530d5387ed"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Cloning for now, should be a reference at some point... \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/schema.rs"},"region":{"startLine":195}}}],"partialFingerprints":{"codehealthFindingId/v1":"cfea1ef95129583edd4734ab69ed6c2a90d9b612e7fb4b39aacd16ba716780da"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Cloning for now, should be a reference at some point... \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/schema.rs"},"region":{"startLine":195}}}],"partialFingerprints":{"codehealthFindingId/v1":"b55a5c6ad3f2cf8c34aa1bf51e509cc94fb7d562f981ee77f0583e2bdd80b3d2"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Not a big fan of this, think a better way.. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/schema.rs"},"region":{"startLine":262}}}],"partialFingerprints":{"codehealthFindingId/v1":"231c2ea7ab591e0d3dc5da747bb364f66b30022b794c2f43ad383c73f66ff104"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Not a big fan of this, think a better way.. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/schema.rs"},"region":{"startLine":262}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ff662f76099a311bbe39471167374c07fed7fca0ebdde425e4d908216a76f3c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Find a way to use turbofish operator \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"e80772d598d43992f1f5aab0e6f2300014764b7a9e7d642e27134576f9d2b832"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Find a way to use turbofish operator \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/parser.rs"},"region":{"startLine":89}}}],"partialFingerprints":{"codehealthFindingId/v1":"bee5abe62bd7748c6a05001e5251583f406f1e3498ca9476333babc0a0a2685a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Find a cleaner way to do this, not very happy with it rn \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":174}}}],"partialFingerprints":{"codehealthFindingId/v1":"1bc4f643e0beda864c7b875ddf0304c24e4fa51c1716c92331895537e7daf118"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Find a cleaner way to do this, not very happy with it rn \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/parser.rs"},"region":{"startLine":174}}}],"partialFingerprints":{"codehealthFindingId/v1":"367e3d23ff33a1ee78e750c7df2c208d1f23ed03f5ac73ec45988d05ff03f097"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Study heuristic method used in krabsetw :) \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":185}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f6b611c99ce2fd368fdda262cefdf356a699f13238586805983f2d4b4b72ceb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Study heuristic method used in krabsetw :) \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/parser.rs"},"region":{"startLine":185}}}],"partialFingerprints":{"codehealthFindingId/v1":"57c88c7a2d420e6b4b6207cbb182ccc6eb84bf9a01cc61462465fe2ea9bfbbf3"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Find a way to do this with an iter, try_find looks promising but is not stable yet \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":238}}}],"partialFingerprints":{"codehealthFindingId/v1":"8ac322f1ec83c386bd9a116fd145d8b34cbb6f79526589d9abffd38c3f50f301"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Find a way to do this with an iter, try_find looks promising but is not stable yet \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/parser.rs"},"region":{"startLine":238}}}],"partialFingerprints":{"codehealthFindingId/v1":"257619567ca488b7d203d5c6f0e47ede5f20867cb60f436ccca266f1340eb5db"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Clean this a bit, not a big fan of this loop \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":239}}}],"partialFingerprints":{"codehealthFindingId/v1":"1bee87c75ae03d7bfbd8308dc8359132f7b2932555d61c9494d7016b0c5a7cee"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Clean this a bit, not a big fan of this loop \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/parser.rs"},"region":{"startLine":239}}}],"partialFingerprints":{"codehealthFindingId/v1":"b5bcba9f16acec139b59da69c692bad55053933d166bd5755c0941077f49d450"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Handle errors and type checking better \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":484}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3a6bb8211752bed35ef8d4d1f34d39d5e4edfbd9a94fbdf8e5084a97555d988"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Handle errors and type checking better \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/parser.rs"},"region":{"startLine":484}}}],"partialFingerprints":{"codehealthFindingId/v1":"bf90ef5167c765be16661a1f894b69a249eaa7df5dcb047db0e9c2a82125c4a0"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Implement SocketAddress \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":640}}}],"partialFingerprints":{"codehealthFindingId/v1":"46340b850885d44f72b03c157caecb046191cf947c3297c4eb32067f36ab5d63"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Implement SocketAddress \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/parser.rs"},"region":{"startLine":640}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce8e9cbf216271eecd40a6de815717c3a46e55375906d43496612ad2d0373824"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Study if we can use primitive types for HexInt64, HexInt32 and Pointer \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/parser.rs"},"region":{"startLine":641}}}],"partialFingerprints":{"codehealthFindingId/v1":"d89e4fd36e65fa5b63f66038607a81a066d333a40415a32647b813d1217c1a77"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Study if we can use primitive types for HexInt64, HexInt32 and Pointer \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/parser.rs"},"region":{"startLine":641}}}],"partialFingerprints":{"codehealthFindingId/v1":"9829b8a1c812d2ff7518b20109fd2c9f9bdcfbe199e056342e688c250893c1b4"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Add Filters option \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":162}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d045cd08d50fa92d484e59d1427caf8a0f12ceb5baa161071f5d9716c886cdb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Add Filters option \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/mod.rs"},"region":{"startLine":162}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a143a5a9fcd3506596a854119355acd57f6fc45132582f658f3c7cc21b32a16"}},{"ruleId":"D17","level":"warning","message":{"text":"FixmeComment: // Fixme: EVENT_CONTROL_CODE_ENABLE_PROVIDER \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":284}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef6bc897b837e70ec7bfe26c44a27ac2349f05974638bb38a669c432ad85ef6b"}},{"ruleId":"D17","level":"warning","message":{"text":"FixmeComment: // Fixme: EVENT_CONTROL_CODE_ENABLE_PROVIDER \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/mod.rs"},"region":{"startLine":284}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b0c0de82efb99f1782e31ab2bdba8d8d81f79c56abfe06889b8950917c9cd5c"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: we should be using the out_type here instead of in_type \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/lib.rs"},"region":{"startLine":409}}}],"partialFingerprints":{"codehealthFindingId/v1":"12a03ba7975c911889f918d2dc1aa1865931d2a9cd14a1f4ba836e056b2c60af"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: we should be using the out_type here instead of in_type \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/mod.rs"},"region":{"startLine":409}}}],"partialFingerprints":{"codehealthFindingId/v1":"76b4c458e8906be9fca167ac3209184001bf00a0a0acf66bb7749bdc1a11a568"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Evaluate performance, but this sounds better than creating a whole Vec\u003Cu16\u003E and getting the string from the offset/2 \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/etw_types.rs"},"region":{"startLine":259}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2a15df05ff4e0725b329b97167236a598575127a590384f9d87e31784983f30"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Evaluate performance, but this sounds better than creating a whole Vec\u003Cu16\u003E and getting the string from the offset/2 \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/etw_types.rs"},"region":{"startLine":259}}}],"partialFingerprints":{"codehealthFindingId/v1":"4ebb828049a2b454cd1f98f9c223a136debc809e595160662e96b8932600cbc8"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: use an enum for these \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/custom_schemas.rs"},"region":{"startLine":704}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e678dffe8630659f3c723622f19a4ae35204e5263c17873b42c09b85de10c3c"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: use an enum for these \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/etw_reader/custom_schemas.rs"},"region":{"startLine":704}}}],"partialFingerprints":{"codehealthFindingId/v1":"e7ee84e7d4295084e6eb7a7029e2521d4fd8681b4db6746a2627cc25a1a86942"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove unused hex address strings from the string table. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fxprof-processed-profile/src/profile.rs"},"region":{"startLine":1230}}}],"partialFingerprints":{"codehealthFindingId/v1":"1328175ff6ac143d1a7e5e89dc269ee0c58b356247c08a1a3b771be43afd03f3"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Add tests for SubcategoryHandle, ProcessHandle, ThreadHandle \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"fxprof-processed-profile/tests/integration_tests/main.rs"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c96e5bd247901bbf0b391c91e42ed401d7f3f8c7fda3fd432a4f7648408c56d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: /// TODO - This is not supported yet. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"gecko_profile/src/markers.rs"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a8222714a764d859c9f794c3f14a258b7ea1f6949e787cd8a8fc98cdc02b4d3"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Get the correct max length for this arch \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-api/src/asm/mod.rs"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c8892e04bf414312dc29df89aad1f05a1bf09ba23a4d3b56054d7f6df50a64c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Extract branch targets for x86 protected mode if needed. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-api/src/asm/mod.rs"},"region":{"startLine":426}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b7dcb2976ed0dbdc2ce1ef2c0e337c60fc7ed65f07e1b2e27d3235a94554276"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Detect whether the instructions in the requested address range \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-api/src/asm/mod.rs"},"region":{"startLine":519}}}],"partialFingerprints":{"codehealthFindingId/v1":"8dbf457e9ea1502dbebdf22d6e8ffb59ca7780dd6c6c58efedac7cb33432723d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-api/tests/integration_tests/main.rs"},"region":{"startLine":353}}}],"partialFingerprints":{"codehealthFindingId/v1":"cd7b3fe0fbeae3c03d985c1c4cf777a7941755970e34e1999dd1cdf21adc3221"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/windows.rs"},"region":{"startLine":276}}}],"partialFingerprints":{"codehealthFindingId/v1":"f314cff663845d67c7e64f0dc680342c94806a4581f9156d26159183a85ff386"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/tests/integration_tests/main.rs"},"region":{"startLine":181}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9f5eeee874a6ca4206978ae3455d678c4a7785d69e6e43c8a6c561d4b453150"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/thread_profiler.rs"},"region":{"startLine":220}}}],"partialFingerprints":{"codehealthFindingId/v1":"19692e79f3e4b7ae44cdd54bf8afd4cf3e92a35b0a065a52dffa75e12b2ccd12"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/coreclr.rs"},"region":{"startLine":667}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ac981f1f147d83396edb0d2146a4d7ebd1dcf766ceb026e881e8628a8be1156"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/coreclr.rs"},"region":{"startLine":670}}}],"partialFingerprints":{"codehealthFindingId/v1":"271525ba9a01738712fc3d1b24fa7fde8dd95ab28ce53cf373e3bec268d8e053"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/debuginfod.rs"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b65d94cf39701173639309ab69b69cce948bc01983296e812f4b30a839c885d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/debuginfod.rs"},"region":{"startLine":92}}}],"partialFingerprints":{"codehealthFindingId/v1":"b511eebd88841f0f083a94514aa9f348be74a16dd1855639178574aa9cc3e6e5"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Convert svma into rva by subtracting the image base address. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/windows.rs"},"region":{"startLine":271}}}],"partialFingerprints":{"codehealthFindingId/v1":"dda495995fdbca94780efd1c6d7a1f9c976ed974e4778940a20be00ddf34304d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: /// TODO: document \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/shared.rs"},"region":{"startLine":187}}}],"partialFingerprints":{"codehealthFindingId/v1":"74aa276bfd7c6102873d2a7c64a187522f4f4c9ae76ca2217b36e7b306333493"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Read symbol server config from some kind of config file \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/symbols.rs"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"afc70cebfe432c552efbbc8f6c96fe0f9920740443266c6fdb43cd22a1824019"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: On Windows, put https://msdl.microsoft.com/download/symbols into the config file."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/symbols.rs"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"b8605d25011ab2acfd7686f2776b66a72d529d696ce13b23485683f8cff6e6b7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Use for perf.data import \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/cli.rs"},"region":{"startLine":383}}}],"partialFingerprints":{"codehealthFindingId/v1":"539bf76644f821235b993fe12a834a7711fc8f49c8fe4647f83e8302daacd3ba"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: /// TODO: We should not do this adjustment if the length of 16 was written down in \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/import/perf.rs"},"region":{"startLine":297}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a9811a70d385565274286c70df7429e4581eda81d067dd095b5d483115a669c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Implement, by sudo launching a helper process which opens cpu-wide perf events \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux/profiler.rs"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"87880c9a22516bd69ae6847a61adb232217ed85198b339a00eee9e7e12b71705"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: implement unlink_aux_files for linux \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux/profiler.rs"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f298f0de057d4d6db85c1fed83f379f58103db388c4de5e6df1ba8f942d2ec6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Gather threads / processes recursively, here and in PerfGroup setup. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux/profiler.rs"},"region":{"startLine":447}}}],"partialFingerprints":{"codehealthFindingId/v1":"293f63774d71871cae8258e7a8951ebc0524723b7c8f31f09754b2bdb55b81ce"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // Assume that we\u0027re using a nanosecond clock. TODO: Check how we can know this for sure \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/event_interpretation.rs"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f43662ec809346e7901ff771354abe822839e2c4bc27f0c7346c47e5b2991c7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Detect event type \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":316}}}],"partialFingerprints":{"codehealthFindingId/v1":"e2c0c0dad29092507a0803419ec2c0ddd6915193bc5a7ff7b0bb200e3214a713"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Find out why .vdex and .jar mappings with symbols aren\u0027t \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":762}}}],"partialFingerprints":{"codehealthFindingId/v1":"4269e1d06ca86895a59bc70654b0c0ec19bd96283a7f6af984d3545d90041815"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: endian \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":1391}}}],"partialFingerprints":{"codehealthFindingId/v1":"a5180dff520e01ca386981bc762cd4cf8f53cd1a50903c540bdd092ed3c560ee"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: endian \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":1558}}}],"partialFingerprints":{"codehealthFindingId/v1":"42e4fe5af52522ec31848c507ab78a5269a01ce9e95f0336c2549c973ddb2d11"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Detect which thread the jitdump file is opened on, and use that thread\u0027s \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/task_profiler.rs"},"region":{"startLine":575}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c5850ddced4bc414a6b12d0f5dc7dc47285dd7d52c9ca7425a9546a356d2f23"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: give status back via task_sender \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/profiler.rs"},"region":{"startLine":168}}}],"partialFingerprints":{"codehealthFindingId/v1":"75741c7493a49a12ad087a0caefa74a909be6076609757ca7be939c60c99df58"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // infoArrayChangeTimestamp is 10.12\u002B. TODO: check version \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/proc_maps.rs"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"294f2a54c742fadb3a498dbfa2b62f9c024c8fc058a5b549b9b64f78543f5d08"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: custom \u0022unaligned address\u0022 error \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/proc_maps.rs"},"region":{"startLine":766}}}],"partialFingerprints":{"codehealthFindingId/v1":"a9439aca3cf6a3ac825c2b9ac10b9dc93b5e7158aae73d51b0aea2cb79f2f048"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: custom \u0022unaligned size\u0022 error \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/proc_maps.rs"},"region":{"startLine":769}}}],"partialFingerprints":{"codehealthFindingId/v1":"772ca0d1efe6a959aeee233b293eeb7d2be07b8355680241918649c365180d15"}},{"ruleId":"D17","level":"warning","message":{"text":"FixmeComment: // FIXME(pcwalton): Does this leak? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/mac/mach_ipc.rs"},"region":{"startLine":236}}}],"partialFingerprints":{"codehealthFindingId/v1":"05a61c1bd03fefa605a65e7c70793f7dc191b9822cbfddedf54cd175a4040858"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // todo: respect when converting perf.data \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/shared/prop_types.rs"},"region":{"startLine":129}}}],"partialFingerprints":{"codehealthFindingId/v1":"0213f860b42edff02eb1211f0f8519c8b7ee14f1760250f5c38a29686ea50f4d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // todo: respect when converting perf.data \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/shared/prop_types.rs"},"region":{"startLine":133}}}],"partialFingerprints":{"codehealthFindingId/v1":"1edb420f66bb656002caa0bcd9e876137b608eebafc4351a3bcc2cfdd1be0a27"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Add to unwinder so that it can use the code bytes for prologue / epilogue detection \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/shared/jitdump_manager.rs"},"region":{"startLine":227}}}],"partialFingerprints":{"codehealthFindingId/v1":"326e3961c27b8fc65c732a1510f4a40c993cb2978224e45b6379b37b0593942e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove from \u002B add to unwinder \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/shared/jitdump_manager.rs"},"region":{"startLine":238}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b360d889207863cd43aef5f3c561a15b693c4469ad09dac1201225ea4ef60c9"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Queue up, and add to unwinder on next CodeLoad \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/shared/jitdump_manager.rs"},"region":{"startLine":241}}}],"partialFingerprints":{"codehealthFindingId/v1":"2bdb8627d2f8694f9b35c49bf1ae132b902f756a5571585ce7de985ea1e1309e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Remove once the perf.data importer respects IncludedProcesses \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/shared/included_processes.rs"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"5cd46700ccdd317c922e768ee8e579cdb9b9dd67fc790738eafd9e1115f30d85"}},{"ruleId":"D17","level":"warning","message":{"text":"HackComment: // hack argument lets things still continue to run for development of samply. \u2014 a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/xperf.rs"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"0887dedfd68f309170d5123e05df60cd9963664033d8729fc0953de7738be9f9"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO elevate with \u0022runas\u0022 verb to pop up UAC dialog. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/winutils.rs"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"9e5890627e9e37fa34eb78224d3a8eaa9361486136063e3f3bc9de32373783ad"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Respect recording_props.time_limit, if specified \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profiler.rs"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"09c07accdf324f828a9159ec3de9eb787cea794b9efb300128c8219888046879"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Respect recording_props.time_limit, if specified \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profiler.rs"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"48eff6f37fbc5a9b2ee974e725b2686358d8776538020e96e56933891a029f38"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: check that process with this pid exists \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profiler.rs"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba258e4509515c4ee9e427fa1b6914f1717992ee517c7f1a062f6b94d6fe5c79"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Do the child waiting and the xperf control on different threads, \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profiler.rs"},"region":{"startLine":99}}}],"partialFingerprints":{"codehealthFindingId/v1":"fa0276427cbd9fb76dab31d07fc62dbad153a0e7394deb3331aa0242f233eeee"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO no idea how to handle \u0022I\u0027m on aarch64 windows but I\u0027m recording a win64 process\u0022. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profile_context.rs"},"region":{"startLine":483}}}],"partialFingerprints":{"codehealthFindingId/v1":"beb55148dec8c6127c693cb521349338872975f6c2ee0d749a1efd4ceb11935f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO -- is this because I can\u0027t use PROFILE events in the VM? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profile_context.rs"},"region":{"startLine":1121}}}],"partialFingerprints":{"codehealthFindingId/v1":"c53edb3c2d01f93662bfc4d3e30cd05de7d0ef8c42873ae597c5b21a4628042e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Consider adding a marker here \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profile_context.rs"},"region":{"startLine":1440}}}],"partialFingerprints":{"codehealthFindingId/v1":"f0d5fac9d695df64658d27347f4f74bb6d2e18418ce6d3f46be6af9a00a6b160"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Find out if this actually is the right way to check whether a thread \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profile_context.rs"},"region":{"startLine":1594}}}],"partialFingerprints":{"codehealthFindingId/v1":"74dd9eca636f89e4000aca1c9ad5a564a92d9532d8d4cd74eaf860497245aade"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Detect arch from file \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/import.rs"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"768d4fb828b6209864c3dff0f67e60ff637353b2a34724c2c3c2972087a8d630"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO -- we may need to use the rundown provider if we trace running processes \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/coreclr.rs"},"region":{"startLine":384}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3cc178c2006319109dc46d6e8eafc3fe6ace0b0f507e8f948d249955033a559"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: R2R doesn\u0027t have a size? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/coreclr.rs"},"region":{"startLine":422}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0e492b1f2c19bea259f90156f7a2c7edcd7145e38db2cd1689473f17881426f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: convert to str, with bulk type data \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/coreclr.rs"},"region":{"startLine":529}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2c28c98a927d9c2810a141dcb59f627fdef6ef6df5f95ea55c9dcad254b784a"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: use gc_type_str as the name \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/coreclr.rs"},"region":{"startLine":631}}}],"partialFingerprints":{"codehealthFindingId/v1":"0562f492f0cc1c436219996172fea5d5dfe6364b10110ca1da3ad0be61a17f0e"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: create an interval \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/coreclr.rs"},"region":{"startLine":673}}}],"partialFingerprints":{"codehealthFindingId/v1":"b8fc54c08dcad97d7a8c8be8e8d2d8260e8d6f599e3c716c98d3afa58bee3bfb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: load source file via debuginfod \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/file_resolver.rs"},"region":{"startLine":141}}}],"partialFingerprints":{"codehealthFindingId/v1":"887298790f17b47f9d1e0c04bcb673107b96295c36e7202412d91040c79fe2b3"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Add timeouts \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/downloader.rs"},"region":{"startLine":243}}}],"partialFingerprints":{"codehealthFindingId/v1":"62db55b51a4dd4cf794d90b54ab860cfe809e35de3d73fb7dafebbdce8ddc898"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Once \u0022official debuginfod\u0022 is supported, change this to: \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/config.rs"},"region":{"startLine":150}}}],"partialFingerprints":{"codehealthFindingId/v1":"3dfd5ff0a6b3eebfcf578913beb4b2e5fad5cd43dbcce7a5955e02e8adc56119"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Once \u0022official debuginfod\u0022 is supported, change this to: \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/config.rs"},"region":{"startLine":161}}}],"partialFingerprints":{"codehealthFindingId/v1":"57323b08d01febcb0e57c7fbb90c1c50fec6de2d57a2f990c77af25daa91d92d"}},{"ruleId":"D20","level":"note","message":{"text":"No ADRs found: No ADRs found. No recognised ADR directory (\u0060docs/adr/\u0060, \u0060docs/decisions/\u0060, \u0060adr/\u0060, \u0060docs/rfcs/\u0060, an \u0060ADR0001/\u0060 folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (\u0060docs/adr/use-postgres.md\u0060, \u0060docs/adr/2024/0001-x.md\u0060); or a file anywhere whose name is ADR-shaped (\u00600001-use-postgres.md\u0060, \u0060adr-012-caching.md\u0060); or, when neither turned anything up, a document carrying the decision-record signature (an \u0022Architecture Decision Record\u0022 heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these \u2014 unnumbered files outside any recognised directory, without those headings \u2014 is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in \u0060docs/adr/\u0060."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"d2bea044ff79d7d275f5a91a6e2f548586178eaf480274c33960ad020c854631"}},{"ruleId":"D22","level":"warning","message":{"text":"Inconsistent naming for property retrieval/access. \u0060TraceEventInfoRaw\u0060 exposes a raw pointer accessor with a generic name \u0060info_as_ptr\u0060, while the \u0060Parser\u0060 component uses \u0060find_property\u0060 to locate specific data. More critically, \u0060TypedEvent\u0060 and \u0060EventSchema\u0060 both expose \u0060property(index: u32): Property\u0060, but \u0060Parser\u0060 uses \u0060find_property(name: str)\u0060. This forces consumers to use different methods (\u0060find_property\u0060 vs \u0060property\u0060) depending on whether they are using the low-level \u0060Parser\u0060 or the higher-level \u0060TypedEvent\u0060/\u0060EventSchema\u0060 abstractions, despite both ultimately accessing event properties.: Unify property access. Either expose \u0060property(index)\u0060 on \u0060Parser\u0060 for consistency with \u0060TypedEvent\u0060, or expose \u0060find_property(name)\u0060 on \u0060TypedEvent\u0060/\u0060EventSchema\u0060 for consistency with \u0060Parser\u0060. Given \u0060TypedEvent\u0060 is the primary user-facing type, \u0060Parser\u0060 should likely support index-based access or be deprecated in favor of \u0060TypedEvent\u0060. (signatures: etw_reader.etw_types.TraceEventInfoRaw.info_as_ptr(): *mut u8 | etw_reader.parser.Parser.find_property(name: str): ParserResult)"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"41dac0886039f5f3dd190e1644e89fa44b9fc74327bcacacaf66ac64e7c83834"}},{"ruleId":"D22","level":"warning","message":{"text":"Redundant API surface for schema registration. \u0060SchemaLocator\u0060 has an instance method \u0060add_custom_schema\u0060, but the module-level function \u0060etw_reader.add_custom_schemas\u0060 takes a \u0060SchemaLocator\u0060 as an argument. It is unclear if the module function performs a different operation (e.g., global registration) or if it is a redundant wrapper. If it just calls the instance method, the module function is unnecessary noise. If it does something else, the naming is ambiguous.: Remove the module-level \u0060add_custom_schemas\u0060 if it merely delegates to the instance method, or rename it to clearly indicate a global scope (e.g., \u0060register_global_custom_schemas\u0060) if that is the intent. (signatures: etw_reader.schema.SchemaLocator.add_custom_schema(schema: Box) | etw_reader.add_custom_schemas(locator: SchemaLocator))"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"01f3e987d69d5c8d54019c3ef3ba6d21ff2de3acfd303e3286807f904ac8ae3a"}},{"ruleId":"D22","level":"warning","message":{"text":"Inconsistent naming for handle creation. The \u0060Profile\u0060 type uses \u0060handle_for_\u0060 prefix for creating handles for categories, strings, frames, etc. However, \u0060InternalCategory\u0060 uses \u0060index_for_subcategory\u0060. This mixes \u0027handle\u0027 and \u0027index\u0027 terminology for similar concepts (identifiers/lookups) within the same domain. Additionally, \u0060handle_for_frame_with_label\u0060 and \u0060handle_for_frame_with_address\u0060 are distinct methods for similar intents (getting a frame handle), which is acceptable, but the lack of a unified \u0060handle_for_frame\u0060 with a discriminator or enum argument increases API complexity.: Standardize on \u0060handle_for_\u0060 for all handle creation methods. Rename \u0060index_for_subcategory\u0060 to \u0060handle_for_subcategory\u0060 or \u0060sub_category_handle\u0060 to match the \u0060Profile\u0060 API. Consider consolidating frame handle creation into a single method with a \u0060FrameSource\u0060 enum argument. (signatures: fxprof_processed_profile.profile.Profile.handle_for_category(category: Category): CategoryHandle | fxprof_processed_profile.profile.Profile.handle_for_subcategory(category_handle: CategoryHandle, subcategory_name: str): SubcategoryHandle | fxprof_processed_profile.profile.Profile.handle_for_string(s: str): StringHandle | fxprof_processed_profile.profile.Profile.handle_for_frame_with_label(...) | fxprof_processed_profile.profile.Profile.handle_for_frame_with_address(...))"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"5a8b23042553676e7258c07dcd899cbb60f47bd4f9f808b97ef4ecc760c837e2"}},{"ruleId":"D22","level":"warning","message":{"text":"Confusing separation of concerns between \u0060Api.build_query\u0060 and the specific \u0060*ApiQueryState\u0060 constructors. \u0060Api.build_query\u0060 takes a URL and JSON, while the specific query states (Source, Symbolicate) have \u0060from_request_json\u0060 constructors. It is unclear how \u0060Api.build_query\u0060 relates to these specific states. If \u0060Api.build_query\u0060 is a factory, it should return the appropriate \u0060ApiQueryState\u0060 or a generic builder. The existence of multiple \u0060from_request_json\u0060 methods on different types suggests a lack of a unified entry point for query processing.: Introduce a unified \u0060QueryBuilder\u0060 or \u0060Api::create_query\u0060 method that returns a generic \u0060ApiQueryState\u0060 or a specific typed state based on the request content, removing the need for users to manually instantiate \u0060SourceApiQueryState\u0060 or \u0060SymbolicateApiQueryState\u0060 directly. (signatures: samply_api.Api.build_query(request_url: str, request_json_data: str): Result | samply_api.query_state.ApiQueryState.from_request_json(request_json: str): Result | samply_api.source.SourceApiQueryState.from_request_json(request_json: str): Result | samply_api.symbolicate.SymbolicateApiQueryState.from_request_json(request_json: str): Result)"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"56fbeee8997a8d4474a747c0a3bd5b3d0953ed6042d58b1eda2580c8f1137654"}},{"ruleId":"D26","level":"note","message":{"text":"Split samply: Catch-all name that is huge (23k LoC) and sprawls across nine namespaces. Suggested: split into domain-specific libraries for each of the nine namespaces"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"017a5f951548de993c3aeaac592d8b635fd6b886f5d24895aea004aa009d11f5"}},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"d5b8f11381d61a58459ffc7c595fd52d09c03c711894a63a9578043d2338412b"},"taxa":[{"id":"CWE-829","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"ad3c8f50e10a50def904c39179d9e606d727633a2874b77a3811d23fc2e880cb"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"f0f948da2edb676740300a4e01c764b96ed135269013139fc5d41859af62cee5"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"b21ef51d97f04d1a8b921e635aca9ef4e877341aa2c3b0f6eaeabc61234774b6"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"06daafe2709e468287b505c00bf9feb366987173d1ade4b317a3c3dfe35f4e51"},"taxa":[{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"6819b36024d45f5f0e1d43e74427f1e72c7d8dae5d09101e0f966a51bf6829ab"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"f1b966c70d2e5f6ab697ac6d268d54938c60e802d8ea58ea6ff9cb7e10a35f70"},"taxa":[{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"ae59d5e9dd2c30e110a21be3f2f3e4339df91ffb4154cfcf5f17bedb858ec684"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"6504d8d1633fd2629c17cb911821ef9d4b240f323d5e1ebac2df01ac4726a04a"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"f4c98c98541a54b0a01af4adaa864ceaab9a6f71372985da44cfe686401ae741"},"taxa":[{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"1de4e8df69f8ea88743a72dc79ebdff0df14ccb12667fe14ae5c33266501ddc5"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"64478662fa5e1544368a8d37a73d78bfc90ea789fe52460bc2794d70b8e273b3"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"e7aea5ad354bb944fe749ff0e5f574830ccdd11e2edd1cb16678dd3d93b52205"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"5a0307a0e95589e470722eaa1f6edefde899ff9d045423b92eaede73ef396b02"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"59bdb5a1e8e9e2536fc49c741fcb4259a61a8678fc811d3adeb596662203897f"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"04b15c1d822501a1f3b0513e178960337673a790f4f183f2453907ced2d2833f"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"fb4a23173542d7a1718b502d857067e50a3ab2bcd9e6cbc8252c0d9b2bd57371"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"9e05a9afdb159c3b4e03fba36ee6c997dfff609cf8e7411f86b673ca79d09a53"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"1d11b483dfcf915b1cf80342d758e26c1a3f32b269afb2615b61f8aa4d116443"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"5820d2832b24c301dfa745945b6d73762e17d6f8190921e1bba42ea7ccd769f9"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"d3863a2595bb228753ae718bfb2db02eb99929aa10f09e1bd606c6259c16041d"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"d2542699b904854fe2d3bb29c559aae2c03652694d5ce26390e798fe91bdf8a8"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"61e47cb8eaba6ed590efb402f0010e4e378e8d96f76e0be561c95e47157a952b"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"f377bae7fc8c25b77e36e36a5c6a7c6a478da5be597be7456f129897606fccfb"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"a5a6817c3e60c068daec7ddb91c2a4f576f381c0014d98cb939b918705a9f811"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"5e41b777af62bb9bd42c0af27b9d5b790ac750e3415e4b6eed579a5d24229589"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"86241c62920064dc4ae69366a772c5e824bdb907cf172df18ca02b470ec830d8"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"9657fccad78c31fd25c17ebcb1057da2502001eb52c741200d0e693ea29e6e88"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"03f7a51574bd916e5b19b074475731a80312a93a48616c62fbf4cff85a3dd3db"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"14af0605796bf6253b681d0573bf279d5f4ba79ecc4dc06937eefba68535c501"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"ce63639a05bba5c090368298a65f5b6edb4d4426e32ebb069535b0db47ab8a06"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"1ef634d6b839d2b46b7a2745e8e227fd424c905acd55169598d6f151e9e79259"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D30","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"3035e85b1a9c0c33df37dc333f490439b3fa52aefda24a401e2e75a177cdf778"},"properties":{"dependency":{"package":"rustls","version":"0.23.44","advisory":"RUSTSEC-2026-0285","aliases":["[GHSA redacted]"],"reachability":{"kind":"unknown"}}}},{"ruleId":"D30","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"c21ca5dd2bd869b16755317fa9a96b3b4c90abd21ecbebbe16f465d27575c243"},"properties":{"dependency":{"package":"fxhash","version":"0.2.1","advisory":"RUSTSEC-2025-0057","reachability":{"kind":"unknown"}}}},{"ruleId":"D34","level":"error","message":{"text":"Orphaned knowledge: No living knowledge remains for this large file \u2014 its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"etw-reader/src/custom_schemas.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"5fce70aebc54bb80b3a45484d05bb6a52acf206ffee8520448c0632a30590318"}},{"ruleId":"D34","level":"note","message":{"text":"Further orphaned files (smaller): 5 smaller file(s) also have no living knowledge \u2014 folded into the freshness score and metrics rather than raised one row each \u2014 most significant first: samply/src/windows/winutils.rs, etw-reader/src/tdh_types.rs, etw-reader/src/tdh.rs, samply-debugid/src/debugid.rs, etw-reader/src/utils.rs (6 orphaned of 162 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 162 of the 229 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"ce861fd78f6935114d3a342cb90ad25870f984e1042954fcbbe27c0e23be3658"}},{"ruleId":"D35","level":"error","message":{"text":"Boundary-crossing change coupling: server.rs \u2194 config.rs: \u0060samply/src/server.rs\u0060 (context samply) and \u0060wholesym/src/config.rs\u0060 (context wholesym) sit in DIFFERENT parts of the tree yet change together 52% of the time (11 of the 21 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) \u2014 the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can\u0027t see. You can check this without leaving the row: of the 11 shared commits counted here, the most recent 3 are \u00600b8c8a01\u0060 Rename SymbolManagerConfig methods from \u0027symbols_*\u0027 to \u0027symbol_*\u0027.; \u0060681ce871\u0060 Add command line arguments to specify symbol paths and symbol servers.; \u0060429462a2\u0060 Move presymbolication info into helper \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/server.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"94d21822e6194c89d38cb9c6628ed3212a506472b1e0ef04b0f6993b5770b226"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: jit_function_add_marker.rs \u2194 process_sample_data.rs: \u0060samply/src/shared/jit_function_add_marker.rs\u0060 and \u0060samply/src/shared/process_sample_data.rs\u0060 change together 80% of the time (8 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module \u2014 a sibling reference still needs an import \u2014 so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are \u0060581958c6\u0060 Add convenience field creator methods.; \u0060fed882cf\u0060 Add StaticSchemaMarkerField::new.; \u00602685d2c8\u0060 Change marker field API. \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/shared/jit_function_add_marker.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"4fd04f47c4e3a860796e1aa914c9c227b7e31bce8939f1e75caa2cda0e3bbd67"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: jit_function_add_marker.rs \u2194 per_cpu.rs: \u0060samply/src/shared/jit_function_add_marker.rs\u0060 and \u0060samply/src/shared/per_cpu.rs\u0060 change together 80% of the time (8 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module \u2014 a sibling reference still needs an import \u2014 so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are \u0060581958c6\u0060 Add convenience field creator methods.; \u0060fed882cf\u0060 Add StaticSchemaMarkerField::new.; \u00602685d2c8\u0060 Change marker field API. \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/shared/jit_function_add_marker.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"096b1605ee0a87f6e779cdb27fde2e10525b45812cf1cb8d62ad17da128e2c1b"}},{"ruleId":"D35","level":"warning","message":{"text":"Change-coupling hub: converter.rs \u2192 process.rs, jit_function_add_marker.rs, stack_converter.rs: \u0060samply/src/linux_shared/converter.rs\u0060 changes together with 3 other files \u2014 \u0060samply/src/linux_shared/process.rs\u0060, \u0060samply/src/shared/jit_function_add_marker.rs\u0060, \u0060samply/src/shared/stack_converter.rs\u0060 \u2014 none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/linux_shared/converter.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"624b9d2f5c0411e2099dd6f499378852122aae74c7d4388bc9268c61e5a04d2c"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: elf.rs \u2194 macho.rs: \u0060samply-symbols/src/elf.rs\u0060 and \u0060samply-symbols/src/macho.rs\u0060 change together 75% of the time (44 of the 59 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module \u2014 a sibling reference still needs an import \u2014 so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 44 shared commits counted here, the most recent 3 are \u0060071b0c11\u0060 Remove ObjectExt and make functions free-standing; \u00602d858c1c\u0060 Split out samply-object crate; \u0060047a948e\u0060 Remove the Mutex in samply_symbols::SymbolMap. \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/elf.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7bafbc933007771576cb14bb8a7353e14f16a63ae53522065847d403231bb9f4"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: mod.rs \u2194 mod.rs: \u0060samply-api/src/source/mod.rs\u0060 and \u0060samply-api/src/symbolicate/mod.rs\u0060 change together 68% of the time (13 of the 19 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency \u2014 the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE \u2014 the registration is the link, and it is meant not to be an import \u2014 and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 13 shared commits counted here, the most recent 3 are \u0060502b740a\u0060 Make query_json_api return a QueryApiJsonResult instead of a String, \u2026; \u00607a0c7001\u0060 Improve wholesym lookup API.; \u0060e85415bd\u0060 Move lookup_external to SymbolMap. \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-api/src/source/mod.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"76ddbf1f79635de6aeb15aa78dd90505955a9d798f1ddbfe1bf76984113e3f98"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: lib.rs \u2194 lib.rs: \u0060tools/dump_table/src/lib.rs\u0060 and \u0060tools/query_api/src/lib.rs\u0060 change together 64% of the time (9 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency \u2014 the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE \u2014 the registration is the link, and it is meant not to be an import \u2014 and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are \u0060f81bba5d\u0060 Migrate utility crates from samply-symbols to wholesym.; \u00608c06199c\u0060 Lower MSRV by reverting the use of async fn in trait.; \u0060850ab0a8\u0060 Use async fn in trait. \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/dump_table/src/lib.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"b91404fa2387267971c73b251db3f4eb17c2997c4917f1c311d7c751f9610530"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: profiler.rs \u2194 xperf.rs: \u0060samply/src/windows/profiler.rs\u0060 and \u0060samply/src/windows/xperf.rs\u0060 change together 62% of the time (8 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module \u2014 a sibling reference still needs an import \u2014 so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are \u006022e5ff76\u0060 Don\u0027t merge the ETL files.; \u00606470142b\u0060 Store the operating system version in the profile.; \u0060799fe445\u0060 Support CoreCLR Rundown events when attaching \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/profiler.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"e73f354fa66d66b1318863dbf2748288790b4e4d542c297c07ea99f34ba822b9"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: import.rs \u2194 profiler.rs: \u0060samply/src/windows/import.rs\u0060 and \u0060samply/src/windows/profiler.rs\u0060 change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module \u2014 a sibling reference still needs an import \u2014 so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are \u00608c277e56\u0060 Share post-recording code across platforms.; \u0060db11ba53\u0060 Move some things to ProfileCreationArgs.; \u00604f133762\u0060 Set a useful profile name for imported simpleperf profiles again. \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply/src/windows/import.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"cdb084ab40768bbaee50c59ca083252e1ca302bc060216f65c009162fc00fd31"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: elf.rs \u2194 windows.rs: \u0060samply-symbols/src/elf.rs\u0060 and \u0060samply-symbols/src/windows.rs\u0060 change together 53% of the time (31 of the 59 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module \u2014 a sibling reference still needs an import \u2014 so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 31 shared commits counted here, the most recent 3 are \u0060071b0c11\u0060 Remove ObjectExt and make functions free-standing; \u00602d858c1c\u0060 Split out samply-object crate; \u0060047a948e\u0060 Remove the Mutex in samply_symbols::SymbolMap. \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"samply-symbols/src/elf.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b34ba45d3461c26391a97ebda4c2b82f553e73ea19a0aa977c290b096e7e0aa"}},{"ruleId":"D36","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"1b213f6eedd4b140d0bc37bdf1496f72811a643f34064f12518b32e9e83bcfc7"}},{"ruleId":"D36","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"0e17f71490e4d120a48b2b2881ab866c93b272bef2febb673a3e8e42b2c288ab"}},{"ruleId":"D36","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"eb00976a698a5d68999b7ee6d27206fd374e916853e7ff1ead5eed42386f043f"}},{"ruleId":"D36","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"90f83b4fa27db32740afe9540c905f3c0499caed87f61049a8a903ecc95b41c3"}},{"ruleId":"D36","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"23242335439540a7f0752c9def5c038b557d1cb0f8e6f7b448b5f69adcab3c1d"}},{"ruleId":"D36","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"0752d0df7434000fcabf1048e2de30a7a1a8b982b3db9a19898c4dec199856b4"}},{"ruleId":"D36","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"35f64a0396611dfd8e0191313b0d7cdc759890497b52affaaa727cf6ce876cfd"}},{"ruleId":"M1","level":"warning","message":{"text":"README may be stale: 103 code files changed in the last 6 months but the README was not touched \u2014 it may no longer reflect the system."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"e973e7a8d5d866995cbf78b120250fe7f132bf928812d48ca62e69aba11b9910"}},{"ruleId":"M2","level":"note","message":{"text":"No ADRs: No Architecture Decision Records found \u2014 no conventional ADR directory, no numbered \u0060NNNN-title\u0060 documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"670b3d6e36a756d63097d0dfbf90afd5fc761308800b9354894a07c3f4e4aa14"}},{"ruleId":"M2","level":"note","message":{"text":"No architecture diagram/doc: No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named \u0060architecture\u0060 or \u0060design\u0060 in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape \u2014 no \u0060## Architecture\u0060 heading, no \u0022architecture overview\u0022/\u0022high-level design\u0022 phrasing, no \u0022the architecture is \u2026\u0022 introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document \u2014 not evidence that nobody wrote the shape down."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"0c190e7c159d1850ee706c3ac4486e151e8a4fe169de4bf61436b9f399654f06"}},{"ruleId":"P12","level":"warning","message":{"text":"Coverage collected but not gated: CI collects a coverage report but no step enforces a minimum \u2014 coverage could halve and CI stays green. Add a step that fails the build when coverage drops below a floor (your coverage tool\u0027s minimum-threshold flag, or a coverage-gate action) so the number guards something. What was searched, so you can tell an absence from a miss: this repository\u0027s CI files AND its coverage configuration \u2014 the well-known coverage and test-runner config files, read at the repository root and inside workspace package directories two levels down, so a floor declared beside the tests rather than in the pipeline is credited \u2014 matched against the threshold settings this check knows by name. A floor set in your coverage service\u0027s web UI rather than in a committed file, or under a setting whose name is not one of those, is not seen here."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"7f63c06044cf998d9a0698692df30d8873e29bc9b0c98ee829255017c1193d33"}},{"ruleId":"P2","level":"note","message":{"text":"Logging is not universal: Only 2/3 runnable modules use logging (modules with no entry point or server are excluded \u2014 they are libraries a runnable module hosts). Silent: \u0060wholesym-addr2line\u0060."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"91a94e21d6d4d0e6a2003f94505b0b02b157176f0b24c4820f3f82b4447a97fe"}},{"ruleId":"P4","level":"note","message":{"text":"No release approval gate: The release is automated and no gate that pauses it for a human is DECLARED IN THIS REPOSITORY\u0027S PIPELINE FILES. What was read: every file under \u0060.github/workflows/\u0060, \u0060.forgejo/workflows/\u0060, \u0060.gitea/workflows/\u0060, \u0060.azuredevops/\u0060 and \u0060.azure-pipelines/\u0060, plus \u0060.gitlab-ci*\u0060 and \u0060azure-pipelines*\u0060 \u2014 with comment text stripped, so documenting a gate is not declaring one. What would have counted: GitLab\u0027s \u0060when: manual\u0060, CircleCI\u0027s \u0060type: approval\u0060, an Azure \u0060ManualValidation@\u0060 task or an \u0060approvals:\u0060 block, a Jenkins \u0060input\u0060 step, a \u0060uses:\u0060 step naming an approval action, an \u0060environment:\u0060 paired with \u0060reviewers\u0060 / \u0060required_reviewers\u0060 / \u0060protection\u0060 / \u0060wait-timer\u0060 / \u0060deployment_branch_policy\u0060, a draft-release step, a \u0060workflow_dispatch\u0060 promotion, or a release-event gate. \u2605 What this cannot see, because none of it is a file: a GitHub environment whose required reviewers are configured in repo SETTINGS, a branch protection rule, or an organisation deployment policy \u2014 all of them real, enforced gates that live outside the repository. If yours is one of those, this row is wrong and nothing in the tree could have told us. Otherwise: whatever the release trigger points at is published to users unreviewed, so a mistagged or unverified commit ships and the only remedy is a follow-up release."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"6c11e2dbd483b4b423b95ac61bfcc7af1d55351b28a20d2b1105b31cfe38cc60"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060path.starts_with(\u0022/usr/\u0022) || path.starts_with(\u0022/System/\u0022)\u0060 appears character-identically in 2 files \u2014 wholesym/src/file_resolver.rs, wholesym/src/symbol_manager.rs. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/file_resolver.rs"},"region":{"startLine":670}}}],"partialFingerprints":{"codehealthFindingId/v1":"e1d5536fc0b323deb8e1f0825786b1964606b3af4fc12eb85f62b290b746c660"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default on Err: \u0060get_candidate_paths_for_gnu_debug_link_dest\u0060 turns every \u0060Err\u0060 into \u0060Vec::new()\u0060 \u2014 a failure becomes a plausible value and a silent behavior change with no trail. Log the error or propagate it with \u0060?\u0060. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the arm or in the doc comment, and the row stops firing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"wholesym/src/file_resolver.rs"},"region":{"startLine":711}}}],"partialFingerprints":{"codehealthFindingId/v1":"7ede41cb599d07ab67ee0c3fad9a687260e402d40585680e16dcf8580b6e5fea"}}],"taxonomies":[{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d","organization":"MITRE","informationUri":"https://cwe.mitre.org/","isComprehensive":false,"shortDescription":{"text":"The MITRE Common Weakness Enumeration (CWE)."},"taxa":[{"id":"CWE-1357","guid":"e4d2e772-757e-0a5c-bd7d-77052949d866","name":"Reliance on Insufficiently Trustworthy Component","shortDescription":{"text":"Reliance on Insufficiently Trustworthy Component"},"helpUri":"https://cwe.mitre.org/data/definitions/1357.html"},{"id":"CWE-1395","guid":"800e09e7-c11a-8654-9fa6-86f398995fed","name":"Dependency on Vulnerable Third-Party Component","shortDescription":{"text":"Dependency on Vulnerable Third-Party Component"},"helpUri":"https://cwe.mitre.org/data/definitions/1395.html"},{"id":"CWE-259","guid":"ae9ad959-fbb6-9d5e-892d-3dca66da0b69","name":"Use of Hard-coded Password","shortDescription":{"text":"Use of Hard-coded Password"},"helpUri":"https://cwe.mitre.org/data/definitions/259.html"},{"id":"CWE-353","guid":"09d7e902-d4ee-f05d-ae6c-0a1554d0c18f","name":"CWE-353","shortDescription":{"text":"CWE-353"},"helpUri":"https://cwe.mitre.org/data/definitions/353.html"},{"id":"CWE-494","guid":"b8a65e0d-e459-4a55-a931-fc1136482375","name":"Download of Code Without Integrity Check","shortDescription":{"text":"Download of Code Without Integrity Check"},"helpUri":"https://cwe.mitre.org/data/definitions/494.html"},{"id":"CWE-506","guid":"401d6455-56e3-0552-9a39-f77461673e3f","name":"CWE-506","shortDescription":{"text":"CWE-506"},"helpUri":"https://cwe.mitre.org/data/definitions/506.html"},{"id":"CWE-77","guid":"332c8ade-6612-9f56-a06b-d8d90b1a8750","name":"Command Injection","shortDescription":{"text":"Command Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/77.html"},{"id":"CWE-78","guid":"2e31ceaf-c7ae-2e5e-9661-cfb1362789cf","name":"OS Command Injection","shortDescription":{"text":"OS Command Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/78.html"},{"id":"CWE-79","guid":"fd45580b-e8c4-fc5e-8c2f-aa8fab0b4dbf","name":"Cross-site Scripting (XSS)","shortDescription":{"text":"Cross-site Scripting (XSS)"},"helpUri":"https://cwe.mitre.org/data/definitions/79.html"},{"id":"CWE-798","guid":"5e8f057d-fee3-995a-a0cb-9fc5b0d174d1","name":"Use of Hard-coded Credentials","shortDescription":{"text":"Use of Hard-coded Credentials"},"helpUri":"https://cwe.mitre.org/data/definitions/798.html"},{"id":"CWE-829","guid":"13c33925-97fb-5a5e-b40c-56d328b8a4d7","name":"CWE-829","shortDescription":{"text":"CWE-829"},"helpUri":"https://cwe.mitre.org/data/definitions/829.html"},{"id":"CWE-89","guid":"6d08fdad-37eb-c150-bbf0-d7d946863407","name":"SQL Injection","shortDescription":{"text":"SQL Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/89.html"},{"id":"CWE-937","guid":"16f316ae-415c-b354-a59b-1f7905f756e9","name":"Using Components with Known Vulnerabilities","shortDescription":{"text":"Using Components with Known Vulnerabilities"},"helpUri":"https://cwe.mitre.org/data/definitions/937.html"},{"id":"CWE-94","guid":"75e7f50c-6c2f-dd52-bf40-bf6c52b861fd","name":"Code Injection","shortDescription":{"text":"Code Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/94.html"}]}],"properties":{"codehealthPublication":{"public":true,"notice":"This is the PUBLIC form of this artifact. Findings are listed in full, but the details of SECURITY findings \u2014 which rule fired, in which file, on which line, and how to fix it \u2014 are deliberately withheld, and any secret-scanner results are excluded entirely. Where detail is absent here it was REMOVED FOR PUBLICATION; it is not missing from the analysis. The complete artifact is available from the repository owner.","securityFindingsRedacted":41,"secretScannerRunsExcluded":0}},"redactionTokens":["A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."]}]}