{"$schema":"https://json.schemastore.org/sarif-2.1.0.json","version":"2.1.0","runs":[{"tool":{"driver":{"name":"codehealth","informationUri":"https://codehealth.canine.dev","rules":[{"id":"D1","name":"Cyclomatic Complexity","shortDescription":{"text":"Cyclomatic Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D1"},{"id":"D2","name":"Cognitive Complexity","shortDescription":{"text":"Cognitive Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D2"},{"id":"D3","name":"God Classes","shortDescription":{"text":"God Classes"},"helpUri":"https://codehealth.canine.dev/dimensions/D3"},{"id":"D4","name":"Code Duplication","shortDescription":{"text":"Code Duplication"},"helpUri":"https://codehealth.canine.dev/dimensions/D4"},{"id":"D5","name":"Coupling","shortDescription":{"text":"Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D5"},{"id":"D9","name":"Test Distribution","shortDescription":{"text":"Test Distribution"},"helpUri":"https://codehealth.canine.dev/dimensions/D9"},{"id":"D12","name":"Dependency Hygiene","shortDescription":{"text":"Dependency Hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/D12"},{"id":"D13","name":"Secret Scanning","shortDescription":{"text":"Secret Scanning"},"helpUri":"https://codehealth.canine.dev/dimensions/D13","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"]}},{"id":"D14","name":"License Compliance","shortDescription":{"text":"License Compliance"},"helpUri":"https://codehealth.canine.dev/dimensions/D14"},{"id":"D15","name":"Churn \u00D7 Complexity Hotspots","shortDescription":{"text":"Churn \u00D7 Complexity Hotspots"},"helpUri":"https://codehealth.canine.dev/dimensions/D15"},{"id":"D16","name":"Bus Factor","shortDescription":{"text":"Bus Factor"},"helpUri":"https://codehealth.canine.dev/dimensions/D16"},{"id":"D17","name":"Explicit Debt","shortDescription":{"text":"Explicit Debt"},"helpUri":"https://codehealth.canine.dev/dimensions/D17"},{"id":"D19","name":"Documentation Quality","shortDescription":{"text":"Documentation Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D19"},{"id":"D20","name":"ADR Quality","shortDescription":{"text":"ADR Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D20"},{"id":"D21","name":"Naming Consistency","shortDescription":{"text":"Naming Consistency"},"helpUri":"https://codehealth.canine.dev/dimensions/D21"},{"id":"D22","name":"Internal API Consistency","shortDescription":{"text":"Internal API Consistency"},"helpUri":"https://codehealth.canine.dev/dimensions/D22"},{"id":"D26","name":"Project Cohesion","shortDescription":{"text":"Project Cohesion"},"helpUri":"https://codehealth.canine.dev/dimensions/D26"},{"id":"D28","name":"Secrets (history)","shortDescription":{"text":"Secrets (history)"},"helpUri":"https://codehealth.canine.dev/dimensions/D28","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"]}},{"id":"D29","name":"Static Analysis (SAST)","shortDescription":{"text":"Static Analysis (SAST)"},"helpUri":"https://codehealth.canine.dev/dimensions/D29","relationships":[{"target":{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-89","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-94","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-77","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-79","CWE-89","CWE-78","CWE-94","CWE-77"]}},{"id":"D30","name":"Dependency Vulnerabilities","shortDescription":{"text":"Dependency Vulnerabilities"},"helpUri":"https://codehealth.canine.dev/dimensions/D30","relationships":[{"target":{"id":"CWE-1395","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-937","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-1395","CWE-937"]}},{"id":"D31","name":"IaC \u0026 Container Security","shortDescription":{"text":"IaC \u0026 Container Security"},"helpUri":"https://codehealth.canine.dev/dimensions/D31","relationships":[{"target":{"id":"CWE-1032","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-732","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-16","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-1032","CWE-732","CWE-16"]}},{"id":"D34","name":"Knowledge Freshness","shortDescription":{"text":"Knowledge Freshness"},"helpUri":"https://codehealth.canine.dev/dimensions/D34"},{"id":"D35","name":"Change Coupling","shortDescription":{"text":"Change Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D35"},{"id":"D36","name":"Supply-chain Provenance \u0026 Signing","shortDescription":{"text":"Supply-chain Provenance \u0026 Signing"},"helpUri":"https://codehealth.canine.dev/dimensions/D36","relationships":[{"target":{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-494","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-1357","CWE-494"]}},{"id":"D43","name":"Malicious Dependencies","shortDescription":{"text":"Malicious Dependencies"},"helpUri":"https://codehealth.canine.dev/dimensions/D43","relationships":[{"target":{"id":"CWE-506","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-506"]}},{"id":"AX10","name":"Code composition","shortDescription":{"text":"Code composition"},"helpUri":"https://codehealth.canine.dev/dimensions/AX10"},{"id":"AX3","name":"Project dependency cycles","shortDescription":{"text":"Project dependency cycles"},"helpUri":"https://codehealth.canine.dev/dimensions/AX3"},{"id":"AX4","name":"Dependency direction","shortDescription":{"text":"Dependency direction"},"helpUri":"https://codehealth.canine.dev/dimensions/AX4"},{"id":"AX9","name":"CQS / query purity","shortDescription":{"text":"CQS / query purity"},"helpUri":"https://codehealth.canine.dev/dimensions/AX9"},{"id":"AXB2","name":"Runtime readiness","shortDescription":{"text":"Runtime readiness"},"helpUri":"https://codehealth.canine.dev/dimensions/AXB2"},{"id":"ES1","name":"Fold determinism","shortDescription":{"text":"Fold determinism"},"helpUri":"https://codehealth.canine.dev/dimensions/ES1"},{"id":"ES2","name":"Immutable events","shortDescription":{"text":"Immutable events"},"helpUri":"https://codehealth.canine.dev/dimensions/ES2"},{"id":"M1","name":"Documentation (README)","shortDescription":{"text":"Documentation (README)"},"helpUri":"https://codehealth.canine.dev/dimensions/M1"},{"id":"M2","name":"Architecture documentation","shortDescription":{"text":"Architecture documentation"},"helpUri":"https://codehealth.canine.dev/dimensions/M2"},{"id":"M3","name":"Folder \u0026 project structure","shortDescription":{"text":"Folder \u0026 project structure"},"helpUri":"https://codehealth.canine.dev/dimensions/M3"},{"id":"M4","name":"Documentation accuracy","shortDescription":{"text":"Documentation accuracy"},"helpUri":"https://codehealth.canine.dev/dimensions/M4"},{"id":"P1","name":"CI/CD gates","shortDescription":{"text":"CI/CD gates"},"helpUri":"https://codehealth.canine.dev/dimensions/P1"},{"id":"P12","name":"CI test-gate honesty","shortDescription":{"text":"CI test-gate honesty"},"helpUri":"https://codehealth.canine.dev/dimensions/P12"},{"id":"P2","name":"Observability","shortDescription":{"text":"Observability"},"helpUri":"https://codehealth.canine.dev/dimensions/P2"},{"id":"P3","name":"Security \u0026 performance tooling","shortDescription":{"text":"Security \u0026 performance tooling"},"helpUri":"https://codehealth.canine.dev/dimensions/P3"},{"id":"P4","name":"Deployment \u0026 Rollback","shortDescription":{"text":"Deployment \u0026 Rollback"},"helpUri":"https://codehealth.canine.dev/dimensions/P4"},{"id":"P6","name":"Release Hygiene","shortDescription":{"text":"Release Hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/P6"},{"id":"P7","name":"Outbound HTTP resilience","shortDescription":{"text":"Outbound HTTP resilience"},"helpUri":"https://codehealth.canine.dev/dimensions/P7"},{"id":"PF3","name":"Async \u0026 latency hygiene","shortDescription":{"text":"Async \u0026 latency hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/PF3"},{"id":"X9","name":"Subsumed condition operand","shortDescription":{"text":"Subsumed condition operand"},"helpUri":"https://codehealth.canine.dev/dimensions/X9"}]}},"results":[{"ruleId":"D1","level":"warning","message":{"text":"Client::spawn_qad_probes (cyclomatic 37): Client::spawn_qad_probes has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":443}}}],"partialFingerprints":{"codehealthFindingId/v1":"6feb792f60c29fc74b14cbc30adaacb1d1ea2077d5a3ff7f2659ca91a2ab0462"}},{"ruleId":"D1","level":"warning","message":{"text":"Transports::inner_poll_recv (cyclomatic 32): Transports::inner_poll_recv has cyclomatic complexity 32 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports.rs"},"region":{"startLine":278}}}],"partialFingerprints":{"codehealthFindingId/v1":"480ea2ea5a91577b2d648ba4e25f9d29a9b0ae955437f0719a53ffdcf04f7c69"}},{"ruleId":"D1","level":"warning","message":{"text":"Actor::run (cyclomatic 24): Actor::run has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket.rs"},"region":{"startLine":1481}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe3e24c9bf9b802c2abf1dd4796f4fbb5ed87a964ae1941a80dfe8821b5af0a3"}},{"ruleId":"D1","level":"warning","message":{"text":"Client::have_enough_reports (cyclomatic 23): Client::have_enough_reports has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":661}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c69d3c354e0d67238335e9abc3c99fdbcf4feb59bd498cb5b0a1cbb61cf35f2"}},{"ruleId":"D1","level":"warning","message":{"text":"ActiveRelayActor::run_connected (cyclomatic 23): ActiveRelayActor::run_connected has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports/relay/actor.rs"},"region":{"startLine":556}}}],"partialFingerprints":{"codehealthFindingId/v1":"e895fac700a469f3c9a46dab0ec290ebebecbd6900f2ad653ae64f14f8a3e580"}},{"ruleId":"D1","level":"warning","message":{"text":"RemoteStateActor::run (cyclomatic 21): RemoteStateActor::run has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform \u2014 the same kind of value, with no behaviour of its own \u2014 a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/remote_map/remote_state.rs"},"region":{"startLine":237}}}],"partialFingerprints":{"codehealthFindingId/v1":"516dc07588021b4641cefbf22e1020a5d1008b97edf51f0d8894173af9738cce"}},{"ruleId":"D1","level":"warning","message":{"text":"RouterBuilder::spawn (cyclomatic 17): RouterBuilder::spawn has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/protocol.rs"},"region":{"startLine":512}}}],"partialFingerprints":{"codehealthFindingId/v1":"808c87bc96bd8ae4adc5868cb13c65625c84cb12e9c4f41fe2cae708a3140dff"}},{"ruleId":"D1","level":"warning","message":{"text":"TransportsSender::poll_send (cyclomatic 17): TransportsSender::poll_send has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports.rs"},"region":{"startLine":965}}}],"partialFingerprints":{"codehealthFindingId/v1":"22b16f9f263254ba429381f75c80bb873503213557ba65f4884276edbb00609d"}},{"ruleId":"D1","level":"warning","message":{"text":"iroh_relay::client::tls::dial_happy_eyeballs (cyclomatic 16): iroh_relay::client::tls::dial_happy_eyeballs has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/client/tls.rs"},"region":{"startLine":246}}}],"partialFingerprints":{"codehealthFindingId/v1":"f49543c38710c818298f6eabfb1cccc7fc367a21b392bbb639ad970f489bdef0"}},{"ruleId":"D2","level":"warning","message":{"text":"Client::spawn_qad_probes (cognitive 60): Client::spawn_qad_probes has cognitive complexity 60 (threshold 15). Drivers by points: if/else 18 (37 pts), match/switch 5 (16 pts), boolean chains 5, loops 2 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass\u0027s cognitive complexity CONCENTRATES: iroh/src/net_report.rs holds 4 of the 27 functions over the threshold \u2014 including the worst \u2014 and 84 of the 292 points over it (29%), 2.4\u00D7 the next-largest file (iroh/src/socket/transports.rs at 35). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":443}}}],"partialFingerprints":{"codehealthFindingId/v1":"d3e9b136f06f6e170b7da605cb91040ed0bb049f6b3a7c614666cefb433f4094"}},{"ruleId":"D2","level":"warning","message":{"text":"Actor::run (cognitive 38): Actor::run has cognitive complexity 38 (threshold 15). Drivers by points: if/else 8 (23 pts), match/switch 5 (13 pts), boolean chains 1, loops 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket.rs"},"region":{"startLine":1481}}}],"partialFingerprints":{"codehealthFindingId/v1":"2f0cbdade6d90b8c7560218c9c597512d6b9c65b1caf57f2dd7faa9fcc10307a"}},{"ruleId":"D2","level":"warning","message":{"text":"ActiveRelayActor::run_connected (cognitive 36): ActiveRelayActor::run_connected has cognitive complexity 36 (threshold 15). Drivers by points: if/else 7 (19 pts), match/switch 5 (15 pts), boolean chains 1, loops 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports/relay/actor.rs"},"region":{"startLine":556}}}],"partialFingerprints":{"codehealthFindingId/v1":"16656778b423adb577e807acbd40d5b1213f808ed0fe68ea74117c841729e3a2"}},{"ruleId":"D2","level":"warning","message":{"text":"Client::have_enough_reports (cognitive 35): Client::have_enough_reports has cognitive complexity 35 (threshold 15). Drivers by points: if/else 10 (24 pts), match/switch 3 (6 pts), boolean chains 4, loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass\u0027s cognitive complexity CONCENTRATES: iroh/src/net_report.rs holds 4 of the 27 functions over the threshold \u2014 including the worst \u2014 and 84 of the 292 points over it (29%), 2.4\u00D7 the next-largest file (iroh/src/socket/transports.rs at 35). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":661}}}],"partialFingerprints":{"codehealthFindingId/v1":"13ccc36e3af79edbb90763e9c6a89e4d7829d82869f21f62b96f2b0424573085"}},{"ruleId":"D2","level":"warning","message":{"text":"RouterBuilder::spawn (cognitive 35): RouterBuilder::spawn has cognitive complexity 35 (threshold 15). Drivers by points: if/else 7 (22 pts), match/switch 4 (11 pts), loops 2 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/protocol.rs"},"region":{"startLine":512}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f0ec7b4f293b96c2b51c9c630dd6701fc1e7c0f0fcf3bdc105085e5fb78fba6"}},{"ruleId":"D2","level":"warning","message":{"text":"TransportsSender::poll_send (cognitive 33): TransportsSender::poll_send has cognitive complexity 33 (threshold 15). Drivers by points: if/else 6 (17 pts), match/switch 4 (10 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 19). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports.rs"},"region":{"startLine":965}}}],"partialFingerprints":{"codehealthFindingId/v1":"8332d6b330a921587649f2c64f1a713e21348ac61b279a4cbc2fcd631b6b4457"}},{"ruleId":"D2","level":"warning","message":{"text":"iroh_relay::client::tls::dial_happy_eyeballs (cognitive 33): iroh_relay::client::tls::dial_happy_eyeballs has cognitive complexity 33 (threshold 15). Drivers by points: if/else 7 (22 pts), match/switch 3 (8 pts), boolean chains 2, loops 1 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/client/tls.rs"},"region":{"startLine":246}}}],"partialFingerprints":{"codehealthFindingId/v1":"aa6bba513858f52219a8645a9fe51864f12e918166f614a753a1cacbd62433c3"}},{"ruleId":"D2","level":"warning","message":{"text":"Client::get_report (cognitive 31): Client::get_report has cognitive complexity 31 (threshold 15). Drivers by points: if/else 6 (14 pts), match/switch 3 (12 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass\u0027s cognitive complexity CONCENTRATES: iroh/src/net_report.rs holds 4 of the 27 functions over the threshold \u2014 including the worst \u2014 and 84 of the 292 points over it (29%), 2.4\u00D7 the next-largest file (iroh/src/socket/transports.rs at 35). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":296}}}],"partialFingerprints":{"codehealthFindingId/v1":"72ca47cc68732c43fb9fed94cbdffe1814cc41388f89d1be5fdb29c7cfce9e67"}},{"ruleId":"D2","level":"warning","message":{"text":"Transports::inner_poll_recv (cognitive 31): Transports::inner_poll_recv has cognitive complexity 31 (threshold 15). Drivers by points: loops 6 (12 pts), if/else 8 (10 pts), match/switch 7 (9 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports.rs"},"region":{"startLine":278}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2774b71cdac4aa98688f8460e6be566603c356ed317c1d4ed8a6e44607303a6"}},{"ruleId":"D2","level":"warning","message":{"text":"IpTransports::bind (cognitive 28): IpTransports::bind has cognitive complexity 28 (threshold 15). Drivers by points: if/else 7 (25 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports/ip.rs"},"region":{"startLine":416}}}],"partialFingerprints":{"codehealthFindingId/v1":"fbcad20652973897c8bffa8894e0d1b5d0dd4a2f89b55d3e80cb7e00a6cb3baf"}},{"ruleId":"D2","level":"warning","message":{"text":"Report::update (cognitive 27): Report::update has cognitive complexity 27 (threshold 15). Drivers by points: if/else 12 (26 pts), match/switch 1 (nesting depth added 14). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report/report.rs"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"1639ba961e466f3c8b94889989d8068ae8aecc4eb1c192b78abeeb9445054f57"}},{"ruleId":"D2","level":"warning","message":{"text":"ActiveRelayActor::run_dialing (cognitive 25): ActiveRelayActor::run_dialing has cognitive complexity 25 (threshold 15). Drivers by points: match/switch 4 (11 pts), if/else 3 (10 pts), loops 2 (4 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports/relay/actor.rs"},"region":{"startLine":451}}}],"partialFingerprints":{"codehealthFindingId/v1":"8bf5ff4f964c53bef79df43d981829b83850187e96bc587af27b51612c2f30cc"}},{"ruleId":"D2","level":"warning","message":{"text":"iroh_relay::build_relay_config (cognitive 25): iroh_relay::build_relay_config has cognitive complexity 25 (threshold 15). Drivers by points: match/switch 5 (13 pts), if/else 8 (11 pts), boolean chains 1 (nesting depth added 11). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/main.rs"},"region":{"startLine":689}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c8ab5ddaf459c8b9920f27dbd76da8b1b016ad6a2be54ab9ea6567f8bb69444"}},{"ruleId":"D2","level":"warning","message":{"text":"Server::spawn (cognitive 24): Server::spawn has cognitive complexity 24 (threshold 15). Drivers by points: match/switch 6 (14 pts), loops 2 (6 pts), if/else 3 (4 pts) (nesting depth added 13). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/server.rs"},"region":{"startLine":691}}}],"partialFingerprints":{"codehealthFindingId/v1":"da1b4c63111921028977ce9291874c66565f9dbef970c2170ed87555e78165b3"}},{"ruleId":"D2","level":"warning","message":{"text":"RemoteStateActor::run (cognitive 23): RemoteStateActor::run has cognitive complexity 23 (threshold 15). Drivers by points: if/else 4 (9 pts), match/switch 4 (9 pts), loops 3 (5 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/remote_map/remote_state.rs"},"region":{"startLine":237}}}],"partialFingerprints":{"codehealthFindingId/v1":"3738e57b7fc161737e1444f1b99c56c4105fafafac0955d1d5be8009f969eb22"}},{"ruleId":"D2","level":"warning","message":{"text":"Actor::collect_local_addresses (cognitive 21): Actor::collect_local_addresses has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (12 pts), boolean chains 3, loops 2 (3 pts), match/switch 1 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket.rs"},"region":{"startLine":1890}}}],"partialFingerprints":{"codehealthFindingId/v1":"dff51368ca369c9463b315cffc935b0189ca4a13a05a0740c10459f841012a67"}},{"ruleId":"D2","level":"warning","message":{"text":"DnsResolver::resolve_host_all (cognitive 20): DnsResolver::resolve_host_all has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (11 pts), match/switch 4 (7 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-dns/src/dns.rs"},"region":{"startLine":908}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc46c3d4d0c3737e2a713e014230c48663e72d3122afde804cdfdc753383afce"}},{"ruleId":"D2","level":"warning","message":{"text":"Actor::handle_message (cognitive 20): Actor::handle_message has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (11 pts), match/switch 5 (9 pts) (nesting depth added 9). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-dns-server/src/store/signed_packets.rs"},"region":{"startLine":149}}}],"partialFingerprints":{"codehealthFindingId/v1":"040329f33fee7d60945998f637efb168d906940a2d2dc5ebdb0942d3cbe4e3bf"}},{"ruleId":"D2","level":"warning","message":{"text":"Actor::run_inner (cognitive 18): Actor::run_inner has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (15 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report/reportgen.rs"},"region":{"startLine":233}}}],"partialFingerprints":{"codehealthFindingId/v1":"961be344a3facf2a339368bae69c15db36cc02cf18896ec2b1dbc7196288d2f8"}},{"ruleId":"D2","level":"warning","message":{"text":"Client::add_report_history_and_set_preferred_relay (cognitive 18): Client::add_report_history_and_set_preferred_relay has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (12 pts), boolean chains 3, loops 3 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass\u0027s cognitive complexity CONCENTRATES: iroh/src/net_report.rs holds 4 of the 27 functions over the threshold \u2014 including the worst \u2014 and 84 of the 292 points over it (29%), 2.4\u00D7 the next-largest file (iroh/src/socket/transports.rs at 35). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":749}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f05e61858177c0afd62a7853661a647ccbfed017ce8426c5cee6b71ae1dd470"}},{"ruleId":"D2","level":"warning","message":{"text":"ActiveRelayActor::run_sending (cognitive 18): ActiveRelayActor::run_sending has cognitive complexity 18 (threshold 15). Drivers by points: match/switch 4 (11 pts), if/else 2 (6 pts), loops 1 (nesting depth added 11). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports/relay/actor.rs"},"region":{"startLine":798}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd944ab38064eef1285c43427a2b7c2c6a05f8f3f608674086c4266c870d48fb"}},{"ruleId":"D2","level":"warning","message":{"text":"RemoteStateActor::apply_selected_path (cognitive 17): RemoteStateActor::apply_selected_path has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (9 pts), match/switch 1 (4 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/remote_map/remote_state.rs"},"region":{"startLine":685}}}],"partialFingerprints":{"codehealthFindingId/v1":"9a6986bbcb60ce161e4c06b30dce82889005ed937b23edc2b5823aa194c9a3e7"}},{"ruleId":"D2","level":"warning","message":{"text":"Config::is_valid_send_addr (cognitive 17): Config::is_valid_send_addr has cognitive complexity 17 (threshold 15). Drivers by points: if/else 3 (10 pts), match/switch 3 (5 pts), boolean chains 2 (nesting depth added 9). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports/ip.rs"},"region":{"startLine":114}}}],"partialFingerprints":{"codehealthFindingId/v1":"582cc49e0508521b7392972102f0a91ed360085002aab1e62eb7d897c4166c6e"}},{"ruleId":"D2","level":"warning","message":{"text":"RemoteStateActor::handle_msg_network_change (cognitive 16): RemoteStateActor::handle_msg_network_change has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 2 (4 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/remote_map/remote_state.rs"},"region":{"startLine":455}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a13fc6c988060dd4672aa12a23acf96b260b9e6c3b2d3d2c9739cfb047161b6"}},{"ruleId":"D2","level":"warning","message":{"text":"ActiveRelayActor::handle_relay_msg (cognitive 16): ActiveRelayActor::handle_relay_msg has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (13 pts), match/switch 2 (3 pts) (nesting depth added 8). The drivers above price the dispatch low by construction \u2014 a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full \u2014 so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports/relay/actor.rs"},"region":{"startLine":715}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff01bf71fe580bffb33927c056900221e533ce36c61ea9187091dc4a9e223780"}},{"ruleId":"D2","level":"warning","message":{"text":"Transports::bind (cognitive 16): Transports::bind has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (8 pts), boolean chains 6, loops 2 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports.rs"},"region":{"startLine":188}}}],"partialFingerprints":{"codehealthFindingId/v1":"2d2da4bdbfe558572c1438a1e48fada4f06d04500324a8c0ca37a9714b4d44c4"}},{"ruleId":"D2","level":"warning","message":{"text":"Actor::update_direct_addresses (cognitive 16): Actor::update_direct_addresses has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 1, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket.rs"},"region":{"startLine":1810}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e80e0f303627b0fb8d3507544c18da91ecf453bc19960ba0b67fdd429a47ab1"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/socket.rs: FileTooLong \u2014 1153 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 653 over it, 2.31\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d56bc4436b9c7e39153a1fccd28c06bbeec220822b30897410a0fb0c919690b1"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: relay/actor.rs: FileTooLong \u2014 819 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 319 over it, 1.64\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports/relay/actor.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"0682ba98747203ec564bb9a73819a2cf05120cdb005acc72ed9897f375b8596e"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: remote_map/remote_state.rs: FileTooLong \u2014 808 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 308 over it, 1.62\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/remote_map/remote_state.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"8643b98b0c60a4a62be05550e43709181cff21964c0c3f32b10d3b5f5cc43459"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: socket/transports.rs: FileTooLong \u2014 764 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 264 over it, 1.53\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"27bcde031a0d33c162c7c1776e4d83f049f7974962c7bcb762d45cf925e19b19"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: Server.spawn: MethodTooLong \u2014 spawn runs 141 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 41 over it, 1.41\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/server.rs"},"region":{"startLine":691}}}],"partialFingerprints":{"codehealthFindingId/v1":"e0d873f9034d2d620871a956bd948e187cfcd97bd32cf850162343a1ffb8f9b2"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: Client.spawn_qad_probes: MethodTooLong \u2014 spawn_qad_probes runs 139 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted) in one body. The bar is 100 significant lines; this is 39 over it, 1.39\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":443}}}],"partialFingerprints":{"codehealthFindingId/v1":"6083f268ebfc9318a8a536992b1d46ac2b74929b24ac45521fe6d2bdbc702998"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/endpoint.rs: FileTooLong \u2014 687 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 187 over it, 1.37\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/endpoint.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"7643afc5472bdcf2be823334314f7c3066a961f76f3db7a1340655a0458a5f8e"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/server.rs: FileTooLong \u2014 641 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 141 over it, 1.28\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/server.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"cc04df46e3e00b5715dffe1bfcdbc8af5dedbe50bef5887f92981d192cf9a507"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/net_report.rs: FileTooLong \u2014 613 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted), about 61% of them inside a single declaration: Client (2 blocks, 137-823). The bar is 500 significant lines; this is 113 over it, 1.23\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"6bb31062069b1fe26a282a3237f0de440be1e8b8a8b2774394b56ec6e56e6731"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: server/http_server.rs: FileTooLong \u2014 592 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 92 over it, 1.18\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/server/http_server.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"e77352921539b362b82cc0890a4d120eda8d1c47422d59753adf2caf00d48ab5"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyFields: Metrics: TooManyFields \u2014 35 stored fields. The bar is 30 stored fields; this is 5 over it, 1.17\u00D7 the bar. This is width in DATA, not behaviour: every reader that takes the whole type couples to all of its fields, so a change to any one of them is a change every reader has to be checked against. To reduce it, group the fields that are read together by the same callers into a smaller type of their own, and have this one hold that type as a single member \u2014 each reader then names only the group it uses."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/metrics.rs"},"region":{"startLine":8}}}],"partialFingerprints":{"codehealthFindingId/v1":"a954dc13fb1839caab9756245930e44d48d7258a991104baaa3dcd40a5feea3b"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: src/dns.rs: FileTooLong \u2014 576 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 76 over it, 1.15\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-dns/src/dns.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d254ffe6e74810581d17b37a852e861faeb82de1547ee39ecd1e27a840d1964e"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: QuicTransportConfigBuilder: TooManyMethods \u2014 34 methods. The bar is 30 methods; this is 4 over it, 1.13\u00D7 the bar. This type is on a published API surface \u2014 a cargo-semver-checks gate in CI (.github/workflows/ci.yml) declares its compatibility contractual \u2014 so moving members onto a smaller type is a breaking change for every consumer, not a local refactor. To reduce it, treat the split as an API migration: move each cohesive group onto its own published type and keep the old members as deprecated forwards for a deprecation period, removing them at the next compatibility break. Where the surface has to stay as it is, that is a decision to record rather than a change to make."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/endpoint/quic.rs"},"region":{"startLine":93}}}],"partialFingerprints":{"codehealthFindingId/v1":"5fb7226dbd1466319c7a89b3cf2d713c00d0ab603726276f90e7c421a05e7923"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: net_report/reportgen.rs: FileTooLong \u2014 547 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 47 over it, 1.09\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report/reportgen.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"431b5ce5b2e1c2f70f4887d03bd46c94c70321cc976d5f5dcd95c80181ffd60d"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: Connection: TooManyMethods \u2014 32 methods. The bar is 30 methods; this is 2 over it, 1.07\u00D7 the bar. This type is on a published API surface \u2014 a cargo-semver-checks gate in CI (.github/workflows/ci.yml) declares its compatibility contractual \u2014 so moving members onto a smaller type is a breaking change for every consumer, not a local refactor. To reduce it, treat the split as an API migration: move each cohesive group onto its own published type and keep the old members as deprecated forwards for a deprecation period, removing them at the next compatibility break. Where the surface has to stay as it is, that is a decision to record rather than a change to make."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/endpoint/connection.rs"},"region":{"startLine":748}}}],"partialFingerprints":{"codehealthFindingId/v1":"0bdde3dac349babaf782cc04a4a1d89570357c70addda7f98c8d30f29ceb143d"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: endpoint/connection.rs: FileTooLong \u2014 525 significant lines (blank, comment-only and punctuation-only lines excluded, and inline test code \u2014 #[cfg(test)] modules and bare #[test] functions \u2014 not counted). The bar is 500 significant lines; this is 25 over it, 1.05\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/endpoint/connection.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"532cde4de174c2edd0fa06f4ab56bf2a6ebbfc4fd3006c0385664d4948488d8f"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: Builder: TooManyMethods \u2014 31 methods. The bar is 30 methods; this is 1 over it, 1.03\u00D7 the bar. This type is on a published API surface \u2014 a cargo-semver-checks gate in CI (.github/workflows/ci.yml) declares its compatibility contractual \u2014 so moving members onto a smaller type is a breaking change for every consumer, not a local refactor. To reduce it, treat the split as an API migration: move each cohesive group onto its own published type and keep the old members as deprecated forwards for a deprecation period, removing them at the next compatibility break. Where the surface has to stay as it is, that is a decision to record rather than a change to make."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/endpoint.rs"},"region":{"startLine":131}}}],"partialFingerprints":{"codehealthFindingId/v1":"ddcc2d607395ef350737ce3734427244ab56fe4904daeb31b8454d567f5ea9a0"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (59 corresponding lines): iroh/src/net_report.rs:831-892 | iroh/src/net_report.rs:900-961 \u2014 These two members are one piece of code written twice and then edited apart: 59 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":831}}}],"partialFingerprints":{"codehealthFindingId/v1":"bf23d2aeadbf659d959d1f7e320608ee1823c0c6923e199dd7088b474ee55238"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (33 lines \u00D7 2): iroh/src/net_report.rs:835-867 | iroh/src/net_report.rs:904-936 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":835}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a863a6267eb7efbcb16a00821b9c50ccceec1a7a23b7e5ff4ac4c35dfa58198"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25 lines \u00D7 2): iroh/src/net_report.rs:583-607 | iroh/src/net_report.rs:622-646 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":583}}}],"partialFingerprints":{"codehealthFindingId/v1":"7f45d097145b32ecd9830e213fa07e49c89d4a1a2d93da5407a9655d4be42c4b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22\u201323 lines \u00D7 2): iroh/src/net_report.rs:695-716 | iroh/src/net_report.rs:723-745 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":695}}}],"partialFingerprints":{"codehealthFindingId/v1":"f908f678089a36546f765187d96116c67463fc12e5e0ce821fcdd03f7c3d1696"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): iroh/src/net_report.rs:871-892 | iroh/src/net_report.rs:940-961 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":871}}}],"partialFingerprints":{"codehealthFindingId/v1":"ea1de0d93ac2fbbcb5e027481d1f787641815ed598ab758008fa9be611e82817"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): iroh-relay/src/client.rs:267-281 | iroh-relay/src/client.rs:391-405 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/client.rs"},"region":{"startLine":267}}}],"partialFingerprints":{"codehealthFindingId/v1":"6cb83cd1e9cdcb9d25af96ea6ef591e0920841448f15cca0dba021185e9eccee"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): iroh/src/socket/transports/relay/actor.rs:602-613 | iroh/src/socket/transports/relay/actor.rs:818-829 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports/relay/actor.rs"},"region":{"startLine":602}}}],"partialFingerprints":{"codehealthFindingId/v1":"55f32a27e0b3d6acb9f30ff420c3b8e166a01d53d94cc466499e1d04eee70f55"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11\u201312 lines \u00D7 2): iroh-dns/src/pkarr.rs:192-202 | iroh-dns/src/pkarr.rs:227-238 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-dns/src/pkarr.rs"},"region":{"startLine":192}}}],"partialFingerprints":{"codehealthFindingId/v1":"94125d9fb72f7b04d497c905a1b62cef92f4d8440626efe41f0ea29b2dc01a79"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): iroh-relay/src/protos/relay.rs:427-438 | iroh-relay/src/protos/relay.rs:562-573 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/protos/relay.rs"},"region":{"startLine":427}}}],"partialFingerprints":{"codehealthFindingId/v1":"176ca41a377afc54e4f7bce9c113c981bbf7ff9ab3a448f5f3939359330be094"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): iroh/src/net_report.rs:508-517 | iroh/src/net_report.rs:525-534 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":508}}}],"partialFingerprints":{"codehealthFindingId/v1":"427901abb89d75cd4e54746ee8c330540b02159cea3ac979f117572de213dd9f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): iroh/src/net_report.rs:571-578 | iroh/src/net_report.rs:610-617 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":571}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e7caf9c919ca2080d9b28dec5c70c5570bf5868e63cc5bc261a1e53ddf7360d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): iroh-dns-server/src/http.rs:123-130 | iroh-dns-server/src/http.rs:164-171 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-dns-server/src/http.rs"},"region":{"startLine":123}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e861f51ba39e41f5877aa42456738f2ac7bbacbaa44b323ea3f61196322acb2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): iroh/src/address_lookup/pkarr.rs:636-643 | iroh/src/address_lookup/pkarr.rs:671-677 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/address_lookup/pkarr.rs"},"region":{"startLine":636}}}],"partialFingerprints":{"codehealthFindingId/v1":"07c4ccc48389568dafbaed13b3d611b1970706a8c11b4c9bb258042e0d40165b"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): iroh-dns/src/pkarr.rs:93-97 | iroh-dns/src/pkarr.rs:135-139 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-dns/src/pkarr.rs"},"region":{"startLine":93}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c499704d3bab43dfa35bed106a0f42fee2c1e28736879227013d0720ee6371d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): iroh-base/src/endpoint_addr.rs:137-142 | iroh-dns/src/endpoint_info.rs:165-170 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-base/src/endpoint_addr.rs"},"region":{"startLine":137}}}],"partialFingerprints":{"codehealthFindingId/v1":"2220b673160d1e93b31e56a633f41305cbaae926842f9fc08a50fd8aa978b5ed"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): iroh-base/src/endpoint_addr.rs:147-152 | iroh-dns/src/endpoint_info.rs:152-157 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-base/src/endpoint_addr.rs"},"region":{"startLine":147}}}],"partialFingerprints":{"codehealthFindingId/v1":"333ac4c1d139305cf7e5a09a82f5d64853e75086f7fbc761c70a5ea070f5a5da"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): iroh-relay/src/client/streams.rs:118-126 | iroh-relay/src/server/streams.rs:240-249 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/client/streams.rs"},"region":{"startLine":118}}}],"partialFingerprints":{"codehealthFindingId/v1":"5732c6bef244f61d75d50d3e2c23042dbd7acd1287cc0ef3e7f21474bf4c77eb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): iroh/src/net_report/reportgen.rs:723-731 | iroh/src/net_report/reportgen.rs:763-771 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report/reportgen.rs"},"region":{"startLine":723}}}],"partialFingerprints":{"codehealthFindingId/v1":"4fa39b50964cdf9c3cc10dd4346c2b5f682409012e24af9b6f113d6250d21659"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): iroh/src/endpoint.rs:1894-1899 | iroh/src/endpoint.rs:1900-1905 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/endpoint.rs"},"region":{"startLine":1894}}}],"partialFingerprints":{"codehealthFindingId/v1":"00dabe0d4522383e4f74be868c9383625a58a5d2214fee8b50dd3379095b26c5"}},{"ruleId":"D4","level":"warning","message":{"text":"Edited copy of a member (45 corresponding lines): iroh/bench/src/iroh.rs:159-203 | iroh/bench/src/noq.rs:128-172 \u2014 These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below \u2014 the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members\u0027 grain \u2014 factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/bench/src/iroh.rs"},"region":{"startLine":159}}}],"partialFingerprints":{"codehealthFindingId/v1":"0469957eef7dc5be8dfb29dcfea9f10d83efdcd81698a58fcb7f73f26f1508ea"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (27 lines \u00D7 2): iroh/bench/src/iroh.rs:207-233 | iroh/bench/src/noq.rs:176-202 \u2014 before extracting anything, compare \u0060iroh/bench/src/iroh.rs\u0060 and \u0060iroh/bench/src/noq.rs\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 118 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/bench/src/iroh.rs"},"region":{"startLine":207}}}],"partialFingerprints":{"codehealthFindingId/v1":"85aa7ec13f939d340751e25f561a4be1ebdef65bce50df6fceff759b64de8d47"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23 lines \u00D7 2): iroh/bench/src/iroh.rs:160-182 | iroh/bench/src/noq.rs:129-151 \u2014 before extracting anything, compare \u0060iroh/bench/src/iroh.rs\u0060 and \u0060iroh/bench/src/noq.rs\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 118 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/bench/src/iroh.rs"},"region":{"startLine":160}}}],"partialFingerprints":{"codehealthFindingId/v1":"da40485910b4403e6f89e6d566939344f27925aede655016a848b1815e0d3b33"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): iroh/bench/src/iroh.rs:289-310 | iroh/bench/src/noq.rs:258-279 \u2014 before extracting anything, compare \u0060iroh/bench/src/iroh.rs\u0060 and \u0060iroh/bench/src/noq.rs\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 118 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/bench/src/iroh.rs"},"region":{"startLine":289}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2226e2a51a9c950392deee55d495fa5d4fb180434a07e0d5d9a85a43568e104"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): iroh/bench/src/iroh.rs:240-256 | iroh/bench/src/noq.rs:209-225 \u2014 before extracting anything, compare \u0060iroh/bench/src/iroh.rs\u0060 and \u0060iroh/bench/src/noq.rs\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 118 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/bench/src/iroh.rs"},"region":{"startLine":240}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3ae7e4d39d2e0923766e9faf8b9541e2386a444100e945bc59921e1358f2d2f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): iroh/bench/src/iroh.rs:189-203 | iroh/bench/src/noq.rs:158-172 \u2014 before extracting anything, compare \u0060iroh/bench/src/iroh.rs\u0060 and \u0060iroh/bench/src/noq.rs\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 118 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/bench/src/iroh.rs"},"region":{"startLine":189}}}],"partialFingerprints":{"codehealthFindingId/v1":"050791c4b1edf96dcb94238e3f901b31bf49b4f6050f5f3859786df887474766"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): iroh/bench/src/iroh.rs:260-273 | iroh/bench/src/noq.rs:229-242 \u2014 before extracting anything, compare \u0060iroh/bench/src/iroh.rs\u0060 and \u0060iroh/bench/src/noq.rs\u0060 as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 118 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/bench/src/iroh.rs"},"region":{"startLine":260}}}],"partialFingerprints":{"codehealthFindingId/v1":"99a34392c2e58434270190946c57bd1d4905b84542bc67cc8ca72f8654c5cce2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): iroh/bench/src/bin/bulk.rs:78-90 | iroh/bench/src/bin/bulk.rs:141-153 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/bench/src/bin/bulk.rs"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"69b06b4b4e7377d400d5f9c32d89419bbc46293daf069bc1b66083a1bef5f019"}},{"ruleId":"D5","level":"warning","message":{"text":"Off the main sequence: iroh-base: iroh-base: abstractness 0.00, instability 0.00, distance 1.00 \u2014 zone of pain \u2014 concrete and depended on by 4 project(s), so it\u0027s rigid to change."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"9d38be1ffc1f0b714c1b6c92da5034536fb9b7405b1ee2f775b3d248bb5e4a84"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: iroh/src/socket/transports.rs: iroh/src/socket/transports.rs changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 32 in Transports::inner_poll_recv at line 278. 2 of those changes were fix/bug commits, and the other 4 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-06-30..2026-09-28, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-06-30 20:21:04 \u002B00:00\u0027 --until=\u00272026-09-28 20:21:04 \u002B00:00\u0027 --full-history --no-merges -- iroh/src/socket/transports.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports.rs"},"region":{"startLine":278}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce7c2a83749ffaed680458ba9a2df5942951e921bf54d53d7aa39593d0f7ff1f"}},{"ruleId":"D15","level":"warning","message":{"text":"Repeated repair: iroh-dns-server/src/http.rs: iroh-dns-server/src/http.rs changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file\u0027s churn. Its max cyclomatic complexity is 5 (its worst body is HttpServer::spawn at line 101), UNDER the 15 threshold, so this is deliberately not filed as a churn \u00D7 complexity hotspot \u2014 the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: \u201Cfix(iroh-dns-server): enable TCP keepalive on HTTP listeners (#4462)\u201D; \u201Cfix: bind iroh-dns-server to both IPv4 and IPv6 (#4432)\u201D; \u201Cfix: remove vergen use from build.rs files (#4426)\u201D. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-30..2026-09-28, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-06-30 20:21:04 \u002B00:00\u0027 --until=\u00272026-09-28 20:21:04 \u002B00:00\u0027 --full-history --no-merges -- iroh-dns-server/src/http.rs\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-dns-server/src/http.rs"},"region":{"startLine":101}}}],"partialFingerprints":{"codehealthFindingId/v1":"00197bc9f3b3794b797e05a4f4fdb3bd53fe4ded86ec4ce4c10657f3b7f91f60"}},{"ruleId":"D16","level":"note","message":{"text":"Off-boarding risk: anonymized user #1: If anonymized user #1 becomes unavailable, 1 significant file(s) lose their only recent owner: iroh/src/socket/remote_map/remote_state/path_watcher.rs. Pair on, review, or document these before any departure."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"5f78e32fd6fc0a77ad2acc29ec644cd14336c60fabca3eb85529a8b2ae5de963"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: less clones \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-dns-server/src/util.rs"},"region":{"startLine":155}}}],"partialFingerprints":{"codehealthFindingId/v1":"c9d33ffcb1a1fd4b48cc24b619659d6682748258cb425ff89aeaeed6ecc4c920"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Graceful cancellation. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-dns-server/src/http.rs"},"region":{"startLine":200}}}],"partialFingerprints":{"codehealthFindingId/v1":"b831ca8684acb3d2402dbec95458249da2008f7e98c209c001c56567a000152d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-dns-server/src/http.rs"},"region":{"startLine":299}}}],"partialFingerprints":{"codehealthFindingId/v1":"6fd16fc3be9d9d7b2cfe8d67821d8dab804d39e5463a2cef6a111ef2089845bc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: This is used by ZoneHandler::origin \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-dns-server/src/dns/node_zone_handler.rs"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"d8f5e06b10162f83d9f645c983d68e2792c16551e538549397c78230622c810d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Port tests from \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-dns-server/src/http/doh.rs"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"162c55cdfec0646f18890d9a5c9dd042644b12c75cabbd1cc34266e8dfbe47fc"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: accept_conn_limit and accept_conn_burst are not currently implemented. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/server.rs"},"region":{"startLine":486}}}],"partialFingerprints":{"codehealthFindingId/v1":"668b7d1fef4d27eb5cd4df599ec9c16cdf7f69d25ceb903213ca9057950975ff"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO(ramfox): I\u0027d like to be able to cancel this so we can close cleanly \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/quic.rs"},"region":{"startLine":326}}}],"partialFingerprints":{"codehealthFindingId/v1":"c81e2f291a146521908008fd7f8d85e391ccd27a0bfaf2c0877c6b443d9e5e6c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: add a label for the frame type. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/server/streams.rs"},"region":{"startLine":543}}}],"partialFingerprints":{"codehealthFindingId/v1":"0310ff2e7912b69717dd0de967207d8ad8c955f863327ed66aa53585aa4f252f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: only important stat that we cannot track right now \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/server/metrics.rs"},"region":{"startLine":107}}}],"partialFingerprints":{"codehealthFindingId/v1":"c45552b95dfaf8a5d57991ad46af3ded16236d604ef0be596e896efd28116b71"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: add rate limiter \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/server/client.rs"},"region":{"startLine":513}}}],"partialFingerprints":{"codehealthFindingId/v1":"df7955cbbddba36d9ff02bcc5031d1f6a585b0989bbbc8926e6cda6bd031ee8b"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: We don\u0027t support passing client transport config currently \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/bench/src/iroh.rs"},"region":{"startLine":124}}}],"partialFingerprints":{"codehealthFindingId/v1":"880465ed12ad765849dda13054b7d73eb78c23570ce96ce764f5175a70f9c8dd"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: enable/disable 0-RTT/storing tickets \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/tls.rs"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"39f32ec473d6b4cf1e237459e88f7623cea9231db50c11bcc079355d839ce062"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Use this \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket.rs"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"b6321233515b58e6aaa3483e7bcb99c0430aa367693efae3adaadaae2f78ed69"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Now check if we can connect to a repaired ep_3, but we can\u0027t modify that \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket.rs"},"region":{"startLine":2749}}}],"partialFingerprints":{"codehealthFindingId/v1":"71f2f0e5ab274f56cb4c670e6e0290943b145dda77b711d68e48eb61b3537b61"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: could remove the addresses again, send, add it back and see it recover. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket.rs"},"region":{"startLine":2864}}}],"partialFingerprints":{"codehealthFindingId/v1":"932533b8980c4c691acabd84cc9d564e4fd632f3446870e33b039302611ce911"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO(Frando): Rename to \u0060from_std\u0060 \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/protocol.rs"},"region":{"startLine":135}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ab603b6e6337e3c4bf9233c5255637740eccf405f222da5c9b017162ff3c4b3"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: randomize choice? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":496}}}],"partialFingerprints":{"codehealthFindingId/v1":"278f55e21a4ce2426d2c7d44ce812fda08e75e7ba8a9525714007dd68a106f0d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Maybe not panic if this is not true? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/endpoint.rs"},"region":{"startLine":2728}}}],"partialFingerprints":{"codehealthFindingId/v1":"d5dcf92fb142729c0aeccfc2b9b9f92967d5fe28fb7d4e7adb12515f54386a44"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO(Frando): Replace once we add a proper API for this. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/endpoint.rs"},"region":{"startLine":3879}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2026e8f417d73b5c7424e4fceda263f9f4487715213f83d4fddc4d0449e5760"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO(ramfox): this is currently unused. As we develop more \u0060AddressLookup\u0060s, we may discover that we do not need this. It is only truly relevant when comparing \u0060relay_urls\u0060, since we can attempt to dial any number of socket addresses, but expect each endpoint to have one \u0022home relay\u0022 that we will attempt to contact them on. This means we would need some way to determine which relay url to choose between, if more than one relay url is reported. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/address_lookup.rs"},"region":{"startLine":383}}}],"partialFingerprints":{"codehealthFindingId/v1":"077dcbe63e57c4d5f9f0cded2d0de18baecee55296d81da1b70440473d346001"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO(flub): huh? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/address_lookup/pkarr.rs"},"region":{"startLine":142}}}],"partialFingerprints":{"codehealthFindingId/v1":"87667543d9a21893036f8368ebc31ec758630d0018f534e36acf39dc85653984"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: is this good? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report/probes.rs"},"region":{"startLine":126}}}],"partialFingerprints":{"codehealthFindingId/v1":"78ef4036b97af23f9436fc4103ccfb3e8989f80b13441129bc069b09cb226ebf"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Revisit this: we might want to do something better. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports.rs"},"region":{"startLine":1211}}}],"partialFingerprints":{"codehealthFindingId/v1":"f9f6ed91adc96e48f7d2fd2bb11a1329a58dc0fd71897fa60c8b7e7a4baca622"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Revisit this: we might want to do something better. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports.rs"},"region":{"startLine":1295}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c8b7dfd7e27e81014116c15b33d2f555440bff2f4b105340bdfb4f88a2ce777"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: use this \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/remote_map.rs"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"55bc2883dc0127f10a630d8b8bc608d95a19eb38eefec6695ed5d20bf873b902"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: use this \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/remote_map/remote_state.rs"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"daf58f88f87ad3b1f0d24bd5321dcca5d2e5df68383e1623666e1a9affb2c963"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // todo: trace \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/remote_map/remote_state.rs"},"region":{"startLine":503}}}],"partialFingerprints":{"codehealthFindingId/v1":"e7afdbab1874a5fa3bbf4105373fabc36efd85edc9053c23729eba5b3ed4687d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Is it possible to recover using the sync APIs to figure out what the \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/remote_map/remote_state.rs"},"region":{"startLine":576}}}],"partialFingerprints":{"codehealthFindingId/v1":"d27b29eb622a7730bb388df731bef830470c37e25588e5a13d7cf2ad63a1680d"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO(Frando): We might want to include a local IP here in the future, if we confidently \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/remote_map/remote_state.rs"},"region":{"startLine":808}}}],"partialFingerprints":{"codehealthFindingId/v1":"2271cd7ab6c067754ecd6df8c49b4ede88b255a9293461829a15499dc89442f1"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO(Frando): We might want to include a local IP here in the future, if we confidently \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/remote_map/remote_state.rs"},"region":{"startLine":834}}}],"partialFingerprints":{"codehealthFindingId/v1":"a075fd49000a847091f1ca73ef1407ed2d4adc206a75b5a9cf30c3d6e491dde6"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: update when UdpSocket under the hood rebinds automatically \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports/ip.rs"},"region":{"startLine":180}}}],"partialFingerprints":{"codehealthFindingId/v1":"753ab1ddd4b6c0097ffd1c53c175d35b6eff0bd6b8ad6b57f3f95bd5c0aa4786"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO(frando): can we avoid the clone here? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports/relay/actor.rs"},"region":{"startLine":673}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad66870f1ead37823c083f6ccb6823a35b18de6a1457607788da6a666c3fde62"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: Replace 64 with PER_CLIENT_SEND_QUEUE_DEPTH once that\u0027s unused \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/transports/relay/actor.rs"},"region":{"startLine":1359}}}],"partialFingerprints":{"codehealthFindingId/v1":"21acc551ae4ecab7a58c6d72f0f2a84763a82324c0e8d862ee33c3754aeac678"}},{"ruleId":"D20","level":"note","message":{"text":"No ADRs found: No ADRs found. No recognised ADR directory (\u0060docs/adr/\u0060, \u0060docs/decisions/\u0060, \u0060adr/\u0060, \u0060docs/rfcs/\u0060, an \u0060ADR0001/\u0060 folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (\u0060docs/adr/use-postgres.md\u0060, \u0060docs/adr/2024/0001-x.md\u0060); or a file anywhere whose name is ADR-shaped (\u00600001-use-postgres.md\u0060, \u0060adr-012-caching.md\u0060); or, when neither turned anything up, a document carrying the decision-record signature (an \u0022Architecture Decision Record\u0022 heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these \u2014 unnumbered files outside any recognised directory, without those headings \u2014 is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in \u0060docs/adr/\u0060."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"d2bea044ff79d7d275f5a91a6e2f548586178eaf480274c33960ad020c854631"}},{"ruleId":"D22","level":"warning","message":{"text":"Redundant factory methods with unclear distinction. Both return a builder, but it is unclear if \u0060n0_dns\u0060 is a specialized version of \u0060builder\u0060 or if they produce different default configurations. In other types (e.g., PkarrPublisher), \u0060n0_dns\u0060 is also present alongside \u0060builder\u0060, suggesting a pattern, but the naming is confusing for users who don\u0027t know the internal \u0027n0\u0027 convention.: Remove \u0060n0_dns\u0060 if it is merely an alias for \u0060builder\u0060 with specific defaults, or rename \u0060builder\u0060 to \u0060custom\u0060 and keep \u0060n0_dns\u0060 as the primary factory if \u0027n0\u0027 defaults are the standard use case. Alternatively, document clearly that \u0060n0_dns\u0060 is a convenience method for a specific preset. (signatures: DnsAddressLookup.builder(origin_domain: String): DnsAddressLookupBuilder | DnsAddressLookup.n0_dns(): DnsAddressLookupBuilder)"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"6a1f99b56183a9c9e1ba0cb8508efb3bc290c626c026ea39bd33309531ad19f6"}},{"ruleId":"D22","level":"warning","message":{"text":"Consistent but confusing pattern across multiple types. The presence of \u0060n0_dns()\u0060 alongside \u0060builder()\u0060 in both Publisher and Resolver suggests a library-specific convention (\u0027n0\u0027) that is not self-explanatory. It creates cognitive load to determine which factory method to use.: Unify the naming convention. If \u0060n0_dns\u0060 is the recommended way, make it the primary method or rename it to \u0060default()\u0060 or \u0060standard()\u0060. If \u0060builder\u0060 is the generic way, ensure \u0060n0_dns\u0060 is clearly documented as a preset wrapper. (signatures: PkarrPublisher.builder(pkarr_relay: Url): PkarrPublisherBuilder | PkarrPublisher.n0_dns(): PkarrPublisherBuilder | PkarrResolver.builder(pkarr_relay: Url): PkarrResolverBuilder | PkarrResolver.n0_dns(): PkarrResolverBuilder)"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"92efc49855383039a47fd4391a43e7ba3ef821bd65d5cb8fa7ebc35690a7abbc"}},{"ruleId":"D22","level":"warning","message":{"text":"Inconsistent naming and return types for similar operations. \u0060from_endpoint_info\u0060 is a constructor-like static method. \u0060set_endpoint_info\u0060 returns \u0060EndpointData\u0060 (likely the stored data), while \u0060add_endpoint_info\u0060 returns \u0060Self\u0060 (unit/void). The distinction between \u0027set\u0027 and \u0027add\u0027 is not immediately obvious from the signature alone (does set overwrite? does add append?).: Standardize on \u0060add\u0060 or \u0060insert\u0060 for mutation. If \u0060set\u0060 implies overwriting and \u0060add\u0060 implies appending, the names are good, but the return types should be consistent (e.g., both return \u0060Option\u003CEndpointData\u003E\u0060 for the previous value, or both return \u0060Self\u0060). Consider renaming \u0060from_endpoint_info\u0060 to \u0060new_with\u0060 or \u0060from_iter\u0060 for clarity. (signatures: MemoryLookup.from_endpoint_info(infos: impl IntoIterator\u003CItem = impl Into\u003CEndpointInfo\u003E\u003E): Self | MemoryLookup.set_endpoint_info(endpoint_info: impl Into\u003CEndpointInfo\u003E): EndpointData | MemoryLookup.add_endpoint_info(endpoint_info: impl Into\u003CEndpointInfo\u003E))"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"23fdbf8773f96af6f06f88ff39e21398258b64cd3566093ee8c7ba66515d0ce3"}},{"ruleId":"D22","level":"warning","message":{"text":"Standard Rust naming convention violation or confusion. \u0060to_\u0060 usually implies borrowing/converting without consuming, while \u0060into_\u0060 implies consuming the source. However, both return the same type \u0060EndpointAddr\u0060. If \u0060to_endpoint_addr\u0060 borrows internally, it should return a reference or a copy. If it consumes, it should be \u0060into_\u0060. Having both suggests one might be a legacy alias or they perform different internal operations (e.g., one clones, one moves) which is confusing.: Remove one. If \u0060Item\u0060 is cheap to clone, \u0060to_endpoint_addr\u0060 is fine. If it\u0027s expensive, \u0060into_endpoint_addr\u0060 is better. Do not expose both unless they have distinct semantic meanings (e.g., one returns a reference, one returns an owned value, but the signature shows both return \u0060EndpointAddr\u0060 owned). (signatures: Item.to_endpoint_addr(): EndpointAddr | Item.into_endpoint_addr(): EndpointAddr)"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"829180d9a0d66489d93e63787903a36c6942d6e1996436a48e3537dec35cbeea"}},{"ruleId":"D22","level":"warning","message":{"text":"Ambiguous naming. \u0060closed()\u0060 typically implies a state check (boolean) or a future/stream of closure events. \u0060close_reason()\u0060 implies getting the reason for closure. Returning the same type \u0060ConnectionError\u0060 from both suggests they might be accessing the same internal state, but the names suggest different intents (state vs. reason).: Rename \u0060closed()\u0060 to \u0060close_error()\u0060 or \u0060last_close_error()\u0060 if it returns the error. If \u0060closed()\u0060 is meant to be a state check, it should return \u0060bool\u0060 or \u0060Option\u003CConnectionError\u003E\u0060. Clarify the distinction between the state of being closed and the reason for closure. (signatures: Connection.close_reason(): ConnectionError | Connection.closed(): ConnectionError)"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"a7ba91f1be445b690718af1a92e5a26fa270fdc9e04461c10581f4ccd07a616e"}},{"ruleId":"D22","level":"warning","message":{"text":"Duplicate method name with different return types. This is a signature collision in the API surface (overloading by return type is not supported in Rust, so these must be on different types or one is a typo in the provided list, or they are methods on different traits/impls not shown as distinct types). Assuming they are on the same \u0060Connection\u0060 type, this is a compilation error. If they are on different types (e.g., \u0060Connection\u0060 vs \u0060Incoming\u0060), the naming is inconsistent. Looking at the list, \u0060Incoming\u0060 has \u0060remote_addr\u0060 etc., but \u0060Connection\u0060 has two \u0060alpn\u0060 methods listed. This is likely a data error or a severe API design flaw if they are on the same type.: Ensure these are on distinct types. If on the same type, rename one to \u0060alpn_protocol()\u0060 and \u0060alpn_bytes()\u0060 or similar to distinguish the return type intent. (signatures: Connection.alpn(): \u0026[u8] | Connection.alpn(): u8)"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"3e547636c69a246009aa681242ee43e0b471a83d84951204ada0e8157a93bfae"}},{"ruleId":"D26","level":"note","message":{"text":"Projects may be oversized for their cohesion: 1 of 5 project(s) overshoot their size bounds, lowering Project Cohesion to 6.0/10. The most over is \u0060iroh\u0060 (26108 LoC, 132 public types across 11 directories). Review these for cohesion \u2014 draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"d5a94650dc74886a0f1f08eb9fb6775f1fc395279ef7e901c970c9d26f767a72"}},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"525a45338366738b480501e7590b14171207903cc661ba27ea2cdb9c09a00e82"},"taxa":[{"id":"CWE-494","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"41a75dcf602eb09151411d16ed03d850531837fb10ca676a087882fd3230e695"},"taxa":[{"id":"CWE-522","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-668","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"2aa099ccbb5a919201d5d201bb335fe0c9cd5cee7dbb154070bafe28df22a6d6"},"taxa":[{"id":"CWE-522","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-668","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"2d15a3a6414fa7b12c443c0c5f143cc3f008224cc6b8cbc1e0d2ff57c4686929"},"taxa":[{"id":"CWE-494","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"692906559b68bbc5c3b0ba91cfdf8e0b2dbefd5a206ee1ac05120fd5e2ba0fb8"},"taxa":[{"id":"CWE-522","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-829","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"7c0646fcc82a872883d52c2f5f299e5577e8132b06e189d27c03a285a4ed279f"},"taxa":[{"id":"CWE-214","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-532","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"34b4e15e451c7035ca763d83217d5dce9f8a960729befb70ff82a820c683a4fa"},"taxa":[{"id":"CWE-494","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"e0e706eb5da0090a1431dfe26c7b04ad57b79aec82d71b0a8b771cac405ba1a1"},"taxa":[{"id":"CWE-494","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"98842c7270ea6919220af1b61d2e39109aaa51f75f33ad131ab3ada5426b45a6"},"taxa":[{"id":"CWE-522","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-668","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"71bef1ea98ccb7dea04dc642679f5b5280730c24fef9e9a917f9ac1a55e5b52c"},"taxa":[{"id":"CWE-522","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-668","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"c64d0b1760407887e8da19c88f32fb37fe12098a77171950378266cb00641d0a"},"taxa":[{"id":"CWE-1104","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-829","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D30","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"9d7e2f5e4e133844171b9412d83e460349b527553e21e4eb5d4f1e038ed6831f"},"properties":{"dependency":{"package":"atomic-polyfill","version":"1.0.3","advisory":"RUSTSEC-2023-0089","reachability":{"kind":"unknown"}}}},{"ruleId":"D30","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"5922a5beeab5ac077ffb485a783ad545036e79b56239f83da38f3fb84336b113"},"properties":{"dependency":{"package":"paste","version":"1.0.15","advisory":"RUSTSEC-2024-0436","reachability":{"kind":"unknown"}}}},{"ruleId":"D31","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"f9deb0b3e9568df1171bacf908174d514cb7e71041f1c1975b38340d1bde8fc0"}},{"ruleId":"D31","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"31fb7ada11de80469ba762f889c4120ca4c46f0a9bde2666fb797f583ecdf041"}},{"ruleId":"D31","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"6a18fdebcf79f357c6ec93448103ab22cfc59c572e86889cb1d09fad139c6e5e"}},{"ruleId":"D31","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"82d96df33eb2300b41796a54723fe9958e89a1b8621ae4abbf05b611544d938d"}},{"ruleId":"D31","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"acb8c3c736222806b993892fbc2842a592bdbe62e4a53ea61af8a9d559b2d6bf"}},{"ruleId":"D31","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"456d2c3f511799653c765ed1632fec68481d07b1aa9db4d76a6f5dab8c714fd8"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D31","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"ace39eb0ac22a1971061fe86734382a32f04651720e85671ed087b440e8b179f"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D31","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"b09b72c3ebbe1a0fd4b5b82f02046db0bb8df33944176d96c070415ac6b2c1c2"}},{"ruleId":"D31","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"bc2e1a8e4d7b43b1f07935b1ee747b826172f9346691a503eb58ddfc3593555a"}},{"ruleId":"D31","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"1c06238e52893b3de6673dbccc8fe832932126f328f5f16387b383dc4abf938d"}},{"ruleId":"D31","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"ccc0cc717a360059224d480b2bc872b7f88a881960a07fa78798e15be3c752b9"}},{"ruleId":"D31","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"0a00fd11229030bcee48c7aebf8a64c7c97d30f75cc51c9272d9a75b070c8a02"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned files with no living knowledge: 1 of 90 analysed file(s) have no living knowledge left \u2014 their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 90 of the 108 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each \u2014 most significant first: iroh-relay/src/client/util.rs. Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"ce861fd78f6935114d3a342cb90ad25870f984e1042954fcbbe27c0e23be3658"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: mapped_addrs.rs \u2194 remote_state.rs: \u0060iroh/src/socket/mapped_addrs.rs\u0060 and \u0060iroh/src/socket/remote_map/remote_state.rs\u0060 change together 57% of the time (13 of the 23 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency \u2014 the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE \u2014 the registration is the link, and it is meant not to be an import \u2014 and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 13 shared commits counted here, the most recent 3 are \u006014bae032\u0060 refactor(iroh)!: Use FourTuple for selected path (#4273); \u0060d434c85e\u0060 feat: Implement custom transports (#3845); \u00602d8b2d49\u0060 refactor!: goodbye magic (#3887) \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/socket/mapped_addrs.rs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"485fc6dff915d87319f007e62fbe44f72feca95cd9ac7a689a2ca57e560a11ed"}},{"ruleId":"D36","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"1b213f6eedd4b140d0bc37bdf1496f72811a643f34064f12518b32e9e83bcfc7"}},{"ruleId":"D36","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"0e17f71490e4d120a48b2b2881ab866c93b272bef2febb673a3e8e42b2c288ab"}},{"ruleId":"D36","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"eb00976a698a5d68999b7ee6d27206fd374e916853e7ff1ead5eed42386f043f"}},{"ruleId":"D36","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"d657599f6f99da1927d3377533dfc0888b34c4d84aa7d5579841fd72d0e39bce"}},{"ruleId":"D36","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"c593d4dbd23724f337bfb8d2c1653812f143ae255bd9b59d4b3e9c37779fa6f4"}},{"ruleId":"AX9","level":"error","message":{"text":"Query writes persistent state on the read path: Client.get_report: \u0060Client.get_report\u0060 is a read-named query yet it performs a durable write on the read path (a persist to a store/repository). A query must stay side-effect-free so reads are safe to retry, cache, and route to a read replica; move the write into a command."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/net_report.rs"},"region":{"startLine":296}}}],"partialFingerprints":{"codehealthFindingId/v1":"db2cb1f3152db40845ef911a0dfc2eaaed374e9ef13bb80d5927b64ce711eb2b"}},{"ruleId":"M2","level":"note","message":{"text":"No ADRs: No Architecture Decision Records found \u2014 no conventional ADR directory, no numbered \u0060NNNN-title\u0060 documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"670b3d6e36a756d63097d0dfbf90afd5fc761308800b9354894a07c3f4e4aa14"}},{"ruleId":"M4","level":"note","message":{"text":"README/code drift: README advertises a RAG / ML engine, but no ML/RAG code or dependency exists \u2014 searched for: \u0060rag\u0060, \u0060langchain\u0060, \u0060llamaindex\u0060, \u0060pinecone\u0060, \u0060weaviate\u0060, \u0060qdrant\u0060, \u0060embeddings\u0060. Each was matched case- and separator-insensitively against file and directory NAMES anywhere in the tree, and against the CONTENTS of manifest files (package.json, *.csproj, *.props, *.slnx, *.yml, Dockerfile); the README\u0027s own prose never counts, so a claim is never refuted by merely being made. Nothing outside that search was read \u2014 a footprint living only in a submodule, in a file type not listed here, or under a name none of those terms matches is not seen, and this row is then wrong."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"343bbbd51ceb8de7a9ff88d79f7c797abf9b5921f8727b67b4d0f4f8a22c5e49"}},{"ruleId":"P7","level":"warning","message":{"text":"Outbound HTTP without resilience: \u0060reqwest::Client::builder(\u0060 makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service\u0027s request, thread or connection until the call gives up on its own \u2014 or never, for a client with no default timeout. 2 of the 2 files that make outbound calls are unbounded; the first 2 are listed."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh-relay/src/main.rs"},"region":{"startLine":221}}}],"partialFingerprints":{"codehealthFindingId/v1":"dc34feb0d7497d7ac0040b33962ec572f7196df98c84ae148895b509f954032b"}},{"ruleId":"P7","level":"warning","message":{"text":"Outbound HTTP without resilience: \u0060reqwest::Client::builder(\u0060 makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service\u0027s request, thread or connection until the call gives up on its own \u2014 or never, for a client with no default timeout."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"iroh/src/util.rs"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"974c14e1405091304dea18f7f48988d117bee4853df7e3f255e87a89d1b6dab7"}}],"taxonomies":[{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d","organization":"MITRE","informationUri":"https://cwe.mitre.org/","isComprehensive":false,"shortDescription":{"text":"The MITRE Common Weakness Enumeration (CWE)."},"taxa":[{"id":"CWE-1032","guid":"5f21e517-68aa-a650-9a25-5771ef024637","name":"OWASP Top Ten \u2014 Security Misconfiguration category","shortDescription":{"text":"OWASP Top Ten \u2014 Security Misconfiguration category"},"helpUri":"https://cwe.mitre.org/data/definitions/1032.html"},{"id":"CWE-1104","guid":"4c918cb5-b2a6-6c55-9963-a44ee464305e","name":"CWE-1104","shortDescription":{"text":"CWE-1104"},"helpUri":"https://cwe.mitre.org/data/definitions/1104.html"},{"id":"CWE-1357","guid":"e4d2e772-757e-0a5c-bd7d-77052949d866","name":"Reliance on Insufficiently Trustworthy Component","shortDescription":{"text":"Reliance on Insufficiently Trustworthy Component"},"helpUri":"https://cwe.mitre.org/data/definitions/1357.html"},{"id":"CWE-1395","guid":"800e09e7-c11a-8654-9fa6-86f398995fed","name":"Dependency on Vulnerable Third-Party Component","shortDescription":{"text":"Dependency on Vulnerable Third-Party Component"},"helpUri":"https://cwe.mitre.org/data/definitions/1395.html"},{"id":"CWE-16","guid":"659db3ea-affc-8453-8add-c1218fbfcb92","name":"Configuration","shortDescription":{"text":"Configuration"},"helpUri":"https://cwe.mitre.org/data/definitions/16.html"},{"id":"CWE-214","guid":"b10ad120-fb22-1351-9348-aa23b453e815","name":"CWE-214","shortDescription":{"text":"CWE-214"},"helpUri":"https://cwe.mitre.org/data/definitions/214.html"},{"id":"CWE-259","guid":"ae9ad959-fbb6-9d5e-892d-3dca66da0b69","name":"Use of Hard-coded Password","shortDescription":{"text":"Use of Hard-coded Password"},"helpUri":"https://cwe.mitre.org/data/definitions/259.html"},{"id":"CWE-353","guid":"09d7e902-d4ee-f05d-ae6c-0a1554d0c18f","name":"CWE-353","shortDescription":{"text":"CWE-353"},"helpUri":"https://cwe.mitre.org/data/definitions/353.html"},{"id":"CWE-494","guid":"b8a65e0d-e459-4a55-a931-fc1136482375","name":"Download of Code Without Integrity Check","shortDescription":{"text":"Download of Code Without Integrity Check"},"helpUri":"https://cwe.mitre.org/data/definitions/494.html"},{"id":"CWE-506","guid":"401d6455-56e3-0552-9a39-f77461673e3f","name":"CWE-506","shortDescription":{"text":"CWE-506"},"helpUri":"https://cwe.mitre.org/data/definitions/506.html"},{"id":"CWE-522","guid":"71fb233e-ce6a-ae57-9419-ef8373540b09","name":"CWE-522","shortDescription":{"text":"CWE-522"},"helpUri":"https://cwe.mitre.org/data/definitions/522.html"},{"id":"CWE-532","guid":"1cd8877a-76e8-ce54-b40b-779af23364a0","name":"CWE-532","shortDescription":{"text":"CWE-532"},"helpUri":"https://cwe.mitre.org/data/definitions/532.html"},{"id":"CWE-668","guid":"e2cb99db-6d24-b056-b0d0-885a733ec403","name":"CWE-668","shortDescription":{"text":"CWE-668"},"helpUri":"https://cwe.mitre.org/data/definitions/668.html"},{"id":"CWE-732","guid":"1da27e8f-b330-7650-ab63-bd61953eae5d","name":"Incorrect Permission Assignment for Critical Resource","shortDescription":{"text":"Incorrect Permission Assignment for Critical Resource"},"helpUri":"https://cwe.mitre.org/data/definitions/732.html"},{"id":"CWE-77","guid":"332c8ade-6612-9f56-a06b-d8d90b1a8750","name":"Command Injection","shortDescription":{"text":"Command Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/77.html"},{"id":"CWE-78","guid":"2e31ceaf-c7ae-2e5e-9661-cfb1362789cf","name":"OS Command Injection","shortDescription":{"text":"OS Command Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/78.html"},{"id":"CWE-79","guid":"fd45580b-e8c4-fc5e-8c2f-aa8fab0b4dbf","name":"Cross-site Scripting (XSS)","shortDescription":{"text":"Cross-site Scripting (XSS)"},"helpUri":"https://cwe.mitre.org/data/definitions/79.html"},{"id":"CWE-798","guid":"5e8f057d-fee3-995a-a0cb-9fc5b0d174d1","name":"Use of Hard-coded Credentials","shortDescription":{"text":"Use of Hard-coded Credentials"},"helpUri":"https://cwe.mitre.org/data/definitions/798.html"},{"id":"CWE-829","guid":"13c33925-97fb-5a5e-b40c-56d328b8a4d7","name":"CWE-829","shortDescription":{"text":"CWE-829"},"helpUri":"https://cwe.mitre.org/data/definitions/829.html"},{"id":"CWE-89","guid":"6d08fdad-37eb-c150-bbf0-d7d946863407","name":"SQL Injection","shortDescription":{"text":"SQL Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/89.html"},{"id":"CWE-937","guid":"16f316ae-415c-b354-a59b-1f7905f756e9","name":"Using Components with Known Vulnerabilities","shortDescription":{"text":"Using Components with Known Vulnerabilities"},"helpUri":"https://cwe.mitre.org/data/definitions/937.html"},{"id":"CWE-94","guid":"75e7f50c-6c2f-dd52-bf40-bf6c52b861fd","name":"Code Injection","shortDescription":{"text":"Code Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/94.html"}]}],"properties":{"codehealthPublication":{"public":true,"notice":"This is the PUBLIC form of this artifact. Findings are listed in full, but the details of SECURITY findings \u2014 which rule fired, in which file, on which line, and how to fix it \u2014 are deliberately withheld, and any secret-scanner results are excluded entirely. Where detail is absent here it was REMOVED FOR PUBLICATION; it is not missing from the analysis. The complete artifact is available from the repository owner.","securityFindingsRedacted":30,"secretScannerRunsExcluded":0}},"redactionTokens":["A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."]}]}