{"$schema":"https://json.schemastore.org/sarif-2.1.0.json","version":"2.1.0","runs":[{"tool":{"driver":{"name":"codehealth","informationUri":"https://codehealth.canine.dev","rules":[{"id":"D1","name":"Cyclomatic Complexity","shortDescription":{"text":"Cyclomatic Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D1"},{"id":"D2","name":"Cognitive Complexity","shortDescription":{"text":"Cognitive Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D2"},{"id":"D3","name":"God Classes","shortDescription":{"text":"God Classes"},"helpUri":"https://codehealth.canine.dev/dimensions/D3"},{"id":"D4","name":"Code Duplication","shortDescription":{"text":"Code Duplication"},"helpUri":"https://codehealth.canine.dev/dimensions/D4"},{"id":"D9","name":"Test Distribution","shortDescription":{"text":"Test Distribution"},"helpUri":"https://codehealth.canine.dev/dimensions/D9"},{"id":"D10","name":"Test Quality","shortDescription":{"text":"Test Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D10"},{"id":"D12","name":"Dependency Hygiene","shortDescription":{"text":"Dependency Hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/D12"},{"id":"D13","name":"Secret Scanning","shortDescription":{"text":"Secret Scanning"},"helpUri":"https://codehealth.canine.dev/dimensions/D13","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"]}},{"id":"D15","name":"Churn \u00D7 Complexity Hotspots","shortDescription":{"text":"Churn \u00D7 Complexity Hotspots"},"helpUri":"https://codehealth.canine.dev/dimensions/D15"},{"id":"D17","name":"Explicit Debt","shortDescription":{"text":"Explicit Debt"},"helpUri":"https://codehealth.canine.dev/dimensions/D17"},{"id":"D19","name":"Documentation Quality","shortDescription":{"text":"Documentation Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D19"},{"id":"D21","name":"Naming Consistency","shortDescription":{"text":"Naming Consistency"},"helpUri":"https://codehealth.canine.dev/dimensions/D21"},{"id":"D28","name":"Secrets (history)","shortDescription":{"text":"Secrets (history)"},"helpUri":"https://codehealth.canine.dev/dimensions/D28","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"]}},{"id":"D29","name":"Static Analysis (SAST)","shortDescription":{"text":"Static Analysis (SAST)"},"helpUri":"https://codehealth.canine.dev/dimensions/D29","relationships":[{"target":{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-89","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-94","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-77","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-79","CWE-89","CWE-78","CWE-94","CWE-77"]}},{"id":"D30","name":"Dependency Vulnerabilities","shortDescription":{"text":"Dependency Vulnerabilities"},"helpUri":"https://codehealth.canine.dev/dimensions/D30","relationships":[{"target":{"id":"CWE-1395","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-937","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-1395","CWE-937"]}},{"id":"D31","name":"IaC \u0026 Container Security","shortDescription":{"text":"IaC \u0026 Container Security"},"helpUri":"https://codehealth.canine.dev/dimensions/D31","relationships":[{"target":{"id":"CWE-1032","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-732","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-16","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-1032","CWE-732","CWE-16"]}},{"id":"D34","name":"Knowledge Freshness","shortDescription":{"text":"Knowledge Freshness"},"helpUri":"https://codehealth.canine.dev/dimensions/D34"},{"id":"D35","name":"Change Coupling","shortDescription":{"text":"Change Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D35"},{"id":"D43","name":"Malicious Dependencies","shortDescription":{"text":"Malicious Dependencies"},"helpUri":"https://codehealth.canine.dev/dimensions/D43","relationships":[{"target":{"id":"CWE-506","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-506"]}},{"id":"D44","name":"Platform End-of-Life","shortDescription":{"text":"Platform End-of-Life"},"helpUri":"https://codehealth.canine.dev/dimensions/D44"},{"id":"AX10","name":"Code composition","shortDescription":{"text":"Code composition"},"helpUri":"https://codehealth.canine.dev/dimensions/AX10"},{"id":"AXB2","name":"Runtime readiness","shortDescription":{"text":"Runtime readiness"},"helpUri":"https://codehealth.canine.dev/dimensions/AXB2"},{"id":"M1","name":"Documentation (README)","shortDescription":{"text":"Documentation (README)"},"helpUri":"https://codehealth.canine.dev/dimensions/M1"},{"id":"M2","name":"Architecture documentation","shortDescription":{"text":"Architecture documentation"},"helpUri":"https://codehealth.canine.dev/dimensions/M2"},{"id":"M3","name":"Folder \u0026 project structure","shortDescription":{"text":"Folder \u0026 project structure"},"helpUri":"https://codehealth.canine.dev/dimensions/M3"},{"id":"M4","name":"Documentation accuracy","shortDescription":{"text":"Documentation accuracy"},"helpUri":"https://codehealth.canine.dev/dimensions/M4"},{"id":"P1","name":"CI/CD gates","shortDescription":{"text":"CI/CD gates"},"helpUri":"https://codehealth.canine.dev/dimensions/P1"},{"id":"P3","name":"Security \u0026 performance tooling","shortDescription":{"text":"Security \u0026 performance tooling"},"helpUri":"https://codehealth.canine.dev/dimensions/P3"},{"id":"X9","name":"Subsumed condition operand","shortDescription":{"text":"Subsumed condition operand"},"helpUri":"https://codehealth.canine.dev/dimensions/X9"}]}},"results":[{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9\u201311 lines \u00D7 2): src/Presentation/Api/Controller/GetContact.php:62-72 | src/Presentation/Api/Controller/GetContacts.php:43-51 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/Presentation/Api/Controller/GetContact.php:62\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Presentation/Api/Controller/GetContact.php"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"ebc4932e034e1e523ed55b8cc0acaf03aaa7ae3114adc133c3ea027b506e3e78"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/Presentation/Api/Controller/AddContact.php:67-75 | src/Presentation/Api/Controller/UpdateContact.php:86-94 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Presentation/Api/Controller/AddContact.php"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"e876d3cad403a8cad94bd6a40a5b74321859388abcc1de764f85f6589a163749"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/Presentation/Api/Controller/GetContact.php:50-57 | src/Presentation/Api/Controller/RemoveContact.php:50-57 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Presentation/Api/Controller/GetContact.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"2fc7537268080c3480e542ab5b1d8f7742c50d366463c7782d33a2a8e1d57068"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (24 lines \u00D7 2): src/Domain/Dto/UpdateContact.php:46-69 | src/Domain/Entity/Contact.php:48-81 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/Domain/Dto/UpdateContact.php:46\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Domain/Dto/UpdateContact.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"41336de532dbdc46d63638f88139dbd85ad1e6a9226477a40bb3d7924a7f3d1d"}},{"ruleId":"D10","level":"note","message":{"text":"No direct assertions: testWithValidOptions: No conventional assertion call was detected, and 10 of 17 tests in \u0060ntorga/clean-ddd-php-poc-contacts\u0060 read the same way \u2014 so this is treated as that project\u0027s convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tests/Domain/ValueObject/ContactIdTest.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"c06d98c3a72526068b956ad53a1c8a1097dacff0e1a844889a7ac70961d35df0"}},{"ruleId":"D10","level":"note","message":{"text":"No direct assertions: testWithInvalidOptions: No conventional assertion call was detected, and 10 of 17 tests in \u0060ntorga/clean-ddd-php-poc-contacts\u0060 read the same way \u2014 so this is treated as that project\u0027s convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tests/Domain/ValueObject/ContactIdTest.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"15ff0d2a8c6a272c5eb03e9e499d5d373f0c40fc64df84aa19d1beade10cf8bf"}},{"ruleId":"D10","level":"note","message":{"text":"No direct assertions: testWithValidOptions: No conventional assertion call was detected, and 10 of 17 tests in \u0060ntorga/clean-ddd-php-poc-contacts\u0060 read the same way \u2014 so this is treated as that project\u0027s convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tests/Domain/ValueObject/NicknameTest.php"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f4b2a46918bfda54b3c831effa32dc027e90e7cb05d61c88de030a695a4f549"}},{"ruleId":"D10","level":"note","message":{"text":"No direct assertions: testWithInvalidOptions: No conventional assertion call was detected, and 10 of 17 tests in \u0060ntorga/clean-ddd-php-poc-contacts\u0060 read the same way \u2014 so this is treated as that project\u0027s convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tests/Domain/ValueObject/NicknameTest.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f73b8b7de7878bd8fdb04cc2d238eb5b083eb2de999be98f96075de24a948af"}},{"ruleId":"D10","level":"note","message":{"text":"No direct assertions: testWithValidOptions: No conventional assertion call was detected, and 10 of 17 tests in \u0060ntorga/clean-ddd-php-poc-contacts\u0060 read the same way \u2014 so this is treated as that project\u0027s convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tests/Domain/ValueObject/PersonNameTest.php"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"7053c45e971c5a6dec3e8dafc007dbe6df986a035d3306f13982e7358906a3e3"}},{"ruleId":"D10","level":"note","message":{"text":"No direct assertions: testWithInvalidOptions: No conventional assertion call was detected, and 10 of 17 tests in \u0060ntorga/clean-ddd-php-poc-contacts\u0060 read the same way \u2014 so this is treated as that project\u0027s convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tests/Domain/ValueObject/PersonNameTest.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"b1dea2f58cffe9c9c2b125c28a586b10220512e55529f9a7fa7ebf2bbf0b253e"}},{"ruleId":"D10","level":"note","message":{"text":"No direct assertions: testWithValidOptions: No conventional assertion call was detected, and 10 of 17 tests in \u0060ntorga/clean-ddd-php-poc-contacts\u0060 read the same way \u2014 so this is treated as that project\u0027s convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tests/Domain/ValueObject/PhoneNumberTest.php"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"68465279e14d50ce2c3c2aa00b1dd00e67ef4c414ec5b00996894b0075d1171a"}},{"ruleId":"D10","level":"note","message":{"text":"No direct assertions: testWithInvalidOptions: No conventional assertion call was detected, and 10 of 17 tests in \u0060ntorga/clean-ddd-php-poc-contacts\u0060 read the same way \u2014 so this is treated as that project\u0027s convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tests/Domain/ValueObject/PhoneNumberTest.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"f53f2c422cdeb64b444bcfecb495a5e0033a8961267ef8706d57d7bc132e117e"}},{"ruleId":"D10","level":"note","message":{"text":"No direct assertions: testAddAndRemoveContact: No conventional assertion call was detected, and 10 of 17 tests in \u0060ntorga/clean-ddd-php-poc-contacts\u0060 read the same way \u2014 so this is treated as that project\u0027s convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tests/Infrastructure/ContactCommandRepositoryTest.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce0c2054993acc460032b7f2f67c08323619fc5b9fde86ae84a4c627da1f595c"}},{"ruleId":"D10","level":"note","message":{"text":"No direct assertions: testGetContactById: No conventional assertion call was detected, and 10 of 17 tests in \u0060ntorga/clean-ddd-php-poc-contacts\u0060 read the same way \u2014 so this is treated as that project\u0027s convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tests/Infrastructure/ContactQueryRepositoryTest.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"2257bbb4990dca490ebb3f4bca1d3a61c33dc6c6a9b5de2b236b548fe0649f5b"}},{"ruleId":"D12","level":"warning","message":{"text":"Abandoned package: doctrine/annotations: \u0060doctrine/annotations\u0060 is marked ABANDONED on Packagist, and this repository requires it at \u0060^2.0\u0060 (locked at 2.0.1). An abandoned package receives no further releases \u2014 including security releases. Its maintainer named no replacement, so the migration target is yours to choose. This is a migration, not an upgrade: a newer release of an abandoned package is not a fix."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"100f2d95eb4cdb692f1ee28e94ee42eeca2c81422ae85ed146ec55acec822990"}},{"ruleId":"D15","level":"warning","message":{"text":"Repeated repair: src/Presentation/Api/Controller/UpdateContact.php: src/Presentation/Api/Controller/UpdateContact.php changed 7 times in last 90 days and 5 of those changes were fix/bug commits, so repair is the majority of this file\u0027s churn. Its max cyclomatic complexity is 6 (its worst body is UpdateContact.action at line 48), UNDER the 15 threshold, so this is deliberately not filed as a churn \u00D7 complexity hotspot \u2014 the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: \u201Cfix: remove id from put endpoint\u201D; \u201Cfix: swagger request body reference error\u201D; \u201Cfix: move swagger routes annotations to controllers\u201D; \u201Cfix: move contact id to the top of the try block\u201D. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2023-10-04..2024-01-02, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272023-10-04 20:42:07 -03:00\u0027 --until=\u00272024-01-02 20:42:07 -03:00\u0027 --full-history --no-merges -- src/Presentation/Api/Controller/UpdateContact.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Presentation/Api/Controller/UpdateContact.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a4fcc16c92fe7b386a6bd5bb7f587db5984a1502badfc3384d1d4a616d68689"}},{"ruleId":"D15","level":"warning","message":{"text":"Repeated repair: src/Presentation/Api/Controller/AddContact.php: src/Presentation/Api/Controller/AddContact.php changed 6 times in last 90 days and 5 of those changes were fix/bug commits, so repair is the majority of this file\u0027s churn. Its max cyclomatic complexity is 3 (its worst body is AddContact.action at line 47), UNDER the 15 threshold, so this is deliberately not filed as a churn \u00D7 complexity hotspot \u2014 the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: \u201Cfix: swagger request body reference error\u201D; \u201Cfix: move swagger routes annotations to controllers\u201D; \u201Cfix: use new use case and adjust return msgs\u201D; \u201Cfix: start add contact dto creation\u201D. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2023-10-04..2024-01-02, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272023-10-04 20:42:07 -03:00\u0027 --until=\u00272024-01-02 20:42:07 -03:00\u0027 --full-history --no-merges -- src/Presentation/Api/Controller/AddContact.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Presentation/Api/Controller/AddContact.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"a9dfe26b75c44d032e3d97b44fcacc337abe7bc5e7d76963b07bec687aee95c5"}},{"ruleId":"D15","level":"warning","message":{"text":"Repeated repair: src/Presentation/Api/Controller/RemoveContact.php: src/Presentation/Api/Controller/RemoveContact.php changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file\u0027s churn. Its max cyclomatic complexity is 4 (its worst body is RemoveContact.action at line 48), UNDER the 15 threshold, so this is deliberately not filed as a churn \u00D7 complexity hotspot \u2014 the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: \u201Cfix: move swagger routes annotations to controllers\u201D; \u201Cfix: simplify return and status code\u201D; \u201Cfix: remove controller suffix\u201D. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2023-10-04..2024-01-02, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272023-10-04 20:42:07 -03:00\u0027 --until=\u00272024-01-02 20:42:07 -03:00\u0027 --full-history --no-merges -- src/Presentation/Api/Controller/RemoveContact.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Presentation/Api/Controller/RemoveContact.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"54a04d33577701a972c992916e7f6b3e71cf459d920dadf8f6d665d2d426f84e"}},{"ruleId":"D15","level":"warning","message":{"text":"Repeated repair: src/Infrastructure/ContactCommandRepository.php: src/Infrastructure/ContactCommandRepository.php changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file\u0027s churn. Its max cyclomatic complexity is 5 (its worst body is ContactCommandRepository.update at line 60), UNDER the 15 threshold, so this is deliberately not filed as a churn \u00D7 complexity hotspot \u2014 the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: \u201Crefactor: adjust flysys adapter and fix add impl\u201D; \u201Cfix: adjust add to use dto\u201D; \u201Cfix: adapt infra to respect new interface\u201D. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2023-10-04..2024-01-02, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272023-10-04 20:42:07 -03:00\u0027 --until=\u00272024-01-02 20:42:07 -03:00\u0027 --full-history --no-merges -- src/Infrastructure/ContactCommandRepository.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Infrastructure/ContactCommandRepository.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"3e1512bc9538e2ae5cb20168b11bf5ecf5dac1c32fc48a3cb69e067b253ae1d2"}},{"ruleId":"D15","level":"warning","message":{"text":"Repeated repair: src/Presentation/Api/Controller/GetContact.php: src/Presentation/Api/Controller/GetContact.php changed 3 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file\u0027s churn. Its max cyclomatic complexity is 3 (its worst body is GetContact.action at line 48), UNDER the 15 threshold, so this is deliberately not filed as a churn \u00D7 complexity hotspot \u2014 the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: \u201Cfix: move swagger routes annotations to controllers\u201D; \u201Cfix: improve vars names and encode entity separately\u201D; \u201Cfix: remove controller suffix\u201D. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2023-10-04..2024-01-02, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272023-10-04 20:42:07 -03:00\u0027 --until=\u00272024-01-02 20:42:07 -03:00\u0027 --full-history --no-merges -- src/Presentation/Api/Controller/GetContact.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Presentation/Api/Controller/GetContact.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"61f02506d1eab77f975a2b94157be4a919cc8ef091ef18c65478277ef69ef54b"}},{"ruleId":"D15","level":"warning","message":{"text":"Repeated repair: src/Presentation/Api/Controller/GetContacts.php: src/Presentation/Api/Controller/GetContacts.php changed 3 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file\u0027s churn. Its max cyclomatic complexity is 2 (its worst body is GetContacts.action at line 36), UNDER the 15 threshold, so this is deliberately not filed as a churn \u00D7 complexity hotspot \u2014 the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: \u201Cfix: move swagger routes annotations to controllers\u201D; \u201Cfix: separate json encode from contacts list\u201D; \u201Cfix: remove controller suffix\u201D. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2023-10-04..2024-01-02, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272023-10-04 20:42:07 -03:00\u0027 --until=\u00272024-01-02 20:42:07 -03:00\u0027 --full-history --no-merges -- src/Presentation/Api/Controller/GetContacts.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Presentation/Api/Controller/GetContacts.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad196dfd8650751973ff301c93ae6279f740aa16d5cc135730eb2bd630eb950c"}},{"ruleId":"D19","level":"note","message":{"text":"Documentation: no usage examples: The README does not include any usage examples, so a reader cannot see how to call the API endpoints. Add a short \u0027How to run it\u0027 section showing curl or HTTP request samples for each endpoint."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"README.md"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"1355eb4e127a4bc9236772ce1c46f09510aa9286e7a06d1e47f308229df19049"}},{"ruleId":"D30","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"2a21de9955647fb0613808181e5012345666ae8621b2fd0d4b8660d47a5c4134"}},{"ruleId":"D30","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"ca2343b8a7dc665cded5c73d3a885a28f41104126f55521a8e7543352a17ed88"}},{"ruleId":"D30","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"50423fc9b275ec3ebdc1b93612f3495818df571f2b4d1e28094c445649fbb4af"}},{"ruleId":"D31","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"7a8649f4259dcf3e9c4efadc6d06cf551d71a89463b53b8fe84060798d80d317"}},{"ruleId":"D31","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"d659c6e92a7152c126c6f4f0fc9ba5fe47371839fd50fc47de98d04bb26be48f"}},{"ruleId":"D31","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"fc8e3260a6c033ace48052bc5585a8cc2936d0b5587266777a503e1a6fae5cac"},"taxa":[{"id":"CWE-1357","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-353","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D31","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"7605b10afee3cb1b621b124b62fd554667217bfa44701244ab081547826b5031"},"taxa":[{"id":"CWE-527","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-538","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D34","level":"note","message":{"text":"Orphaned files with no living knowledge: 4 of 4 analysed file(s) have no living knowledge left \u2014 their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 4 of the 26 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each \u2014 most significant first: src/Presentation/Api/Routes.php, src/Infrastructure/ContactQueryRepository.php, src/Infrastructure/ContactCommandRepository.php, src/Presentation/Api/Controller/UpdateContact.php. Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"ce861fd78f6935114d3a342cb90ad25870f984e1042954fcbbe27c0e23be3658"}},{"ruleId":"M2","level":"note","message":{"text":"No ADRs: No Architecture Decision Records found \u2014 no conventional ADR directory, no numbered \u0060NNNN-title\u0060 documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"670b3d6e36a756d63097d0dfbf90afd5fc761308800b9354894a07c3f4e4aa14"}},{"ruleId":"M4","level":"note","message":{"text":"README/code drift: README claims the project is a \u0027proof of concept\u0027 API but there are no source files or directories showing any API endpoint \u2014 searched for: \u0060API endpoints\u0060. Each was matched case- and separator-insensitively against file and directory NAMES anywhere in the tree, and against the CONTENTS of manifest files (package.json, *.csproj, *.props, *.slnx, *.yml, Dockerfile); the README\u0027s own prose never counts, so a claim is never refuted by merely being made. Nothing outside that search was read \u2014 a footprint living only in a submodule, in a file type not listed here, or under a name none of those terms matches is not seen, and this row is then wrong."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"52bcef477b53600ae42663b5b2fc1344869be4bfee6a3d20e95adeb48f614be8"}},{"ruleId":"M4","level":"note","message":{"text":"README/code drift: README claims the container runs on Podman/Docker but the evidence shows neither Docker nor Podman commands exist in the repo \u2014 searched for: \u0060Docker\u0060, \u0060Podman\u0060. Each was matched case- and separator-insensitively against file and directory NAMES anywhere in the tree, and against the CONTENTS of manifest files (package.json, *.csproj, *.props, *.slnx, *.yml, Dockerfile); the README\u0027s own prose never counts, so a claim is never refuted by merely being made. Nothing outside that search was read \u2014 a footprint living only in a submodule, in a file type not listed here, or under a name none of those terms matches is not seen, and this row is then wrong."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"21b4df40967a8db513928fd6d17a30393a24326696a4cff4778d186bad313c06"}},{"ruleId":"M4","level":"note","message":{"text":"README/code drift: README advertises Docker containerisation, but no Dockerfile/compose file exists \u2014 searched for: \u0060dockerfile\u0060, \u0060docker-compose\u0060, \u0060compose.yaml\u0060, \u0060compose.yml\u0060. Each was matched case- and separator-insensitively against file and directory NAMES anywhere in the tree, and against the CONTENTS of manifest files (package.json, *.csproj, *.props, *.slnx, *.yml, Dockerfile); the README\u0027s own prose never counts, so a claim is never refuted by merely being made. Nothing outside that search was read \u2014 a footprint living only in a submodule, in a file type not listed here, or under a name none of those terms matches is not seen, and this row is then wrong."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"d116e696b89ee5b5606de54018788ae795afe8387ffcf59a3c5f5c024f4aec80"}},{"ruleId":"M4","level":"note","message":{"text":"README/code drift: README advertises a RAG / ML engine, but no ML/RAG code or dependency exists \u2014 searched for: \u0060rag\u0060, \u0060langchain\u0060, \u0060llamaindex\u0060, \u0060pinecone\u0060, \u0060weaviate\u0060, \u0060qdrant\u0060, \u0060embeddings\u0060. Each was matched case- and separator-insensitively against file and directory NAMES anywhere in the tree, and against the CONTENTS of manifest files (package.json, *.csproj, *.props, *.slnx, *.yml, Dockerfile); the README\u0027s own prose never counts, so a claim is never refuted by merely being made. Nothing outside that search was read \u2014 a footprint living only in a submodule, in a file type not listed here, or under a name none of those terms matches is not seen, and this row is then wrong."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"641c12de6a27c56ae4f356e613243d119d1728768480ea36e3ea12271e12b02c"}},{"ruleId":"P1","level":"warning","message":{"text":"No CI pipeline: No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, \u2026) \u2014 changes aren\u0027t gated by an automated build/test."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"44f01af96e50474fba2df84d95ddf4f7e1d34c29c307830b9efc9057daa6b670"}}],"taxonomies":[{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d","organization":"MITRE","informationUri":"https://cwe.mitre.org/","isComprehensive":false,"shortDescription":{"text":"The MITRE Common Weakness Enumeration (CWE)."},"taxa":[{"id":"CWE-1032","guid":"5f21e517-68aa-a650-9a25-5771ef024637","name":"OWASP Top Ten \u2014 Security Misconfiguration category","shortDescription":{"text":"OWASP Top Ten \u2014 Security Misconfiguration category"},"helpUri":"https://cwe.mitre.org/data/definitions/1032.html"},{"id":"CWE-1357","guid":"e4d2e772-757e-0a5c-bd7d-77052949d866","name":"Reliance on Insufficiently Trustworthy Component","shortDescription":{"text":"Reliance on Insufficiently Trustworthy Component"},"helpUri":"https://cwe.mitre.org/data/definitions/1357.html"},{"id":"CWE-1395","guid":"800e09e7-c11a-8654-9fa6-86f398995fed","name":"Dependency on Vulnerable Third-Party Component","shortDescription":{"text":"Dependency on Vulnerable Third-Party Component"},"helpUri":"https://cwe.mitre.org/data/definitions/1395.html"},{"id":"CWE-16","guid":"659db3ea-affc-8453-8add-c1218fbfcb92","name":"Configuration","shortDescription":{"text":"Configuration"},"helpUri":"https://cwe.mitre.org/data/definitions/16.html"},{"id":"CWE-259","guid":"ae9ad959-fbb6-9d5e-892d-3dca66da0b69","name":"Use of Hard-coded Password","shortDescription":{"text":"Use of Hard-coded Password"},"helpUri":"https://cwe.mitre.org/data/definitions/259.html"},{"id":"CWE-353","guid":"09d7e902-d4ee-f05d-ae6c-0a1554d0c18f","name":"CWE-353","shortDescription":{"text":"CWE-353"},"helpUri":"https://cwe.mitre.org/data/definitions/353.html"},{"id":"CWE-506","guid":"401d6455-56e3-0552-9a39-f77461673e3f","name":"CWE-506","shortDescription":{"text":"CWE-506"},"helpUri":"https://cwe.mitre.org/data/definitions/506.html"},{"id":"CWE-527","guid":"79b27cde-9d04-1a54-b64b-d5bb9b4a8ee7","name":"CWE-527","shortDescription":{"text":"CWE-527"},"helpUri":"https://cwe.mitre.org/data/definitions/527.html"},{"id":"CWE-538","guid":"3baa1f05-df1b-ae58-9ee0-1d790ff4a989","name":"CWE-538","shortDescription":{"text":"CWE-538"},"helpUri":"https://cwe.mitre.org/data/definitions/538.html"},{"id":"CWE-732","guid":"1da27e8f-b330-7650-ab63-bd61953eae5d","name":"Incorrect Permission Assignment for Critical Resource","shortDescription":{"text":"Incorrect Permission Assignment for Critical Resource"},"helpUri":"https://cwe.mitre.org/data/definitions/732.html"},{"id":"CWE-77","guid":"332c8ade-6612-9f56-a06b-d8d90b1a8750","name":"Command Injection","shortDescription":{"text":"Command Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/77.html"},{"id":"CWE-78","guid":"2e31ceaf-c7ae-2e5e-9661-cfb1362789cf","name":"OS Command Injection","shortDescription":{"text":"OS Command Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/78.html"},{"id":"CWE-79","guid":"fd45580b-e8c4-fc5e-8c2f-aa8fab0b4dbf","name":"Cross-site Scripting (XSS)","shortDescription":{"text":"Cross-site Scripting (XSS)"},"helpUri":"https://cwe.mitre.org/data/definitions/79.html"},{"id":"CWE-798","guid":"5e8f057d-fee3-995a-a0cb-9fc5b0d174d1","name":"Use of Hard-coded Credentials","shortDescription":{"text":"Use of Hard-coded Credentials"},"helpUri":"https://cwe.mitre.org/data/definitions/798.html"},{"id":"CWE-89","guid":"6d08fdad-37eb-c150-bbf0-d7d946863407","name":"SQL Injection","shortDescription":{"text":"SQL Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/89.html"},{"id":"CWE-937","guid":"16f316ae-415c-b354-a59b-1f7905f756e9","name":"Using Components with Known Vulnerabilities","shortDescription":{"text":"Using Components with Known Vulnerabilities"},"helpUri":"https://cwe.mitre.org/data/definitions/937.html"},{"id":"CWE-94","guid":"75e7f50c-6c2f-dd52-bf40-bf6c52b861fd","name":"Code Injection","shortDescription":{"text":"Code Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/94.html"}]}],"properties":{"codehealthPublication":{"public":true,"notice":"This is the PUBLIC form of this artifact. Findings are listed in full, but the details of SECURITY findings \u2014 which rule fired, in which file, on which line, and how to fix it \u2014 are deliberately withheld, and any secret-scanner results are excluded entirely. Where detail is absent here it was REMOVED FOR PUBLICATION; it is not missing from the analysis. The complete artifact is available from the repository owner.","securityFindingsRedacted":7,"secretScannerRunsExcluded":0}},"redactionTokens":["A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."]}]}