{"$schema":"https://json.schemastore.org/sarif-2.1.0.json","version":"2.1.0","runs":[{"tool":{"driver":{"name":"codehealth","informationUri":"https://codehealth.canine.dev","rules":[{"id":"D1","name":"Cyclomatic Complexity","shortDescription":{"text":"Cyclomatic Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D1"},{"id":"D2","name":"Cognitive Complexity","shortDescription":{"text":"Cognitive Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D2"},{"id":"D3","name":"God Classes","shortDescription":{"text":"God Classes"},"helpUri":"https://codehealth.canine.dev/dimensions/D3"},{"id":"D4","name":"Code Duplication","shortDescription":{"text":"Code Duplication"},"helpUri":"https://codehealth.canine.dev/dimensions/D4"},{"id":"D6","name":"Cohesion (LCOM4)","shortDescription":{"text":"Cohesion (LCOM4)"},"helpUri":"https://codehealth.canine.dev/dimensions/D6"},{"id":"D13","name":"Secret Scanning","shortDescription":{"text":"Secret Scanning"},"helpUri":"https://codehealth.canine.dev/dimensions/D13","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"],"owasp":"A07:2025"}},{"id":"D15","name":"Churn \u00D7 Complexity Hotspots","shortDescription":{"text":"Churn \u00D7 Complexity Hotspots"},"helpUri":"https://codehealth.canine.dev/dimensions/D15"},{"id":"D16","name":"Bus Factor","shortDescription":{"text":"Bus Factor"},"helpUri":"https://codehealth.canine.dev/dimensions/D16"},{"id":"D17","name":"Explicit Debt","shortDescription":{"text":"Explicit Debt"},"helpUri":"https://codehealth.canine.dev/dimensions/D17"},{"id":"D21","name":"Naming Consistency","shortDescription":{"text":"Naming Consistency"},"helpUri":"https://codehealth.canine.dev/dimensions/D21"},{"id":"D27","name":"Navigability","shortDescription":{"text":"Navigability"},"helpUri":"https://codehealth.canine.dev/dimensions/D27"},{"id":"D28","name":"Secrets (history)","shortDescription":{"text":"Secrets (history)"},"helpUri":"https://codehealth.canine.dev/dimensions/D28","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"],"owasp":"A07:2025"}},{"id":"D29","name":"Static Analysis (SAST)","shortDescription":{"text":"Static Analysis (SAST)"},"helpUri":"https://codehealth.canine.dev/dimensions/D29","relationships":[{"target":{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-89","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-94","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-77","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-79","CWE-89","CWE-78","CWE-94","CWE-77"],"owasp":"A05:2025"}},{"id":"D34","name":"Knowledge Freshness","shortDescription":{"text":"Knowledge Freshness"},"helpUri":"https://codehealth.canine.dev/dimensions/D34"},{"id":"D35","name":"Change Coupling","shortDescription":{"text":"Change Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D35"},{"id":"D37","name":"Vulnerability-disclosure Policy","shortDescription":{"text":"Vulnerability-disclosure Policy"},"helpUri":"https://codehealth.canine.dev/dimensions/D37","relationships":[{"target":{"id":"CWE-1059","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"A02:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-1059"],"owasp":"A02:2025"}},{"id":"AC1","name":"Text alternatives","shortDescription":{"text":"Text alternatives"},"helpUri":"https://codehealth.canine.dev/dimensions/AC1"},{"id":"AC2","name":"Forms \u0026 labels","shortDescription":{"text":"Forms \u0026 labels"},"helpUri":"https://codehealth.canine.dev/dimensions/AC2"},{"id":"AC3","name":"Page structure","shortDescription":{"text":"Page structure"},"helpUri":"https://codehealth.canine.dev/dimensions/AC3"},{"id":"AC4","name":"Keyboard semantics","shortDescription":{"text":"Keyboard semantics"},"helpUri":"https://codehealth.canine.dev/dimensions/AC4"},{"id":"AC5","name":"ARIA correctness","shortDescription":{"text":"ARIA correctness"},"helpUri":"https://codehealth.canine.dev/dimensions/AC5"},{"id":"AC6","name":"Visual \u0026 motion safety","shortDescription":{"text":"Visual \u0026 motion safety"},"helpUri":"https://codehealth.canine.dev/dimensions/AC6"},{"id":"AC7","name":"A11y enforcement","shortDescription":{"text":"A11y enforcement"},"helpUri":"https://codehealth.canine.dev/dimensions/AC7"},{"id":"AX10","name":"Code composition","shortDescription":{"text":"Code composition"},"helpUri":"https://codehealth.canine.dev/dimensions/AX10"},{"id":"AXB2","name":"Runtime readiness","shortDescription":{"text":"Runtime readiness"},"helpUri":"https://codehealth.canine.dev/dimensions/AXB2"},{"id":"ED5","name":"Idempotency","shortDescription":{"text":"Idempotency"},"helpUri":"https://codehealth.canine.dev/dimensions/ED5"},{"id":"M1","name":"Documentation (README)","shortDescription":{"text":"Documentation (README)"},"helpUri":"https://codehealth.canine.dev/dimensions/M1"},{"id":"M2","name":"Architecture documentation","shortDescription":{"text":"Architecture documentation"},"helpUri":"https://codehealth.canine.dev/dimensions/M2"},{"id":"M3","name":"Folder \u0026 project structure","shortDescription":{"text":"Folder \u0026 project structure"},"helpUri":"https://codehealth.canine.dev/dimensions/M3"},{"id":"M4","name":"Documentation accuracy","shortDescription":{"text":"Documentation accuracy"},"helpUri":"https://codehealth.canine.dev/dimensions/M4"},{"id":"P1","name":"CI/CD gates","shortDescription":{"text":"CI/CD gates"},"helpUri":"https://codehealth.canine.dev/dimensions/P1"},{"id":"P2","name":"Observability","shortDescription":{"text":"Observability"},"helpUri":"https://codehealth.canine.dev/dimensions/P2"},{"id":"P3","name":"Security \u0026 performance tooling","shortDescription":{"text":"Security \u0026 performance tooling"},"helpUri":"https://codehealth.canine.dev/dimensions/P3"},{"id":"P6","name":"Release Hygiene","shortDescription":{"text":"Release Hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/P6"},{"id":"P7","name":"Outbound HTTP resilience","shortDescription":{"text":"Outbound HTTP resilience"},"helpUri":"https://codehealth.canine.dev/dimensions/P7"},{"id":"PF3","name":"Async \u0026 latency hygiene","shortDescription":{"text":"Async \u0026 latency hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/PF3"},{"id":"R1","name":"Type Safety","shortDescription":{"text":"Type Safety"},"helpUri":"https://codehealth.canine.dev/dimensions/R1"},{"id":"R10","name":"Code Duplication","shortDescription":{"text":"Code Duplication"},"helpUri":"https://codehealth.canine.dev/dimensions/R10"},{"id":"R2","name":"Cyclomatic Complexity","shortDescription":{"text":"Cyclomatic Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/R2"},{"id":"R3","name":"Large Files","shortDescription":{"text":"Large Files"},"helpUri":"https://codehealth.canine.dev/dimensions/R3"},{"id":"R4","name":"Test Coverage","shortDescription":{"text":"Test Coverage"},"helpUri":"https://codehealth.canine.dev/dimensions/R4"},{"id":"R7","name":"Dead Code","shortDescription":{"text":"Dead Code"},"helpUri":"https://codehealth.canine.dev/dimensions/R7"},{"id":"R9","name":"Circular Imports","shortDescription":{"text":"Circular Imports"},"helpUri":"https://codehealth.canine.dev/dimensions/R9"},{"id":"X1","name":"Async correctness","shortDescription":{"text":"Async correctness"},"helpUri":"https://codehealth.canine.dev/dimensions/X1"},{"id":"X10","name":"Duplicated predicate","shortDescription":{"text":"Duplicated predicate"},"helpUri":"https://codehealth.canine.dev/dimensions/X10"},{"id":"X12","name":"Unreachable branch","shortDescription":{"text":"Unreachable branch"},"helpUri":"https://codehealth.canine.dev/dimensions/X12"},{"id":"X13","name":"Undrained process stream","shortDescription":{"text":"Undrained process stream"},"helpUri":"https://codehealth.canine.dev/dimensions/X13"},{"id":"X14","name":"Bypassable address classification","shortDescription":{"text":"Bypassable address classification"},"helpUri":"https://codehealth.canine.dev/dimensions/X14"},{"id":"X15","name":"Unvalidated length from an untrusted reader","shortDescription":{"text":"Unvalidated length from an untrusted reader"},"helpUri":"https://codehealth.canine.dev/dimensions/X15"},{"id":"X16","name":"Unfloored truncation loop","shortDescription":{"text":"Unfloored truncation loop"},"helpUri":"https://codehealth.canine.dev/dimensions/X16"},{"id":"X17","name":"Uncapped recursion over a caller-supplied document","shortDescription":{"text":"Uncapped recursion over a caller-supplied document"},"helpUri":"https://codehealth.canine.dev/dimensions/X17"},{"id":"X18","name":"Disposal-pattern correctness","shortDescription":{"text":"Disposal-pattern correctness"},"helpUri":"https://codehealth.canine.dev/dimensions/X18"},{"id":"X19","name":"Unrestored process-global state","shortDescription":{"text":"Unrestored process-global state"},"helpUri":"https://codehealth.canine.dev/dimensions/X19"},{"id":"X2","name":"Cancellation propagation","shortDescription":{"text":"Cancellation propagation"},"helpUri":"https://codehealth.canine.dev/dimensions/X2"},{"id":"X20","name":"Mistyped argument guard","shortDescription":{"text":"Mistyped argument guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X20"},{"id":"X21","name":"Side-effecting pattern guard","shortDescription":{"text":"Side-effecting pattern guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X21"},{"id":"X22","name":"Contradicted release guard","shortDescription":{"text":"Contradicted release guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X22"},{"id":"X23","name":"Unguarded diagnostic materialisation","shortDescription":{"text":"Unguarded diagnostic materialisation"},"helpUri":"https://codehealth.canine.dev/dimensions/X23"},{"id":"X24","name":"Document value interpolated into markup unescaped","shortDescription":{"text":"Document value interpolated into markup unescaped"},"helpUri":"https://codehealth.canine.dev/dimensions/X24"},{"id":"X25","name":"Inert configuration knob","shortDescription":{"text":"Inert configuration knob"},"helpUri":"https://codehealth.canine.dev/dimensions/X25"},{"id":"X26","name":"Unsynchronised callback handoff","shortDescription":{"text":"Unsynchronised callback handoff"},"helpUri":"https://codehealth.canine.dev/dimensions/X26"},{"id":"X27","name":"Collection changed while being enumerated","shortDescription":{"text":"Collection changed while being enumerated"},"helpUri":"https://codehealth.canine.dev/dimensions/X27"},{"id":"X28","name":"Index access outside its own emptiness guard","shortDescription":{"text":"Index access outside its own emptiness guard"},"helpUri":"https://codehealth.canine.dev/dimensions/X28"},{"id":"X29","name":"Per-element action decided by a fixed element","shortDescription":{"text":"Per-element action decided by a fixed element"},"helpUri":"https://codehealth.canine.dev/dimensions/X29"},{"id":"X3","name":"Exception handling","shortDescription":{"text":"Exception handling"},"helpUri":"https://codehealth.canine.dev/dimensions/X3"},{"id":"X30","name":"Support guard that admits what it rejects","shortDescription":{"text":"Support guard that admits what it rejects"},"helpUri":"https://codehealth.canine.dev/dimensions/X30"},{"id":"X32","name":"Type resolved by simple name across every loaded assembly","shortDescription":{"text":"Type resolved by simple name across every loaded assembly"},"helpUri":"https://codehealth.canine.dev/dimensions/X32"},{"id":"X4","name":"Structured logging","shortDescription":{"text":"Structured logging"},"helpUri":"https://codehealth.canine.dev/dimensions/X4"},{"id":"X5","name":"Nullable reference types","shortDescription":{"text":"Nullable reference types"},"helpUri":"https://codehealth.canine.dev/dimensions/X5"},{"id":"X6","name":"Hand-rolled structured-format parsing","shortDescription":{"text":"Hand-rolled structured-format parsing"},"helpUri":"https://codehealth.canine.dev/dimensions/X6"},{"id":"X7","name":"Silent fallback defaults","shortDescription":{"text":"Silent fallback defaults"},"helpUri":"https://codehealth.canine.dev/dimensions/X7"},{"id":"X9","name":"Subsumed condition operand","shortDescription":{"text":"Subsumed condition operand"},"helpUri":"https://codehealth.canine.dev/dimensions/X9"}]}},"results":[{"ruleId":"D1","level":"warning","message":{"text":"Filter.performValidation (cyclomatic 117): Filter.performValidation has cyclomatic complexity 117 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"58974a52247d6e5f97c09060568b57d9aa077ff430ac7397b082b964f323083a"}},{"ruleId":"D1","level":"warning","message":{"text":"Dnsmasq.performValidation (cyclomatic 103): Dnsmasq.performValidation has cyclomatic complexity 103 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"14b1c7777c242fa05d31172d0a7ca8493360a60384d7a3d5ffbdf684e5a520ac"}},{"ruleId":"D1","level":"warning","message":{"text":"OpenVPN.generateInstanceConfig (cyclomatic 89): OpenVPN.generateInstanceConfig has cyclomatic complexity 89 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php"},"region":{"startLine":551}}}],"partialFingerprints":{"codehealthFindingId/v1":"a42b74914f2ba2564163d610e66705a2f70fbac20dd62f87272abed140b656e4"}},{"ruleId":"D1","level":"warning","message":{"text":"FilterRule.parseFilterRules (cyclomatic 71): FilterRule.parseFilterRules has cyclomatic complexity 71 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php"},"region":{"startLine":203}}}],"partialFingerprints":{"codehealthFindingId/v1":"d86a26a1b381f2af2cf16429a9793c7b202b303f05b73ce491fee5f7337d0b24"}},{"ruleId":"D1","level":"warning","message":{"text":"translateCompatOptions (cyclomatic 69): translateCompatOptions has cyclomatic complexity 69 (threshold 15). Of this number, 68 points are the body\u0027s own statements and 1 belongs to 7 function items inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":244}}}],"partialFingerprints":{"codehealthFindingId/v1":"f0563d6f0813694ca51a5f5b05701404b5a97ff2aa16b63e82855e7a1a79fffc"}},{"ruleId":"D1","level":"warning","message":{"text":"KeaDhcpv6.performValidation (cyclomatic 66): KeaDhcpv6.performValidation has cyclomatic complexity 66 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"f201f37fa836372919fd00373973daa23460b3fbd52f1d2487fc7aa2cef8fe5c"}},{"ruleId":"D1","level":"warning","message":{"text":"keydown (cyclomatic 66): keydown has cyclomatic complexity 66 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":2827}}}],"partialFingerprints":{"codehealthFindingId/v1":"6673178895f2429549ce1a0d5aebe04bba853239ae1c79fa4ddd75b3d488a27e"}},{"ruleId":"D1","level":"warning","message":{"text":"smoothie.SmoothieChart.render (cyclomatic 63): smoothie.SmoothieChart.render has cyclomatic complexity 63 (threshold 15). Of this number, 61 points are the body\u0027s own statements and 2 belong to 2 function items inside it that branch. This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/smoothie.js"},"region":{"startLine":839}}}],"partialFingerprints":{"codehealthFindingId/v1":"37c5ffc72005ae97b96fa7541b5c6ab9071781422f222bb0edea2da6b13345cb"}},{"ruleId":"D1","level":"warning","message":{"text":"clickListener (cyclomatic 63): clickListener has cyclomatic complexity 63 (threshold 15). Most of this is not in the body itself: 1 of the 63 points is its own statement and the rest belongs to 19 function items inside it that branch (a function literal at line 2454, checkPopperExists, a function literal at line 2578, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":2390}}}],"partialFingerprints":{"codehealthFindingId/v1":"b958c06762b8985e569571314f45b4c12fa94fbf17d0c8e621dcb16eabb7c5a7"}},{"ruleId":"D1","level":"warning","message":{"text":"FirmwareController.statusAction (cyclomatic 61): FirmwareController.statusAction has cyclomatic complexity 61 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"a9e49616e8487b81448c7741a53acb66a8da77d892fab5d1208640e073de485f"}},{"ruleId":"D1","level":"warning","message":{"text":"OpenVPN.performValidation (cyclomatic 56): OpenVPN.performValidation has cyclomatic complexity 56 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"3aaf8a4f901b23ee1756d7857fcaa434052826f0a31fc82872f770b85b176ae3"}},{"ruleId":"D1","level":"warning","message":{"text":"createView::scroll (cyclomatic 55): createView::scroll has cyclomatic complexity 55 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1227}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0e0b9f105615d0b7475d75e7697bdf3c2614703999fa5988feb76527f927190"}},{"ruleId":"D1","level":"warning","message":{"text":"states.query_states (cyclomatic 47): states.query_states has cyclomatic complexity 47 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/states.py"},"region":{"startLine":110}}}],"partialFingerprints":{"codehealthFindingId/v1":"297a4e65910b291dc4494e05ee9c855cd28ca6fa66cdfed2c1f622f6ff0b7132"}},{"ruleId":"D1","level":"warning","message":{"text":"Monit.performValidation (cyclomatic 45): Monit.performValidation has cyclomatic complexity 45 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Monit/Monit.php"},"region":{"startLine":153}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf3f1a3525c23e4d896ee2eb64968d2abb6b2117f618b321800d5ba4cd3339fc"}},{"ruleId":"D1","level":"warning","message":{"text":"CrlController.setAction (cyclomatic 44): CrlController.setAction has cyclomatic complexity 44 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CrlController.php"},"region":{"startLine":180}}}],"partialFingerprints":{"codehealthFindingId/v1":"a084980c11ea1a825ce680e85547bd5b49c25991a1a5759f18c30447eed6dc34"}},{"ruleId":"D1","level":"warning","message":{"text":"FirmwareController.infoAction (cyclomatic 43): FirmwareController.infoAction has cyclomatic complexity 43 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php"},"region":{"startLine":801}}}],"partialFingerprints":{"codehealthFindingId/v1":"8fbf2525b6cabf9440e2a8ac9a1ef7eb9745eb69c0b02824f50ca889d3e8f343"}},{"ruleId":"D1","level":"warning","message":{"text":"Swanctl.performValidation (cyclomatic 43): Swanctl.performValidation has cyclomatic complexity 43 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/Swanctl.php"},"region":{"startLine":66}}}],"partialFingerprints":{"codehealthFindingId/v1":"b998f309ec14474e4c3be67e49ca0c8002438a9702599515b284e524b935c448"}},{"ruleId":"D1","level":"warning","message":{"text":"Vip.performValidation (cyclomatic 43): Vip.performValidation has cyclomatic complexity 43 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Vip.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"9097028cbb52dd4212697a9640fb80b278b9aaa8e8eb3444753884fd30c1211a"}},{"ruleId":"D1","level":"warning","message":{"text":"liHeight (cyclomatic 43): liHeight has cyclomatic complexity 43 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1878}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e888707b60b36da26ca7900636e53ef1e042364cd0c0237e6916f511e70f576"}},{"ruleId":"D1","level":"warning","message":{"text":"Radius.authenticate (cyclomatic 42): Radius.authenticate has cyclomatic complexity 42 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php"},"region":{"startLine":512}}}],"partialFingerprints":{"codehealthFindingId/v1":"a44e8b18f2440c48dad3ddc7693880db666bd4290b7686c38d20171def9c030e"}},{"ruleId":"D1","level":"warning","message":{"text":"qrcode::QRUtil::getLostPoint (cyclomatic 42): qrcode::QRUtil::getLostPoint has cyclomatic complexity 42 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":1020}}}],"partialFingerprints":{"codehealthFindingId/v1":"fabb51ff82fb01d8498b1f8ee89fb7ecbf4652cc266f4b0c1962da152cd1d46f"}},{"ruleId":"D1","level":"warning","message":{"text":"setaddr.console_configure_ip_address (cyclomatic 40): setaddr.console_configure_ip_address has cyclomatic complexity 40 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/shell/setaddr.php"},"region":{"startLine":294}}}],"partialFingerprints":{"codehealthFindingId/v1":"afad15ec756830d430c6f6eefc61a5155067cdd229a1e717a5a8b7a2d2dfac03"}},{"ruleId":"D1","level":"warning","message":{"text":"_registerEvents (cyclomatic 40): _registerEvents has cyclomatic complexity 40 (threshold 15). Most of this is not in the body itself: 2 of the 40 points are its own statements and the rest belongs to 33 function items inside it that branch (title, onMouseEnter, (anonymous)::findTreeRowByIndex::walk, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":720}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6e1157e5ccc75aab96eeac41190e8fbf1933b9882b6b38032c3cc7d3ff68484"}},{"ruleId":"D1","level":"warning","message":{"text":"NetworkInterface.performValidation (cyclomatic 39): NetworkInterface.performValidation has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php"},"region":{"startLine":200}}}],"partialFingerprints":{"codehealthFindingId/v1":"f9e99cbb39962df59fb9d952b82cb1004ae6b9d6cd473f9728f24900f3965cef"}},{"ruleId":"D1","level":"warning","message":{"text":"KeaDhcpv6.getConfigSubnets (cyclomatic 39): KeaDhcpv6.getConfigSubnets has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php"},"region":{"startLine":328}}}],"partialFingerprints":{"codehealthFindingId/v1":"705f25728d872ea74b3b9e511bbbe5527e109f5fed36a0f40a7e439432f61485"}},{"ruleId":"D1","level":"warning","message":{"text":"certctl.cmd_rehash (cyclomatic 39): certctl.cmd_rehash has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/system/certctl.py"},"region":{"startLine":120}}}],"partialFingerprints":{"codehealthFindingId/v1":"df6f7364b64222887b7879ecacafa7eb1ce60565e47a63f3d6b209649fdc5330"}},{"ruleId":"D1","level":"warning","message":{"text":"OverviewController.parseIfInfo (cyclomatic 38): OverviewController.parseIfInfo has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/OverviewController.php"},"region":{"startLine":108}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb07cc0c30d4a88e65ada46ed527083f4a2a920032811883336f3239999d1c95"}},{"ruleId":"D1","level":"warning","message":{"text":"Swanctl.getConfig (cyclomatic 38): Swanctl.getConfig has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/Swanctl.php"},"region":{"startLine":211}}}],"partialFingerprints":{"codehealthFindingId/v1":"e17bf345f27be73a66b05ea92c85ecf84ad50d7a4b8fb8363178135902132dcb"}},{"ruleId":"D1","level":"warning","message":{"text":"CPBackgroundProcess.sync_zone (cyclomatic 38): CPBackgroundProcess.sync_zone has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/cp-background-process.py"},"region":{"startLine":140}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7a0e042f4804c5786622fd7c5b2c18273b03f7e4f50731a1a643b8e6861e392"}},{"ruleId":"D1","level":"warning","message":{"text":"render (cyclomatic 37): render has cyclomatic complexity 37 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1714}}}],"partialFingerprints":{"codehealthFindingId/v1":"140678086a242c42ebc91b8b89e2652e514b8d3173a2ddc055371bcf42501a01"}},{"ruleId":"D1","level":"warning","message":{"text":"FilterController.searchRuleAction (cyclomatic 35): FilterController.searchRuleAction has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php"},"region":{"startLine":84}}}],"partialFingerprints":{"codehealthFindingId/v1":"9737ab64d0d4a3756897a697147dfbbc5c9e039ff83f23b26db71aecb9133980"}},{"ruleId":"D1","level":"warning","message":{"text":"ForwardRule.parseRdrRules (cyclomatic 35): ForwardRule.parseRdrRules has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/ForwardRule.php"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"be57c345b414f9745e9e6db7c205a1ebf449bd0eb6dffd2057de0024c24d725a"}},{"ruleId":"D1","level":"warning","message":{"text":"setFormData (cyclomatic 35): setFormData has cyclomatic complexity 35 (threshold 15). Most of this is not in the body itself: 1 of the 35 points is its own statement and the rest belongs to 5 function literals inside it that branch (lines 155, 196, 147, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense.js"},"region":{"startLine":146}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba653c4607168b8571a4b5bb7ed374a987dfc5c4f62b7075b72c3f5bde6a7f28"}},{"ruleId":"D1","level":"warning","message":{"text":"SettingsController.searchGatewayAction (cyclomatic 34): SettingsController.searchGatewayAction has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"d3d3703c82e74f806f049626b0048a0b073d28c558f6b8e1d3748d5fcc5ad1b8"}},{"ruleId":"D1","level":"warning","message":{"text":"Gateways.getGateways (cyclomatic 34): Gateways.getGateways has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php"},"region":{"startLine":329}}}],"partialFingerprints":{"codehealthFindingId/v1":"130eb4d1dab0cf2bfcfbc037f05757cc6021be3c3c84d36be7042057a2bfeff3"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 32): (anonymous) has cyclomatic complexity 32 (threshold 15). Most of this is not in the body itself: 9 of the 32 points are its own statements and the rest belongs to 13 function items inside it that branch ((anonymous)::success, a function literal at line 69, a function literal at line 51, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_favorites.js"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d998b56e584e92d5a67fa1dcf599380f70ff6bf57e8c6c741405d4939fcdfea"}},{"ruleId":"D1","level":"warning","message":{"text":"interfaces.validate_track6_idassoc6 (cyclomatic 31): interfaces.validate_track6_idassoc6 has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/interfaces.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d05550ec97f27aaf2b1c1cfeed27280a61245d92485164bb21d2b699e5554ed"}},{"ruleId":"D1","level":"warning","message":{"text":"M1_0_4.run (cyclomatic 30): M1_0_4.run has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/Migrations/M1_0_4.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d1624d83b7b4ee48e0ee7574ae7cfb25726fae1bee35eb539b591739b83b085"}},{"ruleId":"D1","level":"warning","message":{"text":"CertificatesField.actionPostLoadingEvent (cyclomatic 30): CertificatesField.actionPostLoadingEvent has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CertificatesField.php"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4f62934180c08fc0b9146d48aa9c789bb27af6a65e5df46f22bc133938a0083"}},{"ruleId":"D1","level":"warning","message":{"text":"user_pass_verify.do_auth (cyclomatic 30): user_pass_verify.do_auth has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/openvpn/user_pass_verify.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"90bb0061197122cdcd937c17644057be42c34ce6e2ca81381e7f9b2d473cbcb6"}},{"ruleId":"D1","level":"warning","message":{"text":"Daemonize.start (cyclomatic 30): Daemonize.start has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/daemonize.py"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"be8688084ee0fb28b120d67d9f77220e9f19089e3988745f16c8315f3f8bb84b"}},{"ruleId":"D1","level":"warning","message":{"text":"Daemonize.start (cyclomatic 30): Daemonize.start has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/site-python/daemonize.py"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4a70e69d1f8a34ae9040a572da87e002e291fefaf6665c1e456be8d65182cd6"}},{"ruleId":"D1","level":"warning","message":{"text":"(anonymous) (cyclomatic 30): (anonymous) has cyclomatic complexity 30 (threshold 15). Most of this is not in the body itself: 9 of the 30 points are its own statements and the rest belongs to 26 function items inside it that branch (a function literal at line 181, opnsense_sidebar_toggle, mouseenter, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_theme.js"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"af8ad890f8c33ae6b0b5a7fa94ed76e5a0781cb44f8ff1afc9a204f463639d85"}},{"ruleId":"D1","level":"warning","message":{"text":"TunnelController.searchPhase2Action (cyclomatic 29): TunnelController.searchPhase2Action has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php"},"region":{"startLine":129}}}],"partialFingerprints":{"codehealthFindingId/v1":"1cdc23c62cfdef1a7742a2d02c8dad5cd040dce7a2cfe9e1818110bc23e2ae9a"}},{"ruleId":"D1","level":"warning","message":{"text":"PlainOpenVPN.openvpnConfParts (cyclomatic 29): PlainOpenVPN.openvpnConfParts has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/OpenVPN/PlainOpenVPN.php"},"region":{"startLine":92}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd730a02784b9017dfc9c4825cd84776a26c9ecf0581e3e27b9edcd6182e046c"}},{"ruleId":"D1","level":"warning","message":{"text":"RuleCache.search (cyclomatic 28): RuleCache.search has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/suricata/lib/rulecache.py"},"region":{"startLine":342}}}],"partialFingerprints":{"codehealthFindingId/v1":"e06c81fb52bbc271da7c22f26603bee35082fac02beb31aa650d13444129eb4b"}},{"ruleId":"D1","level":"warning","message":{"text":"CaController.setBaseHook (cyclomatic 27): CaController.setBaseHook has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CaController.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"0666520924f43633dc2189516492231334311767986f0339620aa99161433efa"}},{"ruleId":"D1","level":"warning","message":{"text":"CertController.setBaseHook (cyclomatic 27): CertController.setBaseHook has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"d942a37e97565e048d22d66f0384cc7c32e5127b09e0940ef45a4bcb9c41bcda"}},{"ruleId":"D1","level":"warning","message":{"text":"SNatRule.parseNatRules (cyclomatic 27): SNatRule.parseNatRules has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/SNatRule.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"549f9dfc5a3d8ea4ffd2df926062ca7ed707ce0e8df90a7e7e4de34be304bc97"}},{"ruleId":"D1","level":"warning","message":{"text":"OpenVPN.getOverwrite (cyclomatic 27): OpenVPN.getOverwrite has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php"},"region":{"startLine":234}}}],"partialFingerprints":{"codehealthFindingId/v1":"4396be111ae4bdfccf60535ef8d8668da488811dedf2b0e1df105aea20d0c722"}},{"ruleId":"D1","level":"warning","message":{"text":"UIBootgrid.tabulatorDefaults (cyclomatic 27): UIBootgrid.tabulatorDefaults has cyclomatic complexity 27 (threshold 15). Most of this is not in the body itself: 1 of the 27 points is its own statement and the rest belongs to 9 function literals inside it that branch (lines 1627, 1598, 1657, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1559}}}],"partialFingerprints":{"codehealthFindingId/v1":"9de8f7ff508a0731a9512490186abdef21f20f8143dbff6a613a0dfb6167322e"}},{"ruleId":"D1","level":"warning","message":{"text":"UIBootgrid._internalFormatters (cyclomatic 27): UIBootgrid._internalFormatters has cyclomatic complexity 27 (threshold 15). Most of this is not in the body itself: 1 of the 27 points is its own statement and the rest belongs to 10 function literals inside it that branch (lines 2050, 1947, 2020, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1923}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f4d7f595f838efd479b3c3c3ecd8db0df4df01e662b992338bdeea33a207b47"}},{"ruleId":"D1","level":"warning","message":{"text":"ServiceController.statisticsAction (cyclomatic 26): ServiceController.statisticsAction has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/Api/ServiceController.php"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"3fd76de5ad374302b2d192a46d3bd14646839bcb3a1975e29144b46ff2646f08"}},{"ruleId":"D1","level":"warning","message":{"text":"LDAP._authenticate (cyclomatic 26): LDAP._authenticate has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php"},"region":{"startLine":487}}}],"partialFingerprints":{"codehealthFindingId/v1":"58d1be5f6fa1d6df2b297a4581210363be4bd970eab74110ee9688c9face2e03"}},{"ruleId":"D1","level":"warning","message":{"text":"Rule.mapAddressInfo (cyclomatic 26): Rule.mapAddressInfo has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/Rule.php"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"adaa1474a175a2a85d877f69f81017ef36a79da717049e8d686628ac6cd4b95c"}},{"ruleId":"D1","level":"warning","message":{"text":"Store.parseX509 (cyclomatic 26): Store.parseX509 has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Trust/Store.php"},"region":{"startLine":450}}}],"partialFingerprints":{"codehealthFindingId/v1":"13a095e3a712ac0c99569d370986916cff164cd4642825a8c22a7a5e25bae2af"}},{"ruleId":"D1","level":"warning","message":{"text":"KeaDhcpv4.getConfigSubnets (cyclomatic 26): KeaDhcpv4.getConfigSubnets has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":182}}}],"partialFingerprints":{"codehealthFindingId/v1":"1b8bd8a5771a28b4923ded33c04a895ca11e3f2db320b4b58ad9e249bf8667ee"}},{"ruleId":"D1","level":"warning","message":{"text":"dnsbl_module.operate (cyclomatic 26): dnsbl_module.operate has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound-dnsbl/dnsbl_module.py"},"region":{"startLine":173}}}],"partialFingerprints":{"codehealthFindingId/v1":"81cccaa411ec200139b0fd0c741190da4ad381098b6da582c9df6473b94e78da"}},{"ruleId":"D1","level":"warning","message":{"text":"ControllerBase.beforeExecuteRoute (cyclomatic 25): ControllerBase.beforeExecuteRoute has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php"},"region":{"startLine":373}}}],"partialFingerprints":{"codehealthFindingId/v1":"adda5a3adf65d0d82332bb382f3b71359bb6699784e413bee23364e43401836e"}},{"ruleId":"D1","level":"warning","message":{"text":"DNatRule.parseNatRules (cyclomatic 25): DNatRule.parseNatRules has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/DNatRule.php"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4dcb530519f511a875876a4c5397bb2562ee9d054451fd184e5c5f33a1f2b37"}},{"ruleId":"D1","level":"warning","message":{"text":"MFP1_0_4.run (cyclomatic 25): MFP1_0_4.run has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_0_4.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"90bfd05fc88b777dbb072e74939a8b6284618d07f4c2cf949791060208046628"}},{"ruleId":"D1","level":"warning","message":{"text":"Menu.collect (cyclomatic 25): Menu.collect has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Menu/Menu.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ea5c882d6cd075cd3d21e7a3b0c929b559d23dfe3c2a73862a1d9e3dc041259"}},{"ruleId":"D1","level":"warning","message":{"text":"OpenVPN.getInstanceById (cyclomatic 25): OpenVPN.getInstanceById has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php"},"region":{"startLine":405}}}],"partialFingerprints":{"codehealthFindingId/v1":"92c3b8988c7eeef8b1a66b3b0e835c82add0c493e97e92a6238d5580d07403a7"}},{"ruleId":"D1","level":"warning","message":{"text":"M1_0_13.run (cyclomatic 25): M1_0_13.run has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Unbound/Migrations/M1_0_13.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c948c588250c107381c0f983b98c49177be0ff828be54a4af8bbddaa436c580"}},{"ruleId":"D1","level":"warning","message":{"text":"setaddr.add_gateway_to_config (cyclomatic 25): setaddr.add_gateway_to_config has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/shell/setaddr.php"},"region":{"startLine":199}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3c20152bf6f86e6612f1904ee51a789a796751fe91208613b0a883b99b9b1ca"}},{"ruleId":"D1","level":"warning","message":{"text":"setaddr.console_configure_dhcpd (cyclomatic 25): setaddr.console_configure_dhcpd has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/shell/setaddr.php"},"region":{"startLine":469}}}],"partialFingerprints":{"codehealthFindingId/v1":"982e67ce34173902b96382533ab35c70fc3dd11b99898dcd3a92822c7394e08b"}},{"ruleId":"D1","level":"warning","message":{"text":"unbound_watcher.run_watcher (cyclomatic 25): unbound_watcher.run_watcher has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/unbound_watcher.py"},"region":{"startLine":115}}}],"partialFingerprints":{"codehealthFindingId/v1":"467ff4cea608208edc8d6e9493262301a2ae17b229874f159e703a8e5a135cff"}},{"ruleId":"D1","level":"warning","message":{"text":"buildData (cyclomatic 25): buildData has cyclomatic complexity 25 (threshold 15). Most of this is not in the body itself: 5 of the 25 points are its own statements and the rest belongs to 3 function items inside it that branch (addOption, addOptgroup, addDivider). Those helpers are already separate functions, so extracting the branching again is not available. To reduce it, move them out of the body to the enclosing scope, where each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1499}}}],"partialFingerprints":{"codehealthFindingId/v1":"30968fd19600cd685474bdbcdb575b808156029aeaaed99ceb057f077b3d2133"}},{"ruleId":"D1","level":"warning","message":{"text":"ApiControllerBase.searchRecordsetBase (cyclomatic 24): ApiControllerBase.searchRecordsetBase has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c7df539544ee615a37bea040d61adaa4db124e76fc7e8b8d5dcfd7aaa20b113"}},{"ruleId":"D1","level":"warning","message":{"text":"ApiMutableModelControllerBase.importCsv (cyclomatic 24): ApiMutableModelControllerBase.importCsv has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php"},"region":{"startLine":694}}}],"partialFingerprints":{"codehealthFindingId/v1":"5703454e22a19e7078e4c559fe9d7bd04e503ec3f2195fec2eb56e286106a6b3"}},{"ruleId":"D1","level":"warning","message":{"text":"LeasesController.searchAction (cyclomatic 24): LeasesController.searchAction has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api/LeasesController.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"b6799ff914174cd4155b5488f374956995265231ed96aefd6036df3673fcfb89"}},{"ruleId":"D1","level":"warning","message":{"text":"Base.setGroupMembership (cyclomatic 24): Base.setGroupMembership has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Base.php"},"region":{"startLine":148}}}],"partialFingerprints":{"codehealthFindingId/v1":"5d955dce62c0928cb92656e584af9f78029c284cd82c5d191e6f477ca92a5c5d"}},{"ruleId":"D1","level":"warning","message":{"text":"Radius.stopAccounting (cyclomatic 24): Radius.stopAccounting has cyclomatic complexity 24 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php"},"region":{"startLine":322}}}],"partialFingerprints":{"codehealthFindingId/v1":"21c278b21d1a1ab5c7a8a6658c5ff3b4279b2d697bab92520f2bcab810f042b7"}},{"ruleId":"D1","level":"warning","message":{"text":"Radius.updateAccounting (cyclomatic 24): Radius.updateAccounting has cyclomatic complexity 24 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php"},"region":{"startLine":411}}}],"partialFingerprints":{"codehealthFindingId/v1":"55c2dd951560adb1e5b11299c7cd6f8833084a408bc0047cfd6a0d5f1fea5860"}},{"ruleId":"D1","level":"warning","message":{"text":"IPPortField.getValidators (cyclomatic 24): IPPortField.getValidators has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/IPPortField.php"},"region":{"startLine":103}}}],"partialFingerprints":{"codehealthFindingId/v1":"c5e3df4571b02d3d5055211350525a923293a002fc92b411fdb6a3e8d24ddc31"}},{"ruleId":"D1","level":"warning","message":{"text":"InterfaceField.actionPostLoadingEvent (cyclomatic 24): InterfaceField.actionPostLoadingEvent has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/InterfaceField.php"},"region":{"startLine":106}}}],"partialFingerprints":{"codehealthFindingId/v1":"d0d2f02416f0d29310923d01547c2dcd03e5d4c6bed3c049bd9c09eee4db0003"}},{"ruleId":"D1","level":"warning","message":{"text":"JsonKeyValueStoreField.actionPostLoadingEvent (cyclomatic 24): JsonKeyValueStoreField.actionPostLoadingEvent has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/JsonKeyValueStoreField.php"},"region":{"startLine":123}}}],"partialFingerprints":{"codehealthFindingId/v1":"768f221bb53f57304a8594d646c8d1c15777403e9282d713fea4d903d9c78f29"}},{"ruleId":"D1","level":"warning","message":{"text":"wg-service-control.wg_start (cyclomatic 24): wg-service-control.wg_start has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/wireguard/wg-service-control.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"bdb546a390a8d6ae559608ab2a68ef2573744509546d18de311faace31d288a7"}},{"ruleId":"D1","level":"warning","message":{"text":"Daemonize.start (cyclomatic 24): Daemonize.start has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/lib/daemonize.py"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c696ed7b079e3331b40cdbf4c9bf40d0384f97707a3d6bdf5adb03d2b0117f5"}},{"ruleId":"D1","level":"warning","message":{"text":"bootstrap-select.Plugin (cyclomatic 24): bootstrap-select.Plugin has cyclomatic complexity 24 (threshold 15). Most of this is not in the body itself: 11 of the 24 points are its own statements and the rest belongs to one function literal inside it that branches (line 3163). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal\u0027s work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":3106}}}],"partialFingerprints":{"codehealthFindingId/v1":"6846ae9bce58f31f3c8462f17c601f0c75483433f88de8d32ed7d4dc3b9abf2b"}},{"ruleId":"D1","level":"warning","message":{"text":"IXR_IntrospectionServer.call (cyclomatic 23): IXR_IntrospectionServer.call has cyclomatic complexity 23 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/IXR/IXR_Library.php"},"region":{"startLine":919}}}],"partialFingerprints":{"codehealthFindingId/v1":"0aeb3218a64ff72ee5ea787539060dd808f5ff9f406710f9c76d5dc97f394820"}},{"ruleId":"D1","level":"warning","message":{"text":"SystemController.statusAction (cyclomatic 23): SystemController.statusAction has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/SystemController.php"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"9be6ad8ec47ab1aedc69337838b8dcea30bc750d2df36569421bf4d9a9b6f06f"}},{"ruleId":"D1","level":"warning","message":{"text":"InterfaceController.getVipStatusAction (cyclomatic 23): InterfaceController.getVipStatusAction has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/InterfaceController.php"},"region":{"startLine":251}}}],"partialFingerprints":{"codehealthFindingId/v1":"dfbc575079f592c4408b71445a78c2c5a000267870429fa75ee59ece6b46e2f9"}},{"ruleId":"D1","level":"warning","message":{"text":"M1_0_0.run (cyclomatic 23): M1_0_0.run has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Radvd/Migrations/M1_0_0.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"9e5e5d63b44a4933a2a0bcccd5a3ca5243b92827b0b26d1ae0dc57429bf0c727"}},{"ruleId":"D1","level":"warning","message":{"text":"Metadata.list_rules (cyclomatic 23): Metadata.list_rules has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/suricata/lib/metadata.py"},"region":{"startLine":74}}}],"partialFingerprints":{"codehealthFindingId/v1":"83b0fa72304afc666ec6edd19c339ba27dd30a96e4cd76d8274ff1bf1f2e4c4a"}},{"ruleId":"D1","level":"warning","message":{"text":"RuleCache.list_local_changes (cyclomatic 23): RuleCache.list_local_changes has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/suricata/lib/rulecache.py"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"a1f54f69aca4052803caa75d84a08583d6b60870495eac7c17a49b6908733dab"}},{"ruleId":"D1","level":"warning","message":{"text":"showOptionsDialog (cyclomatic 23): showOptionsDialog has cyclomatic complexity 23 (threshold 15). Most of this is not in the body itself: 7 of the 23 points are its own statements and the rest belongs to 12 function items inside it that branch ((anonymous)::action, updateOptions, (anonymous)::onhide, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":227}}}],"partialFingerprints":{"codehealthFindingId/v1":"8bd06388d65e09bcced3de72374893403756cc771153058ccd8127bff604a57f"}},{"ruleId":"D1","level":"warning","message":{"text":"FilterBaseController.moveRuleBeforeBase (cyclomatic 22): FilterBaseController.moveRuleBeforeBase has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php"},"region":{"startLine":338}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a1855d4670af2e0a17ffef30dfacbfb49e7ae7e85fef7a9342bb4e9b85fc94c"}},{"ruleId":"D1","level":"warning","message":{"text":"Rule.reader (cyclomatic 22): Rule.reader has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/Rule.php"},"region":{"startLine":262}}}],"partialFingerprints":{"codehealthFindingId/v1":"204422246d9ba49f28d9b443f8acd9010161c7b16e4eecedb711028d473f09d7"}},{"ruleId":"D1","level":"warning","message":{"text":"ArrayField.importRecordSet (cyclomatic 22): ArrayField.importRecordSet has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ArrayField.php"},"region":{"startLine":315}}}],"partialFingerprints":{"codehealthFindingId/v1":"5844e8c424b41ce1d03ba0339526413aac7085419ed916f18009d785a8e2ea8a"}},{"ruleId":"D1","level":"warning","message":{"text":"UriParser.iter_addresses (cyclomatic 22): UriParser.iter_addresses has cyclomatic complexity 22 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/uri.py"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a2843427426a741cf510b886c08e951f3742af074da682602bb4f9e8148f29a"}},{"ruleId":"D1","level":"warning","message":{"text":"bootstrap.Tooltip.show (cyclomatic 22): bootstrap.Tooltip.show has cyclomatic complexity 22 (threshold 15). Of this number, 21 points are the body\u0027s own statements and 1 belongs to one function item inside it that branches. This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap.js"},"region":{"startLine":1603}}}],"partialFingerprints":{"codehealthFindingId/v1":"d1d8a837371776f4ce1442b3914dd082e624620d48ce21c0d7fdcf6c472c2f9a"}},{"ruleId":"D1","level":"warning","message":{"text":"qrcode::qrcode::createSvgTag (cyclomatic 22): qrcode::qrcode::createSvgTag has cyclomatic complexity 22 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":495}}}],"partialFingerprints":{"codehealthFindingId/v1":"371ce756d2b96a38baf7cfb11f5b7e8f695d91be6ce6821d1527a43f2fcd35a8"}},{"ruleId":"D1","level":"warning","message":{"text":"_parseGridView (cyclomatic 22): _parseGridView has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":476}}}],"partialFingerprints":{"codehealthFindingId/v1":"9b68a14362fb585088be6e11d999c17bdeddde0aeded0613d205694b89b402fe"}},{"ruleId":"D1","level":"warning","message":{"text":"_parseColumns (cyclomatic 22): _parseColumns has cyclomatic complexity 22 (threshold 15). Of this number, 18 points are the body\u0027s own statements and 4 belong to 3 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":536}}}],"partialFingerprints":{"codehealthFindingId/v1":"b0e9382741b89155eec1611ce68f67b2b33c89ee3d686cad615a8432df6ada72"}},{"ruleId":"D1","level":"warning","message":{"text":"CrlController.getAction (cyclomatic 21): CrlController.getAction has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CrlController.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"21cdaab11f31e332e0a19a52d88215bdc866a73f33e307042e54d055e14c9050"}},{"ruleId":"D1","level":"warning","message":{"text":"ACL.loadUserGroupRights (cyclomatic 21): ACL.loadUserGroupRights has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/ACL.php"},"region":{"startLine":90}}}],"partialFingerprints":{"codehealthFindingId/v1":"cdfafa5f5e45d026d3652963ffc38ea0010b7d7aec46a25cc581f539a0200bb4"}},{"ruleId":"D1","level":"warning","message":{"text":"FilterRuleContainerField.serialize (cyclomatic 21): FilterRuleContainerField.serialize has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/FilterRuleField.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"e4da5427fd6056c7cea363796f3c1d651a9134a8a6ca6efdaee0b564df82ca9a"}},{"ruleId":"D1","level":"warning","message":{"text":"Gateways.performValidation (cyclomatic 21): Gateways.performValidation has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"920237ad1adbacb71ccc79a7af6d2c855f165a08d4413f8d5ddfca7d75c9692a"}},{"ruleId":"D1","level":"warning","message":{"text":"M1_0_1.run (cyclomatic 21): M1_0_1.run has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Unbound/Migrations/M1_0_1.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"f05a43ea7efec307609e85ba3fbb901bbc5a20aa01c095dedd1946670a5f369c"}},{"ruleId":"D1","level":"warning","message":{"text":"GEOIP.process_zip (cyclomatic 21): GEOIP.process_zip has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/geoip.py"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"302bf8ee46caef5e9f2ce779b6766d63800eeeab55029023afb273ed19635cff"}},{"ruleId":"D1","level":"warning","message":{"text":"chartjs-plugin-streaming.clean (cyclomatic 21): chartjs-plugin-streaming.clean has cyclomatic complexity 21 (threshold 15). Most of this is not in the body itself: 3 of the 21 points are its own statements and the rest belongs to 4 function literals inside it that branch (lines 481, 526, 510, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/chartjs-plugin-streaming.js"},"region":{"startLine":473}}}],"partialFingerprints":{"codehealthFindingId/v1":"1377465fa54251c6af7054dbc910c1aea965a3c172959e4804ea72044d0f0817"}},{"ruleId":"D1","level":"warning","message":{"text":"InitialSetup.performValidation (cyclomatic 20): InitialSetup.performValidation has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/InitialSetup.php"},"region":{"startLine":157}}}],"partialFingerprints":{"codehealthFindingId/v1":"a0a24d249b9356f03b8b6f11fae317932adbe2fde26ebe710ffa0fdbb550eeb6"}},{"ruleId":"D1","level":"warning","message":{"text":"DHCRelay.performValidation (cyclomatic 20): DHCRelay.performValidation has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/DHCRelay/DHCRelay.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"ee2991f863eeb38df3d43f6f49d60f99bea3f69eb88320dc18d4b050cb6a29ca"}},{"ruleId":"D1","level":"warning","message":{"text":"Alias.performValidation (cyclomatic 20): Alias.performValidation has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"3393ca266bee8cb3e38e07e53d509e21babb6150464efcddc8ebb6aafda7f31c"}},{"ruleId":"D1","level":"warning","message":{"text":"Radvd.performValidation (cyclomatic 20): Radvd.performValidation has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Radvd/Radvd.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"ea63ac68ae45065c08918a577fe8665eb4631455c1c60b94ea16fa11c3e50cc8"}},{"ruleId":"D1","level":"warning","message":{"text":"Unbound.performValidation (cyclomatic 20): Unbound.performValidation has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Unbound/Unbound.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"958a57493508fa7daffec3a094208bf1dc2966a6ef7b5745ff62ebebebd79cbf"}},{"ruleId":"D1","level":"warning","message":{"text":"diag_backup.restore_config_section (cyclomatic 20): diag_backup.restore_config_section has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/diag_backup.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"bb03dcc189ea0d9dbd00b20e9f91cd8aa4b464c15b95ddca2cb8c7445fa8a45e"}},{"ruleId":"D1","level":"warning","message":{"text":"states.query_top (cyclomatic 20): states.query_top has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/states.py"},"region":{"startLine":225}}}],"partialFingerprints":{"codehealthFindingId/v1":"44cb11bb4650d926eb5cd1c869e59437b4fc89052cb70aa1fcf6e570988758da"}},{"ruleId":"D1","level":"warning","message":{"text":"read_log.parse_record (cyclomatic 20): read_log.parse_record has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/read_log.py"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"03f2d7615122dcd22f0942aa82088dfcef5f4555ce8afcbb8ce9086a1bda8d38"}},{"ruleId":"D1","level":"warning","message":{"text":"ping.read_latest_stats (cyclomatic 20): ping.read_latest_stats has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/interfaces/ping.py"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4e1e683aec52a09c479290c145a75d41c5797a05105ec5da6d828feb1b09490"}},{"ruleId":"D1","level":"warning","message":{"text":"ovpn_status.main (cyclomatic 20): ovpn_status.main has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/openvpn/ovpn_status.py"},"region":{"startLine":112}}}],"partialFingerprints":{"codehealthFindingId/v1":"6cbaa37c6d2ff255a3d56862b63e7ebb128893678633db1dcadeed4a8a1768a8"}},{"ruleId":"D1","level":"warning","message":{"text":"DNSBL.policy_match (cyclomatic 20): DNSBL.policy_match has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound-dnsbl/lib/dnsbl.py"},"region":{"startLine":123}}}],"partialFingerprints":{"codehealthFindingId/v1":"31693fb7a278fed08dae56b447a628ae4d0cef1588c6af8f6ad90ad4b5aa54cc"}},{"ruleId":"D1","level":"warning","message":{"text":"opnsense_legacy.hook_firewall_categories (cyclomatic 20): opnsense_legacy.hook_firewall_categories has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 1 of the 20 points is its own statement and the rest belongs to 5 function literals inside it that branch (lines 186, 197, 248, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/javascript/opnsense_legacy.js"},"region":{"startLine":184}}}],"partialFingerprints":{"codehealthFindingId/v1":"6c64331f300cfa1de9e7dd3393422f857281a31fb9337766c072b61a7c21d7d4"}},{"ruleId":"D1","level":"warning","message":{"text":"SimpleActionButton (cyclomatic 20): SimpleActionButton has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 1 of the 20 points is its own statement and the rest belongs to 14 function items inside it that branch (a function literal at line 884, construct, setIcon, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":816}}}],"partialFingerprints":{"codehealthFindingId/v1":"fa5127d01002691e87a0c4fd275326f7c2a4b1c832b887d59130365c213212cc"}},{"ruleId":"D1","level":"warning","message":{"text":"ApiMutableModelControllerBase.checkAndThrowValueInUse (cyclomatic 19): ApiMutableModelControllerBase.checkAndThrowValueInUse has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php"},"region":{"startLine":109}}}],"partialFingerprints":{"codehealthFindingId/v1":"1edba063b5c868750b380ee0aff471c542de10aaa2d53ebd69cffd7175ea6e17"}},{"ruleId":"D1","level":"warning","message":{"text":"AccessController.logonAction (cyclomatic 19): AccessController.logonAction has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/Api/AccessController.php"},"region":{"startLine":235}}}],"partialFingerprints":{"codehealthFindingId/v1":"5afab78626246d7d05dc214fe03a366ee8a7b47dbe443d77888685767c1ff60c"}},{"ruleId":"D1","level":"warning","message":{"text":"NetworkinsightController.timeserieAction (cyclomatic 19): NetworkinsightController.timeserieAction has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/NetworkinsightController.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d9e86aeba902501c68873d3b623763d3b3b3ba449578a218b2ca61b6b177194"}},{"ruleId":"D1","level":"warning","message":{"text":"ExportController.downloadAction (cyclomatic 19): ExportController.downloadAction has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ExportController.php"},"region":{"startLine":295}}}],"partialFingerprints":{"codehealthFindingId/v1":"202caaab25b72293a1845a9dd87ba14fbe5716920f61f33f98a84cd656eee4ee"}},{"ruleId":"D1","level":"warning","message":{"text":"Config.fromArray (cyclomatic 19): Config.fromArray has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Core/Config.php"},"region":{"startLine":191}}}],"partialFingerprints":{"codehealthFindingId/v1":"e78831aeb700c7395715a9b1a17a25cb842289caeb3b105ea43068aff4d98c96"}},{"ruleId":"D1","level":"warning","message":{"text":"UniqueConstraint.validate (cyclomatic 19): UniqueConstraint.validate has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/Constraints/UniqueConstraint.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"04634894a8faa275d8858c3e025a66a4bbfe35d8d589d3003ff4141cf13468b5"}},{"ruleId":"D1","level":"warning","message":{"text":"InitialSetup.init (cyclomatic 19): InitialSetup.init has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/InitialSetup.php"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"87a7f7559363e9e9a70d1874e1f6666b3e11f0f0815ee58b77b3b060fd865075"}},{"ruleId":"D1","level":"warning","message":{"text":"HostField.getValidators (cyclomatic 19): HostField.getValidators has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Diagnostics/FieldTypes/HostField.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"9461d17df9d444474b91e8d0143d82dae00edb95491d25b03b874ecaeac06599"}},{"ruleId":"D1","level":"warning","message":{"text":"M1_0_0.run (cyclomatic 19): M1_0_0.run has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/Migrations/M1_0_0.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"43b04b242b1957f0b65c29ca0cc0cbbc8dabe61ac59287d8dfd324b027ce8354"}},{"ruleId":"D1","level":"warning","message":{"text":"M1_0_0.run (cyclomatic 19): M1_0_0.run has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Migrations/M1_0_0.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"8269da7a2ce277c06341e45bf2490c18735e18fb55b0fc3d2d645df7a8d967c7"}},{"ruleId":"D1","level":"warning","message":{"text":"Downloader._unpack (cyclomatic 19): Downloader._unpack has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/suricata/lib/downloader.py"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"b35f489f760f85c9c4bc5ca5e1841b2652ad11493f64bffdac2471cc9776861c"}},{"ruleId":"D1","level":"warning","message":{"text":"qrcode::qrcode::setupPositionProbePattern (cyclomatic 19): qrcode::qrcode::setupPositionProbePattern has cyclomatic complexity 19 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f000addacd64c0756209da8c9ec8510128d5b737385afc59831fbe151b0527c"}},{"ruleId":"D1","level":"warning","message":{"text":"liveSearchListener (cyclomatic 19): liveSearchListener has cyclomatic complexity 19 (threshold 15). Most of this is not in the body itself: 1 of the 19 points is its own statement and the rest belongs to 3 function literals inside it that branch (lines 2672, 2661, 2668). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":2658}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d4e45a50c28153b6ab0e3780ad273871fa5dd7e0be63cb00342ad18fa200ffa"}},{"ruleId":"D1","level":"warning","message":{"text":"IXR_Message.tag_close (cyclomatic 18): IXR_Message.tag_close has cyclomatic complexity 18 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/IXR/IXR_Library.php"},"region":{"startLine":262}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf8f54b40026154d5eb5b4ad0d688e5abe922410881a026de9c2e49dbb18c1f8"}},{"ruleId":"D1","level":"warning","message":{"text":"ControllerBase.parseFormNode (cyclomatic 18): ControllerBase.parseFormNode has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php"},"region":{"startLine":166}}}],"partialFingerprints":{"codehealthFindingId/v1":"462600e513a454d4b7fdfb564827f918eccbc3353db20c7f8cf36ad2e0d140c5"}},{"ruleId":"D1","level":"warning","message":{"text":"M1_0_0.run (cyclomatic 18): M1_0_0.run has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/M1_0_0.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec356000f93732eca2c3dd8b4a23e0ddac40f26381809baadaa495679fd11f34"}},{"ruleId":"D1","level":"warning","message":{"text":"M1_0_7.run (cyclomatic 18): M1_0_7.run has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IDS/Migrations/M1_0_7.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"35338cb08dd0ad5009f00df03711ead1e0e1d38714556f69fd686f6c2b68366f"}},{"ruleId":"D1","level":"warning","message":{"text":"VlanInterfaceField.actionPostLoadingEvent (cyclomatic 18): VlanInterfaceField.actionPostLoadingEvent has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/VlanInterfaceField.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"554323cb6b69eb12837eec94e0b4b78d68988ea7f549494e0bd4782eb4dc292d"}},{"ruleId":"D1","level":"warning","message":{"text":"NetworkInterface.serializeToConfig (cyclomatic 18): NetworkInterface.serializeToConfig has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php"},"region":{"startLine":120}}}],"partialFingerprints":{"codehealthFindingId/v1":"d412ac15033b3229100cd3123634cc7f7596499062fa1b91c29d1bac0052d465"}},{"ruleId":"D1","level":"warning","message":{"text":"BaseFlowAggregator.get_top_data (cyclomatic 18): BaseFlowAggregator.get_top_data has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/netflow/lib/aggregates/__init__.py"},"region":{"startLine":283}}}],"partialFingerprints":{"codehealthFindingId/v1":"926a8838aeff29af2e4cf51949690f84a77a6be00fe5508f6bccc25ac0880c1b"}},{"ruleId":"D1","level":"warning","message":{"text":"FlowParser.__iter__ (cyclomatic 18): FlowParser.__iter__ has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/netflow/lib/flowparser.py"},"region":{"startLine":130}}}],"partialFingerprints":{"codehealthFindingId/v1":"2af76d2490b8f4749ca0431a0094d1bf1b88f13adf45cbbf36563256d465dbfa"}},{"ruleId":"D1","level":"warning","message":{"text":"update-crl-fetch.main (cyclomatic 18): update-crl-fetch.main has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/system/update-crl-fetch.py"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"149bb69cb738082e157d10ffc35f13d14b62f3eb1b18599dd839639cb94b4eab"}},{"ruleId":"D1","level":"warning","message":{"text":"UIBootgrid._renderActionBar (cyclomatic 18): UIBootgrid._renderActionBar has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 7 of the 18 points are its own statements and the rest belongs to 5 function literals inside it that branch (lines 1276, 1283, 1300, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1234}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d7da481b3d8e2b0a5a10d4eddeb2b205f37217675ea988e52a46d891cc096fa"}},{"ruleId":"D1","level":"warning","message":{"text":"opnsense_ui.initGlobalOpenShortcuts (cyclomatic 18): opnsense_ui.initGlobalOpenShortcuts has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 1 of the 18 points is its own statement and the rest belongs to one function literal inside it that branches (line 694). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal\u0027s work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest. This is NOT this file\u0027s highest cyclomatic complexity: opnsense_ui.$.fn.SimpleActionButton (cyclomatic 20) is higher and carries no row of its own \u2014 it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension\u0027s figures nor in its score."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":693}}}],"partialFingerprints":{"codehealthFindingId/v1":"31d3ac55640763da1ea88bc969980684a5101ffc32e190c7a2b0606583eb3776"}},{"ruleId":"D1","level":"warning","message":{"text":"qrcode::qrcode::_createHalfASCII (cyclomatic 18): qrcode::qrcode::_createHalfASCII has cyclomatic complexity 18 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":620}}}],"partialFingerprints":{"codehealthFindingId/v1":"860e936c69b1006ef4349b920d39f9e0f89bc63b85c60f82de57e957f3ad86e7"}},{"ruleId":"D1","level":"warning","message":{"text":"createDropdown (cyclomatic 18): createDropdown has cyclomatic complexity 18 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1057}}}],"partialFingerprints":{"codehealthFindingId/v1":"ffad2da09f1d74f878ac22f74772375f4f976471fc5a31ce676e05069158d34f"}},{"ruleId":"D1","level":"warning","message":{"text":"setMenuSize (cyclomatic 18): setMenuSize has cyclomatic complexity 18 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":2030}}}],"partialFingerprints":{"codehealthFindingId/v1":"23b61292d188ff2a5ce390ba664dd36aa61ecb4b421da76843def83b93e64c78"}},{"ruleId":"D1","level":"warning","message":{"text":"SadController.searchAction (cyclomatic 17): SadController.searchAction has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SadController.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"c817dea8ee5877c61b3b237cac1b342cf03beacce9fd6d6af42cf2e314223491"}},{"ruleId":"D1","level":"warning","message":{"text":"SpdController.searchAction (cyclomatic 17): SpdController.searchAction has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SpdController.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"c46474991bd3a3aa82678d35ff066aba43fe120827e2532f6fa28ec4bf3642a7"}},{"ruleId":"D1","level":"warning","message":{"text":"TunnelController.searchPhase1Action (cyclomatic 17): TunnelController.searchPhase1Action has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b6653db01e6e2bbe098850affe6c826d98961f9ad8ab04b641d254f904dbdb1"}},{"ruleId":"D1","level":"warning","message":{"text":"LaggSettingsController.delItemAction (cyclomatic 17): LaggSettingsController.delItemAction has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/LaggSettingsController.php"},"region":{"startLine":126}}}],"partialFingerprints":{"codehealthFindingId/v1":"cf9885ea2d3451d236e2f2cdbf5136bcdc46ae759e26deb3137519ae6c17a243"}},{"ruleId":"D1","level":"warning","message":{"text":"ServiceController.searchSessionsAction (cyclomatic 17): ServiceController.searchSessionsAction has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ServiceController.php"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"786030e3d02214c20737233188400841ada7787bfd39f8691582403c182ecfdf"}},{"ruleId":"D1","level":"warning","message":{"text":"ServiceController.statsAction (cyclomatic 17): ServiceController.statsAction has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Syslog/Api/ServiceController.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"ba442c20d27dfd6f2b6fe24b98c824d3201b58a47a6298a0750071282c1e7589"}},{"ruleId":"D1","level":"warning","message":{"text":"UIModelGrid.fetch (cyclomatic 17): UIModelGrid.fetch has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Base/UIModelGrid.php"},"region":{"startLine":111}}}],"partialFingerprints":{"codehealthFindingId/v1":"14cd848a0a9e24d48b28872e2f6f0822607012c4cc880ccaad4e693a4bfe01d7"}},{"ruleId":"D1","level":"warning","message":{"text":"Config.toArray (cyclomatic 17): Config.toArray has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Core/Config.php"},"region":{"startLine":97}}}],"partialFingerprints":{"codehealthFindingId/v1":"ac22bcf1a5a8a720d761ef83b4a1f9b6fac93b3d2f152ccad750e2503f811daa"}},{"ruleId":"D1","level":"warning","message":{"text":"Plugin.setGatewayGroups (cyclomatic 17): Plugin.setGatewayGroups has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/Plugin.php"},"region":{"startLine":133}}}],"partialFingerprints":{"codehealthFindingId/v1":"56fa6fae4261f61a434a01fd5143ac3d4c3b4e4363e2ba5bd3be5155dde2c8c3"}},{"ruleId":"D1","level":"warning","message":{"text":"BaseModel.runMigrations (cyclomatic 17): BaseModel.runMigrations has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php"},"region":{"startLine":882}}}],"partialFingerprints":{"codehealthFindingId/v1":"7ccacb611f343f5fe5227d712285f57edf51cabf29ea28128c59d3141927bcc8"}},{"ruleId":"D1","level":"warning","message":{"text":"HostnameField.getValidators (cyclomatic 17): HostnameField.getValidators has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/HostnameField.php"},"region":{"startLine":129}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2c7cc72d0bde59a96a2dd624e57bc68afa746180dd4059c1d7f5045b8f2ce9a"}},{"ruleId":"D1","level":"warning","message":{"text":"NetworkField.isValidInput (cyclomatic 17): NetworkField.isValidInput has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NetworkField.php"},"region":{"startLine":142}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef92b21de8c43a4cc21d81f0c95e1b2e6d649f67c395a51ea20d5011dfd8be49"}},{"ruleId":"D1","level":"warning","message":{"text":"DNat.performValidation (cyclomatic 17): DNat.performValidation has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/DNat.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"1670cea3208d6bf550e7a97776e3ce76b0444695286a50afa73835a95a583ac4"}},{"ruleId":"D1","level":"warning","message":{"text":"NetworkInterfaceContainerField.toLegacy (cyclomatic 17): NetworkInterfaceContainerField.toLegacy has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/NetworkInterfaceField.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"ee22000882feb3a2133e6451100588061bf26e1f6efc9626b3bca65c93029378"}},{"ruleId":"D1","level":"warning","message":{"text":"NetworkInterfaceContainerField.fromLegacy (cyclomatic 17): NetworkInterfaceContainerField.fromLegacy has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/NetworkInterfaceField.php"},"region":{"startLine":140}}}],"partialFingerprints":{"codehealthFindingId/v1":"e37f8fed115b3df22666dce01a56b8c7d62f6ec0aca1dc7ff7c3787c389a792e"}},{"ruleId":"D1","level":"warning","message":{"text":"M1_0_0.run (cyclomatic 17): M1_0_0.run has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Monit/Migrations/M1_0_0.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd4e313e0c0040334b17232dbfb2f675bf449b6b19db7f07cb18cf3f4aa7e7a2"}},{"ruleId":"D1","level":"warning","message":{"text":"Gateways.gatewayIterator (cyclomatic 17): Gateways.gatewayIterator has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php"},"region":{"startLine":192}}}],"partialFingerprints":{"codehealthFindingId/v1":"83ec741f5dc6ccbaef8f129d3824accefbf05dd16af2ba9f0219e844c8004f90"}},{"ruleId":"D1","level":"warning","message":{"text":"DB.update_accounting_info (cyclomatic 17): DB.update_accounting_info has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/lib/db.py"},"region":{"startLine":478}}}],"partialFingerprints":{"codehealthFindingId/v1":"381430a5e75ffae6fcf8779cd760b5e8bfb21bf7acb1b7a758662df6f7c9018d"}},{"ruleId":"D1","level":"warning","message":{"text":"AsyncDNSResolver.request_ittr (cyclomatic 17): AsyncDNSResolver.request_ittr has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/base.py"},"region":{"startLine":112}}}],"partialFingerprints":{"codehealthFindingId/v1":"c09eae734f32471a8b0481687bd5611845b52508c03e6a48bfe2051de453a3e1"}},{"ruleId":"D1","level":"warning","message":{"text":"ovpn_event.main (cyclomatic 17): ovpn_event.main has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/openvpn/ovpn_event.py"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"c2ff5493c6f682c5d60299da8943c082c31e83911222eb867f6ad266d91b6808"}},{"ruleId":"D1","level":"warning","message":{"text":"lib.parse_ipfw_pipes (cyclomatic 17): lib.parse_ipfw_pipes has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/shaper/lib/__init__.py"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"8de09ab9ef71a7dc0fd17380d1c578d9c7d349987fbcc3de29faf3aa9198a740"}},{"ruleId":"D1","level":"warning","message":{"text":"Template._generate (cyclomatic 17): Template._generate has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/template.py"},"region":{"startLine":219}}}],"partialFingerprints":{"codehealthFindingId/v1":"3efe9fb36bcec84d52df31be1050c7c0b786adc2aecdecd60c054743fc858357"}},{"ruleId":"D1","level":"warning","message":{"text":"bootstrap.Modal.backdrop (cyclomatic 17): bootstrap.Modal.backdrop has cyclomatic complexity 17 (threshold 15). Of this number, 13 points are the body\u0027s own statements and 4 belong to 2 function items inside it that branch. This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap.js"},"region":{"startLine":1112}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c8d3aa31f077fe9564474d8522a482cc8f89bf1f3141a7b0c856f453cd76d8c"}},{"ruleId":"D1","level":"warning","message":{"text":"opnsense.getFormData (cyclomatic 17): opnsense.getFormData has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 1 of the 17 points is its own statement and the rest belongs to 3 function literals inside it that branch (lines 77, 69, 99). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense.js"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"18f7407d8c844c5413e3a6d074cb1bb7c6b1839034daadeefb131f0b2ab0cfeb"}},{"ruleId":"D1","level":"warning","message":{"text":"qrcode::QRUtil::getLengthInBits (cyclomatic 17): qrcode::QRUtil::getLengthInBits has cyclomatic complexity 17 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":974}}}],"partialFingerprints":{"codehealthFindingId/v1":"b98cd6b835553d4e8e69d1a5417e893d8490f513ab8d222af967b87bc1fd4cf2"}},{"ruleId":"D1","level":"warning","message":{"text":"setPlaceholder (cyclomatic 17): setPlaceholder has cyclomatic complexity 17 (threshold 15). Of this number, 16 points are the body\u0027s own statements and 1 belongs to one function literal inside it that branches. This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1447}}}],"partialFingerprints":{"codehealthFindingId/v1":"4aea429e3bfa210eaaeb227d0e33651d9fde868d892f8f7011689c8256a7ba49"}},{"ruleId":"D1","level":"warning","message":{"text":"handleModalEvents (cyclomatic 17): handleModalEvents has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 1 of the 17 points is its own statement and the rest belongs to 6 function literals inside it that branch (lines 1024, 1040, 1052, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-dialog.js"},"region":{"startLine":1023}}}],"partialFingerprints":{"codehealthFindingId/v1":"7225222cb77acc65fc15672ae1ca4667109be98755c2e1c7260ac271a0a0c0de"}},{"ruleId":"D1","level":"warning","message":{"text":"processTunnels (cyclomatic 17): processTunnels has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 1 of the 17 points is its own statement and the rest belongs to 6 function literals inside it that branch (lines 82, 117, 140, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/Wireguard.js"},"region":{"startLine":77}}}],"partialFingerprints":{"codehealthFindingId/v1":"3e198221b85dc3162193b42c1ce5eb57bbb84fe20296886b0c6d9fbf94da7aa8"}},{"ruleId":"D1","level":"warning","message":{"text":"IXR_Client.query (cyclomatic 16): IXR_Client.query has cyclomatic complexity 16 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/IXR/IXR_Library.php"},"region":{"startLine":625}}}],"partialFingerprints":{"codehealthFindingId/v1":"befac0cbf14a92b65209e4c940ef2a938e14f1dcd0cf0f0c8e8b2f109d2b71e4"}},{"ruleId":"D1","level":"warning","message":{"text":"ControllerBase.getFormGrid (cyclomatic 16): ControllerBase.getFormGrid has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php"},"region":{"startLine":281}}}],"partialFingerprints":{"codehealthFindingId/v1":"081d83e8f76ee4d86accf9c60642aae15658a6ae6e5ff3cdd3346bff8333145d"}},{"ruleId":"D1","level":"warning","message":{"text":"FirewallController.statsAction (cyclomatic 16): FirewallController.statsAction has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/FirewallController.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"b0d556ac2e0b0632ee89a46ad475ecae38c927d015434843ca5f6da7b9dc5e8b"}},{"ruleId":"D1","level":"warning","message":{"text":"AliasController.importAction (cyclomatic 16): AliasController.importAction has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php"},"region":{"startLine":404}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b59cb8fae0a4fff85b942d62914c5db23c86da63477887fbe0b1b60ac7f8b14"}},{"ruleId":"D1","level":"warning","message":{"text":"SettingsController.searchInstalledRulesAction (cyclomatic 16): SettingsController.searchInstalledRulesAction has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IDS/Api/SettingsController.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e6f8219dde8247c0f45fadb02b40f28236d1385e99466cf88c13c8d1622c96a"}},{"ruleId":"D1","level":"warning","message":{"text":"ServiceController.showAction (cyclomatic 16): ServiceController.showAction has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Wireguard/Api/ServiceController.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"630f4976472b2ba43b5319ee74d1dd7d1d0ea4a084736eb1441f211b4b51f7bc"}},{"ruleId":"D1","level":"warning","message":{"text":"Radius.startAccounting (cyclomatic 16): Radius.startAccounting has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php"},"region":{"startLine":253}}}],"partialFingerprints":{"codehealthFindingId/v1":"fecb83dee2c4035ab85545866dece258a2997a2a2b11b3e0c66c0e80e0ed6573"}},{"ruleId":"D1","level":"warning","message":{"text":"TunableField.actionPostLoadingEvent (cyclomatic 16): TunableField.actionPostLoadingEvent has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/FieldTypes/TunableField.php"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"52a8e06b929f36e417cad4ec28b4e2ace2e6e7970f25791d6da6f9e6855d7217"}},{"ruleId":"D1","level":"warning","message":{"text":"Firmware.getRepositoryOptions (cyclomatic 16): Firmware.getRepositoryOptions has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/Firmware.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd126d61b6186b36d737eafc732fc5d419330f99a6f49f846846513b485e519f"}},{"ruleId":"D1","level":"warning","message":{"text":"InitialSetup.flush_network_wan (cyclomatic 16): InitialSetup.flush_network_wan has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/InitialSetup.php"},"region":{"startLine":282}}}],"partialFingerprints":{"codehealthFindingId/v1":"409687f7bd327a4df31b9ca8a2d0a794bafdc8a04094e00827e423b9b7957e7b"}},{"ruleId":"D1","level":"warning","message":{"text":"MFP1_0_3.run (cyclomatic 16): MFP1_0_3.run has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_0_3.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae6a36a0130dfaf2ab4f23f7f34c3abc89779b32922d6969797f3ffd41fe7046"}},{"ruleId":"D1","level":"warning","message":{"text":"IPsec.traverseItems (cyclomatic 16): IPsec.traverseItems has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/IPsec.php"},"region":{"startLine":188}}}],"partialFingerprints":{"codehealthFindingId/v1":"f0c9d652edd1e492496e5c106429ac8a010d6e40ea515d3f0a503941ea8f5fc8"}},{"ruleId":"D1","level":"warning","message":{"text":"M1_0_1.run (cyclomatic 16): M1_0_1.run has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/Migrations/M1_0_1.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"e40ef57fbee427f89fba8904fd4889b1da03cffe218fd72b2c56b41610766120"}},{"ruleId":"D1","level":"warning","message":{"text":"DUIDField.isValidDuid (cyclomatic 16): DUIDField.isValidDuid has cyclomatic complexity 16 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/DUIDField.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"5eb499568d5e9c30f1fc9e7fcc89332fffb0c180b96239898f7f7421f2e709c8"}},{"ruleId":"D1","level":"warning","message":{"text":"WLAN1_0_0.post (cyclomatic 16): WLAN1_0_0.post has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations/WLAN1_0_0.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"96faa2c07247eb42c3bff0ae5ec77c1fe3a61620fc84102ab0d11582c5bf1124"}},{"ruleId":"D1","level":"warning","message":{"text":"KeaDdns.generateConfig (cyclomatic 16): KeaDdns.generateConfig has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"d795727fabe3f29b7e093df0876e39cda9b7037ad3226bd4a6941bfc8f864ea7"}},{"ruleId":"D1","level":"warning","message":{"text":"CPBackgroundProcess.initialize_fixed (cyclomatic 16): CPBackgroundProcess.initialize_fixed has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/cp-background-process.py"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"a6335abe38e9dd3134f741de97ff6325615a3606624b2403f2072ae4a10e2827"}},{"ruleId":"D1","level":"warning","message":{"text":"AsyncDNSResolver.request_ittr (cyclomatic 16): AsyncDNSResolver.request_ittr has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/__init__.py"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"26353f2804b7817bc4876055fd716bc294860a6d2f88fabb85961f53cb2d33ee"}},{"ruleId":"D1","level":"warning","message":{"text":"BlocklistParser.modify_blocklist (cyclomatic 16): BlocklistParser.modify_blocklist has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/blocklists/__init__.py"},"region":{"startLine":147}}}],"partialFingerprints":{"codehealthFindingId/v1":"d9c2e0fe4aeea9f833d59d2d028995c42c6ed60fbfcd5e9a1ae735ea8cbb4585"}},{"ruleId":"D1","level":"warning","message":{"text":"Action.execute (cyclomatic 16): Action.execute has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/actions/inline.py"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"0237a54ae1c904bc2ed9b03f7e464ed1989dc5ad2be8c117cdd4fa79141f5b64"}},{"ruleId":"D1","level":"warning","message":{"text":"RealTimeScale._generate (cyclomatic 16): RealTimeScale._generate has cyclomatic complexity 16 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/chartjs-plugin-streaming.js"},"region":{"startLine":708}}}],"partialFingerprints":{"codehealthFindingId/v1":"b41e9df907bbe561b77b75baca614d0fe713d5bc3e3c74e85b0378dcee44f491"}},{"ruleId":"D1","level":"warning","message":{"text":"opnsense_ui.initFormHelpUI (cyclomatic 16): opnsense_ui.initFormHelpUI has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 3 of the 16 points are its own statements and the rest belongs to 5 function literals inside it that branch (lines 476, 432, 505, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest. This is NOT this file\u0027s highest cyclomatic complexity: opnsense_ui.$.fn.SimpleActionButton (cyclomatic 20) is higher and carries no row of its own \u2014 it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension\u0027s figures nor in its score."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":423}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed291e6d7dc69348b60464b92483f73e9b86bb8795546b366286268ad124cc16"}},{"ruleId":"D1","level":"warning","message":{"text":"tokenize2.Tokenize2.init (cyclomatic 16): tokenize2.Tokenize2.init has cyclomatic complexity 16 (threshold 15). Of this number, 8 points are the body\u0027s own statements and 8 belong to 5 function literals inside it that branch. This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/tokenize2.js"},"region":{"startLine":134}}}],"partialFingerprints":{"codehealthFindingId/v1":"c22eff52b593c2d427884690b67a68f2a87199c2744179efab705bca5907012c"}},{"ruleId":"D1","level":"warning","message":{"text":"_makeOptionField (cyclomatic 16): _makeOptionField has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":350}}}],"partialFingerprints":{"codehealthFindingId/v1":"00ab34fa8a0d950c14a8460744c31e6dccf4d354672c27a872134cdcad834cb8"}},{"ruleId":"D1","level":"warning","message":{"text":"SimpleFileUploadDlg (cyclomatic 16): SimpleFileUploadDlg has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to 8 function items inside it that branch (a function literal at line 1111, a function literal at line 1073, construct::(anonymous)::(anonymous)::onload, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":1045}}}],"partialFingerprints":{"codehealthFindingId/v1":"665e33aae40404e1fd564ef28733df751882c4f729039e89c0f7f53426d8a11c"}},{"ruleId":"D1","level":"warning","message":{"text":"_renderFooterCommands (cyclomatic 16): _renderFooterCommands has cyclomatic complexity 16 (threshold 15). Of this number, 13 points are the body\u0027s own statements and 3 belong to 5 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1350}}}],"partialFingerprints":{"codehealthFindingId/v1":"df778d0faf7a6a0c92e63d4e72090db909ebaac972b790ebf0818a02816f692b"}},{"ruleId":"D1","level":"warning","message":{"text":"setStyle (cyclomatic 16): setStyle has cyclomatic complexity 16 (threshold 15). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1841}}}],"partialFingerprints":{"codehealthFindingId/v1":"65714b8a1d350e9947466132671a9de1607c8393d63f659a85eee8892b44d5fa"}},{"ruleId":"D1","level":"warning","message":{"text":"onWidgetTick (cyclomatic 16): onWidgetTick has cyclomatic complexity 16 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/KeaLeases.js"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e81ab97becc9295e02c977744b4ec182fc8e53dd1ac131e03448d3b786d002a"}},{"ruleId":"D2","level":"warning","message":{"text":"OpenVPN.generateInstanceConfig (cognitive 303): OpenVPN.generateInstanceConfig has cognitive complexity 303 (threshold 15). Drivers by points: if/else 60 (213 pts), loops 12 (49 pts), ternaries 5 (27 pts), boolean chains 14 (nesting depth added 212). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php"},"region":{"startLine":551}}}],"partialFingerprints":{"codehealthFindingId/v1":"7392344dcf6c9f2ff1e147ed3201a52ed41b86079d8f79f698e1f2526bbff20e"}},{"ruleId":"D2","level":"warning","message":{"text":"Filter.performValidation (cognitive 300): Filter.performValidation has cognitive complexity 300 (threshold 15). Drivers by points: if/else 45 (196 pts), boolean chains 48, ternaries 6 (29 pts), loops 9 (27 pts) (nesting depth added 192). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"c27db8eb55efdaf9b27b82967e2ea0357aa653d279c52b73b75b08573b8aeb67"}},{"ruleId":"D2","level":"warning","message":{"text":"Dnsmasq.performValidation (cognitive 195): Dnsmasq.performValidation has cognitive complexity 195 (threshold 15). Drivers by points: if/else 48 (121 pts), boolean chains 34, loops 14 (27 pts), ternaries 5 (13 pts) (nesting depth added 94). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"9d1f6ee6e1fc06360cb3ae5c8d842280a7656f14e431c4816dd4e96658c97c07"}},{"ruleId":"D2","level":"warning","message":{"text":"CrlController.setAction (cognitive 153): CrlController.setAction has cognitive complexity 153 (threshold 15). Drivers by points: if/else 33 (94 pts), loops 9 (31 pts), ternaries 4 (17 pts), error handling 2 (9 pts), boolean chains 2 (nesting depth added 103). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CrlController.php"},"region":{"startLine":180}}}],"partialFingerprints":{"codehealthFindingId/v1":"e21cf603cf493502d3045e7603f86f0e6463de9fe3a5e9cc5165e03a38db7009"}},{"ruleId":"D2","level":"warning","message":{"text":"FilterRule.parseFilterRules (cognitive 151): FilterRule.parseFilterRules has cognitive complexity 151 (threshold 15). Drivers by points: if/else 28 (83 pts), boolean chains 26, ternaries 6 (24 pts), loops 4 (15 pts), match/switch 1 (3 pts) (nesting depth added 86). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php"},"region":{"startLine":203}}}],"partialFingerprints":{"codehealthFindingId/v1":"d14581e58ba3a43e26626ca2af48908bc07abdd2b43a5be2c0f78ef9d59ba9d6"}},{"ruleId":"D2","level":"warning","message":{"text":"KeaDhcpv6.performValidation (cognitive 139): KeaDhcpv6.performValidation has cognitive complexity 139 (threshold 15). Drivers by points: if/else 40 (107 pts), loops 8 (17 pts), boolean chains 15 (nesting depth added 76). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"92749420c19b67cf748034aafb9f6c60116939a26542fb88f090314b21a09dda"}},{"ruleId":"D2","level":"warning","message":{"text":"states.query_states (cognitive 129): states.query_states has cognitive complexity 129 (threshold 15). Drivers by points: if/else 20 (85 pts), loops 5 (19 pts), ternaries 4 (12 pts), boolean chains 8, error handling 1 (5 pts) (nesting depth added 91). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/states.py"},"region":{"startLine":110}}}],"partialFingerprints":{"codehealthFindingId/v1":"e332a563afe9b53a4c42f5a0041781ced6da85c4e969fa3e5dbb03fc632b2399"}},{"ruleId":"D2","level":"warning","message":{"text":"clickListener (cognitive 129): clickListener has cognitive complexity 129 (threshold 15). Drivers by points: if/else 41 (75 pts), ternaries 6 (28 pts), boolean chains 20, loops 1 (6 pts) (nesting depth added 61). None of this is in the body itself: all 129 points belong to 19 function items inside it that branch (a function literal at line 2454, a function literal at line 2578, a function literal at line 2608, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":2390}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ee37de4c193749f1d98728a0ad58399ec806445a97b007cc396303e97512ceb"}},{"ruleId":"D2","level":"warning","message":{"text":"ServiceController.statisticsAction (cognitive 128): ServiceController.statisticsAction has cognitive complexity 128 (threshold 15). Drivers by points: if/else 15 (75 pts), loops 8 (38 pts), ternaries 3 (15 pts) (nesting depth added 102). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/Api/ServiceController.php"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"be4b2b7a8127a06b14bab45e6949db598959d8575ee4f6ba9c1fd76f1b091718"}},{"ruleId":"D2","level":"warning","message":{"text":"keydown (cognitive 113): keydown has cognitive complexity 113 (threshold 15). Drivers by points: if/else 40 (84 pts), boolean chains 23, ternaries 3 (4 pts), loops 1 (2 pts) (nesting depth added 46). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":2827}}}],"partialFingerprints":{"codehealthFindingId/v1":"90706d7070fef7a1e3f53fed5245d4c893a3dc4e9f5d09d53b4127eec448e601"}},{"ruleId":"D2","level":"warning","message":{"text":"CPBackgroundProcess.sync_zone (cognitive 107): CPBackgroundProcess.sync_zone has cognitive complexity 107 (threshold 15). Drivers by points: if/else 23 (85 pts), boolean chains 12, loops 4 (10 pts) (nesting depth added 68). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/cp-background-process.py"},"region":{"startLine":140}}}],"partialFingerprints":{"codehealthFindingId/v1":"31b69ffaec85eb6a8d3272421a340428d8d0ae337aee56cb211f5c4dec2e45e6"}},{"ruleId":"D2","level":"warning","message":{"text":"OpenVPN.performValidation (cognitive 105): OpenVPN.performValidation has cognitive complexity 105 (threshold 15). Drivers by points: if/else 27 (82 pts), boolean chains 22, loops 1 (nesting depth added 55). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"70b039060cdf2ca04ef8d5779f969565a9ffcb4467f76cbd02cdb4fe3aabaff2"}},{"ruleId":"D2","level":"warning","message":{"text":"KeaDhcpv6.getConfigSubnets (cognitive 102): KeaDhcpv6.getConfigSubnets has cognitive complexity 102 (threshold 15). Drivers by points: if/else 32 (84 pts), loops 8 (18 pts) (nesting depth added 62). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php"},"region":{"startLine":328}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b4cae5c08c75f43db7c7098eecd54449e7c6912fdd91c538a67fbc44417b497"}},{"ruleId":"D2","level":"warning","message":{"text":"Monit.performValidation (cognitive 101): Monit.performValidation has cognitive complexity 101 (threshold 15). Drivers by points: if/else 13 (64 pts), boolean chains 16, match/switch 4 (15 pts), loops 2 (6 pts) (nesting depth added 66). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Monit/Monit.php"},"region":{"startLine":153}}}],"partialFingerprints":{"codehealthFindingId/v1":"848cb752ca3bcdb89d1233df8b3fe7b8adf75c4c58478c62716fa5474a3bd396"}},{"ruleId":"D2","level":"warning","message":{"text":"setFormData (cognitive 100): setFormData has cognitive complexity 100 (threshold 15). Drivers by points: if/else 28 (84 pts), loops 2 (9 pts), boolean chains 5, other 2 (nesting depth added 63). None of this is in the body itself: all 100 points belong to 5 function literals inside it that branch (lines 155, 196, 147, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense.js"},"region":{"startLine":146}}}],"partialFingerprints":{"codehealthFindingId/v1":"f4725b7ecf6c95a25b7fb082405518463558dc5f4357ae233704bf096123e1e8"}},{"ruleId":"D2","level":"warning","message":{"text":"OverviewController.parseIfInfo (cognitive 99): OverviewController.parseIfInfo has cognitive complexity 99 (threshold 15). Drivers by points: if/else 15 (52 pts), loops 11 (28 pts), ternaries 6 (14 pts), boolean chains 5 (nesting depth added 62). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/OverviewController.php"},"region":{"startLine":108}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e8f512893e0f2302ffbe478a9c1dac3dcce692289bec072f42e320fb13c3233"}},{"ruleId":"D2","level":"warning","message":{"text":"createView::scroll (cognitive 99): createView::scroll has cognitive complexity 99 (threshold 15). Drivers by points: if/else 27 (63 pts), boolean chains 18, ternaries 6 (14 pts), loops 2 (4 pts) (nesting depth added 46). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1227}}}],"partialFingerprints":{"codehealthFindingId/v1":"e59e0a9615fff7418f636101a4bf69962a5dcbfbacec417ab0fa80717287c849"}},{"ruleId":"D2","level":"warning","message":{"text":"setaddr.console_configure_ip_address (cognitive 96): setaddr.console_configure_ip_address has cognitive complexity 96 (threshold 15). Drivers by points: if/else 16 (51 pts), ternaries 8 (20 pts), loops 4 (13 pts), boolean chains 12 (nesting depth added 56). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/shell/setaddr.php"},"region":{"startLine":294}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3cfb3c08473726ae11871877857aaf59a192d2636fb4951099e21b356282f67"}},{"ruleId":"D2","level":"warning","message":{"text":"dnsbl_module.operate (cognitive 95): dnsbl_module.operate has cognitive complexity 95 (threshold 15). Drivers by points: if/else 15 (64 pts), loops 2 (13 pts), ternaries 3 (12 pts), boolean chains 6 (nesting depth added 69). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound-dnsbl/dnsbl_module.py"},"region":{"startLine":173}}}],"partialFingerprints":{"codehealthFindingId/v1":"b536ec87cd0eea17f993cbe2ab691e3e0f0612e3a3e2b2b1b7766943f28bdb9a"}},{"ruleId":"D2","level":"warning","message":{"text":"render (cognitive 95): render has cognitive complexity 95 (threshold 15). Drivers by points: if/else 21 (33 pts), ternaries 12 (28 pts), boolean chains 20, loops 7 (12 pts), match/switch 1 (2 pts) (nesting depth added 34). Of this number, 93 points are the body\u0027s own statements and 2 belong to 5 function items inside it that branch. This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/smoothie.js"},"region":{"startLine":839}}}],"partialFingerprints":{"codehealthFindingId/v1":"6fc68cb2aaf86d266727ea424606a8048ff2de570cf494b61aaddbb11c853d63"}},{"ruleId":"D2","level":"warning","message":{"text":"Swanctl.getConfig (cognitive 94): Swanctl.getConfig has cognitive complexity 94 (threshold 15). Drivers by points: if/else 17 (63 pts), loops 7 (24 pts), ternaries 1 (5 pts), boolean chains 2 (nesting depth added 67). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/Swanctl.php"},"region":{"startLine":211}}}],"partialFingerprints":{"codehealthFindingId/v1":"5353d1bd6853446c8b78af0d1467db72e4c53e4430802677b029b5ba37abff3e"}},{"ruleId":"D2","level":"warning","message":{"text":"FirmwareController.statusAction (cognitive 93): FirmwareController.statusAction has cognitive complexity 93 (threshold 15). Drivers by points: if/else 15 (33 pts), ternaries 6 (22 pts), boolean chains 15, loops 5 (14 pts), match/switch 2 (9 pts) (nesting depth added 50). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"b1d385efd856ada51aa3199631b5478b090862fecbaa3fdd29d5d21b8c8d5ee4"}},{"ruleId":"D2","level":"warning","message":{"text":"render (cognitive 90): render has cognitive complexity 90 (threshold 15). Drivers by points: if/else 24 (68 pts), boolean chains 12, ternaries 3 (6 pts), loops 1 (4 pts) (nesting depth added 50). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1714}}}],"partialFingerprints":{"codehealthFindingId/v1":"81e1e63d50946713aa368bcd4ffff06a590b52ed92eff736e610d1e17e0f5aec"}},{"ruleId":"D2","level":"warning","message":{"text":"certctl.cmd_rehash (cognitive 84): certctl.cmd_rehash has cognitive complexity 84 (threshold 15). Drivers by points: if/else 16 (50 pts), loops 10 (19 pts), boolean chains 8, ternaries 2 (7 pts) (nesting depth added 48). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/system/certctl.py"},"region":{"startLine":120}}}],"partialFingerprints":{"codehealthFindingId/v1":"4bc287f7a503474b78869c4cc4c5fb8aab9b12cc8ee15db285e892b43d32a2ca"}},{"ruleId":"D2","level":"warning","message":{"text":"qrcode::QRUtil::getLostPoint (cognitive 84): qrcode::QRUtil::getLostPoint has cognitive complexity 84 (threshold 15). Drivers by points: if/else 13 (46 pts), loops 12 (22 pts), boolean chains 16 (nesting depth added 43). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":1020}}}],"partialFingerprints":{"codehealthFindingId/v1":"c80095df58e55b11d69c12064470fd7306517a09f5eef0a1a640a788440ab8a1"}},{"ruleId":"D2","level":"warning","message":{"text":"TunnelController.searchPhase2Action (cognitive 83): TunnelController.searchPhase2Action has cognitive complexity 83 (threshold 15). Drivers by points: if/else 14 (43 pts), ternaries 5 (19 pts), loops 5 (15 pts), match/switch 1 (5 pts), boolean chains 1 (nesting depth added 57). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php"},"region":{"startLine":129}}}],"partialFingerprints":{"codehealthFindingId/v1":"9a752a6684c6cf011204981a281cea8c66b34a5bbfafa966f47613582cffa97c"}},{"ruleId":"D2","level":"warning","message":{"text":"MFP1_0_4.run (cognitive 82): MFP1_0_4.run has cognitive complexity 82 (threshold 15). Drivers by points: if/else 9 (36 pts), ternaries 6 (31 pts), loops 3 (12 pts), boolean chains 3 (nesting depth added 61). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_0_4.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"1b515bb24d4bd9d64f30a6106c005f9dd0822f5618de48c25317c629b2446b08"}},{"ruleId":"D2","level":"warning","message":{"text":"Gateways.getGateways (cognitive 81): Gateways.getGateways has cognitive complexity 81 (threshold 15). Drivers by points: if/else 14 (47 pts), loops 6 (17 pts), boolean chains 9, ternaries 2 (8 pts) (nesting depth added 50). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php"},"region":{"startLine":329}}}],"partialFingerprints":{"codehealthFindingId/v1":"915d59a96072b1058985957894f996184beb559073c45644b21d6c107a3c036b"}},{"ruleId":"D2","level":"warning","message":{"text":"RuleCache.search (cognitive 80): RuleCache.search has cognitive complexity 80 (threshold 15). Drivers by points: if/else 22 (58 pts), loops 8 (20 pts), boolean chains 2 (nesting depth added 48). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/suricata/lib/rulecache.py"},"region":{"startLine":342}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d78067d08c0cb9b3ee4719dbb2a350ac310313e69059b41e49443865709f75d"}},{"ruleId":"D2","level":"warning","message":{"text":"translateCompatOptions (cognitive 80): translateCompatOptions has cognitive complexity 80 (threshold 15). Drivers by points: if/else 39 (47 pts), other 27, boolean chains 2, loops 2, ternaries 1 (2 pts) (nesting depth added 9). Of this number, 78 points are the body\u0027s own statements and 2 belong to 7 function items inside it that branch. To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":244}}}],"partialFingerprints":{"codehealthFindingId/v1":"08bddb71e88e1350bd0bc14acb00c65ee7f06b3087ad39d2f1f238c265bf2e99"}},{"ruleId":"D2","level":"warning","message":{"text":"SettingsController.searchGatewayAction (cognitive 78): SettingsController.searchGatewayAction has cognitive complexity 78 (threshold 15). Drivers by points: if/else 13 (43 pts), loops 5 (15 pts), ternaries 4 (12 pts), boolean chains 8 (nesting depth added 48). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"c5d2af6d81007c8fed0dc8c333770cb84f9d6715af771f5b2a52913879310811"}},{"ruleId":"D2","level":"warning","message":{"text":"FirmwareController.infoAction (cognitive 77): FirmwareController.infoAction has cognitive complexity 77 (threshold 15). Drivers by points: if/else 14 (35 pts), ternaries 10 (18 pts), loops 10 (16 pts), boolean chains 8 (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php"},"region":{"startLine":801}}}],"partialFingerprints":{"codehealthFindingId/v1":"e718e9c2fd4ac2ab57771fb152f024d4680be6e603c0a2f0a66db0737233582b"}},{"ruleId":"D2","level":"warning","message":{"text":"RuleCache.list_local_changes (cognitive 75): RuleCache.list_local_changes has cognitive complexity 75 (threshold 15). Drivers by points: if/else 13 (54 pts), loops 6 (18 pts), boolean chains 2, ternaries 1 (nesting depth added 53). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/suricata/lib/rulecache.py"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"9fd5d5ededd88cdd3de73c56fe9e33bd987ebc0830cb9da38ea3a3ec737e8c33"}},{"ruleId":"D2","level":"warning","message":{"text":"unbound_watcher.run_watcher (cognitive 75): unbound_watcher.run_watcher has cognitive complexity 75 (threshold 15). Drivers by points: if/else 13 (39 pts), loops 9 (30 pts), error handling 1 (4 pts), boolean chains 2 (nesting depth added 50). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/unbound_watcher.py"},"region":{"startLine":115}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2de8acee857712bed22c6887f804269303dcdbc3ecac40fc426077920c482b5"}},{"ruleId":"D2","level":"warning","message":{"text":"NetworkInterface.performValidation (cognitive 72): NetworkInterface.performValidation has cognitive complexity 72 (threshold 15). Drivers by points: if/else 19 (50 pts), boolean chains 12, loops 3 (7 pts), ternaries 1 (3 pts) (nesting depth added 37). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php"},"region":{"startLine":200}}}],"partialFingerprints":{"codehealthFindingId/v1":"bdaebc8aaf13f724ab5d4e6e3c588c2cd43dbb3c8a97a364b3e97fc540b78bf8"}},{"ruleId":"D2","level":"warning","message":{"text":"CaController.setBaseHook (cognitive 71): CaController.setBaseHook has cognitive complexity 71 (threshold 15). Drivers by points: if/else 19 (57 pts), loops 2 (8 pts), boolean chains 3, ternaries 1 (2 pts), match/switch 1 (nesting depth added 45). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CaController.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"72040368ce3f189c35002153ffc0e6a48a736fc3084f43f7c7c9d2b722ffaaec"}},{"ruleId":"D2","level":"warning","message":{"text":"CrlController.getAction (cognitive 71): CrlController.getAction has cognitive complexity 71 (threshold 15). Drivers by points: if/else 7 (24 pts), loops 7 (23 pts), ternaries 5 (23 pts), boolean chains 1 (nesting depth added 51). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CrlController.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"0fc341657947893438944f146ed5adb871746f36508172a8b923bb216c5c760f"}},{"ruleId":"D2","level":"warning","message":{"text":"Vip.performValidation (cognitive 71): Vip.performValidation has cognitive complexity 71 (threshold 15). Drivers by points: if/else 18 (49 pts), boolean chains 14, loops 4 (8 pts) (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Vip.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"e770110e71867b73e30658ef6b8506f8677b725d1997a5068502b67ab9598df5"}},{"ruleId":"D2","level":"warning","message":{"text":"LDAP._authenticate (cognitive 69): LDAP._authenticate has cognitive complexity 69 (threshold 15). Drivers by points: if/else 17 (48 pts), loops 3 (13 pts), boolean chains 5, ternaries 1 (3 pts) (nesting depth added 43). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php"},"region":{"startLine":487}}}],"partialFingerprints":{"codehealthFindingId/v1":"1e5f0c92d426c0f0f68fd4e6c0f71d5d514c575c8e1a5d6cd74154ea0a77590a"}},{"ruleId":"D2","level":"warning","message":{"text":"SystemController.statusAction (cognitive 67): SystemController.statusAction has cognitive complexity 67 (threshold 15). Drivers by points: if/else 21 (60 pts), loops 2 (4 pts), ternaries 1 (3 pts) (nesting depth added 43). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/SystemController.php"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"114a81ac617316a69cfaedb0e257cf0550a971a4dbb99acf1a14e88c5ecbfd81"}},{"ruleId":"D2","level":"warning","message":{"text":"user_pass_verify.do_auth (cognitive 67): user_pass_verify.do_auth has cognitive complexity 67 (threshold 15). Drivers by points: if/else 19 (49 pts), ternaries 3 (10 pts), boolean chains 7, loops 1 (nesting depth added 37). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/openvpn/user_pass_verify.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"37bdea61fe32beacde5ef6de48154df0562101b05cece29c9eb8aeb6e82520a0"}},{"ruleId":"D2","level":"warning","message":{"text":"M1_0_0.run (cognitive 66): M1_0_0.run has cognitive complexity 66 (threshold 15). Drivers by points: if/else 8 (31 pts), loops 5 (21 pts), ternaries 3 (12 pts), boolean chains 2 (nesting depth added 48). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/Migrations/M1_0_0.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a2a22f1affa4f48a12b7f2bc3b327674e45ba572abd197fef5e58e8363fb091"}},{"ruleId":"D2","level":"warning","message":{"text":"ACL.loadUserGroupRights (cognitive 65): ACL.loadUserGroupRights has cognitive complexity 65 (threshold 15). Drivers by points: if/else 9 (37 pts), loops 8 (27 pts), boolean chains 1 (nesting depth added 47). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/ACL.php"},"region":{"startLine":90}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7856c53c239b723b48f0c68e91c3166029d5b89133bf4ab28a9342f2740f408"}},{"ruleId":"D2","level":"warning","message":{"text":"Swanctl.performValidation (cognitive 63): Swanctl.performValidation has cognitive complexity 63 (threshold 15). Drivers by points: if/else 17 (35 pts), boolean chains 16, loops 7 (8 pts), ternaries 1 (4 pts) (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/Swanctl.php"},"region":{"startLine":66}}}],"partialFingerprints":{"codehealthFindingId/v1":"6c3cd480e01c5309753a5de43ddc90d93886063adef72b392155514f67d27508"}},{"ruleId":"D2","level":"warning","message":{"text":"CertificatesField.actionPostLoadingEvent (cognitive 63): CertificatesField.actionPostLoadingEvent has cognitive complexity 63 (threshold 15). Drivers by points: if/else 12 (37 pts), loops 5 (12 pts), ternaries 5 (10 pts), boolean chains 4 (nesting depth added 37). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CertificatesField.php"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"157f90c972b0ccc7e2ac2dee6e2bc2bc42a1b0bc77b840f9c3559723aac31b1c"}},{"ruleId":"D2","level":"warning","message":{"text":"interfaces.validate_track6_idassoc6 (cognitive 63): interfaces.validate_track6_idassoc6 has cognitive complexity 63 (threshold 15). Drivers by points: if/else 12 (33 pts), ternaries 5 (19 pts), boolean chains 8, loops 1 (3 pts) (nesting depth added 37). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/interfaces.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"e03252d26943c082c921938f3ac8e91f7a2db1e16f2114cf7576fafbafbb6896"}},{"ruleId":"D2","level":"warning","message":{"text":"Radius.authenticate (cognitive 62): Radius.authenticate has cognitive complexity 62 (threshold 15). Drivers by points: if/else 13 (36 pts), match/switch 3 (10 pts), boolean chains 6, ternaries 2 (6 pts), loops 1 (4 pts) (nesting depth added 37). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php"},"region":{"startLine":512}}}],"partialFingerprints":{"codehealthFindingId/v1":"35e45b8fea4225b28a2c54137d3255e82fb07ec9e9e781bcd9ec0b46c7b6201a"}},{"ruleId":"D2","level":"warning","message":{"text":"ForwardRule.parseRdrRules (cognitive 62): ForwardRule.parseRdrRules has cognitive complexity 62 (threshold 15). Drivers by points: if/else 15 (40 pts), boolean chains 16, loops 3 (6 pts) (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/ForwardRule.php"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"ebaed8d1f9b8a01bba30b307ad63d48bc39e9407f3738f21cd7b53b2f82e4179"}},{"ruleId":"D2","level":"warning","message":{"text":"KeaDhcpv4.getConfigSubnets (cognitive 61): KeaDhcpv4.getConfigSubnets has cognitive complexity 61 (threshold 15). Drivers by points: if/else 17 (48 pts), loops 6 (13 pts) (nesting depth added 38). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":182}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae3a9e62f2c97047661feb85c4186daa68b092dfe02e00bc5cf3508c3190db22"}},{"ruleId":"D2","level":"warning","message":{"text":"Metadata.list_rules (cognitive 61): Metadata.list_rules has cognitive complexity 61 (threshold 15). Drivers by points: if/else 17 (45 pts), loops 4 (11 pts), boolean chains 5 (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/suricata/lib/metadata.py"},"region":{"startLine":74}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c5472d04cbffa2fbc60c582994c03b59f84592160a8683175fd1ff4ab4dc202"}},{"ruleId":"D2","level":"warning","message":{"text":"ExportController.downloadAction (cognitive 59): ExportController.downloadAction has cognitive complexity 59 (threshold 15). Drivers by points: if/else 15 (54 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 41). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ExportController.php"},"region":{"startLine":295}}}],"partialFingerprints":{"codehealthFindingId/v1":"7617b60a1af64f85834e385197fbd842f06167501db0628ca464de763d3de69a"}},{"ruleId":"D2","level":"warning","message":{"text":"ping.read_latest_stats (cognitive 59): ping.read_latest_stats has cognitive complexity 59 (threshold 15). Drivers by points: if/else 13 (51 pts), loops 2 (6 pts), boolean chains 2 (nesting depth added 42). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/interfaces/ping.py"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"a802daf27b8c1d509979a36fbefe6dbedf34a41b05a70e8935ea2997e543ee57"}},{"ruleId":"D2","level":"warning","message":{"text":"_registerEvents (cognitive 59): _registerEvents has cognitive complexity 59 (threshold 15). Drivers by points: if/else 28 (45 pts), boolean chains 5, loops 3 (5 pts), ternaries 2 (3 pts), other 1 (nesting depth added 20). Most of this is not in the body itself: 1 of the 59 points is its own statement and the rest belongs to 33 function items inside it that branch (title, (anonymous)::findTreeRowByIndex::walk, a function literal at line 918, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":720}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe1671512621dd5dce15b0738cd0a55a512dfa03f5bf205050bac3c6c0543ac0"}},{"ruleId":"D2","level":"warning","message":{"text":"AccessController.logonAction (cognitive 58): AccessController.logonAction has cognitive complexity 58 (threshold 15). Drivers by points: if/else 14 (49 pts), boolean chains 5, loops 1 (4 pts) (nesting depth added 38). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/Api/AccessController.php"},"region":{"startLine":235}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b5c1298657816d73f54c5b8bf3fc98b075367d306cb5783db73b19e8df4142e"}},{"ruleId":"D2","level":"warning","message":{"text":"InterfaceController.getVipStatusAction (cognitive 58): InterfaceController.getVipStatusAction has cognitive complexity 58 (threshold 15). Drivers by points: if/else 11 (29 pts), loops 7 (18 pts), ternaries 1 (7 pts), boolean chains 2, match/switch 1 (2 pts) (nesting depth added 36). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/InterfaceController.php"},"region":{"startLine":251}}}],"partialFingerprints":{"codehealthFindingId/v1":"1e3c3a96c7f891d0a418504dc8d8060a6285acc0f95c78356288580a55f59628"}},{"ruleId":"D2","level":"warning","message":{"text":"Menu.collect (cognitive 58): Menu.collect has cognitive complexity 58 (threshold 15). Drivers by points: if/else 10 (30 pts), loops 8 (15 pts), ternaries 4 (12 pts), boolean chains 1 (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Menu/Menu.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"002e40c3e112c0588f181f89a39e9f5d89be609eab4737276e8a03b86c1d80c7"}},{"ruleId":"D2","level":"warning","message":{"text":"ClientController.getServerInfoAction (cognitive 57): ClientController.getServerInfoAction has cognitive complexity 57 (threshold 15). Drivers by points: loops 6 (25 pts), if/else 5 (20 pts), ternaries 2 (12 pts) (nesting depth added 44). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Wireguard/Api/ClientController.php"},"region":{"startLine":172}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a3b418b7de7f1a0e120ccb681030984e853e271359a4622e67cbf992986d0c2"}},{"ruleId":"D2","level":"warning","message":{"text":"M1_0_1.run (cognitive 56): M1_0_1.run has cognitive complexity 56 (threshold 15). Drivers by points: ternaries 10 (34 pts), if/else 6 (14 pts), loops 3 (7 pts), boolean chains 1 (nesting depth added 36). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Unbound/Migrations/M1_0_1.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d357ee3ce86ecc5ae0b387f854255f48cf90f4399e2ed3497a263affea7e404"}},{"ruleId":"D2","level":"warning","message":{"text":"ApiMutableModelControllerBase.importCsv (cognitive 55): ApiMutableModelControllerBase.importCsv has cognitive complexity 55 (threshold 15). Drivers by points: if/else 9 (29 pts), loops 6 (16 pts), ternaries 4 (6 pts), boolean chains 4 (nesting depth added 32). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php"},"region":{"startLine":694}}}],"partialFingerprints":{"codehealthFindingId/v1":"c936f553bded12c93ed93ef7b97a5503dd0a14530bd2af9c9d0e5fafca0e70c3"}},{"ruleId":"D2","level":"warning","message":{"text":"Gateways.gatewayIterator (cognitive 55): Gateways.gatewayIterator has cognitive complexity 55 (threshold 15). Drivers by points: if/else 10 (37 pts), loops 5 (16 pts), boolean chains 2 (nesting depth added 38). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php"},"region":{"startLine":192}}}],"partialFingerprints":{"codehealthFindingId/v1":"9542c467b76d7361d3d50edb8539bac08a83459dac311bab163cacbde856bfc2"}},{"ruleId":"D2","level":"warning","message":{"text":"setaddr.add_gateway_to_config (cognitive 55): setaddr.add_gateway_to_config has cognitive complexity 55 (threshold 15). Drivers by points: if/else 14 (36 pts), ternaries 5 (9 pts), loops 3 (7 pts), boolean chains 3 (nesting depth added 30). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/shell/setaddr.php"},"region":{"startLine":199}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b385a3d0ac9628b1ced67f9aa9a171037296acc1256ebbdc5dcf391f5d37d73"}},{"ruleId":"D2","level":"warning","message":{"text":"setaddr.console_configure_dhcpd (cognitive 55): setaddr.console_configure_dhcpd has cognitive complexity 55 (threshold 15). Drivers by points: if/else 8 (25 pts), ternaries 6 (17 pts), loops 4 (9 pts), boolean chains 4 (nesting depth added 33). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/shell/setaddr.php"},"region":{"startLine":469}}}],"partialFingerprints":{"codehealthFindingId/v1":"909314750ce316c8a319947a3d76c6470e8cc87f6fd2e8a1cca9b23670076fa5"}},{"ruleId":"D2","level":"warning","message":{"text":"BaseFlowAggregator.get_top_data (cognitive 55): BaseFlowAggregator.get_top_data has cognitive complexity 55 (threshold 15). Drivers by points: if/else 11 (34 pts), loops 5 (19 pts), boolean chains 2 (nesting depth added 37). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/netflow/lib/aggregates/__init__.py"},"region":{"startLine":283}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f0286e9973cebb7a1635d91afe4d5aef9c66f1edc4a4f2996ac841d92c24fe5"}},{"ruleId":"D2","level":"warning","message":{"text":"Template.__find_filters (cognitive 55): Template.__find_filters has cognitive complexity 55 (threshold 15). Drivers by points: if/else 12 (45 pts), loops 4 (10 pts) (nesting depth added 39). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/template.py"},"region":{"startLine":150}}}],"partialFingerprints":{"codehealthFindingId/v1":"31f39b396896454fa2a55c81b6e69a5ea4195bed5d988fbed1a1de31bb7f6c50"}},{"ruleId":"D2","level":"warning","message":{"text":"FilterController.searchRuleAction (cognitive 54): FilterController.searchRuleAction has cognitive complexity 54 (threshold 15). Drivers by points: if/else 19 (29 pts), loops 7 (14 pts), boolean chains 8, ternaries 2 (3 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php"},"region":{"startLine":84}}}],"partialFingerprints":{"codehealthFindingId/v1":"49d6cc634354daeea7487ded2ec25eee87544b4af3310bfc10aaaddd28b82d58"}},{"ruleId":"D2","level":"warning","message":{"text":"SNatRule.parseNatRules (cognitive 54): SNatRule.parseNatRules has cognitive complexity 54 (threshold 15). Drivers by points: if/else 16 (45 pts), boolean chains 6, loops 2 (3 pts) (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/SNatRule.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c8d61798cec7b36894f6d7ad64e9de48529b4fb0b8209447f663c21f3f15858"}},{"ruleId":"D2","level":"warning","message":{"text":"AsyncDNSResolver.request_ittr (cognitive 54): AsyncDNSResolver.request_ittr has cognitive complexity 54 (threshold 15). Drivers by points: if/else 8 (31 pts), loops 6 (22 pts), boolean chains 1 (nesting depth added 39). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/__init__.py"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"038efa1d56d3af17cbfdad23f1929d6cd675a1a78c78463a2ac279d7f8c78d9c"}},{"ruleId":"D2","level":"warning","message":{"text":"AsyncDNSResolver.request_ittr (cognitive 53): AsyncDNSResolver.request_ittr has cognitive complexity 53 (threshold 15). Drivers by points: if/else 7 (30 pts), loops 6 (22 pts), boolean chains 1 (nesting depth added 39). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/base.py"},"region":{"startLine":112}}}],"partialFingerprints":{"codehealthFindingId/v1":"54df470e1a80807429b954d49d3af50606a81a51e0efd417b067c4158fcc257e"}},{"ruleId":"D2","level":"warning","message":{"text":"AssignmentController.reconfigureAction (cognitive 52): AssignmentController.reconfigureAction has cognitive complexity 52 (threshold 15). Drivers by points: if/else 8 (31 pts), loops 4 (21 pts) (nesting depth added 40). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/AssignmentController.php"},"region":{"startLine":140}}}],"partialFingerprints":{"codehealthFindingId/v1":"a1f4646847b2b5b03c60b7a0a06382d814fbdaf44dbb5c1c779ca1b6b5832a05"}},{"ruleId":"D2","level":"warning","message":{"text":"OpenVPN.getOverwrite (cognitive 52): OpenVPN.getOverwrite has cognitive complexity 52 (threshold 15). Drivers by points: if/else 13 (29 pts), loops 7 (15 pts), boolean chains 6, ternaries 1 (2 pts) (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php"},"region":{"startLine":234}}}],"partialFingerprints":{"codehealthFindingId/v1":"d549b01f80406a64de273471630e192f231464f402dd0e3a054586a080dfe0bb"}},{"ruleId":"D2","level":"warning","message":{"text":"M1_0_0.run (cognitive 52): M1_0_0.run has cognitive complexity 52 (threshold 15). Drivers by points: if/else 8 (24 pts), ternaries 6 (18 pts), loops 3 (9 pts), boolean chains 1 (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Migrations/M1_0_0.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"286b0990482bf581edb88c3fffc670c3ad805eb63fa575254eb472d34ad9b69d"}},{"ruleId":"D2","level":"warning","message":{"text":"UriParser.iter_addresses (cognitive 52): UriParser.iter_addresses has cognitive complexity 52 (threshold 15). Drivers by points: loops 6 (23 pts), if/else 10 (21 pts), error handling 2 (5 pts), boolean chains 3 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/uri.py"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"786ebe56430ff1010819d1f79900421a2a50c89b5d7c34b9fdb36a66132a15bf"}},{"ruleId":"D2","level":"warning","message":{"text":"Daemonize.start (cognitive 52): Daemonize.start has cognitive complexity 52 (threshold 15). Drivers by points: if/else 19 (30 pts), error handling 9 (18 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/daemonize.py"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"e31760a1e9a2dfb34e1926fd11c0ecc0c2fd7592affe4876013cb49a7ea270b9"}},{"ruleId":"D2","level":"warning","message":{"text":"Daemonize.start (cognitive 52): Daemonize.start has cognitive complexity 52 (threshold 15). Drivers by points: if/else 19 (30 pts), error handling 9 (18 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/site-python/daemonize.py"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"0486b4843c10dd25bbd18d73b28ae97950e3c042edd56f86f6784061c1fb31c7"}},{"ruleId":"D2","level":"warning","message":{"text":"FirewallController.statsAction (cognitive 51): FirewallController.statsAction has cognitive complexity 51 (threshold 15). Drivers by points: if/else 8 (22 pts), ternaries 4 (15 pts), loops 3 (11 pts), match/switch 1 (3 pts) (nesting depth added 35). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/FirewallController.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"80176afb726cd9c67119f0b484455420ff7612cc23572735e39c3576d739eb2f"}},{"ruleId":"D2","level":"warning","message":{"text":"ArrayField.importRecordSet (cognitive 51): ArrayField.importRecordSet has cognitive complexity 51 (threshold 15). Drivers by points: if/else 13 (25 pts), loops 6 (13 pts), ternaries 3 (8 pts), error handling 1 (3 pts), boolean chains 2 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ArrayField.php"},"region":{"startLine":315}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad2550ad2020731145e2ba38b5b87f690620babb73de1f83ac634447330e9a9e"}},{"ruleId":"D2","level":"warning","message":{"text":"InterfaceField.actionPostLoadingEvent (cognitive 51): InterfaceField.actionPostLoadingEvent has cognitive complexity 51 (threshold 15). Drivers by points: if/else 13 (34 pts), loops 5 (10 pts), boolean chains 4, ternaries 1 (3 pts) (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/InterfaceField.php"},"region":{"startLine":106}}}],"partialFingerprints":{"codehealthFindingId/v1":"5de1330474ed599177651ab8ec706ed8ebbcb61178a0fa62ebdd12136dfa5a14"}},{"ruleId":"D2","level":"warning","message":{"text":"JsonKeyValueStoreField.actionPostLoadingEvent (cognitive 51): JsonKeyValueStoreField.actionPostLoadingEvent has cognitive complexity 51 (threshold 15). Drivers by points: if/else 18 (36 pts), loops 2 (6 pts), ternaries 2 (5 pts), boolean chains 4 (nesting depth added 25). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/JsonKeyValueStoreField.php"},"region":{"startLine":123}}}],"partialFingerprints":{"codehealthFindingId/v1":"9818b7ea3a92d5801e032465ede48a4ee8c6d1df177bf974d4d38b5d8a935783"}},{"ruleId":"D2","level":"warning","message":{"text":"wg-service-control.wg_start (cognitive 50): wg-service-control.wg_start has cognitive complexity 50 (threshold 15). Drivers by points: ternaries 7 (19 pts), if/else 8 (17 pts), loops 6 (13 pts), boolean chains 1 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/wireguard/wg-service-control.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"b1b79fe5a7878c39a521f3be52466ef29bb3ae0b22739552a91687adc35b3590"}},{"ruleId":"D2","level":"warning","message":{"text":"Template._generate (cognitive 50): Template._generate has cognitive complexity 50 (threshold 15). Drivers by points: if/else 6 (28 pts), loops 5 (12 pts), error handling 2 (7 pts), boolean chains 3 (nesting depth added 34). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/template.py"},"region":{"startLine":219}}}],"partialFingerprints":{"codehealthFindingId/v1":"aa87ab9dbb00fc91b43b4ab0979ff25ba4cd13fbe5db8c328f2fff408299f7a8"}},{"ruleId":"D2","level":"warning","message":{"text":"NetworkinsightController.timeserieAction (cognitive 49): NetworkinsightController.timeserieAction has cognitive complexity 49 (threshold 15). Drivers by points: if/else 7 (27 pts), loops 5 (17 pts), ternaries 1 (5 pts) (nesting depth added 36). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/NetworkinsightController.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"2232ff140b8a9c65ab5c89344354ad15e9dd4db0ab739ed9c9100b8e95a790a8"}},{"ruleId":"D2","level":"warning","message":{"text":"TunnelController.searchPhase1Action (cognitive 49): TunnelController.searchPhase1Action has cognitive complexity 49 (threshold 15). Drivers by points: ternaries 7 (22 pts), if/else 7 (18 pts), loops 3 (9 pts) (nesting depth added 32). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4bd06564fc2e54eb469872cf5fa73d740e0a859618b8df6923cd213a8cd7446"}},{"ruleId":"D2","level":"warning","message":{"text":"MFP1_0_3.run (cognitive 49): MFP1_0_3.run has cognitive complexity 49 (threshold 15). Drivers by points: if/else 7 (26 pts), ternaries 2 (10 pts), loops 2 (8 pts), boolean chains 5 (nesting depth added 33). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_0_3.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"8152c2535935311cb55417ac74dd66d4ee99af05a8bea73b1c406237318db8f5"}},{"ruleId":"D2","level":"warning","message":{"text":"sqlite3_helper.check_and_repair (cognitive 49): sqlite3_helper.check_and_repair has cognitive complexity 49 (threshold 15). Drivers by points: if/else 6 (26 pts), loops 4 (17 pts), error handling 2 (5 pts), boolean chains 1 (nesting depth added 36). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/site-python/sqlite3_helper.py"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"da6c201f38810f658f2376c4116ad32fd758dba02b27ba7a50805b5ee06f17f5"}},{"ruleId":"D2","level":"warning","message":{"text":"Plugin (cognitive 49): Plugin has cognitive complexity 49 (threshold 15). Drivers by points: if/else 17 (32 pts), loops 3 (8 pts), boolean chains 4, ternaries 1 (3 pts), error handling 1 (2 pts) (nesting depth added 23). Of this number, 19 points are the body\u0027s own statements and 30 belong to one function literal inside it that branches. This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":3106}}}],"partialFingerprints":{"codehealthFindingId/v1":"4ce54d6262b94d141d5947047173727a44a82de24e83525b64800fed7eb67934"}},{"ruleId":"D2","level":"warning","message":{"text":"UIModelGrid.fetch (cognitive 48): UIModelGrid.fetch has cognitive complexity 48 (threshold 15). Drivers by points: if/else 9 (31 pts), loops 4 (13 pts), boolean chains 4 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Base/UIModelGrid.php"},"region":{"startLine":111}}}],"partialFingerprints":{"codehealthFindingId/v1":"8bd5c1a6475331fb002a46358ac9a1e03e20c251f0653727e49de263688e6b58"}},{"ruleId":"D2","level":"warning","message":{"text":"Store.parseX509 (cognitive 48): Store.parseX509 has cognitive complexity 48 (threshold 15). Drivers by points: if/else 10 (27 pts), loops 5 (13 pts), boolean chains 8 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Trust/Store.php"},"region":{"startLine":450}}}],"partialFingerprints":{"codehealthFindingId/v1":"1429b96fc3fea71a8077ef218da62960a48fab8bbf46cf11fb5faf8ec3b7afbe"}},{"ruleId":"D2","level":"warning","message":{"text":"IPPortField.getValidators (cognitive 48): IPPortField.getValidators has cognitive complexity 48 (threshold 15). Drivers by points: if/else 10 (34 pts), boolean chains 12, loops 1 (2 pts) (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/IPPortField.php"},"region":{"startLine":103}}}],"partialFingerprints":{"codehealthFindingId/v1":"973cb4f39bd7762b5d00eca5cffa26c1d5c9008f7d99150d130e13c7f0e5bf8c"}},{"ruleId":"D2","level":"warning","message":{"text":"OpenVPN.getInstanceById (cognitive 48): OpenVPN.getInstanceById has cognitive complexity 48 (threshold 15). Drivers by points: if/else 8 (25 pts), boolean chains 9, loops 4 (8 pts), ternaries 2 (6 pts) (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php"},"region":{"startLine":405}}}],"partialFingerprints":{"codehealthFindingId/v1":"f43d2b99a32c65c4af7115da44315bbd206818ce324dcaf52f9692eb1c144f95"}},{"ruleId":"D2","level":"warning","message":{"text":"M1_0_0.run (cognitive 48): M1_0_0.run has cognitive complexity 48 (threshold 15). Drivers by points: if/else 21 (44 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Radvd/Migrations/M1_0_0.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"d5c3b1ae06a92698a180ca93184cd133e33ffd40f49c9c907eed820ee0de877f"}},{"ruleId":"D2","level":"warning","message":{"text":"RuleCache.list_rules (cognitive 48): RuleCache.list_rules has cognitive complexity 48 (threshold 15). Drivers by points: if/else 7 (28 pts), loops 3 (10 pts), ternaries 1 (9 pts), boolean chains 1 (nesting depth added 36). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/suricata/lib/rulecache.py"},"region":{"startLine":159}}}],"partialFingerprints":{"codehealthFindingId/v1":"b0edb04d0712f5212a250f5f9ccaffccf8cdd822282127ac0eb21ff907f55e51"}},{"ruleId":"D2","level":"warning","message":{"text":"DNSBL.policy_match (cognitive 48): DNSBL.policy_match has cognitive complexity 48 (threshold 15). Drivers by points: if/else 12 (37 pts), boolean chains 7, loops 2 (4 pts) (nesting depth added 27). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound-dnsbl/lib/dnsbl.py"},"region":{"startLine":123}}}],"partialFingerprints":{"codehealthFindingId/v1":"7bc06e770eb9f0e63329d7f426d48d214f8e2855bd77cc154637806bbe711f60"}},{"ruleId":"D2","level":"warning","message":{"text":"DNatRule.parseNatRules (cognitive 47): DNatRule.parseNatRules has cognitive complexity 47 (threshold 15). Drivers by points: if/else 7 (22 pts), boolean chains 10, ternaries 2 (8 pts), loops 3 (7 pts) (nesting depth added 25). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/DNatRule.php"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"b41838d4f6fdfa8772493f2af6f7a177d86e2b0b363bb6a97897d375edd43953"}},{"ruleId":"D2","level":"warning","message":{"text":"diag_backup.restore_config_section (cognitive 47): diag_backup.restore_config_section has cognitive complexity 47 (threshold 15). Drivers by points: if/else 10 (29 pts), loops 7 (16 pts), boolean chains 1, error handling 1 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/diag_backup.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"8712d50b4b203428bf2e72ead91e2f2c3048683337ba5a28ce4f7e087cb4a5f7"}},{"ruleId":"D2","level":"warning","message":{"text":"RuleCache.parse_policies (cognitive 47): RuleCache.parse_policies has cognitive complexity 47 (threshold 15). Drivers by points: if/else 7 (31 pts), loops 4 (15 pts), boolean chains 1 (nesting depth added 35). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/suricata/lib/rulecache.py"},"region":{"startLine":130}}}],"partialFingerprints":{"codehealthFindingId/v1":"d5ad226b89ee797f2dc7727b6e7ac01e420cd0f8698cd64a8e7f0f8d3e7616d3"}},{"ruleId":"D2","level":"warning","message":{"text":"liHeight (cognitive 46): liHeight has cognitive complexity 46 (threshold 15). Drivers by points: ternaries 25, if/else 10 (12 pts), boolean chains 7, loops 1 (2 pts) (nesting depth added 3). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1878}}}],"partialFingerprints":{"codehealthFindingId/v1":"4968eebd01a9e1fa87163ca10ae8da5e3f5ac3d950194201f5806293c2653ad2"}},{"ruleId":"D2","level":"warning","message":{"text":"ApiControllerBase.searchRecordsetBase (cognitive 45): ApiControllerBase.searchRecordsetBase has cognitive complexity 45 (threshold 15). Drivers by points: if/else 10 (24 pts), loops 5 (12 pts), boolean chains 5, ternaries 3 (4 pts) (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"2c4f40914bc055d2aad9df524514052b991a47c740485638d4fdd7e807588393"}},{"ruleId":"D2","level":"warning","message":{"text":"CertController.setBaseHook (cognitive 45): CertController.setBaseHook has cognitive complexity 45 (threshold 15). Drivers by points: if/else 25 (43 pts), boolean chains 1, match/switch 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"020b8beb628128d2bd23d42b8a7a5fb599aff935134555cd1f7cba4719e99a3c"}},{"ruleId":"D2","level":"warning","message":{"text":"Config.toArray (cognitive 45): Config.toArray has cognitive complexity 45 (threshold 15). Drivers by points: if/else 14 (37 pts), loops 3 (6 pts), boolean chains 2 (nesting depth added 26). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Core/Config.php"},"region":{"startLine":97}}}],"partialFingerprints":{"codehealthFindingId/v1":"35e307e9a3a5edf4c1f95b4c93a3888d80a46dbe69cf74009bc5d9996c3b99b5"}},{"ruleId":"D2","level":"warning","message":{"text":"UniqueConstraint.validate (cognitive 45): UniqueConstraint.validate has cognitive complexity 45 (threshold 15). Drivers by points: if/else 7 (17 pts), loops 4 (14 pts), ternaries 3 (10 pts), boolean chains 4 (nesting depth added 27). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/Constraints/UniqueConstraint.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ca46d8f5b11545b241848673a31db99880020a79cd7d945d174661e40d49e09"}},{"ruleId":"D2","level":"warning","message":{"text":"M1_0_4.run (cognitive 45): M1_0_4.run has cognitive complexity 45 (threshold 15). Drivers by points: if/else 21 (32 pts), loops 5 (9 pts), boolean chains 4 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/Migrations/M1_0_4.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"26d143048e73aeb421a35b6e055a1ee04d2a7cb2562b924294b90002d2968d36"}},{"ruleId":"D2","level":"warning","message":{"text":"Firmware.getRepositoryOptions (cognitive 44): Firmware.getRepositoryOptions has cognitive complexity 44 (threshold 15). Drivers by points: if/else 8 (27 pts), loops 4 (13 pts), boolean chains 4 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/Firmware.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"d5fc6e292e779370b7015e66e7ded7ed1dbf8510b10a9afef27ef462eeeae3b4"}},{"ruleId":"D2","level":"warning","message":{"text":"GEOIP.process_zip (cognitive 44): GEOIP.process_zip has cognitive complexity 44 (threshold 15). Drivers by points: if/else 8 (27 pts), loops 5 (13 pts), boolean chains 3, error handling 1 (nesting depth added 27). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/geoip.py"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a02fcf31e0aa1b039c9446aa2560c7d27a4c5f261558432192a465728c9e2e9"}},{"ruleId":"D2","level":"warning","message":{"text":"Base.setGroupMembership (cognitive 43): Base.setGroupMembership has cognitive complexity 43 (threshold 15). Drivers by points: if/else 9 (21 pts), loops 6 (15 pts), boolean chains 6, ternaries 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Base.php"},"region":{"startLine":148}}}],"partialFingerprints":{"codehealthFindingId/v1":"f55acc47822cb4815cb2af4407975684f38e918b1e116ee54f8c33b5f659aa55"}},{"ruleId":"D2","level":"warning","message":{"text":"WLAN1_0_0.post (cognitive 43): WLAN1_0_0.post has cognitive complexity 43 (threshold 15). Drivers by points: if/else 8 (23 pts), ternaries 2 (10 pts), loops 4 (8 pts), boolean chains 2 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations/WLAN1_0_0.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"c2049c70e915898b25bfedfda257e5693787acb99bb379fc2cd9ff28f6dc9ea8"}},{"ruleId":"D2","level":"warning","message":{"text":"crl_fetch.main (cognitive 43): crl_fetch.main has cognitive complexity 43 (threshold 15). Drivers by points: if/else 6 (28 pts), loops 5 (12 pts), error handling 1 (3 pts) (nesting depth added 31). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/system/crl_fetch.py"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"79a099648f5e8e087d5fa6441b4ad100727bdb10bed4aea4c7c1d429e92641ef"}},{"ruleId":"D2","level":"warning","message":{"text":"ApiControllerBase.beforeExecuteRoute (cognitive 42): ApiControllerBase.beforeExecuteRoute has cognitive complexity 42 (threshold 15). Drivers by points: if/else 14 (39 pts), boolean chains 3 (nesting depth added 25). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php"},"region":{"startLine":289}}}],"partialFingerprints":{"codehealthFindingId/v1":"511fc464576c196b72061576416849072b54e99d1433f65ae8a96f1bb7420a41"}},{"ruleId":"D2","level":"warning","message":{"text":"ControllerBase.getFormGrid (cognitive 42): ControllerBase.getFormGrid has cognitive complexity 42 (threshold 15). Drivers by points: if/else 7 (22 pts), loops 3 (8 pts), ternaries 1 (6 pts), match/switch 1 (4 pts), boolean chains 2 (nesting depth added 28). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php"},"region":{"startLine":281}}}],"partialFingerprints":{"codehealthFindingId/v1":"27562fafd4de2cebe9796fcc82c6bba11f71fb255662439392aaf745dcba9f2c"}},{"ruleId":"D2","level":"warning","message":{"text":"NetworkinsightController.topAction (cognitive 42): NetworkinsightController.topAction has cognitive complexity 42 (threshold 15). Drivers by points: if/else 10 (33 pts), loops 2 (6 pts), boolean chains 3 (nesting depth added 27). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/NetworkinsightController.php"},"region":{"startLine":149}}}],"partialFingerprints":{"codehealthFindingId/v1":"f014579f491082baeca1089478eaae68518e5edba1c992633db9f77be8bab495"}},{"ruleId":"D2","level":"warning","message":{"text":"AliasController.importAction (cognitive 42): AliasController.importAction has cognitive complexity 42 (threshold 15). Drivers by points: if/else 9 (22 pts), loops 3 (11 pts), boolean chains 5, ternaries 1 (4 pts) (nesting depth added 24). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php"},"region":{"startLine":404}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d74492da9849109b20bf15cf82343b071c422740a5ed7f3c1f1b3d2b4847a5b"}},{"ruleId":"D2","level":"warning","message":{"text":"NetworkField.isValidInput (cognitive 42): NetworkField.isValidInput has cognitive complexity 42 (threshold 15). Drivers by points: if/else 11 (35 pts), boolean chains 4, match/switch 1 (2 pts), loops 1 (nesting depth added 25). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NetworkField.php"},"region":{"startLine":142}}}],"partialFingerprints":{"codehealthFindingId/v1":"479ff12ac7eb05d4eddfa7e41edde1a1518bf482da8200cd52d3bf2cc271a536"}},{"ruleId":"D2","level":"warning","message":{"text":"CPBackgroundProcess.initialize_fixed (cognitive 42): CPBackgroundProcess.initialize_fixed has cognitive complexity 42 (threshold 15). Drivers by points: if/else 8 (27 pts), loops 5 (12 pts), boolean chains 3 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/cp-background-process.py"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"b1e2111efaf798c664faeb0e04c919ea52d2652682091cbd948df57be11564ec"}},{"ruleId":"D2","level":"warning","message":{"text":"VlanInterfaceField.actionPostLoadingEvent (cognitive 41): VlanInterfaceField.actionPostLoadingEvent has cognitive complexity 41 (threshold 15). Drivers by points: if/else 6 (16 pts), ternaries 3 (12 pts), loops 3 (8 pts), boolean chains 5 (nesting depth added 24). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/VlanInterfaceField.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"29d4bd9fef457b647d767c075c3542a3b0ac496d50f8ae44d3a64712b56fbf94"}},{"ruleId":"D2","level":"warning","message":{"text":"KeaDdns.generateConfig (cognitive 41): KeaDdns.generateConfig has cognitive complexity 41 (threshold 15). Drivers by points: if/else 10 (33 pts), loops 2 (3 pts), ternaries 1 (3 pts), boolean chains 2 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"86c058f56cdf1fb51997dbc706f3fc0be7ff6f236fb76267c11ad3320b5becef"}},{"ruleId":"D2","level":"warning","message":{"text":"M1_0_13.run (cognitive 41): M1_0_13.run has cognitive complexity 41 (threshold 15). Drivers by points: loops 8 (21 pts), if/else 7 (18 pts), boolean chains 2 (nesting depth added 24). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Unbound/Migrations/M1_0_13.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"c639210321f71ebf4bb3a026fc6582f217ceafb3666743d73fe1964a523aedc6"}},{"ruleId":"D2","level":"warning","message":{"text":"LeasesController.searchAction (cognitive 40): LeasesController.searchAction has cognitive complexity 40 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 6 (10 pts), ternaries 4 (8 pts), boolean chains 6 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api/LeasesController.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e98d5fbc4c3ca8df7e509c121042cf31cc0602bc1ef4c1dd868f2d8a0eac658"}},{"ruleId":"D2","level":"warning","message":{"text":"Rule.reader (cognitive 40): Rule.reader has cognitive complexity 40 (threshold 15). Drivers by points: loops 7 (18 pts), if/else 6 (15 pts), ternaries 4, boolean chains 3 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/Rule.php"},"region":{"startLine":262}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe2cc7bfb93196e7a9de82a628e8020cc07394105950624429a9c047e8d63d6a"}},{"ruleId":"D2","level":"warning","message":{"text":"update-crl-fetch.main (cognitive 40): update-crl-fetch.main has cognitive complexity 40 (threshold 15). Drivers by points: if/else 8 (19 pts), loops 5 (9 pts), ternaries 2 (7 pts), error handling 2 (4 pts), boolean chains 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/system/update-crl-fetch.py"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"63d4bd4a875ddfa6682d32511b8db70713971949512fcbbcce69832a6b7458e2"}},{"ruleId":"D2","level":"warning","message":{"text":"ServiceController.searchSessionsAction (cognitive 39): ServiceController.searchSessionsAction has cognitive complexity 39 (threshold 15). Drivers by points: if/else 8 (22 pts), loops 7 (15 pts), boolean chains 2 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ServiceController.php"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"7bbb9653b1838d892763517840c67b1711571bf4eab805accde402b0331aeccd"}},{"ruleId":"D2","level":"warning","message":{"text":"BaseModel.parseXml (cognitive 39): BaseModel.parseXml has cognitive complexity 39 (threshold 15). Drivers by points: if/else 9 (29 pts), loops 3 (6 pts), ternaries 2 (4 pts) (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php"},"region":{"startLine":255}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f3830e2291d0d94fbbfc7108c7d7984af65f2fdb08fa19a6460dec1489ed068"}},{"ruleId":"D2","level":"warning","message":{"text":"BaseModel.runMigrations (cognitive 39): BaseModel.runMigrations has cognitive complexity 39 (threshold 15). Drivers by points: if/else 7 (17 pts), error handling 2 (8 pts), loops 3 (7 pts), ternaries 1 (4 pts), boolean chains 3 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php"},"region":{"startLine":882}}}],"partialFingerprints":{"codehealthFindingId/v1":"aac0873124d555564f57ce7e80f92ff8c752ecc33153f16836930db9e86e7acc"}},{"ruleId":"D2","level":"warning","message":{"text":"M1_0_0.run (cognitive 39): M1_0_0.run has cognitive complexity 39 (threshold 15). Drivers by points: if/else 7 (24 pts), loops 4 (14 pts), boolean chains 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/M1_0_0.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"61c509ec2f7d60695866c404f8ac6e01bfa261f82c3521ee08b1fdf681a317ed"}},{"ruleId":"D2","level":"warning","message":{"text":"Syslog.performValidation (cognitive 39): Syslog.performValidation has cognitive complexity 39 (threshold 15). Drivers by points: if/else 7 (29 pts), ternaries 1 (6 pts), boolean chains 3, loops 1 (nesting depth added 27). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Syslog/Syslog.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"04049fe6fc5ca9158e39ab729fcaec7330541aec362935d77c535bc07453f140"}},{"ruleId":"D2","level":"warning","message":{"text":"Alias.resolve (cognitive 39): Alias.resolve has cognitive complexity 39 (threshold 15). Drivers by points: if/else 9 (22 pts), loops 2 (9 pts), ternaries 1 (4 pts), error handling 1 (3 pts), boolean chains 1 (nesting depth added 25). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/__init__.py"},"region":{"startLine":199}}}],"partialFingerprints":{"codehealthFindingId/v1":"b21e5a9898a606c78d1f2e12dd2809f94e137af30e5b9f8a3e5314478b6415e4"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 39): (anonymous) has cognitive complexity 39 (threshold 15). Drivers by points: if/else 18 (25 pts), boolean chains 10, ternaries 1 (3 pts), other 1 (nesting depth added 9). Most of this is not in the body itself: 11 of the 39 points are its own statements and the rest belongs to 26 function items inside it that branch (a function literal at line 181, opnsense_sidebar_toggle, mouseenter, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_theme.js"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"305ff6f207d47a667971784b4f0c8bf8d63ef107d98160310d3fd5ad48f4ae6e"}},{"ruleId":"D2","level":"warning","message":{"text":"IPsec.traverseItems (cognitive 38): IPsec.traverseItems has cognitive complexity 38 (threshold 15). Drivers by points: if/else 6 (23 pts), loops 3 (9 pts), ternaries 2 (5 pts), boolean chains 1 (nesting depth added 26). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/IPsec.php"},"region":{"startLine":188}}}],"partialFingerprints":{"codehealthFindingId/v1":"81cfbc2f6a460684cbfb2b7b1f18c0ec7d66ede4667ca42cffd9d3fd603d0c5b"}},{"ruleId":"D2","level":"warning","message":{"text":"CAsField.actionPostLoadingEvent (cognitive 38): CAsField.actionPostLoadingEvent has cognitive complexity 38 (threshold 15). Drivers by points: if/else 9 (30 pts), loops 2 (4 pts), ternaries 2 (4 pts) (nesting depth added 25). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CAsField.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"5064d59c218c26f896e2e31734ae19f4d65f3a6d0e80a63cf590767b6138930f"}},{"ruleId":"D2","level":"warning","message":{"text":"Daemonize.start (cognitive 38): Daemonize.start has cognitive complexity 38 (threshold 15). Drivers by points: if/else 15 (21 pts), error handling 8 (15 pts), loops 1 (2 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/lib/daemonize.py"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a7643cc3913da25655e6446db75a4e1f4e82652fc8242bcd9855e91918941ef"}},{"ruleId":"D2","level":"warning","message":{"text":"states.query_top (cognitive 38): states.query_top has cognitive complexity 38 (threshold 15). Drivers by points: if/else 8 (17 pts), ternaries 3 (11 pts), boolean chains 5, loops 3 (5 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/states.py"},"region":{"startLine":225}}}],"partialFingerprints":{"codehealthFindingId/v1":"3671b7c04246546f1994262892f8a3dc21fec1021084b28933485dc88d2f1cdd"}},{"ruleId":"D2","level":"warning","message":{"text":"ovpn_status.main (cognitive 38): ovpn_status.main has cognitive complexity 38 (threshold 15). Drivers by points: if/else 9 (28 pts), ternaries 2 (5 pts), boolean chains 4, loops 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/openvpn/ovpn_status.py"},"region":{"startLine":112}}}],"partialFingerprints":{"codehealthFindingId/v1":"368d6111d6bc33b1b65d2ffd34aa0dbeb4cf492d192242c41d4eac1104d8a6dd"}},{"ruleId":"D2","level":"warning","message":{"text":"clean (cognitive 38): clean has cognitive complexity 38 (threshold 15). Drivers by points: if/else 13 (26 pts), boolean chains 6, loops 2 (5 pts), ternaries 1 (nesting depth added 16). Most of this is not in the body itself: 2 of the 38 points are its own statements and the rest belongs to 4 function literals inside it that branch (lines 481, 526, 510, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/chartjs-plugin-streaming.js"},"region":{"startLine":473}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f71baa3625d93dbd203eceda2a6dfa4eae1b48356e237d0d909874ffeace40c"}},{"ruleId":"D2","level":"warning","message":{"text":"SettingsController.searchInstalledRulesAction (cognitive 37): SettingsController.searchInstalledRulesAction has cognitive complexity 37 (threshold 15). Drivers by points: if/else 12 (22 pts), loops 3 (8 pts), boolean chains 4, ternaries 1 (3 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IDS/Api/SettingsController.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"6fced751908e5782e97071ce10892e98f3aeef230b2e5e476bfeb6f32c3920dd"}},{"ruleId":"D2","level":"warning","message":{"text":"SettingsController.setRulesetpropertiesAction (cognitive 37): SettingsController.setRulesetpropertiesAction has cognitive complexity 37 (threshold 15). Drivers by points: if/else 8 (27 pts), loops 2 (8 pts), boolean chains 2 (nesting depth added 25). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IDS/Api/SettingsController.php"},"region":{"startLine":282}}}],"partialFingerprints":{"codehealthFindingId/v1":"bde318eb3b2ffa9cf623392c20d8294fbe8bb7f8a3beefb05e054b32cafd65e2"}},{"ruleId":"D2","level":"warning","message":{"text":"LaggSettingsController.delItemAction (cognitive 37): LaggSettingsController.delItemAction has cognitive complexity 37 (threshold 15). Drivers by points: if/else 5 (12 pts), ternaries 4 (12 pts), loops 5 (11 pts), boolean chains 2 (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/LaggSettingsController.php"},"region":{"startLine":126}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d2495552d11754a58493b4ea55caed7058065cbff46141a2674519d91ae89a6"}},{"ruleId":"D2","level":"warning","message":{"text":"ModelRelationField.loadModelOptions (cognitive 37): ModelRelationField.loadModelOptions has cognitive complexity 37 (threshold 15). Drivers by points: if/else 5 (16 pts), loops 4 (14 pts), boolean chains 4, ternaries 1 (3 pts) (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php"},"region":{"startLine":101}}}],"partialFingerprints":{"codehealthFindingId/v1":"08ca47a43823fa2a785749815325e135e1de884a34dc87a93e425fe69adb5a02"}},{"ruleId":"D2","level":"warning","message":{"text":"GatewayGroups.performValidation (cognitive 37): GatewayGroups.performValidation has cognitive complexity 37 (threshold 15). Drivers by points: if/else 6 (23 pts), loops 4 (12 pts), boolean chains 2 (nesting depth added 25). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"02eb305380f8103cb16638caa64c1ca7a606063279f19d626343258241d3cd4c"}},{"ruleId":"D2","level":"warning","message":{"text":"InterfaceController.getSocketStatisticsAction (cognitive 36): InterfaceController.getSocketStatisticsAction has cognitive complexity 36 (threshold 15). Drivers by points: if/else 7 (20 pts), ternaries 2 (8 pts), loops 2 (5 pts), boolean chains 3 (nesting depth added 22). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/InterfaceController.php"},"region":{"startLine":386}}}],"partialFingerprints":{"codehealthFindingId/v1":"9a796215da8b26f01fc15f81f466865f12b6ebcdcad51356039e9ef0d88f4f70"}},{"ruleId":"D2","level":"warning","message":{"text":"ConnectionsController.setConnectionAction (cognitive 36): ConnectionsController.setConnectionAction has cognitive complexity 36 (threshold 15). Drivers by points: loops 4 (17 pts), if/else 6 (16 pts), boolean chains 3 (nesting depth added 23). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/ConnectionsController.php"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"64e0e38dfa17d2b5c4fb88aa5d93610b3e2592b8b788f448aabe09cd3a4b387b"}},{"ruleId":"D2","level":"warning","message":{"text":"Config.fromArray (cognitive 36): Config.fromArray has cognitive complexity 36 (threshold 15). Drivers by points: if/else 12 (24 pts), loops 3 (8 pts), boolean chains 4 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Core/Config.php"},"region":{"startLine":191}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe97f766d291d42c9f3f9ab6a81128e6178218784d28c28ae5bc6c2b2ed6b350"}},{"ruleId":"D2","level":"warning","message":{"text":"BaseModel.getFieldObject (cognitive 36): BaseModel.getFieldObject has cognitive complexity 36 (threshold 15). Drivers by points: if/else 16 (29 pts), loops 3 (7 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php"},"region":{"startLine":161}}}],"partialFingerprints":{"codehealthFindingId/v1":"f515a18cf965ae31f887812b40d808806d69222cb3986ad29d0593dd3510830c"}},{"ruleId":"D2","level":"warning","message":{"text":"Unbound.performValidation (cognitive 36): Unbound.performValidation has cognitive complexity 36 (threshold 15). Drivers by points: if/else 9 (23 pts), boolean chains 6, loops 3 (4 pts), ternaries 1 (3 pts) (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Unbound/Unbound.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"14f241628846b64ce124ade5e01c8aaa31c328508d7bd8f4685206011dfe7203"}},{"ruleId":"D2","level":"warning","message":{"text":"(anonymous) (cognitive 36): (anonymous) has cognitive complexity 36 (threshold 15). Drivers by points: if/else 15 (19 pts), boolean chains 9, ternaries 7 (8 pts) (nesting depth added 5). Most of this is not in the body itself: 8 of the 36 points are its own statements and the rest belongs to 13 function items inside it that branch ((anonymous)::success, a function literal at line 69, a function literal at line 51, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_favorites.js"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"5329f498bf6363d37a94fe1b544a2e05d24bd168f79d8244da789cc2bdad1232"}},{"ruleId":"D2","level":"warning","message":{"text":"getFormData (cognitive 36): getFormData has cognitive complexity 36 (threshold 15). Drivers by points: if/else 17 (31 pts), ternaries 1 (3 pts), boolean chains 2 (nesting depth added 16). None of this is in the body itself: all 36 points belong to 3 function literals inside it that branch (lines 77, 69, 99). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense.js"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"d250ebbdbd187dd3d5db6ae86dfb59c757f986e6bee9330bc653e7fcd3a08e61"}},{"ruleId":"D2","level":"warning","message":{"text":"SessionsController.searchPhase1Action (cognitive 35): SessionsController.searchPhase1Action has cognitive complexity 35 (threshold 15). Drivers by points: loops 6 (19 pts), if/else 7 (16 pts) (nesting depth added 22). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SessionsController.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"99e4bd51e8ff49caffd11b80343c93bbb2953ad3f8cf2f4a2fd8735f6f3eefd9"}},{"ruleId":"D2","level":"warning","message":{"text":"Plugin.setGatewayGroups (cognitive 35): Plugin.setGatewayGroups has cognitive complexity 35 (threshold 15). Drivers by points: if/else 6 (21 pts), boolean chains 5, loops 2 (5 pts), ternaries 1 (4 pts) (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/Plugin.php"},"region":{"startLine":133}}}],"partialFingerprints":{"codehealthFindingId/v1":"b7463dde9ed594dbd258421c00e7ad66f7a9de9c6850f41beadc3128db9ad4d2"}},{"ruleId":"D2","level":"warning","message":{"text":"Rule.mapAddressInfo (cognitive 35): Rule.mapAddressInfo has cognitive complexity 35 (threshold 15). Drivers by points: if/else 8 (20 pts), boolean chains 8, ternaries 2 (6 pts), loops 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/Rule.php"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"1210226e9997a05ce389ae42b44578b3ba4b013fb32507b0f5546e370de2b41d"}},{"ruleId":"D2","level":"warning","message":{"text":"PlainOpenVPN.openvpnConfParts (cognitive 35): PlainOpenVPN.openvpnConfParts has cognitive complexity 35 (threshold 15). Drivers by points: if/else 17 (23 pts), boolean chains 5, loops 3 (5 pts), match/switch 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/OpenVPN/PlainOpenVPN.php"},"region":{"startLine":92}}}],"partialFingerprints":{"codehealthFindingId/v1":"246eaeb143ffdf5749f9b247b28e1088b42b94bda7305a796745fff4647fe6a6"}},{"ruleId":"D2","level":"warning","message":{"text":"JsonAuditField.setValue (cognitive 35): JsonAuditField.setValue has cognitive complexity 35 (threshold 15). Drivers by points: if/else 8 (22 pts), loops 3 (11 pts), boolean chains 2 (nesting depth added 22). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/JsonAuditField.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"3ddc2fe3e68c28af1d5dd9c22ddd7a8ea1476466ed5f2761eb668d99158bf994"}},{"ruleId":"D2","level":"warning","message":{"text":"TunableField.actionPostLoadingEvent (cognitive 35): TunableField.actionPostLoadingEvent has cognitive complexity 35 (threshold 15). Drivers by points: if/else 10 (27 pts), loops 3 (7 pts), boolean chains 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/FieldTypes/TunableField.php"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"c6634783f4c0550070572faefd56e6d32dfe2124a58ba06b38c6400d235cc79e"}},{"ruleId":"D2","level":"warning","message":{"text":"FilterRuleContainerField.serialize (cognitive 35): FilterRuleContainerField.serialize has cognitive complexity 35 (threshold 15). Drivers by points: if/else 17 (29 pts), ternaries 1 (3 pts), loops 2, boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/FilterRuleField.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"dfb26920309bbe8ef13069e087db6b2421fe061104f9070cd00c9f5924e88f4a"}},{"ruleId":"D2","level":"warning","message":{"text":"M1_0_6.run (cognitive 35): M1_0_6.run has cognitive complexity 35 (threshold 15). Drivers by points: if/else 8 (22 pts), loops 2 (6 pts), ternaries 2 (6 pts), boolean chains 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Unbound/Migrations/M1_0_6.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"d122b292b7901e5672825cd9f933669938bbebca4ca89b64f87d70fcf60fa41d"}},{"ruleId":"D2","level":"warning","message":{"text":"Downloader.fetch (cognitive 35): Downloader.fetch has cognitive complexity 35 (threshold 15). Drivers by points: if/else 14 (27 pts), loops 1 (4 pts), error handling 1 (3 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/suricata/lib/downloader.py"},"region":{"startLine":90}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ed9b287b7166252ad77b2b911cb1625952071551653ca996f5df61d5488c043"}},{"ruleId":"D2","level":"warning","message":{"text":"SimpleFileUploadDlg (cognitive 35): SimpleFileUploadDlg has cognitive complexity 35 (threshold 15). Drivers by points: if/else 11 (21 pts), loops 5 (12 pts), boolean chains 2 (nesting depth added 17). None of this is in the body itself: all 35 points belong to 8 function items inside it that branch (a function literal at line 1111, a function literal at line 1073, construct::(anonymous)::(anonymous)::onload, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":1045}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce7061ac19479c820525fa5ce57cf6957cc758816909c30e080bf5cfe5a945b6"}},{"ruleId":"D2","level":"warning","message":{"text":"_parseColumns (cognitive 35): _parseColumns has cognitive complexity 35 (threshold 15). Drivers by points: if/else 12 (22 pts), other 6, boolean chains 3, ternaries 1 (3 pts), loops 1 (nesting depth added 12). Of this number, 31 points are the body\u0027s own statements and 4 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":536}}}],"partialFingerprints":{"codehealthFindingId/v1":"254afc194c8d9265ee7110f3ff29af04c2e56766849645017a4d2fe74b45b0bd"}},{"ruleId":"D2","level":"warning","message":{"text":"SessionsController.searchPhase2Action (cognitive 34): SessionsController.searchPhase2Action has cognitive complexity 34 (threshold 15). Drivers by points: if/else 6 (19 pts), loops 5 (14 pts), boolean chains 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SessionsController.php"},"region":{"startLine":112}}}],"partialFingerprints":{"codehealthFindingId/v1":"2c6d9f52016ce75b9ffd8293f790dbcd863d4a788414b1f4177729357676c1f9"}},{"ruleId":"D2","level":"warning","message":{"text":"TunnelController.togglePhase1Action (cognitive 34): TunnelController.togglePhase1Action has cognitive complexity 34 (threshold 15). Drivers by points: if/else 6 (18 pts), ternaries 2 (12 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 24). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php"},"region":{"startLine":299}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e6d90a4e166325389dc5e8be62d7d734edc321b75ca7109dbe5a5d74f726784"}},{"ruleId":"D2","level":"warning","message":{"text":"DNat.performValidation (cognitive 34): DNat.performValidation has cognitive complexity 34 (threshold 15). Drivers by points: if/else 5 (16 pts), boolean chains 7, loops 3 (7 pts), ternaries 1 (4 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/DNat.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f46531bf5b586588bf312d225a594ea84384df7c31fd3a867211622113c7a63"}},{"ruleId":"D2","level":"warning","message":{"text":"AuthGroup._update (cognitive 34): AuthGroup._update has cognitive complexity 34 (threshold 15). Drivers by points: if/else 5 (21 pts), loops 5 (10 pts), error handling 2, boolean chains 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/auth.py"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"88fcceeda8a495aec1d429cf4f3dc59b69ada9091763715e87f31df62a8fbd9d"}},{"ruleId":"D2","level":"warning","message":{"text":"DefaultBlocklistHandler.blocklists_iter (cognitive 34): DefaultBlocklistHandler.blocklists_iter has cognitive complexity 34 (threshold 15). Drivers by points: if/else 6 (20 pts), loops 7 (14 pts) (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/blocklists/default_bl.py"},"region":{"startLine":151}}}],"partialFingerprints":{"codehealthFindingId/v1":"639ae3756501d10a9d4c1a76d08ad82d62e95e40ce04ebed537b323bda667ca9"}},{"ruleId":"D2","level":"warning","message":{"text":"opnsense_legacy.hook_firewall_categories (cognitive 34): opnsense_legacy.hook_firewall_categories has cognitive complexity 34 (threshold 15). Drivers by points: if/else 14 (23 pts), boolean chains 4, loops 2 (4 pts), ternaries 1 (3 pts) (nesting depth added 13). None of this is in the body itself: all 34 points belong to 5 function literals inside it that branch (lines 186, 197, 248, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/javascript/opnsense_legacy.js"},"region":{"startLine":184}}}],"partialFingerprints":{"codehealthFindingId/v1":"b00db8ce50cdb9f3a00c40a759d0cd2533c58e4ea3ed435fc41ce0d94b9b62df"}},{"ruleId":"D2","level":"warning","message":{"text":"FilterBaseController.moveRuleBeforeBase (cognitive 33): FilterBaseController.moveRuleBeforeBase has cognitive complexity 33 (threshold 15). Drivers by points: if/else 13 (23 pts), ternaries 2 (4 pts), boolean chains 3, loops 3 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php"},"region":{"startLine":338}}}],"partialFingerprints":{"codehealthFindingId/v1":"407fc8d59ae925b8d3815b3c17db5ec2ad8cfd6321b29fc2416bc5c3643203a9"}},{"ruleId":"D2","level":"warning","message":{"text":"LDAP.searchUsers (cognitive 33): LDAP.searchUsers has cognitive complexity 33 (threshold 15). Drivers by points: if/else 9 (25 pts), loops 2 (7 pts), boolean chains 1 (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php"},"region":{"startLine":400}}}],"partialFingerprints":{"codehealthFindingId/v1":"6688ff4a822744ba2a04fa8df195d02a487889bdee28af82ea1f30d006d515a7"}},{"ruleId":"D2","level":"warning","message":{"text":"DHCRelay.performValidation (cognitive 33): DHCRelay.performValidation has cognitive complexity 33 (threshold 15). Drivers by points: if/else 9 (24 pts), loops 4 (5 pts), boolean chains 4 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/DHCRelay/DHCRelay.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"d881f3ede13ffdaa4ccbf925f9bf038b312c3adf47517418f651d0c16a4bad7f"}},{"ruleId":"D2","level":"warning","message":{"text":"GatewayGroups.getActiveGroups (cognitive 33): GatewayGroups.getActiveGroups has cognitive complexity 33 (threshold 15). Drivers by points: if/else 5 (17 pts), ternaries 2 (10 pts), loops 3 (6 pts) (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.php"},"region":{"startLine":223}}}],"partialFingerprints":{"codehealthFindingId/v1":"44270b602c128b862294f29e00b827674df81fdeceac4bfc8d1ef8ff44cd7160"}},{"ruleId":"D2","level":"warning","message":{"text":"base.net_wildcard_iterator (cognitive 33): base.net_wildcard_iterator has cognitive complexity 33 (threshold 15). Drivers by points: if/else 8 (21 pts), loops 3 (10 pts), error handling 1 (2 pts) (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/base.py"},"region":{"startLine":161}}}],"partialFingerprints":{"codehealthFindingId/v1":"f86fb3d01c59a568148f1100b2ba32002853ca1c0a268042af49ce1fb4dd40cd"}},{"ruleId":"D2","level":"warning","message":{"text":"UIBootgrid._internalFormatters (cognitive 33): UIBootgrid._internalFormatters has cognitive complexity 33 (threshold 15). Drivers by points: if/else 16 (17 pts), ternaries 6 (8 pts), boolean chains 7, loops 1 (nesting depth added 3). None of this is in the body itself: all 33 points belong to 10 function literals inside it that branch (lines 1947, 2050, 2020, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1923}}}],"partialFingerprints":{"codehealthFindingId/v1":"16096d071c7baa9f0ed99aa024bdcd929f1b6a7c9822553efe3917bfc9d1cf8a"}},{"ruleId":"D2","level":"warning","message":{"text":"_parseGridView (cognitive 33): _parseGridView has cognitive complexity 33 (threshold 15). Drivers by points: other 8, if/else 4 (7 pts), ternaries 2 (7 pts), boolean chains 6, loops 2 (5 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":476}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a9470d93fb038000be804cd06f993cb6db40b7e258173d38fce0d54b1707d3b"}},{"ruleId":"D2","level":"warning","message":{"text":"M1_0_1.run (cognitive 32): M1_0_1.run has cognitive complexity 32 (threshold 15). Drivers by points: if/else 8 (17 pts), loops 4 (9 pts), ternaries 1 (4 pts), boolean chains 2 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/Migrations/M1_0_1.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"3491e2e6bee4e09ccd4520cd3e7b3ef6a8d098633c4a467dbe0b730ab5ebd8a9"}},{"ruleId":"D2","level":"warning","message":{"text":"NetworkInterface.serializeToConfig (cognitive 32): NetworkInterface.serializeToConfig has cognitive complexity 32 (threshold 15). Drivers by points: if/else 7 (16 pts), loops 5 (7 pts), ternaries 2 (7 pts), boolean chains 2 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php"},"region":{"startLine":120}}}],"partialFingerprints":{"codehealthFindingId/v1":"5eb970d77d5e9e12c82fa44acd901cbbfa359c08ab323b58823da16a382802cd"}},{"ruleId":"D2","level":"warning","message":{"text":"FlowParser.__iter__ (cognitive 32): FlowParser.__iter__ has cognitive complexity 32 (threshold 15). Drivers by points: if/else 12 (26 pts), boolean chains 3, loops 2 (3 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/netflow/lib/flowparser.py"},"region":{"startLine":130}}}],"partialFingerprints":{"codehealthFindingId/v1":"b03d556b90dd9ead84e5060e127c0f815aabaf7594a0f3b6feb27f6ad5c7761d"}},{"ruleId":"D2","level":"warning","message":{"text":"hook_stacked_form_tables (cognitive 32): hook_stacked_form_tables has cognitive complexity 32 (threshold 15). Drivers by points: if/else 12 (30 pts), boolean chains 2 (nesting depth added 18). None of this is in the body itself: all 32 points belong to 4 function items inside it that branch (a function literal at line 92, a function literal at line 87, a function literal at line 127, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/javascript/opnsense_legacy.js"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"1b20cc52ee66267da55634ede524c59cd7b46574073b3aa2ebf7e2b925e6c03a"}},{"ruleId":"D2","level":"warning","message":{"text":"fetch_options (cognitive 32): fetch_options has cognitive complexity 32 (threshold 15). Drivers by points: if/else 11 (18 pts), loops 2 (6 pts), ternaries 1 (5 pts), boolean chains 2, other 1 (nesting depth added 15). Most of this is not in the body itself: 1 of the 32 points is its own statement and the rest belongs to 2 function literals inside it that branch (lines 963, 972). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":958}}}],"partialFingerprints":{"codehealthFindingId/v1":"420d543b1942258dd123188737ec919c608f8b2051cc573c69ccc7b0e796b250"}},{"ruleId":"D2","level":"warning","message":{"text":"AccessController.apiAction (cognitive 31): AccessController.apiAction has cognitive complexity 31 (threshold 15). Drivers by points: if/else 8 (28 pts), boolean chains 3 (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/Api/AccessController.php"},"region":{"startLine":159}}}],"partialFingerprints":{"codehealthFindingId/v1":"2285643b24bdcc8bc97d2c1a13e7281de5c8102cd359a1a5425ef6e234771ca8"}},{"ruleId":"D2","level":"warning","message":{"text":"SettingsController.toggleRuleAction (cognitive 31): SettingsController.toggleRuleAction has cognitive complexity 31 (threshold 15). Drivers by points: if/else 10 (26 pts), loops 2 (5 pts) (nesting depth added 19). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IDS/Api/SettingsController.php"},"region":{"startLine":437}}}],"partialFingerprints":{"codehealthFindingId/v1":"27343a8296a4b09d0f12661ba247180ff297616e39790aaaf9e1e10aafae1626"}},{"ruleId":"D2","level":"warning","message":{"text":"SettingsController.delGatewayAction (cognitive 31): SettingsController.delGatewayAction has cognitive complexity 31 (threshold 15). Drivers by points: if/else 8 (25 pts), loops 2 (6 pts) (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php"},"region":{"startLine":197}}}],"partialFingerprints":{"codehealthFindingId/v1":"e56b856aa95ab2e843eb3d552168b175f86c20165836e9cbcf2f7dcfacd01420"}},{"ruleId":"D2","level":"warning","message":{"text":"ServiceController.statsAction (cognitive 31): ServiceController.statsAction has cognitive complexity 31 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 6 (11 pts), boolean chains 3, ternaries 1 (2 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Syslog/Api/ServiceController.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"af13be146e2cb2335c4fee0a00de42a14ca7afd4c000d8ad35d9769affa44a58"}},{"ruleId":"D2","level":"warning","message":{"text":"Util.getPortAlias (cognitive 31): Util.getPortAlias has cognitive complexity 31 (threshold 15). Drivers by points: if/else 5 (19 pts), loops 3 (10 pts), boolean chains 2 (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php"},"region":{"startLine":308}}}],"partialFingerprints":{"codehealthFindingId/v1":"32e8c32e46e9a9958222ac27eadcc3eda38994fd65adb59a7d301718d51ddd1c"}},{"ruleId":"D2","level":"warning","message":{"text":"User.getUserPrivs (cognitive 31): User.getUserPrivs has cognitive complexity 31 (threshold 15). Drivers by points: if/else 4 (16 pts), loops 4 (15 pts) (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Auth/User.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e08767ac5780a1979a5ed45380c3dccbb88e158e4f9a50eecdf722235591c80"}},{"ruleId":"D2","level":"warning","message":{"text":"MFP1_0_8.run (cognitive 31): MFP1_0_8.run has cognitive complexity 31 (threshold 15). Drivers by points: ternaries 7 (21 pts), if/else 3 (7 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_0_8.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"bef4f3a6c06687bf9087cc93be44d7c7009fe1038666298c674bee4d1201b98f"}},{"ruleId":"D2","level":"warning","message":{"text":"lib.net_wildcard_iterator (cognitive 31): lib.net_wildcard_iterator has cognitive complexity 31 (threshold 15). Drivers by points: if/else 8 (21 pts), loops 3 (10 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/__init__.py"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"89d9d354ae501440e05b21bf58e75e6e6f228b34465df5645a7521b81c4ba6ec"}},{"ruleId":"D2","level":"warning","message":{"text":"hook_ipv4v6 (cognitive 31): hook_ipv4v6 has cognitive complexity 31 (threshold 15). Drivers by points: if/else 7 (14 pts), ternaries 2 (7 pts), loops 2 (6 pts), boolean chains 4 (nesting depth added 16). None of this is in the body itself: all 31 points belong to 2 function literals inside it that branch (lines 43, 40). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/javascript/opnsense_legacy.js"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"a951e3847d0650cc648fe133c4ef7329f8f1866f7eb88ce394ed8decaa2914dd"}},{"ruleId":"D2","level":"warning","message":{"text":"qrcode::qrcode::mapData (cognitive 31): qrcode::qrcode::mapData has cognitive complexity 31 (threshold 15). Drivers by points: if/else 6 (24 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 21). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":216}}}],"partialFingerprints":{"codehealthFindingId/v1":"e94b789ec06d55d116b45745ad2d88e717a59fe04f02a6f973ffb9e9f3c1b518"}},{"ruleId":"D2","level":"warning","message":{"text":"showOptionsDialog (cognitive 31): showOptionsDialog has cognitive complexity 31 (threshold 15). Drivers by points: if/else 6 (10 pts), ternaries 5 (9 pts), loops 5 (6 pts), boolean chains 3, other 2, error handling 1 (nesting depth added 9). Most of this is not in the body itself: 9 of the 31 points are its own statements and the rest belongs to 12 function items inside it that branch ((anonymous)::action, updateOptions, (anonymous)::onhide, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":227}}}],"partialFingerprints":{"codehealthFindingId/v1":"a8ccda29f49152abafcecbd4dd45b098f4c391c561d14e87661ccca529a25f95"}},{"ruleId":"D2","level":"warning","message":{"text":"ApiMutableModelControllerBase.checkAndThrowValueInUse (cognitive 30): ApiMutableModelControllerBase.checkAndThrowValueInUse has cognitive complexity 30 (threshold 15). Drivers by points: if/else 8 (16 pts), loops 4 (7 pts), boolean chains 4, ternaries 1 (3 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php"},"region":{"startLine":109}}}],"partialFingerprints":{"codehealthFindingId/v1":"f303c19be2f61f2be2ae3478858f0973635a023cbdf938305ce91883fab143f7"}},{"ruleId":"D2","level":"warning","message":{"text":"ControllerBase.parseFormNode (cognitive 30): ControllerBase.parseFormNode has cognitive complexity 30 (threshold 15). Drivers by points: if/else 8 (19 pts), loops 3 (8 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php"},"region":{"startLine":166}}}],"partialFingerprints":{"codehealthFindingId/v1":"c92dae85df544e372c5222594aef5a651f30ffbf9ce9a6a62d0ede9bf08854bc"}},{"ruleId":"D2","level":"warning","message":{"text":"ControllerBase.beforeExecuteRoute (cognitive 30): ControllerBase.beforeExecuteRoute has cognitive complexity 30 (threshold 15). Drivers by points: if/else 8 (12 pts), boolean chains 9, loops 5 (7 pts), ternaries 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php"},"region":{"startLine":373}}}],"partialFingerprints":{"codehealthFindingId/v1":"72440d55fa57683d678a9b47355a5669028decb53ff64c7f8fc47505c255572a"}},{"ruleId":"D2","level":"warning","message":{"text":"GroupSettingsController.delAction (cognitive 30): GroupSettingsController.delAction has cognitive complexity 30 (threshold 15). Drivers by points: if/else 4 (16 pts), loops 3 (12 pts), ternaries 1 (2 pts) (nesting depth added 22). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/GroupSettingsController.php"},"region":{"startLine":107}}}],"partialFingerprints":{"codehealthFindingId/v1":"25b72712bfd6d0a3aeafce2c286da1104b871ba9d674b63d4ab22a097c9102d3"}},{"ruleId":"D2","level":"warning","message":{"text":"BaseModel.internalSerializeToConfig (cognitive 30): BaseModel.internalSerializeToConfig has cognitive complexity 30 (threshold 15). Drivers by points: if/else 8 (15 pts), loops 5 (11 pts), ternaries 1 (4 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php"},"region":{"startLine":721}}}],"partialFingerprints":{"codehealthFindingId/v1":"71914cae3ccbed9325dd4f4f50b80110c7ee2b11555f7a26859fed13bc3fde76"}},{"ruleId":"D2","level":"warning","message":{"text":"ACL.hasPrivilege (cognitive 30): ACL.hasPrivilege has cognitive complexity 30 (threshold 15). Drivers by points: if/else 5 (16 pts), loops 4 (12 pts), boolean chains 2 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/ACL.php"},"region":{"startLine":355}}}],"partialFingerprints":{"codehealthFindingId/v1":"393524366046e40e52b2b5c266b3cd2dd17290cde380fb890d299008b0e78929"}},{"ruleId":"D2","level":"warning","message":{"text":"Gateways.performValidation (cognitive 30): Gateways.performValidation has cognitive complexity 30 (threshold 15). Drivers by points: if/else 7 (17 pts), boolean chains 6, loops 3 (4 pts), ternaries 1 (3 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"9910d9c063449cbdc6035252dc4667500e086ad9cd85d96e0505e83220d1c0e5"}},{"ruleId":"D2","level":"warning","message":{"text":"Template.list_module (cognitive 30): Template.list_module has cognitive complexity 30 (threshold 15). Drivers by points: if/else 6 (22 pts), loops 3 (6 pts), boolean chains 2 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/template.py"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"b12b3da5cc21441dc6936157f2ea8280fb70eb1022f77923a559e3476f948811"}},{"ruleId":"D2","level":"warning","message":{"text":"SettingsController.setJobAction (cognitive 29): SettingsController.setJobAction has cognitive complexity 29 (threshold 15). Drivers by points: if/else 7 (24 pts), loops 1 (4 pts), boolean chains 1 (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Cron/Api/SettingsController.php"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"eb4178c36d9528e06466020f94f9c8287b006fc99751a7fc769b631e06dcbacf"}},{"ruleId":"D2","level":"warning","message":{"text":"HostField.getValidators (cognitive 29): HostField.getValidators has cognitive complexity 29 (threshold 15). Drivers by points: if/else 5 (10 pts), boolean chains 9, ternaries 2 (6 pts), loops 2 (4 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Diagnostics/FieldTypes/HostField.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c92339fb7cf309c0ea90009768287f0d163c63cf70218bce0714ec466e65ec0"}},{"ruleId":"D2","level":"warning","message":{"text":"Radvd.performValidation (cognitive 29): Radvd.performValidation has cognitive complexity 29 (threshold 15). Drivers by points: if/else 9 (21 pts), match/switch 1 (4 pts), boolean chains 3, loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Radvd/Radvd.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"f999feb479d660613a891f82945c5a507e19eb633ff58934317f61c3f0a4771e"}},{"ruleId":"D2","level":"warning","message":{"text":"treeview_node_to_table (cognitive 29): treeview_node_to_table has cognitive complexity 29 (threshold 15). Drivers by points: loops 6 (17 pts), if/else 6 (10 pts), boolean chains 1, other 1 (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense-treeview.js"},"region":{"startLine":191}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c7e677ad3783465eaaf2318971af39ac47dec8659350c954706a6b15afe3a04"}},{"ruleId":"D2","level":"warning","message":{"text":"liveSearchListener (cognitive 29): liveSearchListener has cognitive complexity 29 (threshold 15). Drivers by points: if/else 9 (21 pts), boolean chains 4, loops 2 (4 pts) (nesting depth added 14). None of this is in the body itself: all 29 points belong to 3 function literals inside it that branch (lines 2672, 2661, 2668). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":2658}}}],"partialFingerprints":{"codehealthFindingId/v1":"cd765ffa312f9dec9bf59d28f45242e7652f8ac4e7e29c6d67162547a62d6da4"}},{"ruleId":"D2","level":"warning","message":{"text":"Router.resolveNamespace (cognitive 28): Router.resolveNamespace has cognitive complexity 28 (threshold 15). Drivers by points: if/else 8 (19 pts), loops 3 (7 pts), boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Mvc/Router.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"f648219822b8c94d8fc3fdb7a034db0ea3378affb0a766198a992dad005d71a8"}},{"ruleId":"D2","level":"warning","message":{"text":"IPsecProposalField.actionPostLoadingEvent (cognitive 28): IPsecProposalField.actionPostLoadingEvent has cognitive complexity 28 (threshold 15). Drivers by points: loops 6 (16 pts), if/else 3 (11 pts), boolean chains 1 (nesting depth added 18). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/FieldTypes/IPsecProposalField.php"},"region":{"startLine":175}}}],"partialFingerprints":{"codehealthFindingId/v1":"468b44ee485ffa59fdd6f9af6ddd8e42eb0bd64e2d3bedbf0411e504ad208ff6"}},{"ruleId":"D2","level":"warning","message":{"text":"NetworkInterfaceContainerField.toLegacy (cognitive 28): NetworkInterfaceContainerField.toLegacy has cognitive complexity 28 (threshold 15). Drivers by points: if/else 12 (20 pts), loops 4 (6 pts), boolean chains 1, ternaries 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/NetworkInterfaceField.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"3385cffde02988080ddb9fe3df79fe2c02a629e2407f009a366ce7becfdd2748"}},{"ruleId":"D2","level":"warning","message":{"text":"DB.update_accounting_info (cognitive 28): DB.update_accounting_info has cognitive complexity 28 (threshold 15). Drivers by points: if/else 9 (17 pts), loops 5 (6 pts), boolean chains 3, ternaries 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/lib/db.py"},"region":{"startLine":478}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad25658fbd1a34cd2f51272d3f7e41d6d6082c58f51dbfa30ee6b3dc31250962"}},{"ruleId":"D2","level":"warning","message":{"text":"IPFW.add_accounting (cognitive 28): IPFW.add_accounting has cognitive complexity 28 (threshold 15). Drivers by points: if/else 9 (19 pts), loops 4 (8 pts), ternaries 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/lib/ipfw.py"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"b8ee499a99e62acea51bf52f64a02909b36d889368711c0ea03d53e76b319c29"}},{"ruleId":"D2","level":"warning","message":{"text":"BlocklistParser.modify_blocklist (cognitive 28): BlocklistParser.modify_blocklist has cognitive complexity 28 (threshold 15). Drivers by points: if/else 12 (20 pts), ternaries 2 (4 pts), error handling 2 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/blocklists/__init__.py"},"region":{"startLine":147}}}],"partialFingerprints":{"codehealthFindingId/v1":"19fd441c81cc5ad7b4138fd4ba4da0474de60908e407db81e92305e1321cf95d"}},{"ruleId":"D2","level":"warning","message":{"text":"PlatformTLSAdaptor.get_sslcontext (cognitive 28): PlatformTLSAdaptor.get_sslcontext has cognitive complexity 28 (threshold 15). Drivers by points: if/else 8 (21 pts), loops 2 (7 pts) (nesting depth added 18). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/site-python/tls_helper.py"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c6dec867b5c92da2f9947bc962e288f82b42f2a1532a08287c5863532952862"}},{"ruleId":"D2","level":"warning","message":{"text":"Certificates.processItems (cognitive 28): Certificates.processItems has cognitive complexity 28 (threshold 15). Drivers by points: ternaries 10 (26 pts), boolean chains 1, if/else 1 (nesting depth added 16). None of this is in the body itself: all 28 points belong to one function literal inside it that branches (line 77). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal\u0027s work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/Certificates.js"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"8390f535cc0474d915e3b1cf552cb1865a832953cb9712b663402d71f99ff0c5"}},{"ruleId":"D2","level":"warning","message":{"text":"buildData (cognitive 28): buildData has cognitive complexity 28 (threshold 15). Drivers by points: if/else 11 (14 pts), boolean chains 8, ternaries 3 (4 pts), loops 2 (nesting depth added 4). Most of this is not in the body itself: 6 of the 28 points are its own statements and the rest belongs to 3 function items inside it that branch (addOption, addOptgroup, addDivider). Those helpers are already separate functions, so extracting the branching again is not available. To reduce it, move them out of the body to the enclosing scope, where each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1499}}}],"partialFingerprints":{"codehealthFindingId/v1":"8eb44c3cd3df8018d3e639b2a4b9c7f577564d3362a68151fefa2030050f93bd"}},{"ruleId":"D2","level":"warning","message":{"text":"FirewallController.queryStatesAction (cognitive 27): FirewallController.queryStatesAction has cognitive complexity 27 (threshold 15). Drivers by points: if/else 6 (11 pts), ternaries 2 (8 pts), loops 2 (6 pts), boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/FirewallController.php"},"region":{"startLine":162}}}],"partialFingerprints":{"codehealthFindingId/v1":"cfe835a714c0ece42bcabb1546b0d02071b05ac05edcddf833fb1ee1924feb8c"}},{"ruleId":"D2","level":"warning","message":{"text":"FirewallController.queryPfTopAction (cognitive 27): FirewallController.queryPfTopAction has cognitive complexity 27 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 3 (7 pts), ternaries 1 (4 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/FirewallController.php"},"region":{"startLine":223}}}],"partialFingerprints":{"codehealthFindingId/v1":"3708ee17bba30d0638ea15186e082ab622118594e90a919bd30d8bee17a40c46"}},{"ruleId":"D2","level":"warning","message":{"text":"AliasUtilController.deleteAction (cognitive 27): AliasUtilController.deleteAction has cognitive complexity 27 (threshold 15). Drivers by points: if/else 7 (15 pts), ternaries 2 (7 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasUtilController.php"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"c20c293434db15feec73cf4d3c64959b97d27a122cc67bc1f56f556fd5536f68"}},{"ruleId":"D2","level":"warning","message":{"text":"ServiceController.reconfigureAction (cognitive 27): ServiceController.reconfigureAction has cognitive complexity 27 (threshold 15). Drivers by points: if/else 12 (26 pts), boolean chains 1 (nesting depth added 14). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IDS/Api/ServiceController.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"8039b0a63881c33504b02f888634327ea81638820aaf0ee88a0ea4cebbab1cca"}},{"ruleId":"D2","level":"warning","message":{"text":"SadController.searchAction (cognitive 27): SadController.searchAction has cognitive complexity 27 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 4 (6 pts), boolean chains 4, ternaries 2 (4 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SadController.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"8b289055c7c9b67e92060e2ac38301bf9b4f2dc55ed2f5c502c33183b7ed6361"}},{"ruleId":"D2","level":"warning","message":{"text":"SpdController.searchAction (cognitive 27): SpdController.searchAction has cognitive complexity 27 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 4 (6 pts), boolean chains 4, ternaries 2 (4 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SpdController.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"16d28f18b6ee64faf841030f4e727b1a45645b44657d90e999bd9a985479eee3"}},{"ruleId":"D2","level":"warning","message":{"text":"OptionField.setOptionValues (cognitive 27): OptionField.setOptionValues has cognitive complexity 27 (threshold 15). Drivers by points: ternaries 2 (11 pts), if/else 4 (8 pts), loops 2 (8 pts) (nesting depth added 19). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/OptionField.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"46a467f4d4103e2f619b7808eb01c5bebfe33e6199666071f221fa41ba01fd66"}},{"ruleId":"D2","level":"warning","message":{"text":"InitialSetup.flush_network_wan (cognitive 27): InitialSetup.flush_network_wan has cognitive complexity 27 (threshold 15). Drivers by points: if/else 13 (22 pts), loops 2 (3 pts), boolean chains 1, ternaries 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/InitialSetup.php"},"region":{"startLine":282}}}],"partialFingerprints":{"codehealthFindingId/v1":"e191a4c9eae575d4e8106307a6ac36d4508a39b79d66b8fbc3da53e9c51caf27"}},{"ruleId":"D2","level":"warning","message":{"text":"ConnnectionField.actionPostLoadingEvent (cognitive 27): ConnnectionField.actionPostLoadingEvent has cognitive complexity 27 (threshold 15). Drivers by points: if/else 6 (17 pts), loops 4 (9 pts), boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/FieldTypes/ConnnectionField.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f57c79ed1cd1839591ba8f489fde5c7f050ea20a1cfa3cecba403944719a959"}},{"ruleId":"D2","level":"warning","message":{"text":"M1_0_0.post (cognitive 27): M1_0_0.post has cognitive complexity 27 (threshold 15). Drivers by points: if/else 6 (16 pts), loops 3 (10 pts), boolean chains 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/Migrations/M1_0_0.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"47048e57dec7140cfe2aa3ca5bdf21cf166d5e1d95ae2e31cf853e76899f1376"}},{"ruleId":"D2","level":"warning","message":{"text":"getserviceproviders.provider_plans_list (cognitive 27): getserviceproviders.provider_plans_list has cognitive complexity 27 (threshold 15). Drivers by points: ternaries 2 (10 pts), loops 3 (9 pts), if/else 3 (8 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/getserviceproviders.php"},"region":{"startLine":128}}}],"partialFingerprints":{"codehealthFindingId/v1":"e59a6b58cd03dc665c2c5306a5687fef926185a7d2cbaf908c043612f19ebc6f"}},{"ruleId":"D2","level":"warning","message":{"text":"DNSBL._load_dnsbl (cognitive 27): DNSBL._load_dnsbl has cognitive complexity 27 (threshold 15). Drivers by points: if/else 9 (18 pts), ternaries 3 (4 pts), error handling 1 (3 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound-dnsbl/lib/dnsbl.py"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec70cde215c36dcc917be885696843111770c0383cc888ff943f9cc4202c17df"}},{"ruleId":"D2","level":"warning","message":{"text":"Action.execute (cognitive 27): Action.execute has cognitive complexity 27 (threshold 15). Drivers by points: if/else 11 (15 pts), loops 4 (11 pts), error handling 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/actions/inline.py"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"8efa2171fe1e3de2fd78313bf10d2dc69f5aa8b64ff329995d65680939c65da4"}},{"ruleId":"D2","level":"warning","message":{"text":"IXR_IntrospectionServer.call (cognitive 26): IXR_IntrospectionServer.call has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (20 pts), boolean chains 3, match/switch 1 (2 pts), loops 1 (nesting depth added 12). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/IXR/IXR_Library.php"},"region":{"startLine":919}}}],"partialFingerprints":{"codehealthFindingId/v1":"b00e62291200273d4f93c9bff61e65e43075d1e9ef54bfe74c85d094954276ef"}},{"ruleId":"D2","level":"warning","message":{"text":"ApiMutableModelControllerBase.toggleBase (cognitive 26): ApiMutableModelControllerBase.toggleBase has cognitive complexity 26 (threshold 15). Drivers by points: if/else 7 (15 pts), ternaries 2 (7 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 14). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php"},"region":{"startLine":641}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c0cb3df44c8a216891595486e14f1194ee7980bd363588aca7feb8f8a240ba9"}},{"ruleId":"D2","level":"warning","message":{"text":"SettingsController.toggleGatewayAction (cognitive 26): SettingsController.toggleGatewayAction has cognitive complexity 26 (threshold 15). Drivers by points: if/else 6 (15 pts), ternaries 2 (10 pts), boolean chains 1 (nesting depth added 17). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php"},"region":{"startLine":253}}}],"partialFingerprints":{"codehealthFindingId/v1":"b33d47d5e37086340025a5984e5dc94edc87be1e82ee3be735cc1066ee47ee45"}},{"ruleId":"D2","level":"warning","message":{"text":"ServiceController.showAction (cognitive 26): ServiceController.showAction has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (18 pts), loops 4 (5 pts), boolean chains 2, ternaries 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Wireguard/Api/ServiceController.php"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"17c3a5c19967c3b770e38eaa8e7e29ec15c1584d13b2352f9ffe5db7d0d69d85"}},{"ruleId":"D2","level":"warning","message":{"text":"LDAP.search (cognitive 26): LDAP.search has cognitive complexity 26 (threshold 15). Drivers by points: if/else 7 (19 pts), loops 2 (7 pts) (nesting depth added 17). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php"},"region":{"startLine":170}}}],"partialFingerprints":{"codehealthFindingId/v1":"aae1072eba0fddcb6886c74614380859dfbbf352f78309b97d066efb8f1c9399"}},{"ruleId":"D2","level":"warning","message":{"text":"FilterRule.convertReplyTo (cognitive 26): FilterRule.convertReplyTo has cognitive complexity 26 (threshold 15). Drivers by points: if/else 7 (17 pts), boolean chains 6, match/switch 1 (3 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php"},"region":{"startLine":156}}}],"partialFingerprints":{"codehealthFindingId/v1":"090d9c7226d16eb8382a92f564be1d9dc3f8c4855bc71f4b29c50389d1eadf00"}},{"ruleId":"D2","level":"warning","message":{"text":"BaseField.setNodes (cognitive 26): BaseField.setNodes has cognitive complexity 26 (threshold 15). Drivers by points: if/else 8 (22 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php"},"region":{"startLine":810}}}],"partialFingerprints":{"codehealthFindingId/v1":"e16ead670712d8cb38cb27cc6ec0ba71c33a6c50f93679349e74fa9d97a80f69"}},{"ruleId":"D2","level":"warning","message":{"text":"ConfigdActionsField.actionPostLoadingEvent (cognitive 26): ConfigdActionsField.actionPostLoadingEvent has cognitive complexity 26 (threshold 15). Drivers by points: if/else 11 (21 pts), loops 2 (3 pts), boolean chains 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ConfigdActionsField.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ec6582c5018227de1138fb915a0f5504f7cc6a5a4f3016fffdecdbc0ffca20b"}},{"ruleId":"D2","level":"warning","message":{"text":"Vlan.performValidation (cognitive 26): Vlan.performValidation has cognitive complexity 26 (threshold 15). Drivers by points: if/else 5 (14 pts), ternaries 1 (4 pts), loops 2 (3 pts), match/switch 1 (3 pts), boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Vlan.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"855357754129c9c8024cd2963dcbd0d395383ba092cd8f08c02ce4318aa7ac4c"}},{"ruleId":"D2","level":"warning","message":{"text":"dnsmasq_watcher.run_watcher (cognitive 26): dnsmasq_watcher.run_watcher has cognitive complexity 26 (threshold 15). Drivers by points: if/else 6 (16 pts), loops 4 (9 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/dnsmasq/dnsmasq_watcher.py"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"22ee3744d8ae64f444023f82f6dd9ee84670837d227408e1e5f7b7f188807a38"}},{"ruleId":"D2","level":"warning","message":{"text":"read_log.parse_record (cognitive 26): read_log.parse_record has cognitive complexity 26 (threshold 15). Drivers by points: if/else 12 (25 pts), boolean chains 1 (nesting depth added 13). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/read_log.py"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"33ccb99b06e5f82cf35c43dbe99461cdbd944666d19e674d1aa338a95a2fb633"}},{"ruleId":"D2","level":"warning","message":{"text":"updateBoxAnnotation (cognitive 26): updateBoxAnnotation has cognitive complexity 26 (threshold 15). Drivers by points: if/else 8 (14 pts), ternaries 4 (12 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/chartjs-plugin-streaming.js"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"0dd4fba3ff4d339fac9fe384aad858e62d35a1e5d902da1c02b2d84a46da14c3"}},{"ruleId":"D2","level":"warning","message":{"text":"AliasUtilController.addAction (cognitive 25): AliasUtilController.addAction has cognitive complexity 25 (threshold 15). Drivers by points: if/else 8 (15 pts), ternaries 2 (7 pts), boolean chains 3 (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasUtilController.php"},"region":{"startLine":166}}}],"partialFingerprints":{"codehealthFindingId/v1":"b44b5aabb53942468abe2e369cadb53d7fc1fe7069c662c86f4372be0b9c83fc"}},{"ruleId":"D2","level":"warning","message":{"text":"ACL.urlMasks (cognitive 25): ACL.urlMasks has cognitive complexity 25 (threshold 15). Drivers by points: loops 5 (16 pts), if/else 3 (8 pts), ternaries 1 (nesting depth added 16). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/ACL.php"},"region":{"startLine":287}}}],"partialFingerprints":{"codehealthFindingId/v1":"c3c26ab03b069e406057305a1ae3a041104b945e38de6947ed878599819f030f"}},{"ruleId":"D2","level":"warning","message":{"text":"InitialSetup.init (cognitive 25): InitialSetup.init has cognitive complexity 25 (threshold 15). Drivers by points: if/else 12 (18 pts), boolean chains 3, loops 2 (3 pts), ternaries 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/InitialSetup.php"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"08d911565e0439bbbae111a171ce0ceed03dd2c08eb23f01e374e1c0325f619e"}},{"ruleId":"D2","level":"warning","message":{"text":"LinkAddressField.actionPostLoadingEvent (cognitive 25): LinkAddressField.actionPostLoadingEvent has cognitive complexity 25 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 3 (7 pts), ternaries 1 (3 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/LinkAddressField.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"210c73bdd9746143e98d39a68429c042680854e46b5d474b673006f54c04c969"}},{"ruleId":"D2","level":"warning","message":{"text":"Lagg.performValidation (cognitive 25): Lagg.performValidation has cognitive complexity 25 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 4 (7 pts), boolean chains 3 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Lagg.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"77aa4dbde83a202068b3c336af64f3fe84b3f66765a8ae9b9dda2c8f690984f6"}},{"ruleId":"D2","level":"warning","message":{"text":"interfaces_ppps_edit.serial_devices (cognitive 25): interfaces_ppps_edit.serial_devices has cognitive complexity 25 (threshold 15). Drivers by points: if/else 5 (16 pts), loops 4 (8 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/interfaces_ppps_edit.php"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"a81424ad94a10c2e7f41acf31ef5fc3d32f10abe458ff22c9074f37edd6dfc79"}},{"ruleId":"D2","level":"warning","message":{"text":"get_kea_leases.build_reserved_matches (cognitive 25): get_kea_leases.build_reserved_matches has cognitive complexity 25 (threshold 15). Drivers by points: if/else 5 (16 pts), loops 3 (6 pts), boolean chains 3 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/kea/get_kea_leases.py"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"ea57b5c7778a0f3dd2fa3fbda1e98330f7aeae586724f04efaf5a9398715dce2"}},{"ruleId":"D2","level":"warning","message":{"text":"LogMatcher.match_records (cognitive 25): LogMatcher.match_records has cognitive complexity 25 (threshold 15). Drivers by points: if/else 4 (15 pts), error handling 1 (4 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/syslog/log_matcher.py"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"06bfdfbc6d0324ec680f0cff1231f1b8d1b63d595af3b836b41f7647eefc1af6"}},{"ruleId":"D2","level":"warning","message":{"text":"Config._traverse (cognitive 25): Config._traverse has cognitive complexity 25 (threshold 15). Drivers by points: if/else 7 (19 pts), loops 2 (6 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/config.py"},"region":{"startLine":66}}}],"partialFingerprints":{"codehealthFindingId/v1":"435f6e453a1ea32bd334cf9e41842ac70958bbb6a24b02613e7e898de419bc21"}},{"ruleId":"D2","level":"warning","message":{"text":"ActionHandler.load_config (cognitive 25): ActionHandler.load_config has cognitive complexity 25 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 4 (9 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/processhandler.py"},"region":{"startLine":244}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed22e317817aec70b27db7a634647055de91aca62823aa6f7de633099818b078"}},{"ruleId":"D2","level":"warning","message":{"text":"bootstrap.Tooltip.show (cognitive 25): bootstrap.Tooltip.show has cognitive complexity 25 (threshold 15). Drivers by points: if/else 6 (11 pts), boolean chains 8, ternaries 3 (6 pts) (nesting depth added 8). Of this number, 23 points are the body\u0027s own statements and 2 belong to one function item inside it that branches. This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap.js"},"region":{"startLine":1603}}}],"partialFingerprints":{"codehealthFindingId/v1":"9318a8a54c42992e08292fa118bc76eb7e2303fddee438d1d28f2e70856e0663"}},{"ruleId":"D2","level":"warning","message":{"text":"append (cognitive 25): append has cognitive complexity 25 (threshold 15). Drivers by points: if/else 9 (20 pts), loops 1 (2 pts), ternaries 2, boolean chains 1 (nesting depth added 12). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/smoothie.js"},"region":{"startLine":235}}}],"partialFingerprints":{"codehealthFindingId/v1":"548047b3754d1450d80304b403516fc5bb3b10752c481516fa10c8503754bfc6"}},{"ruleId":"D2","level":"warning","message":{"text":"updateLineAnnotation (cognitive 25): updateLineAnnotation has cognitive complexity 25 (threshold 15). Drivers by points: if/else 12 (17 pts), ternaries 3 (8 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/chartjs-plugin-streaming.js"},"region":{"startLine":123}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b6690817c92d4632dc5c6964bf2de4bb7900df6d6c0dd322802c3cb8e89f38d"}},{"ruleId":"D2","level":"warning","message":{"text":"IXR_Client.query (cognitive 24): IXR_Client.query has cognitive complexity 24 (threshold 15). Drivers by points: if/else 12 (18 pts), error handling 2 (4 pts), loops 2 (nesting depth added 8). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/IXR/IXR_Library.php"},"region":{"startLine":625}}}],"partialFingerprints":{"codehealthFindingId/v1":"8dfc6625dc6f3088520cef71933975b8f40982b872f0f41ce2b163a9d3a0bc9e"}},{"ruleId":"D2","level":"warning","message":{"text":"AssignmentController.delItemAction (cognitive 24): AssignmentController.delItemAction has cognitive complexity 24 (threshold 15). Drivers by points: loops 5 (15 pts), if/else 3 (8 pts), boolean chains 1 (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/AssignmentController.php"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c00cdcb7284dda7e0e0e19d598d214c9b741e4d7bb0a1a524f36f21e284c33f"}},{"ruleId":"D2","level":"warning","message":{"text":"AssignmentController.cleanRules (cognitive 24): AssignmentController.cleanRules has cognitive complexity 24 (threshold 15). Drivers by points: if/else 5 (15 pts), loops 4 (9 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/AssignmentController.php"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"5fad27a28bd6e1a887cffd8e02f7d0c463ccfba2300815c608234dfffb73d28f"}},{"ruleId":"D2","level":"warning","message":{"text":"Local.shouldChangePassword (cognitive 24): Local.shouldChangePassword has cognitive complexity 24 (threshold 15). Drivers by points: if/else 8 (20 pts), ternaries 1 (4 pts) (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Local.php"},"region":{"startLine":116}}}],"partialFingerprints":{"codehealthFindingId/v1":"eca6258bf1e1791e06c0de116ad30ead3cfbc24b1de20c3969f906694d06c698"}},{"ruleId":"D2","level":"warning","message":{"text":"Store.getCertificate (cognitive 24): Store.getCertificate has cognitive complexity 24 (threshold 15). Drivers by points: if/else 5 (16 pts), loops 2 (7 pts), boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Trust/Store.php"},"region":{"startLine":106}}}],"partialFingerprints":{"codehealthFindingId/v1":"231c45406794b34314f2355f102e8c5701bcaa906fb6e3d2c850b15cfdc6961a"}},{"ruleId":"D2","level":"warning","message":{"text":"HostnameField.getValidators (cognitive 24): HostnameField.getValidators has cognitive complexity 24 (threshold 15). Drivers by points: if/else 4 (10 pts), ternaries 2 (7 pts), boolean chains 5, loops 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/HostnameField.php"},"region":{"startLine":129}}}],"partialFingerprints":{"codehealthFindingId/v1":"2539d3d8877207985c8a39ed2b4fea098e2b6b2b488ff0fe167ef91d28797bac"}},{"ruleId":"D2","level":"warning","message":{"text":"VirtualIPField.actionPostLoadingEvent (cognitive 24): VirtualIPField.actionPostLoadingEvent has cognitive complexity 24 (threshold 15). Drivers by points: if/else 9 (20 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/VirtualIPField.php"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd61996906d5b0e164533f51a2b75c83b19415c4adeff65a1c5f41f5fac937b3"}},{"ruleId":"D2","level":"warning","message":{"text":"InitialSetup.performValidation (cognitive 24): InitialSetup.performValidation has cognitive complexity 24 (threshold 15). Drivers by points: if/else 11 (17 pts), boolean chains 6, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/InitialSetup.php"},"region":{"startLine":157}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c0bbab68c7b47849280a0f04539167495831604ba1280ca2beeb3aa582a7d2c"}},{"ruleId":"D2","level":"warning","message":{"text":"Gateways.getInterfaceGateway (cognitive 24): Gateways.getInterfaceGateway has cognitive complexity 24 (threshold 15). Drivers by points: if/else 5 (10 pts), ternaries 2 (7 pts), boolean chains 6, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php"},"region":{"startLine":594}}}],"partialFingerprints":{"codehealthFindingId/v1":"838a052bd1064b2ba02d63b6f2f9f9c2f79b860d9f971188523d46f7bbfbcd62"}},{"ruleId":"D2","level":"warning","message":{"text":"Downloader._unpack (cognitive 24): Downloader._unpack has cognitive complexity 24 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 2 (6 pts), boolean chains 5 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/suricata/lib/downloader.py"},"region":{"startLine":49}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e700560297019d4711818a2f653b5a5f3166103ac9b0ae8a90fae63bcdc1afb"}},{"ruleId":"D2","level":"warning","message":{"text":"Handler.run (cognitive 24): Handler.run has cognitive complexity 24 (threshold 15). Drivers by points: if/else 5 (13 pts), error handling 4 (8 pts), loops 2 (3 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/processhandler.py"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"2488deeddb3400923b62d9bf3dc553dba49925bc74e44a7dcd97592fd3b249b2"}},{"ruleId":"D2","level":"warning","message":{"text":"qrcode::qrcode::createSvgTag (cognitive 24): qrcode::qrcode::createSvgTag has cognitive complexity 24 (threshold 15). Drivers by points: ternaries 9, boolean chains 8, if/else 2 (4 pts), loops 2 (3 pts) (nesting depth added 3). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":495}}}],"partialFingerprints":{"codehealthFindingId/v1":"58aa995de53890967b68ab5f0b24587f26fe25f00896d9f89dd1c409dba98f1d"}},{"ruleId":"D2","level":"warning","message":{"text":"SimpleActionButton (cognitive 24): SimpleActionButton has cognitive complexity 24 (threshold 15). Drivers by points: if/else 12 (14 pts), boolean chains 5, ternaries 4 (5 pts) (nesting depth added 3). None of this is in the body itself: all 24 points belong to 14 function items inside it that branch (a function literal at line 884, construct, setIcon, \u2026). The named helpers are already separate functions; the literals\u0027 work cannot be called, reviewed or tested from outside this body. To reduce it, move the named helpers out of the body to the enclosing scope and lift each literal\u0027s work into a named function there, so each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":816}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d37d18e2d88086e0190a3bc6a724faa5d3531a4e200baf3f4a796c03d0c61dc"}},{"ruleId":"D2","level":"warning","message":{"text":"ServiceController.searchRoutesAction (cognitive 23): ServiceController.searchRoutesAction has cognitive complexity 23 (threshold 15). Drivers by points: if/else 4 (13 pts), loops 3 (9 pts), boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ServiceController.php"},"region":{"startLine":140}}}],"partialFingerprints":{"codehealthFindingId/v1":"510d926e8d1b35abb23133e5f5533c7eaaf401960463902b6de8047fb7632225"}},{"ruleId":"D2","level":"warning","message":{"text":"InitialSetup.flush_deployment_type (cognitive 23): InitialSetup.flush_deployment_type has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/InitialSetup.php"},"region":{"startLine":425}}}],"partialFingerprints":{"codehealthFindingId/v1":"013a27c669ab5c157afacaf414300f95491e45541d680edf7b6e6fb8737bdea3"}},{"ruleId":"D2","level":"warning","message":{"text":"FilterRuleContainerField.getPriority (cognitive 23): FilterRuleContainerField.getPriority has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 3 (6 pts), boolean chains 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/FilterRuleField.php"},"region":{"startLine":145}}}],"partialFingerprints":{"codehealthFindingId/v1":"69ca227ab467947e888078fbc2b93fcd03e434838f070be6455dd4bcad44d4b2"}},{"ruleId":"D2","level":"warning","message":{"text":"IDS.getRuleAction (cognitive 23): IDS.getRuleAction has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (19 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IDS/IDS.php"},"region":{"startLine":164}}}],"partialFingerprints":{"codehealthFindingId/v1":"f19726ef5dd7ba176db681b29c0bcc5df4bf64eea4cba41d4431e70eeb7f12fe"}},{"ruleId":"D2","level":"warning","message":{"text":"Cert.linkCaRefs (cognitive 23): Cert.linkCaRefs has cognitive complexity 23 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 3 (6 pts), ternaries 1 (3 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Trust/Cert.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"b8516c486ab938ff951e05efd315fa675a03c322c22b988666f9761714df71d8"}},{"ruleId":"D2","level":"warning","message":{"text":"list_assign_options.list_devices (cognitive 23): list_assign_options.list_devices has cognitive complexity 23 (threshold 15). Drivers by points: if/else 6 (16 pts), loops 4 (6 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/interfaces/list_assign_options.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"7be3f13fe79ee3a2799c4765ec841b54044338fc07c068f23bd40922a80fb963"}},{"ruleId":"D2","level":"warning","message":{"text":"getserviceproviders.provider_plan_data (cognitive 23): getserviceproviders.provider_plan_data has cognitive complexity 23 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 3 (9 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/getserviceproviders.php"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"fff998929e4e81c198370a5437ea3a33f585f60aaafbe70743bb3aef19ff7f54"}},{"ruleId":"D2","level":"warning","message":{"text":"lib.parse_ipfw_pipes (cognitive 23): lib.parse_ipfw_pipes has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (19 pts), boolean chains 3, loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/shaper/lib/__init__.py"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6061d69346979a8ff5774d7e2d19e7366eb2ffedf569ffcd892a2d5b9932a09"}},{"ruleId":"D2","level":"warning","message":{"text":"lib.parse_ipfw_rules (cognitive 23): lib.parse_ipfw_rules has cognitive complexity 23 (threshold 15). Drivers by points: ternaries 4 (12 pts), if/else 3 (9 pts), boolean chains 1, loops 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/shaper/lib/__init__.py"},"region":{"startLine":178}}}],"partialFingerprints":{"codehealthFindingId/v1":"632a1c7a7a8c800dce68c833d05e15d3cd10ffa8c8586d93639b77963782f9cc"}},{"ruleId":"D2","level":"warning","message":{"text":"RuleCache.create (cognitive 23): RuleCache.create has cognitive complexity 23 (threshold 15). Drivers by points: loops 5 (16 pts), if/else 3 (6 pts), error handling 1 (nesting depth added 14). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/suricata/lib/rulecache.py"},"region":{"startLine":233}}}],"partialFingerprints":{"codehealthFindingId/v1":"10c0f491d9c45683e23a8ebbb96d59b64285a5f73459c522a4024f6855859fa2"}},{"ruleId":"D2","level":"warning","message":{"text":"HandlerClient.run (cognitive 23): HandlerClient.run has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (17 pts), error handling 3 (4 pts), boolean chains 1, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/processhandler.py"},"region":{"startLine":153}}}],"partialFingerprints":{"codehealthFindingId/v1":"3525f5ae1b0298971247cd1ebb5976a0212193bdc51b66dd9cd9979e972c8290"}},{"ruleId":"D2","level":"warning","message":{"text":"bootstrap.Modal.backdrop (cognitive 23): bootstrap.Modal.backdrop has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (11 pts), ternaries 4 (7 pts), boolean chains 5 (nesting depth added 7). Of this number, 16 points are the body\u0027s own statements and 7 belong to 2 function items inside it that branch. This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap.js"},"region":{"startLine":1112}}}],"partialFingerprints":{"codehealthFindingId/v1":"23ba4eeb604cb02583498ca181134157951812db2adb74d6bd5e70b61aacf73a"}},{"ruleId":"D2","level":"warning","message":{"text":"UIBootgrid._renderActionBar (cognitive 23): UIBootgrid._renderActionBar has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (11 pts), ternaries 6 (8 pts), boolean chains 4 (nesting depth added 4). Most of this is not in the body itself: 8 of the 23 points are its own statements and the rest belongs to 5 function literals inside it that branch (lines 1283, 1276, 1300, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1234}}}],"partialFingerprints":{"codehealthFindingId/v1":"07a30f032c5b66edde0aef041da6b909f1d3ad0d7b10f597b1d0e7eb8f9aad2e"}},{"ruleId":"D2","level":"warning","message":{"text":"UIBootgrid.tabulatorDefaults (cognitive 23): UIBootgrid.tabulatorDefaults has cognitive complexity 23 (threshold 15). Drivers by points: if/else 12 (13 pts), boolean chains 6, ternaries 2 (3 pts), match/switch 1 (nesting depth added 2). None of this is in the body itself: all 23 points belong to 9 function literals inside it that branch (lines 1657, 1627, 1598, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1559}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ab7162b76b24a4f8fc72c507f3020b310e34523dc4185a15150ee637eb28200"}},{"ruleId":"D2","level":"warning","message":{"text":"setPlaceholder (cognitive 23): setPlaceholder has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (13 pts), boolean chains 8, ternaries 1 (2 pts) (nesting depth added 7). Of this number, 20 points are the body\u0027s own statements and 3 belong to one function literal inside it that branches. This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1447}}}],"partialFingerprints":{"codehealthFindingId/v1":"08ceb3c437b206d09e3cdb5248d0a6be05c3d39390fc49a11301253c8a22f96e"}},{"ruleId":"D2","level":"warning","message":{"text":"setMenuSize (cognitive 23): setMenuSize has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (13 pts), boolean chains 6, loops 1 (2 pts), ternaries 1 (2 pts) (nesting depth added 6). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":2030}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d878ae4cbbf06198b14422e380d30d1408456724d874acc3be20c3c67b3e602"}},{"ruleId":"D2","level":"warning","message":{"text":"ApiMutableModelControllerBase.delBase (cognitive 22): ApiMutableModelControllerBase.delBase has cognitive complexity 22 (threshold 15). Drivers by points: ternaries 4 (11 pts), if/else 5 (9 pts), loops 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php"},"region":{"startLine":544}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ea12ecba77b86bf33d9ef55e4abf231ab4587ca6d62e47ac1eed9ad3c1f657a"}},{"ruleId":"D2","level":"warning","message":{"text":"ApiMutableServiceControllerBase.reconfigureAction (cognitive 22): ApiMutableServiceControllerBase.reconfigureAction has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (17 pts), ternaries 1 (3 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableServiceControllerBase.php"},"region":{"startLine":186}}}],"partialFingerprints":{"codehealthFindingId/v1":"7cde58c88f756126485aa34463d225b5ffc4584c87c46238bba9722d481b9272"}},{"ruleId":"D2","level":"warning","message":{"text":"SettingsController.getRuleInfoAction (cognitive 22): SettingsController.getRuleInfoAction has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 2 (5 pts), boolean chains 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IDS/Api/SettingsController.php"},"region":{"startLine":147}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd9f04e33c6332bb660fd75c3b7de0d5543ebe14ed6afaadf0e1e68a25693b3f"}},{"ruleId":"D2","level":"warning","message":{"text":"VipSettingsController.delItemAction (cognitive 22): VipSettingsController.delItemAction has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (14 pts), loops 3 (6 pts), boolean chains 1, ternaries 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/VipSettingsController.php"},"region":{"startLine":186}}}],"partialFingerprints":{"codehealthFindingId/v1":"d8f1cdfca2480deb28d133dbbee5d41a6a7a33fb8fee680c85501cfaa732371f"}},{"ruleId":"D2","level":"warning","message":{"text":"ExportController.openvpnServers (cognitive 22): ExportController.openvpnServers has cognitive complexity 22 (threshold 15). Drivers by points: ternaries 3 (10 pts), if/else 3 (7 pts), boolean chains 3, loops 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ExportController.php"},"region":{"startLine":97}}}],"partialFingerprints":{"codehealthFindingId/v1":"6c2a920d8a2b51772f7f10f27e8791923ca58645ab3d5b0ab5767aca6f362403"}},{"ruleId":"D2","level":"warning","message":{"text":"Util.smallestCIDR (cognitive 22): Util.smallestCIDR has cognitive complexity 22 (threshold 15). Drivers by points: loops 6 (14 pts), if/else 4 (8 pts) (nesting depth added 12). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php"},"region":{"startLine":560}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ce3bf072844abf59f8ce94ce6203d42576e30cc00edc9141a1ce2afdca55e84"}},{"ruleId":"D2","level":"warning","message":{"text":"IPsecIkev1Status.collectStatus (cognitive 22): IPsecIkev1Status.collectStatus has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (10 pts), boolean chains 4, loops 2 (4 pts), ternaries 1 (4 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/System/Status/IPsecIkev1Status.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce347048e771a802c7bd6f0b49af2a60ca458db2e4903ecef6212e85bd75e221"}},{"ruleId":"D2","level":"warning","message":{"text":"GroupMembershipField.actionPostLoadingEvent (cognitive 22): GroupMembershipField.actionPostLoadingEvent has cognitive complexity 22 (threshold 15). Drivers by points: if/else 4 (11 pts), loops 3 (11 pts) (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Auth/FieldTypes/GroupMembershipField.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"42063f72eadf51aa3ca5080620631b36b4e7c6f41eabe604b636a19fc98356c3"}},{"ruleId":"D2","level":"warning","message":{"text":"Dnsmasq.getDhcpInterfaces (cognitive 22): Dnsmasq.getDhcpInterfaces has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 3 (8 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php"},"region":{"startLine":444}}}],"partialFingerprints":{"codehealthFindingId/v1":"e45e4765904a5ebc436a6c576bb285ab8d4067b116a7f7ffb75883140c54a8b4"}},{"ruleId":"D2","level":"warning","message":{"text":"Group.whereUsed (cognitive 22): Group.whereUsed has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (12 pts), boolean chains 4, loops 2 (3 pts), ternaries 1 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Group.php"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"db928eaa5a544f5da3f8387c71a70248a1a6a28201f4b40cf1eda92cf4b5a4bd"}},{"ruleId":"D2","level":"warning","message":{"text":"Menu.collect (cognitive 22): Menu.collect has cognitive complexity 22 (threshold 15). Drivers by points: if/else 7 (11 pts), boolean chains 4, ternaries 1 (4 pts), loops 2 (3 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Menu/Menu.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f953c8a95dec8fb7bdb49420497bf51082a95303cfee0c2dbe4017eedb770c0"}},{"ruleId":"D2","level":"warning","message":{"text":"OpenVPN.run (cognitive 22): OpenVPN.run has cognitive complexity 22 (threshold 15). Drivers by points: if/else 3 (9 pts), loops 2 (6 pts), ternaries 1 (6 pts), boolean chains 1 (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/health/library/OPNsense/RRD/Stats/OpenVPN.php"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"200bed6caecef74fa04de95e9f5364042bca2189e73d9a2792becad20d763cdf"}},{"ruleId":"D2","level":"warning","message":{"text":"Config.get_zones (cognitive 22): Config.get_zones has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (14 pts), loops 2 (6 pts), boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/lib/__init__.py"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2700841c06a80c1c69851fa732d78405b854906da3c665ecb15a1f07d60e150"}},{"ruleId":"D2","level":"warning","message":{"text":"BGPASN._update (cognitive 22): BGPASN._update has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (14 pts), error handling 2 (4 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/bgpasn.py"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"381973fe43214e24c1946dab53e2d1725e0ab42a85474a78d443034d69e86026"}},{"ruleId":"D2","level":"warning","message":{"text":"pfstatistics.pfctl_rules (cognitive 22): pfstatistics.pfctl_rules has cognitive complexity 22 (threshold 15). Drivers by points: ternaries 2 (10 pts), loops 3 (7 pts), if/else 1 (3 pts), boolean chains 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/pfstatistics.py"},"region":{"startLine":99}}}],"partialFingerprints":{"codehealthFindingId/v1":"9b04992e1cec3c0fdbde80a2ffee74be0b10ef8293d85eb6cb6e987c02f9a2f8"}},{"ruleId":"D2","level":"warning","message":{"text":"BaseFlowAggregator.get_timeserie_data (cognitive 22): BaseFlowAggregator.get_timeserie_data has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (16 pts), loops 2 (5 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/netflow/lib/aggregates/__init__.py"},"region":{"startLine":242}}}],"partialFingerprints":{"codehealthFindingId/v1":"0526760ff50ea758962bd8a2470a6f7de8b4ea0a07974bcc75577adfe36929b5"}},{"ruleId":"D2","level":"warning","message":{"text":"ovpn_event.main (cognitive 22): ovpn_event.main has cognitive complexity 22 (threshold 15). Drivers by points: if/else 12 (21 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/openvpn/ovpn_event.py"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c80dff6ef99fbd723b743df32c72a2a06c83f8d6cd4ee208489e95b0498f71f"}},{"ruleId":"D2","level":"warning","message":{"text":"ovpn_status.ovpn_status (cognitive 22): ovpn_status.ovpn_status has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 3 (7 pts), ternaries 1 (3 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/openvpn/ovpn_status.py"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"3253db8a64cf132fb77e9c36dc4160116d37da6d46accf8cbc620b08fa3d9865"}},{"ruleId":"D2","level":"warning","message":{"text":"BaseBlocklistHandler._uri_reader (cognitive 22): BaseBlocklistHandler._uri_reader has cognitive complexity 22 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/blocklists/__init__.py"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"6d75eb59c57f4e83e0bef50099b7cd06cd5c53b14f4c1fc576e2c961831cf8c4"}},{"ruleId":"D2","level":"warning","message":{"text":"DNSReader._read (cognitive 22): DNSReader._read has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (15 pts), error handling 1 (4 pts), loops 1 (2 pts), ternaries 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/logger.py"},"region":{"startLine":138}}}],"partialFingerprints":{"codehealthFindingId/v1":"07a797bde36eee321bd231888a677214080cf2c18108a90b8e98a190d2792f6a"}},{"ruleId":"D2","level":"warning","message":{"text":"_renderFooterCommands (cognitive 22): _renderFooterCommands has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (8 pts), ternaries 3 (6 pts), boolean chains 5, other 2, loops 1 (nesting depth added 6). Of this number, 19 points are the body\u0027s own statements and 3 belong to 5 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1350}}}],"partialFingerprints":{"codehealthFindingId/v1":"635d34d40333724e6138528ccec560ab542eeefd1dfee406a18d9e0493932437"}},{"ruleId":"D2","level":"warning","message":{"text":"UserController.setBaseHook (cognitive 21): UserController.setBaseHook has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (11 pts), boolean chains 5, loops 2 (4 pts), ternaries 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Auth/Api/UserController.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"0fdba5eeab04806606bb79718f5fe5bdc63b534b1fb166c79c4d6bfbc5759a9f"}},{"ruleId":"D2","level":"warning","message":{"text":"ApiMutableModelControllerBase.setBase (cognitive 21): ApiMutableModelControllerBase.setBase has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (18 pts), boolean chains 3 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php"},"region":{"startLine":590}}}],"partialFingerprints":{"codehealthFindingId/v1":"f009404028ad59686843b2d513535e5d7282162c3796d391b155c100acb4d157"}},{"ruleId":"D2","level":"warning","message":{"text":"SettingsController.toggleRulesetAction (cognitive 21): SettingsController.toggleRulesetAction has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (16 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IDS/Api/SettingsController.php"},"region":{"startLine":394}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a1d5c413226abc945d4bc083335b8e370cddeaeda7f435a7e774c74f095f8d8"}},{"ruleId":"D2","level":"warning","message":{"text":"TunnelController.delPhase1Action (cognitive 21): TunnelController.delPhase1Action has cognitive complexity 21 (threshold 15). Drivers by points: if/else 4 (11 pts), loops 3 (10 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php"},"region":{"startLine":261}}}],"partialFingerprints":{"codehealthFindingId/v1":"88587e8b67bcfd812b8a85e8974a18e46a16dedb03dee27e8b5b73704ef21f5d"}},{"ruleId":"D2","level":"warning","message":{"text":"GroupSettingsController.searchAction (cognitive 21): GroupSettingsController.searchAction has cognitive complexity 21 (threshold 15). Drivers by points: if/else 4 (14 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/GroupSettingsController.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"815049f8257d11c176c02315876dc7b16ff9b93f90c8043f052b8947b679b2d7"}},{"ruleId":"D2","level":"warning","message":{"text":"AuthenticationFactory.authenticate (cognitive 21): AuthenticationFactory.authenticate has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (15 pts), ternaries 3, loops 1 (2 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/AuthenticationFactory.php"},"region":{"startLine":187}}}],"partialFingerprints":{"codehealthFindingId/v1":"65412b28076d72859570a87d3f39f4472507e5dd2a0354f56857aa358bd6799d"}},{"ruleId":"D2","level":"warning","message":{"text":"Base.groups (cognitive 21): Base.groups has cognitive complexity 21 (threshold 15). Drivers by points: if/else 4 (13 pts), loops 2 (8 pts) (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Base.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d923b67baa098e159b4d403bb5b009c7d69ae165d75a366363478e4405ed54b"}},{"ruleId":"D2","level":"warning","message":{"text":"ConfigMaintenance.traverseConfig (cognitive 21): ConfigMaintenance.traverseConfig has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (12 pts), ternaries 1 (5 pts), boolean chains 3, loops 1 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Core/ConfigMaintenance.php"},"region":{"startLine":91}}}],"partialFingerprints":{"codehealthFindingId/v1":"a107b6c247c0c2d9299572d1d2b28f7b319d1f86420e82977d073fbb4fd0ed7b"}},{"ruleId":"D2","level":"warning","message":{"text":"CrashReporterStatus.collectStatus (cognitive 21): CrashReporterStatus.collectStatus has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (12 pts), boolean chains 4, ternaries 1 (3 pts), loops 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/System/Status/CrashReporterStatus.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"300153221b62804d3e41fee2a5f8991ad9eb545b8c53a24f2bdb1470cc2540be"}},{"ruleId":"D2","level":"warning","message":{"text":"Store.createCert (cognitive 21): Store.createCert has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (16 pts), ternaries 1 (4 pts), boolean chains 1 (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Trust/Store.php"},"region":{"startLine":336}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd03eddc68f115ded99b78b7b9c7a165def54889b503f233a06dc1d7b4fd7bea"}},{"ruleId":"D2","level":"warning","message":{"text":"ProtocolField.actionPostLoadingEvent (cognitive 21): ProtocolField.actionPostLoadingEvent has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 3, ternaries 2, boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ProtocolField.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"53690fd9c09ed0a40e02c6095e55a111b0f8140d40ac9e8faa2b58bbb2be2dfc"}},{"ruleId":"D2","level":"warning","message":{"text":"SPDField.getStaticChildren (cognitive 21): SPDField.getStaticChildren has cognitive complexity 21 (threshold 15). Drivers by points: if/else 4 (8 pts), loops 3 (8 pts), ternaries 1 (4 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/FieldTypes/SPDField.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"209f6c538d47112e8f3f249be4267858ec672d4fd3a2703b1b770c3e70ab414c"}},{"ruleId":"D2","level":"warning","message":{"text":"Gif.performValidation (cognitive 21): Gif.performValidation has cognitive complexity 21 (threshold 15). Drivers by points: ternaries 4 (10 pts), if/else 4 (9 pts), boolean chains 1, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Gif.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fae6579d99aa553c8889d4b2be33409777456833b89da084cc33191b77fa7cf"}},{"ruleId":"D2","level":"warning","message":{"text":"Gre.performValidation (cognitive 21): Gre.performValidation has cognitive complexity 21 (threshold 15). Drivers by points: ternaries 4 (10 pts), if/else 4 (9 pts), boolean chains 1, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Gre.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"2911814e5881cba5aeee7e17c32a765a32ca3465233c39a84eda900f81c3438b"}},{"ruleId":"D2","level":"warning","message":{"text":"Vip.whereUsed (cognitive 21): Vip.whereUsed has cognitive complexity 21 (threshold 15). Drivers by points: if/else 3 (11 pts), loops 4 (9 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Vip.php"},"region":{"startLine":234}}}],"partialFingerprints":{"codehealthFindingId/v1":"07c923b0ca7ae204a1d099dd1856a55181610f479227a057e43eafc3e50775e0"}},{"ruleId":"D2","level":"warning","message":{"text":"register.plugins_disk_get (cognitive 21): register.plugins_disk_get has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (13 pts), boolean chains 4, loops 2 (4 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/firmware/register.php"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"87968dce504a5443540d472f48ca6defe769039bd557af9d8e89c96d0121fc84"}},{"ruleId":"D2","level":"warning","message":{"text":"BaseContentParser.iter_addresses (cognitive 21): BaseContentParser.iter_addresses has cognitive complexity 21 (threshold 15). Drivers by points: if/else 5 (8 pts), loops 2 (5 pts), error handling 2 (4 pts), ternaries 1 (3 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/base.py"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"6be672066a679f1c459f845a76a4ebf03c1607972d7eff8a50c0625e41f3004a"}},{"ruleId":"D2","level":"warning","message":{"text":"FlowParser._parse_binary (cognitive 21): FlowParser._parse_binary has cognitive complexity 21 (threshold 15). Drivers by points: if/else 4 (10 pts), error handling 1 (5 pts), ternaries 1 (5 pts), loops 1 (nesting depth added 14). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/netflow/lib/flowparser.py"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"ce0004f5f9248169d0cea6081eb524a1093439066d7d07de8948c6a2c26fd169"}},{"ruleId":"D2","level":"warning","message":{"text":"tokenize2.Tokenize2.keydown (cognitive 21): tokenize2.Tokenize2.keydown has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (19 pts), match/switch 1 (2 pts) (nesting depth added 12). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/tokenize2.js"},"region":{"startLine":447}}}],"partialFingerprints":{"codehealthFindingId/v1":"fcb4b438d8577a6bfe70c537811a0444b7b696e25cb09494be6ec59a4b3eaa4a"}},{"ruleId":"D2","level":"warning","message":{"text":"updateValueRange (cognitive 21): updateValueRange has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (12 pts), ternaries 2 (6 pts), boolean chains 2, loops 1 (nesting depth added 7). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/smoothie.js"},"region":{"startLine":784}}}],"partialFingerprints":{"codehealthFindingId/v1":"d3f5f2815664c7cae3cc3b0dd83e6f5e1ff6d186521c41512bf5582088c9d360"}},{"ruleId":"D2","level":"warning","message":{"text":"qrcode::qrcode::setupPositionAdjustPattern (cognitive 21): qrcode::qrcode::setupPositionAdjustPattern has cognitive complexity 21 (threshold 15). Drivers by points: loops 4 (10 pts), if/else 3 (9 pts), boolean chains 2 (nesting depth added 12). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":133}}}],"partialFingerprints":{"codehealthFindingId/v1":"188682c5db40e0698e1f16426dab4e4debdab4b8444f2cc80c97a0d3a01e5e45"}},{"ruleId":"D2","level":"warning","message":{"text":"qrcode::qrcode::createBytes (cognitive 21): qrcode::qrcode::createBytes has cognitive complexity 21 (threshold 15). Drivers by points: loops 8 (12 pts), if/else 2 (6 pts), ternaries 1 (3 pts) (nesting depth added 10). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":267}}}],"partialFingerprints":{"codehealthFindingId/v1":"92d1b389dfd3c6a0789396a698e62aaf388b153d1acb45b84228e7f5f62cb2a2"}},{"ruleId":"D2","level":"warning","message":{"text":"setStyle (cognitive 21): setStyle has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (17 pts), boolean chains 4 (nesting depth added 5). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1841}}}],"partialFingerprints":{"codehealthFindingId/v1":"a6703044f4e8376766dd349bc8739a790097239c52d571e5780ca8aa6ee2e06c"}},{"ruleId":"D2","level":"warning","message":{"text":"FilterBaseController.listCategoriesAction (cognitive 20): FilterBaseController.listCategoriesAction has cognitive complexity 20 (threshold 15). Drivers by points: if/else 3 (9 pts), loops 4 (9 pts), ternaries 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php"},"region":{"startLine":166}}}],"partialFingerprints":{"codehealthFindingId/v1":"46e56a477e31aaa4736516ace58b7ff38cb6bcb94238a480e39a4abdffd49223"}},{"ruleId":"D2","level":"warning","message":{"text":"TunnelController.togglePhase2Action (cognitive 20): TunnelController.togglePhase2Action has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (10 pts), ternaries 2 (8 pts), boolean chains 2 (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php"},"region":{"startLine":355}}}],"partialFingerprints":{"codehealthFindingId/v1":"c07e3011e84c88aa8d3d0159e76cc063e251793b28b3083c2501f8b7b8d5f449"}},{"ruleId":"D2","level":"warning","message":{"text":"DiagnosticsController.testBlocklistAction (cognitive 20): DiagnosticsController.testBlocklistAction has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (16 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 13). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Unbound/Api/DiagnosticsController.php"},"region":{"startLine":116}}}],"partialFingerprints":{"codehealthFindingId/v1":"5522008fda9485912e814cfcb7a1dfaa893c78ff2880458f7935a9a423554dd5"}},{"ruleId":"D2","level":"warning","message":{"text":"Voucher.generateVouchers (cognitive 20): Voucher.generateVouchers has cognitive complexity 20 (threshold 15). Drivers by points: if/else 4 (9 pts), loops 3 (9 pts), ternaries 1 (2 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Voucher.php"},"region":{"startLine":193}}}],"partialFingerprints":{"codehealthFindingId/v1":"e825f28808d8b68584426d337f8f8a5100b520de996d7b12b3c521f60a6f10ab"}},{"ruleId":"D2","level":"warning","message":{"text":"Util.aliasSummary (cognitive 20): Util.aliasSummary has cognitive complexity 20 (threshold 15). Drivers by points: if/else 6 (18 pts), loops 1 (2 pts) (nesting depth added 13). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php"},"region":{"startLine":273}}}],"partialFingerprints":{"codehealthFindingId/v1":"1b7cb0aad013624d73ae45ea18da168c2b985250b5d811931cee4f6c5bb4e5bc"}},{"ruleId":"D2","level":"warning","message":{"text":"ACL.mergePluggableACLs (cognitive 20): ACL.mergePluggableACLs has cognitive complexity 20 (threshold 15). Drivers by points: if/else 4 (13 pts), loops 3 (7 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/ACL.php"},"region":{"startLine":168}}}],"partialFingerprints":{"codehealthFindingId/v1":"c7734eb92a3f56fe226aeb675e3d9083348e7963cc232b1ba7b20d1a6264c0cb"}},{"ruleId":"D2","level":"warning","message":{"text":"InterfaceField.actionPostLoadingEvent (cognitive 20): InterfaceField.actionPostLoadingEvent has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (10 pts), loops 2 (6 pts), ternaries 1 (4 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Diagnostics/FieldTypes/InterfaceField.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"427d6bcf133e7b35437413898c11ba439a789e68c58e08c36e343beb1b22320f"}},{"ruleId":"D2","level":"warning","message":{"text":"Netflow.performValidation (cognitive 20): Netflow.performValidation has cognitive complexity 20 (threshold 15). Drivers by points: if/else 4 (8 pts), ternaries 2 (8 pts), boolean chains 2, loops 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Diagnostics/Netflow.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad7a90f79b2a63d15b0977a4eb52993bcd24102e6f1ead867f15253fde235484"}},{"ruleId":"D2","level":"warning","message":{"text":"Alias.performValidation (cognitive 20): Alias.performValidation has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (13 pts), boolean chains 4, match/switch 1 (2 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c0b6131550169165b2e82375917e0810553aef35509d79026b211b342c2ff71"}},{"ruleId":"D2","level":"warning","message":{"text":"SourceNatRuleContainerField.serialize (cognitive 20): SourceNatRuleContainerField.serialize has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (15 pts), boolean chains 2, ternaries 1 (2 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/SourceNatRuleField.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"133e4fc5bd4d5e92b8723aca75c51df6d94628d6efd14a1d456248c4064af9a6"}},{"ruleId":"D2","level":"warning","message":{"text":"Group.refactor (cognitive 20): Group.refactor has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (14 pts), boolean chains 3, loops 2 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Group.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"343a32383547d129b46634148db56e211c6d10cc57aee8c2ef021ad3ca0d283e"}},{"ruleId":"D2","level":"warning","message":{"text":"M1_0_7.run (cognitive 20): M1_0_7.run has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (13 pts), boolean chains 5, loops 2 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IDS/Migrations/M1_0_7.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"b7df8048044642aae47609e2ea4c9d0883e681fbf7d03e1ad2b01e1859219d82"}},{"ruleId":"D2","level":"warning","message":{"text":"NetworkInterfaceContainerField.fromLegacy (cognitive 20): NetworkInterfaceContainerField.fromLegacy has cognitive complexity 20 (threshold 15). Drivers by points: ternaries 5 (9 pts), if/else 5 (7 pts), boolean chains 2, loops 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/NetworkInterfaceField.php"},"region":{"startLine":140}}}],"partialFingerprints":{"codehealthFindingId/v1":"e2715c80da8a43e3c31f447d88f70c4e7df157e576d75e37c6cedda10244c733"}},{"ruleId":"D2","level":"warning","message":{"text":"Vip.findSubnet (cognitive 20): Vip.findSubnet has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (13 pts), boolean chains 4, match/switch 1 (2 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Vip.php"},"region":{"startLine":287}}}],"partialFingerprints":{"codehealthFindingId/v1":"d6f1158f69ec8ab3314ea6003ab39d954595d7c98d8b72d6de52cefa97e1ccb6"}},{"ruleId":"D2","level":"warning","message":{"text":"Route.performValidation (cognitive 20): Route.performValidation has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (9 pts), ternaries 3 (7 pts), boolean chains 3, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routes/Route.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"b6ca260357a812b292376a8bc3d4576be35178e6a6fb1148210bd64d2bbfcfd7"}},{"ruleId":"D2","level":"warning","message":{"text":"Main.run (cognitive 20): Main.run has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 2 (4 pts), error handling 1 (2 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/netflow/flowd_aggregate.py"},"region":{"startLine":140}}}],"partialFingerprints":{"codehealthFindingId/v1":"7ac5f0982c846b2307830b7c28e6846dc28c1502b8f4edd87fe91cd42427648f"}},{"ruleId":"D2","level":"warning","message":{"text":"flowd_aggregate.check_rotate (cognitive 20): flowd_aggregate.check_rotate has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (13 pts), error handling 1 (4 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/netflow/flowd_aggregate.py"},"region":{"startLine":91}}}],"partialFingerprints":{"codehealthFindingId/v1":"63e71444f8293b0fef52e3d25db7e1f36ad6fb3cf86da7335db824efb5903448"}},{"ruleId":"D2","level":"warning","message":{"text":"ModuleContext.set_config (cognitive 20): ModuleContext.set_config has cognitive complexity 20 (threshold 15). Drivers by points: error handling 2 (7 pts), if/else 3 (6 pts), loops 2 (4 pts), ternaries 1 (2 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound-dnsbl/lib/__init__.py"},"region":{"startLine":140}}}],"partialFingerprints":{"codehealthFindingId/v1":"9e7c4bb52e05c420953bf02b675d858daf3907d6d1350146d94185a031f25bac"}},{"ruleId":"D2","level":"warning","message":{"text":"stats.handle_rolling (cognitive 20): stats.handle_rolling has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (11 pts), loops 2 (8 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/stats.py"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"00c4190dc757d0937340d297b9cc9c48682c0a84ba8f8e99b03e93aafb28af2b"}},{"ruleId":"D2","level":"warning","message":{"text":"OpenVPNClients.updateClients (cognitive 20): OpenVPNClients.updateClients has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (15 pts), boolean chains 2, ternaries 1 (2 pts), loops 1 (nesting depth added 7). Most of this is not in the body itself: 8 of the 20 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 75, 100). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/OpenVPNClients.js"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"d37a63cb4f884067971caa021ca976c356e07ecbe1dc6922fc536b1bb51c6cb8"}},{"ruleId":"D2","level":"warning","message":{"text":"PrivController.setItemAction (cognitive 19): PrivController.setItemAction has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (9 pts), loops 2 (5 pts), ternaries 1 (3 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Auth/Api/PrivController.php"},"region":{"startLine":108}}}],"partialFingerprints":{"codehealthFindingId/v1":"b50ea9fc066578d87abed151df97510541976f5f9c8f3d4826db1111673d4cee"}},{"ruleId":"D2","level":"warning","message":{"text":"AliasController.searchItemAction (cognitive 19): AliasController.searchItemAction has cognitive complexity 19 (threshold 15). Drivers by points: if/else 3 (9 pts), loops 3 (5 pts), boolean chains 3, ternaries 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"f1dd5f537003e5ab581eccffe9f5065a78047543314cf06ed26e25ee35f1579d"}},{"ruleId":"D2","level":"warning","message":{"text":"SettingsController.updateBlocklistAction (cognitive 19): SettingsController.updateBlocklistAction has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (11 pts), boolean chains 6, loops 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Unbound/Api/SettingsController.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"271f8faa3b1c6abbcaf60ff2506c9b9f6dc2621f1ee33c43f13afbe98a3c3591"}},{"ruleId":"D2","level":"warning","message":{"text":"BaseField.getConstraintValidators (cognitive 19): BaseField.getConstraintValidators has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (17 pts), boolean chains 1, loops 1 (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php"},"region":{"startLine":631}}}],"partialFingerprints":{"codehealthFindingId/v1":"b599b83a29ba7dec377d535cac1108347922f39fc00adeffdece3114e2a92796"}},{"ruleId":"D2","level":"warning","message":{"text":"PortField.actionPostLoadingEvent (cognitive 19): PortField.actionPostLoadingEvent has cognitive complexity 19 (threshold 15). Drivers by points: if/else 4 (9 pts), loops 3 (8 pts), ternaries 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php"},"region":{"startLine":134}}}],"partialFingerprints":{"codehealthFindingId/v1":"fcdf693518f376ba95955c93d056dd07cc83124f31a08ee9701545b03045a2a2"}},{"ruleId":"D2","level":"warning","message":{"text":"MenuSystem.__construct (cognitive 19): MenuSystem.__construct has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (10 pts), loops 3 (4 pts), error handling 1 (3 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuSystem.php"},"region":{"startLine":185}}}],"partialFingerprints":{"codehealthFindingId/v1":"7192533dc082e39959131d43b8d7530261a06c5bfc4c576bb2efe7d25e56062b"}},{"ruleId":"D2","level":"warning","message":{"text":"Alias.searchConfig (cognitive 19): Alias.searchConfig has cognitive complexity 19 (threshold 15). Drivers by points: loops 4 (10 pts), if/else 3 (9 pts) (nesting depth added 12). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.php"},"region":{"startLine":151}}}],"partialFingerprints":{"codehealthFindingId/v1":"9c345ead7a201390f1fd359b53d92cd5bda9e22d38a8ff78c7b9ab365b4b9482"}},{"ruleId":"D2","level":"warning","message":{"text":"Bridge.performValidation (cognitive 19): Bridge.performValidation has cognitive complexity 19 (threshold 15). Drivers by points: if/else 4 (11 pts), loops 3 (6 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Bridge.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"d7e9505b99f2b2d5845b9e72a65b7adf7ea7c9fb5b3014cb3ec023546bc8d69b"}},{"ruleId":"D2","level":"warning","message":{"text":"AliasReflector.setValue (cognitive 19): AliasReflector.setValue has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (13 pts), loops 3 (4 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Unbound/FieldTypes/AliasReflector.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"d5a74a22de1474591f48a6f44009977d07acc593a624a2e2ac1e37a749e53c90"}},{"ruleId":"D2","level":"warning","message":{"text":"GEOIP.process_gzip (cognitive 19): GEOIP.process_gzip has cognitive complexity 19 (threshold 15). Drivers by points: ternaries 3 (9 pts), if/else 2 (5 pts), boolean chains 2, loops 2, error handling 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/geoip.py"},"region":{"startLine":103}}}],"partialFingerprints":{"codehealthFindingId/v1":"0329f9ef37fbd785f2171a4230d74743850c469006487a0affcba0f58ae587d0"}},{"ruleId":"D2","level":"warning","message":{"text":"InterfaceParser._update (cognitive 19): InterfaceParser._update has cognitive complexity 19 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 2 (4 pts), boolean chains 3 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/interface.py"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"e8f5c4346e1b183e67aff8b01ece6e92080848564fd1c525850430c2f56e0bf7"}},{"ruleId":"D2","level":"warning","message":{"text":"kea_prefix_watcher.yield_lease_records (cognitive 19): kea_prefix_watcher.yield_lease_records has cognitive complexity 19 (threshold 15). Drivers by points: if/else 4 (12 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/kea/kea_prefix_watcher.py"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"2f489aba06079b04baba4d0e1ab6a673dfd4761e5ebbea1546d64850c972578f"}},{"ruleId":"D2","level":"warning","message":{"text":"lib.parse_flow (cognitive 19): lib.parse_flow has cognitive complexity 19 (threshold 15). Drivers by points: ternaries 8 (16 pts), boolean chains 2, if/else 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/shaper/lib/__init__.py"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"9a759849f9451ca7caa136268803dc905f9c37fa168b0c502bebb7377381304b"}},{"ruleId":"D2","level":"warning","message":{"text":"LogMatcher.live_match_records (cognitive 19): LogMatcher.live_match_records has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (12 pts), error handling 1 (2 pts), loops 1 (2 pts), ternaries 1 (2 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/syslog/log_matcher.py"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"e6e21c5aff7178859f3b880d6334215260fa9b0650d0e33b3d39f0819d684d8c"}},{"ruleId":"D2","level":"warning","message":{"text":"crl_fetch.fetch_crl (cognitive 19): crl_fetch.fetch_crl has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (9 pts), loops 2 (5 pts), error handling 2 (3 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/system/crl_fetch.py"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"64a2a7dba729d0d2225cc471bc553a0abd1e799557e71ade6c0b59736bfd9000"}},{"ruleId":"D2","level":"warning","message":{"text":"dropdownSelectionMove (cognitive 19): dropdownSelectionMove has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (12 pts), ternaries 2 (7 pts) (nesting depth added 10). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/tokenize2.js"},"region":{"startLine":814}}}],"partialFingerprints":{"codehealthFindingId/v1":"384084c4f95c7f82831d98c1e193ee56b3fcb3908a9e3d702d931a5625ea343c"}},{"ruleId":"D2","level":"warning","message":{"text":"searchValidTarget (cognitive 19): searchValidTarget has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (15 pts), boolean chains 3, loops 1 (nesting depth added 9). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/tokenize2.js"},"region":{"startLine":2287}}}],"partialFingerprints":{"codehealthFindingId/v1":"07ef30ba937c7cc8013241ffdbe5ba1a6b584231debc29e8b071b6267a91ce35"}},{"ruleId":"D2","level":"warning","message":{"text":"qrcode::qrcode::setupPositionProbePattern (cognitive 19): qrcode::qrcode::setupPositionProbePattern has cognitive complexity 19 (threshold 15). Drivers by points: if/else 4 (9 pts), boolean chains 7, loops 2 (3 pts) (nesting depth added 6). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"88577cc3038e515edca827a2e05dbe61872d45db7990007076c7d5b96d4614ee"}},{"ruleId":"D2","level":"warning","message":{"text":"qrcode::qrcode::_createHalfASCII (cognitive 19): qrcode::qrcode::_createHalfASCII has cognitive complexity 19 (threshold 15). Drivers by points: if/else 4 (8 pts), boolean chains 4, ternaries 2 (4 pts), loops 2 (3 pts) (nesting depth added 7). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":620}}}],"partialFingerprints":{"codehealthFindingId/v1":"6335acd871834400c647e9900f229931ccad436af77ee566745c77badcbc158e"}},{"ruleId":"D2","level":"warning","message":{"text":"searchValidTarget (cognitive 19): searchValidTarget has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (15 pts), boolean chains 3, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":313}}}],"partialFingerprints":{"codehealthFindingId/v1":"87276aadb4fd7a7705617131703436d206df208bbb73894e49729ef62e9dae68"}},{"ruleId":"D2","level":"warning","message":{"text":"SessionController.connectAction (cognitive 18): SessionController.connectAction has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/Api/SessionController.php"},"region":{"startLine":115}}}],"partialFingerprints":{"codehealthFindingId/v1":"173e5afa4500e515192a9f8f7d9c0165a912e353f87fa358ebafd10d93e39c8f"}},{"ruleId":"D2","level":"warning","message":{"text":"PacketCaptureController.viewAction (cognitive 18): PacketCaptureController.viewAction has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (8 pts), loops 2 (6 pts), ternaries 1 (4 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php"},"region":{"startLine":120}}}],"partialFingerprints":{"codehealthFindingId/v1":"2c72c03eaec1990510f1e81fd75a16403cb7aa018c139a4084959b9fac60e53c"}},{"ruleId":"D2","level":"warning","message":{"text":"SystemhealthController.getRrdListAction (cognitive 18): SystemhealthController.getRrdListAction has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 2 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/SystemhealthController.php"},"region":{"startLine":124}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae64ee259b063899fbccc1889eb797db16b613ef904bb30b9219cfb56ed07ae9"}},{"ruleId":"D2","level":"warning","message":{"text":"WirelessSettingsController.delItemAction (cognitive 18): WirelessSettingsController.delItemAction has cognitive complexity 18 (threshold 15). Drivers by points: if/else 3 (8 pts), loops 2 (5 pts), ternaries 1 (5 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/WirelessSettingsController.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"8d44d1bf5e757e7d1e8bfcc22c0bb6098c8e7c1d5c5ead6f1a3c222bc4fbc4e9"}},{"ruleId":"D2","level":"warning","message":{"text":"PortField.getValidators (cognitive 18): PortField.getValidators has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (13 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php"},"region":{"startLine":233}}}],"partialFingerprints":{"codehealthFindingId/v1":"20491f9d88e688562278cf546badbe760434db40cf419d635307c3ac4fb84ac5"}},{"ruleId":"D2","level":"warning","message":{"text":"HostnameField.getValidators (cognitive 18): HostnameField.getValidators has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (9 pts), ternaries 2 (5 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Dnsmasq/FieldTypes/HostnameField.php"},"region":{"startLine":127}}}],"partialFingerprints":{"codehealthFindingId/v1":"f33c8ef2e9f281633bf98fafc537dc19f57b64d733e8767f3e09ffe05ca05617"}},{"ruleId":"D2","level":"warning","message":{"text":"VxLan.performValidation (cognitive 18): VxLan.performValidation has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (11 pts), boolean chains 6, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/VxLan.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"747314c8eadab9020138132e0ccbecc3a5be7ede6adc444574d752a312244871"}},{"ruleId":"D2","level":"warning","message":{"text":"KeaDhcpv4.setNodes (cognitive 18): KeaDhcpv4.setNodes has cognitive complexity 18 (threshold 15). Drivers by points: if/else 3 (10 pts), loops 3 (8 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"7ea3f89f38ad29a9d7b47076fcfcf7a4a925b7bba498bab8603dd716d154d478"}},{"ruleId":"D2","level":"warning","message":{"text":"M1_0_0.run (cognitive 18): M1_0_0.run has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (11 pts), boolean chains 6, loops 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth \u2014 checks laid out side by side rather than stacked \u2014 so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Monit/Migrations/M1_0_0.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"6205542df1e3e4c9e91a05bef106e44efdbd6e2d9877da73aaa496b95a97a201"}},{"ruleId":"D2","level":"warning","message":{"text":"Gateways.convertType (cognitive 18): Gateways.convertType has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (11 pts), ternaries 2 (4 pts), boolean chains 3 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php"},"region":{"startLine":283}}}],"partialFingerprints":{"codehealthFindingId/v1":"707df809e80fa1bcbd1a4f9bac6b8a33e1e93016fa4b91ea4b1590a93ceebe0e"}},{"ruleId":"D2","level":"warning","message":{"text":"wg-service-control.get_vhid_status (cognitive 18): wg-service-control.get_vhid_status has cognitive complexity 18 (threshold 15). Drivers by points: if/else 3 (9 pts), loops 4 (9 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/wireguard/wg-service-control.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"e293ecff89ee5e6306338fd210ea71ddd1d62d633933525a37161ab66be5a537"}},{"ruleId":"D2","level":"warning","message":{"text":"Alias.expired (cognitive 18): Alias.expired has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (13 pts), ternaries 1 (3 pts), boolean chains 2 (nesting depth added 9). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/__init__.py"},"region":{"startLine":137}}}],"partialFingerprints":{"codehealthFindingId/v1":"1b95a771fe89f6a05c51133e11204f77454b2cd0dc0dc17a025661242b984cfc"}},{"ruleId":"D2","level":"warning","message":{"text":"BGPASN.iter_addresses (cognitive 18): BGPASN.iter_addresses has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/bgpasn.py"},"region":{"startLine":98}}}],"partialFingerprints":{"codehealthFindingId/v1":"e359d988302670a3975f22777d349f2af6f95363ecce068ec73a53b0bee678c4"}},{"ruleId":"D2","level":"warning","message":{"text":"pfstatistics.pfctl_info (cognitive 18): pfstatistics.pfctl_info has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (13 pts), ternaries 1 (4 pts), loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/pfstatistics.py"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"97eb072d88cc67fdbb1eb1cf395adef77356873847194e15fbbca85e4b3c98ac"}},{"ruleId":"D2","level":"warning","message":{"text":"BlocklistParser.update_blocklist (cognitive 18): BlocklistParser.update_blocklist has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 3 (7 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/blocklists/__init__.py"},"region":{"startLine":243}}}],"partialFingerprints":{"codehealthFindingId/v1":"40a777376f71184f41d0eabecd41c17bcd4550e3e2017797374ce148cad63836"}},{"ruleId":"D2","level":"warning","message":{"text":"DefaultBlocklistHandler._blocklist_reader (cognitive 18): DefaultBlocklistHandler._blocklist_reader has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (8 pts), loops 2 (4 pts), boolean chains 2, error handling 1 (2 pts), ternaries 1 (2 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/blocklists/default_bl.py"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"1963dc84ca40f78e7c3a7cc62a6aad75eb7847526f23e72cb53473fc7db53cbe"}},{"ruleId":"D2","level":"warning","message":{"text":"Action.execute (cognitive 18): Action.execute has cognitive complexity 18 (threshold 15). Drivers by points: error handling 5 (12 pts), if/else 2 (3 pts), loops 2 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/actions/stream_output.py"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"fcb68a33b824cec7744071a9150b50129bc239e49b2c11e1ec76ea5cf3a9051a"}},{"ruleId":"D2","level":"warning","message":{"text":"bootstrap.Affix.getState (cognitive 18): bootstrap.Affix.getState has cognitive complexity 18 (threshold 15). Drivers by points: ternaries 5 (9 pts), if/else 5 (6 pts), boolean chains 3 (nesting depth added 5). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap.js"},"region":{"startLine":2461}}}],"partialFingerprints":{"codehealthFindingId/v1":"9cf3823a4d42218b4100da8c460f131df64fcde234ec07fcd3caacb0eab492cf"}},{"ruleId":"D2","level":"warning","message":{"text":"init (cognitive 18): init has cognitive complexity 18 (threshold 15). Drivers by points: if/else 13 (14 pts), boolean chains 4 (nesting depth added 1). Most of this is not in the body itself: 6 of the 18 points are its own statements and the rest belongs to 13 function literals inside it that branch (lines 174, 218, 149, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/tokenize2.js"},"region":{"startLine":134}}}],"partialFingerprints":{"codehealthFindingId/v1":"86f9368af7ece6dbbfd3bcb150e1feb72ada42d5db48764a43a1cad5a44bd2d8"}},{"ruleId":"D2","level":"warning","message":{"text":"extend (cognitive 18): extend has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (14 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 10). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/smoothie.js"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc2af94a0a4af58955afd8f87eae413e7ce7f5fdb31b4743d2b9b3b03324ac6f"}},{"ruleId":"D2","level":"warning","message":{"text":"tree_delayed_live_search (cognitive 18): tree_delayed_live_search has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 9). None of this is in the body itself: all 18 points belong to 2 function literals inside it that branch (lines 152, 146). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense-treeview.js"},"region":{"startLine":142}}}],"partialFingerprints":{"codehealthFindingId/v1":"55fea714511ad9e050c29f2fa3821403b63692a39295834d2145e93035b6d5ab"}},{"ruleId":"D2","level":"warning","message":{"text":"createDropdown (cognitive 18): createDropdown has cognitive complexity 18 (threshold 15). Drivers by points: ternaries 8 (9 pts), if/else 5, boolean chains 4 (nesting depth added 1). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1057}}}],"partialFingerprints":{"codehealthFindingId/v1":"438550e195b5802f704b5f5e2701621b64d08bbf62575f4e98ca5d5ede6504ca"}},{"ruleId":"D2","level":"warning","message":{"text":"IXR_Server.call (cognitive 17): IXR_Server.call has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (15 pts), boolean chains 2 (nesting depth added 6). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/IXR/IXR_Library.php"},"region":{"startLine":411}}}],"partialFingerprints":{"codehealthFindingId/v1":"b067871de20316e46d715d6cc4ff24a2288f6116b74b3baee49ab002f0e9acad"}},{"ruleId":"D2","level":"warning","message":{"text":"SystemController.dismissStatusAction (cognitive 17): SystemController.dismissStatusAction has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (15 pts), boolean chains 2 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/SystemController.php"},"region":{"startLine":180}}}],"partialFingerprints":{"codehealthFindingId/v1":"61111c51822a7b00034306a0705e9646f848d52aed9857e27ba9c3f758adf507"}},{"ruleId":"D2","level":"warning","message":{"text":"LogController.__call (cognitive 17): LogController.__call has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (10 pts), ternaries 3 (5 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/LogController.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f7c15c2563b235986127b8efa0e83e9f5a0f7d85312876fa7f5be5095a1e452"}},{"ruleId":"D2","level":"warning","message":{"text":"NetflowController.setconfigAction (cognitive 17): NetflowController.setconfigAction has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 1 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/NetflowController.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"c4a47c724651b19cf58a25214c364184789736bcc4c6adc12783b6c47cca97bf"}},{"ruleId":"D2","level":"warning","message":{"text":"AliasController.listCountriesAction (cognitive 17): AliasController.listCountriesAction has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (10 pts), boolean chains 5, loops 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php"},"region":{"startLine":246}}}],"partialFingerprints":{"codehealthFindingId/v1":"092f267ec4ba17768180bbab027382a75d39896626df532da4a4d9afe4907575"}},{"ruleId":"D2","level":"warning","message":{"text":"AliasController.exportAction (cognitive 17): AliasController.exportAction has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php"},"region":{"startLine":373}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a6ebd98c458563b27acfd226b8c0f271fb36e994f7a53b3e7cf0f3d3216c0c4"}},{"ruleId":"D2","level":"warning","message":{"text":"FilterBaseController.getNetworks (cognitive 17): FilterBaseController.getNetworks has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (7 pts), loops 4 (7 pts), ternaries 1 (3 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php"},"region":{"startLine":101}}}],"partialFingerprints":{"codehealthFindingId/v1":"234751d4cfd8c2f598c35a147edaa76a83a3885252352849784f6e93f04d3d9c"}},{"ruleId":"D2","level":"warning","message":{"text":"FilterBaseController.uploadRulesBase (cognitive 17): FilterBaseController.uploadRulesBase has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (8 pts), loops 5 (7 pts), boolean chains 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php"},"region":{"startLine":530}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e49f4b0c241ad513f3e5946de06c0f8e867d79d895ab7a98b058cd2f4adc70f"}},{"ruleId":"D2","level":"warning","message":{"text":"VipSettingsController.setItemAction (cognitive 17): VipSettingsController.setItemAction has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (8 pts), ternaries 4 (6 pts), boolean chains 3 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/VipSettingsController.php"},"region":{"startLine":121}}}],"partialFingerprints":{"codehealthFindingId/v1":"cb738cdfa66c98d6e8dca826969b878d0c651f0fba2c7f5f36f465731855e582"}},{"ruleId":"D2","level":"warning","message":{"text":"LeasesController.searchAction (cognitive 17): LeasesController.searchAction has cognitive complexity 17 (threshold 15). Drivers by points: ternaries 5 (9 pts), if/else 3 (4 pts), boolean chains 2, loops 2 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Kea/Api/LeasesController.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"c443fcfe71da1cc0663c26c18d963c2df157ddd90c4388819dbd460db64408e0"}},{"ruleId":"D2","level":"warning","message":{"text":"CrlController.getOcspInfoDataAction (cognitive 17): CrlController.getOcspInfoDataAction has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (12 pts), loops 3 (5 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CrlController.php"},"region":{"startLine":427}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d48f2b9e14b330047f44a1e9bdbcbdeacaab9e25701990a79ed5ee7dd7a172b"}},{"ruleId":"D2","level":"warning","message":{"text":"CSVListField.getValidators (cognitive 17): CSVListField.getValidators has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 1 (3 pts), ternaries 1 (2 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/CSVListField.php"},"region":{"startLine":85}}}],"partialFingerprints":{"codehealthFindingId/v1":"7ee65511a3ab80eee1e5dc7941a1eb00de3975a280b7b79f71bbcf3197b18fcd"}},{"ruleId":"D2","level":"warning","message":{"text":"Firmware.performValidation (cognitive 17): Firmware.performValidation has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (13 pts), boolean chains 4 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/Firmware.php"},"region":{"startLine":98}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef816d3a9448de6f7d0ab778f1f4443b9384a66a35c912d37975b4530c1360e5"}},{"ruleId":"D2","level":"warning","message":{"text":"InitialSetup.flush_network_lan (cognitive 17): InitialSetup.flush_network_lan has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (11 pts), loops 2 (3 pts), boolean chains 2, ternaries 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/InitialSetup.php"},"region":{"startLine":374}}}],"partialFingerprints":{"codehealthFindingId/v1":"826909f5997f1d80e37d964420e385db5a717a67cf5df3ad608b7abfc9123ff0"}},{"ruleId":"D2","level":"warning","message":{"text":"Group.ruleIterator (cognitive 17): Group.ruleIterator has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Group.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"91b05d180a8258f3f363d1af16cdfbe737fc6e084295d2cdb828c2ac1adc3240"}},{"ruleId":"D2","level":"warning","message":{"text":"DUIDField.isValidDuid (cognitive 17): DUIDField.isValidDuid has cognitive complexity 17 (threshold 15). Drivers by points: boolean chains 8, if/else 6 (8 pts), loops 1 (nesting depth added 2). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/DUIDField.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"771f283ee1b55b6d3965d34982065c486e92b63c695b5d7ede661781ecd3fba0"}},{"ruleId":"D2","level":"warning","message":{"text":"flowd_aggregate.aggregate_flowd (cognitive 17): flowd_aggregate.aggregate_flowd has cognitive complexity 17 (threshold 15). Drivers by points: loops 6 (11 pts), if/else 2 (4 pts), boolean chains 2 (nesting depth added 7). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/netflow/flowd_aggregate.py"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"235b098b75a1657b3aa70278c1d5ae47d54c1258c86c4ca856502d26c075911f"}},{"ruleId":"D2","level":"warning","message":{"text":"BaseFlowAggregator.get_data (cognitive 17): BaseFlowAggregator.get_data has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/netflow/lib/aggregates/__init__.py"},"region":{"startLine":354}}}],"partialFingerprints":{"codehealthFindingId/v1":"c2a86e1baefcf694a76cc016fc4e54bb4a02ef95da89657709be780b5a3a5e62"}},{"ruleId":"D2","level":"warning","message":{"text":"aggregates.get_aggregators (cognitive 17): aggregates.get_aggregators has cognitive complexity 17 (threshold 15). Drivers by points: if/else 3 (11 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/netflow/lib/aggregates/__init__.py"},"region":{"startLine":385}}}],"partialFingerprints":{"codehealthFindingId/v1":"c3f1a1adcc92fddc8b35de0cba232168ed10b9bef0594717b6629ad0d04dd416"}},{"ruleId":"D2","level":"warning","message":{"text":"certctl.certificate_iterator (cognitive 17): certctl.certificate_iterator has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (11 pts), ternaries 2 (4 pts), error handling 1, loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/system/certctl.py"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0462f8c8c171bae53c53f66ac6a21e810a34e3b1998cce7d1f0d8cd220aa4ec"}},{"ruleId":"D2","level":"warning","message":{"text":"DefaultBlocklistHandler._parse_config (cognitive 17): DefaultBlocklistHandler._parse_config has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 2 (4 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/blocklists/default_bl.py"},"region":{"startLine":102}}}],"partialFingerprints":{"codehealthFindingId/v1":"8574a512614d2e01ee7c464ec5c9703f497f08a34556901dc872899e94cbbc53"}},{"ruleId":"D2","level":"warning","message":{"text":"log_helper.reverse_log_reader (cognitive 17): log_helper.reverse_log_reader has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (11 pts), loops 2 (3 pts), ternaries 1 (2 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/site-python/log_helper.py"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"81af234c02f339cddeee84454441408a916f7bb2f23ea6ff0983b985cb2b8722"}},{"ruleId":"D2","level":"warning","message":{"text":"bootstrap-select.sanitizeHtml (cognitive 17): bootstrap-select.sanitizeHtml has cognitive complexity 17 (threshold 15). Drivers by points: if/else 3 (8 pts), loops 3 (6 pts), boolean chains 3 (nesting depth added 8). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":116}}}],"partialFingerprints":{"codehealthFindingId/v1":"35a55dc35d4364d1c2a2c6de6f5e1d23d3005c24e2c95df0966a2eb435100874"}},{"ruleId":"D2","level":"warning","message":{"text":"UIBootgrid._onDataProcessed (cognitive 17): UIBootgrid._onDataProcessed has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (12 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1009}}}],"partialFingerprints":{"codehealthFindingId/v1":"99abeec73c232af00962a604cf9ff19fce6b3c853055fec012a3a6c5dc8445b0"}},{"ruleId":"D2","level":"warning","message":{"text":"opnsense_ui.initFormHelpUI (cognitive 17): opnsense_ui.initFormHelpUI has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (13 pts), boolean chains 2, loops 1, match/switch 1 (nesting depth added 3). Most of this is not in the body itself: 2 of the 17 points are its own statements and the rest belongs to 5 function literals inside it that branch (lines 432, 476, 505, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":423}}}],"partialFingerprints":{"codehealthFindingId/v1":"86028d7449467c33f21fb5b6f2a12feeedb73fc72ae8960f9c96afc116e4bf79"}},{"ruleId":"D2","level":"warning","message":{"text":"smoothie.SmoothieChart.resize (cognitive 17): smoothie.SmoothieChart.resize has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (15 pts), boolean chains 1, ternaries 1 (nesting depth added 7). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/smoothie.js"},"region":{"startLine":679}}}],"partialFingerprints":{"codehealthFindingId/v1":"9d1a8e642824fff32753ac54ad678fb941a421f462621d53bb2bb4b45de87aa2"}},{"ruleId":"D2","level":"warning","message":{"text":"tokenize2.Tokenize2.calculatezindex (cognitive 17): tokenize2.Tokenize2.calculatezindex has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (13 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 9). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/tokenize2.js"},"region":{"startLine":715}}}],"partialFingerprints":{"codehealthFindingId/v1":"da3a159e2c0f16d11734e0983db2f780049a84339fe223ba9217dc23f6ca0e3c"}},{"ruleId":"D2","level":"warning","message":{"text":"BaseTableWidget.updateTable (cognitive 17): BaseTableWidget.updateTable has cognitive complexity 17 (threshold 15). Drivers by points: if/else 12 (14 pts), boolean chains 2, ternaries 1 (nesting depth added 2). Most of this is not in the body itself: 3 of the 17 points are its own statements and the rest belongs to one function literal inside it that branches (line 163). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal\u0027s work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/BaseTableWidget.js"},"region":{"startLine":144}}}],"partialFingerprints":{"codehealthFindingId/v1":"159691c57f0949b18adff938fef327222a26cc6b72ad76ec8e79963749bb72bd"}},{"ruleId":"D2","level":"warning","message":{"text":"_makeOptionField (cognitive 17): _makeOptionField has cognitive complexity 17 (threshold 15). Drivers by points: if/else 5 (6 pts), other 5, boolean chains 4, loops 1 (2 pts) (nesting depth added 2). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":350}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd5e1c0e796d8473aebf9809e2db552b510edceb8607f592c3eaf245f424f45f"}},{"ruleId":"D2","level":"warning","message":{"text":"init (cognitive 17): init has cognitive complexity 17 (threshold 15). Drivers by points: if/else 13 (16 pts), boolean chains 1 (nesting depth added 3). Of this number, 13 points are the body\u0027s own statements and 4 belong to 10 function items inside it that branch. This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":938}}}],"partialFingerprints":{"codehealthFindingId/v1":"cdbe9d25218bd9ad5c474c3f7da496ededef1d079a5f2e631cf555e34ebcef5b"}},{"ruleId":"D2","level":"warning","message":{"text":"processTunnels (cognitive 17): processTunnels has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (8 pts), ternaries 7, boolean chains 2 (nesting depth added 1). None of this is in the body itself: all 17 points belong to 6 function literals inside it that branch (lines 82, 117, 140, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/Wireguard.js"},"region":{"startLine":77}}}],"partialFingerprints":{"codehealthFindingId/v1":"f113cabdd7eb035b39191b6f1fa3b36d0d3487f69bdd61f63386e03c96442fd2"}},{"ruleId":"D2","level":"warning","message":{"text":"BackupController.diffAction (cognitive 16): BackupController.diffAction has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (9 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/BackupController.php"},"region":{"startLine":109}}}],"partialFingerprints":{"codehealthFindingId/v1":"93ceace9c6ff7a48867da4cc0c9192e6e543ccaf0ea27fc7789e5f5f66f85d85"}},{"ruleId":"D2","level":"warning","message":{"text":"SnapshotsController.addAction (cognitive 16): SnapshotsController.addAction has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (15 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/SnapshotsController.php"},"region":{"startLine":214}}}],"partialFingerprints":{"codehealthFindingId/v1":"f88ca0f5b257e1e875ca72189d33a163df5ebae9af3727202f200d1fecf7fe5c"}},{"ruleId":"D2","level":"warning","message":{"text":"TunablesController.resetAction (cognitive 16): TunablesController.resetAction has cognitive complexity 16 (threshold 15). Drivers by points: loops 2 (9 pts), if/else 4 (7 pts) (nesting depth added 10). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/TunablesController.php"},"region":{"startLine":70}}}],"partialFingerprints":{"codehealthFindingId/v1":"8dd878151ff6cf35be2392d487b664d571a3f8a9c8fec5e83c191c85aa5e0fb7"}},{"ruleId":"D2","level":"warning","message":{"text":"DNatController.getConfiguredDestinationNatRules (cognitive 16): DNatController.getConfiguredDestinationNatRules has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (8 pts), loops 3 (5 pts), ternaries 1 (2 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php"},"region":{"startLine":93}}}],"partialFingerprints":{"codehealthFindingId/v1":"45d4f5963e7b0a7e98d5e0727d055f645dd3bdcd73c28ddc59a34a0253c67c4e"}},{"ruleId":"D2","level":"warning","message":{"text":"FilterBaseController.downloadRulesBase (cognitive 16): FilterBaseController.downloadRulesBase has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (8 pts), loops 5 (7 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php"},"region":{"startLine":479}}}],"partialFingerprints":{"codehealthFindingId/v1":"c37797c28c3a8f6de7708238f5869bd675fd4819c73765af97b5c35896b6f0d2"}},{"ruleId":"D2","level":"warning","message":{"text":"OverviewController.getInterfaceAction (cognitive 16): OverviewController.getInterfaceAction has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (13 pts), loops 1 (3 pts) (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/OverviewController.php"},"region":{"startLine":255}}}],"partialFingerprints":{"codehealthFindingId/v1":"71d5805a946b23f7435595436cecb091f85201f008ec130be1acbd7836bcc283"}},{"ruleId":"D2","level":"warning","message":{"text":"VlanSettingsController.setItemAction (cognitive 16): VlanSettingsController.setItemAction has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (9 pts), boolean chains 5, loops 1, ternaries 1 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/VlanSettingsController.php"},"region":{"startLine":101}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c4bc8dbc8006a4df47a65459ca82ad8fcd7233e6bc3e43a89ea899838dd8094"}},{"ruleId":"D2","level":"warning","message":{"text":"Radius.updateAccounting (cognitive 16): Radius.updateAccounting has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (11 pts), match/switch 1 (3 pts), ternaries 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php"},"region":{"startLine":411}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ba90f6749aa7b7b7d844d13330f4ce5d72425e81dfa7b21f86f1e215248a083"}},{"ruleId":"D2","level":"warning","message":{"text":"Voucher._authenticate (cognitive 16): Voucher._authenticate has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (9 pts), ternaries 1 (4 pts), boolean chains 3 (nesting depth added 8). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Voucher.php"},"region":{"startLine":375}}}],"partialFingerprints":{"codehealthFindingId/v1":"35bcbc5f192584aee704bb5247950aa4fd410100050d6571b02ff64348b4bbc9"}},{"ruleId":"D2","level":"warning","message":{"text":"Config.getBackups (cognitive 16): Config.getBackups has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 2 (5 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Core/Config.php"},"region":{"startLine":609}}}],"partialFingerprints":{"codehealthFindingId/v1":"8858afd03e2f33e78fc5b3a770afbf0af0d3b4bdf01eab140727df99322ef993"}},{"ruleId":"D2","level":"warning","message":{"text":"Util.getservbyname (cognitive 16): Util.getservbyname has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (9 pts), loops 2 (6 pts), boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php"},"region":{"startLine":342}}}],"partialFingerprints":{"codehealthFindingId/v1":"de0d7d41680ec7852178df4ec64c918dd157e5c6513f1e20db740a6a87ae6c6c"}},{"ruleId":"D2","level":"warning","message":{"text":"Util.cidrRangeIterator (cognitive 16): Util.cidrRangeIterator has cognitive complexity 16 (threshold 15). Drivers by points: loops 2 (6 pts), ternaries 2 (6 pts), if/else 3 (4 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php"},"region":{"startLine":645}}}],"partialFingerprints":{"codehealthFindingId/v1":"2ef0a6a830a099b250abd2c0337af52e134764b827b78f61e2b12b51bf614f24"}},{"ruleId":"D2","level":"warning","message":{"text":"Response.send (cognitive 16): Response.send has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (8 pts), loops 2 (5 pts), ternaries 1 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Mvc/Response.php"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"1bfc60aba75951ddba5aca03951bc830521b91f816010d759d420ddce76ea5ce"}},{"ruleId":"D2","level":"warning","message":{"text":"Store.ocsp_validate (cognitive 16): Store.ocsp_validate has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (10 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Trust/Store.php"},"region":{"startLine":656}}}],"partialFingerprints":{"codehealthFindingId/v1":"3dadc92a1d8c200d9dcad528e391fa25f7623bf642179474a0543c58e63cbd13"}},{"ruleId":"D2","level":"warning","message":{"text":"MenuItem.getLinkClass (cognitive 16): MenuItem.getLinkClass has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (9 pts), loops 1 (3 pts), ternaries 1 (3 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuItem.php"},"region":{"startLine":281}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd9ce0b4fa5630eff4fd20ce29dfd86670f5b6c918333bea2f46142705497a81"}},{"ruleId":"D2","level":"warning","message":{"text":"HostnameField.setValue (cognitive 16): HostnameField.setValue has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (9 pts), ternaries 1 (3 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Dnsmasq/FieldTypes/HostnameField.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"07e46a64fff029316172676960f3265c58136688cafb312ae30b14ed80848f86"}},{"ruleId":"D2","level":"warning","message":{"text":"AliasContentField.validateNetwork (cognitive 16): AliasContentField.validateNetwork has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 8, if/else 2 (5 pts), loops 2 (3 pts) (nesting depth added 4). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/AliasContentField.php"},"region":{"startLine":234}}}],"partialFingerprints":{"codehealthFindingId/v1":"4ff6be0374dab38bf2375418015406d4899ae37d5f54f895afa8586a6cdc20a2"}},{"ruleId":"D2","level":"warning","message":{"text":"BridgeMemberField.actionPostLoadingEvent (cognitive 16): BridgeMemberField.actionPostLoadingEvent has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (7 pts), ternaries 1 (4 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/BridgeMemberField.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4d459fc55c10b586113d4515d40845d9f3e576b3ea6efda76fcda94f578c6d4"}},{"ruleId":"D2","level":"warning","message":{"text":"VipInterfaceField.actionPostLoadingEvent (cognitive 16): VipInterfaceField.actionPostLoadingEvent has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (7 pts), ternaries 1 (4 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/VipInterfaceField.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"84e3c7fdc280113da168733943fb019c4be8dffe01018b8787affb194a302980"}},{"ruleId":"D2","level":"warning","message":{"text":"Wlan.performValidation (cognitive 16): Wlan.performValidation has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (12 pts), boolean chains 2, loops 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Wlan.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"440dcca71931a81f78d32d8129ae9e26cf765993180d3cb37f23b0c58ce16402"}},{"ruleId":"D2","level":"warning","message":{"text":"OpenVPNServerField.actionPostLoadingEvent (cognitive 16): OpenVPNServerField.actionPostLoadingEvent has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (6 pts), loops 2 (5 pts), ternaries 1 (4 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/FieldTypes/OpenVPNServerField.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"0939660d54b2a63bb49e3b15a2f483e242fd9c2527eeb039d20abada3a11cffa"}},{"ruleId":"D2","level":"warning","message":{"text":"RemoteHostField.getValidators (cognitive 16): RemoteHostField.getValidators has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (8 pts), loops 2 (6 pts), boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/FieldTypes/RemoteHostField.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"f0177a836c0e76e0a710efe5868ceff4dc4694401851ddfa9ece1e6a95116df2"}},{"ruleId":"D2","level":"warning","message":{"text":"read_log.fetch_rule_details (cognitive 16): read_log.fetch_rule_details has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (13 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth \u2014 most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language\u0027s equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/read_log.py"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"9af75d818c62b4311db06eab2cc2cb5501dd6f828b160d45f4ded012c3ce5379"}},{"ruleId":"D2","level":"warning","message":{"text":"lib.parse_ipfw_queues (cognitive 16): lib.parse_ipfw_queues has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/shaper/lib/__init__.py"},"region":{"startLine":126}}}],"partialFingerprints":{"codehealthFindingId/v1":"2c088fb40be4da4900e1ee9d6d0eca4d8cd78d9ef99ee73387d03e8b1d566ff1"}},{"ruleId":"D2","level":"warning","message":{"text":"DNSReader.run_logger (cognitive 16): DNSReader.run_logger has cognitive complexity 16 (threshold 15). Drivers by points: if/else 3 (8 pts), error handling 2 (4 pts), loops 3 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/logger.py"},"region":{"startLine":203}}}],"partialFingerprints":{"codehealthFindingId/v1":"3e286210d140cec5b1c8fdcc11f5ef39378d4d977fbf29fb9022a2cf8c4abb78"}},{"ruleId":"D2","level":"warning","message":{"text":"Action.execute (cognitive 16): Action.execute has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8, boolean chains 3, error handling 2, loops 1 (2 pts), ternaries 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth \u2014 many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/actions/script_output.py"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"e189b841e96932f3d1d88c57a2baadd079b3be649dd8478bd040ad3c17db3c57"}},{"ruleId":"D2","level":"warning","message":{"text":"bootstrap-select.stringSearch (cognitive 16): bootstrap-select.stringSearch has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (15 pts), loops 1 (nesting depth added 9). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":422}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2d88ee58e1b6b0b0ab7e486959b6da0f8bbc6e2fa6ec5a64840ef8d420dc257"}},{"ruleId":"D2","level":"warning","message":{"text":"setSelected (cognitive 16): setSelected has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 4 (nesting depth added 3). This file\u0027s own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes \u2014 or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":2292}}}],"partialFingerprints":{"codehealthFindingId/v1":"9b452581b1eadaf74a2dd5fe2aafb8a4b70866c8813ae78e8c17de5a3a19da7f"}},{"ruleId":"D2","level":"warning","message":{"text":"handleModalEvents (cognitive 16): handleModalEvents has cognitive complexity 16 (threshold 15). Drivers by points: boolean chains 8, if/else 6 (8 pts) (nesting depth added 2). None of this is in the body itself: all 16 points belong to 6 function literals inside it that branch (lines 1024, 1040, 1052, \u2026). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals\u0027 work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-dialog.js"},"region":{"startLine":1023}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec9931831da82af78a58e4dd2404456a0ea8f83a21ab145d8d3bf42c530ad9b5"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: js/bootstrap-select.js: FileTooLong \u2014 2045 significant lines (blank, comment-only and punctuation-only lines excluded; the length bar is tripled for a single-responsibility module of 4 or fewer top-level units). The bar is 1500 significant lines; this is 545 over it, 1.36\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"43a6830b0cb3885b5b98368a32b81fe0ad2e6f28c95a7dc56b0ceb3a9ed76333"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: UIBootgrid: ClassTooLong \u2014 1495 significant lines (blank, comment-only and punctuation-only lines excluded), 62 methods. The bar is 400 significant lines; this is 1095 over it, 3.74\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad93d5ee49fcfb292c824a31b4abff935a6892664bcf063e599cef4585980ee6"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: js/tokenize2.js: FileTooLong \u2014 1840 significant lines (blank, comment-only and punctuation-only lines excluded; the length bar is tripled for a single-responsibility module of 4 or fewer top-level units). The bar is 1500 significant lines; this is 340 over it, 1.23\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/tokenize2.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c6b1f843e1ebae253daa5fcb777a000bbf23fac71bdd305e06aa8875eb26e33b"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: www/interfaces.php: FileTooLong \u2014 1782 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1282 over it, 3.56\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/interfaces.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"006e61ea3d06a0218bfeb4b08d9fa8855d5c410257589941560d4c88d01c901c"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: js/opnsense_bootgrid.js: FileTooLong \u2014 1537 significant lines (blank, comment-only and punctuation-only lines excluded; the length bar is tripled for a single-responsibility module of 4 or fewer top-level units), about 97% of them inside a single declaration: UIBootgrid (104-2539). The bar is 1500 significant lines; this is 37 over it, 1.02\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"2818ccbeac9dffead3bdf66167fb8bff2208924f63cf82fa061c2c6362cc8a63"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: js/bootstrap.js: FileTooLong \u2014 1471 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 971 over it, 2.94\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"39bf6cd2adda2bbfd632b89fb7ad5ad1d38e87e0c1999e0c0db6bc879186e302"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: Filter.performValidation: MethodTooLong \u2014 performValidation runs 239 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 139 over it, 2.39\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e19bed49aaff1c0f0e63035393fc2eb5b8c656f466f2f0204a7e46c0e8db65e"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: BaseField: TooManyMethods \u2014 70 methods. The bar is 30 methods; this is 40 over it, 2.33\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"238f25f514be1d33a2cf097813ff3bb689cb3c5efd840a0cc752bd082c276dd1"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: Dnsmasq.performValidation: MethodTooLong \u2014 performValidation runs 230 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 130 over it, 2.30\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"a957e1e408ed02561101b9793a3c3f9e74df70847b17f07c85db7a15c19f8ea2"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: UIBootgrid: TooManyMethods \u2014 62 methods. The bar is 30 methods; this is 32 over it, 2.07\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"c2f5060ec0339ddf8469d221391f4973afc2d377e0f1f0702d96e96ffd5685de"}},{"ruleId":"D3","level":"warning","message":{"text":"FunctionTooLong: smoothie.SmoothieChart.render: FunctionTooLong \u2014 SmoothieChart.render runs 197 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 97 over it, 1.97\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/smoothie.js"},"region":{"startLine":839}}}],"partialFingerprints":{"codehealthFindingId/v1":"c27d3522dcb7513836c6ab11bb6f330a93580af9a7ea89325512a1d91e79a513"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: OpenVPN.generateInstanceConfig: MethodTooLong \u2014 generateInstanceConfig runs 193 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 93 over it, 1.93\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php"},"region":{"startLine":551}}}],"partialFingerprints":{"codehealthFindingId/v1":"947b5e2c0f1213600d4d2eb8781a6f809a5da3346ca0df49ace9e3725cf89432"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: FirmwareController.statusAction: MethodTooLong \u2014 statusAction runs 182 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 82 over it, 1.82\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"5f225c5ca79a0812ad7440d274caf59446d6a82ef015e296dc211505bc46ff13"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: js/opnsense_widgets.js: FileTooLong \u2014 855 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 355 over it, 1.71\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a685347cef0460385537eaf2149153a6248578a0e5ece823818b4873ba66ed1"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: js/bootstrap-dialog.js: FileTooLong \u2014 784 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 284 over it, 1.57\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-dialog.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad6f6c822fc7341d372540aaf08b6d909ed72525e1009f7ebd349d72ba7049d8"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: www/firewall_schedule_edit.php: FileTooLong \u2014 773 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 273 over it, 1.55\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/firewall_schedule_edit.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"469f12ff0d51964cedf4ea30bd87efdaaeaa70eae285047954d7336fffaa21d1"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: js/opnsense_ui.js: FileTooLong \u2014 757 significant lines (blank, comment-only and punctuation-only lines excluded; the length bar is tripled for a single-responsibility module of 4 or fewer top-level units). The bar is 500 significant lines; this is 257 over it, 1.51\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"8945e9bb46aa3c5e5897817ea4c5a0e620e047df772a376fea5ace156376fd7d"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: UIBootgrid._registerEvents: MethodTooLong \u2014 _registerEvents runs 151 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 51 over it, 1.51\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":720}}}],"partialFingerprints":{"codehealthFindingId/v1":"f29992a8436ff6b45c4c4fa1e90fad3474a9e91c4c05e2a8f0067608d0ab560f"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: IXR/IXR_Library.php: FileTooLong \u2014 732 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 232 over it, 1.46\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/IXR/IXR_Library.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"5a0184868c88cd8a6b925bbebc16f8fed3c075b54111f985e4577549342ce362"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: js/chartjs-plugin-streaming.js: FileTooLong \u2014 728 significant lines (blank, comment-only and punctuation-only lines excluded; the length bar is tripled for a single-responsibility module of 4 or fewer top-level units). The bar is 500 significant lines; this is 228 over it, 1.46\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/chartjs-plugin-streaming.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"60d5c45952910c4aad3aba32b0f45415be074254355ee3e30e2909a8344b8d53"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: KeaDhcpv6.performValidation: MethodTooLong \u2014 performValidation runs 141 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 41 over it, 1.41\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"e70667576017bd368a6d744b18e8ff335579ec86aa9b8e0fff91fcdcf9163997"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: www/interfaces_ppps_edit.php: FileTooLong \u2014 696 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 196 over it, 1.39\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/interfaces_ppps_edit.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"deda0693b3df6c41a1a4dc8d30f1991d5ba49aceac80790272a133428c54e727"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: CrlController.setAction: MethodTooLong \u2014 setAction runs 138 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 38 over it, 1.38\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CrlController.php"},"region":{"startLine":180}}}],"partialFingerprints":{"codehealthFindingId/v1":"710855e7bfed9ef1f4f5f68b02f4b16b56e3db2443cb667f49617ac00ccda8d4"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: KeaDhcpv6.getConfigSubnets: MethodTooLong \u2014 getConfigSubnets runs 132 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 32 over it, 1.32\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php"},"region":{"startLine":328}}}],"partialFingerprints":{"codehealthFindingId/v1":"bf4426a91969fdcc5d78ee58a5ce4bc93f5e9bdfc8ef58c91ab02d65371fe419"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: FirmwareController: ClassTooLong \u2014 526 significant lines (blank, comment-only and punctuation-only lines excluded), 28 methods. The bar is 400 significant lines; this is 126 over it, 1.32\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"b142a8b08ea8e8c6a8e70b4101af166e05efd62a9f64fba94ebb49fd2c6d063b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: Radius.authenticate: MethodTooLong \u2014 authenticate runs 130 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 30 over it, 1.30\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php"},"region":{"startLine":512}}}],"partialFingerprints":{"codehealthFindingId/v1":"6db9292aa0969078026c9ebc4e9b4b96672bf3e114aaf25e75810f54289caeb0"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: OpenVPN: ClassTooLong \u2014 504 significant lines (blank, comment-only and punctuation-only lines excluded), 8 methods. The bar is 400 significant lines; this is 104 over it, 1.26\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"d81d35f339add90ebac313ed8fbe232f4fc4136d5549eb97198d17783ae2fc40"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: UIBootgrid.tabulatorDefaults: MethodTooLong \u2014 tabulatorDefaults runs 125 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 25 over it, 1.25\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1559}}}],"partialFingerprints":{"codehealthFindingId/v1":"03d04c3bd18625285881c96d390526d6e21596939a748d37eae4ea411e093725"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: SettingsController: TooManyMethods \u2014 36 methods. The bar is 30 methods; this is 6 over it, 1.20\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api/SettingsController.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"d235a6db791f361b80a70b9e6a13da60b33c418713e7a7856a0d4d5073dcd516"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: UIBootgrid.translateCompatOptions: MethodTooLong \u2014 translateCompatOptions runs 118 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 18 over it, 1.18\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":244}}}],"partialFingerprints":{"codehealthFindingId/v1":"8e85b2f8206bf4040ee99f2e758ec29b238ca82549140634672fc04b61caae05"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: SettingsController: TooManyMethods \u2014 35 methods. The bar is 30 methods; this is 5 over it, 1.17\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Unbound/Api/SettingsController.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c9425decb7e23a391bedef31e351098fac9b61cc92226106fa451920d8e112c"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: OpenVPN.performValidation: MethodTooLong \u2014 performValidation runs 116 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 16 over it, 1.16\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"38a0aa2c71447b40c96fa85837c202a8390882f8e556fb31c46e65c67127c1d2"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: CertController.setBaseHook: MethodTooLong \u2014 setBaseHook runs 114 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 14 over it, 1.14\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f7f51348e570828cd21667e117972d0a971b8d965ccaead41a38626a1e95277"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: js/smoothie.js: FileTooLong \u2014 568 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 68 over it, 1.14\u00D7 the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/smoothie.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"889c80ba9c5177302f8d74528ab1011c040cc4f9eae4f8bbfb7298c6bd8e9f50"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: Monit.performValidation: MethodTooLong \u2014 performValidation runs 113 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 13 over it, 1.13\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Monit/Monit.php"},"region":{"startLine":153}}}],"partialFingerprints":{"codehealthFindingId/v1":"c433708f114d5240b2ccdabdedc4d316de112a52e21427b5bd3a1a57930a0200"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: UIBootgrid._internalFormatters: MethodTooLong \u2014 _internalFormatters runs 113 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 13 over it, 1.13\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1923}}}],"partialFingerprints":{"codehealthFindingId/v1":"f0d35141f797cb9d34713e2b534a5168f70fe797a802e6bfa64df6ee24b866e0"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: Vip.performValidation: MethodTooLong \u2014 performValidation runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Vip.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"ad8e02de97e7555a859a5aa0a38e24938ae0caa37ed56e4bca08948b24fa18a6"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: SettingsController: TooManyMethods \u2014 32 methods. The bar is 30 methods; this is 2 over it, 1.07\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IDS/Api/SettingsController.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"2452b765fe53a641c0efbcb99ae8849428a11ccff7c2fdb504aa6cecf2391345"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: BaseModel: TooManyMethods \u2014 32 methods. The bar is 30 methods; this is 2 over it, 1.07\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"2e048f31d6a3f9d9e22beb119371f506ef7aabbc8d395f2fc6444d37ee677278"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: Api/FirmwareController.php: FileTooLong \u2014 533 significant lines (blank, comment-only and punctuation-only lines excluded), about 99% of them inside a single declaration: FirmwareController (42-1008). The bar is 500 significant lines; this is 33 over it, 1.07\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"e26852f589463e1235b53f6f3d8c28dbbf62fae2744825b128246cd6471a3ae7"}},{"ruleId":"D3","level":"warning","message":{"text":"ClassTooLong: BaseModel: ClassTooLong \u2014 421 significant lines (blank, comment-only and punctuation-only lines excluded), 32 methods. The bar is 400 significant lines; this is 21 over it, 1.05\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"49759c47f8f279e7869dee37f59a85f2519fa84e689649908a074d44e098484b"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: Gateways.getGateways: MethodTooLong \u2014 getGateways runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php"},"region":{"startLine":329}}}],"partialFingerprints":{"codehealthFindingId/v1":"0a01e9ead83e791d7bf69e091d949a5909aec14975dbbd8cdc448f69c30e2671"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: Util: TooManyMethods \u2014 31 methods. The bar is 30 methods; this is 1 over it, 1.03\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c87340d1d7961085f13428c4cafe4f2b118117f1393ad40eaeffc630367929b"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: KeaOptionDataField: TooManyMethods \u2014 31 methods. The bar is 30 methods; this is 1 over it, 1.03\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/FieldTypes/KeaOptionDataField.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"7a5bc5c44998a72611149e126a6604d31c7eb2813afdc9307814b017854e8808"}},{"ruleId":"D3","level":"warning","message":{"text":"TooManyMethods: WidgetManager: TooManyMethods \u2014 31 methods. The bar is 30 methods; this is 1 over it, 1.03\u00D7 the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":686}}}],"partialFingerprints":{"codehealthFindingId/v1":"9a957f8e3c89b74ca1be2de6a9bdcb0d512c8818d267c10837dbcf4238142841"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: setaddr.console_configure_ip_address: MethodTooLong \u2014 console_configure_ip_address runs 103 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 3 over it, 1.03\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/shell/setaddr.php"},"region":{"startLine":294}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a67272f72b9374e45b076a52b98d441c1e521240f9172225e9896ddfec8d875"}},{"ruleId":"D3","level":"warning","message":{"text":"FileTooLong: OpenVPN/OpenVPN.php: FileTooLong \u2014 512 significant lines (blank, comment-only and punctuation-only lines excluded), about 98% of them inside a single declaration: OpenVPN (42-854). The bar is 500 significant lines; this is 12 over it, 1.02\u00D7 the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body \u2014 the parts that share the same inputs and are named together \u2014 into its own unit in a sibling file, and have the original call them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ac3cf64be080b24bb74b73bfb1c5de07a39c321aa2b8673cdb84cb49b069dae"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: TunnelController.searchPhase2Action: MethodTooLong \u2014 searchPhase2Action runs 102 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2 over it, 1.02\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php"},"region":{"startLine":129}}}],"partialFingerprints":{"codehealthFindingId/v1":"546767ea95ca6c5742eb59e385beea2ca009d7ed4c413f35be88329c3cdbda1e"}},{"ruleId":"D3","level":"warning","message":{"text":"MethodTooLong: OpenVPNClients.updateClients: MethodTooLong \u2014 updateClients runs 101 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 1 over it, 1.01\u00D7 the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body \u2014 the runs of statements that work on the same values and would earn the same name \u2014 into its own named unit, and have this one call them in order."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/OpenVPNClients.js"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"e33d8fdd2f7a61fdd84d9f63e389423558011606a42a7e4c5d7442c66422ba6c"}},{"ruleId":"D4","level":"warning","message":{"text":"Near-duplicate member family (3 members, 127 shared lines): src/opnsense/scripts/captiveportal/lib/daemonize.py:62-211 | src/opnsense/service/modules/daemonize.py:76-242 | src/opnsense/site-python/daemonize.py:74-240 \u2014 These 3 members are variants of one another: a block of 127 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 3 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/lib/daemonize.py"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"454f19bec1033543d2aede9b9558b540908f12a1eb9c2e647aadb23d5b4fb62a"}},{"ruleId":"D4","level":"warning","message":{"text":"Near-duplicate member pair (46 shared lines): src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:184-316 | src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php:330-532 \u2014 These two members are variants of one another: 46 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members\u0027 grain \u2014 factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":184}}}],"partialFingerprints":{"codehealthFindingId/v1":"13e20003710f80222e0b68c1c987a59a36b61f5b086ba2fc2709bfd9ae3c3fa8"}},{"ruleId":"D4","level":"warning","message":{"text":"Members sharing a duplicated core (6 members, 50\u002B identical tokens): src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php:77-84 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php:92-99 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php:107-114 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PingController.php:76-83 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PingController.php:91-98 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PingController.php:106-113 \u2014 These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below \u2014 it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members\u0027 grain \u2014 factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php"},"region":{"startLine":77}}}],"partialFingerprints":{"codehealthFindingId/v1":"4f8c3f843d813e60ab15859087ad278d0b773567e3a017f3ab9b15a2362f90ba"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (50\u201351 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SadController.php:48-98 | src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SpdController.php:48-97 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SadController.php\u0060 and \u0060src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SpdController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SadController.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d3cd58f75082c868bf6e46e1e797bd33b8fc301890ed48fcfcdbfb607bccc7d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (44\u201345 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:409-452 | src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php:625-669 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php\u0060 as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 145 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:409\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:454\u0060 calls \u0060foreach\u0060, \u0060getValues\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php:670\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":409}}}],"partialFingerprints":{"codehealthFindingId/v1":"b36c4679c671d3b7da9d7994bb7421b472c1a0a188e4af2f06a0ae3330533ef0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (43 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Monit/Migrations/M1_0_6.php:37-79 | src/opnsense/mvc/app/models/OPNsense/Monit/Migrations/M1_0_7.php:38-80 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/opnsense/mvc/app/models/OPNsense/Monit/Migrations/M1_0_6.php:81\u0060 calls \u0060run\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Monit/Migrations/M1_0_7.php:81\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Monit/Migrations/M1_0_6.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"641fa53b06a6492822503f8fbdbf531afd3c900af9977ce842e3f4deb2eddaad"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (28 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Interfaces/Gif.php:44-71 | src/opnsense/mvc/app/models/OPNsense/Interfaces/Gre.php:44-71 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/models/OPNsense/Interfaces/Gif.php\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Interfaces/Gre.php\u0060 as WHOLE FILES: 82% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/models/OPNsense/Interfaces/Gif.php:44\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/Gif.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"a2059dbdfed5910241e68d9103456c529bde9d7729e29942341061836e11e753"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (26 lines \u00D7 3): src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:259-284 | src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:331-356 | src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:423-448 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:259\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:328\u0060 calls \u0060splitBytes\u0060 and \u0060src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:257\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php"},"region":{"startLine":259}}}],"partialFingerprints":{"codehealthFindingId/v1":"b29277ea9472eb83f49ebd94cc3ae0b58786deb4aec3ea421917283be7564ecf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/DHCRelay/Migrations/M1_0_0.php:48-72 | src/opnsense/mvc/app/models/OPNsense/DHCRelay/Migrations/M1_0_1.php:48-72 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/models/OPNsense/DHCRelay/Migrations/M1_0_0.php\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/DHCRelay/Migrations/M1_0_1.php\u0060 as WHOLE FILES: 88% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/DHCRelay/Migrations/M1_0_0.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"f4d24064d734e50987859a706a1b80596352f58635885c1e47cf6b1cf975060e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (24 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php:46-69 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PingController.php:45-68 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b3731571bedb95878c79715421f9881229e973a0c7d2a1cc1707eba229a33a2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21\u201322 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:358-378 | src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:450-471 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:358\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:378\u0060 calls \u0060radius_strerror\u0060, \u0060elseif\u0060, \u0060radius_put_int\u0060 and \u0060src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:471\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php"},"region":{"startLine":358}}}],"partialFingerprints":{"codehealthFindingId/v1":"928f78a54bb0494437c6248d17033a4c71adf48b220b04493319563dc5e28042"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/Backup/BackupFactory.php:43-64 | src/opnsense/mvc/app/library/OPNsense/OpenVPN/ExportFactory.php:43-64 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/library/OPNsense/Backup/BackupFactory.php\u0060 and \u0060src/opnsense/mvc/app/library/OPNsense/OpenVPN/ExportFactory.php\u0060 as WHOLE FILES: 84% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Backup/BackupFactory.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"119c3bee0e7d3194ea98ea6a35856138b500e7cbfbb1a7bcd4bfd489e9fba918"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20\u201321 lines \u00D7 3): src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:290-309 | src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:380-399 | src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:469-489 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:290\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:378\u0060 calls \u0060radius_strerror\u0060, \u0060elseif\u0060, \u0060radius_put_int\u0060 and \u0060src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:469\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php"},"region":{"startLine":290}}}],"partialFingerprints":{"codehealthFindingId/v1":"732b1b43d5e8a8661cc972897bf324361a6adca8964b91f2c6d6d3071c1aca7f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:212-232 | src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php:452-472 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php\u0060 as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 145 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:212\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":212}}}],"partialFingerprints":{"codehealthFindingId/v1":"f6bfab18eff9aee55c0fe4cc877000aa2b5022a085a26ef51730b3e77713ea4a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:688-707 | src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:718-737 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php"},"region":{"startLine":688}}}],"partialFingerprints":{"codehealthFindingId/v1":"6950101765930c74d4721b5c1ea0a830758f586d16f5a75f0aabdab7967e11e3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (20 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Kea/Api/Dhcpv4Controller.php:132-151 | src/opnsense/mvc/app/controllers/OPNsense/Kea/Api/Dhcpv6Controller.php:132-151 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/Kea/Api/Dhcpv4Controller.php:132\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Kea/Api/Dhcpv4Controller.php"},"region":{"startLine":132}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd0dc75d064ff7637b50f287805b568cbe97562d9f7a78deb11fb8b1186d3f87"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/OpenVPN/ArchiveOpenVPN.php:76-94 | src/opnsense/mvc/app/library/OPNsense/OpenVPN/ViscosityVisz.php:107-125 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/library/OPNsense/OpenVPN/ArchiveOpenVPN.php:76\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/OpenVPN/ArchiveOpenVPN.php"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"31cfe15b29c3a6e555cacdd8e3b1fce3dbbc9614f9559bb8da821fb89e4f08f6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16\u201317 lines \u00D7 3): src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:570-585 | src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:635-650 | src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:661-677 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php"},"region":{"startLine":570}}}],"partialFingerprints":{"codehealthFindingId/v1":"7ab21b7404562797cdfebca8a50971164217c8f02945b26ce4d74f15a570f849"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CAsField.php:95-111 | src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CertificatesField.php:162-178 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CAsField.php:95\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CAsField.php"},"region":{"startLine":95}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c7f181f701b60c9c2c53de1f010532d6a98c963f6539607f6521847be8646c1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15\u201316 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php:509-523 | src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php:556-571 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php"},"region":{"startLine":509}}}],"partialFingerprints":{"codehealthFindingId/v1":"76c775b48fc8b9f62a17e0f602708ee99fb7b4c59cf5fafaa6d45d830e168a50"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/NptController.php:37-52 | src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/OneToOneController.php:37-52 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/NptController.php:37\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/NptController.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"b37659e9c724d647069879b92fc5bc4004df131e53bfa1467eb689b611edbb0a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CaController.php:220-235 | src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php:269-284 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CaController.php"},"region":{"startLine":220}}}],"partialFingerprints":{"codehealthFindingId/v1":"67031413f6f9c77052f0e06b254fdbe69e9c29e50c96b465a4d32ec431d16d24"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/OpenVPN/ArchiveOpenVPN.php:104-119 | src/opnsense/mvc/app/library/OPNsense/OpenVPN/ViscosityVisz.php:133-148 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/library/OPNsense/OpenVPN/ArchiveOpenVPN.php:104\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/OpenVPN/ArchiveOpenVPN.php"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff3ddf5ff38579ecae179843c3d22a6f7563565fc560de2cf1b6b776cfc98b72"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201315 lines \u00D7 2): contrib/IXR/IXR_Library.php:701-715 | contrib/IXR/IXR_Library.php:1264-1277 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/IXR/IXR_Library.php"},"region":{"startLine":701}}}],"partialFingerprints":{"codehealthFindingId/v1":"b131f445db5ed365b6fdcb0dd8762e8ca3c2ba662c6fe348aab92171244ce5f3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/InterfaceController.php:81-95 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/InterfaceController.php:130-144 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/InterfaceController.php"},"region":{"startLine":81}}}],"partialFingerprints":{"codehealthFindingId/v1":"3a8fb11d694857322d145e97756d3a4301d4a40f669b9a42f673af6500a5c575"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14\u201315 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php:154-168 | src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/SourceNatController.php:137-150 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php:154\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php"},"region":{"startLine":154}}}],"partialFingerprints":{"codehealthFindingId/v1":"c064a79733db47cf34caf082d9363a05fe34f9c97a5bdf45f6f00078a85bcfde"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_0_3.php:59-72 | src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_0_4.php:68-81 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_0_3.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"fffcbcdc72ed393a06591e075ff025b3dc4789b02eaabad471eb0603c231675a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.php:65-78 | src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.php:81-94 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"f83d8316be05a1e04037700cacbe7abbeeef68134392efd9b1ef7d2a1b40b94f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12\u201313 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:401-413 | src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:783-794 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php"},"region":{"startLine":401}}}],"partialFingerprints":{"codehealthFindingId/v1":"5cfd4f9f733f1575642d587d630d97bfe26fce122845775c1aa239b1305e6a85"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/www/diag_backup.php:75-87 | src/www/diag_backup.php:100-112 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/www/diag_backup.php:75\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/www/diag_backup.php:113\u0060 calls \u0060unset\u0060 and \u0060src/www/diag_backup.php:88\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/diag_backup.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"b7aabb2faa8c64dc94b474b3e4cc3b253f4e4f6c339edf255458ece252fd5c4d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 3): src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GifSettingsController.php:97-108 | src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GreSettingsController.php:97-108 | src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/LaggSettingsController.php:97-108 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GifSettingsController.php\u0060 and \u0060src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GreSettingsController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GifSettingsController.php"},"region":{"startLine":97}}}],"partialFingerprints":{"codehealthFindingId/v1":"022d2e366d2878ff5f0fc5c52b436a5929ad3071d3052a90c9ee80c9926a877f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:463-474 | src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:484-495 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php"},"region":{"startLine":463}}}],"partialFingerprints":{"codehealthFindingId/v1":"1d0c4f94275f626111cca9f74c4cddbbce5eaf596c2089ad516d05bab53bac18"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10\u201312 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php:100-111 | src/opnsense/mvc/app/library/OPNsense/Base/UIModelGrid.php:134-143 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"dedd66470f818312d378f92622cea4ee040d9451b88b0745468879214112efbb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/ConnectionsController.php:298-309 | src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php:390-401 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php:402\u0060 calls \u0060touch\u0060 and \u0060src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/ConnectionsController.php:310\u0060 does not \u2014 after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/ConnectionsController.php"},"region":{"startLine":298}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c916c8e15418b4f59e705e66aa96774de45b40e07edc4774d0330ebd070c9bb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:299-310 | src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php:518-529 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php\u0060 as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 145 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:311\u0060 calls \u0060empty\u0060, \u0060array_values\u0060, \u0060array_unique\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php:530\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":299}}}],"partialFingerprints":{"codehealthFindingId/v1":"a129d932de9eddf4369338e47e899bf82de1842f0eddd0929ceb44427f9a9a35"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2): src/opnsense/scripts/shell/setaddr.php:492-503 | src/opnsense/scripts/shell/setaddr.php:506-517 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/scripts/shell/setaddr.php:492\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/shell/setaddr.php"},"region":{"startLine":492}}}],"partialFingerprints":{"codehealthFindingId/v1":"45b1601c62f13242270bde084a811a8a468ce2ba25c43a43b21655fe69f18634"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 3): src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SadController.php:52-62 | src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SpdController.php:52-62 | src/opnsense/mvc/app/models/OPNsense/IPsec/FieldTypes/SPDField.php:45-55 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SadController.php\u0060 and \u0060src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SpdController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SadController.php:52\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SadController.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"6b2a0fcf580013b63bbfbbc59b36ea970f96666d064a92d764131bdde2324c53"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:423-433 | src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:443-453 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php"},"region":{"startLine":423}}}],"partialFingerprints":{"codehealthFindingId/v1":"d61245283a050232be410dad9a147d87bf53ff24ffa41fc49356c76012711c62"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/DnsDiagnosticsController.php:43-53 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/TracerouteController.php:41-53 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/DnsDiagnosticsController.php"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"d901727410cae4f74fb8a2a8553262edb9d5df1b27eba8195af913e08c9df8d6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GifSettingsController.php:136-146 | src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GreSettingsController.php:136-146 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GifSettingsController.php\u0060 and \u0060src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GreSettingsController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GifSettingsController.php:136\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GifSettingsController.php"},"region":{"startLine":136}}}],"partialFingerprints":{"codehealthFindingId/v1":"6fc9765563bbc42027b57ad032f164c42ccb8def8e5fc391978851ab259103bc"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:169-179 | src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php:315-325 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php\u0060 as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 145 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":169}}}],"partialFingerprints":{"codehealthFindingId/v1":"695d80efc6d5a51aafef78d1b1e0bcef1d5c6a13f2e937be7a5c8110bf649425"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.php:58-68 | src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php:129-139 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.php:58\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"a3008fa8b5e56b1d354ff916f3c315aad262ac7c71ba13689745b8351cc097ab"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:76-85 | src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php:46-55 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php\u0060 as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 145 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:76\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":76}}}],"partialFingerprints":{"codehealthFindingId/v1":"e985d612476f4f3c2c3d1f0400356fdeecd02079cbf9a1f6277f8acf71351354"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 3): src/opnsense/mvc/app/library/OPNsense/Auth/TOTP.php:231-239 | src/opnsense/mvc/app/library/OPNsense/Auth/TOTP.php:244-252 | src/opnsense/mvc/app/library/OPNsense/Auth/Voucher.php:430-438 \u2014 there are 3 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/library/OPNsense/Auth/TOTP.php:231\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/TOTP.php"},"region":{"startLine":231}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7da2ee58da262166f1a6f7664ec6e4f8d46db02ed119e3401bdfe462a8400e5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 3): src/opnsense/mvc/app/library/OPNsense/Firewall/DNatRule.php:79-87 | src/opnsense/mvc/app/library/OPNsense/Firewall/ForwardRule.php:83-91 | src/opnsense/mvc/app/library/OPNsense/Firewall/NptRule.php:56-64 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/DNatRule.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"0370e4545913a8888019e75e09105052d8c8c34f168b5bdca8f69b233d5901b3"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php:103-111 | src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php:176-184 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php:103\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php"},"region":{"startLine":103}}}],"partialFingerprints":{"codehealthFindingId/v1":"f61410a68d890c5a62cb3762ff4ead8bf2649cf0f61d896c2f3af6e1402d4205"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8\u20139 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php:320-327 | src/opnsense/mvc/app/library/OPNsense/Auth/TOTP.php:262-270 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php"},"region":{"startLine":320}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c6d302ffe3799bd07f745489e909557af31ec2485127f454192d253cb3835ce"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8\u20139 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/Auth/Services/System.php:64-72 | src/opnsense/mvc/app/library/OPNsense/Auth/Services/WebGui.php:59-66 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Services/System.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"24b301140b94a6daaf8b5859a24eca8e5695b069b516a524864ee5265b2fea93"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php:422-430 | src/opnsense/mvc/app/models/OPNsense/Unbound/Unbound.php:47-55 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php:422\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php"},"region":{"startLine":422}}}],"partialFingerprints":{"codehealthFindingId/v1":"f2ccbbe156ec46ed48ea426aa8e41d787c82aa95da0d5955878675ba15befbc1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:336-344 | src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php:552-560 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php\u0060 as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 145 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":336}}}],"partialFingerprints":{"codehealthFindingId/v1":"dc4a047a87580e4d54a68e1721e7f5c7be4507a4d6ec76cbdb3f31ff1373bc42"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 6): src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php:77-84 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php:92-99 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php:107-114 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PingController.php:76-83 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PingController.php:91-98 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PingController.php:106-113 \u2014 there are 6 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 6 sites; resolving a subset leaves the remainder to drift apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php"},"region":{"startLine":77}}}],"partialFingerprints":{"codehealthFindingId/v1":"75c6edc1391928dd3e0188f034cf49c3de2777c794f3033951e47b0c1cf9eecb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/GroupController.php:119-126 | src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/LaggSettingsController.php:147-154 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/GroupController.php"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"6a4702b1a786d38ea6e51a54d6eae17ff0eb6b88b7f8f93e343c45eebf3dc5da"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php:175-182 | src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php:184-191 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php:175\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php"},"region":{"startLine":175}}}],"partialFingerprints":{"codehealthFindingId/v1":"22fcf9e285d868bc6b2139d7a7d49abd4e29393ca63d7161214792718e18951c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6\u20137 lines \u00D7 3): src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:273-278 | src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:282-287 | src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:289-295 \u2014 all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:273\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, \u0060src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:288\u0060 calls \u0060gettext\u0060, \u0060elseif\u0060, \u0060array_key_exists\u0060 and \u0060src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php:279\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php"},"region":{"startLine":273}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3052170a0157749d2381c9ce5f653340a62dca846e07355ada39e79e4613270"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6\u20137 lines \u00D7 3): src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:285-291 | src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php:446-451 | src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php:508-513 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php\u0060 as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 145 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:285\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":285}}}],"partialFingerprints":{"codehealthFindingId/v1":"59cefd0db472010ed9bcaed429917603df7a2e7701f1b1fd4e80609a6835b7f2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Auth/Api/GroupController.php:82-88 | src/opnsense/mvc/app/controllers/OPNsense/Auth/Api/UserController.php:216-222 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Auth/Api/GroupController.php"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"8ea0c6f8ba87c48fa16270034bf4c87d3d7d863f64c0cb9a7be8383f47715b08"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Kea/DhcpController.php:57-63 | src/opnsense/mvc/app/controllers/OPNsense/Kea/DhcpController.php:75-81 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Kea/DhcpController.php"},"region":{"startLine":57}}}],"partialFingerprints":{"codehealthFindingId/v1":"63c9c3e24719696609bf1bf6085e6f1711bfe7ddc456677aa614ec3bd49b3c98"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/Auth/Voucher.php:428-434 | src/opnsense/mvc/app/library/OPNsense/Auth/Voucher.php:440-446 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Voucher.php"},"region":{"startLine":428}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3a35f73afa3f94e232576916e365357d17a04c25eca9d3efba936c9aed787c9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 4): src/opnsense/mvc/app/controllers/OPNsense/Core/Api/SystemController.php:136-141 | src/opnsense/mvc/app/controllers/OPNsense/Core/Api/SystemController.php:143-148 | src/opnsense/mvc/app/controllers/OPNsense/Core/Api/SystemController.php:150-155 | src/opnsense/mvc/app/controllers/OPNsense/Core/Api/SystemController.php:156-162 \u2014 all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites \u2014 resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/Core/Api/SystemController.php:136\u0060 it runs out through the closing brace of the declaration holding it \u2014 the window is that declaration\u0027s tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/SystemController.php"},"region":{"startLine":136}}}],"partialFingerprints":{"codehealthFindingId/v1":"8b251211533d72a59fe07c959245be4a7ec07ee4aba2aaa87ebe6269993c9048"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php:107-112 | src/opnsense/mvc/app/controllers/OPNsense/Syslog/Api/ServiceController.php:127-132 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php:107\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php"},"region":{"startLine":107}}}],"partialFingerprints":{"codehealthFindingId/v1":"a34e90a058c608e77684b3a0647cafd2debc80813b32a9e98a91d7790f57d4a0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api/LeasesController.php:112-117 | src/opnsense/mvc/app/controllers/OPNsense/Kea/Api/LeasesController.php:99-104 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api/LeasesController.php:112\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api/LeasesController.php"},"region":{"startLine":112}}}],"partialFingerprints":{"codehealthFindingId/v1":"a4401c609a3144fbfcfaa80cdd3ed87b04172e7721f2f3365da0bc85fd82689c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GifSettingsController.php:128-133 | src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GreSettingsController.php:128-133 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GifSettingsController.php\u0060 and \u0060src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GreSettingsController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GifSettingsController.php:128\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GifSettingsController.php"},"region":{"startLine":128}}}],"partialFingerprints":{"codehealthFindingId/v1":"2a0edf2abfe95c1fde5d4ed2bbea3f865fe90015560e0182d3f484a5e995b9b8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ServiceController.php:75-80 | src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ServiceController.php:144-149 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ServiceController.php:75\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ServiceController.php"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"4938448ac466bb715d610731bd6ec19bb8ea9d3984ee9c63e3b0d759437346c9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/Auth/AuthenticationFactory.php:50-55 | src/opnsense/mvc/app/library/OPNsense/Auth/AuthenticationFactory.php:73-78 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/library/OPNsense/Auth/AuthenticationFactory.php:50\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/AuthenticationFactory.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"a750c775b6baae02c42dd9f229a7e5dc2c4d7d7ce0ea3e3c6424a3636bd05243"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php:206-215 | src/opnsense/mvc/app/library/OPNsense/Auth/TOTP.php:220-225 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php"},"region":{"startLine":206}}}],"partialFingerprints":{"codehealthFindingId/v1":"292c95fa98dc7611f2e93c3e5ef8ed8668c471268036555bb1f2d112deaaaf5e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php:399-404 | src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php:425-430 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php:399\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php"},"region":{"startLine":399}}}],"partialFingerprints":{"codehealthFindingId/v1":"2175af2b6cc7fc289b8dc84e97b1ce692dc8be4898bb18252ceba8129803b3de"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php:412-417 | src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php:438-443 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php"},"region":{"startLine":412}}}],"partialFingerprints":{"codehealthFindingId/v1":"00ab080e6128c2749e04c169c58df9f4c332319759275cefeb5a662c8e1ba404"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/OpenVPN/PlainOpenVPN.php:200-205 | src/opnsense/mvc/app/library/OPNsense/OpenVPN/ViscosityVisz.php:132-137 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/library/OPNsense/OpenVPN/PlainOpenVPN.php:200\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/OpenVPN/PlainOpenVPN.php"},"region":{"startLine":200}}}],"partialFingerprints":{"codehealthFindingId/v1":"083ec2d82cb142a99addb844b71e4233caa363fb97c763ceb3fe56f8b9bb591e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/IPsec/Migrations/M1_0_4.php:52-57 | src/opnsense/mvc/app/models/OPNsense/IPsec/Migrations/M1_0_4.php:63-68 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/models/OPNsense/IPsec/Migrations/M1_0_4.php:52\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/Migrations/M1_0_4.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b7030719537dec74644bb7d072b26acc89eb2c1188ed8625d6f246abe12ee7a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:200-205 | src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php:363-368 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php\u0060 as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 145 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:200\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":200}}}],"partialFingerprints":{"codehealthFindingId/v1":"07e05e8101bcfa53b193fafb438e21e911feb078963ad79dbe76386ac0d862b0"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/NetworkinsightController.php:63-67 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/NetworkinsightController.php:158-162 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/NetworkinsightController.php"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"beb684e0f967c1bea6634203fcb98163733567bd59fcfba6f62251fa729188c6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php:78-82 | src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php:153-157 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php:78\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"2c4c8094a5a7307cb2c90d1d7f2a7c89680f6e5f70305c95b6a6a882271e317f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/Firewall/DNatRule.php:120-124 | src/opnsense/mvc/app/library/OPNsense/Firewall/DNatRule.php:137-141 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/library/OPNsense/Firewall/DNatRule.php:120\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/DNatRule.php"},"region":{"startLine":120}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b4dbed1521f5141c601b58edd823bb18f7bd7b35b91c2394b38868009fd999d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Core/FieldTypes/TunableField.php:97-101 | src/opnsense/mvc/app/models/OPNsense/Core/FieldTypes/TunableField.php:107-111 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/models/OPNsense/Core/FieldTypes/TunableField.php:97\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/opnsense/mvc/app/models/OPNsense/Core/FieldTypes/TunableField.php:105\u0060 calls \u0060setValue\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Core/FieldTypes/TunableField.php:94\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Core/FieldTypes/TunableField.php"},"region":{"startLine":97}}}],"partialFingerprints":{"codehealthFindingId/v1":"a414aef8419301591cc6c2cf3629ae77a3948a13f6a8a91e30d9636f891e6eee"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php:371-375 | src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php:437-441 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php"},"region":{"startLine":371}}}],"partialFingerprints":{"codehealthFindingId/v1":"8fba2faf536e09d303800828298ae7bf4cc929bdda45e6eb105489cf9155471c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Unbound/Migrations/M1_0_13.php:122-126 | src/opnsense/mvc/app/models/OPNsense/Unbound/Migrations/M1_0_13.php:146-150 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/models/OPNsense/Unbound/Migrations/M1_0_13.php:122\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Unbound/Migrations/M1_0_13.php"},"region":{"startLine":122}}}],"partialFingerprints":{"codehealthFindingId/v1":"32ca18659da2517d8d0c05edf5837e91760a5af8615caed5b0bb27013ff27ec8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/scripts/health/library/OPNsense/RRD/Stats/Interfaces.php:35-39 | src/opnsense/scripts/health/library/OPNsense/RRD/Stats/OpenVPN.php:35-39 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/scripts/health/library/OPNsense/RRD/Stats/Interfaces.php:35\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/health/library/OPNsense/RRD/Stats/Interfaces.php"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"7225e61b3847dc479a84e5e1e79ce29fcba620f2b26a1e20a358919f1ba3c132"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (77 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/FirewallController.php:44-120 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/InterfaceController.php:44-128 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/FirewallController.php:44\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/FirewallController.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ef00b96680e2f06c079939d389d816a0a77a64421cd9ec98a8e990c20c3ec1d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (25 lines \u00D7 3): src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/FirewallController.php:44-120 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/InterfaceController.php:44-128 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/SystemController.php:44-68 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/FirewallController.php:44\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/FirewallController.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"2c30c0d0ae5a969499df27fe95b1c207013be1a5b8ffe98cdc07f512b48325bb"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (26 lines \u00D7 3): src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/ManualSpdController.php:44-69 | src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/VtiController.php:44-69 | src/opnsense/mvc/app/controllers/OPNsense/Radvd/Api/SettingsController.php:40-65 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/ManualSpdController.php:44\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/ManualSpdController.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"c22962af4c1c8e664df3794b509b4f7f8c8ea119181f3f507b5107aaf5f4b330"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (26 lines \u00D7 4): src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/ManualSpdController.php:44-69 | src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/PreSharedKeysController.php:49-95 | src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/VtiController.php:44-69 | src/opnsense/mvc/app/controllers/OPNsense/Radvd/Api/SettingsController.php:40-65 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/ManualSpdController.php:44\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/ManualSpdController.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"00b1c70743d487f79a6df70642fe3cbd7a0c31f88643a276b30f2a0d175a3ed9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (32 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/LoopbackSettingsController.php:41-72 | src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/VxlanSettingsController.php:41-72 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/LoopbackSettingsController.php:41\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/LoopbackSettingsController.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"7bb6b56a7e1800df4afad8507ba23ac0369735feff5e71f26a7d7274c612adad"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/System/Status/MonitOverrideStatus.php:38-52 | src/opnsense/mvc/app/library/OPNsense/System/Status/OpensshOverrideStatus.php:38-50 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/library/OPNsense/System/Status/MonitOverrideStatus.php:38\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/System/Status/MonitOverrideStatus.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"1c375d5072bd55a205dc643395d38b49268d6413f13ea2abefc8e4502f1764f5"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 3): src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/DescriptionField.php:53-71 | src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/EmailField.php:49-68 | src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/MacAddressField.php:44-72 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/DescriptionField.php:53\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/DescriptionField.php"},"region":{"startLine":53}}}],"partialFingerprints":{"codehealthFindingId/v1":"061259b02bad66a9f6bd755dfff4e068206c6b92879c1cc99d2b7a81ea6a8738"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (33 lines \u00D7 2): src/opnsense/scripts/health/library/OPNsense/RRD/Types/Packets.php:46-78 | src/opnsense/scripts/health/library/OPNsense/RRD/Types/Traffic.php:46-78 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/scripts/health/library/OPNsense/RRD/Types/Packets.php:46\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/health/library/OPNsense/RRD/Types/Packets.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"58340bc66bce3fd19880b015e9e56d2c3fb98a198f516b90b62aba48d36b3a5f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 3): src/opnsense/mvc/app/controllers/OPNsense/Core/Api/HasyncController.php:45-49 | src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/NeighborSettingsController.php:66-70 | src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/SettingsController.php:49-53 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made 3 times."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/HasyncController.php"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"c16350a4057f740dab0a353fe2c2b566b0f89197bfa72eda4afc0e518cf43cb1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/DHCRelay/Api/ServiceController.php:42-48 | src/opnsense/mvc/app/controllers/OPNsense/Radvd/Api/ServiceController.php:48-54 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/DHCRelay/Api/ServiceController.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"2001eabfb98ff2682cf4ec49573bdb680b66e95ba199dcb8d2c5e13158dab1a1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/NetflowController.php:187-193 | src/opnsense/mvc/app/controllers/OPNsense/Unbound/Api/OverviewController.php:139-145 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/NetflowController.php"},"region":{"startLine":187}}}],"partialFingerprints":{"codehealthFindingId/v1":"c2a3d9be4858e2cf30fc81f07b4247fc660c17575bc5c4b2314f21aa94706629"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 3): src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/CategoryController.php:135-139 | src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/Api/SettingsController.php:279-283 | src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/Api/SettingsController.php:301-305 \u2014 there are 3 copies across 2 file(s) \u2014 more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/CategoryController.php"},"region":{"startLine":135}}}],"partialFingerprints":{"codehealthFindingId/v1":"7ff76a8b9caa04c7add4fc6d15aefcd93242c1a61e6dbb3f9904e57dcc5d3fa6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 3): src/opnsense/mvc/app/controllers/OPNsense/Firewall/DNatController.php:34-38 | src/opnsense/mvc/app/controllers/OPNsense/Firewall/NptController.php:34-38 | src/opnsense/mvc/app/controllers/OPNsense/Firewall/OneToOneController.php:34-38 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/DNatController.php"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3134b871dfa247bd5bfd7d70746decb1623a5fd331945832b37d7cd24645aaa"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SadController.php:107-114 | src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SpdController.php:107-114 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SadController.php\u0060 and \u0060src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SpdController.php\u0060 as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/SadController.php"},"region":{"startLine":107}}}],"partialFingerprints":{"codehealthFindingId/v1":"11965f633d26f222ecadbe9b423052edbcac2a3985a245c66406a32c84b68b2f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 3): src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/BridgeSettingsController.php:131-137 | src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GifSettingsController.php:173-179 | src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GreSettingsController.php:173-179 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GifSettingsController.php\u0060 and \u0060src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/GreSettingsController.php\u0060 as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/BridgeSettingsController.php"},"region":{"startLine":131}}}],"partialFingerprints":{"codehealthFindingId/v1":"63a8234882d7d815a84357acf7a98e75847ed5fc8d84b9e5ed46131c186da6d7"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Kea/Api/Dhcpv4Controller.php:46-56 | src/opnsense/mvc/app/controllers/OPNsense/Kea/Api/Dhcpv6Controller.php:46-56 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Kea/Api/Dhcpv4Controller.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"88cabf8d7d29afe48ef661200860898e4e7692693e7896cddfa759f161f5d63a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/GroupSettingsController.php:44-50 | src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php:45-51 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/GroupSettingsController.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"a76547bc84c844355849f60facbbcf6f43521502b356e4ee8e98037df1989eef"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CaController.php:195-204 | src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php:242-251 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CaController.php"},"region":{"startLine":195}}}],"partialFingerprints":{"codehealthFindingId/v1":"e50f771743923d63654411e6b91ecd027f146a3a81347da2a7897e93a641c73e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Unbound/DotController.php:37-43 | src/opnsense/mvc/app/controllers/OPNsense/Unbound/ForwardController.php:37-43 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/controllers/OPNsense/Unbound/DotController.php\u0060 and \u0060src/opnsense/mvc/app/controllers/OPNsense/Unbound/ForwardController.php\u0060 as WHOLE FILES: 82% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Unbound/DotController.php"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"cfcea944b0bd8a9a06e1147b34ce7885ca7acd15662b5c91f61a4c862fad8538"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/System/Status/ConfigdProxyOverrideStatus.php:38-47 | src/opnsense/mvc/app/library/OPNsense/System/Status/IDSOverrideStatus.php:38-45 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/System/Status/ConfigdProxyOverrideStatus.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"fc7e5c459dd1234314f8177c45adb3f2de9c419e8fe51d59c8772c81fc508ae1"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/opnsense/mvc/app/library/OPNsense/System/Status/DnsmasqOverrideStatus.php:38-43 | src/opnsense/mvc/app/library/OPNsense/System/Status/IPsecOverrideStatus.php:38-43 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/library/OPNsense/System/Status/DnsmasqOverrideStatus.php\u0060 and \u0060src/opnsense/mvc/app/library/OPNsense/System/Status/IPsecOverrideStatus.php\u0060 as WHOLE FILES: 88% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names \u2014 the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/System/Status/DnsmasqOverrideStatus.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"aa867d60166c178f6597ee0fe059e0c39f32546317da17f7ec337df64ad0d77d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 3): src/opnsense/mvc/app/models/OPNsense/Auth/FieldTypes/GidField.php:97-107 | src/opnsense/mvc/app/models/OPNsense/Auth/FieldTypes/UidField.php:106-116 | src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/AutoNumberField.php:134-144 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/models/OPNsense/Auth/FieldTypes/GidField.php\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Auth/FieldTypes/UidField.php\u0060 as WHOLE FILES: 88% of the shorter file\u0027s lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it \u2014 treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Auth/FieldTypes/GidField.php"},"region":{"startLine":97}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c8ce6cb7d666f58b879f1dfd9a1f098c84707bc7da8a9b7aae1f667688b6119"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Auth/FieldTypes/MemberField.php:60-64 | src/opnsense/mvc/app/models/OPNsense/Auth/FieldTypes/PrivField.php:54-58 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Auth/FieldTypes/MemberField.php"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"20060607298ae8c5ca1b58b79e67f965ef2197a671c286817b74927b340374f9"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (22 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/IPPortField.php:105-150 | src/opnsense/mvc/app/models/OPNsense/Kea/FieldTypes/KeaPoolsField.php:47-68 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/IPPortField.php:105\u0060 it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows \u2014 the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members\u0027 bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run \u2014 a one-line delegation has no helper inside it to lift \u2014 so generate the run from the set it enumerates, or accept it and keep each member\u0027s own documentation with it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/IPPortField.php"},"region":{"startLine":105}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c9e6a85ae4b9e67acd81feba0e4c60bfd7bea3fa6c0f89f5f9bf0b8418e0d68"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Cron/Migrations/M1_0_2.php:40-44 | src/opnsense/mvc/app/models/OPNsense/Cron/Migrations/M1_0_4.php:40-44 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Cron/Migrations/M1_0_2.php"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"f70c7380c2de851369cb36f25593009e54cd372e8ebf99d290aadd9e8683927e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (27 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/AliasNameField.php:209-235 | src/opnsense/mvc/app/models/OPNsense/OpenVPN/FieldTypes/RemoteHostField.php:59-95 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/AliasNameField.php"},"region":{"startLine":209}}}],"partialFingerprints":{"codehealthFindingId/v1":"77652408a74674d5a1d32cb21fb26715e6d11481d789d3863ba14264eea63bff"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/IPsec/FieldTypes/IKEAddressField.php:51-55 | src/opnsense/mvc/app/models/OPNsense/OpenVPN/FieldTypes/RemoteHostField.php:47-51 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/FieldTypes/IKEAddressField.php"},"region":{"startLine":51}}}],"partialFingerprints":{"codehealthFindingId/v1":"f0687694ac316550434dd2f11bc960076bc12dd9f809a40533a587157f922ef6"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/DUIDField.php:84-94 | src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/LinkAddressField.php:95-107 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/DUIDField.php"},"region":{"startLine":84}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff05fbd501c2d73d444c75a4f21d19fc6bdcfcaa3500509d920bafbef87be360"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:119-126 | src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php:282-289 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php\u0060 as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 145 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"c19fd0ed988a848135cfeec827e9b86423a8e9d49151ee53baef744f4bd5e686"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:131-135 | src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php:305-309 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php\u0060 as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 145 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":131}}}],"partialFingerprints":{"codehealthFindingId/v1":"b75e36166285c0517c193c69fc9a72f5fb7f2e202fc5720584edaf04b7803325"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php:321-331 | src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php:537-547 \u2014 before extracting anything, compare \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php\u0060 and \u0060src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php\u0060 as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 145 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together \u2014 extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":321}}}],"partialFingerprints":{"codehealthFindingId/v1":"b8071804fa8f0b129bc5d90934472afb3ec88dc7722bf88ea360af34b321b057"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (18 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CAsField.php:47-64 | src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CertificatesField.php:48-65 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CAsField.php"},"region":{"startLine":47}}}],"partialFingerprints":{"codehealthFindingId/v1":"d8317eecc4fc0846ec0774e87dbd15f092df2bf303c0ea75a8bd69c76bc5b838"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Syslog/IndexController.php:46-53 | src/opnsense/mvc/app/controllers/OPNsense/Unbound/AclController.php:37-42 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Syslog/IndexController.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"76aeed91add6c5fdf5a551aaa97d6e8114193b796407df18e5019dd14c0bc500"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 3): src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php:370-374 | src/opnsense/mvc/app/library/OPNsense/Firewall/NptRule.php:94-98 | src/opnsense/mvc/app/library/OPNsense/Firewall/SNatRule.php:149-153 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from all 3 call sites, so a change lands once. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php"},"region":{"startLine":370}}}],"partialFingerprints":{"codehealthFindingId/v1":"b57a19cc792ae6d89d24ccbbc150ab4234b650ce468191ee36ad244755c5834e"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuSystem.php:174-178 | src/opnsense/mvc/app/models/OPNsense/Core/ACL.php:511-515 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuSystem.php"},"region":{"startLine":174}}}],"partialFingerprints":{"codehealthFindingId/v1":"79a419bc6de54d54260d241135687185fa49763b34de855239d0e023ddb78321"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/FirewallController.php:126-131 | src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/FirewallController.php:166-171 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/FirewallController.php"},"region":{"startLine":126}}}],"partialFingerprints":{"codehealthFindingId/v1":"c9b71127e2872c4390069689537137d5c373b07850b42bd4053cd0a47fd43e13"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php:337-341 | src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php:357-361 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php:337\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php"},"region":{"startLine":337}}}],"partialFingerprints":{"codehealthFindingId/v1":"44b01f47ee291b9a03ae33f3f02326e6850d896d3613686fdca37fe9f60e0fba"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/mvc/app/models/OPNsense/IDS/Migrations/M1_0_7.php:72-76 | src/opnsense/mvc/app/models/OPNsense/IDS/Migrations/M1_0_7.php:83-87 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/mvc/app/models/OPNsense/IDS/Migrations/M1_0_7.php:72\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IDS/Migrations/M1_0_7.php"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"a69b70c1ce30f966128695b3f7220efb9d2578a525b91b524659dd3c2a257d09"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/scripts/wireguard/wg-service-control.php:98-102 | src/opnsense/scripts/wireguard/wg-service-control.php:110-114 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/scripts/wireguard/wg-service-control.php:98\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/wireguard/wg-service-control.php"},"region":{"startLine":98}}}],"partialFingerprints":{"codehealthFindingId/v1":"11c030e1cb2dec295052bbbcc31eb1e6c87ba7d648bea53b3bb72d59d8be8444"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (75 lines \u00D7 2): src/opnsense/service/modules/daemonize.py:145-219 | src/opnsense/site-python/daemonize.py:143-217 \u2014 before extracting anything, compare \u0060src/opnsense/service/modules/daemonize.py\u0060 and \u0060src/opnsense/site-python/daemonize.py\u0060 as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 223 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/daemonize.py"},"region":{"startLine":145}}}],"partialFingerprints":{"codehealthFindingId/v1":"c786c56af8134dd2c993fd061b25612d63a78876d3264a3168346ef11b8b25a4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (54 lines \u00D7 3): src/opnsense/scripts/captiveportal/lib/daemonize.py:88-141 | src/opnsense/service/modules/daemonize.py:104-157 | src/opnsense/site-python/daemonize.py:102-155 \u2014 before extracting anything, compare \u0060src/opnsense/scripts/captiveportal/lib/daemonize.py\u0060 and \u0060src/opnsense/service/modules/daemonize.py\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 137 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/lib/daemonize.py"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"f19e78f5e175dba6743377f7b3ca0ddc573b0e0f19925fb2702f78a8a5803f2a"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (34 lines \u00D7 3): src/opnsense/scripts/captiveportal/lib/daemonize.py:178-211 | src/opnsense/service/modules/daemonize.py:209-242 | src/opnsense/site-python/daemonize.py:207-240 \u2014 before extracting anything, compare \u0060src/opnsense/scripts/captiveportal/lib/daemonize.py\u0060 and \u0060src/opnsense/service/modules/daemonize.py\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 137 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/opnsense/service/modules/daemonize.py:205\u0060 calls \u0060chown\u0060 and \u0060src/opnsense/scripts/captiveportal/lib/daemonize.py:177\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/lib/daemonize.py"},"region":{"startLine":178}}}],"partialFingerprints":{"codehealthFindingId/v1":"d49824b405317e9b29b90f39b58c369378ae894d657922e7c13382818e5bc1ee"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (24 lines \u00D7 3): src/opnsense/scripts/captiveportal/lib/daemonize.py:62-85 | src/opnsense/service/modules/daemonize.py:76-99 | src/opnsense/site-python/daemonize.py:74-97 \u2014 before extracting anything, compare \u0060src/opnsense/scripts/captiveportal/lib/daemonize.py\u0060 and \u0060src/opnsense/service/modules/daemonize.py\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 137 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/lib/daemonize.py"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"22074e9d0686453c0a897581e1b93c5a9430a1cf20bff49fdf6894c914c046d2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (23 lines \u00D7 2): src/opnsense/scripts/filter/lib/__init__.py:97-119 | src/opnsense/scripts/filter/lib/alias/base.py:113-135 \u2014 before extracting anything, compare \u0060src/opnsense/scripts/filter/lib/__init__.py\u0060 and \u0060src/opnsense/scripts/filter/lib/alias/base.py\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 66 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/__init__.py"},"region":{"startLine":97}}}],"partialFingerprints":{"codehealthFindingId/v1":"83b20a62de4f70c6ac9f2ebe12fa756e27e5f42eb0e67ad86a03660254629833"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (21 lines \u00D7 2): src/opnsense/scripts/filter/lib/__init__.py:50-70 | src/opnsense/scripts/filter/lib/alias/base.py:179-199 \u2014 before extracting anything, compare \u0060src/opnsense/scripts/filter/lib/__init__.py\u0060 and \u0060src/opnsense/scripts/filter/lib/alias/base.py\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 66 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/__init__.py"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"1f1741fcd12a842c59b72516099671495c0cb7871fb5df829756f269beab1b91"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 3): src/opnsense/scripts/captiveportal/lib/daemonize.py:146-160 | src/opnsense/service/modules/daemonize.py:162-176 | src/opnsense/site-python/daemonize.py:160-174 \u2014 before extracting anything, compare \u0060src/opnsense/scripts/captiveportal/lib/daemonize.py\u0060 and \u0060src/opnsense/service/modules/daemonize.py\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 137 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/lib/daemonize.py"},"region":{"startLine":146}}}],"partialFingerprints":{"codehealthFindingId/v1":"94235891749569ff649b511887bc165ec80fd8ccf4a1c335bc220ae9116b68df"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2): src/opnsense/scripts/openvpn/kill_session.py:40-53 | src/opnsense/scripts/openvpn/ovpn_status.py:39-52 \u2014 the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach \u2014 a file they already depend on, or a new one alongside them \u2014 and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/openvpn/kill_session.py"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9ee8647d4eadd9b2877e8e8058b805bed16482030e052720fbc791a7fb90198"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10\u201312 lines \u00D7 2): src/opnsense/scripts/dnsmasq/dnsmasq_watcher.py:72-83 | src/opnsense/scripts/unbound/unbound_watcher.py:164-173 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/opnsense/scripts/dnsmasq/dnsmasq_watcher.py:72\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/opnsense/scripts/unbound/unbound_watcher.py:162\u0060 calls \u0060list\u0060, \u0060time\u0060 and \u0060src/opnsense/scripts/dnsmasq/dnsmasq_watcher.py:72\u0060 does not \u2014 after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/dnsmasq/dnsmasq_watcher.py"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"172eece8f51304b1e0dfaa118d0d667cb63dba741d7e7700ee99b00eae05acd8"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9\u201311 lines \u00D7 2): src/opnsense/scripts/dnsmasq/dnsmasq_watcher.py:52-62 | src/opnsense/scripts/unbound/unbound_watcher.py:139-147 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. \u2605 These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, \u0060src/opnsense/scripts/unbound/unbound_watcher.py:138\u0060 calls \u0060UnboundLocalData\u0060 and \u0060src/opnsense/scripts/dnsmasq/dnsmasq_watcher.py:51\u0060 does not \u2014 after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/dnsmasq/dnsmasq_watcher.py"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"716f1f0415f2ca9fa23253f0c0498a004ede5a19a98b44e2446a79d26dcbcd02"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/opnsense/service/modules/daemonize.py:46-56 | src/opnsense/site-python/daemonize.py:46-56 \u2014 before extracting anything, compare \u0060src/opnsense/service/modules/daemonize.py\u0060 and \u0060src/opnsense/site-python/daemonize.py\u0060 as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 223 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/service/modules/daemonize.py"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"9767e6586b8938cdd58f24fbf4eade7d1c57b6fcd08a6794d170beae480f73ff"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3): src/opnsense/scripts/captiveportal/lib/daemonize.py:34-43 | src/opnsense/service/modules/daemonize.py:45-54 | src/opnsense/site-python/daemonize.py:45-54 \u2014 before extracting anything, compare \u0060src/opnsense/scripts/captiveportal/lib/daemonize.py\u0060 and \u0060src/opnsense/service/modules/daemonize.py\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 137 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/lib/daemonize.py"},"region":{"startLine":34}}}],"partialFingerprints":{"codehealthFindingId/v1":"7b9785b62e825435a6a32b04903ded61e1465755b1e6648df87fabefb09d4254"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2): src/opnsense/scripts/filter/lib/__init__.py:130-139 | src/opnsense/scripts/filter/lib/alias/base.py:146-155 \u2014 before extracting anything, compare \u0060src/opnsense/scripts/filter/lib/__init__.py\u0060 and \u0060src/opnsense/scripts/filter/lib/alias/base.py\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 66 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The \u0060return\u0060 at the foot of the matched lines is the enclosing body\u0027s own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that \u0060return\u0060 occupied \u2014 no decision has to be handed back and re-acted on."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/__init__.py"},"region":{"startLine":130}}}],"partialFingerprints":{"codehealthFindingId/v1":"36b53b802bb75fcdbd0dad09a37e2779de9f669a271ebc56dd9b7b39f2fcabe4"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/opnsense/scripts/captiveportal/cp-background-process.py:197-205 | src/opnsense/scripts/captiveportal/cp-background-process.py:206-213 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/cp-background-process.py"},"region":{"startLine":197}}}],"partialFingerprints":{"codehealthFindingId/v1":"b904cc047f752cd1045d4dd7b5b10c95b4a0eda4732c95da8b5d95612cc26eac"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/opnsense/scripts/shaper/lib/__init__.py:83-89 | src/opnsense/scripts/shaper/lib/__init__.py:127-133 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/shaper/lib/__init__.py"},"region":{"startLine":83}}}],"partialFingerprints":{"codehealthFindingId/v1":"b295a81296bc74018967db483f33de2c70ae63a6f726b8079144d2c2a4b5631f"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/scripts/captiveportal/cp-background-process.py:171-175 | src/opnsense/scripts/captiveportal/cp-background-process.py:181-185 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/cp-background-process.py"},"region":{"startLine":171}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fac4d8b84cf07f56830fd585f71e6a177c47e2eb4cee7ae5f369c2e1110ee51"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/scripts/filter/lib/__init__.py:87-91 | src/opnsense/scripts/filter/lib/alias/base.py:103-107 \u2014 before extracting anything, compare \u0060src/opnsense/scripts/filter/lib/__init__.py\u0060 and \u0060src/opnsense/scripts/filter/lib/alias/base.py\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 66 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/__init__.py"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"35ab7c26dba1577fb4720601e0e98ddc600d58228308dd2eea65fd7fe1c34f07"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/scripts/captiveportal/lib/__init__.py:68-72 | src/opnsense/scripts/captiveportal/lib/__init__.py:73-77 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/lib/__init__.py"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"7db9c389b2da517b35d3d3fda18aaffba626f0af650367f92439e0d871de861c"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2): src/opnsense/scripts/filter/lib/__init__.py:121-127 | src/opnsense/scripts/filter/lib/alias/base.py:137-143 \u2014 before extracting anything, compare \u0060src/opnsense/scripts/filter/lib/__init__.py\u0060 and \u0060src/opnsense/scripts/filter/lib/alias/base.py\u0060 as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 66 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/__init__.py"},"region":{"startLine":121}}}],"partialFingerprints":{"codehealthFindingId/v1":"eb171175d23a8798de264e17b6a83bc8c05dfaf0debb46ccd62ec4ef4ff23e0d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2): src/opnsense/scripts/syslog/logformats/__init__.py:151-155 | src/opnsense/scripts/unbound/blocklists/__init__.py:284-288 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/syslog/logformats/__init__.py"},"region":{"startLine":151}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed269b9fbdd1ab5708030c8816617fca4fbc23d71deab17b6340e36168185dd9"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: FilterBaseController (LCOM4 10): FilterBaseController\u0027s methods fall into 10 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 10 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php"},"region":{"startLine":44}}}],"partialFingerprints":{"codehealthFindingId/v1":"77d20a780a2a520742efb72b1a1c2273f35b5f0c4adfe712d65b0d362abf4d9e"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: Rule (LCOM4 6): Rule\u0027s methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/Rule.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"0f5b47b7bf2e085315677b8677948a1d929cd30e91b0141456549d32dcdff6d7"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: PortField (LCOM4 4): PortField\u0027s methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable \u2014 your repository\u0027s bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected \u2014 and which would otherwise dominate this list \u2014 are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"818276ed74c52a1a58b409a51f74fbc0bfa04402a76813a02ef249446b4b2503"}},{"ruleId":"D13","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"7d4e89de996500ffb2309902a3404f40091b7f9e11352f6b20f087bf722f2c9f"},"taxa":[{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php: src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php changed 23 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 39 in NetworkInterface.performValidation at line 200. 1 of those changes was a fix/bug commit, and the other 22 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php"},"region":{"startLine":200}}}],"partialFingerprints":{"codehealthFindingId/v1":"5c2c86eaa02a4fb180d44223f37824cb4d59f4943cb3a3396e643f0788db90a6"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php: src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php changed 7 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 71 in FilterRule.parseFilterRules at line 203. 2 of those changes were fix/bug commits, and the other 5 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php"},"region":{"startLine":203}}}],"partialFingerprints":{"codehealthFindingId/v1":"587e3c685e570fb2365a760d317a345ba51d93ed1fed3da2c410f8fa78c26160"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php: src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 117 in Filter.performValidation at line 42. 1 of those changes was a fix/bug commit, and the other 3 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php"},"region":{"startLine":42}}}],"partialFingerprints":{"codehealthFindingId/v1":"8defb8b6d677202ebd41278bbfeddda2de089da20ae27a27e08b7aeeb2647485"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/www/js/opnsense_bootgrid.js: src/opnsense/www/js/opnsense_bootgrid.js changed 11 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 39 in UIBootgrid._registerEvents at line 720. 1 of those changes was a fix/bug commit, and the other 10 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/www/js/opnsense_bootgrid.js\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":720}}}],"partialFingerprints":{"codehealthFindingId/v1":"e9e05d85bc2f4805c5ddf21ed99f7ffee06bb744f48fcc50532f0ac63247f33c"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php: src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php changed 9 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 35 in FilterController.searchRuleAction at line 84. 2 of those changes were fix/bug commits, and the other 7 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php"},"region":{"startLine":84}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb8e2b64b8011664581d9ea0cab723224b0b9ba4daf6abd2a2354cbab62dfc09"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/www/js/opnsense_ui.js: src/opnsense/www/js/opnsense_ui.js changed 12 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in opnsense_ui.$.fn.SimpleActionButton at line 816. 1 of those changes was a fix/bug commit, and the other 11 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/www/js/opnsense_ui.js\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":816}}}],"partialFingerprints":{"codehealthFindingId/v1":"8aa054a59f26667a678b3441627e7b4578e4b3fb36f9aa3f41b0ed20302b9d61"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/mvc/app/library/OPNsense/Firewall/ForwardRule.php: src/opnsense/mvc/app/library/OPNsense/Firewall/ForwardRule.php changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 35 in ForwardRule.parseRdrRules at line 100. 1 of those changes was a fix/bug commit, and the other 5 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/library/OPNsense/Firewall/ForwardRule.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Firewall/ForwardRule.php"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"8a231bb68da02948f9a96ccb9a11af43e164a3b2cf0af08716acb75bcde175c2"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php: src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 34 in Gateways.getGateways at line 329. 1 of those changes was a fix/bug commit, and the other 3 changed it for other reasons \u2014 this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one \u2014 a file this often edited pays the complexity back every time. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php"},"region":{"startLine":329}}}],"partialFingerprints":{"codehealthFindingId/v1":"2fe77b02de24ec60939ff54d614a99fced6851d2ab43b74dabd1df38ce8ea60f"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php: src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 26 in KeaDhcpv4.getConfigSubnets at line 182. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php"},"region":{"startLine":182}}}],"partialFingerprints":{"codehealthFindingId/v1":"de5b140007f7673b19baf7e55fd056a1521429320e39a623fbda7552beb618fd"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/NetworkInterfaceField.php: src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/NetworkInterfaceField.php changed 6 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 17 in NetworkInterfaceContainerField.toLegacy at line 41. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/NetworkInterfaceField.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/NetworkInterfaceField.php"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"cd31e3c42fea2f5c9bf8ffee2d6655a4f4734e135314c227436f554b9ca21a08"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php: src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 25 in ControllerBase.beforeExecuteRoute at line 373. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php"},"region":{"startLine":373}}}],"partialFingerprints":{"codehealthFindingId/v1":"5808f744c7a79c23fedb91a0774a12cd9c1745cb85a3aff933560aeb69501ac4"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php: src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 27 in CertController.setBaseHook at line 52. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"94af1f84afe5c182b88e4956cd02ecf392227ca919eaeb91fa45c81d922eb233"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php: src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 39 in KeaDhcpv6.getConfigSubnets at line 328. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php"},"region":{"startLine":328}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b24c6c575186de171d8cfc0b4b9c4fc03ded94e19d765e0ffcc97022fe45eb0"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/scripts/captiveportal/cp-background-process.py: src/opnsense/scripts/captiveportal/cp-background-process.py changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 38 in CPBackgroundProcess.sync_zone at line 140. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/scripts/captiveportal/cp-background-process.py\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/cp-background-process.py"},"region":{"startLine":140}}}],"partialFingerprints":{"codehealthFindingId/v1":"fdb2a24f89865c00a95bd5c1479a778093186e5790db72d184876a9959011280"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/www/js/opnsense.js: src/opnsense/www/js/opnsense.js changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 33 in opnsense.setFormData at line 146. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/www/js/opnsense.js\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense.js"},"region":{"startLine":146}}}],"partialFingerprints":{"codehealthFindingId/v1":"1a59f9cc77a527b45b86f6c380636051dc92a27df46c301cf4e7305cc6d82482"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CaController.php: src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CaController.php changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 27 in CaController.setBaseHook at line 55. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CaController.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CaController.php"},"region":{"startLine":55}}}],"partialFingerprints":{"codehealthFindingId/v1":"b37e1baa9680cd64d98ae37884074c37ce2a1ce7fe42e325af358cea84eef716"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api/LeasesController.php: src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api/LeasesController.php changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in LeasesController.searchAction at line 39. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api/LeasesController.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api/LeasesController.php"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"e0482023aec700c5f739c9b807d128d96d80ddcac144c972dd8c0f2d52fe53be"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/SourceNatRuleField.php: src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/SourceNatRuleField.php changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in SourceNatRuleContainerField.serialize at line 48. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/SourceNatRuleField.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/SourceNatRuleField.php"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"182841ccaa0865065d3e5e44cc7a90fff85f0f1353dca0690bca8f61111dc65b"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/www/js/widgets/BaseWidget.js: src/opnsense/www/js/widgets/BaseWidget.js changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in BaseWidget.getWidgetConfig at line 58. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/www/js/widgets/BaseWidget.js\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/BaseWidget.js"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"daf0b5266f656f7dbf93ee2176bf8771f03d14013789a420e6713b19ecbe7c1a"}},{"ruleId":"D15","level":"warning","message":{"text":"Hotspot: src/opnsense/mvc/app/models/OPNsense/Firewall/Menu/Menu.php: src/opnsense/mvc/app/models/OPNsense/Firewall/Menu/Menu.php changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in Menu.collect at line 36. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/models/OPNsense/Firewall/Menu/Menu.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Firewall/Menu/Menu.php"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"1b856a0670165cfc585608c9404df9ddfbf4b49b0dfa50a688049837053b0a9a"}},{"ruleId":"D15","level":"warning","message":{"text":"Repeated repair: src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/LvtemplateController.php: src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/LvtemplateController.php changed 3 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file\u0027s churn. Its max cyclomatic complexity is 1 (its worst body is LvtemplateController.searchItemAction at line 38), UNDER the 15 threshold, so this is deliberately not filed as a churn \u00D7 complexity hotspot \u2014 the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: \u201Cmvc: fix stale imports in diagnostics\u201D; \u201Cmvc: fix imports for Backend\u201D; \u201Cmvc: fix imports for UserException\u201D. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-22..2026-10-20, the 90 days ending at the analysed commit. Reproduce with \u0060git log --since=\u00272026-07-22 20:57:18 \u002B02:00\u0027 --until=\u00272026-10-20 20:57:18 \u002B02:00\u0027 --full-history --no-merges -- src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/LvtemplateController.php\u0060: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each \u2014 a difference of several commits on a file whose history was re-landed or reverted inside the window."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/LvtemplateController.php"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"a91af60a27560144fe29392fee49dcf7374332ee2fe11f384f9e8d00c7f415df"}},{"ruleId":"D16","level":"note","message":{"text":"Off-boarding risk: anonymized user #1: If anonymized user #1 becomes unavailable, 41 significant file(s) lose their only recent owner: src/www/interfaces_ppps_edit.php, src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php, src/opnsense/scripts/shell/setaddr.php, contrib/parallel-lint/src/Manager.php, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/InterfaceField.php, src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableServiceControllerBase.php, src/opnsense/mvc/app/library/OPNsense/Backup/Base.php, src/opnsense/mvc/app/models/OPNsense/Core/Firmware.php (\u002B33 more). Pair on, review, or document these before any departure."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"b8a1b98c27473d9cc9b072b405eb1fb35d0a7168cd333335a12d1c045f676409"}},{"ruleId":"D16","level":"note","message":{"text":"Off-boarding risk: anonymized user #2: If anonymized user #2 becomes unavailable, 27 significant file(s) lose their only recent owner: src/opnsense/scripts/netflow/lib/aggregates/__init__.py, src/opnsense/scripts/filter/lib/alias/__init__.py, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ArrayField.php, src/opnsense/scripts/filter/lib/states.py, src/opnsense/mvc/app/library/OPNsense/Auth/AuthenticationFactory.php, src/opnsense/scripts/filter/lib/alias/geoip.py, src/opnsense/mvc/app/library/OPNsense/Auth/TOTP.php, src/opnsense/mvc/app/library/OPNsense/Firewall/ForwardRule.php (\u002B19 more). Pair on, review, or document these before any departure."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"75246c918222f7b6c9db193bdcb4246409698a76b9f300a5bc0546e7a64ff609"}},{"ruleId":"D16","level":"note","message":{"text":"Off-boarding risk: anonymized user #3: If anonymized user #3 becomes unavailable, 9 significant file(s) lose their only recent owner: src/opnsense/mvc/app/models/OPNsense/Kea/FieldTypes/KeaOptionDataField.php, src/opnsense/mvc/app/library/OPNsense/Interface/Idassoc.php, src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/AliasNameField.php, src/opnsense/scripts/filter/list_legacy_outbound_nat.php, src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/VlanInterfaceField.php, src/opnsense/scripts/dnsmasq/get_dnsmasq_leases.py, src/opnsense/scripts/interfaces/reconfigure_gifs.php, src/opnsense/scripts/kea/del_kea_leases.py (\u002B1 more). Pair on, review, or document these before any departure."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"b65a853790a286b0bf58d2c3e48a0c47950ce8edf8fb8ad04ca9e00648d642a3"}},{"ruleId":"D16","level":"note","message":{"text":"Off-boarding risk: anonymized user #4: If anonymized user #4 becomes unavailable, 9 significant file(s) lose their only recent owner: src/opnsense/scripts/captiveportal/lib/db.py, src/opnsense/scripts/captiveportal/cp-background-process.py, src/opnsense/scripts/captiveportal/lib/ipfw.py, src/opnsense/mvc/app/library/OPNsense/Firewall/DNatRule.php, src/opnsense/mvc/app/models/OPNsense/Unbound/Migrations/M1_0_13.php, src/opnsense/site-python/duckdb_helper.py, src/opnsense/mvc/app/models/OPNsense/Unbound/FieldTypes/AliasReflector.php, src/opnsense/scripts/captiveportal/lib/pf.py (\u002B1 more). Pair on, review, or document these before any departure."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"3cef17fb36ba5e529fe93906127fadadf237e0c2d69b578e020c31e507659c5f"}},{"ruleId":"D16","level":"note","message":{"text":"Further sole-owners (lower concentration): 2 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold \u2014 folded into the bus-factor score and metrics (88 single-owned of 544 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 544 of the 926 production source files in this repository met that bar). They are anonymized user #5 (1 file(s)), anonymized user #6 (1 file(s)) \u2014 spread or document their files in the same way, at lower priority than the named off-boarding risks above. The files folded here: src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CAsField.php, src/opnsense/scripts/system/disk_info.py."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"6eac528f2429e724e1a97ed868f79eefbcf1888dab4af9a9e673429369bb5b2f"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: should replace \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/spdx-sbom/lib/spdx/spdx_element.py"},"region":{"startLine":48}}}],"partialFingerprints":{"codehealthFindingId/v1":"358e8e3137c5618b29adedc434c6b29758bb9bb179c2233d5078b3d33f6ead18"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: temp static block \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/spdx-sbom/lib/spdx/__init__.py"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"909fe53df78f78465fe208620f4b40594b25ed7d210d1f3b0dd5bf9793291b6f"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: temp static block \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/spdx-sbom/lib/spdx/__init__.py"},"region":{"startLine":73}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e5ef5693141988f85755bf2b88948c32f3c942a90c7ae644ebc58223c9e7026"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: replace \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/spdx-sbom/lib/spdx/__init__.py"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"4edf423b40e47d42ed24124675797db36a5e769c7999a89b57c97019c070af1b"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: static \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/spdx-sbom/lib/spdx/__init__.py"},"region":{"startLine":63}}}],"partialFingerprints":{"codehealthFindingId/v1":"715a4e5fcc26ab8b43ee5d007e798e55afb6aea6e0a7f7cb467e0ca02341ea9b"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX static data from SpdxCreationInfo \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/spdx-sbom/lib/spdx/__init__.py"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"3d55592c8da7d6699cbe2fe9f82ed8c95c5ff4aab0f2a34aadf81921dc92c73c"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: fallback, controller returned data as string. a deprecation message might be an option here. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php"},"region":{"startLine":402}}}],"partialFingerprints":{"codehealthFindingId/v1":"8c00723d6cbc4920b388171bb2e24fdb45f8020c383b5a5d9c9ee5487bc3afe5"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: Omit group types since they don\u0027t link to actual interfaces. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/FirewallController.php"},"region":{"startLine":84}}}],"partialFingerprints":{"codehealthFindingId/v1":"cfe8a2c71f4b37e96013c3dec10dff3c7972888fc76a129284bd035b1e87ee71"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: ideally this should get its own parameter and not reuse show_all \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php"},"region":{"startLine":215}}}],"partialFingerprints":{"codehealthFindingId/v1":"318e5faea3e1b7c39f411fddf111b1ccab3dfa6667fe18a37c94155625a00926"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: Loopback excluded since no rules should be on there \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php"},"region":{"startLine":320}}}],"partialFingerprints":{"codehealthFindingId/v1":"738df826de483f44d69dc02371b2801f9d1f0b40c53d1551ceccbbc4115c8672"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: as shaper1/2 don\u0027t have functional keys, we can only export uuid\u0027s here \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php"},"region":{"startLine":339}}}],"partialFingerprints":{"codehealthFindingId/v1":"f54c8da40a979f0bc30338a83803f07163c5b081e5577870f52c3f2f1ff1b729"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: addresses from \u0022pfctl -t xxx -T show\u0022 don\u0027t always match our input, we probably need a \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasUtilController.php"},"region":{"startLine":128}}}],"partialFingerprints":{"codehealthFindingId/v1":"5333e1c9f9647a851052e6d220d77911a0fe3e8013a6497f30d16922f7bdb5d1"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: we might add some attribute in firmware to store subscription status, since we now only store uri \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php"},"region":{"startLine":484}}}],"partialFingerprints":{"codehealthFindingId/v1":"716829ea0af55416b412687e86f2bcef0520c55384735893c40b4d6aae1099a9"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: a bit convoluted, should probably replace id at some point \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php"},"region":{"startLine":240}}}],"partialFingerprints":{"codehealthFindingId/v1":"71a63ce2c4795ca5b688a373d4bd346f9d41e87ec8b15c5e18e8ab4a29498817"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX a bit unpractical, but we can not validate previous values from the model so \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/VipSettingsController.php"},"region":{"startLine":139}}}],"partialFingerprints":{"codehealthFindingId/v1":"17f43293644777e4c379f2aa4ca24711f39098717b814d858721f60415da8cc0"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: sched_nr seems to be the linking pin to pipe \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/Api/ServiceController.php"},"region":{"startLine":144}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7083566fce260547afae59cccfdf30b701946919fde02b648238bb252b953fc"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: If not directly connected, we better still list the queues so we know what we miss. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/Api/ServiceController.php"},"region":{"startLine":152}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f8be332aead7e880d715a3340cdc7f18a272567a5bb4bb54e28c6f43c43eead"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: backwards compatible for direct callers that do not know about search_tokens \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Base/UIModelGrid.php"},"region":{"startLine":81}}}],"partialFingerprints":{"codehealthFindingId/v1":"20170c8a4e01426da95a262755385b77644e81284436217e31cf1e0abfc86f10"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: Structured field data (e.g. JsonAuditField) would need flattening here \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Base/UIModelGrid.php"},"region":{"startLine":136}}}],"partialFingerprints":{"codehealthFindingId/v1":"38d0bd4c8935fef509a2f6acb6901865665534b2eca450faee0ffebd28f256b2"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: One could argue these settings actually should be set in php.ini, but since legacy code is also \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Mvc/Session.php"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"a66e819d3aed4755606602ebff796cc942049ec7ee20e9e63c1a05c12111a332"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: temporary dual validation \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/Validation.php"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"078463202eeeda31263c2a79a558e3a22cfb4fc23cda5d76eea0756f2e94fbf0"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: although it\u0027s not 100% clean, \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php"},"region":{"startLine":221}}}],"partialFingerprints":{"codehealthFindingId/v1":"0bef60f58b24aa737c9bd91ac9c69bd000cfe03261c5371d3a5bf484bddd0d63"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: don\u0027t use as list, only for validation \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NetworkAliasField.php"},"region":{"startLine":46}}}],"partialFingerprints":{"codehealthFindingId/v1":"29e123ee1c85150938c65a9ca3b7f8a8ec4fa0ca95ab89676d0093b9e94c0193"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: may be improved a bit to prevent the same object being constructed multiple times when used \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php"},"region":{"startLine":219}}}],"partialFingerprints":{"codehealthFindingId/v1":"61b07468a58a145976c447d9502b29a1d7f5a34c3042503aff18ee84fb98681d"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: we could add caching here if configd overhead is an issue \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IDS/FieldTypes/PolicyContentField.php"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"c4754bbacd413dc3c42e650b4210c433447519f4157ce521b08004bbe1691e3f"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: although it\u0027s a bit obscure to update the model on validation, these two fields are \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/IPsec/IPsec.php"},"region":{"startLine":65}}}],"partialFingerprints":{"codehealthFindingId/v1":"1995481730650c133af69692498144354e2721864aeae5053f3c3ea4a7a644bd"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: If a subnet has been created for an interface that does not exist anymore, \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php"},"region":{"startLine":337}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2ecf44e1106b3217ce6c50504ebf9b720a94a3737376e71caf5f100334ad04a"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: previous legacy code did not check if the instance is enabled, we might want to revise that \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php"},"region":{"startLine":474}}}],"partialFingerprints":{"codehealthFindingId/v1":"8dc69d7302cc61b264d16ebeca5956e280f840ccbd257bc987a6843313d5ebde"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: In some cases it might be practical to drop privileges, for server mode this will be \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php"},"region":{"startLine":589}}}],"partialFingerprints":{"codehealthFindingId/v1":"a53319a8bafb47d0917048cc5d34883e524ea47fa81e869f5c75e1c4758c5c62"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: ditch ovpnc in a major upgrade in the future, supersede with interface setting \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php"},"region":{"startLine":443}}}],"partialFingerprints":{"codehealthFindingId/v1":"dab2b5cc99c4ff65552ce382a930eefdb75fff923890a05b527d8266028c36cc"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: $only_configured mimics the pre 19.7 behaviour, which means static non linked interfaces \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php"},"region":{"startLine":611}}}],"partialFingerprints":{"codehealthFindingId/v1":"3234375d4677721278d1e405dc47cf9db8556df745cf2ad4c50463b19a191eea"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: backwards compatibility, when no tiers are up, we seem to select all from the first \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.php"},"region":{"startLine":259}}}],"partialFingerprints":{"codehealthFindingId/v1":"6ffb1023f444d9ff18f3f65e6245b93f9cf2bc9b48cd7f4916d9ff71e0207fa6"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: Endieness can be weird and platform specific \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/tests/app/models/OPNsense/Kea/FieldTypes/KeaOptionDataFieldTest.php"},"region":{"startLine":113}}}],"partialFingerprints":{"codehealthFindingId/v1":"189fbbed80daa59bb1d09760c42ba16eed3c371b913790c9b2e2bcedb540a5a2"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX we pass the full path but do not accept any other directory \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/strip_template.py"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"c784d8f575c47ac6bbc31168e0b4efaf4670c09680749925e2f26b82334c0ccd"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX delete_reason is currently mapped to RADIUS keywords, as is this \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/cp-background-process.py"},"region":{"startLine":161}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb4bcd8ace7105a69353279dc8680634379205a80b4ed7177a2c0f255c81ddfc"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: in order to kill a state, we need to pass both the id and the creator, so it seeems to make \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/states.py"},"region":{"startLine":142}}}],"partialFingerprints":{"codehealthFindingId/v1":"7d41c9af427a921d97a987c65c147b65a80d9470d6eddcea120e5aba7ea560a7"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: At some point we probably want to refactor the Alias class to different types as implementations \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/__init__.py"},"region":{"startLine":143}}}],"partialFingerprints":{"codehealthFindingId/v1":"e4e89e12886f2c77b8024c6041282f26e795a867a4c54bc6ef3a171115856f2e"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: sort output, limit output results to max 200 (safety precaution) \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/interfaces/traffic_top.py"},"region":{"startLine":189}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c7f1749367c9c2d55ccdbf07088b2bcf988084b9d786e3da264bc8c17eac94d"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX this isn\u0027t strictly correct but we only consider this if it\u0027s 0 \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/monit/gateway_alert.php"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"51510c5373909df75d760db58d794fce6a78986a97dcf46ad53f6df72188afc6"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX currently unused \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/netflow/flowd_aggregate.py"},"region":{"startLine":227}}}],"partialFingerprints":{"codehealthFindingId/v1":"7be98c4480a1cbf8277b5ef0538392dca93a8773007e5f7b7436f8e636281db6"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX invalid (empty?) flow record. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/netflow/lib/flowparser.py"},"region":{"startLine":147}}}],"partialFingerprints":{"codehealthFindingId/v1":"057029fad3f3c03101fd58a136d73584ab9abeec91013784ba08280f4a40e0a7"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX logging, but where? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/shaper/sync_fw_hooks.py"},"region":{"startLine":97}}}],"partialFingerprints":{"codehealthFindingId/v1":"a6b8b51e5f0acd33247c5bfabfe43f62b98d3274316eeb039caeca2d58042fec"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # parse OPNsense rule config (XXX: migrate to policy) \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/suricata/lib/rulecache.py"},"region":{"startLine":114}}}],"partialFingerprints":{"codehealthFindingId/v1":"342c1e2804cedd3b5e923e35118f6f92adfbec53248c82aa4852ff79dd884430"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX: should probably add some plugin hook for this. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/syslog/clearlog.php"},"region":{"startLine":64}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b4891bcc348f2a06515dd09ff047a8cd44396c1f07655858a12371fb3c066a0"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: in python \u003E 3.13, replace with sock.get_verified_chain() \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/system/update-crl-fetch.py"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"c448f49653760360c6bdfe70126d5005043a7636c3afe0ed11a6b5fe3af0a8a3"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: probably too broad, but better make sure \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/system/update-crl-fetch.py"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"38c9f8786b93c59a27cf7cbcc87bb5047ce2f1c5d7ca4bea7f33eeef828ca660"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: only support http for now \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/system/update-crl-fetch.py"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b39f7fc5115ed78fa2706034581d647f150193a15592faced9472c39b57fd8b"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX \u0022blocks\u0022 provided for backwards compatibility \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/system/disk_info.py"},"region":{"startLine":82}}}],"partialFingerprints":{"codehealthFindingId/v1":"c362837707b8c1358be7fbeef6983c43d857a1de4df26886d5e5eb17d3df83c6"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: pyOpenSSL doesn\u0027t offer access to subject_name_hash(), so we have to call openssl direct here \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/system/certctl.py"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"bc92d4c2623c7d3fb20e6f7f38053c0f3aa11532671458f1992d93bbbf9fea5f"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX AAAA \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound-dnsbl/dnsbl_module.py"},"region":{"startLine":153}}}],"partialFingerprints":{"codehealthFindingId/v1":"b2cf478145a7254f7dff82cfbdea1df2f7e8660ecd0fe15c784803dae6a09ab0"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX invoke can fail (non-zero exit code), but unclear why and what to do \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/unbound_watcher.py"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"772c6ca5c93d219e1c601224b70aa4b059c45b8fca8d6675a138fa746f6cb6ad"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: remove when plugins are refactored \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/blocklists/__init__.py"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"f9b73274b94da6b21b329ad88dc2a07d248fd6d5bdcaabfc40a8ff336f8c54d0"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: Curves (very) limited supported \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/site-python/tls_helper.py"},"region":{"startLine":52}}}],"partialFingerprints":{"codehealthFindingId/v1":"66b8cf39b7ef4fc490144392aa025445067ce3f10cfcaf2cf81e831512e64810"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: not supported, but openssl.cfg settings do seem to apply here. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/site-python/tls_helper.py"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"a41a1cce31dfa20ad14787e1bd9133737aa21c5441922a08591c175166016941"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX:  TLS1.3 modifications not supported, openssl.cnf defaults should apply \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/site-python/tls_helper.py"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"5d5f7a33007486480df5ac2ed54b6b4b669cfe8bc0cbff4bc7368d440954faa3"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: We can only select a single curve here instead of a group \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/site-python/tls_helper.py"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"4bf0c105437b764605d8a7ae87f3d6555c5e9e790c3f1b12882a235cdf932e50"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: # XXX: this is extremely wacky, apparently we are not able to read the current storage version \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060# REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/site-python/duckdb_helper.py"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ab640fe5e1104ecd64e2aa42d186722d6d949507059575436177b086b01642d"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX Workaround: hook_stacked_form_tables breaks CSS query otherwise \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/firewall_schedule_edit.php"},"region":{"startLine":685}}}],"partialFingerprints":{"codehealthFindingId/v1":"a019fee66e643ce7602b61b903bc7968879110405893b513a30f43c565a0a2b3"}},{"ruleId":"D28","level":"error","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"426a0a80ad0766cd77cb437ad63283ebb76f9818c8638f4641701635cfd94716"},"properties":{"commitSha":"b899e523d48e35bf39cd404087206cdb2cd4ba36"}},{"ruleId":"D28","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"3cdfd7beb31b791ae18dcb425e21eb157c842e7bbcd522cc330573c1a6538db1"}},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"c63a5ae83d0716b5b18f67d2c4c70a2e20b6967ff34c041318d911c5d1eb02ae"},"taxa":[{"id":"CWE-208","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-697","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"923ce1da2434a73558a5e09d5bcc110461affe8816a283a405235b20a0632b6e"},"taxa":[{"id":"CWE-208","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"CWE-697","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A07:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"311d546a338d06fe9e3b31482aa504b37edf82ddabe9eb12f6b28609f4d131c8"},"taxa":[{"id":"CWE-611","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A02:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"51401bd23b1d7971d120bc114cd8804da27c99d2cb11ff1509f7be60328d7ae2"},"taxa":[{"id":"CWE-276","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A01:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"ff451ee2edb643e039ee59ae3bff2840090e6add34d7e157459a5ea8fb92efa1"},"taxa":[{"id":"CWE-116","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"7177f3fce4013156875d6cfa402c0afb386d08a1f68892f879aa972c7820b411"},"taxa":[{"id":"CWE-276","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A01:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"858bc141cda31cd1fe99c52b548dc320d402d7f3e6626a1ccd48a7d6bae6a6ed"},"taxa":[{"id":"CWE-457","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"e32ee2c51ed08927d9ff56ddfefc9c0f0f23838eb6143f6cc5789992ad0004e3"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"fd92f3f7043847b1e795130dc61b608894aa5195882146a26491c50e8343052e"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"e0ba61d2d2cbeb9a5fe1c80c12ee5ac2e0add3ec867923f54d2ac17946406981"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"4f070a4d06ddfdcf3ca40fb44871dd2faba2d4daecc67fde24504384678285cb"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"c676dd58e3bcedb61527a2c08959434ab79342540e6bcbdaca53140af5437f28"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"78bcda722084436734ea5a9a5653e8c04857f5bd46da58483ff82eb103e718d1"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"b07e333fc309a962a9f2c7595cc251e37ca518cfbc87d29e1c88306de0ed0eaa"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"973170d572d70969901032d20e4429949db3f19a460385a94e50f758ae95ed8b"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"e45b35d1b232defa70763592a402e9d69f79765a87495853d383ec492ddd69c8"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"8428f0c9efba71faee0c8bb50cf5d75239eeae6055d12a02259177ddf2d47c8b"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"845407d0cb4a33f45521321426e4de67dfa4210c3d8b5e12db886010287f7f50"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"22ddee037dff8ee26626a3ec1bf2c3e5b6052c37f40fe48126ea8cb8213f0380"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"b3c7416a9127796907c5b19543668b6ff6c5cf3ffe13b6435536436356b99eca"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"eedffa6c47677f7987b5d15ca5e85f8f95b4164c7eb373b2acd5c04090032617"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"93b36008e26bf9e654f76027e06ddd8fba3780773e5d4ac2382a2e71a46860a5"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"180d88607f82c6f9e636bf03fa2914a9b1779fc5ad70baa4d117ffe93e3ec85e"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"37bddd7d780e9d2155561c7668b8fe898b0e4bece9e0676941a4d7fec56d2359"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"14128bb891d79abfd10196da1023d90900de2f1c91a05507df056783e0e41f43"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"412dd47527ba52ecf2ab30b8619e33d8b83f4b40e3b8aa5fdbcc32295c8aec20"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"3d90a939351e815cac547b506a9dbdcfc5720a4f55c889aa0b031dbbe9eeeebd"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"b31f0ef953e56c02e6717906ac158406360377fc44bf34d0042b966508370755"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"cb5eea64ae995bf1a71ad95603bbebc83cae581bd88610e5235bd9953466b281"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"cd0efd7f58a6756cf2a7df8c22d1262279bb571ed94c681114d41a5604d8f2dd"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"e8124743a6e09ee7e2be5a95e96dc796341459f87bea9a5c6c6fdb7f0d72087c"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"12f253da896fdb139f23b32a73589ba8bed00d3a0cdc41ed4de54c2e5eace16b"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"0ff3c4525bb53c6f144303ea30689f3a038678969b4e38cc74b2e69ce6eb3c74"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"f88c17b7c007ab94fc900926b689e14fcec739526ad4b794c467b0ce7c3d50c3"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"abcbeb616723e860e776a13541dd8883594475370998c30a3d643292ff5f2fa5"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"2b390d14a47cc755436a24305c1e693bda522c76a3d785ccccf6a9d068ffae92"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"b9c7365380f59599d97571b67fcf97c7dc4b82ba984eabb298289232ecf2f0e6"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"40e1c42cffa67278f0c89d5a7a072e61734973b7919e9ff92b061736c7834d8f"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"b04f991a03bc21fda46da96d462e562a3058fdd0b4582c4b0d7ddb903cacd116"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"24650b9e2a3ebdebafecb853d14eea82eefb906f079b75e6f914f7c77fbe89e7"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"40380f81a4a6c58e1e3502f4ecc362e6729b303154fcc5d6a6d5eabbd42d9a5c"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"75a09f048377a254db887b3cc68c420724a969f9fd6304afe1d93ed49d1b12dc"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"3b5857b4b15b434aceed258a913dcfe193fcaa938112eb01df702abdd77c816e"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"18b704dc4e5353a4a7187d8f177a34a9a470f6f42b3d7a6ff54267bed11bd5b1"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"2c47fadaca72c0b43fe58498636be0a28a1caae0d84b5bf936c8786da0874888"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"8c38d88562a62e517885d1e3830a7649afd9c08e4d333f353029ae9cf581f965"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"34b78ed74e51b97f482de5f841f5dc1b157a168e6735b29e8e8a2a1e8ae6a778"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"ce0123f162fe08b7cf6b565e00394f444d5a36c1ae8e4c1b28eed744293f6e67"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"1712a4380d8e38779a3050de5a9f058109932b7aa6129129cc8eab4d12355ae4"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"44941d1cdccaeb4b12fa14ac5a0d032ca09c9406730b55382690ec46b70803a7"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"f26b8d8d9eec8e6ab32e05f57de487c841f5c453cb497ab893cc6b40243b502f"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"47715903c8c47c9f9a39a53da239970a34f99086bdb06564d872481c5dbf7435"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"ce66d795b11d745ab199f111112d00272d64959fba8e116790b56cac09b3457f"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"0b23e94ab90514db3e0ab861e8ab6f45b3aa0d9d78de4146be87d8c35696ec77"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"46b3e64ea957ee6274c0a1efcd98ba68636f8ff42b471ac9adfdb77c1574104d"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"3d516562081fff7283c4ddf19ec5aa11f5c1ecfa421728080acbb922abfb8f87"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"1568e438275192dcd6be674bd1d5992023daa226b07ee928bccbc20a209d60ed"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"73db6b37cbfbdaf7adeeaee085bfa0929e6c75754f6a56f5b5ff8c3581fe771d"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"8b3a5d3399f033f33ad1839ff3497fbf85a7f71ecc1dab7fdddbc77146d14b45"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"0ed221c10de14380baf2df8dd7c97258f1eb19abcb9c19a6e716a806b14641eb"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"79ddb4111dc40f871b963e009b6ae6cf35c05ddefed16ab6919e6833953d89cc"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"29ad9726432a2742303653436ebccdf04e0be551fb8aec35e3566bdba8fe7323"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"165770784026d04063413d1260327e7ecaf6eebc3632f83e0f8aaaabe381c464"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"809bbe41a428c298a38d7154bc37959a2963d04cdf6bf62a5397b88ca13d3bb0"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"0cef4022bb7b1fd0aa80710ca0617383c23e32c5b02ab04e2310b2fe7148a6c9"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"7a46c492a54e98e992bfd964e46acdae27c4d42b6ecc0332f713e154eddd0a6d"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"21156e338a671e055e66ff79200ba90a543e3664f5d5b4ecae4ec5cbbb755a68"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"a8dfc7875a389190215ad5e73b938c3da4ffbdb4464df63cc7ee188d006ff0c2"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"b1118b9094937c26a2b8f69bf281f2f36420ba0259317cbd525f2661845817dc"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"8ef49fe8c0ccbfe5eb17e0ce3bec70eec641c3f59863f53bef4e08cfb99c8fe3"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"928b165e4cdbfbe1f9450582fad22303ed5a5fd6f2c28c5c0c22c4cd8365e00d"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"272a9e2e0cc10f7e6cb8e1c109d48d6628f38f24118093cf649be5067ac6146c"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"14e64cc75e7051244b22eafd02e72af29b1381f07813ae6d39a017facdb098eb"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"0756e506ab67fedbff0e8753271495baf9744375592d053ea4055aeb196209d8"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"6270d3eaefc895c3a61a1dbdefdf499bfad6def56969fa55f7d983cf54b2c403"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"85c2a7580941f777a43ff5d67aa2f3406baab1c178f8f6d4e4be5b92706c99a7"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"ff6d84b3ec026c44e4111e7f3be3d86f2078e406fa7ce8174a97121a361b60b8"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"65476a115876095cf407618373dc8465b6f65d3e1bc866fb66b7ad7189f17ade"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"530220bc9f4a15e2c0965e38807240db511e11578cca5f33eed8ba3cc7c233b7"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"6d12c9470884632e6781ef70fabf77507a5cc5ecacebfdf5d8ff3e3f4b1424c1"},"taxa":[{"id":"CWE-918","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A01:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"0e3b3da0f2bb44bdb9ae05cdc5ea517a7a6fb7d253b467bfa89c48658e4ca174"},"taxa":[{"id":"CWE-918","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A01:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"2cda5f91a1624f064f9ca2d60988d517a0ef880d5d02d4d2809c0a331c82267f"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"dfa29adb1593b3f768e1d6184b83714057537e52ba2b1674ecc374f13122e7f5"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"92be88bcafa8b4d62a6374065fa342f861221bc4210c9a598610cd6f165dcbc1"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"802c105b129171e70115812df5f14ddd475220f019c7159e83431eec2f5f40b0"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"f979455609d281d0b118c68cc7c908c395dd00020176aeab9cbbc68f0031fa1e"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"c33d879ad184d2b19eaeb7e8cb36da7244f90b38dfd8107307be91017ff81508"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"3236d891f75a6965f9d170496f54c3cec0f6c6c0bfe2903930cf0700f3f2e5d4"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"50ab00ec9a0e6c8304d65c46f6a3f820c577d16bd32d5761a92bd23b9b96b76a"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"142440b9e23e9180ba6aa9a6b6ed83bff65c202b6a755576e29ccdc9da90cb95"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"19239b567eb407b30afbe20fde77b0f139ea60b0625f94d4c99a99d671ebc0b0"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"d11b36c86cdf9b4d430d3a105b2e31e44240f38451a5a0446a8b2b9a089e01ad"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"efadfe23b99a2154afac8db91154a908706c17ab541ae00462c83e3cf4bb2f24"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"8ce6b27b57881836e2a07f0a1ac710af3579f3d886cd70aba379a9b208b99ce3"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"4f3cc470c6df91417bf8bcf776ba898d73c8466d659fb6186754d68c74fe2e69"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"11519233e0f7458a4985874d63305734487e105e88f40f2450b65824ef319236"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"036a78d2a5355f221459a028b069044b522d6d2adaccc5691591c604f7408661"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"a9d88a7a9ef24c4ff6f3e4c3653ff0fb0b839b11cd8233c817a77322a2622686"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"eed4013b36d041b0b2dad840e100fa8120ad87fb97f6ca4678d5a735dedb57ff"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"cbcefc2252b7e46e5aec3a57f29ffd4f673c6a7465ad7dc80019daa624e04b72"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"dfa313986afabfdf26826e665310dda8b5f3e108da47c5c3a101a6ec1c339490"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"6115fffd10fd6d747cbaf47dfec266ee39254558065fa83e97a2b72d89b091d2"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"2c412d29670c490e934981d217879c7dcdcd2ca924da24435495572c01eefd6f"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"1a6f43a980596cab0c9fee125e1cb14a2c3a324f13f7113abfaf009e141f3e0b"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"42d75d254aa4662e4159f94d17e4d2af1aa6b6228134da4ff80053c4888b7abb"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"eee4bcf5cf1f694746cbbfb37b54a654f56dd2cf6c1383f7ed982ecf4f689cfc"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"b44d2ba722ad056a10165a9ebe4bed3dbd088d7285b8efbcb9a86e29831441d0"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"74db906d0a4c56f81714d9b9fbcc03bf1de33585bd83160630fb3cdb15900997"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"a099bc7575a633ab9af540a56c622d33aac6f4f906a773b795393dfe68f92653"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"8d539dca943a09b5599c6f25027c8f5381549ea16e555b1055d3eba64ef4a5ff"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"451e9afb2769fd3af0fecceb99624f709ae677bb92f440c1952c0f5d7d3c8d71"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"f6c1244e19bb47275013a2dadbd658e6d5086c20fdf9f3e8a358b2823d81f1db"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"293d9e0bbca775c899428da26e9fadba65b2c69608779f0ed92255110e30d208"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"1bc1f4846d3e3a92d24cced965a7781be4114431cafded36a5389ff60eba5ac0"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"8a445b2a523741c8031b5d570b8761f8baece09f85bf4095100783fea0e836b7"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"7dba5b46e3f91ed71b12cad7af0e99cef3a4edf2d4545eebb03eec0c8fa3b85c"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"c3b782a6433e5c6bef1ceaa0046685fe6a4888979cdba247ea245868020a95e8"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"742d0a17c071b7908fa602c20abe008878b9c34b6400df38ac657ea75b588c12"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"a117081179da1d016b1a6f60be7b26ab5ab69efd9bcdec09279105360a021611"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"1b313681adcb9e4de5394202b43ef69e8ea6414974fa10dbfda829bfc63ce654"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"a985b9b9dd9bac7fc13397cb4599c28f328c48a1c168dd1330d111dbfdd655ef"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"734e0b7c7a64dc6d1f838eec526782b8f32c75f121d25f8e00b56d32908f0eae"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"55b2c2a56e3f209c9290553407fde7ebf73110de5ad905fc6430171e0e486dd6"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"36afb00da8c400d7de8073192a89ec10ed2dfbb8b0949abbf413fae9f73b1f76"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"19bfffa76296eab8db5f16c08a9a3f15d630ab8d34c76491ee23bd581a69b43b"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"9367e28b1694dfcc3f34955af4bf820d24fa7a058958439d6a972a5c371dd858"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"warning","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"00638e6319bafdea6518859fd26620d2704e149715758772bec9971d323414de"},"taxa":[{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"90009c9f0eacf87513fd2ae8dc01278e7c503d637261fa346ef21ca780ea2d00"},"taxa":[{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"150d520fbe457f59cdbcb94f84a72b89427ea44831e2ca3b4b0c00c13b25ade5"},"taxa":[{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D29","level":"note","message":{"text":"A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."},"partialFingerprints":{"codehealthFindingId/v1":"b70fe346139fa0ca666df17752e381b586528b42f9dab8f6e47eccb85e775402"},"taxa":[{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},{"id":"A05:2025","toolComponent":{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61"}}]},{"ruleId":"D34","level":"note","message":{"text":"Orphaned files with no living knowledge: 1 of 556 analysed file(s) have no living knowledge left \u2014 their last meaningful change has decayed away, so if one breaks, no one currently understands it (counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 556 of the 926 production source files in this repository met that bar). None is large enough to earn a read-through of its own, so this row stands in for the per-file rows rather than raising one each \u2014 most significant first: src/opnsense/mvc/app/models/OPNsense/Monit/Migrations/M1_0_7.php. Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"ce861fd78f6935114d3a342cb90ad25870f984e1042954fcbbe27c0e23be3658"}},{"ruleId":"D34","level":"note","message":{"text":"Orphaned file: No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Monit/Migrations/M1_0_7.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"371799849cecf2883ccb98d0bce664b98e480b7ba85067f97b200a0b2d9420de"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: ArchiveOpenVPN.php \u2194 ViscosityVisz.php: \u0060src/opnsense/mvc/app/library/OPNsense/OpenVPN/ArchiveOpenVPN.php\u0060 and \u0060src/opnsense/mvc/app/library/OPNsense/OpenVPN/ViscosityVisz.php\u0060 change together 90% of the time (9 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository\u0027s 10,000 most recent commits rather than its whole history \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package \u2014 so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are \u0060693ea2d9\u0060 VPN: OpenVPN: add tls-crypt-v2 support (#10069); \u006084ec4540\u0060 VPN: OpenVPN: add tls-crypt-v2 support (#10069); \u00603ef4d20e\u0060 openvpn: replace exec() in MVC code #9325 \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/OpenVPN/ArchiveOpenVPN.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"ffa3f5053cf94f9325c4b2d1bab806745c25f41caea4293cbd7b3428955069f8"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: OverviewController.php \u2194 stats.py: \u0060src/opnsense/mvc/app/controllers/OPNsense/Unbound/Api/OverviewController.php\u0060 and \u0060src/opnsense/scripts/unbound/stats.py\u0060 change together 58% of the time (7 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository\u0027s 10,000 most recent commits rather than its whole history \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) and are written in DIFFERENT LANGUAGES, so no import can join them and they cannot be co-located into one unit \u2014 they compile and ship as separate artifacts. What binds them is a CONTRACT across that boundary \u2014 an event or message name, a route, a serialised shape \u2014 that each side currently spells out on its own, which is exactly why a change to one drags the other. Declare that contract once where both sides read it (a shared schema, a generated constants file, an interface-definition file) so a change on one side fails the other\u0027s build instead of drifting silently; where the surface is too small to be worth that, name the counterpart in a comment on both sides so the next reader finds it. There is nothing here to merge. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are \u00609ac5b8e2\u0060 unbound: add per-policy quick actions in reporting overview. (#9559); \u0060b533835f\u0060 Reporting: Unbound DNS - duckdb version upgrade handling; \u00601e07a736\u0060 Reporting Unbound DNS: add drill-down for client graph \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Unbound/Api/OverviewController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"ac49a576ee8b8d4a9b43dee0778a1a71f82842567d37fd9114d5046c182564da"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: CategoryController.php \u2194 opnsense_legacy.js: \u0060src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/CategoryController.php\u0060 and \u0060src/www/javascript/opnsense_legacy.js\u0060 change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository\u0027s 10,000 most recent commits rather than its whole history \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) and are written in DIFFERENT LANGUAGES, so no import can join them and they cannot be co-located into one unit \u2014 they compile and ship as separate artifacts. What binds them is a CONTRACT across that boundary \u2014 an event or message name, a route, a serialised shape \u2014 that each side currently spells out on its own, which is exactly why a change to one drags the other. Declare that contract once where both sides read it (a shared schema, a generated constants file, an interface-definition file) so a change on one side fails the other\u0027s build instead of drifting silently; where the surface is too small to be worth that, name the counterpart in a comment on both sides so the next reader finds it. There is nothing here to merge. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are \u00601d039417\u0060 Firewall: Categories / cleanup search action.; \u0060b5b9a2ea\u0060 firewall: categories improvements (#4790); \u00600cf98f4f\u0060 firewall: categories improvements (#4790) \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/CategoryController.php"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd4643d123b47e5176f3bbeb7c027f86f4a511a1026f12daa8dc9c21e09d5d3f"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: logger.py \u2194 stats.py: \u0060src/opnsense/scripts/unbound/logger.py\u0060 and \u0060src/opnsense/scripts/unbound/stats.py\u0060 change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository\u0027s 10,000 most recent commits rather than its whole history \u2014 a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency between them. They sit in the same directory, but in this ecosystem each file is its own module \u2014 a sibling reference still needs an import \u2014 so the missing import edge is real: the coupling runs through shared behaviour, not a declared dependency. If they duplicate structure, extract the common part into one unit; otherwise the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are \u00609ac5b8e2\u0060 unbound: add per-policy quick actions in reporting overview. (#9559); \u0060b533835f\u0060 Reporting: Unbound DNS - duckdb version upgrade handling; \u00605a3765a0\u0060 Reporting: Unbound DNS: resolve hostnames for clients \u2014 run \u0060git show\u0060 on any of them."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/logger.py"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c3d93fd7420c7c775ee72165f057eb3bd3514999d537950fc7de5eb4e5220ec"}},{"ruleId":"AC1","level":"error","message":{"text":"\u003Cimg\u003E without a text alternative: An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt \u2014 alt=\u0022\u0022 if it\u0027s purely decorative."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/htdocs_default/index.html"},"region":{"startLine":179}}}],"partialFingerprints":{"codehealthFindingId/v1":"04f00feaa139b20d0b0189c83584b3f9f65cc99e71aed14fa9c96dd705ca18e5"}},{"ruleId":"AC1","level":"error","message":{"text":"\u003Cimg\u003E without a text alternative: An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt \u2014 alt=\u0022\u0022 if it\u0027s purely decorative."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/htdocs_default/index.html"},"region":{"startLine":180}}}],"partialFingerprints":{"codehealthFindingId/v1":"befb3a63b91dc5f4717a90318f200d876900e4931155567fc38e33b9fd484f19"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Cbutton\u003E with no accessible text: A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1379}}}],"partialFingerprints":{"codehealthFindingId/v1":"be4e428f75c6c03b85f8fa9dfa1c599d70fb910f5451b2cd9483fc414be8416b"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Cbutton\u003E with no accessible text: A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1962}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd514f224082bed0a0a456988bf23d450772227bba521756e031c868b28df4f8"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Cbutton\u003E with no accessible text: A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1983}}}],"partialFingerprints":{"codehealthFindingId/v1":"41e451ac6b2b09c735e0a33850a8c6cc537304f8ba602ecb6ced8c53b9ffdb9a"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Cbutton\u003E with no accessible text: A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1984}}}],"partialFingerprints":{"codehealthFindingId/v1":"a024e86e11c7dbc5a3379a5158a945beb6bcbaf15a5f267b552ae4289112b547"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Cbutton\u003E with no accessible text: A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1985}}}],"partialFingerprints":{"codehealthFindingId/v1":"ea0a183f3ea80b7629533f72c2cd9fb937b6004fe127e7468b0f1f7d33787014"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Cbutton\u003E with no accessible text: A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1986}}}],"partialFingerprints":{"codehealthFindingId/v1":"9afbb69f20c76b7180611190507bc9af1667906e4581204bda4ce9f940344976"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Ctextarea\u003E without a programmatic label: This control has no associated label. Add a \u003Clabel for\u003E / wrapping \u003Clabel\u003E / aria-label / aria-labelledby so assistive tech can name it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":356}}}],"partialFingerprints":{"codehealthFindingId/v1":"a6fca712a6bff3fb1a02d846a56ea79abf6da918f69077351016cea85843695f"}},{"ruleId":"AC2","level":"warning","message":{"text":"\u003Coptgroup\u003E without a label: An \u003Coptgroup\u003E groups \u003Coption\u003Es but has no label, so assistive tech announces the group with no name. Add a label attribute."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":987}}}],"partialFingerprints":{"codehealthFindingId/v1":"66481dd5bd976fad1a6d4014835f99687a6945e7ca9e569c4ff13de39b55dcf5"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Cinput\u003E without a programmatic label: This control has no associated label. Add a \u003Clabel for\u003E / wrapping \u003Clabel\u003E / aria-label / aria-labelledby so assistive tech can name it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":1051}}}],"partialFingerprints":{"codehealthFindingId/v1":"6abf0020368ceb2ad270dd2165283131c59028545a56b94edbda9cb688294c89"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Cselect\u003E without a programmatic label: This control has no associated label. Add a \u003Clabel for\u003E / wrapping \u003Clabel\u003E / aria-label / aria-labelledby so assistive tech can name it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":1201}}}],"partialFingerprints":{"codehealthFindingId/v1":"eab8c062ab57a0eb86f1b8a8d4756274689c4f40dff6ed10271b78f0aeae6a29"}},{"ruleId":"AC2","level":"warning","message":{"text":"\u003Coptgroup\u003E without a label: An \u003Coptgroup\u003E groups \u003Coption\u003Es but has no label, so assistive tech announces the group with no name. Add a label attribute."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":1223}}}],"partialFingerprints":{"codehealthFindingId/v1":"d9051b788ffa75681f294bd6a718482c3995c0b3462e4b532e1e328c879c50e3"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Cselect\u003E without a programmatic label: This control has no associated label. Add a \u003Clabel for\u003E / wrapping \u003Clabel\u003E / aria-label / aria-labelledby so assistive tech can name it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":352}}}],"partialFingerprints":{"codehealthFindingId/v1":"be821f0cca8347dd8b9de90f64d5c4d21ce20530ad7ef01ee28892e3f901a108"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Cinput\u003E without a programmatic label: This control has no associated label. Add a \u003Clabel for\u003E / wrapping \u003Clabel\u003E / aria-label / aria-labelledby so assistive tech can name it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":363}}}],"partialFingerprints":{"codehealthFindingId/v1":"bbc9db0339754ae84507193ab88cb9406b6a45ac68480a33343606e2ff36f183"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Ctextarea\u003E without a programmatic label: This control has no associated label. Add a \u003Clabel for\u003E / wrapping \u003Clabel\u003E / aria-label / aria-labelledby so assistive tech can name it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":367}}}],"partialFingerprints":{"codehealthFindingId/v1":"739ace6b0f54ef7e2fd48c4e5d50219190ae722af0170d17c9f7c7d51211817d"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Cinput\u003E without a programmatic label: This control has no associated label. Add a \u003Clabel for\u003E / wrapping \u003Clabel\u003E / aria-label / aria-labelledby so assistive tech can name it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":375}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed59609fd7d8fad645db4f69e69b2615dbec0ff0cdfb0caa3ea0904ee6347f0b"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Cbutton\u003E with no accessible text: A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":1182}}}],"partialFingerprints":{"codehealthFindingId/v1":"68139181b055f547babe2586b1576e312e7de7f9a85905e02654eafff457c4d9"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Cbutton\u003E with no accessible text: A button with no text and no aria-label has no accessible name. Add visible text or an aria-label (an icon-only button still needs one)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":1202}}}],"partialFingerprints":{"codehealthFindingId/v1":"ced92fe1c7f415a5fd9e4c23943d99867f7599f7788c2ddf07bc9ceabfed51d3"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Cselect\u003E without a programmatic label: This control has no associated label. Add a \u003Clabel for\u003E / wrapping \u003Clabel\u003E / aria-label / aria-labelledby so assistive tech can name it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":1213}}}],"partialFingerprints":{"codehealthFindingId/v1":"47a8d46a4c9f1c87cdd16995bb61e8732f1a9e17e7494b81388d4b25dc032026"}},{"ruleId":"AC2","level":"error","message":{"text":"\u003Ctextarea\u003E without a programmatic label: This control has no associated label. Add a \u003Clabel for\u003E / wrapping \u003Clabel\u003E / aria-label / aria-labelledby so assistive tech can name it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/Firewall.js"},"region":{"startLine":229}}}],"partialFingerprints":{"codehealthFindingId/v1":"3b44963410a1e38ff107a15bea6b217366f066e3d9d21a32aabec8a6f611dc29"}},{"ruleId":"AC3","level":"error","message":{"text":"\u003Chtml\u003E without a lang: The page declares no language, so assistive tech can\u0027t pick the right pronunciation. Add lang (e.g. lang=\u0022en\u0022)."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/htdocs_default/index.html"},"region":{"startLine":2}}}],"partialFingerprints":{"codehealthFindingId/v1":"a2f62021aee1bf7b6836023895f9e6b88b55a9cdc6e070a29a29a26c4677cca0"}},{"ruleId":"AC3","level":"warning","message":{"text":"Empty \u003Ch3\u003E heading: An empty heading appears in the document outline announced with no text. Give the heading text, or remove it if it\u0027s decorative."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap.js"},"region":{"startLine":1994}}}],"partialFingerprints":{"codehealthFindingId/v1":"e17ba8f4fc066578bf418cc49619ab6fd27e76561fc53e8c8aaa36e0829e071b"}},{"ruleId":"AC4","level":"warning","message":{"text":"Anchor without href: An \u003Ca\u003E with no href, role or tabindex isn\u0027t focusable or keyboard-activatable. Give it a real href, or use a \u003Cbutton\u003E for an action."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1281}}}],"partialFingerprints":{"codehealthFindingId/v1":"eadc0571e98796727f81b591ba8b88a690e541c5f21618d00194409ab289f987"}},{"ruleId":"AC4","level":"warning","message":{"text":"Modal dialog does not manage focus: This \u003Cdiv role=\u0022dialog\u0022\u003E is a modal dialog, but nothing moves focus into it when it opens and nothing keeps focus inside it while it is open, so a keyboard or screen-reader user keeps acting on the content behind it (WCAG 2.4.3). Use a native \u003Cdialog\u003E opened with showModal(), a dialog component that traps focus, or move focus to the dialog on open, trap Tab inside it (or make the page behind inert) and return focus to the control that opened it on close."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1181}}}],"partialFingerprints":{"codehealthFindingId/v1":"71bb3a9187e72639828606231fec7339765bda532fe5ea00ffa9592814ea2004"}},{"ruleId":"AC4","level":"error","message":{"text":"Clickable element isn\u0027t keyboard-operable: The repo\u0027s own CSS styles .btn with \u0060cursor: pointer\u0060, so this \u003Cspan\u003E is a control \u2014 but it has no role, no tabindex=\u00220\u0022 and no key handler, so it can only be reached with a mouse. Use a \u003Cbutton\u003E, or add role \u002B tabindex=\u00220\u0022 \u002B a key handler."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":199}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c097d07855715830b8a1067ed8dd33853585d5778e19c4812de5b83ae250942"}},{"ruleId":"AC4","level":"error","message":{"text":"Clickable element isn\u0027t keyboard-operable: The repo\u0027s own CSS styles .btn with \u0060cursor: pointer\u0060, so this \u003Cspan\u003E is a control \u2014 but it has no role, no tabindex=\u00220\u0022 and no key handler, so it can only be reached with a mouse. Use a \u003Cbutton\u003E, or add role \u002B tabindex=\u00220\u0022 \u002B a key handler."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":200}}}],"partialFingerprints":{"codehealthFindingId/v1":"bfa5ad3d8243578d8f47ef39ac0bca368edaf4f1761c5eaef6abbf77293a9033"}},{"ruleId":"AC4","level":"error","message":{"text":"Clickable element isn\u0027t keyboard-operable: The repo\u0027s own CSS styles .btn with \u0060cursor: pointer\u0060, so this \u003Cspan\u003E is a control \u2014 but it has no role, no tabindex=\u00220\u0022 and no key handler, so it can only be reached with a mouse. Use a \u003Cbutton\u003E, or add role \u002B tabindex=\u00220\u0022 \u002B a key handler."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":204}}}],"partialFingerprints":{"codehealthFindingId/v1":"de285776893268e597f433cefceafbfcbb5960fde6b9fdc9211cf865b6024950"}},{"ruleId":"AC4","level":"warning","message":{"text":"Anchor without href: An \u003Ca\u003E with no href, role or tabindex isn\u0027t focusable or keyboard-activatable. Give it a real href, or use a \u003Cbutton\u003E for an action."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":1168}}}],"partialFingerprints":{"codehealthFindingId/v1":"446f0fc13454a078a1b04f4453a18a5c84490cb7bd2c9cc6303e6d1630ee6ffe"}},{"ruleId":"AC4","level":"warning","message":{"text":"Anchor without href: An \u003Ca\u003E with no href, role or tabindex isn\u0027t focusable or keyboard-activatable. Give it a real href, or use a \u003Cbutton\u003E for an action."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":94}}}],"partialFingerprints":{"codehealthFindingId/v1":"b8ca46daa02aafafe7a0e43bb5b9a861ec2a3a005b209c021d8d9cf4705d9f52"}},{"ruleId":"AC4","level":"error","message":{"text":"Click handler on a non-interactive \u003Cb\u003E: A click handler on a plain element isn\u0027t keyboard-operable. Use a \u003Cbutton\u003E, or add role \u002B tabindex=\u00220\u0022 \u002B a key handler."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/Interfaces.js"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"dbb7a430fdf67e374f960f10e672445f8c9f06e3e11a58e03dba831e47ca52c3"}},{"ruleId":"AC4","level":"warning","message":{"text":"Anchor without href: An \u003Ca\u003E with no href, role or tabindex isn\u0027t focusable or keyboard-activatable. Give it a real href, or use a \u003Cbutton\u003E for an action."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/SystemInformation.js"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"ab32e0c01decb80bac3d840ed2bade043a696ac0bd140d6865fa669e5f198b38"}},{"ruleId":"AC5","level":"error","message":{"text":"aria-hidden on a focusable element: aria-hidden=\u0022true\u0022 hides the element from assistive tech but leaves it keyboard-focusable \u2014 a confusing dead stop. Remove aria-hidden or make the element non-focusable."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1079}}}],"partialFingerprints":{"codehealthFindingId/v1":"2f500752700cee738a95c4a59f134c12ed8bff7d31dc0856d9c1c12bc5b0bc8c"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.bootstrap-select.disabled:focus\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/bootstrap-select.scss"},"region":{"startLine":197}}}],"partialFingerprints":{"codehealthFindingId/v1":"d7f8f3cfc16b7a71bdf75c29ecd03b73ec547073390274a496ed04f6aec07c77"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.bootstrap-select .dropdown-menu \u003E .inner:focus\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/bootstrap-select.scss"},"region":{"startLine":265}}}],"partialFingerprints":{"codehealthFindingId/v1":"5879a064bca0ac23dbdbc981935dabcb455c79aacef05e56dd73d1431dc6206d"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060button.toggle-sidebar\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/main.scss"},"region":{"startLine":428}}}],"partialFingerprints":{"codehealthFindingId/v1":"4836e370cc1589cead7d05f5bd7575bf813334c92003092aac4aa6c1c449ead2"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.btn-group \u003E .btn:focus\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/bootstrap/_button-groups.scss"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"faaa66aedbd71e3c7de3784b74013aafa4cbd1a33f3e6d4dccdf2b567a7dbc2b"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.btn-group.open .dropdown-toggle\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/bootstrap/_button-groups.scss"},"region":{"startLine":91}}}],"partialFingerprints":{"codehealthFindingId/v1":"94a9dedc961e601e8b681a45aeb255aea2b1db288b7f7eeb2d2f1ddbaa5c7312"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.btn.active\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/bootstrap/_buttons.scss"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"3498916109e7538453b7f122e4453c587c8ae5433d615d25285b848f55622a7e"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.carousel-control:focus\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/bootstrap/_carousel.scss"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"0c9d49ec3ebf3b99fc87aaef5f99d7584018ba9c393e107f778e17a0fbd1e273"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.dropdown-toggle:focus\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/bootstrap/_dropdowns.scss"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"4879030816a94ff80e8eb95809556faacf05e077e212eed1c9f43c56890573f0"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.dropdown-menu \u003E .active \u003E a\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/bootstrap/_dropdowns.scss"},"region":{"startLine":91}}}],"partialFingerprints":{"codehealthFindingId/v1":"d3f2c7c86311b657561e3b9f9831819f0c63e4ed42f4a8471f7cf690adbfffe3"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.open \u003E a\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/bootstrap/_dropdowns.scss"},"region":{"startLine":128}}}],"partialFingerprints":{"codehealthFindingId/v1":"92a332a02db925f02962793fa8ba5988df39e9c462d90af1f2046aaace8a73f4"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.modal\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/bootstrap/_modals.scss"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"509b89353608e53da83ef99d8659a80dfcc2b6300a2971eb1193f4f10c1517e6"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.modal-content\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/bootstrap/_modals.scss"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"ed7e9c42dc3d85cd7c1c9e5049995230acba6bd41b020954711efdd9dd1ed2cb"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.navbar-toggle:focus\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/bootstrap/_navbar.scss"},"region":{"startLine":203}}}],"partialFingerprints":{"codehealthFindingId/v1":"f8f5e716c31f0ba8b965bcefa2e0fbd3c09063a45be500297f0eaac499867aa1"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060button.toggle-sidebar\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/main.scss"},"region":{"startLine":429}}}],"partialFingerprints":{"codehealthFindingId/v1":"f07275832c9900fba9409ae4838d12c13b17b4e788756d9697884b673e7f0d41"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.bootstrap-select.btn-group.disabled:focus\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap-select/less/bootstrap-select.less"},"region":{"startLine":113}}}],"partialFingerprints":{"codehealthFindingId/v1":"71edd73a879ee6fac80811dd08dda0c608f9451aaeb85f9225163a14c38cd6ca"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.btn-group \u003E .btn:focus\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap/_button-groups.scss"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"f5e2929b83ff8253ba815e5f7dacebe723099ec19aae3d76b236c432549caf90"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.btn-group.open .dropdown-toggle\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap/_button-groups.scss"},"region":{"startLine":91}}}],"partialFingerprints":{"codehealthFindingId/v1":"bafad55ffd20e7731050bb2e84797af0d47943ad12da1d45e4fd7e4ac0313049"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.btn.active\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap/_buttons.scss"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"ca3f119a8a145ec4869959b4d8546b893bd8c0e20f4422562bcd323b4f1b5261"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.carousel-control:focus\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap/_carousel.scss"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"504179ec3b5df2dde181e1ce65944d592fb166fe6ef4711c4705836ea1cf9d5b"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.dropdown-toggle:focus\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap/_dropdowns.scss"},"region":{"startLine":25}}}],"partialFingerprints":{"codehealthFindingId/v1":"63956b374308b67b52a8cf34bf3f5522d1be923cb0b199ec4abe56b894139df3"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.dropdown-menu \u003E .active \u003E a\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap/_dropdowns.scss"},"region":{"startLine":91}}}],"partialFingerprints":{"codehealthFindingId/v1":"29d88489f51bd565f3ac511fab6d111a0a839b9092e4b23fa4169c14a04e814f"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.open \u003E a\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap/_dropdowns.scss"},"region":{"startLine":128}}}],"partialFingerprints":{"codehealthFindingId/v1":"20a9671857f3acac8ebce35e8e60a17524d47cd1e71731a126bd3339cfa2c958"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.modal\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap/_modals.scss"},"region":{"startLine":29}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d2c08ed2af50356541fdff50b8aa2693c7ef4a6ba3a2b69b3256e2ba52f79f4"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.modal-content\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap/_modals.scss"},"region":{"startLine":60}}}],"partialFingerprints":{"codehealthFindingId/v1":"25dbf4ef72951f5e95286d47987b944f029907910118736afc6b191ff4ec89bd"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.navbar-toggle:focus\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap/_navbar.scss"},"region":{"startLine":203}}}],"partialFingerprints":{"codehealthFindingId/v1":"e1bc64067cd04ba9fe66cdebd370e9580d6d2721ae12b00df290631835d66786"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.bootstrap-select.disabled:focus\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/css/bootstrap-select.css"},"region":{"startLine":201}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a92d0690c69a82b5de6b054aa6d2d7e930f593bf7031c968bb4fadbbfaf12d0"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.bootstrap-select .dropdown-menu \u003E .inner:focus\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/css/bootstrap-select.css"},"region":{"startLine":269}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ee57836221bc34e74721694b877a7f95c3fc463039b1d8e70622f4900bd0612"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.bootgrid-header a\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/css/jquery.bootgrid.css"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"19ed56a47d2f330e7ce0b4c63f287aedf5e0d174fafd30815043f7b0670f8860"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.bootgrid-table a\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/css/jquery.bootgrid.css"},"region":{"startLine":80}}}],"partialFingerprints":{"codehealthFindingId/v1":"384669f4c8d1de71c8c0d0a1bccbdbc9c7c888c01c6538650e47e9d9d782880f"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.bootgrid-table th.select-cell .select-box\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/css/jquery.bootgrid.css"},"region":{"startLine":149}}}],"partialFingerprints":{"codehealthFindingId/v1":"d6c6aebde45ca72559bfdb88438f3a9964d865881976de2942406561e12afdc4"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.tokenize.focus \u003E .tokens-container\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/css/tokenize2.css"},"region":{"startLine":19}}}],"partialFingerprints":{"codehealthFindingId/v1":"121f71f3f251df5ba440f1fdbb5f422165c428746443fd585b9fdfbb98415957"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060.tokenize \u003E .tokens-container \u003E .token-search \u003E input\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/css/tokenize2.css"},"region":{"startLine":88}}}],"partialFingerprints":{"codehealthFindingId/v1":"94143d9903103495d8b6da49891e410ac45f8537f3cadc508ab0a8a7acb44e53"}},{"ruleId":"AC6","level":"warning","message":{"text":"Focus outline removed in CSS without a :focus replacement: \u0060input[type=\u0022text\u0022]\u0060 sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/captiveportal/htdocs_default/css/signin.css"},"region":{"startLine":133}}}],"partialFingerprints":{"codehealthFindingId/v1":"873580ce684c3bff881fa871afff8a3dcba62dc0e2cd196d7fbedc183707706f"}},{"ruleId":"AC6","level":"warning","message":{"text":"Animation without a prefers-reduced-motion guard: \u0060.bootstrap-dialog .icon-spin\u0060 moves (\u0060animation: spin 2s infinite linear\u0060) and nothing reads prefers-reduced-motion for it \u2014 no @media (prefers-reduced-motion) rule for this element, no reset this project loads \u2014 so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/bootstrap-dialog.scss"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"7acd8379e3a2eb1055b8d8aa42b85654c961ef619ade2452ce6d2f4f2043debb"}},{"ruleId":"AC6","level":"warning","message":{"text":"Animation without a prefers-reduced-motion guard: \u0060#save-spinner\u0060 moves (\u0060transition: opacity 0.3s ease, transform 0.3s ease\u0060) and nothing reads prefers-reduced-motion for it \u2014 no @media (prefers-reduced-motion) rule for this element, no reset this project loads \u2014 so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/dashboard.scss"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"02e1ea481722ceed92f26221fd66cb564ba9f5a71cb71ec03a1edaa70ab80d1c"}},{"ruleId":"AC6","level":"warning","message":{"text":"Animation without a prefers-reduced-motion guard: \u0060.transition-spinner\u0060 moves (\u0060transition: opacity 0.3s ease, transform 0.3s ease\u0060) and nothing reads prefers-reduced-motion for it \u2014 no @media (prefers-reduced-motion) rule for this element, no reset this project loads \u2014 so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/dashboard.scss"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"9fc0459b47aaec998215416c0d9ea302ff0c9d5edefc1099d82f90dd31b8dfd0"}},{"ruleId":"AC6","level":"warning","message":{"text":"Animation without a prefers-reduced-motion guard: \u0060.list-group-item:before\u0060 moves (\u0060transition: width .2s\u0060) and nothing reads prefers-reduced-motion for it \u2014 no @media (prefers-reduced-motion) rule for this element, no reset this project loads \u2014 so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-dark/assets/stylesheets/main.scss"},"region":{"startLine":606}}}],"partialFingerprints":{"codehealthFindingId/v1":"4c9ecac2c81a0f42209dae67c24209c1aa04ba510bf03c801e802b30dbae3f93"}},{"ruleId":"AC6","level":"warning","message":{"text":"Animation without a prefers-reduced-motion guard: \u0060.bootstrap-dialog .icon-spin\u0060 moves (\u0060animation: spin 2s infinite linear\u0060) and nothing reads prefers-reduced-motion for it \u2014 no @media (prefers-reduced-motion) rule for this element, no reset this project loads \u2014 so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap-dialog.scss"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"e1369e35172b9917393391aeabba764738a003fb994b31c9b1cb64a52e0f7563"}},{"ruleId":"AC6","level":"warning","message":{"text":"Animation without a prefers-reduced-motion guard: \u0060#save-spinner\u0060 moves (\u0060transition: opacity 0.3s ease, transform 0.3s ease\u0060) and nothing reads prefers-reduced-motion for it \u2014 no @media (prefers-reduced-motion) rule for this element, no reset this project loads \u2014 so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/dashboard.scss"},"region":{"startLine":35}}}],"partialFingerprints":{"codehealthFindingId/v1":"2bb629e9890f16322964a0cf31314283553869320f41786864ac0f800967fac3"}},{"ruleId":"AC6","level":"warning","message":{"text":"Animation without a prefers-reduced-motion guard: \u0060.transition-spinner\u0060 moves (\u0060transition: opacity 0.3s ease, transform 0.3s ease\u0060) and nothing reads prefers-reduced-motion for it \u2014 no @media (prefers-reduced-motion) rule for this element, no reset this project loads \u2014 so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/dashboard.scss"},"region":{"startLine":39}}}],"partialFingerprints":{"codehealthFindingId/v1":"d46b08ef725301d8e0104767203c7a446e7a34f6349247bd2fcdc417c8fd4958"}},{"ruleId":"AC6","level":"warning","message":{"text":"Animation without a prefers-reduced-motion guard: \u0060.list-group-item:before\u0060 moves (\u0060transition: width .2s\u0060) and nothing reads prefers-reduced-motion for it \u2014 no @media (prefers-reduced-motion) rule for this element, no reset this project loads \u2014 so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense/assets/stylesheets/main.scss"},"region":{"startLine":611}}}],"partialFingerprints":{"codehealthFindingId/v1":"2fb3e121616bcd0cac71a0d4639b74ac3aab8113654fbabed4bdbb9ae1730d61"}},{"ruleId":"AC6","level":"warning","message":{"text":"Animation without a prefers-reduced-motion guard: \u0060#save-spinner\u0060 moves (\u0060transition: opacity 0.3s ease, transform 0.3s ease\u0060) and nothing reads prefers-reduced-motion for it \u2014 no @media (prefers-reduced-motion) rule for this element, no reset this project loads \u2014 so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/css/dashboard.css"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"02b0c3e7b10c7c8bb711e6941e8fc7da5ee844c0dadd2d4ab2305e533a50aaec"}},{"ruleId":"AC6","level":"warning","message":{"text":"Animation without a prefers-reduced-motion guard: \u0060.transition-spinner\u0060 moves (\u0060transition: opacity 0.3s ease, transform 0.3s ease\u0060) and nothing reads prefers-reduced-motion for it \u2014 no @media (prefers-reduced-motion) rule for this element, no reset this project loads \u2014 so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/css/dashboard.css"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"47218c6418dcea77bdce38de5192024bf120bb68972a95856565668e2892a1e1"}},{"ruleId":"AC6","level":"warning","message":{"text":"Animation without a prefers-reduced-motion guard: \u0060container.animate()\u0060 moves (\u0060Web Animations API keyframes\u0060) and nothing reads prefers-reduced-motion for it \u2014 no @media (prefers-reduced-motion) rule for this element, no reset this project loads \u2014 so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/javascript/opnsense_legacy.js"},"region":{"startLine":170}}}],"partialFingerprints":{"codehealthFindingId/v1":"5321b252632f4caf2554dd3dabe93d965073e7fe74ac305af60f2962e38ba693"}},{"ruleId":"AC7","level":"warning","message":{"text":"Accessibility enforcement below the top rung: No accessibility enforcement found \u2014 no automated accessibility check runs over your pages. Add an accessibility checker (axe-core, pa11y or Lighthouse) over your HTML in CI and fail the build on new violations. What was searched, so you can tell an absence from a miss: the 12 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository\u0027s test and CI files \u2014 matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"d46019b86eff5ddad9db289e6802ac158899e980df54c34f67722442787ead62"}},{"ruleId":"M1","level":"warning","message":{"text":"README may be stale: 369 code files changed in the last 6 months but the README was not touched \u2014 it may no longer reflect the system."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"e973e7a8d5d866995cbf78b120250fe7f132bf928812d48ca62e69aba11b9910"}},{"ruleId":"M2","level":"note","message":{"text":"No ADRs: No Architecture Decision Records found \u2014 no conventional ADR directory, no numbered \u0060NNNN-title\u0060 documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"670b3d6e36a756d63097d0dfbf90afd5fc761308800b9354894a07c3f4e4aa14"}},{"ruleId":"P1","level":"warning","message":{"text":"No CI pipeline: No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, \u2026) \u2014 changes aren\u0027t gated by an automated build/test."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"44f01af96e50474fba2df84d95ddf4f7e1d34c29c307830b9efc9057daa6b670"}},{"ruleId":"P3","level":"note","message":{"text":"No SAST: No static application security testing detected. For this repository\u0027s stack, add phpstan or psalm (or \u0060semgrep --config=auto\u0060, which runs on any language) \u2014 this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge\u0027s web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen \u2014 if that is your case the row is wrong, and saying so is more useful than adding a second scanner."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"6e54424179c892f03ef2fd003130ac4bd43f39bbf3b1ca0a0143e25acb80ec87"}},{"ruleId":"P7","level":"warning","message":{"text":"Outbound HTTP without resilience: \u0060curl_exec(\u0060 makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service\u0027s request, thread or connection until the call gives up on its own \u2014 or never, for a client with no default timeout."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/etc/inc/plugins.inc.d/opendns.inc"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"daa4cddcd7c4ada8fe61c02c144ef319430d911cc67d7dbe6e8735e0b5238d96"}},{"ruleId":"P7","level":"warning","message":{"text":"Outbound HTTP without resilience: \u0060curl_exec(\u0060 makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service\u0027s request, thread or connection until the call gives up on its own \u2014 or never, for a client with no default timeout."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/controllers/OPNsense/Core/Api/DashboardController.php"},"region":{"startLine":235}}}],"partialFingerprints":{"codehealthFindingId/v1":"114538e5e97657d330800fbcb37ddb2b7f6de95f0ec52305f457c0d02af9e510"}},{"ruleId":"P7","level":"warning","message":{"text":"Outbound HTTP without resilience: \u0060requests.get(\u0060 makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service\u0027s request, thread or connection until the call gives up on its own \u2014 or never, for a client with no default timeout."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/geoip.py"},"region":{"startLine":165}}}],"partialFingerprints":{"codehealthFindingId/v1":"7bc94e56000d080ad9d064b7309e141198a912b60c61ea26d0acfdf989667738"}},{"ruleId":"P7","level":"warning","message":{"text":"Outbound HTTP without resilience: \u0060curl_exec(\u0060 makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service\u0027s request, thread or connection until the call gives up on its own \u2014 or never, for a client with no default timeout."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/monit/status.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"2d177f701ffb4551ea72cf88afbe93973a1a5da99194c6dbc022329935312be7"}},{"ruleId":"P7","level":"warning","message":{"text":"Outbound HTTP without resilience: \u0060requests.get(\u0060 makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service\u0027s request, thread or connection until the call gives up on its own \u2014 or never, for a client with no default timeout."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/suricata/lib/downloader.py"},"region":{"startLine":112}}}],"partialFingerprints":{"codehealthFindingId/v1":"9bdbc118f68718188f24a2e8188f1237aa86d1287620e6f089d521f67d0c1e6f"}},{"ruleId":"P7","level":"warning","message":{"text":"Outbound HTTP without resilience: \u0060requests.get(\u0060 makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service\u0027s request, thread or connection until the call gives up on its own \u2014 or never, for a client with no default timeout."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/system/crl_fetch.py"},"region":{"startLine":62}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9158bd2c4fb3e55cf654d75f4ccf1646902282ed17a07f0da2d2f3f7e6c2ef6"}},{"ruleId":"P7","level":"warning","message":{"text":"Outbound HTTP without resilience: \u0060requests.get(\u0060 makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service\u0027s request, thread or connection until the call gives up on its own \u2014 or never, for a client with no default timeout."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/blocklists/__init__.py"},"region":{"startLine":109}}}],"partialFingerprints":{"codehealthFindingId/v1":"84359378f4a78ac1e24d494ea054bba8b84304a514a140cde3c5dcaf554cb070"}},{"ruleId":"P7","level":"warning","message":{"text":"Outbound HTTP without resilience: \u0060requests.Session(\u0060 makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service\u0027s request, thread or connection until the call gives up on its own \u2014 or never, for a client with no default timeout."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/site-python/tls_helper.py"},"region":{"startLine":104}}}],"partialFingerprints":{"codehealthFindingId/v1":"01120f096fc0b55cc758dfd946aadd46223c75b7b285db3292df5be12da33968"}},{"ruleId":"P7","level":"warning","message":{"text":"Outbound HTTP without resilience: \u0060requests.Session(\u0060 makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service\u0027s request, thread or connection until the call gives up on its own \u2014 or never, for a client with no default timeout."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/site-python/tls_helper.py"},"region":{"startLine":109}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd8f727b4118bb354ae762f16cd5511df118f720590f152d3b7e03b5305ad95f"}},{"ruleId":"P7","level":"warning","message":{"text":"Outbound HTTP without resilience: \u0060curl_exec(\u0060 makes an outbound HTTP call, and nothing bounds it: no timeout, deadline, retry or circuit breaker is set for it here, and the client has no process-wide default. A slow or failing dependency will hold this service\u0027s request, thread or connection until the call gives up on its own \u2014 or never, for a client with no default timeout."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/crash_reporter.php"},"region":{"startLine":79}}}],"partialFingerprints":{"codehealthFindingId/v1":"9556f0b6e1e0861f00c22203301ed2c39811b69d95e63ddadf281e96219a9c5c"}},{"ruleId":"R1","level":"warning","message":{"text":"Type Safety: 0 typed \u00B7 53 plain JS \u2014 the untyped files are src/opnsense/www/js/bootstrap-dialog.js, src/opnsense/www/js/bootstrap-select.js, src/opnsense/www/js/chartjs-plugin-streaming.js, src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/opnsense-treeview.js, src/opnsense/www/js/opnsense.js (\u002B47 more)."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"d00ee7953f55325a823d27e5db9657c80ca9b9861c0c0abf8fe487cd3fa586d3"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (527 lines \u00D7 2 locations): src/opnsense/www/js/jquery-sortable.js:31 \u00B7 src/opnsense/www/js/tokenize2.js:2005 \u2014 the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"5d3e961544aa3216d907dad129cea1a1f1cdef2a527fb60fca9e0c6465b5f432"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block with local edits (49 matched lines \u00D7 2 locations): src/opnsense/www/js/widgets/DnsmasqLeases.js:72 \u00B7 src/opnsense/www/js/widgets/KeaLeases.js:92 \u2014 the two spans are one implementation copied and then locally edited \u2014 253 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row\u0027s finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters \u2014 or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/DnsmasqLeases.js"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"59952290ef83e201283ee8bd5c4a8dd59e4f103c7e1c96c4fb1b1e0b40c6d102"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (21 lines \u00D7 2 locations): src/opnsense/www/js/opnsense_bootgrid.js:2215 \u00B7 src/opnsense/www/js/opnsense_bootgrid.js:2362 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":2215}}}],"partialFingerprints":{"codehealthFindingId/v1":"e232d643ba42082920e19140eb6215c25f18b1020589f22b4650a340d81942e6"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2 locations): src/opnsense/www/js/bootstrap-dialog.js:1192 \u00B7 src/opnsense/www/js/bootstrap-dialog.js:1241 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-dialog.js"},"region":{"startLine":1192}}}],"partialFingerprints":{"codehealthFindingId/v1":"cb89802760d2ea6150c44be5115801be61b351e64bb6f92909b59ca2ee9eb49c"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (17 lines \u00D7 2 locations): src/opnsense/www/js/opnsense_bootgrid.js:2486 \u00B7 src/opnsense/www/js/opnsense_bootgrid.js:2504 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":2486}}}],"partialFingerprints":{"codehealthFindingId/v1":"87755413cf87b4148828e038268dc68f7179888c01f2ca424a5dfb0d5a40de50"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block with local edits (16 matched lines \u00D7 2 locations): src/opnsense/www/js/opnsense_theme.js:185 \u00B7 src/opnsense/www/js/opnsense_theme.js:207 \u2014 the two spans are one implementation copied and then locally edited \u2014 73 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row\u0027s finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters \u2014 or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_theme.js"},"region":{"startLine":185}}}],"partialFingerprints":{"codehealthFindingId/v1":"d56536c9753848ec0d35f3ecddede4b7ddbe00bad0ad7a84adf1e692f1bb2ae3"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 3 locations): src/opnsense/www/js/widgets/FirewallStates.js:27 \u00B7 src/opnsense/www/js/widgets/Mbuf.js:27 \u00B7 src/opnsense/www/js/widgets/Swap.js:27 \u2014 the 3 copies are spread across 3 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/FirewallStates.js"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"de42f4b8e6f8a59e11d6bb012df0a2b2ed24de5ffd58d2747aecd76d1b657395"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (16 lines \u00D7 2 locations): src/opnsense/www/js/widgets/IpsecLeases.js:50 \u00B7 src/opnsense/www/js/widgets/IpsecTunnels.js:51 \u2014 the 2 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/IpsecLeases.js"},"region":{"startLine":50}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae79f34cdee85679b601052d32e021663df68220fbaa8f9fb93396424fc03488"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block with local edits (15 matched lines \u00D7 2 locations): src/opnsense/www/js/widgets/Certificates.js:27 \u00B7 src/opnsense/www/js/widgets/LiveLog.js:27 \u2014 the two spans are one implementation copied and then locally edited \u2014 51 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row\u0027s finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters \u2014 or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/Certificates.js"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"4dcdda692572f45b00b6ad3cbf2535c28b0cdd5e7b2287310f4c663b90fb83d3"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (15 lines \u00D7 2 locations): src/opnsense/www/js/widgets/OpenVPNServers.js:27 \u00B7 src/opnsense/www/js/widgets/Wireguard.js:28 \u2014 the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/OpenVPNServers.js"},"region":{"startLine":27}}}],"partialFingerprints":{"codehealthFindingId/v1":"55f2d942c11ef89da0006a669933b32d5bc6265c5e37edc217a6dcd2348cbdc5"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (14 lines \u00D7 2 locations): src/opnsense/www/js/opnsense_ui.js:722 \u00B7 src/opnsense/www/js/opnsense_ui.js:757 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":722}}}],"partialFingerprints":{"codehealthFindingId/v1":"d933b44cf2942e66ef358139e29d7111a34f5c002e43f6528dbb0b9d599264e9"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (12 lines \u00D7 2 locations): src/opnsense/www/js/opnsense_bootgrid.js:1873 \u00B7 src/opnsense/www/js/opnsense_bootgrid.js:1885 \u2014 all 2 copies are in the same file, and the SHAPE of this repetition could not be determined. It is not a run of declarations, a listing, a declaration header, a type body or a slice through a construct \u2014 and it was not measured as a run of executable statements either, so this row cannot tell you whether a function can stand where these lines are. Read the two spans before acting, because the move is opposite in the two cases. Where they are statements, the ordinary answer holds: give the shared part one home and call it from each site. Where they turn out to be declarations, a literal\u0027s entries, or the cases of an enumeration, there is no call site to call anything from, and collapsing them would delete what each copy pins \u2014 a shared base type, a generated set, or one exported constant each site refers to is the move instead, and sometimes the honest answer is that there is nothing to extract at all. Reported because the copies drift apart the first time only one of them is edited, which is true whichever of those they are."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1873}}}],"partialFingerprints":{"codehealthFindingId/v1":"b7c4c41229898b4f04aabd00af451a537da6b8173b03d04928f43b1ada8ec5fb"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2 locations): src/opnsense/www/js/opnsense.js:328 \u00B7 src/opnsense/www/js/opnsense.js:354 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense.js"},"region":{"startLine":328}}}],"partialFingerprints":{"codehealthFindingId/v1":"01ee12cca5e18fbb4aa175717d6d7cd36a472331b241e24f26d51c27e42fb850"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2 locations): src/opnsense/www/js/opnsense_bootgrid.js:2289 \u00B7 src/opnsense/www/js/opnsense_bootgrid.js:2379 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":2289}}}],"partialFingerprints":{"codehealthFindingId/v1":"601c86ceba18099e5783bf20e7ed658fdff8711946d95a49ec1ee79f5260470d"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2 locations): src/opnsense/www/js/bootstrap-dialog.js:764 \u00B7 src/opnsense/www/js/bootstrap-dialog.js:790 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-dialog.js"},"region":{"startLine":764}}}],"partialFingerprints":{"codehealthFindingId/v1":"e5627faea4da939f39048535d31387ff4723e662ccddf78418c0df6a092dac10"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 2 locations): src/opnsense/www/js/bootstrap-select.js:756 \u00B7 src/opnsense/www/js/bootstrap-select.js:791 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":756}}}],"partialFingerprints":{"codehealthFindingId/v1":"d8798651f577d81522cf30e4efbcf8556b237a9c784aedf5b3eec744cef198b5"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3 locations): src/opnsense/www/js/widgets/Announcements.js:38 \u00B7 src/opnsense/www/js/widgets/Carp.js:37 \u00B7 src/opnsense/www/js/widgets/Gateways.js:40 \u2014 the 3 copies are spread across 3 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/Announcements.js"},"region":{"startLine":38}}}],"partialFingerprints":{"codehealthFindingId/v1":"5b491870a8ad477f946487a76c192b3d8ffdb7ae6ca46081e4b258034955a4ce"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (10 lines \u00D7 3 locations): src/opnsense/www/js/widgets/Interfaces.js:40 \u00B7 src/opnsense/www/js/widgets/IpsecLeases.js:41 \u00B7 src/opnsense/www/js/widgets/Wireguard.js:41 \u2014 the 3 copies sit in sibling files in one directory, so check first whether one of them (or an existing module there) already owns this behaviour and the others should call it; otherwise extract it into one module in that directory and have each site call it. There is one copy in each of 3 separate files rather than several in one place, so check first whether these are sibling modules that each declare their own version of one shape \u2014 one per entity, per provider, per language. Where they are, no single extracted module collapses them: each module still has to be written, and what recurs is the TEMPLATE. The moves that do collapse a template are to generate these modules from the set they enumerate, or to replace the repeated construction with one factory each site calls with its own values \u2014 and where the set is the point, each module pinning one distinct thing, the repetition IS the enumeration and there is nothing to delete."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/Interfaces.js"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"13185ef16d1aa553e29bff35478e5c3d301e1ab2a08f82d8a2f1b230b2a7cb15"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2 locations): src/opnsense/www/js/qrcode.js:1071 \u00B7 src/opnsense/www/js/qrcode.js:1087 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":1071}}}],"partialFingerprints":{"codehealthFindingId/v1":"e854759ca1a43275d7737e4b41c001b7307a5bcaa4d768ac6e15f1e4e90a7bbc"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2 locations): src/opnsense/www/js/widgets/Firewall.js:287 \u00B7 src/opnsense/www/js/widgets/InterfaceStatistics.js:171 \u2014 the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/Firewall.js"},"region":{"startLine":287}}}],"partialFingerprints":{"codehealthFindingId/v1":"036aaba4e8184c1934eb29799607f5991fec3130f9f466631ea572f1e7aae523"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2 locations): src/opnsense/www/js/widgets/Gateways.js:56 \u00B7 src/opnsense/www/js/widgets/ThermalSensors.js:188 \u2014 the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/Gateways.js"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"dfab3d0c6bf0a4284674077eaefceded299f85a7afcc194b031cfef18a481922"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2 locations): src/opnsense/www/js/bootstrap-dialog.js:1030 \u00B7 src/opnsense/www/js/bootstrap-dialog.js:1046 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-dialog.js"},"region":{"startLine":1030}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7032ade1c7202ef8987c658089f181a6ba0eeabd63e0365d70813abd14d5d33"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2 locations): src/opnsense/www/js/opnsense_ui.js:377 \u00B7 src/opnsense/www/js/opnsense_ui.js:405 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":377}}}],"partialFingerprints":{"codehealthFindingId/v1":"a66b4cb505088785a0be1cb2bc585abb153b5d58b66c08fb600ca7cd9b1e3fce"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2 locations): src/opnsense/www/js/opnsense_ui.js:464 \u00B7 src/opnsense/www/js/opnsense_ui.js:1077 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":464}}}],"partialFingerprints":{"codehealthFindingId/v1":"d4c9ddfe08140d62a8d222a4cae90b10e38e4f1b4d43afceb6733bfde11faf53"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2 locations): src/opnsense/www/js/qrcode.js:311 \u00B7 src/opnsense/www/js/qrcode.js:320 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":311}}}],"partialFingerprints":{"codehealthFindingId/v1":"f7db692b6216caec7e99f1056cbe0a918190642bbd85468e5e35ad93cf12669e"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2 locations): src/opnsense/www/js/qrcode.js:338 \u00B7 src/opnsense/www/js/qrcode.js:432 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":338}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd0be2b9cf4b0b64eea0da6dbbf17ee5c03037ebcd2446a8de2b39b283f1fdf9"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2 locations): src/opnsense/www/js/widgets/IpsecTunnels.js:180 \u00B7 src/opnsense/www/js/widgets/IpsecTunnels.js:192 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/IpsecTunnels.js"},"region":{"startLine":180}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2ee3c9f7cc384ba18847c38aecfbdab0280b86189042c184758ffb3f69c8f1d"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2 locations): src/opnsense/www/js/opnsense.js:69 \u00B7 src/opnsense/www/js/opnsense.js:147 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense.js"},"region":{"startLine":69}}}],"partialFingerprints":{"codehealthFindingId/v1":"60f72088ff62b9426ce24346b88b239f8ff739f0a96a02dafbd5577377f4d023"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2 locations): src/opnsense/www/js/qrcode.js:917 \u00B7 src/opnsense/www/js/qrcode.js:925 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":917}}}],"partialFingerprints":{"codehealthFindingId/v1":"1ff10801f75acff56c52b40e9234b4b49f4e231b775f160034e1ae3200836f47"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2 locations): src/opnsense/www/js/smoothie.js:525 \u00B7 src/opnsense/www/js/smoothie.js:545 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/smoothie.js"},"region":{"startLine":525}}}],"partialFingerprints":{"codehealthFindingId/v1":"40c3b61790f0a976031fb3fd926549ca70dc6210296fc3b431b59edebb35b1ee"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (7 lines \u00D7 2 locations): src/opnsense/www/js/widgets/BaseWidget.js:256 \u00B7 src/opnsense/www/js/widgets/Traffic.js:38 \u2014 the 2 copies are spread across 2 files, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/BaseWidget.js"},"region":{"startLine":256}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff30d6591192444c1250b90e77c24cbc1a9a4c0b0ae6f3c8ec3817090f5a0d20"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block with local edits (7 matched lines \u00D7 2 locations): src/opnsense/www/js/widgets/InterfaceStatistics.js:93 \u00B7 src/opnsense/www/js/widgets/InterfaceStatistics.js:194 \u2014 the two spans are one implementation copied and then locally edited \u2014 73 tokens are still identical, in the same order in both spans, with only local edits between them. The copies have already begun to drift, which is this row\u0027s finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters \u2014 or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/InterfaceStatistics.js"},"region":{"startLine":93}}}],"partialFingerprints":{"codehealthFindingId/v1":"bc794f7d02e82e24b48dc12a251dd17f9b4e5b2169577b7a0167ed0cf3e36677"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2 locations): src/opnsense/www/js/opnsense_bootgrid.js:390 \u00B7 src/opnsense/www/js/opnsense_bootgrid.js:413 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":390}}}],"partialFingerprints":{"codehealthFindingId/v1":"a11e798b3660aef0b8e4dbf6b401458d53c602c5d82b07bcb46575807eec9078"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 3 locations): src/opnsense/www/js/opnsense_ui.js:364 \u00B7 src/opnsense/www/js/opnsense_ui.js:379 \u00B7 src/opnsense/www/js/opnsense_ui.js:407 \u2014 all 3 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":364}}}],"partialFingerprints":{"codehealthFindingId/v1":"9e9b282d531c663a780ee2652ea9c03a9381110fe6227522f8b31447328c7d18"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2 locations): src/opnsense/www/js/qrcode.js:621 \u00B7 src/opnsense/www/js/qrcode.js:683 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":621}}}],"partialFingerprints":{"codehealthFindingId/v1":"3161b39ca3c04179b0bdf3153ff3809de48e55c591e30232d9c679dd2984bccf"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2 locations): src/opnsense/www/js/smoothie.js:709 \u00B7 src/opnsense/www/js/smoothie.js:716 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/smoothie.js"},"region":{"startLine":709}}}],"partialFingerprints":{"codehealthFindingId/v1":"84408f72f3655601ca81674e324fef6845163e4c3117ee3ce3614bd10c09bbff"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2 locations): src/opnsense/www/js/widgets/BaseGaugeWidget.js:115 \u00B7 src/opnsense/www/js/widgets/BaseGaugeWidget.js:126 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/BaseGaugeWidget.js"},"region":{"startLine":115}}}],"partialFingerprints":{"codehealthFindingId/v1":"d30cd83460e11d646c4e4aa1bca96dee7b152f883ed64aad1b4dea1446842b78"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (6 lines \u00D7 2 locations): src/opnsense/www/themes/opnsense-auto/build/js/theme.js:9 \u00B7 src/opnsense/www/themes/opnsense-auto/build/js/theme.js:18 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/themes/opnsense-auto/build/js/theme.js"},"region":{"startLine":9}}}],"partialFingerprints":{"codehealthFindingId/v1":"60ed68bb5a12b1d276bba2c68e649d59272f5efc84f983ae4bc73fa2170c5c49"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2 locations): src/opnsense/www/js/qrcode.js:648 \u00B7 src/opnsense/www/js/qrcode.js:700 \u2014 all 2 copies are in the same file, and the CITED SPAN is not a self-contained block \u2014 it runs from inside one construct into the next (the tail of a branch plus the head of the following one, a run of switch arms, the end of a declaration plus the list that follows it) rather than covering a whole unit. So do not lift these lines literally: no call can be substituted for a half-open construct. Extract the enclosing repeated UNIT instead \u2014 the whole function, component or branch these lines sit in \u2014 and where the repetition IS the construct (a run of switch arms, a stack of near-identical declarations) replace it with one table or registry looked up by key rather than a helper each arm calls. The copies still drift apart the first time only one of them is edited, which is why this is reported."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":648}}}],"partialFingerprints":{"codehealthFindingId/v1":"5faa0d78712d056d6f7298d873f2b182cb795f1229c12f9bb6e9066485f9a980"}},{"ruleId":"R10","level":"warning","message":{"text":"Duplicated block (5 lines \u00D7 2 locations): src/opnsense/www/js/smoothie.js:688 \u00B7 src/opnsense/www/js/smoothie.js:693 \u2014 both copies are in the same file, so extract the block into one function there and call it from each site \u2014 the copies drift apart the first time only one of them is edited."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/smoothie.js"},"region":{"startLine":688}}}],"partialFingerprints":{"codehealthFindingId/v1":"03a0d701e9cbb64ce65263f941c1acba74ebac54c03a7deb49c4db8df784768a"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function translateCompatOptions (cyclomatic 68, cognitive 78): translateCompatOptions has cyclomatic complexity 68 and cognitive complexity 78; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":244}}}],"partialFingerprints":{"codehealthFindingId/v1":"d39a3a8c57871619884faceea7bafa5fda17bbf038fdeaa1efe8109c90edfa26"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function keydown (cyclomatic 66, cognitive 113): keydown has cyclomatic complexity 66 and cognitive complexity 113; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":2827}}}],"partialFingerprints":{"codehealthFindingId/v1":"f1eab482a08e099af8f32022d49c82ff33376dd8a91986bb2ef583a750e4d316"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function render (cyclomatic 61, cognitive 93): render has cyclomatic complexity 61 and cognitive complexity 93; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/smoothie.js"},"region":{"startLine":839}}}],"partialFingerprints":{"codehealthFindingId/v1":"accaef23efa848375dca5876f7fb3b7b8c0565b0f861f57c72e6005c2d245dae"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function scroll (cyclomatic 55, cognitive 99): scroll has cyclomatic complexity 55 and cognitive complexity 99; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1227}}}],"partialFingerprints":{"codehealthFindingId/v1":"27db21813d3e4068d8c80f3f5ad12de96bead0e79aec7afd8c35544c35a2b1f1"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function liHeight (cyclomatic 43, cognitive 46): liHeight has cyclomatic complexity 43 and cognitive complexity 46; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1878}}}],"partialFingerprints":{"codehealthFindingId/v1":"4d393b7a6a2c64321e613871f3b7b48cf15c07a968ee49460fac82dff9a44dec"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function getLostPoint (cyclomatic 42, cognitive 84): getLostPoint has cyclomatic complexity 42 and cognitive complexity 84; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":1020}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ef61e84ef81b1bf66c297659f6509e489ae06bfc1edd1c4e5f4125824f44dc6"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function (anonymous) (cyclomatic 38, cognitive 99): (anonymous) has cyclomatic complexity 38 and cognitive complexity 99; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":2454}}}],"partialFingerprints":{"codehealthFindingId/v1":"4555ae1b7ce0518704149b1024e5750aa856b5beb854239ae3945a5d6044011a"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function render (cyclomatic 37, cognitive 90): render has cyclomatic complexity 37 and cognitive complexity 90; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1714}}}],"partialFingerprints":{"codehealthFindingId/v1":"9e6d525296ff01e8e6a666a3e9c080729e887a053a3890cb391f5c84a3bd1937"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function (anonymous) (cyclomatic 29, cognitive 82): (anonymous) has cyclomatic complexity 29 and cognitive complexity 82; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense.js"},"region":{"startLine":155}}}],"partialFingerprints":{"codehealthFindingId/v1":"067de7369f05125c1ca6b38042cd39a4ba57115c2e52095c8faab211a142e1da"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _parseGridView (cyclomatic 22, cognitive 33): _parseGridView has cyclomatic complexity 22 and cognitive complexity 33; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":476}}}],"partialFingerprints":{"codehealthFindingId/v1":"7c4c7902c1f22d354b8f957113a1eead6fca4156cd3c7d45b6256d953b700af7"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function createSvgTag (cyclomatic 22, cognitive 24): createSvgTag has cyclomatic complexity 22 and cognitive complexity 24; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":495}}}],"partialFingerprints":{"codehealthFindingId/v1":"b9bd44543552458930632bdaffe20f2277fbeff9a9dbddd395d2fb6e30a8e042"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function setupPositionProbePattern (cyclomatic 19, cognitive 19): setupPositionProbePattern has cyclomatic complexity 19 and cognitive complexity 19; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":75}}}],"partialFingerprints":{"codehealthFindingId/v1":"87501c1b06b7f8f4c078cebb9a254f341e4edee11b0fe838a2c9776f8f609fe7"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _parseColumns (cyclomatic 18, cognitive 31): _parseColumns has cyclomatic complexity 18 and cognitive complexity 31; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":536}}}],"partialFingerprints":{"codehealthFindingId/v1":"120de71718485baf2368b6ad287cad8ad269499a8b18c461200d955a76919a2b"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function (anonymous) (cyclomatic 18, cognitive 28): (anonymous) has cyclomatic complexity 18 and cognitive complexity 28; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":2672}}}],"partialFingerprints":{"codehealthFindingId/v1":"438addad6070d98fefe89a72843085da470606681f9e9573eba1d52abb03ca57"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function setMenuSize (cyclomatic 18, cognitive 23): setMenuSize has cyclomatic complexity 18 and cognitive complexity 23; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":2030}}}],"partialFingerprints":{"codehealthFindingId/v1":"eee1a742d2518f6fce772ef69cd0b380724d1b43b5f35c4efd119f466ae4db90"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function _createHalfASCII (cyclomatic 18, cognitive 19): _createHalfASCII has cyclomatic complexity 18 and cognitive complexity 19; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":620}}}],"partialFingerprints":{"codehealthFindingId/v1":"5b19040bf310a03975f7a1ad580546d620359a7e0bdb25f34c2ff1fd1d810598"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function createDropdown (cyclomatic 18, cognitive 18): createDropdown has cyclomatic complexity 18 and cognitive complexity 18; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1057}}}],"partialFingerprints":{"codehealthFindingId/v1":"d41212a2995c4bc37547055bbae6e4c0c8624ad755b3e3a6ca2497aa832061ad"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function (anonymous) (cyclomatic 18, cognitive 15): (anonymous) has cyclomatic complexity 18 and cognitive complexity 15; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth \u2014 arms side by side rather than stacked \u2014 and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":694}}}],"partialFingerprints":{"codehealthFindingId/v1":"b4e0c0ae4491c73f938d71a0fae13b0716e2306cd6374598ba321af04b381373"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function getLengthInBits (cyclomatic 17, cognitive 11): getLengthInBits has cyclomatic complexity 17 and cognitive complexity 11; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth \u2014 arms side by side rather than stacked \u2014 and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":974}}}],"partialFingerprints":{"codehealthFindingId/v1":"17a847d064cc2bf40c1c46d159d749a7f8089beae75567115a97fcffc7f54cf1"}},{"ruleId":"R2","level":"warning","message":{"text":"Complex function setStyle (cyclomatic 16, cognitive 21): setStyle has cyclomatic complexity 16 and cognitive complexity 21; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side \u2014 extracting each decision into its own named function is the change that pays. Measured by this repository\u0027s own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1841}}}],"partialFingerprints":{"codehealthFindingId/v1":"17aedc1b09ac2223304a02888ad274e53d8f28f6f787ff3e83eb79c7f94146f7"}},{"ruleId":"R3","level":"warning","message":{"text":"src/opnsense/www/js/bootstrap-select.js: 2685 lines of code: src/opnsense/www/js/bootstrap-select.js has 2685 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"fffcd5ca0d1a5a7c814dd8a390ea2d78d308583d037994a672bc71ce914a8934"}},{"ruleId":"R3","level":"warning","message":{"text":"src/opnsense/www/js/tokenize2.js: 2412 lines of code: src/opnsense/www/js/tokenize2.js has 2412 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/tokenize2.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"b10d3cc4d82eed9a31ebd120f394ed75c6f431b364d561e0a7ac90ff55556347"}},{"ruleId":"R3","level":"warning","message":{"text":"src/opnsense/www/js/opnsense_bootgrid.js: 2218 lines of code: src/opnsense/www/js/opnsense_bootgrid.js has 2218 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_bootgrid.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"c0ba26a0bacf1359cbb49887ad839b1dc293b60e7246307f38d0e3f18cbaf6f6"}},{"ruleId":"R3","level":"warning","message":{"text":"src/opnsense/www/js/qrcode.js: 1798 lines of code: src/opnsense/www/js/qrcode.js has 1798 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/qrcode.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"2f4c337c721aaf8110ca14a7c9c6c9cbf15e02a3fa3d157378f826ab4f39f323"}},{"ruleId":"R3","level":"warning","message":{"text":"src/opnsense/www/js/bootstrap-dialog.js: 1204 lines of code: src/opnsense/www/js/bootstrap-dialog.js has 1204 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-dialog.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"798ad2adca9ae78ea812fc0c0d5f942d5e59074e5d7da61eecc52ed022f5c9ab"}},{"ruleId":"R3","level":"warning","message":{"text":"src/opnsense/www/js/opnsense_ui.js: 1199 lines of code: src/opnsense/www/js/opnsense_ui.js has 1199 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_ui.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"fb0a2e0787d864a690b8a1e8fc22cbf46ff0fdd20e66b813707b3204b841f7f5"}},{"ruleId":"R3","level":"warning","message":{"text":"src/opnsense/www/js/opnsense_widgets.js: 1138 lines of code: src/opnsense/www/js/opnsense_widgets.js has 1138 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"a0d3d5ddf7eeead583ec65b3493b3d275be290ba43f8c00271169ecd75f21160"}},{"ruleId":"R3","level":"warning","message":{"text":"src/opnsense/www/js/smoothie.js: 1075 lines of code: src/opnsense/www/js/smoothie.js has 1075 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/smoothie.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"610380073f56f5bda195ed3552f8ee6a42358c5d5a0636f3a2dfec358235784f"}},{"ruleId":"R3","level":"warning","message":{"text":"src/opnsense/www/js/chartjs-plugin-streaming.js: 939 lines of code: src/opnsense/www/js/chartjs-plugin-streaming.js has 939 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/chartjs-plugin-streaming.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"0b0d7c9966d86e041b511399673dc7053465d2525fb38ca5d032e98f65fc7373"}},{"ruleId":"R3","level":"warning","message":{"text":"src/opnsense/www/js/jquery-sortable.js: 631 lines of code: src/opnsense/www/js/jquery-sortable.js has 631 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"422537e13d9a94241993afcff6611bcac9dc4561f6d549efc523b15e24f54ee2"}},{"ruleId":"R3","level":"warning","message":{"text":"src/opnsense/www/js/opnsense.js: 411 lines of code: src/opnsense/www/js/opnsense.js has 411 significant lines (blank lines excluded), over the 400-line bar, and contains logic \u2014 a file this long is usually several responsibilities in one module."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense.js"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"311e1a12405f2c7405ca6bb7d1bdcd31ab0fb5c45bc5442c7a8bac95b1410e56"}},{"ruleId":"R4","level":"warning","message":{"text":"Test Coverage: 0% of 53 production file(s) reachable from 0 test file(s) via the import graph \u2014 \u0027production\u0027 here is the RESIDUE: every source file left once tests, tooling, generated output, config, declarations and declaration-only modules, fixture corpora, type fixtures, behaviour-free data modules, re-export barrels, registration/constant data modules and service workers are set aside, so the percentage is taken over a smaller denominator than the workspace\u0027s file count"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"64e0e3511eb969fb4720b196e7d3799e1714077217351c3c56a27b50e3e21220"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!box || box.top - t \u003E p.top || box.bottom \u002B t \u003C p.top || box.left - t \u003E p.left || box.right \u002B t \u003C p.left\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":286}}}],"partialFingerprints":{"codehealthFindingId/v1":"0cd88658242d7f8f91e96b897a05353e1ee118b77a63b87cc2d7df41f74c02fd"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!distance || this.options.pullPlaceholder\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":328}}}],"partialFingerprints":{"codehealthFindingId/v1":"98e6ae4ab8a77d1ffd46e96a76fe2c683693faa109cc54e0c491067500af9441"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!object \u0026\u0026 (methodOrOptions === undefined || typeof methodOrOptions === \u0022object\u0022)\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":685}}}],"partialFingerprints":{"codehealthFindingId/v1":"3459f97364489dc389c18c4ae73b8ee593fa2770d062a94a0f8092c1bccc7b10"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!response || !response.rows || response.rows.length === 0\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/widgets/IpsecTunnels.js, src/opnsense/www/js/widgets/Wireguard.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/IpsecTunnels.js"},"region":{"startLine":61}}}],"partialFingerprints":{"codehealthFindingId/v1":"a79b2eaec8f08f0634955b8f092ecd7446f3d8cbad0db02e27b386b8eabe2972"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!rootGroup.options.isValidTarget || rootGroup.options.isValidTarget(rootGroup.item, this)\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":496}}}],"partialFingerprints":{"codehealthFindingId/v1":"8dbcd1fe425ada2a5a1e4e5be519c90142d2bf15c622bf4a0f06c25fb2ab012f"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!sameResultBox \u0026\u0026 lastAppendedItem \u0026\u0026 lastAppendedItem[0] === item[0]\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":346}}}],"partialFingerprints":{"codehealthFindingId/v1":"fe771958f21602759790ff2b27b0f9cf233c19c38094af7727d9d8967a27612a"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!this.dataChanged(\u0027dhcp-leases\u0027, leaseRows) \u0026\u0026 !this.configChanged\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/widgets/DnsmasqLeases.js, src/opnsense/www/js/widgets/KeaLeases.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/widgets/DnsmasqLeases.js"},"region":{"startLine":77}}}],"partialFingerprints":{"codehealthFindingId/v1":"14892f7432ea4de0391ba1d301547058badb842d69496493dc527b105bf40546"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!this.disabled \u0026\u0026 !rootGroup.dragInitDone \u0026\u0026 this.options.drag \u0026\u0026 this.isValidDrag(e)\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":479}}}],"partialFingerprints":{"codehealthFindingId/v1":"954e0e270d938f5b7453d1099901971fa0e31589718608456302b89276844833"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060$.support.transition \u0026\u0026 this.$element.hasClass(\u0027fade\u0027)\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/bootstrap-dialog.js, src/opnsense/www/js/bootstrap.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-dialog.js"},"region":{"startLine":99}}}],"partialFingerprints":{"codehealthFindingId/v1":"deb8b2e3a84f60448e014cd58faa3da1a6e3d8ed34c767c958ebe60cd568a3f0"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060API[methodOrOptions].apply(object, args) || this\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":684}}}],"partialFingerprints":{"codehealthFindingId/v1":"898c7bee86c6313080b6c11f50dbb8ea3d2d669b70832f4f57328a9a55a1d5af"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060attr.nodeValue.match(SAFE_URL_PATTERN) || attr.nodeValue.match(DATA_URL_PATTERN)\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/bootstrap-select.js, src/opnsense/www/js/bootstrap.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"086c813e5510b750349ac169ff6aecff69b7c6252772409a745c441a8dc1733f"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060b[1] - a[1] || b[2] - a[2] || b[0] - a[0]\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":212}}}],"partialFingerprints":{"codehealthFindingId/v1":"4e47e07d34fa96329688f8b07d3506eef6212d048ced38ae741f4943a1fff9ae"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060e.originalEvent || e.originalEvent.touches \u0026\u0026 e.originalEvent.touches[0]\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":404}}}],"partialFingerprints":{"codehealthFindingId/v1":"7db53d925c3a09acd8cba7aa4fd8f7a46429f3ba32566fa6f6f6cf4184f0f64b"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060e.which == 1 || e.type == \u0022touchstart\u0022 \u0026\u0026 e.originalEvent.touches.length == 1\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":487}}}],"partialFingerprints":{"codehealthFindingId/v1":"d4d5e9fb096b843b18bcd8ae4e70a62f7e5909734266dc57e6ff092639823f6a"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060el.css(\u0022position\u0022) === \u0022relative\u0022 || el.css(\u0022position\u0022) === \u0022absolute\u0022 || el.css(\u0022position\u0022) === \u0022fixed\u0022\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":565}}}],"partialFingerprints":{"codehealthFindingId/v1":"c488408a39dda51bb260fa828af0129bc596dbd3b4638360392bef9ae24d6a90"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060lastPointer \u0026\u0026 [lastPointer.left, lastPointer.top]\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":201}}}],"partialFingerprints":{"codehealthFindingId/v1":"6f5fe2d24439252abbfa8bc1ad5b122de627f1cf1a7ef32d86a56897de0dd918"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060sanitizeFn \u0026\u0026 typeof sanitizeFn === \u0027function\u0027\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/bootstrap-select.js, src/opnsense/www/js/bootstrap.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":117}}}],"partialFingerprints":{"codehealthFindingId/v1":"7fed3ac8e6022bc4e7a3c5c91be494bcdc06bf52a4261a330b66c0e2ac5bbc2b"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060this.item.is(this.options.exclude) || !this.options.onMousedown(this.item, groupDefaults.onMousedown, e)\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":256}}}],"partialFingerprints":{"codehealthFindingId/v1":"affb9f0f4588287700e353531c84aaf348ef6b6484ccf9fe116a21d992d9160b"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060this.lastRelativePointer || this.lastPointer\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":316}}}],"partialFingerprints":{"codehealthFindingId/v1":"2c43f19214a85a6c1453d51b6053f6af91034bcc9c73f13b9c9608008237dd43"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060this.options.nested \u0026\u0026 this.getContainerGroup(index)\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":572}}}],"partialFingerprints":{"codehealthFindingId/v1":"f582fccbc3b8e46e0bb9915e7ccac11205d626015cf044d3eb29a4c4ced88000"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060this.rootGroup.options.handle || this.rootGroup.options.itemSelector\u0060 appears character-identically in 2 files \u2014 src/opnsense/www/js/jquery-sortable.js, src/opnsense/www/js/tokenize2.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/jquery-sortable.js"},"region":{"startLine":464}}}],"partialFingerprints":{"codehealthFindingId/v1":"1e7e2535bb11cd0dbefaaed06093df051d0e8fd2acd5163c36125a3be86033a6"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060typeof define === \u0027function\u0027 \u0026\u0026 define.amd\u0060 appears character-identically in 5 files \u2014 src/opnsense/www/js/bootstrap-select.js, src/opnsense/www/js/bootstrap3-typeahead.js, src/opnsense/www/js/chartjs-plugin-streaming.js, src/opnsense/www/js/qrcode.js. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"67dd7fed11b6ab0c30e923fde1e7135941e05ea1231826e6392dc3cf701a8955"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!empty($classprefix) \u0026\u0026 strpos($classname, $classprefix) !== 0\u0060 appears character-identically in 2 files \u2014 src/opnsense/mvc/script/run_migrations.php, src/opnsense/mvc/script/run_validations.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/script/run_migrations.php"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"f3fdc5a673dada1a682e5a6794d279b9c58abf785223c2c4278031c7bb8e37b9"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!empty($config-\u003Egateways) \u0026\u0026 count($config-\u003Egateways-\u003Echildren()) \u003E 0\u0060 appears character-identically in 2 files \u2014 src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php, src/opnsense/mvc/app/models/OPNsense/Routing/Migrations/M1_0_0.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php"},"region":{"startLine":212}}}],"partialFingerprints":{"codehealthFindingId/v1":"d733ebcbc853e4a42894297a64057fe384b6839d96bb57d7cbd65d9e9d6c7207"}},{"ruleId":"X10","level":"note","message":{"text":"Duplicated predicate: \u0060!empty($config[$confSetting]) \u0026\u0026 property_exists($this, $objectProperty)\u0060 appears character-identically in 2 files \u2014 src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php, src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php. It is one line, so the duplication detector\u0027s token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php"},"region":{"startLine":282}}}],"partialFingerprints":{"codehealthFindingId/v1":"036c236e3ec3e093a6620d65ff70ab2fa14b0f5405f715b517b37bf33852e05b"}},{"ruleId":"X19","level":"warning","message":{"text":"Process-global state is restored only on the happy path: \u0060connect\u0060 changes state that belongs to the whole PROCESS and changes it back at the end of the same body \u2014 the error handler (changed at line 350, reset at line 386) \u2014 which says the change was meant to last no longer than this call. But the restore is an ordinary statement on the straight-line path, not a \u0060finally\u0060, so it is skipped by any exception thrown in between: PHP then keeps the overwritten value for the rest of the request \u2014 and in a CLI command, a queue worker or a long-running server (Octane, Swoole, RoadRunner, FrankenPHP) for the rest of the process\u0027s life \u2014 and every later relative path, child-process launch, date, number format, XML parse or error report in ANY class reads it. That failure is silent and remote from its cause: the function that breaks is not the function that moved the value. The durable fix is not to widen the restore but to stop mutating the global: pass the value to the operation that needs it \u2014 \u0060cwd\u0060 and \u0060env\u0060 to Symfony \u0060Process\u0060 (\u0060new Process($command, $cwd, $env)\u0060) or \u0060proc_open($command, $spec, $pipes, $cwd, $env)\u0060, absolute paths instead of \u0060chdir\u0060, an explicit \u0060DateTimeZone\u0060 or locale to \u0060DateTimeImmutable\u0060/\u0060IntlDateFormatter\u0060/\u0060NumberFormatter\u0060, an explicit encoding to the \u0060mb_*\u0060 call, \u0060LIBXML_NOERROR\u0060/\u0060libxml_get_errors\u0060 handling in one place. Where the global genuinely must move, wrap it \u0060try\u0060/\u0060finally\u0060 so the restore runs on every path."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php"},"region":{"startLine":346}}}],"partialFingerprints":{"codehealthFindingId/v1":"c03f78a4898907893e5795bf378106ca0caae05e753eb40ec0a3a7471ab3090d"}},{"ruleId":"X19","level":"warning","message":{"text":"Process-global state is restored only on the happy path: \u0060loadFromStream\u0060 changes state that belongs to the whole PROCESS and changes it back at the end of the same body \u2014 the error handler (changed at line 388, reset at line 396) \u2014 which says the change was meant to last no longer than this call. But the restore is an ordinary statement on the straight-line path, not a \u0060finally\u0060, so it is skipped by any exception thrown in between: PHP then keeps the overwritten value for the rest of the request \u2014 and in a CLI command, a queue worker or a long-running server (Octane, Swoole, RoadRunner, FrankenPHP) for the rest of the process\u0027s life \u2014 and every later relative path, child-process launch, date, number format, XML parse or error report in ANY class reads it. That failure is silent and remote from its cause: the function that breaks is not the function that moved the value. The durable fix is not to widen the restore but to stop mutating the global: pass the value to the operation that needs it \u2014 \u0060cwd\u0060 and \u0060env\u0060 to Symfony \u0060Process\u0060 (\u0060new Process($command, $cwd, $env)\u0060) or \u0060proc_open($command, $spec, $pipes, $cwd, $env)\u0060, absolute paths instead of \u0060chdir\u0060, an explicit \u0060DateTimeZone\u0060 or locale to \u0060DateTimeImmutable\u0060/\u0060IntlDateFormatter\u0060/\u0060NumberFormatter\u0060, an explicit encoding to the \u0060mb_*\u0060 call, \u0060LIBXML_NOERROR\u0060/\u0060libxml_get_errors\u0060 handling in one place. Where the global genuinely must move, wrap it \u0060try\u0060/\u0060finally\u0060 so the restore runs on every path."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Core/Config.php"},"region":{"startLine":378}}}],"partialFingerprints":{"codehealthFindingId/v1":"4eaa97690fa927333c88693b0d974a938096a11cae7cdb611df655c62debba3f"}},{"ruleId":"X19","level":"warning","message":{"text":"Process-global state is restored only on the happy path: \u0060signCert\u0060 changes state that belongs to the whole PROCESS and changes it back at the end of the same body \u2014 the error-reporting level (changed at line 267, put back at line 276) \u2014 which says the change was meant to last no longer than this call. But the restore is an ordinary statement on the straight-line path, not a \u0060finally\u0060, so it is skipped by any exception thrown in between: PHP then keeps the overwritten value for the rest of the request \u2014 and in a CLI command, a queue worker or a long-running server (Octane, Swoole, RoadRunner, FrankenPHP) for the rest of the process\u0027s life \u2014 and every later relative path, child-process launch, date, number format, XML parse or error report in ANY class reads it. That failure is silent and remote from its cause: the function that breaks is not the function that moved the value. The durable fix is not to widen the restore but to stop mutating the global: pass the value to the operation that needs it \u2014 \u0060cwd\u0060 and \u0060env\u0060 to Symfony \u0060Process\u0060 (\u0060new Process($command, $cwd, $env)\u0060) or \u0060proc_open($command, $spec, $pipes, $cwd, $env)\u0060, absolute paths instead of \u0060chdir\u0060, an explicit \u0060DateTimeZone\u0060 or locale to \u0060DateTimeImmutable\u0060/\u0060IntlDateFormatter\u0060/\u0060NumberFormatter\u0060, an explicit encoding to the \u0060mb_*\u0060 call, \u0060LIBXML_NOERROR\u0060/\u0060libxml_get_errors\u0060 handling in one place. Where the global genuinely must move, wrap it \u0060try\u0060/\u0060finally\u0060 so the restore runs on every path."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Trust/Store.php"},"region":{"startLine":258}}}],"partialFingerprints":{"codehealthFindingId/v1":"62af19ccb8a22e02be19485b0455b7e5c9161c0b67df18f28c25596d0d089bfe"}},{"ruleId":"X19","level":"warning","message":{"text":"Process-global state is restored only on the happy path: \u0060reIssueCert\u0060 changes state that belongs to the whole PROCESS and changes it back at the end of the same body \u2014 the error-reporting level (changed at line 305, put back at line 318) \u2014 which says the change was meant to last no longer than this call. But the restore is an ordinary statement on the straight-line path, not a \u0060finally\u0060, so it is skipped by any exception thrown in between: PHP then keeps the overwritten value for the rest of the request \u2014 and in a CLI command, a queue worker or a long-running server (Octane, Swoole, RoadRunner, FrankenPHP) for the rest of the process\u0027s life \u2014 and every later relative path, child-process launch, date, number format, XML parse or error report in ANY class reads it. That failure is silent and remote from its cause: the function that breaks is not the function that moved the value. The durable fix is not to widen the restore but to stop mutating the global: pass the value to the operation that needs it \u2014 \u0060cwd\u0060 and \u0060env\u0060 to Symfony \u0060Process\u0060 (\u0060new Process($command, $cwd, $env)\u0060) or \u0060proc_open($command, $spec, $pipes, $cwd, $env)\u0060, absolute paths instead of \u0060chdir\u0060, an explicit \u0060DateTimeZone\u0060 or locale to \u0060DateTimeImmutable\u0060/\u0060IntlDateFormatter\u0060/\u0060NumberFormatter\u0060, an explicit encoding to the \u0060mb_*\u0060 call, \u0060LIBXML_NOERROR\u0060/\u0060libxml_get_errors\u0060 handling in one place. Where the global genuinely must move, wrap it \u0060try\u0060/\u0060finally\u0060 so the restore runs on every path."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Trust/Store.php"},"region":{"startLine":295}}}],"partialFingerprints":{"codehealthFindingId/v1":"6d72c129e2cfdfa092a1f56f9544b4da037152e24c5d6e7cdaf6c6b6b2f05494"}},{"ruleId":"X19","level":"warning","message":{"text":"Process-global state is restored only on the happy path: \u0060createCert\u0060 changes state that belongs to the whole PROCESS and changes it back at the end of the same body \u2014 the error-reporting level (changed at line 346, put back at line 373) \u2014 which says the change was meant to last no longer than this call. But the restore is an ordinary statement on the straight-line path, not a \u0060finally\u0060, so it is skipped by any exception thrown in between: PHP then keeps the overwritten value for the rest of the request \u2014 and in a CLI command, a queue worker or a long-running server (Octane, Swoole, RoadRunner, FrankenPHP) for the rest of the process\u0027s life \u2014 and every later relative path, child-process launch, date, number format, XML parse or error report in ANY class reads it. That failure is silent and remote from its cause: the function that breaks is not the function that moved the value. The durable fix is not to widen the restore but to stop mutating the global: pass the value to the operation that needs it \u2014 \u0060cwd\u0060 and \u0060env\u0060 to Symfony \u0060Process\u0060 (\u0060new Process($command, $cwd, $env)\u0060) or \u0060proc_open($command, $spec, $pipes, $cwd, $env)\u0060, absolute paths instead of \u0060chdir\u0060, an explicit \u0060DateTimeZone\u0060 or locale to \u0060DateTimeImmutable\u0060/\u0060IntlDateFormatter\u0060/\u0060NumberFormatter\u0060, an explicit encoding to the \u0060mb_*\u0060 call, \u0060LIBXML_NOERROR\u0060/\u0060libxml_get_errors\u0060 handling in one place. Where the global genuinely must move, wrap it \u0060try\u0060/\u0060finally\u0060 so the restore runs on every path."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Trust/Store.php"},"region":{"startLine":336}}}],"partialFingerprints":{"codehealthFindingId/v1":"e5915140edb4b13c654d2a0e43823b970951ee7c56a939b9eaf21dddd154c564"}},{"ruleId":"X19","level":"warning","message":{"text":"Process-global state is restored only on the happy path: \u0060getPKCS12\u0060 changes state that belongs to the whole PROCESS and changes it back at the end of the same body \u2014 the error-reporting level (changed at line 553, put back at line 565) \u2014 which says the change was meant to last no longer than this call. But the restore is an ordinary statement on the straight-line path, not a \u0060finally\u0060, so it is skipped by any exception thrown in between: PHP then keeps the overwritten value for the rest of the request \u2014 and in a CLI command, a queue worker or a long-running server (Octane, Swoole, RoadRunner, FrankenPHP) for the rest of the process\u0027s life \u2014 and every later relative path, child-process launch, date, number format, XML parse or error report in ANY class reads it. That failure is silent and remote from its cause: the function that breaks is not the function that moved the value. The durable fix is not to widen the restore but to stop mutating the global: pass the value to the operation that needs it \u2014 \u0060cwd\u0060 and \u0060env\u0060 to Symfony \u0060Process\u0060 (\u0060new Process($command, $cwd, $env)\u0060) or \u0060proc_open($command, $spec, $pipes, $cwd, $env)\u0060, absolute paths instead of \u0060chdir\u0060, an explicit \u0060DateTimeZone\u0060 or locale to \u0060DateTimeImmutable\u0060/\u0060IntlDateFormatter\u0060/\u0060NumberFormatter\u0060, an explicit encoding to the \u0060mb_*\u0060 call, \u0060LIBXML_NOERROR\u0060/\u0060libxml_get_errors\u0060 handling in one place. Where the global genuinely must move, wrap it \u0060try\u0060/\u0060finally\u0060 so the restore runs on every path."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Trust/Store.php"},"region":{"startLine":546}}}],"partialFingerprints":{"codehealthFindingId/v1":"8f4b63c16ddc34503ec973eb6ced3bc3ec55257db036a7595e66a6747e1f62ff"}},{"ruleId":"X2","level":"note","message":{"text":"Not all async functions that make a request accept an AbortSignal: Only 0/2 async functions that make a cancellable request (fetch, axios, ky, ofetch) accept an AbortSignal or pass one on, so a request keeps running after whatever wanted it has given up \u2014 a page navigated away from, an unmounted component, a timed-out job. Take a \u0060signal\u0060 (or an options object that carries one) and hand it to the request; where nothing could ever cancel the call, omitting it is a deliberate choice \u2014 judge against how the function is used."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"bd89d014f84408f7063269aa5892ba3df7c9af3e981ecfb0752c5731bc62d406"}},{"ruleId":"X2","level":"warning","message":{"text":"Async function without AbortSignal: _fetchRRDList: \u0060_fetchRRDList\u0060 awaits \u0060fetch(\u2026)\u0060 but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept \u0060{ signal }\u0060 and pass it through: \u0060fetch(url, { signal })\u0060."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_health.js"},"region":{"startLine":119}}}],"partialFingerprints":{"codehealthFindingId/v1":"4a074c8c88e7f4666b55c0645b13e928b6cef8acb4d88492fd382ede19dfd60b"}},{"ruleId":"X2","level":"warning","message":{"text":"Async function without AbortSignal: _fetchData: \u0060_fetchData\u0060 awaits \u0060fetch(\u2026)\u0060 but neither accepts an AbortSignal nor passes one on, so its caller cannot stop the request once it has started. Accept \u0060{ signal }\u0060 and pass it through: \u0060fetch(url, { signal })\u0060."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_health.js"},"region":{"startLine":124}}}],"partialFingerprints":{"codehealthFindingId/v1":"b7ed12333f3e1cebdd66598842ff8593c57a61aca658723a2878f35d7dfe3fb7"}},{"ruleId":"X24","level":"warning","message":{"text":"Untrusted text written into markup unescaped: \u0060content\u0060 is text this program did not author, and it is written into the text of an element through \u0060innerHTML\u0060 with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework\u0027s escaping output, or sanitise it if it must stay markup."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":714}}}],"partialFingerprints":{"codehealthFindingId/v1":"e6d40eabf44a491fd44254d433d658efa9fd64e6131203f0b8453e045b5936c5"}},{"ruleId":"X24","level":"warning","message":{"text":"Untrusted text written into markup unescaped: \u0060text\u0060 is text this program did not author, and it is written into the text of an element through \u0060insertAdjacentHTML\u0060 with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework\u0027s escaping output, or sanitise it if it must stay markup."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":731}}}],"partialFingerprints":{"codehealthFindingId/v1":"cc157e1e590dd2e190522f0a3221da0610ac3fd0fa54aa5a7cd1ed7498c1488b"}},{"ruleId":"X24","level":"warning","message":{"text":"Untrusted text written into markup unescaped: \u0060options.content\u0060 is text this program did not author, and it is written into the text of an element through \u0060innerHTML\u0060 with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework\u0027s escaping output, or sanitise it if it must stay markup."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":747}}}],"partialFingerprints":{"codehealthFindingId/v1":"7809e24f2df6a457e0be83e890b36e8f855793bd0387869825104efba0a9d0ff"}},{"ruleId":"X24","level":"warning","message":{"text":"Untrusted text written into markup unescaped: \u0060options.display\u0060 is text this program did not author, and it is written into the text of an element through \u0060innerHTML\u0060 with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework\u0027s escaping output, or sanitise it if it must stay markup."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":786}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ef309beb155c7417eae23705700c9376fe627d06a10cdecd54ec935fa945671"}},{"ruleId":"X24","level":"warning","message":{"text":"Untrusted text written into markup unescaped: \u0060this.options.noneResultsText.replace(\u0027{0}\u0027,\u0027\u0022\u0027\u002BhtmlEscape(searchValue)\u002B\u0027\u0022\u0027)\u0060 is text this program did not author, and it is written into the text of an element through \u0060innerHTML\u0060 with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework\u0027s escaping output, or sanitise it if it must stay markup."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":812}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd2292e04fbb49738082f3240cebe0a1ef8a1879da42dcd221d178812ce27b75"}},{"ruleId":"X24","level":"warning","message":{"text":"Untrusted text written into markup unescaped: \u0060unsafeHtml\u0060 is text this program did not author, and it is written into the text of an element through \u0060innerHTML\u0060 with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework\u0027s escaping output, or sanitise it if it must stay markup."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap.js"},"region":{"startLine":1401}}}],"partialFingerprints":{"codehealthFindingId/v1":"2b9c77f13cdd7e341bdd54095e21faf2baeed25e15cc083e8e42c341317eb1b7"}},{"ruleId":"X24","level":"warning","message":{"text":"Untrusted text written into markup unescaped: \u0060this.options.tooltipFormatter.call(this,t,data)\u0060 is text this program did not author, and it is written into the text of an element through \u0060innerHTML\u0060 with nothing encoding it for that place. Whoever controls the value controls the markup: it can close the element or attribute it sits in and open a script of its own. Encode it for HTML at this site, render it through the framework\u0027s escaping output, or sanitise it if it must stay markup."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/smoothie.js"},"region":{"startLine":647}}}],"partialFingerprints":{"codehealthFindingId/v1":"26c424f113b0ff1f7c7ff97d26c31b891516aa787291a9eb55f77b0e65441d0b"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (\\Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/IXR/IXR_Library.php"},"region":{"startLine":656}}}],"partialFingerprints":{"codehealthFindingId/v1":"ae987f1cb05a2ee968c60960e7f72e8a6286f01be0998077190ead485824b01a"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (\\Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"contrib/IXR/IXR_Library.php"},"region":{"startLine":662}}}],"partialFingerprints":{"codehealthFindingId/v1":"5051dea8fbcc7250d50357cbbf8f8e2f83376648d6910c579183501b250e5138"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Throwable)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/etc/inc/config.inc"},"region":{"startLine":217}}}],"partialFingerprints":{"codehealthFindingId/v1":"64f1122f6161cb77c659d31b1e4a23ad0da1e7105ae5227560bdc1680b5ef110"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060catch (Exception)\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php"},"region":{"startLine":134}}}],"partialFingerprints":{"codehealthFindingId/v1":"b3835612b81ae92a52f3f7c402222564d1f110e9aef731e7db450867f7ac0655"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060except\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/states.py"},"region":{"startLine":170}}}],"partialFingerprints":{"codehealthFindingId/v1":"0ff4bb545ac18d5be61e8cc8cc6f94d12af0590afb6b3c911ec7470ea1994e16"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of \u0060close()\u0060 masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems \u2014 or, if it truly cannot matter, say why in a comment on the catch."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound-dnsbl/lib/log.py"},"region":{"startLine":87}}}],"partialFingerprints":{"codehealthFindingId/v1":"83e00965baaa03f849f411c622e4ebf7dd3499bb26cb463553ba8971398adcc0"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (caught, then discarded): \u0060except Exception\u0060 takes every exception and records none of it \u2014 the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/unbound/logger.py"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"a2d88975ed4d0c77e8ed67841104d83623499a3eddf6db1fbfa7717a57e6eb65"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): \u0060.catch(() =\u003E {})\u0060 handles the rejection by doing nothing \u2014 the failure is discarded with no log and no rethrow, and the chain carries on as if the work succeeded. Log it through whatever this codebase already uses to report problems, hand it to a caller that can (\u0060next(error)\u0060, a returned rejection), or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/opnsense_widgets.js"},"region":{"startLine":1192}}}],"partialFingerprints":{"codehealthFindingId/v1":"8180835fd65d42f107dc4372d5b8f0d1c2fe43e9546fce993c63a5e1e3e459f0"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":255}}}],"partialFingerprints":{"codehealthFindingId/v1":"73c33e044798e896b1233958d35fda0a445e07f24f1eaba4417fadbbbdf6bd60"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/www/js/bootstrap-select.js"},"region":{"startLine":652}}}],"partialFingerprints":{"codehealthFindingId/v1":"3c15cb0a0498ec38354ef33399dbd7c0fc9a47bdd300ee6ec59261ad4bf7af69"}},{"ruleId":"X3","level":"warning","message":{"text":"Swallowed exception (empty catch): An empty catch block silently discards the error \u2014 failures vanish with no log and no rethrow. Log it, handle it, or don\u0027t catch it."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/www/diag_backup.php"},"region":{"startLine":58}}}],"partialFingerprints":{"codehealthFindingId/v1":"f74fd9e0daeed0909914f9080b82826c4a542144a1709c37b169fab8cbdbaba0"}},{"ruleId":"X5","level":"note","message":{"text":"PHP static analysis does not check null everywhere: This repository commits no PHPStan or Psalm configuration (\u0060phpstan.neon[.dist]\u0060, \u0060phpstan.dist.neon\u0060, \u0060psalm.xml[.dist]\u0060, or one a composer.json script names with \u0060--configuration\u0060), so nothing checks null: a \u0060?Customer\u0060 reaches \u0060-\u003Ename()\u0060 silently and throws \u0060Error: Call to a member function name() on null\u0060 the first time it is null. If the build passes a level on a command line instead, put it in a committed configuration \u2014 this check reads configuration, and configuration is all it can read."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"4ee877508ebc333ebff2765634874753d7fd67f71ea749a6c333792a59b461d7"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default on parse failure: \u0060read_alias_file\u0060 returns \u0060False\u0060 when \u0060UnicodeDecodeError\u0060 is raised, with no log or raise \u2014 a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the handler or in the docstring, and the row stops firing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/filter/lib/alias/__init__.py"},"region":{"startLine":194}}}],"partialFingerprints":{"codehealthFindingId/v1":"adbb4671647180da8f767c78aa456c8c85ddea45f55f65772611a0efa0370f77"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default on parse failure: \u0060load_settings\u0060 returns \u0060{}\u0060 when \u0060ValueError\u0060 is raised, with no log or raise \u2014 a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the handler or in the docstring, and the row stops firing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/interfaces/capture.py"},"region":{"startLine":72}}}],"partialFingerprints":{"codehealthFindingId/v1":"698595e3436c8c0ff5e40f69cdee525cd05231f8cf80261195bf19f7d3661068"}},{"ruleId":"X7","level":"note","message":{"text":"Silent fallback default on parse failure: \u0060load_settings\u0060 returns \u0060{}\u0060 when \u0060ValueError\u0060 is raised, with no log or raise \u2014 a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment on the handler or in the docstring, and the row stops firing."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/opnsense/scripts/interfaces/ping.py"},"region":{"startLine":59}}}],"partialFingerprints":{"codehealthFindingId/v1":"bd44034e1030a0a00350717a372d7e1b9352dcf0f7eae1bde59d583f8dffde12"}}],"taxonomies":[{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d","organization":"MITRE","informationUri":"https://cwe.mitre.org/","isComprehensive":false,"shortDescription":{"text":"The MITRE Common Weakness Enumeration (CWE)."},"taxa":[{"id":"CWE-1059","guid":"a2381a08-60f6-9554-a8b8-f3018cfaaca5","name":"Insufficient Technical Documentation","shortDescription":{"text":"Insufficient Technical Documentation"},"helpUri":"https://cwe.mitre.org/data/definitions/1059.html"},{"id":"CWE-116","guid":"c0134ca8-adc7-6959-bd17-5253a265d101","name":"Improper Encoding or Escaping of Output","shortDescription":{"text":"Improper Encoding or Escaping of Output"},"helpUri":"https://cwe.mitre.org/data/definitions/116.html"},{"id":"CWE-208","guid":"9afb1e8d-bcf4-2f50-bd88-5c132c0e93d7","name":"CWE-208","shortDescription":{"text":"CWE-208"},"helpUri":"https://cwe.mitre.org/data/definitions/208.html"},{"id":"CWE-259","guid":"ae9ad959-fbb6-9d5e-892d-3dca66da0b69","name":"Use of Hard-coded Password","shortDescription":{"text":"Use of Hard-coded Password"},"helpUri":"https://cwe.mitre.org/data/definitions/259.html"},{"id":"CWE-276","guid":"4e27da05-61af-1d5c-aeb5-9f56b6ede3e3","name":"Incorrect Default Permissions","shortDescription":{"text":"Incorrect Default Permissions"},"helpUri":"https://cwe.mitre.org/data/definitions/276.html"},{"id":"CWE-457","guid":"b62874fe-6222-8b5b-8ade-9527ad1cbb4a","name":"CWE-457","shortDescription":{"text":"CWE-457"},"helpUri":"https://cwe.mitre.org/data/definitions/457.html"},{"id":"CWE-611","guid":"1afbae66-ea29-2d59-aaa2-134e3ae2e85a","name":"Improper Restriction of XML External Entity Reference","shortDescription":{"text":"Improper Restriction of XML External Entity Reference"},"helpUri":"https://cwe.mitre.org/data/definitions/611.html"},{"id":"CWE-697","guid":"61fcce2f-e722-1753-b9b3-ef38f4650b8a","name":"CWE-697","shortDescription":{"text":"CWE-697"},"helpUri":"https://cwe.mitre.org/data/definitions/697.html"},{"id":"CWE-77","guid":"332c8ade-6612-9f56-a06b-d8d90b1a8750","name":"Improper Neutralization of Special Elements used in a Command (\u0027Command Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in a Command (\u0027Command Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/77.html"},{"id":"CWE-78","guid":"2e31ceaf-c7ae-2e5e-9661-cfb1362789cf","name":"Improper Neutralization of Special Elements used in an OS Command (\u0027OS Command Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in an OS Command (\u0027OS Command Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/78.html"},{"id":"CWE-79","guid":"fd45580b-e8c4-fc5e-8c2f-aa8fab0b4dbf","name":"Improper Neutralization of Input During Web Page Generation (\u0027Cross-site Scripting\u0027)","shortDescription":{"text":"Improper Neutralization of Input During Web Page Generation (\u0027Cross-site Scripting\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/79.html"},{"id":"CWE-798","guid":"5e8f057d-fee3-995a-a0cb-9fc5b0d174d1","name":"Use of Hard-coded Credentials","shortDescription":{"text":"Use of Hard-coded Credentials"},"helpUri":"https://cwe.mitre.org/data/definitions/798.html"},{"id":"CWE-89","guid":"6d08fdad-37eb-c150-bbf0-d7d946863407","name":"Improper Neutralization of Special Elements used in an SQL Command (\u0027SQL Injection\u0027)","shortDescription":{"text":"Improper Neutralization of Special Elements used in an SQL Command (\u0027SQL Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/89.html"},{"id":"CWE-918","guid":"2e9b9091-5a0f-dc57-b644-7ad04bd56e64","name":"Server-Side Request Forgery (SSRF)","shortDescription":{"text":"Server-Side Request Forgery (SSRF)"},"helpUri":"https://cwe.mitre.org/data/definitions/918.html"},{"id":"CWE-94","guid":"75e7f50c-6c2f-dd52-bf40-bf6c52b861fd","name":"Improper Control of Generation of Code (\u0027Code Injection\u0027)","shortDescription":{"text":"Improper Control of Generation of Code (\u0027Code Injection\u0027)"},"helpUri":"https://cwe.mitre.org/data/definitions/94.html"}]},{"name":"OWASP Top 10","guid":"7d1f0c2e-4b6a-4e39-9a51-0b2e8c3d5f61","version":"2025","organization":"OWASP Foundation","informationUri":"https://top10.owasp.org/2025/","isComprehensive":false,"shortDescription":{"text":"The OWASP Top 10:2025 web application security risks."},"taxa":[{"id":"A01:2025","guid":"df693558-c822-0452-8f7b-4d53cb6bcc59","name":"Broken Access Control","shortDescription":{"text":"Broken Access Control"},"helpUri":"https://top10.owasp.org/2025/A01_2025-Broken_Access_Control/"},{"id":"A02:2025","guid":"668dee9e-41bc-6354-97d0-fdf8f40c50c1","name":"Security Misconfiguration","shortDescription":{"text":"Security Misconfiguration"},"helpUri":"https://top10.owasp.org/2025/A02_2025-Security_Misconfiguration/"},{"id":"A05:2025","guid":"87e86033-3231-8458-8e4a-5cb82743553a","name":"Injection","shortDescription":{"text":"Injection"},"helpUri":"https://top10.owasp.org/2025/A05_2025-Injection/"},{"id":"A07:2025","guid":"334ddd78-539d-d35c-83dd-253647eb7eaf","name":"Authentication Failures","shortDescription":{"text":"Authentication Failures"},"helpUri":"https://top10.owasp.org/2025/A07_2025-Authentication_Failures/"}]}],"properties":{"codehealthPublication":{"public":true,"notice":"This is the PUBLIC form of this artifact. Findings are listed in full, but the details of SECURITY findings \u2014 which rule fired, in which file, on which line, and how to fix it \u2014 are deliberately withheld, and any secret-scanner results are excluded entirely. Where detail is absent here it was REMOVED FOR PUBLICATION; it is not missing from the analysis. The complete artifact is available from the repository owner.","securityFindingsRedacted":133,"secretScannerRunsExcluded":0}},"redactionTokens":["A security finding was recorded here. Its details are withheld on the public artifact \u2014 ask the repository owner for the full report."]}]}