Public report — phabricator, published 29 Jul 2026.
Concrete security findings (CVE IDs, secret matches, dependency versions) are hidden in this version;
ask the repo owner for the full report.
1674findings with an exact file:lineof 1682 — the remainder are repo-wide signals (a dimension-level measurement, not a single line); open any file:line and verify
26/104dimensions across the health lenses540315 LoC — wide & deep
Executive summary
Read through the Production lens — the standard calibration. *Green* means good enough to run in production. The score is absolute and comparable across repos.
phacility/phabricator carries serious gaps (44%). Several issues below can materially affect correctness, security, or the cost of changing it — and propagate to everything that depends on it.
It is strongest in Architecture (100%) — the structure is clean and changes stay contained.
The area that most needs attention is Readiness (38%) — releases are harder to depend on — versioning, release notes and dependency hygiene are thin, so consumers can't easily tell what changed or trust an upgrade. Security (40%) is the next concern — exposure to security and compliance incidents is elevated.
Leadership focus, highest impact first: SAST step to CI running what this repository's stack ships (Security & performance tooling); tests that import the unreached modules (directly or through… (Test Coverage); Expand the README with getting-started (Documentation (README)).
For scale: Very large (~540,315 production lines); rebuilding it from scratch would take roughly ~3.2 person-years (~1–7 engineers). Approximate, ±~30%.
It builds on a genuinely strong Architecture foundation (100%); the priorities above are the highest-leverage way to bring the rest up to that level.
How the score is built — each lens's share of the headlineWidth is the lens's weight in the worst-heaviest fold (the weakest area pulls hardest); colour is that lens's own band. A lens fixes the score in proportion to its width.
202 finding(s) are new versus the previous scan (2026-07-20) — surfaced by this scheduled scan itself, no pull request required. Showing the first 100; the full set is in the report.
A full-fidelity diff against the previous run's complete recorded findings — line-move tolerant: a finding that only shifted line counts as unchanged, only genuinely new titles/files surface here.
Rebuild cost & value ~ Modeled — €160,000–€790,000
0.7× (at 44% quality) — the last 20% of quality is most of the work
Size & shape
Very large · effort split not classified (source measured from disk; the effort-tier breakdown is a C#-only syntax walk)
This codebase represents roughly ~3.2 person-years of build effort (about ~€470,000 to rebuild). Its weakest lens is Readiness at 38% — the part of that asset most exposed by the findings below.
How we model this: boilerplate at a scaffolding rate + logic × domain Standard (×1.0) — standard service × a 0.7× quality factor, at €60–95/h; indicative, ±~30% · size measured directly from source · effort from total production LoC as straight-line logic (the tier split is a C#-only syntax walk), a conservative lower bound. Indicative only — most sensitive to the hourly rate and the domain tier (both tunable in config).
Top priorities
The highest-leverage moves; the full ranked list is in the Roadmap below.
1
Resolve the 3 Largest orphaned file finding(s) in Knowledge Freshness — start with PhabricatorApplicationTransactionEditor.php, PhabricatorCursorPagedPolicyAwareQuery.php, PhabricatorRepository.php.
Add a SAST step to CI running what this repository's stack ships: phpstan or psalm — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Value concentrated against a weak lens · High · Value at risk
This is a Very large asset (~3.2 person-years to rebuild), and its weakest lens is Readiness at 38%. The operational and business risk on an asset this size concentrates there — that's where remediation buys the most protection.
→ Direct remediation budget at Readiness first — highest risk-reduction per euro on an asset this size.
Highest-leverage move · Medium · Leverage
Of everything flagged, the best return on effort is: Add a SAST step to CI running what this repository's stack ships: phpstan or psalm — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing. The rest can wait behind it.
Evidence: priority ranking: top of 5 ranked by impact/effort
→ Add a SAST step to CI running what this repository's stack ships: phpstan or psalm — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
A velocity tax on every change · Medium · Economics
The code-quality signals (complexity, duplication, cohesion) average 7.0/10, which acts as a tax on every change in the weaker areas: modifications there plausibly cost on the order of 3–6% more than in clean code, and the tax compounds as the codebase grows. (A modelled estimate, not a measured fact.)
Evidence: D1/D2 complexity, D4 duplication, D6 cohesion: averaging 7.0/10 across the code-quality signals
→ Pay it down where churn is highest — the hotspots — not everywhere; that's where the tax is actually paid.
At a glance — Code Health · 56% · Adequate · gated by R1
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A03:2021 — Injection
34
High / Critical
A02:2021 — Cryptographic Failures
4
High / Critical
Roadmap
First, integrate static analysis and security scanning into the CI pipeline to fail the build on regressions. Next, increase test coverage by adding tests for all unreached production modules. Then, expand the README with a getting-started guide, architecture overview, and project map. Finally, establish an architecture decision record log to capture significant design choices and their rationale.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 3 Largest orphaned file finding(s) in Knowledge Freshness — start with PhabricatorApplicationTransactionEditor.php, PhabricatorCursorPagedPolicyAwareQuery.php, PhabricatorRepository.php.
Add a SAST step to CI running what this repository's stack ships: phpstan or psalm — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 25 of 26 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 1 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.4 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.
Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.
What we checked — 26 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 1674 of 1682 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D19 Documentation Quality — LLM provider failed — The model provider returned an unusable result, so this LLM-assisted dimension fell back to a measurement gap (confidence 0) rather than a penalty. Re-run with a reachable provider to score it.
D30 Dependency Vulnerabilities — scanner not present in this environment — The backing tool was not installed where this scan ran, so this dimension was not scored. Install the tool (or run in the hosted environment, where it is always present) for a graded result.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity (jscpd) — it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
The LLM boundary
LLM-set scores this run (2): D21, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score (documentation, ADR quality, naming, comment value, onboarding) — D25 sets the ADR-conformance fraction over sampled code, D22 judges API accuracy over a sample. These are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
331 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was PhabricatorAuthRegisterController.handleRequest at 88. A further 11 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being AphrontResponse.getHTTPResponseMessage at 44 — they are counted neither in the figure above nor in this dimension's score.
+ 326 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 1 PhabricatorAuthRegisterController.handleRequest (cyclomatic 88) finding(s) in Cyclomatic Complexity — start with PhabricatorAuthRegisterController.php. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 DifferentialChangesetParser.render (cyclomatic 65) finding(s) in Cyclomatic Complexity — start with DifferentialChangesetParser.php. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 PhutilSearchQueryCompiler.tokenizeQuery (cyclomatic 62) finding(s) in Cyclomatic Complexity — start with PhutilSearchQueryCompiler.php. — One of this dimension's main actionable groups (1 warning-level).
Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 819 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 1 PhabricatorAuthRegisterController.handleRequest (cognitive 208) finding(s) in Cognitive Complexity — start with PhabricatorAuthRegisterController.php. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 DifferentialChangesetTwoUpRenderer.renderTextChange (cognitive 173) finding(s) in Cognitive Complexity — start with DifferentialChangesetTwoUpRenderer.php. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 PhutilSearchQueryCompiler.tokenizeQuery (cognitive 154) finding(s) in Cognitive Complexity — start with PhutilSearchQueryCompiler.php. — One of this dimension's main actionable groups (1 warning-level).
Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes9.1 / 10Exemplary✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Git-history secret scan via gitleaks detect over full history in an isolated checkout; each match flagged High. Exhaustive; degrades cleanly when tool absent.
7 finding(s): 0 critical, 7 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.
Secret: generic-api-key · ×3src/docs/contributor/using_oauthserver.diviner:104detected by gitleaks finding
Rotate the exposed credentials — git history can't be un-committed
What to do
Resolve the 3 Secret finding(s) in Secrets (history) — start with using_oauthserver.diviner (2), PhabricatorUser.php. — One of this dimension's main actionable groups (3 issue-level).
Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
High: insecure-use-string-copy-fnexternals/figlet/chkfont.c:86detected by semgrep finding
Medium: phpinfo-usesrc/applications/config/view/PhabricatorSetupIssueView.php:357detected by semgrep finding
Low: request-host-used · ×32src/aphront/configuration/AphrontApplicationConfiguration.php:12detected by semgrep finding
What to do
Resolve the 32 Low finding(s) in Static Analysis (SAST) — start with AphrontApplicationConfiguration.php (8), PhabricatorConfigClusterSearchController.php (6), PhabricatorNotificationServersConfigType.php (5). — One of this dimension's main actionable groups (32 recommendation-level).
Resolve the 1 High finding(s) in Static Analysis (SAST) — start with chkfont.c. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 Medium finding(s) in Static Analysis (SAST) — start with PhabricatorSetupIssueView.php. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
1855 of 1855 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php.
Largest orphaned file · ×3src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
Dormant codebase
What to do
Resolve the 3 Largest orphaned file finding(s) in Knowledge Freshness — start with PhabricatorApplicationTransactionEditor.php, PhabricatorCursorPagedPolicyAwareQuery.php, PhabricatorRepository.php. — One of this dimension's main actionable groups (3 recommendation-level).
Resolve the 1 Dormant codebase finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling; coupling through a build step, config, or non-source file isn't seen.
Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
The root README is 33 words — likely missing build/run/architecture context.
What to do
Expand the README with getting-started, architecture overview and a project map.
Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
Add a 'Testing' section to the root README — how to run the test suite.
Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).
Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.
Do you agree with this assessment?
P1 · CI/CD gates6.5 / 10Adequate✓ Tool-verified
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
A CI pipeline exists and the word "test" appears, but no explicit test-runner invocation (your stack's test command, or a test job) was matched — the gate may be running tests, or "test" may be incidental (a path, "latest", a reporter). Make the test step explicit so the gate is unambiguous.
A CI pipeline exists but no build/compile invocation (a build step for your stack — dotnet build, npm run build, go build, mvn package, cargo build, …) was matched — changes may merge without being compiled.
What to do
Run the test suite in CI via an explicit runner step (`vendor/bin/phpunit` for the toolchain this pipeline already uses) and gate merges on it.
Add an explicit build/compile step to your CI pipeline (whatever your stack uses — e.g. dotnet build, npm run build, go build, mvn package, swift build/xcodebuild) so every change is compiled before merge.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
No static application security testing detected. For this repository's stack, add phpstan or psalm (or `semgrep --config=auto`, which runs on any language) as a CI step.
What to do
Add a SAST step to CI running what this repository's stack ships: phpstan or psalm — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.
Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.
Do you agree with this assessment?
R1 · Type Safety0.0 / 10Critical✓ Tool-verified
React / JS · Code Health — How much of the frontend is typed TypeScript vs untyped JavaScript.
Method: Frontend file inventory: the share of typed TypeScript vs untyped JavaScript across the source tree. Deterministic, exhaustive over frontend files.
0 typed · 183 plain JS
What to do
Migrate the remaining .js/.jsx files to TypeScript.
React / JS · Code Health — Per-function cyclomatic/cognitive complexity from the token-level function scanner (D-386) — real branching, not a regex heuristic.
Method: Per-function cyclomatic/cognitive complexity from a token-level function scanner (real branching, not a regex heuristic), computed over every frontend function. Deterministic.
Branch-heavy code is where defects cluster — extract decisions into smaller functions. (×8) — PHUIXAutocomplete.js:428, behavior-phabricator-remarkup-assist.js:188, WorkboardBoard.js:601, …
What to do
Break down the listed branch-heavy functions; aim P95 cyclomatic ≤ 5.
Do you agree with this assessment?
R3 · Large Files8.3 / 10Strong✓ Tool-verified
React / JS · Code Health — How many components/modules exceed the large-file threshold.
Method: Components/modules exceeding the large-file threshold, counted exhaustively across the frontend source tree. Deterministic.
What to do
Split the oversized components into smaller, focused ones.
Do you agree with this assessment?
R4 · Test Coverage0.0 / 10Critical✓ Tool-verified
React / JS · Readiness — Static test reachability (D-386): the share of production files reachable from any test via the import graph — measured without running anything.
Method: Static test reachability: the share of production files reachable from any test via the import graph — measured without running anything. Deterministic.
No test imports this module directly or transitively — its behavior is unverified. (×8) — DiffChangesetList.js, DiffInline.js, DiffChangeset.js, …
What to do
Add tests that import the unreached modules (directly or through their public entry).
Do you agree with this assessment?
R7 · Dead Code10.0 / 10Exemplary✓ Tool-verified
React / JS · Code Health — Files unreachable from every application/tooling/test entry point, and exports nothing imports (module-graph reachability, D-386).
Method: Dead code: files unreachable from every application/tooling/test entry point plus exports nothing imports, via module-graph reachability. Deterministic, exhaustive over the import graph.
183 file(s) (~29748 LoC) were excluded from dead-code analysis — declare main/module/exports or a conventional entry (src/index.*, an index.html script) so reachability can see this package.
React / JS · Readiness — npm dependency truthfulness (D-386): unused dependencies, imports not declared anywhere, and type-/test-only packages shipped as production deps.
Method: npm dependency truthfulness: unused dependencies, imports declared nowhere, and type-/test-only packages shipped as production deps — from the manifest + import graph. Deterministic.
Imported but not declared in any reachable package.json — installs work only by hoisting accident. — aphlict_server.js:76
What to do
Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies.
React / JS · Architecture — Import cycles in the module graph (D-386) — files that can only be understood and changed together.
Method: Import cycles in the module graph, detected exhaustively over JS/TS imports (the same cycle detection as the .NET coupling dimension). Deterministic.
Do you agree with this assessment?
Reference — by lens
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Not included — 78 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
AX1 Captive dependencies — no DI registrations detected
AX10 Code composition — not assessed — code composition is computed by ROLE over the .NET document set and none was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository
AX2 Stateful singletons — no singleton implementations detected
AX3 Project dependency cycles — not assessed — project cycles and dependency direction are computed over the .NET project-reference graph and none was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository
AX4 Dependency direction — not assessed — project cycles and dependency direction are computed over the .NET project-reference graph and none was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository
AX5 Architecture & structure — not assessed — architecture style/structure is computed from the .NET project graph (projects, types, namespaces) and no such graph was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository
AX6 Interface segregation — not assessed — interface segregation is computed over the .NET type surface and none was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — not assessed — test isolation is computed from the .NET project graph (which projects are test projects, and what they reference) and no such graph was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
C1 Data Protection — Not assessed: these personal data controls are read from C# source (attributes, middleware, entity/column names, guard methods) and no C# source was loaded for this repository — because it is written in another language, or the solution failed to load. Absence of a .NET idiom is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C2 Access Controls — Not assessed: these authorization controls are read from C# source (attributes, middleware, entity/column names, guard methods) and no C# source was loaded for this repository — because it is written in another language, or the solution failed to load. Absence of a .NET idiom is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C3 Audit Trail — Not assessed: these audit controls are read from C# source (attributes, middleware, entity/column names, guard methods) and no C# source was loaded for this repository — because it is written in another language, or the solution failed to load. Absence of a .NET idiom is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C4 Data Retention — Not assessed: these retention controls are read from C# source (attributes, middleware, entity/column names, guard methods) and no C# source was loaded for this repository — because it is written in another language, or the solution failed to load. Absence of a .NET idiom is NOT evidence that this repository lacks retention controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C5 Data-Subject Rights — Not assessed: these data-subject rights controls are read from C# source (attributes, middleware, entity/column names, guard methods) and no C# source was loaded for this repository — because it is written in another language, or the solution failed to load. Absence of a .NET idiom is NOT evidence that this repository lacks data-subject rights controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
D10 Test Quality — ~1590 lines of test source are present (.php, .js) but the test-quality collector reads C# only, so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
D11 Test Reliability — Test reliability not included
D12 Dependency Hygiene — Dependency hygiene not measured — no supported dependency manifest was read
D14 License Compliance — Not scored — this repository's package manifest is not parsed for licence data yet. A gap in the analyzer's language coverage, NOT a finding that the repository's licenses are compliant (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems)), which this pass does not parse yet — so this dimension asserts nothing about this repository's licensing in either direction.
D16 Bus Factor — dormant codebase — no living knowledge left to concentrate
D17 Explicit Debt — explicit-debt markers are read through a C# workspace today, so they were not read for this repository's language — this asserts nothing about how many markers the code carries. Not scored — this is a gap in the analyzer, not a finding about this repository
D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
D19 Documentation Quality — LLM evaluation failed
D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
D22 Internal API Consistency — No exposed public API
D23 Boundary Type-Coupling — Production source is present (.php) but bounded contexts are resolved over the C#/VB project set, which exposed none, so context scope could not be assessed. Not scored — this is a gap in the analyzer, not a verdict about this repository. Declaring the codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed — see the recommendation on this dimension for where. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["Acme.Billing"]`, `Catalog: ["Acme.Catalog"]`.
D24 Comment Value — No inline comments to assess — comment value is not applicable here.
D25 ADR Conformance — no ADRs to check
D26 Project Cohesion — Project cohesion is assessed over the .NET project set; this target exposed no projects, so project size and spread could not be assessed. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
D27 Navigability — No calls could be sampled, so navigability was not assessed — tracing effort is measured over resolved call sites and this target exposed none. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
D30 Dependency Vulnerabilities — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet) — where an OSV-supported manifest exists, dependency vulnerabilities for this repository are reported under D38 instead.
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Terraform, Kubernetes/Helm, CloudFormation); nothing to scan.
D32 Data Compliance (PII/GDPR) — No PII/GDPR ruleset is bundled (the public p/gdpr semgrep pack was retired) — data compliance is not assessed in this scan.
D33 JS/npm Dependency Vulnerabilities — No JS/npm manifest or lockfile found outside build output (package.json, package-lock.json, yarn.lock, pnpm-lock.yaml, bun.lockb); no JS dependencies to scan.
D36 Supply-chain Provenance & Signing — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .gitlab-ci.yml, azure-pipelines.yml, Jenkinsfile, .circleci); there is no build to attest provenance for.
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D38 OSV Dependency Vulnerabilities — No supported non-.NET dependency lockfile found outside build output (npm package-lock/yarn/pnpm/bun, Go go.mod, Rust Cargo.lock, Maven pom.xml, Gradle lockfiles, Python requirements.txt/poetry.lock/Pipfile.lock/pdm.lock, PHP composer.lock, Ruby Gemfile.lock, Elixir mix.lock, Dart pubspec.lock, Swift Package.resolved); nothing for OSV to scan. A NuGet-only repo stays NotApplicable — .NET CVEs are D30's domain.
D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D5 Coupling — Inter-project coupling could not be assessed — no analyzable project graph was found for this repository. Not scored: a gap in the analyzer's reach, not a verdict about this repository. (Coupling here is Martin afferent/efferent/instability plus reference cycles across a project-reference graph, read today from .NET project files; other ecosystems' module graphs are not read yet.)
D6 Cohesion (LCOM4) — Cohesion (LCOM4) is measured over a C#/VB class graph, and this repository's production source is .php, which this pass does not read — so no class could be assessed. Not scored — this is a gap in the analyzer, not a finding about this repository.
D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
D8 Code Coverage — Coverage not included — suite not readable by the collector
D9 Test Distribution — Test source is present (.php, .js) but the test-pyramid classifier reads C# only, so its unit/integration/BDD/E2E split couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
DM1 Domain Modelling — not run — 0/3 markers found
ED1 Event-Driven — not run — 0/3 markers found
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not run — 0/3 markers found
GD1 Unfinished & placeholder code — no source files
IC1 Incompleteness & stubs — not analysed — these correctness checks are read from C# source and none was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository
P12 CI test-gate honesty — no data
P2 Observability — Observability was not assessed: this check reads .NET source (ILogger/Serilog, OpenTelemetry, health checks) and no such source carries this repository's product — because it is written in another language, or because the solution failed to load. Absence of a .NET logging idiom is NOT evidence that this repo lacks structured logging (it may log through its own ecosystem's logger). This is a gap in the analyzer, not a finding about this repository.
P4 Deployment & Rollback — not evidenced — no deploy/rollback/approval signal in the repo; absence of evidence is not evidence of a manual release
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
P7 Outbound HTTP resilience — not applicable — this isn't a service/API/worker
P8 Schema migrations — not assessed — schema-migration practice is read from EF Core usage in .NET source and none was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Clover XML — `vendor/bin/phpunit --coverage-clover coverage.xml`) into the repo working tree before the scan — a CI step is the usual place, since the artefact is commonly gitignored, or wire coverage collection into CI, to enable this cross-layer check
PF1 Benchmark discipline — Performance was not assessed: this lens reads .NET source (allocation-aware APIs — Span/Memory, ArrayPool/ObjectPool, stackalloc — and a BenchmarkDotNet suite) and no such source was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
PF2 Allocation hygiene — Performance was not assessed: this lens reads .NET source (allocation-aware APIs — Span/Memory, ArrayPool/ObjectPool, stackalloc — and a BenchmarkDotNet suite) and no such source was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
PF3 Async & latency hygiene — Performance was not assessed: this lens reads .NET source (allocation-aware APIs — Span/Memory, ArrayPool/ObjectPool, stackalloc — and a BenchmarkDotNet suite) and no such source was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
R11 Import Boundaries — No recognizable feature-sliced/layered src layout — boundary rules not applicable.
R5 Dependency Freshness — no package-lock.json — dependency freshness not measured (would require an npm lockfile); JS/npm CVEs are scored in D33 (JS/npm Dependency Vulnerabilities)
R6 Tooling — no package.json in the repository — test/lint/typecheck wiring is read from package.json scripts (corroborated against CI), so this project's own toolchain isn't measured here
S1 Web-Security Posture — Not assessed: these web-security controls are read from C# source (attributes, middleware, entity/column names, guard methods) and no C# source was loaded for this repository — because it is written in another language, or the solution failed to load. Absence of a .NET idiom is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
X1 Async correctness — not analysed — these correctness checks are read from C# source and none was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository
X2 Cancellation propagation — not analysed — these correctness checks are read from C# source and none was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository
X3 Exception handling — not analysed — these correctness checks are read from C# source and none was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository
X4 Structured logging — not analysed — these correctness checks are read from C# source and none was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository
X5 Nullable reference types — not analysed — these correctness checks are read from C# source and none was loaded for this repository, because it is written in another language or the solution failed to load. This is a gap in the analyzer, not a finding about this repository
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
High: insecure-use-string-copy-fn externals/figlet/chkfont.c:86— Finding triggers whenever there is a strcpy or strncpy used. This is an issue because strcpy does not affirm the size of the destination array and strncpy will not automatically NULL-terminate strings. This can lead to buffer overflows, which can cause program crashes and potentially let an attacker inject code in the program. Fix this by using strcpy_s instead (although note that strcpy_s is an optional part of the C11 standard, and so may not be available). This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
FileTooLong: diff/DiffChangesetList.js webroot/rsrc/js/application/diff/DiffChangesetList.js:0— FileTooLong — 1689 significant lines (blank, comment-only and punctuation-only lines excluded; the length bar is tripled for a single-responsibility module of 4 or fewer top-level units).
Change coupling: PhabricatorInlineComment.php ↔ DiffInline.js src/infrastructure/diff/interface/PhabricatorInlineComment.php— `src/infrastructure/diff/interface/PhabricatorInlineComment.php` and `webroot/rsrc/js/application/diff/DiffInline.js` change together 90% of the time (9 of the 10 commits that touched the less-changed of the two, renames followed) with no explicit dependency — a hidden/logical coupling. If they belong together, co-locate them; if not, break the coupling.
Change coupling: PHUIDiffInlineCommentView.php ↔ DiffInline.js src/infrastructure/diff/view/PHUIDiffInlineCommentView.php— `src/infrastructure/diff/view/PHUIDiffInlineCommentView.php` and `webroot/rsrc/js/application/diff/DiffInline.js` change together 64% of the time (9 of the 14 commits that touched the less-changed of the two, renames followed) with no explicit dependency — a hidden/logical coupling. If they belong together, co-locate them; if not, break the coupling.
Change coupling: DifferentialChangesetParser.php ↔ DifferentialChangesetTestRenderer.php src/applications/differential/parser/DifferentialChangesetParser.php— `src/applications/differential/parser/DifferentialChangesetParser.php` and `src/applications/differential/render/DifferentialChangesetTestRenderer.php` change together 64% of the time (7 of the 11 commits that touched the less-changed of the two, renames followed) with no explicit dependency — a hidden/logical coupling. If they belong together, co-locate them; if not, break the coupling.
Change coupling: PhabricatorInlineComment.php ↔ PHUIDiffInlineCommentEditView.php src/infrastructure/diff/interface/PhabricatorInlineComment.php— `src/infrastructure/diff/interface/PhabricatorInlineComment.php` and `src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php` change together 50% of the time (5 of the 10 commits that touched the less-changed of the two, renames followed) with no explicit dependency — a hidden/logical coupling. If they belong together, co-locate them; if not, break the coupling.
PhabricatorAuthRegisterController.handleRequest (cyclomatic 88) src/applications/auth/controller/PhabricatorAuthRegisterController.php:10— PhabricatorAuthRegisterController.handleRequest has cyclomatic complexity 88 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialChangesetParser.render (cyclomatic 65) src/applications/differential/parser/DifferentialChangesetParser.php:749— DifferentialChangesetParser.render has cyclomatic complexity 65 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhutilSearchQueryCompiler.tokenizeQuery (cyclomatic 62) src/applications/search/compiler/PhutilSearchQueryCompiler.php:104— PhutilSearchQueryCompiler.tokenizeQuery has cyclomatic complexity 62 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HarbormasterBuildLogRenderController.handleRequest (cyclomatic 60) src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php:10— HarbormasterBuildLogRenderController.handleRequest has cyclomatic complexity 60 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialRevisionViewController.handleRequest (cyclomatic 57) src/applications/differential/controller/DifferentialRevisionViewController.php:43— DifferentialRevisionViewController.handleRequest has cyclomatic complexity 57 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialChangesetHTMLRenderer.renderChangeTypeHeader (cyclomatic 57) src/applications/differential/render/DifferentialChangesetHTMLRenderer.php:21— DifferentialChangesetHTMLRenderer.renderChangeTypeHeader has cyclomatic complexity 57 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
PhabricatorRepositorySvnCommitChangeParserWorker.parseCommitChanges (cyclomatic 54) src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php:6— PhabricatorRepositorySvnCommitChangeParserWorker.parseCommitChanges has cyclomatic complexity 54 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialChangesetTwoUpRenderer.renderTextChange (cyclomatic 52) src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php:31— DifferentialChangesetTwoUpRenderer.renderTextChange has cyclomatic complexity 52 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorCalendarImportEngine.importEventDocument (cyclomatic 51) src/applications/calendar/import/PhabricatorCalendarImportEngine.php:55— PhabricatorCalendarImportEngine.importEventDocument has cyclomatic complexity 51 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorApplicationSearchController.processSearchRequest (cyclomatic 51) src/applications/search/controller/PhabricatorApplicationSearchController.php:95— PhabricatorApplicationSearchController.processSearchRequest has cyclomatic complexity 51 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorApplicationTransactionEditor.applyTransactions (cyclomatic 50) src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1175— PhabricatorApplicationTransactionEditor.applyTransactions has cyclomatic complexity 50 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorRepositoryMercurialCommitChangeParserWorker.parseCommitChanges (cyclomatic 49) src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryMercurialCommitChangeParserWorker.php:6— PhabricatorRepositoryMercurialCommitChangeParserWorker.parseCommitChanges has cyclomatic complexity 49 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionCommitQuery.buildWhereClauseParts (cyclomatic 48) src/applications/diffusion/query/DiffusionCommitQuery.php:534— DiffusionCommitQuery.buildWhereClauseParts has cyclomatic complexity 48 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionCommitController.handleRequest (cyclomatic 47) src/applications/diffusion/controller/DiffusionCommitController.php:17— DiffusionCommitController.handleRequest has cyclomatic complexity 47 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorProfileMenuEngine.buildResponse (cyclomatic 47) src/applications/search/engine/PhabricatorProfileMenuEngine.php:102— PhabricatorProfileMenuEngine.buildResponse has cyclomatic complexity 47 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHUIDiffInlineCommentDetailView.render (cyclomatic 46) src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php:78— PHUIDiffInlineCommentDetailView.render has cyclomatic complexity 46 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHUIObjectItemView.getTagContent (cyclomatic 46) src/view/phui/PHUIObjectItemView.php:383— PHUIObjectItemView.getTagContent has cyclomatic complexity 46 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HeraldAdapter.doesConditionMatch (cyclomatic 43) src/applications/herald/adapter/HeraldAdapter.php:444— HeraldAdapter.doesConditionMatch has cyclomatic complexity 43 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorConfigSchemaSpec.getDetailsForDataType (cyclomatic 42) src/applications/config/schema/PhabricatorConfigSchemaSpec.php:269— PhabricatorConfigSchemaSpec.getDetailsForDataType has cyclomatic complexity 42 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
PhabricatorInlineCommentAdjustmentEngine.execute (cyclomatic 42) src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php:60— PhabricatorInlineCommentAdjustmentEngine.execute has cyclomatic complexity 42 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionServeController.serveRequest (cyclomatic 41) src/applications/diffusion/controller/DiffusionServeController.php:176— DiffusionServeController.serveRequest has cyclomatic complexity 41 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AphrontTableView.render (cyclomatic 41) src/view/control/AphrontTableView.php:131— AphrontTableView.render has cyclomatic complexity 41 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionURIEditor.validateTransaction (cyclomatic 40) src/applications/diffusion/editor/DiffusionURIEditor.php:156— DiffusionURIEditor.validateTransaction has cyclomatic complexity 40 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorManiphestTaskFactEngine.newDatapointsForObject (cyclomatic 39) src/applications/fact/engine/PhabricatorManiphestTaskFactEngine.php:86— PhabricatorManiphestTaskFactEngine.newDatapointsForObject has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorRepositoryManagementReparseWorkflow.execute (cyclomatic 39) src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php:81— PhabricatorRepositoryManagementReparseWorkflow.execute has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorEditEngine.buildEditResponse (cyclomatic 39) src/applications/transactions/editengine/PhabricatorEditEngine.php:1033— PhabricatorEditEngine.buildEditResponse has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorWorkerManagementWorkflow.loadTasks (cyclomatic 39) src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementWorkflow.php:69— PhabricatorWorkerManagementWorkflow.loadTasks has cyclomatic complexity 39 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialChangesetViewController.handleRequest (cyclomatic 38) src/applications/differential/controller/DifferentialChangesetViewController.php:9— DifferentialChangesetViewController.handleRequest has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionRepositoryBasicsManagementPanel.buildRepositoryStatus (cyclomatic 38) src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:336— DiffusionRepositoryBasicsManagementPanel.buildRepositoryStatus has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorFilesManagementIntegrityWorkflow.execute (cyclomatic 38) src/applications/files/management/PhabricatorFilesManagementIntegrityWorkflow.php:53— PhabricatorFilesManagementIntegrityWorkflow.execute has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorSearchManagementIndexWorkflow.execute (cyclomatic 38) src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php:74— PhabricatorSearchManagementIndexWorkflow.execute has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorController.willBeginExecution (cyclomatic 37) src/applications/base/controller/PhabricatorController.php:64— PhabricatorController.willBeginExecution has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhutilCalendarRecurrenceRule.newDaysSet (cyclomatic 35) src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php:1178— PhutilCalendarRecurrenceRule.newDaysSet has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorEditEngineConfigurationQuery.loadPage (cyclomatic 35) src/applications/transactions/query/PhabricatorEditEngineConfigurationQuery.php:71— PhabricatorEditEngineConfigurationQuery.loadPage has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorConduitAPIController.authenticateUser (cyclomatic 34) src/applications/conduit/controller/PhabricatorConduitAPIController.php:167— PhabricatorConduitAPIController.authenticateUser has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialChangesetOneUpRenderer.renderDocumentEngineBlocks (cyclomatic 34) src/applications/differential/render/DifferentialChangesetOneUpRenderer.php:270— DifferentialChangesetOneUpRenderer.renderDocumentEngineBlocks has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ConpherenceThreadSearchEngine.loadContextMessages (cyclomatic 33) src/applications/conpherence/query/ConpherenceThreadSearchEngine.php:233— ConpherenceThreadSearchEngine.loadContextMessages has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorFactObjectController.handleRequest (cyclomatic 33) src/applications/fact/controller/PhabricatorFactObjectController.php:6— PhabricatorFactObjectController.handleRequest has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorInlineCommentController.processRequest (cyclomatic 33) src/infrastructure/diff/PhabricatorInlineCommentController.php:93— PhabricatorInlineCommentController.processRequest has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ConpherenceUpdateController.handleRequest (cyclomatic 32) src/applications/conpherence/controller/ConpherenceUpdateController.php:6— ConpherenceUpdateController.handleRequest has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhortunePaymentMethodCreateController.handleRequest (cyclomatic 32) src/applications/phortune/controller/paymentmethod/PhortunePaymentMethodCreateController.php:6— PhortunePaymentMethodCreateController.handleRequest has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorProjectBoardViewController.handleRequest (cyclomatic 32) src/applications/project/controller/PhabricatorProjectBoardViewController.php:10— PhabricatorProjectBoardViewController.handleRequest has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorProjectColumnBulkMoveController.handleRequest (cyclomatic 32) src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php:6— PhabricatorProjectColumnBulkMoveController.handleRequest has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorRepositoryManagementThawWorkflow.execute (cyclomatic 32) src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php:49— PhabricatorRepositoryManagementThawWorkflow.execute has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorEditEngine.buildResponse (cyclomatic 32) src/applications/transactions/editengine/PhabricatorEditEngine.php:882— PhabricatorEditEngine.buildResponse has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorEditEngine.buildCommentResponse (cyclomatic 32) src/applications/transactions/editengine/PhabricatorEditEngine.php:1875— PhabricatorEditEngine.buildCommentResponse has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorAuthManagementStripWorkflow.execute (cyclomatic 31) src/applications/auth/management/PhabricatorAuthManagementStripWorkflow.php:54— PhabricatorAuthManagementStripWorkflow.execute has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorRepositoryQuery.willFilterPage (cyclomatic 31) src/applications/repository/query/PhabricatorRepositoryQuery.php:236— PhabricatorRepositoryQuery.willFilterPage has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorAphlictManagementWorkflow.parseLaunchArguments (cyclomatic 30) src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php:27— PhabricatorAphlictManagementWorkflow.parseLaunchArguments has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorAuthSessionEngine.newHighSecurityToken (cyclomatic 30) src/applications/auth/engine/PhabricatorAuthSessionEngine.php:446— PhabricatorAuthSessionEngine.newHighSecurityToken has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialChangesetEngine.detectCopiedCode (cyclomatic 30) src/applications/differential/engine/DifferentialChangesetEngine.php:162— DifferentialChangesetEngine.detectCopiedCode has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionCommitHookEngine.findMercurialChangegroupRefUpdates (cyclomatic 30) src/applications/diffusion/engine/DiffusionCommitHookEngine.php:743— DiffusionCommitHookEngine.findMercurialChangegroupRefUpdates has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HeraldAdapter.willSaveCondition (cyclomatic 30) src/applications/herald/adapter/HeraldAdapter.php:613— HeraldAdapter.willSaveCondition has cyclomatic complexity 30 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
LegalpadDocumentSignController.handleRequest (cyclomatic 30) src/applications/legalpad/controller/LegalpadDocumentSignController.php:24— LegalpadDocumentSignController.handleRequest has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ManiphestReportController.renderBurn (cyclomatic 30) src/applications/maniphest/controller/ManiphestReportController.php:74— ManiphestReportController.renderBurn has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ManiphestReportController.renderOpenTasks (cyclomatic 30) src/applications/maniphest/controller/ManiphestReportController.php:487— ManiphestReportController.renderOpenTasks has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ManiphestTransactionEditor.buildMoveTransaction (cyclomatic 30) src/applications/maniphest/editor/ManiphestTransactionEditor.php:438— ManiphestTransactionEditor.buildMoveTransaction has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorApplicationQuery.loadPage (cyclomatic 30) src/applications/meta/query/PhabricatorApplicationQuery.php:71— PhabricatorApplicationQuery.loadPage has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhortunePayPalPaymentProvider.processControllerRequest (cyclomatic 30) src/applications/phortune/provider/PhortunePayPalPaymentProvider.php:287— PhortunePayPalPaymentProvider.processControllerRequest has cyclomatic complexity 30 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
PhabricatorCursorPagedPolicyAwareQuery.buildFerretWhereClause (cyclomatic 30) src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:2208— PhabricatorCursorPagedPolicyAwareQuery.buildFerretWhereClause has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHUIHeaderView.getTagContent (cyclomatic 30) src/view/phui/PHUIHeaderView.php:190— PHUIHeaderView.getTagContent has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
_update (cyclomatic 30) webroot/rsrc/js/phuix/PHUIXAutocomplete.js:428— _update has cyclomatic complexity 30 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
PhabricatorCalendarEventQuery.willFilterPage (cyclomatic 29) src/applications/calendar/query/PhabricatorCalendarEventQuery.php:515— PhabricatorCalendarEventQuery.willFilterPage has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionBrowseQueryConduitAPIMethod.getGitResult (cyclomatic 29) src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php:35— DiffusionBrowseQueryConduitAPIMethod.getGitResult has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PassphraseCredentialEditController.handleRequest (cyclomatic 29) src/applications/passphrase/controller/PassphraseCredentialEditController.php:5— PassphraseCredentialEditController.handleRequest has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorProjectQuery.buildWhereClauseParts (cyclomatic 29) src/applications/project/query/PhabricatorProjectQuery.php:457— PhabricatorProjectQuery.buildWhereClauseParts has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorApplicationTransactionView.renderEvent (cyclomatic 29) src/applications/transactions/view/PhabricatorApplicationTransactionView.php:422— PhabricatorApplicationTransactionView.renderEvent has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorTypeaheadModularDatasourceController.handleRequest (cyclomatic 29) src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php:10— PhabricatorTypeaheadModularDatasourceController.handleRequest has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
assist (cyclomatic 29) webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js:188— assist has cyclomatic complexity 29 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
PhutilSpriteSheet.generate (cyclomatic 28) src/aphront/sprite/PhutilSpriteSheet.php:57— PhutilSpriteSheet.generate has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorCalendarNotificationEngine.sendNotifications (cyclomatic 28) src/applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php:73— PhabricatorCalendarNotificationEngine.sendNotifications has cyclomatic complexity 28 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
DoorkeeperAsanaFeedWorker.publishFeedStory (cyclomatic 28) src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php:27— DoorkeeperAsanaFeedWorker.publishFeedStory has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorMailManagementShowOutboundWorkflow.execute (cyclomatic 28) src/applications/metamta/management/PhabricatorMailManagementShowOutboundWorkflow.php:29— PhabricatorMailManagementShowOutboundWorkflow.execute has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorPeopleNewController.handleRequest (cyclomatic 28) src/applications/people/controller/PhabricatorPeopleNewController.php:6— PhabricatorPeopleNewController.handleRequest has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhrictionDocumentController.handleRequest (cyclomatic 28) src/applications/phriction/controller/PhrictionDocumentController.php:13— PhrictionDocumentController.handleRequest has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorBoardLayoutEngine.layoutBoard (cyclomatic 28) src/applications/project/engine/PhabricatorBoardLayoutEngine.php:419— PhabricatorBoardLayoutEngine.layoutBoard has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhutilRemarkupListBlockRule.renderTree (cyclomatic 28) src/infrastructure/markup/blockrule/PhutilRemarkupListBlockRule.php:428— PhutilRemarkupListBlockRule.renderTree has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorPolicyAwareQuery.execute (cyclomatic 28) src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php:204— PhabricatorPolicyAwareQuery.execute has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHUITimelineEventView.render (cyclomatic 28) src/view/phui/PHUITimelineEventView.php:318— PHUITimelineEventView.render has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorAuditManagementDeleteWorkflow.execute (cyclomatic 27) src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php:62— PhabricatorAuditManagementDeleteWorkflow.execute has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorAuthStartController.handleRequest (cyclomatic 27) src/applications/auth/controller/PhabricatorAuthStartController.php:10— PhabricatorAuthStartController.handleRequest has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorAuthEditController.handleRequest (cyclomatic 27) src/applications/auth/controller/config/PhabricatorAuthEditController.php:6— PhabricatorAuthEditController.handleRequest has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorWebServerSetupCheck.executeChecks (cyclomatic 27) src/applications/config/check/PhabricatorWebServerSetupCheck.php:9— PhabricatorWebServerSetupCheck.executeChecks has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialChangesetOneUpRenderer.renderPrimitives (cyclomatic 27) src/applications/differential/render/DifferentialChangesetOneUpRenderer.php:47— DifferentialChangesetOneUpRenderer.renderPrimitives has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HarbormasterBuildEngine.updateBuildSteps (cyclomatic 27) src/applications/harbormaster/engine/HarbormasterBuildEngine.php:165— HarbormasterBuildEngine.updateBuildSteps has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhutilXHPASTSyntaxHighlighterFuture.applyXHPHighlight (cyclomatic 27) src/infrastructure/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php:31— PhutilXHPASTSyntaxHighlighterFuture.applyXHPHighlight has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorCalendarEventQuery.loadPage (cyclomatic 26) src/applications/calendar/query/PhabricatorCalendarEventQuery.php:161— PhabricatorCalendarEventQuery.loadPage has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialHunkParser.parseHunksForHighlightMasks (cyclomatic 26) src/applications/differential/parser/DifferentialHunkParser.php:566— DifferentialHunkParser.parseHunksForHighlightMasks has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialReviewersView.render (cyclomatic 26) src/applications/differential/view/DifferentialReviewersView.php:26— DifferentialReviewersView.render has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionCommitController.buildPropertyListView (cyclomatic 26) src/applications/diffusion/controller/DiffusionCommitController.php:524— DiffusionCommitController.buildPropertyListView has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DivinerAtomController.handleRequest (cyclomatic 26) src/applications/diviner/controller/DivinerAtomController.php:9— DivinerAtomController.handleRequest has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MultimeterSampleController.handleRequest (cyclomatic 26) src/applications/multimeter/controller/MultimeterSampleController.php:9— MultimeterSampleController.handleRequest has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorObjectListQuery.execute (cyclomatic 26) src/applications/phid/query/PhabricatorObjectListQuery.php:56— PhabricatorObjectListQuery.execute has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorApplicationTransactionEditor.getTransactionOldValue (cyclomatic 26) src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:490— PhabricatorApplicationTransactionEditor.getTransactionOldValue has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorDifferenceEngine.applyIntralineDiff (cyclomatic 26) src/infrastructure/diff/PhabricatorDifferenceEngine.php:172— PhabricatorDifferenceEngine.applyIntralineDiff has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHUIDiffTableOfContentsListView.render (cyclomatic 26) src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php:53— PHUIDiffTableOfContentsListView.render has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorCursorPagedPolicyAwareQuery.buildSpacesWhereClause (cyclomatic 26) src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:3139— PhabricatorCursorPagedPolicyAwareQuery.buildSpacesWhereClause has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
updateCard (cyclomatic 26) webroot/rsrc/js/application/projects/WorkboardBoard.js:601— updateCard has cyclomatic complexity 26 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
Text_Figlet.loadFont (cyclomatic 25) externals/pear-figlet/Text/Figlet.php:111— Text_Figlet.loadFont has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorAuthManagementRevokeWorkflow.execute (cyclomatic 25) src/applications/auth/management/PhabricatorAuthManagementRevokeWorkflow.php:50— PhabricatorAuthManagementRevokeWorkflow.execute has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhutilCalendarRecurrenceSet.getEventsBetween (cyclomatic 25) src/applications/calendar/parser/data/PhutilCalendarRecurrenceSet.php:23— PhutilCalendarRecurrenceSet.getEventsBetween has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialHunkParser.makeContextDiff (cyclomatic 25) src/applications/differential/parser/DifferentialHunkParser.php:665— DifferentialHunkParser.makeContextDiff has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DivinerAtomQuery.willFilterPage (cyclomatic 25) src/applications/diviner/query/DivinerAtomQuery.php:139— DivinerAtomQuery.willFilterPage has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorFeedStory.loadAllFromRows (cyclomatic 25) src/applications/feed/story/PhabricatorFeedStory.php:41— PhabricatorFeedStory.loadAllFromRows has cyclomatic complexity 25 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PholioMockEditController.handleRequest (cyclomatic 25) src/applications/pholio/controller/PholioMockEditController.php:5— PholioMockEditController.handleRequest has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhrictionRemarkupRule.didMarkupText (cyclomatic 25) src/applications/phriction/markup/PhrictionRemarkupRule.php:86— PhrictionRemarkupRule.didMarkupText has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorPolicyEditController.handleRequest (cyclomatic 25) src/applications/policy/controller/PhabricatorPolicyEditController.php:6— PhabricatorPolicyEditController.handleRequest has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorPolicyFilter.apply (cyclomatic 25) src/applications/policy/filter/PhabricatorPolicyFilter.php:156— PhabricatorPolicyFilter.apply has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorRepositoryQuery.buildWhereClauseParts (cyclomatic 25) src/applications/repository/query/PhabricatorRepositoryQuery.php:533— PhabricatorRepositoryQuery.buildWhereClauseParts has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorFerretFulltextEngineExtension.indexFulltextObject (cyclomatic 25) src/applications/search/engineextension/PhabricatorFerretFulltextEngineExtension.php:19— PhabricatorFerretFulltextEngineExtension.indexFulltextObject has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHUIDiffGraphView.renderRawGraph (cyclomatic 25) src/infrastructure/diff/view/PHUIDiffGraphView.php:36— PHUIDiffGraphView.renderRawGraph has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorCursorPagedPolicyAwareQuery.buildFerretJoinClause (cyclomatic 25) src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:1995— PhabricatorCursorPagedPolicyAwareQuery.buildFerretJoinClause has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorActionView.render (cyclomatic 25) src/view/layout/PhabricatorActionView.php:198— PhabricatorActionView.render has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialQueryConduitAPIMethod.execute (cyclomatic 24) src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php:65— DifferentialQueryConduitAPIMethod.execute has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionBrowseQueryConduitAPIMethod.getSVNResult (cyclomatic 24) src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php:363— DiffusionBrowseQueryConduitAPIMethod.getSVNResult has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionCommitQuery.didFilterPage (cyclomatic 24) src/applications/diffusion/query/DiffusionCommitQuery.php:361— DiffusionCommitQuery.didFilterPage has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HarbormasterBuildViewController.handleRequest (cyclomatic 24) src/applications/harbormaster/controller/HarbormasterBuildViewController.php:10— HarbormasterBuildViewController.handleRequest has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HeraldEngine.getRuleMatchResult (cyclomatic 24) src/applications/herald/engine/HeraldEngine.php:379— HeraldEngine.getRuleMatchResult has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ManiphestTaskQuery.buildWhereClauseParts (cyclomatic 24) src/applications/maniphest/query/ManiphestTaskQuery.php:354— ManiphestTaskQuery.buildWhereClauseParts has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ManiphestTaskSearchEngine.buildQueryFromParameters (cyclomatic 24) src/applications/maniphest/query/ManiphestTaskSearchEngine.php:190— ManiphestTaskSearchEngine.buildQueryFromParameters has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorMetaMTAMailViewController.buildDeliveryProperties (cyclomatic 24) src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php:216— PhabricatorMetaMTAMailViewController.buildDeliveryProperties has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorMailEmailEngine.newMessage (cyclomatic 24) src/applications/metamta/engine/PhabricatorMailEmailEngine.php:6— PhabricatorMailEmailEngine.newMessage has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PassphraseQueryConduitAPIMethod.execute (cyclomatic 24) src/applications/passphrase/conduit/PassphraseQueryConduitAPIMethod.php:31— PassphraseQueryConduitAPIMethod.execute has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhrictionEditController.handleRequest (cyclomatic 24) src/applications/phriction/controller/PhrictionEditController.php:6— PhrictionEditController.handleRequest has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorPolicyFilter.checkCapability (cyclomatic 24) src/applications/policy/filter/PhabricatorPolicyFilter.php:499— PhabricatorPolicyFilter.checkCapability has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorProjectQuery.willFilterPage (cyclomatic 24) src/applications/project/query/PhabricatorProjectQuery.php:239— PhabricatorProjectQuery.willFilterPage has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorProjectSearchEngine.buildQueryFromParameters (cyclomatic 24) src/applications/project/query/PhabricatorProjectSearchEngine.php:130— PhabricatorProjectSearchEngine.buildQueryFromParameters has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorRepositoryPullLocalDaemon.run (cyclomatic 24) src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:38— PhabricatorRepositoryPullLocalDaemon.run has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorDatabaseRefParser.newRefs (cyclomatic 24) src/infrastructure/cluster/PhabricatorDatabaseRefParser.php:37— PhabricatorDatabaseRefParser.newRefs has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
_onjumpkey (cyclomatic 24) webroot/rsrc/js/application/diff/DiffChangesetList.js:650— _onjumpkey has cyclomatic complexity 24 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
AphrontMultipartParser.continueParse (cyclomatic 23) src/aphront/multipartparser/AphrontMultipartParser.php:62— AphrontMultipartParser.continueParse has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhutilICSParser.unescapeFieldValue (cyclomatic 23) src/applications/calendar/parser/ics/PhutilICSParser.php:386— PhutilICSParser.unescapeFieldValue has cyclomatic complexity 23 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
DifferentialTransactionEditor.didApplyHeraldRules (cyclomatic 23) src/applications/differential/editor/DifferentialTransactionEditor.php:1034— DifferentialTransactionEditor.didApplyHeraldRules has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialChangesetTwoUpRenderer.renderDocumentEngineBlocks (cyclomatic 23) src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php:367— DifferentialChangesetTwoUpRenderer.renderDocumentEngineBlocks has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionLowLevelResolveRefsQuery.resolveGitRefs (cyclomatic 23) src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php:60— DiffusionLowLevelResolveRefsQuery.resolveGitRefs has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DivinerAtomController.renderFullSignature (cyclomatic 23) src/applications/diviner/controller/DivinerAtomController.php:472— DivinerAtomController.renderFullSignature has cyclomatic complexity 23 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
PhabricatorFileViewController.buildPropertyViews (cyclomatic 23) src/applications/files/controller/PhabricatorFileViewController.php:218— PhabricatorFileViewController.buildPropertyViews has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorEmbedFileRemarkupRule.renderImageFile (cyclomatic 23) src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php:129— PhabricatorEmbedFileRemarkupRule.renderImageFile has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HeraldRuleQuery.willFilterPage (cyclomatic 23) src/applications/herald/query/HeraldRuleQuery.php:89— HeraldRuleQuery.willFilterPage has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ManiphestTaskDetailController.newChangesView (cyclomatic 23) src/applications/maniphest/controller/ManiphestTaskDetailController.php:545— ManiphestTaskDetailController.newChangesView has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorPeopleProfilePictureController.handleRequest (cyclomatic 23) src/applications/people/controller/PhabricatorPeopleProfilePictureController.php:6— PhabricatorPeopleProfilePictureController.handleRequest has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorProjectDatasource.loadResults (cyclomatic 23) src/applications/project/typeahead/PhabricatorProjectDatasource.php:18— PhabricatorProjectDatasource.loadResults has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorRepositoryGitCommitChangeParserWorker.parseCommitChanges (cyclomatic 23) src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php:6— PhabricatorRepositoryGitCommitChangeParserWorker.parseCommitChanges has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TransactionSearchConduitAPIMethod.execute (cyclomatic 23) src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php:102— TransactionSearchConduitAPIMethod.execute has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhutilRemarkupCodeBlockRule.markupText (cyclomatic 23) src/infrastructure/markup/blockrule/PhutilRemarkupCodeBlockRule.php:46— PhutilRemarkupCodeBlockRule.markupText has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AphrontDialogView.render (cyclomatic 23) src/view/AphrontDialogView.php:255— AphrontDialogView.render has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
(anonymous) (cyclomatic 23) webroot/rsrc/js/application/diffusion/behavior-commit-graph.js:8— (anonymous) has cyclomatic complexity 23 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
Porter.step2 (cyclomatic 22) externals/porter-stemmer/src/Porter.php:146— Porter.step2 has cyclomatic complexity 22 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
xhprof_lib.xhprof_aggregate_runs (cyclomatic 22) externals/xhprof/xhprof_lib.php:244— xhprof_lib.xhprof_aggregate_runs has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CelerityResourceController.serveResource (cyclomatic 22) src/applications/celerity/controller/CelerityResourceController.php:27— CelerityResourceController.serveResource has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorConfigEditController.handleRequest (cyclomatic 22) src/applications/config/controller/settings/PhabricatorConfigEditController.php:6— PhabricatorConfigEditController.handleRequest has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialChangesetParser.replaceTabsWithSpaces (cyclomatic 22) src/applications/differential/parser/DifferentialChangesetParser.php:1615— DifferentialChangesetParser.replaceTabsWithSpaces has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialRevisionQuery.buildWhereClause (cyclomatic 22) src/applications/differential/query/DifferentialRevisionQuery.php:630— DifferentialRevisionQuery.buildWhereClause has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialRevisionReviewersTransaction.renderReviewerEditTitle (cyclomatic 22) src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php:165— DifferentialRevisionReviewersTransaction.renderReviewerEditTitle has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DivinerAtomQuery.buildWhereClause (cyclomatic 22) src/applications/diviner/query/DivinerAtomQuery.php:302— DivinerAtomQuery.buildWhereClause has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ManiphestConduitAPIMethod.applyRequest (cyclomatic 22) src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php:53— ManiphestConduitAPIMethod.applyRequest has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorMailManagementSendTestWorkflow.execute (cyclomatic 22) src/applications/metamta/management/PhabricatorMailManagementSendTestWorkflow.php:72— PhabricatorMailManagementSendTestWorkflow.execute has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorPeopleInviteSendController.handleRequest (cyclomatic 22) src/applications/people/controller/PhabricatorPeopleInviteSendController.php:6— PhabricatorPeopleInviteSendController.handleRequest has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorApplicationSearchEngine.buildConduitResponse (cyclomatic 22) src/applications/search/engine/PhabricatorApplicationSearchEngine.php:1134— PhabricatorApplicationSearchEngine.buildConduitResponse has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorSlowvoteEditController.handleRequest (cyclomatic 22) src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php:6— PhabricatorSlowvoteEditController.handleRequest has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorApplicationTransactionEditor.getTransactionNewValue (cyclomatic 22) src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:588— PhabricatorApplicationTransactionEditor.getTransactionNewValue has cyclomatic complexity 22 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
PhutilRemarkupListBlockRule.markupText (cyclomatic 22) src/infrastructure/markup/blockrule/PhutilRemarkupListBlockRule.php:88— PhutilRemarkupListBlockRule.markupText has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Porter.step4 (cyclomatic 21) externals/porter-stemmer/src/Porter.php:240— Porter.step4 has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
PhutilCalendarRecurrenceRule.newYearMap (cyclomatic 21) src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php:1349— PhutilCalendarRecurrenceRule.newYearMap has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorConfigClusterRepositoriesController.buildClusterRepositoryStatus (cyclomatic 21) src/applications/config/controller/services/PhabricatorConfigClusterRepositoriesController.php:46— PhabricatorConfigClusterRepositoriesController.buildClusterRepositoryStatus has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorDashboardPanelTabsController.handleRequest (cyclomatic 21) src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php:17— PhabricatorDashboardPanelTabsController.handleRequest has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorDashboardTabsPanelType.renderPanelContent (cyclomatic 21) src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:46— PhabricatorDashboardTabsPanelType.renderPanelContent has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialTransactionEditor.expandTransaction (cyclomatic 21) src/applications/differential/editor/DifferentialTransactionEditor.php:152— DifferentialTransactionEditor.expandTransaction has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialTransactionEditor.updateReviewStatus (cyclomatic 21) src/applications/differential/editor/DifferentialTransactionEditor.php:403— DifferentialTransactionEditor.updateReviewStatus has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionSymbolController.handleRequest (cyclomatic 21) src/applications/diffusion/controller/DiffusionSymbolController.php:5— DiffusionSymbolController.handleRequest has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionGitUploadPackWireProtocol.willReadBytes (cyclomatic 21) src/applications/diffusion/protocol/DiffusionGitUploadPackWireProtocol.php:16— DiffusionGitUploadPackWireProtocol.willReadBytes has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionMercurialWireClientSSHProtocolChannel.decodeStream (cyclomatic 21) src/applications/diffusion/ssh/DiffusionMercurialWireClientSSHProtocolChannel.php:79— DiffusionMercurialWireClientSSHProtocolChannel.decodeStream has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorFileQuery.buildWhereClauseParts (cyclomatic 21) src/applications/files/query/PhabricatorFileQuery.php:396— PhabricatorFileQuery.buildWhereClauseParts has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HeraldAction.loadStandardTargets (cyclomatic 21) src/applications/herald/action/HeraldAction.php:206— HeraldAction.loadStandardTargets has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorMentionRemarkupRule.didMarkupText (cyclomatic 21) src/applications/people/markup/PhabricatorMentionRemarkupRule.php:57— PhabricatorMentionRemarkupRule.didMarkupText has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhrictionDocumentQuery.buildWhereClauseParts (cyclomatic 21) src/applications/phriction/query/PhrictionDocumentQuery.php:199— PhrictionDocumentQuery.buildWhereClauseParts has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorRepositoryPullEngine.pullRepositoryWithLock (cyclomatic 21) src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:51— PhabricatorRepositoryPullEngine.pullRepositoryWithLock has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorSearchHovercardController.handleRequest (cyclomatic 21) src/applications/search/controller/PhabricatorSearchHovercardController.php:10— PhabricatorSearchHovercardController.handleRequest has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorProfileMenuEngine.buildItemConfigureContent (cyclomatic 21) src/applications/search/engine/PhabricatorProfileMenuEngine.php:683— PhabricatorProfileMenuEngine.buildItemConfigureContent has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorSearchResultView.emboldenQuery (cyclomatic 21) src/applications/search/view/PhabricatorSearchResultView.php:59— PhabricatorSearchResultView.emboldenQuery has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorSubscriptionsHeraldAction.applySubscribe (cyclomatic 21) src/applications/subscriptions/herald/PhabricatorSubscriptionsHeraldAction.php:19— PhabricatorSubscriptionsHeraldAction.applySubscribe has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHUIDiffTableOfContentsListView.newComponentView (cyclomatic 21) src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php:387— PHUIDiffTableOfContentsListView.newComponentView has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorCursorPagedPolicyAwareQuery.buildPagingClauseFromMultipleColumns (cyclomatic 21) src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:727— PhabricatorCursorPagedPolicyAwareQuery.buildPagingClauseFromMultipleColumns has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorStandardPageView.willRenderPage (cyclomatic 21) src/view/page/PhabricatorStandardPageView.php:199— PhabricatorStandardPageView.willRenderPage has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
redraw (cyclomatic 21) webroot/rsrc/js/application/diff/DiffTreeView.js:87— redraw has cyclomatic complexity 21 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
Text_Figlet.lineEcho (cyclomatic 20) externals/pear-figlet/Text/Figlet.php:269— Text_Figlet.lineEcho has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Text_Figlet._rep (cyclomatic 20) externals/pear-figlet/Text/Figlet.php:390— Text_Figlet._rep has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHPMailerLite.WrapText (cyclomatic 20) externals/phpmailer/class.phpmailer-lite.php:785— PHPMailerLite.WrapText has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHPMailer.WrapText (cyclomatic 20) externals/phpmailer/class.phpmailer.php:916— PHPMailer.WrapText has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Porter.step1ab (cyclomatic 20) externals/porter-stemmer/src/Porter.php:83— Porter.step1ab has cyclomatic complexity 20 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
PhabricatorAuthOneTimeLoginController.handleRequest (cyclomatic 20) src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php:10— PhabricatorAuthOneTimeLoginController.handleRequest has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorEmailLoginController.handleRequest (cyclomatic 20) src/applications/auth/controller/PhabricatorEmailLoginController.php:10— PhabricatorEmailLoginController.handleRequest has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorAuthInviteAction.newActionListFromAddresses (cyclomatic 20) src/applications/auth/data/PhabricatorAuthInviteAction.php:94— PhabricatorAuthInviteAction.newActionListFromAddresses has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorAuthPasswordEngine.checkNewPassword (cyclomatic 20) src/applications/auth/engine/PhabricatorAuthPasswordEngine.php:57— PhabricatorAuthPasswordEngine.checkNewPassword has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorCalendarEventCancelController.handleRequest (cyclomatic 20) src/applications/calendar/controller/PhabricatorCalendarEventCancelController.php:6— PhabricatorCalendarEventCancelController.handleRequest has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhutilCalendarRecurrenceRule.advanceCursorState (cyclomatic 20) src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php:1685— PhutilCalendarRecurrenceRule.advanceCursorState has cyclomatic complexity 20 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
PhabricatorCalendarEventQuery.buildWhereClauseParts (cyclomatic 20) src/applications/calendar/query/PhabricatorCalendarEventQuery.php:357— PhabricatorCalendarEventQuery.buildWhereClauseParts has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorConduitAPIController.handleRequest (cyclomatic 20) src/applications/conduit/controller/PhabricatorConduitAPIController.php:10— PhabricatorConduitAPIController.handleRequest has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DarkConsoleServicesPlugin.generateData (cyclomatic 20) src/applications/console/plugin/DarkConsoleServicesPlugin.php:47— DarkConsoleServicesPlugin.generateData has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialGetCommitMessageConduitAPIMethod.execute (cyclomatic 20) src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php:34— DifferentialGetCommitMessageConduitAPIMethod.execute has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialTransactionEditor.buildMailBody (cyclomatic 20) src/applications/differential/editor/DifferentialTransactionEditor.php:662— DifferentialTransactionEditor.buildMailBody has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionController.buildCrumbList (cyclomatic 20) src/applications/diffusion/controller/DiffusionController.php:128— DiffusionController.buildCrumbList has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionLowLevelResolveRefsQuery.resolveMercurialRefs (cyclomatic 20) src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php:243— DiffusionLowLevelResolveRefsQuery.resolveMercurialRefs has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HarbormasterBuildEngine.updateBuildable (cyclomatic 20) src/applications/harbormaster/engine/HarbormasterBuildEngine.php:442— HarbormasterBuildEngine.updateBuildable has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ManiphestTaskStatus.validateConfiguration (cyclomatic 20) src/applications/maniphest/constants/ManiphestTaskStatus.php:261— ManiphestTaskStatus.validateConfiguration has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorPeopleTestDataGenerator.generateUsername (cyclomatic 20) src/applications/people/lipsum/PhabricatorPeopleTestDataGenerator.php:44— PhabricatorPeopleTestDataGenerator.generateUsername has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhortuneCartCheckoutController.handleCartRequest (cyclomatic 20) src/applications/phortune/controller/cart/PhortuneCartCheckoutController.php:14— PhortuneCartCheckoutController.handleCartRequest has cyclomatic complexity 20 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
PhabricatorBulkManagementExportWorkflow.newQueries (cyclomatic 20) src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php:152— PhabricatorBulkManagementExportWorkflow.newQueries has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHUIObjectBoxView.getTagContent (cyclomatic 20) src/view/phui/PHUIObjectBoxView.php:181— PHUIObjectBoxView.getTagContent has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHUIObjectItemView.getTagAttributes (cyclomatic 20) src/view/phui/PHUIObjectItemView.php:287— PHUIObjectItemView.getTagAttributes has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SMTP.Data (cyclomatic 19) externals/phpmailer/class.smtp.php:326— SMTP.Data has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AphrontHTTPHeaderParser.getHeaderContentAsPairs (cyclomatic 19) src/aphront/headerparser/AphrontHTTPHeaderParser.php:34— AphrontHTTPHeaderParser.getHeaderContentAsPairs has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhutilCalendarRecurrenceRule.resetSource (cyclomatic 19) src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php:566— PhutilCalendarRecurrenceRule.resetSource has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
PhabricatorBinariesSetupCheck.executeChecks (cyclomatic 19) src/applications/config/check/PhabricatorBinariesSetupCheck.php:9— PhabricatorBinariesSetupCheck.executeChecks has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorExtraConfigSetupCheck.executeChecks (cyclomatic 19) src/applications/config/check/PhabricatorExtraConfigSetupCheck.php:9— PhabricatorExtraConfigSetupCheck.executeChecks has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialChangesetRenderer.buildPrimitives (cyclomatic 19) src/applications/differential/render/DifferentialChangesetRenderer.php:453— DifferentialChangesetRenderer.buildPrimitives has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialLocalCommitsView.render (cyclomatic 19) src/applications/differential/view/DifferentialLocalCommitsView.php:19— DifferentialLocalCommitsView.render has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionRepositoryStorageManagementPanel.buildClusterStatusPanel (cyclomatic 19) src/applications/diffusion/management/DiffusionRepositoryStorageManagementPanel.php:79— DiffusionRepositoryStorageManagementPanel.buildClusterStatusPanel has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorFilesManagementMigrateWorkflow.execute (cyclomatic 19) src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php:57— PhabricatorFilesManagementMigrateWorkflow.execute has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorOAuthServerTokenController.handleRequest (cyclomatic 19) src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php:17— PhabricatorOAuthServerTokenController.handleRequest has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorOwnersPackageQuery.getControllingPackagesForPath (cyclomatic 19) src/applications/owners/query/PhabricatorOwnersPackageQuery.php:369— PhabricatorOwnersPackageQuery.getControllingPackagesForPath has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorPeopleQuery.fillUserCaches (cyclomatic 19) src/applications/people/query/PhabricatorPeopleQuery.php:514— PhabricatorPeopleQuery.fillUserCaches has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhortuneCartCancelController.handleCartRequest (cyclomatic 19) src/applications/phortune/controller/cart/PhortuneCartCancelController.php:14— PhortuneCartCancelController.handleCartRequest has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorPhortuneManagementInvoiceWorkflow.execute (cyclomatic 19) src/applications/phortune/management/PhabricatorPhortuneManagementInvoiceWorkflow.php:49— PhabricatorPhortuneManagementInvoiceWorkflow.execute has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhortunePayPalPaymentProvider.updateCharge (cyclomatic 19) src/applications/phortune/provider/PhortunePayPalPaymentProvider.php:194— PhortunePayPalPaymentProvider.updateCharge has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
PhrictionDocumentQuery.willFilterPage (cyclomatic 19) src/applications/phriction/query/PhrictionDocumentQuery.php:69— PhrictionDocumentQuery.willFilterPage has cyclomatic complexity 19 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PhabricatorProjectIconSet.validateConfiguration (cyclomatic 19) src/applications/project/icon/PhabricatorProjectIconSet.php:195— PhabricatorProjectIconSet.validateConfiguration has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorRepositoryManagementParentsWorkflow.rebuildRepository (cyclomatic 19) src/applications/repository/management/PhabricatorRepositoryManagementParentsWorkflow.php:49— PhabricatorRepositoryManagementParentsWorkflow.rebuildRepository has cyclomatic complexity 19 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.execute (cyclomatic 19) src/applications/repository/management/PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.php:63— PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.execute has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorSearchRelationshipController.handleRequest (cyclomatic 19) src/applications/search/controller/PhabricatorSearchRelationshipController.php:6— PhabricatorSearchRelationshipController.handleRequest has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorApplicationTransactionEditor.addHeadersAndCommentsToMailBody (cyclomatic 19) src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:3859— PhabricatorApplicationTransactionEditor.addHeadersAndCommentsToMailBody has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhutilProseDifferenceEngine.buildDiff (cyclomatic 19) src/infrastructure/diff/prose/PhutilProseDifferenceEngine.php:9— PhutilProseDifferenceEngine.buildDiff has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorDiffInlineCommentQuery.willFilterPage (cyclomatic 19) src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php:144— PhabricatorDiffInlineCommentQuery.willFilterPage has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorJavelinLinter.lintPath (cyclomatic 19) src/infrastructure/lint/linter/PhabricatorJavelinLinter.php:104— PhabricatorJavelinLinter.lintPath has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorManagementWorkflow.loadUsersFromArguments (cyclomatic 19) src/infrastructure/management/PhabricatorManagementWorkflow.php:70— PhabricatorManagementWorkflow.loadUsersFromArguments has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorCursorPagedPolicyAwareQuery.buildEdgeLogicJoinClause (cyclomatic 19) src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:2694— PhabricatorCursorPagedPolicyAwareQuery.buildEdgeLogicJoinClause has cyclomatic complexity 19 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PhabricatorRemarkupControl.renderInput (cyclomatic 19) src/view/form/control/PhabricatorRemarkupControl.php:52— PhabricatorRemarkupControl.renderInput has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorMainMenuView.render (cyclomatic 19) src/view/page/menu/PhabricatorMainMenuView.php:51— PhabricatorMainMenuView.render has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHUIPagerView.render (cyclomatic 19) src/view/phui/PHUIPagerView.php:119— PHUIPagerView.render has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
_getFragmentLocation (cyclomatic 19) webroot/rsrc/js/application/diff/DiffChangesetList.js:2643— _getFragmentLocation has cyclomatic complexity 19 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
PhabricatorDuoAuthFactor.processAddFactorForm (cyclomatic 18) src/applications/auth/factor/PhabricatorDuoAuthFactor.php:155— PhabricatorDuoAuthFactor.processAddFactorForm has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorConfigConsoleController.loadVersions (cyclomatic 18) src/applications/config/controller/PhabricatorConfigConsoleController.php:139— PhabricatorConfigConsoleController.loadVersions has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorDashboardObjectInstallWorkflow.handleRequest (cyclomatic 18) src/applications/dashboard/install/PhabricatorDashboardObjectInstallWorkflow.php:10— PhabricatorDashboardObjectInstallWorkflow.handleRequest has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialTransactionEditor.didApplyTransactions (cyclomatic 18) src/applications/differential/editor/DifferentialTransactionEditor.php:1529— DifferentialTransactionEditor.didApplyTransactions has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialCommitMessageParser.parseCorpus (cyclomatic 18) src/applications/differential/parser/DifferentialCommitMessageParser.php:136— DifferentialCommitMessageParser.parseCorpus has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialRevisionListView.render (cyclomatic 18) src/applications/differential/view/DifferentialRevisionListView.php:50— DifferentialRevisionListView.render has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionLintSaveRunner.run (cyclomatic 18) src/applications/diffusion/DiffusionLintSaveRunner.php:45— DiffusionLintSaveRunner.run has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionRefTableController.handleRequest (cyclomatic 18) src/applications/diffusion/controller/DiffusionRefTableController.php:9— DiffusionRefTableController.handleRequest has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionRepositoryProfilePictureController.handleRequest (cyclomatic 18) src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php:6— DiffusionRepositoryProfilePictureController.handleRequest has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionSubversionWireProtocol.writeData (cyclomatic 18) src/applications/diffusion/protocol/DiffusionSubversionWireProtocol.php:31— DiffusionSubversionWireProtocol.writeData has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionCommitGraphView.newObjectItemViews (cyclomatic 18) src/applications/diffusion/view/DiffusionCommitGraphView.php:105— DiffusionCommitGraphView.newObjectItemViews has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorChartStackedAreaDataset.newChartDisplayData (cyclomatic 18) src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php:19— PhabricatorChartStackedAreaDataset.newChartDisplayData has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorChartRenderingEngine.newTabularView (cyclomatic 18) src/applications/fact/engine/PhabricatorChartRenderingEngine.php:112— PhabricatorChartRenderingEngine.newTabularView has cyclomatic complexity 18 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PhabricatorFileDataController.handleRequest (cyclomatic 18) src/applications/files/controller/PhabricatorFileDataController.php:17— PhabricatorFileDataController.handleRequest has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorFileQuery.loadPage (cyclomatic 18) src/applications/files/query/PhabricatorFileQuery.php:166— PhabricatorFileQuery.loadPage has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HarbormasterUIEventListener.handlePropertyEvent (cyclomatic 18) src/applications/harbormaster/event/HarbormasterUIEventListener.php:18— HarbormasterUIEventListener.handlePropertyEvent has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HeraldRuleController.saveRule (cyclomatic 18) src/applications/herald/controller/HeraldRuleController.php:263— HeraldRuleController.saveRule has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HeraldEngine.applyRules (cyclomatic 18) src/applications/herald/engine/HeraldEngine.php:126— HeraldEngine.applyRules has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HeraldEngine.applyEffects (cyclomatic 18) src/applications/herald/engine/HeraldEngine.php:258— HeraldEngine.applyEffects has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorMacroQuery.buildWhereClauseParts (cyclomatic 18) src/applications/macro/query/PhabricatorMacroQuery.php:103— PhabricatorMacroQuery.buildWhereClauseParts has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorMailSMTPAdapter.sendMessage (cyclomatic 18) src/applications/metamta/adapter/PhabricatorMailSMTPAdapter.php:47— PhabricatorMailSMTPAdapter.sendMessage has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorNotificationServersConfigType.validateStoredValue (cyclomatic 18) src/applications/notification/config/PhabricatorNotificationServersConfigType.php:8— PhabricatorNotificationServersConfigType.validateStoredValue has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
NuanceGitHubImportCursor.pullDataFromSource (cyclomatic 18) src/applications/nuance/cursor/NuanceGitHubImportCursor.php:56— NuanceGitHubImportCursor.pullDataFromSource has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorOAuthServerAuthController.handleRequest (cyclomatic 18) src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php:12— PhabricatorOAuthServerAuthController.handleRequest has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorPolicyFilter.applyExtendedPolicyChecks (cyclomatic 18) src/applications/policy/filter/PhabricatorPolicyFilter.php:299— PhabricatorPolicyFilter.applyExtendedPolicyChecks has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorRepositoryGraphCache.loadLastModifiedCommitID (cyclomatic 18) src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php:75— PhabricatorRepositoryGraphCache.loadLastModifiedCommitID has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorProfileMenuItemView.newListItemView (cyclomatic 18) src/applications/search/engine/PhabricatorProfileMenuItemView.php:138— PhabricatorProfileMenuItemView.newListItemView has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorSSHPassthruCommand.execute (cyclomatic 18) src/infrastructure/ssh/PhabricatorSSHPassthruCommand.php:87— PhabricatorSSHPassthruCommand.execute has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHUIListItemView.getTagContent (cyclomatic 18) src/view/phui/PHUIListItemView.php:286— PHUIListItemView.getTagContent has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHUITimelineView.buildEvents (cyclomatic 18) src/view/phui/PHUITimelineView.php:101— PHUITimelineView.buildEvents has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
getSelectableItems (cyclomatic 18) webroot/rsrc/js/application/diff/DiffChangeset.js:435— getSelectableItems has cyclomatic complexity 18 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
PHPMailer.CreateHeader (cyclomatic 17) externals/phpmailer/class.phpmailer.php:1057— PHPMailer.CreateHeader has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorConfigClusterDatabasesController.buildClusterDatabaseStatus (cyclomatic 17) src/applications/config/controller/services/PhabricatorConfigClusterDatabasesController.php:36— PhabricatorConfigClusterDatabasesController.buildClusterDatabaseStatus has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ConpherenceViewController.handleRequest (cyclomatic 17) src/applications/conpherence/controller/ConpherenceViewController.php:12— ConpherenceViewController.handleRequest has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ConpherenceThreadSearchEngine.renderResultList (cyclomatic 17) src/applications/conpherence/query/ConpherenceThreadSearchEngine.php:94— ConpherenceThreadSearchEngine.renderResultList has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialChangesetParser.newDocumentEngine (cyclomatic 17) src/applications/differential/parser/DifferentialChangesetParser.php:1746— DifferentialChangesetParser.newDocumentEngine has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialChangesetOneUpMailRenderer.renderPrimitives (cyclomatic 17) src/applications/differential/render/DifferentialChangesetOneUpMailRenderer.php:43— DifferentialChangesetOneUpMailRenderer.renderPrimitives has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialRevisionUpdateHistoryView.render (cyclomatic 17) src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php:38— DifferentialRevisionUpdateHistoryView.render has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionCompareController.handleRequest (cyclomatic 17) src/applications/diffusion/controller/DiffusionCompareController.php:9— DiffusionCompareController.handleRequest has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DiffusionSourceLinkRemarkupRule.didMarkupText (cyclomatic 17) src/applications/diffusion/remarkup/DiffusionSourceLinkRemarkupRule.php:46— DiffusionSourceLinkRemarkupRule.didMarkupText has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DivinerPHPAtomizer.executeAtomize (cyclomatic 17) src/applications/diviner/atomizer/DivinerPHPAtomizer.php:9— DivinerPHPAtomizer.executeAtomize has cyclomatic complexity 17 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PhabricatorJupyterDocumentEngine.newCells (cyclomatic 17) src/applications/files/document/PhabricatorJupyterDocumentEngine.php:307— PhabricatorJupyterDocumentEngine.newCells has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HeraldRuleController.setupEditorBehavior (cyclomatic 17) src/applications/herald/controller/HeraldRuleController.php:400— HeraldRuleController.setupEditorBehavior has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorPeopleQuery.buildWhereClauseParts (cyclomatic 17) src/applications/people/query/PhabricatorPeopleQuery.php:242— PhabricatorPeopleQuery.buildWhereClauseParts has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorPeopleQuery.rebuildAvailabilityCache (cyclomatic 17) src/applications/people/query/PhabricatorPeopleQuery.php:385— PhabricatorPeopleQuery.rebuildAvailabilityCache has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhameLiveController.setupLiveEnvironment (cyclomatic 17) src/applications/phame/controller/PhameLiveController.php:30— PhameLiveController.setupLiveEnvironment has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhluxEditController.handleRequest (cyclomatic 17) src/applications/phlux/controller/PhluxEditController.php:5— PhluxEditController.handleRequest has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhortuneMerchantProviderEditController.handleMerchantRequest (cyclomatic 17) src/applications/phortune/controller/merchant/PhortuneMerchantProviderEditController.php:10— PhortuneMerchantProviderEditController.handleMerchantRequest has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhortuneOrderSummaryView.newMessagesView (cyclomatic 17) src/applications/phortune/view/PhortuneOrderSummaryView.php:49— PhortuneOrderSummaryView.newMessagesView has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorProjectBoardReorderController.handleRequest (cyclomatic 17) src/applications/project/controller/PhabricatorProjectBoardReorderController.php:6— PhabricatorProjectBoardReorderController.handleRequest has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorProjectEditPictureController.handleRequest (cyclomatic 17) src/applications/project/controller/PhabricatorProjectEditPictureController.php:6— PhabricatorProjectEditPictureController.handleRequest has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorProjectUserListView.render (cyclomatic 17) src/applications/project/view/PhabricatorProjectUserListView.php:55— PhabricatorProjectUserListView.render has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorRepositorySvnCommitChangeParserWorker.parseRecursiveListFileData (cyclomatic 17) src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php:676— PhabricatorRepositorySvnCommitChangeParserWorker.parseRecursiveListFileData has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorApplicationTransactionEditor.filterTransactions (cyclomatic 17) src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:2772— PhabricatorApplicationTransactionEditor.filterTransactions has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhutilDaemonHandle.update (cyclomatic 17) src/infrastructure/daemon/PhutilDaemonHandle.php:136— PhutilDaemonHandle.update has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhutilDefaultSyntaxHighlighterEngine.getHighlightFuture (cyclomatic 17) src/infrastructure/markup/syntax/engine/PhutilDefaultSyntaxHighlighterEngine.php:42— PhutilDefaultSyntaxHighlighterEngine.getHighlightFuture has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhutilXHPASTSyntaxHighlighterFuture.findInterestingSymbols (cyclomatic 17) src/infrastructure/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php:164— PhutilXHPASTSyntaxHighlighterFuture.findInterestingSymbols has cyclomatic complexity 17 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PHUICalendarMonthView.render (cyclomatic 17) src/view/phui/calendar/PHUICalendarMonthView.php:53— PHUICalendarMonthView.render has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
_getInlinesByType (cyclomatic 17) webroot/rsrc/js/application/diff/DiffChangesetList.js:1968— _getInlinesByType has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
PHPMailerLite.newFromMessage (cyclomatic 16) externals/phpmailer/class.phpmailer-lite.php:45— PHPMailerLite.newFromMessage has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHPMailerLite.MailSend (cyclomatic 16) externals/phpmailer/class.phpmailer-lite.php:649— PHPMailerLite.MailSend has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHPMailer.MailSend (cyclomatic 16) externals/phpmailer/class.phpmailer.php:628— PHPMailer.MailSend has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhutilICSParser.parseICSProperty (cyclomatic 16) src/applications/calendar/parser/ics/PhutilICSParser.php:191— PhutilICSParser.parseICSProperty has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorConduitMethodQuery.filterMethods (cyclomatic 16) src/applications/conduit/query/PhabricatorConduitMethodQuery.php:57— PhabricatorConduitMethodQuery.filterMethods has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorPathSetupCheck.executeChecks (cyclomatic 16) src/applications/config/check/PhabricatorPathSetupCheck.php:9— PhabricatorPathSetupCheck.executeChecks has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ConpherenceTransactionRenderer.renderTransactions (cyclomatic 16) src/applications/conpherence/ConpherenceTransactionRenderer.php:5— ConpherenceTransactionRenderer.renderTransactions has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ConpherenceRoomPictureController.handleRequest (cyclomatic 16) src/applications/conpherence/controller/ConpherenceRoomPictureController.php:6— ConpherenceRoomPictureController.handleRequest has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialDiffCreateController.handleRequest (cyclomatic 16) src/applications/differential/controller/DifferentialDiffCreateController.php:5— DifferentialDiffCreateController.handleRequest has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialTransactionEditor.expandCustomRemarkupBlockTransactions (cyclomatic 16) src/applications/differential/editor/DifferentialTransactionEditor.php:807— DifferentialTransactionEditor.expandCustomRemarkupBlockTransactions has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialDiffExtractionEngine.isDiffChangedBeforeCommit (cyclomatic 16) src/applications/differential/engine/DifferentialDiffExtractionEngine.php:119— DifferentialDiffExtractionEngine.isDiffChangedBeforeCommit has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DifferentialRevisionReviewTransaction.applyReviewerEffect (cyclomatic 16) src/applications/differential/xaction/DifferentialRevisionReviewTransaction.php:163— DifferentialRevisionReviewTransaction.applyReviewerEffect has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DrydockManagementLeaseWorkflow.execute (cyclomatic 16) src/applications/drydock/management/DrydockManagementLeaseWorkflow.php:44— DrydockManagementLeaseWorkflow.execute has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorTransactionFactEngine.groupTransactions (cyclomatic 16) src/applications/fact/engine/PhabricatorTransactionFactEngine.php:21— PhabricatorTransactionFactEngine.groupTransactions has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorFeedTransactionQuery.loadPage (cyclomatic 16) src/applications/feed/query/PhabricatorFeedTransactionQuery.php:41— PhabricatorFeedTransactionQuery.loadPage has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FileAllocateConduitAPIMethod.execute (cyclomatic 16) src/applications/files/conduit/FileAllocateConduitAPIMethod.php:28— FileAllocateConduitAPIMethod.execute has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HeraldRuleController.handleRequest (cyclomatic 16) src/applications/herald/controller/HeraldRuleController.php:5— HeraldRuleController.handleRequest has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorMetaMTAMemberQuery.execute (cyclomatic 16) src/applications/metamta/query/PhabricatorMetaMTAMemberQuery.php:26— PhabricatorMetaMTAMemberQuery.execute has cyclomatic complexity 16 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PhabricatorPeopleSearchEngine.renderResultList (cyclomatic 16) src/applications/people/query/PhabricatorPeopleSearchEngine.php:233— PhabricatorPeopleSearchEngine.renderResultList has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhameBlogProfilePictureController.handleRequest (cyclomatic 16) src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:6— PhameBlogProfilePictureController.handleRequest has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorProjectColumnQuery.didFilterPage (cyclomatic 16) src/applications/project/query/PhabricatorProjectColumnQuery.php:88— PhabricatorProjectColumnQuery.didFilterPage has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorRepositoryPullEngine.executeGitUpdate (cyclomatic 16) src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:275— PhabricatorRepositoryPullEngine.executeGitUpdate has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorRepositoryRefEngine.updateCursors (cyclomatic 16) src/applications/repository/engine/PhabricatorRepositoryRefEngine.php:258— PhabricatorRepositoryRefEngine.updateCursors has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorElasticFulltextStorageEngine.buildSpec (cyclomatic 16) src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php:108— PhabricatorElasticFulltextStorageEngine.buildSpec has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorEmailAddressesSettingsPanel.returnNewAddressResponse (cyclomatic 16) src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php:158— PhabricatorEmailAddressesSettingsPanel.returnNewAddressResponse has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PhabricatorInternationalizationManagementExtractWorkflow.extractFiles (cyclomatic 16) src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php:127— PhabricatorInternationalizationManagementExtractWorkflow.extractFiles has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
PhutilRemarkupListBlockRule.getMatchingLineCount (cyclomatic 16) src/infrastructure/markup/blockrule/PhutilRemarkupListBlockRule.php:13— PhutilRemarkupListBlockRule.getMatchingLineCount has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PHUIButtonView.getTagAttributes (cyclomatic 16) src/view/phui/PHUIButtonView.php:172— PHUIButtonView.getTagAttributes has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
_onresults (cyclomatic 16) webroot/rsrc/js/phuix/PHUIXAutocomplete.js:230— _onresults has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
seek_anchor (cyclomatic 16) webroot/rsrc/js/core/behavior-watch-anchor.js:34— seek_anchor has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
getNewValue (cyclomatic 16) webroot/rsrc/js/core/behavior-time-typeahead.js:82— getNewValue has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
_newHoverMap (cyclomatic 16) webroot/rsrc/js/application/diff/DiffChangesetList.js:1539— _newHoverMap has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
dormant codebase — no living knowledge left to concentrate — All 650 significant source file(s) were last meaningfully changed so long ago that no living knowledge remains — nothing since has been substantial enough to re-establish ownership (a broad, mechanical sweep that touches many files shallowly does not count, and neither does no activity at all). There is no concentration to measure, so the bus factor is not scored. This is not a clean bill: nobody currently holds working knowledge of this code (see D34 Knowledge Freshness).
LLM evaluation failed — JSON parse error: Expected end of string, but instead reached end of data. Path: $.findings[1].issue | LineNumber: 0 | BytePositionInLine: 1155.
PhabricatorAuthRegisterController.handleRequest (cognitive 208) src/applications/auth/controller/PhabricatorAuthRegisterController.php:10— PhabricatorAuthRegisterController.handleRequest has cognitive complexity 208 (threshold 15). Drivers by points: if/else 187, boolean chains 10, error handling 6, ternaries 5 (nesting depth added 101). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialChangesetTwoUpRenderer.renderTextChange (cognitive 173) src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php:31— DifferentialChangesetTwoUpRenderer.renderTextChange has cognitive complexity 173 (threshold 15). Drivers by points: if/else 132, ternaries 16, loops 14, boolean chains 11 (nesting depth added 108). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilSearchQueryCompiler.tokenizeQuery (cognitive 154) src/applications/search/compiler/PhutilSearchQueryCompiler.php:104— PhutilSearchQueryCompiler.tokenizeQuery has cognitive complexity 154 (threshold 15). Drivers by points: if/else 130, loops 10, match/switch 8, boolean chains 6 (nesting depth added 89). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionCommitController.handleRequest (cognitive 152) src/applications/diffusion/controller/DiffusionCommitController.php:17— DiffusionCommitController.handleRequest has cognitive complexity 152 (threshold 15). Drivers by points: if/else 114, loops 25, match/switch 7, boolean chains 6 (nesting depth added 97). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialChangesetParser.render (cognitive 150) src/applications/differential/parser/DifferentialChangesetParser.php:749— DifferentialChangesetParser.render has cognitive complexity 150 (threshold 15). Drivers by points: if/else 120, loops 21, boolean chains 8, match/switch 1 (nesting depth added 73). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositorySvnCommitChangeParserWorker.parseCommitChanges (cognitive 149) src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php:6— PhabricatorRepositorySvnCommitChangeParserWorker.parseCommitChanges has cognitive complexity 149 (threshold 15). Drivers by points: if/else 113, loops 28, match/switch 5, boolean chains 3 (nesting depth added 91). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositoryMercurialCommitChangeParserWorker.parseCommitChanges (cognitive 123) src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryMercurialCommitChangeParserWorker.php:6— PhabricatorRepositoryMercurialCommitChangeParserWorker.parseCommitChanges has cognitive complexity 123 (threshold 15). Drivers by points: if/else 97, loops 18, ternaries 6, boolean chains 2 (nesting depth added 60). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HarbormasterBuildLogRenderController.handleRequest (cognitive 117) src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php:10— HarbormasterBuildLogRenderController.handleRequest has cognitive complexity 117 (threshold 15). Drivers by points: if/else 89, loops 23, boolean chains 5 (nesting depth added 54). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialChangesetEngine.detectCopiedCode (cognitive 115) src/applications/differential/engine/DifferentialChangesetEngine.php:162— DifferentialChangesetEngine.detectCopiedCode has cognitive complexity 115 (threshold 15). Drivers by points: if/else 71, loops 35, ternaries 9 (nesting depth added 86). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorApplicationSearchController.processSearchRequest (cognitive 112) src/applications/search/controller/PhabricatorApplicationSearchController.php:95— PhabricatorApplicationSearchController.processSearchRequest has cognitive complexity 112 (threshold 15). Drivers by points: if/else 78, loops 16, boolean chains 8, error handling 8, ternaries 2 (nesting depth added 54). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionCommitQuery.buildWhereClauseParts (cognitive 111) src/applications/diffusion/query/DiffusionCommitQuery.php:534— DiffusionCommitQuery.buildWhereClauseParts has cognitive complexity 111 (threshold 15). Drivers by points: if/else 96, loops 12, error handling 3 (nesting depth added 57). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionMercurialWireClientSSHProtocolChannel.decodeStream (cognitive 111) src/applications/diffusion/ssh/DiffusionMercurialWireClientSSHProtocolChannel.php:79— DiffusionMercurialWireClientSSHProtocolChannel.decodeStream has cognitive complexity 111 (threshold 15). Drivers by points: if/else 109, boolean chains 1, loops 1 (nesting depth added 79). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionURIEditor.validateTransaction (cognitive 105) src/applications/diffusion/editor/DiffusionURIEditor.php:156— DiffusionURIEditor.validateTransaction has cognitive complexity 105 (threshold 15). Drivers by points: if/else 81, loops 16, match/switch 4, error handling 3, boolean chains 1 (nesting depth added 71). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AphrontTableView.render (cognitive 105) src/view/control/AphrontTableView.php:131— AphrontTableView.render has cognitive complexity 105 (threshold 15). Drivers by points: if/else 76, loops 26, boolean chains 3 (nesting depth added 60). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HeraldEngine.getRuleMatchResult (cognitive 100) src/applications/herald/engine/HeraldEngine.php:379— HeraldEngine.getRuleMatchResult has cognitive complexity 100 (threshold 15). Drivers by points: if/else 63, error handling 28, loops 6, boolean chains 3 (nesting depth added 71). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorManiphestTaskFactEngine.newDatapointsForObject (cognitive 99) src/applications/fact/engine/PhabricatorManiphestTaskFactEngine.php:86— PhabricatorManiphestTaskFactEngine.newDatapointsForObject has cognitive complexity 99 (threshold 15). Drivers by points: if/else 68, loops 20, match/switch 7, boolean chains 4 (nesting depth added 61). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorCalendarImportEngine.importEventDocument (cognitive 97) src/applications/calendar/import/PhabricatorCalendarImportEngine.php:55— PhabricatorCalendarImportEngine.importEventDocument has cognitive complexity 97 (threshold 15). Drivers by points: if/else 61, loops 28, error handling 3, match/switch 3, boolean chains 2 (nesting depth added 46). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorApplicationTransactionEditor.applyTransactions (cognitive 97) src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1175— PhabricatorApplicationTransactionEditor.applyTransactions has cognitive complexity 97 (threshold 15). Drivers by points: if/else 73, loops 21, error handling 2, boolean chains 1 (nesting depth added 43). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorInlineCommentAdjustmentEngine.execute (cognitive 97) src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php:60— PhabricatorInlineCommentAdjustmentEngine.execute has cognitive complexity 97 (threshold 15). Drivers by points: if/else 77, loops 17, ternaries 3 (nesting depth added 46). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionCommitHookEngine.findMercurialChangegroupRefUpdates (cognitive 92) src/applications/diffusion/engine/DiffusionCommitHookEngine.php:743— DiffusionCommitHookEngine.findMercurialChangegroupRefUpdates has cognitive complexity 92 (threshold 15). Drivers by points: if/else 60, loops 28, boolean chains 4 (nesting depth added 57). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorEditEngine.buildEditResponse (cognitive 92) src/applications/transactions/editengine/PhabricatorEditEngine.php:1033— PhabricatorEditEngine.buildEditResponse has cognitive complexity 92 (threshold 15). Drivers by points: if/else 63, loops 23, boolean chains 4, error handling 2 (nesting depth added 48). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionSubversionWireProtocol.writeData (cognitive 89) src/applications/diffusion/protocol/DiffusionSubversionWireProtocol.php:31— DiffusionSubversionWireProtocol.writeData has cognitive complexity 89 (threshold 15). Drivers by points: if/else 88, loops 1 (nesting depth added 62). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilCalendarRecurrenceRule.newDaysSet (cognitive 88) src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php:1178— PhutilCalendarRecurrenceRule.newDaysSet has cognitive complexity 88 (threshold 15). Drivers by points: if/else 76, loops 7, boolean chains 5 (nesting depth added 50). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialChangesetOneUpRenderer.renderDocumentEngineBlocks (cognitive 87) src/applications/differential/render/DifferentialChangesetOneUpRenderer.php:270— DifferentialChangesetOneUpRenderer.renderDocumentEngineBlocks has cognitive complexity 87 (threshold 15). Drivers by points: if/else 69, loops 15, boolean chains 3 (nesting depth added 46). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialRevisionViewController.handleRequest (cognitive 86) src/applications/differential/controller/DifferentialRevisionViewController.php:43— DifferentialRevisionViewController.handleRequest has cognitive complexity 86 (threshold 15). Drivers by points: if/else 57, loops 24, boolean chains 4, ternaries 1 (nesting depth added 20). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PhrictionDocumentController.handleRequest (cognitive 86) src/applications/phriction/controller/PhrictionDocumentController.php:13— PhrictionDocumentController.handleRequest has cognitive complexity 86 (threshold 15). Drivers by points: if/else 84, boolean chains 1, loops 1 (nesting depth added 43). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorFilesManagementIntegrityWorkflow.execute (cognitive 85) src/applications/files/management/PhabricatorFilesManagementIntegrityWorkflow.php:53— PhabricatorFilesManagementIntegrityWorkflow.execute has cognitive complexity 85 (threshold 15). Drivers by points: if/else 74, boolean chains 7, error handling 3, loops 1 (nesting depth added 37). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHUIDiffGraphView.renderRawGraph (cognitive 85) src/infrastructure/diff/view/PHUIDiffGraphView.php:36— PHUIDiffGraphView.renderRawGraph has cognitive complexity 85 (threshold 15). Drivers by points: if/else 58, loops 26, boolean chains 1 (nesting depth added 56). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialHunkParser.makeContextDiff (cognitive 84) src/applications/differential/parser/DifferentialHunkParser.php:665— DifferentialHunkParser.makeContextDiff has cognitive complexity 84 (threshold 15). Drivers by points: if/else 73, boolean chains 7, loops 4 (nesting depth added 58). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhortunePaymentMethodCreateController.handleRequest (cognitive 84) src/applications/phortune/controller/paymentmethod/PhortunePaymentMethodCreateController.php:6— PhortunePaymentMethodCreateController.handleRequest has cognitive complexity 84 (threshold 15). Drivers by points: if/else 69, error handling 11, boolean chains 2, loops 2 (nesting depth added 44). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialChangesetOneUpRenderer.renderPrimitives (cognitive 83) src/applications/differential/render/DifferentialChangesetOneUpRenderer.php:47— DifferentialChangesetOneUpRenderer.renderPrimitives has cognitive complexity 83 (threshold 15). Drivers by points: if/else 79, match/switch 2, boolean chains 1, loops 1 (nesting depth added 52). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProjectColumnBulkMoveController.handleRequest (cognitive 83) src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php:6— PhabricatorProjectColumnBulkMoveController.handleRequest has cognitive complexity 83 (threshold 15). Drivers by points: if/else 75, loops 8 (nesting depth added 42). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositoryManagementReparseWorkflow.execute (cognitive 82) src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php:81— PhabricatorRepositoryManagementReparseWorkflow.execute has cognitive complexity 82 (threshold 15). Drivers by points: if/else 68, boolean chains 6, error handling 3, loops 3, match/switch 2 (nesting depth added 39). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilRemarkupListBlockRule.renderTree (cognitive 81) src/infrastructure/markup/blockrule/PhutilRemarkupListBlockRule.php:428— PhutilRemarkupListBlockRule.renderTree has cognitive complexity 81 (threshold 15). Drivers by points: if/else 54, loops 12, match/switch 9, ternaries 5, boolean chains 1 (nesting depth added 49). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorFactObjectController.handleRequest (cognitive 80) src/applications/fact/controller/PhabricatorFactObjectController.php:6— PhabricatorFactObjectController.handleRequest has cognitive complexity 80 (threshold 15). Drivers by points: if/else 41, loops 39 (nesting depth added 43). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorTypeaheadModularDatasourceController.handleRequest (cognitive 77) src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php:10— PhabricatorTypeaheadModularDatasourceController.handleRequest has cognitive complexity 77 (threshold 15). Drivers by points: if/else 62, loops 5, ternaries 4, error handling 3, match/switch 3 (nesting depth added 45). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ConpherenceThreadSearchEngine.loadContextMessages (cognitive 76) src/applications/conpherence/query/ConpherenceThreadSearchEngine.php:233— ConpherenceThreadSearchEngine.loadContextMessages has cognitive complexity 76 (threshold 15). Drivers by points: if/else 42, loops 34 (nesting depth added 40). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionServeController.serveRequest (cognitive 76) src/applications/diffusion/controller/DiffusionServeController.php:176— DiffusionServeController.serveRequest has cognitive complexity 76 (threshold 15). Drivers by points: if/else 58, boolean chains 7, error handling 7, match/switch 4 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionRepositoryBasicsManagementPanel.buildRepositoryStatus (cognitive 76) src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php:336— DiffusionRepositoryBasicsManagementPanel.buildRepositoryStatus has cognitive complexity 76 (threshold 15). Drivers by points: if/else 56, match/switch 13, loops 6, boolean chains 1 (nesting depth added 37). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorPeopleTestDataGenerator.generateUsername (cognitive 73) src/applications/people/lipsum/PhabricatorPeopleTestDataGenerator.php:44— PhabricatorPeopleTestDataGenerator.generateUsername has cognitive complexity 73 (threshold 15). Drivers by points: if/else 50, loops 20, boolean chains 3 (nesting depth added 45). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorAuthSessionEngine.newHighSecurityToken (cognitive 71) src/applications/auth/engine/PhabricatorAuthSessionEngine.php:446— PhabricatorAuthSessionEngine.newHighSecurityToken has cognitive complexity 71 (threshold 15). Drivers by points: if/else 55, loops 15, boolean chains 1 (nesting depth added 41). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProfileMenuEngine.buildResponse (cognitive 71) src/applications/search/engine/PhabricatorProfileMenuEngine.php:102— PhabricatorProfileMenuEngine.buildResponse has cognitive complexity 71 (threshold 15). Drivers by points: if/else 58, match/switch 6, error handling 3, boolean chains 2, loops 2 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorCursorPagedPolicyAwareQuery.buildFerretWhereClause (cognitive 71) src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:2208— PhabricatorCursorPagedPolicyAwareQuery.buildFerretWhereClause has cognitive complexity 71 (threshold 15). Drivers by points: if/else 68, boolean chains 2, loops 1 (nesting depth added 32). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorMetaMTAMailViewController.buildDeliveryProperties (cognitive 69) src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php:216— PhabricatorMetaMTAMailViewController.buildDeliveryProperties has cognitive complexity 69 (threshold 15). Drivers by points: if/else 54, loops 12, match/switch 3 (nesting depth added 36). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorMailManagementShowOutboundWorkflow.execute (cognitive 68) src/applications/metamta/management/PhabricatorMailManagementShowOutboundWorkflow.php:29— PhabricatorMailManagementShowOutboundWorkflow.execute has cognitive complexity 68 (threshold 15). Drivers by points: if/else 50, loops 18 (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorConduitAPIController.authenticateUser (cognitive 67) src/applications/conduit/controller/PhabricatorConduitAPIController.php:167— PhabricatorConduitAPIController.authenticateUser has cognitive complexity 67 (threshold 15). Drivers by points: if/else 64, error handling 2, boolean chains 1 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorConfigClusterRepositoriesController.buildClusterRepositoryStatus (cognitive 67) src/applications/config/controller/services/PhabricatorConfigClusterRepositoriesController.php:46— PhabricatorConfigClusterRepositoriesController.buildClusterRepositoryStatus has cognitive complexity 67 (threshold 15). Drivers by points: if/else 55, loops 9, boolean chains 3 (nesting depth added 37). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorMentionRemarkupRule.didMarkupText (cognitive 67) src/applications/people/markup/PhabricatorMentionRemarkupRule.php:57— PhabricatorMentionRemarkupRule.didMarkupText has cognitive complexity 67 (threshold 15). Drivers by points: if/else 57, loops 10 (nesting depth added 41). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorBoardLayoutEngine.layoutBoard (cognitive 67) src/applications/project/engine/PhabricatorBoardLayoutEngine.php:419— PhabricatorBoardLayoutEngine.layoutBoard has cognitive complexity 67 (threshold 15). Drivers by points: if/else 36, loops 29, boolean chains 2 (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialReviewersView.render (cognitive 66) src/applications/differential/view/DifferentialReviewersView.php:26— DifferentialReviewersView.render has cognitive complexity 66 (threshold 15). Drivers by points: if/else 59, boolean chains 3, loops 2, match/switch 2 (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionBrowseQueryConduitAPIMethod.getGitResult (cognitive 66) src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php:35— DiffusionBrowseQueryConduitAPIMethod.getGitResult has cognitive complexity 66 (threshold 15). Drivers by points: if/else 53, loops 7, boolean chains 3, error handling 2, ternaries 1 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositoryPullLocalDaemon.run (cognitive 66) src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:38— PhabricatorRepositoryPullLocalDaemon.run has cognitive complexity 66 (threshold 15). Drivers by points: if/else 45, loops 20, boolean chains 1 (nesting depth added 43). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositoryManagementThawWorkflow.execute (cognitive 66) src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php:49— PhabricatorRepositoryManagementThawWorkflow.execute has cognitive complexity 66 (threshold 15). Drivers by points: if/else 50, loops 8, boolean chains 5, error handling 3 (nesting depth added 32). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorEditEngineConfigurationQuery.loadPage (cognitive 66) src/applications/transactions/query/PhabricatorEditEngineConfigurationQuery.php:71— PhabricatorEditEngineConfigurationQuery.loadPage has cognitive complexity 66 (threshold 15). Drivers by points: if/else 44, loops 22 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorDatabaseRefParser.newRefs (cognitive 66) src/infrastructure/cluster/PhabricatorDatabaseRefParser.php:37— PhabricatorDatabaseRefParser.newRefs has cognitive complexity 66 (threshold 15). Drivers by points: if/else 56, loops 10 (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHUIDiffInlineCommentDetailView.render (cognitive 66) src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php:78— PHUIDiffInlineCommentDetailView.render has cognitive complexity 66 (threshold 15). Drivers by points: if/else 50, boolean chains 9, ternaries 3, loops 2, match/switch 2 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorPolicyAwareQuery.execute (cognitive 66) src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php:204— PhabricatorPolicyAwareQuery.execute has cognitive complexity 66 (threshold 15). Drivers by points: if/else 52, loops 8, boolean chains 3, error handling 3 (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorController.willBeginExecution (cognitive 65) src/applications/base/controller/PhabricatorController.php:64— PhabricatorController.willBeginExecution has cognitive complexity 65 (threshold 15). Drivers by points: if/else 56, boolean chains 8, loops 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorCalendarEventQuery.willFilterPage (cognitive 65) src/applications/calendar/query/PhabricatorCalendarEventQuery.php:515— PhabricatorCalendarEventQuery.willFilterPage has cognitive complexity 65 (threshold 15). Drivers by points: if/else 33, loops 32 (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DivinerAtomQuery.willFilterPage (cognitive 65) src/applications/diviner/query/DivinerAtomQuery.php:139— DivinerAtomQuery.willFilterPage has cognitive complexity 65 (threshold 15). Drivers by points: if/else 46, loops 19 (nesting depth added 38). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHUIObjectItemView.getTagContent (cognitive 65) src/view/phui/PHUIObjectItemView.php:383— PHUIObjectItemView.getTagContent has cognitive complexity 65 (threshold 15). Drivers by points: if/else 41, loops 12, ternaries 7, boolean chains 5 (nesting depth added 17). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PhabricatorPeopleNewController.handleRequest (cognitive 64) src/applications/people/controller/PhabricatorPeopleNewController.php:6— PhabricatorPeopleNewController.handleRequest has cognitive complexity 64 (threshold 15). Drivers by points: if/else 56, boolean chains 3, error handling 3, match/switch 1, ternaries 1 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProjectBoardViewController.handleRequest (cognitive 64) src/applications/project/controller/PhabricatorProjectBoardViewController.php:10— PhabricatorProjectBoardViewController.handleRequest has cognitive complexity 64 (threshold 15). Drivers by points: if/else 48, loops 14, boolean chains 2 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MultimeterSampleController.handleRequest (cognitive 63) src/applications/multimeter/controller/MultimeterSampleController.php:9— MultimeterSampleController.handleRequest has cognitive complexity 63 (threshold 15). Drivers by points: if/else 57, loops 4, ternaries 2 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PholioMockEditController.handleRequest (cognitive 62) src/applications/pholio/controller/PholioMockEditController.php:5— PholioMockEditController.handleRequest has cognitive complexity 62 (threshold 15). Drivers by points: if/else 44, ternaries 10, loops 7, boolean chains 1 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HarbormasterBuildEngine.updateBuildSteps (cognitive 61) src/applications/harbormaster/engine/HarbormasterBuildEngine.php:165— HarbormasterBuildEngine.updateBuildSteps has cognitive complexity 61 (threshold 15). Drivers by points: if/else 41, loops 18, boolean chains 2 (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Text_Figlet.lineEcho (cognitive 60) externals/pear-figlet/Text/Figlet.php:269— Text_Figlet.lineEcho has cognitive complexity 60 (threshold 15). Drivers by points: if/else 43, loops 16, boolean chains 1 (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
xhprof_lib.xhprof_aggregate_runs (cognitive 60) externals/xhprof/xhprof_lib.php:244— xhprof_lib.xhprof_aggregate_runs has cognitive complexity 60 (threshold 15). Drivers by points: if/else 38, loops 18, boolean chains 2, ternaries 2 (nesting depth added 36). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialHunkParser.parseHunksForHighlightMasks (cognitive 60) src/applications/differential/parser/DifferentialHunkParser.php:566— DifferentialHunkParser.parseHunksForHighlightMasks has cognitive complexity 60 (threshold 15). Drivers by points: if/else 47, boolean chains 9, loops 4 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PassphraseCredentialEditController.handleRequest (cognitive 60) src/applications/passphrase/controller/PassphraseCredentialEditController.php:5— PassphraseCredentialEditController.handleRequest has cognitive complexity 60 (threshold 15). Drivers by points: if/else 49, error handling 8, boolean chains 2, ternaries 1 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhrictionRemarkupRule.didMarkupText (cognitive 60) src/applications/phriction/markup/PhrictionRemarkupRule.php:86— PhrictionRemarkupRule.didMarkupText has cognitive complexity 60 (threshold 15). Drivers by points: if/else 46, loops 13, boolean chains 1 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorAuthEditController.handleRequest (cognitive 58) src/applications/auth/controller/config/PhabricatorAuthEditController.php:6— PhabricatorAuthEditController.handleRequest has cognitive complexity 58 (threshold 15). Drivers by points: if/else 49, loops 5, error handling 3, boolean chains 1 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialChangesetTwoUpRenderer.renderDocumentEngineBlocks (cognitive 58) src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php:367— DifferentialChangesetTwoUpRenderer.renderDocumentEngineBlocks has cognitive complexity 58 (threshold 15). Drivers by points: if/else 50, loops 7, boolean chains 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionRepositoryStorageManagementPanel.buildClusterStatusPanel (cognitive 58) src/applications/diffusion/management/DiffusionRepositoryStorageManagementPanel.php:79— DiffusionRepositoryStorageManagementPanel.buildClusterStatusPanel has cognitive complexity 58 (threshold 15). Drivers by points: if/else 48, error handling 5, loops 4, boolean chains 1 (nesting depth added 35). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorSearchManagementIndexWorkflow.execute (cognitive 58) src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php:74— PhabricatorSearchManagementIndexWorkflow.execute has cognitive complexity 58 (threshold 15). Drivers by points: if/else 38, boolean chains 11, loops 7, error handling 2 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorAuthManagementStripWorkflow.execute (cognitive 57) src/applications/auth/management/PhabricatorAuthManagementStripWorkflow.php:54— PhabricatorAuthManagementStripWorkflow.execute has cognitive complexity 57 (threshold 15). Drivers by points: if/else 41, loops 10, boolean chains 6 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DivinerAtomController.handleRequest (cognitive 57) src/applications/diviner/controller/DivinerAtomController.php:9— DivinerAtomController.handleRequest has cognitive complexity 57 (threshold 15). Drivers by points: if/else 32, loops 18, ternaries 7 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositoryQuery.willFilterPage (cognitive 57) src/applications/repository/query/PhabricatorRepositoryQuery.php:236— PhabricatorRepositoryQuery.willFilterPage has cognitive complexity 57 (threshold 15). Drivers by points: if/else 35, loops 18, match/switch 4 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorPeopleInviteSendController.handleRequest (cognitive 56) src/applications/people/controller/PhabricatorPeopleInviteSendController.php:6— PhabricatorPeopleInviteSendController.handleRequest has cognitive complexity 56 (threshold 15). Drivers by points: if/else 44, loops 9, ternaries 2, boolean chains 1 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AphrontMultipartParser.continueParse (cognitive 55) src/aphront/multipartparser/AphrontMultipartParser.php:62— AphrontMultipartParser.continueParse has cognitive complexity 55 (threshold 15). Drivers by points: if/else 52, match/switch 2, loops 1 (nesting depth added 37). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorApplicationQuery.loadPage (cognitive 55) src/applications/meta/query/PhabricatorApplicationQuery.php:71— PhabricatorApplicationQuery.loadPage has cognitive complexity 55 (threshold 15). Drivers by points: if/else 36, loops 18, match/switch 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorWorkerManagementWorkflow.loadTasks (cognitive 55) src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementWorkflow.php:69— PhabricatorWorkerManagementWorkflow.loadTasks has cognitive complexity 55 (threshold 15). Drivers by points: if/else 45, boolean chains 7, loops 3 (nesting depth added 12). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PHUIDiffTableOfContentsListView.render (cognitive 55) src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php:53— PHUIDiffTableOfContentsListView.render has cognitive complexity 55 (threshold 15). Drivers by points: if/else 51, loops 4 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HarbormasterBuildViewController.handleRequest (cognitive 54) src/applications/harbormaster/controller/HarbormasterBuildViewController.php:10— HarbormasterBuildViewController.handleRequest has cognitive complexity 54 (threshold 15). Drivers by points: if/else 48, loops 5, boolean chains 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LegalpadDocumentSignController.handleRequest (cognitive 54) src/applications/legalpad/controller/LegalpadDocumentSignController.php:24— LegalpadDocumentSignController.handleRequest has cognitive complexity 54 (threshold 15). Drivers by points: if/else 47, boolean chains 4, match/switch 3 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ManiphestReportController.renderOpenTasks (cognitive 54) src/applications/maniphest/controller/ManiphestReportController.php:487— ManiphestReportController.renderOpenTasks has cognitive complexity 54 (threshold 15). Drivers by points: if/else 27, loops 19, match/switch 4, ternaries 3, boolean chains 1 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ManiphestTransactionEditor.buildMoveTransaction (cognitive 54) src/applications/maniphest/editor/ManiphestTransactionEditor.php:438— ManiphestTransactionEditor.buildMoveTransaction has cognitive complexity 54 (threshold 15). Drivers by points: if/else 42, loops 10, boolean chains 2 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorObjectListQuery.execute (cognitive 54) src/applications/phid/query/PhabricatorObjectListQuery.php:56— PhabricatorObjectListQuery.execute has cognitive complexity 54 (threshold 15). Drivers by points: if/else 32, loops 21, boolean chains 1 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorEditEngine.buildCommentResponse (cognitive 54) src/applications/transactions/editengine/PhabricatorEditEngine.php:1875— PhabricatorEditEngine.buildCommentResponse has cognitive complexity 54 (threshold 15). Drivers by points: if/else 38, loops 8, error handling 5, boolean chains 3 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilCalendarRecurrenceSet.getEventsBetween (cognitive 53) src/applications/calendar/parser/data/PhutilCalendarRecurrenceSet.php:23— PhutilCalendarRecurrenceSet.getEventsBetween has cognitive complexity 53 (threshold 15). Drivers by points: if/else 41, loops 8, boolean chains 4 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialRevisionReviewersTransaction.renderReviewerEditTitle (cognitive 53) src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php:165— DifferentialRevisionReviewersTransaction.renderReviewerEditTitle has cognitive complexity 53 (threshold 15). Drivers by points: if/else 48, boolean chains 4, loops 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProfileMenuEngine.buildItemConfigureContent (cognitive 53) src/applications/search/engine/PhabricatorProfileMenuEngine.php:683— PhabricatorProfileMenuEngine.buildItemConfigureContent has cognitive complexity 53 (threshold 15). Drivers by points: if/else 49, loops 3, boolean chains 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorApplicationTransactionView.renderEvent (cognitive 53) src/applications/transactions/view/PhabricatorApplicationTransactionView.php:422— PhabricatorApplicationTransactionView.renderEvent has cognitive complexity 53 (threshold 15). Drivers by points: if/else 44, boolean chains 9 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHUIHeaderView.getTagContent (cognitive 53) src/view/phui/PHUIHeaderView.php:190— PHUIHeaderView.getTagContent has cognitive complexity 53 (threshold 15). Drivers by points: if/else 40, loops 7, boolean chains 3, match/switch 3 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialChangesetViewController.handleRequest (cognitive 52) src/applications/differential/controller/DifferentialChangesetViewController.php:9— DifferentialChangesetViewController.handleRequest has cognitive complexity 52 (threshold 15). Drivers by points: if/else 42, boolean chains 4, loops 4, match/switch 2 (nesting depth added 11). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PhabricatorPolicyFilter.checkCapability (cognitive 52) src/applications/policy/filter/PhabricatorPolicyFilter.php:499— PhabricatorPolicyFilter.checkCapability has cognitive complexity 52 (threshold 15). Drivers by points: if/else 50, boolean chains 1, match/switch 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Text_Figlet.loadFont (cognitive 51) externals/pear-figlet/Text/Figlet.php:111— Text_Figlet.loadFont has cognitive complexity 51 (threshold 15). Drivers by points: if/else 45, loops 4, boolean chains 2 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionGitUploadPackWireProtocol.willReadBytes (cognitive 51) src/applications/diffusion/protocol/DiffusionGitUploadPackWireProtocol.php:16— DiffusionGitUploadPackWireProtocol.willReadBytes has cognitive complexity 51 (threshold 15). Drivers by points: if/else 40, loops 6, match/switch 4, boolean chains 1 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionCommitQuery.didFilterPage (cognitive 51) src/applications/diffusion/query/DiffusionCommitQuery.php:361— DiffusionCommitQuery.didFilterPage has cognitive complexity 51 (threshold 15). Drivers by points: if/else 24, loops 24, error handling 3 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHUIDiffTableOfContentsListView.newComponentView (cognitive 51) src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php:387— PHUIDiffTableOfContentsListView.newComponentView has cognitive complexity 51 (threshold 15). Drivers by points: if/else 45, boolean chains 3, loops 3 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorCursorPagedPolicyAwareQuery.buildSpacesWhereClause (cognitive 51) src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:3139— PhabricatorCursorPagedPolicyAwareQuery.buildSpacesWhereClause has cognitive complexity 51 (threshold 15). Drivers by points: if/else 43, boolean chains 4, loops 4 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
updateCard (cognitive 51) webroot/rsrc/js/application/projects/WorkboardBoard.js:601— updateCard has cognitive complexity 51 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHPMailerLite.WrapText (cognitive 50) externals/phpmailer/class.phpmailer-lite.php:785— PHPMailerLite.WrapText has cognitive complexity 50 (threshold 15). Drivers by points: if/else 36, loops 7, ternaries 5, boolean chains 2 (nesting depth added 32). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHPMailer.WrapText (cognitive 50) externals/phpmailer/class.phpmailer.php:916— PHPMailer.WrapText has cognitive complexity 50 (threshold 15). Drivers by points: if/else 36, loops 7, ternaries 5, boolean chains 2 (nesting depth added 32). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilSpriteSheet.generate (cognitive 50) src/aphront/sprite/PhutilSpriteSheet.php:57— PhutilSpriteSheet.generate has cognitive complexity 50 (threshold 15). Drivers by points: if/else 30, loops 17, boolean chains 2, match/switch 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorAuthManagementRevokeWorkflow.execute (cognitive 50) src/applications/auth/management/PhabricatorAuthManagementRevokeWorkflow.php:50— PhabricatorAuthManagementRevokeWorkflow.execute has cognitive complexity 50 (threshold 15). Drivers by points: if/else 41, boolean chains 6, loops 3 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionBrowseQueryConduitAPIMethod.getSVNResult (cognitive 50) src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php:363— DiffusionBrowseQueryConduitAPIMethod.getSVNResult has cognitive complexity 50 (threshold 15). Drivers by points: if/else 45, loops 3, boolean chains 2 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhortuneCartCancelController.handleCartRequest (cognitive 50) src/applications/phortune/controller/cart/PhortuneCartCancelController.php:14— PhortuneCartCancelController.handleCartRequest has cognitive complexity 50 (threshold 15). Drivers by points: if/else 38, error handling 8, loops 3, match/switch 1 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilProseDifferenceEngine.buildDiff (cognitive 50) src/infrastructure/diff/prose/PhutilProseDifferenceEngine.php:9— PhutilProseDifferenceEngine.buildDiff has cognitive complexity 50 (threshold 15). Drivers by points: if/else 38, loops 9, match/switch 2, boolean chains 1 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorCalendarNotificationEngine.sendNotifications (cognitive 49) src/applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php:73— PhabricatorCalendarNotificationEngine.sendNotifications has cognitive complexity 49 (threshold 15). Drivers by points: loops 26, if/else 20, error handling 2, boolean chains 1 (nesting depth added 21). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PhabricatorConfigClusterDatabasesController.buildClusterDatabaseStatus (cognitive 49) src/applications/config/controller/services/PhabricatorConfigClusterDatabasesController.php:36— PhabricatorConfigClusterDatabasesController.buildClusterDatabaseStatus has cognitive complexity 49 (threshold 15). Drivers by points: if/else 44, match/switch 4, loops 1 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ConpherenceThreadSearchEngine.renderResultList (cognitive 49) src/applications/conpherence/query/ConpherenceThreadSearchEngine.php:94— ConpherenceThreadSearchEngine.renderResultList has cognitive complexity 49 (threshold 15). Drivers by points: if/else 27, loops 19, boolean chains 3 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialChangesetRenderer.processPrimitivesForOneUp (cognitive 49) src/applications/differential/render/DifferentialChangesetRenderer.php:567— DifferentialChangesetRenderer.processPrimitivesForOneUp has cognitive complexity 49 (threshold 15). Drivers by points: if/else 47, boolean chains 1, loops 1 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorSlowvoteEditController.handleRequest (cognitive 49) src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php:6— PhabricatorSlowvoteEditController.handleRequest has cognitive complexity 49 (threshold 15). Drivers by points: if/else 40, loops 9 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorEditEngine.buildResponse (cognitive 49) src/applications/transactions/editengine/PhabricatorEditEngine.php:882— PhabricatorEditEngine.buildResponse has cognitive complexity 49 (threshold 15). Drivers by points: if/else 43, boolean chains 4, match/switch 2 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorEmailLoginController.handleRequest (cognitive 48) src/applications/auth/controller/PhabricatorEmailLoginController.php:10— PhabricatorEmailLoginController.handleRequest has cognitive complexity 48 (threshold 15). Drivers by points: if/else 43, error handling 4, boolean chains 1 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DarkConsoleServicesPlugin.generateData (cognitive 48) src/applications/console/plugin/DarkConsoleServicesPlugin.php:47— DarkConsoleServicesPlugin.generateData has cognitive complexity 48 (threshold 15). Drivers by points: if/else 36, loops 4, match/switch 4, error handling 3, boolean chains 1 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DoorkeeperAsanaFeedWorker.publishFeedStory (cognitive 48) src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php:27— DoorkeeperAsanaFeedWorker.publishFeedStory has cognitive complexity 48 (threshold 15). Drivers by points: if/else 37, loops 8, boolean chains 3 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhrictionEditController.handleRequest (cognitive 48) src/applications/phriction/controller/PhrictionEditController.php:6— PhrictionEditController.handleRequest has cognitive complexity 48 (threshold 15). Drivers by points: if/else 42, boolean chains 4, error handling 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialChangesetParser.replaceTabsWithSpaces (cognitive 47) src/applications/differential/parser/DifferentialChangesetParser.php:1615— DifferentialChangesetParser.replaceTabsWithSpaces has cognitive complexity 47 (threshold 15). Drivers by points: if/else 37, loops 10 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionLowLevelResolveRefsQuery.resolveGitRefs (cognitive 47) src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php:60— DiffusionLowLevelResolveRefsQuery.resolveGitRefs has cognitive complexity 47 (threshold 15). Drivers by points: if/else 35, loops 10, match/switch 2 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorChartRenderingEngine.newTabularView (cognitive 47) src/applications/fact/engine/PhabricatorChartRenderingEngine.php:112— PhabricatorChartRenderingEngine.newTabularView has cognitive complexity 47 (threshold 15). Drivers by points: loops 32, if/else 15 (nesting depth added 29). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
HeraldNewController.handleRequest (cognitive 47) src/applications/herald/controller/HeraldNewController.php:5— HeraldNewController.handleRequest has cognitive complexity 47 (threshold 15). Drivers by points: if/else 47 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorDifferenceEngine.applyIntralineDiff (cognitive 47) src/infrastructure/diff/PhabricatorDifferenceEngine.php:172— PhabricatorDifferenceEngine.applyIntralineDiff has cognitive complexity 47 (threshold 15). Drivers by points: if/else 33, boolean chains 7, loops 4, match/switch 3 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorCursorPagedPolicyAwareQuery.buildFerretJoinClause (cognitive 47) src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:1995— PhabricatorCursorPagedPolicyAwareQuery.buildFerretJoinClause has cognitive complexity 47 (threshold 15). Drivers by points: if/else 38, loops 8, boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorCalendarEventQuery.loadPage (cognitive 46) src/applications/calendar/query/PhabricatorCalendarEventQuery.php:161— PhabricatorCalendarEventQuery.loadPage has cognitive complexity 46 (threshold 15). Drivers by points: if/else 34, loops 10, boolean chains 2 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HeraldAdapter.doesConditionMatch (cognitive 46) src/applications/herald/adapter/HeraldAdapter.php:444— HeraldAdapter.doesConditionMatch has cognitive complexity 46 (threshold 15). Drivers by points: if/else 34, loops 6, error handling 5, match/switch 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ManiphestReportController.renderBurn (cognitive 46) src/applications/maniphest/controller/ManiphestReportController.php:74— ManiphestReportController.renderBurn has cognitive complexity 46 (threshold 15). Drivers by points: if/else 35, loops 4, boolean chains 3, match/switch 2, ternaries 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorPeopleQuery.rebuildAvailabilityCache (cognitive 46) src/applications/people/query/PhabricatorPeopleQuery.php:385— PhabricatorPeopleQuery.rebuildAvailabilityCache has cognitive complexity 46 (threshold 15). Drivers by points: if/else 29, loops 16, boolean chains 1 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorBoardLayoutEngine.queueAddPosition (cognitive 46) src/applications/project/engine/PhabricatorBoardLayoutEngine.php:138— PhabricatorBoardLayoutEngine.queueAddPosition has cognitive complexity 46 (threshold 15). Drivers by points: if/else 37, loops 9 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorDiffInlineCommentQuery.willFilterPage (cognitive 46) src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php:144— PhabricatorDiffInlineCommentQuery.willFilterPage has cognitive complexity 46 (threshold 15). Drivers by points: if/else 35, loops 10, boolean chains 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_update (cognitive 46) webroot/rsrc/js/phuix/PHUIXAutocomplete.js:428— _update has cognitive complexity 46 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorPeopleProfilePictureController.handleRequest (cognitive 45) src/applications/people/controller/PhabricatorPeopleProfilePictureController.php:6— PhabricatorPeopleProfilePictureController.handleRequest has cognitive complexity 45 (threshold 15). Drivers by points: if/else 41, loops 3, boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorPolicyFilter.apply (cognitive 45) src/applications/policy/filter/PhabricatorPolicyFilter.php:156— PhabricatorPolicyFilter.apply has cognitive complexity 45 (threshold 15). Drivers by points: if/else 33, loops 11, boolean chains 1 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilRemarkupListBlockRule.markupText (cognitive 45) src/infrastructure/markup/blockrule/PhutilRemarkupListBlockRule.php:88— PhutilRemarkupListBlockRule.markupText has cognitive complexity 45 (threshold 15). Drivers by points: if/else 39, loops 5, boolean chains 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilICSParser.parseICSProperty (cognitive 44) src/applications/calendar/parser/ics/PhutilICSParser.php:191— PhutilICSParser.parseICSProperty has cognitive complexity 44 (threshold 15). Drivers by points: if/else 37, loops 5, boolean chains 1, match/switch 1 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ConpherenceUpdateController.handleRequest (cognitive 44) src/applications/conpherence/controller/ConpherenceUpdateController.php:6— ConpherenceUpdateController.handleRequest has cognitive complexity 44 (threshold 15). Drivers by points: if/else 31, match/switch 7, error handling 3, boolean chains 2, ternaries 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionServeController.isVCSRequest (cognitive 44) src/applications/diffusion/controller/DiffusionServeController.php:40— DiffusionServeController.isVCSRequest has cognitive complexity 44 (threshold 15). Drivers by points: if/else 44 (nesting depth added 28). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ManiphestTaskDetailController.newChangesView (cognitive 44) src/applications/maniphest/controller/ManiphestTaskDetailController.php:545— ManiphestTaskDetailController.newChangesView has cognitive complexity 44 (threshold 15). Drivers by points: if/else 32, loops 7, ternaries 4, boolean chains 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhrictionDocumentQuery.buildWhereClauseParts (cognitive 44) src/applications/phriction/query/PhrictionDocumentQuery.php:199— PhrictionDocumentQuery.buildWhereClauseParts has cognitive complexity 44 (threshold 15). Drivers by points: if/else 36, loops 7, boolean chains 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorBulkManagementExportWorkflow.newQueries (cognitive 44) src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php:152— PhabricatorBulkManagementExportWorkflow.newQueries has cognitive complexity 44 (threshold 15). Drivers by points: if/else 36, loops 8 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_onjumpkey (cognitive 44) webroot/rsrc/js/application/diff/DiffChangesetList.js:650— _onjumpkey has cognitive complexity 44 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorConfigConsoleController.loadVersions (cognitive 43) src/applications/config/controller/PhabricatorConfigConsoleController.php:139— PhabricatorConfigConsoleController.loadVersions has cognitive complexity 43 (threshold 15). Drivers by points: if/else 38, loops 5 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HeraldRuleQuery.willFilterPage (cognitive 43) src/applications/herald/query/HeraldRuleQuery.php:89— HeraldRuleQuery.willFilterPage has cognitive complexity 43 (threshold 15). Drivers by points: if/else 28, loops 14, boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorCursorPagedPolicyAwareQuery.buildPagingClauseFromMultipleColumns (cognitive 43) src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:727— PhabricatorCursorPagedPolicyAwareQuery.buildPagingClauseFromMultipleColumns has cognitive complexity 43 (threshold 15). Drivers by points: if/else 33, match/switch 3, ternaries 3, boolean chains 2, loops 2 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHUITimelineEventView.render (cognitive 43) src/view/phui/PHUITimelineEventView.php:318— PHUITimelineEventView.render has cognitive complexity 43 (threshold 15). Drivers by points: if/else 26, loops 9, ternaries 5, boolean chains 3 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorAuthInviteTestCase.testInviteWithKnownEmail (cognitive 42) src/applications/auth/factor/__tests__/PhabricatorAuthInviteTestCase.php:145— PhabricatorAuthInviteTestCase.testInviteWithKnownEmail has cognitive complexity 42 (threshold 15). Drivers by points: if/else 17, loops 10, match/switch 10, error handling 5 (nesting depth added 30). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorExtraConfigSetupCheck.executeChecks (cognitive 42) src/applications/config/check/PhabricatorExtraConfigSetupCheck.php:9— PhabricatorExtraConfigSetupCheck.executeChecks has cognitive complexity 42 (threshold 15). Drivers by points: if/else 36, loops 6 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorPathSetupCheck.executeChecks (cognitive 42) src/applications/config/check/PhabricatorPathSetupCheck.php:9— PhabricatorPathSetupCheck.executeChecks has cognitive complexity 42 (threshold 15). Drivers by points: if/else 36, loops 5, boolean chains 1 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PassphraseQueryConduitAPIMethod.execute (cognitive 42) src/applications/passphrase/conduit/PassphraseQueryConduitAPIMethod.php:31— PassphraseQueryConduitAPIMethod.execute has cognitive complexity 42 (threshold 15). Drivers by points: if/else 37, boolean chains 2, match/switch 2, loops 1 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorPolicyFilter.applyExtendedPolicyChecks (cognitive 42) src/applications/policy/filter/PhabricatorPolicyFilter.php:299— PhabricatorPolicyFilter.applyExtendedPolicyChecks has cognitive complexity 42 (threshold 15). Drivers by points: if/else 27, loops 15 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProjectIconSet.validateConfiguration (cognitive 42) src/applications/project/icon/PhabricatorProjectIconSet.php:195— PhabricatorProjectIconSet.validateConfiguration has cognitive complexity 42 (threshold 15). Drivers by points: if/else 40, loops 2 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TransactionSearchConduitAPIMethod.execute (cognitive 42) src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php:102— TransactionSearchConduitAPIMethod.execute has cognitive complexity 42 (threshold 15). Drivers by points: if/else 24, match/switch 9, loops 6, error handling 3 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorInternationalizationManagementExtractWorkflow.extractFiles (cognitive 42) src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php:127— PhabricatorInternationalizationManagementExtractWorkflow.extractFiles has cognitive complexity 42 (threshold 15). Drivers by points: match/switch 16, if/else 13, loops 8, error handling 5 (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_getInlinesByType (cognitive 42) webroot/rsrc/js/application/diff/DiffChangesetList.js:1968— _getInlinesByType has cognitive complexity 42 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorAphlictManagementWorkflow.parseLaunchArguments (cognitive 41) src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php:27— PhabricatorAphlictManagementWorkflow.parseLaunchArguments has cognitive complexity 41 (threshold 15). Drivers by points: if/else 21, error handling 6, boolean chains 5, loops 5, match/switch 4 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorCalendarEventCancelController.handleRequest (cognitive 41) src/applications/calendar/controller/PhabricatorCalendarEventCancelController.php:6— PhabricatorCalendarEventCancelController.handleRequest has cognitive complexity 41 (threshold 15). Drivers by points: if/else 29, loops 6, boolean chains 3, error handling 3 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialHunkParser.generateIntraLineDiffs (cognitive 41) src/applications/differential/parser/DifferentialHunkParser.php:270— DifferentialHunkParser.generateIntraLineDiffs has cognitive complexity 41 (threshold 15). Drivers by points: if/else 32, loops 7, boolean chains 2 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialChangesetRenderer.buildPrimitives (cognitive 41) src/applications/differential/render/DifferentialChangesetRenderer.php:453— DifferentialChangesetRenderer.buildPrimitives has cognitive complexity 41 (threshold 15). Drivers by points: if/else 31, loops 7, boolean chains 3 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionCommitQuery.willFilterPage (cognitive 41) src/applications/diffusion/query/DiffusionCommitQuery.php:293— DiffusionCommitQuery.willFilterPage has cognitive complexity 41 (threshold 15). Drivers by points: if/else 25, loops 16 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorChartStackedAreaDataset.newChartDisplayData (cognitive 41) src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php:19— PhabricatorChartStackedAreaDataset.newChartDisplayData has cognitive complexity 41 (threshold 15). Drivers by points: if/else 26, loops 15 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorFeedTransactionQuery.loadPage (cognitive 41) src/applications/feed/query/PhabricatorFeedTransactionQuery.php:41— PhabricatorFeedTransactionQuery.loadPage has cognitive complexity 41 (threshold 15). Drivers by points: if/else 38, loops 3 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhortuneMerchantProviderEditController.handleMerchantRequest (cognitive 41) src/applications/phortune/controller/merchant/PhortuneMerchantProviderEditController.php:10— PhortuneMerchantProviderEditController.handleMerchantRequest has cognitive complexity 41 (threshold 15). Drivers by points: if/else 28, loops 7, error handling 4, boolean chains 2 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorPolicyEditController.handleRequest (cognitive 41) src/applications/policy/controller/PhabricatorPolicyEditController.php:6— PhabricatorPolicyEditController.handleRequest has cognitive complexity 41 (threshold 15). Drivers by points: if/else 29, loops 6, match/switch 4, error handling 2 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProjectDatasource.loadResults (cognitive 41) src/applications/project/typeahead/PhabricatorProjectDatasource.php:18— PhabricatorProjectDatasource.loadResults has cognitive complexity 41 (threshold 15). Drivers by points: if/else 31, loops 6, boolean chains 4 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositoryGraphCache.loadLastModifiedCommitID (cognitive 41) src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php:75— PhabricatorRepositoryGraphCache.loadLastModifiedCommitID has cognitive complexity 41 (threshold 15). Drivers by points: if/else 34, loops 5, boolean chains 2 (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositoryQuery.buildWhereClauseParts (cognitive 41) src/applications/repository/query/PhabricatorRepositoryQuery.php:533— PhabricatorRepositoryQuery.buildWhereClauseParts has cognitive complexity 41 (threshold 15). Drivers by points: if/else 34, boolean chains 4, loops 3 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorAuthStartController.handleRequest (cognitive 40) src/applications/auth/controller/PhabricatorAuthStartController.php:10— PhabricatorAuthStartController.handleRequest has cognitive complexity 40 (threshold 15). Drivers by points: if/else 30, loops 7, match/switch 2, boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionRefTableController.handleRequest (cognitive 40) src/applications/diffusion/controller/DiffusionRefTableController.php:9— DiffusionRefTableController.handleRequest has cognitive complexity 40 (threshold 15). Drivers by points: if/else 23, loops 9, ternaries 8 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhameLiveController.setupLiveEnvironment (cognitive 40) src/applications/phame/controller/PhameLiveController.php:30— PhameLiveController.setupLiveEnvironment has cognitive complexity 40 (threshold 15). Drivers by points: if/else 38, boolean chains 2 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhrictionTransactionEditor.validateTransaction (cognitive 40) src/applications/phriction/editor/PhrictionTransactionEditor.php:348— PhrictionTransactionEditor.validateTransaction has cognitive complexity 40 (threshold 15). Drivers by points: if/else 37, match/switch 2, loops 1 (nesting depth added 27). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositoryManagementParentsWorkflow.rebuildRepository (cognitive 40) src/applications/repository/management/PhabricatorRepositoryManagementParentsWorkflow.php:49— PhabricatorRepositoryManagementParentsWorkflow.rebuildRepository has cognitive complexity 40 (threshold 15). Drivers by points: loops 24, if/else 16 (nesting depth added 20). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PhabricatorSearchHovercardController.handleRequest (cognitive 40) src/applications/search/controller/PhabricatorSearchHovercardController.php:10— PhabricatorSearchHovercardController.handleRequest has cognitive complexity 40 (threshold 15). Drivers by points: if/else 28, loops 12 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorCacheEngine.updateObject (cognitive 40) src/applications/system/engine/PhabricatorCacheEngine.php:9— PhabricatorCacheEngine.updateObject has cognitive complexity 40 (threshold 15). Drivers by points: if/else 30, loops 10 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorInlineCommentController.processRequest (cognitive 40) src/infrastructure/diff/PhabricatorInlineCommentController.php:93— PhabricatorInlineCommentController.processRequest has cognitive complexity 40 (threshold 15). Drivers by points: if/else 36, match/switch 3, boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorAuthInviteAction.newActionListFromAddresses (cognitive 39) src/applications/auth/data/PhabricatorAuthInviteAction.php:94— PhabricatorAuthInviteAction.newActionListFromAddresses has cognitive complexity 39 (threshold 15). Drivers by points: if/else 26, loops 10, match/switch 3 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorConfigSchemaSpec.getDetailsForDataType (cognitive 39) src/applications/config/schema/PhabricatorConfigSchemaSpec.php:269— PhabricatorConfigSchemaSpec.getDetailsForDataType has cognitive complexity 39 (threshold 15). Drivers by points: if/else 33, match/switch 6 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialRevisionUpdateHistoryView.render (cognitive 39) src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php:38— DifferentialRevisionUpdateHistoryView.render has cognitive complexity 39 (threshold 15). Drivers by points: if/else 27, ternaries 9, loops 2, boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhrictionDocumentQuery.willFilterPage (cognitive 39) src/applications/phriction/query/PhrictionDocumentQuery.php:69— PhrictionDocumentQuery.willFilterPage has cognitive complexity 39 (threshold 15). Drivers by points: loops 20, if/else 19 (nesting depth added 21). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
(anonymous) (cognitive 39) webroot/rsrc/js/application/diffusion/behavior-commit-graph.js:8— (anonymous) has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorAuditManagementDeleteWorkflow.execute (cognitive 38) src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php:62— PhabricatorAuditManagementDeleteWorkflow.execute has cognitive complexity 38 (threshold 15). Drivers by points: if/else 23, loops 9, boolean chains 6 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CelerityResourceController.serveResource (cognitive 38) src/applications/celerity/controller/CelerityResourceController.php:27— CelerityResourceController.serveResource has cognitive complexity 38 (threshold 15). Drivers by points: if/else 25, error handling 6, boolean chains 4, loops 3 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorDashboardTabsPanelType.renderPanelContent (cognitive 38) src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php:46— PhabricatorDashboardTabsPanelType.renderPanelContent has cognitive complexity 38 (threshold 15). Drivers by points: if/else 30, boolean chains 3, loops 3, ternaries 2 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialGetCommitMessageConduitAPIMethod.execute (cognitive 38) src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php:34— DifferentialGetCommitMessageConduitAPIMethod.execute has cognitive complexity 38 (threshold 15). Drivers by points: if/else 28, boolean chains 5, loops 5 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionRepositoryProfilePictureController.handleRequest (cognitive 38) src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php:6— DiffusionRepositoryProfilePictureController.handleRequest has cognitive complexity 38 (threshold 15). Drivers by points: if/else 35, loops 2, boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorFeedStory.loadAllFromRows (cognitive 38) src/applications/feed/story/PhabricatorFeedStory.php:41— PhabricatorFeedStory.loadAllFromRows has cognitive complexity 38 (threshold 15). Drivers by points: loops 20, if/else 15, error handling 2, boolean chains 1 (nesting depth added 14). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
HeraldEngine.applyRules (cognitive 38) src/applications/herald/engine/HeraldEngine.php:126— HeraldEngine.applyRules has cognitive complexity 38 (threshold 15). Drivers by points: if/else 18, loops 10, error handling 8, boolean chains 2 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorEmailAddressesSettingsPanel.returnNewAddressResponse (cognitive 38) src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php:158— PhabricatorEmailAddressesSettingsPanel.returnNewAddressResponse has cognitive complexity 38 (threshold 15). Drivers by points: if/else 34, error handling 3, boolean chains 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorCursorPagedPolicyAwareQuery.buildEdgeLogicJoinClause (cognitive 38) src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:2694— PhabricatorCursorPagedPolicyAwareQuery.buildEdgeLogicJoinClause has cognitive complexity 38 (threshold 15). Drivers by points: loops 24, if/else 7, match/switch 7 (nesting depth added 26). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PhabricatorConfigDatabaseIssueController.handleRequest (cognitive 37) src/applications/config/controller/services/PhabricatorConfigDatabaseIssueController.php:6— PhabricatorConfigDatabaseIssueController.handleRequest has cognitive complexity 37 (threshold 15). Drivers by points: loops 33, if/else 4 (nesting depth added 23). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
DiffusionLowLevelResolveRefsQuery.resolveMercurialRefs (cognitive 37) src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php:243— DiffusionLowLevelResolveRefsQuery.resolveMercurialRefs has cognitive complexity 37 (threshold 15). Drivers by points: if/else 19, loops 16, error handling 2 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionCommitGraphView.newObjectItemViews (cognitive 37) src/applications/diffusion/view/DiffusionCommitGraphView.php:105— DiffusionCommitGraphView.newObjectItemViews has cognitive complexity 37 (threshold 15). Drivers by points: if/else 25, loops 12 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorOwnersPackageQuery.getControllingPackagesForPath (cognitive 37) src/applications/owners/query/PhabricatorOwnersPackageQuery.php:369— PhabricatorOwnersPackageQuery.getControllingPackagesForPath has cognitive complexity 37 (threshold 15). Drivers by points: if/else 26, loops 10, boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProjectColumnQuery.didFilterPage (cognitive 37) src/applications/project/query/PhabricatorProjectColumnQuery.php:88— PhabricatorProjectColumnQuery.didFilterPage has cognitive complexity 37 (threshold 15). Drivers by points: if/else 31, loops 6 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProjectQuery.willFilterPage (cognitive 37) src/applications/project/query/PhabricatorProjectQuery.php:239— PhabricatorProjectQuery.willFilterPage has cognitive complexity 37 (threshold 15). Drivers by points: if/else 26, loops 8, boolean chains 3 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositoryPullEngine.pullRepositoryWithLock (cognitive 37) src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:51— PhabricatorRepositoryPullEngine.pullRepositoryWithLock has cognitive complexity 37 (threshold 15). Drivers by points: if/else 33, loops 2, error handling 1, match/switch 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositoryRefEngine.updateCursors (cognitive 37) src/applications/repository/engine/PhabricatorRepositoryRefEngine.php:258— PhabricatorRepositoryRefEngine.updateCursors has cognitive complexity 37 (threshold 15). Drivers by points: if/else 25, loops 11, boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorApplicationSearchEngine.buildConduitResponse (cognitive 37) src/applications/search/engine/PhabricatorApplicationSearchEngine.php:1134— PhabricatorApplicationSearchEngine.buildConduitResponse has cognitive complexity 37 (threshold 15). Drivers by points: if/else 19, loops 17, boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilRemarkupCodeBlockRule.markupText (cognitive 37) src/infrastructure/markup/blockrule/PhutilRemarkupCodeBlockRule.php:46— PhutilRemarkupCodeBlockRule.markupText has cognitive complexity 37 (threshold 15). Drivers by points: if/else 30, loops 6, boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorActionView.render (cognitive 37) src/view/layout/PhabricatorActionView.php:198— PhabricatorActionView.render has cognitive complexity 37 (threshold 15). Drivers by points: if/else 34, loops 2, ternaries 1 (nesting depth added 9). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ConpherenceTransactionRenderer.renderTransactions (cognitive 36) src/applications/conpherence/ConpherenceTransactionRenderer.php:5— ConpherenceTransactionRenderer.renderTransactions has cognitive complexity 36 (threshold 15). Drivers by points: if/else 33, loops 2, boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialTransactionEditor.buildMailBody (cognitive 36) src/applications/differential/editor/DifferentialTransactionEditor.php:662— DifferentialTransactionEditor.buildMailBody has cognitive complexity 36 (threshold 15). Drivers by points: if/else 25, boolean chains 4, error handling 3, loops 2, match/switch 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialRevisionListView.render (cognitive 36) src/applications/differential/view/DifferentialRevisionListView.php:50— DifferentialRevisionListView.render has cognitive complexity 36 (threshold 15). Drivers by points: if/else 29, loops 6, boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialRevisionReviewTransaction.applyReviewerEffect (cognitive 36) src/applications/differential/xaction/DifferentialRevisionReviewTransaction.php:163— DifferentialRevisionReviewTransaction.applyReviewerEffect has cognitive complexity 36 (threshold 15). Drivers by points: if/else 29, loops 4, error handling 3 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionCommitController.buildPropertyListView (cognitive 36) src/applications/diffusion/controller/DiffusionCommitController.php:524— DiffusionCommitController.buildPropertyListView has cognitive complexity 36 (threshold 15). Drivers by points: if/else 25, loops 10, boolean chains 1 (nesting depth added 10). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PhabricatorFileViewController.buildPropertyViews (cognitive 36) src/applications/files/controller/PhabricatorFileViewController.php:218— PhabricatorFileViewController.buildPropertyViews has cognitive complexity 36 (threshold 15). Drivers by points: if/else 24, ternaries 6, boolean chains 3, loops 3 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HarbormasterBuildEngine.updateBuildable (cognitive 36) src/applications/harbormaster/engine/HarbormasterBuildEngine.php:442— HarbormasterBuildEngine.updateBuildable has cognitive complexity 36 (threshold 15). Drivers by points: if/else 29, loops 3, boolean chains 2, match/switch 2 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProjectEditPictureController.handleRequest (cognitive 36) src/applications/project/controller/PhabricatorProjectEditPictureController.php:6— PhabricatorProjectEditPictureController.handleRequest has cognitive complexity 36 (threshold 15). Drivers by points: if/else 33, loops 2, boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorSubscriptionsHeraldAction.applySubscribe (cognitive 36) src/applications/subscriptions/herald/PhabricatorSubscriptionsHeraldAction.php:19— PhabricatorSubscriptionsHeraldAction.applySubscribe has cognitive complexity 36 (threshold 15). Drivers by points: if/else 29, loops 7 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilXHPASTSyntaxHighlighterFuture.applyXHPHighlight (cognitive 36) src/infrastructure/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php:31— PhutilXHPASTSyntaxHighlighterFuture.applyXHPHighlight has cognitive complexity 36 (threshold 15). Drivers by points: if/else 28, loops 4, match/switch 3, boolean chains 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorStandardPageView.willRenderPage (cognitive 36) src/view/page/PhabricatorStandardPageView.php:199— PhabricatorStandardPageView.willRenderPage has cognitive complexity 36 (threshold 15). Drivers by points: if/else 28, ternaries 8 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorAuthLoginController.handleRequest (cognitive 35) src/applications/auth/controller/PhabricatorAuthLoginController.php:28— PhabricatorAuthLoginController.handleRequest has cognitive complexity 35 (threshold 15). Drivers by points: if/else 33, boolean chains 1, error handling 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorDuoAuthFactor.processAddFactorForm (cognitive 35) src/applications/auth/factor/PhabricatorDuoAuthFactor.php:155— PhabricatorDuoAuthFactor.processAddFactorForm has cognitive complexity 35 (threshold 15). Drivers by points: if/else 23, match/switch 8, ternaries 3, boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilCalendarRecurrenceRule.newYearMap (cognitive 35) src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php:1349— PhutilCalendarRecurrenceRule.newYearMap has cognitive complexity 35 (threshold 15). Drivers by points: if/else 27, loops 5, boolean chains 2, ternaries 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorWebServerSetupCheck.executeChecks (cognitive 35) src/applications/config/check/PhabricatorWebServerSetupCheck.php:9— PhabricatorWebServerSetupCheck.executeChecks has cognitive complexity 35 (threshold 15). Drivers by points: if/else 25, boolean chains 5, error handling 3, loops 2 (nesting depth added 5). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PhabricatorConfigEditController.handleRequest (cognitive 35) src/applications/config/controller/settings/PhabricatorConfigEditController.php:6— PhabricatorConfigEditController.handleRequest has cognitive complexity 35 (threshold 15). Drivers by points: if/else 29, error handling 3, boolean chains 2, loops 1 (nesting depth added 7). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ConpherenceRoomPictureController.handleRequest (cognitive 35) src/applications/conpherence/controller/ConpherenceRoomPictureController.php:6— ConpherenceRoomPictureController.handleRequest has cognitive complexity 35 (threshold 15). Drivers by points: if/else 33, boolean chains 1, loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialTransactionEditor.updateReviewStatus (cognitive 35) src/applications/differential/editor/DifferentialTransactionEditor.php:403— DifferentialTransactionEditor.updateReviewStatus has cognitive complexity 35 (threshold 15). Drivers by points: if/else 27, boolean chains 5, match/switch 2, loops 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DivinerAtomQuery.buildWhereClause (cognitive 35) src/applications/diviner/query/DivinerAtomQuery.php:302— DivinerAtomQuery.buildWhereClause has cognitive complexity 35 (threshold 15). Drivers by points: if/else 30, loops 4, boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorFileQuery.loadPage (cognitive 35) src/applications/files/query/PhabricatorFileQuery.php:166— PhabricatorFileQuery.loadPage has cognitive complexity 35 (threshold 15). Drivers by points: if/else 25, loops 10 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorMailEmailEngine.newMessage (cognitive 35) src/applications/metamta/engine/PhabricatorMailEmailEngine.php:6— PhabricatorMailEmailEngine.newMessage has cognitive complexity 35 (threshold 15). Drivers by points: if/else 27, loops 5, boolean chains 3 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorMetaMTAMemberQuery.execute (cognitive 35) src/applications/metamta/query/PhabricatorMetaMTAMemberQuery.php:26— PhabricatorMetaMTAMemberQuery.execute has cognitive complexity 35 (threshold 15). Drivers by points: loops 24, if/else 9, match/switch 2 (nesting depth added 20). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PhameBlogProfilePictureController.handleRequest (cognitive 35) src/applications/phame/controller/blog/PhameBlogProfilePictureController.php:6— PhameBlogProfilePictureController.handleRequest has cognitive complexity 35 (threshold 15). Drivers by points: if/else 33, boolean chains 1, loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhrequentUserTimeQuery.didFilterPage (cognitive 35) src/applications/phrequent/query/PhrequentUserTimeQuery.php:159— PhrequentUserTimeQuery.didFilterPage has cognitive complexity 35 (threshold 15). Drivers by points: if/else 26, loops 7, boolean chains 2 (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProjectSearchEngine.buildQueryFromParameters (cognitive 35) src/applications/project/query/PhabricatorProjectSearchEngine.php:130— PhabricatorProjectSearchEngine.buildQueryFromParameters has cognitive complexity 35 (threshold 15). Drivers by points: if/else 32, boolean chains 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorSearchRelationshipController.handleRequest (cognitive 35) src/applications/search/controller/PhabricatorSearchRelationshipController.php:6— PhabricatorSearchRelationshipController.handleRequest has cognitive complexity 35 (threshold 15). Drivers by points: if/else 23, loops 5, error handling 4, boolean chains 3 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHUICalendarMonthView.render (cognitive 35) src/view/phui/calendar/PHUICalendarMonthView.php:53— PHUICalendarMonthView.render has cognitive complexity 35 (threshold 15). Drivers by points: if/else 22, loops 12, boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
redraw (cognitive 35) webroot/rsrc/js/application/diff/DiffTreeView.js:87— redraw has cognitive complexity 35 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHPMailerLite.MailSend (cognitive 34) externals/phpmailer/class.phpmailer-lite.php:649— PHPMailerLite.MailSend has cognitive complexity 34 (threshold 15). Drivers by points: ternaries 14, if/else 10, loops 7, boolean chains 3 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHPMailer.MailSend (cognitive 34) externals/phpmailer/class.phpmailer.php:628— PHPMailer.MailSend has cognitive complexity 34 (threshold 15). Drivers by points: ternaries 14, if/else 10, loops 7, boolean chains 3 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorConfigSchemaQuery.loadActualSchemaForServer (cognitive 34) src/applications/config/schema/PhabricatorConfigSchemaQuery.php:64— PhabricatorConfigSchemaQuery.loadActualSchemaForServer has cognitive complexity 34 (threshold 15). Drivers by points: loops 16, if/else 14, error handling 4 (nesting depth added 18). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
DifferentialChangesetParser.newDocumentEngine (cognitive 34) src/applications/differential/parser/DifferentialChangesetParser.php:1746— DifferentialChangesetParser.newDocumentEngine has cognitive complexity 34 (threshold 15). Drivers by points: if/else 32, boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DivinerPHPAtomizer.executeAtomize (cognitive 34) src/applications/diviner/atomizer/DivinerPHPAtomizer.php:9— DivinerPHPAtomizer.executeAtomize has cognitive complexity 34 (threshold 15). Drivers by points: loops 21, if/else 7, match/switch 6 (nesting depth added 22). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PhabricatorFilesManagementRebuildWorkflow.execute (cognitive 34) src/applications/files/management/PhabricatorFilesManagementRebuildWorkflow.php:30— PhabricatorFilesManagementRebuildWorkflow.execute has cognitive complexity 34 (threshold 15). Drivers by points: if/else 25, loops 5, error handling 3, boolean chains 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ManiphestConduitAPIMethod.applyRequest (cognitive 34) src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php:53— ManiphestConduitAPIMethod.applyRequest has cognitive complexity 34 (threshold 15). Drivers by points: if/else 30, loops 3, boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NuanceGitHubImportCursor.pullDataFromSource (cognitive 34) src/applications/nuance/cursor/NuanceGitHubImportCursor.php:56— NuanceGitHubImportCursor.pullDataFromSource has cognitive complexity 34 (threshold 15). Drivers by points: if/else 26, loops 8 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhortuneMerchantPictureController.handleMerchantRequest (cognitive 34) src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php:10— PhortuneMerchantPictureController.handleMerchantRequest has cognitive complexity 34 (threshold 15). Drivers by points: if/else 32, boolean chains 1, loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhrequentTrackController.processRequest (cognitive 34) src/applications/phrequent/controller/PhrequentTrackController.php:14— PhrequentTrackController.processRequest has cognitive complexity 34 (threshold 15). Drivers by points: if/else 33, match/switch 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProjectTriggerSearchEngine.renderResultList (cognitive 34) src/applications/project/query/PhabricatorProjectTriggerSearchEngine.php:72— PhabricatorProjectTriggerSearchEngine.renderResultList has cognitive complexity 34 (threshold 15). Drivers by points: if/else 32, loops 2 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorApplicationTransactionEditor.addHeadersAndCommentsToMailBody (cognitive 34) src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:3859— PhabricatorApplicationTransactionEditor.addHeadersAndCommentsToMailBody has cognitive complexity 34 (threshold 15). Drivers by points: if/else 28, loops 4, boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilRemarkupSimpleTableBlockRule.markupText (cognitive 34) src/infrastructure/markup/blockrule/PhutilRemarkupSimpleTableBlockRule.php:19— PhutilRemarkupSimpleTableBlockRule.markupText has cognitive complexity 34 (threshold 15). Drivers by points: if/else 26, loops 7, boolean chains 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
render.phutil_escape_html (cognitive 34) src/infrastructure/markup/render.php:107— render.phutil_escape_html has cognitive complexity 34 (threshold 15). Drivers by points: if/else 24, error handling 6, loops 4 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SMTP.Data (cognitive 33) externals/phpmailer/class.smtp.php:326— SMTP.Data has cognitive complexity 33 (threshold 15). Drivers by points: if/else 26, loops 5, boolean chains 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionCommitHookEngine.findGitChangeFlags (cognitive 33) src/applications/diffusion/engine/DiffusionCommitHookEngine.php:526— DiffusionCommitHookEngine.findGitChangeFlags has cognitive complexity 33 (threshold 15). Drivers by points: if/else 31, boolean chains 1, loops 1 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionRepositoryClusterEngine.synchronizeWorkingCopyBeforeRead (cognitive 33) src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php:153— DiffusionRepositoryClusterEngine.synchronizeWorkingCopyBeforeRead has cognitive complexity 33 (threshold 15). Drivers by points: if/else 25, loops 6, boolean chains 1, error handling 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HeraldTranscriptController.buildActionTranscriptPanel (cognitive 33) src/applications/herald/controller/HeraldTranscriptController.php:226— HeraldTranscriptController.buildActionTranscriptPanel has cognitive complexity 33 (threshold 15). Drivers by points: if/else 25, loops 8 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhluxEditController.handleRequest (cognitive 33) src/applications/phlux/controller/PhluxEditController.php:5— PhluxEditController.handleRequest has cognitive complexity 33 (threshold 15). Drivers by points: if/else 27, error handling 3, boolean chains 2, ternaries 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorPhortuneManagementInvoiceWorkflow.execute (cognitive 33) src/applications/phortune/management/PhabricatorPhortuneManagementInvoiceWorkflow.php:49— PhabricatorPhortuneManagementInvoiceWorkflow.execute has cognitive complexity 33 (threshold 15). Drivers by points: if/else 25, boolean chains 7, ternaries 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositorySvnCommitChangeParserWorker.parseRecursiveListFileData (cognitive 33) src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php:676— PhabricatorRepositorySvnCommitChangeParserWorker.parseRecursiveListFileData has cognitive complexity 33 (threshold 15). Drivers by points: if/else 30, match/switch 2, loops 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorApplicationSearchController.newQueryListView (cognitive 33) src/applications/search/controller/PhabricatorApplicationSearchController.php:621— PhabricatorApplicationSearchController.newQueryListView has cognitive complexity 33 (threshold 15). Drivers by points: if/else 31, boolean chains 1, loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorFerretFulltextEngineExtension.indexFulltextObject (cognitive 33) src/applications/search/engineextension/PhabricatorFerretFulltextEngineExtension.php:19— PhabricatorFerretFulltextEngineExtension.indexFulltextObject has cognitive complexity 33 (threshold 15). Drivers by points: if/else 21, loops 6, match/switch 4, error handling 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorDatabaseRef.queryRefs (cognitive 33) src/infrastructure/cluster/PhabricatorDatabaseRef.php:342— PhabricatorDatabaseRef.queryRefs has cognitive complexity 33 (threshold 15). Drivers by points: if/else 24, error handling 6, boolean chains 2, loops 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilRemarkupListBlockRule.getMatchingLineCount (cognitive 33) src/infrastructure/markup/blockrule/PhutilRemarkupListBlockRule.php:13— PhutilRemarkupListBlockRule.getMatchingLineCount has cognitive complexity 33 (threshold 15). Drivers by points: if/else 28, boolean chains 4, loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_getFragmentLocation (cognitive 33) webroot/rsrc/js/application/diff/DiffChangesetList.js:2643— _getFragmentLocation has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialRevisionViewController.getOldDiffID (cognitive 32) src/applications/differential/controller/DifferentialRevisionViewController.php:1321— DifferentialRevisionViewController.getOldDiffID has cognitive complexity 32 (threshold 15). Drivers by points: if/else 24, loops 7, boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialLocalCommitsView.render (cognitive 32) src/applications/differential/view/DifferentialLocalCommitsView.php:19— DifferentialLocalCommitsView.render has cognitive complexity 32 (threshold 15). Drivers by points: if/else 27, loops 4, boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorFilesManagementMigrateWorkflow.execute (cognitive 32) src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php:57— PhabricatorFilesManagementMigrateWorkflow.execute has cognitive complexity 32 (threshold 15). Drivers by points: if/else 25, error handling 4, boolean chains 2, loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ManiphestTaskQuery.buildWhereClauseParts (cognitive 32) src/applications/maniphest/query/ManiphestTaskQuery.php:354— ManiphestTaskQuery.buildWhereClauseParts has cognitive complexity 32 (threshold 15). Drivers by points: if/else 25, loops 7 (nesting depth added 9). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PhutilDaemonOverseer.run (cognitive 32) src/infrastructure/daemon/PhutilDaemonOverseer.php:162— PhutilDaemonOverseer.run has cognitive complexity 32 (threshold 15). Drivers by points: if/else 28, loops 3, boolean chains 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorTaskmasterDaemon.run (cognitive 32) src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php:5— PhabricatorTaskmasterDaemon.run has cognitive complexity 32 (threshold 15). Drivers by points: if/else 28, loops 4 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilRemarkupBlockRule.renderRemarkupTable (cognitive 32) src/infrastructure/markup/blockrule/PhutilRemarkupBlockRule.php:105— PhutilRemarkupBlockRule.renderRemarkupTable has cognitive complexity 32 (threshold 15). Drivers by points: loops 17, if/else 10, ternaries 5 (nesting depth added 19). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PhabricatorMainMenuView.render (cognitive 32) src/view/page/menu/PhabricatorMainMenuView.php:51— PhabricatorMainMenuView.render has cognitive complexity 32 (threshold 15). Drivers by points: if/else 24, loops 8 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorConduitAPIController.handleRequest (cognitive 31) src/applications/conduit/controller/PhabricatorConduitAPIController.php:10— PhabricatorConduitAPIController.handleRequest has cognitive complexity 31 (threshold 15). Drivers by points: if/else 25, error handling 3, boolean chains 1, match/switch 1, ternaries 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorBinariesSetupCheck.executeChecks (cognitive 31) src/applications/config/check/PhabricatorBinariesSetupCheck.php:9— PhabricatorBinariesSetupCheck.executeChecks has cognitive complexity 31 (threshold 15). Drivers by points: if/else 23, loops 4, match/switch 4 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorDashboardPanelsTransaction.validateTransactions (cognitive 31) src/applications/dashboard/xaction/dashboard/PhabricatorDashboardPanelsTransaction.php:22— PhabricatorDashboardPanelsTransaction.validateTransactions has cognitive complexity 31 (threshold 15). Drivers by points: if/else 22, loops 6, error handling 3 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialCommitMessageParser.parseCorpus (cognitive 31) src/applications/differential/parser/DifferentialCommitMessageParser.php:136— DifferentialCommitMessageParser.parseCorpus has cognitive complexity 31 (threshold 15). Drivers by points: if/else 23, loops 5, boolean chains 3 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialLineAdjustmentMap.mapLine (cognitive 31) src/applications/differential/parser/DifferentialLineAdjustmentMap.php:65— DifferentialLineAdjustmentMap.mapLine has cognitive complexity 31 (threshold 15). Drivers by points: if/else 25, loops 4, boolean chains 2 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionLintSaveRunner.run (cognitive 31) src/applications/diffusion/DiffusionLintSaveRunner.php:45— DiffusionLintSaveRunner.run has cognitive complexity 31 (threshold 15). Drivers by points: if/else 26, error handling 2, ternaries 2, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionRepositoryURIViewController.buildPropertySection (cognitive 31) src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php:178— DiffusionRepositoryURIViewController.buildPropertySection has cognitive complexity 31 (threshold 15). Drivers by points: if/else 31 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HeraldEngine.isForbidden (cognitive 31) src/applications/herald/engine/HeraldEngine.php:790— HeraldEngine.isForbidden has cognitive complexity 31 (threshold 15). Drivers by points: if/else 17, loops 8, error handling 6 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LegalpadDocumentSignatureAddController.handleRequest (cognitive 31) src/applications/legalpad/controller/LegalpadDocumentSignatureAddController.php:5— LegalpadDocumentSignatureAddController.handleRequest has cognitive complexity 31 (threshold 15). Drivers by points: if/else 31 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorLipsumGenerateWorkflow.execute (cognitive 31) src/applications/lipsum/management/PhabricatorLipsumGenerateWorkflow.php:31— PhabricatorLipsumGenerateWorkflow.execute has cognitive complexity 31 (threshold 15). Drivers by points: if/else 23, loops 8 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ManiphestTaskStatus.validateConfiguration (cognitive 31) src/applications/maniphest/constants/ManiphestTaskStatus.php:261— ManiphestTaskStatus.validateConfiguration has cognitive complexity 31 (threshold 15). Drivers by points: if/else 23, loops 4, boolean chains 2, match/switch 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorPeopleSearchEngine.renderResultList (cognitive 31) src/applications/people/query/PhabricatorPeopleSearchEngine.php:233— PhabricatorPeopleSearchEngine.renderResultList has cognitive complexity 31 (threshold 15). Drivers by points: if/else 28, boolean chains 2, loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorPeopleDatasource.loadResults (cognitive 31) src/applications/people/typeahead/PhabricatorPeopleDatasource.php:18— PhabricatorPeopleDatasource.loadResults has cognitive complexity 31 (threshold 15). Drivers by points: if/else 29, boolean chains 1, loops 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProjectBoardReorderController.handleRequest (cognitive 31) src/applications/project/controller/PhabricatorProjectBoardReorderController.php:6— PhabricatorProjectBoardReorderController.handleRequest has cognitive complexity 31 (threshold 15). Drivers by points: if/else 24, loops 5, boolean chains 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProjectQuery.buildWhereClauseParts (cognitive 31) src/applications/project/query/PhabricatorProjectQuery.php:457— PhabricatorProjectQuery.buildWhereClauseParts has cognitive complexity 31 (threshold 15). Drivers by points: if/else 25, loops 4, match/switch 2 (nesting depth added 5). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PhabricatorSearchResultView.emboldenQuery (cognitive 31) src/applications/search/view/PhabricatorSearchResultView.php:59— PhabricatorSearchResultView.emboldenQuery has cognitive complexity 31 (threshold 15). Drivers by points: if/else 22, loops 7, match/switch 2 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorApplicationTransactionEditor.mergePHIDOrEdgeTransactions (cognitive 31) src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:2481— PhabricatorApplicationTransactionEditor.mergePHIDOrEdgeTransactions has cognitive complexity 31 (threshold 15). Drivers by points: if/else 26, loops 5 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorJavelinLinter.lintPath (cognitive 31) src/infrastructure/lint/linter/PhabricatorJavelinLinter.php:104— PhabricatorJavelinLinter.lintPath has cognitive complexity 31 (threshold 15). Drivers by points: if/else 22, loops 7, boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorManagementWorkflow.loadUsersFromArguments (cognitive 31) src/infrastructure/management/PhabricatorManagementWorkflow.php:70— PhabricatorManagementWorkflow.loadUsersFromArguments has cognitive complexity 31 (threshold 15). Drivers by points: if/else 17, loops 13, boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilXHPASTSyntaxHighlighterFuture.findInterestingSymbols (cognitive 31) src/infrastructure/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php:164— PhutilXHPASTSyntaxHighlighterFuture.findInterestingSymbols has cognitive complexity 31 (threshold 15). Drivers by points: loops 15, if/else 14, boolean chains 2 (nesting depth added 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PhabricatorCursorPagedPolicyAwareQuery.buildEdgeLogicWhereClause (cognitive 31) src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:2814— PhabricatorCursorPagedPolicyAwareQuery.buildEdgeLogicWhereClause has cognitive complexity 31 (threshold 15). Drivers by points: if/else 15, loops 12, match/switch 3, boolean chains 1 (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorSourceCodeView.render (cognitive 31) src/view/layout/PhabricatorSourceCodeView.php:72— PhabricatorSourceCodeView.render has cognitive complexity 31 (threshold 15). Drivers by points: if/else 28, loops 3 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHPMailer.SmtpConnect (cognitive 30) externals/phpmailer/class.phpmailer.php:756— PHPMailer.SmtpConnect has cognitive complexity 30 (threshold 15). Drivers by points: if/else 22, ternaries 5, boolean chains 1, error handling 1, loops 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorCalendarEventViewController.buildPropertySection (cognitive 30) src/applications/calendar/controller/PhabricatorCalendarEventViewController.php:275— PhabricatorCalendarEventViewController.buildPropertySection has cognitive complexity 30 (threshold 15). Drivers by points: if/else 25, loops 5 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorConfigManagementSetWorkflow.execute (cognitive 30) src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php:32— PhabricatorConfigManagementSetWorkflow.execute has cognitive complexity 30 (threshold 15). Drivers by points: if/else 18, match/switch 6, error handling 5, boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorDashboardObjectInstallWorkflow.handleRequest (cognitive 30) src/applications/dashboard/install/PhabricatorDashboardObjectInstallWorkflow.php:10— PhabricatorDashboardObjectInstallWorkflow.handleRequest has cognitive complexity 30 (threshold 15). Drivers by points: if/else 28, boolean chains 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialQueryConduitAPIMethod.execute (cognitive 30) src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php:65— DifferentialQueryConduitAPIMethod.execute has cognitive complexity 30 (threshold 15). Drivers by points: if/else 25, loops 3, boolean chains 2 (nesting depth added 6). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DifferentialTransactionEditor.expandTransaction (cognitive 30) src/applications/differential/editor/DifferentialTransactionEditor.php:152— DifferentialTransactionEditor.expandTransaction has cognitive complexity 30 (threshold 15). Drivers by points: if/else 24, match/switch 5, boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialDiffExtractionEngine.isDiffChangedBeforeCommit (cognitive 30) src/applications/differential/engine/DifferentialDiffExtractionEngine.php:119— DifferentialDiffExtractionEngine.isDiffChangedBeforeCommit has cognitive complexity 30 (threshold 15). Drivers by points: if/else 22, loops 4, error handling 3, boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionLocalRepositoryFilter.execute (cognitive 30) src/applications/diffusion/data/DiffusionLocalRepositoryFilter.php:50— DiffusionLocalRepositoryFilter.execute has cognitive complexity 30 (threshold 15). Drivers by points: if/else 26, loops 4 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorFactDatapointQuery.execute (cognitive 30) src/applications/fact/query/PhabricatorFactDatapointQuery.php:34— PhabricatorFactDatapointQuery.execute has cognitive complexity 30 (threshold 15). Drivers by points: if/else 23, loops 6, boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorPeopleQuery.fillUserCaches (cognitive 30) src/applications/people/query/PhabricatorPeopleQuery.php:514— PhabricatorPeopleQuery.fillUserCaches has cognitive complexity 30 (threshold 15). Drivers by points: if/else 18, loops 10, boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositoryPullEngine.executeGitUpdate (cognitive 30) src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:275— PhabricatorRepositoryPullEngine.executeGitUpdate has cognitive complexity 30 (threshold 15). Drivers by points: if/else 26, loops 3, boolean chains 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositoryPushMailWorker.renderRefs (cognitive 30) src/applications/repository/worker/PhabricatorRepositoryPushMailWorker.php:135— PhabricatorRepositoryPushMailWorker.renderRefs has cognitive complexity 30 (threshold 15). Drivers by points: if/else 27, match/switch 2, loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilRemarkupLiteralBlockRule.getMatchingLineCount (cognitive 30) src/infrastructure/markup/blockrule/PhutilRemarkupLiteralBlockRule.php:9— PhutilRemarkupLiteralBlockRule.getMatchingLineCount has cognitive complexity 30 (threshold 15). Drivers by points: if/else 28, boolean chains 1, loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHUITimelineEventView.renderExtra (cognitive 30) src/view/phui/PHUITimelineEventView.php:560— PHUITimelineEventView.renderExtra has cognitive complexity 30 (threshold 15). Drivers by points: if/else 26, loops 4 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
getSelectableItems (cognitive 30) webroot/rsrc/js/application/diff/DiffChangeset.js:435— getSelectableItems has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Text_Figlet._rep (cognitive 29) externals/pear-figlet/Text/Figlet.php:390— Text_Figlet._rep has cognitive complexity 29 (threshold 15). Drivers by points: if/else 19, boolean chains 6, ternaries 4 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHPMailerLite.EncodeQPphp (cognitive 29) externals/phpmailer/class.phpmailer-lite.php:1489— PHPMailerLite.EncodeQPphp has cognitive complexity 29 (threshold 15). Drivers by points: if/else 23, boolean chains 3, loops 3 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHPMailer.EncodeQPphp (cognitive 29) externals/phpmailer/class.phpmailer.php:1621— PHPMailer.EncodeQPphp has cognitive complexity 29 (threshold 15). Drivers by points: if/else 23, boolean chains 3, loops 3 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorAuthPasswordEngine.checkNewPassword (cognitive 29) src/applications/auth/engine/PhabricatorAuthPasswordEngine.php:57— PhabricatorAuthPasswordEngine.checkNewPassword has cognitive complexity 29 (threshold 15). Drivers by points: if/else 21, loops 7, boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorPasswordAuthProvider.processLoginRequest (cognitive 29) src/applications/auth/provider/PhabricatorPasswordAuthProvider.php:251— PhabricatorPasswordAuthProvider.processLoginRequest has cognitive complexity 29 (threshold 15). Drivers by points: if/else 23, ternaries 3, error handling 2, boolean chains 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilCalendarRecurrenceRule.advanceCursorState (cognitive 29) src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php:1685— PhutilCalendarRecurrenceRule.advanceCursorState has cognitive complexity 29 (threshold 15). Drivers by points: if/else 13, loops 10, match/switch 6 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorConduitMethodQuery.filterMethods (cognitive 29) src/applications/conduit/query/PhabricatorConduitMethodQuery.php:57— PhabricatorConduitMethodQuery.filterMethods has cognitive complexity 29 (threshold 15). Drivers by points: if/else 20, loops 9 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorDashboardPanelTabsController.handleMoveOperation (cognitive 29) src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php:301— PhabricatorDashboardPanelTabsController.handleMoveOperation has cognitive complexity 29 (threshold 15). Drivers by points: if/else 24, boolean chains 3, loops 2 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionGitUploadPackWireProtocol.newProtocolRefMessage (cognitive 29) src/applications/diffusion/protocol/DiffusionGitUploadPackWireProtocol.php:165— DiffusionGitUploadPackWireProtocol.newProtocolRefMessage has cognitive complexity 29 (threshold 15). Drivers by points: if/else 26, loops 3 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionLowLevelGitRefQuery.executeQuery (cognitive 29) src/applications/diffusion/query/lowlevel/DiffusionLowLevelGitRefQuery.php:16— DiffusionLowLevelGitRefQuery.executeQuery has cognitive complexity 29 (threshold 15). Drivers by points: if/else 27, boolean chains 1, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionSourceLinkRemarkupRule.didMarkupText (cognitive 29) src/applications/diffusion/remarkup/DiffusionSourceLinkRemarkupRule.php:46— DiffusionSourceLinkRemarkupRule.didMarkupText has cognitive complexity 29 (threshold 15). Drivers by points: if/else 25, loops 4 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HeraldAction.loadStandardTargets (cognitive 29) src/applications/herald/action/HeraldAction.php:206— HeraldAction.loadStandardTargets has cognitive complexity 29 (threshold 15). Drivers by points: if/else 23, loops 5, boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorApplicationEditController.handleRequest (cognitive 29) src/applications/meta/controller/PhabricatorApplicationEditController.php:6— PhabricatorApplicationEditController.handleRequest has cognitive complexity 29 (threshold 15). Drivers by points: if/else 23, loops 3, error handling 2, boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorMailReplyHandler.expandRecipientPHIDs (cognitive 29) src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php:281— PhabricatorMailReplyHandler.expandRecipientPHIDs has cognitive complexity 29 (threshold 15). Drivers by points: if/else 19, loops 10 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhrictionRemarkupRule.markupDocumentLink (cognitive 29) src/applications/phriction/markup/PhrictionRemarkupRule.php:18— PhrictionRemarkupRule.markupDocumentLink has cognitive complexity 29 (threshold 15). Drivers by points: if/else 25, loops 3, boolean chains 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilDaemonHandle.update (cognitive 29) src/infrastructure/daemon/PhutilDaemonHandle.php:136— PhutilDaemonHandle.update has cognitive complexity 29 (threshold 15). Drivers by points: if/else 21, error handling 4, boolean chains 2, loops 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorObjectGraph.newGraphTable (cognitive 29) src/infrastructure/graph/PhabricatorObjectGraph.php:163— PhabricatorObjectGraph.newGraphTable has cognitive complexity 29 (threshold 15). Drivers by points: if/else 21, loops 8 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
markup.javelin_tag (cognitive 29) src/infrastructure/javelin/markup.php:3— markup.javelin_tag has cognitive complexity 29 (threshold 15). Drivers by points: if/else 22, match/switch 3, boolean chains 2, loops 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilRemarkupEngine.splitTextIntoBlocks (cognitive 29) src/infrastructure/markup/remarkup/PhutilRemarkupEngine.php:156— PhutilRemarkupEngine.splitTextIntoBlocks has cognitive complexity 29 (threshold 15). Drivers by points: if/else 19, loops 9, boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorCursorPagedPolicyAwareQuery.validateEdgeLogicConstraints (cognitive 29) src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:3000— PhabricatorCursorPagedPolicyAwareQuery.validateEdgeLogicConstraints has cognitive complexity 29 (threshold 15). Drivers by points: if/else 13, loops 8, match/switch 6, boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHUIObjectBoxView.getTagContent (cognitive 29) src/view/phui/PHUIObjectBoxView.php:181— PHUIObjectBoxView.getTagContent has cognitive complexity 29 (threshold 15). Drivers by points: if/else 18, ternaries 6, loops 4, boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHUIPagerView.render (cognitive 29) src/view/phui/PHUIPagerView.php:119— PHUIPagerView.render has cognitive complexity 29 (threshold 15). Drivers by points: if/else 22, loops 4, ternaries 2, boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHUITimelineView.buildEvents (cognitive 29) src/view/phui/PHUITimelineView.php:101— PHUITimelineView.buildEvents has cognitive complexity 29 (threshold 15). Drivers by points: if/else 25, match/switch 2, boolean chains 1, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
xhprof_lib.xhprof_prune_run (cognitive 28) externals/xhprof/xhprof_lib.php:563— xhprof_lib.xhprof_prune_run has cognitive complexity 28 (threshold 15). Drivers by points: if/else 19, loops 7, boolean chains 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AphrontHTTPHeaderParser.getHeaderContentAsPairs (cognitive 28) src/aphront/headerparser/AphrontHTTPHeaderParser.php:34— AphrontHTTPHeaderParser.getHeaderContentAsPairs has cognitive complexity 28 (threshold 15). Drivers by points: if/else 23, boolean chains 2, match/switch 2, loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorPHPPreflightSetupCheck.executeChecks (cognitive 28) src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php:13— PhabricatorPHPPreflightSetupCheck.executeChecks has cognitive complexity 28 (threshold 15). Drivers by points: if/else 21, loops 5, boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialDiffCreateController.handleRequest (cognitive 28) src/applications/differential/controller/DifferentialDiffCreateController.php:5— DifferentialDiffCreateController.handleRequest has cognitive complexity 28 (threshold 15). Drivers by points: if/else 25, error handling 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialTransactionEditor.didApplyTransactions (cognitive 28) src/applications/differential/editor/DifferentialTransactionEditor.php:1529— DifferentialTransactionEditor.didApplyTransactions has cognitive complexity 28 (threshold 15). Drivers by points: if/else 22, boolean chains 6 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialRevisionQuery.buildWhereClause (cognitive 28) src/applications/differential/query/DifferentialRevisionQuery.php:630— DifferentialRevisionQuery.buildWhereClause has cognitive complexity 28 (threshold 15). Drivers by points: if/else 26, loops 2 (nesting depth added 6). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DifferentialChangesetOneUpMailRenderer.renderPrimitives (cognitive 28) src/applications/differential/render/DifferentialChangesetOneUpMailRenderer.php:43— DifferentialChangesetOneUpMailRenderer.renderPrimitives has cognitive complexity 28 (threshold 15). Drivers by points: if/else 21, loops 4, match/switch 2, boolean chains 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialRevisionReviewTransaction.isViewerReviewerStatusFully (cognitive 28) src/applications/differential/xaction/DifferentialRevisionReviewTransaction.php:97— DifferentialRevisionReviewTransaction.isViewerReviewerStatusFully has cognitive complexity 28 (threshold 15). Drivers by points: if/else 27, loops 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionBlameController.handleRequest (cognitive 28) src/applications/diffusion/controller/DiffusionBlameController.php:9— DiffusionBlameController.handleRequest has cognitive complexity 28 (threshold 15). Drivers by points: if/else 21, loops 5, ternaries 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionCompareController.handleRequest (cognitive 28) src/applications/diffusion/controller/DiffusionCompareController.php:9— DiffusionCompareController.handleRequest has cognitive complexity 28 (threshold 15). Drivers by points: if/else 25, boolean chains 2, error handling 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HeraldRuleController.setupEditorBehavior (cognitive 28) src/applications/herald/controller/HeraldRuleController.php:400— HeraldRuleController.setupEditorBehavior has cognitive complexity 28 (threshold 15). Drivers by points: if/else 13, loops 11, error handling 4 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ManiphestTransactionEditor.getLockValidationErrors (cognitive 28) src/applications/maniphest/editor/ManiphestTransactionEditor.php:774— ManiphestTransactionEditor.getLockValidationErrors has cognitive complexity 28 (threshold 15). Drivers by points: if/else 23, boolean chains 2, match/switch 2, loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ManiphestTaskSearchEngine.buildQueryFromParameters (cognitive 28) src/applications/maniphest/query/ManiphestTaskSearchEngine.php:190— ManiphestTaskSearchEngine.buildQueryFromParameters has cognitive complexity 28 (threshold 15). Drivers by points: if/else 24, boolean chains 2, loops 2 (nesting depth added 4). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.execute (cognitive 28) src/applications/repository/management/PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.php:63— PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.execute has cognitive complexity 28 (threshold 15). Drivers by points: if/else 19, loops 5, boolean chains 4 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositoryManagementUnpublishWorkflow.unpublishEdgeTransaction (cognitive 28) src/applications/repository/management/PhabricatorRepositoryManagementUnpublishWorkflow.php:154— PhabricatorRepositoryManagementUnpublishWorkflow.unpublishEdgeTransaction has cognitive complexity 28 (threshold 15). Drivers by points: if/else 21, loops 7 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRepositoryGitCommitChangeParserWorker.parseCommitChanges (cognitive 28) src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php:6— PhabricatorRepositoryGitCommitChangeParserWorker.parseCommitChanges has cognitive complexity 28 (threshold 15). Drivers by points: if/else 16, loops 6, match/switch 4, ternaries 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorApplicationTransactionView.buildEvents (cognitive 28) src/applications/transactions/view/PhabricatorApplicationTransactionView.php:129— PhabricatorApplicationTransactionView.buildEvents has cognitive complexity 28 (threshold 15). Drivers by points: if/else 18, loops 8, boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilRemarkupTableBlockRule.newTable (cognitive 28) src/infrastructure/markup/blockrule/PhutilRemarkupTableBlockRule.php:63— PhutilRemarkupTableBlockRule.newTable has cognitive complexity 28 (threshold 15). Drivers by points: if/else 20, loops 7, boolean chains 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorCursorPagedPolicyAwareQuery.buildApplicationSearchJoinClause (cognitive 28) src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:1535— PhabricatorCursorPagedPolicyAwareQuery.buildApplicationSearchJoinClause has cognitive complexity 28 (threshold 15). Drivers by points: if/else 20, loops 5, match/switch 2, boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorRemarkupControl.renderInput (cognitive 28) src/view/form/control/PhabricatorRemarkupControl.php:52— PhabricatorRemarkupControl.renderInput has cognitive complexity 28 (threshold 15). Drivers by points: if/else 26, loops 1, ternaries 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
_newHoverMap (cognitive 28) webroot/rsrc/js/application/diff/DiffChangesetList.js:1539— _newHoverMap has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHPMailerLite.MsgHTML (cognitive 27) externals/phpmailer/class.phpmailer-lite.php:1865— PHPMailerLite.MsgHTML has cognitive complexity 27 (threshold 15). Drivers by points: if/else 18, ternaries 4, boolean chains 3, loops 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PHPMailer.MsgHTML (cognitive 27) externals/phpmailer/class.phpmailer.php:2003— PHPMailer.MsgHTML has cognitive complexity 27 (threshold 15). Drivers by points: if/else 18, ternaries 4, boolean chains 3, loops 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionRepositoryController.handleRequest (cognitive 27) src/applications/diffusion/controller/DiffusionRepositoryController.php:13— DiffusionRepositoryController.handleRequest has cognitive complexity 27 (threshold 15). Drivers by points: if/else 25, loops 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionSymbolController.handleRequest (cognitive 27) src/applications/diffusion/controller/DiffusionSymbolController.php:5— DiffusionSymbolController.handleRequest has cognitive complexity 27 (threshold 15). Drivers by points: if/else 22, error handling 2, loops 2, boolean chains 1 (nesting depth added 6). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DivinerSymbolRemarkupRule.didMarkupText (cognitive 27) src/applications/diviner/markup/DivinerSymbolRemarkupRule.php:87— DivinerSymbolRemarkupRule.didMarkupText has cognitive complexity 27 (threshold 15). Drivers by points: if/else 23, match/switch 3, loops 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DoorkeeperImportEngine.execute (cognitive 27) src/applications/doorkeeper/engine/DoorkeeperImportEngine.php:65— DoorkeeperImportEngine.execute has cognitive complexity 27 (threshold 15). Drivers by points: if/else 16, loops 11 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorJupyterDocumentEngine.newCells (cognitive 27) src/applications/files/document/PhabricatorJupyterDocumentEngine.php:307— PhabricatorJupyterDocumentEngine.newCells has cognitive complexity 27 (threshold 15). Drivers by points: if/else 16, loops 9, boolean chains 1, error handling 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HarbormasterPlanViewController.buildArtifactList (cognitive 27) src/applications/harbormaster/controller/HarbormasterPlanViewController.php:284— HarbormasterPlanViewController.buildArtifactList has cognitive complexity 27 (threshold 15). Drivers by points: if/else 26, loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HeraldEngine.applyEffects (cognitive 27) src/applications/herald/engine/HeraldEngine.php:258— HeraldEngine.applyEffects has cognitive complexity 27 (threshold 15). Drivers by points: if/else 16, loops 9, boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorMailManagementSendTestWorkflow.execute (cognitive 27) src/applications/metamta/management/PhabricatorMailManagementSendTestWorkflow.php:72— PhabricatorMailManagementSendTestWorkflow.execute has cognitive complexity 27 (threshold 15). Drivers by points: if/else 22, loops 3, boolean chains 2 (nesting depth added 5). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PhabricatorNotificationServersConfigType.validateStoredValue (cognitive 27) src/applications/notification/config/PhabricatorNotificationServersConfigType.php:8— PhabricatorNotificationServersConfigType.validateStoredValue has cognitive complexity 27 (threshold 15). Drivers by points: if/else 17, match/switch 4, boolean chains 2, error handling 2, loops 2 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PholioInlineController.handleRequest (cognitive 27) src/applications/pholio/controller/PholioInlineController.php:5— PholioInlineController.handleRequest has cognitive complexity 27 (threshold 15). Drivers by points: if/else 24, loops 2, match/switch 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProjectEditController.handleRequest (cognitive 27) src/applications/project/controller/PhabricatorProjectEditController.php:17— PhabricatorProjectEditController.handleRequest has cognitive complexity 27 (threshold 15). Drivers by points: if/else 27 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProjectQuery.loadSlugs (cognitive 27) src/applications/project/query/PhabricatorProjectQuery.php:799— PhabricatorProjectQuery.loadSlugs has cognitive complexity 27 (threshold 15). Drivers by points: if/else 22, loops 5 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorProjectUserListView.render (cognitive 27) src/applications/project/view/PhabricatorProjectUserListView.php:55— PhabricatorProjectUserListView.render has cognitive complexity 27 (threshold 15). Drivers by points: if/else 19, ternaries 4, boolean chains 2, loops 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorApplicationSearchController.processExportRequest (cognitive 27) src/applications/search/controller/PhabricatorApplicationSearchController.php:399— PhabricatorApplicationSearchController.processExportRequest has cognitive complexity 27 (threshold 15). Drivers by points: if/else 26, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorApplicationTransactionEditor.combineTransactions (cognitive 27) src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:2430— PhabricatorApplicationTransactionEditor.combineTransactions has cognitive complexity 27 (threshold 15). Drivers by points: if/else 20, loops 5, boolean chains 2 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorApplicationTransactionEditor.filterTransactions (cognitive 27) src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:2772— PhabricatorApplicationTransactionEditor.filterTransactions has cognitive complexity 27 (threshold 15). Drivers by points: if/else 22, boolean chains 3, loops 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorTypeaheadCompositeDatasource.loadResultsForPhase (cognitive 27) src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php:67— PhabricatorTypeaheadCompositeDatasource.loadResultsForPhase has cognitive complexity 27 (threshold 15). Drivers by points: if/else 23, loops 4 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorTypeaheadDatasource.renderTokens (cognitive 27) src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php:274— PhabricatorTypeaheadDatasource.renderTokens has cognitive complexity 27 (threshold 15). Drivers by points: if/else 16, loops 11 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhutilPygmentizeParser.parse (cognitive 27) src/infrastructure/parser/PhutilPygmentizeParser.php:20— PhutilPygmentizeParser.parse has cognitive complexity 27 (threshold 15). Drivers by points: if/else 24, match/switch 2, loops 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorSSHPassthruCommand.execute (cognitive 27) src/infrastructure/ssh/PhabricatorSSHPassthruCommand.php:87— PhabricatorSSHPassthruCommand.execute has cognitive complexity 27 (threshold 15). Drivers by points: if/else 19, boolean chains 5, loops 3 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorCalendarEventSearchEngine.getQueryDateRange (cognitive 26) src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php:149— PhabricatorCalendarEventSearchEngine.getQueryDateRange has cognitive complexity 26 (threshold 15). Drivers by points: if/else 21, boolean chains 5 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorDashboardPanelTabsController.handleRequest (cognitive 26) src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php:17— PhabricatorDashboardPanelTabsController.handleRequest has cognitive complexity 26 (threshold 15). Drivers by points: if/else 19, loops 4, match/switch 3 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DifferentialChangesetHTMLRenderer.renderShowContextLinks (cognitive 26) src/applications/differential/render/DifferentialChangesetHTMLRenderer.php:499— DifferentialChangesetHTMLRenderer.renderShowContextLinks has cognitive complexity 26 (threshold 15). Drivers by points: if/else 26 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DiffusionLintController.handleRequest (cognitive 26) src/applications/diffusion/controller/DiffusionLintController.php:9— DiffusionLintController.handleRequest has cognitive complexity 26 (threshold 15). Drivers by points: if/else 25, loops 1 (nesting depth added 5). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DiffusionSetPasswordSettingsPanel.processRequest (cognitive 26) src/applications/diffusion/panel/DiffusionSetPasswordSettingsPanel.php:33— DiffusionSetPasswordSettingsPanel.processRequest has cognitive complexity 26 (threshold 15). Drivers by points: if/else 22, error handling 4 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DrydockLandRepositoryOperation.getBarrierToLanding (cognitive 26) src/applications/drydock/operation/DrydockLandRepositoryOperation.php:225— DrydockLandRepositoryOperation.getBarrierToLanding has cognitive complexity 26 (threshold 15). Drivers by points: if/else 24, loops 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PhabricatorFileQuery.buildWhereClauseParts (cognitive 26) src/applications/files/query/PhabricatorFileQuery.php:396— PhabricatorFileQuery.buildWhereClauseParts has cognitive complexity 26 (threshold 15). Drivers by points: if/else 24, loops 2 (nesting depth added 4). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
HarbormasterUIEventListener.handlePropertyEvent (cognitive 26) src/applications/harbormaster/event/HarbormasterUIEventListener.php:18— HarbormasterUIEventListener.handlePropertyEvent has cognitive complexity 26 (threshold 15). Drivers by points: if/else 15, loops 9, boolean chains 1, error handling 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HeraldRuleController.handleRequest (cognitive 26) src/applications/herald/controller/HeraldRuleController.php:5— HeraldRuleController.handleRequest has cognitive complexity 26 (threshold 15). Drivers by points: if/else 22, error handling 2, boolean chains 1, ternaries 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HeraldRuleController.saveRule (cognitive 26) src/applications/herald/controller/HeraldRuleController.php:263— HeraldRuleController.saveRule has cognitive complexity 26 (threshold 15). Drivers by points: if/else 15, error handling 7, boolean chains 2, loops 2 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ManiphestTaskStatusTransaction.getTitle (cognitive 26) src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php:49— ManiphestTaskStatusTransaction.getTitle has cognitive complexity 26 (threshold 15). Drivers by points: if/else 24, boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.