qunarcorp/qmq

Executive summary

qunarcorp/qmq scores 46 out of 100 and is rated Weak, while six of its seven lenses score higher still: Event Sourcing at 100, rated Exemplary, Architecture at 82 and Performance at 70, both rated Strong, Security and Compliance at 61, rated Adequate, and Code Health at 50 and Maturity at 49, both rated Weak.

The score is lower than those six because the weakest lens counts most, and here that is Production Readiness, which scores 35 and is rated Weak. Its Security & performance tooling dimension scores 0 out of 10, and until that reaches 4, Production Readiness can't be rated higher than Adequate. The first actions are to add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing and to resolve the 7 WriteOnlyPrivateField finding(s) in Explicit Debt, and if Production Readiness rose to 70, the score would rise from 46 to about 55.

33 findings are critical: 16 in Explicit Debt, 12 in Dependency Vulnerabilities, three in Static Analysis (SAST), one in Project dependency cycles and one in Secrets (history).

Watchdog couldn't measure 4 dimensions in this code, among them Test Reliability, Dependency Hygiene and Navigability, so they are left out of the score. The product code is 66,713 lines, which would take an estimated 0.5 person-years, around €69,000, to rebuild.

Code Health 50 Weak, capped by Async correctness Architecture 82 Strong Maturity 49 Weak, capped by Knowledge Freshness and Architecture documentation Production Readiness 35 Weak, capped by Security & performance tooling and Schema migrations Security and Compliance 61 Adequate, capped by Dependency Vulnerabilities and Supply-chain Provenance & Signing Event Sourcing 100 ★ Exemplary Performance 70 Strong

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.

Production Readiness 35 · counts for 46%Maturity 49 · counts for 25%Code Health 50 · counts for 14%Security and Compliance 61 · counts for 8%Performance 70 · counts for 4%Architecture 82 · counts for 2%Event Sourcing 100 · counts for 1%

If Production Readiness rose from 35 to 70, the lowest score rated Strong, the score would rise from 46 to about 55.

Code composition: what the lines of code are

Business logic 31%Supporting code 59%Tests 10%

New since the last survey: 14 findings

These 14 critical or serious findings weren't in the previous survey, on 8 October 2026.

Explicit Debt · Dead code: DefaultExpiredTime clients/csharp/qmqclient/MessageProducerProvider.cs
Secrets (history) · REDACTED
Static Analysis (SAST) · REDACTED
Dependency Vulnerabilities · REDACTED
Supply-chain Provenance & Signing · REDACTED
Async correctness · Sync-over-async (deadlock risk) through `.Result` clients/csharp/qmqclient/Consumer/PullConsumerRegister.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` clients/csharp/qmqclient/Pull/DefaultPullConsumer.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` clients/csharp/qmqclient/Pull/DefaultPullConsumer.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` clients/csharp/qmqclient/Pull/DefaultPullConsumer.cs
Cancellation propagation · Async method without CancellationToken: AsyncPull clients/csharp/qmqclient/Pull/DefaultPullConsumer.cs
Cancellation propagation · Async method without CancellationToken: Pull clients/csharp/qmqclient/Pull/Puller.cs
Async & latency hygiene · Sync-over-async blocking
Async & latency hygiene · Sync-over-async blocking clients/csharp/qmqclient/Transport/Future.cs
Async & latency hygiene · Sync-over-async blocking clients/csharp/qmqclient/Util/WaitHolder.cs

Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 4 findings

These 4 critical or serious findings were in the previous survey, on 8 October 2026, and are gone from this one.

Explicit Debt · WriteOnlyPrivateField clients/csharp/qmqclient/Util/Scheduler.cs
Dependency Vulnerabilities · High CVE: [GHSA redacted] REDACTED
Supply-chain Provenance & Signing REDACTED
Exception handling · Swallowed exception (caught, then discarded) clients/csharp/qmqclient/Util/BatchExecutor.cs

Rebuild cost: about €69,000 · Estimate

Cost to rebuild	€23,000 to €120,000, for 383 to 1,215 hours of work, about 0.5 person-years for one engineer
Difficulty of the problem	Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor	×0.7 at a score of 46. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size	Medium: 66,713 lines of product code
Comment lines	The estimate prices 66,337 lines. Comment lines count towards the size of 66,713 lines but aren't priced as work.

How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

Raises the score by about 6 points · Medium effort · Security & performance tooling

Resolve the 7 WriteOnlyPrivateField finding(s) in Explicit Debt — start with MessageConsumerProvider.cs (2), Request.cs, PulledMessage.cs.

Raises the score by about 2 points · Low effort · Explicit Debt

Resolve the 9 EmptyCatchBlock finding(s) in Explicit Debt — start with ProducerMessageImpl.cs (2), MetainfoAddressResolver.cs, NewQmqClient.cs.

Raises the score by about 2 points · Low effort · Explicit Debt

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk

This code would cost about €69,000 to build again, about 0.5 person-years of work. Its weakest lens is Production Readiness, at 35 (Weak). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.

Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts

What to do: Start with the Production Readiness actions in Top priorities.

If you do one thing first · First action

Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing. Of all the actions in this report, it raises the score most for the work it takes: about 6 points for medium effort. The next survey will show the change in the score.

Based on: the ranked actions in Top priorities, by score gain and effort

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways — a layering smell or cycle. A clean layered graph has none.

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

143 modules, with 421 dependencies between them. 6 loops run through 44 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 103 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →	1 qunar.tc.qmq	2 qunar.tc.qmq.common	3 Qunar.TC.Qmq.Client.Transport	4 qunar.tc.qmq.protocol	5 Qunar.TC.Qmq.Client	6 qunar.tc.qmq.netty	7 Qunar.TC.Qmq.Client.NewQmq	8 qunar.tc.qmq.netty.client	10 qunar.tc.qmq.meta	11 qunar.tc.qmq.configuration	12 qunar.tc.qmq.protocol.consumer	13 qunar.tc.qmq.metainfoclient	14 qunar.tc.qmq.processor	15 qunar.tc.qmq.consumer.pull	16 qunar.tc.qmq.producer.sender	17 qunar.tc.qmq.consumer	18 qunar.tc.qmq.store	19 qunar.tc.qmq.store.buffer	20 qunar.tc.qmq.base	21 qunar.tc.qmq.backup.base	22 qunar.tc.qmq.delay.store.model	23 qunar.tc.qmq.meta.model	24 qunar.tc.qmq.producer	25 qunar.tc.qmq.sync	26 qunar.tc.qmq.sync.master	27 qunar.tc.qmq.backup.service	28 qunar.tc.qmq.delay.sender	29 qunar.tc.qmq.meta.route	30 qunar.tc.qmq.meta.store	34 qunar.tc.qmq.delay.wheel	35 qunar.tc.qmq.meta.cache	36 qunar.tc.qmq.delay.store.log	38 qunar.tc.qmq.delay	39 qunar.tc.qmq.delay.receiver
1 qunar.tc.qmq
2 qunar.tc.qmq.common
3 Qunar.TC.Qmq.Client.Transport					3
4 qunar.tc.qmq.protocol																			3
5 Qunar.TC.Qmq.Client			2
6 qunar.tc.qmq.netty		1		8
7 Qunar.TC.Qmq.Client.NewQmq			6		4
8 qunar.tc.qmq.netty.client				3		2
9 Qunar.TC.Qmq.Client.Pull					3		3
10 qunar.tc.qmq.meta		1		1				1
11 qunar.tc.qmq.configuration									2
12 qunar.tc.qmq.protocol.consumer	1	1		3					1										2
13 qunar.tc.qmq.metainfoclient		5		1		1		2	4		5								1
14 qunar.tc.qmq.processor				15		2				2	5					4	5		10
15 qunar.tc.qmq.consumer.pull	8	13		3				7			6	2				4			12
16 qunar.tc.qmq.producer.sender	10	2		2				1				1											7
17 qunar.tc.qmq.consumer	9	4								2			1	2			7	1	6
18 qunar.tc.qmq.store		1							2	6	8					1		20	7
19 qunar.tc.qmq.store.buffer																	1
20 qunar.tc.qmq.base	1																	1
21 qunar.tc.qmq.backup.base		1															1		1
22 qunar.tc.qmq.delay.store.model																	11		2
23 qunar.tc.qmq.meta.model									1										1
24 qunar.tc.qmq.producer	9	3													1				2
25 qunar.tc.qmq.sync		1		6				2		2							3		6
26 qunar.tc.qmq.sync.master		4		8		3			1	7							10	5	6
27 qunar.tc.qmq.backup.service		2								1							1			7
28 qunar.tc.qmq.delay.sender		3		3				1		3											5												8
29 qunar.tc.qmq.meta.route									4		3											1									1
30 qunar.tc.qmq.meta.store									3		1											8
31 qunar.tc.qmq.startup		1		1		1			1	1			1			2	3							2	2
32 qunar.tc.qmq.backup.service.impl		1								5							14		1	8						14
33 qunar.tc.qmq.backup.sync				1						1							6		3	2				5		3
34 qunar.tc.qmq.delay.wheel																											2					2	6
35 qunar.tc.qmq.meta.cache		3							1	2	3								1			4						1	6
36 qunar.tc.qmq.delay.store.log		1															19	4			30			2						1			3
37 qunar.tc.qmq.meta.processor				8		3			4	1	5								1			1						3	5		4
38 qunar.tc.qmq.delay																	2	2			7			2						2		9
39 qunar.tc.qmq.delay.receiver				6		1				1											2			1									1
40 qunar.tc.qmq.delay.startup		1				1			1	1																				1			2	2

Uses a module listed above itPart of a loopThe module itself

At a glance — Code Health · 50% · Weak · gated by X1 ·

The Good

D1 · .NET / C# Cyclomatic Complexity 9.4 D2 · .NET / C# Cognitive Complexity 7.3 D3 · .NET / C# God Classes 9.5 D4 · .NET / C# Code Duplication 9.5 GD1 · Repo Unfinished & placeholder code 9.9 IC1 · Repo Incompleteness & stubs 8.9 X12 · Repo Unreachable branch 10.0 X13 · Repo Undrained process stream 10.0 X16 · Repo Unfloored truncation loop 10.0 X19 · Repo Unrestored process-global state 10.0 X21 · Repo Side-effecting pattern guard 10.0 X22 · Repo Contradicted release guard 10.0 X23 · Repo Unguarded diagnostic materialisation 10.0 X25 · Repo Inert configuration knob 10.0 X26 · Repo Unsynchronised callback handoff 10.0 X27 · Repo Collection changed while being enumerated 10.0 X28 · Repo Index access outside its own emptiness guard 10.0 X29 · Repo Per-element action decided by a fixed element 10.0 X30 · Repo Support guard that admits what it rejects 10.0 X32 · Repo Type resolved by simple name across every loaded assembly 10.0 X4 · Repo Structured logging 10.0

The Bad

D17 · .NET / C# Explicit Debt 6.2 X3 · Repo Exception handling 5.0

The Ugly

X1 · Repo Async correctness 2.0 X18 · Repo Disposal-pattern correctness 4.8 X2 · Repo Cancellation propagation 4.0 X20 · Repo Mistyped argument guard 4.3

At a glance — Architecture · 82% · Strong ·

The Good

D5 · .NET / C# Coupling 10.0 D6 · .NET / C# Cohesion (LCOM4) 9.9 D26 · .NET / C# Project Cohesion 10.0 D35 · .NET / C# Change Coupling 10.0 AX1 · Repo Captive dependencies 10.0 AX2 · Repo Stateful singletons 10.0 AX3 · Repo Project dependency cycles 10.0 AX5 · Repo Architecture & structure 10.0 AX6 · Repo Interface segregation 9.8 AX9 · Repo CQS / query purity 10.0

The Ugly

AX10 · Repo Code composition 4.0

At a glance — Maturity · 49% · Weak · gated by D34, M2 ·

The Good

D15 · .NET / C# Churn × Complexity Hotspots 10.0 D19 · .NET / C# Documentation Quality 9.0 D21 · .NET / C# Naming Consistency 8.5 D24 · .NET / C# Comment Value 9.0 M3 · Repo Folder & project structure 10.0 M4 · Repo Documentation accuracy 10.0

The Bad

M1 · Repo Documentation (README) 6.0

The Ugly

D34 · .NET / C# Knowledge Freshness 0.0 M2 · Repo Architecture documentation 2.0

At a glance — Readiness · 35% · Weak · gated by P3, P8 ·

The Good

D9 · .NET / C# Test Distribution 10.0 D10 · .NET / C# Test Quality 9.5 D13 · .NET / C# Secret Scanning 10.0 D14 · .NET / C# License Compliance 10.0

The Bad

P1 · Repo CI/CD gates 6.5 P10 · Repo Library API & versioning 6.0 P4 · Repo Deployment & Rollback 5.0 P6 · Repo Release Hygiene 5.0

The Ugly

P3 · Repo Security & performance tooling 0.0 P5 · Repo DR & Backup 4.0 P8 · Repo Schema migrations 3.0

At a glance — Security · 61% · Adequate · gated by D30, D36 ·

The Good

D28 · .NET / C# Secrets (history) 9.0 D43 · .NET / C# Malicious Dependencies 10.0 D44 · .NET / C# Platform End-of-Life 8.5 X14 · Repo Bypassable address classification 10.0 X15 · Repo Unvalidated length from an untrusted reader 10.0 X17 · Repo Uncapped recursion over a caller-supplied document 10.0 X24 · Repo Document value interpolated into markup unescaped 10.0

The Bad

D29 · .NET / C# Static Analysis (SAST) 6.3

The Ugly

D30 · .NET / C# Dependency Vulnerabilities 0.1 D36 · .NET / C# Supply-chain Provenance & Signing 2.5

At a glance — Event Sourcing · 100% · Exemplary ·

The Good

ES1 · Repo Fold determinism 10.0 ES2 · Repo Immutable events 10.0

At a glance — Performance · 70% · Strong ·

The Good

PF3 · Repo Async & latency hygiene 7.0

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP category	Findings	Severity
A03:2025 — Software Supply Chain Failures	20	High / Critical
A05:2025 — Injection	12	High / Critical
A07:2025 — Authentication Failures	2	High / Critical

Roadmap

First, integrate automated security scanning into the CI pipeline to prevent regressions from reaching production. Next, address technical debt by resolving orphaned files and private write-only fields, while replacing automatic database schema generation with versioned migrations for safe evolution. Finally, document significant design decisions in a dedicated folder to preserve architectural knowledge and context.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do this	Helps	Effort	Dimension
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.	+6.4 pts	Medium	Security & performance tooling
Resolve the 7 WriteOnlyPrivateField finding(s) in Explicit Debt — start with MessageConsumerProvider.cs (2), Request.cs, PulledMessage.cs.	+2.2 pts	Low	Explicit Debt
Resolve the 9 EmptyCatchBlock finding(s) in Explicit Debt — start with ProducerMessageImpl.cs (2), MetainfoAddressResolver.cs, NewQmqClient.cs.	+2.2 pts	Low	Explicit Debt
Resolve the 35 Orphaned file finding(s) in Knowledge Freshness — start with ConcurrentPriorityQueue.cs, SocketChannel.cs, MetainfoClient.cs.	+3.3 pts	Medium	Knowledge Freshness
Replace Hibernate ddl-auto with Flyway or Liquibase, with `ddl-auto` set to `validate` so the production schema can evolve safely and reproducibly.	+2.9 pts	Medium	Schema migrations
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.	+2.5 pts	Medium	Architecture documentation
Document RTO/RPO and a tested restore procedure (a backup config alone isn't disaster recovery).	+2.0 pts	Medium	DR & Backup
Sync-over-async (deadlock risk) through `.Result`	+1.7 pts	Medium	Async correctness

File quality

Per-file score 0–10 — a quality signature. Of 102 files carrying findings, judged against the Production bar: 1% slop · 50% mixed · 49% near-clean.

File	Score	Band	Worst signal
REDACTED	1.4	Slop	Static Analysis (SAST): High: REDACTED
REDACTED	4.5	Mixed	Dependency Vulnerabilities: Critical CVE: REDACTED
REDACTED	5.1	Mixed	Dependency Vulnerabilities: Critical CVE: REDACTED
REDACTED	5.1	Mixed	Dependency Vulnerabilities: High CVE: REDACTED
REDACTED	5.7	Mixed	Dependency Vulnerabilities: High CVE: REDACTED
clients/csharp/qmqclient/MessageProducerProvider.cs	5.8	Mixed	Explicit Debt: WriteOnlyPrivateField
clients/csharp/qmqclient/Model/ACKMessage.cs	5.8	Mixed	Explicit Debt: WriteOnlyPrivateField
REDACTED	5.8	Mixed	Dependency Vulnerabilities: Critical CVE: REDACTED
clients/csharp/qmqclient/Transport/SocketChannel.cs	6.1	Mixed	Explicit Debt: WriteOnlyPrivateField
clients/csharp/qmqclient/MessageConsumerProvider.cs	6.4	Mixed	Explicit Debt: WriteOnlyPrivateField
clients/csharp/qmqclient/ProducerMessageImpl.cs	6.4	Mixed	Explicit Debt: EmptyCatchBlock
clients/csharp/qmqclient/Util/ConcurrentPriorityQueue.cs	6.7	Mixed	Explicit Debt: Dead code: ConcurrentPriorityQueue
clients/csharp/qmqclient/NewQmq/AckHandlerQueue.cs	6.7	Mixed	Explicit Debt: TodoComment
clients/csharp/qmqclient/Transport/InputStream.cs	6.9	Mixed	Explicit Debt: Dead code: MarkWriterIndex
REDACTED	6.9	Mixed	Static Analysis (SAST): Medium: REDACTED
REDACTED	6.9	Mixed	Static Analysis (SAST): Medium: REDACTED
qmq-store/src/main/java/qunar/tc/qmq/store/CheckpointManager.java	7.0	Mixed	God Classes: TooManyMethods: CheckpointManager
qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java	7.0	Mixed	Cyclomatic Complexity: DelayMessageLogVisitor.readOneRecord (cyclomatic 16)
qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java	7.1	Mixed	Code Duplication: Duplicated block (12 lines × 2)
qmq-store/src/main/java/qunar/tc/qmq/store/DefaultStorage.java	7.1	Mixed	Cyclomatic Complexity: DefaultStorage.pollFromConsumerLog (cyclomatic 21)

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 33

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 170

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 81

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 4

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 67 of 71 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 4 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.9 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 71 dimensions across the health lenses

D1D2D3D4D5D6D9D10D13D14D15D17D19D21D24D26D28D29D30D34D35D36D43D44AX1AX10AX2AX3AX5AX6AX9ES1ES2GD1IC1M1M2M3M4P1P10P3P4P5P6P8PF3X1X12X13X14X15X16X17X18X19X2X20X21X22X23X24X25X26X27X28X29X3X30X32X4

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions

Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 266 of 284 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

Method	Backs	Version	Evaluator
Roslyn static analysis	Complexity, cohesion, coupling, dead code, API surface, layering	5.3.0	✓ deterministic
Native secret scanner	Hardcoded secrets / credentials	1.0.0	✓ deterministic
Watchdog duplication detector (in-process)	Code duplication	1.0.0	✓ deterministic
Coverage (coverlet / dotnet-coverage)	Line & branch coverage	10.0.400	✓ deterministic
NuGet / dotnet	Outdated, vulnerable & deprecated dependencies	10.0.400	✓ deterministic
git / LibGit2Sharp	Churn hotspots, knowledge concentration, history	2.43.0 · 0.31.0	✓ deterministic
gitleaks · semgrep · trivy	Secrets in history, SAST, CVEs, IaC & container, PII / GDPR	1.86.0 · 0.69.3	✓ deterministic
LLM (sampled · advisory)	Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurement	Local LLM	◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 01a164b1-c19f-77cb-9263-0159f86d2fa4.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.java) and this repository declares a JVM test suite (repository root, Maven), but it was not re-run: no test result was produced. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
D12 Dependency Hygiene — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `dotnet list package` did not return usable output (restore or query failed); no outdated/vulnerable/deprecated data to assess. The tool said: `dotnet list package` exited 1 with no output.
D14 License Compliance — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares a Maven POM, but the licence verdict published here was taken over its NuGet package dependencies. Nothing was read about its Maven dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Every one of the 36 significant source file(s) was last meaningfully changed so long ago that no living knowledge remains, so there is no concentration to measure — the bus factor is not scored. This is not a clean bill: nobody currently holds working knowledge of this code (see D34 Knowledge Freshness).
D17 Explicit Debt — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 22 deducted marker(s) and the 1.9/KLoC density on this row were taken over this repository's .NET projects ALONE: .java (54,357 lines, 81% of production source) went unread, because every marker collector on this path is reached through a C# workspace. A read-only sweep of that source finds at least 25 task marker(s) (TODO/FIXME/HACK/XXX) across 19 file(s) that this score does not count — a floor, since only line comments are read there and D17's other eight marker kinds (suppressions, NoWarn, editorconfig severities, empty catches, commented-out code, Obsolete, dead code, preprocessor branches) need a compiler we do not have for that language. The debt in that source is UNMEASURED — its absence from the score above is a gap in this analyzer's language coverage, not a finding that the code carries none.
D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The loaded project set declares no packable project and no `.Contracts` project, so there is no intentionally-exposed surface for API consistency to be judged over.
D27 Navigability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Navigability is taken over call sites whose callee resolved. For C# that population includes calls into referenced assemblies; for this language only calls declared inside the repository count, so the abstention threshold reads the repository's use of its standard library as a resolution failure. That is a limit of this analyzer, not a build problem in this repository.
D39 IL Efficiency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. IL NOT MEASURED: the analyzer's own build of this repository failed for an ENVIRONMENT reason (exit 1) — MSBuild's engine or the CLR gave up, or our image does not carry the SDK band/targeting pack this repository needs. This is OUR limitation, not a defect in the repo, and it is not a statement that this repository fails to build. D18 owns the question of whether this repository builds; it was not answered here.
P1 CI/CD gates — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. A CI pipeline exists and the word "test" appears, but no explicit test-runner invocation (your stack's test command, or a test job) was matched — so either the gate runs tests through a step this pass could not recognise, or "test" is incidental here (a path, "latest", a reporter). Which of the two it is cannot be settled from this dimension's evidence; the coverage dimensions report whether a suite exists at all. You can widen what we reach: name the test runner explicitly in the pipeline step (your stack's test command, or a job named for the suite) so the gate is unambiguous to a reader and to this pass.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
D24 Comment Value: Comment value (WHY vs WHAT) is an LLM judgement over a bounded sample — it is advisory and cannot weigh a comment against the precise code change it was written to explain.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
AX9 CQS / query purity: Handlers are found by interface/name convention — a query handler using neither is not seen. Mutation is a resolved write/publish invocation (SaveChanges/repository/bus), so a write hidden behind a hand-rolled wrapper, reflection, or a string-keyed service locator resolves to a non-persistence type and isn't flagged; it detects that a query writes state, not whether the write is a legitimate read-side cache update. Clean means "no resolved write/publish in a query body", not a proof of CQS purity.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

The LLM boundary

LLM-set scores this run (4): D19, D21, D24, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.

Dimensions

D1 · Cyclomatic Complexity9.4 / 10Stronggated by 3 serious findings✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.4 / 10 · rule-coverage 100% · ceiling Prevented

3 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was DefaultStorage.pollFromConsumerLog at 21.

DefaultStorage.pollFromConsumerLog (cyclomatic 21)qmq-store/src/main/java/qunar/tc/qmq/store/DefaultStorage.java:258

MessageStoreWrapper.doFindUnAckMessages (cyclomatic 20)qmq-server/src/main/java/qunar/tc/qmq/store/MessageStoreWrapper.java:279

DelayMessageLogVisitor.readOneRecord (cyclomatic 16)qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:45

What to do

Bring the 3 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with DefaultStorage.pollFromConsumerLog (cyclomatic 21), MessageStoreWrapper.doFindUnAckMessages (cyclomatic 20), DelayMessageLogVisitor.readOneRecord (cyclomatic 16). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 3 together lifts Cyclomatic Complexity from 9.4 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D2 · Cognitive Complexity7.3 / 10Strong✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 7.3 / 10 · rule-coverage 100% · ceiling Prevented

21 method(s) exceeded the cognitive complexity threshold of 15; the worst was MessageStoreWrapper.doFindUnAckMessages at 38.

MessageStoreWrapper.doFindUnAckMessages (cognitive 38)qmq-server/src/main/java/qunar/tc/qmq/store/MessageStoreWrapper.java:279

DefaultStorage.pollFromConsumerLog (cognitive 37)qmq-store/src/main/java/qunar/tc/qmq/store/DefaultStorage.java:258

SocketChannel.Flush (cognitive 28)clients/csharp/qmqclient/Transport/SocketChannel.cs:146

DelayMessageLogVisitor.readOneRecord (cognitive 28)qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:45

MinBinaryHeap.Remove (cognitive 24)clients/csharp/qmqclient/Util/ConcurrentPriorityQueue.cs:288

+ 16 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

Bring the 21 bodies over 15 down to 15 or less in Cognitive Complexity — start with MessageStoreWrapper.doFindUnAckMessages (cognitive 38), DefaultStorage.pollFromConsumerLog (cognitive 37), SocketChannel.Flush (cognitive 28). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 21 together lifts Cognitive Complexity from 7.3 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D3 · God Classes9.5 / 10Stronggated by 7 serious findings✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.5 / 10 · rule-coverage 100% · ceiling Prevented

7 god class(es) detected.

TooManyMethods: QMon · ×6qmq-server-common/src/main/java/qunar/tc/qmq/monitor/QMon.java:32

ClassTooLong: DefaultStorageqmq-store/src/main/java/qunar/tc/qmq/store/DefaultStorage.java:48

What to do

Resolve the 6 TooManyMethods finding(s) in God Classes — start with QMon.java (2), BaseMessage.java, CheckpointManager.java. — One of this dimension's main actionable groups (6 warning-level).
Resolve the 1 ClassTooLong finding(s) in God Classes — start with DefaultStorage.java. — One of this dimension's main actionable groups (1 warning-level).
Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D4 · Code Duplication9.5 / 10Stronggated by 73 serious findings✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.5 / 10 · rule-coverage 100% · ceiling Verified

71 duplicated block group(s) detected. A further 2 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.

Duplicated block (9 lines × 2) · ×11qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:113

Duplicated block (8 lines × 2) · ×8qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java:84

Duplicated block (6 lines × 2) · ×8qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageIndexBatchBackup.java:69

Duplicated block (11 lines × 2) · ×6qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/DispatchLogSegmentContainer.java:70

Duplicated block (12 lines × 2) · ×5qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:84

+ 23 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

Resolve the 11 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with RecordBatchBackup.java (2), ActionLog.java (2), HBaseIndexStore.java. — One of this dimension's main actionable groups (11 warning-level).
Resolve the 8 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with DeadMessageBatchBackup.java, RecordBatchBackup.java, ReceivedDelayMessageProcessor.java. — One of this dimension's main actionable groups (8 warning-level).
Resolve the 8 Duplicated block (6 lines × 2) finding(s) in Code Duplication — start with MessageIndexBatchBackup.java, HFileIndexStore.java, PullService.java. — One of this dimension's main actionable groups (8 warning-level).
Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D5 · Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

17 production modules (Maven+OTP), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; 0 module(s) off the main sequence, with abstractness counted on 16 of the 17 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).

✓ On the Gold path — maintain.

Detailed fixes: d5_recommendation.md.

Do you agree with this assessment?

D6 · Cohesion (LCOM4)9.9 / 10Stronggated by 2 serious findings✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Verified

2 of 300 classes have LCOM4 above 3.

Low cohesion: CheckpointManager (LCOM4 6) · ×2qmq-store/src/main/java/qunar/tc/qmq/store/CheckpointManager.java:40

What to do

Resolve the 2 Low cohesion finding(s) in Cohesion (LCOM4) — start with CheckpointManager.java, MessageLogSyncWorker.java. — One of this dimension's main actionable groups (2 warning-level).
Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.

Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

30 test methods: 30 unit, 0 integration, 0 BDD, 0 e2e.

✓ On the Gold path — maintain.

Detailed fixes: d9_recommendation.md.

Do you agree with this assessment?

D10 · Test Quality9.5 / 10Stronggated by 2 serious findings✓ Tool-verified

What it measures: Whether the tests truly assert behaviour rather than just running the code.

Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.5 / 10 · rule-coverage 100% · ceiling Prevented

0 skipped, 1 zero-assertion, no mocking-framework packages referenced (hand-written doubles or no mocking) across 30 tests.

No assertions: bulkloadqmq-backup/src/test/bulkloadtest/BulkloadTest.java:24

Test project verifies nothing: qmq-backupqmq-backup/src/test/bulkloadtest/BulkloadTest.java:24

What to do

Resolve the 1 No assertions finding(s) in Test Quality — start with BulkloadTest.java. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Test project verifies nothing finding(s) in Test Quality — start with BulkloadTest.java. — One of this dimension's main actionable groups (1 warning-level).
Enforce Test Quality in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

Do you agree with this assessment?

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 119 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 2 direct `PackageReference`(s), and 117 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution. ★ COVERAGE OF THIS VERDICT: it grades this repository's NuGet package dependencies and nothing else. The repository also declares a Maven POM, and the licences of those dependencies were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

Do you agree with this assessment?

D15 · Churn × Complexity Hotspots10.0 / 10Exemplary✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No churn × complexity hotspots in the window.

✓ On the Gold path — maintain.

Detailed fixes: d15_recommendation.md.

Do you agree with this assessment?

D17 · Explicit Debt6.2 / 10Adequate✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 6.2 / 10 · rule-coverage 100% · ceiling Prevented

22 deducted debt markers + 11 dead symbols across 8410 LoC in the .NET projects (1.9/KLoC) → score 6.2. Measured on the .NET source only: .java (81% of production source) was not read, and carries at least 25 uncounted task marker(s) in 19 file(s).

EmptyCatchBlock · ×9clients/csharp/qmqclient/Metainfo/MetainfoAddressResolver.cs:59

WriteOnlyPrivateField · ×7clients/csharp/qmqclient/Codec/Request.cs:8

Dead code: BlockMessageException · ×11clients/csharp/qmqclient/Exceptions/BlockMessageException.cs:3

TodoComment · ×4clients/csharp/qmqclient/Cluster/NewQmqCluster.cs:66

CommentedOutCode · ×2clients/csharp/qmqclient/Util/ClientId.cs:43

What to do

Resolve the 9 EmptyCatchBlock finding(s) in Explicit Debt — start with ProducerMessageImpl.cs (2), MetainfoAddressResolver.cs, NewQmqClient.cs. — One of this dimension's main actionable groups (9 issue-level).
Resolve the 7 WriteOnlyPrivateField finding(s) in Explicit Debt — start with MessageConsumerProvider.cs (2), Request.cs, PulledMessage.cs. — One of this dimension's main actionable groups (7 issue-level).
Resolve the 11 Dead code finding(s) in Explicit Debt — start with InputStream.cs (3), BlockMessageException.cs, MessageProducerProvider.cs. — One of this dimension's main actionable groups (11 warning-level).
Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D19 · Documentation QualityStronggated by 1 serious finding◐ Sampled · advisory

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Strong / 10 · rule-coverage 100% · ceiling Documented

This is a well-structured project with comprehensive documentation: the README and architecture/design docs cover what the project does (QMQ as an open-source message broker), its historical motivation, design decisions (consumer-storage decoupling, exactly-once semantics via idempotent checks), installation/build steps, configuration options (JVM, ulimit, sysctl, datasource), a full HA guide with metaserver/broker/delay-server deployment and failover, an operations/monitoring section covering Prometheus integration, .NET client API, tools.sh commands for read-only marking/unmarking/resetting offsets, and a dedicated FAQ on the QMQ message pattern (at most once, at least once, exactly once). The design doc is also thorough: it explains why partition-based models are not adopted, how consumer-scalability scaling works with partition/consumer multiples, and the load-balancing tradeoffs against Kafka/RocketMQ. It ends with a real-world usage note about handling repeat messages (e.g., deleting a cached entry without requiring a full re-load). (14 of 25 sampled documents could not be assessed: 1 of 2 evaluation groups failed.)

Low XML-doc coverage: qmqclientREDACTED

What to do

Resolve the 1 Low XML-doc coverage finding(s) in Documentation Quality — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D21 · Naming ConsistencyStrong◐ Sampled · advisory

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Strong / 10 · rule-coverage 100% · ceiling Verified

3 naming inconsistencies across 200 sampled symbols.

Inconsistent casing style for private fields: some use camelCase (messageId, IP, consumer) while others use PascalCase (Group). The codebase appears to mix conventions for private fields, with most following camelCase but specific fields like Group using PascalCase.

Inconsistent naming style for private fields within the same class (SocketChannel): some use camelCase (index, logger, reading), some use underscore prefix (_state, _tagType, _writtable), and some use ALL_CAPS (LOH, T8_0_IDEX). This indicates a lack of consistent internal naming convention for private members.

Inconsistent casing for what appears to be configuration or constant-like fields: MAX_WEIGHT and LOH use ALL_CAPS, while MaxWeight uses PascalCase. If these are mutable fields, they should likely be camelCase; if constants, ALL_CAPS is consistent but MaxWeight is not.

What to do

Resolve the 1 Inconsistent casing style for private fields finding(s) in Naming Consistency. — One of this dimension's main actionable groups (1 recommendation-level).
Resolve the 1 Inconsistent naming style for private fields within the same class… finding(s) in Naming Consistency. — One of this dimension's main actionable groups (1 recommendation-level).
Resolve the 1 Inconsistent casing for what appears to be configuration or… finding(s) in Naming Consistency. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D24 · Comment ValueExemplary◐ Sampled · advisory

What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).

Method: Judged by language model at low temperature (0.0-0.1) on deterministically sampled inline comments with surrounding code; findings verified back to sampled comments by substring match. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Documented

34 valuable / 1 redundant across 118 sampled comments; 1 shown with locations.

redundant commentclients/csharp/qmqclient/Codec/NewQmq/NewQmqDecoder.cs:26

✓ On the Gold path — maintain.

Detailed fixes: d24_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D26 · Project Cohesion10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic, LLM-independent.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 of 1 projects flagged as possibly oversized/incoherent.

✓ On the Gold path — maintain.

Detailed fixes: d26_recommendation.md.

Do you agree with this assessment?

D28 · Secrets (history)9.0 / 10Adequategated by 1 critical finding✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 9.0 / 10 · rule-coverage 100% · ceiling Documented

1 finding(s): 0 critical, 1 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED

What to do

Resolve the 1 High secret finding(s) in Secrets (history) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D29 · Static Analysis (SAST)6.3 / 10Adequate✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 6.3 / 10 · rule-coverage 100% · ceiling Documented

12 finding(s): 0 critical, 3 high, 9 medium, 0 low. 3 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens.

REDACTED

What to do

Resolve the 6 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2), REDACTED (2), REDACTED. — One of this dimension's main actionable groups (6 warning-level).
Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2). — One of this dimension's main actionable groups (2 warning-level).
No action in Static Analysis (SAST) — all 3 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (3 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D30 · Dependency Vulnerabilities0.1 / 10Critical✓ Tool-verified

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05.

Maturity: Documented → Verified → Prevented · effective 0.1 / 10 · rule-coverage 100% · ceiling Documented

15 finding(s): 3 critical, 9 high, 3 medium, 0 low.

REDACTED

What to do

Resolve the 9 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (8), REDACTED. — One of this dimension's main actionable groups (9 issue-level).
Resolve the 3 Critical CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (3). — One of this dimension's main actionable groups (3 issue-level).
Resolve the 3 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (3). — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D34 · Knowledge Freshness0.0 / 10Critical✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

36 of 36 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is clients/csharp/qmqclient/Util/Crc32.cs. Counted over 36 of the 133 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned file · ×35clients/csharp/qmqclient/Util/ConcurrentPriorityQueue.cs:1

Dormant codebase

Most significant orphaned fileclients/csharp/qmqclient/Util/Crc32.cs:1

What to do

Resolve the 35 Orphaned file finding(s) in Knowledge Freshness — start with ConcurrentPriorityQueue.cs, SocketChannel.cs, MetainfoClient.cs. — One of this dimension's main actionable groups (35 recommendation-level).
Resolve the 1 Dormant codebase finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).
Resolve the 1 Most significant orphaned file finding(s) in Knowledge Freshness — start with Crc32.cs. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D35 · Change Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No strong hidden change-coupling between production files.

✓ On the Gold path — maintain.

Detailed fixes: d35_recommendation.md.

Do you agree with this assessment?

D36 · Supply-chain Provenance & Signing2.5 / 10Weak✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 2.5 / 10 · rule-coverage 100% · ceiling Documented

1/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED

What to do

Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Scored apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. SCORED, not informational.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

Do you agree with this assessment?

D44 · Platform End-of-Life8.5 / 10Strong✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 8.5 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 1 end-of-life framework(s), read from 1 platform declaration(s) and 25 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

End-of-life framework: Spring Boot 1qmq-demo/pom.xml:1

What to do

Resolve the 1 End-of-life framework finding(s) in Platform End-of-Life — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d44_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX1 · Captive dependencies10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.

Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.

Do you agree with this assessment?

AX10 · Code composition4.0 / 10Weak✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

What to do

The domain core is a small share of production code — check that business logic isn't leaking into the application/infrastructure layers (a thin domain is the anemic-domain smell).

Do you agree with this assessment?

AX2 · Stateful singletons10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

Do you agree with this assessment?

AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

The namespaces Qunar.TC.Qmq.Client ↔ Qunar.TC.Qmq.Client.Cluster ↔ Qunar.TC.Qmq.Client.Codec ↔ Qunar.TC.Qmq.Client.Codec.NewQmq ↔ Qunar.TC.Qmq.Client.Consumer ↔ Qunar.TC.Qmq.Client.Metainfo ↔ Qunar.TC.Qmq.Client.Model ↔ Qunar.TC.Qmq.Client.NewQmq ↔ Qunar.TC.Qmq.Client.Pull ↔ Qunar.TC.Qmq.Client.Transport ↔ Qunar.TC.Qmq.Client.Tx ↔ Qunar.TC.Qmq.Client.Util depend on each other. The lightest dependency in the cycle is Qunar.TC.Qmq.Client → Qunar.TC.Qmq.Client.Metainfo (Qunar.TC.Qmq.Client.MessageProducerProvider → Qunar.TC.Qmq.Client.Metainfo.BrokerGroupService, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — clients/csharp/qmqclient/MessageProducerProvider.cs:7

What to do

Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.

Do you agree with this assessment?

AX5 · Architecture & structure10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.

Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.

Do you agree with this assessment?

AX6 · Interface segregation9.8 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

`Message` declares 31 members: `MessageId`, `Subject`, `CreatedTime`, `ExpiredTime`, `ScheduleReceiveTime`, `AutoAck`, `StoreAtFailed`, `Times`, `SetProperty`, `SetProperty`, `SetProperty`, `SetProperty`, `SetProperty`, `SetProperty`, `SetProperty`, `SetLargeString`, `GetLargeString`, `GetBooleanProperty`, `GetIntProperty`, `GetLongProperty`, `GetFloatProperty`, `GetDoubleProperty`, `GetDateProperty`, `GetStringProperty`, `SetDelayTime`, `SetDelayTime`, `Ack`, `Ack`, `Durable`, `SetTags`, `GetTags`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 31 declarations carry 23 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 23 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — clients/csharp/qmqclient/Message.cs:7
`Storage` declares 32 abstract methods: `allConsumerGroupProgresses`, `allPullLogs`, `appendActionLogData`, `appendMessage`, `appendMessageLogData`, `destroyPullLog`, `disableLagMonitor`, `getActionLogData`, `getCheckpointManager`, `getConsumerGroupProgress`, `getMaxActionLogOffset`, `getMaxMessageOffset`, `getMaxPulledMessageSequence`, `getMessage`, `getMessageData`, `getMessageSequenceByPullLog`, `getMinActionLogOffset`, `getMinMessageOffset`, `getPullLogReplayState`, `getStorageConfig`, `getSubjectConsumerLogBound`, `locateConsumeQueue`, `locateSubjectConsumeQueues`, `newMessageLogVisitor`, `pollMessages`, `pollMessages`, `putAction`, `putPullLogs`, `registerActionEventListener`, `registerEventListener`, `start`, `updateConsumeQueue`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 32 declarations carry 31 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 31 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — qmq-store/src/main/java/qunar/tc/qmq/store/Storage.java:35
`StorageConfig` declares 23 abstract methods: `getActionCheckpointInterval`, `getActionLogStorePath`, `getCheckpointRetainCount`, `getCheckpointStorePath`, `getConsumerLogRetentionMs`, `getConsumerLogStorePath`, `getIndexLogStorePath`, `getLogDispatcherPauseMillis`, `getLogRetentionCheckIntervalSeconds`, `getLogRetentionMs`, `getMaxActiveMemTable`, `getMaxReservedMemTable`, `getMessageCheckpointInterval`, `getMessageLogRetentionMs`, `getMessageLogStorePath`, `getPullLogRetentionMs`, `getPullLogSMTStorePath`, `getPullLogStorePath`, `getRetryDelaySeconds`, `getSMTRetentionMs`, `getSMTStorePath`, `isConsumerLogV2Enable`, `isSMTEnable`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — qmq-store/src/main/java/qunar/tc/qmq/store/StorageConfig.java:23
`Store` declares 20 abstract methods: `batchUpdateMetaInfo`, `getAllBrokerGroups`, `getAllSubjectInfo`, `getAllSubjectRoutes`, `getBrokerGroup`, `getSubjectInfo`, `insertClientMetaInfo`, `insertOrUpdateBrokerGroup`, `insertSubject`, `insertSubjectRoute`, `queryClientIds`, `queryConsumerByAppAndSubject`, `queryConsumerByIdAndSubject`, `queryConsumerBySubject`, `selectSubjectRoute`, `updateBrokerGroup`, `updateBrokerGroupExt`, `updateBrokerGroupTag`, `updateSubjectRoute`, `updateTimeByIds`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — qmq-metaserver/src/main/java/qunar/tc/qmq/meta/store/Store.java:35
`StoreConfiguration` declares 17 abstract methods: `getCheckCleanTimeBeforeDispatch`, `getCheckpointStorePath`, `getConfig`, `getDispatchLogKeepTime`, `getDispatchLogStorePath`, `getLoadBlockingExitTimesInMillis`, `getLoadInAdvanceTimesInMillis`, `getLoadSegmentDelayMinutes`, `getLogCleanerIntervalSeconds`, `getMessageLogRetentionMs`, `getMessageLogSegmentFileSize`, `getMessageLogStorePath`, `getScheduleLogStorePath`, `getScheduleOffsetCheckpointPath`, `getSegmentScale`, `getSingleMessageLimitSize`, `isDeleteExpiredLogsEnable`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/config/StoreConfiguration.java:25
`DelayLogFacade` declares 23 abstract methods: `appendDispatchLog`, `appendDispatchLogData`, `appendMessageLog`, `appendMessageLogData`, `appendScheduleLog`, `blockUntilReplayDone`, `getDispatchLogMaxOffset`, `getDispatchLogSyncMaxRequest`, `getDispatchLogs`, `getMessageLogMaxOffset`, `getMessageLogMinOffset`, `getMessageLogs`, `higherDispatchLogBaseOffset`, `higherScheduleBaseOffset`, `initialMessageIterateFrom`, `latestDispatchSegment`, `loadScheduleLogSegment`, `loadUnDispatch`, `lowerDispatchSegment`, `recoverLogRecord`, `shutdown`, `start`, `updateIterateOffset`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/DelayLogFacade.java:40
`Message` declares 42 abstract methods: `ack`, `ack`, `addTag`, `autoAck`, `getAttrs`, `getBooleanProperty`, `getCreatedTime`, `getDateProperty`, `getDoubleProperty`, `getFloatProperty`, `getIntProperty`, `getLargeString`, `getLongProperty`, `getMaxRetryNum`, `getMessageId`, `getScheduleReceiveTime`, `getStringProperty`, `getSubject`, `getTags`, `isDurable`, `isSyncSend`, `localRetries`, `setDelayTime`, `setDelayTime`, `setDurable`, `setLargeString`, `setMaxRetryNum`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setStoreAtFailed`, and 2 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 42 declarations carry 29 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 29 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — qmq-api/src/main/java/qunar/tc/qmq/Message.java:28

What to do

Split fat interfaces into focused role-interfaces so clients depend only on what they use.

Do you agree with this assessment?

AX9 · CQS / query purity10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether read (query) handlers stay side-effect-free — a query that writes persistent state or raises events breaks CQS and makes reads unsafe to retry, cache, or route to a read replica.

Method: Roslyn scan: CQRS handlers classified query-vs-command by interface (IQueryHandler/ICommandHandler/IRequestHandler<TQuery,TResult>) and name convention (*Query/Get*/Find* vs *Command); each query handler's body checked for persistent-state writes (SaveChanges/repository Add-Update) or event publishes by resolved invocation. Deterministic, type-level, exhaustive over the detected handlers.

Coverage: Population: CQRS handlers identified by IQueryHandler/ICommandHandler/IRequestHandler interface + *Query/Get*/Find*/*Command NAME convention; query purity then checked exhaustively within that set — a query handler using neither convention is invisible, and mutation is a resolved persistence/publish CALL, not full dataflow.

Do you agree with this assessment?

ES1 · Fold determinism10.0 / 10Exemplary✓ Tool-verified

Other · Event Sourcing — Whether the event-sourcing replay fold reconstructs state purely from the event (no wall clock, UUID or randomness) so replay is reproducible.

Method: Roslyn syntax scan (event-sourcing gated): Apply/When folds checked for forbidden tokens (DateTime.Now, Guid.NewGuid, Random, IO), stripped of comments/strings. Deterministic, hard fact per fold.

Do you agree with this assessment?

ES2 · Immutable events10.0 / 10Exemplary✓ Tool-verified

Other · Event Sourcing — Whether persisted events stay immutable (never rewritten in place).

Method: Roslyn scan (event-sourcing gated): persisted events checked for public setters; immutability verified per property/field. Deterministic, hard fact.

Do you agree with this assessment?

GD1 · Unfinished & placeholder code9.9 / 10Exemplary✓ Tool-verified

Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.

Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.

A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×3) — clients/csharp/qmqclient/Transport/PacketInputStream.cs:80, clients/csharp/qmqclient/Transport/PacketInputStream.cs:85, clients/csharp/qmqclient/Transport/PacketInputStream.cs:90

What to do

Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.

Do you agree with this assessment?

IC1 · Incompleteness & stubs8.9 / 10Strong✓ Tool-verified

Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

`Write` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — clients/csharp/qmqclient/Transport/PacketInputStream.cs:90
A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). (×6) — clients/csharp/qmqclient/Util/ClientId.cs:37, clients/csharp/qmqclient/Util/ClientId.cs:40, clients/csharp/qmqclient/Util/ClientId.cs:44, …

What to do

Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.

Do you agree with this assessment?

M1 · Documentation (README)6.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
Add a README to the 1 of 1 project(s) that lack one — worth up to 2 pts.

Do you agree with this assessment?

M2 · Architecture documentation2.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.

Do you agree with this assessment?

M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

Do you agree with this assessment?

M4 · Documentation accuracy10.0 / 10Exemplary◐ Sampled · advisory

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

Do you agree with this assessment?

P1 · CI/CD gates6.5 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

A CI pipeline exists but no build step was matched — changes may merge without the build ever running. A build step may be invoked directly as a command, or declared as a task that a runner named in the pipeline resolves.

What to do

Run the test suite in CI via an explicit runner step (`mvn test` for the toolchain this pipeline already uses) and gate merges on it.
Add an explicit build step to your CI pipeline — your stack's own build command, or, if the pipeline delegates to a task runner, a build task that runner executes in CI — so every change is built before merge.

Do you agree with this assessment?

P10 · Library API & versioning6.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.

Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.

688/918 types (75%) declared in the published library are public. For a library, every public type is a stability contract — keep implementation types off the surface and expose only the intended API.

What to do

Keep implementation types off the public surface (Java: package-private (no modifier), or leave its package out of `module-info` exports) so internals can change without breaking consumers.

Do you agree with this assessment?

P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1239 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.

What to do

Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.

Do you agree with this assessment?

P4 · Deployment & Rollback5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

What to do

Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.

Do you agree with this assessment?

P5 · DR & Backup4.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.

Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.

What to do

Document RTO/RPO and a tested restore procedure (a backup config alone isn't disaster recovery).

Do you agree with this assessment?

P6 · Release Hygiene5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

What to do

Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.

Do you agree with this assessment?

P8 · Schema migrations3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether database schema changes go through versioned migrations rather than being auto-created from the model at startup.

Method: Roslyn scan: EF Core DbContext for a versioned migrations directory versus bare EnsureCreated usage; off .NET, a file scan of dependency manifests, migration histories (Flyway, Liquibase, Alembic, Django, Rails, Prisma, TypeORM, Knex/Sequelize, golang-migrate, goose, Laravel, Doctrine, Diesel/sqlx) and schema auto-create in production source or config. Exhaustive, deterministic.

Hibernate ddl-auto builds the schema from the model at startup and keeps no migration history, so there is no reviewed, repeatable upgrade path for an existing production database — a renamed column is dropped and re-added rather than migrated. Adopt Flyway or Liquibase, with `ddl-auto` set to `validate`, so every schema change is a versioned file applied the same way in every environment. — qmq-demo/src/main/resources/application.properties:15

What to do

Replace Hibernate ddl-auto with Flyway or Liquibase, with `ddl-auto` set to `validate` so the production schema can evolve safely and reproducibly.

Do you agree with this assessment?

PF3 · Async & latency hygiene7.0 / 10Strong✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

2 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
`_event.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). — clients/csharp/qmqclient/Transport/Future.cs:28
`_waitAvaliable.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). — clients/csharp/qmqclient/Util/WaitHolder.cs:18

What to do

Make the call chain async end-to-end and await it — never block on a Task with .Wait()/.GetAwaiter().GetResult().

Do you agree with this assessment?

X1 · Async correctness2.0 / 10Critical✓ Tool-verified

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout. (×4) — clients/csharp/qmqclient/Consumer/PullConsumerRegister.cs:100, clients/csharp/qmqclient/Pull/DefaultPullConsumer.cs:71, clients/csharp/qmqclient/Pull/DefaultPullConsumer.cs:100, …

What to do

Sync-over-async (deadlock risk) through `.Result`

Do you agree with this assessment?

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X14 · Bypassable address classification10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.

Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.

Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.

Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X18 · Disposal-pattern correctness4.8 / 10Weak✓ Tool-verified

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

`BatchExecutor` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_workQueue` itself (line 17), which makes that instance its own. But `_workQueue` is named in none of the methods the disposal search covered: `Dispose` (line 123) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_workQueue?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — clients/csharp/qmqclient/Util/BatchExecutor.cs:17
`BatchExecutor` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_queue` itself (line 18), which makes that instance its own. But `_queue` is named in none of the methods the disposal search covered: `Dispose` (line 123) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_queue?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — clients/csharp/qmqclient/Util/BatchExecutor.cs:18

What to do

Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.

Do you agree with this assessment?

X19 · Unrestored process-global state10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X2 · Cancellation propagation4.0 / 10Weak✓ Tool-verified

Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

Only 0/2 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
No CancellationToken parameter — this work can't be stopped early once started. (×2) — clients/csharp/qmqclient/Pull/DefaultPullConsumer.cs:127, clients/csharp/qmqclient/Pull/Puller.cs:47

What to do

Thread a CancellationToken through async methods so work stops promptly on cancellation.

Do you agree with this assessment?

X20 · Mistyped argument guard4.3 / 10Weak✓ Tool-verified

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.

The guard on line 46 rejects `group` and line 48 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(group)` is true of a value that is NOT null: it is satisfied by an EMPTY `group`, and on that path `group` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — clients/csharp/qmqclient/MessageConsumerProvider.cs:48

What to do

Each finding names the throw and the test in its own condition that is true of a NON-null value. Confirm from the two, then throw the exception that describes what was actually wrong: `ArgumentException` for a value that arrived empty, or the .NET 8 helpers that spell the whole guard in one line and pick the type for you — `ArgumentException.ThrowIfNullOrEmpty(s)` / `ThrowIfNullOrWhiteSpace(s)` for strings, `ArgumentNullException.ThrowIfNull(x)` followed by `ArgumentOutOfRangeException.ThrowIfZero(x.Count)` for a collection. Splitting the two conditions is usually clearer than picking one exception for both: they are different failures and the caller may want to handle them differently.

Do you agree with this assessment?

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X22 · Contradicted release guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.

Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.

Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X26 · Unsynchronised callback handoff10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.

Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X3 · Exception handling5.0 / 10Adequate✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×9) — clients/csharp/qmqclient/Metainfo/MetainfoAddressResolver.cs:59, clients/csharp/qmqclient/NewQmq/NewQmqClient.cs:33, clients/csharp/qmqclient/ProducerMessageImpl.cs:131, …
`catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch. — clients/csharp/qmqclient/Tx/TransactionMessageHolder.cs:36

What to do

Swallowed exception (empty catch)

Do you agree with this assessment?

X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X32 · Type resolved by simple name across every loaded assembly10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a plugin lookup names the type it means — searching every assembly loaded into the process for a candidate whose SIMPLE name equals a string supplied at runtime, and taking the first one found, is decided by assembly LOAD ORDER rather than by this source, so the same name can resolve to a different type on the next run.

Method: Roslyn syntax only, no semantic model: every invocation of `First`/`FirstOrDefault`/`Single`/`SingleOrDefault` whose OWN expression subtree contains both a `GetAssemblies()` call and a `GetTypes()`/`GetExportedTypes()` call — a single-element pick out of every type loaded into the process. A nested selector in the same chain sees no `GetAssemblies()` in its own subtree and is outside the population, so one lookup counts once however many links its chain has. A finding additionally needs both remaining halves: the selector must be `First`/`FirstOrDefault` (`Single`/`SingleOrDefault` reports the ambiguity rather than resolving it, and is counted and never reported), and the chain must carry an `==` comparison of `<lambda parameter>.Name` against something that is not a literal. The receiver must be a plain identifier bound by one of the chain’s own lambdas, which places `assembly.GetName().Name == "X"` outside the rule by construction. One exemption: a `.Name` test joined by `&&` to a `FullName`/`AssemblyQualifiedName` test on the same identifier is spared; joined by `||` it is not. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X4 · Structured logging10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

Do you agree with this assessment?

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

Lens	Score	Rating	Impact
Code Health	50%	Weak — gated by X1	Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Architecture	82%	Strong	Solid.
Maturity	49%	Weak — gated by D34, M2	Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness	35%	Weak — gated by P3, P8	Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security	61%	Adequate — gated by D30, D36	Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Event Sourcing	100%	Exemplary	Strongest area.
Performance	70%	Strong	Solid.

Unscored — 3 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

SC1 Supply-chain hygiene — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X10 Duplicated predicate — 11 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 6 observation(s) recorded · Advisory — this card reports evidence and never carries a score.

Not included — 48 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

AC1 Text alternatives — No user-facing web UI (the repo is a library/CLI/worker/headless service) — accessibility is not applicable.
AC2 Forms & labels — No user-facing web UI (the repo is a library/CLI/worker/headless service) — accessibility is not applicable.
AC3 Page structure — No user-facing web UI (the repo is a library/CLI/worker/headless service) — accessibility is not applicable.
AC4 Keyboard semantics — No user-facing web UI (the repo is a library/CLI/worker/headless service) — accessibility is not applicable.
AC5 ARIA correctness — No user-facing web UI (the repo is a library/CLI/worker/headless service) — accessibility is not applicable.
AC6 Visual & motion safety — No user-facing web UI (the repo is a library/CLI/worker/headless service) — accessibility is not applicable.
AC7 A11y enforcement — No user-facing web UI (the repo is a library/CLI/worker/headless service) — accessibility is not applicable.
AX4 Dependency direction — not applicable to a CQRS architecture (the inward-dependency rule is for layered/clean styles)
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — no test/production split to check
AXB1 Runtime evidence locked — no reproducible boot — This repository has nothing the runtime tiers could boot or serve — 1 markup document under demonstration, documentation or developer-tool trees (or modules the build marks non-production) but none in the product; no UI framework or web-server dependency, no UI component source, no native UI project and no API definition — those pages are demos or docs for the code, not something this tier can boot — so runtime a11y/egress/header evidence has no subject here. Not applicable: this is neither a gap in the scan nor a finding about your code.
C1 Data Protection — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C2 Access Controls — No access-control surface detected in the analyzed source — no web/app surface to authorize (no HTTP API or web-UI project) and no authorization code at all (no [Authorize]/policies, no imperative guard methods). Access control is therefore N/A here — this is a library/CLI, which is authorized by its CALLER, not by itself. If this codebase grows request handlers, the dimension reactivates and a default-deny posture is expected then.
C3 Audit Trail — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C4 Data Retention — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C5 Data-Subject Rights — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
D11 Test Reliability — Test reliability not included — the .java suite was found but not re-run
D12 Dependency Hygiene — Dependency hygiene not measured
D16 Bus Factor — dormant codebase — no living knowledge left to concentrate
D18 Solution Shape — D18 scores the shape of a C#/VB .NET solution, but this repository's production source is mostly .cpp, .erl, .java, which the C#/VB workspace does not load — the projects that loaded are an immaterial minority, so solution shape was not assessed for this repository. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
D23 Boundary Type-Coupling — single shared-core project — no cross-context coupling to assess
D25 ADR Conformance — no ADRs to check
D27 Navigability — D27 counts a call into the standard library or a dependency as unresolved for this repository's language (.java), so too few call sites counted as resolved to assess navigability. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D32 Data Compliance (PII/GDPR) — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D39 IL Efficiency — IL not measured — the analyzer's build of the target did not succeed
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
D8 Code Coverage — Coverage NOT MEASURED: `--collect:"XPlat Code Coverage"` names a data collector that ships in the `coverlet.collector` package, and this repository wires up none — no test project references it and no runsettings declares one. The absence of coverage here is therefore not evidence about the suite or about our analyzer environment: without a collector, `--collect` produces nothing even from a suite that builds and passes. Add a `coverlet.collector` PackageReference to the test project(s) (or commit the Cobertura/OpenCover/lcov report your CI produces) and real coverage will be measured. It is excluded from the score rather than counted as a near-zero defect.
DM1 Domain Modelling — not scored — this repository shows only 1 of the 3 signals this lens looks for (79 value object(s))
ED1 Event-Driven — not scored — this repository shows only 1 of the 3 signals this lens looks for (1 CQRS handler(s))
ED5 Idempotency — 1 mutating command handler(s)/consumer(s) detected and 2 handler method(s) walked, but no persistent write was recognised in any of them — idempotency not assessed
P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
P2 Observability — This repo is a library, not a deployed service — it has no process to operate, so production observability (structured logging, tracing/metrics, health checks) is N/A. A library may log via an injected ILogger, but the absence of operational telemetry is not a defect here. If it grows a host (web API, worker), the dimension reactivates.
P7 Outbound HTTP resilience — not applicable — this isn't a service/API/worker
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (JaCoCo XML — `mvn jacoco:report`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
PF1 Benchmark discipline — Performance is assessed only for perf-relevant repos — a packaged library, one that ships benchmarks, or one already using allocation-aware APIs. This repo isn't one, so the Performance lens is not applicable and is excluded from the score.
PF2 Allocation hygiene — Performance is assessed only for perf-relevant repos — a packaged library, one that ships benchmarks, or one already using allocation-aware APIs. This repo isn't one, so the Performance lens is not applicable and is excluded from the score.
S1 Web-Security Posture — No web surface detected in the analyzed source — no HTTP API or web-UI project (no controllers/minimal-API endpoints, no Razor/Blazor views) and no web middleware (HTTPS redirection, HSTS, security headers, cookies). Transport security, security headers, secure cookies, CSRF/input-validation and middleware-order controls are therefore N/A here — this is a library/CLI/worker, not a web app. Crypto hygiene was still checked and found nothing to flag. If this codebase becomes web-facing, the dimension reactivates automatically.
X31 Test-only surface in a production module — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X5 Nullable reference types — no NRT-eligible projects
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 33 finding(s)

D17 · Explicit Debt · EmptyCatchBlock · ×9

EmptyCatchBlock clients/csharp/qmqclient/Metainfo/MetainfoAddressResolver.cs:59 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock clients/csharp/qmqclient/NewQmq/NewQmqClient.cs:33 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock clients/csharp/qmqclient/ProducerMessageImpl.cs:131 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock clients/csharp/qmqclient/ProducerMessageImpl.cs:143 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock clients/csharp/qmqclient/Transport/QueueSender.cs:76 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock clients/csharp/qmqclient/Transport/SingleEventLoop.cs:31 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock clients/csharp/qmqclient/Transport/TransportClient.cs:273 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock clients/csharp/qmqclient/Util/BatchExecutor.cs:76 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock clients/csharp/qmqclient/Util/Scheduler.cs:51 — empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.

D30 · Dependency Vulnerabilities · High CVE · ×9

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

D17 · Explicit Debt · WriteOnlyPrivateField · ×7

WriteOnlyPrivateField clients/csharp/qmqclient/Codec/Request.cs:8 — private Hashtable EmptyAttachments — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField clients/csharp/qmqclient/Consumer/PulledMessage.cs:20 — private long _startConsume — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField clients/csharp/qmqclient/MessageConsumerProvider.cs:17 — private int Port — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField clients/csharp/qmqclient/MessageConsumerProvider.cs:18 — private string Host — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField clients/csharp/qmqclient/MessageProducerProvider.cs:53 — private string _metaServer — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField clients/csharp/qmqclient/Model/ACKMessage.cs:12 — private long next — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField clients/csharp/qmqclient/Transport/SocketChannel.cs:46 — private int readBufferSize — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.

D29 · Static Analysis (SAST) · REDACTED

REDACTED
REDACTED
REDACTED

D30 · Dependency Vulnerabilities · Critical CVE · ×3

REDACTED
REDACTED
REDACTED

AX3 · Project dependency cycles · Namespace dependency cycle · ×1

Namespace dependency cycle clients/csharp/qmqclient/MessageProducerProvider.cs:7 — The namespaces Qunar.TC.Qmq.Client ↔ Qunar.TC.Qmq.Client.Cluster ↔ Qunar.TC.Qmq.Client.Codec ↔ Qunar.TC.Qmq.Client.Codec.NewQmq ↔ Qunar.TC.Qmq.Client.Consumer ↔ Qunar.TC.Qmq.Client.Metainfo ↔ Qunar.TC.Qmq.Client.Model ↔ Qunar.TC.Qmq.Client.NewQmq ↔ Qunar.TC.Qmq.Client.Pull ↔ Qunar.TC.Qmq.Client.Transport ↔ Qunar.TC.Qmq.Client.Tx ↔ Qunar.TC.Qmq.Client.Util depend on each other. The lightest dependency in the cycle is Qunar.TC.Qmq.Client → Qunar.TC.Qmq.Client.Metainfo (Qunar.TC.Qmq.Client.MessageProducerProvider → Qunar.TC.Qmq.Client.Metainfo.BrokerGroupService, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.

D28 · Secrets (history) · High secret · ×1

REDACTED

Serious — 170 finding(s)

D17 · Explicit Debt · Dead code · ×11

Dead code: BlockMessageException clients/csharp/qmqclient/Exceptions/BlockMessageException.cs:3 — NamedType BlockMessageException — Roslyn's SymbolFinder walked every project the solution loads, including qmqclient, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: DefaultExpiredTime clients/csharp/qmqclient/MessageProducerProvider.cs:50 — Field DefaultExpiredTime — Roslyn's SymbolFinder walked every project the solution loads, including qmqclient, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: InitLenBuffer clients/csharp/qmqclient/Metainfo/MetainfoClient.cs:253 — Method InitLenBuffer — Roslyn's SymbolFinder walked every project the solution loads, including qmqclient, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ACKMessage clients/csharp/qmqclient/Model/ACKMessage.cs:5 — NamedType ACKMessage — Roslyn's SymbolFinder walked every project the solution loads, including qmqclient, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: HandlerMismatchException clients/csharp/qmqclient/Model/HandlerMismatchException.cs:6 — NamedType HandlerMismatchException — Roslyn's SymbolFinder walked every project the solution loads, including qmqclient, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: QueryRequest clients/csharp/qmqclient/Model/QueryRequest.cs:5 — NamedType QueryRequest — Roslyn's SymbolFinder walked every project the solution loads, including qmqclient, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ChannelContext clients/csharp/qmqclient/Transport/ChannelContext.cs:5 — NamedType ChannelContext — Roslyn's SymbolFinder walked every project the solution loads, including qmqclient, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: MarkWriterIndex clients/csharp/qmqclient/Transport/InputStream.cs:7 — Method MarkWriterIndex — Roslyn's SymbolFinder walked every project the solution loads, including qmqclient, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ResetWriterIndex clients/csharp/qmqclient/Transport/InputStream.cs:9 — Method ResetWriterIndex — Roslyn's SymbolFinder walked every project the solution loads, including qmqclient, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: Limit clients/csharp/qmqclient/Transport/InputStream.cs:15 — Method Limit — Roslyn's SymbolFinder walked every project the solution loads, including qmqclient, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ConcurrentPriorityQueue clients/csharp/qmqclient/Util/ConcurrentPriorityQueue.cs:11 — NamedType ConcurrentPriorityQueue — Roslyn's SymbolFinder walked every project the solution loads, including qmqclient, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.

D4 · Code Duplication · Duplicated block (9 lines × 2) · ×11

Duplicated block (9 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:113 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:113-121 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java:116-124 — before extracting anything, compare `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:123 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:123-131 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java:126-134 — before extracting anything, compare `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseIndexStore.java:80 — qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseIndexStore.java:80-88 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseStore.java:65-73 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (9 lines × 2) qmq-metaserver/src/main/java/qunar/tc/qmq/meta/management/AddBrokerAction.java:89 — qmq-metaserver/src/main/java/qunar/tc/qmq/meta/management/AddBrokerAction.java:89-97 | qmq-metaserver/src/main/java/qunar/tc/qmq/meta/management/ReplaceBrokerAction.java:84-92 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (9 lines × 2) qmq-store/src/main/java/qunar/tc/qmq/store/ActionLog.java:53 — qmq-store/src/main/java/qunar/tc/qmq/store/ActionLog.java:53-61 | qmq-store/src/main/java/qunar/tc/qmq/store/MessageLog.java:82-90 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) qmq-store/src/main/java/qunar/tc/qmq/store/DefaultStorage.java:623 — qmq-store/src/main/java/qunar/tc/qmq/store/DefaultStorage.java:623-631 | qmq-store/src/main/java/qunar/tc/qmq/store/MessageLog.java:169-178 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-store/src/main/java/qunar/tc/qmq/store/DefaultStorage.java:623` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/receiver/Receiver.java:221 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/receiver/Receiver.java:221-229 | qmq-server/src/main/java/qunar/tc/qmq/processor/SendMessageWorker.java:219-227 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (9 lines × 2) qmq-store/src/main/java/qunar/tc/qmq/store/ActionLog.java:81 — qmq-store/src/main/java/qunar/tc/qmq/store/ActionLog.java:81-89 | qmq-store/src/main/java/qunar/tc/qmq/store/MessageLog.java:130-138 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) qmq-store/src/main/java/qunar/tc/qmq/store/BuildMessageMemTableEventListener.java:93 — qmq-store/src/main/java/qunar/tc/qmq/store/BuildMessageMemTableEventListener.java:93-101 | qmq-store/src/main/java/qunar/tc/qmq/store/action/PullLogBuilder.java:112-120 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (9 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/startup/ServerWrapper.java:177 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/startup/ServerWrapper.java:177-185 | qmq-server/src/main/java/qunar/tc/qmq/startup/ServerWrapper.java:289-297 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (9 lines × 2) qmq-store/src/main/java/qunar/tc/qmq/store/ConsumerLogFlusher.java:69 — qmq-store/src/main/java/qunar/tc/qmq/store/ConsumerLogFlusher.java:69-77 | qmq-store/src/main/java/qunar/tc/qmq/store/PullLogFlusher.java:70-78 — before extracting anything, compare `qmq-store/src/main/java/qunar/tc/qmq/store/ConsumerLogFlusher.java` and `qmq-store/src/main/java/qunar/tc/qmq/store/PullLogFlusher.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 37 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `event` to `MessageLogRecord` in one and `ActionEvent` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.

X3 · Exception handling · Swallowed exception (empty catch) · ×9

Swallowed exception (empty catch) clients/csharp/qmqclient/Metainfo/MetainfoAddressResolver.cs:59 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) clients/csharp/qmqclient/NewQmq/NewQmqClient.cs:33 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) clients/csharp/qmqclient/ProducerMessageImpl.cs:131 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) clients/csharp/qmqclient/ProducerMessageImpl.cs:143 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) clients/csharp/qmqclient/Transport/QueueSender.cs:76 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) clients/csharp/qmqclient/Transport/SingleEventLoop.cs:31 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) clients/csharp/qmqclient/Transport/TransportClient.cs:273 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) clients/csharp/qmqclient/Util/BatchExecutor.cs:76 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) clients/csharp/qmqclient/Util/Scheduler.cs:51 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.

D4 · Code Duplication · Duplicated block (8 lines × 2) · ×8

Duplicated block (8 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java:84 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java:84-91 | qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageContentBatchBackup.java:72-79 — before extracting anything, compare `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageContentBatchBackup.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java:84` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:213 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:213-220 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java:252-259 — before extracting anything, compare `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/receiver/ReceivedDelayMessageProcessor.java:90 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/receiver/ReceivedDelayMessageProcessor.java:90-97 | qmq-server/src/main/java/qunar/tc/qmq/processor/SendMessageProcessor.java:103-110 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (8 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/MessageSegmentContainer.java:311 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/MessageSegmentContainer.java:311-318 | qmq-store/src/main/java/qunar/tc/qmq/store/MessageLog.java:263-270 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/MessageSegmentContainer.java:311` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `qmq-store/src/main/java/qunar/tc/qmq/store/MessageLog.java:271` calls `getOffsetOrDefault` and `qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/MessageSegmentContainer.java:319` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 2) qmq-store/src/main/java/qunar/tc/qmq/store/ConsumerLogFlusher.java:59 — qmq-store/src/main/java/qunar/tc/qmq/store/ConsumerLogFlusher.java:59-66 | qmq-store/src/main/java/qunar/tc/qmq/store/PullLogFlusher.java:60-67 — before extracting anything, compare `qmq-store/src/main/java/qunar/tc/qmq/store/ConsumerLogFlusher.java` and `qmq-store/src/main/java/qunar/tc/qmq/store/PullLogFlusher.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 37 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (8 lines × 2) qmq-common/src/main/java/qunar/tc/qmq/meta/MetaServerLocator.java:93 — qmq-common/src/main/java/qunar/tc/qmq/meta/MetaServerLocator.java:93-100 | qmq-store/src/main/java/qunar/tc/qmq/store/DefaultStorage.java:185-192 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `closeable` to `Closeable` in one and `AutoCloseable` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (8 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/DispatchLogSegmentContainer.java:83 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/DispatchLogSegmentContainer.java:83-90 | qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/ScheduleSetSegmentContainer.java:78-85 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `result` to `AppendMessageResult<Boolean>` in one and `AppendMessageResult<ScheduleSetSequence>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (8 lines × 2) qmq-store/src/main/java/qunar/tc/qmq/store/ActionLog.java:124 — qmq-store/src/main/java/qunar/tc/qmq/store/ActionLog.java:124-131 | qmq-store/src/main/java/qunar/tc/qmq/store/MessageLog.java:149-156 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.

D4 · Code Duplication · Duplicated block (6 lines × 2) · ×8

Duplicated block (6 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageIndexBatchBackup.java:69 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageIndexBatchBackup.java:69-74 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileIndexStore.java:112-117 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (6 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileIndexStore.java:83 — qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileIndexStore.java:83-88 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java:90-95 — before extracting anything, compare `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileIndexStore.java` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 38 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) qmq-client/src/main/java/qunar/tc/qmq/consumer/pull/PullService.java:220 — qmq-client/src/main/java/qunar/tc/qmq/consumer/pull/PullService.java:220-225 | qmq-remoting/src/main/java/qunar/tc/qmq/protocol/QMQSerializer.java:115-120 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-client/src/main/java/qunar/tc/qmq/consumer/pull/PullService.java:220` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) qmq-client/src/main/java/qunar/tc/qmq/producer/ProduceMessageImpl.java:149 — qmq-client/src/main/java/qunar/tc/qmq/producer/ProduceMessageImpl.java:149-154 | qmq-client/src/main/java/qunar/tc/qmq/producer/ProduceMessageImpl.java:193-198 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-client/src/main/java/qunar/tc/qmq/producer/ProduceMessageImpl.java:149` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) qmq-tools/src/main/java/qunar/tc/qmq/tools/command/AddSubjectBrokerGroupCommand.java:52 — qmq-tools/src/main/java/qunar/tc/qmq/tools/command/AddSubjectBrokerGroupCommand.java:52-57 | qmq-tools/src/main/java/qunar/tc/qmq/tools/command/RemoveSubjectBrokerGroupCommand.java:52-57 — before extracting anything, compare `qmq-tools/src/main/java/qunar/tc/qmq/tools/command/AddSubjectBrokerGroupCommand.java` and `qmq-tools/src/main/java/qunar/tc/qmq/tools/command/RemoveSubjectBrokerGroupCommand.java` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-tools/src/main/java/qunar/tc/qmq/tools/command/AddSubjectBrokerGroupCommand.java:52` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) qmq-tools/src/main/java/qunar/tc/qmq/tools/command/MarkBrokerReadonlyCommand.java:53 — qmq-tools/src/main/java/qunar/tc/qmq/tools/command/MarkBrokerReadonlyCommand.java:53-58 | qmq-tools/src/main/java/qunar/tc/qmq/tools/command/UnMarkBrokerReadonlyCommand.java:53-58 — before extracting anything, compare `qmq-tools/src/main/java/qunar/tc/qmq/tools/command/MarkBrokerReadonlyCommand.java` and `qmq-tools/src/main/java/qunar/tc/qmq/tools/command/UnMarkBrokerReadonlyCommand.java` as WHOLE FILES: 90% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-tools/src/main/java/qunar/tc/qmq/tools/command/MarkBrokerReadonlyCommand.java:53` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/receiver/Receiver.java:214 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/receiver/Receiver.java:214-219 | qmq-server/src/main/java/qunar/tc/qmq/processor/SendMessageWorker.java:229-234 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: the declarations holding them bind `result` to `ReceivedResult` in one and `ReceiveResult` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (6 lines × 2) qmq-server/src/main/java/qunar/tc/qmq/processor/PullMessageProcessor.java:216 — qmq-server/src/main/java/qunar/tc/qmq/processor/PullMessageProcessor.java:216-221 | qmq-store/src/main/java/qunar/tc/qmq/store/DataTransfer.java:72-77 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.

D29 · Static Analysis (SAST) · REDACTED

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

D3 · God Classes · TooManyMethods · ×6

TooManyMethods: QMon qmq-server-common/src/main/java/qunar/tc/qmq/monitor/QMon.java:32 — TooManyMethods — 88 methods. The bar is 30 methods; this is 58 over it, 2.93× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: BaseMessage qmq-common/src/main/java/qunar/tc/qmq/base/BaseMessage.java:33 — TooManyMethods — 62 methods. The bar is 30 methods; this is 32 over it, 2.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: CheckpointManager qmq-store/src/main/java/qunar/tc/qmq/store/CheckpointManager.java:40 — TooManyMethods — 52 methods. The bar is 30 methods; this is 22 over it, 1.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DefaultStorage qmq-store/src/main/java/qunar/tc/qmq/store/DefaultStorage.java:48 — TooManyMethods — 42 methods. The bar is 30 methods; this is 12 over it, 1.40× the bar. Most of these members implement store.Storage (31 of 40 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
TooManyMethods: BaseMessage clients/csharp/qmqclient/Model/BaseMessage.cs — TooManyMethods — 208 significant lines (blank, comment-only and punctuation-only lines excluded), 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: QMon qmq-delay-server/src/main/java/qunar/tc/qmq/delay/monitor/QMon.java:29 — TooManyMethods — 32 methods. The bar is 30 methods; this is 2 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.

D4 · Code Duplication · Duplicated block (11 lines × 2) · ×6

Duplicated block (11 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/DispatchLogSegmentContainer.java:70 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/DispatchLogSegmentContainer.java:70-80 | qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/ScheduleSetSegmentContainer.java:65-75 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/DispatchLogSegmentContainer.java:70` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:90 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:90-100 | qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:103-113 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) qmq-store/src/main/java/qunar/tc/qmq/store/IndexLogVisitor.java:63 — qmq-store/src/main/java/qunar/tc/qmq/store/IndexLogVisitor.java:63-73 | qmq-store/src/main/java/qunar/tc/qmq/store/IndexLogVisitor.java:76-86 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `qmq-store/src/main/java/qunar/tc/qmq/store/IndexLogVisitor.java:73` calls `readString` and `qmq-store/src/main/java/qunar/tc/qmq/store/IndexLogVisitor.java:60` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 2) qmq-tools/src/main/java/qunar/tc/qmq/tools/command/AddBrokerCommand.java:63 — qmq-tools/src/main/java/qunar/tc/qmq/tools/command/AddBrokerCommand.java:63-73 | qmq-tools/src/main/java/qunar/tc/qmq/tools/command/ReplaceBrokerCommand.java:64-74 — before extracting anything, compare `qmq-tools/src/main/java/qunar/tc/qmq/tools/command/AddBrokerCommand.java` and `qmq-tools/src/main/java/qunar/tc/qmq/tools/command/ReplaceBrokerCommand.java` as WHOLE FILES: 92% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (11 lines × 2) qmq-tools/src/main/java/qunar/tc/qmq/tools/command/ListBrokerGroupsCommand.java:36 — qmq-tools/src/main/java/qunar/tc/qmq/tools/command/ListBrokerGroupsCommand.java:36-46 | qmq-tools/src/main/java/qunar/tc/qmq/tools/command/ListSubjectRoutesCommand.java:36-46 — before extracting anything, compare `qmq-tools/src/main/java/qunar/tc/qmq/tools/command/ListBrokerGroupsCommand.java` and `qmq-tools/src/main/java/qunar/tc/qmq/tools/command/ListSubjectRoutesCommand.java` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (11 lines × 2) qmq-client/src/main/java/qunar/tc/qmq/consumer/pull/DefaultPullEntry.java:183 — qmq-client/src/main/java/qunar/tc/qmq/consumer/pull/DefaultPullEntry.java:183-193 | qmq-client/src/main/java/qunar/tc/qmq/consumer/pull/ParallelPullEntry.java:109-119 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.

D4 · Code Duplication · Duplicated block (12 lines × 2) · ×5

Duplicated block (12 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:84 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:84-95 | qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:104-115 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:84` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (12 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:133 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:133-144 | qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:161-172 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:133` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:132` calls `get` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:160` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:169 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:169-180 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java:208-219 — before extracting anything, compare `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:169` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileIndexStore.java:170 — qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileIndexStore.java:170-181 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java:180-191 — before extracting anything, compare `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileIndexStore.java` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 38 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (12 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/ScheduleLogValidatorSupport.java:79 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/ScheduleLogValidatorSupport.java:79-90 | qmq-store/src/main/java/qunar/tc/qmq/store/CheckpointStore.java:46-57 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.

D4 · Code Duplication · Duplicated block (10 lines × 2) · ×5

Duplicated block (10 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/DispatchLogSegmentContainer.java:56 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/DispatchLogSegmentContainer.java:56-65 | qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/ScheduleSetSegmentContainer.java:51-60 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/DispatchLogSegmentContainer.java:56` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) qmq-gateway/src/main/java/qunar/tc/qmq/gateway/servlet/SendServlet.java:164 — qmq-gateway/src/main/java/qunar/tc/qmq/gateway/servlet/SendServlet.java:164-173 | qmq-gateway/src/main/java/qunar/tc/qmq/gateway/servlet/SendServlet.java:179-188 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-gateway/src/main/java/qunar/tc/qmq/gateway/servlet/SendServlet.java:164` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) qmq-store/src/main/java/qunar/tc/qmq/store/ActionLogVisitor.java:56 — qmq-store/src/main/java/qunar/tc/qmq/store/ActionLogVisitor.java:56-65 | qmq-store/src/main/java/qunar/tc/qmq/store/MessageLogRecordVisitor.java:52-61 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-store/src/main/java/qunar/tc/qmq/store/ActionLogVisitor.java:56` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `qmq-store/src/main/java/qunar/tc/qmq/store/MessageLogRecordVisitor.java:51` calls `getLong` and `qmq-store/src/main/java/qunar/tc/qmq/store/ActionLogVisitor.java:55` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 2) qmq-store/src/main/java/qunar/tc/qmq/store/ConsumerLogFlusher.java:99 — qmq-store/src/main/java/qunar/tc/qmq/store/ConsumerLogFlusher.java:99-108 | qmq-store/src/main/java/qunar/tc/qmq/store/PullLogFlusher.java:100-109 — before extracting anything, compare `qmq-store/src/main/java/qunar/tc/qmq/store/ConsumerLogFlusher.java` and `qmq-store/src/main/java/qunar/tc/qmq/store/PullLogFlusher.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 37 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (10 lines × 2) qmq-store/src/main/java/qunar/tc/qmq/store/ConsumerLogFlusher.java:44 — qmq-store/src/main/java/qunar/tc/qmq/store/ConsumerLogFlusher.java:44-53 | qmq-store/src/main/java/qunar/tc/qmq/store/PullLogFlusher.java:45-54 — before extracting anything, compare `qmq-store/src/main/java/qunar/tc/qmq/store/ConsumerLogFlusher.java` and `qmq-store/src/main/java/qunar/tc/qmq/store/PullLogFlusher.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 37 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.

D4 · Code Duplication · Duplicated block (7 lines × 2) · ×5

Duplicated block (7 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:120 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:120-126 | qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:149-155 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:120` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:177 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:177-183 | qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:202-208 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageServiceImpl.java:177` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:191 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:191-197 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java:230-236 — before extracting anything, compare `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:191` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/sync/HeartBeatProcessor.java:46 — qmq-backup/src/main/java/qunar/tc/qmq/backup/sync/HeartBeatProcessor.java:46-52 | qmq-sync/src/main/java/qunar/tc/qmq/sync/HeartbeatProcessor.java:45-51 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) qmq-server/src/main/java/qunar/tc/qmq/processor/PullMessageProcessor.java:197 — qmq-server/src/main/java/qunar/tc/qmq/processor/PullMessageProcessor.java:197-203 | qmq-store/src/main/java/qunar/tc/qmq/store/DataTransfer.java:53-59 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.

D4 · Code Duplication · Duplicated block (5 lines × 2) · ×5

Duplicated block (5 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:206 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:206-210 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java:245-249 — before extracting anything, compare `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/RecordBatchBackup.java:206` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileIndexStore.java:98 — qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileIndexStore.java:98-102 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java:105-109 — before extracting anything, compare `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileIndexStore.java` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 38 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileIndexStore.java:98` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java:95 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java:95-99 | qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageContentBatchBackup.java:92-96 — before extracting anything, compare `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageContentBatchBackup.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageContentBatchBackup.java:91` calls `info` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java:93` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/AbstractHBaseMessageStore.java:61 — qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/AbstractHBaseMessageStore.java:61-65 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseDeadMessageContentStore.java:86-90 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/AbstractHBaseMessageStore.java:61` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/MessageSegmentContainer.java:329 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/MessageSegmentContainer.java:329-333 | qmq-store/src/main/java/qunar/tc/qmq/store/MessageLog.java:280-284 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `RawMessageExtend` in one and `RawMessage` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.

D17 · Explicit Debt · TodoComment · ×4

TodoComment clients/csharp/qmqclient/Cluster/NewQmqCluster.cs:66 — // TODO(keli.wang): make timeout configable — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment clients/csharp/qmqclient/NewQmq/AckHandlerQueue.cs:187 — // TODO(keli.wang): when one ack delay and blocks many other acks, can we just make this one a nack? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment clients/csharp/qmqclient/NewQmq/PullMessageDataTransformer.cs:35 — // TODO(keli.wang): return list of messages or a special object? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment clients/csharp/qmqclient/NewQmq/SendMessageDataTransformer.cs:21 — // TODO(keli.wang): don't use request id here? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.

X1 · Async correctness · Sync-over-async (deadlock risk) through `.Result` · ×4

Sync-over-async (deadlock risk) through `.Result` clients/csharp/qmqclient/Consumer/PullConsumerRegister.cs:100 — Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` clients/csharp/qmqclient/Pull/DefaultPullConsumer.cs:71 — Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` clients/csharp/qmqclient/Pull/DefaultPullConsumer.cs:100 — Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` clients/csharp/qmqclient/Pull/DefaultPullConsumer.cs:148 — Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.

D30 · Dependency Vulnerabilities · Medium CVE · ×3

REDACTED
REDACTED
REDACTED

GD1 · Unfinished & placeholder code · Unfinished stub · ×3

Unfinished stub — throws NotImplementedException clients/csharp/qmqclient/Transport/PacketInputStream.cs:80 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException clients/csharp/qmqclient/Transport/PacketInputStream.cs:85 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException clients/csharp/qmqclient/Transport/PacketInputStream.cs:90 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.

PF3 · Async & latency hygiene · Sync-over-async blocking · ×3

Sync-over-async blocking — 2 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking clients/csharp/qmqclient/Transport/Future.cs:28 — `_event.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking clients/csharp/qmqclient/Util/WaitHolder.cs:18 — `_waitAvaliable.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).

D17 · Explicit Debt · CommentedOutCode · ×2

CommentedOutCode clients/csharp/qmqclient/Util/ClientId.cs:43 — 3 consecutive commented-code lines
CommentedOutCode clients/csharp/qmqclient/Util/PortSelector.cs:11 — 3 consecutive commented-code lines

D29 · Static Analysis (SAST) · REDACTED

REDACTED
REDACTED

D6 · Cohesion (LCOM4) · Low cohesion · ×2

Low cohesion: CheckpointManager (LCOM4 6) qmq-store/src/main/java/qunar/tc/qmq/store/CheckpointManager.java:40 — CheckpointManager's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: MessageLogSyncWorker (LCOM4 5) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/sync/master/MessageLogSyncWorker.java:42 — MessageLogSyncWorker's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.

X18 · Disposal-pattern correctness · Owned disposable field is never released · ×2

Owned disposable field is never released clients/csharp/qmqclient/Util/BatchExecutor.cs:17 — `BatchExecutor` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_workQueue` itself (line 17), which makes that instance its own. But `_workQueue` is named in none of the methods the disposal search covered: `Dispose` (line 123) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_workQueue?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
Owned disposable field is never released clients/csharp/qmqclient/Util/BatchExecutor.cs:18 — `BatchExecutor` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `_queue` itself (line 18), which makes that instance its own. But `_queue` is named in none of the methods the disposal search covered: `Dispose` (line 123) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`_queue?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.

X2 · Cancellation propagation · Async method without CancellationToken · ×2

Async method without CancellationToken: AsyncPull clients/csharp/qmqclient/Pull/DefaultPullConsumer.cs:127 — No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Pull clients/csharp/qmqclient/Pull/Puller.cs:47 — No CancellationToken parameter — this work can't be stopped early once started.

D1 · Cyclomatic Complexity · DefaultStorage.pollFromConsumerLog (cyclomatic 21) · ×1

DefaultStorage.pollFromConsumerLog (cyclomatic 21) qmq-store/src/main/java/qunar/tc/qmq/store/DefaultStorage.java:258 — DefaultStorage.pollFromConsumerLog has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.

D1 · Cyclomatic Complexity · MessageStoreWrapper.doFindUnAckMessages (cyclomatic 20) · ×1

MessageStoreWrapper.doFindUnAckMessages (cyclomatic 20) qmq-server/src/main/java/qunar/tc/qmq/store/MessageStoreWrapper.java:279 — MessageStoreWrapper.doFindUnAckMessages has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.

D1 · Cyclomatic Complexity · DelayMessageLogVisitor.readOneRecord (cyclomatic 16) · ×1

DelayMessageLogVisitor.readOneRecord (cyclomatic 16) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:45 — DelayMessageLogVisitor.readOneRecord has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.

D10 · Test Quality · No assertions · ×1

No assertions: bulkload qmq-backup/src/test/bulkloadtest/BulkloadTest.java:24 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.

D10 · Test Quality · Test project verifies nothing · ×1

Test project verifies nothing: qmq-backup qmq-backup/src/test/bulkloadtest/BulkloadTest.java:24 — No conventional assertion call was detected in 1 of 1 tests in `qmq-backup` — the project as a whole, not one method. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a suite that genuinely checks nothing. If it is the latter, this project passes unconditionally and cannot fail.

D19 · Documentation Quality · Low XML-doc coverage · ×1

Low XML-doc coverage: qmqclient REDACTED — qmqclient: 4 % XML-doc coverage (23/592).

D2 · Cognitive Complexity · MessageStoreWrapper.doFindUnAckMessages (cognitive 38) · ×1

MessageStoreWrapper.doFindUnAckMessages (cognitive 38) qmq-server/src/main/java/qunar/tc/qmq/store/MessageStoreWrapper.java:279 — MessageStoreWrapper.doFindUnAckMessages has cognitive complexity 38 (threshold 15). Drivers by points: if/else 18 (32 pts), boolean chains 3, error handling 1 (2 pts), loops 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · DefaultStorage.pollFromConsumerLog (cognitive 37) · ×1

DefaultStorage.pollFromConsumerLog (cognitive 37) qmq-store/src/main/java/qunar/tc/qmq/store/DefaultStorage.java:258 — DefaultStorage.pollFromConsumerLog has cognitive complexity 37 (threshold 15). Drivers by points: if/else 18 (34 pts), boolean chains 1, loops 1, ternaries 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · SocketChannel.Flush (cognitive 28) · ×1

SocketChannel.Flush (cognitive 28) clients/csharp/qmqclient/Transport/SocketChannel.cs:146 — SocketChannel.Flush has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · DelayMessageLogVisitor.readOneRecord (cognitive 28) · ×1

DelayMessageLogVisitor.readOneRecord (cognitive 28) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:45 — DelayMessageLogVisitor.readOneRecord has cognitive complexity 28 (threshold 15). Drivers by points: if/else 16 (28 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · MinBinaryHeap.Remove (cognitive 24) · ×1

MinBinaryHeap.Remove (cognitive 24) clients/csharp/qmqclient/Util/ConcurrentPriorityQueue.cs:288 — MinBinaryHeap.Remove has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · NetworkUtils.getLocalAddress (cognitive 24) · ×1

NetworkUtils.getLocalAddress (cognitive 24) qmq-common/src/main/java/qunar/tc/qmq/utils/NetworkUtils.java:47 — NetworkUtils.getLocalAddress has cognitive complexity 24 (threshold 15). Drivers by points: if/else 9 (18 pts), loops 3 (5 pts), error handling 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · IndexLog.copy (cognitive 23) · ×1

IndexLog.copy (cognitive 23) qmq-store/src/main/java/qunar/tc/qmq/store/IndexLog.java:147 — IndexLog.copy has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (22 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · MessageIndexSyncWorker.getSyncLog (cognitive 22) · ×1

MessageIndexSyncWorker.getSyncLog (cognitive 22) qmq-server/src/main/java/qunar/tc/qmq/sync/master/MessageIndexSyncWorker.java:51 — MessageIndexSyncWorker.getSyncLog has cognitive complexity 22 (threshold 15). Drivers by points: if/else 13 (21 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · SenderGroup.send (cognitive 21) · ×1

SenderGroup.send (cognitive 21) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/sender/SenderGroup.java:120 — SenderGroup.send has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (15 pts), boolean chains 3, loops 1 (2 pts), error handling 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · WeightLoadBalance.select (cognitive 21) · ×1

WeightLoadBalance.select (cognitive 21) qmq-client/src/main/java/qunar/tc/qmq/consumer/pull/WeightLoadBalance.java:45 — WeightLoadBalance.select has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (15 pts), boolean chains 3, loops 2 (3 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · MessageLogRecordVisitor.readOneRecord (cognitive 20) · ×1

MessageLogRecordVisitor.readOneRecord (cognitive 20) qmq-store/src/main/java/qunar/tc/qmq/store/MessageLogRecordVisitor.java:36 — MessageLogRecordVisitor.readOneRecord has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (20 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · SendServlet.appendAttrs (cognitive 20) · ×1

SendServlet.appendAttrs (cognitive 20) qmq-gateway/src/main/java/qunar/tc/qmq/gateway/servlet/SendServlet.java:103 — SendServlet.appendAttrs has cognitive complexity 20 (threshold 15). Drivers by points: if/else 9 (18 pts), boolean chains 1, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · SendMessageTask.processErrorMessages (cognitive 19) · ×1

SendMessageTask.processErrorMessages (cognitive 19) qmq-watchdog/src/main/java/qunar/tc/qmq/task/SendMessageTask.java:123 — SendMessageTask.processErrorMessages has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (10 pts), error handling 3 (5 pts), ternaries 1 (3 pts), loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · NettyConnectManageHandler.getOrCreateChannel (cognitive 19) · ×1

NettyConnectManageHandler.getOrCreateChannel (cognitive 19) qmq-remoting/src/main/java/qunar/tc/qmq/netty/client/NettyConnectManageHandler.java:78 — NettyConnectManageHandler.getOrCreateChannel has cognitive complexity 19 (threshold 15). Drivers by points: if/else 13 (17 pts), boolean chains 1, error handling 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.

D2 · Cognitive Complexity · DefaultPullEntry.run (cognitive 19) · ×1

DefaultPullEntry.run (cognitive 19) qmq-client/src/main/java/qunar/tc/qmq/consumer/pull/DefaultPullEntry.java:109 — DefaultPullEntry.run has cognitive complexity 19 (threshold 15). Drivers by points: if/else 6 (13 pts), error handling 3 (5 pts), match/switch 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · PollBrokerLoadBalance.loadBalance (cognitive 18) · ×1

PollBrokerLoadBalance.loadBalance (cognitive 18) qmq-common/src/main/java/qunar/tc/qmq/broker/impl/PollBrokerLoadBalance.java:48 — PollBrokerLoadBalance.loadBalance has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (11 pts), loops 3 (6 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · WeightLoadBalance.Select (cognitive 17) · ×1

WeightLoadBalance.Select (cognitive 17) clients/csharp/qmqclient/NewQmq/WeightLoadBalance.cs:18 — WeightLoadBalance.Select has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · DefaultPullConsumer.AsyncPull (cognitive 17) · ×1

DefaultPullConsumer.AsyncPull (cognitive 17) clients/csharp/qmqclient/Pull/DefaultPullConsumer.cs:127 — DefaultPullConsumer.AsyncPull has cognitive complexity 17 (threshold 15). Most of this is not in the body itself: 3 of the 17 points are its own statements and the rest belongs to one function literal inside it that branches (line 141). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.

D2 · Cognitive Complexity · 1.onLoad (cognitive 17) · ×1

1.onLoad (cognitive 17) qmq-client/src/main/java/qunar/tc/qmq/config/PullSubjectsConfig.java:72 — 1.onLoad has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (11 pts), loops 4 (5 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · MetaInfoService.parseResponse (cognitive 16) · ×1

MetaInfoService.parseResponse (cognitive 16) qmq-remoting/src/main/java/qunar/tc/qmq/metainfoclient/MetaInfoService.java:188 — MetaInfoService.parseResponse has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (10 pts), boolean chains 3, loops 2, ternaries 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.

D2 · Cognitive Complexity · HBaseStore.scan (cognitive 16) · ×1

HBaseStore.scan (cognitive 16) qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseStore.java:91 — HBaseStore.scan has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (12 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.

D29 · Static Analysis (SAST) · REDACTED · ×1

REDACTED

D3 · God Classes · ClassTooLong · ×1

ClassTooLong: DefaultStorage qmq-store/src/main/java/qunar/tc/qmq/store/DefaultStorage.java:48 — ClassTooLong — 405 significant lines (blank, comment-only and punctuation-only lines excluded), 42 methods. The bar is 400 significant lines; this is 5 over it, 1.01× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

D36 · Supply-chain Provenance & Signing REDACTED · ×1

REDACTED

D4 · Code Duplication · Near-duplicate member pair (42 shared lines) · ×1

Near-duplicate member pair (42 shared lines) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:45 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:45-145 | qmq-store/src/main/java/qunar/tc/qmq/store/MessageLogRecordVisitor.java:36-100 — These two members are variants of one another: 42 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.

D4 · Code Duplication · Near-duplicate member pair (30 shared lines) · ×1

Near-duplicate member pair (30 shared lines) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java:83 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java:83-128 | qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageContentBatchBackup.java:71-120 — These two members are variants of one another: 30 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.

D4 · Code Duplication · Duplicated block (27 lines × 2) · ×1

Duplicated block (27 lines × 2) clients/csharp/qmqclient/NewQmq/AckHandlerQueue.cs:137 — clients/csharp/qmqclient/NewQmq/AckHandlerQueue.cs:137-163 | clients/csharp/qmqclient/NewQmq/AckHandlerQueue.cs:205-231 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `clients/csharp/qmqclient/NewQmq/AckHandlerQueue.cs:137` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (21–24 lines × 2) · ×1

Duplicated block (21–24 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:109 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:109-132 | qmq-store/src/main/java/qunar/tc/qmq/store/MessageLogRecordVisitor.java:68-88 — before extracting anything, compare `qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java` and `qmq-store/src/main/java/qunar/tc/qmq/store/MessageLogRecordVisitor.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `qmq-store/src/main/java/qunar/tc/qmq/store/MessageLogRecordVisitor.java:89` calls `position` and `qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:133` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.

D4 · Code Duplication · Duplicated block (19 lines × 2) · ×1

Duplicated block (19 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/MessageSegmentContainer.java:357 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/MessageSegmentContainer.java:357-375 | qmq-store/src/main/java/qunar/tc/qmq/store/ActionLog.java:189-207 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.

D4 · Code Duplication · Duplicated block (15–19 lines × 2) · ×1

Duplicated block (15–19 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:46 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:46-64 | qmq-store/src/main/java/qunar/tc/qmq/store/MessageLogRecordVisitor.java:37-51 — before extracting anything, compare `qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java` and `qmq-store/src/main/java/qunar/tc/qmq/store/MessageLogRecordVisitor.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.

D4 · Code Duplication · Duplicated block (17 lines × 2) · ×1

Duplicated block (17 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java:109 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java:109-125 | qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageContentBatchBackup.java:101-117 — before extracting anything, compare `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageContentBatchBackup.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java:109` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (16 lines × 2) · ×1

Duplicated block (16 lines × 2) qmq-store/src/main/java/qunar/tc/qmq/store/LogManager.java:58 — qmq-store/src/main/java/qunar/tc/qmq/store/LogManager.java:58-73 | qmq-store/src/main/java/qunar/tc/qmq/store/SortedPullLogTable.java:208-223 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.

D4 · Code Duplication · Duplicated block (15 lines × 2) · ×1

Duplicated block (15 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileIndexStore.java:152 — qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileIndexStore.java:152-166 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java:162-176 — before extracting anything, compare `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileIndexStore.java` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileRecordStore.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 38 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.

D4 · Code Duplication · Duplicated block (14 lines × 2) · ×1

Duplicated block (14 lines × 2) qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/AbstractHBaseMessageStore.java:67 — qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/AbstractHBaseMessageStore.java:67-80 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseDeadMessageContentStore.java:97-110 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/AbstractHBaseMessageStore.java:67` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/AbstractHBaseMessageStore.java:82` calls `getMessagesWithMeta` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseDeadMessageContentStore.java:112` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.

D4 · Code Duplication · Duplicated block (11–12 lines × 2) · ×1

Duplicated block (11–12 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/receiver/ReceivedDelayMessageProcessor.java:55 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/receiver/ReceivedDelayMessageProcessor.java:55-65 | qmq-server/src/main/java/qunar/tc/qmq/processor/SendMessageProcessor.java:71-82 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-delay-server/src/main/java/qunar/tc/qmq/delay/receiver/ReceivedDelayMessageProcessor.java:55` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (6–10 lines × 2) · ×1

Duplicated block (6–10 lines × 2) qmq-remoting/src/main/java/qunar/tc/qmq/netty/EncodeHandler.java:56 — qmq-remoting/src/main/java/qunar/tc/qmq/netty/EncodeHandler.java:56-61 | qmq-server/src/main/java/qunar/tc/qmq/utils/HeaderSerializer.java:36-45 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.

D4 · Code Duplication · Duplicated block (7–8 lines × 2) · ×1

Duplicated block (7–8 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/MessageSegmentContainer.java:121 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/MessageSegmentContainer.java:121-127 | qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/MessageSegmentContainer.java:398-405 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/MessageSegmentContainer.java:121` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (7 lines × 3) · ×1

Duplicated block (7 lines × 3) qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseIndexStore.java:83 — qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseIndexStore.java:83-89 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseRecordStore.java:201-207 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseStore.java:68-74 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.

D4 · Code Duplication · Duplicated block (3–7 lines × 3) · ×1

Duplicated block (3–7 lines × 3) qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseIndexStore.java:91 — qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseIndexStore.java:91-97 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseRecordStore.java:209-215 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseStore.java:75-77 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseIndexStore.java:91` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseIndexStore.java:91` calls `BackupMessageMeta`, `String` and `qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HBaseStore.java:75` does not — after which the two agree again for 5 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.

D4 · Code Duplication · Duplicated block (6 lines × 3) · ×1

Duplicated block (6 lines × 3) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:66 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java:66-72 | qmq-store/src/main/java/qunar/tc/qmq/store/ActionLogVisitor.java:57-62 | qmq-store/src/main/java/qunar/tc/qmq/store/MessageLogRecordVisitor.java:53-58 — before extracting anything, compare `qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/visitor/DelayMessageLogVisitor.java` and `qmq-store/src/main/java/qunar/tc/qmq/store/MessageLogRecordVisitor.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 50 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `qmq-store/src/main/java/qunar/tc/qmq/store/MessageLogRecordVisitor.java:51` calls `getLong` and `qmq-store/src/main/java/qunar/tc/qmq/store/ActionLogVisitor.java:55` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.

D4 · Code Duplication · Duplicated block (5 lines × 3) · ×1

Duplicated block (5 lines × 3) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/BackupKeyGenerator.java:52 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/BackupKeyGenerator.java:52-56 | qmq-backup/src/main/java/qunar/tc/qmq/backup/service/BackupKeyGenerator.java:64-68 | qmq-backup/src/main/java/qunar/tc/qmq/backup/service/BackupKeyGenerator.java:75-79 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-backup/src/main/java/qunar/tc/qmq/backup/service/BackupKeyGenerator.java:52` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.

D4 · Code Duplication · Duplicated block (4–5 lines × 3) · ×1

Duplicated block (4–5 lines × 3) qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java:100 — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java:100-103 | qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageIndexBatchBackup.java:76-80 | qmq-backup/src/main/java/qunar/tc/qmq/backup/store/impl/HFileIndexStore.java:119-123 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.

D4 · Code Duplication · Duplicated block (34 lines × 2) · ×1

Duplicated block (34 lines × 2) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/receiver/filter/ValidateFilter.java:1 — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/receiver/filter/ValidateFilter.java:1-37 | qmq-server/src/main/java/qunar/tc/qmq/processor/filters/ValidateFilter.java:1-34 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-delay-server/src/main/java/qunar/tc/qmq/delay/receiver/filter/ValidateFilter.java:1` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (51 lines × 2) · ×1

Duplicated block (51 lines × 2) qmq-remoting/src/main/java/qunar/tc/qmq/protocol/consumer/AckRequest.java:1 — qmq-remoting/src/main/java/qunar/tc/qmq/protocol/consumer/AckRequest.java:1-77 | qmq-server-common/src/main/java/qunar/tc/qmq/base/ActionLogOffsetRequest.java:1-51 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `qmq-remoting/src/main/java/qunar/tc/qmq/protocol/consumer/AckRequest.java:1` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.

D44 · Platform End-of-Life · End-of-life framework · ×1

End-of-life framework: Spring Boot 1 qmq-demo/pom.xml:1 — qmq-demo/pom.xml depends on `org.springframework.boot` at a version that pins Spring Boot 1, and Spring Boot 1.x, open-source support ended 2019-08-01. The constraint cannot admit a different major, so this repository stays on it until the declaration is edited. An end-of-life framework receives no further releases, including security releases.

D8 · Code Coverage · Coverage not measured · ×1

Coverage not measured — no coverage collector is wired up — Coverage NOT MEASURED: `--collect:"XPlat Code Coverage"` names a data collector that ships in the `coverlet.collector` package, and this repository wires up none — no test project references it and no runsettings declares one. The absence of coverage here is therefore not evidence about the suite or about our analyzer environment: without a collector, `--collect` produces nothing even from a suite that builds and passes. Add a `coverlet.collector` PackageReference to the test project(s) (or commit the Cobertura/OpenCover/lcov report your CI produces) and real coverage will be measured. It is excluded from the score rather than counted as a near-zero defect.

IC1 · Incompleteness & stubs · Unfinished stub · ×1

Unfinished stub — throws NotImplementedException clients/csharp/qmqclient/Transport/PacketInputStream.cs:90 — `Write` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.

P8 · Schema migrations · Schema created by Hibernate ddl-auto (no migration path) · ×1

Schema created by Hibernate ddl-auto (no migration path) qmq-demo/src/main/resources/application.properties:15 — Hibernate ddl-auto builds the schema from the model at startup and keeps no migration history, so there is no reviewed, repeatable upgrade path for an existing production database — a renamed column is dropped and re-added rather than migrated. Adopt Flyway or Liquibase, with `ddl-auto` set to `validate`, so every schema change is a versioned file applied the same way in every environment.

SC1 · Supply-chain hygiene · NuGet dependencies are not locked · ×1

NuGet dependencies are not locked — No packages.lock.json and no central package management — restores aren't reproducible or pinned (SSDF PW.4.4). Enable <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> (commit the lockfile) or adopt Directory.Packages.props. Advisory — never scored.

X20 · Mistyped argument guard · Argument guard throws the exception its own condition disproves · ×1

Argument guard throws the exception its own condition disproves clients/csharp/qmqclient/MessageConsumerProvider.cs:48 — The guard on line 46 rejects `group` and line 48 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(group)` is true of a value that is NOT null: it is satisfied by an EMPTY `group`, and on that path `group` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.

X3 · Exception handling · Swallowed exception (caught, then discarded) · ×1

Swallowed exception (caught, then discarded) clients/csharp/qmqclient/Tx/TransactionMessageHolder.cs:36 — `catch (Exception)` does nothing with the exception it caught — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch. Log it through whatever this codebase already uses to report problems, or let it propagate; if one specific failure genuinely cannot matter, catch exactly that exception type and say why in a comment on the catch.

Minor — 81 finding(s)

D34 · Knowledge Freshness · Orphaned file · ×35

Orphaned file clients/csharp/qmqclient/Util/ConcurrentPriorityQueue.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Transport/SocketChannel.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Metainfo/MetainfoClient.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/NewQmq/AckHandlerQueue.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Model/BaseMessage.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Transport/TransportClient.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Pull/DefaultPullConsumer.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Pull/Puller.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/NewQmq/AckHandler.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Transport/QueueSender.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Consumer/PullConsumerRegister.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/NewQmq/NewQmqClient.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/MessageProducerProvider.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/MessageConsumerProvider.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/NewQmq/PullMessageDataTransformer.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Cluster/NewQmqCluster.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Util/PriorityQueue.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/NewQmq/MessageSendPayloadHolder.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Util/BatchExecutor.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Metainfo/BrokerGroupService.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Tx/TransactionMessageHolder.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Consumer/MessageDistributor.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Transport/DecodeHandler.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/Transport/Packet.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file clients/csharp/qmqclient/ProducerMessageImpl.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
+ 10 more in this group — see findings.md.

X10 · Duplicated predicate · Duplicated predicate · ×11

Duplicated predicate qmq-store/src/main/java/qunar/tc/qmq/store/LogManager.java:70 — `!logDir.isDirectory() || !logDir.canRead()` appears character-identically in 2 files — qmq-store/src/main/java/qunar/tc/qmq/store/LogManager.java, qmq-store/src/main/java/qunar/tc/qmq/store/SortedPullLogTable.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate qmq-client/src/main/java/qunar/tc/qmq/consumer/pull/AckService.java:214 — `!responseFuture.isSendOk() || response == null` appears character-identically in 2 files — qmq-client/src/main/java/qunar/tc/qmq/consumer/pull/AckService.java, qmq-client/src/main/java/qunar/tc/qmq/consumer/pull/SendMessageBackImpl.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate qmq-metaserver/src/main/java/qunar/tc/qmq/meta/management/AddSubjectBrokerGroupAction.java:49 — `Strings.isNullOrEmpty(brokerGroup) || Strings.isNullOrEmpty(subject)` appears character-identically in 2 files — qmq-metaserver/src/main/java/qunar/tc/qmq/meta/management/AddSubjectBrokerGroupAction.java, qmq-metaserver/src/main/java/qunar/tc/qmq/meta/management/RemoveSubjectBrokerGroupAction.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate qmq-metaserver/src/main/java/qunar/tc/qmq/meta/management/MarkReadonlyBrokerGroupAction.java:45 — `Strings.isNullOrEmpty(subject) || Strings.isNullOrEmpty(brokerGroup)` appears character-identically in 2 files — qmq-metaserver/src/main/java/qunar/tc/qmq/meta/management/MarkReadonlyBrokerGroupAction.java, qmq-metaserver/src/main/java/qunar/tc/qmq/meta/management/UnMarkReadonlyBrokerGroupAction.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate qmq-client/src/main/java/qunar/tc/qmq/consumer/pull/PlainPullEntry.java:51 — `brokerGroup == null || !brokerGroup.isAvailable()` appears character-identically in 2 files — qmq-client/src/main/java/qunar/tc/qmq/consumer/pull/PlainPullEntry.java, qmq-common/src/main/java/qunar/tc/qmq/broker/BrokerGroupInfo.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/DirectBufCloser.java:30 — `buffer == null || !buffer.isDirect() || buffer.capacity() == 0` appears character-identically in 2 files — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/DirectBufCloser.java, qmq-store/src/main/java/qunar/tc/qmq/store/LogSegment.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate qmq-server/src/main/java/qunar/tc/qmq/consumer/ConsumerSequenceManager.java:73 — `consumers == null || consumers.isEmpty()` appears character-identically in 2 files — qmq-server/src/main/java/qunar/tc/qmq/consumer/ConsumerSequenceManager.java, qmq-store/src/main/java/qunar/tc/qmq/store/PullLogManager.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/MessageSegmentContainer.java:307 — `recordSize != freeSpace && recordSize + MIN_RECORD_BYTES > freeSpace` appears character-identically in 2 files — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/MessageSegmentContainer.java, qmq-store/src/main/java/qunar/tc/qmq/store/MessageLog.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate qmq-metaserver/src/main/java/qunar/tc/qmq/meta/cache/BrokerMetaManager.java:78 — `role == BrokerRole.SLAVE || role == BrokerRole.DELAY_SLAVE` appears character-identically in 2 files — qmq-metaserver/src/main/java/qunar/tc/qmq/meta/cache/BrokerMetaManager.java, qmq-metaserver/src/main/java/qunar/tc/qmq/meta/processor/BrokerAcquireMetaProcessor.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate qmq-delay-server/src/main/java/qunar/tc/qmq/delay/receiver/Receiver.java:156 — `shouldWaitSlave() && waitSlaveSyncQueue.size() >= config.getInt("receive.queue.size", 50000)` appears character-identically in 2 files — qmq-delay-server/src/main/java/qunar/tc/qmq/delay/receiver/Receiver.java, qmq-server/src/main/java/qunar/tc/qmq/processor/SendMessageWorker.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java:113 — `tailIndex == null || tailIndex.compareTo(index) < 0` appears character-identically in 3 files — qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageBatchBackup.java, qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/DeadMessageContentBatchBackup.java, qmq-backup/src/main/java/qunar/tc/qmq/backup/service/impl/MessageIndexBatchBackup.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.

AX6 · Interface segregation · Fat interface · ×7

Fat interface: Message (31 members) clients/csharp/qmqclient/Message.cs:7 — `Message` declares 31 members: `MessageId`, `Subject`, `CreatedTime`, `ExpiredTime`, `ScheduleReceiveTime`, `AutoAck`, `StoreAtFailed`, `Times`, `SetProperty`, `SetProperty`, `SetProperty`, `SetProperty`, `SetProperty`, `SetProperty`, `SetProperty`, `SetLargeString`, `GetLargeString`, `GetBooleanProperty`, `GetIntProperty`, `GetLongProperty`, `GetFloatProperty`, `GetDoubleProperty`, `GetDateProperty`, `GetStringProperty`, `SetDelayTime`, `SetDelayTime`, `Ack`, `Ack`, `Durable`, `SetTags`, `GetTags`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 31 declarations carry 23 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 23 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: Storage (32 abstract methods) qmq-store/src/main/java/qunar/tc/qmq/store/Storage.java:35 — `Storage` declares 32 abstract methods: `allConsumerGroupProgresses`, `allPullLogs`, `appendActionLogData`, `appendMessage`, `appendMessageLogData`, `destroyPullLog`, `disableLagMonitor`, `getActionLogData`, `getCheckpointManager`, `getConsumerGroupProgress`, `getMaxActionLogOffset`, `getMaxMessageOffset`, `getMaxPulledMessageSequence`, `getMessage`, `getMessageData`, `getMessageSequenceByPullLog`, `getMinActionLogOffset`, `getMinMessageOffset`, `getPullLogReplayState`, `getStorageConfig`, `getSubjectConsumerLogBound`, `locateConsumeQueue`, `locateSubjectConsumeQueues`, `newMessageLogVisitor`, `pollMessages`, `pollMessages`, `putAction`, `putPullLogs`, `registerActionEventListener`, `registerEventListener`, `start`, `updateConsumeQueue`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 32 declarations carry 31 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 31 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: StorageConfig (23 abstract methods) qmq-store/src/main/java/qunar/tc/qmq/store/StorageConfig.java:23 — `StorageConfig` declares 23 abstract methods: `getActionCheckpointInterval`, `getActionLogStorePath`, `getCheckpointRetainCount`, `getCheckpointStorePath`, `getConsumerLogRetentionMs`, `getConsumerLogStorePath`, `getIndexLogStorePath`, `getLogDispatcherPauseMillis`, `getLogRetentionCheckIntervalSeconds`, `getLogRetentionMs`, `getMaxActiveMemTable`, `getMaxReservedMemTable`, `getMessageCheckpointInterval`, `getMessageLogRetentionMs`, `getMessageLogStorePath`, `getPullLogRetentionMs`, `getPullLogSMTStorePath`, `getPullLogStorePath`, `getRetryDelaySeconds`, `getSMTRetentionMs`, `getSMTStorePath`, `isConsumerLogV2Enable`, `isSMTEnable`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: Store (20 abstract methods) qmq-metaserver/src/main/java/qunar/tc/qmq/meta/store/Store.java:35 — `Store` declares 20 abstract methods: `batchUpdateMetaInfo`, `getAllBrokerGroups`, `getAllSubjectInfo`, `getAllSubjectRoutes`, `getBrokerGroup`, `getSubjectInfo`, `insertClientMetaInfo`, `insertOrUpdateBrokerGroup`, `insertSubject`, `insertSubjectRoute`, `queryClientIds`, `queryConsumerByAppAndSubject`, `queryConsumerByIdAndSubject`, `queryConsumerBySubject`, `selectSubjectRoute`, `updateBrokerGroup`, `updateBrokerGroupExt`, `updateBrokerGroupTag`, `updateSubjectRoute`, `updateTimeByIds`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: StoreConfiguration (17 abstract methods) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/config/StoreConfiguration.java:25 — `StoreConfiguration` declares 17 abstract methods: `getCheckCleanTimeBeforeDispatch`, `getCheckpointStorePath`, `getConfig`, `getDispatchLogKeepTime`, `getDispatchLogStorePath`, `getLoadBlockingExitTimesInMillis`, `getLoadInAdvanceTimesInMillis`, `getLoadSegmentDelayMinutes`, `getLogCleanerIntervalSeconds`, `getMessageLogRetentionMs`, `getMessageLogSegmentFileSize`, `getMessageLogStorePath`, `getScheduleLogStorePath`, `getScheduleOffsetCheckpointPath`, `getSegmentScale`, `getSingleMessageLimitSize`, `isDeleteExpiredLogsEnable`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: DelayLogFacade (23 abstract methods) qmq-delay-server/src/main/java/qunar/tc/qmq/delay/DelayLogFacade.java:40 — `DelayLogFacade` declares 23 abstract methods: `appendDispatchLog`, `appendDispatchLogData`, `appendMessageLog`, `appendMessageLogData`, `appendScheduleLog`, `blockUntilReplayDone`, `getDispatchLogMaxOffset`, `getDispatchLogSyncMaxRequest`, `getDispatchLogs`, `getMessageLogMaxOffset`, `getMessageLogMinOffset`, `getMessageLogs`, `higherDispatchLogBaseOffset`, `higherScheduleBaseOffset`, `initialMessageIterateFrom`, `latestDispatchSegment`, `loadScheduleLogSegment`, `loadUnDispatch`, `lowerDispatchSegment`, `recoverLogRecord`, `shutdown`, `start`, `updateIterateOffset`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: Message (42 abstract methods) qmq-api/src/main/java/qunar/tc/qmq/Message.java:28 — `Message` declares 42 abstract methods: `ack`, `ack`, `addTag`, `autoAck`, `getAttrs`, `getBooleanProperty`, `getCreatedTime`, `getDateProperty`, `getDoubleProperty`, `getFloatProperty`, `getIntProperty`, `getLargeString`, `getLongProperty`, `getMaxRetryNum`, `getMessageId`, `getScheduleReceiveTime`, `getStringProperty`, `getSubject`, `getTags`, `isDurable`, `isSyncSend`, `localRetries`, `setDelayTime`, `setDelayTime`, `setDurable`, `setLargeString`, `setMaxRetryNum`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setProperty`, `setStoreAtFailed`, and 2 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 42 declarations carry 29 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 29 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.

IC1 · Incompleteness & stubs · Commented-out code · ×6

Commented-out code clients/csharp/qmqclient/Util/ClientId.cs:37 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code clients/csharp/qmqclient/Util/ClientId.cs:40 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code clients/csharp/qmqclient/Util/ClientId.cs:44 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code clients/csharp/qmqclient/Util/PortSelector.cs:11 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code clients/csharp/qmqclient/Util/PortSelector.cs:12 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code clients/csharp/qmqclient/Util/PortSelector.cs:13 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).

X7 · Silent fallback defaults · Silent fallback default in catch · ×6

Silent fallback default in catch clients/csharp/qmqclient/Pull/DefaultPullConsumer.cs:87 — `Pull` swallows every exception into `return new List<Message>();` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch clients/csharp/qmqclient/Util/BatchExecutor.cs:95 — `Take` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch qmq-delay-server/src/main/java/qunar/tc/qmq/delay/store/log/DispatchLogSegment.java:104 — `entries` swallows every exception into `return 0` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the Javadoc, and the row stops firing.
Silent fallback default in catch qmq-common/src/main/java/qunar/tc/qmq/base/BaseMessage.java:396 — `getMaxRetryNum` swallows every exception into `return -1` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the Javadoc, and the row stops firing.
Silent fallback default in catch qmq-common/src/main/java/qunar/tc/qmq/utils/PidUtil.java:28 — `getPid` swallows every exception into `return 0` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the Javadoc, and the row stops firing.
Silent fallback default in catch qmq-client/src/main/java/qunar/tc/qmq/consumer/pull/AckService.java:150 — `getOffset` swallows every exception into `return -1` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the Javadoc, and the row stops firing.

D21 · Naming Consistency · Inconsistent casing style for private fields · ×1

Inconsistent casing style for private fields: some use camelCase (messageId, IP, consumer) while others use PascalCase (Group). The codebase appears to mix conventions for private fields, with most following camelCase but specific fields like Group using PascalCase. — Standardize private field naming to camelCase (e.g., rename Group to group) to match the majority convention observed in messageId, IP, and consumer. (symbols: Field: private string Qunar.TC.Qmq.Client.Model.QueryRequest.messageId, Field: private string Qunar.TC.Qmq.Client.Exceptions.MessageException.messageId, Field: private string Qunar.TC.Qmq.Client.TimestampIdGenerator.IP, Field: private string Qunar.TC.Qmq.Client.Model.SubscribeRequest.consumer, Field: private string Qunar.TC.Qmq.Client.Model.SubscribeRequest.Group)

D21 · Naming Consistency · Inconsistent naming style for private fields within the same class (SocketChannel) · ×1

Inconsistent naming style for private fields within the same class (SocketChannel): some use camelCase (index, logger, reading), some use underscore prefix (_state, _tagType, _writtable), and some use ALL_CAPS (LOH, T8_0_IDEX). This indicates a lack of consistent internal naming convention for private members. — Adopt a single consistent style for private fields in SocketChannel, such as camelCase without prefix (index, logger) or underscore prefix (_index, _logger), and avoid ALL_CAPS unless they are constants. (symbols: Field: private int Qunar.TC.Qmq.Client.Transport.SocketChannel.index, Field: private int Qunar.TC.Qmq.Client.Transport.SocketChannel.logger, Field: private int Qunar.TC.Qmq.Client.Transport.SocketChannel.reading, Field: private int Qunar.TC.Qmq.Client.Transport.SocketChannel._state, Field: private int Qunar.TC.Qmq.Client.Transport.SocketChannel._tagType, Field: private int Qunar.TC.Qmq.Client.Transport.SocketChannel._writtable, Field: private int Qunar.TC.Qmq.Client.Transport.SocketChannel.LOH, Field: private int Qunar.TC.Qmq.Client.Transport.SocketChannel.T8_0_IDEX)

D21 · Naming Consistency · Inconsistent casing for what appears to be configuration or constant-like fields · ×1

Inconsistent casing for what appears to be configuration or constant-like fields: MAX_WEIGHT and LOH use ALL_CAPS, while MaxWeight uses PascalCase. If these are mutable fields, they should likely be camelCase; if constants, ALL_CAPS is consistent but MaxWeight is not. — If these are constants, rename MaxWeight to MAX_WEIGHT. If they are mutable fields, rename MAX_WEIGHT and LOH to camelCase (maxWeight, loh) to match MaxWeight's style (assuming MaxWeight is also a field, not a constant). (symbols: Field: private int Qunar.TC.Qmq.Client.NewQmq.WeightLoadBalance.MAX_WEIGHT, Field: private int Qunar.TC.Qmq.Client.Pull.WeightPullStrategy.MaxWeight, Field: Field: private int Qunar.TC.Qmq.Client.Transport.SocketChannel.LOH)

D24 · Comment Value · redundant comment · ×1

redundant comment clients/csharp/qmqclient/Codec/NewQmq/NewQmqDecoder.cs:26 — "go to magic code field" — delete - restates ReadInt64; the comment is a stub marker, not an explanation

D28 · Secrets (history) · Rotate the exposed credentials · ×1

REDACTED

D34 · Knowledge Freshness · Dormant codebase · ×1

Dormant codebase — 36 of 36 significant files have no living knowledge — the codebase as a whole is dormant, not 36 separate risks. Counted over 36 of the 133 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over. Re-engage owners or document before change.

D34 · Knowledge Freshness · Most significant orphaned file · ×1

Most significant orphaned file clients/csharp/qmqclient/Util/Crc32.cs:1 — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

M2 · Architecture documentation · No ADRs · ×1

No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

P1 · CI/CD gates · CI build step not evidenced · ×1

CI build step not evidenced — A CI pipeline exists but no build step was matched — changes may merge without the build ever running. A build step may be invoked directly as a command, or declared as a task that a runner named in the pipeline resolves.

P10 · Library API & versioning · Large public API surface · ×1

Large public API surface — 688/918 types (75%) declared in the published library are public. For a library, every public type is a stability contract — keep implementation types off the surface and expose only the intended API.

P3 · Security & performance tooling · No SAST · ×1

No SAST — No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 1239 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.

P6 · Release Hygiene · No changelog · ×1

No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

X2 · Cancellation propagation · Not all async methods take a CancellationToken · ×1

Not all async methods take a CancellationToken — Only 0/2 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

Dimension	Tool	Version	Command	Findings	Raw output
D28 · Secrets (history)	gitleaks	—	gitleaks detect --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-d0d2cd68742c4c91a34519aeb76873d4/history.json --exit-code 0 --source .	0	artifacts/raw/gitleaks-history.json
D28 · Secrets (history)	gitleaks	—	gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-d0d2cd68742c4c91a34519aeb76873d4/tree.json --exit-code 0 --source .	0	artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)	semgrep	—	semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/watchdog-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off .	12	artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilities	dotnet	—	dotnet list clients/csharp/qmqclient.sln package --vulnerable --include-transitive --format json	15	artifacts/raw/dotnet-vulnerable.json
D31 · IaC & Container Security	trivy	—	trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.	0	—
D32 · Data Compliance (PII/GDPR)	semgrep	—	semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.	0	—
D37 · Vulnerability-disclosure Policy	disclosure	—	disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.	0	—
D40 · Network Egress Confinement	runtime-hardening	—	runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.	0	—
D41 · Kernel & Syscall Confinement	runtime-hardening	—	runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.	0	—
D42 · Runtime Threat Enforcement	runtime-hardening	—	runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.	0	—
D43 · Malicious Dependencies	osv-scanner	—	osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm .	0	artifacts/raw/osv-scanner.json

Run 01a164b1-c19f-77cb-9263-0159f86d2fa4 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Findings by how serious they are

This survey was produced by

Executive summary

Top priorities

Diagnosis: what the measurements show together

Architecture — module dependency graph

Architecture: which parts of the code depend on which

At a glance — Code Health · 50% · Weak · gated by X1 ·

At a glance — Architecture · 82% · Strong ·

At a glance — Maturity · 49% · Weak · gated by D34, M2 ·

At a glance — Readiness · 35% · Weak · gated by P3, P8 ·

At a glance — Security · 61% · Adequate · gated by D30, D36 ·

At a glance — Event Sourcing · 100% · Exemplary ·

At a glance — Performance · 70% · Strong ·

Security & Compliance — OWASP Top-10 mapping

Roadmap

File quality

How the grades work

Methodology & how to trust this report

Tools & methods

Run transparency — what happened this run

Limitations & what we did not check

Per-dimension blind spots

The LLM boundary

Dimensions

Frontend & cross-cutting dimensions

Reference — by lens

Appendix A — Findings (grouped)

Appendix B — Reproduction & audit trail

Downloadable artifacts