{"$schema":"https://json.schemastore.org/sarif-2.1.0.json","version":"2.1.0","runs":[{"tool":{"driver":{"name":"codehealth","informationUri":"https://codehealth.canine.dev","rules":[{"id":"D1","name":"Cyclomatic Complexity","shortDescription":{"text":"Cyclomatic Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D1"},{"id":"D2","name":"Cognitive Complexity","shortDescription":{"text":"Cognitive Complexity"},"helpUri":"https://codehealth.canine.dev/dimensions/D2"},{"id":"D3","name":"God Classes","shortDescription":{"text":"God Classes"},"helpUri":"https://codehealth.canine.dev/dimensions/D3"},{"id":"D4","name":"Code Duplication","shortDescription":{"text":"Code Duplication"},"helpUri":"https://codehealth.canine.dev/dimensions/D4"},{"id":"D5","name":"Coupling","shortDescription":{"text":"Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D5"},{"id":"D6","name":"Cohesion (LCOM4)","shortDescription":{"text":"Cohesion (LCOM4)"},"helpUri":"https://codehealth.canine.dev/dimensions/D6"},{"id":"D9","name":"Test Distribution","shortDescription":{"text":"Test Distribution"},"helpUri":"https://codehealth.canine.dev/dimensions/D9"},{"id":"D10","name":"Test Quality","shortDescription":{"text":"Test Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D10"},{"id":"D12","name":"Dependency Hygiene","shortDescription":{"text":"Dependency Hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/D12"},{"id":"D13","name":"Secret Scanning","shortDescription":{"text":"Secret Scanning"},"helpUri":"https://codehealth.canine.dev/dimensions/D13","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"]}},{"id":"D14","name":"License Compliance","shortDescription":{"text":"License Compliance"},"helpUri":"https://codehealth.canine.dev/dimensions/D14"},{"id":"D15","name":"Churn \u00D7 Complexity Hotspots","shortDescription":{"text":"Churn \u00D7 Complexity Hotspots"},"helpUri":"https://codehealth.canine.dev/dimensions/D15"},{"id":"D16","name":"Bus Factor","shortDescription":{"text":"Bus Factor"},"helpUri":"https://codehealth.canine.dev/dimensions/D16"},{"id":"D17","name":"Explicit Debt","shortDescription":{"text":"Explicit Debt"},"helpUri":"https://codehealth.canine.dev/dimensions/D17"},{"id":"D18","name":"Solution Shape","shortDescription":{"text":"Solution Shape"},"helpUri":"https://codehealth.canine.dev/dimensions/D18"},{"id":"D21","name":"Naming Consistency","shortDescription":{"text":"Naming Consistency"},"helpUri":"https://codehealth.canine.dev/dimensions/D21"},{"id":"D22","name":"Internal API Consistency","shortDescription":{"text":"Internal API Consistency"},"helpUri":"https://codehealth.canine.dev/dimensions/D22"},{"id":"D23","name":"Boundary Type-Coupling","shortDescription":{"text":"Boundary Type-Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D23"},{"id":"D24","name":"Comment Value","shortDescription":{"text":"Comment Value"},"helpUri":"https://codehealth.canine.dev/dimensions/D24"},{"id":"D26","name":"Project Cohesion","shortDescription":{"text":"Project Cohesion"},"helpUri":"https://codehealth.canine.dev/dimensions/D26"},{"id":"D28","name":"Secrets (history)","shortDescription":{"text":"Secrets (history)"},"helpUri":"https://codehealth.canine.dev/dimensions/D28","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"]}},{"id":"D29","name":"Static Analysis (SAST)","shortDescription":{"text":"Static Analysis (SAST)"},"helpUri":"https://codehealth.canine.dev/dimensions/D29","relationships":[{"target":{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-89","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-94","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-77","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-79","CWE-89","CWE-78","CWE-94","CWE-77"]}},{"id":"D34","name":"Knowledge Freshness","shortDescription":{"text":"Knowledge Freshness"},"helpUri":"https://codehealth.canine.dev/dimensions/D34"},{"id":"D35","name":"Change Coupling","shortDescription":{"text":"Change Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D35"}]}},"results":[{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (19 lines \u00D7 2): src/Loyalty.Application.Storage.Dto/Validators/VenueLogoValidator.cs:17-35 | src/Loyalty.Application.Storage.Dto/Validators/VenueNewImageValidator.cs:17-35 \u2014 the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Application.Storage.Dto/Validators/VenueLogoValidator.cs"},"region":{"startLine":17}}}],"partialFingerprints":{"codehealthFindingId/v1":"441132b3056cb5358627df5e2f79a7d854c6110d6644755fd1e8e28a4089d179"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (13 lines \u00D7 3): src/Loyalty.Application.Storage.Dto/Validators/VenueImageValidator.cs:16-28 | src/Loyalty.Application.Storage.Dto/Validators/VenueLogoValidator.cs:16-34 | src/Loyalty.Application.Storage.Dto/Validators/VenueNewImageValidator.cs:16-34 \u2014 the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/Loyalty.Application.Storage.Dto/Validators/VenueImageValidator.cs:16\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Application.Storage.Dto/Validators/VenueImageValidator.cs"},"region":{"startLine":16}}}],"partialFingerprints":{"codehealthFindingId/v1":"3f67d68b722abc7bfe55377be1e7068a490651a2395e28f1d59214e22f28f1cf"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/LoyaltyProgram/Http/Write/Admin/VenueApprovePatchFunction.cs:41-51 | src/LoyaltyProgram/Http/Write/Admin/VenueRejectPatchFunction.cs:41-51 \u2014 the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/LoyaltyProgram/Http/Write/Admin/VenueApprovePatchFunction.cs:41\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/LoyaltyProgram/Http/Write/Admin/VenueApprovePatchFunction.cs"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"1a8bda0d42fce5ff3e4affb6cf9b9efaf1868226bd833454f422c1901a076d6d"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (11 lines \u00D7 2): src/Loyalty.Application.ViewModels/Validators/Venue/CreateVenueValidator.cs:12-22 | src/Loyalty.Application.ViewModels/Validators/Venue/UpdateVenueValidator.cs:14-24 \u2014 the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Application.ViewModels/Validators/Venue/CreateVenueValidator.cs"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"f63ff1ceb8871dde5886270e0990f622a9d3099745add8ba6ed205aac330bfca"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (9 lines \u00D7 2): src/LoyaltyProgram/Http/Write/VenueImages/VenueCreateImageFunction.cs:56-64 | src/LoyaltyProgram/Http/Write/VenueLogo/VenueCreateLogoFunction.cs:56-64 \u2014 the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach \u2014 a location they all depend on today, or a new shared one if there is none \u2014 and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/LoyaltyProgram/Http/Write/VenueImages/VenueCreateImageFunction.cs:56\u0060 it does not close everything it opens, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/LoyaltyProgram/Http/Write/VenueImages/VenueCreateImageFunction.cs"},"region":{"startLine":56}}}],"partialFingerprints":{"codehealthFindingId/v1":"ef9bca30381e96deee63866a9718d8ed8e1c9a48fcf79db3b568684898d6def2"}},{"ruleId":"D4","level":"warning","message":{"text":"Duplicated block (8 lines \u00D7 2): src/Loyalty.Application.ViewModels/Validators/Venue/CreateVenueValidator.cs:33-40 | src/Loyalty.Application.ViewModels/Validators/Venue/UpdateVenueValidator.cs:32-39 \u2014 the copies sit in sibling files of one directory: extract the block into a single shared function in that directory and call it from each site, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at \u0060src/Loyalty.Application.ViewModels/Validators/Venue/CreateVenueValidator.cs:33\u0060 it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand \u2014 widen the region to the smallest complete statement or declaration that contains it, and extract that."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Application.ViewModels/Validators/Venue/CreateVenueValidator.cs"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"bcac95a364e6b310d16bfba1f0f73948f6e0adba993ee52099c6ca1ad7cdf19e"}},{"ruleId":"D5","level":"warning","message":{"text":"Unstable project LoyaltyProgram: LoyaltyProgram has instability 1.00 with 0 dependents."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"d1a836bf00139a34b889a144bc0afe4f1a1443fa611b2cfe82ce4ad22cb8a679"}},{"ruleId":"D5","level":"warning","message":{"text":"Unstable project Loyalty.Infrastructure.IoC: Loyalty.Infrastructure.IoC has instability 0.92 with 1 dependents."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"0f1de5b5d405cf3d9c1810fab501696b9112108c7279beb358b9e9b4cb70cf55"}},{"ruleId":"D5","level":"warning","message":{"text":"Unstable project Loyalty.Infrastructure.Handlers.Commands: Loyalty.Infrastructure.Handlers.Commands has instability 0.86 with 1 dependents."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"8466d928fbaa813ba9f1c2cdae01b9b740e93660d9b66438f88f4ffbf9386fcf"}},{"ruleId":"D5","level":"warning","message":{"text":"Off the main sequence: Loyalty.Common.Shared: Loyalty.Common.Shared: abstractness 0.00, instability 0.00, distance 1.00 \u2014 the shape a shared-kernel / building-block library has BY DESIGN \u2014 concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"3780eb8b58de0bdfcd09182dcf1f59aeb8304c202cefae80bb153cb912a5f8a2"}},{"ruleId":"D5","level":"warning","message":{"text":"Off the main sequence: Loyalty.Domain.Handlers.Queries: Loyalty.Domain.Handlers.Queries: abstractness 0.00, instability 0.14, distance 0.86 \u2014 zone of pain \u2014 concrete and depended on by 6 project(s), so it\u0027s rigid to change."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"0a883cf018f3946f2ddfcd9587e9eb766900c0b8f0f4cbec66ab76372e5d985e"}},{"ruleId":"D5","level":"warning","message":{"text":"Off the main sequence: Loyalty.Domain.Handlers.Firebase.Queries: Loyalty.Domain.Handlers.Firebase.Queries: abstractness 0.00, instability 0.20, distance 0.80 \u2014 zone of pain \u2014 concrete and depended on by 4 project(s), so it\u0027s rigid to change."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"2d83a55a5c50f1b4d63384f97e228c69ae4c5f1680630f2c3b66da5cba34f8db"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: LoyaltyVenueAppService (LCOM4 10): LoyaltyVenueAppService\u0027s methods form 10 groups that share no state and don\u0027t call each other \u2014 a sign it may have several responsibilities. Review whether it splits into focused classes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Application.Venue/LoyaltyVenueAppService.cs"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"d979dd23b1dbff0ff66100236434a4df120a13cb4b491c8d4aa64b30250f31dc"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: WorkerAppService (LCOM4 7): WorkerAppService\u0027s methods form 7 groups that share no state and don\u0027t call each other \u2014 a sign it may have several responsibilities. Review whether it splits into focused classes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Application.Venue/WorkerAppService.cs"},"region":{"startLine":28}}}],"partialFingerprints":{"codehealthFindingId/v1":"c5b9c3fd13545d5de86f1428163103831b71e531c7b370964237c573f972b351"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: LoyaltyVenueImageAppService (LCOM4 5): LoyaltyVenueImageAppService\u0027s methods form 5 groups that share no state and don\u0027t call each other \u2014 a sign it may have several responsibilities. Review whether it splits into focused classes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Application.Venue/LoyaltyVenueImageAppService.cs"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"f19fbb7f56c3bd9d2ecf0dac0427164b4e3a3a0ed2da9dc5a1f9bfb17e0efba7"}},{"ruleId":"D6","level":"warning","message":{"text":"Low cohesion: Worker (LCOM4 4): Worker\u0027s methods form 4 groups that share no state and don\u0027t call each other \u2014 a sign it may have several responsibilities. Review whether it splits into focused classes."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Core.Entities/Aggregates/Workers/Worker.cs"},"region":{"startLine":12}}}],"partialFingerprints":{"codehealthFindingId/v1":"660b77c70821cff7c245fc3c629ce97c17c4652c86bdcb8ecff81acf0a01a26c"}},{"ruleId":"D10","level":"error","message":{"text":"No assertions (empty test): ShouldArchiveWorker: Test method has an empty body \u2014 it asserts nothing and exercises no code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"test/LoyaltyProgram.Tests/Tests/Venue/WorkerTests.cs"},"region":{"startLine":78}}}],"partialFingerprints":{"codehealthFindingId/v1":"29428564d8582eeae91c012cd051dde2fafdf8f6c27d21a084a27e80f7750be8"}},{"ruleId":"D10","level":"error","message":{"text":"No assertions (empty test): ShouldGetOnlyOwnVenues: Test method has an empty body \u2014 it asserts nothing and exercises no code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"test/LoyaltyProgram.Tests/Tests/Venue/VenueTests.cs"},"region":{"startLine":224}}}],"partialFingerprints":{"codehealthFindingId/v1":"a148d4d6d0e3a362b4cc8ee898fc89716ab644faf25b614053d6f45fb02eddaf"}},{"ruleId":"D10","level":"error","message":{"text":"No assertions (empty test): ShouldGetOnlyNotArchiveVenues: Test method has an empty body \u2014 it asserts nothing and exercises no code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"test/LoyaltyProgram.Tests/Tests/Venue/VenueTests.cs"},"region":{"startLine":229}}}],"partialFingerprints":{"codehealthFindingId/v1":"82d13bdf1db2791199dae055117797a2f7d9d7094e20043e761a677483c09878"}},{"ruleId":"D16","level":"warning","message":{"text":"single-maintainer \u2014 knowledge-concentration (bus factor) risk: single-maintainer \u2014 knowledge-concentration (bus factor) risk (1 author(s) across 594 commit(s) sampled)."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"b4b49d961df742f0e507f4cc5c8094fb077ba0391a27fd015d18320865187719"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: //todo: comment when scoped fixed \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Application.DomainEvents.Handlers/ProductGroup/ProductGroupArchivedDomainEventHandler.cs"},"region":{"startLine":32}}}],"partialFingerprints":{"codehealthFindingId/v1":"f60c3865d3e4cad65f2b5913776854b0128b87610cf1a10e5efd1a6dc68f2f9c"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: //todo: comment when scoped fixed \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Application.DomainEvents.Handlers/ProductGroup/ProductGroupChangedDomainEventHandler.cs"},"region":{"startLine":40}}}],"partialFingerprints":{"codehealthFindingId/v1":"8bdcdd5084b504216cf3abc444566da320e405d54676219dbd2feb79dbc520af"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: //todo: this should be tested \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Application.Venue/LoyaltyProductGroupAppService.cs"},"region":{"startLine":131}}}],"partialFingerprints":{"codehealthFindingId/v1":"57a0045c84b3a1601b6d4f48902ab0cc667c4e072c6e683c431c6d19d98e7a90"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: //todo: put in a common lib as a const. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Common.Shared/Extensions/ClaimsPrincipalExtensions.cs"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"505285ede357c374a6c5f4f8ec60da7613408bb1c7c494f93abd1003319d4761"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // todo: remove it when"},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Domain.Handlers.Firebase.Queries/Commands/User/SetupFirebaseTokenCommand.cs"},"region":{"startLine":13}}}],"partialFingerprints":{"codehealthFindingId/v1":"ec3e367fd34e09930124fdb41636c3178e12cd1978122fde99108257c71487b0"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: //todo: when named query filter appear: separate archive and tenant filters; \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Infrastructure.DataAccess/Context/LoyaltyTenantDbContext.cs"},"region":{"startLine":67}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b92a7184fe5dd45b891634cabdf64659b8b7458f6f31a113a5e30efb9433c36"}},{"ruleId":"D17","level":"warning","message":{"text":"CommentedOutCode: 8 consecutive commented-code lines"},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Infrastructure.DataAccess/Context/Scoped/ObjectStore.cs"},"region":{"startLine":33}}}],"partialFingerprints":{"codehealthFindingId/v1":"f48ac7a8a32619ed668f85b15466dad6dc1ad34c13c3a3e194b6dbe75c72c009"}},{"ruleId":"D18","level":"warning","message":{"text":"Monorepo: only 1 of 2 solutions was scored: This repository contains 2 .NET solutions, but a scan analyzes ONE. Every score, lens, and finding here reflects only \u0060src/LoyaltyProgram.sln\u0060 \u2014 the other 1 (\u0060common/Loyalty.Venue.Common.sln\u0060) were not analyzed and are not represented in the headline. To cover them, scan each solution as its own target and group them in a Solution or Product for a portfolio roll-up. If a secondary solution is an archived or vendored tree, declare it \u2014 \u0060.gitattributes\u0060 (\u0060path/** linguist-vendored\u0060) or \u0060.editorconfig\u0060 (\u0060[path/**] generated_code = true\u0060) \u2014 to exclude it from discovery the same way generated code is."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"a714c749a7ed0270f25ef54f0d77846abefb01ce5214d0fe8c64e4324d302faf"}},{"ruleId":"D18","level":"note","message":{"text":"Shell project: Loyalty.Domain.Handlers.Notifications: \u0060Loyalty.Domain.Handlers.Notifications\u0060 contributes only 0 significant line(s) \u2014 an empty/placeholder project is structural noise. Remove it or fold its contents into a real project."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Domain.Handlers.Notifications/Loyalty.Domain.Handlers.Notifications.csproj"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"d2aa629da074339eedb37eb4a7196d3befa65a5490c6e61f120d86928c9174b6"}},{"ruleId":"D18","level":"note","message":{"text":"Thin analysable surface across projects: 1 project(s) carry only a thin slice of real code (e.g. \u0060Loyalty.Core.Contracts\u0060 with 25 significant line(s)). The mean analysable-surface weight is 94 %, lowering Solution Shape by about 0.5 point(s). Consolidate thin projects or grow them into substantial, well-scoped assemblies."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"dd0b92fd965c2065080f16843920964ee00f7696ea03d87cdf61aed4cd2c746a"}},{"ruleId":"D22","level":"warning","message":{"text":"Redundant/Overlapping Types: CommandNotificationResult appears to be a wrapper around CommandResult (it has a CommandResult property) but also duplicates the Success, Message, and Result properties directly. This creates confusion about whether consumers should use CommandResult or CommandNotificationResult, and why both exist.: Remove the redundant properties (Success, Message, Result) from CommandNotificationResult and rely on the CommandResult property, or merge the two types if they serve the same purpose. (signatures: Loyalty.Domain.Contracts.CommandResult | Loyalty.Domain.Contracts.CommandNotificationResult)"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"3263f3a5d3af941631050284563e8bc57d2b3b81fde770cbbd334bc4a424af3c"}},{"ruleId":"D22","level":"warning","message":{"text":"Inconsistent Naming and Structure: ICommandNotificationResult is an interface that duplicates the structure of CommandResult but with different naming conventions (e.g., OnSuccessNotifications, OnFailNotifications). This suggests a lack of clear distinction between the result of a command and the notification of its outcome.: Align the interface and class structures. If ICommandNotificationResult is meant to handle notifications, it should not duplicate the success/message/result pattern of CommandResult. Consider using a single type or clearly separating \u0027result\u0027 from \u0027notification\u0027 concerns. (signatures: Loyalty.Domain.Contracts.CommandResult | Loyalty.Domain.Contracts.Interfaces.ICommandNotificationResult)"},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"2b3215a525973df41019d57fc65cefc3f7a05739ddc805c6dc2b713a775220de"}},{"ruleId":"D23","level":"note","message":{"text":"Bounded contexts not declared: At 17617 LoC spread over 26 projects the codebase is large and multi-module, so explicit bounded contexts are needed. Name this codebase\u0027s bounded contexts (\u22652 module groups, e.g. per subsystem) so cross-boundary type coupling can be assessed. Declare them in \u0060.codehealth/config.yaml\u0060 at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it \u2014 e.g. \u0060architecture:\u0060 \u2192 \u0060contexts:\u0060 \u2192 \u0060Billing: [\u0022src/billing\u0022, \u0022Acme.Billing\u0022]\u0060, \u0060Catalog: [\u0022src/catalog\u0022, \u0022Acme.Catalog\u0022]\u0060."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"1c7e276c9c682731f01819ed5378b90ca320cde1b583c90920172911598362b3"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022public constructor available to developer to create a new book\u0022 \u2014 trim - \u0027available to developer\u0027 restates the ctor\u0027s accessibility"},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Core.Entities/Aggregates/Products/Product.cs"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"d65026131f743163dcc5a564ff707383057a8539e0ea5630bbcb2339ef424985"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022var context = ObjectDictionary[hashCode];\u0022 \u2014 delete - the lookup is self-evident"},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Infrastructure.DataAccess/Context/Scoped/ObjectStore.cs"},"region":{"startLine":37}}}],"partialFingerprints":{"codehealthFindingId/v1":"98c6f816269208095701412cdf660ab19fe08e95a381434754baf2a26481db78"}},{"ruleId":"D35","level":"error","message":{"text":"Boundary-crossing change coupling: WorkerAppService.cs \u2194 GetVerificationLinkQueryHandler.cs: \u0060src/Loyalty.Application.Venue/WorkerAppService.cs\u0060 (context Loyalty.Application.Venue) and \u0060src/Loyalty.Infrastructure.Firebase.Handlers/Queries/GetVerificationLinkQueryHandler.cs\u0060 (context Loyalty.Infrastructure.Firebase.Handlers) sit in DIFFERENT parts of the tree yet change together 50% of the time (7 of the 14 commits that touched the less-changed of the two, renames followed) \u2014 the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can\u0027t see."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"src/Loyalty.Application.Venue/WorkerAppService.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"974b3d333f2799b3d3d11ad0b3aaf2c9ce1b58d3da634424a4450bd5668bdf76"}}],"taxonomies":[{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d","organization":"MITRE","informationUri":"https://cwe.mitre.org/","isComprehensive":false,"shortDescription":{"text":"The MITRE Common Weakness Enumeration (CWE)."},"taxa":[{"id":"CWE-259","guid":"ae9ad959-fbb6-9d5e-892d-3dca66da0b69","name":"Use of Hard-coded Password","shortDescription":{"text":"Use of Hard-coded Password"},"helpUri":"https://cwe.mitre.org/data/definitions/259.html"},{"id":"CWE-77","guid":"332c8ade-6612-9f56-a06b-d8d90b1a8750","name":"Command Injection","shortDescription":{"text":"Command Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/77.html"},{"id":"CWE-78","guid":"2e31ceaf-c7ae-2e5e-9661-cfb1362789cf","name":"OS Command Injection","shortDescription":{"text":"OS Command Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/78.html"},{"id":"CWE-79","guid":"fd45580b-e8c4-fc5e-8c2f-aa8fab0b4dbf","name":"Cross-site Scripting (XSS)","shortDescription":{"text":"Cross-site Scripting (XSS)"},"helpUri":"https://cwe.mitre.org/data/definitions/79.html"},{"id":"CWE-798","guid":"5e8f057d-fee3-995a-a0cb-9fc5b0d174d1","name":"Use of Hard-coded Credentials","shortDescription":{"text":"Use of Hard-coded Credentials"},"helpUri":"https://cwe.mitre.org/data/definitions/798.html"},{"id":"CWE-89","guid":"6d08fdad-37eb-c150-bbf0-d7d946863407","name":"SQL Injection","shortDescription":{"text":"SQL Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/89.html"},{"id":"CWE-94","guid":"75e7f50c-6c2f-dd52-bf40-bf6c52b861fd","name":"Code Injection","shortDescription":{"text":"Code Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/94.html"}]}],"properties":{"codehealthPublication":{"public":true,"notice":"This is the PUBLIC form of this artifact. Findings are listed in full, but the details of SECURITY findings \u2014 which rule fired, in which file, on which line, and how to fix it \u2014 are deliberately withheld, and any secret-scanner results are excluded entirely. Where detail is absent here it was REMOVED FOR PUBLICATION; it is not missing from the analysis. The complete artifact is available from the repository owner.","securityFindingsRedacted":0,"secretScannerRunsExcluded":0}}}]}