spring-projects/spring-data-commons

Executive summary

spring-projects/spring-data-commons scores 55 out of 100 and is rated Adequate, while five of its seven lenses score higher still: Domain Modelling at 100, rated Exemplary, Code Health at 86 and Performance at 78, both rated Strong, and Architecture at 75 and Production Readiness at 63, both rated Adequate.

The score is lower than those five because the weakest lens counts most, and here that is Maturity, which scores 46 and is rated Weak. Its Architecture documentation dimension scores 0 out of 10, and until that reaches 4, Maturity can't be rated higher than Adequate. The first actions are to record your significant design decisions and to improve Documentation Quality — currently 5.0/10, and if Maturity rose to 70, the score would rise from 55 to about 61.

28 findings are critical: 27 in Static Analysis (SAST) and one in Knowledge Freshness.

Watchdog couldn't measure 15 dimensions in this code, among them Code Coverage, Test Reliability and Dependency Hygiene, so they are left out of the score. The product code is 79,598 lines, which would take an estimated 1.0 person-years, around €140,000, to rebuild.

Code Health 86 Strong Architecture 75 Adequate, capped by Project Cohesion Maturity 46 Weak, capped by Architecture documentation Production Readiness 63 Adequate Security and Compliance 51 Adequate, capped by Static Analysis (SAST) and Supply-chain Provenance & Signing Domain Modelling 100 ★ Exemplary Performance 78 Strong

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.

Maturity 46 · counts for 46%Security and Compliance 51 · counts for 25%Production Readiness 63 · counts for 14%Architecture 75 · counts for 8%Performance 78 · counts for 4%Code Health 86 · counts for 2%Domain Modelling 100 · counts for 1%

If Maturity rose from 46 to 70, the lowest score rated Strong, the score would rise from 55 to about 61.

Code composition: what the lines of code are

Product code 63%Tests 37%

New since the last survey: 2 findings

These 2 critical or serious findings weren't in the previous survey, on 8 October 2026.

Explicit Debt · TodoComment src/main/java/org/springframework/data/core/PropertyPathUtil.java
Change Coupling · Change coupling: CrudRepository.java ↔ ReactiveCrudRepository.java src/main/java/org/springframework/data/repository/CrudRepository.java

Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Rebuild cost: about €140,000 · Estimate

Cost to rebuild	€48,000 to €240,000, for 799 to 2,535 hours of work, about 1.0 person-years for 1 to 2 engineers
Difficulty of the problem	Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor	×0.8 at a score of 55. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size	Medium: 79,598 lines of product code

How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

Record your significant design decisions.

Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.

Raises the score by about 7 points · Medium effort · Architecture documentation

Improve Documentation Quality — currently 5.0/10.

Raises the score by about 6 points · Medium effort · Documentation Quality

Resolve the 1 Orphaned knowledge finding(s) in Knowledge Freshness — start with CustomCollections.java.

Raises the score by about 3 points · Low effort · Knowledge Freshness

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk

This code would cost about €140,000 to build again, about 1.0 person-years of work. Its weakest lens is Maturity, at 46 (Weak). Maturity is about how well the project explains and looks after itself, which decides whether a new developer, or a new supplier, can take over. Because the weakest lens counts most in the score, work on Maturity also moves the score most.

Based on: the rebuild estimate · the Maturity grade · how much each lens counts

What to do: Start with the Maturity actions in Top priorities.

If you do one thing first · First action

Record your significant design decisions. Of all the actions in this report, it raises the score most for the work it takes: about 7 points for medium effort. The next survey will show the change in the score.

Based on: the ranked actions in Top priorities, by score gain and effort

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

50 modules, with 127 dependencies between them. 2 loops run through 5 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 10 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →	4 util	5 core	6 spel.spi	7 domain	8 mapping	10 spel	12 expression	13 geo	14 history	15 repository	16 support	18 mapping.model	22 mapping.context	23 aot	26 projection	27 repository.core.support	28 web	29 repository.core	30 repository.query	31 repository.config	33 repository.support	34 querydsl	35 repository.aot.generate	38 querydsl.binding	39 web.querydsl
1 annotation
2 auditing.config
3 config
4 util
5 core	4
6 spel.spi	1
7 domain	6	3
8 mapping	3	6
9 repository.util		2
10 spel	2		12
11 domain.jaxb				5
12 expression						5
13 geo				3
14 history	2			2
15 repository				4
16 support				13
17 geo.format								3
18 mapping.model	4	8		1	89	6	4				2
19 repository.history				2					2	1
20 repository.kotlin										2
21 repository.reactive				2						4
22 mapping.context	3	13		1	22	1						9
23 aot	11	1		2	3							8	1
24 auditing	2			3	7								12
25 convert	1	8			22							5	4
26 projection	3	8			2								1
27 repository.core.support	8	3			4	2	1			2			1		4			46	18
28 web		2		21											4
29 repository.core		2														2
30 repository.query	5	7	1	36	1	5	16								6			6
31 repository.config	16									2			2	6		6		10	1				2
32 repository.query.parser	3	1		6															1
33 repository.support	2			8	2					2						3		9	2
34 querydsl				12															2		1
35 repository.aot.generate	1	2													2	2		4	8	1
36 repository.cdi	1					1										5		1	1	6
37 repository.init																					4
38 querydsl.binding		5																			1	5
39 web.querydsl		1																						5
40 web.config	2			1				2									14					2		2	2

Uses a module listed above itPart of a loopThe module itself

At a glance — Code Health · 86% · Strong ·

The Good

D1 · .NET / C# Cyclomatic Complexity 8.6 D2 · .NET / C# Cognitive Complexity 7.4 D3 · .NET / C# God Classes 9.6 D4 · .NET / C# Code Duplication 9.6 D17 · .NET / C# Explicit Debt 10.0 IC1 · Repo Incompleteness & stubs 10.0 X1 · Repo Async correctness 10.0 X12 · Repo Unreachable branch 10.0 X13 · Repo Undrained process stream 10.0 X16 · Repo Unfloored truncation loop 10.0 X18 · Repo Disposal-pattern correctness 10.0 X19 · Repo Unrestored process-global state 10.0 X20 · Repo Mistyped argument guard 10.0 X21 · Repo Side-effecting pattern guard 10.0 X22 · Repo Contradicted release guard 10.0 X23 · Repo Unguarded diagnostic materialisation 10.0 X25 · Repo Inert configuration knob 10.0 X26 · Repo Unsynchronised callback handoff 10.0 X27 · Repo Collection changed while being enumerated 10.0 X28 · Repo Index access outside its own emptiness guard 10.0 X29 · Repo Per-element action decided by a fixed element 10.0 X3 · Repo Exception handling 7.2 X30 · Repo Support guard that admits what it rejects 10.0 X4 · Repo Structured logging 10.0 X5 · Repo Nullable reference types 8.4

At a glance — Architecture · 75% · Adequate · gated by D26 ·

The Good

D6 · .NET / C# Cohesion (LCOM4) 9.8 D35 · .NET / C# Change Coupling 9.9 AX1 · Repo Captive dependencies 10.0 AX2 · Repo Stateful singletons 10.0 AX3 · Repo Project dependency cycles 10.0 AX4 · Repo Dependency direction 10.0 AX6 · Repo Interface segregation 9.9

The Ugly

D26 · .NET / C# Project Cohesion 0.0 AX10 · Repo Code composition 4.0

At a glance — Maturity · 46% · Weak · gated by M2 ·

The Good

D15 · .NET / C# Churn × Complexity Hotspots 10.0 D16 · .NET / C# Bus Factor 9.6 D21 · .NET / C# Naming Consistency 10.0 D34 · .NET / C# Knowledge Freshness 7.3 M3 · Repo Folder & project structure 10.0 M4 · Repo Documentation accuracy 10.0

The Bad

D19 · .NET / C# Documentation Quality 5.0

The Ugly

M1 · Repo Documentation (README) 4.5 M2 · Repo Architecture documentation 0.0

At a glance — Readiness · 63% · Adequate ·

The Good

D9 · .NET / C# Test Distribution 10.0 D10 · .NET / C# Test Quality 7.3 D13 · .NET / C# Secret Scanning 10.0 D14 · .NET / C# License Compliance 10.0 P1 · Repo CI/CD gates 10.0

The Bad

P3 · Repo Security & performance tooling 5.0 P4 · Repo Deployment & Rollback 5.0 P6 · Repo Release Hygiene 5.0

At a glance — Security · 51% · Adequate · gated by D29, D36 ·

The Good

D28 · .NET / C# Secrets (history) 10.0 D44 · .NET / C# Platform End-of-Life 10.0 X14 · Repo Bypassable address classification 10.0 X15 · Repo Unvalidated length from an untrusted reader 10.0 X17 · Repo Uncapped recursion over a caller-supplied document 10.0 X24 · Repo Document value interpolated into markup unescaped 10.0

The Ugly

D29 · .NET / C# Static Analysis (SAST) 0.5 D36 · .NET / C# Supply-chain Provenance & Signing 0.0

At a glance — Domain Modelling · 100% · Exemplary ·

The Good

DM10 · Repo One transaction, one aggregate 10.0 DM12 · Repo Ambient inputs in the domain 10.0 DM6 · Repo Domain ↔ infrastructure boundary 10.0 DM8 · Repo Value-object opportunities 10.0 DM9 · Repo Scattered domain decisions 10.0

At a glance — Performance · 78% · Strong ·

The Good

PF1 · Repo Benchmark discipline 8.5 PF3 · Repo Async & latency hygiene 10.0

The Bad

PF2 · Repo Allocation hygiene 6.1

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP category	Findings	Severity
A05:2025 — Injection	27	High / Critical
A03:2025 — Software Supply Chain Failures	5	Medium

Roadmap

Begin by documenting significant design decisions in a dedicated folder and completing the truncated root README with a clear quick-start section to improve onboarding. Next, address the 112 orphaned files to ensure codebase freshness, prioritizing key components like QuerydslBindings. Finally, resolve the ten security findings in the CI workflows to strengthen static analysis and pipeline integrity.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do this	Helps	Effort	Dimension
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.	+7.1 pts	Medium	Architecture documentation
Improve Documentation Quality — currently 5.0/10.	+6.4 pts	Medium	Documentation Quality
Resolve the 1 Orphaned knowledge finding(s) in Knowledge Freshness — start with CustomCollections.java.	+2.7 pts	Low	Knowledge Freshness
Add a build/run (quick start) section to the root README — the first thing a newcomer needs.	+4.7 pts	Medium	Documentation (README)
Resolve the 6 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED, REDACTED.	+2.1 pts	Low	Static Analysis (SAST)
Resolve the 10 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (5), REDACTED (5).	+3.3 pts	Medium	Static Analysis (SAST)
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing.	+1.3 pts	Low	Supply-chain Provenance & Signing
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing.	+1.3 pts	Low	Supply-chain Provenance & Signing

File quality

Per-file score 0–10 — a quality signature. Of 214 files carrying findings, judged against the Production bar: 0% slop · 57% mixed · 43% near-clean.

File	Score	Band	Worst signal
REDACTED	4.4	Mixed	Static Analysis (SAST): High: REDACTED
REDACTED	4.4	Mixed	Static Analysis (SAST): High: REDACTED
REDACTED	5.1	Mixed	Static Analysis (SAST): High: REDACTED
src/main/java/org/springframework/data/convert/CustomConversions.java	5.5	Mixed	Cognitive Complexity: CustomConversions.isSupportedConverter (cognitive 19)
src/main/java/org/springframework/data/repository/aot/generate/AotRepositoryCreator.java	6.0	Mixed	Explicit Debt: TodoComment
src/main/java/org/springframework/data/core/SerializableLambdaReader.java	6.0	Mixed	Explicit Debt: TodoComment
src/test/java/org/springframework/data/core/TypeDiscovererUnitTests.java	6.0	Mixed	Explicit Debt: TodoComment
src/test/java/org/springframework/data/mapping/model/ClassGeneratingEntityInstantiatorUnitTests.java	6.0	Mixed	Explicit Debt: HackComment
src/test/java/org/springframework/data/mapping/model/ReflectionEntityInstantiatorUnitTests.java	6.0	Mixed	Explicit Debt: HackComment
src/test/java/org/springframework/data/repository/aot/RepositoryRegistrationAotProcessorIntegrationTests.java	6.0	Mixed	Explicit Debt: TodoComment
src/main/java/org/springframework/data/projection/EntityProjectionIntrospector.java	6.7	Mixed	Explicit Debt: TodoComment
src/test/java/org/springframework/data/convert/PropertyValueConverterFactoryUnitTests.java	6.7	Mixed	Explicit Debt: TodoComment
src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java	7.0	Mixed	God Classes: TooManyMethods: JSONArray
src/main/java/org/springframework/data/spel/spi/ParameterTypes.java	7.0	Mixed	Code Duplication: Duplicated block (19 lines × 2)
src/main/java/org/springframework/data/web/SortHandlerMethodArgumentResolverSupport.java	7.0	Mixed	Code Duplication: Duplicated block (10 lines × 2)
src/test/java/org/springframework/data/mapping/model/AnnotationBasedPersistentPropertyUnitTests.java	7.0	Mixed	Test Quality: No assertions: discoversAnnotationOnField
src/test/java/org/springframework/data/repository/core/support/DefaultCrudMethodsUnitTests.java	7.0	Mixed	Test Quality: No assertions: detectsCustomSaveMethod
src/test/java/org/springframework/data/repository/query/parser/PartTreeUnitTests.java	7.0	Mixed	Test Quality: No assertions: buildsPartTreeForNotContainingCorrectly
src/test/java/org/springframework/data/repository/query/QueryMethodUnitTests.java	7.0	Mixed	Test Quality: No assertions: acceptsScrollAndSortMaybe
src/test/java/org/springframework/data/repository/support/ReflectionRepositoryInvokerUnitTests.java	7.0	Mixed	Test Quality: No assertions: considersFormattingAnnotationsOnQueryMethodParameters

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 28

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 572

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 151

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 16

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 63 of 67 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 4 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.8 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 67 dimensions across the health lenses

D1D2D3D4D6D9D10D13D14D15D16D17D19D21D26D28D29D34D35D36D44AX1AX10AX2AX3AX4AX6DM10DM12DM6DM8DM9IC1M1M2M3M4P1P3P4P6PF1PF2PF3X1X12X13X14X15X16X17X18X19X20X21X22X23X24X25X26X27X28X29X3X30X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions

Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 736 of 751 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

Method	Backs	Version	Evaluator
Roslyn static analysis	Complexity, cohesion, coupling, dead code, API surface, layering	5.3.0	✓ deterministic
Native secret scanner	Hardcoded secrets / credentials	1.0.0	✓ deterministic
Watchdog duplication detector (in-process)	Code duplication	1.0.0	✓ deterministic
Coverage (coverlet / dotnet-coverage)	Line & branch coverage	10.0.400	✓ deterministic
NuGet / dotnet	Outdated, vulnerable & deprecated dependencies	10.0.400	✓ deterministic
git / LibGit2Sharp	Churn hotspots, knowledge concentration, history	2.43.0 · 0.31.0	✓ deterministic
gitleaks · semgrep · trivy	Secrets in history, SAST, CVEs, IaC & container, PII / GDPR	1.86.0 · 0.69.3	✓ deterministic
LLM (sampled · advisory)	Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurement	Local LLM	◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 01a164d0-9d52-7127-bd1a-19b300a2ef4e.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

D8 Code Coverage — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.java, .kt) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo. To have real coverage read, produce a coverage report in a standard format (JaCoCo XML — `mvn jacoco:report`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures. You can widen what we reach: optional: produce a coverage report in a standard format (JaCoCo XML — `mvn jacoco:report`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures — then the real number is read on the next scan.
D10 Test Quality — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 2,415 test(s) behind this row are the ones the code-model census could read, and this repository also carries at least 38 test source file(s) (.kt) that it cannot: it reads the test types the .java frontend declared, so a suite in any other language is invisible to it. Skipped tests, zero-assertion tests and the other quality signals on this row are UNMEASURED in that suite — their absence from the counts above is a gap in this analyzer's language coverage, not a finding that those tests are sound.
D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.java, .kt) and this repository declares a JVM test suite (repository root, Maven), but it was not re-run: the analyzer environment could not run it. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
D12 Dependency Hygiene — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This repository's dependency manifests WERE read and their pinning discipline assessed; what went unanswered is the currency half, because repo.spring.io — the registry that answers it — was asked and did not reply (the build stopped because repo.spring.io, a repository this project declares, refused it with HTTP 403 — what this scan's egress allowlist returns for a host that is not on it, so the dependency graph was not resolved). This is OUR side and it is an ENVIRONMENT fault, not a missing collector: the collector exists and ran. An HTTP 403 here is what this scan's egress allowlist returns for a host that is not on it, so the remedy is to add repo.spring.io to the allowlist and re-run — not to build anything.
D20 ADR Quality — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. The ADR expectation is gated on whether a repository ships a deployable product. Our repo-kind classifier reads .NET project files and the host and package markers of the other ecosystems it knows (a Go `package main`, a Cargo binary, a package.json `bin`, `start` script or application dev server such as Vite or Next, Python console scripts or a Django/WSGI entry point, a Spring Boot / WAR / Gradle application build, a Rack or Rails app, a Composer project, an OTP release or escript, a Dockerfile, a Procfile, a Platform.sh `.platform/routes.yaml`, and the corresponding published-package manifests, including an OTP `*.app.src`, a Drupal module's `*.info` and a Claude Code `.claude-plugin/plugin.json`), and found none here, so we could not tell what kind of repository this is and did not assess its ADR log. This is a gap in our analyzer, not a finding about this repository.
D22 Internal API Consistency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is an ADMISSION gap, not an environment fault: no published-package marker D22 reads admitted any project here. D22 DOES collect the public API of every language in this tree, and admits a project only when its manifest makes that ecosystem's publication act in a form the marker recognises — so what is missing is not a collector but an admission rule for the publication act this repository makes, if it makes one. The remedy is a better discriminator for that marker — not a collector, and no change to the scan image can close it. The marker's rules are measured to refuse applications, so one refused repository is the rule working as calibrated; several are the evidence that it is too strict.
D27 Navigability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Navigability is taken over call sites whose callee resolved. For C# that population includes calls into referenced assemblies; for this language only calls declared inside the repository count, so the abstention threshold reads the repository's use of its standard library as a resolution failure. That is a limit of this analyzer, not a build problem in this repository.
D30 Dependency Vulnerabilities — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Osv: osv-scanner exited 127 with no findings — dependency CVEs were not measured. 'osv-scanner' exited 127 and produced no findings, and that exit code has no documented repo-side meaning — so this run measured nothing, and nothing here is a statement about the repository.
D43 Malicious Dependencies — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Osv: osv-scanner exited 127 with no findings — dependency CVEs were not measured. 'osv-scanner' exited 127 and produced no findings, and that exit code has no documented repo-side meaning — so this run measured nothing, and nothing here is a statement about the repository.
C1 Data Protection — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These personal data controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks personal data controls.
C2 Access Controls — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
C3 Audit Trail — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These audit controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks audit controls.
C4 Data Retention — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These retention controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks retention controls.
C5 Data-Subject Rights — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These data-subject rights controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks data-subject rights controls.
DM9 Scattered domain decisions — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Arm one resolves each comparison operand to the domain member it judges, and that binding exists only in a Roslyn compilation, which this run did not load. Arm two ran over the neutral model because this repository's frontend declares whether each construction is produced or passed. A rule decided in two places would not appear above.
DM9 Scattered domain decisions — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The frontend declares that it computes whether a construction is produced or passed, yet 7 of 1488 constructions arrived without the answer. Arm two skipped them; it did not clear them.
GD1 Unfinished & placeholder code — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and no C#, F#, JavaScript/TypeScript, Dart, Ruby or Scala was found, and this repository's Java, Kotlin is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
S1 Web-Security Posture — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
DM6 Domain ↔ infrastructure boundary: Infrastructure reached through a hand-rolled wrapper, a domain-named facade, reflection, or a string-keyed service locator resolves to a non-infra type and isn't seen; the body scan is symbol resolution over syntax, not full dataflow. A clean result means "no resolved infra reference in a domain body", not a proof of purity.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

The LLM boundary

LLM-set scores this run (4): D19, D21, D26, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.

Dimensions

D1 · Cyclomatic Complexity8.6 / 10Strong✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.6 / 10 · rule-coverage 100% · ceiling Prevented

7 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was BytecodeUtil.autoboxIfNeeded at 33.

BytecodeUtil.autoboxIfNeeded (cyclomatic 33)src/main/java/org/springframework/data/mapping/model/BytecodeUtil.java:87

AotRepositoryCreator.contributeMethod (cyclomatic 24)src/main/java/org/springframework/data/repository/aot/generate/AotRepositoryCreator.java:250

ResultProcessor.processResult (cyclomatic 18)src/main/java/org/springframework/data/repository/query/ResultProcessor.java:140

InputMessageProjecting.invoke (cyclomatic 18)src/main/java/org/springframework/data/web/JsonProjectingMethodInterceptorFactory.java:137

ObjectInstantiatorClassGenerator.insertUnboxInsns (cyclomatic 17)src/main/java/org/springframework/data/mapping/model/ClassGeneratingEntityInstantiator.java:614

+ 2 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

Bring the 7 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with BytecodeUtil.autoboxIfNeeded (cyclomatic 33), AotRepositoryCreator.contributeMethod (cyclomatic 24), ResultProcessor.processResult (cyclomatic 18). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 7 together lifts Cyclomatic Complexity from 8.6 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D2 · Cognitive Complexity7.4 / 10Strong✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 7.4 / 10 · rule-coverage 100% · ceiling Prevented

21 method(s) exceeded the cognitive complexity threshold of 15; the worst was AotRepositoryCreator.contributeMethod at 36.

AotRepositoryCreator.contributeMethod (cognitive 36)src/main/java/org/springframework/data/repository/aot/generate/AotRepositoryCreator.java:250

BytecodeUtil.autoboxIfNeeded (cognitive 32)src/main/java/org/springframework/data/mapping/model/BytecodeUtil.java:87

InputMessageProjecting.invoke (cognitive 26)src/main/java/org/springframework/data/web/JsonProjectingMethodInterceptorFactory.java:137

DefaultValueExpressionParser.findPlaceholderEndIndex (cognitive 24)src/main/java/org/springframework/data/expression/DefaultValueExpressionParser.java:140

InstanceCreatorMetadataDiscoverer.discover (cognitive 24)src/main/java/org/springframework/data/mapping/model/InstanceCreatorMetadataDiscoverer.java:62

+ 16 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

Bring the 21 bodies over 15 down to 15 or less in Cognitive Complexity — start with AotRepositoryCreator.contributeMethod (cognitive 36), BytecodeUtil.autoboxIfNeeded (cognitive 32), InputMessageProjecting.invoke (cognitive 26). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 21 together lifts Cognitive Complexity from 7.4 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D3 · God Classes9.6 / 10Stronggated by 9 serious findings✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.6 / 10 · rule-coverage 100% · ceiling Prevented

9 god class(es) detected.

TooManyMethods: BasicPersistentEntity · ×7src/main/java/org/springframework/data/mapping/model/BasicPersistentEntity.java:67

ClassTooLong: ClassGeneratingPropertyAccessorFactorysrc/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:77

FileTooLong: model/ClassGeneratingPropertyAccessorFactory.javasrc/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java

What to do

Resolve the 7 TooManyMethods finding(s) in God Classes — start with BasicPersistentEntity.java, JSONObject.java, JSONArray.java. — One of this dimension's main actionable groups (7 warning-level).
Resolve the 1 ClassTooLong finding(s) in God Classes — start with ClassGeneratingPropertyAccessorFactory.java. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 FileTooLong finding(s) in God Classes — start with ClassGeneratingPropertyAccessorFactory.java. — One of this dimension's main actionable groups (1 warning-level).
Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D4 · Code Duplication9.6 / 10Stronggated by 70 serious findings✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.6 / 10 · rule-coverage 100% · ceiling Verified

70 duplicated block group(s) detected.

Duplicated block (8 lines × 2) · ×13src/main/java/org/springframework/data/geo/GeoJacksonModule.java:46

Duplicated block (5 lines × 2) · ×8src/main/java/org/springframework/data/core/PropertyReferenceException.java:151

Duplicated block (11 lines × 2) · ×7src/main/java/org/springframework/data/querydsl/binding/PropertyPathInformation.java:136

Duplicated block (10 lines × 2) · ×7src/main/java/org/springframework/data/mapping/callback/DefaultEntityCallbacks.java:69

Duplicated block (12 lines × 2) · ×6src/main/java/org/springframework/data/mapping/model/ClassGeneratingEntityInstantiator.java:429

+ 15 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

Resolve the 13 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with JSONArray.java (7), GeoJacksonModule.java, CdiRepositoryBean.java. — One of this dimension's main actionable groups (13 warning-level).
Resolve the 8 Duplicated block (5 lines × 2) finding(s) in Code Duplication — start with JSONArray.java (5), PropertyReferenceException.java, InstanceCreatorMetadataDiscoverer.java. — One of this dimension's main actionable groups (8 warning-level).
Resolve the 7 Duplicated block (11 lines × 2) finding(s) in Code Duplication — start with PropertyPathInformation.java, RepositoryMethodInvoker.java, ParameterTypes.java. — One of this dimension's main actionable groups (7 warning-level).
Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D6 · Cohesion (LCOM4)9.8 / 10Stronggated by 4 serious findings✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Verified

4 of 238 classes have LCOM4 above 3.

Low cohesion: CustomConversions (LCOM4 8) · ×4src/main/java/org/springframework/data/convert/CustomConversions.java:71

What to do

Resolve the 4 Low cohesion finding(s) in Cohesion (LCOM4) — start with CustomConversions.java, SortHandlerMethodArgumentResolverSupport.java, Sort.java. — One of this dimension's main actionable groups (4 warning-level).
Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.

Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

2415 test methods: 2415 unit, 0 integration, 0 BDD, 0 e2e.

✓ On the Gold path — maintain.

Detailed fixes: d9_recommendation.md.

Do you agree with this assessment?

D10 · Test Quality7.3 / 10Strong✓ Tool-verified

What it measures: Whether the tests truly assert behaviour rather than just running the code.

Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.

Maturity: Documented → Verified → Prevented · effective 7.3 / 10 · rule-coverage 100% · ceiling Prevented

2 skipped (2 with a documented reason), 437 zero-assertion, no mocking-framework packages referenced (hand-written doubles or no mocking) across 2415 tests. Measured on the .java suite only — at least 38 test source file(s) (.kt) went unread, so its test quality is unmeasured and is not in these counts.

No assertions: doesNotContributeGeneratedAccessorForUnsupportedType · ×437src/test/java/org/springframework/data/aot/AotMappingContextUnitTests.java:60

Skipped (documented): projectionFactoryConsidersKotlinNullabilityConstraints · ×2src/test/java/org/springframework/data/projection/ProxyProjectionFactoryUnitTests.java:351

What to do

Resolve the 437 No assertions finding(s) in Test Quality — start with PartTreeUnitTests.java (42), PageableHandlerMethodArgumentResolverUnitTests.java (15), RepositoryRegistrationAotProcessorIntegrationTests.java (14). — One of this dimension's main actionable groups (437 warning-level).
Enforce Test Quality in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

Do you agree with this assessment?

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 8 declared JVM dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the coordinates this repository's 1 Maven/Gradle manifest(s) declare with a version resolvable from the manifest itself — the same declaration-site closure this analysis reads for dependency currency. The JVM has no lockfile a checkout is guaranteed to carry, so this is deliberately NOT the transitive closure. 40 further coordinate(s) are declared with no version at the declaration site — inherited from a parent POM, a BOM or an unresolved Gradle version reference — and are NOT graded: this verdict covers what the checkout pins, not the full transitive graph.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

Do you agree with this assessment?

D15 · Churn × Complexity Hotspots10.0 / 10Exemplary✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No churn × complexity hotspots in the window.

✓ On the Gold path — maintain.

Detailed fixes: d15_recommendation.md.

Do you agree with this assessment?

D16 · Bus Factor9.6 / 10Exemplary✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: Documented → Verified → Prevented · effective 9.6 / 10 · rule-coverage 100% · ceiling Documented

20 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java. Counted over 400 of the 656 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Off-boarding risk: anonymized user #1

Further sole-owners (lower concentration)

✓ On the Gold path — maintain.

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D17 · Explicit Debt10.0 / 10Stronggated by 14 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

14 deducted task-comment markers across 79598 LoC (0.0/KLoC) → score 10.0. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×12src/main/java/org/springframework/data/core/SerializableLambdaReader.java:482

HackComment · ×2src/test/java/org/springframework/data/mapping/model/ReflectionEntityInstantiatorUnitTests.java:105

What to do

Resolve the 12 TodoComment finding(s) in Explicit Debt — start with RepositoryBeanDefinitionBuilder.java (2), SerializableLambdaReader.java, PropertyPathUtil.java. — One of this dimension's main actionable groups (12 warning-level).
Resolve the 2 HackComment finding(s) in Explicit Debt — start with ReflectionEntityInstantiatorUnitTests.java, ClassGeneratingEntityInstantiatorUnitTests.java. — One of this dimension's main actionable groups (2 warning-level).
Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D19 · Documentation QualityAdequate◐ Sampled · advisory

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Adequate / 10 · rule-coverage 100% · ceiling Documented

The repository's root README gives a high-level overview (Spring Data Commons project purpose and its six primary goals) plus a Code of Conduct link, and starts getting started with Maven dependency and snapshot repo configuration. It is well written but clipped mid-sentence inside the Getting Started section ('* Check the h') before covering installation, usage, contribution, or licence; it also lacks architecture/design docs as the summary states.

What to do

Improve Documentation Quality — currently 5.0/10. — The repository's root README gives a high-level overview (Spring Data Commons project purpose and its six primary goals) plus a Code of Conduct link, and starts getting started with Maven dependency and snapshot repo configuration. It is well written but clipped mid-sentence inside the Getting Started section ('* Check the h') before covering installation, usage, contribution, or licence; it also lacks architecture/design docs as the summary states.

Detailed fixes: d19_recommendation.md.

Do you agree with this assessment?

D21 · Naming ConsistencyExemplary◐ Sampled · advisory

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Verified

0 naming inconsistencies across 0 sampled symbols.

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md.

Do you agree with this assessment?

D26 · Project Cohesion0.0 / 10Critical✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic, LLM-independent.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

1 of 1 build units (Maven) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion

What to do

Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D28 · Secrets (history)10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

gitleaks scanned the full history AND the current working tree and found no secrets.

✓ On the Gold path — maintain.

Detailed fixes: d28_recommendation.md.

Do you agree with this assessment?

D29 · Static Analysis (SAST)0.5 / 10Critical✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 0.5 / 10 · rule-coverage 100% · ceiling Documented

27 finding(s): 0 critical, 27 high, 0 medium, 0 low. 10 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 1 file(s) — `mvnw` (lines 217–218) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 6 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED

What to do

Resolve the 10 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (5), REDACTED (5). — One of this dimension's main actionable groups (10 issue-level).
Resolve the 6 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (6 issue-level).
No action in Static Analysis (SAST) — all 9 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (9 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D34 · Knowledge Freshness7.3 / 10Adequategated by 1 critical finding✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 7.3 / 10 · rule-coverage 100% · ceiling Documented

113 of 400 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is src/main/java/org/springframework/data/core/CustomCollections.java. Counted over 400 of the 656 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned knowledgesrc/main/java/org/springframework/data/core/CustomCollections.java:1

Orphaned file · ×112src/main/java/org/springframework/data/querydsl/binding/QuerydslBindings.java:1

Further orphaned files (smaller)

What to do

Resolve the 112 Orphaned file finding(s) in Knowledge Freshness — start with QuerydslBindings.java, RepositoryConfigurationExtensionSupport.java, ExtensionAwareEvaluationContextProvider.java. — One of this dimension's main actionable groups (112 recommendation-level).
Resolve the 1 Orphaned knowledge finding(s) in Knowledge Freshness — start with CustomCollections.java. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D35 · Change Coupling9.9 / 10Stronggated by 4 serious findings✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: CustomConversions.java↔SimplePropertyValueConversions.java 70%; PageableHandlerMethodArgumentResolverSupport.java↔SortHandlerMethodArgumentResolverSupport.java 60%; CrudRepository.java↔ReactiveCrudRepository.java 54%

Change coupling: CustomConversions.java ↔ SimplePropertyValueConversions.java · ×4src/main/java/org/springframework/data/convert/CustomConversions.java:1

What to do

Resolve the 4 Change coupling finding(s) in Change Coupling — start with CustomConversions.java, PageableHandlerMethodArgumentResolverSupport.java, CrudRepository.java. — One of this dimension's main actionable groups (4 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D36 · Supply-chain Provenance & Signing0.0 / 10Critical✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

0/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED

What to do

Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

Do you agree with this assessment?

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 0 platform declaration(s) and 9 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Do you agree with this assessment?

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX1 · Captive dependencies10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.

Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.

Do you agree with this assessment?

AX10 · Code composition4.0 / 10Weak✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

What to do

The domain core is a small share of production code — check that business logic isn't leaking into the application/infrastructure layers (a thin domain is the anemic-domain smell).

Do you agree with this assessment?

AX2 · Stateful singletons10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

Do you agree with this assessment?

AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

Do you agree with this assessment?

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

Do you agree with this assessment?

AX6 · Interface segregation9.9 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

`TypeInformation<S>` declares 16 abstract methods under just 15 distinct name(s): `getActualType`, `getComponentType`, `getMapValueType`, `getParameterTypes`, `getParameterTypes`, `getProperty`, `getRawTypeInformation`, `getReturnType`, `getSuperTypeInformation`, `getType`, `getTypeArguments`, `isAssignableFrom`, `isCollectionLike`, `isMap`, `toResolvableType`, `toTypeDescriptor`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/main/java/org/springframework/data/core/TypeInformation.java:44
`PersistentEntity<T, P>` declares 28 abstract methods: `doWithAssociations`, `doWithAssociations`, `doWithProperties`, `doWithProperties`, `findAnnotation`, `getIdProperty`, `getIdentifierAccessor`, `getInstanceCreatorMetadata`, `getName`, `getPersistentProperties`, `getPersistentProperty`, `getPropertyAccessor`, `getPropertyPathAccessor`, `getTransientProperty`, `getType`, `getTypeAlias`, `getTypeInformation`, `getVersionProperty`, `hasIdProperty`, `hasVersionProperty`, `isAnnotationPresent`, `isCreatorArgument`, `isIdProperty`, `isImmutable`, `isNew`, `isTransient`, `isVersionProperty`, `requiresPropertyPopulation`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 28 declarations carry 26 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 26 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/main/java/org/springframework/data/mapping/PersistentEntity.java:38
`PersistentProperty<P>` declares 32 abstract methods: `findAnnotation`, `findPropertyOrOwnerAnnotation`, `getActualType`, `getAssociation`, `getAssociationTargetType`, `getAssociationTargetTypeInformation`, `getComponentType`, `getField`, `getGetter`, `getMapValueType`, `getName`, `getOwner`, `getPersistentEntityTypeInformation`, `getRawType`, `getSetter`, `getSpelExpression`, `getType`, `getTypeInformation`, `getWither`, `isAnnotationPresent`, `isArray`, `isAssociation`, `isCollectionLike`, `isEntity`, `isIdProperty`, `isImmutable`, `isMap`, `isReadable`, `isTransient`, `isVersionProperty`, `isWritable`, `usePropertyAccess`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/main/java/org/springframework/data/mapping/PersistentProperty.java:40
`RepositoryConfiguration<T>` declares 18 abstract methods: `getBasePackages`, `getConfigurationSource`, `getExcludeFilters`, `getImplementationBasePackages`, `getImplementationBeanName`, `getNamedQueriesLocation`, `getQueryLookupStrategyKey`, `getRepositoryBaseClassName`, `getRepositoryBeanName`, `getRepositoryFactoryBeanClassName`, `getRepositoryFragmentsContributorClassName`, `getRepositoryInterface`, `getResourceDescription`, `getSource`, `isLazyInit`, `isPrimary`, `toImplementationDetectionConfiguration`, `toLookupConfiguration`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/main/java/org/springframework/data/repository/config/RepositoryConfiguration.java:33
`RepositoryConfigurationSource` declares 17 abstract methods: `generateBeanName`, `getAttribute`, `getAttribute`, `getBasePackages`, `getBootstrapMode`, `getCandidates`, `getExcludeFilters`, `getNamedQueryLocation`, `getQueryLookupStrategyKey`, `getRepositoryBaseClassName`, `getRepositoryFactoryBeanClassName`, `getRepositoryFragmentsContributorClassName`, `getRepositoryImplementationPostfix`, `getResourceDescription`, `getSource`, `toImplementationDetectionConfiguration`, `usesExplicitFilters`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 17 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/main/java/org/springframework/data/repository/config/RepositoryConfigurationSource.java:40
`ReactiveCrudRepository<T, ID>` declares 18 abstract methods under just 11 distinct name(s): `count`, `delete`, `deleteAll`, `deleteAll`, `deleteAll`, `deleteAllById`, `deleteById`, `deleteById`, `existsById`, `existsById`, `findAll`, `findAllById`, `findAllById`, `findById`, `findById`, `save`, `saveAll`, `saveAll`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 18 separate responsibilities: a caller binds to 11 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 18 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/main/java/org/springframework/data/repository/reactive/ReactiveCrudRepository.java:49
`RxJava3CrudRepository<T, ID>` declares 17 abstract methods under just 11 distinct name(s): `count`, `delete`, `deleteAll`, `deleteAll`, `deleteAll`, `deleteAllById`, `deleteById`, `existsById`, `existsById`, `findAll`, `findAllById`, `findAllById`, `findById`, `findById`, `save`, `saveAll`, `saveAll`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 11 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/main/java/org/springframework/data/repository/reactive/RxJava3CrudRepository.java:49

What to do

Split fat interfaces into focused role-interfaces so clients depend only on what they use.
Where the width is an overload set rather than separate responsibilities, collapse the overloads instead — segregating those relieves no caller.

Do you agree with this assessment?

DM10 · One transaction, one aggregate10.0 / 10Exemplary○ Nothing flagged

Other · Domain Modelling — Whether a single operation mutates more than one aggregate root. An aggregate is a consistency boundary, so saving two together fuses them into one — the second's invariants come to depend on the first's transaction, and the pair can no longer be separated. Reads of other aggregates are not counted.

Method: Neutral body surface (DDD-gated): every method body scanned for repository WRITE calls (Add/Update/Save/Remove/Delete/Insert/Store and their async forms), keyed on the ARGUMENT type rather than the repository type — three `IRepository<T>` writes collapse to one repository but are three distinct aggregates. Reads (Get/Find/Load/Query) are excluded, so loading another aggregate for context never counts. Score is offending methods over methods that write at all. Deterministic.

Do you agree with this assessment?

DM12 · Ambient inputs in the domain10.0 / 10Exemplary○ Nothing flagged

Other · Domain Modelling — Whether domain types receive the time and randomness their rules depend on, rather than reading the process clock or a global random source directly — an ambient read makes the rule it feeds untestable at the instant that matters and lets two reads inside one operation disagree.

Method: Roslyn (DDD-gated, C#/VB only): domain-layer types scanned for ambient reads — DateTime/DateTimeOffset.Now/UtcNow/Today, Random.Shared, new Random(), Stopwatch.GetTimestamp — resolved against the semantic model, with a comment/string-stripped token fallback only where resolution fails. Body reads are scored; field/property initialisers are surfaced unscored. Apply/When folds excluded (ES1 owns them). Deterministic, symbol-resolved.

Do you agree with this assessment?

DM6 · Domain ↔ infrastructure boundary10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether the domain layer stays free of infrastructure dependencies (EF/Marten/HTTP/ASP.NET) — the clean-architecture dependency rule.

Method: Roslyn (DDD-gated): domain-layer types scanned for infrastructure usage in member SIGNATURES and inside method/accessor BODIES — resolved calls and object-creations into EF/Marten/HTTP/Mongo/Redis/message-bus types (not just a namespace allowlist). Deterministic, symbol-resolved, exhaustive over domain-layer bodies, DDD-native.

Coverage: Domain layer identified by NAMESPACE heuristic; infrastructure then resolved by symbol in member SIGNATURES and method/accessor BODIES — rename the layer and the check evaporates.

Do you agree with this assessment?

DM8 · Value-object opportunities10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether clusters of primitives that travel together (a missing value object) are extracted — a low-weight suggestion, LLM-confirmed when configured.

Method: Roslyn (DDD-gated): primitive parameter clusters recurring three or more times across signatures extracted, then confirmed by language model when configured. Advisory, low-weight.

Do you agree with this assessment?

DM9 · Scattered domain decisions10.0 / 10Exemplary✓ Tool-verified

Other · Domain Modelling — Whether one domain rule is decided — or one measurement produced — in more than one place, rather than living on the type that owns it.

Method: Neutral body surface plus Roslyn (DDD-gated), two arms. DECISION (Roslyn only): a predicate over a domain type's members judged in two or more types, where none of those decisions live on the owning type — operands of comparisons and relational property patterns only, so a member merely passed as an argument is not judged. DERIVATION: a plain all-numeric carrier of ≥2 members, with no base type and exactly one constructor, CONSTRUCTED as the result of a method (returned or assigned, never inline as an argument) in two or more types other than its own — the same measurement produced twice, which centralising the judgement does not fix. DERIVATION runs on every language whose frontend declares the produced-or-passed fact per construction (Roslyn and the Java sidecar today); a target with only the derivation arm carries an engine gap naming the decision arm as not assessed, and a frontend that declares nothing keeps the dimension not measured rather than clean. Single-member rules, test code and generated code are out of population for both. Advisory.

Do you agree with this assessment?

IC1 · Incompleteness & stubs10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Unfinished work detected by code SHAPE, not keywords, in this repository's Java: methods that only throw a "not implemented" exception, methods that take inputs and return a constant or do nothing, dead `if (false)` branches, and skeleton classes most of whose methods are holes.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

`@SuppressWarnings("all")` switches every compiler and analyser warning off for the whole declaration — hidden debt. Suppress the specific warning on the specific member, with a justification, instead. (×2) — src/main/java/org/springframework/data/repository/cdi/CdiRepositoryExtensionSupport.java:198, src/main/java/org/springframework/data/repository/cdi/CdiRepositoryExtensionSupport.java:205
A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something. (×3) — src/test/java/org/springframework/data/DependencyTests.java:39, src/test/java/org/springframework/data/projection/ProxyProjectionFactoryUnitTests.java:350, src/test/java/org/springframework/data/repository/aot/GeneratedClassesCaptureIntegrationTests.java:66

What to do

Clear the softer debt: re-enable or delete @Disabled/@Ignore tests, decide whether each empty method or UnsupportedOperationException is deliberate (and say so in a comment), and replace @SuppressWarnings("all") with targeted, justified suppressions.

Do you agree with this assessment?

M1 · Documentation (README)4.5 / 10Weak✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

20 code files changed in the last 6 months but the README was not touched — it may no longer reflect the system.

What to do

Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
Review the README against recent changes; refresh the parts that drifted.

Do you agree with this assessment?

M2 · Architecture documentation0.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.

What to do

Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.

Do you agree with this assessment?

M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

Do you agree with this assessment?

M4 · Documentation accuracy10.0 / 10Exemplary◐ Sampled · advisory

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

Do you agree with this assessment?

P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

Do you agree with this assessment?

P3 · Security & performance tooling5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

What to do

Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.

Do you agree with this assessment?

P4 · Deployment & Rollback5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

What to do

Nothing pauses a release for a human: publish as a draft release (or gate the release job on a protected tag/manual dispatch) so a bad build can be stopped before users can download it.

Do you agree with this assessment?

P6 · Release Hygiene5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

What to do

Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.

Do you agree with this assessment?

PF1 · Benchmark discipline8.5 / 10Strong✓ Tool-verified

Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.

Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.

A JMH/Jetpack Benchmark suite exists but nothing turns on its allocation measurement — allocations (the main way hot code pressures a garbage collector or allocator) aren't being measured. — src/jmh/java/org/springframework/data/core/TypedPropertyPathBenchmarks.java

What to do

Run JMH with the GC profiler (`-prof gc`, or addProfiler(GCProfiler.class)) so allocation rate regressions are visible, not just time.

Do you agree with this assessment?

PF2 · Allocation hygiene6.1 / 10Adequate✓ Tool-verified

Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.

Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — in .NET Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit; off .NET, with comments and strings blanked, Go's sync.Pool, preallocated slices/maps, Grow, strconv.Append* and buf[:0] reuse; the JVM's NIO buffer views, MemorySegment, primitive collections, pools and literal presizes (plus Kotlin primitive arrays and value classes, Scala AnyVal and @specialized); Swift's reserveCapacity, ContiguousArray, withUnsafe* access and ~Copyable. Activated off .NET on the same floor (400 lines, and benchmarks or 8 uses); Rust and garbage-collected scripting languages are not applicable. Reward-only. Deterministic, syntax/text detection.

What to do

Raise allocation-aware density on the hot paths — currently 23 use(s) across 95,430 production line(s) (~0.2/1k). More of the idioms below on the allocation-heavy paths climbs this toward 10.
Java: on hot paths, work through buffer views (ByteBuffer/LongBuffer slices, MemorySegment) instead of copies, avoid boxing with primitive collections (fastutil, Eclipse Collections, HPPC, Trove), presize collections and StringBuilders, and pool expensive buffers (Netty's pooled allocator, commons-pool).
Kotlin: on hot paths, use primitive arrays (IntArray, LongArray …) and @JvmInline value classes instead of boxed values, primitive collections (androidx.collection, fastutil) instead of boxed ones, and presize collections and StringBuilders.

Do you agree with this assessment?

PF3 · Async & latency hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

Do you agree with this assessment?

X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

Do you agree with this assessment?

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X14 · Bypassable address classification10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.

Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.

Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.

Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X18 · Disposal-pattern correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X19 · Unrestored process-global state10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X20 · Mistyped argument guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `NullPointerException` (Java, Kotlin, Scala), `ArgumentError.notNull` (Dart) or `ArgumentNullException` (F#'s `nullArg`) tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X22 · Contradicted release guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.

Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.

Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X26 · Unsynchronised callback handoff10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.

Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen. Whether a `for (x in c)` or `c.forEach { … }` leaves the collection it is walking alone — a `mutableListOf`/`ArrayList`, `mutableMapOf`/`HashMap` or `mutableSetOf`/`HashSet` is a `java.util` collection on the JVM and is walked by its own fail-fast iterator, so a body that adds to or removes from the very collection the loop is walking makes the next step throw `ConcurrentModificationException` and the remaining elements are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X3 · Exception handling7.2 / 10Strong✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

`catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×2) — src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:157, src/main/java/org/springframework/data/util/ClassUtils.java:75
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. — src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:833

What to do

Swallowed exception (caught, then discarded)

Do you agree with this assessment?

X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

Do you agree with this assessment?

X4 · Structured logging10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

Do you agree with this assessment?

X5 · Nullable reference types8.4 / 10Strong✓ Tool-verified

Other · Code Health — Whether Java packages are null-marked and not undermined by heavy nullness suppression — a package under `@NullMarked` (or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, or a NullAway/Checker Framework configuration naming it) makes an unannotated reference exclude null, and `@SuppressWarnings("NullAway")`, `("nullness")`, `("null")` and `castToNonNull(…)` are what silence it.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

46/47 of this repository's Java package directories are under a non-null default: a `package-info.java` declaring `@NullMarked` (JSpecify) or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, `@DefaultQualifier(NonNull.class)`; a `module-info.java` declaring `@NullMarked`; every type in it `@NullMarked`; or a build that runs NullAway with the package in `AnnotatedPackages`, or the Checker Framework's `NullnessChecker`. Elsewhere every reference admits null and no checker warns on the dereference that throws a `NullPointerException`.

What to do

Declare the default where Java declares it: `@NullMarked` (org.jspecify.annotations) in each package's `package-info.java`, or once in `module-info.java`, and run NullAway (Error Prone) or the Checker Framework so the declaration is enforced. Then annotate the real exceptions `@Nullable` and resolve the suppressions rather than adding to them: a `@SuppressWarnings("NullAway")` or `castToNonNull(x)` on a value the checker could show to be null is a `NullPointerException` waiting for the path that makes it true — where the value genuinely cannot be null, say something the checker can see instead (a null check, `Objects.requireNonNull`, a non-null field initialised in the constructor).

Do you agree with this assessment?

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

Lens	Score	Rating	Impact
Code Health	86%	Strong	Solid.
Architecture	75%	Adequate — gated by D26	Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Maturity	46%	Weak — gated by M2	Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness	63%	Adequate	Acceptable, with room to improve.
Security	51%	Adequate — gated by D29, D36	Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Domain Modelling	100%	Exemplary	Strongest area.
Performance	78%	Strong	Solid.

Unscored — 2 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

P12 CI test-gate honesty — 1 observation(s) recorded · Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
X10 Duplicated predicate — 12 observation(s) recorded · Advisory — this card reports evidence and never carries a score.

Not evidenced — 4 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

C3 Audit Trail — Not assessed: these audit controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C4 Data Retention — Not assessed: these retention controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks retention controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C5 Data-Subject Rights — Not assessed: these data-subject rights controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks data-subject rights controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control

Not included — 57 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — no test/production split to check
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB1 Runtime evidence locked — no reproducible boot — This repository has nothing the runtime tiers could boot or serve — no markup, no UI framework or web-server dependency, no UI component source, no native UI project and no API definition — nothing here is a surface to boot — so runtime a11y/egress/header evidence has no subject here. Not applicable: this is neither a gap in the scan nor a finding about your code.
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
D11 Test Reliability — Test reliability not included — the .java suite was found but not re-run
D12 Dependency Hygiene — Dependency currency not established — repo.spring.io did not answer
D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
D20 ADR Quality — Repository kind not determined
D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ projects each declaring an entity of their own. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D24 Comment Value — No inline comments to assess — comment value is not applicable here.
D25 ADR Conformance — no ADRs to check
D27 Navigability — D27 counts a call into the standard library or a dependency as unresolved for this repository's language (.java), so too few call sites counted as resolved to assess navigability. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D30 Dependency Vulnerabilities — Scanner failed to run — not a clean result
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D32 Data Compliance (PII/GDPR) — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D43 Malicious Dependencies — Scanner failed to run — not a clean result
D5 Coupling — Not applicable — this Maven build ships 1 production module(s), so there is no coupling BETWEEN modules to measure. (Its test and non-production modules are not part of the shipped graph.)
D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
D8 Code Coverage — Coverage not included — suite not readable by the collector
DM1 Aggregate boundaries — no aggregates detected — aggregate-boundary check not applicable
DM11 Constructible invalid state — no entities detected — construction-time invariants not assessable
DM2 Strongly-typed ids — no id-bearing domain types detected — strongly-typed-id adoption not assessable
DM3 Integration-event coupling — no integration events detected — coupling check not applicable
DM4 Rich vs anemic model — no data-bearing entities detected — rich-vs-anemic model not assessable
DM5 Encapsulated state — no domain entities found — DM5 grades how entities protect their state, and this repository declares none
DM7 Repository granularity — no repository abstraction detected (e.g. uses a document session)
ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
P2 Observability — This repository's JVM source (1 module(s), 656 file(s) read) declares no entry point and bootstraps no server, and nothing here deploys a service — it is a library, run inside whatever hosts it, so production observability (structured logging, tracing/metrics, health checks) is N/A. If it grows a binary or a service, the dimension reactivates.
P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the JVM source, so there is no service whose uptime a failing dependency could take down
P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (JaCoCo XML — `mvn jacoco:report`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
X2 Cancellation propagation — no C# was loaded; this repository's Java and Kotlin were read, and no request in it can be cancelled by a caller (Ktor, OkHttp's newCall or a URL stream, from a suspend function) — a Java request off Android takes no token: it is cancelled through the handle it returns (Future.cancel, Call.cancel, a Disposable), ambiently (io.grpc.Context) or by interrupting its thread, not through a parameter; a Kotlin request outside a suspend function has no caller's cancellation to honour
X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 28 finding(s)

D29 · Static Analysis (SAST) · REDACTED

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

D29 · Static Analysis (SAST) · REDACTED

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

D29 · Static Analysis (SAST) · REDACTED

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

D29 · Static Analysis (SAST) · REDACTED · ×1

REDACTED

D29 · Static Analysis (SAST) · REDACTED · ×1

REDACTED

D34 · Knowledge Freshness · Orphaned knowledge · ×1

Orphaned knowledge src/main/java/org/springframework/data/core/CustomCollections.java:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.

Serious — 572 finding(s)

D10 · Test Quality · No assertions · ×437

No assertions: doesNotContributeGeneratedAccessorForUnsupportedType src/test/java/org/springframework/data/aot/AotMappingContextUnitTests.java:60 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: obtainEntityWithReference src/test/java/org/springframework/data/aot/AotMappingContextUnitTests.java:41 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: contributesProxyForAuditorAwareInterface src/test/java/org/springframework/data/aot/AuditingBeanRegistrationAotProcessorUnitTests.java:47 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: contributesProxyForReactiveAuditorAwareInterface src/test/java/org/springframework/data/aot/AuditingBeanRegistrationAotProcessorUnitTests.java:61 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: shouldConsiderDisabledAccessors src/test/java/org/springframework/data/aot/DefaultAotContextUnitTests.java:61 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: rejectsNullAnnotationMetadata src/test/java/org/springframework/data/auditing/config/AuditingBeanDefinitionRegistrarSupportUnitTests.java:62 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: rejectsNullRegistry src/test/java/org/springframework/data/auditing/config/AuditingBeanDefinitionRegistrarSupportUnitTests.java:71 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: rejectsInvalidDateTypeField src/test/java/org/springframework/data/auditing/AnnotationAuditingMetadataUnitTests.java:65 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: rejectsNullSource src/test/java/org/springframework/data/auditing/DefaultAuditableBeanWrapperFactoryUnitTests.java:46 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: shouldRejectUnsupportedTemporalConversion src/test/java/org/springframework/data/auditing/DefaultAuditableBeanWrapperFactoryUnitTests.java:141 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: handlingOptionalIsANoOp src/test/java/org/springframework/data/auditing/IsNewAwareAuditingHandlerUnitTests.java:86 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: rejectsNullMappingContext src/test/java/org/springframework/data/auditing/IsNewAwareAuditingHandlerUnitTests.java:76 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: setsUpHandlerWithMappingContext src/test/java/org/springframework/data/auditing/IsNewAwareAuditingHandlerUnitTests.java:81 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: skipsEntityWithoutIdentifier src/test/java/org/springframework/data/auditing/IsNewAwareAuditingHandlerUnitTests.java:96 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: exposesLongAsModificationDate src/test/java/org/springframework/data/auditing/MappingAuditableBeanWrapperFactoryUnitTests.java:179 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: returnsLastModificationCalendarAsCalendar src/test/java/org/springframework/data/auditing/MappingAuditableBeanWrapperFactoryUnitTests.java:138 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: returnsLastModificationDateAsCalendar src/test/java/org/springframework/data/auditing/MappingAuditableBeanWrapperFactoryUnitTests.java:150 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: returnsLastModificationJsr310DateTimeAsCalendar src/test/java/org/springframework/data/auditing/MappingAuditableBeanWrapperFactoryUnitTests.java:159 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: shouldRejectUnsupportedTemporalConversion src/test/java/org/springframework/data/auditing/MappingAuditableBeanWrapperFactoryUnitTests.java:262 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: rejectsNonBijectionalMap src/test/java/org/springframework/data/convert/ConfigurableTypeInformationMapperUnitTests.java:55 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: rejectsNullTypeMap src/test/java/org/springframework/data/convert/ConfigurableTypeInformationMapperUnitTests.java:50 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: setsUpBidirectionalConvertersFromReading src/test/java/org/springframework/data/convert/ConverterBuilderUnitTests.java:36 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: setsUpBidirectionalConvertersFromWriting src/test/java/org/springframework/data/convert/ConverterBuilderUnitTests.java:46 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: setsUpReadingConverter src/test/java/org/springframework/data/convert/ConverterBuilderUnitTests.java:56 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: setsUpWritingConverter src/test/java/org/springframework/data/convert/ConverterBuilderUnitTests.java:66 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
+ 412 more in this group — see findings.md.

D4 · Code Duplication · Duplicated block (8 lines × 2) · ×13

Duplicated block (8 lines × 2) src/main/java/org/springframework/data/geo/GeoJacksonModule.java:46 — src/main/java/org/springframework/data/geo/GeoJacksonModule.java:46-53 | src/main/java/org/springframework/data/geo/GeoModule.java:46-53 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: `Version` names `com.fasterxml.jackson.core.Version` in one and `tools.jackson.core.Version` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (8 lines × 2) src/main/java/org/springframework/data/repository/cdi/CdiRepositoryBean.java:103 — src/main/java/org/springframework/data/repository/cdi/CdiRepositoryBean.java:103-110 | src/main/java/org/springframework/data/repository/cdi/CdiRepositoryBean.java:128-135 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) src/main/java/org/springframework/data/geo/Box.java:46 — src/main/java/org/springframework/data/geo/Box.java:46-53 | src/main/java/org/springframework/data/util/Pair.java:43-50 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: the declarations holding them bind `first` to `Point` in one and `S` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (8 lines × 2) src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:336 — src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:336-343 | src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:386-393 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:377 — src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:377-384 | src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:427-434 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:418 — src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:418-425 | src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:468-475 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:458 — src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:458-465 | src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:510-517 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:498 — src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:498-505 | src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:553-560 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:541 — src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:541-548 | src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:596-603 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8 lines × 2) src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:571 — src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:571-578 | src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:626-633 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8 lines × 2) src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:214 — src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:214-221 | src/main/java/org/springframework/data/util/ParameterTypes.java:215-222 — before extracting anything, compare `src/main/java/org/springframework/data/spel/spi/ParameterTypes.java` and `src/main/java/org/springframework/data/util/ParameterTypes.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 149 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) src/main/java/org/springframework/data/mapping/callback/EntityCallbacks.java:57 — src/main/java/org/springframework/data/mapping/callback/EntityCallbacks.java:57-64 | src/main/java/org/springframework/data/mapping/callback/ReactiveEntityCallbacks.java:60-67 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) src/main/java/org/springframework/data/web/PagedResourcesAssembler.java:207 — src/main/java/org/springframework/data/web/PagedResourcesAssembler.java:207-214 | src/main/java/org/springframework/data/web/SlicedResourcesAssembler.java:206-213 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/web/PagedResourcesAssembler.java:207` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.

D17 · Explicit Debt · TodoComment · ×12

TodoComment src/main/java/org/springframework/data/core/SerializableLambdaReader.java:482 — // TODO composite path information — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/main/java/org/springframework/data/core/PropertyPathUtil.java:87 — // TODO: actual arg count vs. hardcoded value '1' — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/main/java/org/springframework/data/crossstore/ChangeSetBackedTransactionSynchronization.java:53 — // this could be bad - TODO: compensate — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/main/java/org/springframework/data/projection/EntityProjectionIntrospector.java:125 — // TODO: PropertyDescriptor only created for DTO's with getters/setters — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/main/java/org/springframework/data/repository/aot/generate/AotRepositoryCreator.java:139 — // TODO: decouple json from method building and get rid of methodMetadata here? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/main/java/org/springframework/data/repository/config/RepositoryBeanDefinitionBuilder.java:159 — // TODO: merge that with the one that creates the BD — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/main/java/org/springframework/data/repository/config/RepositoryBeanDefinitionBuilder.java:160 — // TODO: Add support for fragments discovered from spring.factories — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/main/java/org/springframework/data/repository/query/QueryMethod.java:399 — // TODO: to resolve generics fully we'd need the actual repository interface here — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/main/java/org/springframework/data/util/TypeUtils.java:41 — // TODO: Consider moving to the org.springframework.data.util package or make this package-private if not used somewhere — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/test/java/org/springframework/data/convert/PropertyValueConverterFactoryUnitTests.java:204 — // TODO: is this a valid assumption? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/test/java/org/springframework/data/core/TypeDiscovererUnitTests.java:271 — // TODO: notEquals — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/test/java/org/springframework/data/repository/aot/RepositoryRegistrationAotProcessorIntegrationTests.java:61 — // TODO: This is verifying repository.config code. Move to repository.config package? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.

D4 · Code Duplication · Duplicated block (5 lines × 2) · ×8

Duplicated block (5 lines × 2) src/main/java/org/springframework/data/core/PropertyReferenceException.java:151 — src/main/java/org/springframework/data/core/PropertyReferenceException.java:151-155 | src/main/java/org/springframework/data/mapping/context/InvalidPersistentPropertyPath.java:128-132 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/core/PropertyReferenceException.java:151` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (5 lines × 2) src/main/java/org/springframework/data/mapping/model/InstanceCreatorMetadataDiscoverer.java:151 — src/main/java/org/springframework/data/mapping/model/InstanceCreatorMetadataDiscoverer.java:151-155 | src/main/java/org/springframework/data/mapping/model/PreferredConstructorDiscoverer.java:257-261 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/mapping/model/InstanceCreatorMetadataDiscoverer.java:151` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) src/main/java/org/springframework/data/querydsl/binding/PropertyPathInformation.java:149 — src/main/java/org/springframework/data/querydsl/binding/PropertyPathInformation.java:149-153 | src/main/java/org/springframework/data/querydsl/binding/QuerydslPathInformation.java:107-111 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:364 — src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:364-368 | src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:414-418 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:405 — src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:405-409 | src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:455-459 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:445 — src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:445-449 | src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:496-500 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:485 — src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:485-489 | src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:540-544 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:526 — src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:526-530 | src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:581-585 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.

D3 · God Classes · TooManyMethods · ×7

TooManyMethods: BasicPersistentEntity src/main/java/org/springframework/data/mapping/model/BasicPersistentEntity.java:67 — TooManyMethods — 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: JSONObject src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:69 — TooManyMethods — 47 methods. The bar is 30 methods; this is 17 over it, 1.57× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: JSONArray src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:46 — TooManyMethods — 46 methods. The bar is 30 methods; this is 16 over it, 1.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: RepositoryFactorySupport src/main/java/org/springframework/data/repository/core/support/RepositoryFactorySupport.java:97 — TooManyMethods — 37 methods. The bar is 30 methods; this is 7 over it, 1.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: AbstractPersistentProperty src/main/java/org/springframework/data/mapping/model/AbstractPersistentProperty.java:47 — TooManyMethods — 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PropertyAccessorClassGenerator src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:328 — TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: CdiRepositoryBean src/main/java/org/springframework/data/repository/cdi/CdiRepositoryBean.java:68 — TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.

D4 · Code Duplication · Duplicated block (11 lines × 2) · ×7

Duplicated block (11 lines × 2) src/main/java/org/springframework/data/querydsl/binding/PropertyPathInformation.java:136 — src/main/java/org/springframework/data/querydsl/binding/PropertyPathInformation.java:136-146 | src/main/java/org/springframework/data/querydsl/binding/QuerydslPathInformation.java:94-104 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (11 lines × 2) src/main/java/org/springframework/data/repository/core/support/RepositoryMethodInvoker.java:224 — src/main/java/org/springframework/data/repository/core/support/RepositoryMethodInvoker.java:224-234 | src/main/java/org/springframework/data/repository/core/support/RepositoryMethodInvoker.java:241-251 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/repository/core/support/RepositoryMethodInvoker.java:224` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:226 — src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:226-236 | src/main/java/org/springframework/data/util/ParameterTypes.java:227-237 — before extracting anything, compare `src/main/java/org/springframework/data/spel/spi/ParameterTypes.java` and `src/main/java/org/springframework/data/util/ParameterTypes.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 149 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (11 lines × 2) src/main/java/org/springframework/data/web/ProjectingJackson2HttpMessageConverter.java:116 — src/main/java/org/springframework/data/web/ProjectingJackson2HttpMessageConverter.java:116-126 | src/main/java/org/springframework/data/web/XmlBeamHttpMessageConverter.java:96-107 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/web/ProjectingJackson2HttpMessageConverter.java:116` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 2) src/main/java/org/springframework/data/core/NullableWrapperConverters.java:260 — src/main/java/org/springframework/data/core/NullableWrapperConverters.java:260-270 | src/main/java/org/springframework/data/repository/util/QueryExecutionConverters.java:330-340 — before extracting anything, compare `src/main/java/org/springframework/data/core/NullableWrapperConverters.java` and `src/main/java/org/springframework/data/repository/util/QueryExecutionConverters.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/core/NullableWrapperConverters.java:260` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/main/java/org/springframework/data/repository/util/QueryExecutionConverters.java:327` calls `Contract` and `src/main/java/org/springframework/data/core/NullableWrapperConverters.java:256` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 2) src/main/java/org/springframework/data/web/config/SpringDataJackson3Configuration.java:89 — src/main/java/org/springframework/data/web/config/SpringDataJackson3Configuration.java:89-99 | src/main/java/org/springframework/data/web/config/SpringDataJacksonConfiguration.java:93-103 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (11 lines × 2) src/main/java/org/springframework/data/mapping/PersistentEntity.java:314 — src/main/java/org/springframework/data/mapping/PersistentEntity.java:314-324 | src/main/java/org/springframework/data/mapping/PersistentProperty.java:380-390 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/mapping/PersistentEntity.java:314` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (10 lines × 2) · ×7

Duplicated block (10 lines × 2) src/main/java/org/springframework/data/mapping/callback/DefaultEntityCallbacks.java:69 — src/main/java/org/springframework/data/mapping/callback/DefaultEntityCallbacks.java:69-78 | src/main/java/org/springframework/data/mapping/callback/DefaultReactiveEntityCallbacks.java:69-78 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (10 lines × 2) src/main/java/org/springframework/data/web/PageableHandlerMethodArgumentResolver.java:91 — src/main/java/org/springframework/data/web/PageableHandlerMethodArgumentResolver.java:91-100 | src/main/java/org/springframework/data/web/ReactivePageableHandlerMethodArgumentResolver.java:83-92 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/web/PageableHandlerMethodArgumentResolver.java:91` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/main/java/org/springframework/data/web/SortHandlerMethodArgumentResolverSupport.java:244 — src/main/java/org/springframework/data/web/SortHandlerMethodArgumentResolverSupport.java:244-253 | src/main/java/org/springframework/data/web/SortHandlerMethodArgumentResolverSupport.java:274-283 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/web/SortHandlerMethodArgumentResolverSupport.java:244` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/main/java/org/springframework/data/auditing/config/AuditingBeanDefinitionRegistrarSupport.java:185 — src/main/java/org/springframework/data/auditing/config/AuditingBeanDefinitionRegistrarSupport.java:185-194 | src/main/java/org/springframework/data/auditing/config/AuditingHandlerBeanDefinitionParser.java:109-118 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:125 — src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:125-134 | src/main/java/org/springframework/data/util/ParameterTypes.java:126-135 — before extracting anything, compare `src/main/java/org/springframework/data/spel/spi/ParameterTypes.java` and `src/main/java/org/springframework/data/util/ParameterTypes.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 149 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (10 lines × 2) src/main/java/org/springframework/data/web/ProjectingJackson2HttpMessageConverter.java:86 — src/main/java/org/springframework/data/web/ProjectingJackson2HttpMessageConverter.java:86-95 | src/main/java/org/springframework/data/web/ProjectingJacksonHttpMessageConverter.java:97-106 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: `ObjectMapper` names `com.fasterxml.jackson.databind.ObjectMapper` in one and `tools.jackson.databind.ObjectMapper` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (10 lines × 2) src/main/java/org/springframework/data/web/config/SpringDataJackson3Configuration.java:150 — src/main/java/org/springframework/data/web/config/SpringDataJackson3Configuration.java:150-159 | src/main/java/org/springframework/data/web/config/SpringDataJacksonConfiguration.java:156-165 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/web/config/SpringDataJackson3Configuration.java:150` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note first that the copies are not typed on the same thing: `BeanPropertyWriter` names `com.fasterxml.jackson.databind.ser.BeanPropertyWriter` in one and `tools.jackson.databind.ser.BeanPropertyWriter` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.

D4 · Code Duplication · Duplicated block (12 lines × 2) · ×6

Duplicated block (12 lines × 2) src/main/java/org/springframework/data/mapping/model/ClassGeneratingEntityInstantiator.java:429 — src/main/java/org/springframework/data/mapping/model/ClassGeneratingEntityInstantiator.java:429-440 | src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:355-366 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (12 lines × 2) src/main/java/org/springframework/data/mapping/model/MappingInstantiationException.java:124 — src/main/java/org/springframework/data/mapping/model/MappingInstantiationException.java:124-135 | src/main/java/org/springframework/data/mapping/model/MappingInstantiationException.java:141-152 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/mapping/model/MappingInstantiationException.java:124` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) src/main/java/org/springframework/data/repository/init/Jackson2ResourceReader.java:95 — src/main/java/org/springframework/data/repository/init/Jackson2ResourceReader.java:95-106 | src/main/java/org/springframework/data/repository/init/JacksonResourceReader.java:90-101 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/repository/init/Jackson2ResourceReader.java:95` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: `JsonNode` names `com.fasterxml.jackson.databind.JsonNode` in one and `tools.jackson.databind.JsonNode` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (12 lines × 2) src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:141 — src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:141-152 | src/main/java/org/springframework/data/util/ParameterTypes.java:142-153 — before extracting anything, compare `src/main/java/org/springframework/data/spel/spi/ParameterTypes.java` and `src/main/java/org/springframework/data/util/ParameterTypes.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 149 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:290 — src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:290-301 | src/main/java/org/springframework/data/util/ParameterTypes.java:291-302 — before extracting anything, compare `src/main/java/org/springframework/data/spel/spi/ParameterTypes.java` and `src/main/java/org/springframework/data/util/ParameterTypes.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 149 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:81 — src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:81-92 | src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:140-151 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.

D4 · Code Duplication · Duplicated block (7 lines × 2) · ×5

Duplicated block (7 lines × 2) src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:883 — src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:883-889 | src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:912-918 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:883` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:195 — src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:195-201 | src/main/java/org/springframework/data/util/ParameterTypes.java:196-202 — before extracting anything, compare `src/main/java/org/springframework/data/spel/spi/ParameterTypes.java` and `src/main/java/org/springframework/data/util/ParameterTypes.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 149 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) src/main/java/org/springframework/data/web/PagedResourcesAssembler.java:286 — src/main/java/org/springframework/data/web/PagedResourcesAssembler.java:286-292 | src/main/java/org/springframework/data/web/SlicedResourcesAssembler.java:276-282 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) src/main/java/org/springframework/data/web/querydsl/QuerydslPredicateArgumentResolver.java:75 — src/main/java/org/springframework/data/web/querydsl/QuerydslPredicateArgumentResolver.java:75-81 | src/main/java/org/springframework/data/web/querydsl/ReactiveQuerydslPredicateArgumentResolver.java:50-56 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/web/querydsl/QuerydslPredicateArgumentResolver.java:75` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (7 lines × 2) src/main/java/org/springframework/data/convert/CustomConversions.java:462 — src/main/java/org/springframework/data/convert/CustomConversions.java:462-468 | src/main/java/org/springframework/data/querydsl/binding/QuerydslBindings.java:188-194 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.

D4 · Code Duplication · Duplicated block (6 lines × 2) · ×5

Duplicated block (6 lines × 2) src/main/java/org/springframework/data/core/SerializableLambdaReader.java:421 — src/main/java/org/springframework/data/core/SerializableLambdaReader.java:421-426 | src/main/java/org/springframework/data/core/SerializableLambdaReader.java:467-472 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/core/SerializableLambdaReader.java:421` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) src/main/java/org/springframework/data/core/NullableWrapperConverters.java:251 — src/main/java/org/springframework/data/core/NullableWrapperConverters.java:251-256 | src/main/java/org/springframework/data/repository/util/QueryExecutionConverters.java:320-325 — before extracting anything, compare `src/main/java/org/springframework/data/core/NullableWrapperConverters.java` and `src/main/java/org/springframework/data/repository/util/QueryExecutionConverters.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/main/java/org/springframework/data/repository/util/QueryExecutionConverters.java:327` calls `Contract` and `src/main/java/org/springframework/data/core/NullableWrapperConverters.java:258` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 2) src/main/java/org/springframework/data/querydsl/SimpleEntityPathResolver.java:127 — src/main/java/org/springframework/data/querydsl/SimpleEntityPathResolver.java:127-132 | src/main/java/org/springframework/data/util/QTypeContributor.java:103-108 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (6 lines × 2) src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:207 — src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:207-212 | src/main/java/org/springframework/data/util/ParameterTypes.java:208-213 — before extracting anything, compare `src/main/java/org/springframework/data/spel/spi/ParameterTypes.java` and `src/main/java/org/springframework/data/util/ParameterTypes.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 149 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (6 lines × 2) src/main/java/org/springframework/data/web/PagedResourcesAssembler.java:78 — src/main/java/org/springframework/data/web/PagedResourcesAssembler.java:78-83 | src/main/java/org/springframework/data/web/SlicedResourcesAssembler.java:79-84 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/web/PagedResourcesAssembler.java:78` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note first that the copies are not typed on the same thing: the declarations holding them bind `baseUri` to `Optional<UriComponents>` in one and `UriComponents` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.

D35 · Change Coupling · Change coupling · ×4

Change coupling: CustomConversions.java ↔ SimplePropertyValueConversions.java src/main/java/org/springframework/data/convert/CustomConversions.java:1 — `src/main/java/org/springframework/data/convert/CustomConversions.java` and `src/main/java/org/springframework/data/convert/SimplePropertyValueConversions.java` change together 70% of the time (7 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `1b79eeb5` Polishing.; `adc8e3ff` Revisit internal caching arrangements.; `97be53bd` Remove superfluous `@NonNull` annotations. — run `git show` on any of them.
Change coupling: PageableHandlerMethodArgumentResolverSupport.java ↔ SortHandlerMethodArgumentResolverSupport.java src/main/java/org/springframework/data/web/PageableHandlerMethodArgumentResolverSupport.java:1 — `src/main/java/org/springframework/data/web/PageableHandlerMethodArgumentResolverSupport.java` and `src/main/java/org/springframework/data/web/SortHandlerMethodArgumentResolverSupport.java` change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `f3e92b0e` Polishing.; `7e1712a5` Refine `@PageableDefault` and `@SortDefault` annotations.; `6616f6e5` DATACMNS-1827 - Polishing. — run `git show` on any of them.
Change coupling: CrudRepository.java ↔ ReactiveCrudRepository.java src/main/java/org/springframework/data/repository/CrudRepository.java:1 — `src/main/java/org/springframework/data/repository/CrudRepository.java` and `src/main/java/org/springframework/data/repository/reactive/ReactiveCrudRepository.java` change together 54% of the time (7 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `ef42e7e1` Polishing.; `2534f176` Polishing.; `02ec7ed1` Polishing. — run `git show` on any of them.
Change coupling: OrderBySource.java ↔ Part.java src/main/java/org/springframework/data/repository/query/parser/OrderBySource.java:1 — `src/main/java/org/springframework/data/repository/query/parser/OrderBySource.java` and `src/main/java/org/springframework/data/repository/query/parser/Part.java` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `b4d2391c` Use `List.of()` and `Set.of()` where feasible.; `4e27cce6` DATACMNS-84 - Improved infrastructure to access PersistentProperty pa… (at that commit the files were still `spring-data-commons-core/src/main/java/org/springframework/data/repository/query/parser/OrderBySource.java` and `spring-data-commons-core/src/main/java/org/springframework/data/repository/query/parser/Part.java`); `04165ab0` DATACMNS-72 - A lot of improvements related to Sonar results. (at that commit the files were still `spring-data-commons-core/src/main/java/org/springframework/data/repository/query/parser/OrderBySource.java` and `spring-data-commons-core/src/main/java/org/springframework/data/repository/query/parser/Part.java`) — run `git show` on any of them.

D4 · Code Duplication · Duplicated block (9 lines × 2) · ×4

Duplicated block (9 lines × 2) src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:650 — src/main/java/org/springframework/data/repository/aot/generate/JSONArray.java:650-658 | src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:703-711 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (9 lines × 2) src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:89 — src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:89-97 | src/main/java/org/springframework/data/util/ParameterTypes.java:90-98 — before extracting anything, compare `src/main/java/org/springframework/data/spel/spi/ParameterTypes.java` and `src/main/java/org/springframework/data/util/ParameterTypes.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 149 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:160 — src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:160-168 | src/main/java/org/springframework/data/util/ParameterTypes.java:161-169 — before extracting anything, compare `src/main/java/org/springframework/data/spel/spi/ParameterTypes.java` and `src/main/java/org/springframework/data/util/ParameterTypes.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 149 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) src/main/java/org/springframework/data/auditing/MappingAuditableBeanWrapperFactory.java:197 — src/main/java/org/springframework/data/auditing/MappingAuditableBeanWrapperFactory.java:197-205 | src/main/java/org/springframework/data/mapping/model/ConvertingPropertyAccessor.java:49-58 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/auditing/MappingAuditableBeanWrapperFactory.java:197` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note first that the copies are not typed on the same thing: the declarations holding them bind `accessor` to `PersistentPropertyPathAccessor<T>` in one and `PersistentPropertyAccessor<T>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.

D6 · Cohesion (LCOM4) · Low cohesion · ×4

Low cohesion: CustomConversions (LCOM4 8) src/main/java/org/springframework/data/convert/CustomConversions.java:71 — CustomConversions's methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: SortHandlerMethodArgumentResolverSupport (LCOM4 6) src/main/java/org/springframework/data/web/SortHandlerMethodArgumentResolverSupport.java:50 — SortHandlerMethodArgumentResolverSupport's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: Sort (LCOM4 4) src/main/java/org/springframework/data/domain/Sort.java:53 — Sort's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: PageableHandlerMethodArgumentResolverSupport (LCOM4 4) src/main/java/org/springframework/data/web/PageableHandlerMethodArgumentResolverSupport.java:49 — PageableHandlerMethodArgumentResolverSupport's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.

D4 · Code Duplication · Duplicated block (16 lines × 2) · ×3

Duplicated block (16 lines × 2) src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:268 — src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:268-283 | src/main/java/org/springframework/data/util/ParameterTypes.java:269-284 — before extracting anything, compare `src/main/java/org/springframework/data/spel/spi/ParameterTypes.java` and `src/main/java/org/springframework/data/util/ParameterTypes.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 149 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (16 lines × 2) src/main/java/org/springframework/data/core/NullableWrapperConverters.java:470 — src/main/java/org/springframework/data/core/NullableWrapperConverters.java:470-485 | src/main/java/org/springframework/data/repository/util/QueryExecutionConverters.java:439-454 — before extracting anything, compare `src/main/java/org/springframework/data/core/NullableWrapperConverters.java` and `src/main/java/org/springframework/data/repository/util/QueryExecutionConverters.java` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 2) src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:342 — src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:342-357 | src/main/java/org/springframework/data/util/ParameterTypes.java:343-358 — before extracting anything, compare `src/main/java/org/springframework/data/spel/spi/ParameterTypes.java` and `src/main/java/org/springframework/data/util/ParameterTypes.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 149 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.

D17 · Explicit Debt · HackComment · ×2

HackComment src/test/java/org/springframework/data/mapping/model/ReflectionEntityInstantiatorUnitTests.java:105 — // Hack to check synthetic field as compiles create different field names (e.g. this$0, this$1) — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
HackComment src/test/java/org/springframework/data/mapping/model/ClassGeneratingEntityInstantiatorUnitTests.java:117 — // Hack to check synthetic field as compiles create different field names (e.g. this$0, this$1) — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.

D4 · Code Duplication · Duplicated block (13 lines × 2) · ×2

Duplicated block (13 lines × 2) src/main/java/org/springframework/data/core/MemberDescriptor.java:172 — src/main/java/org/springframework/data/core/MemberDescriptor.java:172-184 | src/main/java/org/springframework/data/core/MemberDescriptor.java:222-234 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (13 lines × 2) src/main/java/org/springframework/data/web/OffsetScrollPositionHandlerMethodArgumentResolverSupport.java:76 — src/main/java/org/springframework/data/web/OffsetScrollPositionHandlerMethodArgumentResolverSupport.java:76-88 | src/main/java/org/springframework/data/web/SortHandlerMethodArgumentResolverSupport.java:191-203 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.

X3 · Exception handling · Swallowed exception (caught, then discarded) · ×2

Swallowed exception (caught, then discarded) src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:157 — `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/main/java/org/springframework/data/util/ClassUtils.java:75 — `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.

D1 · Cyclomatic Complexity · BytecodeUtil.autoboxIfNeeded (cyclomatic 33) · ×1

BytecodeUtil.autoboxIfNeeded (cyclomatic 33) src/main/java/org/springframework/data/mapping/model/BytecodeUtil.java:87 — BytecodeUtil.autoboxIfNeeded has cyclomatic complexity 33 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.

D1 · Cyclomatic Complexity · AotRepositoryCreator.contributeMethod (cyclomatic 24) · ×1

AotRepositoryCreator.contributeMethod (cyclomatic 24) src/main/java/org/springframework/data/repository/aot/generate/AotRepositoryCreator.java:250 — AotRepositoryCreator.contributeMethod has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.

D1 · Cyclomatic Complexity · ResultProcessor.processResult (cyclomatic 18) · ×1

ResultProcessor.processResult (cyclomatic 18) src/main/java/org/springframework/data/repository/query/ResultProcessor.java:140 — ResultProcessor.processResult has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.

D1 · Cyclomatic Complexity · InputMessageProjecting.invoke (cyclomatic 18) · ×1

InputMessageProjecting.invoke (cyclomatic 18) src/main/java/org/springframework/data/web/JsonProjectingMethodInterceptorFactory.java:137 — InputMessageProjecting.invoke has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.

D1 · Cyclomatic Complexity · ObjectInstantiatorClassGenerator.insertUnboxInsns (cyclomatic 17) · ×1

ObjectInstantiatorClassGenerator.insertUnboxInsns (cyclomatic 17) src/main/java/org/springframework/data/mapping/model/ClassGeneratingEntityInstantiator.java:614 — ObjectInstantiatorClassGenerator.insertUnboxInsns has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.

D1 · Cyclomatic Complexity · DefaultValueExpressionParser.findPlaceholderEndIndex (cyclomatic 16) · ×1

DefaultValueExpressionParser.findPlaceholderEndIndex (cyclomatic 16) src/main/java/org/springframework/data/expression/DefaultValueExpressionParser.java:140 — DefaultValueExpressionParser.findPlaceholderEndIndex has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.

D1 · Cyclomatic Complexity · ReflectionUtils.getPrimitiveDefault (cyclomatic 16) · ×1

ReflectionUtils.getPrimitiveDefault (cyclomatic 16) src/main/java/org/springframework/data/util/ReflectionUtils.java:509 — ReflectionUtils.getPrimitiveDefault has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.

D2 · Cognitive Complexity · AotRepositoryCreator.contributeMethod (cognitive 36) · ×1

AotRepositoryCreator.contributeMethod (cognitive 36) src/main/java/org/springframework/data/repository/aot/generate/AotRepositoryCreator.java:250 — AotRepositoryCreator.contributeMethod has cognitive complexity 36 (threshold 15). Drivers by points: if/else 15 (23 pts), ternaries 2 (7 pts), boolean chains 6 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · BytecodeUtil.autoboxIfNeeded (cognitive 32) · ×1

BytecodeUtil.autoboxIfNeeded (cognitive 32) src/main/java/org/springframework/data/mapping/model/BytecodeUtil.java:87 — BytecodeUtil.autoboxIfNeeded has cognitive complexity 32 (threshold 15). Drivers by points: boolean chains 16, if/else 16. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.

D2 · Cognitive Complexity · InputMessageProjecting.invoke (cognitive 26) · ×1

InputMessageProjecting.invoke (cognitive 26) src/main/java/org/springframework/data/web/JsonProjectingMethodInterceptorFactory.java:137 — InputMessageProjecting.invoke has cognitive complexity 26 (threshold 15). Drivers by points: ternaries 6 (14 pts), boolean chains 4, if/else 2 (4 pts), error handling 1 (2 pts), loops 1, match/switch 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · DefaultValueExpressionParser.findPlaceholderEndIndex (cognitive 24) · ×1

DefaultValueExpressionParser.findPlaceholderEndIndex (cognitive 24) src/main/java/org/springframework/data/expression/DefaultValueExpressionParser.java:140 — DefaultValueExpressionParser.findPlaceholderEndIndex has cognitive complexity 24 (threshold 15). Drivers by points: if/else 9 (16 pts), boolean chains 4, loops 2 (4 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · InstanceCreatorMetadataDiscoverer.discover (cognitive 24) · ×1

InstanceCreatorMetadataDiscoverer.discover (cognitive 24) src/main/java/org/springframework/data/mapping/model/InstanceCreatorMetadataDiscoverer.java:62 — InstanceCreatorMetadataDiscoverer.discover has cognitive complexity 24 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 2 (6 pts), boolean chains 3 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · KotlinInstantiationDelegate.findKotlinConstructor (cognitive 24) · ×1

KotlinInstantiationDelegate.findKotlinConstructor (cognitive 24) src/main/java/org/springframework/data/mapping/model/KotlinInstantiationDelegate.java:217 — KotlinInstantiationDelegate.findKotlinConstructor has cognitive complexity 24 (threshold 15). Drivers by points: if/else 10 (21 pts), ternaries 1 (2 pts), loops 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · EntityProjectionIntrospector.getProperties (cognitive 23) · ×1

EntityProjectionIntrospector.getProperties (cognitive 23) src/main/java/org/springframework/data/projection/EntityProjectionIntrospector.java:119 — EntityProjectionIntrospector.getProperties has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (14 pts), ternaries 3 (8 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · QueryExecutionResultHandler.postProcessInvocationResult (cognitive 21) · ×1

QueryExecutionResultHandler.postProcessInvocationResult (cognitive 21) src/main/java/org/springframework/data/repository/core/support/QueryExecutionResultHandler.java:132 — QueryExecutionResultHandler.postProcessInvocationResult has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (17 pts), ternaries 2 (3 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · RepositoryMethodInvoker.<init> (cognitive 21) · ×1

RepositoryMethodInvoker.<init> (cognitive 21) src/main/java/org/springframework/data/repository/core/support/RepositoryMethodInvoker.java:63 — RepositoryMethodInvoker.<init> has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (13 pts), ternaries 3 (6 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · Parameters.<init> (cognitive 21) · ×1

Parameters.<init> (cognitive 21) src/main/java/org/springframework/data/repository/query/Parameters.java:77 — Parameters.<init> has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (18 pts), boolean chains 2, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · ResultProcessor.processResult (cognitive 20) · ×1

ResultProcessor.processResult (cognitive 20) src/main/java/org/springframework/data/repository/query/ResultProcessor.java:140 — ResultProcessor.processResult has cognitive complexity 20 (threshold 15). Drivers by points: boolean chains 7, if/else 7, ternaries 2 (4 pts), loops 1 (2 pts) (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.

D2 · Cognitive Complexity · CustomConversions.isSupportedConverter (cognitive 19) · ×1

CustomConversions.isSupportedConverter (cognitive 19) src/main/java/org/springframework/data/convert/CustomConversions.java:356 — CustomConversions.isSupportedConverter has cognitive complexity 19 (threshold 15). Drivers by points: ternaries 4 (12 pts), if/else 3 (4 pts), boolean chains 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · KotlinBeanInfoFactory.collectKotlinProperties (cognitive 19) · ×1

KotlinBeanInfoFactory.collectKotlinProperties (cognitive 19) src/main/java/org/springframework/data/util/KotlinBeanInfoFactory.java:92 — KotlinBeanInfoFactory.collectKotlinProperties has cognitive complexity 19 (threshold 15). Drivers by points: if/else 4 (12 pts), boolean chains 3, ternaries 1 (3 pts), loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · LambdaMethodVisitor.resolve (cognitive 18) · ×1

LambdaMethodVisitor.resolve (cognitive 18) src/main/java/org/springframework/data/core/SerializableLambdaReader.java:480 — LambdaMethodVisitor.resolve has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 1 (3 pts), ternaries 1 (2 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · ObjectInstantiatorClassGenerator.insertUnboxInsns (cognitive 17) · ×1

ObjectInstantiatorClassGenerator.insertUnboxInsns (cognitive 17) src/main/java/org/springframework/data/mapping/model/ClassGeneratingEntityInstantiator.java:614 — ObjectInstantiatorClassGenerator.insertUnboxInsns has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (16 pts), match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.

D2 · Cognitive Complexity · QuerydslDefaultBinding.bind (cognitive 17) · ×1

QuerydslDefaultBinding.bind (cognitive 17) src/main/java/org/springframework/data/querydsl/binding/QuerydslDefaultBinding.java:48 — QuerydslDefaultBinding.bind has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (9 pts), loops 2 (6 pts), ternaries 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · JSONTokener.readLiteral (cognitive 17) · ×1

JSONTokener.readLiteral (cognitive 17) src/main/java/org/springframework/data/repository/aot/generate/JSONTokener.java:271 — JSONTokener.readLiteral has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (11 pts), boolean chains 3, error handling 2 (3 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.

D2 · Cognitive Complexity · JSONTokener.readObject (cognitive 17) · ×1

JSONTokener.readObject (cognitive 17) src/main/java/org/springframework/data/repository/aot/generate/JSONTokener.java:346 — JSONTokener.readObject has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (12 pts), boolean chains 2, match/switch 1 (2 pts), loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · RepositoryConfigurationExtensionSupport.isStrictRepositoryCandidate (cognitive 17) · ×1

RepositoryConfigurationExtensionSupport.isStrictRepositoryCandidate (cognitive 17) src/main/java/org/springframework/data/repository/config/RepositoryConfigurationExtensionSupport.java:278 — RepositoryConfigurationExtensionSupport.isStrictRepositoryCandidate has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (10 pts), ternaries 2 (4 pts), loops 2, boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · RepositoryFactorySupport.getRepository (cognitive 17) · ×1

RepositoryFactorySupport.getRepository (cognitive 17) src/main/java/org/springframework/data/repository/core/support/RepositoryFactorySupport.java:308 — RepositoryFactorySupport.getRepository has cognitive complexity 17 (threshold 15). Drivers by points: if/else 11 (15 pts), boolean chains 1, loops 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D2 · Cognitive Complexity · Parameters.<init> (cognitive 17) · ×1

Parameters.<init> (cognitive 17) src/main/java/org/springframework/data/repository/query/Parameters.java:160 — Parameters.<init> has cognitive complexity 17 (threshold 15). Drivers by points: ternaries 8 (16 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.

D3 · God Classes · ClassTooLong · ×1

ClassTooLong: ClassGeneratingPropertyAccessorFactory src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:77 — ClassTooLong — 683 significant lines (blank, comment-only and punctuation-only lines excluded), 13 methods. The bar is 400 significant lines; this is 283 over it, 1.71× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.

D3 · God Classes · FileTooLong · ×1

FileTooLong: model/ClassGeneratingPropertyAccessorFactory.java src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java — FileTooLong — 726 significant lines (blank, comment-only and punctuation-only lines excluded), about 94% of them inside a single declaration: ClassGeneratingPropertyAccessorFactory (77-1512). The bar is 500 significant lines; this is 226 over it, 1.45× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

D4 · Code Duplication · Duplicated block (28–29 lines × 2) · ×1

Duplicated block (28–29 lines × 2) src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:828 — src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:828-855 | src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:992-1020 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:828` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (21–22 lines × 2) · ×1

Duplicated block (21–22 lines × 2) src/main/java/org/springframework/data/repository/support/DomainClassConverter.java:165 — src/main/java/org/springframework/data/repository/support/DomainClassConverter.java:165-185 | src/main/java/org/springframework/data/repository/support/DomainClassConverter.java:233-254 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.

D4 · Code Duplication · Duplicated block (19 lines × 2) · ×1

Duplicated block (19 lines × 2) src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:240 — src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:240-258 | src/main/java/org/springframework/data/util/ParameterTypes.java:241-259 — before extracting anything, compare `src/main/java/org/springframework/data/spel/spi/ParameterTypes.java` and `src/main/java/org/springframework/data/util/ParameterTypes.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 149 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.

D4 · Code Duplication · Duplicated block (13–15 lines × 2) · ×1

Duplicated block (13–15 lines × 2) src/main/java/org/springframework/data/mapping/callback/DefaultEntityCallbacks.java:112 — src/main/java/org/springframework/data/mapping/callback/DefaultEntityCallbacks.java:112-126 | src/main/java/org/springframework/data/mapping/callback/DefaultReactiveEntityCallbacks.java:115-127 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/mapping/callback/DefaultEntityCallbacks.java:112` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (14 lines × 2) · ×1

Duplicated block (14 lines × 2) src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:179 — src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:179-192 | src/main/java/org/springframework/data/util/ParameterTypes.java:180-193 — before extracting anything, compare `src/main/java/org/springframework/data/spel/spi/ParameterTypes.java` and `src/main/java/org/springframework/data/util/ParameterTypes.java` as WHOLE FILES: this scan already matched 13 separate duplicated blocks between them, totalling at least 149 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.

D4 · Code Duplication · Duplicated block (9–10 lines × 2) · ×1

Duplicated block (9–10 lines × 2) src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:1194 — src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:1194-1203 | src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:1232-1240 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:1194` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.

D4 · Code Duplication · Duplicated block (6 lines × 4) · ×1

Duplicated block (6 lines × 4) src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:885 — src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:885-890 | src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:914-919 | src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:1196-1202 | src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:1234-1239 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:885` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:1195` calls `visitVarInsn` and `src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:884` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.

D4 · Code Duplication · Duplicated block (5 lines × 3) · ×1

Duplicated block (5 lines × 3) src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:1076 — src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:1076-1081 | src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:1192-1196 | src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:1230-1234 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java:1076` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.

D4 · Code Duplication · Duplicated block (8 lines × 3) · ×1

Duplicated block (8 lines × 3) src/main/java/org/springframework/data/domain/DoubleVector.java:55 — src/main/java/org/springframework/data/domain/DoubleVector.java:55-62 | src/main/java/org/springframework/data/domain/FloatVector.java:55-62 | src/main/java/org/springframework/data/domain/NumberVector.java:58-65 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `v` to `double[]` in one and `float[]` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.

D4 · Code Duplication · Duplicated block (12 lines × 3) · ×1

Duplicated block (12 lines × 3) src/main/java/org/springframework/data/domain/DoubleVector.java:114 — src/main/java/org/springframework/data/domain/DoubleVector.java:114-125 | src/main/java/org/springframework/data/domain/FloatVector.java:114-125 | src/main/java/org/springframework/data/domain/NumberVector.java:129-140 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.

M1 · Documentation (README) · README may be stale · ×1

README may be stale — 20 code files changed in the last 6 months but the README was not touched — it may no longer reflect the system.

P12 · CI test-gate honesty · Test suite runs only after the merge · ×1

Test suite runs only after the merge — `REDACTED` run(s) the test suite, but no workflow that runs tests is triggered by a pull request (or a merge queue) — so the suite reports on code that is already on the default branch. A red build there blocks nothing and the only remedy is a revert. Add the pull-request trigger to the workflow that runs your suite so the gate applies before the merge, not after it.

X3 · Exception handling · Swallowed exception (empty catch) · ×1

Swallowed exception (empty catch) src/main/java/org/springframework/data/repository/aot/generate/JSONObject.java:833 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.

Minor — 149 finding(s)

D34 · Knowledge Freshness · Orphaned file · ×112

Orphaned file src/main/java/org/springframework/data/querydsl/binding/QuerydslBindings.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/repository/config/RepositoryConfigurationExtensionSupport.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/spel/ExtensionAwareEvaluationContextProvider.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/repository/support/Repositories.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/spel/EvaluationContextExtensionInformation.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/web/PagedResourcesAssembler.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/mapping/AccessOptions.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/mapping/model/AnnotationBasedPersistentProperty.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/repository/core/support/EventPublishingRepositoryProxyPostProcessor.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/projection/ProxyProjectionFactory.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/repository/query/ResultProcessor.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/auditing/DefaultAuditableBeanWrapperFactory.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/repository/support/ReflectionRepositoryInvoker.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/transaction/ChainedTransactionManager.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/repository/query/parser/Part.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/web/config/EnableSpringDataWebSupport.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/mapping/model/Property.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/repository/support/DomainClassConverter.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/querydsl/binding/QuerydslBindingsFactory.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/web/config/SpringDataWebConfiguration.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/mapping/model/SimplePersistentPropertyPathAccessor.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/repository/config/XmlRepositoryConfigurationSource.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/repository/config/RepositoryComponentProvider.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/config/TypeFilterParser.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/main/java/org/springframework/data/util/Streamable.java:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
+ 87 more in this group — see findings.md.

X10 · Duplicated predicate · Duplicated predicate · ×12

Duplicated predicate src/main/java/org/springframework/data/querydsl/binding/PropertyPathInformation.java:144 — `ObjectUtils.nullSafeEquals(getRootParentType(), that.getRootParentType()) && ObjectUtils.nullSafeEquals(toDotPath(), that.toDotPath())` appears character-identically in 2 files — src/main/java/org/springframework/data/querydsl/binding/PropertyPathInformation.java, src/main/java/org/springframework/data/querydsl/binding/QuerydslPathInformation.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/main/java/org/springframework/data/core/SimplePropertyPath.java:397 — `Objects.equals(this.type, that.type) && Objects.equals(this.path, that.path)` appears character-identically in 2 files — src/main/java/org/springframework/data/core/SimplePropertyPath.java, src/main/java/org/springframework/data/mapping/context/PersistentPropertyPathFactory.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/main/java/org/springframework/data/web/config/SpringDataJackson3Configuration.java:152 — `Page.class.isAssignableFrom(beanDesc.getBeanClass()) && !warningRendered` appears character-identically in 2 files — src/main/java/org/springframework/data/web/config/SpringDataJackson3Configuration.java, src/main/java/org/springframework/data/web/config/SpringDataJacksonConfiguration.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:228 — `lastDescriptor.isArray() && descriptor.equals(lastDescriptor.getElementTypeDescriptor())` appears character-identically in 2 files — src/main/java/org/springframework/data/spel/spi/ParameterTypes.java, src/main/java/org/springframework/data/util/ParameterTypes.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/main/java/org/springframework/data/mapping/callback/DefaultEntityCallbacks.java:119 — `msg == null || EntityCallbackInvoker.matchesClassCastMessage(msg, entity.getClass())` appears character-identically in 2 files — src/main/java/org/springframework/data/mapping/callback/DefaultEntityCallbacks.java, src/main/java/org/springframework/data/mapping/callback/DefaultReactiveEntityCallbacks.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/main/java/org/springframework/data/repository/core/support/DefaultCrudMethods.java:242 — `paramTypes.length == method.getParameterCount() && Arrays.equals(paramTypes, method.getParameterTypes())` appears character-identically in 2 files — src/main/java/org/springframework/data/repository/core/support/DefaultCrudMethods.java, src/main/java/org/springframework/data/util/ReflectionUtils.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/main/java/org/springframework/data/mapping/model/InstanceCreatorMetadataDiscoverer.java:150 — `parameterNames == null || parameterNames.length <= i` appears character-identically in 2 files — src/main/java/org/springframework/data/mapping/model/InstanceCreatorMetadataDiscoverer.java, src/main/java/org/springframework/data/mapping/model/PreferredConstructorDiscoverer.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/main/java/org/springframework/data/spel/spi/ParameterTypes.java:133 — `parent != null && parent.hasValidAlternativeFor(method)` appears character-identically in 2 files — src/main/java/org/springframework/data/spel/spi/ParameterTypes.java, src/main/java/org/springframework/data/util/ParameterTypes.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/main/java/org/springframework/data/web/ProjectingJackson2HttpMessageConverter.java:122 — `rawType.isInterface() && AnnotationUtils.findAnnotation(rawType, ProjectedPayload.class) != null` appears character-identically in 2 files — src/main/java/org/springframework/data/web/ProjectingJackson2HttpMessageConverter.java, src/main/java/org/springframework/data/web/XmlBeamHttpMessageConverter.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/main/java/org/springframework/data/web/config/SpringDataJackson3Configuration.java:93 — `settings == null || settings.pageSerializationMode() == PageSerializationMode.DIRECT` appears character-identically in 2 files — src/main/java/org/springframework/data/web/config/SpringDataJackson3Configuration.java, src/main/java/org/springframework/data/web/config/SpringDataJacksonConfiguration.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/main/java/org/springframework/data/core/NullableWrapperConverters.java:187 — `source == null || !supports(source.getClass())` appears character-identically in 2 files — src/main/java/org/springframework/data/core/NullableWrapperConverters.java, src/main/java/org/springframework/data/repository/util/QueryExecutionConverters.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/main/java/org/springframework/data/repository/query/ResultProcessor.java:234 — `source == null || targetType.isInstance(source)` appears character-identically in 2 files — src/main/java/org/springframework/data/repository/query/ResultProcessor.java, REDACTED. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.

AX6 · Interface segregation · Fat interface · ×7

Fat interface: TypeInformation<S> (16 abstract methods) src/main/java/org/springframework/data/core/TypeInformation.java:44 — `TypeInformation<S>` declares 16 abstract methods under just 15 distinct name(s): `getActualType`, `getComponentType`, `getMapValueType`, `getParameterTypes`, `getParameterTypes`, `getProperty`, `getRawTypeInformation`, `getReturnType`, `getSuperTypeInformation`, `getType`, `getTypeArguments`, `isAssignableFrom`, `isCollectionLike`, `isMap`, `toResolvableType`, `toTypeDescriptor`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: PersistentEntity<T, P> (28 abstract methods) src/main/java/org/springframework/data/mapping/PersistentEntity.java:38 — `PersistentEntity<T, P>` declares 28 abstract methods: `doWithAssociations`, `doWithAssociations`, `doWithProperties`, `doWithProperties`, `findAnnotation`, `getIdProperty`, `getIdentifierAccessor`, `getInstanceCreatorMetadata`, `getName`, `getPersistentProperties`, `getPersistentProperty`, `getPropertyAccessor`, `getPropertyPathAccessor`, `getTransientProperty`, `getType`, `getTypeAlias`, `getTypeInformation`, `getVersionProperty`, `hasIdProperty`, `hasVersionProperty`, `isAnnotationPresent`, `isCreatorArgument`, `isIdProperty`, `isImmutable`, `isNew`, `isTransient`, `isVersionProperty`, `requiresPropertyPopulation`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 28 declarations carry 26 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 26 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: PersistentProperty<P> (32 abstract methods) src/main/java/org/springframework/data/mapping/PersistentProperty.java:40 — `PersistentProperty<P>` declares 32 abstract methods: `findAnnotation`, `findPropertyOrOwnerAnnotation`, `getActualType`, `getAssociation`, `getAssociationTargetType`, `getAssociationTargetTypeInformation`, `getComponentType`, `getField`, `getGetter`, `getMapValueType`, `getName`, `getOwner`, `getPersistentEntityTypeInformation`, `getRawType`, `getSetter`, `getSpelExpression`, `getType`, `getTypeInformation`, `getWither`, `isAnnotationPresent`, `isArray`, `isAssociation`, `isCollectionLike`, `isEntity`, `isIdProperty`, `isImmutable`, `isMap`, `isReadable`, `isTransient`, `isVersionProperty`, `isWritable`, `usePropertyAccess`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: RepositoryConfiguration<T> (18 abstract methods) src/main/java/org/springframework/data/repository/config/RepositoryConfiguration.java:33 — `RepositoryConfiguration<T>` declares 18 abstract methods: `getBasePackages`, `getConfigurationSource`, `getExcludeFilters`, `getImplementationBasePackages`, `getImplementationBeanName`, `getNamedQueriesLocation`, `getQueryLookupStrategyKey`, `getRepositoryBaseClassName`, `getRepositoryBeanName`, `getRepositoryFactoryBeanClassName`, `getRepositoryFragmentsContributorClassName`, `getRepositoryInterface`, `getResourceDescription`, `getSource`, `isLazyInit`, `isPrimary`, `toImplementationDetectionConfiguration`, `toLookupConfiguration`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: RepositoryConfigurationSource (17 abstract methods) src/main/java/org/springframework/data/repository/config/RepositoryConfigurationSource.java:40 — `RepositoryConfigurationSource` declares 17 abstract methods: `generateBeanName`, `getAttribute`, `getAttribute`, `getBasePackages`, `getBootstrapMode`, `getCandidates`, `getExcludeFilters`, `getNamedQueryLocation`, `getQueryLookupStrategyKey`, `getRepositoryBaseClassName`, `getRepositoryFactoryBeanClassName`, `getRepositoryFragmentsContributorClassName`, `getRepositoryImplementationPostfix`, `getResourceDescription`, `getSource`, `toImplementationDetectionConfiguration`, `usesExplicitFilters`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 17 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: ReactiveCrudRepository<T, ID> (18 abstract methods) src/main/java/org/springframework/data/repository/reactive/ReactiveCrudRepository.java:49 — `ReactiveCrudRepository<T, ID>` declares 18 abstract methods under just 11 distinct name(s): `count`, `delete`, `deleteAll`, `deleteAll`, `deleteAll`, `deleteAllById`, `deleteById`, `deleteById`, `existsById`, `existsById`, `findAll`, `findAllById`, `findAllById`, `findById`, `findById`, `save`, `saveAll`, `saveAll`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 18 separate responsibilities: a caller binds to 11 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 18 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: RxJava3CrudRepository<T, ID> (17 abstract methods) src/main/java/org/springframework/data/repository/reactive/RxJava3CrudRepository.java:49 — `RxJava3CrudRepository<T, ID>` declares 17 abstract methods under just 11 distinct name(s): `count`, `delete`, `deleteAll`, `deleteAll`, `deleteAll`, `deleteAllById`, `deleteById`, `existsById`, `existsById`, `findAll`, `findAllById`, `findAllById`, `findById`, `findById`, `save`, `saveAll`, `saveAll`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 11 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.

IC1 · Incompleteness & stubs · Disabled test · ×3

Disabled test src/test/java/org/springframework/data/DependencyTests.java:39 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
Disabled test src/test/java/org/springframework/data/projection/ProxyProjectionFactoryUnitTests.java:350 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
Disabled test src/test/java/org/springframework/data/repository/aot/GeneratedClassesCaptureIntegrationTests.java:66 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.

IC1 · Incompleteness & stubs · Blanket warning suppression · ×2

Blanket warning suppression src/main/java/org/springframework/data/repository/cdi/CdiRepositoryExtensionSupport.java:198 — `@SuppressWarnings("all")` switches every compiler and analyser warning off for the whole declaration — hidden debt. Suppress the specific warning on the specific member, with a justification, instead.
Blanket warning suppression src/main/java/org/springframework/data/repository/cdi/CdiRepositoryExtensionSupport.java:205 — `@SuppressWarnings("all")` switches every compiler and analyser warning off for the whole declaration — hidden debt. Suppress the specific warning on the specific member, with a justification, instead.

D16 · Bus Factor · Off-boarding risk · ×1

Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 19 significant file(s) lose their only recent owner: src/main/java/org/springframework/data/mapping/model/ClassGeneratingPropertyAccessorFactory.java, src/main/java/org/springframework/data/javapoet/LordOfTheStrings.java, src/main/java/org/springframework/data/mapping/model/ClassGeneratingEntityInstantiator.java, src/main/java/org/springframework/data/repository/core/support/RepositoryComposition.java, src/main/java/org/springframework/data/repository/util/QueryExecutionConverters.java, src/main/java/org/springframework/data/repository/config/AnnotationRepositoryConfigurationSource.java, src/main/java/org/springframework/data/core/TypeInformation.java, src/main/java/org/springframework/data/repository/query/FluentQuery.java (+11 more). Pair on, review, or document these before any departure.

D16 · Bus Factor · Further sole-owners (lower concentration) · ×1

Further sole-owners (lower concentration) — 1 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (20 single-owned of 400 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 400 of the 656 production source files in this repository met that bar). They are anonymized user #2 (1 file(s)) — spread or document their files in the same way, at lower priority than the named off-boarding risks above. The files folded here: src/main/java/org/springframework/data/convert/SimpleTypeInformationMapper.java.

D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1

Projects may be oversized for their cohesion — 1 of 1 project(s) overshoot their size bounds, lowering Project Cohesion to 0.0/10. The most over is `(repository root)` (79598 LoC, 642 module-visible types across 48 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.

D34 · Knowledge Freshness · Further orphaned files (smaller) · ×1

Further orphaned files (smaller) — 112 smaller file(s) also have no living knowledge — folded into the freshness score and metrics rather than raised one row each — most significant first: src/main/java/org/springframework/data/querydsl/binding/QuerydslBindings.java, src/main/java/org/springframework/data/repository/config/RepositoryConfigurationExtensionSupport.java, src/main/java/org/springframework/data/spel/ExtensionAwareEvaluationContextProvider.java, src/main/java/org/springframework/data/repository/support/Repositories.java, src/main/java/org/springframework/data/spel/EvaluationContextExtensionInformation.java, src/main/java/org/springframework/data/domain/Slice.java, src/main/java/org/springframework/data/web/PagedResourcesAssembler.java, src/main/java/org/springframework/data/mapping/AccessOptions.java (and 104 more) (113 orphaned of 400 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 400 of the 656 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

D36 · Supply-chain Provenance & Signing · REDACTED · ×1

REDACTED

M2 · Architecture documentation · No ADRs · ×1

No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

M2 · Architecture documentation · No architecture diagram/doc · ×1

No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.

P6 · Release Hygiene · No changelog · ×1

No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)

PF1 · Benchmark discipline · Benchmarks don't track allocations · ×1

Benchmarks don't track allocations src/jmh/java/org/springframework/data/core/TypedPropertyPathBenchmarks.java — A JMH/Jetpack Benchmark suite exists but nothing turns on its allocation measurement — allocations (the main way hot code pressures a garbage collector or allocator) aren't being measured.

X5 · Nullable reference types · Java packages are not null-marked everywhere · ×1

Java packages are not null-marked everywhere — 46/47 of this repository's Java package directories are under a non-null default: a `package-info.java` declaring `@NullMarked` (JSpecify) or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, `@DefaultQualifier(NonNull.class)`; a `module-info.java` declaring `@NullMarked`; every type in it `@NullMarked`; or a build that runs NullAway with the package in `AnnotatedPackages`, or the Checker Framework's `NullnessChecker`. Elsewhere every reference admits null and no checker warns on the dereference that throws a `NullPointerException`.

Minor — 2 finding(s)

D10 · Test Quality · Skipped (documented) · ×2

Skipped (documented): projectionFactoryConsidersKotlinNullabilityConstraints src/test/java/org/springframework/data/projection/ProxyProjectionFactoryUnitTests.java:351 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled
Skipped (documented): registersGeneratedPropertyAccessorsEntityInstantiatorsForCyclicProperties src/test/java/org/springframework/data/repository/aot/GeneratedClassesCaptureIntegrationTests.java:67 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Disabled

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

Dimension	Tool	Version	Command	Findings	Raw output
D28 · Secrets (history)	gitleaks	—	gitleaks detect --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-34f0e83e11d2444e84fe2f9edff87429/history.json --exit-code 0 --source .	0	artifacts/raw/gitleaks-history.json
D28 · Secrets (history)	gitleaks	—	gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-34f0e83e11d2444e84fe2f9edff87429/tree.json --exit-code 0 --source .	0	artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)	semgrep	—	semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/watchdog-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off .	27	artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilities	osv-scanner	—	osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm .	0	artifacts/raw/osv-scanner.json
D31 · IaC & Container Security	trivy	—	trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.	0	—
D32 · Data Compliance (PII/GDPR)	semgrep	—	semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.	0	—
D37 · Vulnerability-disclosure Policy	disclosure	—	disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.	0	—
D40 · Network Egress Confinement	runtime-hardening	—	runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.	0	—
D41 · Kernel & Syscall Confinement	runtime-hardening	—	runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.	0	—
D42 · Runtime Threat Enforcement	runtime-hardening	—	runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.	0	—
D43 · Malicious Dependencies	osv-scanner	—	osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm .	0	artifacts/raw/osv-scanner.json

Run 01a164d0-9d52-7127-bd1a-19b300a2ef4e · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Findings by how serious they are

This survey was produced by

Executive summary

Top priorities

Diagnosis: what the measurements show together

Architecture: which parts of the code depend on which

At a glance — Code Health · 86% · Strong ·

At a glance — Architecture · 75% · Adequate · gated by D26 ·

At a glance — Maturity · 46% · Weak · gated by M2 ·

At a glance — Readiness · 63% · Adequate ·

At a glance — Security · 51% · Adequate · gated by D29, D36 ·

At a glance — Domain Modelling · 100% · Exemplary ·

At a glance — Performance · 78% · Strong ·

Security & Compliance — OWASP Top-10 mapping

Roadmap

File quality

How the grades work

Methodology & how to trust this report

Tools & methods

Run transparency — what happened this run

Limitations & what we did not check

Per-dimension blind spots

The LLM boundary

Dimensions

Frontend & cross-cutting dimensions

Reference — by lens

Appendix A — Findings (grouped)

Appendix B — Reproduction & audit trail

Downloadable artifacts