Public report of thunderbird/thunderbird-android, published 24 October 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Watchdog signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 24 October 2026, 22:13 UTC · Survey ID cd_77ee153514c3461f88e2c0cac0ceebf5
thunderbird/thunderbird-android
Measured 24 October 2026, 21:49 UTC, at code version de8a032
A regression is a drop of 0.5 points or more in the score, or of 2.5 or more out of 10 in a dimension, since the last survey.
Test reliability is not measured: The suite could not be re-run, but the repository declares tests of its own unreliable.
CAI scoreAdequate
CriticalWeakAdequateStrongExemplary
Down 6 since the last survey
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A large codebase: 203,880 lines of product code in 154 projects, tests not counted · Estimated rebuild effort: about 3.4 person-years · Weakest lens: Accessibility, 40
Findings by how serious they are
23 critical741 serious297 minor
15 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
24 October 2026, 21:49 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that
implements it, and today Watchdog is the only one that does.
The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
75of 81 dimensions measured by tools. The other 6 are advisory notes from an AI model, which explain the code but don't count towards the score.
1003of 1061 findings point to an exact file and line, so you can open each one in the code. The other 58 concern the repository as a whole, such as missing documentation.
81dimensions across 8 lenses, read from 203,880 lines of product code in 154 projects.
thunderbird/thunderbird-android scores 58 out of 100 and is rated Adequate, while seven of its eight lenses score higher still: Architecture at 95, rated Exemplary, Code Health and Domain Modelling at 87, Maturity at 84 and Security and Compliance and Performance at 80, all rated Strong, and Production Readiness at 65, rated Adequate.
The score is lower than those seven because the weakest lens counts most, and here that is Accessibility, which scores 40 and is rated Weak. Its Keyboard semantics dimension scores 1 out of 10, and until that reaches 4, Accessibility can't be rated higher than Adequate. The first actions are to resolve the 1 Leaked secret finding(s) in Secret Scanning and to make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href, and if Accessibility rose to 70, the score would rise from 58 to about 71.
23 findings are critical: seven in Knowledge Freshness, four in Change Coupling, three in Secrets (history), three in Static Analysis (SAST), one in Coupling, one in Keyboard semantics, one in Page structure, one in Project dependency cycles, one in Secret Scanning and one in Test Reliability.
Watchdog couldn't measure 14 dimensions in this code, among them Code Coverage, Dependency Hygiene and License Compliance, so they are left out of the score. The product code is 203,880 lines, which would take an estimated 3.4 person-years, around €490,000, to rebuild.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Visual & motion safety · Focus outline removed in CSS without a :focus replacement docs/assets/tb-theme/css/general.css
Visual & motion safety · Animation without a prefers-reduced-motion guard docs/assets/tb-theme/css/chrome.css
Visual & motion safety · Animation without a prefers-reduced-motion guard docs/assets/tb-theme/css/chrome.css
Visual & motion safety · Animation without a prefers-reduced-motion guard docs/assets/tb-theme/css/chrome.css
Visual & motion safety · Animation without a prefers-reduced-motion guard docs/assets/tb-theme/css/general.css
Visual & motion safety · Animation without a prefers-reduced-motion guard docs/assets/tb-theme/css/general.css
Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.
Fixed since the last survey: 42 findings
These 42 critical or serious findings were in the previous survey, on 10 October 2026, and are gone from this one.
God Classes · ClassTooLong: LegacyAccountDto core/android/account/src/main/kotlin/net/thunderbird/core/android/account/LegacyAccountDto.kt
God Classes · TooManyMethods: MessagingControllerWrapper legacy/core/src/main/java/com/fsck/k9/controller/MessagingControllerWrapper.kt
Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsViewModel.kt
€160,000 to €820,000, for 2,723 to 8,640 hours of work, about 3.4 person-years for 2 to 7 engineers
Difficulty of the problem
High, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.8 at a score of 58. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Large: 203,880 lines of product code
How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Resolve the 1 Leaked secret finding(s) in Secret Scanning — start with REDACTED.
Raises the score by about 4 points · Low effort · Secret Scanning
2
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €490,000 to build again, about 3.4 person-years of work. Its weakest lens is Accessibility, at 40 (Weak). Accessibility is about whether the interface is built so that everyone can use it, including people who can't see the screen or can't use a mouse. Because the weakest lens counts most in the score, work on Accessibility also moves the score most.
Based on: the rebuild estimate · the Accessibility grade · how much each lens counts
What to do: Start with the Accessibility actions in Top priorities.
If you do one thing first · First action
Resolve the 1 Leaked secret finding(s) in Secret Scanning. Of all the actions in this report, it raises the score most for the work it takes: about 4 points for low effort, because it clears the 1 Secret Scanning findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture — module dependency graph
Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways — a layering smell or cycle. A clean layered graph has none.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
1518 modules, with 2725 dependencies between them. 26 loops run through 117 of the modules, marked above the diagonal.
The table shows the 40 modules with the most connections; 1478 more are left out to keep it readable.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
com.fsck.k9.mail uses net.thunderbird.core.common.mail, so a change to net.thunderbird.core.common.mail can break com.fsck.k9.mail, while a change to com.fsck.k9.mail can't break net.thunderbird.core.common.mail.
Position
Below the diagonal: com.fsck.k9.mail uses a module listed above it, which is the healthy direction.
com.fsck.k9.mail uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break com.fsck.k9.mail, while a change to com.fsck.k9.mail can't break net.thunderbird.feature.account.
Position
Below the diagonal: com.fsck.k9.mail uses a module listed above it, which is the healthy direction.
com.fsck.k9.message.html uses net.thunderbird.core.featureflag, so a change to net.thunderbird.core.featureflag can break com.fsck.k9.message.html, while a change to com.fsck.k9.message.html can't break net.thunderbird.core.featureflag.
Position
Below the diagonal: com.fsck.k9.message.html uses a module listed above it, which is the healthy direction.
net.thunderbird.core.preference.display.visualSettings.message.list uses net.thunderbird.core.preference, so a change to net.thunderbird.core.preference can break net.thunderbird.core.preference.display.visualSettings.message.list, while a change to net.thunderbird.core.preference.display.visualSettings.message.list can't break net.thunderbird.core.preference.
Position
Below the diagonal: net.thunderbird.core.preference.display.visualSettings.message.list uses a module listed above it, which is the healthy direction.
2 pairs of types, where a type in net.thunderbird.core.preference.display.visualSettings.message.list uses a type in net.thunderbird.core.preference.storage.
net.thunderbird.core.preference.display.visualSettings.message.list uses net.thunderbird.core.preference.storage, so a change to net.thunderbird.core.preference.storage can break net.thunderbird.core.preference.display.visualSettings.message.list, while a change to net.thunderbird.core.preference.display.visualSettings.message.list can't break net.thunderbird.core.preference.storage.
Position
Below the diagonal: net.thunderbird.core.preference.display.visualSettings.message.list uses a module listed above it, which is the healthy direction.
net.thunderbird.feature.account.avatar uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break net.thunderbird.feature.account.avatar, while a change to net.thunderbird.feature.account.avatar can't break net.thunderbird.feature.account.
Position
Below the diagonal: net.thunderbird.feature.account.avatar uses a module listed above it, which is the healthy direction.
net.thunderbird.feature.mail.folder.api uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break net.thunderbird.feature.mail.folder.api, while a change to net.thunderbird.feature.mail.folder.api can't break net.thunderbird.feature.account.
Position
Below the diagonal: net.thunderbird.feature.mail.folder.api uses a module listed above it, which is the healthy direction.
net.thunderbird.feature.mail.message.list.ui.state uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break net.thunderbird.feature.mail.message.list.ui.state, while a change to net.thunderbird.feature.mail.message.list.ui.state can't break net.thunderbird.feature.account.
Position
Below the diagonal: net.thunderbird.feature.mail.message.list.ui.state uses a module listed above it, which is the healthy direction.
net.thunderbird.feature.notification.api.content uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break net.thunderbird.feature.notification.api.content, while a change to net.thunderbird.feature.notification.api.content can't break net.thunderbird.feature.account.
Position
Below the diagonal: net.thunderbird.feature.notification.api.content uses a module listed above it, which is the healthy direction.
20→26 net.thunderbird.feature.notification.api.content uses net.thunderbird.feature.notification.apipart of a loop✕
Connections
13 pairs of types, where a type in net.thunderbird.feature.notification.api.content uses a type in net.thunderbird.feature.notification.api.
net.thunderbird.feature.notification.api.content uses net.thunderbird.feature.notification.api, so a change to net.thunderbird.feature.notification.api can break net.thunderbird.feature.notification.api.content, while a change to net.thunderbird.feature.notification.api.content can't break net.thunderbird.feature.notification.api.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
net.thunderbird.feature.search.legacy uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break net.thunderbird.feature.search.legacy, while a change to net.thunderbird.feature.search.legacy can't break net.thunderbird.feature.account.
Position
Below the diagonal: net.thunderbird.feature.search.legacy uses a module listed above it, which is the healthy direction.
app.k9mail.feature.account.common.domain.entity uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break app.k9mail.feature.account.common.domain.entity, while a change to app.k9mail.feature.account.common.domain.entity can't break net.thunderbird.feature.account.
Position
Below the diagonal: app.k9mail.feature.account.common.domain.entity uses a module listed above it, which is the healthy direction.
app.k9mail.feature.account.common.domain.entity uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break app.k9mail.feature.account.common.domain.entity, while a change to app.k9mail.feature.account.common.domain.entity can't break com.fsck.k9.mail.
Position
Below the diagonal: app.k9mail.feature.account.common.domain.entity uses a module listed above it, which is the healthy direction.
app.k9mail.legacy.message.controller uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break app.k9mail.legacy.message.controller, while a change to app.k9mail.legacy.message.controller can't break net.thunderbird.feature.account.
Position
Below the diagonal: app.k9mail.legacy.message.controller uses a module listed above it, which is the healthy direction.
app.k9mail.legacy.message.controller uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break app.k9mail.legacy.message.controller, while a change to app.k9mail.legacy.message.controller can't break com.fsck.k9.mail.
Position
Below the diagonal: app.k9mail.legacy.message.controller uses a module listed above it, which is the healthy direction.
app.k9mail.legacy.message.controller uses net.thunderbird.feature.search.legacy, so a change to net.thunderbird.feature.search.legacy can break app.k9mail.legacy.message.controller, while a change to app.k9mail.legacy.message.controller can't break net.thunderbird.feature.search.legacy.
Position
Below the diagonal: app.k9mail.legacy.message.controller uses a module listed above it, which is the healthy direction.
com.fsck.k9.mail.store.imap uses net.thunderbird.core.common.mail, so a change to net.thunderbird.core.common.mail can break com.fsck.k9.mail.store.imap, while a change to com.fsck.k9.mail.store.imap can't break net.thunderbird.core.common.mail.
Position
Below the diagonal: com.fsck.k9.mail.store.imap uses a module listed above it, which is the healthy direction.
com.fsck.k9.mail.store.imap uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break com.fsck.k9.mail.store.imap, while a change to com.fsck.k9.mail.store.imap can't break com.fsck.k9.mail.
Position
Below the diagonal: com.fsck.k9.mail.store.imap uses a module listed above it, which is the healthy direction.
net.thunderbird.core.android.account uses net.thunderbird.core.preference.storage, so a change to net.thunderbird.core.preference.storage can break net.thunderbird.core.android.account, while a change to net.thunderbird.core.android.account can't break net.thunderbird.core.preference.storage.
Position
Below the diagonal: net.thunderbird.core.android.account uses a module listed above it, which is the healthy direction.
net.thunderbird.core.android.account uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break net.thunderbird.core.android.account, while a change to net.thunderbird.core.android.account can't break net.thunderbird.feature.account.
Position
Below the diagonal: net.thunderbird.core.android.account uses a module listed above it, which is the healthy direction.
net.thunderbird.core.android.account uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break net.thunderbird.core.android.account, while a change to net.thunderbird.core.android.account can't break com.fsck.k9.mail.
Position
Below the diagonal: net.thunderbird.core.android.account uses a module listed above it, which is the healthy direction.
net.thunderbird.core.android.account uses net.thunderbird.feature.mail.folder.api, so a change to net.thunderbird.feature.mail.folder.api can break net.thunderbird.core.android.account, while a change to net.thunderbird.core.android.account can't break net.thunderbird.feature.mail.folder.api.
Position
Below the diagonal: net.thunderbird.core.android.account uses a module listed above it, which is the healthy direction.
net.thunderbird.feature.notification.api uses net.thunderbird.feature.notification.api.content, so a change to net.thunderbird.feature.notification.api.content can break net.thunderbird.feature.notification.api, while a change to net.thunderbird.feature.notification.api can't break net.thunderbird.feature.notification.api.content.
Position
Below the diagonal: net.thunderbird.feature.notification.api uses a module listed above it, which is the healthy direction.
app.k9mail.legacy.mailstore uses net.thunderbird.core.common.mail, so a change to net.thunderbird.core.common.mail can break app.k9mail.legacy.mailstore, while a change to app.k9mail.legacy.mailstore can't break net.thunderbird.core.common.mail.
Position
Below the diagonal: app.k9mail.legacy.mailstore uses a module listed above it, which is the healthy direction.
app.k9mail.legacy.mailstore uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break app.k9mail.legacy.mailstore, while a change to app.k9mail.legacy.mailstore can't break net.thunderbird.feature.account.
Position
Below the diagonal: app.k9mail.legacy.mailstore uses a module listed above it, which is the healthy direction.
app.k9mail.legacy.mailstore uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break app.k9mail.legacy.mailstore, while a change to app.k9mail.legacy.mailstore can't break com.fsck.k9.mail.
Position
Below the diagonal: app.k9mail.legacy.mailstore uses a module listed above it, which is the healthy direction.
app.k9mail.legacy.mailstore uses net.thunderbird.feature.mail.folder.api, so a change to net.thunderbird.feature.mail.folder.api can break app.k9mail.legacy.mailstore, while a change to app.k9mail.legacy.mailstore can't break net.thunderbird.feature.mail.folder.api.
Position
Below the diagonal: app.k9mail.legacy.mailstore uses a module listed above it, which is the healthy direction.
app.k9mail.legacy.mailstore uses net.thunderbird.feature.search.legacy, so a change to net.thunderbird.feature.search.legacy can break app.k9mail.legacy.mailstore, while a change to app.k9mail.legacy.mailstore can't break net.thunderbird.feature.search.legacy.
Position
Below the diagonal: app.k9mail.legacy.mailstore uses a module listed above it, which is the healthy direction.
app.k9mail.legacy.mailstore uses net.thunderbird.core.android.account, so a change to net.thunderbird.core.android.account can break app.k9mail.legacy.mailstore, while a change to app.k9mail.legacy.mailstore can't break net.thunderbird.core.android.account.
Position
Below the diagonal: app.k9mail.legacy.mailstore uses a module listed above it, which is the healthy direction.
com.fsck.k9.message uses net.thunderbird.core.preference, so a change to net.thunderbird.core.preference can break com.fsck.k9.message, while a change to com.fsck.k9.message can't break net.thunderbird.core.preference.
Position
Below the diagonal: com.fsck.k9.message uses a module listed above it, which is the healthy direction.
com.fsck.k9.message uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break com.fsck.k9.message, while a change to com.fsck.k9.message can't break com.fsck.k9.mail.
Position
Below the diagonal: com.fsck.k9.message uses a module listed above it, which is the healthy direction.
com.fsck.k9.message uses app.k9mail.legacy.message.controller, so a change to app.k9mail.legacy.message.controller can break com.fsck.k9.message, while a change to com.fsck.k9.message can't break app.k9mail.legacy.message.controller.
Position
Below the diagonal: com.fsck.k9.message uses a module listed above it, which is the healthy direction.
com.fsck.k9.message uses net.thunderbird.core.android.account, so a change to net.thunderbird.core.android.account can break com.fsck.k9.message, while a change to com.fsck.k9.message can't break net.thunderbird.core.android.account.
Position
Below the diagonal: com.fsck.k9.message uses a module listed above it, which is the healthy direction.
28→40 com.fsck.k9.message uses com.fsck.k9part of a loop✕
Connections
3 pairs of types, where a type in com.fsck.k9.message uses a type in com.fsck.k9.
com.fsck.k9.message uses com.fsck.k9, so a change to com.fsck.k9 can break com.fsck.k9.message, while a change to com.fsck.k9.message can't break com.fsck.k9.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
com.fsck.k9.ui.settings uses com.fsck.k9.ui.base, so a change to com.fsck.k9.ui.base can break com.fsck.k9.ui.settings, while a change to com.fsck.k9.ui.settings can't break com.fsck.k9.ui.base.
Position
Below the diagonal: com.fsck.k9.ui.settings uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.settings uses net.thunderbird.core.common.provider, so a change to net.thunderbird.core.common.provider can break com.fsck.k9.ui.settings, while a change to com.fsck.k9.ui.settings can't break net.thunderbird.core.common.provider.
Position
Below the diagonal: com.fsck.k9.ui.settings uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.settings uses net.thunderbird.core.ui.contract.mvi, so a change to net.thunderbird.core.ui.contract.mvi can break com.fsck.k9.ui.settings, while a change to com.fsck.k9.ui.settings can't break net.thunderbird.core.ui.contract.mvi.
Position
Below the diagonal: com.fsck.k9.ui.settings uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.settings uses net.thunderbird.core.ui.theme.api, so a change to net.thunderbird.core.ui.theme.api can break com.fsck.k9.ui.settings, while a change to com.fsck.k9.ui.settings can't break net.thunderbird.core.ui.theme.api.
Position
Below the diagonal: com.fsck.k9.ui.settings uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.settings uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break com.fsck.k9.ui.settings, while a change to com.fsck.k9.ui.settings can't break net.thunderbird.feature.account.
Position
Below the diagonal: com.fsck.k9.ui.settings uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.settings uses net.thunderbird.core.android.account, so a change to net.thunderbird.core.android.account can break com.fsck.k9.ui.settings, while a change to com.fsck.k9.ui.settings can't break net.thunderbird.core.android.account.
Position
Below the diagonal: com.fsck.k9.ui.settings uses a module listed above it, which is the healthy direction.
com.fsck.k9.controller uses net.thunderbird.core.common.mail, so a change to net.thunderbird.core.common.mail can break com.fsck.k9.controller, while a change to com.fsck.k9.controller can't break net.thunderbird.core.common.mail.
Position
Below the diagonal: com.fsck.k9.controller uses a module listed above it, which is the healthy direction.
com.fsck.k9.controller uses net.thunderbird.core.featureflag, so a change to net.thunderbird.core.featureflag can break com.fsck.k9.controller, while a change to com.fsck.k9.controller can't break net.thunderbird.core.featureflag.
Position
Below the diagonal: com.fsck.k9.controller uses a module listed above it, which is the healthy direction.
com.fsck.k9.controller uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break com.fsck.k9.controller, while a change to com.fsck.k9.controller can't break net.thunderbird.feature.account.
Position
Below the diagonal: com.fsck.k9.controller uses a module listed above it, which is the healthy direction.
com.fsck.k9.controller uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break com.fsck.k9.controller, while a change to com.fsck.k9.controller can't break com.fsck.k9.mail.
Position
Below the diagonal: com.fsck.k9.controller uses a module listed above it, which is the healthy direction.
com.fsck.k9.controller uses net.thunderbird.feature.mail.folder.api, so a change to net.thunderbird.feature.mail.folder.api can break com.fsck.k9.controller, while a change to com.fsck.k9.controller can't break net.thunderbird.feature.mail.folder.api.
Position
Below the diagonal: com.fsck.k9.controller uses a module listed above it, which is the healthy direction.
com.fsck.k9.controller uses net.thunderbird.feature.notification.api.content, so a change to net.thunderbird.feature.notification.api.content can break com.fsck.k9.controller, while a change to com.fsck.k9.controller can't break net.thunderbird.feature.notification.api.content.
Position
Below the diagonal: com.fsck.k9.controller uses a module listed above it, which is the healthy direction.
com.fsck.k9.controller uses net.thunderbird.feature.search.legacy, so a change to net.thunderbird.feature.search.legacy can break com.fsck.k9.controller, while a change to com.fsck.k9.controller can't break net.thunderbird.feature.search.legacy.
Position
Below the diagonal: com.fsck.k9.controller uses a module listed above it, which is the healthy direction.
com.fsck.k9.controller uses app.k9mail.legacy.message.controller, so a change to app.k9mail.legacy.message.controller can break com.fsck.k9.controller, while a change to com.fsck.k9.controller can't break app.k9mail.legacy.message.controller.
Position
Below the diagonal: com.fsck.k9.controller uses a module listed above it, which is the healthy direction.
com.fsck.k9.controller uses net.thunderbird.core.android.account, so a change to net.thunderbird.core.android.account can break com.fsck.k9.controller, while a change to com.fsck.k9.controller can't break net.thunderbird.core.android.account.
Position
Below the diagonal: com.fsck.k9.controller uses a module listed above it, which is the healthy direction.
com.fsck.k9.controller uses net.thunderbird.feature.notification.api, so a change to net.thunderbird.feature.notification.api can break com.fsck.k9.controller, while a change to com.fsck.k9.controller can't break net.thunderbird.feature.notification.api.
Position
Below the diagonal: com.fsck.k9.controller uses a module listed above it, which is the healthy direction.
com.fsck.k9.controller uses app.k9mail.legacy.mailstore, so a change to app.k9mail.legacy.mailstore can break com.fsck.k9.controller, while a change to com.fsck.k9.controller can't break app.k9mail.legacy.mailstore.
Position
Below the diagonal: com.fsck.k9.controller uses a module listed above it, which is the healthy direction.
30→31 com.fsck.k9.controller uses com.fsck.k9.mailstorepart of a loop✕
Connections
11 pairs of types, where a type in com.fsck.k9.controller uses a type in com.fsck.k9.mailstore.
com.fsck.k9.controller uses com.fsck.k9.mailstore, so a change to com.fsck.k9.mailstore can break com.fsck.k9.controller, while a change to com.fsck.k9.controller can't break com.fsck.k9.mailstore.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
30→38 com.fsck.k9.controller uses com.fsck.k9.notificationpart of a loop✕
Connections
3 pairs of types, where a type in com.fsck.k9.controller uses a type in com.fsck.k9.notification.
com.fsck.k9.controller uses com.fsck.k9.notification, so a change to com.fsck.k9.notification can break com.fsck.k9.controller, while a change to com.fsck.k9.controller can't break com.fsck.k9.notification.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
com.fsck.k9.mailstore uses net.thunderbird.core.common.mail, so a change to net.thunderbird.core.common.mail can break com.fsck.k9.mailstore, while a change to com.fsck.k9.mailstore can't break net.thunderbird.core.common.mail.
Position
Below the diagonal: com.fsck.k9.mailstore uses a module listed above it, which is the healthy direction.
com.fsck.k9.mailstore uses net.thunderbird.core.preference, so a change to net.thunderbird.core.preference can break com.fsck.k9.mailstore, while a change to com.fsck.k9.mailstore can't break net.thunderbird.core.preference.
Position
Below the diagonal: com.fsck.k9.mailstore uses a module listed above it, which is the healthy direction.
com.fsck.k9.mailstore uses net.thunderbird.core.preference.storage, so a change to net.thunderbird.core.preference.storage can break com.fsck.k9.mailstore, while a change to com.fsck.k9.mailstore can't break net.thunderbird.core.preference.storage.
Position
Below the diagonal: com.fsck.k9.mailstore uses a module listed above it, which is the healthy direction.
com.fsck.k9.mailstore uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break com.fsck.k9.mailstore, while a change to com.fsck.k9.mailstore can't break net.thunderbird.feature.account.
Position
Below the diagonal: com.fsck.k9.mailstore uses a module listed above it, which is the healthy direction.
26 pairs of types, where a type in com.fsck.k9.mailstore uses a type in com.fsck.k9.mail. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
com.fsck.k9.mailstore uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break com.fsck.k9.mailstore, while a change to com.fsck.k9.mailstore can't break com.fsck.k9.mail.
Position
Below the diagonal: com.fsck.k9.mailstore uses a module listed above it, which is the healthy direction.
com.fsck.k9.mailstore uses com.fsck.k9.message.html, so a change to com.fsck.k9.message.html can break com.fsck.k9.mailstore, while a change to com.fsck.k9.mailstore can't break com.fsck.k9.message.html.
Position
Below the diagonal: com.fsck.k9.mailstore uses a module listed above it, which is the healthy direction.
com.fsck.k9.mailstore uses net.thunderbird.feature.mail.folder.api, so a change to net.thunderbird.feature.mail.folder.api can break com.fsck.k9.mailstore, while a change to com.fsck.k9.mailstore can't break net.thunderbird.feature.mail.folder.api.
Position
Below the diagonal: com.fsck.k9.mailstore uses a module listed above it, which is the healthy direction.
com.fsck.k9.mailstore uses net.thunderbird.feature.search.legacy, so a change to net.thunderbird.feature.search.legacy can break com.fsck.k9.mailstore, while a change to com.fsck.k9.mailstore can't break net.thunderbird.feature.search.legacy.
Position
Below the diagonal: com.fsck.k9.mailstore uses a module listed above it, which is the healthy direction.
com.fsck.k9.mailstore uses app.k9mail.legacy.message.controller, so a change to app.k9mail.legacy.message.controller can break com.fsck.k9.mailstore, while a change to com.fsck.k9.mailstore can't break app.k9mail.legacy.message.controller.
Position
Below the diagonal: com.fsck.k9.mailstore uses a module listed above it, which is the healthy direction.
com.fsck.k9.mailstore uses net.thunderbird.core.android.account, so a change to net.thunderbird.core.android.account can break com.fsck.k9.mailstore, while a change to com.fsck.k9.mailstore can't break net.thunderbird.core.android.account.
Position
Below the diagonal: com.fsck.k9.mailstore uses a module listed above it, which is the healthy direction.
com.fsck.k9.mailstore uses app.k9mail.legacy.mailstore, so a change to app.k9mail.legacy.mailstore can break com.fsck.k9.mailstore, while a change to com.fsck.k9.mailstore can't break app.k9mail.legacy.mailstore.
Position
Below the diagonal: com.fsck.k9.mailstore uses a module listed above it, which is the healthy direction.
com.fsck.k9.mailstore uses com.fsck.k9.controller, so a change to com.fsck.k9.controller can break com.fsck.k9.mailstore, while a change to com.fsck.k9.mailstore can't break com.fsck.k9.controller.
Position
Below the diagonal: com.fsck.k9.mailstore uses a module listed above it, which is the healthy direction.
31→40 com.fsck.k9.mailstore uses com.fsck.k9part of a loop✕
Connections
2 pairs of types, where a type in com.fsck.k9.mailstore uses a type in com.fsck.k9.
com.fsck.k9.mailstore uses com.fsck.k9, so a change to com.fsck.k9 can break com.fsck.k9.mailstore, while a change to com.fsck.k9.mailstore can't break com.fsck.k9.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
com.fsck.k9.ui.messageview uses net.thunderbird.core.common.mail, so a change to net.thunderbird.core.common.mail can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break net.thunderbird.core.common.mail.
Position
Below the diagonal: com.fsck.k9.ui.messageview uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messageview uses net.thunderbird.core.common.provider, so a change to net.thunderbird.core.common.provider can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break net.thunderbird.core.common.provider.
Position
Below the diagonal: com.fsck.k9.ui.messageview uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messageview uses net.thunderbird.core.featureflag, so a change to net.thunderbird.core.featureflag can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break net.thunderbird.core.featureflag.
Position
Below the diagonal: com.fsck.k9.ui.messageview uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messageview uses net.thunderbird.core.preference, so a change to net.thunderbird.core.preference can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break net.thunderbird.core.preference.
Position
Below the diagonal: com.fsck.k9.ui.messageview uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messageview uses net.thunderbird.core.ui.theme.api, so a change to net.thunderbird.core.ui.theme.api can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break net.thunderbird.core.ui.theme.api.
Position
Below the diagonal: com.fsck.k9.ui.messageview uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messageview uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break net.thunderbird.feature.account.
Position
Below the diagonal: com.fsck.k9.ui.messageview uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messageview uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break com.fsck.k9.mail.
Position
Below the diagonal: com.fsck.k9.ui.messageview uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messageview uses com.fsck.k9.message.html, so a change to com.fsck.k9.message.html can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break com.fsck.k9.message.html.
Position
Below the diagonal: com.fsck.k9.ui.messageview uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messageview uses net.thunderbird.core.preference.display.visualSettings.message.list, so a change to net.thunderbird.core.preference.display.visualSettings.message.list can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break net.thunderbird.core.preference.display.visualSettings.message.list.
Position
Below the diagonal: com.fsck.k9.ui.messageview uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messageview uses net.thunderbird.feature.mail.folder.api, so a change to net.thunderbird.feature.mail.folder.api can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break net.thunderbird.feature.mail.folder.api.
Position
Below the diagonal: com.fsck.k9.ui.messageview uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messageview uses app.k9mail.legacy.message.controller, so a change to app.k9mail.legacy.message.controller can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break app.k9mail.legacy.message.controller.
Position
Below the diagonal: com.fsck.k9.ui.messageview uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messageview uses net.thunderbird.core.android.account, so a change to net.thunderbird.core.android.account can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break net.thunderbird.core.android.account.
Position
Below the diagonal: com.fsck.k9.ui.messageview uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messageview uses com.fsck.k9.mailstore, so a change to com.fsck.k9.mailstore can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break com.fsck.k9.mailstore.
Position
Below the diagonal: com.fsck.k9.ui.messageview uses a module listed above it, which is the healthy direction.
32→33 com.fsck.k9.ui.messageview uses com.fsck.k9.viewpart of a loop✕
Connections
2 pairs of types, where a type in com.fsck.k9.ui.messageview uses a type in com.fsck.k9.view.
com.fsck.k9.ui.messageview uses com.fsck.k9.view, so a change to com.fsck.k9.view can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break com.fsck.k9.view.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
32→36 com.fsck.k9.ui.messageview uses com.fsck.k9.activitypart of a loop✕
Connections
1 pair of types, where a type in com.fsck.k9.ui.messageview uses a type in com.fsck.k9.activity.
com.fsck.k9.ui.messageview uses com.fsck.k9.activity, so a change to com.fsck.k9.activity can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break com.fsck.k9.activity.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
32→37 com.fsck.k9.ui.messageview uses com.fsck.k9.ui.messagelistpart of a loop✕
Connections
2 pairs of types, where a type in com.fsck.k9.ui.messageview uses a type in com.fsck.k9.ui.messagelist.
com.fsck.k9.ui.messageview uses com.fsck.k9.ui.messagelist, so a change to com.fsck.k9.ui.messagelist can break com.fsck.k9.ui.messageview, while a change to com.fsck.k9.ui.messageview can't break com.fsck.k9.ui.messagelist.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
com.fsck.k9.view uses net.thunderbird.core.preference, so a change to net.thunderbird.core.preference can break com.fsck.k9.view, while a change to com.fsck.k9.view can't break net.thunderbird.core.preference.
Position
Below the diagonal: com.fsck.k9.view uses a module listed above it, which is the healthy direction.
com.fsck.k9.view uses net.thunderbird.core.ui.theme.api, so a change to net.thunderbird.core.ui.theme.api can break com.fsck.k9.view, while a change to com.fsck.k9.view can't break net.thunderbird.core.ui.theme.api.
Position
Below the diagonal: com.fsck.k9.view uses a module listed above it, which is the healthy direction.
com.fsck.k9.view uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break com.fsck.k9.view, while a change to com.fsck.k9.view can't break com.fsck.k9.mail.
Position
Below the diagonal: com.fsck.k9.view uses a module listed above it, which is the healthy direction.
com.fsck.k9.view uses net.thunderbird.core.preference.display.visualSettings.message.list, so a change to net.thunderbird.core.preference.display.visualSettings.message.list can break com.fsck.k9.view, while a change to com.fsck.k9.view can't break net.thunderbird.core.preference.display.visualSettings.message.list.
Position
Below the diagonal: com.fsck.k9.view uses a module listed above it, which is the healthy direction.
com.fsck.k9.view uses net.thunderbird.core.android.account, so a change to net.thunderbird.core.android.account can break com.fsck.k9.view, while a change to com.fsck.k9.view can't break net.thunderbird.core.android.account.
Position
Below the diagonal: com.fsck.k9.view uses a module listed above it, which is the healthy direction.
com.fsck.k9.view uses com.fsck.k9.ui.messageview, so a change to com.fsck.k9.ui.messageview can break com.fsck.k9.view, while a change to com.fsck.k9.view can't break com.fsck.k9.ui.messageview.
Position
Below the diagonal: com.fsck.k9.view uses a module listed above it, which is the healthy direction.
33→34 com.fsck.k9.view uses com.fsck.k9.activity.composepart of a loop✕
Connections
1 pair of types, where a type in com.fsck.k9.view uses a type in com.fsck.k9.activity.compose.
com.fsck.k9.view uses com.fsck.k9.activity.compose, so a change to com.fsck.k9.activity.compose can break com.fsck.k9.view, while a change to com.fsck.k9.view can't break com.fsck.k9.activity.compose.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
33→36 com.fsck.k9.view uses com.fsck.k9.activitypart of a loop✕
Connections
2 pairs of types, where a type in com.fsck.k9.view uses a type in com.fsck.k9.activity.
com.fsck.k9.view uses com.fsck.k9.activity, so a change to com.fsck.k9.activity can break com.fsck.k9.view, while a change to com.fsck.k9.view can't break com.fsck.k9.activity.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
33→40 com.fsck.k9.view uses com.fsck.k9part of a loop✕
Connections
1 pair of types, where a type in com.fsck.k9.view uses a type in com.fsck.k9.
com.fsck.k9.activity.compose uses net.thunderbird.core.ui.theme.api, so a change to net.thunderbird.core.ui.theme.api can break com.fsck.k9.activity.compose, while a change to com.fsck.k9.activity.compose can't break net.thunderbird.core.ui.theme.api.
Position
Below the diagonal: com.fsck.k9.activity.compose uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity.compose uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break com.fsck.k9.activity.compose, while a change to com.fsck.k9.activity.compose can't break net.thunderbird.feature.account.
Position
Below the diagonal: com.fsck.k9.activity.compose uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity.compose uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break com.fsck.k9.activity.compose, while a change to com.fsck.k9.activity.compose can't break com.fsck.k9.mail.
Position
Below the diagonal: com.fsck.k9.activity.compose uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity.compose uses app.k9mail.legacy.message.controller, so a change to app.k9mail.legacy.message.controller can break com.fsck.k9.activity.compose, while a change to com.fsck.k9.activity.compose can't break app.k9mail.legacy.message.controller.
Position
Below the diagonal: com.fsck.k9.activity.compose uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity.compose uses net.thunderbird.core.android.account, so a change to net.thunderbird.core.android.account can break com.fsck.k9.activity.compose, while a change to com.fsck.k9.activity.compose can't break net.thunderbird.core.android.account.
Position
Below the diagonal: com.fsck.k9.activity.compose uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity.compose uses com.fsck.k9.message, so a change to com.fsck.k9.message can break com.fsck.k9.activity.compose, while a change to com.fsck.k9.activity.compose can't break com.fsck.k9.message.
Position
Below the diagonal: com.fsck.k9.activity.compose uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity.compose uses com.fsck.k9.controller, so a change to com.fsck.k9.controller can break com.fsck.k9.activity.compose, while a change to com.fsck.k9.activity.compose can't break com.fsck.k9.controller.
Position
Below the diagonal: com.fsck.k9.activity.compose uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity.compose uses com.fsck.k9.mailstore, so a change to com.fsck.k9.mailstore can break com.fsck.k9.activity.compose, while a change to com.fsck.k9.activity.compose can't break com.fsck.k9.mailstore.
Position
Below the diagonal: com.fsck.k9.activity.compose uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity.compose uses com.fsck.k9.view, so a change to com.fsck.k9.view can break com.fsck.k9.activity.compose, while a change to com.fsck.k9.activity.compose can't break com.fsck.k9.view.
Position
Below the diagonal: com.fsck.k9.activity.compose uses a module listed above it, which is the healthy direction.
34→40 com.fsck.k9.activity.compose uses com.fsck.k9part of a loop✕
Connections
2 pairs of types, where a type in com.fsck.k9.activity.compose uses a type in com.fsck.k9.
com.fsck.k9.activity.compose uses com.fsck.k9, so a change to com.fsck.k9 can break com.fsck.k9.activity.compose, while a change to com.fsck.k9.activity.compose can't break com.fsck.k9.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
com.fsck.k9.ui.messagedetails uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break com.fsck.k9.ui.messagedetails, while a change to com.fsck.k9.ui.messagedetails can't break com.fsck.k9.mail.
Position
Below the diagonal: com.fsck.k9.ui.messagedetails uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagedetails uses net.thunderbird.core.preference.display.visualSettings.message.list, so a change to net.thunderbird.core.preference.display.visualSettings.message.list can break com.fsck.k9.ui.messagedetails, while a change to com.fsck.k9.ui.messagedetails can't break net.thunderbird.core.preference.display.visualSettings.message.list.
Position
Below the diagonal: com.fsck.k9.ui.messagedetails uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagedetails uses app.k9mail.legacy.message.controller, so a change to app.k9mail.legacy.message.controller can break com.fsck.k9.ui.messagedetails, while a change to com.fsck.k9.ui.messagedetails can't break app.k9mail.legacy.message.controller.
Position
Below the diagonal: com.fsck.k9.ui.messagedetails uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagedetails uses net.thunderbird.core.android.account, so a change to net.thunderbird.core.android.account can break com.fsck.k9.ui.messagedetails, while a change to com.fsck.k9.ui.messagedetails can't break net.thunderbird.core.android.account.
Position
Below the diagonal: com.fsck.k9.ui.messagedetails uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagedetails uses com.fsck.k9.mailstore, so a change to com.fsck.k9.mailstore can break com.fsck.k9.ui.messagedetails, while a change to com.fsck.k9.ui.messagedetails can't break com.fsck.k9.mailstore.
Position
Below the diagonal: com.fsck.k9.ui.messagedetails uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagedetails uses com.fsck.k9.view, so a change to com.fsck.k9.view can break com.fsck.k9.ui.messagedetails, while a change to com.fsck.k9.ui.messagedetails can't break com.fsck.k9.view.
Position
Below the diagonal: com.fsck.k9.ui.messagedetails uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses com.fsck.k9.ui.base, so a change to com.fsck.k9.ui.base can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break com.fsck.k9.ui.base.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses net.thunderbird.core.common.mail, so a change to net.thunderbird.core.common.mail can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break net.thunderbird.core.common.mail.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses net.thunderbird.core.featureflag, so a change to net.thunderbird.core.featureflag can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break net.thunderbird.core.featureflag.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses net.thunderbird.core.preference, so a change to net.thunderbird.core.preference can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break net.thunderbird.core.preference.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses net.thunderbird.core.preference.storage, so a change to net.thunderbird.core.preference.storage can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break net.thunderbird.core.preference.storage.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break net.thunderbird.feature.account.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break com.fsck.k9.mail.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses com.fsck.k9.message.html, so a change to com.fsck.k9.message.html can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break com.fsck.k9.message.html.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses net.thunderbird.core.preference.display.visualSettings.message.list, so a change to net.thunderbird.core.preference.display.visualSettings.message.list can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break net.thunderbird.core.preference.display.visualSettings.message.list.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses net.thunderbird.feature.mail.folder.api, so a change to net.thunderbird.feature.mail.folder.api can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break net.thunderbird.feature.mail.folder.api.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses net.thunderbird.feature.search.legacy, so a change to net.thunderbird.feature.search.legacy can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break net.thunderbird.feature.search.legacy.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses app.k9mail.legacy.message.controller, so a change to app.k9mail.legacy.message.controller can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break app.k9mail.legacy.message.controller.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses net.thunderbird.core.android.account, so a change to net.thunderbird.core.android.account can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break net.thunderbird.core.android.account.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses com.fsck.k9.message, so a change to com.fsck.k9.message can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break com.fsck.k9.message.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses com.fsck.k9.controller, so a change to com.fsck.k9.controller can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break com.fsck.k9.controller.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses com.fsck.k9.mailstore, so a change to com.fsck.k9.mailstore can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break com.fsck.k9.mailstore.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses com.fsck.k9.ui.messageview, so a change to com.fsck.k9.ui.messageview can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break com.fsck.k9.ui.messageview.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses com.fsck.k9.view, so a change to com.fsck.k9.view can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break com.fsck.k9.view.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
com.fsck.k9.activity uses com.fsck.k9.activity.compose, so a change to com.fsck.k9.activity.compose can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break com.fsck.k9.activity.compose.
Position
Below the diagonal: com.fsck.k9.activity uses a module listed above it, which is the healthy direction.
36→37 com.fsck.k9.activity uses com.fsck.k9.ui.messagelistpart of a loop✕
Connections
3 pairs of types, where a type in com.fsck.k9.activity uses a type in com.fsck.k9.ui.messagelist.
com.fsck.k9.activity uses com.fsck.k9.ui.messagelist, so a change to com.fsck.k9.ui.messagelist can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break com.fsck.k9.ui.messagelist.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
36→40 com.fsck.k9.activity uses com.fsck.k9part of a loop✕
Connections
3 pairs of types, where a type in com.fsck.k9.activity uses a type in com.fsck.k9.
com.fsck.k9.activity uses com.fsck.k9, so a change to com.fsck.k9 can break com.fsck.k9.activity, while a change to com.fsck.k9.activity can't break com.fsck.k9.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
com.fsck.k9.ui.messagelist uses net.thunderbird.core.common.mail, so a change to net.thunderbird.core.common.mail can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break net.thunderbird.core.common.mail.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses net.thunderbird.core.featureflag, so a change to net.thunderbird.core.featureflag can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break net.thunderbird.core.featureflag.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses net.thunderbird.core.preference, so a change to net.thunderbird.core.preference can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break net.thunderbird.core.preference.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses net.thunderbird.core.ui.theme.api, so a change to net.thunderbird.core.ui.theme.api can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break net.thunderbird.core.ui.theme.api.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break net.thunderbird.feature.account.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break com.fsck.k9.mail.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses net.thunderbird.core.preference.display.visualSettings.message.list, so a change to net.thunderbird.core.preference.display.visualSettings.message.list can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break net.thunderbird.core.preference.display.visualSettings.message.list.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses net.thunderbird.feature.account.avatar, so a change to net.thunderbird.feature.account.avatar can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break net.thunderbird.feature.account.avatar.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses net.thunderbird.feature.mail.folder.api, so a change to net.thunderbird.feature.mail.folder.api can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break net.thunderbird.feature.mail.folder.api.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses net.thunderbird.feature.mail.message.list.ui.state, so a change to net.thunderbird.feature.mail.message.list.ui.state can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break net.thunderbird.feature.mail.message.list.ui.state.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses net.thunderbird.feature.notification.api.content, so a change to net.thunderbird.feature.notification.api.content can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break net.thunderbird.feature.notification.api.content.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses net.thunderbird.feature.search.legacy, so a change to net.thunderbird.feature.search.legacy can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break net.thunderbird.feature.search.legacy.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses app.k9mail.legacy.message.controller, so a change to app.k9mail.legacy.message.controller can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break app.k9mail.legacy.message.controller.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses net.thunderbird.core.android.account, so a change to net.thunderbird.core.android.account can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break net.thunderbird.core.android.account.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses app.k9mail.legacy.mailstore, so a change to app.k9mail.legacy.mailstore can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break app.k9mail.legacy.mailstore.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses com.fsck.k9.controller, so a change to com.fsck.k9.controller can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break com.fsck.k9.controller.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses com.fsck.k9.mailstore, so a change to com.fsck.k9.mailstore can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break com.fsck.k9.mailstore.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses com.fsck.k9.ui.messageview, so a change to com.fsck.k9.ui.messageview can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break com.fsck.k9.ui.messageview.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
com.fsck.k9.ui.messagelist uses com.fsck.k9.activity, so a change to com.fsck.k9.activity can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break com.fsck.k9.activity.
Position
Below the diagonal: com.fsck.k9.ui.messagelist uses a module listed above it, which is the healthy direction.
37→40 com.fsck.k9.ui.messagelist uses com.fsck.k9part of a loop✕
Connections
1 pair of types, where a type in com.fsck.k9.ui.messagelist uses a type in com.fsck.k9.
com.fsck.k9.ui.messagelist uses com.fsck.k9, so a change to com.fsck.k9 can break com.fsck.k9.ui.messagelist, while a change to com.fsck.k9.ui.messagelist can't break com.fsck.k9.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
com.fsck.k9.notification uses net.thunderbird.core.preference, so a change to net.thunderbird.core.preference can break com.fsck.k9.notification, while a change to com.fsck.k9.notification can't break net.thunderbird.core.preference.
Position
Below the diagonal: com.fsck.k9.notification uses a module listed above it, which is the healthy direction.
27 pairs of types, where a type in com.fsck.k9.notification uses a type in net.thunderbird.feature.account. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
com.fsck.k9.notification uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break com.fsck.k9.notification, while a change to com.fsck.k9.notification can't break net.thunderbird.feature.account.
Position
Below the diagonal: com.fsck.k9.notification uses a module listed above it, which is the healthy direction.
com.fsck.k9.notification uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break com.fsck.k9.notification, while a change to com.fsck.k9.notification can't break com.fsck.k9.mail.
Position
Below the diagonal: com.fsck.k9.notification uses a module listed above it, which is the healthy direction.
com.fsck.k9.notification uses net.thunderbird.core.preference.display.visualSettings.message.list, so a change to net.thunderbird.core.preference.display.visualSettings.message.list can break com.fsck.k9.notification, while a change to com.fsck.k9.notification can't break net.thunderbird.core.preference.display.visualSettings.message.list.
Position
Below the diagonal: com.fsck.k9.notification uses a module listed above it, which is the healthy direction.
com.fsck.k9.notification uses net.thunderbird.feature.mail.folder.api, so a change to net.thunderbird.feature.mail.folder.api can break com.fsck.k9.notification, while a change to com.fsck.k9.notification can't break net.thunderbird.feature.mail.folder.api.
Position
Below the diagonal: com.fsck.k9.notification uses a module listed above it, which is the healthy direction.
com.fsck.k9.notification uses app.k9mail.legacy.message.controller, so a change to app.k9mail.legacy.message.controller can break com.fsck.k9.notification, while a change to com.fsck.k9.notification can't break app.k9mail.legacy.message.controller.
Position
Below the diagonal: com.fsck.k9.notification uses a module listed above it, which is the healthy direction.
28 pairs of types, where a type in com.fsck.k9.notification uses a type in net.thunderbird.core.android.account. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
com.fsck.k9.notification uses net.thunderbird.core.android.account, so a change to net.thunderbird.core.android.account can break com.fsck.k9.notification, while a change to com.fsck.k9.notification can't break net.thunderbird.core.android.account.
Position
Below the diagonal: com.fsck.k9.notification uses a module listed above it, which is the healthy direction.
com.fsck.k9.notification uses net.thunderbird.feature.notification.api, so a change to net.thunderbird.feature.notification.api can break com.fsck.k9.notification, while a change to com.fsck.k9.notification can't break net.thunderbird.feature.notification.api.
Position
Below the diagonal: com.fsck.k9.notification uses a module listed above it, which is the healthy direction.
com.fsck.k9.notification uses app.k9mail.legacy.mailstore, so a change to app.k9mail.legacy.mailstore can break com.fsck.k9.notification, while a change to com.fsck.k9.notification can't break app.k9mail.legacy.mailstore.
Position
Below the diagonal: com.fsck.k9.notification uses a module listed above it, which is the healthy direction.
com.fsck.k9.notification uses com.fsck.k9.mailstore, so a change to com.fsck.k9.mailstore can break com.fsck.k9.notification, while a change to com.fsck.k9.notification can't break com.fsck.k9.mailstore.
Position
Below the diagonal: com.fsck.k9.notification uses a module listed above it, which is the healthy direction.
com.fsck.k9.notification uses com.fsck.k9.ui.messagelist, so a change to com.fsck.k9.ui.messagelist can break com.fsck.k9.notification, while a change to com.fsck.k9.notification can't break com.fsck.k9.ui.messagelist.
Position
Below the diagonal: com.fsck.k9.notification uses a module listed above it, which is the healthy direction.
38→40 com.fsck.k9.notification uses com.fsck.k9part of a loop✕
Connections
1 pair of types, where a type in com.fsck.k9.notification uses a type in com.fsck.k9.
com.fsck.k9.notification uses com.fsck.k9, so a change to com.fsck.k9 can break com.fsck.k9.notification, while a change to com.fsck.k9.notification can't break com.fsck.k9.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
com.fsck.k9.preferences uses net.thunderbird.core.preference, so a change to net.thunderbird.core.preference can break com.fsck.k9.preferences, while a change to com.fsck.k9.preferences can't break net.thunderbird.core.preference.
Position
Below the diagonal: com.fsck.k9.preferences uses a module listed above it, which is the healthy direction.
com.fsck.k9.preferences uses net.thunderbird.core.preference.storage, so a change to net.thunderbird.core.preference.storage can break com.fsck.k9.preferences, while a change to com.fsck.k9.preferences can't break net.thunderbird.core.preference.storage.
Position
Below the diagonal: com.fsck.k9.preferences uses a module listed above it, which is the healthy direction.
com.fsck.k9.preferences uses net.thunderbird.feature.account, so a change to net.thunderbird.feature.account can break com.fsck.k9.preferences, while a change to com.fsck.k9.preferences can't break net.thunderbird.feature.account.
Position
Below the diagonal: com.fsck.k9.preferences uses a module listed above it, which is the healthy direction.
com.fsck.k9.preferences uses com.fsck.k9.mail, so a change to com.fsck.k9.mail can break com.fsck.k9.preferences, while a change to com.fsck.k9.preferences can't break com.fsck.k9.mail.
Position
Below the diagonal: com.fsck.k9.preferences uses a module listed above it, which is the healthy direction.
com.fsck.k9.preferences uses net.thunderbird.core.preference.display.visualSettings.message.list, so a change to net.thunderbird.core.preference.display.visualSettings.message.list can break com.fsck.k9.preferences, while a change to com.fsck.k9.preferences can't break net.thunderbird.core.preference.display.visualSettings.message.list.
Position
Below the diagonal: com.fsck.k9.preferences uses a module listed above it, which is the healthy direction.
com.fsck.k9.preferences uses net.thunderbird.feature.account.avatar, so a change to net.thunderbird.feature.account.avatar can break com.fsck.k9.preferences, while a change to com.fsck.k9.preferences can't break net.thunderbird.feature.account.avatar.
Position
Below the diagonal: com.fsck.k9.preferences uses a module listed above it, which is the healthy direction.
com.fsck.k9.preferences uses net.thunderbird.core.android.account, so a change to net.thunderbird.core.android.account can break com.fsck.k9.preferences, while a change to com.fsck.k9.preferences can't break net.thunderbird.core.android.account.
Position
Below the diagonal: com.fsck.k9.preferences uses a module listed above it, which is the healthy direction.
com.fsck.k9.preferences uses com.fsck.k9.mailstore, so a change to com.fsck.k9.mailstore can break com.fsck.k9.preferences, while a change to com.fsck.k9.preferences can't break com.fsck.k9.mailstore.
Position
Below the diagonal: com.fsck.k9.preferences uses a module listed above it, which is the healthy direction.
com.fsck.k9.preferences uses com.fsck.k9.notification, so a change to com.fsck.k9.notification can break com.fsck.k9.preferences, while a change to com.fsck.k9.preferences can't break com.fsck.k9.notification.
Position
Below the diagonal: com.fsck.k9.preferences uses a module listed above it, which is the healthy direction.
39→40 com.fsck.k9.preferences uses com.fsck.k9part of a loop✕
Connections
1 pair of types, where a type in com.fsck.k9.preferences uses a type in com.fsck.k9.
com.fsck.k9.preferences uses com.fsck.k9, so a change to com.fsck.k9 can break com.fsck.k9.preferences, while a change to com.fsck.k9.preferences can't break com.fsck.k9.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
com.fsck.k9 uses net.thunderbird.core.preference.storage, so a change to net.thunderbird.core.preference.storage can break com.fsck.k9, while a change to com.fsck.k9 can't break net.thunderbird.core.preference.storage.
Position
Below the diagonal: com.fsck.k9 uses a module listed above it, which is the healthy direction.
com.fsck.k9 uses net.thunderbird.core.android.account, so a change to net.thunderbird.core.android.account can break com.fsck.k9, while a change to com.fsck.k9 can't break net.thunderbird.core.android.account.
Position
Below the diagonal: com.fsck.k9 uses a module listed above it, which is the healthy direction.
com.fsck.k9 uses com.fsck.k9.notification, so a change to com.fsck.k9.notification can break com.fsck.k9, while a change to com.fsck.k9 can't break com.fsck.k9.notification.
Position
Below the diagonal: com.fsck.k9 uses a module listed above it, which is the healthy direction.
com.fsck.k9 uses com.fsck.k9.preferences, so a change to com.fsck.k9.preferences can break com.fsck.k9, while a change to com.fsck.k9 can't break com.fsck.k9.preferences.
Position
Below the diagonal: com.fsck.k9 uses a module listed above it, which is the healthy direction.
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A05:2025 — Injection
10
High / Critical
A07:2025 — Authentication Failures
5
High / Critical
A03:2025 — Software Supply Chain Failures
3
Medium
Roadmap
First, ensure all custom controls are fully keyboard-operable and anchors have valid hrefs to support navigation. Next, improve visual safety by maintaining visible focus styles, respecting reduced motion preferences, and fixing low-contrast colors. Simultaneously, resolve the single leaked secret in the keystore and enforce accessibility standards by integrating automated checks into your CI pipeline to prevent regressions. Finally, correct page structure by adding proper language attributes, titles, and semantic landmarks while keeping zoom enabled.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 1 Leaked secret finding(s) in Secret Scanning — start with REDACTED.
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Enforce accessibility in the toolchain your project already uses: assert accessibility in your UI test suite with your toolkit's own matcher (Flutter `meetsGuideline`, Espresso `AccessibilityChecks`, XCTest `performAccessibilityAudit`), then gate that test in CI so a regression blocks the merge.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 23
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 741
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 297
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 15
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 75 of 81 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 6 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.9 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.
Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.
What we checked — 81 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 1003 of 1061 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D8 Code Coverage — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.kt, .java) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo. To have real coverage read, produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures. You can widen what we reach: optional: produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures — then the real number is read on the next scan.
D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This repository declares 1 of its own test(s) unreliable. The built-in reliability runner does not support this repository's ecosystem (.kt, .java), so the suite was not re-run and no reliability score is given — these are the repository's own declarations, not our measurement.
D12 Dependency Hygiene — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Not scored — 162 Maven/Gradle manifest(s) were read, stating a version for 150 dependency(ies) and leaving 22 to a parent or an imported BOM, but no build resolved the dependency graph, so the outdated signal was not established. NOT a finding that these dependencies are current or healthy.
D27 Navigability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Navigability is taken over call sites whose callee resolved. For C# that population includes calls into referenced assemblies; for this language only calls declared inside the repository count, so the abstention threshold reads the repository's use of its standard library as a resolution failure. That is a limit of this analyzer, not a build problem in this repository.
D32 Data Compliance (PII/GDPR) — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `app-common/src/main/kotlin/net/thunderbird/app/common/feature/mail/message/mapper/DomainToLegacyMessageMapper.kt`, `benchmarks/src/main/kotlin/net/thunderbird/benchmarks/common/account/BenchmarkAccountProvider.kt`, `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/icon/BadgeIconBuilder.kt`, `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/icon/IconBuilder.kt`, `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/swipe/SwipeableRow.kt`, … (+129 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
AX1 Captive dependencies — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads Microsoft.Extensions.DependencyInjection registrations in C# and Spring beans in Java/Kotlin only, and this repository's container is Koin, whose lifetimes are not modelled yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
AXB1 Runtime evidence locked — no reproducible boot — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Subject: a native UI project (app-common/src/main/AndroidManifest.xml). The Runtime Evidence tier boots an app only via docker-compose, an Aspire AppHost, a Dockerfile, an npm dev script, a web service's own toolchain entry point (cargo, go, dotnet, Python, Spring Boot), or an Android app's own Gradle wrapper (run on an emulator); an Apple or Flutter app needs a host it lacks. None applied, so no live runtime a11y/egress/header evidence was collected. You can widen what we reach: add a docker-compose.yml (or an Aspire AppHost) that brings the app up with its dependencies. Watchdog then boots it in an isolated sandbox and gathers real runtime evidence — you change nothing in your pipeline (no CI step, no SDK).
C1 Data Protection — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'android.database.sqlite' is imported (legacy/core/src/main/java/com/fsck/k9/mailstore/LockableDatabase.java:10), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
C2 Access Controls — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
C3 Audit Trail — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'android.database.sqlite' is imported (legacy/core/src/main/java/com/fsck/k9/mailstore/LockableDatabase.java:10), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
C4 Data Retention — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'android.database.sqlite' is imported (legacy/core/src/main/java/com/fsck/k9/mailstore/LockableDatabase.java:10), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
C5 Data-Subject Rights — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 'android.database.sqlite' is imported (legacy/core/src/main/java/com/fsck/k9/mailstore/LockableDatabase.java:10), but no entity, schema, table or model declaration this check reads was found beside it, so whether personal data is stored could not be decided.
DM9 Scattered domain decisions — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The frontend declares that it computes whether a construction is produced or passed, yet 2208 of 3338 constructions arrived without the answer. Arm two skipped them; it did not clear them.
ED5 Idempotency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check decides whether a handler's mutation is safe to re-run by recognising its persistence writes (a database save, a repository write, an event publish) and its guards. Those markers are .NET member names, so in this repository's language a write such as `repository.save(order)` is not recognised and a same-named call on an unrelated library type could be. The handlers were found; their idempotency was neither confirmed nor ruled out.
GD1 Unfinished & placeholder code — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and this repository's Java, Kotlin, Python is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
IC1 Incompleteness & stubs — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby and Scala source only, and this repository's Kotlin, Python is most of its product and is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D7 Architectural Integrity: Layering is checked against detected/declared rules — an architecture whose boundaries live in convention or in code review, not in a rule a scanner can read, is not enforced here.
D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
D22 Internal API Consistency: API-surface coherence is an LLM judgement over a sample of the public surface — consistency of intent across the whole API is approximated, not exhaustively verified.
D25 ADR Conformance: ADR conformance is the LLM-scored fraction of sampled code that follows recorded decisions — it checks the decisions that were written down and the slices it sampled, not unrecorded rules or the whole tree.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
AC4 Keyboard semantics: Keyboard semantics are inferred from markup attributes — interactivity wired purely in script, focus managed at runtime, and component-level handlers are invisible. A clean result means "no static keyboard-trap shape", not a keyboard-operability proof.
AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
AC7 A11y enforcement: Enforcement is scored from in-repo config/CI evidence only — an a11y gate enforced in external tooling with no in-repo trace can't be credited, and a configured linter is presence, not proof the rules actually run or block a merge.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
DM6 Domain ↔ infrastructure boundary: Infrastructure reached through a hand-rolled wrapper, a domain-named facade, reflection, or a string-keyed service locator resolves to a non-infra type and isn't seen; the body scan is symbol resolution over syntax, not full dataflow. A clean result means "no resolved infra reference in a domain body", not a proof of purity.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
The LLM boundary
LLM-set scores this run (6): D19, D20, D21, D22, D25, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
45 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was MessageHomeActivity.onCustomKeyDown at 48. A further 15 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being CharsetSupport.importCodePointFromIphone at 486 — they are counted neither in the figure above nor in this dimension's score. 9 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: mail/common/src/main/java/com/fsck/k9/mail/internet/CharsetSupport.java (CharsetSupport.importCodePointFromIphone at 486), legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/general/GeneralSettingsDataStore.kt (GeneralSettingsDataStore.getString at 30), legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.kt (MessageViewFragment.selectMenuItem at 28), legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/AccountSettingsDataStore.kt (AccountSettingsDataStore.putString at 26), legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt (LegacyMessageListFragment.selectMenuItem at 21), and 4 more not listed here. They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 40 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 3 bodies over 30 down to 30 or less in Cyclomatic Complexity — start with MessageHomeActivity.onCustomKeyDown (cyclomatic 48), MessageCompose.onCreate (cyclomatic 36), render-notes.render_notes (cyclomatic 32). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 3 together lifts Cyclomatic Complexity from 6.8 to about 7.3/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 96 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 2 bodies over 60 down to 60 or less in Cognitive Complexity — start with render-notes.render_notes (cognitive 68), Rfc822Tokenizer.tokenize (cognitive 62). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 2 together lifts Cognitive Complexity from 6.4 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes8.9 / 10Strong✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 31 TooManyMethods finding(s) in God Classes — start with ItemTouchHelper.java (2), MessagingController.java, LegacyMessageListFragment.kt. — One of this dimension's main actionable groups (31 warning-level).
Resolve the 20 ClassTooLong finding(s) in God Classes — start with MessagingController.java, LegacyMessageListFragment.kt, MessageListFragment.kt. — One of this dimension's main actionable groups (20 warning-level).
Resolve the 20 FileTooLong finding(s) in God Classes — start with MessagingController.java, LegacyMessageListFragment.kt, MessageListFragment.kt. — One of this dimension's main actionable groups (20 warning-level).
Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
210 duplicated block group(s) detected. A further 9 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.
+ 78 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 15 Duplicated block (11 lines × 2) finding(s) in Code Duplication — start with LegacyMessageListFragment.kt (3), Rfc822Tokenizer.java (2), StorageMigrationTo24.kt. — One of this dimension's main actionable groups (15 warning-level).
Resolve the 14 Duplicated block (10 lines × 2) finding(s) in Code Duplication — start with LegacyMessageListFragment.kt (2), MessageListLoader.kt (2), AttachmentTempFileProvider.java (2). — One of this dimension's main actionable groups (14 warning-level).
Resolve the 14 Duplicated block (7 lines × 2) finding(s) in Code Duplication — start with LegacyMessageListFragment.kt (4), IncomingServerSettingsViewModel.kt (2), MessageItemSwipeBackground.kt. — One of this dimension's main actionable groups (14 warning-level).
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling7.7 / 10Adequategated by 1 critical finding✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
154 production modules (Gradle), 1 dependency cycle(s), 20 unstable depended-on module(s). Read from the build's own module declarations; edges a convention plugin adds from buildSrc or build-logic are not visible there; 17 module(s) off the main sequence, with abstractness counted on 148 of the 154 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).
Circular dependency
Unstable project tfa:app-common · ×20
Off the main sequence: tfa:core:mail:mailserver · ×15
Off the main sequence: tfa:core:common · ×2
What to do
Resolve the 1 Circular dependency finding(s) in Coupling. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 20 Unstable project tfa finding(s) in Coupling. — One of this dimension's main actionable groups (20 warning-level).
Resolve the 15 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (15 warning-level).
Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 2 Low cohesion finding(s) in Cohesion (LCOM4) — start with RecipientMvpView.kt, TbFundingSettings.kt. — One of this dimension's main actionable groups (2 warning-level).
Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the code respects its intended layering / architecture rules.
Method: Enforcement rung (Prevented/Verified/Documented) per checkable ADR via Roslyn, plus dependency cycles via the engine shared with D5/AX3. Deterministic, exact.
All 15 mechanizable ADR(s) are enforced: 14 by analyzers, 1 by tests. Dependency cycles not checked (no project-reference graph; where this repository's language has an import-cycle lens, cycles are reported there).
✓ On the Gold path — maintain.
Detailed fixes: d7_recommendation.md.
Do you agree with this assessment?
D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.
Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.
405 test methods: 405 unit, 0 integration, 0 BDD, 0 e2e. The Python suite contributes 6 test function(s) across 1 file(s) declaring at least one — every `def test…` in a file pytest or unittest would collect, which is those frameworks' own definition of a case; a parametrize table counts once, so this is a floor. Its tier split is read from file names and paths only.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
Resolve the 1 Leaked secret finding(s) in Secret Scanning — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Enforce Secret Scanning in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d13_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Top hotspots: legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java (22×36=792); legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageHomeActivity.kt (16×18=288); legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java (11×24=264) Repeated repair below the complexity floor: app-k9mail/src/main/kotlin/app/k9mail/feature/K9FundingSettings.kt (9 of 15 changes were fixes); app-thunderbird/src/main/kotlin/net/thunderbird/android/feature/TbFundingSettings.kt (8 of 13 changes were fixes); app-common/src/main/kotlin/net/thunderbird/app/common/feature/funding/configstore/FundingConfigMapper.kt (7 of 8 changes were fixes)
Resolve the 11 Hotspot finding(s) in Churn × Complexity Hotspots — start with MessageCompose.java, MessageHomeActivity.kt, MessagingController.java. — One of this dimension's main actionable groups (11 warning-level).
Resolve the 5 Repeated repair finding(s) in Churn × Complexity Hotspots — start with K9FundingSettings.kt, TbFundingSettings.kt, FundingConfigMapper.kt. — One of this dimension's main actionable groups (5 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D16 · Bus Factor7.9 / 10Strong✓ Tool-verified
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
211 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java. Counted over 1000 of the 3090 production source files in this repository: 2081 are under the ~2,400-byte size floor this dimension measures over, and the remaining 9 have no attributable history left to measure.
Off-boarding risk: anonymized user #1 · ×4
Further sole-owners (lower concentration)
What to do
Resolve the 4 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (4 recommendation-level).
Resolve the 1 Further sole-owners (lower concentration) finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
191 deducted task-comment markers across 203880 LoC (0.1/KLoC) → score 9.8. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.
Resolve the 165 TodoComment finding(s) in Explicit Debt — start with MessageListFragment.kt (8), DisplaySystemNotificationCommandTest.kt (6), BillingPurchaseHandler.kt (5). — One of this dimension's main actionable groups (165 warning-level).
Resolve the 25 FixmeComment finding(s) in Explicit Debt — start with LegacyAccount.kt (8), MessageListLoader.kt (3), MessagingController.java (2). — One of this dimension's main actionable groups (25 warning-level).
Resolve the 1 HackComment finding(s) in Explicit Debt — start with MessageListFragment.kt. — One of this dimension's main actionable groups (1 warning-level).
Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.
The repository's root README (Thunderbird for Android) is clear and comprehensive: it introduces the project as a privacy-focused email app with unified inbox, explains where to get it on Google Play/F-Droid, and gives an overview of what it does before diving into download links. It also documents the broader architecture via a dedicated docs/README pointing readers to the rendered documentation site, while each subdirectory README (app-common, build-plugin, components, cli/html-cleaner-cli, etc.) is written for its own directory rather than the repository root, as required by scope. The visible content is complete and well-structured across all documents. The repository is well documented with READMEs for each directory (core/file/, docs/architecture/, docs/developer/, docs/engineering/, feature/notification/, library/token-auto-complete/, plugins/openpgp-api-lib/, quality/e2e/) covering the module, architecture principles, contribution process, and automation tests. The core README documents its own directory rather than the repository; all visible documents are per-directory and meet their scope.
✓ On the Gold path — maintain.
Detailed fixes: d19_recommendation.md.
Do you agree with this assessment?
D20 · ADR QualityStrong◐ Sampled · advisory
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Per-ADR judgment by language model at low temperature with two-pass stability; confidence is share of ADRs evaluated; enforcement-field presence detected deterministically. Advisory.
Evaluated 22 ADR(s) individually; mean quality 8.6/10 (consistently complete and clear). 0 flagged with a specific gap.
ADR has no Consequences section · ×10docs/engineering/adr/0001-switch-from-java-to-kotlin.md:1detected by adr-integrity
What to do
Resolve the 10 ADR has no Consequences section finding(s) in ADR Quality — start with 0001-switch-from-java-to-kotlin.md, 0002-ui-wrap-material-components-in-atomic-design-system.md, 0003-switch-test-assertions-from-truth-to-assertk.md. — One of this dimension's main actionable groups (10 recommendation-level).
Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.
0 naming inconsistencies across 0 sampled symbols.
✓ On the Gold path — maintain.
Detailed fixes: d21_recommendation.md.
Do you agree with this assessment?
D22 · Internal API ConsistencyAdequate◐ Sampled · advisory
What it measures: Whether the internal API surface is consistent and coherent.
Method: Judged by language model at low temperature over a sample of the public API surface (IsPackable or .Contracts types). Sampled, advisory; confidence discounted by model uncertainty.
Duplicate operation across class and companion object/extension. `OutboxFolderManagerKt.getOutboxFolderIdSync` has the exact same signature as `OutboxFolderManager.getOutboxFolderIdSync`. This creates ambiguity for callers on whether to use the instance method or the static/extension function.
Inconsistent naming convention for synchronous operations. `OutboxFolderManager` has `hasPendingMessages` (no Sync suffix) while the extension function in `OutboxFolderManagerKt` is `hasPendingMessagesSync`. This suggests one might be async and one sync, or they are duplicates with inconsistent naming. Given the previous inconsistency, this pattern is confusing.
Duplicate intent across distinct repository types. Both `FolderDetailsRepository` and `FolderQueryRepository` expose an `findById` method with identical signatures. It is unclear why the API is split between 'Details' and 'Query' repositories if they share the same primary lookup operation.
Inconsistent naming for reactive vs imperative access. `observeAllByAccountId` implies a Flow/Stream, while `getAllByAccountId` implies a single snapshot. While distinct, the naming pattern `observe...` vs `get...` is less consistent than `observe...` vs `get...Sync` or `get...Once`. However, the bigger issue is the parallel with `PushFolderTrackingRepository` which uses `observeEnabled` and `isEnabled`.
What to do
Resolve the 1 Duplicate operation across class and companion object/extension.… finding(s) in Internal API Consistency. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Inconsistent naming convention for synchronous operations.… finding(s) in Internal API Consistency. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Duplicate intent across distinct repository types. Both… finding(s) in Internal API Consistency. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d22_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the code actually follows the decisions recorded in the project's ADRs.
Method: Judged by language model at low temperature against ADRs plus a deterministic structural code summary; findings linked to repo-rooted ADR paths for traceability. Advisory.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
3 finding(s): 0 critical, 3 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.
REDACTED
REDACTED
What to do
Resolve the 3 High secret finding(s) in Secrets (history) — start with REDACTED (2), REDACTED. — One of this dimension's main actionable groups (3 issue-level).
Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
10 finding(s): 0 critical, 3 high, 7 medium, 0 low. semgrep hit a parse error in 7 file(s) — `app-common/src/main/kotlin/net/thunderbird/app/common/feature/mail/message/mapper/DomainToLegacyMessageMapper.kt` (line 112, line 114, line 116, …), `gradlew` (line 74, line 178), `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` (line 1302), `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` (line 1181), `scripts/ci/merges/do_merge.sh` (lines 61–102), … (+2 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 1 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
+ 1 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.
Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
220 of 1009 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is legacy/core/src/main/java/com/fsck/k9/helper/MimeTypeUtil.java. Counted over 1009 of the 3090 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Resolve the 213 Orphaned file finding(s) in Knowledge Freshness — start with MessageExtractor.java, RecipientMvpView.kt, REDACTED. — One of this dimension's main actionable groups (213 recommendation-level).
Resolve the 7 Orphaned knowledge finding(s) in Knowledge Freshness — start with MimeTypeUtil.java, MessageCryptoHelper.java, CharsetSupport.java. — One of this dimension's main actionable groups (7 issue-level).
Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 4 Boundary-crossing change coupling finding(s) in Change Coupling — start with DefaultAccountDefaultsProvider.kt, DrawerView.kt, FeatureModule.kt. — One of this dimension's main actionable groups (4 issue-level).
Resolve the 13 Change coupling finding(s) in Change Coupling — start with DrawerContentPreview.kt (2), K9StoragePersister.java, IncomingServerSettingsContent.kt. — One of this dimension's main actionable groups (13 warning-level).
Resolve the 3 Change-coupling hub finding(s) in Change Coupling — start with GeneralSettingsDataStore.kt, K9.kt, RetrieveFolderOperations.kt. — One of this dimension's main actionable groups (3 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
What it measures: Whether the repository publishes a coordinated-vulnerability-disclosure policy (SECURITY.md or security.txt) with a reporting contact, so finders know how to report a vulnerability. Presence of a policy file with a contact, not whether the policy is adequate or honoured.
Method: Vulnerability-disclosure policy read deterministically from the repo: a SECURITY.md (root/.github/docs) or .well-known/security.txt / security.txt, regex-checked for a reporting contact (email / URL / mailto). Present + contact → 10; present without a contact → 4; NotApplicable when no policy file exists (it may live off-repo). Detects the policy file's presence + contact, not its adequacy.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Scored apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. SCORED, not informational.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 9 platform declaration(s) and 155 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
✓ On the Gold path — maintain.
Detailed fixes: d44_recommendation.md.
Do you agree with this assessment?
Frontend & cross-cutting dimensions
R = React/JS · M = Maturity · P = Readiness.
AC2 · Forms & labels10.0 / 10Exemplary○ Nothing flagged
Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.
Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.
Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
An iframe with no title (or an empty one) is announced only as "frame". Add a non-empty title describing its content, or an aria-label. — docs/assets/tb-theme/index.hbs:132
What to do
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
Other · Accessibility — Whether interactive behaviour is keyboard-reachable — no click handler on a non-interactive element lacking a role, tabindex and key handler, no element the repo's own CSS styles `cursor: pointer` without giving it any of the three, no unfocusable element whose only binding is a mouse enter/leave pair or a double-click, no positive tabindex, no href-less anchor, no placeholder-href (#/javascript) link acting as a button. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: click handlers on non-interactive elements lacking role+tabindex+key handler, positive tabindex values, and href-less anchors. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: elements that pose a keyboard-semantics question, in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) — a non-natively-interactive element carrying a click handler, a double-click or hover enter/leave binding, a pointer-only gesture on a tabindex="0" element, or `cursor: pointer` from the repo's own CSS; an href-less or placeholder-href (#, javascript:) anchor; and any element with a positive tabindex. Natively interactive elements used correctly (<button>, <a href>, form controls) are NOT in the population — there is nothing to judge — so a page of nothing but correct controls gives AC4 nothing to measure. Keyboard reachability is judged from the markup, never from a rendered page. ★ An interactive element declared in a tagged-template (html`…`) or hyperscript frontend is NOT in this population — no producer reads either — so an empty population is reported as an analyzer gap, never as "this repository has no interactive elements".
The repo's own CSS styles .menu-title with `cursor: pointer`, so this <h1> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler. — docs/assets/tb-theme/index.hbs:164
What to do
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.
Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.
Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.
Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
`.page` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible. — docs/assets/tb-theme/css/general.css:82
`#fa-spin` moves (`animation: rotating 2s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — docs/assets/tb-theme/css/chrome.css:383
`html:not(.sidebar-resizing) .sidebar` moves (`transition: transform 0.3s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — docs/assets/tb-theme/css/chrome.css:499
`.chapter-fold-toggle div` moves (`transition: transform 0.5s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — docs/assets/tb-theme/css/chrome.css:631
`html:not(.js) .page-wrapper` moves (`transition: margin-left 0.3s ease, transform 0.3s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — docs/assets/tb-theme/css/general.css:92
`[dir=rtl]:not(.js) .page-wrapper` moves (`transition: margin-right 0.3s ease, transform 0.3s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce. — docs/assets/tb-theme/css/general.css:96
What to do
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Do you agree with this assessment?
AC7 · A11y enforcement4.0 / 10Weak✓ Tool-verified
Other · Accessibility — Whether accessibility is ENFORCED in the toolchain — an accessibility checker configured over the markup (an a11y lint rule set, e.g. eslint-plugin-jsx-a11y or vuejs-accessibility where the project lints JavaScript) and an automated accessibility assertion wired into tests or CI (axe/pa11y/Lighthouse or an equivalent) — on the Documented→Verified→Prevented ladder.
Method: Repo config/CI scan: an accessibility checker configured over the markup (an a11y lint rule set such as eslint-plugin-jsx-a11y / vuejs-accessibility where JavaScript is linted) and an automated accessibility assertion in tests or CI (axe/pa11y/Lighthouse or equivalent), graded on the Documented→Verified→Prevented rungs. Deterministic, presence/rung detection.
Coverage: Population: the repository's own tooling configuration — lint config, test and CI files — NOT the markup. It is read for a configured accessibility checker and an automated accessibility assertion (axe/pa11y/Lighthouse, or a native-toolkit equivalent), and it credits an INVOCATION, never a mention: a licence filename, an import comment or a doc reference earns no rung. Enforcement configured entirely outside the repository leaves no evidence here and cannot be credited.
No accessibility enforcement found — no accessibility linting at author time and no automated accessibility check in tests or CI. Add your UI toolkit's own accessibility assertion to the test suite (Flutter `meetsGuideline`, Espresso `AccessibilityChecks`, XCTest `performAccessibilityAudit`), then gate that test in the pipeline. What was searched, so you can tell an absence from a miss: the 3 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.
What to do
Enforce accessibility in the toolchain your project already uses: assert accessibility in your UI test suite with your toolkit's own matcher (Flutter `meetsGuideline`, Espresso `AccessibilityChecks`, XCTest `performAccessibilityAudit`), then gate that test in CI so a regression blocks the merge.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
What to do
The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
The projects tfa:feature:notification:api → tfa:feature:notification:testing → tfa:feature:notification:api form a reference cycle. Cyclic dependencies prevent independent build/test/deploy, blur ownership, and tend to grow into a big ball of mud. Break the cycle by extracting the shared types into a separate project both can reference.
What to do
Break project reference cycles by extracting shared abstractions into a separate project; keep the graph a DAG.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.
Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
`Part` declares 16 abstract methods: `addHeader`, `addRawHeader`, `getBody`, `getContentId`, `getContentType`, `getDisposition`, `getHeader`, `getMimeType`, `getServerExtra`, `isMimeType`, `removeHeader`, `setBody`, `setHeader`, `setServerExtra`, `writeHeaderTo`, `writeTo`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — mail/common/src/main/java/com/fsck/k9/mail/Part.java:11
`MessagingListener` declares 23 abstract methods: `checkMailFinished`, `checkMailStarted`, `enableProgressIndicator`, `folderStatusChanged`, `loadAttachmentFailed`, `loadAttachmentFinished`, `loadMessageRemoteFailed`, `loadMessageRemoteFinished`, `messageUidChanged`, `remoteSearchFailed`, `remoteSearchFinished`, `remoteSearchServerQueryComplete`, `remoteSearchStarted`, `synchronizeMailboxFailed`, `synchronizeMailboxFinished`, `synchronizeMailboxHeadersFinished`, `synchronizeMailboxHeadersProgress`, `synchronizeMailboxHeadersStarted`, `synchronizeMailboxNewMessage`, `synchronizeMailboxProgress`, `synchronizeMailboxRemovedMessage`, `synchronizeMailboxStarted`, `updateProgress`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — legacy/message/src/main/java/app/k9mail/legacy/message/controller/MessagingListener.java:12
What to do
Split fat interfaces into focused role-interfaces so clients depend only on what they use.
Do you agree with this assessment?
DM10 · One transaction, one aggregate10.0 / 10Exemplary○ Nothing flagged
Other · Domain Modelling — Whether a single operation mutates more than one aggregate root. An aggregate is a consistency boundary, so saving two together fuses them into one — the second's invariants come to depend on the first's transaction, and the pair can no longer be separated. Reads of other aggregates are not counted.
Method: Neutral body surface (DDD-gated): every method body scanned for repository WRITE calls (Add/Update/Save/Remove/Delete/Insert/Store and their async forms), keyed on the ARGUMENT type rather than the repository type — three `IRepository<T>` writes collapse to one repository but are three distinct aggregates. Reads (Get/Find/Load/Query) are excluded, so loading another aggregate for context never counts. Score is offending methods over methods that write at all. Deterministic.
Do you agree with this assessment?
DM12 · Ambient inputs in the domain10.0 / 10Exemplary○ Nothing flagged
Other · Domain Modelling — Whether domain types receive the time and randomness their rules depend on, rather than reading the process clock or a global random source directly — an ambient read makes the rule it feeds untestable at the instant that matters and lets two reads inside one operation disagree.
Method: Roslyn (DDD-gated, C#/VB only): domain-layer types scanned for ambient reads — DateTime/DateTimeOffset.Now/UtcNow/Today, Random.Shared, new Random(), Stopwatch.GetTimestamp — resolved against the semantic model, with a comment/string-stripped token fallback only where resolution fails. Body reads are scored; field/property initialisers are surfaced unscored. Apply/When folds excluded (ES1 owns them). Deterministic, symbol-resolved.
Other · Domain Modelling — How much of the domain uses strongly-typed ids vs raw Guid/string/int — adoption curve, not all-or-nothing.
Method: Roslyn (DDD-gated): strongly-typed id adoption on domain entities/events; raw Guid/int/string ids counted versus wrapped types. An id wrapper is recognised by VALUE SEMANTICS, not by being a struct — a record struct, a record class (`record ApartmentId(Guid Value)`) or a class declared by a typed-id base (`class MemberId : TypedIdValueBase`) all count, while a plain mutable class (reference equality) and a verb-phrase query record (`GetCustomerById`) do not. Deterministic, adoption percentage.
Coverage: Population: id-like members by *Id/*Key NAME suffix; strongly-typed-ID shape then checked semantically — non-suffixed identifiers are not seen.
`Success.rawNotificationId` is a raw `Int` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int`, in whatever form your language spells that. — feature/notification/api/src/commonMain/kotlin/net/thunderbird/feature/notification/api/command/outcome/NotificationCommandOutcome.kt:27
What to do
Adopt strongly-typed ids across the domain — finish the migration or document the boundary; primitive ids invite transposed-argument bugs.
Other · Domain Modelling — Whether the domain layer stays free of infrastructure dependencies (EF/Marten/HTTP/ASP.NET) — the clean-architecture dependency rule.
Method: Roslyn (DDD-gated): domain-layer types scanned for infrastructure usage in member SIGNATURES and inside method/accessor BODIES — resolved calls and object-creations into EF/Marten/HTTP/Mongo/Redis/message-bus types (not just a namespace allowlist). Deterministic, symbol-resolved, exhaustive over domain-layer bodies, DDD-native.
Coverage: Domain layer identified by NAMESPACE heuristic; infrastructure then resolved by symbol in member SIGNATURES and method/accessor BODIES — rename the layer and the check evaporates.
Other · Domain Modelling — Whether clusters of primitives that travel together (a missing value object) are extracted — a low-weight suggestion, LLM-confirmed when configured.
Method: Roslyn (DDD-gated): primitive parameter clusters recurring three or more times across signatures extracted, then confirmed by language model when configured. Advisory, low-weight.
Other · Domain Modelling — Whether one domain rule is decided — or one measurement produced — in more than one place, rather than living on the type that owns it.
Method: Neutral body surface plus Roslyn (DDD-gated), two arms. DECISION (Roslyn only): a predicate over a domain type's members judged in two or more types, where none of those decisions live on the owning type — operands of comparisons and relational property patterns only, so a member merely passed as an argument is not judged. DERIVATION: a plain all-numeric carrier of ≥2 members, with no base type and exactly one constructor, CONSTRUCTED as the result of a method (returned or assigned, never inline as an argument) in two or more types other than its own — the same measurement produced twice, which centralising the judgement does not fix. DERIVATION runs on every language whose frontend declares the produced-or-passed fact per construction (Roslyn and the Java sidecar today); a target with only the derivation arm carries an engine gap naming the decision arm as not assessed, and a frontend that declares nothing keeps the dimension not measured rather than clean. Single-member rules, test code and generated code are out of population for both. Advisory.
Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
What to do
Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
Add a README to the 136 of 160 project(s) that lack one — worth up to 1.7 pts.
Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).
Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.
app-k9mail/README.md links to `fastlane/metadata`, but `app-k9mail/fastlane/metadata` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — app-k9mail/README.md:9
cli/html-cleaner-cli/README.md links to `../../html-cleaner`, but `html-cleaner` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — cli/html-cleaner-cli/README.md:15
cli/html-cleaner-cli/README.md links to `../../app/html-cleaner/src/main/java/app/k9mail/html/cleaner`, but `app/html-cleaner/src/main/java/app/k9mail/html/cleaner` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — cli/html-cleaner-cli/README.md:17
cli/translation-cli/README.md names `legacy/core/src/res/values/arrays_general_settings_values.xml`, but no file or folder `legacy/core/src/res/values/arrays_general_settings_values.xml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — cli/translation-cli/README.md:28
docs/architecture/README.md names `core/security`, but no file or folder `core/security` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/architecture/README.md:351
docs/architecture/README.md names `core/crypto`, but no file or folder `core/crypto` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/architecture/README.md:354
docs/architecture/README.md names `core/feature-flags`, but no file or folder `core/feature-flags` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/architecture/README.md:355
docs/architecture/README.md names `core/sync`, but no file or folder `core/sync` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/architecture/README.md:356
docs/architecture/module-structure.md links to `adr/0009-api-internal-split.md`, but `docs/architecture/adr/0009-api-internal-split.md` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/architecture/module-structure.md:11
docs/contributing/code-quality-guide.md names `build-plugin/src/main/kotlin/thunderbird.quality.detekt.gradle.kts`, but no file or folder `build-plugin/src/main/kotlin/thunderbird.quality.detekt.gradle.kts` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/contributing/code-quality-guide.md:76
docs/contributing/code-quality-guide.md names `build-plugin/src/main/kotlin/thunderbird.quality.spotless.gradle.kts`, but no file or folder `build-plugin/src/main/kotlin/thunderbird.quality.spotless.gradle.kts` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/contributing/code-quality-guide.md:99
docs/contributing/code-quality-guide.md documents the environment variable `UPPER_SNAKE_CASE`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/contributing/code-quality-guide.md:135
docs/contributing/code-quality-guide.md names `android.yml`, but no file or folder `android.yml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/contributing/code-quality-guide.md:205
docs/contributing/managing-strings.md names `plurals.xml`, but no file or folder `plurals.xml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/contributing/managing-strings.md:29
docs/contributing/managing-strings.md names `legacy/core/src/res/values/arrays_general_settings_values.xml`, but no file or folder `legacy/core/src/res/values/arrays_general_settings_values.xml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/contributing/managing-strings.md:225
docs/contributing/managing-strings.md names `app/core/src/main/res/values/arrays_general_settings_values.xml`, but no file or folder `app/core/src/main/res/values/arrays_general_settings_values.xml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/contributing/managing-strings.md:257
docs/contributing/managing-strings.md names `app/ui/legacy/src/main/res/values/arrays_general_settings_strings.xml`, but no file or folder `app/ui/legacy/src/main/res/values/arrays_general_settings_strings.xml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/contributing/managing-strings.md:265
docs/contributing/testing-guide.md documents the environment variable `CODE_COVERAGE_DISABLED`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/contributing/testing-guide.md:394
docs/developer/foldable-device-support.md names `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/foldable/FoldableStateObserver.kt`, but no file or folder `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/foldable/FoldableStateObserver.kt` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/developer/foldable-device-support.md:36
docs/developer/foldable-device-support.md names `legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MainActivity.kt`, but no file or folder `legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MainActivity.kt` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/developer/foldable-device-support.md:61
docs/release/HISTORICAL_RELEASE.md names `app-k9mail/src/main/res/raw/changelog_master.xml`, but no file or folder `app-k9mail/src/main/res/raw/changelog_master.xml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/release/HISTORICAL_RELEASE.md:60
docs/security/threat-modeling-guide.md documents the environment variable `FLAG_IMMUTABLE`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/security/threat-modeling-guide.md:180
feature/notification/README.md links to `../../components/ui/bolt/src/commonMain/kotlin/net/thunderbird/core/ui/compose/theme2/thunderbird/ThemeColors.kt#L22`, but `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/core/ui/compose/theme2/thunderbird/ThemeColors.kt` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — feature/notification/README.md:108
docs/engineering/technical-designs/0000-technical-design-template.md links to `../rfcs/NNNN-title.md`, but `docs/engineering/rfcs/NNNN-title.md` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/engineering/technical-designs/0000-technical-design-template.md:4
docs/engineering/technical-designs/0000-technical-design-template.md links to `../adr/NNNN-title.md`, but `docs/engineering/adr/NNNN-title.md` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/engineering/technical-designs/0000-technical-design-template.md:5
docs/engineering/technical-designs/0002-feature-flag-declarative-catalog.md documents the environment variable `FLAG_NOT_FOUND`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — docs/engineering/technical-designs/0002-feature-flag-declarative-catalog.md:442
core/ui/compose/testing/README.md links to `../theme/README.md`, but `core/ui/compose/theme/README.md` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — core/ui/compose/testing/README.md:3
What to do
Reconcile the README with reality: app-k9mail/README.md links to `fastlane/metadata`, but `app-k9mail/fastlane/metadata` does not exist; cli/html-cleaner-cli/README.md links to `../../html-cleaner`, but `html-cleaner` does not exist; cli/html-cleaner-cli/README.md links to `../../app/html-cleaner/src/main/java/app/k9mail/html/cleaner`, but `app/html-cleaner/src/main/java/app/k9mail/html/cleaner` does not exist; cli/translation-cli/README.md names `legacy/core/src/res/values/arrays_general_settings_values.xml`, but no file or folder `legacy/core/src/res/values/arrays_general_settings_values.xml` exists; docs/architecture/README.md names `core/security`, but no file or folder `core/security` exists.
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
Do you agree with this assessment?
P10 · Library API & versioning6.0 / 10Adequate✓ Tool-verified
Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.
Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.
73/93 types (78%) declared in the published library are public. For a library, every public type is a stability contract — keep implementation types off the surface and expose only the intended API.
What to do
Keep implementation types off the public surface (Kotlin: `internal`) so internals can change without breaking consumers.
Do you agree with this assessment?
P2 · Observability6.5 / 10Adequate✓ Tool-verified
Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.
Only 26/31 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `cli/autodiscovery-cli`, `cli/html-cleaner-cli`, `cli/resource-mover-cli`, `cli/translation-cli`, `cli/weblate-cli`.
What to do
Extend structured logging to the remaining runnable modules so everything you run is diagnosable in production.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
`security-codeql.yml`, `security-fluidscan.yml`, `security-scorecard.yml` run(s) a static-analysis scan, but no workflow that runs one is triggered by a pull request (or a merge queue, or an unfiltered push) — the scan fires on a schedule or a manual dispatch only. A vulnerable change therefore merges clean and is reported on the next scheduled run, by which time it is on the default branch and the only remedy is a follow-up fix. Add the pull-request trigger to the workflow that runs the scan so the finding arrives before the merge rather than after it.
What to do
Trigger your SAST workflow on pull requests — a scan that only runs on a cron reports history, it does not gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.
Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.
Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.
Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — in .NET Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit; off .NET, with comments and strings blanked, Go's sync.Pool, preallocated slices/maps, Grow, strconv.Append* and buf[:0] reuse; the JVM's NIO buffer views, MemorySegment, primitive collections, pools and literal presizes (plus Kotlin primitive arrays and value classes, Scala AnyVal and @specialized); Swift's reserveCapacity, ContiguousArray, withUnsafe* access and ~Copyable. Activated off .NET on the same floor (400 lines, and benchmarks or 8 uses); Rust and garbage-collected scripting languages are not applicable. Reward-only. Deterministic, syntax/text detection.
What to do
Raise allocation-aware density on the hot paths — currently 75 use(s) across 229,975 production line(s) (~0.3/1k). More of the idioms below on the allocation-heavy paths climbs this toward 10.
Java: on hot paths, work through buffer views (ByteBuffer/LongBuffer slices, MemorySegment) instead of copies, avoid boxing with primitive collections (fastutil, Eclipse Collections, HPPC, Trove), presize collections and StringBuilders, and pool expensive buffers (Netty's pooled allocator, commons-pool).
Kotlin: on hot paths, use primitive arrays (IntArray, LongArray …) and @JvmInline value classes instead of boxed values, primitive collections (androidx.collection, fastutil) instead of boxed ones, and presize collections and StringBuilders.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
Other · Security — Only what this repository's own non-C# files could be read for was assessed — markup this repository SHIPS is scored for third-party script integrity whether or not the repository serves it itself, since a page handed to a consumer runs in that consumer’s origin. Nothing else in this dimension was assessed: the transport, cookie, input-validation and crypto controls are read from a source model that was not loaded for this repository’s language, so their absence here is not a finding about this repository.
Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.
`https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.1/MathJax.js?config=TeX-AMS-MML_HTMLorMML` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. — docs/assets/tb-theme/index.hbs:50
What to do
Pin third-party scripts and verify them: name an exact version in the URL and add an `integrity="sha384-…"` hash alongside `crossorigin="anonymous"` (both are required — an integrity hash on a cross-origin script without `crossorigin` is not evaluated, it blocks the script). Where the vendor ships a continuously-updated loader and publishes no stable hash (tag managers, analytics, chat widgets), Subresource Integrity is not available: constrain it instead with a `Content-Security-Policy` that names the exact origins allowed to execute, and drop the script from the pages that do not need it. Where the page is shipped inside a package that others host, prefer vendoring the asset and serving it from the app’s own origin, so no consumer inherits a third-party dependency they did not choose.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.
Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.
Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.
Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.
Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether suspend functions that make a cancellable request accept or pass on the coroutine's cancellation (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.
Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `NullPointerException` (Java, Kotlin, Scala), `ArgumentError.notNull` (Dart) or `ArgumentNullException` (F#'s `nullArg`) tells the caller a parameter was null when it provably was not.
Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.
Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.
Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.
Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen. Whether a `for` loop leaves the `dict`, `set` or `deque` it is walking alone — CPython's iterators over those check that the collection has not changed size since the loop began, so a body that removes from (or empties) the very collection the loop is walking makes the next step raise `RuntimeError: dictionary changed size during iteration` and the remaining items are never seen. Whether a `for (x in c)` or `c.forEach { … }` leaves the collection it is walking alone — a `mutableListOf`/`ArrayList`, `mutableMapOf`/`HashMap` or `mutableSetOf`/`HashSet` is a `java.util` collection on the JVM and is walked by its own fail-fast iterator, so a body that adds to or removes from the very collection the loop is walking makes the next step throw `ConcurrentModificationException` and the remaining elements are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×4) — core/file/src/commonMain/kotlin/net/thunderbird/core/file/command/CopyCommand.kt:87, core/file/src/commonMain/kotlin/net/thunderbird/core/file/command/CopyCommand.kt:91, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/compose/QuotedMessagePresenter.java:247, …
`catch (_: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×2) — core/file/src/jvmMain/kotlin/net/thunderbird/core/file/JvmFileSystemManager.kt:29, core/file/src/jvmMain/kotlin/net/thunderbird/core/file/JvmFileSystemManager.kt:38
`catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×3) — legacy/core/src/main/java/com/fsck/k9/message/quote/QuoteDateFormatter.kt:19, legacy/ui/legacy/src/main/java/com/fsck/k9/contacts/ContactPictureLoader.kt:104, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagedetails/MessageDetailsViewModel.kt:116
`catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — legacy/ui/legacy/src/main/java/com/fsck/k9/ui/compose/QuotedMessagePresenter.java:234
What to do
Swallowed exception (empty catch)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether Kotlin's null safety is not undermined by not-null assertions — `String` cannot hold null and `String?` must be checked before use in every Kotlin module, and each `!!` is a run-time `NullPointerException` the author has told the compiler cannot happen.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
Do you agree with this assessment?
WCAG coverage — what static analysis assessed
Statically assessed 12 of 55 WCAG 2.2 Level A/AA success criteria (22%; ≈24% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 43 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 4 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
D11 Test Reliability — 1 observation(s) recorded · This repository declares 1 of its own test(s) unreliable. The built-in reliability runner does not support this repository's ecosystem (.kt, .java), so the suite was not re-run and no reliability score is given — these are the repository's own declarations, not our measurement.
X10 Duplicated predicate — 25 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X6 Hand-rolled structured-format parsing — 2 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 2 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 4 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
C3 Audit Trail — Not assessed: this repository stores data through 'android.database.sqlite' (legacy/core/src/main/java/com/fsck/k9/mailstore/LockableDatabase.java:10) but declares no persisted model this check reads (Room/JPA/Spring Data/MongoDB @Entity and Realm classes, Exposed and Ktorm table columns, CREATE TABLE and ALTER TABLE … ADD columns in SQL migrations and SQLDelight files). Personal data may be written through raw SQL or a hosted backend, so whether its changes need an audit trail could not be established, and the trail's absence is not scored.
C4 Data Retention — Not assessed: this repository stores data through 'android.database.sqlite' (legacy/core/src/main/java/com/fsck/k9/mailstore/LockableDatabase.java:10) but declares no persisted model this check reads (Room/JPA/Spring Data/MongoDB @Entity and Realm classes, Exposed and Ktorm table columns, CREATE TABLE and ALTER TABLE … ADD columns in SQL migrations and SQLDelight files). Personal data may be written through raw SQL or a hosted backend, so whether a retention limit applies here could not be established, and its absence is not scored.
C5 Data-Subject Rights — Not assessed: this repository stores data through 'android.database.sqlite' (legacy/core/src/main/java/com/fsck/k9/mailstore/LockableDatabase.java:10) but declares no persisted model this check reads (Room/JPA/Spring Data/MongoDB @Entity and Realm classes, Exposed and Ktorm table columns, CREATE TABLE and ALTER TABLE … ADD columns in SQL migrations and SQLDelight files). Personal data may be written through raw SQL or a hosted backend, so whether data-subject rights apply here could not be established, and their absence is not scored.
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 42 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — No image/media element found in the parsed markup — AC1 not applicable here.
AX1 Captive dependencies — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
AX2 Stateful singletons — No container singleton was found, so there is no shared instance for concurrent requests to race on. No class in this Java code is a Spring, JSR-330 or CDI singleton bean. No class in this Kotlin code is a Spring, JSR-330 or CDI singleton bean. No function in this Python code is served by a threaded web framework (a Flask, Bottle or FastAPI route, a Django or Pyramid view), so no module is shared between request threads. TypeScript/JavaScript runs each process's requests on one event loop, so no two requests write a shared object at the same instant (interleaving across an await is a different defect).
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX8 Test isolation — no test/production split to check
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB1 Runtime evidence locked — no reproducible boot — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
C1 Data Protection — Not assessed: this repository stores data through 'android.database.sqlite' (legacy/core/src/main/java/com/fsck/k9/mailstore/LockableDatabase.java:10) but declares no persisted model this check reads (Room/JPA/Spring Data/MongoDB @Entity and Realm classes, Exposed and Ktorm table columns, CREATE TABLE and ALTER TABLE … ADD columns in SQL migrations and SQLDelight files). Personal data may be written through raw SQL or a hosted backend, so the absence of a personal-data field here is not evidence that none is stored, and encryption at rest is not scored over a subject that could not be established.
C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
D10 Test Quality — ~98436 lines of test source are present (.kt, .java) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
D12 Dependency Hygiene — Not scored — 162 Maven/Gradle manifest(s) were read, stating a version for 150 dependency(ies) and leaving 22 to a parent or an imported BOM, but no build resolved the dependency graph, so the outdated signal was not established. NOT a finding that these dependencies are current or healthy.
D14 License Compliance — Not scored — this repository's 150 declared JVM dependency coordinate(s) were read from its 162 Maven/Gradle manifest(s), but Maven Central could not be asked for the licence of 150 of them (HTTP 429 Too Many Requests from https://repo1.maven.org/maven2/com/android/billingclient/billing/9.1.0/billing-9.1.0.pom), and a licence verdict over part of a dependency graph is not a licence verdict. Nothing is asserted about this repository's licensing in either direction.
D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ projects each declaring an entity of their own. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D24 Comment Value — No inline comments to assess — comment value is not applicable here.
D27 Navigability — D27 counts a call into the standard library or a dependency as unresolved for this repository's language (.kt), so too few call sites counted as resolved to assess navigability. Not scored: this is a gap in the analyzer, not a verdict about this repository.
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D32 Data Compliance (PII/GDPR) — 134 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D8 Code Coverage — Coverage not included — suite not readable by the collector
DM1 Aggregate boundaries — no aggregates detected — aggregate-boundary check not applicable
DM11 Constructible invalid state — no entities detected — construction-time invariants not assessable
DM3 Integration-event coupling — no integration events detected — coupling check not applicable
DM4 Rich vs anemic model — no data-bearing entities detected — rich-vs-anemic model not assessable
DM5 Encapsulated state — no domain entities found — DM5 grades how entities protect their state, and this repository declares none
DM7 Repository granularity — no repository abstraction detected (e.g. uses a document session)
ED1 Event-Driven — not scored — this repository shows only 1 of the 3 signals this lens looks for (6 CQRS handler(s))
ED5 Idempotency — Not assessed, and this one is on us: 6 command handler(s) or message consumer(s) were found here, but this check does not yet recognise persistence writes in this repository's language. Idempotency was neither confirmed nor ruled out — this is a limit of the analyzer, not a finding about your code.
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the JVM, JavaScript/TypeScript, Python source, so there is no service whose uptime a failing dependency could take down
P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
X4 Structured logging — This check asks whether log calls keep a message's values apart from its text, which needs a logger that can carry them as fields. This repository's Kotlin was read, and it logs through none that an assembled message defeats: Android's `Log` and Timber, java.util.logging and log4j-api-kotlin take one finished message (as log4net does in C#), or it makes no call through a named logger at all. Calls made through SLF4J, log4j 2 or kotlin-logging (`LoggerFactory.getLogger`, `KotlinLogging.logger {}`) would be judged.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
Orphaned knowledge legacy/core/src/main/java/com/fsck/k9/helper/MimeTypeUtil.java:1— No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
Orphaned knowledge legacy/ui/legacy/src/main/java/com/fsck/k9/ui/crypto/MessageCryptoHelper.java:1— No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
Orphaned knowledge mail/common/src/main/java/com/fsck/k9/mail/internet/CharsetSupport.java:1— No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
Orphaned knowledge mail/common/src/main/java/com/fsck/k9/mail/filter/Base64.java:1— No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
Orphaned knowledge legacy/core/src/main/java/com/fsck/k9/mailstore/MessageViewInfoExtractor.java:1— No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
Orphaned knowledge legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientLoader.java:1— No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
Orphaned knowledge mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Folder.java:1— No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
Boundary-crossing change coupling: DefaultAccountDefaultsProvider.kt ↔ LegacyAccountStorageHandler.kt app-common/src/main/kotlin/net/thunderbird/app/common/account/DefaultAccountDefaultsProvider.kt:1— `app-common/src/main/kotlin/net/thunderbird/app/common/account/DefaultAccountDefaultsProvider.kt` (context app-common) and `feature/account/storage/legacy/src/main/kotlin/net/thunderbird/feature/account/storage/legacy/LegacyAccountStorageHandler.kt` (context feature) sit in DIFFERENT parts of the tree yet change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `d7a2fbbc` refactor(core): move DEFAULT_VISIBLE_LIMIT from K9 to AccountDefaultP… (at that commit the file was still `legacy/core/src/main/java/com/fsck/k9/AccountPreferenceSerializer.kt`); `40c60c9c` chore: move SpecialFolderSelection to :core:mail:folder:api module (at that commit the files were still `app-common/src/main/kotlin/net/thunderbird/app/common/account/CommonAccountDefaultsProvider.kt` and `legacy/core/src/main/java/com/fsck/k9/AccountPreferenceSerializer.kt`); `a5957898` Refactor: Move :legacy:notification folder content to :feature:notifi… (at that commit the files were still `app-common/src/main/kotlin/net/thunderbird/app/common/account/CommonAccountDefaultsProvider.kt` and `legacy/core/src/main/java/com/fsck/k9/AccountPreferenceSerializer.kt`) — run `git show` on any of them.
Boundary-crossing change coupling: DrawerView.kt ↔ MessageHomeActivity.kt feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerView.kt:1— `feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerView.kt` (context feature) and `legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageHomeActivity.kt` (context legacy) sit in DIFFERENT parts of the tree yet change together 50% of the time (9 of the 18 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `322dcafe` feat(notification-settings): Manage Folders from acct drawer to acct …; `f92b82aa` feat(drawer): add quick action add account (at that commit the file was still `legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageList.kt`); `44eb34ac` fix(drawer): openFolder must be called with accountId and folderId (at that commit the file was still `legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageList.kt`) — run `git show` on any of them.
Boundary-crossing change coupling: FeatureModule.kt ↔ TbFundingSettings.kt app-k9mail/src/main/kotlin/app/k9mail/feature/FeatureModule.kt:1— `app-k9mail/src/main/kotlin/app/k9mail/feature/FeatureModule.kt` (context app-k9mail) and `app-thunderbird/src/main/kotlin/net/thunderbird/android/feature/TbFundingSettings.kt` (context app-thunderbird) sit in DIFFERENT parts of the tree yet change together 50% of the time (7 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `03a3c376` feat(donation-appeal): Updated donation appeal to launch observer onl…; `34021a32` fix(donation appeal): removed the unused scope, attempt to keep activ…; `25b08035` fix(donation-appeal): split out funding config store api classes and … — run `git show` on any of them.
Boundary-crossing change coupling: MessageListLoader.kt ↔ LocalStore.java feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt:1— `feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt` (context feature) and `legacy/core/src/main/java/com/fsck/k9/mailstore/LocalStore.java` (context legacy) sit in DIFFERENT parts of the tree yet change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `dfbbdf8d` refactor(search): rename SqlQueryBuilder to SqlWhereClause; `d26a4792` refactor(search): change SqlQueryBuilder to builder pattern; `0b36cb19` refactor(search): move SqlQueryBuilder to :feature:search module — run `git show` on any of them.
AC3 · Page structure· <iframe> without a title · ×1
<iframe> without a title docs/assets/tb-theme/index.hbs:132— An iframe with no title (or an empty one) is announced only as "frame". Add a non-empty title describing its content, or an aria-label.
AC4 · Keyboard semantics· Clickable element isn't keyboard-operable · ×1
Clickable element isn't keyboard-operable docs/assets/tb-theme/index.hbs:164— The repo's own CSS styles .menu-title with `cursor: pointer`, so this <h1> is a control — but it has no role, no tabindex="0" and no key handler, so it can only be reached with a mouse. Use a <button>, or add role + tabindex="0" + a key handler.
Project dependency cycle — The projects tfa:feature:notification:api → tfa:feature:notification:testing → tfa:feature:notification:api form a reference cycle. Cyclic dependencies prevent independent build/test/deploy, blur ownership, and tend to grow into a big ball of mud. Break the cycle by extracting the shared types into a separate project both can reference.
D11 · Test Reliability· Test declared unreliable · ×1
Test declared unreliable: QrCodeScannerScreen feature/migration/qrcode/src/test/kotlin/app/k9mail/feature/migration/qrcode/ui/QrCodeScannerScreenKtTest.kt:83— This test is disabled or skipped with a reason naming unreliability — the repository's own words: "This test is flaky. Figure out why.". A test that is skipped for flakiness is neither passing nor protecting the code it covers; either stabilise it or delete it, but do not leave it disabled indefinitely. (Found by reading the repository's own test source — the suite itself was not re-run, since the reliability runner does not support this ecosystem.)
TodoComment app-common/src/main/kotlin/net/thunderbird/android/feature/mail/message/reader/api/css/DefaultCssClassNameProvider.kt:18— // TODO(#10498): Remove when UseNewMessageReaderCssStyles is no longer required
TodoComment app-common/src/main/kotlin/net/thunderbird/android/feature/mail/message/reader/api/css/DefaultCssClassNameProvider.kt:25— // TODO(#10498): Remove when UseNewMessageReaderCssStyles is no longer required
TodoComment feature/mail/message/reader/impl/src/commonMain/kotlin/net/thunderbird/feature/mail/message/reader/impl/css/DefaultGlobalCssStyleProvider.kt:58— // TODO(#10498): Remove when UseNewMessageReaderCssStyles is no longer required
TodoComment feature/mail/message/reader/impl/src/commonMain/kotlin/net/thunderbird/feature/mail/message/reader/impl/inject/FeatureMessageReaderModule.kt:36— // TODO(#10498): Remove when UseNewMessageReaderCssStyles is no longer required
TodoComment legacy/core/src/main/java/com/fsck/k9/message/html/HtmlProcessorFactory.kt:20— // TODO(#10498): Remove when UseNewMessageReaderCssStyles is no longer required
TodoComment app-common/src/main/kotlin/net/thunderbird/app/common/account/AccountCreator.kt:44— // TODO Move to feature/account/setup — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment backend/api/src/main/java/com/fsck/k9/backend/api/Backend.kt:24— // TODO: Add a way to cancel the sync process — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:380— // TODO: Only fetch small and large messages if we have some — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment backend/pop3/src/main/java/com/fsck/k9/backend/pop3/Pop3Sync.kt:343— // TODO: Only fetch small and large messages if we have some — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:508— // TODO: This might be the source of poll count errors in the UI. Is todo always the same as ofTotal — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapBackendPusher.kt:199— // TODO: This could be happening because of too many connections to the host. Ideally we'd want to — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment backend/jmap/src/main/java/com/fsck/k9/backend/jmap/JmapBackend.kt:41— // TODO: add support — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment backend/pop3/src/main/java/com/fsck/k9/backend/pop3/Pop3Sync.kt:506— // TODO: This might be the source of poll count errors in the UI. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment backend/pop3/src/main/java/com/fsck/k9/backend/pop3/Pop3Sync.kt:628— // TODO do we need to re-fetch this here? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/swipe/fork/Draggable.kt:17— // TODO(#10676): Delete this file once the `compose-foundation` 1.11.0 is released.
TodoComment core/android/account/src/main/kotlin/net/thunderbird/core/android/account/Identity.kt:16— // TODO remove when callers are converted to Kotlin — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment core/android/account/src/main/kotlin/net/thunderbird/core/android/account/AccountDefaultsProvider.kt:57— // TODO : Remove once storage is migrated to new format — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment core/common/src/commonMain/kotlin/net/thunderbird/core/common/net/HostNameUtils.kt:161— // TODO: support Zone indices in Link-local addresses? Currently they are rejected. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment core/common/src/commonMain/kotlin/net/thunderbird/core/common/resources/StringsResourceManager.kt:3— // TODO: Add support for Multiplatform resources. See https://www.jetbrains.com/help/kotlin-multiplatform-dev/compose-multiplatform-resources.html
TodoComment core/common/src/commonMain/kotlin/net/thunderbird/core/common/resources/PluralsResourceManager.kt:3— // TODO: Add support for Multiplatform resources. See https://www.jetbrains.com/help/kotlin-multiplatform-dev/compose-multiplatform-resources.html
TodoComment core/preference/api/src/commonMain/kotlin/net/thunderbird/core/preference/GeneralSettings.kt:18— // TODO: Move over settings from K9 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment feature/account/server/certificate/src/main/kotlin/app/k9mail/feature/account/server/certificate/domain/usecase/FormatServerCertificateError.kt:33— // TODO: Parse the name to be able to display the components in a more structured way. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/domain/usecase/ValidatePassword.kt:11— // TODO change behavior to allow empty password when no password is required based on auth type — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment feature/account/server/validation/src/main/kotlin/app/k9mail/feature/account/server/validation/ui/ServerValidationContent.kt:59— // TODO add raw error message — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/syncAndNotifications/SyncAndNotificationsSettingsId.kt:4— // TODO #11683
TooManyMethods: MessagingController legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:122— TooManyMethods — 157 methods. The bar is 30 methods; this is 127 over it, 5.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: LegacyMessageListFragment legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:151— TooManyMethods — 130 methods. The bar is 30 methods; this is 100 over it, 4.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MessageListFragment legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:195— TooManyMethods — 121 methods. The bar is 30 methods; this is 91 over it, 4.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MessageHomeActivity legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageHomeActivity.kt:109— TooManyMethods — 88 methods. The bar is 30 methods; this is 58 over it, 2.93× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: LinearLayoutManager ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:45— TooManyMethods — 83 methods. The bar is 30 methods; this is 53 over it, 2.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: LocalFolder legacy/core/src/main/java/com/fsck/k9/mailstore/LocalFolder.java:62— TooManyMethods — 82 methods. The bar is 30 methods; this is 52 over it, 2.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MessageViewFragment legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.kt:113— TooManyMethods — 73 methods. The bar is 30 methods; this is 43 over it, 2.43× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: RecipientPresenter legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientPresenter.kt:59— TooManyMethods — 70 methods. The bar is 30 methods; this is 40 over it, 2.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MessageCompose legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java:174— TooManyMethods — 67 methods. The bar is 30 methods; this is 37 over it, 2.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: TokenCompleteTextView library/token-auto-complete/src/main/java/com/tokenautocomplete/TokenCompleteTextView.java:56— TooManyMethods — 66 methods. The bar is 30 methods; this is 36 over it, 2.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: GeneralSettingsDataStore legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/general/GeneralSettingsDataStore.kt:24— TooManyMethods — 63 methods. The bar is 30 methods; this is 33 over it, 2.10× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: K9MessageStore legacy/storage/src/main/java/com/fsck/k9/storage/messages/K9MessageStore.kt:23— TooManyMethods — 59 methods. The bar is 30 methods; this is 29 over it, 1.97× the bar. Most of these members implement mailstore.MessageStore (54 of 55 members), so moving them onto a smaller type would remove them from that contract rather than reduce it. To reduce it, split the contract instead: give each cohesive group of operations its own smaller interface and its own implementing type. Where the contract has to stay whole, move the work behind these members into collaborator types, so what is left here is a forward per member rather than a responsibility per member.
TooManyMethods: MessageBuilder legacy/core/src/main/java/com/fsck/k9/message/MessageBuilder.java:42— TooManyMethods — 53 methods. The bar is 30 methods; this is 23 over it, 1.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: RealImapConnection mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapConnection.kt:46— TooManyMethods — 53 methods. The bar is 30 methods; this is 23 over it, 1.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: RealImapFolder mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt:33— TooManyMethods — 50 methods. The bar is 30 methods; this is 20 over it, 1.67× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: RecipientMvpView legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientMvpView.kt:23— TooManyMethods — 49 methods. The bar is 30 methods; this is 19 over it, 1.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MimeMessage mail/common/src/main/java/com/fsck/k9/mail/internet/MimeMessage.java:50— TooManyMethods — 47 methods. The bar is 30 methods; this is 17 over it, 1.57× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MessageCryptoHelper legacy/ui/legacy/src/main/java/com/fsck/k9/ui/crypto/MessageCryptoHelper.java:59— TooManyMethods — 46 methods. The bar is 30 methods; this is 16 over it, 1.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: RecipientSelectView legacy/ui/legacy/src/main/java/com/fsck/k9/view/RecipientSelectView.java:59— TooManyMethods — 45 methods. The bar is 30 methods; this is 15 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: LocalStore legacy/core/src/main/java/com/fsck/k9/mailstore/LocalStore.java:68— TooManyMethods — 42 methods. The bar is 30 methods; this is 12 over it, 1.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: Message mail/common/src/main/java/com/fsck/k9/mail/Message.java:22— TooManyMethods — 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: AccountSettingsFragment legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/AccountSettingsFragment.kt:57— TooManyMethods — 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MessageTopView legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/MessageTopView.kt:42— TooManyMethods — 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ItemTouchHelper ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:54— TooManyMethods — 35 methods. The bar is 30 methods; this is 5 over it, 1.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: LocalMessage legacy/core/src/main/java/com/fsck/k9/mailstore/LocalMessage.java:31— TooManyMethods — 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
FixmeComment backend/api/src/main/java/com/fsck/k9/backend/api/BackendFolder.kt:8— // FIXME: add documentation — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment backend/jmap/src/main/java/com/fsck/k9/backend/jmap/JmapBackend.kt:42— // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/molecule/AdaptiveMessageItemHeaderRowPreview.kt:33— // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt:78— // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt:78— // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListLoader.kt:131— // FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment backend/jmap/src/main/java/com/fsck/k9/backend/jmap/CommandSync.kt:116— // FIXME: Add sort parameter — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment core/android/account/src/main/kotlin/net/thunderbird/core/android/account/LegacyAccount.kt:209— // FIXME Java interop code, remove once MessagingController is converted to Kotlin — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment core/android/account/src/main/kotlin/net/thunderbird/core/android/account/LegacyAccount.kt:216— // FIXME Java interop code, remove once MessagingController is converted to Kotlin — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment core/android/account/src/main/kotlin/net/thunderbird/core/android/account/LegacyAccount.kt:223— // FIXME Java interop code, remove once MessagingController is converted to Kotlin — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment core/android/account/src/main/kotlin/net/thunderbird/core/android/account/LegacyAccount.kt:230— // FIXME Java interop code, remove once MessagingController is converted to Kotlin — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment core/android/account/src/main/kotlin/net/thunderbird/core/android/account/LegacyAccount.kt:237— // FIXME Java interop code, remove once MessagingController is converted to Kotlin — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment core/android/account/src/main/kotlin/net/thunderbird/core/android/account/LegacyAccount.kt:244— // FIXME Java interop code, remove once MessagingController is converted to Kotlin — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment core/android/account/src/main/kotlin/net/thunderbird/core/android/account/LegacyAccount.kt:251— // FIXME Java interop code, remove once MessagingController is converted to Kotlin — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment core/android/account/src/main/kotlin/net/thunderbird/core/android/account/LegacyAccount.kt:258— // FIXME Java interop code, remove once MessagingController is converted to Kotlin — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:919— //FIXME: This should never happen. Throw in debug builds. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:1660— //FIXME: When uploading a message to the remote Sent folder the move code creates a placeholder — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment legacy/core/src/main/java/com/fsck/k9/message/MessageBuilder.java:100— //FIXME: check arguments — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment legacy/core/src/main/java/com/fsck/k9/message/IdentityHeaderBuilder.java:49— //FIXME: check arguments — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment legacy/crypto-openpgp/src/main/java/com/fsck/k9/crypto/openpgp/EncryptionDetector.java:17— //FIXME: Make this only detect OpenPGP messages. Move support for S/MIME messages to separate module. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagedetails/MessageDetailsFragment.kt:56— // FIXME: Replace this with a mechanism that survives process death — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:852— // FIXME: Don't save the changes in the UI thread — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:964— // FIXME: Don't save the changes in the UI thread — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment mail/common/src/main/java/com/fsck/k9/mailstore/BinaryMemoryBody.java:36— //FIXME — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment mail/protocols/smtp/src/test/java/com/fsck/k9/mail/transport/smtp/SmtpTransportTest.kt:760— // FIXME: Make sure connection was closed — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
ClassTooLong: MessagingController legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:122— ClassTooLong — 1807 significant lines (blank, comment-only and punctuation-only lines excluded), 157 methods. The bar is 400 significant lines; this is 1407 over it, 4.52× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: LegacyMessageListFragment legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:151— ClassTooLong — 1634 significant lines (blank, comment-only and punctuation-only lines excluded), 130 methods. The bar is 400 significant lines; this is 1234 over it, 4.09× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: MessageListFragment legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:195— ClassTooLong — 1485 significant lines (blank, comment-only and punctuation-only lines excluded), 121 methods. The bar is 400 significant lines; this is 1085 over it, 3.71× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: MessageCompose legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java:174— ClassTooLong — 1388 significant lines (blank, comment-only and punctuation-only lines excluded), 67 methods. The bar is 400 significant lines; this is 988 over it, 3.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: ItemTouchHelper ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:54— ClassTooLong — 1107 significant lines (blank, comment-only and punctuation-only lines excluded), 35 methods. The bar is 400 significant lines; this is 707 over it, 2.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: CharsetSupport mail/common/src/main/java/com/fsck/k9/mail/internet/CharsetSupport.java:17— ClassTooLong — 1028 significant lines (blank, comment-only and punctuation-only lines excluded), 4 methods. The bar is 400 significant lines; this is 628 over it, 2.57× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: MessageHomeActivity legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageHomeActivity.kt:109— ClassTooLong — 1002 significant lines (blank, comment-only and punctuation-only lines excluded), 88 methods. The bar is 400 significant lines; this is 602 over it, 2.51× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: TokenCompleteTextView library/token-auto-complete/src/main/java/com/tokenautocomplete/TokenCompleteTextView.java:56— ClassTooLong — 851 significant lines (blank, comment-only and punctuation-only lines excluded), 66 methods. The bar is 400 significant lines; this is 451 over it, 2.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: RealImapFolder mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt:33— ClassTooLong — 763 significant lines (blank, comment-only and punctuation-only lines excluded), 50 methods. The bar is 400 significant lines; this is 363 over it, 1.91× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: MessageViewFragment legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.kt:113— ClassTooLong — 752 significant lines (blank, comment-only and punctuation-only lines excluded), 73 methods. The bar is 400 significant lines; this is 352 over it, 1.88× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: LocalFolder legacy/core/src/main/java/com/fsck/k9/mailstore/LocalFolder.java:62— ClassTooLong — 750 significant lines (blank, comment-only and punctuation-only lines excluded), 82 methods. The bar is 400 significant lines; this is 350 over it, 1.88× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: LocalStore legacy/core/src/main/java/com/fsck/k9/mailstore/LocalStore.java:68— ClassTooLong — 589 significant lines (blank, comment-only and punctuation-only lines excluded), 42 methods. The bar is 400 significant lines; this is 189 over it, 1.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: GeneralSettingsDataStore legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/general/GeneralSettingsDataStore.kt:24— ClassTooLong — 584 significant lines (blank, comment-only and punctuation-only lines excluded), 63 methods. The bar is 400 significant lines; this is 184 over it, 1.46× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: RealImapConnection mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapConnection.kt:46— ClassTooLong — 572 significant lines (blank, comment-only and punctuation-only lines excluded), 53 methods. The bar is 400 significant lines; this is 172 over it, 1.43× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: MessageCryptoHelper legacy/ui/legacy/src/main/java/com/fsck/k9/ui/crypto/MessageCryptoHelper.java:59— ClassTooLong — 511 significant lines (blank, comment-only and punctuation-only lines excluded), 46 methods. The bar is 400 significant lines; this is 111 over it, 1.28× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: ImapSync backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:30— ClassTooLong — 466 significant lines (blank, comment-only and punctuation-only lines excluded), 15 methods. The bar is 400 significant lines; this is 66 over it, 1.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: RecipientPresenter legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientPresenter.kt:59— ClassTooLong — 454 significant lines (blank, comment-only and punctuation-only lines excluded), 70 methods. The bar is 400 significant lines; this is 54 over it, 1.14× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: RecipientSelectView legacy/ui/legacy/src/main/java/com/fsck/k9/view/RecipientSelectView.java:59— ClassTooLong — 432 significant lines (blank, comment-only and punctuation-only lines excluded), 45 methods. The bar is 400 significant lines; this is 32 over it, 1.08× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Pop3Sync backend/pop3/src/main/java/com/fsck/k9/backend/pop3/Pop3Sync.kt:28— ClassTooLong — 408 significant lines (blank, comment-only and punctuation-only lines excluded), 13 methods. The bar is 400 significant lines; this is 8 over it, 1.02× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: LegacyAccountStorageHandler feature/account/storage/legacy/src/main/kotlin/net/thunderbird/feature/account/storage/legacy/LegacyAccountStorageHandler.kt:28— ClassTooLong — 403 significant lines (blank, comment-only and punctuation-only lines excluded), 8 methods. The bar is 400 significant lines; this is 3 over it, 1.01× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
FileTooLong: controller/MessagingController.java legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java— FileTooLong — 1912 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: MessagingController (122-3034). The bar is 500 significant lines; this is 1412 over it, 3.82× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: messagelist/LegacyMessageListFragment.kt legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt— FileTooLong — 1778 significant lines (blank, comment-only and punctuation-only lines excluded), about 92% of them inside a single declaration: LegacyMessageListFragment (151-2735). The bar is 500 significant lines; this is 1278 over it, 3.56× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: messagelist/MessageListFragment.kt legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt— FileTooLong — 1757 significant lines (blank, comment-only and punctuation-only lines excluded), about 85% of them inside a single declaration: MessageListFragment (195-2560). The bar is 500 significant lines; this is 1257 over it, 3.51× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: activity/MessageCompose.java legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java— FileTooLong — 1557 significant lines (blank, comment-only and punctuation-only lines excluded), about 89% of them inside a single declaration: MessageCompose (174-2308). The bar is 500 significant lines; this is 1057 over it, 3.11× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: linearlayoutmanager/LinearLayoutManager.java ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java— FileTooLong — 1301 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 801 over it, 2.60× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: itemtouchhelper/ItemTouchHelper.java ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java— FileTooLong — 1131 significant lines (blank, comment-only and punctuation-only lines excluded), about 98% of them inside a single declaration: ItemTouchHelper (54-2372). The bar is 500 significant lines; this is 631 over it, 2.26× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: activity/MessageHomeActivity.kt legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageHomeActivity.kt— FileTooLong — 1096 significant lines (blank, comment-only and punctuation-only lines excluded), about 91% of them inside a single declaration: MessageHomeActivity (109-1730). The bar is 500 significant lines; this is 596 over it, 2.19× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: internet/CharsetSupport.java mail/common/src/main/java/com/fsck/k9/mail/internet/CharsetSupport.java— FileTooLong — 1039 significant lines (blank, comment-only and punctuation-only lines excluded), about 99% of them inside a single declaration: CharsetSupport (17-1098). The bar is 500 significant lines; this is 539 over it, 2.08× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: tokenautocomplete/TokenCompleteTextView.java library/token-auto-complete/src/main/java/com/tokenautocomplete/TokenCompleteTextView.java— FileTooLong — 895 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: TokenCompleteTextView (56-1591). The bar is 500 significant lines; this is 395 over it, 1.79× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: messageview/MessageViewFragment.kt legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.kt— FileTooLong — 861 significant lines (blank, comment-only and punctuation-only lines excluded), about 87% of them inside a single declaration: MessageViewFragment (113-1305). The bar is 500 significant lines; this is 361 over it, 1.72× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: mailstore/LocalFolder.java legacy/core/src/main/java/com/fsck/k9/mailstore/LocalFolder.java— FileTooLong — 804 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: LocalFolder (62-1246). The bar is 500 significant lines; this is 304 over it, 1.61× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: imap/RealImapFolder.kt mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt— FileTooLong — 797 significant lines (blank, comment-only and punctuation-only lines excluded), about 96% of them inside a single declaration: RealImapFolder (33-1314). The bar is 500 significant lines; this is 297 over it, 1.59× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: mailstore/LocalStore.java legacy/core/src/main/java/com/fsck/k9/mailstore/LocalStore.java— FileTooLong — 646 significant lines (blank, comment-only and punctuation-only lines excluded), about 91% of them inside a single declaration: LocalStore (68-1065). The bar is 500 significant lines; this is 146 over it, 1.29× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: imap/RealImapConnection.kt mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapConnection.kt— FileTooLong — 611 significant lines (blank, comment-only and punctuation-only lines excluded), about 94% of them inside a single declaration: RealImapConnection (46-959). The bar is 500 significant lines; this is 111 over it, 1.22× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: general/GeneralSettingsDataStore.kt legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/general/GeneralSettingsDataStore.kt— FileTooLong — 605 significant lines (blank, comment-only and punctuation-only lines excluded), about 97% of them inside a single declaration: GeneralSettingsDataStore (24-946). The bar is 500 significant lines; this is 105 over it, 1.21× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: crypto/MessageCryptoHelper.java legacy/ui/legacy/src/main/java/com/fsck/k9/ui/crypto/MessageCryptoHelper.java— FileTooLong — 563 significant lines (blank, comment-only and punctuation-only lines excluded), about 91% of them inside a single declaration: MessageCryptoHelper (59-842). The bar is 500 significant lines; this is 63 over it, 1.13× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: outlined/OutlinedFlowerIcon.kt components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/icon/outlined/OutlinedFlowerIcon.kt— FileTooLong — 550 significant lines (blank, comment-only and punctuation-only lines excluded), about 98% of them inside a single declaration: OutlinedFlowerIcon (11-672). The bar is 500 significant lines; this is 50 over it, 1.10× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: tb-theme/book.js docs/assets/tb-theme/book.js— FileTooLong — 541 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 41 over it, 1.08× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: fork/Draggable.kt components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/swipe/fork/Draggable.kt— FileTooLong — 514 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 14 over it, 1.03× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: compose/RecipientPresenter.kt legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientPresenter.kt— FileTooLong — 506 significant lines (blank, comment-only and punctuation-only lines excluded), about 90% of them inside a single declaration: RecipientPresenter (59-796). The bar is 500 significant lines; this is 6 over it, 1.01× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
Duplicated block (11 lines × 2) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo24.kt:31— legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo24.kt:31-41 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo25.kt:28-38 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (11 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientMvpView.kt:176— legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientMvpView.kt:176-186 | legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/ReplyToView.kt:101-111 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (11 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:350— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:350-360 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:379-389 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (11 lines × 2) app-thunderbird/src/daily/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:9— app-thunderbird/src/daily/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:9-19 | app-thunderbird/src/release/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:9-19 — before extracting anything, compare `app-thunderbird/src/daily/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt` and `app-thunderbird/src/release/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 42 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/template/pager/HorizontalTabPagerPrimary.kt:135— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/template/pager/HorizontalTabPagerPrimary.kt:135-145 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/template/pager/HorizontalTabPagerSecondary.kt:118-128 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/template/pager/HorizontalTabPagerPrimary.kt:135` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `itemContent` to `@Composable (HorizontalTabPagerScope<T, TabPrimaryConfig>.(T) -> Unit)` in one and `@Composable (HorizontalTabPagerScope<T, TabSecondaryConfig>.(T) -> Unit)` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (11 lines × 2) legacy/common/src/main/java/com/fsck/k9/backends/ImapServerSettingsExtensions.kt:9— legacy/common/src/main/java/com/fsck/k9/backends/ImapServerSettingsExtensions.kt:9-19 | legacy/storage/src/main/java/com/fsck/k9/storage/migrations/MigrationTo90.kt:101-111 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 2) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo20.kt:18— legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo20.kt:18-28 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo26.kt:18-28 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo26.kt:16` calls `EmailAddressValidator` and `legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo20.kt:17` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:746— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:746-756 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:659-669 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (11 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:901— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:901-911 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:790-800 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (11 lines × 2) legacy/storage/src/main/java/com/fsck/k9/storage/messages/KeyValueStoreOperations.kt:71— legacy/storage/src/main/java/com/fsck/k9/storage/messages/KeyValueStoreOperations.kt:71-81 | legacy/storage/src/main/java/com/fsck/k9/storage/messages/KeyValueStoreOperations.kt:102-112 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/storage/src/main/java/com/fsck/k9/storage/messages/KeyValueStoreOperations.kt:71` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) legacy/mailstore/src/main/java/app/k9mail/legacy/mailstore/folder/DefaultFolderDetailsRepository.kt:83— legacy/mailstore/src/main/java/app/k9mail/legacy/mailstore/folder/DefaultFolderDetailsRepository.kt:83-93 | legacy/mailstore/src/main/java/app/k9mail/legacy/mailstore/folder/DefaultFolderDetailsRepository.kt:113-123 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/mailstore/src/main/java/app/k9mail/legacy/mailstore/folder/DefaultFolderDetailsRepository.kt:83` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:1382— legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:1382-1392 | legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:1401-1411 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) mail/common/src/main/java/com/fsck/k9/mail/helper/Rfc822Tokenizer.java:62— mail/common/src/main/java/com/fsck/k9/mail/helper/Rfc822Tokenizer.java:62-72 | mail/common/src/main/java/com/fsck/k9/mail/helper/Rfc822Tokenizer.java:147-157 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (11 lines × 2) mail/common/src/main/java/com/fsck/k9/mail/helper/Rfc822Tokenizer.java:86— mail/common/src/main/java/com/fsck/k9/mail/helper/Rfc822Tokenizer.java:86-96 | mail/common/src/main/java/com/fsck/k9/mail/helper/Rfc822Tokenizer.java:114-124 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `mail/common/src/main/java/com/fsck/k9/mail/helper/Rfc822Tokenizer.java:86` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java:174— legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java:174-184 | legacy/core/src/main/java/com/fsck/k9/provider/DecryptedFileProvider.java:181-191 — before extracting anything, compare `legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java` and `legacy/core/src/main/java/com/fsck/k9/provider/DecryptedFileProvider.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 73 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Off the main sequence: tfa:core:mail:mailserver — tfa:core:mail:mailserver: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
Off the main sequence: tfa:core:testing — tfa:core:testing: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 5 project(s), so it's rigid to change.
Off the main sequence: tfa:legacy:di — tfa:legacy:di: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
Off the main sequence: tfa:legacy:logging — tfa:legacy:logging: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 25 project(s), so it's rigid to change.
Off the main sequence: tfa:core:android:permissions — tfa:core:android:permissions: abstractness 0.13, instability 0.00, distance 0.88 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
Off the main sequence: tfa:ui-utils:toolbar-bottom-sheet — tfa:ui-utils:toolbar-bottom-sheet: abstractness 0.13, instability 0.00, distance 0.88 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
Off the main sequence: tfa:library:html-cleaner — tfa:library:html-cleaner: abstractness 0.14, instability 0.00, distance 0.86 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
Off the main sequence: tfa:core:ui:legacy:designsystem — tfa:core:ui:legacy:designsystem: abstractness 0.00, instability 0.17, distance 0.83 — zone of pain — concrete and depended on by 5 project(s), so it's rigid to change.
Off the main sequence: tfa:library:token-auto-complete — tfa:library:token-auto-complete: abstractness 0.20, instability 0.00, distance 0.80 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
Off the main sequence: tfa:ui-utils:linear-layout-manager — tfa:ui-utils:linear-layout-manager: abstractness 0.21, instability 0.00, distance 0.79 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
Off the main sequence: tfa:core:preference:api — tfa:core:preference:api: abstractness 0.13, instability 0.09, distance 0.78 — zone of pain — concrete and depended on by 10 project(s), so it's rigid to change.
Off the main sequence: tfa:core:ui:setting:api — tfa:core:ui:setting:api: abstractness 0.22, instability 0.00, distance 0.78 — zone of pain — concrete and depended on by 4 project(s), so it's rigid to change.
Off the main sequence: tfa:core:file — tfa:core:file: abstractness 0.25, instability 0.00, distance 0.75 — zone of pain — concrete and depended on by 7 project(s), so it's rigid to change.
Off the main sequence: tfa:ui-utils:item-touch-helper — tfa:ui-utils:item-touch-helper: abstractness 0.25, instability 0.00, distance 0.75 — zone of pain — concrete and depended on by 1 project(s), so it's rigid to change.
Off the main sequence: tfa:core:validation — tfa:core:validation: abstractness 0.29, instability 0.00, distance 0.71 — zone of pain — concrete and depended on by 4 project(s), so it's rigid to change.
Duplicated block (10 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/ErrorBannerInlineNotificationCard.kt:66— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/ErrorBannerInlineNotificationCard.kt:66-75 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/ErrorBannerInlineNotificationCard.kt:84-93 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/ErrorBannerInlineNotificationCard.kt:66` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/InfoBannerInlineNotificationCard.kt:66— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/InfoBannerInlineNotificationCard.kt:66-75 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/InfoBannerInlineNotificationCard.kt:84-93 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/InfoBannerInlineNotificationCard.kt:66` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/SuccessBannerInlineNotificationCard.kt:66— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/SuccessBannerInlineNotificationCard.kt:66-75 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/SuccessBannerInlineNotificationCard.kt:84-93 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/SuccessBannerInlineNotificationCard.kt:66` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/WarningBannerInlineNotificationCard.kt:66— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/WarningBannerInlineNotificationCard.kt:66-75 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/WarningBannerInlineNotificationCard.kt:84-93 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/WarningBannerInlineNotificationCard.kt:66` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1846— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1846-1855 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1657-1666 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1846` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2374— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2374-2383 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1993-2002 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) app-k9mail/src/debug/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt:97— app-k9mail/src/debug/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt:97-106 | app-k9mail/src/release/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt:97-106 — before extracting anything, compare `app-k9mail/src/debug/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt` and `app-k9mail/src/release/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 42 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (10 lines × 2) feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt:26— feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt:26-35 | feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt:26-35 — before extracting anything, compare `feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt` and `feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt:37— feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt:37-46 | feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt:37-46 — before extracting anything, compare `feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt` and `feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (10 lines × 2) legacy/core/src/main/java/com/fsck/k9/message/extractors/BodyTextExtractor.java:26— legacy/core/src/main/java/com/fsck/k9/message/extractors/BodyTextExtractor.java:26-35 | legacy/core/src/main/java/com/fsck/k9/message/extractors/BodyTextExtractor.java:40-49 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/core/src/main/java/com/fsck/k9/message/extractors/BodyTextExtractor.java:26` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java:120— legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java:120-129 | legacy/core/src/main/java/com/fsck/k9/provider/DecryptedFileProvider.java:100-109 — before extracting anything, compare `legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java` and `legacy/core/src/main/java/com/fsck/k9/provider/DecryptedFileProvider.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 73 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java:120` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (10 lines × 2) ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:1974— ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:1974-1983 | ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:1991-2000 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:1974` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java:131— legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java:131-140 | legacy/core/src/main/java/com/fsck/k9/provider/DecryptedFileProvider.java:111-120 — before extracting anything, compare `legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java` and `legacy/core/src/main/java/com/fsck/k9/provider/DecryptedFileProvider.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 73 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/PgpInlineDialog.java:23— legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/PgpInlineDialog.java:23-32 | legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/PgpSignOnlyDialog.java:23-32 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsViewModel.kt:39— feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsViewModel.kt:39-45 | feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsViewModel.kt:34-40 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: `Event` names `app.k9mail.feature.account.server.settings.ui.incoming.IncomingServerSettingsContract.Event` in one and `app.k9mail.feature.account.server.settings.ui.outgoing.OutgoingServerSettingsContract.Event` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (7 lines × 2) feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsViewModel.kt:104— feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsViewModel.kt:104-110 | feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsViewModel.kt:67-73 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsViewModel.kt:104` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) feature/mail/message/list/internal/src/main/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/component/MessageItemSwipeBackground.kt:136— feature/mail/message/list/internal/src/main/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/component/MessageItemSwipeBackground.kt:136-142 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/SwipeResourceProvider.kt:24-30 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `feature/mail/message/list/internal/src/main/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/component/MessageItemSwipeBackground.kt:136` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: `Icons` names `app.k9mail.core.ui.legacy.designsystem.atom.icon.Icons` in one and `net.thunderbird.components.ui.bolt.atom.icon.Icons` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (7 lines × 2) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapConnection.kt:799— mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapConnection.kt:799-805 | mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapConnection.kt:831-837 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapConnection.kt:799` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListItemMapper.kt:62— feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListItemMapper.kt:62-68 | feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListItemMapper.kt:62-68 — before extracting anything, compare `feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListItemMapper.kt` and `feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListItemMapper.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt:62— feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt:62-68 | feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt:62-68 — before extracting anything, compare `feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt` and `feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:624— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:624-630 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:546-552 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:682— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:682-689 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:583-589 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (7 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1679— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1679-1685 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1508-1514 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (7 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2351— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2351-2357 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1970-1976 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (7 lines × 2) mail/common/src/main/java/com/fsck/k9/mail/internet/MessageIdParser.kt:191— mail/common/src/main/java/com/fsck/k9/mail/internet/MessageIdParser.kt:191-197 | mail/common/src/main/java/com/fsck/k9/mail/internet/MimeHeaderChecker.kt:108-114 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (7 lines × 2) legacy/mailstore/src/main/java/app/k9mail/legacy/mailstore/folder/DefaultRemoteFolderDetailsRepository.kt:49— legacy/mailstore/src/main/java/app/k9mail/legacy/mailstore/folder/DefaultRemoteFolderDetailsRepository.kt:49-55 | legacy/mailstore/src/main/java/app/k9mail/legacy/mailstore/folder/DefaultRemoteFolderQueryRepository.kt:39-46 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/mailstore/src/main/java/app/k9mail/legacy/mailstore/folder/DefaultRemoteFolderDetailsRepository.kt:49` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:114— legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:114-120 | legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:173-179 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:114` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/view/RecipientSelectView.java:556— legacy/ui/legacy/src/main/java/com/fsck/k9/view/RecipientSelectView.java:556-563 | library/token-auto-complete/src/main/java/com/tokenautocomplete/TokenCompleteTextView.java:835-841 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `obj` to `Recipient` in one and `T` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Change coupling: K9StoragePersister.java ↔ StorageMigrations.kt legacy/storage/src/main/java/com/fsck/k9/preferences/K9StoragePersister.java:1— `legacy/storage/src/main/java/com/fsck/k9/preferences/K9StoragePersister.java` and `legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrations.kt` change together 100% of the time (12 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 12 shared commits counted here, the most recent 3 are `e7835fd1` fix(account): preserve account state during setup and storage migration; `c13787f9` feat(settings): Animation setting inherits systemwide settings; `465159cd` feat: add migration to rename preference key from account_setup_auto_… — run `git show` on any of them.
Change coupling: IncomingServerSettingsContent.kt ↔ OutgoingServerSettingsContent.kt feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsContent.kt:1— `feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsContent.kt` and `feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsContent.kt` change together 65% of the time (17 of the 26 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 17 shared commits counted here, the most recent 3 are `9885f38b` chore(ui-test): extract hardcoded test tags to test tag objects; `9eaec506` fix: prevent double ime padding for edit server settings; `b17e0bdc` refactor(compose): replace LocalContext.current.resources by LocalRes… — run `git show` on any of them.
Change coupling: DropDownDrawer.kt ↔ DrawerViewModel.kt feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/DropDownDrawer.kt:1— `feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/DropDownDrawer.kt` and `feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerViewModel.kt` change together 62% of the time (10 of the 16 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `322dcafe` feat(notification-settings): Manage Folders from acct drawer to acct …; `f92b82aa` feat(drawer): add quick action add account; `44eb34ac` fix(drawer): openFolder must be called with accountId and folderId — run `git show` on any of them.
Change coupling: DrawerContentPreview.kt ↔ DrawerViewModel.kt feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:1— `feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt` and `feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerViewModel.kt` change together 62% of the time (10 of the 16 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `413bda28` refactor: hoist showAccountSelector settings from DrawerConfig to Dra…; `dd842775` Fix drawer not updating on account changes (at that commit the files were still `feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/DrawerContentPreview.kt` and `feature/navigation/drawer/src/main/kotlin/app/k9mail/feature/navigation/drawer/ui/DrawerViewModel.kt`); `9d5fccb5` Rename accountUuid to accountId (at that commit the files were still `feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/DrawerContentPreview.kt` and `feature/navigation/drawer/src/main/kotlin/app/k9mail/feature/navigation/drawer/ui/DrawerViewModel.kt`) — run `git show` on any of them.
Change coupling: TextFieldOutlined.kt ↔ TextFieldItems.kt components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/textfield/TextFieldOutlined.kt:1— `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/textfield/TextFieldOutlined.kt` and `components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/atom/items/TextFieldItems.kt` change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `544acf75` Move icons to design system (at that commit the files were still `core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/atom/textfield/TextFieldOutlined.kt` and `app-ui-catalog/src/main/java/app/k9mail/ui/catalog/ui/atom/items/TextFieldItems.kt`); `fccf89f3` Add TextInput and add singleLine to TextFieldOutlined (at that commit the files were still `core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/atom/textfield/TextFieldOutlined.kt` and `app-ui-catalog/src/main/java/app/k9mail/ui/catalog/ui/atom/items/TextFieldItems.kt`); `7f2f5e21` Add read-only to TextFieldOutlined atom (at that commit the files were still `core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/atom/textfield/TextFieldOutlined.kt` and `app-ui-catalog/src/main/java/app/k9mail/ui/catalog/items/TextFieldItems.kt`) — run `git show` on any of them.
Change coupling: NotificationPreference.kt ↔ SingleMessageNotificationDataCreator.kt core/preference/api/src/commonMain/kotlin/net/thunderbird/core/preference/notification/NotificationPreference.kt:1— `core/preference/api/src/commonMain/kotlin/net/thunderbird/core/preference/notification/NotificationPreference.kt` and `legacy/core/src/main/java/com/fsck/k9/notification/SingleMessageNotificationDataCreator.kt` change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `f1c63584` Unified to list handling directly; `4db2791c` refactor: use PreferenceDataStore for notificationQuickDeleteBehaviour; `cfcc6fca` Added star, moved options to common source of truth — run `git show` on any of them.
Change coupling: FeatureFundingModule.kt ↔ BillingClient.kt feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/FeatureFundingModule.kt:1— `feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/FeatureFundingModule.kt` and `feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/data/remote/bilingclient/BillingClient.kt` change together 57% of the time (8 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `df28120e` feat(funding): add purchased contribution; `55bafd33` refactor(funding): decouple purchase flow from using Activity and use…; `01cf6450` refactor(funding): rename GoogleBillingClient to BillingClient — run `git show` on any of them.
Change coupling: DrawerContentPreview.kt ↔ FakeData.kt feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:1— `feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt` and `feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/FakeData.kt` change together 54% of the time (7 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `c943c778` Add more drawer preview for corner cases (at that commit the files were still `feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/DrawerContentPreview.kt` and `feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/FakeData.kt`); `dd842775` Fix drawer not updating on account changes (at that commit the files were still `feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/DrawerContentPreview.kt` and `feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/FakeData.kt`); `9d5fccb5` Rename accountUuid to accountId (at that commit the files were still `feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/DrawerContentPreview.kt` and `feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/FakeData.kt`) — run `git show` on any of them.
Change coupling: LocalStore.java ↔ MessageListLoader.kt legacy/core/src/main/java/com/fsck/k9/mailstore/LocalStore.java:1— `legacy/core/src/main/java/com/fsck/k9/mailstore/LocalStore.java` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListLoader.kt` change together 50% of the time (9 of the 18 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `dfbbdf8d` refactor(search): rename SqlQueryBuilder to SqlWhereClause; `d26a4792` refactor(search): change SqlQueryBuilder to builder pattern; `0b36cb19` refactor(search): move SqlQueryBuilder to :feature:search module — run `git show` on any of them.
Change coupling: TextFieldOutlinedPassword.kt ↔ TextFieldItems.kt components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/textfield/TextFieldOutlinedPassword.kt:1— `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/textfield/TextFieldOutlinedPassword.kt` and `components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/atom/items/TextFieldItems.kt` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `a5faea80` Change compose design system to use outlined icons (at that commit the files were still `core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/atom/textfield/TextFieldOutlinedPassword.kt` and `app-ui-catalog/src/main/java/app/k9mail/ui/catalog/ui/atom/items/TextFieldItems.kt`); `544acf75` Move icons to design system (at that commit the files were still `core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/atom/textfield/TextFieldOutlinedPassword.kt` and `app-ui-catalog/src/main/java/app/k9mail/ui/catalog/ui/atom/items/TextFieldItems.kt`); `7f2f5e21` Add read-only to TextFieldOutlined atom (at that commit the files were still `core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/atom/textfield/TextFieldOutlinedPassword.kt` and `app-ui-catalog/src/main/java/app/k9mail/ui/catalog/items/TextFieldItems.kt`) — run `git show` on any of them.
Change coupling: DefaultDrawerConfigManager.kt ↔ DefaultGeneralSettingsManager.kt legacy/core/src/main/java/com/fsck/k9/preferences/DefaultDrawerConfigManager.kt:1— `legacy/core/src/main/java/com/fsck/k9/preferences/DefaultDrawerConfigManager.kt` and `legacy/core/src/main/java/com/fsck/k9/preferences/DefaultGeneralSettingsManager.kt` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `07d516a7` refactor: refactor DisplaySettings to introduce DefaultDisplayInboxSe…; `0b2821c5` refactor: rename RealGeneralSettingsManager → DefaultGeneralSettingsM…; `55fa9f80` refactor(core-preference): move StorageEditor, StoragePersistor and S… (at that commit the files were still `legacy/core/src/main/java/com/fsck/k9/preferences/RealDrawerConfigManager.kt` and `legacy/core/src/main/java/com/fsck/k9/preferences/RealGeneralSettingsManager.kt`) — run `git show` on any of them.
Change coupling: AccountSetupNavigation.kt ↔ OnboardingNavigation.kt feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/navigation/AccountSetupNavigation.kt:1— `feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/navigation/AccountSetupNavigation.kt` and `feature/onboarding/main/src/main/kotlin/app/k9mail/feature/onboarding/main/navigation/OnboardingNavigation.kt` change together 50% of the time (6 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `f16c1298` refactor(navigation): change package to net.thunderbird.core.ui.compo…; `fe33dd2c` Add permissions screen to onboarding flow; `2f9f757e` Change to deep link navigation (at that commit the file was still `feature/onboarding/src/main/kotlin/app/k9mail/feature/onboarding/navigation/OnboardingNavigation.kt`) — run `git show` on any of them.
Change coupling: DefaultMessageCountsProvider.kt ↔ MessageStore.kt legacy/core/src/main/java/com/fsck/k9/controller/DefaultMessageCountsProvider.kt:1— `legacy/core/src/main/java/com/fsck/k9/controller/DefaultMessageCountsProvider.kt` and `legacy/mailstore/src/main/java/app/k9mail/legacy/mailstore/MessageStore.kt` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `593cbcad` refactor(search): rename ConditionsTreeNode to SearchConditionTreeNode; `99f03db1` Move `SearchSpecification`, `ConditionsTreeNode` and `LocalSearch` to… (at that commit the files were still `legacy/core/src/main/java/com/fsck/k9/controller/MessageCountsProvider.kt` and `legacy/core/src/main/java/com/fsck/k9/mailstore/MessageStore.kt`); `b5964f32` Change `DefaultMessageCountsProvider` to support `LocalSearch.conditi… (at that commit the files were still `app/core/src/main/java/com/fsck/k9/controller/MessageCountsProvider.kt` and `app/core/src/main/java/com/fsck/k9/mailstore/MessageStore.kt`) — run `git show` on any of them.
MethodTooLong: CharsetSupport.importCodePointFromIphone mail/common/src/main/java/com/fsck/k9/mail/internet/CharsetSupport.java:121— MethodTooLong — importCodePointFromIphone runs 974 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 874 over it, 9.74× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ColorItemsKt.colorItems components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/atom/items/ColorItems.kt:10— MethodTooLong — colorItems runs 218 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 118 over it, 2.18× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: MessageCompose.onCreate legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java:325— MethodTooLong — onCreate runs 195 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 95 over it, 1.95× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: HearthSunburstKt.createInstance feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:43— MethodTooLong — createInstance runs 190 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 90 over it, 1.90× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: LegacyAccountStorageHandler.load feature/account/storage/legacy/src/main/kotlin/net/thunderbird/feature/account/storage/legacy/LegacyAccountStorageHandler.kt:36— MethodTooLong — load runs 186 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 86 over it, 1.86× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: StoreSchemaDefinition.dbCreateDatabaseFromScratch legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:77— MethodTooLong — dbCreateDatabaseFromScratch runs 174 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 74 over it, 1.74× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ImapSync.synchronizeMailboxSynchronous backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:40— MethodTooLong — synchronizeMailboxSynchronous runs 131 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 31 over it, 1.31× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: FetchingMailSettingsViewModel.event feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsViewModel.kt:48— MethodTooLong — event runs 131 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 31 over it, 1.31× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: SendingMailSettingsViewModel.event feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/sendingMail/SendingMailSettingsViewModel.kt:51— MethodTooLong — event runs 122 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 22 over it, 1.22× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: InputItemsKt.inputItems components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/InputItems.kt:19— MethodTooLong — inputItems runs 110 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 10 over it, 1.10× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: AccountSettingsWriter.createAccount legacy/core/src/main/java/com/fsck/k9/preferences/AccountSettingsWriter.kt:95— MethodTooLong — createAccount runs 108 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 8 over it, 1.08× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: Pop3Sync.synchronizeMailboxSynchronous backend/pop3/src/main/java/com/fsck/k9/backend/pop3/Pop3Sync.kt:45— MethodTooLong — synchronizeMailboxSynchronous runs 106 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 6 over it, 1.06× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
Hotspot: legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java:325— legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java changed 22 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 36 in MessageCompose.onCreate at line 325. 6 of those changes were fix/bug commits, and the other 16 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageHomeActivity.kt legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageHomeActivity.kt:495— legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageHomeActivity.kt changed 16 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in MessageHomeActivity.decodeExtrasToLaunchData at line 495. 7 of those changes were fix/bug commits, and the other 9 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageHomeActivity.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:2154— legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java changed 11 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in MessagingController.deleteMessagesSynchronous at line 2154. 2 of those changes were fix/bug commits, and the other 9 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.kt legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.kt:480— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.kt changed 9 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 28 in MessageViewFragment.selectMenuItem at line 480. 1 of those changes was a fix/bug commit, and the other 8 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: legacy/core/src/main/java/com/fsck/k9/preferences/SettingsExporter.kt legacy/core/src/main/java/com/fsck/k9/preferences/SettingsExporter.kt:139— legacy/core/src/main/java/com/fsck/k9/preferences/SettingsExporter.kt changed 8 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 24 in SettingsExporter.writeAccount at line 139. 2 of those changes were fix/bug commits, and the other 6 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- legacy/core/src/main/java/com/fsck/k9/preferences/SettingsExporter.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/AccountSettingsDataStore.kt legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/AccountSettingsDataStore.kt:173— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/AccountSettingsDataStore.kt changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 26 in AccountSettingsDataStore.putString at line 173. 2 of those changes were fix/bug commits, and the other 2 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/AccountSettingsDataStore.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:40— backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 29 in ImapSync.synchronizeMailboxSynchronous at line 40. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: scripts/ci/render-notes.py scripts/ci/render-notes.py:27— scripts/ci/render-notes.py changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 32 in render-notes.render_notes at line 27. 1 of those changes was a fix/bug commit, and the other 1 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- scripts/ci/render-notes.py`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: feature/debug-settings/src/main/kotlin/net/thunderbird/feature/debug/settings/notification/DebugNotificationSectionViewModel.kt feature/debug-settings/src/main/kotlin/net/thunderbird/feature/debug/settings/notification/DebugNotificationSectionViewModel.kt:215— feature/debug-settings/src/main/kotlin/net/thunderbird/feature/debug/settings/notification/DebugNotificationSectionViewModel.kt changed 4 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in DebugNotificationSectionViewModel.buildNotification at line 215. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- feature/debug-settings/src/main/kotlin/net/thunderbird/feature/debug/settings/notification/DebugNotificationSectionViewModel.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt:572— mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 20 in RealImapFolder.fetch at line 572. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/domain/usecase/UpdateSendingMailSettings.kt feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/domain/usecase/UpdateSendingMailSettings.kt:31— feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/domain/usecase/UpdateSendingMailSettings.kt changed 2 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 15 in UpdateSendingMailSettings.updatedWith at line 31. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/domain/usecase/UpdateSendingMailSettings.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Duplicated block (9 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/choosefolder/ChooseFolderActivity.kt:209— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/choosefolder/ChooseFolderActivity.kt:209-217 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/managefolders/ManageFoldersFragment.kt:159-167 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1212— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1212-1220 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1098-1106 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (9 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1552— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1552-1560 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1383-1391 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1562` calls `computeBatchDirection` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1392` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2506— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2506-2514 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:2125-2133 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2506` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) app-k9mail/src/debug/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt:109— app-k9mail/src/debug/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt:109-117 | app-k9mail/src/release/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt:109-117 — before extracting anything, compare `app-k9mail/src/debug/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt` and `app-k9mail/src/release/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 42 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1653— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1653-1661 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1482-1490 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/domain/AutoDiscoveryMapper.kt:24— feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/domain/AutoDiscoveryMapper.kt:24-32 | feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/domain/AutoDiscoveryMapper.kt:56-64 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/domain/AutoDiscoveryMapper.kt:24` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:1970— legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:1970-1978 | legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:2202-2210 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (9 lines × 2) legacy/core/src/main/java/com/fsck/k9/message/MessageBuilder.java:252— legacy/core/src/main/java/com/fsck/k9/message/MessageBuilder.java:252-260 | legacy/core/src/main/java/com/fsck/k9/message/MessageBuilder.java:269-277 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `legacy/core/src/main/java/com/fsck/k9/message/MessageBuilder.java:278` calls `addHeader` and `legacy/core/src/main/java/com/fsck/k9/message/MessageBuilder.java:262` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9 lines × 2) mail/common/src/main/java/com/fsck/k9/mail/internet/EncoderUtil.java:85— mail/common/src/main/java/com/fsck/k9/mail/internet/EncoderUtil.java:85-93 | mail/common/src/main/java/com/fsck/k9/mail/internet/EncoderUtil.java:115-123 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `mail/common/src/main/java/com/fsck/k9/mail/internet/EncoderUtil.java:85` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) mail/common/src/main/java/com/fsck/k9/mail/internet/MimeBodyPart.java:173— mail/common/src/main/java/com/fsck/k9/mail/internet/MimeBodyPart.java:173-181 | mail/common/src/main/java/com/fsck/k9/mail/internet/MimeMessage.java:458-467 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (8 lines × 2) feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsViewModel.kt:116— feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsViewModel.kt:116-123 | feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsViewModel.kt:78-85 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsViewModel.kt:116` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsViewModel.kt:124` calls `updateFromValidationOutcome` and `feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsViewModel.kt:86` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 2) feature/mail/message/list/internal/src/main/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/MessageListScreenAccessibilityState.kt:163— feature/mail/message/list/internal/src/main/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/MessageListScreenAccessibilityState.kt:163-170 | feature/mail/message/list/internal/src/main/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/component/MessageItemSwipeBackground.kt:152-159 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `feature/mail/message/list/internal/src/main/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/MessageListScreenAccessibilityState.kt:163` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:978— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:978-985 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:867-874 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:978` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `sortType` to `SortType` in one and `LegacySortType` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (8 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:989— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:989-996 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:878-885 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:989` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `sortType` to `SortType` in one and `LegacySortType` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (8 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1994— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1994-2001 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1801-1808 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (8 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagesource/MessageSourceActivity.kt:38— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagesource/MessageSourceActivity.kt:38-45 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/push/PushInfoActivity.kt:25-32 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/AccountSettingsActivity.kt:107— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/AccountSettingsActivity.kt:107-114 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/general/GeneralSettingsActivity.kt:139-146 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:277— legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:277-284 | legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:292-299 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/AttachmentPresenter.java:174— legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/AttachmentPresenter.java:174-181 | legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/AttachmentPresenter.java:192-199 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/AttachmentPresenter.java:174` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/AlternateRecipientAdapter.java:100— legacy/ui/legacy/src/main/java/com/fsck/k9/activity/AlternateRecipientAdapter.java:100-107 | legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientAdapter.java:73-80 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (19 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowPrimary.kt:132— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowPrimary.kt:132-150 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:81-99 — before extracting anything, compare `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowPrimary.kt` and `components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowPrimary.kt:132` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowSecondary.kt:97— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowSecondary.kt:97-115 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:185-203 — before extracting anything, compare `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowSecondary.kt` and `components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 54 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowSecondary.kt:97` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowSecondary.kt:125— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowSecondary.kt:125-143 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:209-227 — before extracting anything, compare `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowSecondary.kt` and `components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 54 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowSecondary.kt:125` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/TopAppBar.kt:100— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/TopAppBar.kt:100-118 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/organism/items/AppBarItems.kt:29-47 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/TopAppBar.kt:100` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/setting/AccountSettingList.kt:26— feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/setting/AccountSettingList.kt:26-44 | feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/setting/FolderSettingList.kt:26-44 — before extracting anything, compare `feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/setting/AccountSettingList.kt` and `feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/setting/FolderSettingList.kt` as WHOLE FILES: 85% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/setting/AccountSettingList.kt:26` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:759— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:759-777 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:672-690 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (19 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1411— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1411-1429 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1290-1308 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (19 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2322— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2322-2340 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1941-1959 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2322` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/BasicDialog.kt:189— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/BasicDialog.kt:189-205 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/organism/items/dialogs/BasicDialogItems.kt:123-139 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (17 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/BannerInlineNotificationCard.kt:336— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/BannerInlineNotificationCard.kt:336-352 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/BannerInlineNotificationCard.kt:362-378 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/BannerInlineNotificationCard.kt:336` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsContent.kt:99— feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsContent.kt:99-115 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/advanced/AdvancedFetchingMailSettingsContent.kt:45-61 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsContent.kt:99` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) feature/debug-settings/src/debug/kotlin/net/thunderbird/feature/debug/settings/notification/DebugNotificationSectionPreview.kt:25— feature/debug-settings/src/debug/kotlin/net/thunderbird/feature/debug/settings/notification/DebugNotificationSectionPreview.kt:25-41 | feature/debug-settings/src/debug/kotlin/net/thunderbird/feature/debug/settings/notification/DebugNotificationSectionPreview.kt:57-73 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feature/debug-settings/src/debug/kotlin/net/thunderbird/feature/debug/settings/notification/DebugNotificationSectionPreview.kt:25` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/account/AccountListItemBadge.kt:37— feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/account/AccountListItemBadge.kt:37-53 | feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/folder/FolderListItemBadge.kt:37-53 — before extracting anything, compare `feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/account/AccountListItemBadge.kt` and `feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/folder/FolderListItemBadge.kt` as WHOLE FILES: 89% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/account/AccountListItemBadge.kt:37` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/choosefolder/ChooseFolderActivity.kt:160— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/choosefolder/ChooseFolderActivity.kt:160-176 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/managefolders/ManageFoldersFragment.kt:125-141 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (17 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1166— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1166-1182 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1057-1073 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1166` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:2297— legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:2297-2313 | legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:2358-2374 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:2297` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/button/ButtonFilled.kt:28— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/button/ButtonFilled.kt:28-42 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/button/ButtonOutlined.kt:39-53 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/button/ButtonFilled.kt:28` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (15 lines × 2) components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:41— components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:41-55 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:170-184 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:41` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (15 lines × 2) components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:66— components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:66-80 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:194-208 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:66` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (15 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1570— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1570-1584 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1399-1413 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (15 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1591— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1591-1605 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1420-1434 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (15 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2555— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2555-2569 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:2174-2188 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2555` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsValidator.kt:18— feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsValidator.kt:18-36 | feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsValidator.kt:15-29 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15 lines × 2) legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:219— legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:219-233 | legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:239-253 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:219` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/BannerInlineNotificationCard.kt:288— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/BannerInlineNotificationCard.kt:288-299 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/BannerInlineNotificationCard.kt:320-331 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/BannerInlineNotificationCard.kt:288` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt:49— feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt:49-60 | feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt:49-60 — before extracting anything, compare `feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt` and `feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (12 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1262— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1262-1273 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1141-1152 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (12 lines × 2) app-k9mail/src/debug/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt:34— app-k9mail/src/debug/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt:34-45 | app-k9mail/src/release/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt:34-45 — before extracting anything, compare `app-k9mail/src/debug/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt` and `app-k9mail/src/release/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 42 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/icon/BadgeIconBuilder.kt:57— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/icon/BadgeIconBuilder.kt:57-68 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/icon/IconBuilder.kt:63-74 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (12 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/BannerInlineNotificationCard.kt:264— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/BannerInlineNotificationCard.kt:264-275 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/BannerInlineNotificationCard.kt:319-330 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/inline/BannerInlineNotificationCard.kt:264` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java:107— legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java:107-118 | legacy/core/src/main/java/com/fsck/k9/provider/DecryptedFileProvider.java:87-98 — before extracting anything, compare `legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java` and `legacy/core/src/main/java/com/fsck/k9/provider/DecryptedFileProvider.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 73 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java:107` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java:204— legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java:204-215 | legacy/core/src/main/java/com/fsck/k9/provider/DecryptedFileProvider.java:211-222 — before extracting anything, compare `legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java` and `legacy/core/src/main/java/com/fsck/k9/provider/DecryptedFileProvider.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 73 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:186— feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:186-191 | feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:214-219 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListItemMapper.kt:23— feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListItemMapper.kt:23-28 | feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListItemMapper.kt:23-28 — before extracting anything, compare `feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListItemMapper.kt` and `feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListItemMapper.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:894— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:894-899 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:783-788 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (6 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2476— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2476-2481 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:2095-2100 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `accountId` to `AccountId?` in one and `AccountId` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (6 lines × 2) legacy/core/src/main/java/com/fsck/k9/mailstore/MimePartStreamParser.java:158— legacy/core/src/main/java/com/fsck/k9/mailstore/MimePartStreamParser.java:158-163 | mail/common/src/main/java/com/fsck/k9/mail/internet/MimeMessage.java:590-595 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (6 lines × 2) legacy/core/src/main/java/com/fsck/k9/mailstore/MimePartStreamParser.java:166— legacy/core/src/main/java/com/fsck/k9/mailstore/MimePartStreamParser.java:166-171 | mail/common/src/main/java/com/fsck/k9/mail/internet/MimeMessage.java:598-603 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (6 lines × 2) legacy/core/src/main/java/com/fsck/k9/mailstore/MimePartStreamParser.java:206— legacy/core/src/main/java/com/fsck/k9/mailstore/MimePartStreamParser.java:206-211 | mail/common/src/main/java/com/fsck/k9/mail/internet/MimeMessage.java:495-500 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (6 lines × 2) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo2.java:45— legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo2.java:45-50 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo2.java:90-95 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Swallowed exception (caught, then discarded) core/file/src/jvmMain/kotlin/net/thunderbird/core/file/JvmFileSystemManager.kt:29— `catch (_: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) core/file/src/jvmMain/kotlin/net/thunderbird/core/file/JvmFileSystemManager.kt:38— `catch (_: Throwable)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) legacy/core/src/main/java/com/fsck/k9/message/quote/QuoteDateFormatter.kt:19— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) legacy/ui/legacy/src/main/java/com/fsck/k9/contacts/ContactPictureLoader.kt:104— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/compose/QuotedMessagePresenter.java:234— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagedetails/MessageDetailsViewModel.kt:116— `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
AC6 · Visual & motion safety· Animation without a prefers-reduced-motion guard · ×5
Animation without a prefers-reduced-motion guard docs/assets/tb-theme/css/chrome.css:383— `#fa-spin` moves (`animation: rotating 2s linear infinite`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard docs/assets/tb-theme/css/chrome.css:499— `html:not(.sidebar-resizing) .sidebar` moves (`transition: transform 0.3s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard docs/assets/tb-theme/css/chrome.css:631— `.chapter-fold-toggle div` moves (`transition: transform 0.5s`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard docs/assets/tb-theme/css/general.css:92— `html:not(.js) .page-wrapper` moves (`transition: margin-left 0.3s ease, transform 0.3s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Animation without a prefers-reduced-motion guard docs/assets/tb-theme/css/general.css:96— `[dir=rtl]:not(.js) .page-wrapper` moves (`transition: margin-right 0.3s ease, transform 0.3s ease`) and nothing reads prefers-reduced-motion for it — no @media (prefers-reduced-motion) rule for this element, no reset this project loads — so a motion-sensitive user cannot turn it off (WCAG 2.3.3). Declare it under @media (prefers-reduced-motion: no-preference), or neutralise it under reduce.
Repeated repair: app-k9mail/src/main/kotlin/app/k9mail/feature/K9FundingSettings.kt app-k9mail/src/main/kotlin/app/k9mail/feature/K9FundingSettings.kt:8— app-k9mail/src/main/kotlin/app/k9mail/feature/K9FundingSettings.kt changed 15 times in last 90 days and 9 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is K9FundingSettings.isReady at line 8), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(donation-appeal): removed K-9 code, but leaving the class as to not require a larger refactor of MessageHomeActivity. This requires Detekt ignore these empty codeblocks for now. A larger refactor of this system is being planned that would not require this class to exist.”; “fix(donation-appeal) Nullable Funding Config Store defaults added to allow us to check that the config store is loaded and ready before testing values. Updated tests to match new expected outputs.”; “fix(donation-appeal) Fixed the breaking test for the new logic that does store the new timestamp for the second reminder, as new requirements dictate wwe only show the second reminder if the first does not display. Moved asserts to assertk, removed redundant code.”; “fix(donation appeal): removed the unused scope, attempt to keep activity observer to not register multiple times.”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- app-k9mail/src/main/kotlin/app/k9mail/feature/K9FundingSettings.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: app-thunderbird/src/main/kotlin/net/thunderbird/android/feature/TbFundingSettings.kt app-thunderbird/src/main/kotlin/net/thunderbird/android/feature/TbFundingSettings.kt:13— app-thunderbird/src/main/kotlin/net/thunderbird/android/feature/TbFundingSettings.kt changed 13 times in last 90 days and 8 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is TbFundingSettings.isReady at line 13), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(donation-appeal) Nullable Funding Config Store defaults added to allow us to check that the config store is loaded and ready before testing values. Updated tests to match new expected outputs.”; “fix(donation-appeal) Fixed the breaking test for the new logic that does store the new timestamp for the second reminder, as new requirements dictate wwe only show the second reminder if the first does not display. Moved asserts to assertk, removed redundant code.”; “fix(donation appeal): removed the unused scope, attempt to keep activity observer to not register multiple times.”; “fix(donation-appeals): Improved the concurrency of reading values”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- app-thunderbird/src/main/kotlin/net/thunderbird/android/feature/TbFundingSettings.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: app-common/src/main/kotlin/net/thunderbird/app/common/feature/funding/configstore/FundingConfigMapper.kt app-common/src/main/kotlin/net/thunderbird/app/common/feature/funding/configstore/FundingConfigMapper.kt:9— app-common/src/main/kotlin/net/thunderbird/app/common/feature/funding/configstore/FundingConfigMapper.kt changed 8 times in last 90 days and 7 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is FundingConfigMapper.toConfig at line 9), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(donation-appeal) Nullable Funding Config Store defaults added to allow us to check that the config store is loaded and ready before testing values. Updated tests to match new expected outputs.”; “fix(donation-appeal) performance fixes and race condition elimination. Updated tests to reflect fixes.”; “fix(donation-appeal) Fix for empty update.”; “fix(donation-appeal): Fixed the issue with the activity not registering, was launching the check between activities switching, now waits to do check after resume. Fixed bug with reading null values from datastore”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- app-common/src/main/kotlin/net/thunderbird/app/common/feature/funding/configstore/FundingConfigMapper.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: legacy/core/src/main/java/com/fsck/k9/preferences/AccountSettingsWriter.kt legacy/core/src/main/java/com/fsck/k9/preferences/AccountSettingsWriter.kt:86— legacy/core/src/main/java/com/fsck/k9/preferences/AccountSettingsWriter.kt changed 9 times in last 90 days and 5 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is AccountSettingsWriter.enum at line 86), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: changing XML export and import to transfer K-9 avatar to tb -removed unused imports”; “fix: changing XML export and import to transfer K-9 avatar to tb -fixed merge conflicts”; “fix: changing XML export and import to transfer K-9 avatar to tb -Changed the importer -Tests are missing”; “fix(account): keep account changes consistent after moving to immutable accounts”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- legacy/core/src/main/java/com/fsck/k9/preferences/AccountSettingsWriter.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: app-common/src/main/kotlin/net/thunderbird/app/common/feature/funding/configstore/DefaultFundingConfigStore.kt app-common/src/main/kotlin/net/thunderbird/app/common/feature/funding/configstore/DefaultFundingConfigStore.kt:31— app-common/src/main/kotlin/net/thunderbird/app/common/feature/funding/configstore/DefaultFundingConfigStore.kt changed 7 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 1 (its worst body is DefaultFundingConfigStore.safeUpdate at line 31), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(donation-appeal) Fixed the breaking test for the new logic that does store the new timestamp for the second reminder, as new requirements dictate wwe only show the second reminder if the first does not display. Moved asserts to assertk, removed redundant code.”; “fix(donation-appeals): Improved the concurrency of reading values”; “fix(donation-appeal): Moved the api to the feature funding api module.”; “fix(donation-appeal): split out funding config store api classes and added implementation in original package.”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-24..2026-10-22, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-24 11:31:00 -03:00' --until='2026-10-22 11:31:00 -03:00' --full-history --no-merges -- app-common/src/main/kotlin/net/thunderbird/app/common/feature/funding/configstore/DefaultFundingConfigStore.kt`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Duplicated block (16 lines × 2) feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:114— feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:114-129 | feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:140-155 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:114` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:524— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:524-539 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:501-516 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (16 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2386— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2386-2401 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:2005-2020 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (16 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/template/ListDetailPane.kt:204— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/template/ListDetailPane.kt:204-219 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/template/items/LayoutItems.kt:131-146 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 2) legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:225— legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:225-240 | legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:245-262 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:225` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) legacy/storage/src/main/java/com/fsck/k9/storage/messages/DeleteMessageOperations.kt:91— legacy/storage/src/main/java/com/fsck/k9/storage/messages/DeleteMessageOperations.kt:91-104 | legacy/storage/src/main/java/com/fsck/k9/storage/messages/MoveMessageOperations.kt:116-129 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (14 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2518— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2518-2531 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:2137-2150 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2518` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (14 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:731— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:731-744 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:644-657 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (14 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1629— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1629-1642 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1458-1471 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1629` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 2) legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:186— legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:186-199 | legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:213-228 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:186` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (13 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/template/pager/HorizontalTabPagerPrimary.kt:94— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/template/pager/HorizontalTabPagerPrimary.kt:94-106 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/template/pager/HorizontalTabPagerSecondary.kt:81-93 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (13 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:862— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:862-874 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:769-781 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:862` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:861` calls `putLongArray`, `toLongArray` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:767` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (13 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:509— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:509-521 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:486-498 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (13 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1612— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1612-1624 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1441-1453 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1612` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2407— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2407-2419 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:2026-2038 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×4
Members sharing a duplicated core (4 members, 50+ identical tokens) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/global/ErrorBannerGlobalNotificationCard.kt:65— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/global/ErrorBannerGlobalNotificationCard.kt:65-87 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/global/InfoBannerGlobalNotificationCard.kt:122-144 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/global/SuccessBannerGlobalNotificationCard.kt:122-144 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/global/WarningBannerGlobalNotificationCard.kt:122-144 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsContent.kt:34— feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsContent.kt:34-92 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/readingMail/ReadingMailSettingsContent.kt:34-90 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/search/SearchSettingContent.kt:30-86 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/sendingMail/SendingMailSettingsContent.kt:33-90 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:190— feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:190-210 | feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:214-234 | feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:238-264 | feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:268-294 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/ImapStoreUriDecoder.java:35— legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/ImapStoreUriDecoder.java:35-143 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/Pop3StoreUriDecoder.java:34-105 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/SmtpTransportUriDecoder.java:30-99 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/WebDavStoreUriDecoder.java:26-119 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Duplicated block (22 lines × 2) backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:172— backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:172-193 | backend/pop3/src/main/java/com/fsck/k9/backend/pop3/Pop3Sync.kt:146-167 — before extracting anything, compare `backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt` and `backend/pop3/src/main/java/com/fsck/k9/backend/pop3/Pop3Sync.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 51 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:172` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (22 lines × 2) feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/content/IncomingFormItems.kt:57— feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/content/IncomingFormItems.kt:57-78 | feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/content/OutgoingFormItems.kt:46-67 — before extracting anything, compare `feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/content/IncomingFormItems.kt` and `feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/content/OutgoingFormItems.kt` as WHOLE FILES: 83% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/content/IncomingFormItems.kt:57` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note first that the copies are not typed on the same thing: `Event` names `app.k9mail.feature.account.server.settings.ui.incoming.IncomingServerSettingsContract.Event` in one and `app.k9mail.feature.account.server.settings.ui.outgoing.OutgoingServerSettingsContract.Event` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (22 lines × 2) feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItem.kt:43— feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItem.kt:43-64 | feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/UnreadMessageItem.kt:43-64 — before extracting anything, compare `feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItem.kt` and `feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/UnreadMessageItem.kt` as WHOLE FILES: 93% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItem.kt:43` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (22 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:454— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:454-475 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:448-469 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:454` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsViewModel.kt:33— feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsViewModel.kt:33-37 | feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsViewModel.kt:28-32 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: `Event` names `app.k9mail.feature.account.server.settings.ui.incoming.IncomingServerSettingsContract.Event` in one and `app.k9mail.feature.account.server.settings.ui.outgoing.OutgoingServerSettingsContract.Event` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsViewModel.kt:29` calls `updateProtocolType` and `feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsViewModel.kt:24` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1005— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1005-1009 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:894-898 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (5 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1037— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1037-1041 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:926-930 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (5 lines × 2) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:1202— ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:1202-1206 | ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:1229-1233 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:1202` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Swallowed exception (empty catch) core/file/src/commonMain/kotlin/net/thunderbird/core/file/command/CopyCommand.kt:87— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) core/file/src/commonMain/kotlin/net/thunderbird/core/file/command/CopyCommand.kt:91— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/compose/QuotedMessagePresenter.java:247— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) mail/protocols/smtp/src/main/java/com/fsck/k9/mail/transport/smtp/SmtpTransport.kt:442— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Change-coupling hub: GeneralSettingsDataStore.kt → DisplayVisualSettings.kt, NotificationPreference.kt, DefaultDisplayVisualSettingsPreferenceManager.kt, GeneralSettingsDescriptions.java legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/general/GeneralSettingsDataStore.kt— `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/general/GeneralSettingsDataStore.kt` changes together with 4 other files — `core/preference/api/src/commonMain/kotlin/net/thunderbird/core/preference/display/visualSettings/DisplayVisualSettings.kt`, `core/preference/api/src/commonMain/kotlin/net/thunderbird/core/preference/notification/NotificationPreference.kt`, `core/preference/impl/src/commonMain/kotlin/net/thunderbird/core/preference/display/visualSettings/DefaultDisplayVisualSettingsPreferenceManager.kt`, `legacy/core/src/main/java/com/fsck/k9/preferences/GeneralSettingsDescriptions.java` — none of which declares a dependency on it: one file is the hub of 4 separate couplings, not 4 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 4.
Change-coupling hub: K9.kt → GeneralSettings.kt, DisplayVisualSettings.kt, DefaultDrawerConfigManager.kt, MessageListActivityConfig.kt, GeneralSettingsDataStore.kt legacy/core/src/main/java/com/fsck/k9/K9.kt— `legacy/core/src/main/java/com/fsck/k9/K9.kt` changes together with 5 other files — `core/preference/api/src/commonMain/kotlin/net/thunderbird/core/preference/GeneralSettings.kt`, `core/preference/api/src/commonMain/kotlin/net/thunderbird/core/preference/display/visualSettings/DisplayVisualSettings.kt`, `legacy/core/src/main/java/com/fsck/k9/preferences/DefaultDrawerConfigManager.kt`, `legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageListActivityConfig.kt`, `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/general/GeneralSettingsDataStore.kt` — none of which declares a dependency on it: one file is the hub of 5 separate couplings, not 5 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 5.
Change-coupling hub: RetrieveFolderOperations.kt → DefaultMessageCountsProvider.kt, LocalStore.java, MessageStore.kt legacy/storage/src/main/java/com/fsck/k9/storage/messages/RetrieveFolderOperations.kt— `legacy/storage/src/main/java/com/fsck/k9/storage/messages/RetrieveFolderOperations.kt` changes together with 3 other files — `legacy/core/src/main/java/com/fsck/k9/controller/DefaultMessageCountsProvider.kt`, `legacy/core/src/main/java/com/fsck/k9/mailstore/LocalStore.java`, `legacy/mailstore/src/main/java/app/k9mail/legacy/mailstore/MessageStore.kt` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
Duplicated block (39 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1290— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1290-1328 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1169-1207 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1290` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (39 lines × 2) feature/account/edit/src/main/kotlin/app/k9mail/feature/account/edit/ui/server/settings/EditIncomingServerSettingsNavHost.kt:38— feature/account/edit/src/main/kotlin/app/k9mail/feature/account/edit/ui/server/settings/EditIncomingServerSettingsNavHost.kt:38-76 | feature/account/edit/src/main/kotlin/app/k9mail/feature/account/edit/ui/server/settings/EditOutgoingServerSettingsNavHost.kt:38-76 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `feature/account/edit/src/main/kotlin/app/k9mail/feature/account/edit/ui/server/settings/EditIncomingServerSettingsNavHost.kt:38` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (39 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/PgpInlineDialog.java:35— legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/PgpInlineDialog.java:35-73 | legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/PgpSignOnlyDialog.java:35-73 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (35 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1331— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1331-1365 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1210-1244 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (35 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2629— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2629-2663 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:2248-2282 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2629` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (35 lines × 2) scripts/changelog/generate_changelog_json.py:50— scripts/changelog/generate_changelog_json.py:50-84 | scripts/changelog/migrate_changelog_to_json.py:76-110 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (21 lines × 2) legacy/core/src/main/java/com/fsck/k9/notification/AuthenticationErrorNotificationController.kt:28— legacy/core/src/main/java/com/fsck/k9/notification/AuthenticationErrorNotificationController.kt:28-48 | legacy/core/src/main/java/com/fsck/k9/notification/CertificateErrorNotificationController.kt:28-48 — before extracting anything, compare `legacy/core/src/main/java/com/fsck/k9/notification/AuthenticationErrorNotificationController.kt` and `legacy/core/src/main/java/com/fsck/k9/notification/CertificateErrorNotificationController.kt` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/core/src/main/java/com/fsck/k9/notification/AuthenticationErrorNotificationController.kt:28` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (21 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:542— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:542-562 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:519-539 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (21 lines × 2) scripts/changelog/generate_changelog_json.py:158— scripts/changelog/generate_changelog_json.py:158-178 | scripts/changelog/migrate_changelog_to_json.py:116-136 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (18 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/template/Scaffold.kt:61— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/template/Scaffold.kt:61-78 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/template/Scaffold.kt:93-110 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/template/Scaffold.kt:61` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:663— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:663-680 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:564-581 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (18 lines × 2) legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java:155— legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java:155-172 | legacy/core/src/main/java/com/fsck/k9/provider/DecryptedFileProvider.java:162-179 — before extracting anything, compare `legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java` and `legacy/core/src/main/java/com/fsck/k9/provider/DecryptedFileProvider.java` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 73 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
ActionModeCallback.setContextCapabilities (cognitive 23) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2554— ActionModeCallback.setContextCapabilities has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (20 pts), boolean chains 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ActionModeCallback.setContextCapabilities (cognitive 23) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:2173— ActionModeCallback.setContextCapabilities has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (20 pts), boolean chains 3 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RealImapFolderIdler.idle (cognitive 20) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolderIdler.kt:34— RealImapFolderIdler.idle has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 3 (5 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (RealImapFolderIdler.idle) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
RealImapFolderIdler.idle (cognitive 20) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolderIdler.kt:74— RealImapFolderIdler.idle has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (14 pts), loops 3 (5 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (RealImapFolderIdler.idle) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
Duplicated block (31 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1087— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1087-1117 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:978-1008 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1087` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (31 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2572— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2572-2602 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:2191-2221 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2572` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (30 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:367— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:367-396 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:396-425 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:367` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (30 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:788— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:788-817 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:697-726 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (27 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/text/TextAutoResize.kt:25— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/text/TextAutoResize.kt:25-51 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/text/TextAutoResize.kt:64-90 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (27 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2666— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2666-2692 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:2285-2311 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2666` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (26 lines × 2) feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:239— feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:239-264 | feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:269-294 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (26 lines × 2) legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:80— legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:80-105 | legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:158-183 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:80` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (24 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/theme/k9mail/K9MailBoltTheme.kt:25— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/theme/k9mail/K9MailBoltTheme.kt:25-48 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/theme/thunderbird/ThunderbirdBoltTheme.kt:25-48 — before extracting anything, compare `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/theme/k9mail/K9MailBoltTheme.kt` and `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/theme/thunderbird/ThunderbirdBoltTheme.kt` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/theme/k9mail/K9MailBoltTheme.kt:25` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (24 lines × 2) feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/ui/options/display/DisplayOptionsScreen.kt:28— feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/ui/options/display/DisplayOptionsScreen.kt:28-51 | feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/ui/options/sync/SyncOptionsScreen.kt:28-51 — before extracting anything, compare `feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/ui/options/display/DisplayOptionsScreen.kt` and `feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/ui/options/sync/SyncOptionsScreen.kt` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/ui/options/display/DisplayOptionsScreen.kt:28` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: `Effect` names `app.k9mail.feature.account.setup.ui.options.display.DisplayOptionsContract.Effect` in one and `app.k9mail.feature.account.setup.ui.options.sync.SyncOptionsContract.Effect` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (23 lines × 2) feature/account/server/validation/src/main/kotlin/app/k9mail/feature/account/server/validation/ui/ServerValidationMainScreen.kt:36— feature/account/server/validation/src/main/kotlin/app/k9mail/feature/account/server/validation/ui/ServerValidationMainScreen.kt:36-58 | feature/account/server/validation/src/main/kotlin/app/k9mail/feature/account/server/validation/ui/ServerValidationToolbarScreen.kt:30-52 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `feature/account/server/validation/src/main/kotlin/app/k9mail/feature/account/server/validation/ui/ServerValidationMainScreen.kt:36` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23 lines × 2) feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListItemMapper.kt:37— feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListItemMapper.kt:37-59 | feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListItemMapper.kt:37-59 — before extracting anything, compare `feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListItemMapper.kt` and `feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListItemMapper.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 36 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListItemMapper.kt:37` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (20 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowPrimary.kt:103— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowPrimary.kt:103-122 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:56-75 — before extracting anything, compare `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowPrimary.kt` and `components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowPrimary.kt:103` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1240— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1240-1259 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1119-1138 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1240` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 4) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/global/ErrorBannerGlobalNotificationCard.kt:71— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/global/ErrorBannerGlobalNotificationCard.kt:71-87 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/global/InfoBannerGlobalNotificationCard.kt:128-144 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/global/SuccessBannerGlobalNotificationCard.kt:128-144 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/global/WarningBannerGlobalNotificationCard.kt:128-144 — before extracting anything, compare `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/global/InfoBannerGlobalNotificationCard.kt` and `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/global/SuccessBannerGlobalNotificationCard.kt` as WHOLE FILES: 83% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/banner/global/ErrorBannerGlobalNotificationCard.kt:71` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 4) feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:194— feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:194-210 | feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:218-234 | feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:247-263 | feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:277-293 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerContentPreview.kt:194` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15–16 lines × 6) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowPrimary.kt:82— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowPrimary.kt:82-96 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowPrimary.kt:110-125 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowPrimary.kt:138-153 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:39-53 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:63-78 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:87-102 — before extracting anything, compare `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowPrimary.kt` and `components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 55 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowPrimary.kt:82` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15–16 lines × 6) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowSecondary.kt:76— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowSecondary.kt:76-90 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowSecondary.kt:103-118 | components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowSecondary.kt:131-146 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:168-182 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:191-206 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt:215-230 — before extracting anything, compare `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowSecondary.kt` and `components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/TabRowItems.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 54 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/tab/TabRowSecondary.kt:76` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14–16 lines × 2) backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:238— backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:238-251 | backend/pop3/src/main/java/com/fsck/k9/backend/pop3/Pop3Sync.kt:213-228 — before extracting anything, compare `backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt` and `backend/pop3/src/main/java/com/fsck/k9/backend/pop3/Pop3Sync.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 51 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:238` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14–16 lines × 2) legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:202— legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:202-215 | legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:217-232 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:202` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 3) components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/atom/items/TextFieldItems.kt:189— components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/atom/items/TextFieldItems.kt:189-198 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/atom/items/TextFieldItems.kt:211-220 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/atom/items/TextFieldItems.kt:233-242 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/atom/items/TextFieldItems.kt:189` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 3) legacy/core/src/main/java/com/fsck/k9/preferences/AccountSettingsDescriptions.java:458— legacy/core/src/main/java/com/fsck/k9/preferences/AccountSettingsDescriptions.java:458-467 | legacy/core/src/main/java/com/fsck/k9/preferences/Settings.java:420-429 | legacy/core/src/main/java/com/fsck/k9/preferences/Settings.java:453-462 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart.
Duplicated block (15 lines × 3) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/IntentItem.kt:23— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/IntentItem.kt:23-37 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/SettingsActionItem.kt:23-37 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/UrlActionItem.kt:22-36 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/IntentItem.kt:23` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `v` to `View) = ViewHolder(v) class ViewHolder(view: View) : FastAdapter.ViewHolder<IntentItem>(view` in one and `View) = ViewHolder(v) class ViewHolder(view: View) : FastAdapter.ViewHolder<SettingsActionItem>(view` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (15 lines × 3) legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:123— legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:123-137 | legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:156-170 | legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:182-196 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:123` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10–11 lines × 2) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo2.java:68— legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo2.java:68-77 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo2.java:78-88 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo2.java:68` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10–11 lines × 2) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:1167— ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:1167-1177 | ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:1185-1194 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Low cohesion: RecipientMvpView (LCOM4 6) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientMvpView.kt:23— RecipientMvpView's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: TbFundingSettings (LCOM4 4) app-thunderbird/src/main/kotlin/net/thunderbird/android/feature/TbFundingSettings.kt:9— TbFundingSettings's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
AC6 · Visual & motion safety· Focus outline removed in CSS without a · ×1
Focus outline removed in CSS without a :focus replacement docs/assets/tb-theme/css/general.css:82— `.page` sets the outline to none/0 and no visible :focus / :focus-visible style for that element replaces it in this stylesheet, so a keyboard user cannot see where focus is. Draw a focus ring (outline, box-shadow or border) under :focus-visible.
AC7 · A11y enforcement· Accessibility enforcement below the top rung · ×1
Accessibility enforcement below the top rung — No accessibility enforcement found — no accessibility linting at author time and no automated accessibility check in tests or CI. Add your UI toolkit's own accessibility assertion to the test suite (Flutter `meetsGuideline`, Espresso `AccessibilityChecks`, XCTest `performAccessibilityAudit`), then gate that test in the pipeline. What was searched, so you can tell an absence from a miss: the 3 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.
MessageHomeActivity.onCustomKeyDown (cyclomatic 48) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageHomeActivity.kt:890— MessageHomeActivity.onCustomKeyDown has cyclomatic complexity 48 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MessageCompose.onCreate (cyclomatic 36) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java:325— MessageCompose.onCreate has cyclomatic complexity 36 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
render-notes.render_notes (cyclomatic 32) scripts/ci/render-notes.py:27— render-notes.render_notes has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
StorageMigrations.upgradeDatabase (cyclomatic 30) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrations.kt:8— StorageMigrations.upgradeDatabase has cyclomatic complexity 30 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
HttpUriParser.tryMatchIpv6Address (cyclomatic 29) legacy/core/src/main/java/com/fsck/k9/message/html/HttpUriParser.kt:122— HttpUriParser.tryMatchIpv6Address has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapSync.synchronizeMailboxSynchronous (cyclomatic 29) backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:40— ImapSync.synchronizeMailboxSynchronous has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Migrations.upgradeDatabase (cyclomatic 28) legacy/storage/src/main/java/com/fsck/k9/storage/migrations/Migrations.kt:9— Migrations.upgradeDatabase has cyclomatic complexity 28 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
LinearLayoutManager.onLayoutChildren (cyclomatic 28) ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:434— LinearLayoutManager.onLayoutChildren has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Rfc822Tokenizer.tokenize (cyclomatic 27) mail/common/src/main/java/com/fsck/k9/mail/helper/Rfc822Tokenizer.java:44— Rfc822Tokenizer.tokenize has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SettingsExporter.writeAccount (cyclomatic 24) legacy/core/src/main/java/com/fsck/k9/preferences/SettingsExporter.kt:139— SettingsExporter.writeAccount has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ItemTouchHelper.select (cyclomatic 24) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:583— ItemTouchHelper.select has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
QuotedMessagePresenter.processDraftMessage (cyclomatic 24) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/compose/QuotedMessagePresenter.java:199— QuotedMessagePresenter.processDraftMessage has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MessagingController.deleteMessagesSynchronous (cyclomatic 24) legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:2154— MessagingController.deleteMessagesSynchronous has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RealImapFolder.parseBodyStructure (cyclomatic 23) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt:884— RealImapFolder.parseBodyStructure has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FlowedMessageUtils.deflow (cyclomatic 22) mail/common/src/main/java/com/fsck/k9/mail/internet/FlowedMessageUtils.kt:15— FlowedMessageUtils.deflow has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Iso2022JpToShiftJisInputStream.read (cyclomatic 22) mail/common/src/main/java/com/fsck/k9/mail/internet/Iso2022JpToShiftJisInputStream.java:22— Iso2022JpToShiftJisInputStream.read has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SmtpTransport.open (cyclomatic 21) mail/protocols/smtp/src/main/java/com/fsck/k9/mail/transport/smtp/SmtpTransport.kt:94— SmtpTransport.open has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RealImapFolder.handleFetchResponse (cyclomatic 21) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt:761— RealImapFolder.handleFetchResponse has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MessagingController.sendPendingMessagesSynchronous (cyclomatic 21) legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:1616— MessagingController.sendPendingMessagesSynchronous has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RealImapFolder.fetch (cyclomatic 20) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt:572— RealImapFolder.fetch has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ItemTouchHelper.scrollIfNecessary (cyclomatic 20) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:770— ItemTouchHelper.scrollIfNecessary has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MessageExtractor.findViewablesAndAttachments (cyclomatic 20) mail/common/src/main/java/com/fsck/k9/mail/internet/MessageExtractor.java:149— MessageExtractor.findViewablesAndAttachments has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MessagingController.moveOrCopyMessageSynchronous (cyclomatic 20) legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:1927— MessagingController.moveOrCopyMessageSynchronous has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PgpMessageBuilder.startOrContinueBuildMessage (cyclomatic 20) legacy/core/src/main/java/com/fsck/k9/message/PgpMessageBuilder.java:156— PgpMessageBuilder.startOrContinueBuildMessage has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Pop3Sync.synchronizeMailboxSynchronous (cyclomatic 19) backend/pop3/src/main/java/com/fsck/k9/backend/pop3/Pop3Sync.kt:45— Pop3Sync.synchronizeMailboxSynchronous has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Rfc822Tokenizer.findTokenEnd (cyclomatic 19) mail/common/src/main/java/com/fsck/k9/mail/helper/Rfc822Tokenizer.java:240— Rfc822Tokenizer.findTokenEnd has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
WebDavStoreUriDecoder.decode (cyclomatic 19) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/WebDavStoreUriDecoder.java:26— WebDavStoreUriDecoder.decode has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AdvancedNodeTraversor.filter (cyclomatic 19) legacy/core/src/main/java/com/fsck/k9/helper/jsoup/AdvancedNodeTraversor.java:82— AdvancedNodeTraversor.filter has cyclomatic complexity 19 (threshold 15). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
MessageHomeActivity.decodeExtrasToLaunchData (cyclomatic 18) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageHomeActivity.kt:495— MessageHomeActivity.decodeExtrasToLaunchData has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MessageViewHolder.bind (cyclomatic 18) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/item/MessageViewHolder.kt:61— MessageViewHolder.bind has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
LinearLayoutManager.findReferenceChild (cyclomatic 18) ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:1669— LinearLayoutManager.findReferenceChild has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
LinearLayoutManager.updateAnchorFromPendingData (cyclomatic 18) ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:815— LinearLayoutManager.updateAnchorFromPendingData has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ItemTouchHelper.checkSelectForSwipe (cyclomatic 18) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:1031— ItemTouchHelper.checkSelectForSwipe has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Callback.chooseDropTarget (cyclomatic 18) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:1630— Callback.chooseDropTarget has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Pop3Folder.indexMsgNums (cyclomatic 18) mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Folder.java:156— Pop3Folder.indexMsgNums has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ImapStoreUriDecoder.decode (cyclomatic 18) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/ImapStoreUriDecoder.java:35— ImapStoreUriDecoder.decode has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RealImapStore.listFolders (cyclomatic 17) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapStore.kt:132— RealImapStore.listFolders has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SendingMailSettingsContentKt.handleSettingChange (cyclomatic 17) feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/sendingMail/SendingMailSettingsContent.kt:93— SendingMailSettingsContentKt.handleSettingChange has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
DraggableNode.initializePointerInputNode (cyclomatic 17) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/swipe/fork/Draggable.kt:278— DraggableNode.initializePointerInputNode has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Pop3Folder.fetch (cyclomatic 17) mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Folder.java:293— Pop3Folder.fetch has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
book.document.addEventListener("keydown") (cyclomatic 17) docs/assets/tb-theme/book.js:650— book.document.addEventListener("keydown") has cyclomatic complexity 17 (threshold 15). Of this number, 12 points are the body's own statements and 5 belong to 4 function items inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
LinearLayoutManager.convertFocusDirectionToLayoutDirection (cyclomatic 16) ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:1563— LinearLayoutManager.convertFocusDirectionToLayoutDirection has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MessageCompose.processDraftMessage (cyclomatic 16) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java:1637— MessageCompose.processDraftMessage has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
StorageMigrationTo2.urlEncodeUserNameAndPassword (cyclomatic 16) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo2.java:16— StorageMigrationTo2.urlEncodeUserNameAndPassword has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
IdentityHeaderParser.parse (cyclomatic 16) legacy/core/src/main/java/com/fsck/k9/message/IdentityHeaderParser.java:25— IdentityHeaderParser.parse has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
HackComment legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:349— // hack to force the view model to be created earlier. — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
render-notes.render_notes (cognitive 68) scripts/ci/render-notes.py:27— render-notes.render_notes has cognitive complexity 68 (threshold 15). Drivers by points: if/else 19 (47 pts), boolean chains 7, loops 4 (6 pts), error handling 1 (4 pts), ternaries 1 (4 pts) (nesting depth added 36). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Rfc822Tokenizer.tokenize (cognitive 62) mail/common/src/main/java/com/fsck/k9/mail/helper/Rfc822Tokenizer.java:44— Rfc822Tokenizer.tokenize has cognitive complexity 62 (threshold 15). Drivers by points: if/else 22 (46 pts), loops 5 (13 pts), boolean chains 3 (nesting depth added 32). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RealImapFolder.parseBodyStructure (cognitive 56) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt:884— RealImapFolder.parseBodyStructure has cognitive complexity 56 (threshold 15). Drivers by points: if/else 20 (43 pts), loops 3 (9 pts), boolean chains 4 (nesting depth added 29). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
HttpUriParser.tryMatchIpv6Address (cognitive 47) legacy/core/src/main/java/com/fsck/k9/message/html/HttpUriParser.kt:122— HttpUriParser.tryMatchIpv6Address has cognitive complexity 47 (threshold 15). Drivers by points: if/else 19 (34 pts), boolean chains 9, loops 3 (4 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessageCompose.onCreate (cognitive 46) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java:325— MessageCompose.onCreate has cognitive complexity 46 (threshold 15). Drivers by points: if/else 33 (39 pts), boolean chains 5, loops 1 (2 pts) (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
MessageHomeActivity.onCustomKeyDown (cognitive 45) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageHomeActivity.kt:890— MessageHomeActivity.onCustomKeyDown has cognitive complexity 45 (threshold 15). Drivers by points: if/else 24 (39 pts), boolean chains 4, match/switch 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapSync.synchronizeMailboxSynchronous (cognitive 45) backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:40— ImapSync.synchronizeMailboxSynchronous has cognitive complexity 45 (threshold 15). Drivers by points: if/else 17 (27 pts), loops 3 (7 pts), boolean chains 6, error handling 3 (5 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LinearLayoutManager.onLayoutChildren (cognitive 43) ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:434— LinearLayoutManager.onLayoutChildren has cognitive complexity 43 (threshold 15). Drivers by points: if/else 25 (36 pts), boolean chains 6, ternaries 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StorageMigrationTo2.urlEncodeUserNameAndPassword (cognitive 42) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo2.java:16— StorageMigrationTo2.urlEncodeUserNameAndPassword has cognitive complexity 42 (threshold 15). Drivers by points: if/else 13 (36 pts), error handling 1 (3 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 26). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RealImapFolder.fetch (cognitive 41) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt:572— RealImapFolder.fetch has cognitive complexity 41 (threshold 15). Drivers by points: if/else 15 (29 pts), match/switch 1 (5 pts), loops 2 (3 pts), boolean chains 2, error handling 1 (2 pts) (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Callback.chooseDropTarget (cognitive 41) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:1630— Callback.chooseDropTarget has cognitive complexity 41 (threshold 15). Drivers by points: if/else 12 (36 pts), boolean chains 4, loops 1 (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
QuotedMessagePresenter.processDraftMessage (cognitive 41) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/compose/QuotedMessagePresenter.java:199— QuotedMessagePresenter.processDraftMessage has cognitive complexity 41 (threshold 15). Drivers by points: if/else 16 (28 pts), error handling 4 (6 pts), ternaries 6, boolean chains 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessageHomeActivity.decodeExtrasToLaunchData (cognitive 39) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageHomeActivity.kt:495— MessageHomeActivity.decodeExtrasToLaunchData has cognitive complexity 39 (threshold 15). Drivers by points: if/else 20 (38 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LinearLayoutManager.findReferenceChild (cognitive 39) ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:1669— LinearLayoutManager.findReferenceChild has cognitive complexity 39 (threshold 15). Drivers by points: if/else 12 (31 pts), boolean chains 4, ternaries 2 (3 pts), loops 1 (nesting depth added 20). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
Pop3Folder.indexMsgNums (cognitive 39) mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Folder.java:156— Pop3Folder.indexMsgNums has cognitive complexity 39 (threshold 15). Drivers by points: if/else 11 (30 pts), loops 3 (5 pts), boolean chains 4 (nesting depth added 21). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
Rfc822Tokenizer.findTokenEnd (cognitive 38) mail/common/src/main/java/com/fsck/k9/mail/helper/Rfc822Tokenizer.java:240— Rfc822Tokenizer.findTokenEnd has cognitive complexity 38 (threshold 15). Drivers by points: if/else 14 (24 pts), loops 4 (10 pts), boolean chains 4 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessagingController.deleteMessagesSynchronous (cognitive 38) legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:2154— MessagingController.deleteMessagesSynchronous has cognitive complexity 38 (threshold 15). Drivers by points: if/else 18 (26 pts), loops 5 (8 pts), boolean chains 3, error handling 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessagingController.moveOrCopyMessageSynchronous (cognitive 37) legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:1927— MessagingController.moveOrCopyMessageSynchronous has cognitive complexity 37 (threshold 15). Drivers by points: if/else 11 (20 pts), loops 5 (13 pts), boolean chains 3, error handling 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FlowedMessageUtils.deflow (cognitive 36) mail/common/src/main/java/com/fsck/k9/mail/internet/FlowedMessageUtils.kt:15— FlowedMessageUtils.deflow has cognitive complexity 36 (threshold 15). Drivers by points: if/else 13 (25 pts), boolean chains 8, loops 2 (3 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LinearLayoutManager.updateAnchorFromPendingData (cognitive 36) ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:815— LinearLayoutManager.updateAnchorFromPendingData has cognitive complexity 36 (threshold 15). Drivers by points: if/else 16 (30 pts), boolean chains 3, ternaries 1 (3 pts) (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SettingsExporter.writeAccount (cognitive 35) legacy/core/src/main/java/com/fsck/k9/preferences/SettingsExporter.kt:139— SettingsExporter.writeAccount has cognitive complexity 35 (threshold 15). Drivers by points: if/else 15 (23 pts), loops 5 (9 pts), boolean chains 3 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ItemTouchHelper.select (cognitive 35) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:583— ItemTouchHelper.select has cognitive complexity 35 (threshold 15). Drivers by points: if/else 17 (27 pts), match/switch 1 (3 pts), ternaries 1 (3 pts), boolean chains 2 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessageExtractor.findViewablesAndAttachments (cognitive 35) mail/common/src/main/java/com/fsck/k9/mail/internet/MessageExtractor.java:149— MessageExtractor.findViewablesAndAttachments has cognitive complexity 35 (threshold 15). Drivers by points: if/else 18 (29 pts), boolean chains 3, loops 1 (3 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AdvancedNodeTraversor.filter (cognitive 35) legacy/core/src/main/java/com/fsck/k9/helper/jsoup/AdvancedNodeTraversor.java:82— AdvancedNodeTraversor.filter has cognitive complexity 35 (threshold 15). Drivers by points: if/else 9 (23 pts), boolean chains 6, loops 2 (3 pts), ternaries 1 (3 pts) (nesting depth added 17). This file's own header attributes it to another copyright holder, so it is code this repository carries rather than code it wrote: restructuring the body in place forks it from upstream and turns every future re-sync into a manual merge. The performable moves are to leave the body as close to its upstream form as possible and keep it behind a narrow interface of your own, and to re-sync it when upstream changes — or, if it has already diverged far enough that you maintain it here, adopt it deliberately and then split the body into named stages.
MessagingController.sendPendingMessagesSynchronous (cognitive 34) legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:1616— MessagingController.sendPendingMessagesSynchronous has cognitive complexity 34 (threshold 15). Drivers by points: if/else 11 (18 pts), error handling 6 (11 pts), loops 3 (4 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RealImapFolder.handleFetchResponse (cognitive 33) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt:761— RealImapFolder.handleFetchResponse has cognitive complexity 33 (threshold 15). Drivers by points: if/else 11 (22 pts), match/switch 1 (4 pts), error handling 1 (3 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessageViewHolder.bind (cognitive 32) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/item/MessageViewHolder.kt:61— MessageViewHolder.bind has cognitive complexity 32 (threshold 15). Drivers by points: if/else 26 (31 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
Pop3Sync.synchronizeMailboxSynchronous (cognitive 32) backend/pop3/src/main/java/com/fsck/k9/backend/pop3/Pop3Sync.kt:45— Pop3Sync.synchronizeMailboxSynchronous has cognitive complexity 32 (threshold 15). Drivers by points: if/else 12 (19 pts), loops 3 (7 pts), error handling 3 (5 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Iso2022JpToShiftJisInputStream.read (cognitive 32) mail/common/src/main/java/com/fsck/k9/mail/internet/Iso2022JpToShiftJisInputStream.java:22— Iso2022JpToShiftJisInputStream.read has cognitive complexity 32 (threshold 15). Drivers by points: if/else 12 (18 pts), ternaries 3 (7 pts), boolean chains 5, loops 1, match/switch 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IdentityHeaderParser.parse (cognitive 32) legacy/core/src/main/java/com/fsck/k9/message/IdentityHeaderParser.java:25— IdentityHeaderParser.parse has cognitive complexity 32 (threshold 15). Drivers by points: if/else 10 (19 pts), error handling 2 (7 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LinearLayoutManager.validateChildOrder (cognitive 30) ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:1962— LinearLayoutManager.validateChildOrder has cognitive complexity 30 (threshold 15). Drivers by points: if/else 10 (26 pts), loops 2 (4 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WebDavStoreUriDecoder.decode (cognitive 30) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/WebDavStoreUriDecoder.java:26— WebDavStoreUriDecoder.decode has cognitive complexity 30 (threshold 15). Drivers by points: if/else 15 (25 pts), boolean chains 3, error handling 1, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RealImapFolder.appendMessages (cognitive 29) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt:1022— RealImapFolder.appendMessages has cognitive complexity 29 (threshold 15). Drivers by points: if/else 9 (22 pts), boolean chains 3, loops 2 (3 pts), error handling 1 (nesting depth added 14). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
StorageMigrations.upgradeDatabase (cognitive 29) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrations.kt:8— StorageMigrations.upgradeDatabase has cognitive complexity 29 (threshold 15). Drivers by points: if/else 29. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SmtpTransport.open (cognitive 28) mail/protocols/smtp/src/main/java/com/fsck/k9/mail/transport/smtp/SmtpTransport.kt:94— SmtpTransport.open has cognitive complexity 28 (threshold 15). Drivers by points: if/else 17 (23 pts), error handling 4, match/switch 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapStoreUriDecoder.decode (cognitive 28) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/ImapStoreUriDecoder.java:35— ImapStoreUriDecoder.decode has cognitive complexity 28 (threshold 15). Drivers by points: if/else 17 (25 pts), boolean chains 2, error handling 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Migrations.upgradeDatabase (cognitive 27) legacy/storage/src/main/java/com/fsck/k9/storage/migrations/Migrations.kt:9— Migrations.upgradeDatabase has cognitive complexity 27 (threshold 15). Drivers by points: if/else 27. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
Pop3Folder.fetchEnvelope (cognitive 27) mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Folder.java:351— Pop3Folder.fetchEnvelope has cognitive complexity 27 (threshold 15). Drivers by points: if/else 8 (18 pts), loops 4 (7 pts), boolean chains 2 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Base64.encode (cognitive 27) mail/common/src/main/java/com/fsck/k9/mail/filter/Base64.java:348— Base64.encode has cognitive complexity 27 (threshold 15). Drivers by points: if/else 9 (20 pts), boolean chains 3, loops 1 (2 pts), match/switch 1 (2 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessageHomeActivity.handleOnBackPressed (cognitive 26) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageHomeActivity.kt:841— MessageHomeActivity.handleOnBackPressed has cognitive complexity 26 (threshold 15). Drivers by points: if/else 15 (23 pts), boolean chains 3 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ItemTouchHelper.scrollIfNecessary (cognitive 26) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:770— ItemTouchHelper.scrollIfNecessary has cognitive complexity 26 (threshold 15). Drivers by points: if/else 15 (22 pts), boolean chains 3, ternaries 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Pop3Folder.indexUids (cognitive 25) mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Folder.java:232— Pop3Folder.indexUids has cognitive complexity 25 (threshold 15). Drivers by points: if/else 8 (21 pts), boolean chains 2, loops 2 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RecipientLoader.fillCryptoStatusData (cognitive 25) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientLoader.java:501— RecipientLoader.fillCryptoStatusData has cognitive complexity 25 (threshold 15). Drivers by points: if/else 5 (15 pts), match/switch 1 (4 pts), loops 2 (3 pts), ternaries 1 (2 pts), error handling 1 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GeneralSettingsDataStore.getStringSet (cognitive 24) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/general/GeneralSettingsDataStore.kt:233— GeneralSettingsDataStore.getStringSet has cognitive complexity 24 (threshold 15). Drivers by points: if/else 12 (23 pts), match/switch 1 (nesting depth added 11). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
DraggableNode.initializePointerInputNode (cognitive 24) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/swipe/fork/Draggable.kt:278— DraggableNode.initializePointerInputNode has cognitive complexity 24 (threshold 15). Drivers by points: if/else 11 (15 pts), loops 3 (5 pts), boolean chains 3, error handling 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LinearLayoutManager.layoutChunk (cognitive 24) ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:1481— LinearLayoutManager.layoutChunk has cognitive complexity 24 (threshold 15). Drivers by points: if/else 17 (22 pts), boolean chains 2 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
ImapResponseParser.parseLiteral (cognitive 24) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapResponseParser.java:358— ImapResponseParser.parseLiteral has cognitive complexity 24 (threshold 15). Drivers by points: if/else 9 (17 pts), error handling 3 (5 pts), boolean chains 1, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessageCompose.processDraftMessage (cognitive 24) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java:1637— MessageCompose.processDraftMessage has cognitive complexity 24 (threshold 15). Drivers by points: if/else 17 (22 pts), boolean chains 2 (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
RealImapFolder.fetchPart (cognitive 23) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt:690— RealImapFolder.fetchPart has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (16 pts), match/switch 1 (4 pts), boolean chains 1, error handling 1, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DraggableKt.awaitPointerSlopOrCancellation (cognitive 23) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/swipe/fork/Draggable.kt:621— DraggableKt.awaitPointerSlopOrCancellation has cognitive complexity 23 (threshold 15). Drivers by points: if/else 11 (22 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Pop3Folder.fetch (cognitive 23) mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Folder.java:293— Pop3Folder.fetch has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (12 pts), error handling 3 (4 pts), boolean chains 3, loops 2, ternaries 1 (2 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Pop3Folder.fetchBody (cognitive 23) mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Folder.java:414— Pop3Folder.fetchBody has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (15 pts), boolean chains 5, error handling 2 (3 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessageExtractor.findHtmlPart (cognitive 23) mail/common/src/main/java/com/fsck/k9/mail/internet/MessageExtractor.java:332— MessageExtractor.findHtmlPart has cognitive complexity 23 (threshold 15). Drivers by points: if/else 8 (19 pts), boolean chains 3, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TextBodyBuilder.buildTextHtml (cognitive 23) legacy/core/src/main/java/com/fsck/k9/message/TextBodyBuilder.java:47— TextBodyBuilder.buildTextHtml has cognitive complexity 23 (threshold 15). Drivers by points: if/else 10 (19 pts), boolean chains 4 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DefaultDataStoreConfigBackend.update (cognitive 22) core/configstore/impl-backend/src/commonMain/kotlin/net/thunderbird/core/configstore/backend/DefaultDataStoreConfigBackend.kt:43— DefaultDataStoreConfigBackend.update has cognitive complexity 22 (threshold 15). Drivers by points: if/else 7 (19 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ItemTouchHelper.checkSelectForSwipe (cognitive 22) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:1031— ItemTouchHelper.checkSelectForSwipe has cognitive complexity 22 (threshold 15). Drivers by points: if/else 11 (15 pts), boolean chains 6, ternaries 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImapResponseParser.readStatusResponse (cognitive 22) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapResponseParser.java:90— ImapResponseParser.readStatusResponse has cognitive complexity 22 (threshold 15). Drivers by points: if/else 5 (11 pts), boolean chains 7, loops 2 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Utility.stripSubject (cognitive 22) legacy/core/src/main/java/com/fsck/k9/helper/Utility.java:80— Utility.stripSubject has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (16 pts), boolean chains 5, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PgpMessageBuilder.startOrContinueBuildMessage (cognitive 22) legacy/core/src/main/java/com/fsck/k9/message/PgpMessageBuilder.java:156— PgpMessageBuilder.startOrContinueBuildMessage has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (11 pts), boolean chains 10, error handling 1 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ItemTouchHelper.findSwapTargets (cognitive 21) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:834— ItemTouchHelper.findSwapTargets has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (16 pts), loops 2 (4 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
KeyChainKeyManager.chooseAlias (cognitive 21) legacy/core/src/main/java/com/fsck/k9/helper/KeyChainKeyManager.java:127— KeyChainKeyManager.chooseAlias has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (15 pts), boolean chains 3, loops 2 (3 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LocalMessage.populateFromGetMessageCursor (cognitive 21) legacy/core/src/main/java/com/fsck/k9/mailstore/LocalMessage.java:70— LocalMessage.populateFromGetMessageCursor has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (11 pts), ternaries 4, error handling 1 (3 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
HostNameUtils.isLegalIPv6Address (cognitive 20) core/common/src/commonMain/kotlin/net/thunderbird/core/common/net/HostNameUtils.kt:83— HostNameUtils.isLegalIPv6Address has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (15 pts), loops 3 (5 pts) (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
LinearLayoutManager.fill (cognitive 20) ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:1431— LinearLayoutManager.fill has cognitive complexity 20 (threshold 15). Drivers by points: if/else 8 (15 pts), boolean chains 4, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Base64.decode (cognitive 20) mail/common/src/main/java/com/fsck/k9/mail/filter/Base64.java:427— Base64.decode has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (14 pts), match/switch 1 (3 pts), boolean chains 2, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Settings.validate (cognitive 20) legacy/core/src/main/java/com/fsck/k9/preferences/Settings.java:42— Settings.validate has cognitive complexity 20 (threshold 15). Drivers by points: if/else 5 (9 pts), ternaries 2 (7 pts), error handling 1 (3 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DecoderUtil.decodeEncodedWords (cognitive 19) mail/common/src/main/java/com/fsck/k9/mail/internet/DecoderUtil.kt:37— DecoderUtil.decodeEncodedWords has cognitive complexity 19 (threshold 15). Drivers by points: if/else 11 (18 pts), loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LinearLayoutManager.convertFocusDirectionToLayoutDirection (cognitive 19) ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:1563— LinearLayoutManager.convertFocusDirectionToLayoutDirection has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (10 pts), ternaries 4 (8 pts), match/switch 1 (nesting depth added 7). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
LinearLayoutManager.updateAnchorFromChildren (cognitive 19) ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:755— LinearLayoutManager.updateAnchorFromChildren has cognitive complexity 19 (threshold 15). Drivers by points: if/else 7 (10 pts), boolean chains 5, ternaries 1 (4 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
2.onInterceptTouchEvent (cognitive 19) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:303— 2.onInterceptTouchEvent has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (18 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Pop3Connection.getCapabilities (cognitive 19) REDACTED:220— Pop3Connection.getCapabilities has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (17 pts), error handling 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MessagingController.setFlagSynchronous (cognitive 19) legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:1205— MessagingController.setFlagSynchronous has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (9 pts), error handling 4 (6 pts), loops 2 (3 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SmtpResponseParser.readResponseAfterReplyCode (cognitive 18) mail/protocols/smtp/src/main/java/com/fsck/k9/mail/transport/smtp/SmtpResponseParser.kt:164— SmtpResponseParser.readResponseAfterReplyCode has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (14 pts), match/switch 1 (2 pts), boolean chains 1, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RealImapConnection.authenticate (cognitive 18) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapConnection.kt:311— RealImapConnection.authenticate has cognitive complexity 18 (threshold 15). Drivers by points: if/else 13 (17 pts), match/switch 1 (nesting depth added 4). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
MessageViewFragment.prepareMenu (cognitive 18) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/MessageViewFragment.kt:384— MessageViewFragment.prepareMenu has cognitive complexity 18 (threshold 15). Drivers by points: if/else 13 (16 pts), boolean chains 2 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
ItemTouchHelper.swipeIfNecessary (cognitive 18) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:1150— ItemTouchHelper.swipeIfNecessary has cognitive complexity 18 (threshold 15). Drivers by points: if/else 10 (18 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ItemTouchHelperGestureListener.onLongPress (cognitive 18) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:2169— ItemTouchHelperGestureListener.onLongPress has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (18 pts) (nesting depth added 11). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
MessageCompose.onActivityResult (cognitive 18) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java:1031— MessageCompose.onActivityResult has cognitive complexity 18 (threshold 15). Drivers by points: if/else 8 (17 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
QuotedMessagePresenter.populateUIWithQuotedMessage (cognitive 18) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/compose/QuotedMessagePresenter.java:89— QuotedMessagePresenter.populateUIWithQuotedMessage has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (11 pts), boolean chains 5, ternaries 1 (2 pts) (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
MessageViewInfoExtractor.extractTextFromViewables (cognitive 18) legacy/core/src/main/java/com/fsck/k9/mailstore/MessageViewInfoExtractor.java:183— MessageViewInfoExtractor.extractTextFromViewables has cognitive complexity 18 (threshold 15). Drivers by points: loops 3 (7 pts), ternaries 2 (6 pts), if/else 3 (4 pts), error handling 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HtmlQuoteCreator.quoteOriginalHtmlMessage (cognitive 18) legacy/core/src/main/java/com/fsck/k9/message/quote/HtmlQuoteCreator.java:48— HtmlQuoteCreator.quoteOriginalHtmlMessage has cognitive complexity 18 (threshold 15). Drivers by points: if/else 9 (15 pts), boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
book.document.addEventListener("keydown") (cognitive 18) docs/assets/tb-theme/book.js:650— book.document.addEventListener("keydown") has cognitive complexity 18 (threshold 15). Drivers by points: if/else 12 (14 pts), boolean chains 2, match/switch 2 (nesting depth added 2). Of this number, 13 points are the body's own statements and 5 belong to 4 function items inside it that branch. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
RealImapStore.listFolders (cognitive 17) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapStore.kt:132— RealImapStore.listFolders has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (12 pts), match/switch 2 (3 pts), boolean chains 1, loops 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SettingsExporter.writeIdentity (cognitive 17) legacy/core/src/main/java/com/fsck/k9/preferences/SettingsExporter.kt:389— SettingsExporter.writeIdentity has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (11 pts), error handling 1 (4 pts), boolean chains 1, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LinearLayoutManager.recycleViewsFromEnd (cognitive 17) ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:1362— LinearLayoutManager.recycleViewsFromEnd has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (LinearLayoutManager.recycleViewsFromStart) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
LinearLayoutManager.recycleViewsFromStart (cognitive 17) ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java:1315— LinearLayoutManager.recycleViewsFromStart has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (11 pts), loops 2 (4 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (LinearLayoutManager.recycleViewsFromEnd) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
CharsetSupport.readToString (cognitive 17) mail/common/src/main/java/com/fsck/k9/mail/internet/CharsetSupport.java:51— CharsetSupport.readToString has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (10 pts), error handling 2 (4 pts), boolean chains 2, loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TokenCompleteTextView.onTouchEvent (cognitive 17) library/token-auto-complete/src/main/java/com/tokenautocomplete/TokenCompleteTextView.java:681— TokenCompleteTextView.onTouchEvent has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (15 pts), boolean chains 1, match/switch 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
generate_changelog_json.extract_release (cognitive 17) scripts/changelog/generate_changelog_json.py:111— generate_changelog_json.extract_release has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (13 pts), boolean chains 3, loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SmtpResponse.toLogString (cognitive 16) mail/protocols/smtp/src/main/java/com/fsck/k9/mail/transport/smtp/SmtpResponse.kt:13— SmtpResponse.toLogString has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (13 pts), loops 1 (3 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SmtpTransport.sendMessage (cognitive 16) mail/protocols/smtp/src/main/java/com/fsck/k9/mail/transport/smtp/SmtpTransport.kt:319— SmtpTransport.sendMessage has cognitive complexity 16 (threshold 15). Drivers by points: loops 5 (7 pts), if/else 5 (6 pts), error handling 2, boolean chains 1 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RecipientPresenter.toggleEncryptionState (cognitive 16) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientPresenter.kt:595— RecipientPresenter.toggleEncryptionState has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (13 pts), boolean chains 3 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
MessageContainerView.createImageMenu (cognitive 16) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/MessageContainerView.kt:213— MessageContainerView.createImageMenu has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (14 pts), boolean chains 1, match/switch 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
ThreadMessageOperations.doMessageThreading (cognitive 16) legacy/storage/src/main/java/com/fsck/k9/storage/messages/ThreadMessageOperations.kt:67— ThreadMessageOperations.doMessageThreading has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 1, loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Pop3Sync.evaluateMessageForDownload (cognitive 16) backend/pop3/src/main/java/com/fsck/k9/backend/pop3/Pop3Sync.kt:402— Pop3Sync.evaluateMessageForDownload has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 2 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ItemTouchHelper.checkHorizontalSwipe (cognitive 16) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:1199— ItemTouchHelper.checkHorizontalSwipe has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (8 pts), ternaries 2 (5 pts), boolean chains 3 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ItemTouchHelper.checkVerticalSwipe) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ItemTouchHelper.checkVerticalSwipe (cognitive 16) ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java:1226— ItemTouchHelper.checkVerticalSwipe has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (8 pts), ternaries 2 (5 pts), boolean chains 3 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ItemTouchHelper.checkHorizontalSwipe) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
Pop3StoreUriDecoder.decode (cognitive 16) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/Pop3StoreUriDecoder.java:34— Pop3StoreUriDecoder.decode has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 1, error handling 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LocalStore.findPartById (cognitive 16) legacy/core/src/main/java/com/fsck/k9/mailstore/LocalStore.java:536— LocalStore.findPartById has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 2 (4 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D22 · Internal API Consistency· Duplicate operation across class and companion object/extension. `OutboxFolderManagerKt.getOutboxFolderIdSync` has the exact same signature as `OutboxFolderManager.getOutboxFolderIdSync`. This creates ambiguity for callers on whether to use the instance method or the static/extension function. · ×1
Duplicate operation across class and companion object/extension. `OutboxFolderManagerKt.getOutboxFolderIdSync` has the exact same signature as `OutboxFolderManager.getOutboxFolderIdSync`. This creates ambiguity for callers on whether to use the instance method or the static/extension function. — Remove the duplicate method from `OutboxFolderManagerKt` or rename it to indicate a different behavior (e.g., if one is async and one is sync, ensure naming reflects that, but here both are named Sync). Ideally, keep the instance method and remove the redundant extension function. (signatures: OutboxFolderManager.getOutboxFolderId(accountId: AccountId, createIfMissing: Boolean): Long | OutboxFolderManager.getOutboxFolderIdSync(accountId: AccountId, createIfMissing: Boolean): Long | OutboxFolderManagerKt.getOutboxFolderIdSync(accountId: AccountId, createIfMissing: Boolean): Long)
D22 · Internal API Consistency· Inconsistent naming convention for synchronous operations. `OutboxFolderManager` has `hasPendingMessages` (no Sync suffix) while the extension function in `OutboxFolderManagerKt` is `hasPendingMessagesSync`. This suggests one might be async and one sync, or they are duplicates with inconsistent naming. Given the previous inconsistency, this pattern is confusing. · ×1
Inconsistent naming convention for synchronous operations. `OutboxFolderManager` has `hasPendingMessages` (no Sync suffix) while the extension function in `OutboxFolderManagerKt` is `hasPendingMessagesSync`. This suggests one might be async and one sync, or they are duplicates with inconsistent naming. Given the previous inconsistency, this pattern is confusing. — Standardize naming. If both are synchronous, remove the 'Sync' suffix from the extension function. If one is async, name it `hasPendingMessagesAsync` or similar to distinguish from the sync version. (signatures: OutboxFolderManager.hasPendingMessages(accountId: AccountId): Boolean | OutboxFolderManagerKt.hasPendingMessagesSync(accountId: AccountId): Boolean)
D22 · Internal API Consistency· Duplicate intent across distinct repository types. Both `FolderDetailsRepository` and `FolderQueryRepository` expose an `findById` method with identical signatures. It is unclear why the API is split between 'Details' and 'Query' repositories if they share the same primary lookup operation. · ×1
Duplicate intent across distinct repository types. Both `FolderDetailsRepository` and `FolderQueryRepository` expose an `findById` method with identical signatures. It is unclear why the API is split between 'Details' and 'Query' repositories if they share the same primary lookup operation. — Consolidate into a single repository interface or clearly distinguish the return types/semantics (e.g., one returns full details, one returns minimal query data) and rename methods to reflect that difference (e.g., `findDetailsById` vs `findIdByServerId`). (signatures: FolderDetailsRepository.findById(accountId: AccountId, folderId: Long) | FolderQueryRepository.findById(accountId: AccountId, folderId: Long))
D22 · Internal API Consistency· Inconsistent naming for reactive vs imperative access. `observeAllByAccountId` implies a Flow/Stream, while `getAllByAccountId` implies a single snapshot. While distinct, the naming pattern `observe...` vs `get...` is less consistent than `observe...` vs `get...Sync` or `get...Once`. However, the bigger issue is the parallel with `PushFolderTrackingRepository` which uses `observeEnabled` and `isEnabled`. · ×1
Inconsistent naming for reactive vs imperative access. `observeAllByAccountId` implies a Flow/Stream, while `getAllByAccountId` implies a single snapshot. While distinct, the naming pattern `observe...` vs `get...` is less consistent than `observe...` vs `get...Sync` or `get...Once`. However, the bigger issue is the parallel with `PushFolderTrackingRepository` which uses `observeEnabled` and `isEnabled`. — Ensure consistent naming across all repositories. If `observe` is used for streams, ensure the corresponding getter is clearly named (e.g., `getAll` is acceptable, but check if `PushFolderTrackingRepository`'s `isEnabled` matches the pattern of `getAll`). (signatures: PushFoldersQueryRepository.observeAllByAccountId(accountId: AccountId) | PushFoldersQueryRepository.getAllByAccountId(accountId: AccountId))
Change coupling clique: BaseMessageListWidgetProvider.kt, MessageListRemoteViewFactory.kt, UnreadWidgetDataProvider.kt feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/BaseMessageListWidgetProvider.kt— 3 files — `feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/BaseMessageListWidgetProvider.kt`, `feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListRemoteViewFactory.kt`, `feature/widget/unread/src/main/kotlin/app/k9mail/feature/widget/unread/UnreadWidgetDataProvider.kt` — all change together with no explicit dependency: a fully-connected co-change clique, not 3 separate couplings. They share one concern (thin parallel siblings over a common abstraction), so extract the shared part into ONE unit and the whole clique's coupling clears at once — you do not need to break each pair individually.
D4 · Code Duplication· Near-duplicate member family (4 members, 62 shared lines) · ×1
Near-duplicate member family (4 members, 62 shared lines) feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:157— feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:157-224 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:230-297 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:303-370 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:376-442 — These 4 members are variants of one another: a block of 62 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Near-duplicate member pair (25 shared lines) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:965— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:965-1003 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:853-892 — These two members are variants of one another: 25 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication· Members sharing a duplicated core (12 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (12 members, 50+ identical tokens) feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:158— feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:158-201 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:207-250 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:256-299 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:305-348 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItemPreview.kt:189-232 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItemPreview.kt:238-281 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItemPreview.kt:287-330 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItemPreview.kt:336-379 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/UnreadMessageItemPreview.kt:158-201 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/UnreadMessageItemPreview.kt:207-250 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/UnreadMessageItemPreview.kt:256-299 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/UnreadMessageItemPreview.kt:305-348 — These 12 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 12 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 12 times.
D4 · Code Duplication· Members sharing a duplicated core (8 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (8 members, 50+ identical tokens) feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/MessageListScreenLoadingMessagesStatePreviewParams.kt:78— feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/MessageListScreenLoadingMessagesStatePreviewParams.kt:78-102 | feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/MessageListScreenSearchingMessagesStatePreviewParams.kt:72-96 | feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/MessageListScreenSelectingMessagesStatePreviewParams.kt:47-71 | feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/MessageListScreenWarmingUpStatePreviewParams.kt:39-63 | feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/loadedmessages/MessageListScreenLoadedMessagesContentPreview.kt:87-111 | feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/loadedmessages/MessageListScreenLoadedMessagesDensityPreview.kt:65-89 | feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/loadedmessages/MessageListScreenLoadedMessagesFooterPreview.kt:61-85 | feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/loadedmessages/MessageListScreenLoadedMessagesLayoutPreview.kt:65-89 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
D4 · Code Duplication· Members sharing a duplicated core (5 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (5 members, 50+ identical tokens) feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsViewModel.kt:315— feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsViewModel.kt:315-323 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/general/GeneralSettingsViewModel.kt:94-102 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/readingMail/ReadingMailSettingsViewModel.kt:152-160 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/search/SearchSettingsViewModel.kt:110-118 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/sendingMail/SendingMailSettingsViewModel.kt:259-267 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
Duplicated block (54 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1727— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1727-1780 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1556-1609 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (43–44 lines × 4) feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsContent.kt:49— feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsContent.kt:49-92 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/readingMail/ReadingMailSettingsContent.kt:47-90 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/search/SearchSettingContent.kt:43-86 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/sendingMail/SendingMailSettingsContent.kt:48-90 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsContent.kt:49` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsContent.kt:94` calls `Suppress` and `feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/readingMail/ReadingMailSettingsContent.kt:92` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (40–41 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/BasicDialog.kt:210— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/BasicDialog.kt:210-249 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/organism/items/dialogs/BasicDialogItems.kt:150-190 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/organism/BasicDialog.kt:210` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (41 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1368— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1368-1408 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1247-1287 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (38 lines × 4) feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:183— feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:183-220 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:256-293 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:329-366 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:402-439 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:183` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (37 lines × 2) feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt:103— feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt:103-139 | feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt:103-139 — before extracting anything, compare `feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt` and `feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (32 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1131— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1131-1162 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1022-1053 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (23–30 lines × 3) feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt:71— feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt:71-100 | feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt:71-100 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListLoader.kt:127-149 — before extracting anything, compare `feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt` and `feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 106 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (29 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1688— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1688-1716 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1517-1545 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (28 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1859— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1859-1886 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1670-1697 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (24 lines × 8) feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/MessageListScreenLoadingMessagesStatePreviewParams.kt:79— feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/MessageListScreenLoadingMessagesStatePreviewParams.kt:79-102 | feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/MessageListScreenSearchingMessagesStatePreviewParams.kt:73-96 | feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/MessageListScreenSelectingMessagesStatePreviewParams.kt:48-71 | feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/MessageListScreenWarmingUpStatePreviewParams.kt:40-63 | feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/loadedmessages/MessageListScreenLoadedMessagesContentPreview.kt:88-111 | feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/loadedmessages/MessageListScreenLoadedMessagesDensityPreview.kt:66-89 | feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/loadedmessages/MessageListScreenLoadedMessagesFooterPreview.kt:62-85 | feature/mail/message/list/internal/src/debug/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/renderer/statepreview/loadedmessages/MessageListScreenLoadedMessagesLayoutPreview.kt:66-89 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 8 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 8 times. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (24 lines × 4) feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:158— feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:158-181 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:231-254 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:304-327 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:377-400 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/MessageItemPreview.kt:158` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (21 lines × 12) feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:163— feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:163-183 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:212-232 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:261-281 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:310-330 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItemPreview.kt:194-214 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItemPreview.kt:243-263 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItemPreview.kt:292-312 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItemPreview.kt:341-361 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/UnreadMessageItemPreview.kt:163-183 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/UnreadMessageItemPreview.kt:212-232 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/UnreadMessageItemPreview.kt:261-281 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/UnreadMessageItemPreview.kt:310-330 — before extracting anything, compare `feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt` and `feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItemPreview.kt` as WHOLE FILES: 84% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:163` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (21 lines × 3) app-k9mail/src/debug/kotlin/app/k9mail/dev/DebugConfig.kt:13— app-k9mail/src/debug/kotlin/app/k9mail/dev/DebugConfig.kt:13-33 | app-thunderbird/src/daily/kotlin/net/thunderbird/android/dev/DailyConfig.kt:13-33 | app-thunderbird/src/debug/kotlin/net/thunderbird/android/dev/DebugConfig.kt:13-33 — before extracting anything, compare `app-k9mail/src/debug/kotlin/app/k9mail/dev/DebugConfig.kt` and `app-thunderbird/src/daily/kotlin/net/thunderbird/android/dev/DailyConfig.kt` as WHOLE FILES: 95% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (20 lines × 3) mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapServerSettingsValidator.kt:51— mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapServerSettingsValidator.kt:51-70 | mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3ServerSettingsValidator.kt:39-58 | mail/protocols/smtp/src/main/java/com/fsck/k9/mail/transport/smtp/SmtpServerSettingsValidator.kt:43-62 — before extracting anything, compare `mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapServerSettingsValidator.kt` and `mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3ServerSettingsValidator.kt` as WHOLE FILES: 89% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapServerSettingsValidator.kt:51` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18–20 lines × 2) feature/autodiscovery/autoconfig/src/main/kotlin/app/k9mail/autodiscovery/autoconfig/RealAutoconfigParser.kt:257— feature/autodiscovery/autoconfig/src/main/kotlin/app/k9mail/autodiscovery/autoconfig/RealAutoconfigParser.kt:257-276 | legacy/core/src/main/java/com/fsck/k9/preferences/SettingsFileParser.kt:395-412 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (18 lines × 3) feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItem.kt:66— feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItem.kt:66-83 | feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItem.kt:67-84 | feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/UnreadMessageItem.kt:66-83 — before extracting anything, compare `feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItem.kt` and `feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItem.kt` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItem.kt:66` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItem.kt:85` calls `readMessageItemColors` and `feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/UnreadMessageItem.kt:84` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (17 lines × 9) feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:185— feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:185-201 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:234-250 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:283-299 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItemPreview.kt:216-232 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItemPreview.kt:265-281 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItemPreview.kt:314-330 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/UnreadMessageItemPreview.kt:185-201 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/UnreadMessageItemPreview.kt:234-250 | feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/UnreadMessageItemPreview.kt:283-299 — before extracting anything, compare `feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt` and `feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/ReadMessageItemPreview.kt` as WHOLE FILES: 84% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feature/mail/message/list/api/src/debug/kotlin/net/thunderbird/feature/mail/message/list/ui/component/organism/NewMessageItemPreview.kt:185` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16–17 lines × 2) components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/ContentLoadingErrorView.kt:131— components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/ContentLoadingErrorView.kt:131-146 | components/ui/catalog/src/main/kotlin/net/thunderbird/components/ui/catalog/ui/page/molecule/items/StateItems.kt:137-153 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/ContentLoadingErrorView.kt:131` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15–17 lines × 2) feature/account/server/validation/src/main/kotlin/app/k9mail/feature/account/server/validation/ui/ServerValidationMainScreen.kt:29— feature/account/server/validation/src/main/kotlin/app/k9mail/feature/account/server/validation/ui/ServerValidationMainScreen.kt:29-43 | feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/ui/createaccount/CreateAccountScreen.kt:48-64 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `feature/account/server/validation/src/main/kotlin/app/k9mail/feature/account/server/validation/ui/ServerValidationMainScreen.kt:29` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: `Event` names `app.k9mail.feature.account.server.validation.ui.ServerValidationContract.Event` in one and `app.k9mail.feature.account.setup.ui.createaccount.CreateAccountContract.Event` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (13–17 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1800— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1800-1812 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:1625-1641 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1800` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 3) feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsScreen.kt:33— feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsScreen.kt:33-48 | feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/ui/options/display/DisplayOptionsScreen.kt:27-42 | feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/ui/options/sync/SyncOptionsScreen.kt:27-42 — before extracting anything, compare `feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/ui/options/display/DisplayOptionsScreen.kt` and `feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/ui/options/sync/SyncOptionsScreen.kt` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsScreen.kt:33` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: `Effect` names `app.k9mail.feature.account.server.settings.ui.outgoing.OutgoingServerSettingsContract.Effect` in one and `app.k9mail.feature.account.setup.ui.options.display.DisplayOptionsContract.Effect` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (13 lines × 3) legacy/core/src/main/java/com/fsck/k9/notification/AuthenticationErrorNotificationController.kt:28— legacy/core/src/main/java/com/fsck/k9/notification/AuthenticationErrorNotificationController.kt:28-40 | legacy/core/src/main/java/com/fsck/k9/notification/CertificateErrorNotificationController.kt:28-40 | legacy/core/src/main/java/com/fsck/k9/notification/SendFailedNotificationController.kt:37-49 — before extracting anything, compare `legacy/core/src/main/java/com/fsck/k9/notification/AuthenticationErrorNotificationController.kt` and `legacy/core/src/main/java/com/fsck/k9/notification/CertificateErrorNotificationController.kt` as WHOLE FILES: 86% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (11–13 lines × 2) backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:448— backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:448-458 | backend/pop3/src/main/java/com/fsck/k9/backend/pop3/Pop3Sync.kt:449-461 — before extracting anything, compare `backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt` and `backend/pop3/src/main/java/com/fsck/k9/backend/pop3/Pop3Sync.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 51 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:448` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 3) feature/mail/message/list/internal/src/main/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/component/MessageListItem.kt:26— feature/mail/message/list/internal/src/main/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/component/MessageListItem.kt:26-36 | feature/mail/message/list/internal/src/main/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/component/MessageListItem.kt:41-51 | feature/mail/message/list/internal/src/main/kotlin/net/thunderbird/feature/mail/message/list/internal/ui/component/MessageListItem.kt:56-66 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (9–11 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:966— legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:966-974 | legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt:854-864 — before extracting anything, compare `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt` and `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt` as WHOLE FILES: this scan already matched 56 separate duplicated blocks between them, totalling at least 972 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:966` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `sortType` to `SortType` in one and `LegacySortType` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (4–5 lines × 14) feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:62— feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:62-66 | feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:68-72 | feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:75-79 | feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:83-87 | feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:89-93 | feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:97-101 | feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:105-109 | feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:113-117 | feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:121-125 | feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:129-133 | feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:136-140 | feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:195-199 | feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:202-205 | feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:234-238 — all 14 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:201` calls `path`, `SolidColor` and `feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt:67` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 3) feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/setting/AccountSettingList.kt:26— feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/setting/AccountSettingList.kt:26-30 | feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/setting/FolderSettingList.kt:26-30 | feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/setting/SettingList.kt:21-25 — before extracting anything, compare `feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/setting/AccountSettingList.kt` and `feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/setting/FolderSettingList.kt` as WHOLE FILES: 85% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (11 lines × 4) app-k9mail/src/debug/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt:9— app-k9mail/src/debug/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt:9-19 | app-k9mail/src/release/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt:9-19 | app-thunderbird/src/beta/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:9-19 | app-thunderbird/src/debug/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:9-19 — before extracting anything, compare `app-k9mail/src/debug/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt` and `app-k9mail/src/release/kotlin/app/k9mail/auth/K9OAuthConfigurationFactory.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 42 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 3) app-k9mail/src/release/kotlin/app/k9mail/dev/ReleaseConfig.kt:8— app-k9mail/src/release/kotlin/app/k9mail/dev/ReleaseConfig.kt:8-15 | app-thunderbird/src/beta/kotlin/net/thunderbird/android/dev/BetaConfig.kt:8-15 | app-thunderbird/src/release/kotlin/net/thunderbird/android/dev/ReleaseConfig.kt:8-15 — before extracting anything, compare `app-k9mail/src/release/kotlin/app/k9mail/dev/ReleaseConfig.kt` and `app-thunderbird/src/beta/kotlin/net/thunderbird/android/dev/BetaConfig.kt` as WHOLE FILES: 90% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (12 lines × 4) app-thunderbird/src/beta/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:34— app-thunderbird/src/beta/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:34-45 | app-thunderbird/src/daily/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:34-45 | app-thunderbird/src/debug/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:34-45 | app-thunderbird/src/release/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:34-45 — before extracting anything, compare `app-thunderbird/src/beta/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt` and `app-thunderbird/src/daily/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 31 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 4) app-thunderbird/src/beta/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:97— app-thunderbird/src/beta/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:97-106 | app-thunderbird/src/daily/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:97-106 | app-thunderbird/src/debug/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:97-106 | app-thunderbird/src/release/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:97-106 — before extracting anything, compare `app-thunderbird/src/beta/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt` and `app-thunderbird/src/daily/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 31 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (9 lines × 4) app-thunderbird/src/beta/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:109— app-thunderbird/src/beta/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:109-117 | app-thunderbird/src/daily/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:109-117 | app-thunderbird/src/debug/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:109-117 | app-thunderbird/src/release/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt:109-117 — before extracting anything, compare `app-thunderbird/src/beta/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt` and `app-thunderbird/src/daily/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 31 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 3) core/validation/src/commonMain/kotlin/net/thunderbird/core/validation/input/BooleanInputField.kt:65— core/validation/src/commonMain/kotlin/net/thunderbird/core/validation/input/BooleanInputField.kt:65-70 | core/validation/src/commonMain/kotlin/net/thunderbird/core/validation/input/IntegerInputField.kt:66-71 | core/validation/src/commonMain/kotlin/net/thunderbird/core/validation/input/NumberInputField.kt:66-71 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 3) feature/account/avatar/impl/src/main/kotlin/net/thunderbird/feature/account/avatar/DefaultAvatarMonogramCreator.kt:10— feature/account/avatar/impl/src/main/kotlin/net/thunderbird/feature/account/avatar/DefaultAvatarMonogramCreator.kt:10-18 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo27.kt:42-50 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo28.kt:48-56 — before extracting anything, compare `legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo27.kt` and `legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo28.kt` as WHOLE FILES: 83% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 5) feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsViewModel.kt:305— feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsViewModel.kt:305-313 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/general/GeneralSettingsViewModel.kt:60-68 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/readingMail/ReadingMailSettingsViewModel.kt:94-102 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/search/SearchSettingsViewModel.kt:68-76 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/sendingMail/SendingMailSettingsViewModel.kt:249-257 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 5 times.
Duplicated block (7 lines × 3) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo22.kt:67— legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo22.kt:67-73 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo24.kt:73-79 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo25.kt:60-66 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 5) feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsViewModel.kt:316— feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsViewModel.kt:316-323 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/general/GeneralSettingsViewModel.kt:95-102 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/readingMail/ReadingMailSettingsViewModel.kt:153-160 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/search/SearchSettingsViewModel.kt:111-118 | feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/sendingMail/SendingMailSettingsViewModel.kt:260-267 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 5 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 5 times. Read the line range as the matched WINDOW rather than a finished unit: at `feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsViewModel.kt:316` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (38 lines × 3) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/ImapStoreUriDecoder.java:46— legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/ImapStoreUriDecoder.java:46-83 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/Pop3StoreUriDecoder.java:42-79 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/SmtpTransportUriDecoder.java:39-76 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
Duplicated block (25–26 lines × 3) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/Pop3StoreUriDecoder.java:39— legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/Pop3StoreUriDecoder.java:39-63 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/SmtpTransportUriDecoder.java:36-60 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/WebDavStoreUriDecoder.java:34-59 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/Pop3StoreUriDecoder.java:39` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (25 lines × 3) legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:80— legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:80-104 | legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:114-139 | legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:157-182 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:80` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:185` calls `execSQL` and `legacy/storage/src/main/java/com/fsck/k9/storage/StoreSchemaDefinition.java:140` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14 lines × 3) legacy/core/src/main/java/com/fsck/k9/mailstore/LocalStore.java:854— legacy/core/src/main/java/com/fsck/k9/mailstore/LocalStore.java:854-867 | legacy/core/src/main/java/com/fsck/k9/mailstore/LocalStore.java:900-913 | legacy/core/src/main/java/com/fsck/k9/mailstore/LocalStore.java:950-963 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/core/src/main/java/com/fsck/k9/mailstore/LocalStore.java:854` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12–13 lines × 2) legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java:695— legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java:695-706 | legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java:717-729 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java:695` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7–11 lines × 2) legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/ImapStoreUriDecoder.java:99— legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/ImapStoreUriDecoder.java:99-109 | legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/SmtpTransportUriDecoder.java:82-88 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `legacy/storage/src/main/java/com/fsck/k9/preferences/migration/migration12/ImapStoreUriDecoder.java:99` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8–9 lines × 2) legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:2009— legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:2009-2016 | legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:2215-2223 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
P3 · Security & performance tooling· SAST runs, but gates no merge · ×1
SAST runs, but gates no merge — `security-codeql.yml`, `security-fluidscan.yml`, `security-scorecard.yml` run(s) a static-analysis scan, but no workflow that runs one is triggered by a pull request (or a merge queue, or an unfiltered push) — the scan fires on a schedule or a manual dispatch only. A vulnerable change therefore merges clean and is reported on the next scheduled run, by which time it is on the default branch and the only remedy is a follow-up fix. Add the pull-request trigger to the workflow that runs the scan so the finding arrives before the merge rather than after it.
Third-party script without Subresource Integrity docs/assets/tb-theme/index.hbs:50— `https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.1/MathJax.js?config=TeX-AMS-MML_HTMLorMML` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session.
Orphaned file mail/common/src/main/java/com/fsck/k9/mail/internet/MessageExtractor.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientMvpView.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file REDACTED:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapResponseParser.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file ui-utils/toolbar-bottom-sheet/src/main/java/app/k9mail/ui/utils/bottomsheet/ToolbarBottomSheetDialog.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file mail/protocols/smtp/src/main/java/com/fsck/k9/mail/transport/smtp/SmtpResponseParser.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file mail/common/src/main/java/com/fsck/k9/mail/internet/MimeParameterDecoder.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file legacy/core/src/main/java/com/fsck/k9/message/quote/HtmlQuoteCreator.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file feature/settings/import/src/main/kotlin/app/k9mail/feature/settings/import/ui/SettingsImportFragment.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file feature/autodiscovery/autoconfig/src/main/kotlin/app/k9mail/autodiscovery/autoconfig/RealAutoconfigParser.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file legacy/storage/src/main/java/com/fsck/k9/storage/messages/CopyMessageOperations.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file legacy/core/src/main/java/com/fsck/k9/crypto/MessageCryptoStructureDetector.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file legacy/core/src/main/java/com/fsck/k9/mailstore/LockableDatabase.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/ViewBoundsCheck.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file legacy/core/src/main/java/com/fsck/k9/controller/MessagingControllerCommands.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file mail/common/src/main/java/com/fsck/k9/mail/helper/Rfc822Tokenizer.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/notificationactions/NotificationActionsReorderController.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file legacy/core/src/main/java/com/fsck/k9/notification/SummaryNotificationCreator.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file legacy/ui/legacy/src/main/java/com/fsck/k9/ui/ContactBadge.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file mail/common/src/main/java/com/fsck/k9/mail/internet/MimeUtility.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file legacy/core/src/main/java/com/fsck/k9/provider/DecryptedFileProvider.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file feature/settings/import/src/main/kotlin/app/k9mail/feature/settings/import/ui/SettingsImportUiModel.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file legacy/core/src/main/java/com/fsck/k9/provider/AttachmentTempFileProvider.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file legacy/storage/src/main/java/com/fsck/k9/storage/messages/ThreadMessageOperations.kt:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file legacy/ui/legacy/src/main/java/com/fsck/k9/activity/AlternateRecipientAdapter.java:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
README/code drift app-k9mail/README.md:9— app-k9mail/README.md links to `fastlane/metadata`, but `app-k9mail/fastlane/metadata` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift cli/html-cleaner-cli/README.md:15— cli/html-cleaner-cli/README.md links to `../../html-cleaner`, but `html-cleaner` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift cli/html-cleaner-cli/README.md:17— cli/html-cleaner-cli/README.md links to `../../app/html-cleaner/src/main/java/app/k9mail/html/cleaner`, but `app/html-cleaner/src/main/java/app/k9mail/html/cleaner` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift cli/translation-cli/README.md:28— cli/translation-cli/README.md names `legacy/core/src/res/values/arrays_general_settings_values.xml`, but no file or folder `legacy/core/src/res/values/arrays_general_settings_values.xml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/architecture/README.md:351— docs/architecture/README.md names `core/security`, but no file or folder `core/security` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/architecture/README.md:354— docs/architecture/README.md names `core/crypto`, but no file or folder `core/crypto` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/architecture/README.md:355— docs/architecture/README.md names `core/feature-flags`, but no file or folder `core/feature-flags` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/architecture/README.md:356— docs/architecture/README.md names `core/sync`, but no file or folder `core/sync` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/architecture/module-structure.md:11— docs/architecture/module-structure.md links to `adr/0009-api-internal-split.md`, but `docs/architecture/adr/0009-api-internal-split.md` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/contributing/code-quality-guide.md:76— docs/contributing/code-quality-guide.md names `build-plugin/src/main/kotlin/thunderbird.quality.detekt.gradle.kts`, but no file or folder `build-plugin/src/main/kotlin/thunderbird.quality.detekt.gradle.kts` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/contributing/code-quality-guide.md:99— docs/contributing/code-quality-guide.md names `build-plugin/src/main/kotlin/thunderbird.quality.spotless.gradle.kts`, but no file or folder `build-plugin/src/main/kotlin/thunderbird.quality.spotless.gradle.kts` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/contributing/code-quality-guide.md:135— docs/contributing/code-quality-guide.md documents the environment variable `UPPER_SNAKE_CASE`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/contributing/code-quality-guide.md:205— docs/contributing/code-quality-guide.md names `android.yml`, but no file or folder `android.yml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/contributing/managing-strings.md:29— docs/contributing/managing-strings.md names `plurals.xml`, but no file or folder `plurals.xml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/contributing/managing-strings.md:225— docs/contributing/managing-strings.md names `legacy/core/src/res/values/arrays_general_settings_values.xml`, but no file or folder `legacy/core/src/res/values/arrays_general_settings_values.xml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/contributing/managing-strings.md:257— docs/contributing/managing-strings.md names `app/core/src/main/res/values/arrays_general_settings_values.xml`, but no file or folder `app/core/src/main/res/values/arrays_general_settings_values.xml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/contributing/managing-strings.md:265— docs/contributing/managing-strings.md names `app/ui/legacy/src/main/res/values/arrays_general_settings_strings.xml`, but no file or folder `app/ui/legacy/src/main/res/values/arrays_general_settings_strings.xml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/contributing/testing-guide.md:394— docs/contributing/testing-guide.md documents the environment variable `CODE_COVERAGE_DISABLED`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/developer/foldable-device-support.md:36— docs/developer/foldable-device-support.md names `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/foldable/FoldableStateObserver.kt`, but no file or folder `legacy/ui/legacy/src/main/java/com/fsck/k9/ui/foldable/FoldableStateObserver.kt` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/developer/foldable-device-support.md:61— docs/developer/foldable-device-support.md names `legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MainActivity.kt`, but no file or folder `legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MainActivity.kt` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/release/HISTORICAL_RELEASE.md:60— docs/release/HISTORICAL_RELEASE.md names `app-k9mail/src/main/res/raw/changelog_master.xml`, but no file or folder `app-k9mail/src/main/res/raw/changelog_master.xml` exists. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/security/threat-modeling-guide.md:180— docs/security/threat-modeling-guide.md documents the environment variable `FLAG_IMMUTABLE`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift feature/notification/README.md:108— feature/notification/README.md links to `../../components/ui/bolt/src/commonMain/kotlin/net/thunderbird/core/ui/compose/theme2/thunderbird/ThemeColors.kt#L22`, but `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/core/ui/compose/theme2/thunderbird/ThemeColors.kt` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/engineering/technical-designs/0000-technical-design-template.md:4— docs/engineering/technical-designs/0000-technical-design-template.md links to `../rfcs/NNNN-title.md`, but `docs/engineering/rfcs/NNNN-title.md` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
README/code drift docs/engineering/technical-designs/0000-technical-design-template.md:5— docs/engineering/technical-designs/0000-technical-design-template.md links to `../adr/NNNN-title.md`, but `docs/engineering/adr/NNNN-title.md` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
Duplicated predicate mail/common/src/main/java/com/fsck/k9/mail/Multipart.java:47— `!MimeUtil.ENC_7BIT.equalsIgnoreCase(encoding) && !MimeUtil.ENC_8BIT.equalsIgnoreCase(encoding)` appears character-identically in 2 files — mail/common/src/main/java/com/fsck/k9/mail/Multipart.java, mail/common/src/main/java/com/fsck/k9/mail/internet/BinaryTempFileMessageBody.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate REDACTED:344— `K9MailLib.isDebug() && DEBUG_PROTOCOL_POP3` appears character-identically in 2 files — REDACTED, mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Folder.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/core/src/main/java/com/fsck/k9/mailstore/LocalMessage.java:229— `addresses == null || addresses.length == 0` appears character-identically in 2 files — legacy/core/src/main/java/com/fsck/k9/mailstore/LocalMessage.java, mail/common/src/main/java/com/fsck/k9/mail/internet/JisSupport.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java:1387— `message == null || message.getDatabaseId() == 0` appears character-identically in 2 files — legacy/core/src/main/java/com/fsck/k9/controller/MessagingController.java, legacy/core/src/main/java/com/fsck/k9/provider/RawMessageProvider.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/core/src/main/java/com/fsck/k9/helper/MimeTypeUtil.java:923— `mimeType != null && mimeType.equalsIgnoreCase(otherMimeType)` appears character-identically in 2 files — legacy/core/src/main/java/com/fsck/k9/helper/MimeTypeUtil.java, mail/common/src/main/java/com/fsck/k9/mail/internet/MimeUtility.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/ui/legacy/src/main/java/com/fsck/k9/activity/loader/AttachmentContentLoader.java:48— `takeContentChanged() || cachedResultAttachment == null` appears character-identically in 2 files — legacy/ui/legacy/src/main/java/com/fsck/k9/activity/loader/AttachmentContentLoader.java, legacy/ui/legacy/src/main/java/com/fsck/k9/activity/loader/AttachmentInfoLoader.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2593— `!account.hasArchiveFolder() || isArchiveFolder` appears character-identically in 2 files — legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2597— `!account.hasSpamFolder() || isSpamFolder` appears character-identically in 2 files — legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1180— `!isRemoteSearch && isRemoteSearchAllowed` appears character-identically in 2 files — legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt:449— `!messageFlags.contains(Flag.X_DOWNLOADED_FULL) && !messageFlags.contains(Flag.X_DOWNLOADED_PARTIAL)` appears character-identically in 2 files — backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt, backend/pop3/src/main/java/com/fsck/k9/backend/pop3/Pop3Sync.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:657— `!showRecentChangesHint && recentChangesSnackbarVisible` appears character-identically in 2 files — legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/setting/AccountSettingList.kt:31— `(isLandscape && isCompactHeight) || isSmallDisplay` appears character-identically in 2 files — feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/setting/AccountSettingList.kt, feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/setting/FolderSettingList.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:769— `account == null || isUnifiedFoldersView || accountManager.findAll().size == 1` appears character-identically in 2 files — legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1991— `account.expungePolicy == Expunge.EXPUNGE_MANUALLY && messagingController.supportsExpunge(account.id)` appears character-identically in 2 files — legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1978— `accountId == null || !messagingController.isMoveCapable(accountId)` appears character-identically in 2 files — legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:2477— `accountId == null || accountId !in accountIds` appears character-identically in 2 files — legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo12.kt:22— `accountUuidsListValue == null || accountUuidsListValue.isEmpty()` appears character-identically in 10 files — legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo12.kt, legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo14.kt, legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo15.kt, legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo17.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo27.kt:30— `avatarType == AvatarTypeDto.MONOGRAM.name && avatarMonogram.isEmpty()` appears character-identically in 2 files — legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo27.kt, legacy/storage/src/main/java/com/fsck/k9/preferences/migration/StorageMigrationTo28.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt:89— `config.sortType == SortType.SORT_DATE || config.sortType == SortType.SORT_ARRIVAL` appears character-identically in 3 files — feature/widget/message-list-glance/src/main/kotlin/net/thunderbird/feature/widget/message/list/MessageListLoader.kt, feature/widget/message-list/src/main/kotlin/app/k9mail/feature/widget/message/list/MessageListLoader.kt, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListLoader.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:791— `currentFolder.moreMessages && !localSearch.isManualSearch` appears character-identically in 2 files — legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/storage/src/main/java/com/fsck/k9/storage/messages/DeleteMessageOperations.kt:139— `cursor.moveToFirst() && !cursor.isNull(0)` appears character-identically in 3 files — legacy/storage/src/main/java/com/fsck/k9/storage/messages/DeleteMessageOperations.kt, legacy/storage/src/main/java/com/fsck/k9/storage/migrations/MigrationTo74.kt, legacy/storage/src/main/java/com/fsck/k9/storage/migrations/MigrationTo75.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/storage/src/main/java/com/fsck/k9/storage/messages/DeleteMessageOperations.kt:161— `cursor.moveToFirst() && !cursor.isNull(0) && cursor.getLong(0) > 0L` appears character-identically in 2 files — legacy/storage/src/main/java/com/fsck/k9/storage/messages/DeleteMessageOperations.kt, legacy/storage/src/main/java/com/fsck/k9/storage/migrations/MigrationTo74.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:1815— `dialogId == R.id.dialog_confirm_spam || dialogId == R.id.dialog_confirm_delete` appears character-identically in 2 files — legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate feature/autodiscovery/autoconfig/src/main/kotlin/app/k9mail/autodiscovery/autoconfig/PostMxLookupAutoconfigUrlProvider.kt:26— `email != null && config.includeEmailAddress` appears character-identically in 2 files — feature/autodiscovery/autoconfig/src/main/kotlin/app/k9mail/autodiscovery/autoconfig/PostMxLookupAutoconfigUrlProvider.kt, feature/autodiscovery/autoconfig/src/main/kotlin/app/k9mail/autodiscovery/autoconfig/ProviderAutoconfigUrlProvider.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt:671— `event == DISMISS_EVENT_SWIPE || event == DISMISS_EVENT_TIMEOUT` appears character-identically in 2 files — legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/LegacyMessageListFragment.kt, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
D20 · ADR Quality· ADR has no Consequences section · ×10
ADR has no Consequences section docs/engineering/adr/0001-switch-from-java-to-kotlin.md:1— docs/engineering/adr/0001-switch-from-java-to-kotlin.md has no Consequences section (a heading such as `## Consequences`, or the MADR equivalent). A decision record states the context that forced it, the decision and its consequences, so a reader can tell later whether it still holds.
ADR has no Consequences section docs/engineering/adr/0002-ui-wrap-material-components-in-atomic-design-system.md:1— docs/engineering/adr/0002-ui-wrap-material-components-in-atomic-design-system.md has no Consequences section (a heading such as `## Consequences`, or the MADR equivalent). A decision record states the context that forced it, the decision and its consequences, so a reader can tell later whether it still holds.
ADR has no Consequences section docs/engineering/adr/0003-switch-test-assertions-from-truth-to-assertk.md:1— docs/engineering/adr/0003-switch-test-assertions-from-truth-to-assertk.md has no Consequences section (a heading such as `## Consequences`, or the MADR equivalent). A decision record states the context that forced it, the decision and its consequences, so a reader can tell later whether it still holds.
ADR has no Consequences section docs/engineering/adr/0004-naming-conventions-for-interfaces-and-their-implementations.md:1— docs/engineering/adr/0004-naming-conventions-for-interfaces-and-their-implementations.md has no Consequences section (a heading such as `## Consequences`, or the MADR equivalent). A decision record states the context that forced it, the decision and its consequences, so a reader can tell later whether it still holds.
ADR has no Consequences section docs/engineering/adr/0005-central-project-configuration.md:1— docs/engineering/adr/0005-central-project-configuration.md has no Consequences section (a heading such as `## Consequences`, or the MADR equivalent). A decision record states the context that forced it, the decision and its consequences, so a reader can tell later whether it still holds.
ADR has no Consequences section docs/engineering/adr/0006-white-label-architecture.md:1— docs/engineering/adr/0006-white-label-architecture.md has no Consequences section (a heading such as `## Consequences`, or the MADR equivalent). A decision record states the context that forced it, the decision and its consequences, so a reader can tell later whether it still holds.
ADR has no Consequences section docs/engineering/adr/0007-project-structure.md:1— docs/engineering/adr/0007-project-structure.md has no Consequences section (a heading such as `## Consequences`, or the MADR equivalent). A decision record states the context that forced it, the decision and its consequences, so a reader can tell later whether it still holds.
ADR has no Consequences section docs/engineering/adr/0008-change-shared-modules-package-name.md:1— docs/engineering/adr/0008-change-shared-modules-package-name.md has no Consequences section (a heading such as `## Consequences`, or the MADR equivalent). A decision record states the context that forced it, the decision and its consequences, so a reader can tell later whether it still holds.
ADR has no Consequences section docs/engineering/adr/0009-api-internal-split.md:1— docs/engineering/adr/0009-api-internal-split.md has no Consequences section (a heading such as `## Consequences`, or the MADR equivalent). A decision record states the context that forced it, the decision and its consequences, so a reader can tell later whether it still holds.
ADR has no Consequences section docs/engineering/adr/0010-adopt-project-wide-repository-pattern.md:1— docs/engineering/adr/0010-adopt-project-wide-repository-pattern.md has no Consequences section (a heading such as `## Consequences`, or the MADR equivalent). A decision record states the context that forced it, the decision and its consequences, so a reader can tell later whether it still holds.
Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 116 significant file(s) lose their only recent owner: ui-utils/item-touch-helper/src/main/java/app/k9mail/ui/utils/itemtouchhelper/ItemTouchHelper.java, ui-utils/linear-layout-manager/src/main/java/app/k9mail/ui/utils/linearlayoutmanager/LinearLayoutManager.java, mail/common/src/main/java/com/fsck/k9/mail/internet/MimeMessage.java, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagedetails/MessageDetailsFragment.kt, plugins/openpgp-api-lib/openpgp-api/src/main/java/org/openintents/openpgp/util/OpenPgpKeyPreference.java, legacy/core/src/main/java/com/fsck/k9/notification/NotificationChannelManager.kt, feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/data/remote/bilingclient/BillingClient.kt, feature/funding/googleplay/src/main/kotlin/net/thunderbird/feature/funding/googleplay/ui/contribution/image/HearthSunburst.kt (+108 more). Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 74 significant file(s) lose their only recent owner: components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/swipe/SwipeableRowState.kt, feature/notification/api/src/commonMain/kotlin/net/thunderbird/feature/notification/api/ui/host/visual/InAppNotificationVisual.kt, components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/button/ButtonDefaults.kt, feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/state/MessageListState.kt, core/architecture/api/src/commonMain/kotlin/net/thunderbird/core/architecture/model/LegacyEntityIdFactory.kt, feature/mail/message/list/api/src/main/kotlin/net/thunderbird/feature/mail/message/list/ui/component/molecule/MessageBodyContent.kt, feature/notification/api/src/androidMain/kotlin/net/thunderbird/feature/notification/api/ui/InAppNotificationHost.kt, library/pii-safe/compiler-plugin/src/main/kotlin/net/thunderbird/piisafe/compiler/ir/transformer/ToStringOverridePiiSafeTransformer.kt (+66 more). Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #3 — If anonymized user #3 becomes unavailable, 12 significant file(s) lose their only recent owner: feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsViewModel.kt, feature/changelog/internal/src/main/kotlin/net/thunderbird/feature/changelog/internal/ChangelogScreen.kt, feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsBuilder.kt, legacy/core/src/main/java/com/fsck/k9/autocrypt/AutocryptOperations.java, feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/search/SearchSettingsViewModel.kt, feature/account/settings/impl/src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/fetchingMail/FetchingMailSettingsContent.kt, feature/changelog/internal/src/debug/kotlin/feature/changelog/internal/ChangelogScreenPreview.kt, feature/changelog/internal/src/main/kotlin/net/thunderbird/feature/changelog/internal/ChangelogViewModel.kt (+4 more). Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #4 — If anonymized user #4 becomes unavailable, 3 significant file(s) lose their only recent owner: feature/migration/qrcode/src/main/kotlin/app/k9mail/feature/migration/qrcode/settings/XmlSettingWriter.kt, feature/funding/common/src/main/kotlin/net/thunderbird/feature/funding/common/ui/reminder/FundingReminder.kt, components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/text/TextAutoResize.kt. Pair on, review, or document these before any departure.
Fat interface: Part (16 abstract methods) mail/common/src/main/java/com/fsck/k9/mail/Part.java:11— `Part` declares 16 abstract methods: `addHeader`, `addRawHeader`, `getBody`, `getContentId`, `getContentType`, `getDisposition`, `getHeader`, `getMimeType`, `getServerExtra`, `isMimeType`, `removeHeader`, `setBody`, `setHeader`, `setServerExtra`, `writeHeaderTo`, `writeTo`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: MessagingListener (23 abstract methods) legacy/message/src/main/java/app/k9mail/legacy/message/controller/MessagingListener.java:12— `MessagingListener` declares 23 abstract methods: `checkMailFinished`, `checkMailStarted`, `enableProgressIndicator`, `folderStatusChanged`, `loadAttachmentFailed`, `loadAttachmentFinished`, `loadMessageRemoteFailed`, `loadMessageRemoteFinished`, `messageUidChanged`, `remoteSearchFailed`, `remoteSearchFinished`, `remoteSearchServerQueryComplete`, `remoteSearchStarted`, `synchronizeMailboxFailed`, `synchronizeMailboxFinished`, `synchronizeMailboxHeadersFinished`, `synchronizeMailboxHeadersProgress`, `synchronizeMailboxHeadersStarted`, `synchronizeMailboxNewMessage`, `synchronizeMailboxProgress`, `synchronizeMailboxRemovedMessage`, `synchronizeMailboxStarted`, `updateProgress`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Hand-rolled JSON/XML parsing via regex legacy/core/src/main/java/com/fsck/k9/message/quote/HtmlQuoteCreator.java:27— A regex whose pattern encodes JSON/XML syntax is parsing a structured format by hand — malformed or differently-typed content (e.g. `"amount": "5"` as a string) silently mis-parses instead of failing validation. This JVM code already uses a real parser in the same package; use it here too.
Hand-rolled JSON/XML parsing via regex legacy/core/src/main/java/com/fsck/k9/message/quote/HtmlQuoteCreator.java:28— A regex whose pattern encodes JSON/XML syntax is parsing a structured format by hand — malformed or differently-typed content (e.g. `"amount": "5"` as a string) silently mis-parses instead of failing validation. This JVM code already uses a real parser in the same package; use it here too.
D16 · Bus Factor· Further sole-owners (lower concentration) · ×1
Further sole-owners (lower concentration) — 5 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (211 single-owned of 1000 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 1000 of the 3090 production source files in this repository met that bar). They are anonymized user #5 (2 file(s)), anonymized user #6 (1 file(s)), anonymized user #7 (1 file(s)), anonymized user #8 (1 file(s)), anonymized user #9 (1 file(s)) — spread or document their files in the same way, at lower priority than the named off-boarding risks above. The files folded here: legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/notificationactions/NotificationActionsReorderController.kt, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/notificationactions/NotificationActionsSettingsFragment.kt, legacy/core/src/main/java/com/fsck/k9/message/html/HttpUriParser.kt, legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/AttachmentController.kt, scripts/ci/contributor_list.py, core/android/common/src/main/kotlin/app/k9mail/core/android/common/camera/CameraCaptureHandler.kt.
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion — 7 of 152 project(s) overshoot their size bounds, lowering Project Cohesion to 9.1/10. The most over is `legacy/ui/legacy` (32866 LoC, 566 module-visible types across 40 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D28 · Secrets (history)· Rotate the exposed credentials · ×1
REDACTED
D34 · Knowledge Freshness· Further orphaned files (smaller) · ×1
Further orphaned files (smaller) — 213 smaller file(s) also have no living knowledge — folded into the freshness score and metrics rather than raised one row each — most significant first: mail/common/src/main/java/com/fsck/k9/mail/internet/MessageExtractor.java, legacy/ui/legacy/src/main/java/com/fsck/k9/activity/compose/RecipientMvpView.kt, REDACTED, mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapResponseParser.java, ui-utils/toolbar-bottom-sheet/src/main/java/app/k9mail/ui/utils/bottomsheet/ToolbarBottomSheetDialog.kt, mail/protocols/smtp/src/main/java/com/fsck/k9/mail/transport/smtp/SmtpResponseParser.kt, mail/common/src/main/java/com/fsck/k9/mail/internet/MimeParameterDecoder.kt, legacy/core/src/main/java/com/fsck/k9/message/quote/HtmlQuoteCreator.java (and 205 more) (220 orphaned of 1009 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 1009 of the 3090 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
DM2 · Strongly-typed ids· Primitive id on a domain type · ×1
Primitive id on a domain type: Success.rawNotificationId feature/notification/api/src/commonMain/kotlin/net/thunderbird/feature/notification/api/command/outcome/NotificationCommandOutcome.kt:27— `Success.rawNotificationId` is a raw `Int` — give it a strongly-typed id: a dedicated single-field type wrapping the `Int`, in whatever form your language spells that.
P10 · Library API & versioning· Large public API surface · ×1
Large public API surface — 73/93 types (78%) declared in the published library are public. For a library, every public type is a stability contract — keep implementation types off the surface and expose only the intended API.
Logging is not universal — Only 26/31 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `cli/autodiscovery-cli`, `cli/html-cleaner-cli`, `cli/resource-mover-cli`, `cli/translation-cli`, `cli/weblate-cli`.
Silent fallback default in catch legacy/core/src/main/java/com/fsck/k9/message/quote/QuoteDateFormatter.kt:19— `format` swallows every exception into `""` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
Silent fallback default on parse failure core/featureflag/src/commonMain/kotlin/net/thunderbird/core/featureflag/data/configstore/mapper/FeatureFlagConfigDefinitionMapper.kt:44— `decodeOverrides` answers `emptyMap()` when `SerializationException` is thrown, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the KDoc, and the row stops firing.
Off the main sequence: tfa:core:common — tfa:core:common: abstractness 0.18, instability 0.02, distance 0.80 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Off the main sequence: tfa:core:ui:compose:common — tfa:core:ui:compose:common: abstractness 0.08, instability 0.13, distance 0.80 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 134 file(s) — `app-common/src/main/kotlin/net/thunderbird/app/common/feature/mail/message/mapper/DomainToLegacyMessageMapper.kt`, `benchmarks/src/main/kotlin/net/thunderbird/benchmarks/common/account/BenchmarkAccountProvider.kt`, `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/icon/BadgeIconBuilder.kt`, `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/atom/icon/IconBuilder.kt`, `components/ui/bolt/src/commonMain/kotlin/net/thunderbird/components/ui/bolt/molecule/swipe/SwipeableRow.kt`, … (+129 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
Run 01a16fe3-f300-7b1f-ae85-6cc926dec7b1 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 23 · Warnings: 741 · Recommendations: 295 · Info: 2 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 24-10-2026 @ 21:49 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.