Public report — finagle, published 27 Sep 2026. Concrete security findings (which rule fired, in which file, on which line; CVE IDs, secret matches, dependency versions) are REDACTED in this version; ask the repo owner for the full report.
Public
Codebase survey Measured under the Code Assurance Index · rubric rubric-2026.09.15 (frozen) · verify this survey Filed cd_dc030282c93c4022abe97238b0b0f244 Filed 27 September 2026, 12:51 UTC Public

Twitter/finagle

Measured 27 September 2026, 10:45 UTC

Supply-chain provenance is not scored
75% Strong
CriticalWeakAdequateStrongExemplary
Architecture 93% Exemplary Code Health 92% Exemplary Security 85% Strong Readiness 73% Adequate Maturity 68% Adequate

Large · 112,827 LoC · rebuild ~2.1 person-years · weakest lens: Maturity (68%)

Findings by grade

12 critical 218 serious 10 minor 45 could not be resolved — could be critical — see Limitations

This survey was produced by

Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
27 September 2026, 10:45 UTC

A measurement, not a certificate. The Code Assurance Index does not certify, approve or guarantee this codebase; it records a reproducible number and the evidence it was computed from. The standard is authored by Canine Development, who also build Watchdog — its only implementation today. That is said here so the number is checked rather than believed.

Grounded in facts. Every number here is computed, not narrated — reproducible, tool-backed, and traceable to a line of code. How to trust this ▸

25/28dimensions tool-verifieddeterministic · confidence 1.0 · 3 LLM-assisted, advisory
233findings with an exact file:lineof 240 — the remainder are repo-wide signals (a dimension-level measurement, not a single line); open any file:line and verify
28/115dimensions across the health lenses112827 LoC — wide & deep
Chapters

Executive summary

The system holds a strong overall standing of 75%, indicating a robust asset that delivers value with manageable risk. This score reflects a codebase that is fundamentally sound in its core logic and architectural integrity, providing a stable foundation for future growth. However, the health of the organization’s ability to maintain and operate this system is uneven, creating specific vulnerabilities that require attention to sustain long-term delivery speed and reliability.

The scale of the investment is significant, with over 112,000 lines of production code and a comparable volume of tests. Rebuilding this logic from scratch would cost approximately €310,000 and require two to five engineers for two years, highlighting the substantial value tied up in the existing implementation. The code itself is highly refined, with virtually no boilerplate or straight-line logic, suggesting a mature engineering culture that has successfully avoided common technical debt traps in the core implementation.

The primary risk lies in knowledge freshness and operational readiness. While the code is well-structured, the maturity score of 68% reveals gaps in documentation and decision tracking that could slow down new team members or lead to repeated mistakes. Without clear records of significant architectural decisions or a quick-start guide, onboarding becomes a bottleneck, increasing the cost of change and the risk of human error during deployments. Additionally, unresolved orphaned files in key modules like the client builder and partitioning strategy create confusion about what is actually in use, potentially leading to wasted effort or accidental deletion of critical logic.

Conversely, the system’s architectural and code health are genuine strengths. The high scores in these areas mean that changes are less likely to ripple unexpectedly, and the code is easier to read and modify. Security posture is also solid at 85%, with no confirmed critical vulnerabilities, though supply chain monitoring remains unverified. To maximize leverage, the immediate focus should be adding a build and run section to the root documentation. This single action will dramatically improve newcomer productivity and reduce support overhead, providing the highest return on effort for the least amount of disruption.

Code Health 92% ★ Exemplary Architecture 93% ★ Exemplary Maturity 68% Adequate · gated by D34 Readiness 73% Adequate · gated by P3 Security 85% Strong
How the score is built — each lens's share of the headline Width is the lens's weight in the worst-heaviest fold (the weakest area pulls hardest); colour is that lens's own band. A lens fixes the score in proportion to its width.
Maturity 68% · 47% weightReadiness 73% · 26% weightSecurity 85% · 14% weightCode Health 92% · 8% weightArchitecture 93% · 4% weight

Raise Maturity 68 → 70 (the Healthy floor) ⇒ headline 75 → ~76.

Code composition — where the lines go
Tests 100%
New since the last scan (100+)

226 finding(s) are new versus the previous scan (2026-08-07) — surfaced by this scheduled scan itself, no pull request required. Showing the first 100; the full set is in the report.

  • D1 · IncludeCode.run (cyclomatic 31) doc/src/sphinx/exts/includecode.py
  • D1 · Interpreter.apply (cyclomatic 28) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Interpreter.scala
  • D1 · NameTree.eval (cyclomatic 20) finagle-core/src/main/scala/com/twitter/finagle/NameTree.scala
  • D1 · Simulation.main (cyclomatic 18) finagle-benchmark/src/main/scala/com/twitter/finagle/balancersim/Simulation.scala
  • D1 · NameTree.simplify (cyclomatic 18) finagle-core/src/main/scala/com/twitter/finagle/NameTree.scala
  • D1 · Namer.bind (cyclomatic 18) finagle-core/src/main/scala/com/twitter/finagle/Namer.scala
  • D1 · AuthNegotiation.step (cyclomatic 18) finagle-mysql/src/main/scala/com/twitter/finagle/mysql/AuthNegotiation.scala
  • D1 · Group.withMaxSyncConcurrency (cyclomatic 16) finagle-exp/src/main/scala/com/twitter/finagle/exp/fiber_scheduler/fiber/Group.scala
  • D1 · MuxClientSession.handleProcessMessage (cyclomatic 16) finagle-mux/src/main/scala/com/twitter/finagle/mux/pushsession/MuxClientSession.scala
  • D2 · IncludeCode.run (cognitive 48) doc/src/sphinx/exts/includecode.py
  • D2 · Interpreter.apply (cognitive 39) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Interpreter.scala
  • D2 · Rfc7230HeaderValidation.validateValue (cognitive 25) finagle-base-http/src/main/scala/com/twitter/finagle/http/headers/Rfc7230HeaderValidation.scala
  • D2 · ClientDispatcher.decodePacket (cognitive 25) finagle-mysql/src/main/scala/com/twitter/finagle/mysql/ClientDispatcher.scala
  • D2 · LinearPathMatcher.extractMatchingParameterValues (cognitive 23) finagle-http/src/main/scala/com/twitter/finagle/http/exp/routing/PathMatcher.scala
  • D2 · Message.decodeTreq (cognitive 23) finagle-mux/src/main/scala/com/twitter/finagle/mux/transport/Message.scala
  • D2 · Netty4FormPostEncoder.encode (cognitive 23) finagle-netty4-http/src/main/scala/com/twitter/finagle/netty4/http/Netty4FormPostEncoder.scala
  • D2 · WeightedP2CPick.pick (cognitive 22) finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/aperture/WeightedP2CPick.scala
  • D2 · ClientDecoder.decodeData (cognitive 22) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/protocol/text/client/ClientDecoder.scala
  • D2 · StringUtil.splitWorker (cognitive 21) finagle-base-http/src/main/scala/com/twitter/finagle/http/util/StringUtil.scala
  • D2 · Simulation.main (cognitive 21) finagle-benchmark/src/main/scala/com/twitter/finagle/balancersim/Simulation.scala
  • D2 · RequeueFilter.issueRequest (cognitive 21) finagle-core/src/main/scala/com/twitter/finagle/service/RequeueFilter.scala
  • D2 · Name.all (cognitive 20) finagle-core/src/main/scala/com/twitter/finagle/Name.scala
  • D2 · NameTree.simplify (cognitive 20) finagle-core/src/main/scala/com/twitter/finagle/NameTree.scala
  • D2 · Netty4ClientSslConfigurations.startClientWithKey (cognitive 20) finagle-netty4/src/main/scala/com/twitter/finagle/netty4/ssl/client/Netty4ClientSslConfigurations.scala
  • D2 · Netty4ServerSslConfigurations.startServerWithKey (cognitive 20) finagle-netty4/src/main/scala/com/twitter/finagle/netty4/ssl/server/Netty4ServerSslConfigurations.scala
  • D2 · QueryParamDecoder.decodeParams (cognitive 19) finagle-base-http/src/main/scala/com/twitter/finagle/http/QueryParamDecoder.scala
  • D2 · P2CPick.pick (cognitive 19) finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/p2c/P2CPick.scala
  • D2 · TraceId.deserialize (cognitive 19) finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceId.scala
  • D2 · Group.withMaxSyncConcurrency (cognitive 19) finagle-exp/src/main/scala/com/twitter/finagle/exp/fiber_scheduler/fiber/Group.scala
  • D2 · ZstdDecoder.decode (cognitive 19) finagle-netty4/src/main/java/com/twitter/finagle/netty4/codec/compression/zstd/ZstdDecoder.java
  • D2 · HttpDtab.readXDtabPairs (cognitive 18) finagle-base-http/src/main/scala/com/twitter/finagle/http/codec/HttpDtab.scala
  • D2 · UriUtils.isValidUri (cognitive 18) finagle-netty4-http/src/main/scala/com/twitter/finagle/netty4/http/util/UriUtils.scala
  • D2 · Endpoint.parseJson (cognitive 18) finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/Entry.scala
  • D2 · ClientTraceAnnotationsFilter.module (cognitive 18) finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ClientTraceAnnotationsFilter.scala
  • D2 · NameTree.eval (cognitive 17) finagle-core/src/main/scala/com/twitter/finagle/NameTree.scala
  • D2 · StabilizingAddr.apply (cognitive 17) finagle-core/src/main/scala/com/twitter/finagle/addr/StabilizingAddr.scala
  • D2 · LengthFieldFramer.readNextFrameLength (cognitive 17) finagle-core/src/main/scala/com/twitter/finagle/decoder/LengthFieldFramer.scala
  • D2 · Trace.letTracerAndId (cognitive 17) finagle-core/src/main/scala/com/twitter/finagle/tracing/Trace.scala
  • D2 · RedisPartitioningService.mergeResponses (cognitive 17) finagle-redis/src/main/scala/com/twitter/finagle/redis/RedisPartitioningService.scala
  • D2 · Namer.bind (cognitive 16) finagle-core/src/main/scala/com/twitter/finagle/Namer.scala
  • D2 · HeapLeastLoaded.get (cognitive 16) finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/heap/HeapLeastLoaded.scala
  • D2 · TraceInitializerFilter.apply (cognitive 16) finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala
  • D2 · AnnotatingTracingFilter.apply (cognitive 16) finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala
  • D2 · LogFormatter.escape (cognitive 16) finagle-http/src/main/scala/com/twitter/finagle/http/filter/LoggingFilter.scala
  • D2 · LogFormatter.escape (cognitive 16) finagle-http/src/main/scala/com/twitter/finagle/http/filter/LoggingFilter.scala
  • D2 · MuxClientSession.handleProcessMessage (cognitive 16) finagle-mux/src/main/scala/com/twitter/finagle/mux/pushsession/MuxClientSession.scala
  • D2 · AuthNegotiation.step (cognitive 16) finagle-mysql/src/main/scala/com/twitter/finagle/mysql/AuthNegotiation.scala
  • D2 · PgNumeric.bigDecimalToNumeric (cognitive 16) finagle-postgresql/src/main/scala/com/twitter/finagle/postgresql/types/PgNumeric.scala
  • D2 · Zk2Resolver.merge (cognitive 16) finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/Zk2Resolver.scala
  • D3 · TooManyMethods: Message finagle-base-http/src/main/scala/com/twitter/finagle/http/Message.scala
  • D3 · TooManyMethods: ClientBuilder finagle-core/src/main/scala/com/twitter/finagle/builder/ClientBuilder.scala
  • D3 · TooManyMethods: Tracing finagle-core/src/main/scala/com/twitter/finagle/tracing/Tracing.scala
  • D3 · TooManyMethods: Request finagle-base-http/src/main/scala/com/twitter/finagle/http/Request.scala
  • D3 · TooManyMethods: Row finagle-mysql/src/main/scala/com/twitter/finagle/mysql/Row.scala
  • D3 · TooManyMethods: NameTreeParsers finagle-core/src/main/scala/com/twitter/finagle/NameTreeParsers.scala
  • D3 · TooManyMethods: AbstractByteBufByteReader finagle-netty4/src/main/scala/com/twitter/finagle/netty4/AbstractByteBufByteReader.scala
  • D4 · Near-duplicate member pair (46 shared lines) finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala
  • D4 · Members sharing a duplicated core (4 members, 50+ identical tokens) finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala
  • D4 · Members sharing a duplicated core (4 members, 50+ identical tokens) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala
  • D4 · Members sharing a duplicated core (4 members, 50+ identical tokens) finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/Hashes.scala
  • D4 · Duplicated block (31 lines × 2) finagle-thrift/src/main/scala/com/twitter/finagle/thrift/RichClientParam.scala
  • D4 · Duplicated block (23 lines × 2) finagle-thrift/src/main/scala/com/twitter/finagle/thrift/RichClientParam.scala
  • D4 · Duplicated block (22 lines × 2) finagle-thrift/src/main/scala/com/twitter/finagle/thrift/service/ThriftResponseClassifier.scala
  • D4 · Duplicated block (22 lines × 2) finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala
  • D4 · Duplicated block (19 lines × 2) finagle-core/src/main/scala/com/twitter/finagle/service/ExpiringService.scala
  • D4 · Duplicated block (15 lines × 2) finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala
  • D4 · Duplicated block (14 lines × 2) finagle-thrift/src/main/scala/com/twitter/finagle/thrift/service/ThriftResponseClassifier.scala
  • D4 · Duplicated block (14 lines × 2) finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala
  • D4 · Duplicated block (11 lines × 2) finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala
  • D4 · Duplicated block (9–11 lines × 2) finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheZooKeeper.scala
  • D4 · Duplicated block (10 lines × 4) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala
  • D4 · Duplicated block (9–10 lines × 4) finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/Hashes.scala
  • D4 · Duplicated block (10 lines × 3) finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala
  • D4 · Duplicated block (10 lines × 2) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala
  • D4 · Duplicated block (10 lines × 2) finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala
  • D4 · Duplicated block (9 lines × 4) finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala
  • D4 · Duplicated block (9 lines × 2) finagle-netty4-http/src/main/scala/com/twitter/finagle/netty4/http/Bijections.scala
  • D4 · Duplicated block (9 lines × 2) finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheZooKeeper.scala
  • D4 · Duplicated block (8 lines × 2) finagle-benchmark/src/main/scala/com/twitter/finagle/thrift/ThriftGenBenchmark.scala
  • D4 · Duplicated block (6 lines × 2) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/MockClient.scala
  • D4 · Duplicated block (6 lines × 2) finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheZooKeeper.scala
  • D4 · Duplicated block (5 lines × 2) finagle-netty4/src/main/scala/com/twitter/finagle/netty4/ssl/client/Netty4ClientSslConfigurations.scala
  • D4 · Duplicated block (34 lines × 2) doc/src/sphinx/code/client-server-anatomy/netty3/Pipeline.scala
  • D4 · Duplicated block (22 lines × 2) finagle-toggle/src/main/scala/com/twitter/finagle/server/WriteOnce.scala
  • D4 · Duplicated block (17 lines × 2) finagle-base-http/src/main/scala/com/twitter/finagle/http/GenStreamingSerialServerDispatcher.scala
  • D4 · Duplicated block (5 lines × 2) finagle-core/src/main/scala/com/twitter/finagle/client/EndpointerStackClient.scala
  • D4 · Duplicated block (6 lines × 2) finagle-core/src/main/scala/com/twitter/finagle/client/StackClient.scala
  • D4 · Duplicated block (6 lines × 2) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/partitioning/MemcachedPartitioningService.scala
  • D4 · Duplicated block (13 lines × 2) finagle-mysql/src/main/scala/com/twitter/finagle/mysql/PlainHandshake.scala
  • D4 · Duplicated block (7 lines × 3) finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/BtreeSortedSet.scala
  • D4 · Duplicated block (11 lines × 2) finagle-stats-core/src/main/scala/com/twitter/finagle/stats/MetricsStatsReceiver.scala
  • D6 · Low cohesion: SimpleChannelSnooper (LCOM4 17) finagle-netty4/src/main/scala/com/twitter/finagle/netty4/channel/ChannelSnooper.scala
  • D6 · Low cohesion: Metrics (LCOM4 6) finagle-stats-core/src/main/scala/com/twitter/finagle/stats/Metrics.scala
  • D17 · TodoComment finagle-base-http/src/main/scala/com/twitter/finagle/http/QueryParamEncoder.scala
  • D17 · TodoComment finagle-base-http/src/main/scala/com/twitter/finagle/http/QueryParamEncoder.scala
  • D17 · TodoComment finagle-benchmark/src/main/scala/com/twitter/finagle/balancersim/Simulation.scala
  • D17 · TodoComment finagle-benchmark/src/main/scala/com/twitter/finagle/balancersim/Simulation.scala
  • D17 · TodoComment finagle-benchmark/src/main/scala/com/twitter/finagle/http/ParamMapBenchmark.scala
  • D17 · TodoComment finagle-core/src/main/scala/com/twitter/finagle/FactoryToService.scala
  • D17 · TodoComment finagle-core/src/main/scala/com/twitter/finagle/filter/MaskCancelFilter.scala

A full-fidelity diff against the previous run's complete recorded findings — line-move tolerant: a finding that only shifted line counts as unchanged, only genuinely new titles/files surface here.

Rebuild cost & value ~ Modeled — €100,000–€520,000
Cost to rebuild€100,000–€520,000 (1.0–3.2 person-years (1,712–5,431 h), ~1–5 engineers)
Domain complexityStandard — harder problems cost more per line
Quality factor1.1× (at 75% quality) — the last 20% of quality is most of the work
Size & shapeLarge · effort split not classified (source measured from disk; the effort-tier breakdown is a C#-only syntax walk)

This codebase represents roughly ~2.1 person-years of build effort (about ~€310,000 to rebuild). Its weakest lens is Maturity at 68% — the part of that asset most exposed by the findings below.

How we model this: boilerplate at a scaffolding rate + logic × domain Standard (×1.0) — standard service × a 1.1× quality factor, at €60–95/h; indicative, ±~30% · size measured directly from source · effort from total production LoC as straight-line logic (the tier split is a C#-only syntax walk), a conservative lower bound. Indicative only — most sensitive to the hourly rate and the domain tier (both tunable in config).

Top priorities

The highest-leverage moves; the full ranked list is in the Roadmap below.

1
Resolve the 3 Most significant orphaned file finding(s) in Knowledge Freshness — start with ClientBuilder.scala, PartitioningStrategy.scala, Thrift.scala.
+6.3 pts · Low effort · Knowledge Freshness
2
Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
+6.8 pts · Medium effort · Documentation (README)
3
Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree, with each file named `NNNN-title` in whatever markup those docs already use, is the most discoverable form).
+6.8 pts · Medium effort · Architecture documentation

Diagnosis — what's actually going on

Highest-leverage move · Medium · Leverage
Of everything flagged, the best return on effort is: Add a build/run (quick start) section to the root README — the first thing a newcomer needs. The rest can wait behind it.
Evidence: priority ranking: top of 5 ranked by impact/effort
→ Add a build/run (quick start) section to the root README — the first thing a newcomer needs.

Architecture — module dependency matrix

Rows and columns are the same modules, ordered so that a module only depends on ones above it. A cell means the row depends on the column, and its number is how many type pairs create that dependency. Read one thing: is anything above the diagonal? A mark there is a dependency cycle. (A cycle is all this shows — an unusual but cycle-free dependency sits below the diagonal like any other.)

575 modules, 1421 dependencies. 5 dependency cycles across 96 modules, marked above the diagonal.

Showing the 40 most-connected modules; 535 more are not drawn.

Module dependency matrix. The row depends on the column; the number is how many type pairs create the dependency. A cell above the diagonal is part of a dependency cycle.
depends on →1 com.twitter.finagle.benchmark2 com.twitter.finagle.context.LocalContext3 com.twitter.finagle.http.collection.RecordSchema4 com.twitter.finagle.postgresql.types.Kind5 com.twitter.finagle.ssl.OpportunisticTls6 com.twitter.finagle.Address7 com.twitter.finagle.Name8 com.twitter.finagle.http2.transport.client.RefCountedFactory9 com.twitter.finagle.transport10 com.twitter.finagle.Stack11 com.twitter.finagle.http.path12 com.twitter.finagle.memcached.protocol13 com.twitter.finagle.postgresql.Types14 com.twitter.finagle.serverset2.client.Data15 com.twitter.finagle.tracing16 com.twitter.finagle.http.exp.routing17 com.twitter.finagle.redis.exp18 com.twitter.finagle.service19 com.twitter.finagle.stats.StatsReceiverBenchmark20 com.twitter.finagle.thrift21 com.twitter.finagle.mux22 com.twitter.finagle.mysql23 com.twitter.finagle.serverset2.client24 com.twitter.finagle.serverset225 com.twitter.finagle.util26 com.twitter.finagle.loadbalancer27 com.twitter.finagle.param28 com.twitter.finagle.client29 com.twitter.finagle.http30 com.twitter.finagle.Filter31 com.twitter.finagle.redis.protocol32 com.twitter.finagle33 com.twitter.finagle.stats34 com.twitter.finagle.postgresql.Response35 com.twitter.finagle.server36 com.twitter.finagle.ssl37 Echo38 com.twitter.finagle.postgresql39 com.twitter.finagle.pushsession40 com.twitter.finagle.mux.pushsession
1 com.twitter.finagle.benchmark
2 com.twitter.finagle.context.LocalContext
3 com.twitter.finagle.http.collection.RecordSchema
4 com.twitter.finagle.postgresql.types.Kind
5 com.twitter.finagle.ssl.OpportunisticTls
6 com.twitter.finagle.Address3
7 com.twitter.finagle.Name3
8 com.twitter.finagle.http2.transport.client.RefCountedFactory1
9 com.twitter.finagle.transport3
10 com.twitter.finagle.Stack129
11 com.twitter.finagle.http.path67
12 com.twitter.finagle.memcached.protocol11311
13 com.twitter.finagle.postgresql.Types1
14 com.twitter.finagle.serverset2.client.Data1
15 com.twitter.finagle.tracing42518228212
16 com.twitter.finagle.http.exp.routing21414
17 com.twitter.finagle.redis.exp211365
18 com.twitter.finagle.service11323211183331
19 com.twitter.finagle.stats.StatsReceiverBenchmark22
20 com.twitter.finagle.thrift3181112211431320
21 com.twitter.finagle.mux3121211124
22 com.twitter.finagle.mysql38154225824314218102
23 com.twitter.finagle.serverset2.client1151742
24 com.twitter.finagle.serverset262151423
25 com.twitter.finagle.util6314115
26 com.twitter.finagle.loadbalancer3851121316
27 com.twitter.finagle.param12122
28 com.twitter.finagle.client11116214111183301
29 com.twitter.finagle.http73271210551122119
30 com.twitter.finagle.Filter3110
31 com.twitter.finagle.redis.protocol12384451
32 com.twitter.finagle105716101611621113171116
33 com.twitter.finagle.stats333623111461
34 com.twitter.finagle.postgresql.Response21351
35 com.twitter.finagle.server1538114121
36 com.twitter.finagle.ssl2221
37 Echo222242
38 com.twitter.finagle.postgresql11211562852
39 com.twitter.finagle.pushsession2111591
40 com.twitter.finagle.mux.pushsession12211817
Dependency, pointing down the layeringAbove the diagonal — part of a cycleThe module itself
…ter.finagle.benchmark….context.LocalContext…llection.RecordSchema…postgresql.types.Kind….ssl.OpportunisticTls…itter.finagle.Address….twitter.finagle.Name…ent.RefCountedFactory…ter.finagle.transport…twitter.finagle.Stack…ter.finagle.http.path…le.memcached.protocol…agle.postgresql.Types…erverset2.client.Data…itter.finagle.tracing…agle.http.exp.routing…ter.finagle.redis.exp…itter.finagle.service…tatsReceiverBenchmark…witter.finagle.thrift…m.twitter.finagle.mux…twitter.finagle.mysql…gle.serverset2.client…er.finagle.serverset2….twitter.finagle.util….finagle.loadbalancer…twitter.finagle.param…witter.finagle.client….twitter.finagle.http…witter.finagle.Filter…inagle.redis.protocolcom.twitter.finagle…twitter.finagle.stats…e.postgresql.Response…witter.finagle.server…m.twitter.finagle.sslEcho…er.finagle.postgresql…r.finagle.pushsession…nagle.mux.pushsession…ter.finagle.benchmark1….context.LocalContext2…llection.RecordSchema3…postgresql.types.Kind4….ssl.OpportunisticTls5…itter.finagle.Address6….twitter.finagle.Name7…ent.RefCountedFactory8…ter.finagle.transport9…twitter.finagle.Stack10…ter.finagle.http.path11…le.memcached.protocol12…agle.postgresql.Types13…erverset2.client.Data14…itter.finagle.tracing15…agle.http.exp.routing16…ter.finagle.redis.exp17…itter.finagle.service18…tatsReceiverBenchmark19…witter.finagle.thrift20…m.twitter.finagle.mux21…twitter.finagle.mysql22…gle.serverset2.client23…er.finagle.serverset224….twitter.finagle.util25….finagle.loadbalancer26…twitter.finagle.param27…witter.finagle.client28….twitter.finagle.http29…witter.finagle.Filter30…inagle.redis.protocol31com.twitter.finagle32…twitter.finagle.stats33…e.postgresql.Response34…witter.finagle.server35…m.twitter.finagle.ssl36Echo37…er.finagle.postgresql38…r.finagle.pushsession39…nagle.mux.pushsession40331312967113111142518228212214142113651132321118333122318111221143132031212111243815422582431421810211517426215142363141153851121316121221111621411118330173271210551122119311012384451105716101611621113171116333623111461213511538114121222122224211211562852211159112211817+535 more modules (most-connected shown)

At a glance — Code Health · 92% · Exemplary ·

The Good
D1 · Scala Cyclomatic Complexity 8.5 D3 · Scala God Classes 9.7 D4 · Scala Code Duplication 9.9 D17 · Scala Explicit Debt 9.8
The Bad
D2 · Scala Cognitive Complexity 6.8

At a glance — Architecture · 93% · Exemplary ·

The Good
D6 · Scala Cohesion (LCOM4) 9.9 D35 · Scala Change Coupling 10.0 AX10 · Repo Code composition 8.9

At a glance — Maturity · 68% · Adequate · gated by D34 ·

The Good
D15 · Scala Churn × Complexity Hotspots 10.0 D16 · Scala Bus Factor 9.9 D19 · Scala Documentation Quality 9.3 D21 · Scala Naming Consistency 10.0 M3 · Repo Folder & project structure 10.0 M4 · Repo Documentation accuracy 10.0
The Bad
M1 · Repo Documentation (README) 6.0 M2 · Repo Architecture documentation 5.0
The Ugly
D34 · Scala Knowledge Freshness 0.7

At a glance — Readiness · 73% · Adequate · gated by P3 ·

The Good
D9 · Scala Test Distribution 10.0 D12 · Scala Dependency Hygiene 10.0 D13 · Scala REDACTED Scanning 10.0 D14 · Scala License Compliance 10.0 P1 · Repo CI/CD gates 10.0 P6 · Repo Release Hygiene 10.0
The Ugly
P3 · Repo Security & performance tooling 1.0

At a glance — Security · 85% · Strong ·

The Good
D28 · Scala Secrets (history) 9.0 D30 · Scala Dependency Vulnerabilities 10.0 D43 · Scala Malicious Dependencies 10.0
The Bad
D29 · Scala Static Analysis (SAST) 5.0

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A03:2021 — Injection15High / Critical
A02:2021 — Cryptographic Failures2High / Critical

Roadmap

Begin by adding a build and run quick start to the root README and documenting key architectural decisions in a dedicated, discoverable location. Next, address the most significant orphaned files and concentrated knowledge decay to ensure critical code knowledge remains current and accessible. Finally, integrate a static analysis security step into the CI pipeline to automatically block security regressions before they are merged.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 3 Most significant orphaned file finding(s) in Knowledge Freshness — start with ClientBuilder.scala, PartitioningStrategy.scala, Thrift.scala.+6.3 ptsLowKnowledge Freshness
Add a build/run (quick start) section to the root README — the first thing a newcomer needs.+6.8 ptsMediumDocumentation (README)
Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree, with each file named `NNNN-title` in whatever markup those docs already use, is the most discoverable form).+6.8 ptsMediumArchitecture documentation
Resolve the 1 Concentrated knowledge decay finding(s) in Knowledge Freshness.+3.0 ptsLowKnowledge Freshness
Add a SAST step to CI running what this repository's stack ships: scalafix or scapegoat — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.+4.6 ptsMediumSecurity & performance tooling
Resolve the 1 REDACTED finding(s) in Secrets (history) — start with REDACTED.+0.7 ptsLowSecrets (history)
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED.+0.7 ptsLowStatic Analysis (SAST)
Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED.+0.7 ptsLowStatic Analysis (SAST)

File quality

Per-file score 0–10 — a quality signature. Of 133 files carrying findings, judged against the Production bar: 1% slop · 32% mixed · 67% near-clean.

FileScoreBandWorst signal
REDACTED0.8SlopStatic Analysis (SAST): High: REDACTED
finagle-benchmark/src/main/scala/com/twitter/finagle/balancersim/Simulation.scala6.0MixedExplicit Debt: TodoComment
finagle-http/src/main/scala/com/twitter/finagle/http/exp/routing/PathMatcher.scala6.0MixedExplicit Debt: TodoComment
finagle-mux/src/main/scala/com/twitter/finagle/mux/transport/Message.scala6.0MixedExplicit Debt: TodoComment
finagle-redis/src/main/scala/com/twitter/finagle/redis/ServerCommands.scala6.4MixedExplicit Debt: TodoComment
finagle-http/src/main/scala/com/twitter/finagle/http/exp/routing/Parameter.scala6.5MixedExplicit Debt: TodoComment
finagle-postgresql/src/test/scala/com/twitter/finagle/postgresql/PropertiesSpec.scala6.5MixedExplicit Debt: TodoComment
finagle-mux/src/main/scala/com/twitter/finagle/mux/lease/exp/Lessor.scala6.6MixedExplicit Debt: TodoComment
finagle-mux/src/main/scala/com/twitter/finagle/mux/lease/exp/Coordinator.scala6.6MixedExplicit Debt: TodoComment
finagle-postgresql/src/main/scala/com/twitter/finagle/postgresql/machine/ExecuteMachine.scala6.6MixedExplicit Debt: TodoComment
finagle-mysql/src/main/scala/com/twitter/finagle/mysql/ClientDispatcher.scala6.7MixedExplicit Debt: TodoComment
finagle-stats-core/src/main/scala/com/twitter/finagle/stats/MetricsStatsReceiver.scala6.7MixedExplicit Debt: TodoComment
finagle-postgresql/src/main/scala/com/twitter/finagle/postgresql/machine/SimpleQueryMachine.scala6.9MixedExplicit Debt: TodoComment
finagle-core/src/main/scala/com/twitter/finagle/client/EndpointerStackClient.scala7.0MixedCode Duplication: Duplicated block (5 lines × 2)
finagle-core/src/main/scala/com/twitter/finagle/NameTree.scala7.2MixedCyclomatic Complexity: NameTree.eval (cyclomatic 20)
finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala7.2MixedCognitive Complexity: TraceInitializerFilter.apply (cognitive 16)
finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala7.2MixedCode Duplication: Near-duplicate member pair (46 shared lines)
REDACTED7.2MixedSecrets (history): REDACTED: REDACTED
REDACTED7.2MixedStatic Analysis (SAST): High: REDACTED
REDACTED7.2MixedStatic Analysis (SAST): High: REDACTED

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 12

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 218

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 10

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 45

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 25 of 28 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 3 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.8 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 28 dimensions across the health lenses
D1D2D3D4D6D9D12D13D14D15D16D17D19D21D28D29D30D34D35D43AX10M1M2M3M4P1P3P6

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 233 of 240 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Watchdog duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic
LLM (sampled · advisory)Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurementLocal LLM◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 01a0e278-479c-7ef0-894f-d33dbbdca666.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.java, .scala) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo. To have real coverage read, produce a coverage report in a standard format (JaCoCo XML — `mvn jacoco:report` or the Gradle `jacocoTestReport` task, or `addSbtPlugin("org.scoverage" % "sbt-scoverage" % "<version>")` in `project/plugins.sbt`, then `sbt clean coverage test coverageReport`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures. You can widen what we reach: optional: produce a coverage report in a standard format (JaCoCo XML — `mvn jacoco:report` or the Gradle `jacocoTestReport` task, or `addSbtPlugin("org.scoverage" % "sbt-scoverage" % "<version>")` in `project/plugins.sbt`, then `sbt clean coverage test coverageReport`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures — then the real number is read on the next scan.
  • D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.java, .scala) and this repository declares an sbt build (repository root, 721 test files), but it was not re-run: the analyzer environment could not run it. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
  • D14 License Compliance — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares an sbt build (build.sbt), but the licence verdict published here was taken over its gem dependencies. Nothing was read about its sbt dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
  • D22 Internal API Consistency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is a COLLECTOR gap, not an environment fault: it declares a published package (build.sbt), but no published-package marker D22 reads admitted any project here, so this ecosystem's public API has no collector, and the remedy is to write one — no change to the scan image can close it.
  • D44 Platform End-of-Life — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This dimension reads a project's own statement about the platform it runs on: a TargetFramework in a .NET project file, a .nvmrc or .python-version, a capped requires-python, or a framework major pinned by a dependency constraint. This repository carries none of them, so nothing about its platform was established. That is a gap in this analyzer's coverage, NOT a finding that the platform is supported — a language whose runtime is declared elsewhere (go.mod, a Gemfile's ruby directive, a Dockerfile) is simply not read here yet.
  • AX3 Project dependency cycles — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is computed over which project references which. That is a language-neutral question, but the project-reference graph is collected from MSBuild .csproj, Gradle and Maven builds only, and this repository commits none — so there was no graph to read, and re-running the same commit reads the same nothing. Its modules are declared as: sbt subprojects (build.sbt); Ruby gems (gemspec, Gemfile); Bazel packages (BUILD, MODULE.bazel). A reader for that graph is the collector this check is missing. That is a COLLECTOR gap in this analyzer — no change to the scan image closes it — and not a finding that the repository is free of what this check looks for.
  • AX4 Dependency direction — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is computed over the direction each project reference points. That is a language-neutral question, but the project-reference graph is collected from MSBuild .csproj, Gradle and Maven builds only, and this repository commits none — so there was no graph to read, and re-running the same commit reads the same nothing. Its modules are declared as: sbt subprojects (build.sbt); Ruby gems (gemspec, Gemfile); Bazel packages (BUILD, MODULE.bazel). A reader for that graph is the collector this check is missing. That is a COLLECTOR gap in this analyzer — no change to the scan image closes it — and not a finding that the repository is free of what this check looks for.
  • AX6 Interface segregation — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is computed over the public interfaces this run's compilations declare, and none was loaded, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • AX8 Test isolation — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is computed over which projects are test projects, and what they reference. That is a language-neutral question, but the project-reference graph is collected from MSBuild .csproj, Gradle and Maven builds only, and this repository commits none — so there was no graph to read, and re-running the same commit reads the same nothing. Its modules are declared as: sbt subprojects (build.sbt); Ruby gems (gemspec, Gemfile); Bazel packages (BUILD, MODULE.bazel). A reader for that graph is the collector this check is missing. That is a COLLECTOR gap in this analyzer — no change to the scan image closes it — and not a finding that the repository is free of what this check looks for.
  • AXB1 Runtime evidence locked — no reproducible boot — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. The Runtime Evidence tier boots an app only via docker-compose, an Aspire AppHost, or a Dockerfile. None was found, so no live runtime a11y/egress/header evidence was collected. You can widen what we reach: add a docker-compose.yml (or an Aspire AppHost) that brings the app up with its dependencies. Watchdog then boots it in an isolated sandbox and gathers real runtime evidence — you change nothing in your pipeline (no CI step, no SDK).
  • C1 Data Protection — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These personal data controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks personal data controls.
  • C2 Access Controls — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • C3 Audit Trail — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These audit controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks audit controls.
  • C4 Data Retention — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These retention controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks retention controls.
  • C5 Data-Subject Rights — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These data-subject rights controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks data-subject rights controls.
  • ED5 Idempotency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check finds retry-prone mutations by walking the repository's declared types, and NONE was loaded on this run, so it had nothing to look at. That is a limit of the analyzer's reach — it reads .NET projects — not a finding that this repository has no command handlers or message consumers.
  • GD1 Unfinished & placeholder code — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • IC1 Incompleteness & stubs — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
  • S1 Web-Security Posture — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.
  • X1 Async correctness — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X12 Unreachable branch — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X13 Undrained process stream — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X14 Bypassable address classification — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X15 Unvalidated length from an untrusted reader — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X16 Unfloored truncation loop — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X17 Uncapped recursion over a caller-supplied document — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X18 Disposal-pattern correctness — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X19 Unrestored process-global state — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X2 Cancellation propagation — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X20 Mistyped argument guard — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X21 Side-effecting pattern guard — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X22 Contradicted release guard — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X23 Unguarded diagnostic materialisation — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X24 Document value interpolated into markup unescaped — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X25 Inert configuration knob — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X26 Unsynchronised callback handoff — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X27 Collection changed while being enumerated — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X28 Index access outside its own emptiness guard — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X29 Per-element action decided by a fixed element — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X3 Exception handling — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X30 Support guard that admits what it rejects — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X32 Type resolved by simple name across every loaded assembly — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X4 Structured logging — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X5 Nullable reference types — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is implemented over the C# syntax tree, and no C# was loaded on this run, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
  • D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
  • D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
  • D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

The LLM boundary

LLM-set scores this run (3): D19, D21, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.

Dimensions

D1 · Cyclomatic Complexity8.5 / 10Strong✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.5 / 10 · rule-coverage 100% · ceiling Prevented

9 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was IncludeCode.run at 31. A further 14 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being Status.fromCode at 59 — they are counted neither in the figure above nor in this dimension's score. 12 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: finagle-base-http/src/main/scala/com/twitter/finagle/http/Status.scala (Status.fromCode at 59), finagle-zipkin-core/src/main/scala/com/twitter/finagle/zipkin/core/RawZipkinTracer.scala (RawZipkinTracer.record at 30), finagle-mysql/src/main/scala/com/twitter/finagle/mysql/Type.scala (Type.getCodeString at 29), finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheKeeperException.scala (ApacheKeeperException.apply at 27), finagle-postgresql/src/main/scala/com/twitter/finagle/postgresql/transport/MessageDecoder.scala (MessageDecoder.fromBuf at 23), and 7 more not listed here. They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

IncludeCode.run (cyclomatic 31)doc/src/sphinx/exts/includecode.py:32
Interpreter.apply (cyclomatic 28)finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Interpreter.scala:19
NameTree.eval (cyclomatic 20)finagle-core/src/main/scala/com/twitter/finagle/NameTree.scala:251
Simulation.main (cyclomatic 18)finagle-benchmark/src/main/scala/com/twitter/finagle/balancersim/Simulation.scala:43
NameTree.simplify (cyclomatic 18)finagle-core/src/main/scala/com/twitter/finagle/NameTree.scala:159

+ 4 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 1 IncludeCode.run (cyclomatic 31) finding(s) in Cyclomatic Complexity — start with includecode.py. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 Interpreter.apply (cyclomatic 28) finding(s) in Cyclomatic Complexity — start with Interpreter.scala. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 NameTree.eval (cyclomatic 20) finding(s) in Cyclomatic Complexity — start with NameTree.scala. — One of this dimension's main actionable groups (1 warning-level).
  4. Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity6.8 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.8 / 10 · rule-coverage 100% · ceiling Prevented

40 method(s) exceeded the cognitive complexity threshold of 15; the worst was IncludeCode.run at 48.

LogFormatter.escape (cognitive 16) · ×2finagle-http/src/main/scala/com/twitter/finagle/http/filter/LoggingFilter.scala:17
IncludeCode.run (cognitive 48)doc/src/sphinx/exts/includecode.py:32
Interpreter.apply (cognitive 39)finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Interpreter.scala:19
Rfc7230HeaderValidation.validateValue (cognitive 25)finagle-base-http/src/main/scala/com/twitter/finagle/http/headers/Rfc7230HeaderValidation.scala:126
ClientDispatcher.decodePacket (cognitive 25)finagle-mysql/src/main/scala/com/twitter/finagle/mysql/ClientDispatcher.scala:181

+ 34 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 2 LogFormatter.escape (cognitive 16) finding(s) in Cognitive Complexity — start with LoggingFilter.scala (2). — One of this dimension's main actionable groups (2 warning-level).
  2. Resolve the 1 IncludeCode.run (cognitive 48) finding(s) in Cognitive Complexity — start with includecode.py. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 Interpreter.apply (cognitive 39) finding(s) in Cognitive Complexity — start with Interpreter.scala. — One of this dimension's main actionable groups (1 warning-level).
  4. Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes9.7 / 10Stronggated by 7 serious findings✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.7 / 10 · rule-coverage 100% · ceiling Prevented

7 god class(es) detected.

TooManyMethods: Message · ×7finagle-base-http/src/main/scala/com/twitter/finagle/http/Message.scala:28

What to do

  1. Resolve the 7 TooManyMethods finding(s) in God Classes — start with Message.scala, ClientBuilder.scala, Tracing.scala. — One of this dimension's main actionable groups (7 warning-level).
  2. Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication9.9 / 10Stronggated by 35 serious findings✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Verified

31 duplicated block group(s) detected. A further 4 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.

Duplicated block (6 lines × 2) · ×4finagle-memcached/src/main/scala/com/twitter/finagle/memcached/MockClient.scala:123
Members sharing a duplicated core (4 members, 50+ identical tokens) · ×3finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:80
Duplicated block (22 lines × 2) · ×3finagle-thrift/src/main/scala/com/twitter/finagle/thrift/service/ThriftResponseClassifier.scala:92
Duplicated block (14 lines × 2) · ×2finagle-thrift/src/main/scala/com/twitter/finagle/thrift/service/ThriftResponseClassifier.scala:116
Duplicated block (11 lines × 2) · ×2finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala:213

+ 18 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 4 Duplicated block (6 lines × 2) finding(s) in Code Duplication — start with MockClient.scala, ApacheZooKeeper.scala, StackClient.scala. — One of this dimension's main actionable groups (4 warning-level).
  2. Resolve the 3 Members sharing a duplicated core (4 members, 50+ identical tokens) finding(s) in Code Duplication — start with Balancers.scala, Client.scala, Hashes.scala. — One of this dimension's main actionable groups (3 warning-level).
  3. Resolve the 3 Duplicated block (22 lines × 2) finding(s) in Code Duplication — start with ThriftResponseClassifier.scala, ThriftMuxResponseClassifier.scala, WriteOnce.scala. — One of this dimension's main actionable groups (3 warning-level).
  4. Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)9.9 / 10Stronggated by 2 serious findings✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Verified

2 of 265 classes have LCOM4 above 3.

Low cohesion: SimpleChannelSnooper (LCOM4 17) · ×2finagle-netty4/src/main/scala/com/twitter/finagle/netty4/channel/ChannelSnooper.scala:77

What to do

  1. Resolve the 2 Low cohesion finding(s) in Cohesion (LCOM4) — start with ChannelSnooper.scala, Metrics.scala. — One of this dimension's main actionable groups (2 warning-level).
  2. Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.

Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

86 test methods: 86 unit, 0 integration, 0 BDD, 0 e2e.

✓ On the Gold path — maintain.

Detailed fixes: d9_recommendation.md.

D12 · Dependency Hygiene10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether dependencies are current, secure, and not bloated.

Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (saturating for vulnerabilities, capped-linear for deprecation/outdated) per KLoC. Exhaustive, deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 outdated direct gem(s), 0 pinning defect(s). 1 declaration(s) graded against rubygems.org, none of them against a committed Gemfile.lock — this repository commits none, which a published gem correctly does not, so currency is read off the declared requirements: a declaration that does not cap below the current release resolves to it on `bundle install`. 1 declaration(s) carry a requirement that EXCLUDES the current release; that is a deliberate constraint (a supported-version ceiling or a held-back CI pin) and is counted, not charged. Whether any of these gems is DEPRECATED or YANKED is not graded — rubygems.org publishes no deprecation marker, and a yank removes a version rather than flagging it. Whether any is UNMAINTAINED is not graded either: no registry publishes a maintenance status, and release age does not stand in for one. Whether any is UNUSED is a source question, not a registry one. Known CVEs in this dependency graph are D30's question, read from the manifest there.

✓ On the Gold path — maintain.

Detailed fixes: d12_recommendation.md.

D13 · REDACTED Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

REDACTED scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 1 shipped gem(s) use a banned license. Licences were resolved from rubygems.org over the 1 runtime gem(s) this repository declares. It commits no Gemfile.lock to close that set over, so the verdict covers the declarations rather than the whole resolved graph. Development-group and `add_development_dependency` gems are excluded: they are not distributed with this repository. This repository publishes itself under Apache License Version 2.0, which is its own choice and is not judged here. ★ COVERAGE OF THIS VERDICT: it grades this repository's gem dependencies and nothing else. The repository also declares an sbt build (build.sbt), and the licences of those dependencies were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots10.0 / 10Exemplary✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No churn × complexity hotspots in the window.

✓ On the Gold path — maintain.

Detailed fixes: d15_recommendation.md.

D16 · Bus Factor9.9 / 10Exemplary✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: Documented → Verified → Prevented · effective 9.9 / 10 · rule-coverage 100% · ceiling Documented

4 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is finagle-core/src/main/scala/com/twitter/finagle/Exceptions.scala. Counted over 327 of the 1204 production source files in this repository: 652 are under the ~2,400-byte size floor this dimension measures over, and the remaining 225 have no attributable history left to measure.

Off-boarding risk: anonymized user #1

✓ On the Gold path — maintain.

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt9.8 / 10Stronggated by 120 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Prevented

120 deducted task-comment markers across 112827 LoC (0.1/KLoC) → score 9.8. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×120finagle-base-http/src/main/scala/com/twitter/finagle/http/QueryParamEncoder.scala:47

What to do

  1. Resolve the 120 TodoComment finding(s) in Explicit Debt — start with ServerCommands.scala (24), Parameter.scala (6), PropertiesSpec.scala (5). — One of this dimension's main actionable groups (120 warning-level).
  2. Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation QualityExemplary◐ Sampled · advisory

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Documented

The repository's root README and its Finagle User Guide are clear and complete: the former states what the project is (Finagle itself) and gives status, releases, getting-involved links, adoption, and a one-line description of the project; the latter documents the user guide website build process, publishing steps, and an extensive Clients chapter covering stateless vs. stateful clients, eager connections, compression, and more, with a clip mid-Client API section (so no later sections are flagged as missing). The architecture/Docs markdown files (61) provide comprehensive design docs for the Finagle family of modules, which is the project's intended scope; each document in that set is judged against its own directory rather than the root README. All visible content is present and well-structured. This Finagle documentation is comprehensive and well-structured: it contains 13 README-style directory-level documents (Contexts, FAQ, Flags, Futures, Glossary) plus 61 architecture/design markdown files covering the project's concurrency model, retry storm semantics, global flags, futures pools, metrics format, and failure accrual. The body is clipped mid-document, so no trailing sections are flagged as missing; each visible document states what it covers (e.g., Contexts gives an overview of request-scoped state across asynchronous code) and the absence of a header section does not imply lack of overview.

✓ On the Gold path — maintain.

Detailed fixes: d19_recommendation.md.

D21 · Naming ConsistencyExemplary◐ Sampled · advisory

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Verified

0 naming inconsistencies across 0 sampled symbols.

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md.

D28 · Secrets (history)9.0 / 10Adequategated by 1 critical finding✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 9.0 / 10 · rule-coverage 100% · ceiling Documented

1 finding(s): 0 critical, 1 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED
REDACTED

What to do

  1. Resolve the 1 REDACTED finding(s) in Secrets (history) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  2. Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

D29 · Static Analysis (SAST)5.0 / 10Adequate✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Documented

15 finding(s): 0 critical, 11 high, 3 medium, 1 low. 8 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 2 file(s) — `doc/src/sphinx/_themes/flask/layout.html` (lines 1–4, line 6, lines 19–23, …), `doc/src/sphinx/_themes/flask_small/layout.html` (lines 1–16, lines 19–22) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 1 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 issue-level).
  2. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  3. No action in Static Analysis (SAST) — all 8 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (8 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir/Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex, Go, Java and Kotlin via Maven/Gradle, npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No known-vulnerable dependencies in any ecosystem this repository declares. No known-vulnerable gem among the 1 declared gem(s) osv.dev was asked about. This repository commits no Gemfile.lock — which a published gem correctly does not — so osv-scanner had no resolved graph to read, and the question was put to osv.dev instead over the releases `bundle install` resolves this repository's 1 declared requirement(s) to. The verdict therefore covers the DIRECT declarations at their resolved releases, not the transitive graph a lock would close over.

✓ On the Gold path — maintain.

Detailed fixes: d30_recommendation.md.

D34 · Knowledge Freshness0.7 / 10Critical✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 0.7 / 10 · rule-coverage 100% · ceiling Documented

516 of 552 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is finagle-core/src/main/scala/com/twitter/finagle/builder/ClientBuilder.scala. Counted over 552 of the 1204 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Most significant orphaned file · ×3finagle-core/src/main/scala/com/twitter/finagle/builder/ClientBuilder.scala
Concentrated knowledge decay

What to do

  1. Resolve the 3 Most significant orphaned file finding(s) in Knowledge Freshness — start with ClientBuilder.scala, PartitioningStrategy.scala, Thrift.scala. — One of this dimension's main actionable groups (3 recommendation-level).
  2. Resolve the 1 Concentrated knowledge decay finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling10.0 / 10Stronggated by 1 serious finding✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: EndpointerStackClient.scala↔ListeningStackServer.scala 53%

Change coupling: EndpointerStackClient.scala ↔ ListeningStackServer.scalafinagle-core/src/main/scala/com/twitter/finagle/client/EndpointerStackClient.scala

What to do

  1. Resolve the 1 Change coupling finding(s) in Change Coupling — start with EndpointerStackClient.scala. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Scored apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. SCORED, not informational.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious. No known-vulnerable gem among the 1 declared gem(s) osv.dev was asked about. This repository commits no Gemfile.lock — which a published gem correctly does not — so osv-scanner had no resolved graph to read, and the question was put to osv.dev instead over the releases `bundle install` resolves this repository's 1 declared requirement(s) to. The verdict therefore covers the DIRECT declarations at their resolved releases, not the transitive graph a lock would close over.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX10 · Code composition8.9 / 10Strong✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

What to do

  • The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
M1 · Documentation (README)6.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
  • Add a 'Testing' section to the root README — how to run the test suite.
  • Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
  • Add a README to the 4 of 4 project(s) that lack one — worth up to 2 pts.
M2 · Architecture documentation5.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.

What to do

  • Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree, with each file named `NNNN-title` in whatever markup those docs already use, is the most discoverable form).
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy10.0 / 10Exemplary◐ Sampled · advisory

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

P3 · Security & performance tooling1.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add scalafix or scapegoat (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 4073 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.

What to do

  • Add a SAST step to CI running what this repository's stack ships: scalafix or scapegoat — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P6 · Release Hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health92%ExemplarySolid.
Architecture93%ExemplaryStrongest area.
Maturity68%Adequate — gated by D34Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness73%Adequate — gated by P3Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security85%StrongSolid.
Not evidenced — 5 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • C3 Audit Trail — Not assessed: these audit controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C4 Data Retention — Not assessed: these retention controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks retention controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C5 Data-Subject Rights — Not assessed: these data-subject rights controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks data-subject rights controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • P4 Deployment & Rollback — not evidenced — no deploy/rollback/approval signal in the repo; absence of evidence is not evidence of a manual release
  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 82 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
  • AX1 Captive dependencies — no DI registrations detected
  • AX2 Stateful singletons — no singleton implementations detected
  • AX3 Project dependency cycles — not assessed — project cycles and dependency direction are computed over a project-reference graph that was not loaded for this repository, because the repository commits no project file of a kind this check models. This is a gap in the analyzer, not a finding about this repository
  • AX4 Dependency direction — not assessed — project cycles and dependency direction are computed over a project-reference graph that was not loaded for this repository, because the repository commits no project file of a kind this check models. This is a gap in the analyzer, not a finding about this repository
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX6 Interface segregation — not assessed — interface segregation is computed over a type surface that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — not assessed — test isolation is computed from a project graph (which projects are test projects, and what they reference) that was not loaded for this repository, because the repository commits no project file of a kind this check models. This is a gap in the analyzer, not a finding about this repository
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB1 Runtime evidence locked — no reproducible boot — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • D10 Test Quality — ~96255 lines of test source are present (.java, .scala) but no test cases reached the test census for this repository — no test root we could resolve declared them, or the files we read declare no cases in a test framework we recognise — so skipped/assertion-free tests couldn't be counted. Not scored — this is a gap in the analyzer, not a finding about this repository.
  • D11 Test Reliability — Test reliability not included — the .scala suite was found but not re-run
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
  • D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
  • D23 Boundary Type-Coupling — Production source is present (.java, .py, .rb, .scala) but bounded contexts are resolved over the C#/VB project set, which exposed none, so context scope could not be assessed. Not scored — this is a gap in the analyzer, not a verdict about this repository. Declaring the codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed — see the recommendation on this dimension for where. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — No inline comments to assess — comment value is not applicable here.
  • D25 ADR Conformance — no ADRs to check
  • D26 Project Cohesion — Project cohesion is assessed over the .NET project set; this target exposed no projects, so project size and spread could not be assessed. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
  • D27 Navigability — symbol resolution incomplete — navigability not assessed
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.
  • D36 Supply-chain Provenance & Signing — The CI pipeline builds and tests but publishes no released artifact — no package publish, container push, GitHub release or deployment step. Supply-chain provenance, signing and SBOM attest RELEASED artifacts, so there is nothing to attest here. Add them to the release pipeline when this repo starts shipping artifacts (a published package, a container image, a deployed service or a tagged release). Build integrity and workflow-token hygiene are reported below: they describe what the CI runs and the token it runs with, neither of which is affected by whether the pipeline ships an artifact.
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D44 Platform End-of-Life — Platform end-of-life not assessed — this repository declares no platform this pass reads
  • D5 Coupling — Inter-project coupling could not be assessed — no analyzable project graph was found for this repository. Not scored: a gap in the analyzer's reach, not a verdict about this repository. (Coupling here is Martin afferent/efferent/instability plus reference cycles across a project-reference graph, read today from .NET project files; other ecosystems' module graphs are not read yet.)
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • DM1 Domain Modelling — applicable but not scored (4 signals for this style, 2 needed — the count is met but a required primary signal is absent): 3 aggregate root(s) (AggregateRoot/IAggregateRoot); 1148 value object(s); 31 domain event(s); a Domain/Aggregates/ValueObjects layer; a top-level finagle-example/ tree: a library or framework whose examples are its consumers — these types are building blocks, not a domain
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
  • ED5 Idempotency — This check finds retry-prone mutations (command handlers and message/event consumers) by walking the repository's declared types, and none was loaded here, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • GD1 Unfinished & placeholder code — no source files were read — this check reads C# syntax, and none was loaded for this repository. That is a limit of the analyzer, not a finding about your code.
  • IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • P2 Observability — Observability was not assessed: this check reads a source model that does not carry this repository's product — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of a logging idiom this check recognises is NOT evidence that this repo lacks structured logging (it may log through its own ecosystem's logger). This is a gap in the analyzer, not a finding about this repository.
  • P7 Outbound HTTP resilience — not measured — the application kind could not be determined for this repo
  • P8 Schema migrations — not assessed — schema-migration practice is read from a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (`addSbtPlugin("org.scoverage" % "sbt-scoverage" % "<version>")` in `project/plugins.sbt`, then `sbt clean coverage test coverageReport`) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
  • PF1 Benchmark discipline — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
  • PF2 Allocation hygiene — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
  • PF3 Async & latency hygiene — Performance was not assessed: this lens reads a source model that was not loaded for this repository, because the repository is written in a language this lens does not yet model or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository — in particular it is NOT a statement that this repo is unpackaged or performance-careless.
  • S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • X1 Async correctness — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X12 Unreachable branch — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X13 Undrained process stream — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X14 Bypassable address classification — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X15 Unvalidated length from an untrusted reader — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X16 Unfloored truncation loop — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X17 Uncapped recursion over a caller-supplied document — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X18 Disposal-pattern correctness — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X19 Unrestored process-global state — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X2 Cancellation propagation — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X20 Mistyped argument guard — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X21 Side-effecting pattern guard — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X22 Contradicted release guard — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X23 Unguarded diagnostic materialisation — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X24 Document value interpolated into markup unescaped — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X25 Inert configuration knob — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X26 Unsynchronised callback handoff — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X27 Collection changed while being enumerated — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X28 Index access outside its own emptiness guard — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X29 Per-element action decided by a fixed element — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X3 Exception handling — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X30 Support guard that admits what it rejects — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X32 Type resolved by simple name across every loaded assembly — This check reads C# syntax; no C# was loaded for this repository, so it has nothing to report. That is a limit of the analyzer, not a finding about your code.
  • X4 Structured logging — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X5 Nullable reference types — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 12 finding(s)
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D28 · Secrets (history) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
Serious — 218 finding(s)
D17 · Explicit Debt · TodoComment · ×120
  • TodoComment finagle-base-http/src/main/scala/com/twitter/finagle/http/QueryParamEncoder.scala:47 — // TODO: URLEncoder is known to be slow, explore more efficient options. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-base-http/src/main/scala/com/twitter/finagle/http/QueryParamEncoder.scala:53 — // TODO: we can do better than a regex — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-benchmark/src/main/scala/com/twitter/finagle/balancersim/Simulation.scala:132 — // TODO: These latency events are dependent on the running time of — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-benchmark/src/main/scala/com/twitter/finagle/balancersim/Simulation.scala:223 — // TODO: export standard deviation. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-benchmark/src/main/scala/com/twitter/finagle/http/ParamMapBenchmark.scala:26 — // TODO: this is a bit of a cheat since we fastpath values without a space in the new impl — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-core/src/main/scala/com/twitter/finagle/FactoryToService.scala:27 — // TODO: we should simply transform the stack for boolean — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-core/src/main/scala/com/twitter/finagle/filter/MaskCancelFilter.scala:9 — // TODO: we should simply transform the stack for boolean — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-core/src/main/scala/com/twitter/finagle/util/StackRegistry.scala:33 — // TODO: many case classes have a $outer field because they close over an outside scope. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-core/src/main/scala/com/twitter/finagle/util/DefaultTimer.scala:80 — // TODO: We might consider doing round-robin over the set of "default" timers in future. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-core/src/test/scala/com/twitter/finagle/NameTreeTest.scala:107 — // TODO(jdonham) test fractional weights — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-core/src/test/scala/com/twitter/finagle/loadbalancer/aperture/LoadBandTest.scala:81 — // TODO: We should test this with a smoothWin to get a more — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-core/src/test/scala/com/twitter/finagle/tracing/TraceTest.scala:441 — // TODO: Consider using scalacheck here. (CSL-595)
  • TodoComment finagle-http/src/main/scala/com/twitter/finagle/http/exp/routing/PathMatcher.scala:203 — // TODO - spec compliant, but *will* break things — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-http/src/main/scala/com/twitter/finagle/http/exp/routing/PathMatcher.scala:418 — // TODO - TrieSpecMatcher — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-http/src/main/scala/com/twitter/finagle/http/exp/routing/Parameter.scala:19 — // TODO: missing Parameter properties (https://swagger.io/specification/#parameter-object):
  • TodoComment finagle-http/src/main/scala/com/twitter/finagle/http/exp/routing/Parameter.scala:50 — // TODO - minimum, maximum, exclusive minimum, exclusive maximum, multipleOf — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-http/src/main/scala/com/twitter/finagle/http/exp/routing/Parameter.scala:95 — // TODO - add support for exploding path styles at https://swagger.io/docs/specification/serialization/
  • TodoComment finagle-http/src/main/scala/com/twitter/finagle/http/exp/routing/Parameter.scala:97 — // TODO - array support — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-http/src/main/scala/com/twitter/finagle/http/exp/routing/Parameter.scala:98 — // TODO - object support (https://swagger.io/specification/#schema-object)
  • TodoComment finagle-http/src/main/scala/com/twitter/finagle/http/exp/routing/HttpRouter.scala:267 — // TODO - TrieHttpRouter — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-http/src/test/scala/com/twitter/finagle/http/SpnegoAuthenticatorTest.scala:40 — // TODO: c.t.u.Base64StringEncoder is too permissive: the only way to win is not to play — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-http/src/test/scala/com/twitter/finagle/http/DirectPayloadsLifecycleTest.scala:74 — // TODO: Test ALPN — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-http/src/test/scala/com/twitter/finagle/http/AbstractH2CEndToEndTest.scala:92 — // TODO: Consolidate behavior between h1 and h2 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-http/src/test/scala/com/twitter/finagle/http/AbstractEndToEndTest.scala:875 — // TODO: with offload on this now throws a ChannelClosedException — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment finagle-http2/src/main/scala/com/twitter/finagle/http2/param/Params.scala:123 — // TODO: revert to 8.kilobytes after we resolve https://github.com/netty/netty/issues/7511
  • + 95 more in this group — see findings.md.
D3 · God Classes · TooManyMethods · ×7
  • TooManyMethods: Message finagle-base-http/src/main/scala/com/twitter/finagle/http/Message.scala:28 — TooManyMethods — 64 methods. The bar is 30 methods; this is 34 over it, 2.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ClientBuilder finagle-core/src/main/scala/com/twitter/finagle/builder/ClientBuilder.scala:245 — TooManyMethods — 57 methods. The bar is 30 methods; this is 27 over it, 1.90× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Tracing finagle-core/src/main/scala/com/twitter/finagle/tracing/Tracing.scala:131 — TooManyMethods — 48 methods. The bar is 30 methods; this is 18 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Request finagle-base-http/src/main/scala/com/twitter/finagle/http/Request.scala:24 — TooManyMethods — 45 methods. The bar is 30 methods; this is 15 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Row finagle-mysql/src/main/scala/com/twitter/finagle/mysql/Row.scala:55 — TooManyMethods — 35 methods. The bar is 30 methods; this is 5 over it, 1.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: NameTreeParsers finagle-core/src/main/scala/com/twitter/finagle/NameTreeParsers.scala:15 — TooManyMethods — 32 methods. The bar is 30 methods; this is 2 over it, 1.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: AbstractByteBufByteReader finagle-netty4/src/main/scala/com/twitter/finagle/netty4/AbstractByteBufByteReader.scala:26 — TooManyMethods — 31 methods. The bar is 30 methods; this is 1 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×4
  • Duplicated block (6 lines × 2) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/MockClient.scala:123 — finagle-memcached/src/main/scala/com/twitter/finagle/memcached/MockClient.scala:123-128 | finagle-memcached/src/main/scala/com/twitter/finagle/memcached/MockClient.scala:136-142 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-memcached/src/main/scala/com/twitter/finagle/memcached/MockClient.scala:123` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheZooKeeper.scala:195 — finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheZooKeeper.scala:195-200 | finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheZooKeeper.scala:238-243 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheZooKeeper.scala:195` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (6 lines × 2) finagle-core/src/main/scala/com/twitter/finagle/client/StackClient.scala:56 — finagle-core/src/main/scala/com/twitter/finagle/client/StackClient.scala:56-61 | finagle-core/src/main/scala/com/twitter/finagle/server/StackServer.scala:33-38 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (6 lines × 2) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/partitioning/MemcachedPartitioningService.scala:130 — finagle-memcached/src/main/scala/com/twitter/finagle/memcached/partitioning/MemcachedPartitioningService.scala:130-135 | finagle-redis/src/main/scala/com/twitter/finagle/redis/RedisPartitioningService.scala:203-209 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×3
  • Members sharing a duplicated core (4 members, 50+ identical tokens) finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:80 — finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:80-93 | finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:120-139 | finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:149-165 | finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:371-383 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala:711 — finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala:711-723 | finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala:725-737 | finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala:739-751 | finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala:753-765 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/Hashes.scala:82 — finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/Hashes.scala:82-94 | finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/Keys.scala:100-112 | finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/Sets.scala:47-57 | finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/SortedSets.scala:338-348 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Duplicated block (22 lines × 2) · ×3
  • Duplicated block (22 lines × 2) finagle-thrift/src/main/scala/com/twitter/finagle/thrift/service/ThriftResponseClassifier.scala:92 — finagle-thrift/src/main/scala/com/twitter/finagle/thrift/service/ThriftResponseClassifier.scala:92-113 | finagle-thrift/src/main/scala/com/twitter/finagle/thrift/service/ThriftResponseClassifier.scala:199-220 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-thrift/src/main/scala/com/twitter/finagle/thrift/service/ThriftResponseClassifier.scala:92` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (22 lines × 2) finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala:93 — finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala:93-114 | finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala:205-226 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala:93` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (22 lines × 2) finagle-toggle/src/main/scala/com/twitter/finagle/server/WriteOnce.scala:19 — finagle-toggle/src/main/scala/com/twitter/finagle/server/WriteOnce.scala:19-40 | finagle-toggle/src/main/scala/com/twitter/finagle/toggle/WriteOnce.scala:19-40 — `finagle-toggle/src/main/scala/com/twitter/finagle/server/WriteOnce.scala` and `finagle-toggle/src/main/scala/com/twitter/finagle/toggle/WriteOnce.scala` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 1 separate duplicated blocks between them, totalling at least 22 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own.
D2 · Cognitive Complexity · LogFormatter.escape (cognitive 16) · ×2
  • LogFormatter.escape (cognitive 16) finagle-http/src/main/scala/com/twitter/finagle/http/filter/LoggingFilter.scala:17 — LogFormatter.escape has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (13 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (LogFormatter.escape) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
  • LogFormatter.escape (cognitive 16) finagle-http/src/main/scala/com/twitter/finagle/http/filter/LoggingFilter.scala:24 — LogFormatter.escape has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (13 pts), match/switch 1 (2 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (LogFormatter.escape) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×2
  • Duplicated block (14 lines × 2) finagle-thrift/src/main/scala/com/twitter/finagle/thrift/service/ThriftResponseClassifier.scala:116 — finagle-thrift/src/main/scala/com/twitter/finagle/thrift/service/ThriftResponseClassifier.scala:116-129 | finagle-thrift/src/main/scala/com/twitter/finagle/thrift/service/ThriftResponseClassifier.scala:223-236 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-thrift/src/main/scala/com/twitter/finagle/thrift/service/ThriftResponseClassifier.scala:116` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (14 lines × 2) finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala:117 — finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala:117-130 | finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala:229-242 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala:117` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×2
  • Duplicated block (11 lines × 2) finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala:213 — finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala:213-223 | finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala:250-260 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala:213` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) finagle-stats-core/src/main/scala/com/twitter/finagle/stats/MetricsStatsReceiver.scala:237 — finagle-stats-core/src/main/scala/com/twitter/finagle/stats/MetricsStatsReceiver.scala:237-247 | finagle-stats-core/src/main/scala/com/twitter/finagle/stats/PrometheusExporterHandler.scala:63-73 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×2
  • Duplicated block (10 lines × 2) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala:784 — finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala:784-793 | finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala:798-807 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala:784` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala:81 — finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala:81-90 | finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala:193-202 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala:81` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×2
  • Duplicated block (9 lines × 2) finagle-netty4-http/src/main/scala/com/twitter/finagle/netty4/http/Bijections.scala:64 — finagle-netty4-http/src/main/scala/com/twitter/finagle/netty4/http/Bijections.scala:64-72 | finagle-netty4-http/src/main/scala/com/twitter/finagle/netty4/http/Bijections.scala:119-127 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (9 lines × 2) finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheZooKeeper.scala:85 — finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheZooKeeper.scala:85-93 | finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheZooKeeper.scala:305-313 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheZooKeeper.scala:85` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×2
  • Duplicated block (5 lines × 2) finagle-netty4/src/main/scala/com/twitter/finagle/netty4/ssl/client/Netty4ClientSslConfigurations.scala:77 — finagle-netty4/src/main/scala/com/twitter/finagle/netty4/ssl/client/Netty4ClientSslConfigurations.scala:77-81 | finagle-netty4/src/main/scala/com/twitter/finagle/netty4/ssl/server/Netty4ServerSslConfigurations.scala:81-85 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-netty4/src/main/scala/com/twitter/finagle/netty4/ssl/client/Netty4ClientSslConfigurations.scala:77` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) finagle-core/src/main/scala/com/twitter/finagle/client/EndpointerStackClient.scala:98 — finagle-core/src/main/scala/com/twitter/finagle/client/EndpointerStackClient.scala:98-102 | finagle-thriftmux/src/main/scala/com/twitter/finagle/ThriftMux.scala:628-632 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D6 · Cohesion (LCOM4) · Low cohesion · ×2
  • Low cohesion: SimpleChannelSnooper (LCOM4 17) finagle-netty4/src/main/scala/com/twitter/finagle/netty4/channel/ChannelSnooper.scala:77 — SimpleChannelSnooper's methods fall into 17 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 17 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: Metrics (LCOM4 6) finagle-stats-core/src/main/scala/com/twitter/finagle/stats/Metrics.scala:150 — Metrics's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
D1 · Cyclomatic Complexity · IncludeCode.run (cyclomatic 31) · ×1
  • IncludeCode.run (cyclomatic 31) doc/src/sphinx/exts/includecode.py:32 — IncludeCode.run has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Interpreter.apply (cyclomatic 28) · ×1
  • Interpreter.apply (cyclomatic 28) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Interpreter.scala:19 — Interpreter.apply has cyclomatic complexity 28 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · NameTree.eval (cyclomatic 20) · ×1
  • NameTree.eval (cyclomatic 20) finagle-core/src/main/scala/com/twitter/finagle/NameTree.scala:251 — NameTree.eval has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · Simulation.main (cyclomatic 18) · ×1
  • Simulation.main (cyclomatic 18) finagle-benchmark/src/main/scala/com/twitter/finagle/balancersim/Simulation.scala:43 — Simulation.main has cyclomatic complexity 18 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · NameTree.simplify (cyclomatic 18) · ×1
  • NameTree.simplify (cyclomatic 18) finagle-core/src/main/scala/com/twitter/finagle/NameTree.scala:159 — NameTree.simplify has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · Namer.bind (cyclomatic 18) · ×1
  • Namer.bind (cyclomatic 18) finagle-core/src/main/scala/com/twitter/finagle/Namer.scala:218 — Namer.bind has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · AuthNegotiation.step (cyclomatic 18) · ×1
  • AuthNegotiation.step (cyclomatic 18) finagle-mysql/src/main/scala/com/twitter/finagle/mysql/AuthNegotiation.scala:192 — AuthNegotiation.step has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · Group.withMaxSyncConcurrency (cyclomatic 16) · ×1
  • Group.withMaxSyncConcurrency (cyclomatic 16) finagle-exp/src/main/scala/com/twitter/finagle/exp/fiber_scheduler/fiber/Group.scala:71 — Group.withMaxSyncConcurrency has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · MuxClientSession.handleProcessMessage (cyclomatic 16) · ×1
  • MuxClientSession.handleProcessMessage (cyclomatic 16) finagle-mux/src/main/scala/com/twitter/finagle/mux/pushsession/MuxClientSession.scala:246 — MuxClientSession.handleProcessMessage has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D2 · Cognitive Complexity · IncludeCode.run (cognitive 48) · ×1
  • IncludeCode.run (cognitive 48) doc/src/sphinx/exts/includecode.py:32 — IncludeCode.run has cognitive complexity 48 (threshold 15). Drivers by points: if/else 19 (34 pts), boolean chains 5, ternaries 4 (5 pts), error handling 3, loops 1 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Interpreter.apply (cognitive 39) · ×1
  • Interpreter.apply (cognitive 39) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Interpreter.scala:19 — Interpreter.apply has cognitive complexity 39 (threshold 15). Drivers by points: if/else 16 (25 pts), match/switch 7 (13 pts), boolean chains 1 (nesting depth added 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · Rfc7230HeaderValidation.validateValue (cognitive 25) · ×1
  • Rfc7230HeaderValidation.validateValue (cognitive 25) finagle-base-http/src/main/scala/com/twitter/finagle/http/headers/Rfc7230HeaderValidation.scala:126 — Rfc7230HeaderValidation.validateValue has cognitive complexity 25 (threshold 15). Drivers by points: if/else 13 (21 pts), match/switch 1 (2 pts), boolean chains 1, loops 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClientDispatcher.decodePacket (cognitive 25) · ×1
  • ClientDispatcher.decodePacket (cognitive 25) finagle-mysql/src/main/scala/com/twitter/finagle/mysql/ClientDispatcher.scala:181 — ClientDispatcher.decodePacket has cognitive complexity 25 (threshold 15). Drivers by points: loops 5 (20 pts), if/else 3 (4 pts), match/switch 1 (nesting depth added 16). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · LinearPathMatcher.extractMatchingParameterValues (cognitive 23) · ×1
  • LinearPathMatcher.extractMatchingParameterValues (cognitive 23) finagle-http/src/main/scala/com/twitter/finagle/http/exp/routing/PathMatcher.scala:355 — LinearPathMatcher.extractMatchingParameterValues has cognitive complexity 23 (threshold 15). Drivers by points: if/else 10 (14 pts), match/switch 3 (8 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Message.decodeTreq (cognitive 23) · ×1
  • Message.decodeTreq (cognitive 23) finagle-mux/src/main/scala/com/twitter/finagle/mux/transport/Message.scala:446 — Message.decodeTreq has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (17 pts), match/switch 3 (5 pts), loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Netty4FormPostEncoder.encode (cognitive 23) · ×1
  • Netty4FormPostEncoder.encode (cognitive 23) finagle-netty4-http/src/main/scala/com/twitter/finagle/netty4/http/Netty4FormPostEncoder.scala:42 — Netty4FormPostEncoder.encode has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (10 pts), match/switch 4 (9 pts), loops 1 (4 pts) (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WeightedP2CPick.pick (cognitive 22) · ×1
  • WeightedP2CPick.pick (cognitive 22) finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/aperture/WeightedP2CPick.scala:25 — WeightedP2CPick.pick has cognitive complexity 22 (threshold 15). Drivers by points: if/else 14 (22 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ClientDecoder.decodeData (cognitive 22) · ×1
  • ClientDecoder.decodeData (cognitive 22) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/protocol/text/client/ClientDecoder.scala:80 — ClientDecoder.decodeData has cognitive complexity 22 (threshold 15). Drivers by points: if/else 13 (21 pts), match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · StringUtil.splitWorker (cognitive 21) · ×1
  • StringUtil.splitWorker (cognitive 21) finagle-base-http/src/main/scala/com/twitter/finagle/http/util/StringUtil.scala:90 — StringUtil.splitWorker has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (15 pts), boolean chains 3, loops 2 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Simulation.main (cognitive 21) · ×1
  • Simulation.main (cognitive 21) finagle-benchmark/src/main/scala/com/twitter/finagle/balancersim/Simulation.scala:43 — Simulation.main has cognitive complexity 21 (threshold 15). Drivers by points: if/else 8 (10 pts), loops 4 (9 pts), boolean chains 1, match/switch 1 (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · RequeueFilter.issueRequest (cognitive 21) · ×1
  • RequeueFilter.issueRequest (cognitive 21) finagle-core/src/main/scala/com/twitter/finagle/service/RequeueFilter.scala:65 — RequeueFilter.issueRequest has cognitive complexity 21 (threshold 15). Drivers by points: if/else 12 (18 pts), boolean chains 2, match/switch 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Name.all (cognitive 20) · ×1
  • Name.all (cognitive 20) finagle-core/src/main/scala/com/twitter/finagle/Name.scala:160 — Name.all has cognitive complexity 20 (threshold 15). Drivers by points: match/switch 5 (13 pts), if/else 7 (nesting depth added 8). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · NameTree.simplify (cognitive 20) · ×1
  • NameTree.simplify (cognitive 20) finagle-core/src/main/scala/com/twitter/finagle/NameTree.scala:159 — NameTree.simplify has cognitive complexity 20 (threshold 15). Drivers by points: match/switch 7 (15 pts), if/else 5 (nesting depth added 8). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · Netty4ClientSslConfigurations.startClientWithKey (cognitive 20) · ×1
  • Netty4ClientSslConfigurations.startClientWithKey (cognitive 20) finagle-netty4/src/main/scala/com/twitter/finagle/netty4/ssl/client/Netty4ClientSslConfigurations.scala:62 — Netty4ClientSslConfigurations.startClientWithKey has cognitive complexity 20 (threshold 15). Drivers by points: loops 7 (19 pts), match/switch 1 (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · Netty4ServerSslConfigurations.startServerWithKey (cognitive 20) · ×1
  • Netty4ServerSslConfigurations.startServerWithKey (cognitive 20) finagle-netty4/src/main/scala/com/twitter/finagle/netty4/ssl/server/Netty4ServerSslConfigurations.scala:64 — Netty4ServerSslConfigurations.startServerWithKey has cognitive complexity 20 (threshold 15). Drivers by points: loops 7 (19 pts), match/switch 1 (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · QueryParamDecoder.decodeParams (cognitive 19) · ×1
  • QueryParamDecoder.decodeParams (cognitive 19) finagle-base-http/src/main/scala/com/twitter/finagle/http/QueryParamDecoder.scala:16 — QueryParamDecoder.decodeParams has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (16 pts), boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · P2CPick.pick (cognitive 19) · ×1
  • P2CPick.pick (cognitive 19) finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/p2c/P2CPick.scala:23 — P2CPick.pick has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (17 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TraceId.deserialize (cognitive 19) · ×1
  • TraceId.deserialize (cognitive 19) finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceId.scala:61 — TraceId.deserialize has cognitive complexity 19 (threshold 15). Drivers by points: if/else 12 (18 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Group.withMaxSyncConcurrency (cognitive 19) · ×1
  • Group.withMaxSyncConcurrency (cognitive 19) finagle-exp/src/main/scala/com/twitter/finagle/exp/fiber_scheduler/fiber/Group.scala:71 — Group.withMaxSyncConcurrency has cognitive complexity 19 (threshold 15). Drivers by points: if/else 10 (11 pts), boolean chains 6, loops 1 (2 pts) (nesting depth added 2). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ZstdDecoder.decode (cognitive 19) · ×1
  • ZstdDecoder.decode (cognitive 19) finagle-netty4/src/main/java/com/twitter/finagle/netty4/codec/compression/zstd/ZstdDecoder.java:47 — ZstdDecoder.decode has cognitive complexity 19 (threshold 15). Drivers by points: if/else 4 (11 pts), error handling 2 (5 pts), match/switch 1 (2 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · HttpDtab.readXDtabPairs (cognitive 18) · ×1
  • HttpDtab.readXDtabPairs (cognitive 18) finagle-base-http/src/main/scala/com/twitter/finagle/http/codec/HttpDtab.scala:171 — HttpDtab.readXDtabPairs has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (9 pts), loops 4 (7 pts), match/switch 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UriUtils.isValidUri (cognitive 18) · ×1
  • UriUtils.isValidUri (cognitive 18) finagle-netty4-http/src/main/scala/com/twitter/finagle/netty4/http/util/UriUtils.scala:11 — UriUtils.isValidUri has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 3, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Endpoint.parseJson (cognitive 18) · ×1
  • Endpoint.parseJson (cognitive 18) finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/Entry.scala:110 — Endpoint.parseJson has cognitive complexity 18 (threshold 15). Drivers by points: loops 10 (15 pts), match/switch 2 (3 pts) (nesting depth added 6). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · ClientTraceAnnotationsFilter.module (cognitive 18) · ×1
  • ClientTraceAnnotationsFilter.module (cognitive 18) finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ClientTraceAnnotationsFilter.scala:16 — ClientTraceAnnotationsFilter.module has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (15 pts), match/switch 1 (3 pts) (nesting depth added 10). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · NameTree.eval (cognitive 17) · ×1
  • NameTree.eval (cognitive 17) finagle-core/src/main/scala/com/twitter/finagle/NameTree.scala:251 — NameTree.eval has cognitive complexity 17 (threshold 15). Drivers by points: match/switch 6 (14 pts), if/else 3 (nesting depth added 8). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · StabilizingAddr.apply (cognitive 17) · ×1
  • StabilizingAddr.apply (cognitive 17) finagle-core/src/main/scala/com/twitter/finagle/addr/StabilizingAddr.scala:36 — StabilizingAddr.apply has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (10 pts), match/switch 3 (4 pts), loops 1 (2 pts), boolean chains 1 (nesting depth added 3). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · LengthFieldFramer.readNextFrameLength (cognitive 17) · ×1
  • LengthFieldFramer.readNextFrameLength (cognitive 17) finagle-core/src/main/scala/com/twitter/finagle/decoder/LengthFieldFramer.scala:91 — LengthFieldFramer.readNextFrameLength has cognitive complexity 17 (threshold 15). Drivers by points: if/else 12 (16 pts), match/switch 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Trace.letTracerAndId (cognitive 17) · ×1
  • Trace.letTracerAndId (cognitive 17) finagle-core/src/main/scala/com/twitter/finagle/tracing/Trace.scala:183 — Trace.letTracerAndId has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (12 pts), match/switch 2 (5 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RedisPartitioningService.mergeResponses (cognitive 17) · ×1
  • RedisPartitioningService.mergeResponses (cognitive 17) finagle-redis/src/main/scala/com/twitter/finagle/redis/RedisPartitioningService.scala:127 — RedisPartitioningService.mergeResponses has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (7 pts), match/switch 4 (7 pts), loops 1 (3 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Namer.bind (cognitive 16) · ×1
  • Namer.bind (cognitive 16) finagle-core/src/main/scala/com/twitter/finagle/Namer.scala:218 — Namer.bind has cognitive complexity 16 (threshold 15). Drivers by points: match/switch 4 (12 pts), if/else 4 (nesting depth added 8). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · HeapLeastLoaded.get (cognitive 16) · ×1
  • HeapLeastLoaded.get (cognitive 16) finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/heap/HeapLeastLoaded.scala:136 — HeapLeastLoaded.get has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 1, loops 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TraceInitializerFilter.apply (cognitive 16) · ×1
  • TraceInitializerFilter.apply (cognitive 16) finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala:79 — TraceInitializerFilter.apply has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (16 pts) (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AnnotatingTracingFilter.apply (cognitive 16) · ×1
  • AnnotatingTracingFilter.apply (cognitive 16) finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala:141 — AnnotatingTracingFilter.apply has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (11 pts), match/switch 2 (5 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MuxClientSession.handleProcessMessage (cognitive 16) · ×1
  • MuxClientSession.handleProcessMessage (cognitive 16) finagle-mux/src/main/scala/com/twitter/finagle/mux/pushsession/MuxClientSession.scala:246 — MuxClientSession.handleProcessMessage has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (12 pts), match/switch 2 (3 pts), boolean chains 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AuthNegotiation.step (cognitive 16) · ×1
  • AuthNegotiation.step (cognitive 16) finagle-mysql/src/main/scala/com/twitter/finagle/mysql/AuthNegotiation.scala:192 — AuthNegotiation.step has cognitive complexity 16 (threshold 15). Drivers by points: match/switch 5 (9 pts), if/else 5 (7 pts) (nesting depth added 6). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · PgNumeric.bigDecimalToNumeric (cognitive 16) · ×1
  • PgNumeric.bigDecimalToNumeric (cognitive 16) finagle-postgresql/src/main/scala/com/twitter/finagle/postgresql/types/PgNumeric.scala:52 — PgNumeric.bigDecimalToNumeric has cognitive complexity 16 (threshold 15). Drivers by points: if/else 10 (14 pts), loops 1 (2 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Zk2Resolver.merge (cognitive 16) · ×1
  • Zk2Resolver.merge (cognitive 16) finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/Zk2Resolver.scala:64 — Zk2Resolver.merge has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (8 pts), match/switch 3 (8 pts) (nesting depth added 6). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D35 · Change Coupling · Change coupling · ×1
  • Change coupling: EndpointerStackClient.scala ↔ ListeningStackServer.scala finagle-core/src/main/scala/com/twitter/finagle/client/EndpointerStackClient.scala — `finagle-core/src/main/scala/com/twitter/finagle/client/EndpointerStackClient.scala` and `finagle-core/src/main/scala/com/twitter/finagle/server/ListeningStackServer.scala` change together 53% of the time (9 of the 17 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `11ca7e82` finagle: more comprehensive support for dimensional metrics; `188c6f6b` finagle-core: Don't migrate all metrics yet; `4867a5c7` finagle-core: Move SourceRole subtypes into its object — run `git show` on any of them.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Near-duplicate member pair (46 shared lines) · ×1
  • Near-duplicate member pair (46 shared lines) finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala:81 — finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala:81-130 | finagle-thriftmux/src/main/scala/com/twitter/finagle/thriftmux/service/ThriftMuxResponseClassifier.scala:193-242 — These two members are variants of one another: 46 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Duplicated block (31 lines × 2) · ×1
  • Duplicated block (31 lines × 2) finagle-thrift/src/main/scala/com/twitter/finagle/thrift/RichClientParam.scala:138 — finagle-thrift/src/main/scala/com/twitter/finagle/thrift/RichClientParam.scala:138-168 | finagle-thrift/src/main/scala/com/twitter/finagle/thrift/RichServerParam.scala:86-116 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (23 lines × 2) · ×1
  • Duplicated block (23 lines × 2) finagle-thrift/src/main/scala/com/twitter/finagle/thrift/RichClientParam.scala:184 — finagle-thrift/src/main/scala/com/twitter/finagle/thrift/RichClientParam.scala:184-206 | finagle-thrift/src/main/scala/com/twitter/finagle/thrift/RichServerParam.scala:132-154 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×1
  • Duplicated block (19 lines × 2) finagle-core/src/main/scala/com/twitter/finagle/service/ExpiringService.scala:28 — finagle-core/src/main/scala/com/twitter/finagle/service/ExpiringService.scala:28-46 | finagle-core/src/main/scala/com/twitter/finagle/service/ExpiringService.scala:76-94 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-core/src/main/scala/com/twitter/finagle/service/ExpiringService.scala:28` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×1
  • Duplicated block (15 lines × 2) finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:227 — finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:227-241 | finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:320-334 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:227` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–11 lines × 2) · ×1
  • Duplicated block (9–11 lines × 2) finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheZooKeeper.scala:254 — finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheZooKeeper.scala:254-262 | finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheZooKeeper.scala:279-289 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/client/apache/ApacheZooKeeper.scala:254` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (10 lines × 4) · ×1
  • Duplicated block (10 lines × 4) finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala:714 — finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala:714-723 | finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala:728-737 | finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala:742-751 | finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala:756-765 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-memcached/src/main/scala/com/twitter/finagle/memcached/Client.scala:714` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–10 lines × 4) · ×1
  • Duplicated block (9–10 lines × 4) finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/Hashes.scala:85 — finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/Hashes.scala:85-94 | finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/Keys.scala:103-112 | finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/Sets.scala:49-57 | finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/SortedSets.scala:340-348 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/Hashes.scala:85` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×1
  • Duplicated block (10 lines × 3) finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala:210 — finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala:210-219 | finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala:247-256 | finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala:343-352 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-core/src/main/scala/com/twitter/finagle/tracing/TraceInitializerFilter.scala:210` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 4) · ×1
  • Duplicated block (9 lines × 4) finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:80 — finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:80-88 | finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:120-128 | finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:149-157 | finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:371-379 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:80` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:131` calls `P2CPeakEwma` and `finagle-core/src/main/scala/com/twitter/finagle/loadbalancer/Balancers.scala:158` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×1
  • Duplicated block (8 lines × 2) finagle-benchmark/src/main/scala/com/twitter/finagle/thrift/ThriftGenBenchmark.scala:38 — finagle-benchmark/src/main/scala/com/twitter/finagle/thrift/ThriftGenBenchmark.scala:38-45 | finagle-benchmark/src/main/scala/com/twitter/finagle/thrift/ThriftGenBenchmark.scala:101-108 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `finagle-benchmark/src/main/scala/com/twitter/finagle/thrift/ThriftGenBenchmark.scala:38` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (34 lines × 2) · ×1
  • Duplicated block (34 lines × 2) doc/src/sphinx/code/client-server-anatomy/netty3/Pipeline.scala:8 — doc/src/sphinx/code/client-server-anatomy/netty3/Pipeline.scala:8-41 | doc/src/sphinx/code/client-server-anatomy/netty4/Pipeline.scala:8-41 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `doc/src/sphinx/code/client-server-anatomy/netty3/Pipeline.scala:8` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note first that the copies are not typed on the same thing: `CharsetUtil` names `io.netty.util.CharsetUtil` in one and `org.jboss.netty.util.CharsetUtil` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×1
  • Duplicated block (17 lines × 2) finagle-base-http/src/main/scala/com/twitter/finagle/http/GenStreamingSerialServerDispatcher.scala:151 — finagle-base-http/src/main/scala/com/twitter/finagle/http/GenStreamingSerialServerDispatcher.scala:151-167 | finagle-core/src/main/scala/com/twitter/finagle/dispatch/ServerDispatcher.scala:133-149 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×1
  • Duplicated block (13 lines × 2) finagle-mysql/src/main/scala/com/twitter/finagle/mysql/PlainHandshake.scala:13 — finagle-mysql/src/main/scala/com/twitter/finagle/mysql/PlainHandshake.scala:13-25 | finagle-mysql/src/main/scala/com/twitter/finagle/mysql/SecureHandshake.scala:84-96 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×1
  • Duplicated block (7 lines × 3) finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/BtreeSortedSet.scala:39 — finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/BtreeSortedSet.scala:39-45 | finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/Hashes.scala:57-64 | finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/commands/Hashes.scala:69-76 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart.
Minor — 10 finding(s)
D34 · Knowledge Freshness · Most significant orphaned file · ×3
  • Most significant orphaned file finagle-core/src/main/scala/com/twitter/finagle/builder/ClientBuilder.scala — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
  • Most significant orphaned file finagle-thrift/src/main/scala/com/twitter/finagle/thrift/exp/partitioning/PartitioningStrategy.scala — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
  • Most significant orphaned file finagle-thrift/src/main/scala/com/twitter/finagle/Thrift.scala — One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
D16 · Bus Factor · Off-boarding risk · ×1
  • Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 4 significant file(s) lose their only recent owner: finagle-core/src/main/scala/com/twitter/finagle/Exceptions.scala, finagle-core/src/main/scala/com/twitter/finagle/InetResolver.scala, finagle-serversets/src/main/scala/com/twitter/finagle/serverset2/Zk2Resolver.scala, finagle-mux/src/main/scala/com/twitter/finagle/mux/pushsession/MuxServerSession.scala. Pair on, review, or document these before any departure.
D28 · Secrets (history) · Rotate the exposed credentials · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D34 · Knowledge Freshness · Concentrated knowledge decay · ×1
  • Concentrated knowledge decay — 516 of 552 significant files have no living knowledge, while the repository is still being changed at a low rate (5 commit(s) in the last 90 days) — so this is one repo-wide knowledge-decay state, not 516 separate risks. Counted over 552 of the 1204 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over. The code moved on without the people who understood these files: document them or schedule a read-through before the next change lands in them.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST — No static application security testing detected. For this repository's stack, add scalafix or scapegoat (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 4073 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-d8b96cf5a20a4adfa4518d1053401145/history.json --exit-code 0 --source .1artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-d8b96cf5a20a4adfa4518d1053401145/tree.json --exit-code 0 --source .1artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/watchdog-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off .15artifacts/raw/semgrep.json
D31 · IaC & Container Securitytrivy—trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.0—
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—

Run 01a0e278-479c-7ef0-894f-d33dbbdca666 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Issues: 12 · Warnings: 218 · Recommendations: 10 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 27-09-2026 @ 10:45 UTC.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md