Public report of vip32/Naos, published 22 October 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Watchdog signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 22 October 2026, 01:50 UTC · Survey ID cd_161e62618951480e972b75057784dcbd
vip32/Naos
Measured 22 October 2026, 01:46 UTC, at code version 8c1cd13
Test reliability is not measured: No test run produced results.
CAI scoreWeak
CriticalWeakAdequateStrongExemplary
Down 3 since the last survey
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A medium codebase: 52,730 lines of product code in 123 projects, tests not counted · Estimated rebuild effort: about 0.9 person-years · Weakest lens: Production Readiness, 34
Findings by how serious they are
197 critical1052 serious570 minor
3 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.
This survey was produced by
Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
22 October 2026, 01:46 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that
implements it, and today Watchdog is the only one that does.
The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
90of 94 dimensions measured by tools. The other 4 are advisory notes from an AI model, which explain the code but don't count towards the score.
1731of 1819 findings point to an exact file and line, so you can open each one in the code. The other 88 concern the repository as a whole, such as missing documentation.
94dimensions across 8 lenses, read from 52,730 lines of product code in 123 projects.
vip32/Naos scores 40 out of 100, which would normally be rated Adequate, but it is rated Weak because its weakest group of dimensions, Dependencies, is rated Critical. The standard never rates a score more than one step above its weakest group, so a high average can't hide a weak area. Watchdog judged it as a template, sample or demo, meant to be read or copied, so the dimensions about building, releasing and running a product don't apply, and its lenses are rated against a lower bar. The score itself is worked out as for any repository.
The weakest lens counts most in the score, and here that is Production Readiness, which scores 34 and is rated Adequate. Its Dependency Hygiene dimension scores 0 out of 10, and until that reaches 4, Production Readiness can't be rated higher than Adequate. The first actions are to resolve the 1 Leaked secret finding(s) in REDACTED Scanning and to resolve the 9 Vulnerable finding(s) in Dependency Hygiene. The weakest lenses score close to each other, so improving any of them moves the score.
197 findings are critical: 90 in Explicit Debt, 42 in Coupling, 18 in Captive dependencies, 17 in Dependency direction, 11 in Static Analysis (SAST), nine in Dependency Hygiene, four in Project dependency cycles, two in Change Coupling, one in CQS / query purity, one in REDACTED Scanning, one in Secrets (history) and one in Test Quality.
Watchdog couldn't measure Documentation Quality and IL Efficiency in this code, so those dimensions are left out of the score. The product code is 52,730 lines, which would take an estimated 0.9 person-years, around €130,000, to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
The weakest lenses score close to each other, so improving any of them moves the score.
Code composition: what the lines of code are
Business logic 26%Supporting code 48%Tests 25%Generated by tools 1%
New since the last survey: 190 findings
These 190 critical or serious findings weren't in the previous survey, on 7 October 2026. The first 100 are listed here, and the findings file in the download package lists them all.
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Application.Web/NaosExtensions.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Application.Web/NaosExtensions.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Application.Web/NaosExtensions.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V3/CosmosSqlProviderV3.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V3/CosmosSqlProviderV3.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs
Async correctness · Blocking `FileStorageMessageBroker.GetFileContents` inside an `async` method src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/ServiceDiscovery.Application/Client/ServiceDiscoveryClient.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Authentication.Application.Web/ApplicationExtensions.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Authentication.Application.Web/ApplicationExtensions.cs
Async correctness · Blocking `Thread.Sleep` inside an `async` method REDACTED
Async correctness · Blocking `Thread.Sleep` inside an `async` method REDACTED
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/Operations.Application.Web/Controllers/NaosOperationsLogTracesController.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/FileStorage/Provider/FileStorageDirectoryContents.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/FileStorage/Provider/FileStorageFileInfo.cs
Async correctness · Sync-over-async (deadlock risk) through `.Result` src/FileStorage/Provider/FileStorageFileInfo.cs
Cancellation propagation · Async method without CancellationToken: SendAsync src/Foundation.Application.Web/Console/Commands/OpenBrowserConsoleCommand.cs
Cancellation propagation · Async method without CancellationToken: FindOneAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs
Cancellation propagation · Async method without CancellationToken: ExistsAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs
Cancellation propagation · Async method without CancellationToken: InsertAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs
Cancellation propagation · Async method without CancellationToken: UpdateAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs
Cancellation propagation · Async method without CancellationToken: UpsertAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs
Cancellation propagation · Async method without CancellationToken: DeleteAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs
Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.
Fixed since the last survey: 66 findings
These 66 critical or serious findings were in the previous survey, on 7 October 2026, and are gone from this one.
Dependency direction · Dependency-rule violation: Configuration.Application (Application) → Infrastructure.Azure.KeyVault (Infrastructure)
Dependency direction · Dependency-rule violation: Commands.Application.Web (Application) → Utilities.Web (Web)
Dependency direction · Dependency-rule violation: Commands.Application.Web (Application) → Queueing.Infrastructure.Azure (Infrastructure)
Dependency direction · Dependency-rule violation: Commands.Application.Web (Application) → FileStorage.Infrastructure.Azure (Infrastructure)
Dependency direction · Dependency-rule violation: Commands.Application.Web (Application) → FileStorage.Infrastructure.FileSystem (Infrastructure)
Dependency direction · Dependency-rule violation: Commands.Application.Web.RabbitMQ (Application) → Infrastructure.RabbitMQ (Infrastructure)
Dependency direction · Dependency-rule violation: Commands.Application.Web.RabbitMQ (Application) → Queueing.Infrastructure.RabbitMQ (Infrastructure)
Dependency direction · Dependency-rule violation: Commands.Application.Web.Azure (Application) → Queueing.Infrastructure.Azure (Infrastructure)
Aggregate boundaries · Aggregate holds a reference to another aggregate: AggregateRoot.DomainEvents src/Foundation.Domain/Model/AggregateRoot.cs
Aggregate boundaries · Aggregate holds a reference to another aggregate: TenantAggregateRoot.DomainEvents src/Foundation.Domain/Model/TenantAggregateRoot.cs
Aggregate boundaries · Aggregate holds a reference to another aggregate: LogEvent.DomainEvents src/Operations.Domain/Logging/Model/LogEvent.cs
Aggregate boundaries · Aggregate holds a reference to another aggregate: Command.DomainEvents src/Commands.Domain/Model/Command.cs
Aggregate boundaries · Aggregate holds a reference to another aggregate: LogTrace.DomainEvents src/Tracing.Domain/Model/LogTrace.cs
Repository granularity · Repository for a non-root entity: LogAnalyticsLogEventRepository → LogEvent src/Operations.Infrastructure.Azure/Logging/Repositories/LogAnalyticsLogEventRepository.cs
Repository granularity · Repository for a non-root entity: LogAnalyticsLogTraceRepository → LogTrace src/Tracing.Infrastructure.Azure/Repositories/LogAnalyticsLogTraceRepository.cs
One transaction, one aggregate · One operation mutates 2 aggregates: SqlServerDocumentProvider.UpsertInternalAsync REDACTED
Rebuild cost: about €130,000 · Estimate
Cost to rebuild
€41,000 to €210,000, for 690 to 2,221 hours of work, about 0.9 person-years for 1 to 2 engineers
Difficulty of the problem
Very high, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.7 at a score of 40. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Medium: 52,730 lines of product code, of which 41% is declarations and boilerplate, 24% straight logic and 35% logic with branches
Comment lines
The estimate prices 45,357 lines. Comment lines count towards the size of 52,730 lines but aren't priced as work.
How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED.
Resolve the 7 FileScopedPragmaDisable finding(s) in Explicit Debt — start with FileStorageExtensions.cs (2), LogAnalyticsRepository.cs, InMemoryQueue.cs.
Raises the score by about 3 points · Low effort · Explicit Debt
Diagnosis: what the measurements show together
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €130,000 to build again, about 0.9 person-years of work. Its weakest lens is Production Readiness, at 34 (Weak). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
One cause behind 40 Domain Modelling findings · Common cause
40 findings in the Domain Modelling lens come from the same cause. The code models the business as objects, such as an order or a customer, and each object should guard its own rules: an order, for example, should refuse to be shipped before it has been paid. Here the objects don't do that. Other code can change an object's data directly, so it can put an order into a state the rules forbid. Some objects only hold data, while the rules that should keep that data valid sit elsewhere in the code. Identifiers, such as order numbers and customer numbers, are passed around as plain numbers or text, so nothing stops the code from using one kind where another belongs. Because all of these findings have the same cause, fixing it once, in the business objects themselves, deals with them together.
Based on: Encapsulated state (11 findings) · Rich vs anemic model (8 findings) · Strongly-typed ids (21 findings)
What to do: Give each business object the methods that enforce its rules, such as a method for shipping an order that first checks it has been paid, and let only those methods change its data. Give each kind of identifier a type of its own, so an order number can't be used where a customer number belongs.
If you do one thing first · First action
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning. Of all the actions in this report, it raises the score most for the work it takes: about 4 points for low effort, because it clears the 1 REDACTED Scanning findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture — bounded-context dependency graph
Each box is a bounded context (its layer projects grouped, or a project count when large); arrows show dependencies between contexts. A shared kernel is where many arrows converge.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
70 modules, with 143 dependencies between them. 4 loops run through 10 of the modules, marked above the diagonal.
The table shows the 40 modules with the most connections; 30 more are left out to keep it readable.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
Naos.Foundation.Domain.EventSourcing uses Naos.Foundation.Domain, so a change to Naos.Foundation.Domain can break Naos.Foundation.Domain.EventSourcing, while a change to Naos.Foundation.Domain.EventSourcing can't break Naos.Foundation.Domain.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Naos.KeyValueStorage.Domain uses Naos.Foundation, so a change to Naos.Foundation can break Naos.KeyValueStorage.Domain, while a change to Naos.KeyValueStorage.Domain can't break Naos.Foundation.
Position
Below the diagonal: Naos.KeyValueStorage.Domain uses a module listed above it, which is the healthy direction.
Naos.Foundation.Domain uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Foundation.Domain, while a change to Naos.Foundation.Domain can't break Naos.Foundation.
Position
Below the diagonal: Naos.Foundation.Domain uses a module listed above it, which is the healthy direction.
Naos.Foundation.Domain uses Naos.Foundation.Domain.EventSourcing, so a change to Naos.Foundation.Domain.EventSourcing can break Naos.Foundation.Domain, while a change to Naos.Foundation.Domain can't break Naos.Foundation.Domain.EventSourcing.
Position
Below the diagonal: Naos.Foundation.Domain uses a module listed above it, which is the healthy direction.
Naos.FileStorage.Domain uses Naos.Foundation, so a change to Naos.Foundation can break Naos.FileStorage.Domain, while a change to Naos.FileStorage.Domain can't break Naos.Foundation.
Position
Below the diagonal: Naos.FileStorage.Domain uses a module listed above it, which is the healthy direction.
Naos.FileStorage.Domain uses Naos.Foundation.Domain, so a change to Naos.Foundation.Domain can break Naos.FileStorage.Domain, while a change to Naos.FileStorage.Domain can't break Naos.Foundation.Domain.
Position
Below the diagonal: Naos.FileStorage.Domain uses a module listed above it, which is the healthy direction.
Naos.Foundation.Infrastructure uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Foundation.Infrastructure, while a change to Naos.Foundation.Infrastructure can't break Naos.Foundation.
Position
Below the diagonal: Naos.Foundation.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.Foundation.Infrastructure uses Naos.Foundation.Domain, so a change to Naos.Foundation.Domain can break Naos.Foundation.Infrastructure, while a change to Naos.Foundation.Infrastructure can't break Naos.Foundation.Domain.
Position
Below the diagonal: Naos.Foundation.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.Messaging.Domain uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Messaging.Domain, while a change to Naos.Messaging.Domain can't break Naos.Foundation.
Position
Below the diagonal: Naos.Messaging.Domain uses a module listed above it, which is the healthy direction.
Naos.Messaging.Domain uses Naos.Foundation.Domain, so a change to Naos.Foundation.Domain can break Naos.Messaging.Domain, while a change to Naos.Messaging.Domain can't break Naos.Foundation.Domain.
Position
Below the diagonal: Naos.Messaging.Domain uses a module listed above it, which is the healthy direction.
8→18 Naos.Messaging.Domain uses Naos.Messagingpart of a loop✕
Connections
1 pair of types, where a type in Naos.Messaging.Domain uses a type in Naos.Messaging.
Naos.Messaging.Domain uses Naos.Messaging, so a change to Naos.Messaging can break Naos.Messaging.Domain, while a change to Naos.Messaging.Domain can't break Naos.Messaging.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Naos.Operations.Domain uses Naos.Foundation.Domain, so a change to Naos.Foundation.Domain can break Naos.Operations.Domain, while a change to Naos.Operations.Domain can't break Naos.Foundation.Domain.
Position
Below the diagonal: Naos.Operations.Domain uses a module listed above it, which is the healthy direction.
Naos.RequestFiltering.Application uses Naos.Foundation, so a change to Naos.Foundation can break Naos.RequestFiltering.Application, while a change to Naos.RequestFiltering.Application can't break Naos.Foundation.
Position
Below the diagonal: Naos.RequestFiltering.Application uses a module listed above it, which is the healthy direction.
Naos.RequestFiltering.Application uses Naos.Foundation.Domain, so a change to Naos.Foundation.Domain can break Naos.RequestFiltering.Application, while a change to Naos.RequestFiltering.Application can't break Naos.Foundation.Domain.
Position
Below the diagonal: Naos.RequestFiltering.Application uses a module listed above it, which is the healthy direction.
Naos.Tracing.Domain uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Tracing.Domain, while a change to Naos.Tracing.Domain can't break Naos.Foundation.
Position
Below the diagonal: Naos.Tracing.Domain uses a module listed above it, which is the healthy direction.
Naos.Tracing.Domain uses Naos.Foundation.Domain, so a change to Naos.Foundation.Domain can break Naos.Tracing.Domain, while a change to Naos.Tracing.Domain can't break Naos.Foundation.Domain.
Position
Below the diagonal: Naos.Tracing.Domain uses a module listed above it, which is the healthy direction.
Naos.Commands.Application uses Naos.Foundation.Domain, so a change to Naos.Foundation.Domain can break Naos.Commands.Application, while a change to Naos.Commands.Application can't break Naos.Foundation.Domain.
Position
Below the diagonal: Naos.Commands.Application uses a module listed above it, which is the healthy direction.
Naos.Commands.Application uses Naos.Tracing.Domain, so a change to Naos.Tracing.Domain can break Naos.Commands.Application, while a change to Naos.Commands.Application can't break Naos.Tracing.Domain.
Position
Below the diagonal: Naos.Commands.Application uses a module listed above it, which is the healthy direction.
Naos.FileStorage uses Naos.Foundation, so a change to Naos.Foundation can break Naos.FileStorage, while a change to Naos.FileStorage can't break Naos.Foundation.
Position
Below the diagonal: Naos.FileStorage uses a module listed above it, which is the healthy direction.
Naos.FileStorage uses Naos.FileStorage.Domain, so a change to Naos.FileStorage.Domain can break Naos.FileStorage, while a change to Naos.FileStorage can't break Naos.FileStorage.Domain.
Position
Below the diagonal: Naos.FileStorage uses a module listed above it, which is the healthy direction.
31 pairs of types, where a type in Naos.FileStorage.Infrastructure uses a type in Naos.Foundation. Showing 25 of them; the rest are in namespace-graph.json in this report's bundle.
Naos.FileStorage.Infrastructure uses Naos.Foundation, so a change to Naos.Foundation can break Naos.FileStorage.Infrastructure, while a change to Naos.FileStorage.Infrastructure can't break Naos.Foundation.
Position
Below the diagonal: Naos.FileStorage.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.FileStorage.Infrastructure uses Naos.FileStorage.Domain, so a change to Naos.FileStorage.Domain can break Naos.FileStorage.Infrastructure, while a change to Naos.FileStorage.Infrastructure can't break Naos.FileStorage.Domain.
Position
Below the diagonal: Naos.FileStorage.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.Foundation.Infrastructure.Azure uses Naos.Foundation.Domain, so a change to Naos.Foundation.Domain can break Naos.Foundation.Infrastructure.Azure, while a change to Naos.Foundation.Infrastructure.Azure can't break Naos.Foundation.Domain.
Position
Below the diagonal: Naos.Foundation.Infrastructure.Azure uses a module listed above it, which is the healthy direction.
Naos.Foundation.Infrastructure.Azure uses Naos.Foundation.Infrastructure, so a change to Naos.Foundation.Infrastructure can break Naos.Foundation.Infrastructure.Azure, while a change to Naos.Foundation.Infrastructure.Azure can't break Naos.Foundation.Infrastructure.
Position
Below the diagonal: Naos.Foundation.Infrastructure.Azure uses a module listed above it, which is the healthy direction.
Naos.JobScheduling.Domain uses Naos.Foundation.Domain, so a change to Naos.Foundation.Domain can break Naos.JobScheduling.Domain, while a change to Naos.JobScheduling.Domain can't break Naos.Foundation.Domain.
Position
Below the diagonal: Naos.JobScheduling.Domain uses a module listed above it, which is the healthy direction.
Naos.JobScheduling.Domain uses Naos.Tracing.Domain, so a change to Naos.Tracing.Domain can break Naos.JobScheduling.Domain, while a change to Naos.JobScheduling.Domain can't break Naos.Tracing.Domain.
Position
Below the diagonal: Naos.JobScheduling.Domain uses a module listed above it, which is the healthy direction.
Naos.KeyValueStorage.Infrastructure uses Naos.Foundation, so a change to Naos.Foundation can break Naos.KeyValueStorage.Infrastructure, while a change to Naos.KeyValueStorage.Infrastructure can't break Naos.Foundation.
Position
Below the diagonal: Naos.KeyValueStorage.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.KeyValueStorage.Infrastructure uses Naos.KeyValueStorage.Domain, so a change to Naos.KeyValueStorage.Domain can break Naos.KeyValueStorage.Infrastructure, while a change to Naos.KeyValueStorage.Infrastructure can't break Naos.KeyValueStorage.Domain.
Position
Below the diagonal: Naos.KeyValueStorage.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.KeyValueStorage.Infrastructure uses Naos.FileStorage.Domain, so a change to Naos.FileStorage.Domain can break Naos.KeyValueStorage.Infrastructure, while a change to Naos.KeyValueStorage.Infrastructure can't break Naos.FileStorage.Domain.
Position
Below the diagonal: Naos.KeyValueStorage.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.Messaging uses Naos.Messaging.Domain, so a change to Naos.Messaging.Domain can break Naos.Messaging, while a change to Naos.Messaging can't break Naos.Messaging.Domain.
Position
Below the diagonal: Naos.Messaging uses a module listed above it, which is the healthy direction.
Naos.Operations.Application uses Naos.Operations.Domain, so a change to Naos.Operations.Domain can break Naos.Operations.Application, while a change to Naos.Operations.Application can't break Naos.Operations.Domain.
Position
Below the diagonal: Naos.Operations.Application uses a module listed above it, which is the healthy direction.
Naos.Operations.Application uses Naos.RequestFiltering.Application, so a change to Naos.RequestFiltering.Application can break Naos.Operations.Application, while a change to Naos.Operations.Application can't break Naos.RequestFiltering.Application.
Position
Below the diagonal: Naos.Operations.Application uses a module listed above it, which is the healthy direction.
Naos.Operations.Infrastructure.Mongo uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Operations.Infrastructure.Mongo, while a change to Naos.Operations.Infrastructure.Mongo can't break Naos.Foundation.
Position
Below the diagonal: Naos.Operations.Infrastructure.Mongo uses a module listed above it, which is the healthy direction.
Naos.Operations.Infrastructure.Mongo uses Naos.Foundation.Infrastructure, so a change to Naos.Foundation.Infrastructure can break Naos.Operations.Infrastructure.Mongo, while a change to Naos.Operations.Infrastructure.Mongo can't break Naos.Foundation.Infrastructure.
Position
Below the diagonal: Naos.Operations.Infrastructure.Mongo uses a module listed above it, which is the healthy direction.
Naos.Operations.Infrastructure.Mongo uses Naos.Operations.Domain, so a change to Naos.Operations.Domain can break Naos.Operations.Infrastructure.Mongo, while a change to Naos.Operations.Infrastructure.Mongo can't break Naos.Operations.Domain.
Position
Below the diagonal: Naos.Operations.Infrastructure.Mongo uses a module listed above it, which is the healthy direction.
Naos.Queueing.Domain uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Queueing.Domain, while a change to Naos.Queueing.Domain can't break Naos.Foundation.
Position
Below the diagonal: Naos.Queueing.Domain uses a module listed above it, which is the healthy direction.
Naos.Queueing.Domain uses Naos.Foundation.Domain, so a change to Naos.Foundation.Domain can break Naos.Queueing.Domain, while a change to Naos.Queueing.Domain can't break Naos.Foundation.Domain.
Position
Below the diagonal: Naos.Queueing.Domain uses a module listed above it, which is the healthy direction.
Naos.Queueing.Domain uses Naos.Tracing.Domain, so a change to Naos.Tracing.Domain can break Naos.Queueing.Domain, while a change to Naos.Queueing.Domain can't break Naos.Tracing.Domain.
Position
Below the diagonal: Naos.Queueing.Domain uses a module listed above it, which is the healthy direction.
Naos.Tracing.Application uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Tracing.Application, while a change to Naos.Tracing.Application can't break Naos.Foundation.
Position
Below the diagonal: Naos.Tracing.Application uses a module listed above it, which is the healthy direction.
Naos.Tracing.Application uses Naos.Tracing.Domain, so a change to Naos.Tracing.Domain can break Naos.Tracing.Application, while a change to Naos.Tracing.Application can't break Naos.Tracing.Domain.
Position
Below the diagonal: Naos.Tracing.Application uses a module listed above it, which is the healthy direction.
22→34 Naos.Tracing.Application uses Microsoft.Extensions.DependencyInjectionpart of a loop✕
Connections
1 pair of types, where a type in Naos.Tracing.Application uses a type in Microsoft.Extensions.DependencyInjection.
Naos.Tracing.Application uses Microsoft.Extensions.DependencyInjection, so a change to Microsoft.Extensions.DependencyInjection can break Naos.Tracing.Application, while a change to Naos.Tracing.Application can't break Microsoft.Extensions.DependencyInjection.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Naos.Tracing.Infrastructure uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Tracing.Infrastructure, while a change to Naos.Tracing.Infrastructure can't break Naos.Foundation.
Position
Below the diagonal: Naos.Tracing.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.Tracing.Infrastructure uses Naos.Foundation.Infrastructure, so a change to Naos.Foundation.Infrastructure can break Naos.Tracing.Infrastructure, while a change to Naos.Tracing.Infrastructure can't break Naos.Foundation.Infrastructure.
Position
Below the diagonal: Naos.Tracing.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.Tracing.Infrastructure uses Naos.Tracing.Domain, so a change to Naos.Tracing.Domain can break Naos.Tracing.Infrastructure, while a change to Naos.Tracing.Infrastructure can't break Naos.Tracing.Domain.
Position
Below the diagonal: Naos.Tracing.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.Commands.Application.Web uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Commands.Application.Web, while a change to Naos.Commands.Application.Web can't break Naos.Foundation.
Position
Below the diagonal: Naos.Commands.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Commands.Application.Web uses Naos.FileStorage.Domain, so a change to Naos.FileStorage.Domain can break Naos.Commands.Application.Web, while a change to Naos.Commands.Application.Web can't break Naos.FileStorage.Domain.
Position
Below the diagonal: Naos.Commands.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Commands.Application.Web uses Naos.Tracing.Domain, so a change to Naos.Tracing.Domain can break Naos.Commands.Application.Web, while a change to Naos.Commands.Application.Web can't break Naos.Tracing.Domain.
Position
Below the diagonal: Naos.Commands.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Commands.Application.Web uses Naos.Commands.Application, so a change to Naos.Commands.Application can break Naos.Commands.Application.Web, while a change to Naos.Commands.Application.Web can't break Naos.Commands.Application.
Position
Below the diagonal: Naos.Commands.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Commands.Application.Web uses Naos.Queueing.Domain, so a change to Naos.Queueing.Domain can break Naos.Commands.Application.Web, while a change to Naos.Commands.Application.Web can't break Naos.Queueing.Domain.
Position
Below the diagonal: Naos.Commands.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Commands.Infrastructure.FileStorage uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Commands.Infrastructure.FileStorage, while a change to Naos.Commands.Infrastructure.FileStorage can't break Naos.Foundation.
Position
Below the diagonal: Naos.Commands.Infrastructure.FileStorage uses a module listed above it, which is the healthy direction.
Naos.Commands.Infrastructure.FileStorage uses Naos.FileStorage.Domain, so a change to Naos.FileStorage.Domain can break Naos.Commands.Infrastructure.FileStorage, while a change to Naos.Commands.Infrastructure.FileStorage can't break Naos.FileStorage.Domain.
Position
Below the diagonal: Naos.Commands.Infrastructure.FileStorage uses a module listed above it, which is the healthy direction.
Naos.Commands.Infrastructure.FileStorage uses Naos.Commands.Application, so a change to Naos.Commands.Application can break Naos.Commands.Infrastructure.FileStorage, while a change to Naos.Commands.Infrastructure.FileStorage can't break Naos.Commands.Application.
Position
Below the diagonal: Naos.Commands.Infrastructure.FileStorage uses a module listed above it, which is the healthy direction.
Naos.Messaging.Application.Web uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Messaging.Application.Web, while a change to Naos.Messaging.Application.Web can't break Naos.Foundation.
Position
Below the diagonal: Naos.Messaging.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Messaging.Application.Web uses Naos.Messaging, so a change to Naos.Messaging can break Naos.Messaging.Application.Web, while a change to Naos.Messaging.Application.Web can't break Naos.Messaging.
Position
Below the diagonal: Naos.Messaging.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Messaging.Application.Web uses Naos.Queueing.Domain, so a change to Naos.Queueing.Domain can break Naos.Messaging.Application.Web, while a change to Naos.Messaging.Application.Web can't break Naos.Queueing.Domain.
Position
Below the diagonal: Naos.Messaging.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Messaging.Infrastructure uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Messaging.Infrastructure, while a change to Naos.Messaging.Infrastructure can't break Naos.Foundation.
Position
Below the diagonal: Naos.Messaging.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.Messaging.Infrastructure uses Naos.FileStorage.Domain, so a change to Naos.FileStorage.Domain can break Naos.Messaging.Infrastructure, while a change to Naos.Messaging.Infrastructure can't break Naos.FileStorage.Domain.
Position
Below the diagonal: Naos.Messaging.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.Messaging.Infrastructure uses Naos.Messaging.Domain, so a change to Naos.Messaging.Domain can break Naos.Messaging.Infrastructure, while a change to Naos.Messaging.Infrastructure can't break Naos.Messaging.Domain.
Position
Below the diagonal: Naos.Messaging.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.Messaging.Infrastructure uses Naos.Tracing.Domain, so a change to Naos.Tracing.Domain can break Naos.Messaging.Infrastructure, while a change to Naos.Messaging.Infrastructure can't break Naos.Tracing.Domain.
Position
Below the diagonal: Naos.Messaging.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.Messaging.Infrastructure uses Naos.Messaging, so a change to Naos.Messaging can break Naos.Messaging.Infrastructure, while a change to Naos.Messaging.Infrastructure can't break Naos.Messaging.
Position
Below the diagonal: Naos.Messaging.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.Messaging.Infrastructure.Azure uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Messaging.Infrastructure.Azure, while a change to Naos.Messaging.Infrastructure.Azure can't break Naos.Foundation.
Position
Below the diagonal: Naos.Messaging.Infrastructure.Azure uses a module listed above it, which is the healthy direction.
Naos.Messaging.Infrastructure.Azure uses Naos.Foundation.Infrastructure, so a change to Naos.Foundation.Infrastructure can break Naos.Messaging.Infrastructure.Azure, while a change to Naos.Messaging.Infrastructure.Azure can't break Naos.Foundation.Infrastructure.
Position
Below the diagonal: Naos.Messaging.Infrastructure.Azure uses a module listed above it, which is the healthy direction.
Naos.Messaging.Infrastructure.Azure uses Naos.Messaging.Domain, so a change to Naos.Messaging.Domain can break Naos.Messaging.Infrastructure.Azure, while a change to Naos.Messaging.Infrastructure.Azure can't break Naos.Messaging.Domain.
Position
Below the diagonal: Naos.Messaging.Infrastructure.Azure uses a module listed above it, which is the healthy direction.
Naos.Messaging.Infrastructure.Azure uses Naos.Tracing.Domain, so a change to Naos.Tracing.Domain can break Naos.Messaging.Infrastructure.Azure, while a change to Naos.Messaging.Infrastructure.Azure can't break Naos.Tracing.Domain.
Position
Below the diagonal: Naos.Messaging.Infrastructure.Azure uses a module listed above it, which is the healthy direction.
Naos.Messaging.Infrastructure.Azure uses Naos.Messaging, so a change to Naos.Messaging can break Naos.Messaging.Infrastructure.Azure, while a change to Naos.Messaging.Infrastructure.Azure can't break Naos.Messaging.
Position
Below the diagonal: Naos.Messaging.Infrastructure.Azure uses a module listed above it, which is the healthy direction.
Naos.Operations.Application.Web uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Operations.Application.Web, while a change to Naos.Operations.Application.Web can't break Naos.Foundation.
Position
Below the diagonal: Naos.Operations.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Operations.Application.Web uses Naos.FileStorage.Domain, so a change to Naos.FileStorage.Domain can break Naos.Operations.Application.Web, while a change to Naos.Operations.Application.Web can't break Naos.FileStorage.Domain.
Position
Below the diagonal: Naos.Operations.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Operations.Application.Web uses Naos.Operations.Domain, so a change to Naos.Operations.Domain can break Naos.Operations.Application.Web, while a change to Naos.Operations.Application.Web can't break Naos.Operations.Domain.
Position
Below the diagonal: Naos.Operations.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Operations.Application.Web uses Naos.RequestFiltering.Application, so a change to Naos.RequestFiltering.Application can break Naos.Operations.Application.Web, while a change to Naos.Operations.Application.Web can't break Naos.RequestFiltering.Application.
Position
Below the diagonal: Naos.Operations.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Operations.Application.Web uses Naos.Tracing.Domain, so a change to Naos.Tracing.Domain can break Naos.Operations.Application.Web, while a change to Naos.Operations.Application.Web can't break Naos.Tracing.Domain.
Position
Below the diagonal: Naos.Operations.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Operations.Application.Web uses Naos.Operations.Application, so a change to Naos.Operations.Application can break Naos.Operations.Application.Web, while a change to Naos.Operations.Application.Web can't break Naos.Operations.Application.
Position
Below the diagonal: Naos.Operations.Application.Web uses a module listed above it, which is the healthy direction.
29→34 Naos.Operations.Application.Web uses Microsoft.Extensions.DependencyInjectionpart of a loop✕
Connections
1 pair of types, where a type in Naos.Operations.Application.Web uses a type in Microsoft.Extensions.DependencyInjection.
Naos.Operations.Application.Web uses Microsoft.Extensions.DependencyInjection, so a change to Microsoft.Extensions.DependencyInjection can break Naos.Operations.Application.Web, while a change to Naos.Operations.Application.Web can't break Microsoft.Extensions.DependencyInjection.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
Naos.Operations.Infrastructure.Azure uses Naos.Foundation.Infrastructure, so a change to Naos.Foundation.Infrastructure can break Naos.Operations.Infrastructure.Azure, while a change to Naos.Operations.Infrastructure.Azure can't break Naos.Foundation.Infrastructure.
Position
Below the diagonal: Naos.Operations.Infrastructure.Azure uses a module listed above it, which is the healthy direction.
Naos.Operations.Infrastructure.Azure uses Naos.Operations.Domain, so a change to Naos.Operations.Domain can break Naos.Operations.Infrastructure.Azure, while a change to Naos.Operations.Infrastructure.Azure can't break Naos.Operations.Domain.
Position
Below the diagonal: Naos.Operations.Infrastructure.Azure uses a module listed above it, which is the healthy direction.
Naos.Operations.Infrastructure.Azure uses Naos.Foundation.Infrastructure.Azure, so a change to Naos.Foundation.Infrastructure.Azure can break Naos.Operations.Infrastructure.Azure, while a change to Naos.Operations.Infrastructure.Azure can't break Naos.Foundation.Infrastructure.Azure.
Position
Below the diagonal: Naos.Operations.Infrastructure.Azure uses a module listed above it, which is the healthy direction.
Naos.Queueing uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Queueing, while a change to Naos.Queueing can't break Naos.Foundation.
Position
Below the diagonal: Naos.Queueing uses a module listed above it, which is the healthy direction.
Naos.Queueing uses Naos.Tracing.Domain, so a change to Naos.Tracing.Domain can break Naos.Queueing, while a change to Naos.Queueing can't break Naos.Tracing.Domain.
Position
Below the diagonal: Naos.Queueing uses a module listed above it, which is the healthy direction.
Naos.Queueing uses Naos.Queueing.Domain, so a change to Naos.Queueing.Domain can break Naos.Queueing, while a change to Naos.Queueing can't break Naos.Queueing.Domain.
Position
Below the diagonal: Naos.Queueing uses a module listed above it, which is the healthy direction.
Naos.Queueing.Infrastructure uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Queueing.Infrastructure, while a change to Naos.Queueing.Infrastructure can't break Naos.Foundation.
Position
Below the diagonal: Naos.Queueing.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.Queueing.Infrastructure uses Naos.Tracing.Domain, so a change to Naos.Tracing.Domain can break Naos.Queueing.Infrastructure, while a change to Naos.Queueing.Infrastructure can't break Naos.Tracing.Domain.
Position
Below the diagonal: Naos.Queueing.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.Queueing.Infrastructure uses Naos.Queueing.Domain, so a change to Naos.Queueing.Domain can break Naos.Queueing.Infrastructure, while a change to Naos.Queueing.Infrastructure can't break Naos.Queueing.Domain.
Position
Below the diagonal: Naos.Queueing.Infrastructure uses a module listed above it, which is the healthy direction.
Naos.Queueing.Infrastructure.Azure uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Queueing.Infrastructure.Azure, while a change to Naos.Queueing.Infrastructure.Azure can't break Naos.Foundation.
Position
Below the diagonal: Naos.Queueing.Infrastructure.Azure uses a module listed above it, which is the healthy direction.
Naos.Queueing.Infrastructure.Azure uses Naos.Tracing.Domain, so a change to Naos.Tracing.Domain can break Naos.Queueing.Infrastructure.Azure, while a change to Naos.Queueing.Infrastructure.Azure can't break Naos.Tracing.Domain.
Position
Below the diagonal: Naos.Queueing.Infrastructure.Azure uses a module listed above it, which is the healthy direction.
Naos.Queueing.Infrastructure.Azure uses Naos.Queueing.Domain, so a change to Naos.Queueing.Domain can break Naos.Queueing.Infrastructure.Azure, while a change to Naos.Queueing.Infrastructure.Azure can't break Naos.Queueing.Domain.
Position
Below the diagonal: Naos.Queueing.Infrastructure.Azure uses a module listed above it, which is the healthy direction.
Microsoft.Extensions.DependencyInjection uses Naos.Foundation, so a change to Naos.Foundation can break Microsoft.Extensions.DependencyInjection, while a change to Microsoft.Extensions.DependencyInjection can't break Naos.Foundation.
Position
Below the diagonal: Microsoft.Extensions.DependencyInjection uses a module listed above it, which is the healthy direction.
Microsoft.Extensions.DependencyInjection uses Naos.Tracing.Domain, so a change to Naos.Tracing.Domain can break Microsoft.Extensions.DependencyInjection, while a change to Microsoft.Extensions.DependencyInjection can't break Naos.Tracing.Domain.
Position
Below the diagonal: Microsoft.Extensions.DependencyInjection uses a module listed above it, which is the healthy direction.
Microsoft.Extensions.DependencyInjection uses Naos.FileStorage, so a change to Naos.FileStorage can break Microsoft.Extensions.DependencyInjection, while a change to Microsoft.Extensions.DependencyInjection can't break Naos.FileStorage.
Position
Below the diagonal: Microsoft.Extensions.DependencyInjection uses a module listed above it, which is the healthy direction.
Microsoft.Extensions.DependencyInjection uses Naos.FileStorage.Infrastructure, so a change to Naos.FileStorage.Infrastructure can break Microsoft.Extensions.DependencyInjection, while a change to Microsoft.Extensions.DependencyInjection can't break Naos.FileStorage.Infrastructure.
Position
Below the diagonal: Microsoft.Extensions.DependencyInjection uses a module listed above it, which is the healthy direction.
Microsoft.Extensions.DependencyInjection uses Naos.Tracing.Application, so a change to Naos.Tracing.Application can break Microsoft.Extensions.DependencyInjection, while a change to Microsoft.Extensions.DependencyInjection can't break Naos.Tracing.Application.
Position
Below the diagonal: Microsoft.Extensions.DependencyInjection uses a module listed above it, which is the healthy direction.
Microsoft.Extensions.DependencyInjection uses Naos.Commands.Application.Web, so a change to Naos.Commands.Application.Web can break Microsoft.Extensions.DependencyInjection, while a change to Microsoft.Extensions.DependencyInjection can't break Naos.Commands.Application.Web.
Position
Below the diagonal: Microsoft.Extensions.DependencyInjection uses a module listed above it, which is the healthy direction.
Microsoft.Extensions.DependencyInjection uses Naos.Operations.Application.Web, so a change to Naos.Operations.Application.Web can break Microsoft.Extensions.DependencyInjection, while a change to Microsoft.Extensions.DependencyInjection can't break Naos.Operations.Application.Web.
Position
Below the diagonal: Microsoft.Extensions.DependencyInjection uses a module listed above it, which is the healthy direction.
Microsoft.Extensions.DependencyInjection uses Naos.Queueing, so a change to Naos.Queueing can break Microsoft.Extensions.DependencyInjection, while a change to Microsoft.Extensions.DependencyInjection can't break Naos.Queueing.
Position
Below the diagonal: Microsoft.Extensions.DependencyInjection uses a module listed above it, which is the healthy direction.
Naos.Application.Web uses Naos.RequestCorrelation.Application, so a change to Naos.RequestCorrelation.Application can break Naos.Application.Web, while a change to Naos.Application.Web can't break Naos.RequestCorrelation.Application.
Position
Below the diagonal: Naos.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Application.Web uses Naos.Foundation.Domain, so a change to Naos.Foundation.Domain can break Naos.Application.Web, while a change to Naos.Application.Web can't break Naos.Foundation.Domain.
Position
Below the diagonal: Naos.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Application.Web uses Naos.RequestFiltering.Application, so a change to Naos.RequestFiltering.Application can break Naos.Application.Web, while a change to Naos.Application.Web can't break Naos.RequestFiltering.Application.
Position
Below the diagonal: Naos.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Application.Web uses Microsoft.Extensions.DependencyInjection, so a change to Microsoft.Extensions.DependencyInjection can break Naos.Application.Web, while a change to Naos.Application.Web can't break Microsoft.Extensions.DependencyInjection.
Position
Below the diagonal: Naos.Application.Web uses a module listed above it, which is the healthy direction.
Naos.Messaging.Application uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Messaging.Application, while a change to Naos.Messaging.Application can't break Naos.Foundation.
Position
Below the diagonal: Naos.Messaging.Application uses a module listed above it, which is the healthy direction.
Naos.Messaging.Application uses Naos.Messaging, so a change to Naos.Messaging can break Naos.Messaging.Application, while a change to Naos.Messaging.Application can't break Naos.Messaging.
Position
Below the diagonal: Naos.Messaging.Application uses a module listed above it, which is the healthy direction.
Naos.Messaging.Application uses Microsoft.Extensions.DependencyInjection, so a change to Microsoft.Extensions.DependencyInjection can break Naos.Messaging.Application, while a change to Naos.Messaging.Application can't break Microsoft.Extensions.DependencyInjection.
Position
Below the diagonal: Naos.Messaging.Application uses a module listed above it, which is the healthy direction.
Naos.Queueing.Application uses Naos.Foundation, so a change to Naos.Foundation can break Naos.Queueing.Application, while a change to Naos.Queueing.Application can't break Naos.Foundation.
Position
Below the diagonal: Naos.Queueing.Application uses a module listed above it, which is the healthy direction.
Naos.Queueing.Application uses Naos.Queueing.Domain, so a change to Naos.Queueing.Domain can break Naos.Queueing.Application, while a change to Naos.Queueing.Application can't break Naos.Queueing.Domain.
Position
Below the diagonal: Naos.Queueing.Application uses a module listed above it, which is the healthy direction.
Naos.Queueing.Application uses Microsoft.Extensions.DependencyInjection, so a change to Microsoft.Extensions.DependencyInjection can break Naos.Queueing.Application, while a change to Naos.Queueing.Application can't break Microsoft.Extensions.DependencyInjection.
Position
Below the diagonal: Naos.Queueing.Application uses a module listed above it, which is the healthy direction.
Naos.ServiceDiscovery.Application uses Naos.FileStorage.Domain, so a change to Naos.FileStorage.Domain can break Naos.ServiceDiscovery.Application, while a change to Naos.ServiceDiscovery.Application can't break Naos.FileStorage.Domain.
Position
Below the diagonal: Naos.ServiceDiscovery.Application uses a module listed above it, which is the healthy direction.
Naos.ServiceDiscovery.Application uses Microsoft.Extensions.DependencyInjection, so a change to Microsoft.Extensions.DependencyInjection can break Naos.ServiceDiscovery.Application, while a change to Naos.ServiceDiscovery.Application can't break Microsoft.Extensions.DependencyInjection.
Position
Below the diagonal: Naos.ServiceDiscovery.Application uses a module listed above it, which is the healthy direction.
Naos.ServiceDiscovery.Application.Web.Router uses Microsoft.Extensions.DependencyInjection, so a change to Microsoft.Extensions.DependencyInjection can break Naos.ServiceDiscovery.Application.Web.Router, while a change to Naos.ServiceDiscovery.Application.Web.Router can't break Microsoft.Extensions.DependencyInjection.
Position
Below the diagonal: Naos.ServiceDiscovery.Application.Web.Router uses a module listed above it, which is the healthy direction.
Naos.ServiceDiscovery.Application.Web.Router uses Naos.ServiceDiscovery.Application, so a change to Naos.ServiceDiscovery.Application can break Naos.ServiceDiscovery.Application.Web.Router, while a change to Naos.ServiceDiscovery.Application.Web.Router can't break Naos.ServiceDiscovery.Application.
Position
Below the diagonal: Naos.ServiceDiscovery.Application.Web.Router uses a module listed above it, which is the healthy direction.
Naos.ServiceDiscovery.Application.Web uses Naos.Foundation, so a change to Naos.Foundation can break Naos.ServiceDiscovery.Application.Web, while a change to Naos.ServiceDiscovery.Application.Web can't break Naos.Foundation.
Position
Below the diagonal: Naos.ServiceDiscovery.Application.Web uses a module listed above it, which is the healthy direction.
Naos.ServiceDiscovery.Application.Web uses Naos.ServiceDiscovery.Application, so a change to Naos.ServiceDiscovery.Application can break Naos.ServiceDiscovery.Application.Web, while a change to Naos.ServiceDiscovery.Application.Web can't break Naos.ServiceDiscovery.Application.
Position
Below the diagonal: Naos.ServiceDiscovery.Application.Web uses a module listed above it, which is the healthy direction.
Naos.ServiceDiscovery.Application.Web uses Naos.ServiceDiscovery.Application.Web.Router, so a change to Naos.ServiceDiscovery.Application.Web.Router can break Naos.ServiceDiscovery.Application.Web, while a change to Naos.ServiceDiscovery.Application.Web can't break Naos.ServiceDiscovery.Application.Web.Router.
Position
Below the diagonal: Naos.ServiceDiscovery.Application.Web uses a module listed above it, which is the healthy direction.
At a glance — Code Health · 38% · Weak · gated by D17, X4, X5 ·
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A05:2025 — Injection
14
High / Critical
A03:2025 — Software Supply Chain Failures
4
Medium
A07:2025 — Authentication Failures
3
High / Critical
Roadmap
Begin by resolving the 54 deprecated dependency warnings, prioritizing Infrastructure.Azure.ServiceBus.csproj, Queueing.Infrastructure.Azure.csproj, and Directory.Build.props, while immediately addressing the single leaked secret in REDACTED. Next, remediate the nine vulnerable dependencies and replace the five instances of broken MD5 or SHA1 hashes with secure alternatives like SHA-256 or non-cryptographic hashes where appropriate. Finally, eliminate the twelve empty catch blocks, starting with Expando.cs, HttpResponseExtensions.cs, and ZipkinSpanExporter.cs, to improve error handling robustness.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED.
Resolve the 7 FileScopedPragmaDisable finding(s) in Explicit Debt — start with FileStorageExtensions.cs (2), LogAnalyticsRepository.cs, InMemoryQueue.cs.
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name. This repository constructs a collision-broken hash (MD5/SHA1) at 5 sites, not one: `src/Foundation.Utilities/HashAlgorithm.cs:20` (MD5CryptoServiceProvider), `src/Foundation.Utilities/HashAlgorithm.cs:36` (MD5CryptoServiceProvider), `src/Foundation.Utilities/HashAlgorithm.cs:99` (MD5), `src/Foundation.Utilities/HashAlgorithm.cs:110` (MD5), `src/Foundation.Utilities/HashAlgorithm.cs:113` (SHA1). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 197
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 1052
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 570
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 3
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 90 of 94 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 4 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.9 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.
Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.
What we checked — 94 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 1731 of 1819 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test reliability NOT MEASURED: the test run produced no results for any test tier, so no test ever ran and flakiness could not be exercised. The cause could not be attributed, so it is excluded from the score rather than read as an absence of tests.
D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-contributor repository — bus factor is not applicable (1 contributor(s) across 1782 commit(s) sampled, automation and bot accounts excluded). Concentration needs a team to concentrate: with one contributor there is nobody to spread the knowledge to, so there is nothing here for the owner to act on.
D17 Explicit Debt — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The C# workspace loaded this repository's projects but reported a load failure, and the dead-code reference search is unreliable over a graph that did not load cleanly, so it was skipped. The other debt markers on this row were read; dead symbols were not, and their absence from the score is not a finding that the code has none. First load diagnostic: Failure: Msbuild failed when processing the file 'src/Application/Application.csproj' with message: The "TargetFramework" parameter is not supported by the "Csc" task loaded from assembly: Microsoft.Build.Tasks.CodeAnalysis, Version=3.7.2.37502, Culture=neutral, PublicKeyToken=31bf3856ad364e35 from the path: /root/.nuget/packages/microsoft.net.c….
D18 Solution Shape — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. `dotnet build` reported 16 error(s), and the diagnostics it printed were: MSB4064: The "InterceptorsNamespaces" parameter is not supported by the "Csc" task loaded from assembly: Microsoft.Build.Tasks.CodeAnalysis, Version=3.7.2.37502, Culture=neutral, PublicKeyToken=31bf3856ad364e35 from the path: /root/.nuget/packages/microsoft.net.compilers/3.7.0/tools/Microsoft.Build.Tasks.CodeAnalysis.dll. Verify that the parameter exists on the task, the <UsingTask> points to the correct assembly, and it is a settable public instance property.; MSB4063: The "Csc" task could not be initialized with its input parameters.. None of them is a .NET compiler diagnostic, which is the only signal this check reads as "the code does not compile", so the failure is recorded as a build-environment gap rather than a code defect. The usual causes are a project that targets a platform this run cannot build (a Windows-only target framework on a Linux worker) or a build step that shells out to a tool the image does not carry. Solution Shape is scored on structure and is NOT capped. Semantic analysis is independent of this build and covers every project that loaded — but a project whose restore did not complete has no resolved references, so treat its results as absent rather than clean. ★ The reach of that test, stated so this classification can be checked rather than taken on trust: it reads the C# (CS), Visual Basic (BC) and F# (FS) compiler series, and treats SDK, NuGet-restore and MSBuild codes (NETSDK, NU, MSB) as evidence that the build did not run rather than that the code is broken — read the diagnostics named above and judge for yourself. You can widen what we reach: if this build is meant to run off its own platform, without host tooling we do not carry, the diagnostics named above are what stopped it. If it is deliberately platform-bound — a Windows-only desktop product, say — there is nothing to do here: the note records our reach, not a defect in your build.
D19 Documentation Quality — LLM provider failed — The model provider returned an unusable result, so this LLM-assisted dimension fell back to a measurement gap (confidence 0) rather than a penalty. Re-run with a reachable provider to score it.
D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The loaded project set declares no packable project and no `.Contracts` project, so there is no intentionally-exposed surface for API consistency to be judged over.
D32 Data Compliance (PII/GDPR) — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `src/Configuration.Application.Web/NaosExtensions.cs`, `src/Foundation.Logging/LoggerExtensions.cs` produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
D39 IL Efficiency — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. IL NOT MEASURED: the analyzer's build of this repository exited 1 and the cause could not be attributed, so no assemblies were produced and there was no IL to read. We do not read it as a defect in the repository: an unattributed failure leans OURS. D18 owns the question of whether this repository builds; it was not answered here.
AX4 Dependency direction — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 32 further occurrence(s) are not listed individually; the score already reflects all 72.
GD1 Unfinished & placeholder code — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 14 further occurrence(s) are not listed individually; the score already reflects all 54.
IC1 Incompleteness & stubs — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 314 further occurrence(s) are not listed individually; the score already reflects all 354.
X1 Async correctness — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 5 further occurrence(s) are not listed individually; the score already reflects all 45.
X2 Cancellation propagation — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 312 further occurrence(s) are not listed individually; the score already reflects all 352.
X4 Structured logging — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 239 further occurrence(s) are not listed individually; the score already reflects all 279.
Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.
Limitations & what we did not check
Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D8 Code Coverage: Coverage is measured by building and running the test suite inside Watchdog's isolated image — the target repo is never modified, and nothing on your systems runs. So coverage exists only when the suite builds and runs within the inline time budget; one that needs external services, can't build, or exceeds the budget yields no coverage (D8 then degrades to not-measured, not a low score). Line coverage also says nothing about assertion quality.
D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
D23 Boundary Type-Coupling: Boundary leakage is detected from type references across detected contexts — leaks that flow through primitives, serialization or shared infrastructure may not surface as a typed reference.
D24 Comment Value: Comment value (WHY vs WHAT) is an LLM judgement over a bounded sample — it is advisory and cannot weigh a comment against the precise code change it was written to explain.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
AX9 CQS / query purity: Handlers are found by interface/name convention — a query handler using neither is not seen. Mutation is a resolved write/publish invocation (SaveChanges/repository/bus), so a write hidden behind a hand-rolled wrapper, reflection, or a string-keyed service locator resolves to a non-persistence type and isn't flagged; it detects that a query writes state, not whether the write is a legitimate read-side cache update. Clean means "no resolved write/publish in a query body", not a proof of CQS purity.
DM4 Rich vs anemic model: Behaviour is detected as state mutation inside a method body — a method that enforces an invariant by validating-and-throwing without mutating reads as a query, and mutation delegated through an interface the scan can't resolve isn't credited; entities with zero public properties still drop out of the population. It detects that state changes, not whether the rule is correct.
DM6 Domain ↔ infrastructure boundary: Infrastructure reached through a hand-rolled wrapper, a domain-named facade, reflection, or a string-keyed service locator resolves to a non-infra type and isn't seen; the body scan is symbol resolution over syntax, not full dataflow. A clean result means "no resolved infra reference in a domain body", not a proof of purity.
ED5 Idempotency: Idempotency is judged from the handler body's visible writes and guards — a guard enforced by a database unique constraint, a broker's exactly-once delivery, or a domain method whose no-op-when-applied logic the scan can't follow may read as at-risk; the at-risk candidates are confirmed by a SAMPLED LLM verdict (advisory, not exhaustive) and degrade to heuristic-only when no model is configured. It flags the at-least-once double-apply SHAPE, not a runtime proof of a duplicate effect.
M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
The LLM boundary
LLM-set scores this run (4): D21, D24, ED5, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
5 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was SqlBuilder.BuildExpressionSelect at 38. A further 2 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being ExpressionVisitor.Visit at 46 — they are counted neither in the figure above nor in this dimension's score. 2 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: src/Foundation.Utilities/Expressions/ExpressionExtensions.cs (ExpressionVisitor.Visit at 46), src/Foundation.Extensions/TypeExtensions.cs (TypeExtensions.IsNumeric at 24). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
Bring the 5 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with SqlBuilder.BuildExpressionSelect (cyclomatic 38), FileStorageKeyValueStorage.Match (cyclomatic 35), Extensions.To (cyclomatic 18). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 5 together lifts Cyclomatic Complexity from 8.6 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 22 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 2 bodies over 30 down to 30 or less in Cognitive Complexity — start with FileStorageKeyValueStorage.Match (cognitive 46), NaosOperationsHealthController.GetHtmlAsync (cognitive 33). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 2 together lifts Cognitive Complexity from 6.8 to about 7.3/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.
Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes9.7 / 10Stronggated by 3 serious findings✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 2 TooManyMethods finding(s) in God Classes — start with SequentialGuid.cs, REDACTED. — One of this dimension's main actionable groups (2 warning-level).
Resolve the 1 FileTooLong finding(s) in God Classes — start with ContentType.cs. — One of this dimension's main actionable groups (1 warning-level).
Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Copy-pasted code that should be shared instead.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.
136 duplicated block group(s) detected. A further 13 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.
+ 66 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 13 Duplicated block (7 lines × 2) finding(s) in Code Duplication — start with MongoRepository{TEntity,TDestination}.cs (3), RepositoryLoggingDecorator.cs, AzureBlobFileStorage.cs. — One of this dimension's main actionable groups (13 warning-level).
Resolve the 11 Duplicated block (5 lines × 2) finding(s) in Code Duplication — start with RepositorySpecificationDecorator.cs (3), CommandRequestOptionsExtensions.cs, EntityInsertDomainEventHandler.cs. — One of this dimension's main actionable groups (11 warning-level).
Resolve the 10 Duplicated block (6 lines × 2) finding(s) in Code Duplication — start with RepositoryTracingDecorator.cs (3), NaosExtensions.cs (2), NaosOperationsHealthController.cs. — One of this dimension's main actionable groups (10 warning-level).
Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling8.7 / 10Adequategated by 42 critical findings✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
+ 4 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 42 Layer violation finding(s) in Coupling — start with Application.Web.csproj (16), Messaging.Application.FileStorage.csproj (3), Messaging.Application.RabbitMQ.csproj (3). — One of this dimension's main actionable groups (42 issue-level).
Resolve the 12 Off the main sequence finding(s) in Coupling — start with Infrastructure.Azure.csproj, Extensions.csproj, Infrastructure.RabbitMQ.csproj. — One of this dimension's main actionable groups (12 warning-level).
Resolve the 1 Unstable project Messaging.Infrastructure.Azure finding(s) in Coupling — start with Messaging.Infrastructure.Azure.csproj. — One of this dimension's main actionable groups (1 warning-level).
Enforce Coupling in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
Resolve the 2 Low cohesion finding(s) in Cohesion (LCOM4) — start with SqlBuilder.cs, Span.cs. — One of this dimension's main actionable groups (2 warning-level).
Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D8 · Code Coverage3.7 / 10Weak✓ Tool-verified
What it measures: How much of the code is actually exercised by tests.
Method: Coverage from coverlet runs or committed reports (Cobertura/OpenCover/lcov), computed per-file with structured exclusions for generated, trivial, and glue code. When the suite can't be built/run in-image AND no report is committed, coverage is reported NOT-MEASURED (excluded from the score) with the precondition to make it measurable — never a LoC-ratio proxy folded in as if measured. Deterministic.
Line coverage 15.1% — read from a committed opencover report (tests/Foundation.UnitTests/coverage.opencover.xml); the in-image collector couldn't run the suite (commonly external-service dependencies). A real measurement, but from a committed artifact rather than a fresh in-image run.
Coverage read from a committed report
What to do
Enforce Code Coverage in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d8_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.
Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.
552 test methods: 381 unit, 171 integration, 0 BDD, 0 e2e.
✓ On the Gold path — maintain.
Detailed fixes: d9_recommendation.md.
Do you agree with this assessment?
D10 · Test Quality9.8 / 10Adequategated by 1 critical finding✓ Tool-verified
What it measures: Whether the tests truly assert behaviour rather than just running the code.
Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.
Resolve the 1 Assertions commented out finding(s) in Test Quality — start with CommandRequestTests.cs. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 4 No assertions finding(s) in Test Quality — start with RandomGeneratorTests.cs (3), ExpandoTests.cs. — One of this dimension's main actionable groups (4 warning-level).
Resolve the 1 Depends on a live external host finding(s) in Test Quality — start with HttpClientTests.cs. — One of this dimension's main actionable groups (1 warning-level).
Enforce Test Quality in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether dependencies are current, secure, and not bloated.
Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (saturating for vulnerabilities, capped-linear for deprecation/outdated) per KLoC. Exhaustive, deterministic.
Resolve the 54 Deprecated finding(s) in Dependency Hygiene — start with Infrastructure.Azure.ServiceBus.csproj (3), Queueing.Infrastructure.Azure.csproj (3), Directory.Build.props (2). — One of this dimension's main actionable groups (54 warning-level).
Resolve the 9 Vulnerable finding(s) in Dependency Hygiene. — One of this dimension's main actionable groups (9 issue-level).
Resolve the 1 Prerelease dependency finding(s) in Dependency Hygiene. — One of this dimension's main actionable groups (1 warning-level).
Enforce Dependency Hygiene in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
Resolve the 1 Leaked secret finding(s) in REDACTED Scanning — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Enforce REDACTED Scanning in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d13_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 501 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 130 direct `PackageReference`(s), and 120 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
663 deducted debt markers + unmeasured dead symbols across 52730 LoC in the .NET projects (3.4/KLoC) → score 3.2. Dead code not measured: the solution did not load cleanly, so the reference search was skipped.
+ 5 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 70 WriteOnlyPrivateField finding(s) in Explicit Debt — start with StorageQueueMessageBroker.cs (4), TracerCommandBehavior.cs (2), DistributedMutext.cs (2). — One of this dimension's main actionable groups (70 issue-level).
Resolve the 12 EmptyCatchBlock finding(s) in Explicit Debt — start with Expando.cs (3), HttpResponseExtensions.cs (2), ZipkinSpanExporter.cs (2). — One of this dimension's main actionable groups (12 issue-level).
Resolve the 7 FileScopedPragmaDisable finding(s) in Explicit Debt — start with FileStorageExtensions.cs (2), LogAnalyticsRepository.cs, InMemoryQueue.cs. — One of this dimension's main actionable groups (7 issue-level).
Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the solution is laid out in a sensible, conventional structure.
Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.
123 projects, 1433 source files, 67842 hand-written lines of code (52730 production / 15112 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), plus 518 generated (machine-written code — designer, scaffolded and tool-emitted files — excluded from quality), 669 inter-project edges (build NOT measured — `dotnet build` did not complete in the analyzer, so the build half of this dimension is unmeasured rather than failed: the score above rests on structure alone and is not capped. The diagnostics that stopped it are named under Limitations.)
What it measures: Whether names — types, methods, variables — are clear and consistent.
Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.
What it measures: Whether domain types (IDs, enums, value objects) leak across bounded-context boundaries.
Method: Cross-context domain-type leakage via Roslyn structural classification (strongly-typed IDs / value objects) over every public surface. Exhaustive, deterministic, type-level aggregate-boundary check.
Coverage: Bounded contexts derived from NAMESPACE prefix (or graph-inferred where available); cross-boundary domain-type leakage then checked exhaustively over every public member of every type.
15 domain type(s) cross context boundaries across 85 contexts.
Cross-context type EventResult (Foundation.Domain.EventSourcing → Foundation.Infrastructure.EventStore) · ×4src/Foundation.Infrastructure.EventStore/EventStore/EventStoreEventStore.cs:65
Cross-context type ISubscriptionMap (Messaging → Messaging.Infrastructure.RabbitMQ) · ×2src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBrokerOptions.cs:21
Cross-context type ISubscriptionMap (Messaging → Messaging.Infrastructure.FileSystem) · ×2src/Messaging.Infrastructure.FileSystem/FileStorageMessageBrokerOptions.cs:20
Cross-context type ISubscriptionMap (Messaging → Messaging.Infrastructure.Azure.SignalR) · ×2src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBrokerOptions.cs:24
Cross-context type Message (Messaging → Messaging.Infrastructure.RabbitMQ)src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:117
+ 5 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 4 Cross-context type EventResult (Foundation.Domain.EventSourcing →… finding(s) in Boundary Type-Coupling — start with EventStoreEventStore.cs (2), SqlEventStore.cs (2). — One of this dimension's main actionable groups (4 warning-level).
Resolve the 2 Cross-context type ISubscriptionMap (Messaging →… finding(s) in Boundary Type-Coupling — start with RabbitMQMessageBrokerOptions.cs, RabbitMQMessageBrokerOptionsBuilder.cs. — One of this dimension's main actionable groups (2 warning-level).
Resolve the 2 Cross-context type ISubscriptionMap (Messaging →… finding(s) in Boundary Type-Coupling — start with FileStorageMessageBrokerOptions.cs, FileStorageMessageBrokerOptionsBuilder.cs. — One of this dimension's main actionable groups (2 warning-level).
Enforce Boundary Type-Coupling in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.
Detailed fixes: d23_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D24 · Comment ValueStrong◐ Sampled · advisory
What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).
Method: Judged by language model at low temperature (0.0-0.1) on deterministically sampled inline comments with surrounding code; findings verified back to sampled comments by substring match. Advisory, sampled.
Resolve the 1 redundant comment finding(s) in Comment Value — start with KeyValueStorageBaseTests.cs. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d24_recommendation.md · top locations in Appendix A, every location in findings.md.
0 of 109 projects flagged as possibly oversized/incoherent.
✓ On the Gold path — maintain.
Detailed fixes: d26_recommendation.md.
Do you agree with this assessment?
D27 · Navigability8.2 / 10Strong✓ Tool-verified
What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.
Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.
Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.
87 % of calls cross a namespace and 12 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: large — vertical-slice locality expected.
Resolve the 4 Pass-through layer finding(s) in Navigability — start with RijndaelSerializer.cs, LoggingAdapter.cs, LoggingAdapter{T}.cs. — One of this dimension's main actionable groups (4 recommendation-level).
Detailed fixes: d27_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
1 finding(s): 0 critical, 1 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.
REDACTED
REDACTED
What to do
Resolve the 1 REDACTED finding(s) in Secrets (history) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
14 finding(s): 0 critical, 11 high, 3 medium, 0 low. semgrep hit a parse error in 2 file(s) — `src/Configuration.Application.Web/NaosExtensions.cs` (line 25), `src/Foundation.Logging/LoggerExtensions.cs` (line 30) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
+ 1 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 4 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (4). — One of this dimension's main actionable groups (4 issue-level).
Resolve the 4 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2), REDACTED, REDACTED. — One of this dimension's main actionable groups (4 issue-level).
Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 issue-level).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.
Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.
271 of 271 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is src/Foundation.ContentTypes/ContentType.cs. Counted over 271 of the 883 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Most significant orphaned file · ×3src/Foundation.ContentTypes/ContentType.cs:1
Dormant codebase
What to do
Resolve the 268 Orphaned file finding(s) in Knowledge Freshness — start with NaosExtensions.cs (15), ServiceCollectionExtensions.cs (6), ApplicationExtensions.cs (4). — One of this dimension's main actionable groups (268 recommendation-level).
Resolve the 3 Most significant orphaned file finding(s) in Knowledge Freshness — start with ContentType.cs, ExpressionExtensions.cs, REDACTED. — One of this dimension's main actionable groups (3 recommendation-level).
Resolve the 1 Dormant codebase finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 2 Boundary-crossing change coupling finding(s) in Change Coupling — start with HttpClientLogHandler.cs, NaosOperationsLogEventsController.cs. — One of this dimension's main actionable groups (2 issue-level).
Resolve the 3 Change coupling finding(s) in Change Coupling — start with NaosOperationsHealthController.cs (2), NaosOperationsLogEventsController.cs. — One of this dimension's main actionable groups (3 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
1 end-of-life runtime(s) and 0 end-of-life framework(s), read from 109 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
Resolve the 1 End-of-life runtime finding(s) in Platform End-of-Life — start with UnitTests.csproj. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d44_recommendation.md · top locations in Appendix A, every location in findings.md.
Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.
Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.
Building the SINGLETON `IJobScheduler` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes. (×3) — src/JobScheduling.Application/NaosExtensions.cs:38, src/JobScheduling.Application/NaosExtensions.cs:44, src/JobScheduling.Application/NaosExtensions.cs:46
Building the SINGLETON `IHostedService` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes. (×2) — src/JobScheduling.Application/NaosExtensions.cs:51, src/Operations.Application/OperationsOptionsExtensions.cs:73
Building the SINGLETON `RequestStorageMiddlewareOptions` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes. (×2) — src/Operations.Application.Web/RequestStorageOptionsExtensions.cs:33, src/Operations.Application.Web/RequestStorageOptionsExtensions.cs:59
`LoggingAdapter` is registered as a SINGLETON but its constructor takes `ILoggerFactory factory`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `ILoggerFactory` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/Operations.Application/LoggingAdapter.cs:10
Building the SINGLETON `IQueue` resolves `ITracer`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ITracer` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ITracer` from the scope's provider, or align the lifetimes. — src/Queueing.Application/NaosExtensions.cs:59
Building the SINGLETON `IQueue` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes. (×4) — src/Queueing.Application/NaosExtensions.cs:60, src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:357, src/Commands.Application.Web.Azure/CommandRequestOptionsExtensions.cs:48, …
`QueueProcessItemsHostedService` is registered as a SINGLETON but its constructor takes `ILoggerFactory loggerFactory`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `ILoggerFactory` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes. — src/Queueing.Application.Web/QueueProcessItemsHostedService.cs:20
Building the SINGLETON `CommandRequestStore` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes. (×4) — src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:311, src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:323, src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:334, …
What to do
Don't inject scoped/transient services into singletons; resolve them per-use via IServiceScopeFactory or a factory delegate, or align the lifetimes.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
`ServiceDiscoveryHostedService` is a singleton (one shared instance) but mutates instance state outside any lock (serviceAddress; e.g. `serviceAddress` at line 59). — src/ServiceDiscovery.Application/Web/ServiceDiscoveryHostedService.cs:15
`CommandRequestRegistration` is a singleton (one shared instance) but mutates instance state outside any lock (route; e.g. `route` at line 26). — src/Commands.Application.Web/CommandRequestRegistration.cs:12
What to do
Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
The namespaces Naos.Foundation.Domain ↔ Naos.Foundation.Domain.EventSourcing depend on each other. The lightest dependency in the cycle is Naos.Foundation.Domain → Naos.Foundation.Domain.EventSourcing (Naos.Foundation.Domain.EventSourcingRepository → Naos.Foundation.Domain.EventSourcing.IEventStore, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/Foundation.Domain.EventSourcing/Repositories/EventSourcingRepository.cs:7
The namespaces Microsoft.Extensions.DependencyInjection ↔ Naos.Operations ↔ Naos.Operations.Application.Web ↔ Naos.Tracing.Application depend on each other. The lightest dependency in the cycle is Microsoft.Extensions.DependencyInjection → Naos.Tracing.Application (Microsoft.Extensions.DependencyInjection.OperationsTracingOptionsExtensions → Naos.Tracing.Application.OperationsTracingOptions, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/Tracing.Application/OperationsTracingOptionsExtensions.cs:5
The namespaces Naos.JobScheduling ↔ Naos.JobScheduling.Domain depend on each other. The lightest dependency in the cycle is Naos.JobScheduling.Domain → Naos.JobScheduling (Naos.JobScheduling.Domain.IJobScheduler → Naos.JobScheduling.JobSchedulerOptions, 2 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/JobScheduling/Domain/Services/IJobScheduler.cs:7
The namespaces Naos.Messaging ↔ Naos.Messaging.Domain depend on each other. The lightest dependency in the cycle is Naos.Messaging → Naos.Messaging.Domain (Naos.Messaging.IMessageBroker → Naos.Messaging.Domain.Message, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/Messaging/IMessageBroker.cs:3
What to do
Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
`Tracing.Application.Zipkin` is a Application project but references `Tracing.Infrastructure.Zipkin`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Tracing.Application.Zipkin/Tracing.Application.Zipkin.csproj:16
This Application file depends on the Infrastructure project `Tracing.Infrastructure.Zipkin`: it names `Naos.Tracing.Infrastructure`, `ZipkinSpanExporterConfiguration`, `ZipkinSpanExporter`. The inward dependency rule is broken here. It is named again on lines 23, 27, 28, 36. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Tracing.Application.Zipkin/OperationsTracingOptionsExtensions.cs:12
`Queueing.Application.RabbitMQ` is a Application project but references `Infrastructure.RabbitMQ`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Queueing.Application.RabbitMQ/Queueing.Application.RabbitMQ.csproj:15
This Application file depends on the Infrastructure project `Infrastructure.RabbitMQ`: it names `Naos.Foundation.Infrastructure`, `RabbitMQConfiguration`. The inward dependency rule is broken here. It is named again on line 32. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Queueing.Application.RabbitMQ/NaosExtensions.cs:10
`Queueing.Application.RabbitMQ` is a Application project but references `Queueing.Infrastructure.RabbitMQ`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Queueing.Application.RabbitMQ/Queueing.Application.RabbitMQ.csproj:17
This Application file depends on the Infrastructure project `Queueing.Infrastructure.RabbitMQ`: it names `Naos.Queueing.Infrastructure`, `RabbitMQProvider`, `RabbitMQQueue`. The inward dependency rule is broken here. It is named again on lines 47, 48, 53, 69. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Queueing.Application.RabbitMQ/NaosExtensions.cs:13
`Queueing.Application.Azure` is a Application project but references `Infrastructure.Azure.ServiceBus`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Queueing.Application.Azure/Queueing.Application.Azure.csproj:15
This Application file depends on the Infrastructure project `Infrastructure.Azure.ServiceBus`: it names `ServiceBusConfiguration`. The inward dependency rule is broken here. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Queueing.Application.Azure/NaosExtensions.cs:31
`Queueing.Application.Azure` is a Application project but references `Infrastructure.Azure`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Queueing.Application.Azure/Queueing.Application.Azure.csproj:16
This Application file depends on the Infrastructure project `Infrastructure.Azure`: it names `QueueStorageConfiguration`. The inward dependency rule is broken here. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Queueing.Application.Azure/NaosExtensions.cs:74
`Queueing.Application.Azure` is a Application project but references `Queueing.Infrastructure.Azure`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Queueing.Application.Azure/Queueing.Application.Azure.csproj:18
This Application file depends on the Infrastructure project `Queueing.Infrastructure.Azure`: it names `Naos.Queueing.Infrastructure.Azure`, `AzureServiceBusQueue`, `AzureStorageQueue`. The inward dependency rule is broken here. It is named again on lines 36, 52, 79, 95. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Queueing.Application.Azure/NaosExtensions.cs:13
`Operations.Application.Web` is a Application project but references `Infrastructure.Azure`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Operations.Application.Web/Operations.Application.Web.csproj:30
This Application file depends on the Infrastructure project `Infrastructure.Azure`: it names `BlobStorageConfiguration`. The inward dependency rule is broken here. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Operations.Application.Web/RequestStorageOptionsExtensions.cs:48
`Operations.Application.Web` is a Application project but references `FileStorage.Infrastructure.Azure`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Operations.Application.Web/Operations.Application.Web.csproj:31
This Application file depends on the Infrastructure project `FileStorage.Infrastructure.Azure`: it names `Naos.FileStorage.Infrastructure`, `AzureBlobFileStorage`. The inward dependency rule is broken here. It is named again on lines 51, 60. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Operations.Application.Web/RequestStorageOptionsExtensions.cs:9
`Operations.Application.Web` is a Application project but references `FileStorage.Infrastructure.FileSystem`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Operations.Application.Web/Operations.Application.Web.csproj:32
This Application file depends on the Infrastructure project `FileStorage.Infrastructure.FileSystem`: it names `Naos.FileStorage.Infrastructure`, `FolderFileStorage`. The inward dependency rule is broken here. It is named again on lines 27, 34. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Operations.Application.Web/RequestStorageOptionsExtensions.cs:9
`Operations.Application.Web` is a Application project but references `Utilities.Web`, a Web project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Operations.Application.Web/Operations.Application.Web.csproj:35
This Application file depends on the Web project `Utilities.Web`: it names `Naos.Foundation`. The inward dependency rule is broken here. Depend on an abstraction the inner layer owns, implemented in the outer one. (×7) — src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:12, src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs:12, src/Operations.Application.Web/Health/HealthReportResponseWriter.cs:10, …
This Application file depends on the Web project `Utilities.Web`: it names `Naos.Foundation`, `HtmlNodeRenderOptions`. The inward dependency rule is broken here. It is named again on line 114. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Operations.Application.Web/Controllers/NaosOperationsLogTracesController.cs:13
`Messaging.Application.RabbitMQ` is a Application project but references `Infrastructure.RabbitMQ`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Messaging.Application.RabbitMQ/Messaging.Application.RabbitMQ.csproj:19
This Application file depends on the Infrastructure project `Infrastructure.RabbitMQ`: it names `Naos.Foundation.Infrastructure`, `RabbitMQConfiguration`. The inward dependency rule is broken here. It is named again on line 37. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Messaging.Application.RabbitMQ/NaosExtensions.cs:12
`Messaging.Application.RabbitMQ` is a Application project but references `Messaging.Infrastructure.RabbitMQ`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Messaging.Application.RabbitMQ/Messaging.Application.RabbitMQ.csproj:22
This Application file depends on the Infrastructure project `Messaging.Infrastructure.RabbitMQ`: it names `RabbitMQMessageBroker`, `RabbitMQProvider`. The inward dependency rule is broken here. It is named again on lines 63, 64, 103. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Messaging.Application.RabbitMQ/NaosExtensions.cs:52
`Messaging.Application.FileStorage` is a Application project but references `FileStorage.Infrastructure.FileSystem`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Messaging.Application.FileSystem/Messaging.Application.FileStorage.csproj:16
This Application file depends on the Infrastructure project `FileStorage.Infrastructure.FileSystem`: it names `Naos.FileStorage.Infrastructure`, `FolderFileStorage`. The inward dependency rule is broken here. It is named again on line 45. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Messaging.Application.FileSystem/NaosExtensions.cs:12
`Messaging.Application.FileStorage` is a Application project but references `Messaging.Infrastructure.FileStorage`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Messaging.Application.FileSystem/Messaging.Application.FileStorage.csproj:19
This Application file depends on the Infrastructure project `Messaging.Infrastructure.FileStorage`: it names `Naos.Messaging.Infrastructure`, `FileStorageConfiguration`, `FileStorageMessageBroker`. The inward dependency rule is broken here. It is named again on lines 32, 38, 60. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Messaging.Application.FileSystem/NaosExtensions.cs:17
`Messaging.Application.Azure` is a Application project but references `Messaging.Infrastructure.Azure`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Messaging.Application.Azure/Messaging.Application.Azure.csproj:20
This Application file depends on the Infrastructure project `Messaging.Infrastructure.Azure`: it names `ServiceBusMessageBroker`. The inward dependency rule is broken here. It is named again on lines 73, 104, 127. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Messaging.Application.Azure/NaosExtensions.cs:52
`Messaging.Application.Azure.SignalR` is a Application project but references `Messaging.Infrastructure.Azure.SignalR`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Messaging.Application.Azure.SignalR/Messaging.Application.Azure.SignalR.csproj:19
This Application file depends on the Infrastructure project `Messaging.Infrastructure.Azure.SignalR`: it names `Naos.Messaging.Infrastructure.Azure`, `SignalRServerlessMessageBroker`. The inward dependency rule is broken here. It is named again on lines 37, 58. Depend on an abstraction the inner layer owns, implemented in the outer one. — src/Messaging.Application.Azure.SignalR/NaosExtensions.cs:16
`Application.Web.Startup.EntityFramework` is a Application project but references `Infrastructure.EntityFramework`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one. — src/Foundation.Application.Web.Startup.EntityFramework/Application.Web.Startup.EntityFramework.csproj:11
Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.
Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
`IQueueItem<TData>` declares 19 members: `Id`, `CorrelationId`, `TraceId`, `SpanId`, `Data`, `IsCompleted`, `IsAbandoned`, `EnqueuedDate`, `RenewedDate`, `DequeuedDate`, `Attempts`, `ProcessingTime`, `TotalTime`, `Properties`, `MarkAbandoned`, `MarkCompleted`, `RenewLockAsync`, `AbandonAsync`, `CompleteAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Queueing/Domain/Model/IQueueItem.cs:7
`ISpan` declares 25 members: `OperationName`, `TraceId`, `SpanId`, `ParentSpanId`, `Kind`, `LogKey`, `Status`, `IsSampled`, `StatusDescription`, `StartTime`, `EndTime`, `Tags`, `Logs`, `Duration`, `Start`, `End`, `WithOperationName`, `WithLogKey`, `SetSpanId`, `WithTag`, `WithTags`, `SetStatus`, `SetSampled`, `AddLog`, `AddLog`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 25 declarations carry 24 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 24 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — src/Tracing.Domain/Model/ISpan.cs:7
`IDocumentProvider<T>` declares 17 members under just 9 distinct name(s): `CountAsync`, `CountAsync`, `ResetAsync`, `ExistsAsync`, `UpsertAsync`, `Upsert`, `UpsertAsync`, `LoadKeysAsync`, `LoadKeysAsync`, `LoadDataAsync`, `LoadDataAsync`, `LoadDataAsync`, `LoadValuesAsync`, `LoadValuesAsync`, `LoadValuesAsync`, `DeleteAsync`, `DeleteAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 9 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — src/Foundation.Domain.Repositories.Documents/Provider/IDocumentProvider.cs:9
What to do
Split fat interfaces into focused role-interfaces so clients depend only on what they use.
Where the width is an overload set rather than separate responsibilities, collapse the overloads instead — segregating those relieves no caller.
Do you agree with this assessment?
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified
Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.
Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.
Other · Architecture — Whether read (query) handlers stay side-effect-free — a query that writes persistent state or raises events breaks CQS and makes reads unsafe to retry, cache, or route to a read replica.
Method: Roslyn scan: CQRS handlers classified query-vs-command by interface (IQueryHandler/ICommandHandler/IRequestHandler<TQuery,TResult>) and name convention (*Query/Get*/Find* vs *Command); each query handler's body checked for persistent-state writes (SaveChanges/repository Add-Update) or event publishes by resolved invocation. Deterministic, type-level, exhaustive over the detected handlers.
Coverage: Population: CQRS handlers identified by IQueryHandler/ICommandHandler/IRequestHandler interface + *Query/Get*/Find*/*Command NAME convention; query purity then checked exhaustively within that set — a query handler using neither convention is invisible, and mutation is a resolved persistence/publish CALL, not full dataflow.
`Application.MessagingConsoleCommandEventHandler` is a read (query) handler but its body raises events — a query must stay side-effect-free so reads are safe to retry, cache, and route to a read replica. — src/Messaging.Application/Console/MessagingConsoleCommandEventHandler.cs:12
What to do
Keep query handlers read-only — move the writes/event-publishes into a command handler so reads stay safe to retry, cache, and route to a read replica.
Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.
Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.
Other · Domain Modelling — Whether aggregates reference each other by identity (id) rather than by direct object reference — the core DDD consistency-boundary rule.
Method: Roslyn (DDD-gated): aggregate roots identified by convention; each aggregate field checked for direct references to other aggregates versus id-only. Deterministic, DDD-native.
Coverage: Population: aggregate roots identified by AggregateRoot/IAggregateRoot base/interface NAME convention; reference-by-identity then checked exhaustively within that set — a root not using those names is invisible.
Do you agree with this assessment?
DM10 · One transaction, one aggregate10.0 / 10Exemplary○ Nothing flagged
Other · Domain Modelling — Whether a single operation mutates more than one aggregate root. An aggregate is a consistency boundary, so saving two together fuses them into one — the second's invariants come to depend on the first's transaction, and the pair can no longer be separated. Reads of other aggregates are not counted.
Method: Neutral body surface (DDD-gated): every method body scanned for repository WRITE calls (Add/Update/Save/Remove/Delete/Insert/Store and their async forms), keyed on the ARGUMENT type rather than the repository type — three `IRepository<T>` writes collapse to one repository but are three distinct aggregates. Reads (Get/Find/Load/Query) are excluded, so loading another aggregate for context never counts. Score is offending methods over methods that write at all. Deterministic.
Other · Domain Modelling — Whether an aggregate can be constructed in a state its own rules forbid — a public constructor that takes a raw primitive, stores it, and validates nothing, with no factory beside it. A constructor taking only value objects is not counted: each parameter has already validated itself.
Method: Neutral surface (DDD-gated): each non-abstract entity/aggregate checked for a PUBLIC constructor taking at least one RAW PRIMITIVE parameter whose body contains no guard token (throw / Guard. / Ensure. / ArgumentException / CheckRule), on a type that also offers no static Create/Of/From/New factory. A constructor taking only value objects is never charged -- measured: 64 of 87 unguarded public constructors on the C# corpus take value objects only, so ignoring parameter types would be 73% false positives. One finding per entity. Deterministic.
`Message`'s public constructor takes `id`, `correlationId` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `Message` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — src/Messaging/Domain/Model/Message.cs:24
`QueueItem`'s public constructor takes `id`, `attempts` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `QueueItem` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — src/Queueing/Domain/Model/QueueItem.cs:14
`Span`'s public constructor takes `traceId`, `spanId`, `parentSpanId` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `Span` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse. — src/Tracing.Domain/Model/Span/Span.cs:15
What to do
Give each aggregate one way in that can refuse — a guarded constructor, value-object parameters that validate themselves, or a private constructor behind a factory that returns a failure.
Do you agree with this assessment?
DM12 · Ambient inputs in the domain9.7 / 10Exemplary✓ Tool-verified
Other · Domain Modelling — Whether domain types receive the time and randomness their rules depend on, rather than reading the process clock or a global random source directly — an ambient read makes the rule it feeds untestable at the instant that matters and lets two reads inside one operation disagree.
Method: Roslyn (DDD-gated, C#/VB only): domain-layer types scanned for ambient reads — DateTime/DateTimeOffset.Now/UtcNow/Today, Random.Shared, new Random(), Stopwatch.GetTimestamp — resolved against the semantic model, with a comment/string-stripped token fallback only where resolution fails. Body reads are scored; field/property initialisers are surfaced unscored. Apply/When folds excluded (ES1 owns them). Deterministic, symbol-resolved.
`FileStorageScopedDecorator` reads `DateTime.UtcNow` inside `UpdatePathPrefix`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — src/FileStorage/Domain/Decorators/FileStorageScopedDecorator.cs:127
`JobScheduler` reads `DateTime.UtcNow` inside `RunAsync`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — src/JobScheduling/Domain/Services/JobScheduler.cs:111
`LogEvent` reads `DateTime.UtcNow` inside `GetAge`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — src/Operations.Domain/Logging/Model/LogEvent.cs:64
`LogTrace` reads `DateTime.UtcNow` inside `GetAge`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — src/Tracing.Domain/Model/LogTrace.cs:89
`QueueBase` reads `DateTime.UtcNow` inside `DequeueAsync`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — src/Queueing/Domain/Model/QueueBase.cs:43
`QueueItem` reads `DateTime.UtcNow` inside `RenewLockAsync`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — src/Queueing/Domain/Model/QueueItem.cs:65
`Span` reads `DateTimeOffset.UtcNow` inside `Start`, `End`, `AddLog`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — src/Tracing.Domain/Model/Span/Span.cs:62
`State` reads `DateTimeOffset.UtcNow` inside `SetDeactivated`, `SetCreated`, `SetUpdated`, `SetDeleted`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`. — src/Foundation.Domain/Model/State.cs:150
What to do
Pass the instant into the domain method that needs it, or inject `TimeProvider` (BCL, .NET 8+) and read it there — then a test can choose the moment a rule is evaluated at.
Other · Domain Modelling — How much of the domain uses strongly-typed ids vs raw Guid/string/int — adoption curve, not all-or-nothing.
Method: Roslyn (DDD-gated): strongly-typed id adoption on domain entities/events; raw Guid/int/string ids counted versus wrapped types. An id wrapper is recognised by VALUE SEMANTICS, not by being a struct — a record struct, a record class (`record ApartmentId(Guid Value)`) or a class declared by a typed-id base (`class MemberId : TypedIdValueBase`) all count, while a plain mutable class (reference equality) and a verb-phrase query record (`GetCustomerById`) do not. Deterministic, adoption percentage.
Coverage: Population: id-like members by *Id/*Key NAME suffix; strongly-typed-ID shape then checked semantically — non-suffixed identifiers are not seen.
`DomainEventBase.EventId` is a raw `Guid` — give it a strongly-typed id: a dedicated single-field type wrapping the `Guid`, in whatever form your language spells that. — src/Foundation.Domain/Events/DomainEventBase.cs:34
`DomainEventBase.CorrelationId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Foundation.Domain/Events/DomainEventBase.cs:42
`TenantEntity.TenantId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Foundation.Domain/Model/TenantEntity.cs:14
`Message.CorrelationId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Messaging/Domain/Model/Message.cs:58
`LogEvent.Key` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Operations.Domain/Logging/Model/LogEvent.cs:36
`LogEvent.CorrelationId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Operations.Domain/Logging/Model/LogEvent.cs:46
`LogEvent.TrackId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Operations.Domain/Logging/Model/LogEvent.cs:58
`Command.CorrelationId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Commands.Domain/Model/Command.cs:26
`QueueItem.CorrelationId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Queueing/Domain/Model/QueueItem.cs:29
`QueueItem.TraceId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Queueing/Domain/Model/QueueItem.cs:31
`QueueItem.SpanId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Queueing/Domain/Model/QueueItem.cs:33
`LogTrace.Key` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Tracing.Domain/Model/LogTrace.cs:36
`LogTrace.CorrelationId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Tracing.Domain/Model/LogTrace.cs:46
`LogTrace.TrackId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Tracing.Domain/Model/LogTrace.cs:58
`LogTrace.TraceId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Tracing.Domain/Model/LogTrace.cs:62
`LogTrace.SpanId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Tracing.Domain/Model/LogTrace.cs:64
`LogTrace.ParentSpanId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Tracing.Domain/Model/LogTrace.cs:66
`Span.TraceId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Tracing.Domain/Model/Span/Span.cs:29
`Span.SpanId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Tracing.Domain/Model/Span/Span.cs:34
`Span.ParentSpanId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Tracing.Domain/Model/Span/Span.cs:36
`Span.LogKey` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that. — src/Tracing.Domain/Model/Span/Span.cs:40
What to do
Adopt strongly-typed ids across the domain — finish the migration or document the boundary; primitive ids invite transposed-argument bugs.
Do you agree with this assessment?
DM4 · Rich vs anemic model4.4 / 10Adequate✓ Tool-verified
Other · Domain Modelling — Whether aggregates/entities carry the behaviour that protects their invariants, rather than being data bags driven by external services.
Method: Roslyn (DDD-gated): entity method BODIES classified mutator-vs-query — only methods that mutate the entity's own declared state count as invariant-protecting behaviour, so a getter/passthrough doesn't rescue an anemic class. Deterministic, exhaustive over domain-layer entities.
Coverage: Population: entities by name/base convention; rich-vs-anemic judged by classifying each method body mutator-vs-query — logic-bearing domain types outside the convention are invisible.
`EchoEntity` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — src/Foundation.Domain/Model/EchoEntity.cs:3
`DummyMessage` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — src/Messaging/Domain/Handlers/DummyMessage.cs:3
`EchoMessage` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — src/Messaging/Domain/Handlers/EchoMessage.cs:3
`EntityMessage` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — src/Messaging/Domain/Handlers/EntityMessage.cs:5
`Message` is an aggregate/entity with 8 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — src/Messaging/Domain/Model/Message.cs:7
`LogEvent` is an aggregate/entity with 16 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — src/Operations.Domain/Logging/Model/LogEvent.cs:10
`Command` is an aggregate/entity with 6 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — src/Commands.Domain/Model/Command.cs:8
`LogTrace` is an aggregate/entity with 28 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service. — src/Tracing.Domain/Model/LogTrace.cs:10
What to do
Move business rules onto the aggregates/entities they govern so invariants are enforced at the source, not in anemic services.
Other · Domain Modelling — Whether entities protect their state — private/init-only setters, and collections handed out as read-only views rather than the mutable backing collection — instead of exposing writable state that bypasses invariants. Softened when a rehydration framework (Marten/EF) is present.
Method: Roslyn (DDD-gated): entities scanned for publicly writable state — public setters, and (C#/VB) own mutable collections handed out through an auto-property, a public field or a bare-field expression getter, where a computed/copying getter is never charged. One finding per entity; score softened when Marten/EF rehydration frameworks present. Deterministic, framework-aware.
Coverage: Population: entities by convention; encapsulation (setter shape) checked exhaustively within the set.
`EchoEntity` exposes publicly writable state (Text). — src/Foundation.Domain/Model/EchoEntity.cs:3
`TenantEntity` exposes publicly writable state (TenantId). — src/Foundation.Domain/Model/TenantEntity.cs:10
`DummyMessage` exposes publicly writable state (Data). — src/Messaging/Domain/Handlers/DummyMessage.cs:3
`EchoMessage` exposes publicly writable state (Text). — src/Messaging/Domain/Handlers/EchoMessage.cs:3
`EntityMessage` exposes publicly writable state (Entity). — src/Messaging/Domain/Handlers/EntityMessage.cs:5
`QueueItem` exposes publicly writable state (CorrelationId, TraceId, SpanId, Data, EnqueuedDate, RenewedDate, and 4 more). — src/Queueing/Domain/Model/QueueItem.cs:8
`LogTrace` exposes publicly writable state (Id, Level, Key, Environment, Message, Timestamp, and 20 more). — src/Tracing.Domain/Model/LogTrace.cs:10
`Span` exposes publicly writable state (LogKey). — src/Tracing.Domain/Model/Span/Span.cs:10
What to do
Make entity setters private/init-only and hand collections out as IReadOnlyList/IReadOnlyCollection over a private backing field; change state only through methods that enforce the invariants (Marten/EF can bind via constructor or private setters).
Other · Domain Modelling — Whether the domain layer stays free of infrastructure dependencies (EF/Marten/HTTP/ASP.NET) — the clean-architecture dependency rule.
Method: Roslyn (DDD-gated): domain-layer types scanned for infrastructure usage in member SIGNATURES and inside method/accessor BODIES — resolved calls and object-creations into EF/Marten/HTTP/Mongo/Redis/message-bus types (not just a namespace allowlist). Deterministic, symbol-resolved, exhaustive over domain-layer bodies, DDD-native.
Coverage: Domain layer identified by NAMESPACE heuristic; infrastructure then resolved by symbol in member SIGNATURES and method/accessor BODIES — rename the layer and the check evaporates.
Other · Domain Modelling — Whether repositories are per aggregate root (not per child entity) and keep the persistence query handle behind the contract, so the root's invariants can't be bypassed.
Method: Roslyn (DDD-gated): repository abstraction detection; repositories over non-aggregate-root entities flagged, and (C#/VB) repository INTERFACES whose members return a live persistence query handle (IQueryable/DbSet/IMongoQueryable) — implementations and specification evaluators are out of population by design, since composing a query internally is what an implementation is for. Deterministic, DDD-native.
Coverage: Population: repositories + aggregate roots by NAME convention; per-root repository rule checked within the set.
Other · Domain Modelling — Whether clusters of primitives that travel together (a missing value object) are extracted — a low-weight suggestion, LLM-confirmed when configured.
Method: Roslyn (DDD-gated): primitive parameter clusters recurring three or more times across signatures extracted, then confirmed by language model when configured. Advisory, low-weight.
The parameters [orderdescending, skip, take] travel together across 8 signatures and were confirmed as a coherent concept by the model — that's a missing value object. Extracting them into one type (e.g. `Address`, `Money`, `Coordinate`) removes repetition, prevents argument-order mistakes, and gives the concept a home for its rules. — src/Foundation.Domain.Repositories.Documents/Provider/IDocumentProvider.cs:32
What to do
Extract recurring primitive parameter clusters into value objects so the concept (and its rules) lives in one place.
Other · Domain Modelling — Whether one domain rule is decided — or one measurement produced — in more than one place, rather than living on the type that owns it.
Method: Neutral body surface plus Roslyn (DDD-gated), two arms. DECISION (Roslyn only): a predicate over a domain type's members judged in two or more types, where none of those decisions live on the owning type — operands of comparisons and relational property patterns only, so a member merely passed as an argument is not judged. DERIVATION: a plain all-numeric carrier of ≥2 members, with no base type and exactly one constructor, CONSTRUCTED as the result of a method (returned or assigned, never inline as an argument) in two or more types other than its own — the same measurement produced twice, which centralising the judgement does not fix. DERIVATION runs on every language whose frontend declares the produced-or-passed fact per construction (Roslyn and the Java sidecar today); a target with only the derivation arm carries an engine gap naming the decision arm as not assessed, and a frontend that declares nothing keeps the dimension not measured rather than clean. Single-member rules, test code and generated code are out of population for both. Advisory.
Other · Event-Driven — Whether event handlers stay asynchronous (no blocking remote HTTP/gRPC calls awaited inside a handler).
Method: Roslyn semantic scan (event-driven gated): event-handler bodies scanned for HTTP/gRPC invocations by resolved symbol type, not substring. Deterministic, semantic-resolved.
Other · Event-Driven — Whether commands have a single handler (one owner of the decision) and fan-out is modelled with events.
Method: Roslyn scan (event-driven gated): command-shaped messages identified by convention; handler count per command checked for the exactly-one rule. Deterministic, hard fact.
Other · Event-Driven — Whether events are named in the past tense (a clarity nudge — low weight).
Method: Roslyn scan (event-driven gated): domain and integration events checked for past-tense naming (-ed/-en suffix or irregular set). Naming nudge, low-weight advisory.
`EntityDeleteDomainEvent` reads as an instruction, not a fact that happened. Events describe something that already occurred — name them in the past tense (e.g. `OrderPlaced`, `PaymentCaptured`) so the ubiquitous language stays clear. — src/Foundation.Domain/Events/EntityDeleteDomainEvent.cs:3
`EntityInsertDomainEvent` reads as an instruction, not a fact that happened. Events describe something that already occurred — name them in the past tense (e.g. `OrderPlaced`, `PaymentCaptured`) so the ubiquitous language stays clear. — src/Foundation.Domain/Events/EntityInsertDomainEvent.cs:3
`EntityUpdateDomainEvent` reads as an instruction, not a fact that happened. Events describe something that already occurred — name them in the past tense (e.g. `OrderPlaced`, `PaymentCaptured`) so the ubiquitous language stays clear. — src/Foundation.Domain/Events/EntityUpdateDomainEvent.cs:3
What to do
Name events in the past tense — they record facts that already happened.
Other · Event-Driven — Whether state changes and message publishes are atomic (a transactional outbox) rather than a crash-unsafe dual write.
Method: Roslyn semantic scan (event-driven gated): event-handler methods scanned for DB-save plus bus-publish without a transactional outbox reference. Deterministic, semantic-resolved.
Other · Readiness — Whether retry-prone mutations (command handlers + message/event consumers) are idempotent so an at-least-once redelivery or client retry doesn't double-apply the effect — heuristic at-risk detection confirmed by language model, advisory.
Method: Roslyn heuristic (any mutation, ungated): command handlers and message/event consumers that mutate persistent state without a visible idempotency guard (exists/dedup check, upsert, idempotency-key/inbox, conditional/versioned write, fixed-value set) flagged as at-risk; each at-risk candidate then confirmed or cleared by a language model as genuinely non-idempotent versus naturally-idempotent. Advisory without a model (heuristic-only, degraded), per-candidate judged with one.
Coverage: Population: retry-prone mutations — command handlers (CQRS write side) + message/event consumers (IConsumer/I*EventHandler) — that mutate persistent state; runs on any repo with mutations, not only event-driven ones. The at-risk subset (no obvious guard) is a HEURISTIC candidate set, each then LLM-JUDGED non-idempotent vs safe; a handler outside those conventions, or a guard the LLM can't confirm, is bounded by the sample. Degrades to heuristic-only when no model is configured.
Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×40) — src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V3/CosmosSqlProviderV3.cs:171, src/Foundation.Infrastructure.Azure.LogAnalytics/Repositories/LogAnalyticsRepository.cs:93, src/Foundation.Infrastructure.Azure.LogAnalytics/Repositories/LogAnalyticsRepository.cs:98, …
What to do
Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
`GetSecretsWithHttpMessagesAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/Configuration.Application/CachedKeyVaultClient.cs:48
`GetSecretWithHttpMessagesAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/Configuration.Application/CachedKeyVaultClient.cs:57
`RenameFileAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×3) — src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:141, src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:54, src/FileStorage.Infrastructure.FileSystem/EmbeddedFileStorage.cs:90
`AzureKeyVaultFileStorage` has 11 unfinished members out of 11 declared members (methods, properties, indexers and events, whether or not each carries a body) — a scaffolded type that was never implemented. — src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:9
`Serializer` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:12
`CopyFileAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:14, src/FileStorage.Infrastructure.FileSystem/EmbeddedFileStorage.cs:95
`DeleteFileAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:19, src/FileStorage.Infrastructure.FileSystem/EmbeddedFileStorage.cs:100
`DeleteFilesAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:24, src/FileStorage.Infrastructure.FileSystem/EmbeddedFileStorage.cs:105
`Dispose` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:29
`ExistsAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:34
`GetFileInformationAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:39
`GetFileInformationsAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:44
`GetFileStreamAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:49
`SaveFileAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:59, src/FileStorage.Infrastructure.FileSystem/EmbeddedFileStorage.cs:85
`Length` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/FileStorage/Provider/FileStorageFileInfo.cs:25
`GetDirectoryContents` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/FileStorage/Provider/FileStorageProvider.cs:21
`InMemoryEventStore` has 2 unfinished members out of 4 declared members (methods, properties, indexers and events, whether or not each carries a body) — a scaffolded type that was never implemented. — src/Foundation.Domain.EventSourcing/Repositories/EventStore/InMemoryEventStore.cs:7
`ReadSnapshotAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — src/Foundation.Domain.EventSourcing/Repositories/EventStore/InMemoryEventStore.cs:32, src/Foundation.Infrastructure.EventStore/Sql/SqlEventStore.cs:21
`SaveSnapshotAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×2) — src/Foundation.Domain.EventSourcing/Repositories/EventStore/InMemoryEventStore.cs:38, src/Foundation.Infrastructure.EventStore/Sql/SqlEventStore.cs:27
`FindAllAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/Foundation.Domain.Repositories.Documents/DocumentRepository.cs:85
`FindOneAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work. — src/Foundation.Domain.Repositories.Documents/DocumentRepository.cs:113
`WhereAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V3/CosmosSqlProviderV3.cs:171
`CountAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. (×3) — src/Foundation.Infrastructure.Azure.LogAnalytics/Repositories/LogAnalyticsRepository.cs:93, src/Foundation.Infrastructure.Azure.LogAnalytics/Repositories/LogAnalyticsRepository.cs:98, src/Foundation.Infrastructure.Azure.LogAnalytics/Repositories/LogAnalyticsRepository.cs:103
`AddContainsFromExpression` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs:352
`SqlEventStore` has 4 unfinished members out of 4 declared members (methods, properties, indexers and events, whether or not each carries a body) — a scaffolded type that was never implemented. — src/Foundation.Infrastructure.EventStore/Sql/SqlEventStore.cs:8
`ReadEventsAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/Foundation.Infrastructure.EventStore/Sql/SqlEventStore.cs:11
`SaveEventAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/Foundation.Infrastructure.EventStore/Sql/SqlEventStore.cs:16
Control only reaches here when `type == typeof(float)` is false, because the guard on line 298 exits otherwise. This test is therefore always false and everything it guards is unreachable. Implement the distinction that was intended, or delete the test. — src/Foundation.Utilities/Expando/PropertyBag.cs:313
`ReleaseLock` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/JobScheduling/Domain/Services/DistributedMutext.cs:27
`TryAcquireLock` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/JobScheduling/Domain/Services/DistributedMutext.cs:32
What to do
Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
What to do
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Add a README to the 107 of 109 project(s) that lack one — worth up to 2 pts.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).
Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.
README advertises a microservices architecture, but the repo is a single project with no service manifests — searched for: `microservice`, `service-mesh`, `istio`. Each was matched case- and separator-insensitively against file and directory NAMES anywhere in the tree, and against the CONTENTS of manifest and configuration files (package.json and other *.json, *.csproj, *.props, *.sln/*.slnx, *.yml, *.toml, *.config, tool configs such as eslint.config.js, Dockerfile); the README's own prose never counts, so a claim is never refuted by merely being made. Nothing outside that search was read — a footprint living only in a submodule, in a file type not listed here, or under a name none of those terms matches is not seen, and this row is then wrong. — README.md:191
What to do
Reconcile the README with reality: README advertises a microservices architecture, but the repo is a single project with no service manifests.
`src/Foundation.Application.Web/Console/Commands/OpenBrowserConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 52 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Application.Web/Console/Commands/OpenBrowserConsoleCommandEventHandler.cs:52
`src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 26 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs:26
`src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 33 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs:33
`src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 42 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs:42
`src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 48 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs:48
`src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 57 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs:57
`src/Messaging.Application/Console/MessagingConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 27 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Messaging.Application/Console/MessagingConsoleCommandEventHandler.cs:27
`src/Messaging.Application/Console/MessagingConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 32 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Messaging.Application/Console/MessagingConsoleCommandEventHandler.cs:32
`src/Queueing.Application/Console/QueueingConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 26 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Queueing.Application/Console/QueueingConsoleCommandEventHandler.cs:26
`src/Queueing.Application/Console/QueueingConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 56 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Queueing.Application/Console/QueueingConsoleCommandEventHandler.cs:56
`src/Foundation.Console/App/InteractiveConsoleHostedService.cs` reports through `Console.Write…` at line 39 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/App/InteractiveConsoleHostedService.cs:39
`src/Foundation.Console/App/InteractiveConsoleHostedService.cs` reports through `Console.Write…` at line 57 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/App/InteractiveConsoleHostedService.cs:57
`src/Foundation.Console/App/InteractiveConsoleHostedService.cs` reports through `Console.Write…` at line 92 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/App/InteractiveConsoleHostedService.cs:92
`src/Foundation.Console/App/InteractiveConsoleHostedService.cs` reports through `Console.Write…` at line 108 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/App/InteractiveConsoleHostedService.cs:108
`src/Foundation.Console/App/InteractiveConsoleHostedService.cs` reports through `Console.Write…` at line 120 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/App/InteractiveConsoleHostedService.cs:120
`src/Foundation.Console/App/InteractiveConsoleHostedService.cs` reports through `Console.Write…` at line 127 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/App/InteractiveConsoleHostedService.cs:127
`src/Foundation.Console/App/InteractiveConsoleHostedService.cs` reports through `Console.Write…` at line 128 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/App/InteractiveConsoleHostedService.cs:128
`src/Foundation.Console/Commands/EchoConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 28 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/Commands/EchoConsoleCommandEventHandler.cs:28
`src/Foundation.Console/Commands/ExitConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 34 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/Commands/ExitConsoleCommandEventHandler.cs:34
`src/Foundation.Console/Commands/HistoryConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 16 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/Commands/HistoryConsoleCommandEventHandler.cs:16
`src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 24 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs:24
`src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 25 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs:25
`src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 26 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs:26
`src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 27 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs:27
`src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 28 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs:28
`src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 29 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs:29
`src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 30 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs:30
`src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 34 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs:34
`src/Foundation.Application.Web.Startup/Console/StartupTaskConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 31 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — src/Foundation.Application.Web.Startup/Console/StartupTaskConsoleCommandEventHandler.cs:31
What to do
Replace `Console.Write…` in service code with the project's injected `ILogger<T>` (message templates with named properties), so delivery outcomes and failures reach the log pipeline with a level and a category.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
What to do
Enable Dependabot/Renovate or a dependency-review gate.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
What to do
The pipeline declares a deployment environment, but whether required reviewers / protection rules are attached to it lives in repository settings we cannot read — confirm the gate is enforced before production promotion.
Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.
Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.
No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
What to do
Keep a changelog (e.g. Keep-a-Changelog) recording what shipped in each release.
Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.
Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.
`context.Services.AddHttpClient<TClient>()` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default). — src/Application/NaosExtensions.cs:40
`context.Services .AddHttpClient<TClient>()` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default). — src/Application/NaosExtensions.cs:46
`context.Services.AddHttpClient(name)` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default). — src/Application/NaosExtensions.cs:66
`context.Services .AddHttpClient(name)` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default). — src/Application/NaosExtensions.cs:72
`new System.Net.Http.HttpClient()` builds an outbound HTTP client and nothing bounds it: no timeout is set on it and no retry or resilience policy wraps its calls in the type that owns it. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default). (×2) — src/Operations.Infrastructure.Azure/NaosExtensions.cs:37, src/Tracing.Infrastructure.Azure/NaosExtensions.cs:37
What to do
Add `AddStandardResilienceHandler()` (or a Polly policy and an explicit timeout) to each client registration flagged here, so a flaky dependency can't take the app down.
Do you agree with this assessment?
P8 · Schema migrations3.0 / 10Weak✓ Tool-verified
Readiness · Readiness — Whether EF Core schema changes go through versioned migrations rather than the un-evolvable EnsureCreated().
Method: Roslyn scan: EF Core DbContext for a versioned migrations directory versus bare EnsureCreated usage; off .NET, a file scan of dependency manifests, migration histories (Flyway, Liquibase, Alembic, Django, Rails, Prisma, TypeORM, Knex/Sequelize, golang-migrate, goose, Laravel, Doctrine, Diesel/sqlx) and schema auto-create in production source or config. Exhaustive, deterministic.
This repository evolves its schema with versioned migrations, but `EnsureCreated()` here builds a schema straight from the model instead — with no migrations-history row, so a database it creates can't be upgraded by `Migrate()` afterwards and the two paths can disagree about the shape. Apply the migrations here (`Migrate()` / a migrations bundle) rather than creating the schema. (×2) — src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:37, src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs:34
What to do
Replace each EnsureCreated() in production code with the migrations the rest of the repository already uses (`Database.Migrate()` or a migrations bundle), so every database gets its schema from the one versioned path.
Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.
Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.
Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.
Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — in .NET Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit; off .NET, with comments and strings blanked, Go's sync.Pool, preallocated slices/maps, Grow, strconv.Append* and buf[:0] reuse; the JVM's NIO buffer views, MemorySegment, primitive collections, pools and literal presizes (plus Kotlin primitive arrays and value classes, Scala AnyVal and @specialized); Swift's reserveCapacity, ContiguousArray, withUnsafe* access and ~Copyable. Activated off .NET on the same floor (400 lines, and benchmarks or 8 uses); Rust and garbage-collected scripting languages are not applicable. Reward-only. Deterministic, syntax/text detection.
What to do
Raise allocation-aware density on the hot paths — currently 2 use(s) across 55,720 production line(s) (~0.0/1k). More Span/Memory, pooling (ArrayPool/ObjectPool), stackalloc and ValueTask on the allocation-heavy paths climbs this toward 10.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from the language model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
18 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
`.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×13) — src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:201, src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:70, src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:149, …
`.GetAwaiter() .GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×2) — src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:180, src/Messaging.Application.Azure/NaosExtensions.cs:61
`.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×3) — src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:168, src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs:156, src/Operations.Application.Web/Controllers/NaosOperationsLogTracesController.cs:125
What to do
Make the call chain async end-to-end and await it — never block on a Task with .Wait()/.GetAwaiter().GetResult().
Other · Security — Transport security, security headers, secure cookies, input validation, middleware order and crypto hygiene (presence, not runtime).
Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.
MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses. (×5) — src/Foundation.Utilities/HashAlgorithm.cs:20, src/Foundation.Utilities/HashAlgorithm.cs:36, src/Foundation.Utilities/HashAlgorithm.cs:99, …
This type encrypts through `SymmetricAlgorithm`, whose every cipher mode (CBC/ECB/OFB/CFB/CTS) is unauthenticated, and no keyed MAC or AEAD cipher appears anywhere in it — so nothing establishes that the ciphertext it produced is the ciphertext it later reads back. Encryption alone provides confidentiality, not integrity: unauthenticated CBC is MALLEABLE, and an attacker who can modify stored or transmitted ciphertext can flip chosen plaintext bits in the following block by flipping ciphertext bits in the preceding one, without ever knowing the key. Where the decrypt path reports failure differently for a padding error than for a downstream one — a broad `catch` that returns null is the usual spelling — the same construction also answers the attacker's questions, which is the padding-oracle shape that recovers plaintext outright. Prefer an AEAD cipher: `AesGcm` or `ChaCha20Poly1305` authenticate the ciphertext as part of encrypting it, and give you an associated-data slot for the surrounding context. Where the format cannot change, MAC it with encrypt-then-MAC — HMAC-SHA256 over the IV and the ciphertext together, with a key derived separately from the encryption key — and verify that tag with `CryptographicOperations.FixedTimeEquals` BEFORE decrypting anything. (×3) — src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:54, src/Foundation.Utilities/EncryptionHelper.cs:24, src/Foundation.Utilities/EncryptionHelper.cs:70
Here `Write` is called on a `CryptoStream` opened with `CryptoStreamMode.Read`. A `CryptoStream` is one-directional by construction: `CryptoStreamMode.Read` leaves `CanWrite` false and `CryptoStreamMode.Write` leaves `CanRead` false, and the mismatched call throws `NotSupportedException` before a single byte reaches the transform. So this encrypt/decrypt routine can never succeed for any input — every caller gets an exception, or, where a broad `catch` swallows it, silently gets nothing back and believes the data was protected or recovered. Open the stream for the direction the code uses it in: `CryptoStreamMode.Write` when the routine writes bytes or text INTO the stream and reads the result off the underlying `MemoryStream`, `CryptoStreamMode.Read` when it reads the transformed bytes OUT of the stream — and add a round-trip test (`Decrypt(Encrypt(x)) == x`) that exercises this overload, which is the test that would have caught it. — src/Foundation.Utilities/EncryptionHelper.cs:99
DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes. (×3) — src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:46, src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:79, src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:109
`RequireHttpsMetadata = false` allows the OIDC discovery doc to be fetched over plain HTTP. Safe for loopback-only fetches (Aspire / on-host); risky for any other path. — src/Authentication.Application.Web/NaosExtensions.cs:106
None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. (−2.0 on this card.)
No UseHttpsRedirection/UseHsts and no reverse-proxy signal — transport security is unverified at the app layer. (−2.0 on this card.)
No CookieSecurePolicy/HttpOnly/SameSite configuration found. (−1.5 on this card; skip if the app sets no cookies.) — src/Authentication.Application.Web/NaosExtensions.cs:98
What to do
Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name. This repository constructs a collision-broken hash (MD5/SHA1) at 5 sites, not one: `src/Foundation.Utilities/HashAlgorithm.cs:20` (MD5CryptoServiceProvider), `src/Foundation.Utilities/HashAlgorithm.cs:36` (MD5CryptoServiceProvider), `src/Foundation.Utilities/HashAlgorithm.cs:99` (MD5), `src/Foundation.Utilities/HashAlgorithm.cs:110` (MD5), `src/Foundation.Utilities/HashAlgorithm.cs:113` (SHA1). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Authenticate ciphertext, do not just encrypt it: move to an AEAD cipher (`AesGcm`, `ChaCha20Poly1305`), or where the wire format is fixed, add encrypt-then-MAC with HMAC-SHA256 over IV+ciphertext under a separately derived key and verify the tag with `CryptographicOperations.FixedTimeEquals` before decrypting. Unauthenticated CBC is malleable, and a decrypt path that distinguishes padding failures from other failures is a padding oracle. This repository constructs symmetric encryption whose ciphertext nothing authenticates at 3 sites, not one: `src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:54` (CBC or another CipherMode member), `src/Foundation.Utilities/EncryptionHelper.cs:24` (CBC or another CipherMode member), `src/Foundation.Utilities/EncryptionHelper.cs:70` (CBC or another CipherMode member). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Open each `CryptoStream` for the direction the routine uses it in — `CryptoStreamMode.Write` where bytes or text are written into it, `CryptoStreamMode.Read` where they are read out of it — and pin every encrypt/decrypt overload with a round-trip test (`Decrypt(Encrypt(x)) == x`). A write into a Read-mode stream, or a read from a Write-mode one, throws `NotSupportedException` on the first byte.
Replace DES/3DES (and bare RijndaelManaged) with AES-GCM via `Aes.Create()`. This repository constructs a broken or deprecated cipher at 3 sites, not one: `src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:46` (RijndaelManaged), `src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:79` (RijndaelManaged), `src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:109` (RijndaelManaged). Each is a separate decision — fixing only the line this row cites leaves the others in place.
Set RequireHttpsMetadata = true in prod (or pin MetadataAddress to a localhost URL the API can hit directly).
Add security response headers (Content-Security-Policy first, then Strict-Transport-Security, X-Content-Type-Options and a frame policy) — defense in depth, even when a reverse proxy could set them.
Enforce HTTPS at the app layer (UseHttpsRedirection / UseHsts) — only skip this if a reverse proxy demonstrably terminates TLS.
Set secure cookie flags — CookieSecurePolicy.Always, HttpOnly, and SameSite (Strict/Lax) on auth/session cookies. Skip only if the app sets no cookies.
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout. (×19) — src/Application.Web/NaosExtensions.cs:136, src/Application.Web/NaosExtensions.cs:172, src/Application.Web/NaosExtensions.cs:183, …
Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process. (×15) — src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:201, src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:66, src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:149, …
`FileStorageMessageBroker.GetFileContents` is a synchronous helper that blocks (`Thread.Sleep`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll). — src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:146
Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback. (×2) — src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:52, src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:53
`Thread.Sleep` parks the thread for the whole delay: no other work runs on it, and under load the pool must grow to make up for it. `await Task.Delay(…)` suspends only this method. (×2) — REDACTED:31, REDACTED:82
`async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained. — src/JobScheduling.Application/JobSchedulerHostedService.cs:70
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.
Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.
Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.
Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X15 · Unvalidated length from an untrusted reader10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.
Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.
Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
`sp.CreateScope()` (line 75) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`. — src/Messaging.Application.Azure/NaosExtensions.cs:75
`sp.CreateScope()` (line 80) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`. — src/Messaging.Application.Azure/NaosExtensions.cs:80
`sp.CreateScope()` (line 40) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`. (×3) — src/Messaging.Application.Azure.SignalR/NaosExtensions.cs:40, src/JobScheduling.Application/NaosExtensions.cs:40, src/Foundation.Application.Web.Startup/ServiceCollectionExtensions.cs:40
`sp.CreateScope()` (line 41) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`. — src/Messaging.Application.FileSystem/NaosExtensions.cs:41
`sp.CreateScope()` (line 39) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`. — src/JobScheduling.Application/NaosExtensions.cs:39
`sp.CreateScope()` (line 45) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`. — src/JobScheduling.Application/NaosExtensions.cs:45
`sp.CreateScope()` (line 74) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`. — src/Operations.Application/OperationsOptionsExtensions.cs:74
`inner` is never created by `AutoCompleteQueueDecorator` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 57). Its declared type `IQueue` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed. — src/Queueing/Domain/Decorators/AutoCompleteQueueDecorator.cs:57
`inner` is never created by `FileStorageQueueDecorator` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 55). Its declared type `IQueue` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed. — src/Queueing/Domain/Decorators/FileStorageQueueDecorator.cs:55
`sw` is a `StreamWriter`, which implements `IDisposable`, and it is created here (line 48). Every use of it in `ToStream` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var sw = …;`), which releases it at the end of the scope on every path including a throw. — src/Foundation.Utilities/StreamHelper.cs:48
`sp.CreateScope()` (line 48) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`. — src/Foundation.Application.Web.Startup/ServiceCollectionExtensions.cs:48
`inner` is never created by `StartupTaskServerDecorator` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 64). Its declared type `IServer` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed. — src/Foundation.Application.Web.Startup/StartupTaskServerDecorator.cs:64
`sp.CreateScope()` (line 25) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`. — src/Tracing.Application/OperationsOptionsExtensions.cs:25
What to do
Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.
Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.
Only 207/549 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
No CancellationToken parameter — this work can't be stopped early once started. (×38) — src/Application.Web/Controllers/NaosGenericRepositoryControllerBase.cs:36, src/Application.Web/Controllers/NaosGenericRepositoryControllerBase.cs:69, src/Application.Web/Controllers/NaosGenericRepositoryControllerBase.cs:95, …
No CancellationToken parameter, and the token `source.HttpContext.RequestAborted` carries reaches none of the calls here that take one — this work can't be stopped early once started. Pass `source.HttpContext.RequestAborted` on, or take a CancellationToken. — src/Foundation.Application.Web/Dashboard/HttpResponseExtensions.cs:12
What to do
Thread a CancellationToken through async methods so work stops promptly on cancellation.
Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.
Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.
Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
`LogDebug` at line 105 is called with an argument built by `behaviors.Select(e => e.GetType().PrettyName())` (line 105), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because LogDebug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region. — src/Commands.Application/Handlers/BaseCommandHandler.cs:105
`LogDebug` at line 123 is called with an argument built by `behaviors.Select(e => e.GetType().PrettyName())` (line 123), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because LogDebug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region. — src/Commands.Application/Handlers/BaseCommandHandler.cs:123
`LogDebug` at line 107 is called with an argument built by `result.Select(c => c.ToString())` (line 107), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because LogDebug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region. — src/Filtering.Application/Web/FilterContextFactory.cs:107
`LogDebug` at line 138 is called with an argument built by `result.Select(o => o.ToString())` (line 138), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because LogDebug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region. — src/Filtering.Application/Web/FilterContextFactory.cs:138
`LogDebug` at line 58 is called with an argument built by `string.Join("|", notification.Span.Tags.Select(t => $"{t.Key}={t.Value}"))` (line 58), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because LogDebug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region. — src/Tracing.Domain/Events/SpanEndedLoggerDomainEventHandler.cs:58
`LogDebug` at line 119 is called with an argument built by `extensions.Select(e => e.GetType().PrettyName())` (line 119), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because LogDebug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region. — src/Commands.Application.Web/Middleware/CommandRequestMiddleware.cs:119
`LogDebug` at line 143 is called with an argument built by `extensions.Select(e => e.GetType().PrettyName())` (line 143), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because LogDebug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region. — src/Commands.Application.Web/Middleware/CommandRequestMiddleware.cs:143
What to do
Each finding names the diagnostic call and the expression inside its argument whose cost scales with a collection. Confirm from the two that the argument is built before the call — that is C#'s evaluation order, not a guess — then put the construction behind the same level check the sink applies: `if (logger.IsEnabled(LogLevel.Trace))` for Microsoft.Extensions.Logging, the repository's own debug flag where it has one, or a message template whose ARGUMENTS the logging framework only formats when the level is on. Moving the call is not the fix: it is the join/projection in the argument that is paid, wherever the call sits.
Do you agree with this assessment?
X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged
Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.
Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.
Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×12) — src/Foundation.Application.Web/Dashboard/HttpResponseExtensions.cs:77, src/Foundation.Application.Web/Dashboard/HttpResponseExtensions.cs:94, src/Foundation.Domain/Model/DataDictionary.cs:121, …
What to do
Swallowed exception (empty catch)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X32 · Type resolved by simple name across every loaded assembly10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a plugin lookup names the type it means — searching every assembly loaded into the process for a candidate whose SIMPLE name equals a string supplied at runtime, and taking the first one found, is decided by assembly LOAD ORDER rather than by this source, so the same name can resolve to a different type on the next run.
Method: Roslyn syntax only, no semantic model: every invocation of `First`/`FirstOrDefault`/`Single`/`SingleOrDefault` whose OWN expression subtree contains both a `GetAssemblies()` call and a `GetTypes()`/`GetExportedTypes()` call — a single-element pick out of every type loaded into the process. A nested selector in the same chain sees no `GetAssemblies()` in its own subtree and is outside the population, so one lookup counts once however many links its chain has. A finding additionally needs both remaining halves: the selector must be `First`/`FirstOrDefault` (`Single`/`SingleOrDefault` reports the ambiguity rather than resolving it, and is counted and never reported), and the chain must carry an `==` comparison of `<lambda parameter>.Name` against something that is not a literal. The receiver must be a plain identifier bound by one of the chain’s own lambdas, which places `assembly.GetName().Name == "X"` outside the rule by construction. One exemption: a `.Name` test joined by `&&` to a `FullName`/`AssemblyQualifiedName` test on the same identifier is spared; joined by `||` it is not. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.
Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.
Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it. (×40) — src/Application/HttpClientBuilderExtensions.cs:53, src/Application/HttpClientBuilderExtensions.cs:63, src/Application.Web/Controllers/NaosReadOnlyGenericRepositoryControllerBase.cs:42, …
Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
This method contradicts itself about `other`: line 104 assigns it with `as Entity<TId>`, which hands back null rather than throwing when the value is not a `Entity<TId>`, but line 116 then dereferences it directly as `other.GetType` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `other` once before the first use and handle the null case, or cast with `(Entity<TId>)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/Foundation.Domain/Model/Entity.cs:116
This method contradicts itself about `message`: line 369 writes `message?.Id`, which says `message` can be null, but line 366 then dereferences it directly as `message.Origin` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `message` truly cannot be null here, the `?.` is misleading. Settle it one way — test `message` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:366
This method contradicts itself about `message`: line 269 writes `message?.Id`, which says `message` can be null, but line 262 then dereferences it directly as `message.Origin` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `message` truly cannot be null here, the `?.` is misleading. Settle it one way — test `message` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:262
This method contradicts itself about `context`: line 49 writes `context?.Request`, which says `context` can be null, but line 52 then dereferences it directly as `context.GetRequestId` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `context` truly cannot be null here, the `?.` is misleading. Settle it one way — test `context` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Filtering.Application/Web/Middleware/RequestFilterMiddleware.cs:52
This method contradicts itself about `message`: line 185 writes `message?.Id`, which says `message` can be null, but line 164 then dereferences it directly as `message.Origin` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `message` truly cannot be null here, the `?.` is misleading. Settle it one way — test `message` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:164
This method contradicts itself about `message`: line 215 writes `message?.Id`, which says `message` can be null, but line 203 then dereferences it directly as `message.Properties` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `message` truly cannot be null here, the `?.` is misleading. Settle it one way — test `message` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:203
This method contradicts itself about `serviceDescriptor`: line 64 writes `serviceDescriptor?.ToString`, which says `serviceDescriptor` can be null, but line 49 then dereferences it directly as `serviceDescriptor.Product` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `serviceDescriptor` truly cannot be null here, the `?.` is misleading. Settle it one way — test `serviceDescriptor` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/ServiceContext.Application/Web/Middleware/ServiceContextMiddleware.cs:49
This method contradicts itself about `options`: line 91 writes `options?.Invoke`, which says `options` can be null, but line 95 then dereferences it directly as `options.DefaultScheme` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `options` truly cannot be null here, the `?.` is misleading. Settle it one way — test `options` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Authentication.Application.Web/NaosExtensions.cs:95
This method contradicts itself about `addItem`: line 84 assigns it with `as QueueItem<TData>`, which hands back null rather than throwing when the value is not a `QueueItem<TData>`, but line 89 then dereferences it directly as `addItem.RenewedDate` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `addItem` once before the first use and handle the null case, or cast with `(QueueItem<TData>)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/Queueing/InMemoryQueue.cs:89
This method contradicts itself about `queue`: line 69 assigns it with `as IQueue`, which hands back null rather than throwing when the value is not a `IQueue`, but line 70 then dereferences it directly as `queue.GetMetricsAsync` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `queue` once before the first use and handle the null case, or cast with `(IQueue)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/Queueing.Application.Web/Controllers/NaosQueuesController.cs:70
This method contradicts itself about `member`: line 383 assigns it with `as MethodInfo`, which hands back null rather than throwing when the value is not a `MethodInfo`, but line 384 then dereferences it directly as `member.Invoke` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `member` once before the first use and handle the null case, or cast with `(MethodInfo)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/Foundation.Utilities/Expando/Expando.cs:384
This method contradicts itself about `value`: line 72 tests it for null before doing anything with it — the author's own statement that null is an input this code expects — but that `if` scopes only the block beneath it, and line 119 then dereferences `value` as `value.GetType` AFTER the block has closed, where the guard no longer applies. A null `value` skips the guarded body and reaches that line anyway, throwing NullReferenceException on exactly the input the guard was written for. If the dereference belongs to the guarded work, move it inside the block; if `value` truly cannot be null by then, the guard above is misleading and should go. — src/Foundation.Utilities/Expando/PropertyBag.cs:119
This method contradicts itself about `firstStep`: line 37 assigns it with `as IPipelineStep<TPipeIn>`, which hands back null rather than throwing when the value is not a `IPipelineStep<TPipeIn>`, but line 40 then dereferences it directly as `firstStep.Buffer` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `firstStep` once before the first use and handle the null case, or cast with `(IPipelineStep<TPipeIn>)` so the failure is reported where it happens — rather than leaving the two readings side by side. — src/Foundation.Utilities/Pipeline/Pipeline.cs:40
This method contradicts itself about `items`: line 89 writes `items?.Add`, which says `items` can be null, but line 87 then dereferences it directly as `items.ContainsKey` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `items` truly cannot be null here, the `?.` is misleading. Settle it one way — test `items` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Commands.Application.Web/CommandRequestDocumentProcessor.cs:87
This method contradicts itself about `registration`: line 42 writes `registration?.OnSuccess`, which says `registration` can be null, but line 32 then dereferences it directly as `registration.CommandType` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `registration` truly cannot be null here, the `?.` is misleading. Settle it one way — test `registration` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Commands.Application.Web/Middleware/Extensions/MediatorDispatcherCommandRequestExtension.cs:32
This method contradicts itself about `registration`: line 73 writes `registration?.OnSuccess`, which says `registration` can be null, but line 65 then dereferences it directly as `registration.CommandType` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `registration` truly cannot be null here, the `?.` is misleading. Settle it one way — test `registration` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Commands.Application.Web/Middleware/Extensions/MediatorDispatcherCommandRequestExtension.cs:65
This method contradicts itself about `indexMaps`: line 107 writes `indexMaps?.Select`, which says `indexMaps` can be null, but line 86 then dereferences it directly as `indexMaps.IsNullOrEmpty` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `indexMaps` truly cannot be null here, the `?.` is misleading. Settle it one way — test `indexMaps` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs:86
This method contradicts itself about `indexMaps`: line 244 writes `indexMaps?.Select`, which says `indexMaps` can be null, but line 238 then dereferences it directly as `indexMaps.IsNullOrEmpty` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `indexMaps` truly cannot be null here, the `?.` is misleading. Settle it one way — test `indexMaps` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs:238
This method contradicts itself about `tags`: line 691 writes `tags?.ToString`, which says `tags` can be null, but line 720 then dereferences it directly as `tags.Safe` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `tags` truly cannot be null here, the `?.` is misleading. Settle it one way — test `tags` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — REDACTED:720
0/4 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
What to do
Where a method uses `?.` on a symbol and then dereferences it directly, settle the question once: test it before the first use and handle null, or drop the `?.`.
Where a method null-tests a symbol and then uses it after the guarded block closes, move the trailing work inside the block — the guard skips its body on null, it does not stop the method.
Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.
Do you agree with this assessment?
Reference — by lens
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 4 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
P12 CI test-gate honesty — 2 observation(s) recorded · Reported, not scored — this card publishes what the CI gate does with the test inventory rather than grading it. The findings above are its output.
SC1 Supply-chain hygiene — 1 observation(s) recorded · Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X10 Duplicated predicate — 23 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 2 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 35 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AXB1 Runtime evidence locked — no reproducible boot — This repository has nothing the runtime tiers could boot or serve — no markup, no UI framework or web-server dependency, no UI component source, no native UI project and no API definition — nothing here is a surface to boot — so runtime a11y/egress/header evidence has no subject here. Not applicable: this is neither a gap in the scan nor a finding about your code.
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
C1 Data Protection — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C3 Audit Trail — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C4 Data Retention — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C5 Data-Subject Rights — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
D11 Test Reliability — Test reliability not measured — no test run produced results
D16 Bus Factor — single-contributor repository — bus factor is not applicable
D19 Documentation Quality — LLM evaluation failed
D20 ADR Quality — N/A — this repo declares itself a template / kata / sample / demo; a formal ADR log is deferred to a real application built from it.
D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
D25 ADR Conformance — no ADRs to check
D30 Dependency Vulnerabilities — nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan
D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
D32 Data Compliance (PII/GDPR) — 2 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D39 IL Efficiency — IL not measured — the analyzer's build of the target did not succeed
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D43 Malicious Dependencies — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).
D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
DM3 Integration-event coupling — no integration events detected — coupling check not applicable
ES1 Event Sourcing — applicable but not scored (2 of 3 signals for this style — below the bar we score at): an event-store package (Marten/EventStore); an append-only event-store seam (IEventStore/Append-of-events)
P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (Cobertura — `dotnet test --collect:"XPlat Code Coverage"` with a `coverlet.collector` PackageReference) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
WriteOnlyPrivateField src/Application.Web/Controllers/NaosEchoController.cs:13— private ILogger<NaosEchoController> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Authentication.Application.Web/Controllers/NaosAuthenticationEchoController.cs:16— private ILogger<NaosAuthenticationEchoController> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Authentication.Application.Web/Oidc/OidcAuthenticationChallengeMiddleware.cs:18— private ILogger<OidcAuthenticationChallengeMiddleware> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Commands.Application.Web/CommandRequestQueueProcessor.cs:13— private ILogger<CommandRequestQueueProcessor> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Commands.Application.Web/Controllers/NaosCommandRequestsController.cs:17— private ILogger<NaosCommandRequestsController> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Commands.Application.Web/Controllers/NaosCommandsEchoController.cs:14— private ILogger<NaosCommandsEchoController> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Commands.Application/Handlers/Behaviors/TracerCommandBehavior.cs:12— private ILogger<TracerCommandBehavior> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Commands.Application/Handlers/Behaviors/TracerCommandBehavior.cs:13— private ITracer tracer — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/JobScheduling/Domain/Services/JobScheduler.cs:16— private ITracer tracer — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Correlation.Application/Web/Controllers/NaosCorrelationEchoController.cs:14— private ILogger<NaosCorrelationEchoController> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/FileStorage.Infrastructure.FileSystem/EmbeddedFileStorage.cs:16— private object lock — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/FileStorage.Infrastructure.Ssh/SshNetFileStorage.cs:20— private SshNetFileStorageOptions options — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/FileStorage/Provider/FileStorageDirectoryContents.cs:14— private string path — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Filtering.Application/Web/Controllers/NaosRequestFilteringEchoController.cs:14— private ILogger<NaosRequestFilteringEchoController> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Foundation.Application.Web.Startup/Console/StartupTaskConsoleCommandEventHandler.cs:13— private ILogger<StartupTaskConsoleCommandEventHandler> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Foundation.Console/App/InteractiveConsoleHostedService.cs:20— private ILogger<InteractiveConsoleHostedService> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Foundation.Console/Commands/EchoConsoleCommandEventHandler.cs:12— private ILogger<EchoConsoleCommandEventHandler> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs:14— private ILogger<ProcessConsoleCommandEventHandler> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:25— private AsyncLazy<Database> database — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/JobScheduling.Application.Web/Controllers/NaosJobRegistrationsController.cs:18— private ILogger<NaosJobRegistrationsController> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/JobScheduling.Application.Web/Controllers/NaosJobsController.cs:18— private ILogger<NaosJobRegistrationsController> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/JobScheduling.Application.Web/Controllers/NaosJobSchedulingEchoController.cs:15— private ILogger<NaosJobSchedulingEchoController> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/JobScheduling/Domain/Services/DistributedMutext.cs:11— private ILogger<DistributedMutext> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/JobScheduling/Domain/Services/DistributedMutext.cs:12— private DateTime moment — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/KeyValueStorage.Infrastructure.Azure/TableKeyValueStorage.cs:25— private ILogger<TableKeyValueStorage> logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
Captive dependency: singleton IJobScheduler resolves scoped ILoggerFactory from the root provider src/JobScheduling.Application/NaosExtensions.cs:38— Building the SINGLETON `IJobScheduler` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes.
Captive dependency: singleton IJobScheduler resolves scoped ILoggerFactory from the root provider src/JobScheduling.Application/NaosExtensions.cs:44— Building the SINGLETON `IJobScheduler` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes.
Captive dependency: singleton IJobScheduler resolves scoped ILoggerFactory from the root provider src/JobScheduling.Application/NaosExtensions.cs:46— Building the SINGLETON `IJobScheduler` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes.
Captive dependency: singleton IHostedService resolves scoped ILoggerFactory from the root provider src/JobScheduling.Application/NaosExtensions.cs:51— Building the SINGLETON `IHostedService` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes.
Captive dependency: singleton RequestStorageMiddlewareOptions resolves scoped ILoggerFactory from the root provider src/Operations.Application.Web/RequestStorageOptionsExtensions.cs:33— Building the SINGLETON `RequestStorageMiddlewareOptions` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes.
Captive dependency: singleton RequestStorageMiddlewareOptions resolves scoped ILoggerFactory from the root provider src/Operations.Application.Web/RequestStorageOptionsExtensions.cs:59— Building the SINGLETON `RequestStorageMiddlewareOptions` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes.
Captive dependency: singleton LoggingAdapter captures scoped ILoggerFactory src/Operations.Application/LoggingAdapter.cs:10— `LoggingAdapter` is registered as a SINGLETON but its constructor takes `ILoggerFactory factory`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `ILoggerFactory` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton IHostedService resolves scoped ILoggerFactory from the root provider src/Operations.Application/OperationsOptionsExtensions.cs:73— Building the SINGLETON `IHostedService` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes.
Captive dependency: singleton IQueue resolves scoped ITracer from the root provider src/Queueing.Application/NaosExtensions.cs:59— Building the SINGLETON `IQueue` resolves `ITracer`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ITracer` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ITracer` from the scope's provider, or align the lifetimes.
Captive dependency: singleton IQueue resolves scoped ILoggerFactory from the root provider src/Queueing.Application/NaosExtensions.cs:60— Building the SINGLETON `IQueue` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes.
Captive dependency: singleton QueueProcessItemsHostedService captures scoped ILoggerFactory src/Queueing.Application.Web/QueueProcessItemsHostedService.cs:20— `QueueProcessItemsHostedService` is registered as a SINGLETON but its constructor takes `ILoggerFactory loggerFactory`, which is registered as Scoped. The singleton captures one instance of the scoped dependency forever — defeating its lifetime (a per-request DbContext shared across all requests is a classic data-corruption/threading bug). Make the singleton resolve `ILoggerFactory` per-use (inject `IServiceScopeFactory` or a factory func), or align the lifetimes.
Captive dependency: singleton CommandRequestStore resolves scoped ILoggerFactory from the root provider src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:311— Building the SINGLETON `CommandRequestStore` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes.
Captive dependency: singleton CommandRequestStore resolves scoped ILoggerFactory from the root provider src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:323— Building the SINGLETON `CommandRequestStore` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes.
Captive dependency: singleton CommandRequestStore resolves scoped ILoggerFactory from the root provider src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:334— Building the SINGLETON `CommandRequestStore` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes.
Captive dependency: singleton CommandRequestStore resolves scoped ILoggerFactory from the root provider src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:345— Building the SINGLETON `CommandRequestStore` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes.
Captive dependency: singleton IQueue resolves scoped ILoggerFactory from the root provider src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:357— Building the SINGLETON `IQueue` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes.
Captive dependency: singleton IQueue resolves scoped ILoggerFactory from the root provider src/Commands.Application.Web.Azure/CommandRequestOptionsExtensions.cs:48— Building the SINGLETON `IQueue` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes.
Captive dependency: singleton IQueue resolves scoped ILoggerFactory from the root provider src/Commands.Application.Web.Azure/CommandRequestOptionsExtensions.cs:76— Building the SINGLETON `IQueue` resolves `ILoggerFactory`, registered as Scoped, from the provider it was handed — the ROOT provider, outside any scope. The root provider keeps that instance for the life of the process, so the singleton is handed one scoped `ILoggerFactory` forever (ASP.NET Core's scope validation rejects it in Development and lets it through in Production). Create a scope per use (`IServiceScopeFactory.CreateScope()`) and resolve `ILoggerFactory` from the scope's provider, or align the lifetimes.
Dependency-rule violation: Tracing.Application.Zipkin (Application) → Tracing.Infrastructure.Zipkin (Infrastructure) src/Tracing.Application.Zipkin/Tracing.Application.Zipkin.csproj:16— `Tracing.Application.Zipkin` is a Application project but references `Tracing.Infrastructure.Zipkin`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Queueing.Application.RabbitMQ (Application) → Infrastructure.RabbitMQ (Infrastructure) src/Queueing.Application.RabbitMQ/Queueing.Application.RabbitMQ.csproj:15— `Queueing.Application.RabbitMQ` is a Application project but references `Infrastructure.RabbitMQ`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Queueing.Application.RabbitMQ (Application) → Queueing.Infrastructure.RabbitMQ (Infrastructure) src/Queueing.Application.RabbitMQ/Queueing.Application.RabbitMQ.csproj:17— `Queueing.Application.RabbitMQ` is a Application project but references `Queueing.Infrastructure.RabbitMQ`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Queueing.Application.Azure (Application) → Infrastructure.Azure.ServiceBus (Infrastructure) src/Queueing.Application.Azure/Queueing.Application.Azure.csproj:15— `Queueing.Application.Azure` is a Application project but references `Infrastructure.Azure.ServiceBus`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Queueing.Application.Azure (Application) → Infrastructure.Azure (Infrastructure) src/Queueing.Application.Azure/Queueing.Application.Azure.csproj:16— `Queueing.Application.Azure` is a Application project but references `Infrastructure.Azure`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Queueing.Application.Azure (Application) → Queueing.Infrastructure.Azure (Infrastructure) src/Queueing.Application.Azure/Queueing.Application.Azure.csproj:18— `Queueing.Application.Azure` is a Application project but references `Queueing.Infrastructure.Azure`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Operations.Application.Web (Application) → Infrastructure.Azure (Infrastructure) src/Operations.Application.Web/Operations.Application.Web.csproj:30— `Operations.Application.Web` is a Application project but references `Infrastructure.Azure`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Operations.Application.Web (Application) → FileStorage.Infrastructure.Azure (Infrastructure) src/Operations.Application.Web/Operations.Application.Web.csproj:31— `Operations.Application.Web` is a Application project but references `FileStorage.Infrastructure.Azure`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Operations.Application.Web (Application) → FileStorage.Infrastructure.FileSystem (Infrastructure) src/Operations.Application.Web/Operations.Application.Web.csproj:32— `Operations.Application.Web` is a Application project but references `FileStorage.Infrastructure.FileSystem`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Operations.Application.Web (Application) → Utilities.Web (Web) src/Operations.Application.Web/Operations.Application.Web.csproj:35— `Operations.Application.Web` is a Application project but references `Utilities.Web`, a Web project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Messaging.Application.RabbitMQ (Application) → Infrastructure.RabbitMQ (Infrastructure) src/Messaging.Application.RabbitMQ/Messaging.Application.RabbitMQ.csproj:19— `Messaging.Application.RabbitMQ` is a Application project but references `Infrastructure.RabbitMQ`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Messaging.Application.RabbitMQ (Application) → Messaging.Infrastructure.RabbitMQ (Infrastructure) src/Messaging.Application.RabbitMQ/Messaging.Application.RabbitMQ.csproj:22— `Messaging.Application.RabbitMQ` is a Application project but references `Messaging.Infrastructure.RabbitMQ`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Messaging.Application.FileStorage (Application) → FileStorage.Infrastructure.FileSystem (Infrastructure) src/Messaging.Application.FileSystem/Messaging.Application.FileStorage.csproj:16— `Messaging.Application.FileStorage` is a Application project but references `FileStorage.Infrastructure.FileSystem`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Messaging.Application.FileStorage (Application) → Messaging.Infrastructure.FileStorage (Infrastructure) src/Messaging.Application.FileSystem/Messaging.Application.FileStorage.csproj:19— `Messaging.Application.FileStorage` is a Application project but references `Messaging.Infrastructure.FileStorage`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Messaging.Application.Azure (Application) → Messaging.Infrastructure.Azure (Infrastructure) src/Messaging.Application.Azure/Messaging.Application.Azure.csproj:20— `Messaging.Application.Azure` is a Application project but references `Messaging.Infrastructure.Azure`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Messaging.Application.Azure.SignalR (Application) → Messaging.Infrastructure.Azure.SignalR (Infrastructure) src/Messaging.Application.Azure.SignalR/Messaging.Application.Azure.SignalR.csproj:19— `Messaging.Application.Azure.SignalR` is a Application project but references `Messaging.Infrastructure.Azure.SignalR`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
Dependency-rule violation: Application.Web.Startup.EntityFramework (Application) → Infrastructure.EntityFramework (Infrastructure) src/Foundation.Application.Web.Startup.EntityFramework/Application.Web.Startup.EntityFramework.csproj:11— `Application.Web.Startup.EntityFramework` is a Application project but references `Infrastructure.EntityFramework`, a Infrastructure project. The clean-architecture rule is that dependencies point INWARD — the domain/application core must not depend on outer layers (infrastructure/web). Invert it: define the abstraction in the inner layer and implement it in the outer one.
EmptyCatchBlock src/Foundation.Application.Web/Dashboard/HttpResponseExtensions.cs:77— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Foundation.Application.Web/Dashboard/HttpResponseExtensions.cs:94— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Foundation.Domain/Model/DataDictionary.cs:121— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Foundation.Extensions/EnumExtensions.cs:116— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Foundation.Utilities/Expando/Expando.cs:174— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Foundation.Utilities/Expando/Expando.cs:204— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Foundation.Utilities/Expando/Expando.cs:234— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:160— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs:151— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Operations.Application.Web/Controllers/NaosOperationsLogTracesController.cs:116— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Tracing.Infrastructure.Zipkin/ZipkinSpanExporter.cs:165— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/Tracing.Infrastructure.Zipkin/ZipkinSpanExporter.cs:193— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
FileScopedPragmaDisable src/FileStorage/Domain/FileStorageExtensions.cs:20— #pragma warning disable CA2000 // Dispose objects before losing scope — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable src/FileStorage/Domain/FileStorageExtensions.cs:33— #pragma warning disable CA2000 // Dispose objects before losing scope — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable src/Foundation.Infrastructure.Azure.LogAnalytics/Repositories/LogAnalyticsRepository.cs:130— #pragma warning disable CA2000 // Dispose objects before losing scope — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable src/Queueing/InMemoryQueue.cs:280— #pragma warning disable CA2000 // Dispose objects before losing scope — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable tests/Sample/Customers/Application/Commands/GetActiveCustomersQueryHandler.cs:50— #pragma warning disable CA2000 // Dispose objects before losing scope — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable tests/Sample.IntegrationTests/Catalogs/Infrastructure/DocumentRepositoryTests.cs:185— #pragma warning disable CA1307 // Specify StringComparison — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable tests/Sample.IntegrationTests/Catalogs/Infrastructure/SqlServerDocumentProviderTests.cs:300— #pragma warning disable CA1307 // Specify StringComparison — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
Namespace dependency cycle src/Foundation.Domain.EventSourcing/Repositories/EventSourcingRepository.cs:7— The namespaces Naos.Foundation.Domain ↔ Naos.Foundation.Domain.EventSourcing depend on each other. The lightest dependency in the cycle is Naos.Foundation.Domain → Naos.Foundation.Domain.EventSourcing (Naos.Foundation.Domain.EventSourcingRepository → Naos.Foundation.Domain.EventSourcing.IEventStore, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/Tracing.Application/OperationsTracingOptionsExtensions.cs:5— The namespaces Microsoft.Extensions.DependencyInjection ↔ Naos.Operations ↔ Naos.Operations.Application.Web ↔ Naos.Tracing.Application depend on each other. The lightest dependency in the cycle is Microsoft.Extensions.DependencyInjection → Naos.Tracing.Application (Microsoft.Extensions.DependencyInjection.OperationsTracingOptionsExtensions → Naos.Tracing.Application.OperationsTracingOptions, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/JobScheduling/Domain/Services/IJobScheduler.cs:7— The namespaces Naos.JobScheduling ↔ Naos.JobScheduling.Domain depend on each other. The lightest dependency in the cycle is Naos.JobScheduling.Domain → Naos.JobScheduling (Naos.JobScheduling.Domain.IJobScheduler → Naos.JobScheduling.JobSchedulerOptions, 2 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/Messaging/IMessageBroker.cs:3— The namespaces Naos.Messaging ↔ Naos.Messaging.Domain depend on each other. The lightest dependency in the cycle is Naos.Messaging → Naos.Messaging.Domain (Naos.Messaging.IMessageBroker → Naos.Messaging.Domain.Message, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Boundary-crossing change coupling: HttpClientLogHandler.cs ↔ RequestLoggingMiddleware.cs src/Foundation.Application.Web/Client/Handlers/HttpClientLogHandler.cs:1— `src/Foundation.Application.Web/Client/Handlers/HttpClientLogHandler.cs` (context Foundation.Application) and `src/Operations.Application.Web/Middleware/RequestLoggingMiddleware.cs` (context Operations.Application) sit in DIFFERENT parts of the tree yet change together 58% of the time (7 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `c6c857ff` tr (at that commit the file was still `src/Operations.App.Web/Middleware/RequestLoggingMiddleware.cs`); `2ffc2bd7` cc (at that commit the file was still `src/Operations.App.Web/Middleware/RequestLoggingMiddleware.cs`); `90606c46` renames (at that commit the file was still `src/Operations.App.Web/Middleware/RequestLoggingMiddleware.cs`) — run `git show` on any of them.
Boundary-crossing change coupling: NaosOperationsLogEventsController.cs ↔ ServiceContextMiddleware.cs src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs:1— `src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs` (context Operations.Application) and `src/ServiceContext.Application/Web/Middleware/ServiceContextMiddleware.cs` (context ServiceContext) sit in DIFFERENT parts of the tree yet change together 57% of the time (13 of the 23 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets) — the bounded-context boundary may be in the wrong place, or one context is leaking into the other. This is the behavioural boundary violation a static scan can't see. You can check this without leaving the row: of the 13 shared commits counted here, the most recent 3 are `da7e1e71` cc; `b17ada0a` dashboard template abstracted; `fc5c961c` html template + dashboards — run `git show` on any of them.
Query handler raises events: Application.MessagingConsoleCommandEventHandler src/Messaging.Application/Console/MessagingConsoleCommandEventHandler.cs:12— `Application.MessagingConsoleCommandEventHandler` is a read (query) handler but its body raises events — a query must stay side-effect-free so reads are safe to retry, cache, and route to a read replica.
Assertions commented out: CanSendInvalid_Test tests/IntegrationTests/Commands/CommandRequestTests.cs:65— The test body contains commented-out assertion calls and no live one — it runs, verifies nothing, and still passes. Restore the assertions or delete the test; a green test that checks nothing is worse than an absent one.
FileScopedPragmaDisable repeated across 13 files src/Commands.Application.Web/CommandRequestRegistration.cs:63— The identical FileScopedPragmaDisable (`#pragma warning disable SA1402 // File may only contain a single type`) appears in 13 files (13 occurrences) — a single repo-wide policy (e.g. a Directory.Build.props decision or an idiomatic suppression), not 13 independent debts. Decide it once centrally rather than file-by-file. (Every occurrence still counts toward the score and metrics.)
TodoComment src/Application.Web/Controllers/NaosGenericRepositoryControllerBase.cs:35— // TODO: use 2.2 conventions https://blogs.msdn.microsoft.com/webdev/2018/08/23/asp-net-core-2-20-preview1-open-api-analyzers-conventions/
TodoComment src/Application.Web/Controllers/NaosGenericRepositoryControllerBase.cs:68— // TODO: use 2.2 conventions https://blogs.msdn.microsoft.com/webdev/2018/08/23/asp-net-core-2-20-preview1-open-api-analyzers-conventions/
TodoComment src/Application.Web/Controllers/NaosGenericRepositoryControllerBase.cs:94— // TODO: use 2.2 conventions https://blogs.msdn.microsoft.com/webdev/2018/08/23/asp-net-core-2-20-preview1-open-api-analyzers-conventions/
TodoComment src/Application.Web/Controllers/NaosReadOnlyGenericRepositoryControllerBase.cs:39— // TODO: use 2.2 conventions https://blogs.msdn.microsoft.com/webdev/2018/08/23/asp-net-core-2-20-preview1-open-api-analyzers-conventions/
TodoComment src/Application.Web/Controllers/NaosReadOnlyGenericRepositoryControllerBase.cs:57— // TODO: use 2.2 conventions https://blogs.msdn.microsoft.com/webdev/2018/08/23/asp-net-core-2-20-preview1-open-api-analyzers-conventions/
TodoComment src/JobScheduling.Application.Web/Controllers/NaosJobRegistrationsController.cs:36— // TODO: use 2.2 conventions https://blogs.msdn.microsoft.com/webdev/2018/08/23/asp-net-core-2-20-preview1-open-api-analyzers-conventions/
TodoComment src/JobScheduling.Application.Web/Controllers/NaosJobRegistrationsController.cs:49— // TODO: use 2.2 conventions https://blogs.msdn.microsoft.com/webdev/2018/08/23/asp-net-core-2-20-preview1-open-api-analyzers-conventions/
TodoComment src/JobScheduling.Application.Web/Controllers/NaosJobsController.cs:39— // TODO: use 2.2 conventions https://blogs.msdn.microsoft.com/webdev/2018/08/23/asp-net-core-2-20-preview1-open-api-analyzers-conventions/
TodoComment src/ServiceDiscovery.Application.Web.Router/Controllers/NaosServiceDiscoveryRegistrationsController.cs:38— // TODO: use 2.2 conventions https://blogs.msdn.microsoft.com/webdev/2018/08/23/asp-net-core-2-20-preview1-open-api-analyzers-conventions/
TodoComment src/ServiceDiscovery.Application.Web.Router/Controllers/NaosServiceDiscoveryRegistrationsController.cs:51— // TODO: use 2.2 conventions https://blogs.msdn.microsoft.com/webdev/2018/08/23/asp-net-core-2-20-preview1-open-api-analyzers-conventions/
TodoComment src/ServiceDiscovery.Application.Web.Router/Controllers/NaosServiceDiscoveryRegistrationsController.cs:78— // TODO: use 2.2 conventions https://blogs.msdn.microsoft.com/webdev/2018/08/23/asp-net-core-2-20-preview1-open-api-analyzers-conventions/
TodoComment tests/Sample/Countries/Presentation/Web/Controllers/CountriesController.cs:29— // TODO: use 2.2 conventions https://blogs.msdn.microsoft.com/webdev/2018/08/23/asp-net-core-2-20-preview1-open-api-analyzers-conventions/
TodoComment src/Application.Web/Controllers/NaosGenericRepositoryControllerBase.cs:55— // TODO: throw notfoundexception? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Application.Web/Controllers/NaosGenericRepositoryControllerBase.cs:104— // TODO: throw notfoundexception? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Application.Web/Controllers/NaosReadOnlyGenericRepositoryControllerBase.cs:73— // TODO: throw notfoundexception? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/JobScheduling.Application.Web/Controllers/NaosJobRegistrationsController.cs:60— // TODO: throw notfoundexception? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/JobScheduling.Application.Web/Controllers/NaosJobsController.cs:50— // TODO: throw notfoundexception? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/ServiceDiscovery.Application.Web.Router/Controllers/NaosServiceDiscoveryRegistrationsController.cs:88— // TODO: throw notfoundexception? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment tests/Sample/Countries/Presentation/Web/Controllers/CountriesController.cs:40— // TODO: throw notfoundexception? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Application.Web/NaosExtensions.cs:93— // TODO: replace with .AddOpenApiDocument, but currently has issues with example model generation in UI — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Application.Web/NaosExtensions.cs:95— // TODO: AddNaos.AddSwaggerDocument() ^^^^ — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Application.Web/NaosExtensions.cs:178— // TODO: also allow the auth header to be sent in the querystring — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/Application.Web/NaosExtensions.cs:190— // TODO: also allow the auth header to be sent in the url https://en.wikipedia.org/wiki/Basic_access_authentication
TodoComment src/Authentication.Application.Web/ApplicationExtensions.cs:58— // TODO: register other middleware for different authentication schemes (easyauth?) — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
Deprecated: Microsoft.CodeAnalysis.FxCopAnalyzers Directory.Build.props:37— Microsoft.CodeAnalysis.FxCopAnalyzers 3.3.0 — Legacy — the publisher's replacement is `Microsoft.CodeAnalysis.NetAnalyzers`; migrate the reference to it.
Deprecated: SecurityCodeScan Directory.Build.props:43— SecurityCodeScan 3.5.3 — Legacy — the publisher's replacement is `SecurityCodeScan.VS2019`; migrate the reference to it.
Deprecated: Microsoft.Azure.DocumentDB.Core src/Foundation.Infrastructure.Azure.Cosmos/Infrastructure.Azure.Cosmos.csproj:11— Microsoft.Azure.DocumentDB.Core 2.11.0 — Legacy — the publisher's replacement is `Microsoft.Azure.Cosmos`; migrate the reference to it.
Deprecated: Microsoft.IdentityModel.Clients.ActiveDirectory src/Foundation.Infrastructure.Azure.LogAnalytics/Infrastructure.Azure.LogAnalytics.csproj:14— Microsoft.IdentityModel.Clients.ActiveDirectory 5.2.7 — Legacy — the publisher's replacement is `Microsoft.Identity.Client`; migrate the reference to it.
Deprecated: Microsoft.IdentityModel.Clients.ActiveDirectory src/Operations.Infrastructure.Azure/Operations.Infrastructure.Azure.csproj:19— Microsoft.IdentityModel.Clients.ActiveDirectory 5.2.7 — Legacy — the publisher's replacement is `Microsoft.Identity.Client`; migrate the reference to it.
Deprecated: Microsoft.IdentityModel.Clients.ActiveDirectory src/Tracing.Infrastructure.Azure/Tracing.Infrastructure.Azure.csproj:13— Microsoft.IdentityModel.Clients.ActiveDirectory 5.2.7 — Legacy — the publisher's replacement is `Microsoft.Identity.Client`; migrate the reference to it.
Deprecated: xunit tests/UnitTests/UnitTests.csproj:39— xunit 2.4.1 — Legacy — the publisher's replacement is `xunit.v3`; that is the next major line under a new package id, so the move is a breaking rename rather than a version bump — budget for API changes in the code that uses it, not only the reference swap.
CoverageExclusion src/Application.Web/NaosExtensions.cs:16— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Authentication.Application.Web/NaosExtensions.cs:13— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Commands.Application.Web/NaosExtensions.cs:11— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Commands.Application/NaosExtensions.cs:10— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Configuration.Application/NaosExtensions.cs:14— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Correlation.Application/NaosExtensions.cs:13— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Exceptions.Application.Web/NaosExtensions.cs:10— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Filtering.Application/NaosExtensions.cs:10— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/JobScheduling.Application/NaosExtensions.cs:16— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Messaging.Application.Azure.SignalR/NaosExtensions.cs:19— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Messaging.Application.Azure/NaosExtensions.cs:21— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Messaging.Application.FileSystem/NaosExtensions.cs:20— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Messaging.Application.RabbitMQ/NaosExtensions.cs:20— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Messaging.Application/NaosExtensions.cs:13— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Operations.Application/NaosExtensions.cs:10— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Operations.Infrastructure.Azure/NaosExtensions.cs:12— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Operations.Infrastructure.Mongo/NaosExtensions.cs:14— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Queueing.Application.Azure/NaosExtensions.cs:16— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Queueing.Application.RabbitMQ/NaosExtensions.cs:17— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Queueing.Application.Web/NaosExtensions.cs:10— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/Queueing.Application/NaosExtensions.cs:16— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/ServiceContext.Application/NaosExtensions.cs:13— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/ServiceDiscovery.Application.Consul/NaosExtensions.cs:19— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/ServiceDiscovery.Application.Web.Router/NaosExtensions.cs:18— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
CoverageExclusion src/ServiceDiscovery.Application/NaosExtensions.cs:20— class NaosExtensions — this shipped code is lifted out of the coverage measurement, so it is not that the code is reported as untested: it is not reported at all. The excluded lines leave the denominator, which means the percentage the team publishes goes UP when code stops being covered, and the gap is invisible in the artefact that would otherwise disclose it. Nothing here is written by a compiler or a build — the attribute is only ever typed by an author — so it is a standing decision, and the only record of it is this line. Test what it covers and delete the attribute; where the code genuinely cannot be exercised (a debugger display, a platform branch this build cannot reach), narrow the exclusion to the smallest declaration that is really untestable rather than the type around it, so members added later are not silently excluded too. If it is correct as it stands, say why — in the attribute's own Justification, or in a comment above it: that is what turns it from unexplained debt into a recorded decision, and it clears this row.
Unfinished stub — throws NotImplementedException src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V3/CosmosSqlProviderV3.cs:171— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Foundation.Infrastructure.Azure.LogAnalytics/Repositories/LogAnalyticsRepository.cs:93— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Foundation.Infrastructure.Azure.LogAnalytics/Repositories/LogAnalyticsRepository.cs:98— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Foundation.Infrastructure.Azure.LogAnalytics/Repositories/LogAnalyticsRepository.cs:103— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Messaging.Infrastructure.Azure/Storage/StorageQueueMessageBroker.cs:35— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Messaging.Infrastructure.Azure/Storage/StorageQueueMessageBroker.cs:47— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Configuration.Application/CachedKeyVaultClient.cs:48— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Configuration.Application/CachedKeyVaultClient.cs:57— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/JobScheduling/Domain/Services/DistributedMutext.cs:27— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/JobScheduling/Domain/Services/DistributedMutext.cs:32— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:130— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/ServiceDiscovery.Application/Registries/RouterServiceRegistry.cs:49— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/ServiceDiscovery.Application/Registries/RpcRouterServiceRegistry.cs:9— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/ServiceDiscovery.Application/Registries/RpcRouterServiceRegistry.cs:14— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/ServiceDiscovery.Application/Registries/RpcRouterServiceRegistry.cs:20— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/ServiceDiscovery.Application.Web.Router/Services/RpcRouterService.cs:18— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/ServiceDiscovery.Application.Web.Router/Services/RpcRouterService.cs:23— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/ServiceDiscovery.Application.Web.Router/Services/RpcRouterService.cs:28— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage/Provider/FileStorageFileInfo.cs:25— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage/Provider/FileStorageProvider.cs:21— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:141— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:12— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:14— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:19— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:24— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
+ 15 more in this group — see findings.md.
X2 · Cancellation propagation· Async method without CancellationToken · ×39
Async method without CancellationToken: Put src/Application.Web/Controllers/NaosGenericRepositoryControllerBase.cs:36— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Post src/Application.Web/Controllers/NaosGenericRepositoryControllerBase.cs:69— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Delete src/Application.Web/Controllers/NaosGenericRepositoryControllerBase.cs:95— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: FindAll src/Application.Web/Controllers/NaosReadOnlyGenericRepositoryControllerBase.cs:40— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: FindOne src/Application.Web/Controllers/NaosReadOnlyGenericRepositoryControllerBase.cs:58— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: LogHttpRequest src/Foundation.Application.Web/Client/Handlers/HttpClientLogHandler.cs:53— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: LogHttpResponse src/Foundation.Application.Web/Client/Handlers/HttpClientLogHandler.cs:70— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: SendAsync src/Foundation.Application.Web/Console/Commands/OpenBrowserConsoleCommand.cs:22— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: WriteNaosDashboard src/Foundation.Application.Web/Dashboard/HttpResponseExtensions.cs:12— No CancellationToken parameter, and the token `source.HttpContext.RequestAborted` carries reaches none of the calls here that take one — this work can't be stopped early once started. Pass `source.HttpContext.RequestAborted` on, or take a CancellationToken.
Async method without CancellationToken: ReadAsAsync src/Foundation.Application.Web/Extensions/HttpResponseMessageExtensions.cs:144— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: DispatchAsync src/Foundation.Domain/Model/DomainEvents.cs:32— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: FindOneAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:70— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ExistsAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:80— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: InsertAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:94— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: UpdateAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:104— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: UpsertAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:114— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: DeleteAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:173— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: DeleteAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:189— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: FindOneAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:64— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ExistsAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:74— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: InsertAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:88— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: UpdateAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:98— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: UpsertAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:108— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: DeleteAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:166— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: DeleteAsync src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:182— No CancellationToken parameter — this work can't be stopped early once started.
Unfinished stub — throws NotImplementedException src/Configuration.Application/CachedKeyVaultClient.cs:48— `GetSecretsWithHttpMessagesAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Configuration.Application/CachedKeyVaultClient.cs:57— `GetSecretWithHttpMessagesAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:141— `RenameFileAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:12— `Serializer` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:14— `CopyFileAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:19— `DeleteFileAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:24— `DeleteFilesAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:29— `Dispose` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:34— `ExistsAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:39— `GetFileInformationAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:44— `GetFileInformationsAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:49— `GetFileStreamAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:54— `RenameFileAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:59— `SaveFileAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.FileSystem/EmbeddedFileStorage.cs:85— `SaveFileAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.FileSystem/EmbeddedFileStorage.cs:90— `RenameFileAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.FileSystem/EmbeddedFileStorage.cs:95— `CopyFileAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.FileSystem/EmbeddedFileStorage.cs:100— `DeleteFileAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage.Infrastructure.FileSystem/EmbeddedFileStorage.cs:105— `DeleteFilesAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage/Provider/FileStorageFileInfo.cs:25— `Length` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/FileStorage/Provider/FileStorageProvider.cs:21— `GetDirectoryContents` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Foundation.Domain.EventSourcing/Repositories/EventStore/InMemoryEventStore.cs:32— `ReadSnapshotAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Foundation.Domain.EventSourcing/Repositories/EventStore/InMemoryEventStore.cs:38— `SaveSnapshotAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V3/CosmosSqlProviderV3.cs:171— `WhereAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/Foundation.Infrastructure.Azure.LogAnalytics/Repositories/LogAnalyticsRepository.cs:93— `CountAsync` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Dependency-rule violation: Tracing.Application.Zipkin (Application) → Tracing.Infrastructure.Zipkin (Infrastructure) src/Tracing.Application.Zipkin/OperationsTracingOptionsExtensions.cs:12— This Application file depends on the Infrastructure project `Tracing.Infrastructure.Zipkin`: it names `Naos.Tracing.Infrastructure`, `ZipkinSpanExporterConfiguration`, `ZipkinSpanExporter`. The inward dependency rule is broken here. It is named again on lines 23, 27, 28, 36. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Queueing.Application.RabbitMQ (Application) → Infrastructure.RabbitMQ (Infrastructure) src/Queueing.Application.RabbitMQ/NaosExtensions.cs:10— This Application file depends on the Infrastructure project `Infrastructure.RabbitMQ`: it names `Naos.Foundation.Infrastructure`, `RabbitMQConfiguration`. The inward dependency rule is broken here. It is named again on line 32. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Queueing.Application.RabbitMQ (Application) → Queueing.Infrastructure.RabbitMQ (Infrastructure) src/Queueing.Application.RabbitMQ/NaosExtensions.cs:13— This Application file depends on the Infrastructure project `Queueing.Infrastructure.RabbitMQ`: it names `Naos.Queueing.Infrastructure`, `RabbitMQProvider`, `RabbitMQQueue`. The inward dependency rule is broken here. It is named again on lines 47, 48, 53, 69. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Queueing.Application.Azure (Application) → Infrastructure.Azure.ServiceBus (Infrastructure) src/Queueing.Application.Azure/NaosExtensions.cs:31— This Application file depends on the Infrastructure project `Infrastructure.Azure.ServiceBus`: it names `ServiceBusConfiguration`. The inward dependency rule is broken here. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Queueing.Application.Azure (Application) → Infrastructure.Azure (Infrastructure) src/Queueing.Application.Azure/NaosExtensions.cs:74— This Application file depends on the Infrastructure project `Infrastructure.Azure`: it names `QueueStorageConfiguration`. The inward dependency rule is broken here. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Queueing.Application.Azure (Application) → Queueing.Infrastructure.Azure (Infrastructure) src/Queueing.Application.Azure/NaosExtensions.cs:13— This Application file depends on the Infrastructure project `Queueing.Infrastructure.Azure`: it names `Naos.Queueing.Infrastructure.Azure`, `AzureServiceBusQueue`, `AzureStorageQueue`. The inward dependency rule is broken here. It is named again on lines 36, 52, 79, 95. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Operations.Application.Web (Application) → Infrastructure.Azure (Infrastructure) src/Operations.Application.Web/RequestStorageOptionsExtensions.cs:48— This Application file depends on the Infrastructure project `Infrastructure.Azure`: it names `BlobStorageConfiguration`. The inward dependency rule is broken here. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Operations.Application.Web (Application) → FileStorage.Infrastructure.Azure (Infrastructure) src/Operations.Application.Web/RequestStorageOptionsExtensions.cs:9— This Application file depends on the Infrastructure project `FileStorage.Infrastructure.Azure`: it names `Naos.FileStorage.Infrastructure`, `AzureBlobFileStorage`. The inward dependency rule is broken here. It is named again on lines 51, 60. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Operations.Application.Web (Application) → FileStorage.Infrastructure.FileSystem (Infrastructure) src/Operations.Application.Web/RequestStorageOptionsExtensions.cs:9— This Application file depends on the Infrastructure project `FileStorage.Infrastructure.FileSystem`: it names `Naos.FileStorage.Infrastructure`, `FolderFileStorage`. The inward dependency rule is broken here. It is named again on lines 27, 34. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Operations.Application.Web (Application) → Utilities.Web (Web) src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:12— This Application file depends on the Web project `Utilities.Web`: it names `Naos.Foundation`. The inward dependency rule is broken here. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Operations.Application.Web (Application) → Utilities.Web (Web) src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs:12— This Application file depends on the Web project `Utilities.Web`: it names `Naos.Foundation`. The inward dependency rule is broken here. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Operations.Application.Web (Application) → Utilities.Web (Web) src/Operations.Application.Web/Controllers/NaosOperationsLogTracesController.cs:13— This Application file depends on the Web project `Utilities.Web`: it names `Naos.Foundation`, `HtmlNodeRenderOptions`. The inward dependency rule is broken here. It is named again on line 114. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Operations.Application.Web (Application) → Utilities.Web (Web) src/Operations.Application.Web/Health/HealthReportResponseWriter.cs:10— This Application file depends on the Web project `Utilities.Web`: it names `Naos.Foundation`. The inward dependency rule is broken here. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Operations.Application.Web (Application) → Utilities.Web (Web) src/Operations.Application.Web/Health/SystemCpuHealthCheck.cs:7— This Application file depends on the Web project `Utilities.Web`: it names `Naos.Foundation`. The inward dependency rule is broken here. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Operations.Application.Web (Application) → Utilities.Web (Web) src/Operations.Application.Web/Health/SystemMemoryHealthCheck.cs:7— This Application file depends on the Web project `Utilities.Web`: it names `Naos.Foundation`. The inward dependency rule is broken here. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Operations.Application.Web (Application) → Utilities.Web (Web) src/Operations.Application.Web/Middleware/RequestLoggingMiddleware.cs:13— This Application file depends on the Web project `Utilities.Web`: it names `Naos.Foundation`. The inward dependency rule is broken here. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Operations.Application.Web (Application) → Utilities.Web (Web) src/Operations.Application.Web/Middleware/RequestStorageMiddleware.cs:9— This Application file depends on the Web project `Utilities.Web`: it names `Naos.Foundation`. The inward dependency rule is broken here. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Messaging.Application.RabbitMQ (Application) → Infrastructure.RabbitMQ (Infrastructure) src/Messaging.Application.RabbitMQ/NaosExtensions.cs:12— This Application file depends on the Infrastructure project `Infrastructure.RabbitMQ`: it names `Naos.Foundation.Infrastructure`, `RabbitMQConfiguration`. The inward dependency rule is broken here. It is named again on line 37. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Messaging.Application.RabbitMQ (Application) → Messaging.Infrastructure.RabbitMQ (Infrastructure) src/Messaging.Application.RabbitMQ/NaosExtensions.cs:52— This Application file depends on the Infrastructure project `Messaging.Infrastructure.RabbitMQ`: it names `RabbitMQMessageBroker`, `RabbitMQProvider`. The inward dependency rule is broken here. It is named again on lines 63, 64, 103. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Messaging.Application.FileStorage (Application) → FileStorage.Infrastructure.FileSystem (Infrastructure) src/Messaging.Application.FileSystem/NaosExtensions.cs:12— This Application file depends on the Infrastructure project `FileStorage.Infrastructure.FileSystem`: it names `Naos.FileStorage.Infrastructure`, `FolderFileStorage`. The inward dependency rule is broken here. It is named again on line 45. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Messaging.Application.FileStorage (Application) → Messaging.Infrastructure.FileStorage (Infrastructure) src/Messaging.Application.FileSystem/NaosExtensions.cs:17— This Application file depends on the Infrastructure project `Messaging.Infrastructure.FileStorage`: it names `Naos.Messaging.Infrastructure`, `FileStorageConfiguration`, `FileStorageMessageBroker`. The inward dependency rule is broken here. It is named again on lines 32, 38, 60. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Messaging.Application.Azure (Application) → Messaging.Infrastructure.Azure (Infrastructure) src/Messaging.Application.Azure/NaosExtensions.cs:52— This Application file depends on the Infrastructure project `Messaging.Infrastructure.Azure`: it names `ServiceBusMessageBroker`. The inward dependency rule is broken here. It is named again on lines 73, 104, 127. Depend on an abstraction the inner layer owns, implemented in the outer one.
Dependency-rule violation: Messaging.Application.Azure.SignalR (Application) → Messaging.Infrastructure.Azure.SignalR (Infrastructure) src/Messaging.Application.Azure.SignalR/NaosExtensions.cs:16— This Application file depends on the Infrastructure project `Messaging.Infrastructure.Azure.SignalR`: it names `Naos.Messaging.Infrastructure.Azure`, `SignalRServerlessMessageBroker`. The inward dependency rule is broken here. It is named again on lines 37, 58. Depend on an abstraction the inner layer owns, implemented in the outer one.
Sync-over-async blocking — 18 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:201— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:70— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:149— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:156— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:180— `.GetAwaiter() .GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:63— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:125— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:52— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:53— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:83— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:151— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:163— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:173— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Messaging.Application.Azure/NaosExtensions.cs:61— `.GetAwaiter() .GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:168— `.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs:156— `.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/Operations.Application.Web/Controllers/NaosOperationsLogTracesController.cs:125— `.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs:253— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async (deadlock risk) through `.Result` src/Application.Web/NaosExtensions.cs:136— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/Application.Web/NaosExtensions.cs:172— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/Application.Web/NaosExtensions.cs:183— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:70— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:72— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:94— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V3/CosmosSqlProviderV3.cs:279— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V3/CosmosSqlProviderV3.cs:282— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:116— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:244— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/ServiceDiscovery.Application/Client/ServiceDiscoveryClient.cs:47— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/Authentication.Application.Web/ApplicationExtensions.cs:52— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/Authentication.Application.Web/ApplicationExtensions.cs:72— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:94— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs:101— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/Operations.Application.Web/Controllers/NaosOperationsLogTracesController.cs:105— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/FileStorage/Provider/FileStorageDirectoryContents.cs:23— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/FileStorage/Provider/FileStorageFileInfo.cs:20— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
Sync-over-async (deadlock risk) through `.Result` src/FileStorage/Provider/FileStorageFileInfo.cs:42— Reading `.Result` of a task that has not completed blocks this thread until it does — the same block as `.Wait()`: under a synchronization context (Blazor, a UI thread, classic ASP.NET) it deadlocks, and on the thread pool it parks a thread for as long as the work runs. `await` the task instead (make the caller `async`); where a synchronous entry point must stay, keep the block in ONE documented bridge with a timeout.
X5 · Nullable reference types· Symbol treated as nullable, then dereferenced unguarded · ×18
Symbol treated as nullable, then dereferenced unguarded src/Foundation.Domain/Model/Entity.cs:116— This method contradicts itself about `other`: line 104 assigns it with `as Entity<TId>`, which hands back null rather than throwing when the value is not a `Entity<TId>`, but line 116 then dereferences it directly as `other.GetType` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `other` once before the first use and handle the null case, or cast with `(Entity<TId>)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:366— This method contradicts itself about `message`: line 369 writes `message?.Id`, which says `message` can be null, but line 366 then dereferences it directly as `message.Origin` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `message` truly cannot be null here, the `?.` is misleading. Settle it one way — test `message` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:262— This method contradicts itself about `message`: line 269 writes `message?.Id`, which says `message` can be null, but line 262 then dereferences it directly as `message.Origin` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `message` truly cannot be null here, the `?.` is misleading. Settle it one way — test `message` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Filtering.Application/Web/Middleware/RequestFilterMiddleware.cs:52— This method contradicts itself about `context`: line 49 writes `context?.Request`, which says `context` can be null, but line 52 then dereferences it directly as `context.GetRequestId` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `context` truly cannot be null here, the `?.` is misleading. Settle it one way — test `context` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:164— This method contradicts itself about `message`: line 185 writes `message?.Id`, which says `message` can be null, but line 164 then dereferences it directly as `message.Origin` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `message` truly cannot be null here, the `?.` is misleading. Settle it one way — test `message` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:203— This method contradicts itself about `message`: line 215 writes `message?.Id`, which says `message` can be null, but line 203 then dereferences it directly as `message.Properties` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `message` truly cannot be null here, the `?.` is misleading. Settle it one way — test `message` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/ServiceContext.Application/Web/Middleware/ServiceContextMiddleware.cs:49— This method contradicts itself about `serviceDescriptor`: line 64 writes `serviceDescriptor?.ToString`, which says `serviceDescriptor` can be null, but line 49 then dereferences it directly as `serviceDescriptor.Product` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `serviceDescriptor` truly cannot be null here, the `?.` is misleading. Settle it one way — test `serviceDescriptor` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Authentication.Application.Web/NaosExtensions.cs:95— This method contradicts itself about `options`: line 91 writes `options?.Invoke`, which says `options` can be null, but line 95 then dereferences it directly as `options.DefaultScheme` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `options` truly cannot be null here, the `?.` is misleading. Settle it one way — test `options` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Queueing/InMemoryQueue.cs:89— This method contradicts itself about `addItem`: line 84 assigns it with `as QueueItem<TData>`, which hands back null rather than throwing when the value is not a `QueueItem<TData>`, but line 89 then dereferences it directly as `addItem.RenewedDate` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `addItem` once before the first use and handle the null case, or cast with `(QueueItem<TData>)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Queueing.Application.Web/Controllers/NaosQueuesController.cs:70— This method contradicts itself about `queue`: line 69 assigns it with `as IQueue`, which hands back null rather than throwing when the value is not a `IQueue`, but line 70 then dereferences it directly as `queue.GetMetricsAsync` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `queue` once before the first use and handle the null case, or cast with `(IQueue)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Foundation.Utilities/Expando/Expando.cs:384— This method contradicts itself about `member`: line 383 assigns it with `as MethodInfo`, which hands back null rather than throwing when the value is not a `MethodInfo`, but line 384 then dereferences it directly as `member.Invoke` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `member` once before the first use and handle the null case, or cast with `(MethodInfo)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Foundation.Utilities/Pipeline/Pipeline.cs:40— This method contradicts itself about `firstStep`: line 37 assigns it with `as IPipelineStep<TPipeIn>`, which hands back null rather than throwing when the value is not a `IPipelineStep<TPipeIn>`, but line 40 then dereferences it directly as `firstStep.Buffer` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `firstStep` once before the first use and handle the null case, or cast with `(IPipelineStep<TPipeIn>)` so the failure is reported where it happens — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Commands.Application.Web/CommandRequestDocumentProcessor.cs:87— This method contradicts itself about `items`: line 89 writes `items?.Add`, which says `items` can be null, but line 87 then dereferences it directly as `items.ContainsKey` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `items` truly cannot be null here, the `?.` is misleading. Settle it one way — test `items` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Commands.Application.Web/Middleware/Extensions/MediatorDispatcherCommandRequestExtension.cs:32— This method contradicts itself about `registration`: line 42 writes `registration?.OnSuccess`, which says `registration` can be null, but line 32 then dereferences it directly as `registration.CommandType` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `registration` truly cannot be null here, the `?.` is misleading. Settle it one way — test `registration` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Commands.Application.Web/Middleware/Extensions/MediatorDispatcherCommandRequestExtension.cs:65— This method contradicts itself about `registration`: line 73 writes `registration?.OnSuccess`, which says `registration` can be null, but line 65 then dereferences it directly as `registration.CommandType` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `registration` truly cannot be null here, the `?.` is misleading. Settle it one way — test `registration` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs:86— This method contradicts itself about `indexMaps`: line 107 writes `indexMaps?.Select`, which says `indexMaps` can be null, but line 86 then dereferences it directly as `indexMaps.IsNullOrEmpty` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `indexMaps` truly cannot be null here, the `?.` is misleading. Settle it one way — test `indexMaps` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs:238— This method contradicts itself about `indexMaps`: line 244 writes `indexMaps?.Select`, which says `indexMaps` can be null, but line 238 then dereferences it directly as `indexMaps.IsNullOrEmpty` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `indexMaps` truly cannot be null here, the `?.` is misleading. Settle it one way — test `indexMaps` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Symbol treated as nullable, then dereferenced unguarded REDACTED:720— This method contradicts itself about `tags`: line 691 writes `tags?.ToString`, which says `tags` can be null, but line 720 then dereferences it directly as `tags.Safe` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `tags` truly cannot be null here, the `?.` is misleading. Settle it one way — test `tags` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side.
Sync-over-async (deadlock risk) src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:201— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:66— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:149— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:156— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:178— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:63— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:125— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:52— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
Sync-over-async (deadlock risk) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:53— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` wastes a thread and, if the task needs a context this one is holding, deadlocks. `Dispose()` returns void by contract, so it cannot simply `await`: signal the work to stop first (cancel its token, set its stop flag) so the wait is short, give the wait a TIMEOUT so a hung task cannot hang shutdown, and — where callers can use it — add an awaitable teardown (`DisposeAsync`/`StopAsync`) beside the synchronous one and let `Dispose()` remain the bounded fallback.
Sync-over-async (deadlock risk) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:83— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:151— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:163— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:173— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Messaging.Application.Azure/NaosExtensions.cs:59— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:88— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs:96— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Sync-over-async (deadlock risk) src/Operations.Application.Web/Controllers/NaosOperationsLogTracesController.cs:100— Blocking on a Task with `.Wait()`/`.GetAwaiter().GetResult()` can deadlock (and wastes a thread). Prefer awaiting it: make the caller `async` and `await` instead. Where a synchronous entry point must stay — a public sync API you cannot break, or a process entry point that must not return until the work finishes — the block belongs in ONE documented bridge and never inside code that is already async; and where it already is that bridge, give the wait a TIMEOUT so a hung task fails the call instead of hanging the process.
Duplicated block (7 lines × 2) src/Foundation.Domain.Repositories/Decorators/RepositoryLoggingDecorator.cs:82— src/Foundation.Domain.Repositories/Decorators/RepositoryLoggingDecorator.cs:82-88 | src/Foundation.Domain.Repositories/Decorators/RepositoryLoggingDecorator.cs:99-105 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Domain.Repositories/Decorators/RepositoryLoggingDecorator.cs:82` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (7 lines × 2) src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs:212— src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs:212-218 | src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:279-285 — before extracting anything, compare `src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs` and `src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs:212` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/Foundation.Utilities/EncryptionHelper.cs:24— src/Foundation.Utilities/EncryptionHelper.cs:24-30 | src/Foundation.Utilities/EncryptionHelper.cs:70-76 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `data` to `string` in one and `byte[]` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (7 lines × 2) src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:57— src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:57-63 | src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:52-58 — before extracting anything, compare `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs` and `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 94 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:57` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/KeyValueStorage/Domain/Extensions.cs:24— src/KeyValueStorage/Domain/Extensions.cs:24-30 | src/KeyValueStorage/Domain/Extensions.cs:36-42 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/KeyValueStorage/Domain/Extensions.cs:24` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:157— src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:157-163 | src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs:147-153 — before extracting anything, compare `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs` and `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 120 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:157` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:236— src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:236-242 | src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs:227-233 — before extracting anything, compare `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs` and `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 120 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:236` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 2) src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:78— src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:78-84 | src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:91-97 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:78` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:85` calls `OrderByIf` and `src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:98` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 2) src/Configuration.Application.Web/NaosExtensions.cs:40— src/Configuration.Application.Web/NaosExtensions.cs:40-46 | src/Configuration.Application/NaosExtensions.cs:120-126 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Configuration.Application.Web/NaosExtensions.cs:40` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (7 lines × 2) src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/OrderByIf.cs:57— src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/OrderByIf.cs:57-63 | src/Foundation.Infrastructure.Mongo/Repositories/Extensions/OrderByIf.cs:57-63 — before extracting anything, compare `src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/OrderByIf.cs` and `src/Foundation.Infrastructure.Mongo/Repositories/Extensions/OrderByIf.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 38 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/OrderByIf.cs:57` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (7 lines × 2) src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:164— src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:164-170 | src/Queueing/InMemoryQueue.cs:168-174 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs` and `src/Queueing/InMemoryQueue.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 156 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:164` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (7 lines × 2) src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:55— src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:55-61 | src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs:51-57 — before extracting anything, compare `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs` and `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 120 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 2) src/Foundation.Domain.Repositories.Documents/DocumentRepository.cs:76— src/Foundation.Domain.Repositories.Documents/DocumentRepository.cs:76-82 | src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs:84-90 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Off the main sequence: Infrastructure.Azure src/Foundation.Infrastructure.Azure/Infrastructure.Azure.csproj:1— Infrastructure.Azure: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 6 project(s), so it's rigid to change.
Off the main sequence: Extensions src/Foundation.Extensions/Extensions.csproj:1— Extensions: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 21 project(s), so it's rigid to change.
Off the main sequence: Infrastructure.RabbitMQ src/Foundation.Infrastructure.RabbitMQ/Infrastructure.RabbitMQ.csproj:1— Infrastructure.RabbitMQ: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 3 project(s), so it's rigid to change.
Off the main sequence: ContentTypes src/Foundation.ContentTypes/ContentTypes.csproj:1— ContentTypes: abstractness 0.00, instability 0.13, distance 0.88 — zone of pain — concrete and depended on by 5 project(s), so it's rigid to change.
Off the main sequence: Messaging.Application.Web src/Messaging.Application.Web/Messaging.Application.Web.csproj:1— Messaging.Application.Web: abstractness 0.00, instability 0.14, distance 0.86 — zone of pain — concrete and depended on by 5 project(s), so it's rigid to change.
Off the main sequence: Criteria src/Foundation.Criteria/Criteria.csproj:1— Criteria: abstractness 0.00, instability 0.14, distance 0.86 — zone of pain — concrete and depended on by 5 project(s), so it's rigid to change.
Off the main sequence: Serialization src/Foundation.Serialization/Serialization.csproj:1— Serialization: abstractness 0.10, instability 0.07, distance 0.83 — zone of pain — concrete and depended on by 13 project(s), so it's rigid to change.
Off the main sequence: Application.Web(netcoreapp3.1) (src/Foundation.Application.Web) src/Foundation.Application.Web/Application.Web.csproj:1— Application.Web(netcoreapp3.1) (src/Foundation.Application.Web): abstractness 0.00, instability 0.19, distance 0.81 — zone of pain — concrete and depended on by 15 project(s), so it's rigid to change.
Off the main sequence: Configuration.Application src/Configuration.Application/Configuration.Application.csproj:1— Configuration.Application: abstractness 0.08, instability 0.12, distance 0.80 — zone of pain — concrete and depended on by 23 project(s), so it's rigid to change.
Off the main sequence: Utilities src/Foundation.Utilities/Utilities.csproj:1— Utilities: abstractness 0.08, instability 0.13, distance 0.80 — zone of pain — concrete and depended on by 10 project(s), so it's rigid to change.
Off the main sequence: Infrastructure.Azure.ServiceBus src/Foundation.Infrastructure.Azure.ServiceBus/Infrastructure.Azure.ServiceBus.csproj:1— Infrastructure.Azure.ServiceBus: abstractness 0.25, instability 0.00, distance 0.75 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
Off the main sequence: Logging src/Foundation.Logging/Logging.csproj:1— Logging: abstractness 0.00, instability 0.25, distance 0.75 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
Swallowed exception (empty catch) src/Foundation.Application.Web/Dashboard/HttpResponseExtensions.cs:77— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Foundation.Application.Web/Dashboard/HttpResponseExtensions.cs:94— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Foundation.Domain/Model/DataDictionary.cs:121— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:160— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs:151— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Operations.Application.Web/Controllers/NaosOperationsLogTracesController.cs:116— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Foundation.Extensions/EnumExtensions.cs:116— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Foundation.Utilities/Expando/Expando.cs:174— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Foundation.Utilities/Expando/Expando.cs:204— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Foundation.Utilities/Expando/Expando.cs:234— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Tracing.Infrastructure.Zipkin/ZipkinSpanExporter.cs:165— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/Tracing.Infrastructure.Zipkin/ZipkinSpanExporter.cs:193— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Duplicated block (5 lines × 2) src/Commands.Application.Web.RabbitMQ/CommandRequestOptionsExtensions.cs:41— src/Commands.Application.Web.RabbitMQ/CommandRequestOptionsExtensions.cs:41-45 | src/Queueing.Application.RabbitMQ/NaosExtensions.cs:47-51 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) src/Foundation.Domain/Events/Handlers/EntityInsertDomainEventHandler.cs:20— src/Foundation.Domain/Events/Handlers/EntityInsertDomainEventHandler.cs:20-24 | src/Foundation.Domain/Events/Handlers/EntityUpdateDomainEventHandler.cs:20-24 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Domain/Events/Handlers/EntityInsertDomainEventHandler.cs:20` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `notification` to `EntityInsertDomainEvent` in one and `EntityUpdateDomainEvent` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (5 lines × 2) src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:24— src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:24-28 | src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs:21-25 — before extracting anything, compare `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs` and `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 120 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:29` calls `IsNotNull`, `nameof` and `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs:27` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 2) src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/SkipIf.cs:13— src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/SkipIf.cs:13-17 | src/Foundation.Infrastructure.Mongo/Repositories/Extensions/SkipIf.cs:13-17 — before extracting anything, compare `src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/SkipIf.cs` and `src/Foundation.Infrastructure.Mongo/Repositories/Extensions/SkipIf.cs` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (5 lines × 2) src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/TakeIf.cs:13— src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/TakeIf.cs:13-17 | src/Foundation.Infrastructure.Mongo/Repositories/Extensions/TakeIf.cs:13-17 — before extracting anything, compare `src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/TakeIf.cs` and `src/Foundation.Infrastructure.Mongo/Repositories/Extensions/TakeIf.cs` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (5 lines × 2) src/Foundation.Domain.Repositories/Decorators/RepositorySpecificationDecorator.cs:64— src/Foundation.Domain.Repositories/Decorators/RepositorySpecificationDecorator.cs:64-68 | src/Foundation.Domain.Repositories/Decorators/RepositoryStateSoftDeleteDecorator.cs:82-86 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) src/Foundation.Domain.Repositories/Decorators/RepositorySpecificationDecorator.cs:72— src/Foundation.Domain.Repositories/Decorators/RepositorySpecificationDecorator.cs:72-76 | src/Foundation.Domain.Repositories/Decorators/RepositoryStateSoftDeleteDecorator.cs:90-94 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) src/Foundation.Domain.Repositories/Decorators/RepositorySpecificationDecorator.cs:128— src/Foundation.Domain.Repositories/Decorators/RepositorySpecificationDecorator.cs:128-132 | src/Foundation.Domain.Repositories/Decorators/RepositoryStateSoftDeleteDecorator.cs:146-150 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (5 lines × 2) src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:198— src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:198-202 | src/Queueing/InMemoryQueue.cs:199-203 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs` and `src/Queueing/InMemoryQueue.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 156 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) src/KeyValueStorage.Infrastructure.Azure/TableKeyValueStorage.cs:85— src/KeyValueStorage.Infrastructure.Azure/TableKeyValueStorage.cs:85-89 | src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:73-77 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (5 lines × 2) src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:141— src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:141-145 | src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:152-156 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:152` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `Domain.Message` in one and `Message` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
X18 · Disposal-pattern correctness· DI scope created and never disposed · ×11
DI scope created and never disposed src/Messaging.Application.Azure/NaosExtensions.cs:75— `sp.CreateScope()` (line 75) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`.
DI scope created and never disposed src/Messaging.Application.Azure/NaosExtensions.cs:80— `sp.CreateScope()` (line 80) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`.
DI scope created and never disposed src/Messaging.Application.Azure.SignalR/NaosExtensions.cs:40— `sp.CreateScope()` (line 40) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`.
DI scope created and never disposed src/Messaging.Application.FileSystem/NaosExtensions.cs:41— `sp.CreateScope()` (line 41) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`.
DI scope created and never disposed src/JobScheduling.Application/NaosExtensions.cs:39— `sp.CreateScope()` (line 39) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`.
DI scope created and never disposed src/JobScheduling.Application/NaosExtensions.cs:40— `sp.CreateScope()` (line 40) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`.
DI scope created and never disposed src/JobScheduling.Application/NaosExtensions.cs:45— `sp.CreateScope()` (line 45) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`.
DI scope created and never disposed src/Operations.Application/OperationsOptionsExtensions.cs:74— `sp.CreateScope()` (line 74) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`.
DI scope created and never disposed src/Foundation.Application.Web.Startup/ServiceCollectionExtensions.cs:40— `sp.CreateScope()` (line 40) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`.
DI scope created and never disposed src/Foundation.Application.Web.Startup/ServiceCollectionExtensions.cs:48— `sp.CreateScope()` (line 48) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`.
DI scope created and never disposed src/Tracing.Application/OperationsOptionsExtensions.cs:25— `sp.CreateScope()` (line 25) creates an `IServiceScope`, and it is dropped: `CreateScope().ServiceProvider` never names the scope, so nothing can release it. A scope owns every scoped service resolved from it — the `DbContext`, its connection, anything registered `AddScoped` — and releases them only when the scope itself is disposed; nothing here ever does, so each scope's services stay alive until the process ends. Create it with `using var scope = …CreateScope();` (or `await using` for `CreateAsyncScope`), or, when it must outlive the method, dispose it from the owning type's `Dispose`.
Duplicated block (6 lines × 2) src/ServiceDiscovery.Application.Web.Router/NaosExtensions.cs:49— src/ServiceDiscovery.Application.Web.Router/NaosExtensions.cs:49-54 | src/ServiceDiscovery.Application/NaosExtensions.cs:55-60 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/ServiceDiscovery.Application.Web.Router/NaosExtensions.cs:49` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `options` to `this ServiceDiscoveryRouterOptions` in one and `this ServiceDiscoveryOptions` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (6 lines × 2) src/JobScheduling.Application/NaosExtensions.cs:24— src/JobScheduling.Application/NaosExtensions.cs:24-29 | src/Queueing.Application/NaosExtensions.cs:24-29 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/JobScheduling.Application/NaosExtensions.cs:24` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) src/Tracing.Domain/Repositories/Decorators/RepositoryTracingDecorator.cs:46— src/Tracing.Domain/Repositories/Decorators/RepositoryTracingDecorator.cs:46-51 | src/Tracing.Domain/Repositories/Decorators/RepositoryTracingDecorator.cs:55-60 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (6 lines × 2) src/Tracing.Domain/Repositories/Decorators/RepositoryTracingDecorator.cs:82— src/Tracing.Domain/Repositories/Decorators/RepositoryTracingDecorator.cs:82-87 | src/Tracing.Domain/Repositories/Decorators/RepositoryTracingDecorator.cs:91-96 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (6 lines × 2) src/Tracing.Domain/Repositories/Decorators/RepositoryTracingDecorator.cs:154— src/Tracing.Domain/Repositories/Decorators/RepositoryTracingDecorator.cs:154-159 | src/Tracing.Domain/Repositories/Decorators/RepositoryTracingDecorator.cs:168-173 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (6 lines × 2) src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:95— src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:95-100 | src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:134-139 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:95` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:102— src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:102-107 | src/Queueing/InMemoryQueue.cs:71-76 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs` and `src/Queueing/InMemoryQueue.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 156 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:102` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 2) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:200— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:200-205 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:236-241 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs` and `src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 147 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:200` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (6 lines × 2) src/JobScheduling.Application.Web/Controllers/NaosJobRegistrationsController.cs:25— src/JobScheduling.Application.Web/Controllers/NaosJobRegistrationsController.cs:25-30 | src/JobScheduling.Application.Web/Controllers/NaosJobsController.cs:25-30 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/JobScheduling.Application.Web/Controllers/NaosJobsController.cs:33` calls `Route`, `ProducesResponseType` and `src/JobScheduling.Application.Web/Controllers/NaosJobRegistrationsController.cs:33` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 2) src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs:140— src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs:140-145 | src/ServiceDiscovery.Application/Registries/FileSystemServiceRegistry.cs:139-144 — before extracting anything, compare `src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs` and `src/ServiceDiscovery.Application/Registries/FileSystemServiceRegistry.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication· Members sharing a duplicated core (4 members, 50+ identical tokens) · ×9
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:99— src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:99-167 | src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:88-159 | src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:77-128 | src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:118-204 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Foundation.Domain.Repositories/Decorators/RepositoryDomainEventsDecorator.cs:87— src/Foundation.Domain.Repositories/Decorators/RepositoryDomainEventsDecorator.cs:87-97 | src/Foundation.Domain.Repositories/Decorators/RepositoryDomainEventsDecorator.cs:100-110 | src/Foundation.Domain.Repositories/Decorators/RepositoryDomainEventsDecorator.cs:113-123 | src/Foundation.Domain.Repositories/Decorators/RepositoryDomainEventsDecorator.cs:131-142 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:53— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:53-105 | src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:59-107 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:54-124 | src/Queueing/InMemoryQueue.cs:46-76 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:144— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:144-159 | src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:123-141 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:167-188 | src/Queueing/InMemoryQueue.cs:101-125 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:162— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:162-178 | src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:144-172 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:191-213 | src/Queueing/InMemoryQueue.cs:128-177 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:87— src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:87-95 | src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:98-106 | src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:109-117 | src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:120-128 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:81— src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:81-103 | src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:161-183 | src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:241-263 | src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:281-303 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) REDACTED:67— REDACTED:67-90 | REDACTED:133-159 | REDACTED:210-258 | REDACTED:309-357 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
Members sharing a duplicated core (4 members, 50+ identical tokens) src/KeyValueStorage.Infrastructure.LightningDb/LightningDbKeyValueStorage.cs:102— src/KeyValueStorage.Infrastructure.LightningDb/LightningDbKeyValueStorage.cs:102-117 | src/KeyValueStorage.Infrastructure.LightningDb/LightningDbKeyValueStorage.cs:120-135 | src/KeyValueStorage.Infrastructure.LightningDb/LightningDbKeyValueStorage.cs:138-153 | src/KeyValueStorage.Infrastructure.LightningDb/LightningDbKeyValueStorage.cs:156-171 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
DM12 · Ambient inputs in the domain· Domain type reads the wall clock · ×8
Domain type reads the wall clock: FileStorageScopedDecorator src/FileStorage/Domain/Decorators/FileStorageScopedDecorator.cs:127— `FileStorageScopedDecorator` reads `DateTime.UtcNow` inside `UpdatePathPrefix`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.
Domain type reads the wall clock: JobScheduler src/JobScheduling/Domain/Services/JobScheduler.cs:111— `JobScheduler` reads `DateTime.UtcNow` inside `RunAsync`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.
Domain type reads the wall clock: LogEvent src/Operations.Domain/Logging/Model/LogEvent.cs:64— `LogEvent` reads `DateTime.UtcNow` inside `GetAge`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.
Domain type reads the wall clock: LogTrace src/Tracing.Domain/Model/LogTrace.cs:89— `LogTrace` reads `DateTime.UtcNow` inside `GetAge`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.
Domain type reads the wall clock: QueueBase src/Queueing/Domain/Model/QueueBase.cs:43— `QueueBase` reads `DateTime.UtcNow` inside `DequeueAsync`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.
Domain type reads the wall clock: QueueItem src/Queueing/Domain/Model/QueueItem.cs:65— `QueueItem` reads `DateTime.UtcNow` inside `RenewLockAsync`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.
Domain type reads the wall clock: Span src/Tracing.Domain/Model/Span/Span.cs:62— `Span` reads `DateTimeOffset.UtcNow` inside `Start`, `End`, `AddLog`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.
Domain type reads the wall clock: State src/Foundation.Domain/Model/State.cs:150— `State` reads `DateTimeOffset.UtcNow` inside `SetDeactivated`, `SetCreated`, `SetUpdated`, `SetDeleted`. The rule this feeds is not a function of its inputs: it cannot be tested at the instant that matters without moving the machine clock, and two reads inside one operation can observe different times. Pass the instant in as a parameter, or inject `TimeProvider`.
Anemic entity: EchoEntity src/Foundation.Domain/Model/EchoEntity.cs:3— `EchoEntity` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: DummyMessage src/Messaging/Domain/Handlers/DummyMessage.cs:3— `DummyMessage` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: EchoMessage src/Messaging/Domain/Handlers/EchoMessage.cs:3— `EchoMessage` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: EntityMessage src/Messaging/Domain/Handlers/EntityMessage.cs:5— `EntityMessage` is an aggregate/entity with 1 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Message src/Messaging/Domain/Model/Message.cs:7— `Message` is an aggregate/entity with 8 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: LogEvent src/Operations.Domain/Logging/Model/LogEvent.cs:10— `LogEvent` is an aggregate/entity with 16 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: Command src/Commands.Domain/Model/Command.cs:8— `Command` is an aggregate/entity with 6 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Anemic entity: LogTrace src/Tracing.Domain/Model/LogTrace.cs:10— `LogTrace` is an aggregate/entity with 28 data propert(ies) but no state-changing behaviour (only data and queries) — the business logic lives in a service.
Duplicated block (11 lines × 2) src/FileStorage/InMemoryFileStorage.cs:114— src/FileStorage/InMemoryFileStorage.cs:114-124 | src/FileStorage/InMemoryFileStorage.cs:137-147 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/FileStorage/InMemoryFileStorage.cs:114` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (11 lines × 2) src/Commands.Application.Web/Controllers/NaosCommandRequestsController.cs:63— src/Commands.Application.Web/Controllers/NaosCommandRequestsController.cs:63-73 | src/Commands.Application.Web/Controllers/NaosCommandRequestsController.cs:113-123 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Commands.Application.Web/Controllers/NaosCommandRequestsController.cs:63` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) src/Operations.Infrastructure.Mongo/MongoLoggingConfiguration.cs:5— src/Operations.Infrastructure.Mongo/MongoLoggingConfiguration.cs:5-15 | src/Tracing.Infrastructure.Mongo/MongoTracingConfiguration.cs:5-15 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (11 lines × 2) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:183— src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:183-193 | src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:332-342 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:183` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:331` calls `LogDebug` and `src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:182` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (11 lines × 2) src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs:151— src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs:151-161 | src/ServiceDiscovery.Application/Registries/FileSystemServiceRegistry.cs:152-162 — before extracting anything, compare `src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs` and `src/ServiceDiscovery.Application/Registries/FileSystemServiceRegistry.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs:151` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 2) src/Foundation.Utilities/Node/ConsoleNodeRenderOptions.cs:8— src/Foundation.Utilities/Node/ConsoleNodeRenderOptions.cs:8-18 | src/Foundation.Utilities/Node/StringBuilderNodeRenderOptions.cs:18-28 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
Duplicated block (11 lines × 2) src/Foundation.Compression/CompressionHelper.cs:81— src/Foundation.Compression/CompressionHelper.cs:81-91 | src/Foundation.Utilities/StreamHelper.cs:9-19 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Outbound HTTP without resilience src/Application/NaosExtensions.cs:40— `context.Services.AddHttpClient<TClient>()` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
Outbound HTTP without resilience src/Application/NaosExtensions.cs:46— `context.Services .AddHttpClient<TClient>()` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
Outbound HTTP without resilience src/Application/NaosExtensions.cs:66— `context.Services.AddHttpClient(name)` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
Outbound HTTP without resilience src/Application/NaosExtensions.cs:72— `context.Services .AddHttpClient(name)` registers an outbound HTTP client with no resilience handler, retry policy or timeout of its own in its builder chain. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
Outbound HTTP without resilience src/Operations.Infrastructure.Azure/NaosExtensions.cs:37— `new System.Net.Http.HttpClient()` builds an outbound HTTP client and nothing bounds it: no timeout is set on it and no retry or resilience policy wraps its calls in the type that owns it. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
Outbound HTTP without resilience src/Tracing.Infrastructure.Azure/NaosExtensions.cs:37— `new System.Net.Http.HttpClient()` builds an outbound HTTP client and nothing bounds it: no timeout is set on it and no retry or resilience policy wraps its calls in the type that owns it. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
Weak hash algorithm src/Foundation.Utilities/HashAlgorithm.cs:20— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm src/Foundation.Utilities/HashAlgorithm.cs:36— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm src/Foundation.Utilities/HashAlgorithm.cs:99— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm src/Foundation.Utilities/HashAlgorithm.cs:110— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
Weak hash algorithm src/Foundation.Utilities/HashAlgorithm.cs:113— MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
No assertions: MixInObjectInstanceTest tests/Foundation.UnitTests/Utilities/ExpandoTests.cs:220— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: WhenGeneratingMany tests/Foundation.UnitTests/Utilities/RandomGeneratorTests.cs:54— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: WhenGeneratingManyFast tests/Foundation.UnitTests/Utilities/RandomGeneratorTests.cs:84— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: WhenGeneratingManyPasswords tests/Foundation.UnitTests/Utilities/RandomGeneratorTests.cs:90— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure* — so verification routed through a helper of your own naming, through a base-class or callback object whose members hold the assertions, or through a harness that fails by throwing under some other name, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
Cross-context type EventResult (Foundation.Domain.EventSourcing → Foundation.Infrastructure.EventStore) src/Foundation.Infrastructure.EventStore/EventStore/EventStoreEventStore.cs:65— EventResult (context Foundation.Domain.EventSourcing) is exposed in Foundation.Infrastructure.EventStore's public surface via EventStoreEventStore.SaveEventAsync — couples the contexts.
Cross-context type EventResult (Foundation.Domain.EventSourcing → Foundation.Infrastructure.EventStore) src/Foundation.Infrastructure.EventStore/EventStore/EventStoreEventStore.cs:109— EventResult (context Foundation.Domain.EventSourcing) is exposed in Foundation.Infrastructure.EventStore's public surface via EventStoreEventStore.SaveSnapshotAsync — couples the contexts.
Cross-context type EventResult (Foundation.Domain.EventSourcing → Foundation.Infrastructure.EventStore) src/Foundation.Infrastructure.EventStore/Sql/SqlEventStore.cs:16— EventResult (context Foundation.Domain.EventSourcing) is exposed in Foundation.Infrastructure.EventStore's public surface via SqlEventStore.SaveEventAsync — couples the contexts.
Cross-context type EventResult (Foundation.Domain.EventSourcing → Foundation.Infrastructure.EventStore) src/Foundation.Infrastructure.EventStore/Sql/SqlEventStore.cs:27— EventResult (context Foundation.Domain.EventSourcing) is exposed in Foundation.Infrastructure.EventStore's public surface via SqlEventStore.SaveSnapshotAsync — couples the contexts.
Duplicated block (8 lines × 2) src/FileStorage.Infrastructure.Azure/Extensions.cs:31— src/FileStorage.Infrastructure.Azure/Extensions.cs:31-38 | src/FileStorage.Infrastructure.Azure/Extensions.cs:53-60 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) src/Foundation.Criteria/CriteriaExtensions.cs:27— src/Foundation.Criteria/CriteriaExtensions.cs:27-34 | src/Foundation.Criteria/CriteriaExtensions.cs:47-54 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Criteria/CriteriaExtensions.cs:27` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Operations.Application/LoggingOptionsExtensions.cs:23— src/Operations.Application/LoggingOptionsExtensions.cs:23-30 | src/Operations.Infrastructure.Azure/LoggingOptionsExtensions.cs:23-31 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Operations.Application/LoggingOptionsExtensions.cs:23` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (8 lines × 2) src/Operations.Domain/Logging/Model/LogEvent.cs:66— src/Operations.Domain/Logging/Model/LogEvent.cs:66-73 | src/Tracing.Domain/Model/LogTrace.cs:91-98 — before extracting anything, compare `src/Operations.Domain/Logging/Model/LogEvent.cs` and `src/Tracing.Domain/Model/LogTrace.cs` as WHOLE FILES: 91% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Tracing.Domain/Model/LogTrace.cs:100` calls `ToString` and `src/Operations.Domain/Logging/Model/LogEvent.cs:74` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (12 lines × 2) src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:78— src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:78-89 | src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:108-119 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:78` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/OrderByIf.cs:45— src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/OrderByIf.cs:45-56 | src/Foundation.Infrastructure.Mongo/Repositories/Extensions/OrderByIf.cs:45-56 — before extracting anything, compare `src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/OrderByIf.cs` and `src/Foundation.Infrastructure.Mongo/Repositories/Extensions/OrderByIf.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 38 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/OrderByIf.cs:45` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs:39— src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs:39-50 | src/ServiceDiscovery.Application/Registries/FileSystemServiceRegistry.cs:38-49 — before extracting anything, compare `src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs` and `src/ServiceDiscovery.Application/Registries/FileSystemServiceRegistry.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (12 lines × 2) src/Commands.Application.Web/Middleware/CommandRequestMiddleware.cs:120— src/Commands.Application.Web/Middleware/CommandRequestMiddleware.cs:120-131 | src/Commands.Application.Web/Middleware/CommandRequestMiddleware.cs:144-155 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Commands.Application.Web/Middleware/CommandRequestMiddleware.cs:120` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) src/Foundation.Utilities/System/SystemMetricsClient.cs:22— src/Foundation.Utilities/System/SystemMetricsClient.cs:22-35 | src/Foundation.Utilities/System/SystemMetricsClient.cs:51-64 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (14 lines × 2) REDACTED:518— REDACTED:518-531 | src/Foundation.Infrastructure.Documents.Sqlite/Provider/SqliteDocumentProvider.cs:66-79 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:518` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) src/Foundation.Application.Web/Extensions/HttpResponseExtensions.cs:23— src/Foundation.Application.Web/Extensions/HttpResponseExtensions.cs:23-36 | src/Foundation.Application.Web/Extensions/HttpResponseExtensions.cs:46-59 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (14 lines × 2) src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Extensions/WhereExpression.cs:25— src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Extensions/WhereExpression.cs:25-38 | src/Foundation.Infrastructure.Mongo/Repositories/Extensions/WhereExpression.cs:25-38 — before extracting anything, compare `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Extensions/WhereExpression.cs` and `src/Foundation.Infrastructure.Mongo/Repositories/Extensions/WhereExpression.cs` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (13 lines × 2) src/Queueing.Application.Azure/NaosExtensions.cs:37— src/Queueing.Application.Azure/NaosExtensions.cs:37-49 | src/Queueing.Application.Azure/NaosExtensions.cs:80-92 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Queueing.Application.Azure/NaosExtensions.cs:37` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 2) src/Foundation.Utilities/EncryptionHelper.cs:57— src/Foundation.Utilities/EncryptionHelper.cs:57-69 | src/Foundation.Utilities/EncryptionHelper.cs:83-95 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (13 lines × 2) src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:111— src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:111-123 | src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs:104-116 — before extracting anything, compare `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs` and `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 120 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:111` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:125` calls `Select` and `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs:117` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (13 lines × 2) src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:175— src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:175-187 | src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:168-180 — before extracting anything, compare `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs` and `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 94 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) src/Operations.Infrastructure.Azure/NaosExtensions.cs:25— src/Operations.Infrastructure.Azure/NaosExtensions.cs:25-34 | src/Tracing.Infrastructure.Azure/NaosExtensions.cs:25-34 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (10 lines × 2) src/Foundation.Serialization/Serializers/Base64Serializer.cs:58— src/Foundation.Serialization/Serializers/Base64Serializer.cs:58-67 | src/Foundation.Serialization/Serializers/Base64Serializer.cs:86-95 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Serialization/Serializers/Base64Serializer.cs:58` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/Foundation.ContentTypes/ContentTypeExtensions.cs:8— src/Foundation.ContentTypes/ContentTypeExtensions.cs:8-17 | src/Foundation.ContentTypes/ContentTypeExtensions.cs:28-37 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.ContentTypes/ContentTypeExtensions.cs:8` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/Foundation.Serialization/Json/PrivateSetterCamelCasePropertyNamesContractResolver.cs:10— src/Foundation.Serialization/Json/PrivateSetterCamelCasePropertyNamesContractResolver.cs:10-19 | src/Foundation.Serialization/Json/PrivateSetterContractResolver.cs:10-20 — before extracting anything, compare `src/Foundation.Serialization/Json/PrivateSetterCamelCasePropertyNamesContractResolver.cs` and `src/Foundation.Serialization/Json/PrivateSetterContractResolver.cs` as WHOLE FILES: 90% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (6 lines × 3) src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:182— src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:182-187 | src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:204-209 | src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:229-234 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:182` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:228` calls `Select` and `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:181` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 3) src/Foundation.Domain.Repositories/Decorators/RepositoryLoggingDecorator.cs:65— src/Foundation.Domain.Repositories/Decorators/RepositoryLoggingDecorator.cs:65-70 | src/Foundation.Domain.Repositories/Decorators/RepositoryLoggingDecorator.cs:82-87 | src/Foundation.Domain.Repositories/Decorators/RepositoryLoggingDecorator.cs:99-104 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (6 lines × 3) src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs:191— src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs:191-196 | src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:258-263 | src/FileStorage.Infrastructure.Ssh/SshNetFileStorage.cs:397-402 — before extracting anything, compare `src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs` and `src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (6 lines × 3) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:173— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:173-178 | src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:167-172 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:205-210 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs` and `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:173` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Change coupling: NaosOperationsLogEventsController.cs ↔ NaosOperationsLogTracesController.cs src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs:1— `src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs` and `src/Operations.Application.Web/Controllers/NaosOperationsLogTracesController.cs` change together 74% of the time (25 of the 34 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 25 shared commits counted here, the most recent 3 are `5242cbfe` nd; `da7e1e71` cc; `476f068c` cc — run `git show` on any of them.
Change coupling: NaosOperationsHealthController.cs ↔ NaosOperationsLogEventsController.cs src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:1— `src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs` and `src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs` change together 64% of the time (9 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `5242cbfe` nd; `da7e1e71` cc; `e10f1280` lime color — run `git show` on any of them.
Change coupling: NaosOperationsHealthController.cs ↔ NaosOperationsLogTracesController.cs src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:1— `src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs` and `src/Operations.Application.Web/Controllers/NaosOperationsLogTracesController.cs` change together 64% of the time (9 of the 14 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `5242cbfe` nd; `da7e1e71` cc; `e10f1280` lime color — run `git show` on any of them.
Duplicated block (19 lines × 2) src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs:210— src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs:210-228 | src/Foundation.Infrastructure.Documents.Sqlite/Provider/SqliteBuilder.cs:23-41 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (19 lines × 2) src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/OrderByIf.cs:19— src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/OrderByIf.cs:19-37 | src/Foundation.Infrastructure.Mongo/Repositories/Extensions/OrderByIf.cs:19-37 — before extracting anything, compare `src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/OrderByIf.cs` and `src/Foundation.Infrastructure.Mongo/Repositories/Extensions/OrderByIf.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 38 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (19 lines × 2) src/Operations.Application/Configuration/FileLoggingConfiguration.cs:7— src/Operations.Application/Configuration/FileLoggingConfiguration.cs:7-25 | src/Operations.Infrastructure.Azure/DiagnosticsLogStreamLoggingConfiguration.cs:16-34 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (16 lines × 2) src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs:229— src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs:229-244 | src/FileStorage.Infrastructure.Ssh/SshNetFileStorage.cs:214-229 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs:229` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 2) src/Foundation.Serialization/SerializerExtensions.cs:56— src/Foundation.Serialization/SerializerExtensions.cs:56-71 | src/Foundation.Serialization/SerializerExtensions.cs:84-99 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Serialization/SerializerExtensions.cs:56` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `input` to `byte[]` in one and `string` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (16 lines × 2) src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:284— src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:284-299 | src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs:275-290 — before extracting anything, compare `src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs` and `src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 131 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (17 lines × 2) src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V3/CosmosSqlProviderV3.cs:120— src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V3/CosmosSqlProviderV3.cs:120-136 | src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V3/CosmosSqlProviderV3.cs:153-169 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V3/CosmosSqlProviderV3.cs:120` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (17 lines × 2) src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs:182— src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs:182-198 | src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:249-265 — before extracting anything, compare `src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs` and `src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (17 lines × 2) src/Foundation.Application.Web/Extensions/HttpRequestMessageExtensions.cs:156— src/Foundation.Application.Web/Extensions/HttpRequestMessageExtensions.cs:156-172 | src/Foundation.Application.Web/Extensions/HttpResponseMessageExtensions.cs:72-88 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `source` to `this HttpRequestMessage` in one and `this HttpResponseMessage` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
Duplicated block (9 lines × 2) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:185— src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:185-193 | src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:148-156 — before extracting anything, compare `src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs` and `src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:185` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:145` calls `SliceTillLast`, `GetFileContents` and `src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:183` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9 lines × 2) src/Foundation.Domain.Repositories.Documents/Provider/IDocumentProvider.cs:40— src/Foundation.Domain.Repositories.Documents/Provider/IDocumentProvider.cs:40-56 | src/Foundation.Domain.Repositories.Documents/Provider/IDocumentProvider.cs:64-72 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Domain.Repositories.Documents/Provider/IDocumentProvider.cs:40` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/Foundation.Domain.Repositories.Documents/Provider/IDocumentProvider.cs:74— src/Foundation.Domain.Repositories.Documents/Provider/IDocumentProvider.cs:74-89 | src/Foundation.Domain.Repositories.Documents/Provider/IDocumentProvider.cs:99-107 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Domain.Repositories.Documents/Provider/IDocumentProvider.cs:74` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
DM11 · Constructible invalid state· Constructible in an invalid state · ×3
Constructible in an invalid state: Message src/Messaging/Domain/Model/Message.cs:24— `Message`'s public constructor takes `id`, `correlationId` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `Message` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: QueueItem src/Queueing/Domain/Model/QueueItem.cs:14— `QueueItem`'s public constructor takes `id`, `attempts` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `QueueItem` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Constructible in an invalid state: Span src/Tracing.Domain/Model/Span/Span.cs:15— `Span`'s public constructor takes `traceId`, `spanId`, `parentSpanId` as raw primitives, and neither of the two things that would make that safe was found. What was searched, so you can tell an absence from a miss: for VALIDATION, the constructor body was scanned for `throw`, `Guard.`, `Ensure.`, `ArgumentNullException`, `ArgumentException`, `CheckRule` or `Requires.` — a guard reached through a helper method those tokens do not name is not seen; for a FACTORY, only this type's OWN static members were read, and only names beginning `Create`, `Of`, `From`, `New` or `Build` — one inherited from a base type, one on a companion builder, or one called `Parse`, `Make` or `Rehydrate` is not seen. If either exists, this row is wrong. If neither does, a caller can build a `Span` that breaks the rules it exists to enforce, and every rule downstream then has to cope with a state the model said was impossible. Guard in the constructor, take value objects that validate themselves, or make the constructor private behind a `Create` that can refuse.
Skeleton type — most members are unfinished src/FileStorage.Infrastructure.Azure/AzureKeyVaultFileStorage.cs:9— `AzureKeyVaultFileStorage` has 11 unfinished members out of 11 declared members (methods, properties, indexers and events, whether or not each carries a body) — a scaffolded type that was never implemented.
Skeleton type — most members are unfinished src/Foundation.Domain.EventSourcing/Repositories/EventStore/InMemoryEventStore.cs:7— `InMemoryEventStore` has 2 unfinished members out of 4 declared members (methods, properties, indexers and events, whether or not each carries a body) — a scaffolded type that was never implemented.
Skeleton type — most members are unfinished src/Foundation.Infrastructure.EventStore/Sql/SqlEventStore.cs:8— `SqlEventStore` has 4 unfinished members out of 4 declared members (methods, properties, indexers and events, whether or not each carries a body) — a scaffolded type that was never implemented.
S1 · Web-Security Posture· Ciphertext is encrypted but not authenticated · ×3
Ciphertext is encrypted but not authenticated src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:54— This type encrypts through `SymmetricAlgorithm`, whose every cipher mode (CBC/ECB/OFB/CFB/CTS) is unauthenticated, and no keyed MAC or AEAD cipher appears anywhere in it — so nothing establishes that the ciphertext it produced is the ciphertext it later reads back. Encryption alone provides confidentiality, not integrity: unauthenticated CBC is MALLEABLE, and an attacker who can modify stored or transmitted ciphertext can flip chosen plaintext bits in the following block by flipping ciphertext bits in the preceding one, without ever knowing the key. Where the decrypt path reports failure differently for a padding error than for a downstream one — a broad `catch` that returns null is the usual spelling — the same construction also answers the attacker's questions, which is the padding-oracle shape that recovers plaintext outright. Prefer an AEAD cipher: `AesGcm` or `ChaCha20Poly1305` authenticate the ciphertext as part of encrypting it, and give you an associated-data slot for the surrounding context. Where the format cannot change, MAC it with encrypt-then-MAC — HMAC-SHA256 over the IV and the ciphertext together, with a key derived separately from the encryption key — and verify that tag with `CryptographicOperations.FixedTimeEquals` BEFORE decrypting anything.
Ciphertext is encrypted but not authenticated src/Foundation.Utilities/EncryptionHelper.cs:24— This type encrypts through `SymmetricAlgorithm`, whose every cipher mode (CBC/ECB/OFB/CFB/CTS) is unauthenticated, and no keyed MAC or AEAD cipher appears anywhere in it — so nothing establishes that the ciphertext it produced is the ciphertext it later reads back. Encryption alone provides confidentiality, not integrity: unauthenticated CBC is MALLEABLE, and an attacker who can modify stored or transmitted ciphertext can flip chosen plaintext bits in the following block by flipping ciphertext bits in the preceding one, without ever knowing the key. Where the decrypt path reports failure differently for a padding error than for a downstream one — a broad `catch` that returns null is the usual spelling — the same construction also answers the attacker's questions, which is the padding-oracle shape that recovers plaintext outright. Prefer an AEAD cipher: `AesGcm` or `ChaCha20Poly1305` authenticate the ciphertext as part of encrypting it, and give you an associated-data slot for the surrounding context. Where the format cannot change, MAC it with encrypt-then-MAC — HMAC-SHA256 over the IV and the ciphertext together, with a key derived separately from the encryption key — and verify that tag with `CryptographicOperations.FixedTimeEquals` BEFORE decrypting anything.
Ciphertext is encrypted but not authenticated src/Foundation.Utilities/EncryptionHelper.cs:70— This type encrypts through `SymmetricAlgorithm`, whose every cipher mode (CBC/ECB/OFB/CFB/CTS) is unauthenticated, and no keyed MAC or AEAD cipher appears anywhere in it — so nothing establishes that the ciphertext it produced is the ciphertext it later reads back. Encryption alone provides confidentiality, not integrity: unauthenticated CBC is MALLEABLE, and an attacker who can modify stored or transmitted ciphertext can flip chosen plaintext bits in the following block by flipping ciphertext bits in the preceding one, without ever knowing the key. Where the decrypt path reports failure differently for a padding error than for a downstream one — a broad `catch` that returns null is the usual spelling — the same construction also answers the attacker's questions, which is the padding-oracle shape that recovers plaintext outright. Prefer an AEAD cipher: `AesGcm` or `ChaCha20Poly1305` authenticate the ciphertext as part of encrypting it, and give you an associated-data slot for the surrounding context. Where the format cannot change, MAC it with encrypt-then-MAC — HMAC-SHA256 over the IV and the ciphertext together, with a key derived separately from the encryption key — and verify that tag with `CryptographicOperations.FixedTimeEquals` BEFORE decrypting anything.
Weak cipher src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:46— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Weak cipher src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:79— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
Weak cipher src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:109— DES / 3DES / RijndaelManaged-bare is deprecated or broken. Use AES-GCM via `Aes.Create()` with explicit key/iv sizes.
X18 · Disposal-pattern correctness· Disposes a dependency it does not own · ×3
Disposes a dependency it does not own src/Queueing/Domain/Decorators/AutoCompleteQueueDecorator.cs:57— `inner` is never created by `AutoCompleteQueueDecorator` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 57). Its declared type `IQueue` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed.
Disposes a dependency it does not own src/Queueing/Domain/Decorators/FileStorageQueueDecorator.cs:55— `inner` is never created by `FileStorageQueueDecorator` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 55). Its declared type `IQueue` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed.
Disposes a dependency it does not own src/Foundation.Application.Web.Startup/StartupTaskServerDecorator.cs:64— `inner` is never created by `StartupTaskServerDecorator` — every assignment to it takes a constructor parameter — yet this type disposes it here (line 64). Its declared type `IServer` is an interface, so the instance came from whoever resolved it, and that owner decides when it ends. Disposing it from here reaches outside this object's lifetime: a dependency shared with the rest of the process is torn down when THIS instance goes away, and the real owner's later `Dispose()` runs a second time on an object already disposed. Drop the call — a type disposes what it constructed, and only that. If this dependency genuinely is exclusive to this instance, construct it here (or take an owned factory) so the ownership is stated in the code rather than assumed.
Stateful singleton: ServiceDiscoveryHostedService src/ServiceDiscovery.Application/Web/ServiceDiscoveryHostedService.cs:15— `ServiceDiscoveryHostedService` is a singleton (one shared instance) but mutates instance state outside any lock (serviceAddress; e.g. `serviceAddress` at line 59).
Stateful singleton: CommandRequestRegistration src/Commands.Application.Web/CommandRequestRegistration.cs:12— `CommandRequestRegistration` is a singleton (one shared instance) but mutates instance state outside any lock (route; e.g. `route` at line 26).
D17 · Explicit Debt· Whole file has no live code · ×2
Whole file has no live code — 1 debt marker inside it src/Application/ServiceCollectionExtensions.cs:21— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 1 debt marker (1 CommentedOutCode) all sit inside that dead text: one decision to leave the whole file switched off, not 1 independent debts. It records no note anywhere: the file is switched off with nothing in it saying why, so a reader cannot tell whether it is waiting on something or was simply abandoned — which is the harder of the two to bring back. Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
Whole file has no live code — 1 debt marker inside it src/Commands.Application/Handlers/Behaviors/ServiceContextEnrichCommandBehavior.cs:14— Every line in this file is a comment or blank — it declares no type, member, using or attribute, so nothing in it reaches the build. Its 1 debt marker (1 TodoComment) all sit inside that dead text: one decision to leave the whole file switched off, not 1 independent debts. The first note recorded in it is "// public ServiceContextEnrichCommandBehavior(ServiceContext serviceContext) // TODO: accessor" (line 14). Decide the FILE rather than its lines — restore it, or delete it and let version control hold the history. (Every occurrence still counts toward the score and metrics.)
BarePragmaDisable src/Foundation.Utilities/Factory.cs:9— #pragma warning disable SA1402 // File may only contain a single class — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable tests/Foundation.UnitTests/Domain/Repositories/Stubs.cs:11— #pragma warning disable SA1402 // File may only contain a single type — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
EntityFrameworkRepository.UpsertAsync (cognitive 20) src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:152— EntityFrameworkRepository.UpsertAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
EntityFrameworkRepository.UpsertAsync (cognitive 20) src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs:148— EntityFrameworkRepository.UpsertAsync has cognitive complexity 20 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
CosmosSqlRepository.UpsertAsync (cognitive 18) src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:114— CosmosSqlRepository.UpsertAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
CosmosSqlRepository.UpsertAsync (cognitive 18) src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:108— CosmosSqlRepository.UpsertAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
MongoRepository.UpsertAsync (cognitive 18) src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:165— MongoRepository.UpsertAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
MongoRepository.UpsertAsync (cognitive 18) src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs:155— MongoRepository.UpsertAsync has cognitive complexity 18 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
InMemoryRepository.FindAll (cognitive 16) src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity,TDestination}.cs:90— InMemoryRepository.FindAll has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InMemoryRepository.FindAll (cognitive 16) src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs:312— InMemoryRepository.FindAll has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
Cross-context type ISubscriptionMap (Messaging → Messaging.Infrastructure.RabbitMQ) src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBrokerOptions.cs:21— ISubscriptionMap (context Messaging) is exposed in Messaging.Infrastructure.RabbitMQ's public surface via RabbitMQMessageBrokerOptions.Subscriptions — couples the contexts.
Cross-context type ISubscriptionMap (Messaging → Messaging.Infrastructure.RabbitMQ) src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBrokerOptionsBuilder.cs:51— ISubscriptionMap (context Messaging) is exposed in Messaging.Infrastructure.RabbitMQ's public surface via RabbitMQMessageBrokerOptionsBuilder.Subscriptions — couples the contexts.
Cross-context type ISubscriptionMap (Messaging → Messaging.Infrastructure.FileSystem) src/Messaging.Infrastructure.FileSystem/FileStorageMessageBrokerOptions.cs:20— ISubscriptionMap (context Messaging) is exposed in Messaging.Infrastructure.FileSystem's public surface via FileStorageMessageBrokerOptions.Subscriptions — couples the contexts.
Cross-context type ISubscriptionMap (Messaging → Messaging.Infrastructure.FileSystem) src/Messaging.Infrastructure.FileSystem/FileStorageMessageBrokerOptionsBuilder.cs:36— ISubscriptionMap (context Messaging) is exposed in Messaging.Infrastructure.FileSystem's public surface via FileStorageMessageBrokerOptionsBuilder.Subscriptions — couples the contexts.
Cross-context type ISubscriptionMap (Messaging → Messaging.Infrastructure.Azure.SignalR) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBrokerOptions.cs:24— ISubscriptionMap (context Messaging) is exposed in Messaging.Infrastructure.Azure.SignalR's public surface via SignalRServerlessMessageBrokerOptions.Subscriptions — couples the contexts.
Cross-context type ISubscriptionMap (Messaging → Messaging.Infrastructure.Azure.SignalR) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBrokerOptionsBuilder.cs:50— ISubscriptionMap (context Messaging) is exposed in Messaging.Infrastructure.Azure.SignalR's public surface via SignalRServerlessMessageBrokerOptionsBuilder.Subscriptions — couples the contexts.
TooManyMethods: SequentialGuid src/Foundation.Utilities/SequentialGuid.cs— TooManyMethods — 126 significant lines (blank, comment-only and punctuation-only lines excluded), 39 methods. The bar is 30 methods; this is 9 over it, 1.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
TooManyMethods: SqlServerDocumentProvider REDACTED— TooManyMethods — 378 significant lines (blank, comment-only and punctuation-only lines excluded), 34 methods. The bar is 30 methods; this is 4 over it, 1.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication· Members sharing a duplicated core (5 members, 50+ identical tokens) · ×2
Members sharing a duplicated core (5 members, 50+ identical tokens) src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:42— src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:42-66 | src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:69-88 | src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:91-111 | src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:164-185 | src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:224-240 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
Members sharing a duplicated core (5 members, 50+ identical tokens) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:200— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:200-240 | src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:205-230 | src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:296-354 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:236-287 | src/Queueing/InMemoryQueue.cs:308-369 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
Duplicated block (30 lines × 2) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:209— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:209-238 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:251-280 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs` and `src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 147 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (30 lines × 2) src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs:54— src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs:54-83 | src/ServiceDiscovery.Application/Registries/FileSystemServiceRegistry.cs:53-82 — before extracting anything, compare `src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs` and `src/ServiceDiscovery.Application/Registries/FileSystemServiceRegistry.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (32 lines × 2) src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:183— src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:183-214 | src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs:173-204 — before extracting anything, compare `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs` and `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 120 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:183` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
Duplicated block (32 lines × 2) src/Commands.Application/Handlers/Behaviors/IdempotentCommandBehavior.cs:12— src/Commands.Application/Handlers/Behaviors/IdempotentCommandBehavior.cs:12-44 | src/Commands.Application/Handlers/Behaviors/PersistCommandBehavior.cs:12-43 — before extracting anything, compare `src/Commands.Application/Handlers/Behaviors/IdempotentCommandBehavior.cs` and `src/Commands.Application/Handlers/Behaviors/PersistCommandBehavior.cs` as WHOLE FILES: 88% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
Duplicated block (23 lines × 2) src/Messaging.Infrastructure.RabbitMQ/RabbitMQProvider.cs:75— src/Messaging.Infrastructure.RabbitMQ/RabbitMQProvider.cs:75-97 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQProvider.cs:75-97 — `src/Messaging.Infrastructure.RabbitMQ/RabbitMQProvider.cs` and `src/Queueing.Infrastructure.RabbitMQ/RabbitMQProvider.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 1 separate duplicated blocks between them, totalling at least 23 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `src/Messaging.Infrastructure.RabbitMQ/RabbitMQProvider.cs:75` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23 lines × 2) src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:23— src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:23-45 | src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs:20-42 — before extracting anything, compare `src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs` and `src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 131 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:23` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:22` calls `IsNotNull`, `nameof` and `src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs:19` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (25 lines × 2) src/Operations.Domain/Logging/Model/LogEvent.cs:34— src/Operations.Domain/Logging/Model/LogEvent.cs:34-58 | src/Tracing.Domain/Model/LogTrace.cs:34-58 — before extracting anything, compare `src/Operations.Domain/Logging/Model/LogEvent.cs` and `src/Tracing.Domain/Model/LogTrace.cs` as WHOLE FILES: 91% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (25 lines × 2) src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:191— src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:191-215 | src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:184-208 — before extracting anything, compare `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs` and `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 94 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 4) src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:88— src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:88-95 | src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:99-106 | src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:110-117 | src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:121-128 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (8 lines × 4) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:209— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:209-216 | src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:322-329 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:251-258 | src/Queueing/InMemoryQueue.cs:338-345 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs` and `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:209` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (7 lines × 3) src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs:279— src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs:279-285 | src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:253-259 | src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs:244-250 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (7 lines × 3) src/Foundation.Domain.Repositories.Documents/DocumentRepository.cs:51— src/Foundation.Domain.Repositories.Documents/DocumentRepository.cs:51-57 | src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:246-252 | src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs:237-243 — before extracting anything, compare `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs` and `src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 120 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Low cohesion: SqlBuilder (LCOM4 11) src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs:11— SqlBuilder's methods fall into 11 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 11 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Low cohesion: Span (LCOM4 8) src/Tracing.Domain/Model/Span/Span.cs:10— Span's methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
Fake-async — async method never awaits src/Foundation.Domain.Repositories.Documents/DocumentRepository.cs:85— `FindAllAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
Fake-async — async method never awaits src/Foundation.Domain.Repositories.Documents/DocumentRepository.cs:113— `FindOneAsync` is declared `async` but never awaits anything, so it runs synchronously while pretending to be asynchronous. Drop `async` or do the real async work.
P8 · Schema migrations· Schema created with EnsureCreated() outside the migrations · ×2
Schema created with EnsureCreated() outside the migrations src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:37— This repository evolves its schema with versioned migrations, but `EnsureCreated()` here builds a schema straight from the model instead — with no migrations-history row, so a database it creates can't be upgraded by `Migrate()` afterwards and the two paths can disagree about the shape. Apply the migrations here (`Migrate()` / a migrations bundle) rather than creating the schema.
Schema created with EnsureCreated() outside the migrations src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs:34— This repository evolves its schema with versioned migrations, but `EnsureCreated()` here builds a schema straight from the model instead — with no migrations-history row, so a database it creates can't be upgraded by `Migrate()` afterwards and the two paths can disagree about the shape. Apply the migrations here (`Migrate()` / a migrations bundle) rather than creating the schema.
Blocking `Thread.Sleep` inside an `async` method REDACTED:31— `Thread.Sleep` parks the thread for the whole delay: no other work runs on it, and under load the pool must grow to make up for it. `await Task.Delay(…)` suspends only this method.
Blocking `Thread.Sleep` inside an `async` method REDACTED:82— `Thread.Sleep` parks the thread for the whole delay: no other work runs on it, and under load the pool must grow to make up for it. `await Task.Delay(…)` suspends only this method.
SqlBuilder.BuildExpressionSelect (cyclomatic 38) src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs:84— SqlBuilder.BuildExpressionSelect has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
FileStorageKeyValueStorage.Match (cyclomatic 35) src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:184— FileStorageKeyValueStorage.Match has cyclomatic complexity 35 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
Extensions.To (cyclomatic 18) src/Foundation.Extensions/To.cs:21— Extensions.To has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
Extensions.To (cyclomatic 17) src/Foundation.Extensions/To.cs:92— Extensions.To has cyclomatic complexity 17 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function, or replace a long branch ladder over a single value with a data-driven lookup or dispatch table.
SshNetFileStorage.CreateConnectionInfo (cyclomatic 16) src/FileStorage.Infrastructure.Ssh/SshNetFileStorage.cs:300— SshNetFileStorage.CreateConnectionInfo has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D10 · Test Quality· Depends on a live external host · ×1
Depends on a live external host: CanUseHttpClient_Test tests/IntegrationTests/HttpClientTests.cs:44— This test fetches `http://mockbin.org/request` while it runs, so it passes only while mockbin.org is up, reachable from the build machine, and still serving what this test expects — none of which this repository controls. It goes red on an aeroplane, behind a corporate proxy, in a sealed CI network, and on the day the third party edits that document. Serve the payload from the repository instead (a checked-in fixture file), or stub the transport; if the point really is to check the remote contract, move it out of the unit suite into a separately-scheduled integration job that is allowed to fail for someone else's reasons.
Prerelease dependency: Microsoft.Azure.Cosmos.Table — Microsoft.Azure.Cosmos.Table resolves to 2.0.0-preview, a prerelease build. Prerelease packages carry no support policy, may change breaking between previews and can be unlisted — pin a stable release before shipping, or record the reason this preview is required.
D17 · Explicit Debt· BareSuppressMessage repeated 90 times in one file · ×1
BareSuppressMessage repeated 90 times in one file GlobalSuppressions.cs:2— The identical BareSuppressMessage (`System.Diagnostics.CodeAnalysis.SuppressMessage`) appears 90 times in one file — one decision applied repeatedly (e.g. the same rule silenced on every overload of a fluent API), not 90 independent debts. Decide it once — at the type or project level, or by fixing the underlying pattern — rather than occurrence-by-occurrence. (Every occurrence still counts toward the score and metrics.)
FileStorageKeyValueStorage.Match (cognitive 46) src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:184— FileStorageKeyValueStorage.Match has cognitive complexity 46 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
NaosOperationsHealthController.GetHtmlAsync (cognitive 33) src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:86— NaosOperationsHealthController.GetHtmlAsync has cognitive complexity 33 (threshold 15). None of this is in the body itself: all 33 points belong to one function literal inside it that branches (line 91). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
ServiceBusMessageBroker.ProcessMessage (cognitive 30) src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:213— ServiceBusMessageBroker.ProcessMessage has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FileStorageMessageBroker.ProcessMessage (cognitive 29) src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:142— FileStorageMessageBroker.ProcessMessage has cognitive complexity 29 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InteractiveConsoleHostedService.Run (cognitive 27) src/Foundation.Console/App/InteractiveConsoleHostedService.cs:50— InteractiveConsoleHostedService.Run has cognitive complexity 27 (threshold 15). Of this number, 23 points are the body's own statements and 4 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SqlBuilder.BuildExpressionSelect (cognitive 26) src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs:84— SqlBuilder.BuildExpressionSelect has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LogAnalyticsRepository.MapResponse (cognitive 25) src/Foundation.Infrastructure.Azure.LogAnalytics/Repositories/LogAnalyticsRepository.cs:155— LogAnalyticsRepository.MapResponse has cognitive complexity 25 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
RabbitMQMessageBroker.ProcessMessage (cognitive 23) src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:329— RabbitMQMessageBroker.ProcessMessage has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SignalRServerlessMessageBroker.ProcessMessage (cognitive 23) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:181— SignalRServerlessMessageBroker.ProcessMessage has cognitive complexity 23 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
LoggingFilterContext.Prepare (cognitive 20) src/Operations.Application/LoggingFilterContext.cs:21— LoggingFilterContext.Prepare has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
PropertyBag.ReadXml (cognitive 20) src/Foundation.Utilities/Expando/PropertyBag.cs:132— PropertyBag.ReadXml has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ApiKeyAuthenticationHandler.HandleAuthenticateAsync (cognitive 19) src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs:32— ApiKeyAuthenticationHandler.HandleAuthenticateAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BasicAuthenticationHandler.HandleAuthenticateAsync (cognitive 19) src/Authentication.Application.Web/Basic/BasicAuthenticationHandler.cs:32— BasicAuthenticationHandler.HandleAuthenticateAsync has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
ExpressionExpander.VisitMethodCall (cognitive 19) src/Foundation.Utilities/Expressions/ExpressionExtensions.cs:92— ExpressionExpander.VisitMethodCall has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
InMemoryRepository.UpsertAsync (cognitive 17) src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs:157— InMemoryRepository.UpsertAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
NaosOperationsLogEventsController.GetHtmlAsync (cognitive 17) src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs:94— NaosOperationsLogEventsController.GetHtmlAsync has cognitive complexity 17 (threshold 15). None of this is in the body itself: all 17 points belong to one function literal inside it that branches (line 99). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
SshNetFileStorage.CreateConnectionInfo (cognitive 17) src/FileStorage.Infrastructure.Ssh/SshNetFileStorage.cs:300— SshNetFileStorage.CreateConnectionInfo has cognitive complexity 17 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
Extensions.To (cognitive 17) src/Foundation.Extensions/To.cs:21— Extensions.To has cognitive complexity 17 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
Run.WithRetriesAsync (cognitive 17) src/Foundation.Utilities/Run.cs:50— Run.WithRetriesAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CommandRequestMiddleware.Invoke (cognitive 17) src/Commands.Application.Web/Middleware/CommandRequestMiddleware.cs:61— CommandRequestMiddleware.Invoke has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
BadRequestExceptionResponseHandler.Handle (cognitive 16) src/Exceptions.Application.Web/Middleware/Handlers/BadRequestExceptionResponseHandler.cs:26— BadRequestExceptionResponseHandler.Handle has cognitive complexity 16 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
PropertyBag.WriteXml (cognitive 16) src/Foundation.Utilities/Expando/PropertyBag.cs:65— PropertyBag.WriteXml has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DocumentRepository.UpsertAsync (cognitive 16) src/Foundation.Domain.Repositories.Documents/DocumentRepository.cs:134— DocumentRepository.UpsertAsync has cognitive complexity 16 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
Cross-context type Message (Messaging → Messaging.Infrastructure.RabbitMQ) src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:117— Message (context Messaging) is exposed in Messaging.Infrastructure.RabbitMQ's public surface via RabbitMQMessageBroker.Publish — couples the contexts.
Cross-context type Message (Messaging → Messaging.Infrastructure.FileSystem) src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:76— Message (context Messaging) is exposed in Messaging.Infrastructure.FileSystem's public surface via FileStorageMessageBroker.Publish — couples the contexts.
Cross-context type Message (Messaging → Messaging.Infrastructure.Azure.SignalR) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:98— Message (context Messaging) is exposed in Messaging.Infrastructure.Azure.SignalR's public surface via SignalRServerlessMessageBroker.Publish — couples the contexts.
Cross-context type LogEvent (Operations → Operations.Infrastructure.Mongo) src/Operations.Infrastructure.Mongo/Logging/Repositories/MongoLogEventRepository.cs:9— LogEvent (context Operations) is exposed in Operations.Infrastructure.Mongo's public surface via MongoLogEventRepository..ctor — couples the contexts.
Cross-context type LogTrace (Tracing → Tracing.Infrastructure.Mongo) src/Tracing.Infrastructure.Mongo/Repositories/MongoLogTraceRepository.cs:9— LogTrace (context Tracing) is exposed in Tracing.Infrastructure.Mongo's public surface via MongoLogTraceRepository..ctor — couples the contexts.
FileTooLong: Foundation.ContentTypes/ContentType.cs src/Foundation.ContentTypes/ContentType.cs— FileTooLong — 1990 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 1490 over it, 3.98× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D4 · Code Duplication· Near-duplicate member family (7 members, 30 shared lines) · ×1
Near-duplicate member family (7 members, 30 shared lines) src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs:158— src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs:158-228 | src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:115-171 | src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:109-164 | src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:153-216 | src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs:149-209 | src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:166-222 | src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs:156-212 — These 7 members are variants of one another: a block of 30 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 7 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 7 times.
Near-duplicate member pair (70 shared lines) src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs:33— src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs:33-126 | src/Authentication.Application.Web/Basic/BasicAuthenticationHandler.cs:33-126 — These two members are variants of one another: 70 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
Duplicated block (59–62 lines × 2) src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:296— src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:296-354 | src/Queueing/InMemoryQueue.cs:308-369 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs` and `src/Queueing/InMemoryQueue.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 156 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (44 lines × 2) src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs:59— src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs:59-102 | src/Authentication.Application.Web/Basic/BasicAuthenticationHandler.cs:59-102 — before extracting anything, compare `src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs` and `src/Authentication.Application.Web/Basic/BasicAuthenticationHandler.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 91 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs:59` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16–36 lines × 2) src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:161— src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:161-176 | src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs:156-191 — before extracting anything, compare `src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs` and `src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 131 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:161` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (31 lines × 2) src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs:87— src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs:87-117 | src/ServiceDiscovery.Application/Registries/FileSystemServiceRegistry.cs:86-116 — before extracting anything, compare `src/ServiceDiscovery.Application/Registries/FileStorageServiceRegistry.cs` and `src/ServiceDiscovery.Application/Registries/FileSystemServiceRegistry.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (20–28 lines × 2) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:216— src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:216-235 | src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:186-213 — before extracting anything, compare `src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs` and `src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:216` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (26 lines × 2) src/Foundation.Utilities/Expressions/ExpressionExtensions.cs:55— src/Foundation.Utilities/Expressions/ExpressionExtensions.cs:55-80 | src/Foundation.Utilities/Expressions/ExpressionExtensions.cs:97-122 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Utilities/Expressions/ExpressionExtensions.cs:55` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (28 lines × 2) src/Operations.Infrastructure.Mongo/Logging/Repositories/Dto/MongoLogEvent.cs:51— src/Operations.Infrastructure.Mongo/Logging/Repositories/Dto/MongoLogEvent.cs:51-78 | src/Tracing.Infrastructure.Mongo/Repositories/Dto/MongoLogTrace.cs:51-78 — before extracting anything, compare `src/Operations.Infrastructure.Mongo/Logging/Repositories/Dto/MongoLogEvent.cs` and `src/Tracing.Infrastructure.Mongo/Repositories/Dto/MongoLogTrace.cs` as WHOLE FILES: 96% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Operations.Infrastructure.Mongo/Logging/Repositories/Dto/MongoLogEvent.cs:51` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13–25 lines × 7) src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs:172— src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs:172-196 | src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:128-152 | src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:122-146 | src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:164-176 | src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs:159-171 | src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:179-191 | src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs:169-181 — before extracting anything, compare `src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs` and `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 49 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:147` calls `UpsertAsync`, `AnyContext` and `src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:177` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (21 lines × 3) src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs:139— src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs:139-159 | src/Authentication.Application.Web/Basic/BasicAuthenticationHandler.cs:139-159 | src/Authentication.Application.Web/EasyAuth/EasyAuthAuthenticationHandler.cs:100-120 — before extracting anything, compare `src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs` and `src/Authentication.Application.Web/Basic/BasicAuthenticationHandler.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 91 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (23 lines × 3) src/Operations.Application/LoggingOptionsExtensions.cs:107— src/Operations.Application/LoggingOptionsExtensions.cs:107-129 | src/Operations.Infrastructure.Azure/LoggingOptionsExtensions.cs:147-169 | src/Operations.Infrastructure.Mongo/LoggingOptionsExtensions.cs:66-88 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (22 lines × 4) src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:82— src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:82-103 | src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:162-183 | src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:242-263 | src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:282-303 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (22 lines × 3) src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:42— src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:42-63 | src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:122-143 | src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:202-223 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (21 lines × 2) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:244— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:244-264 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:291-311 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs` and `src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 147 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (6–21 lines × 4) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:153— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:153-158 | src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:134-140 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:179-184 | src/Queueing/InMemoryQueue.cs:103-123 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs` and `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (12–20 lines × 3) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:216— src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:216-227 | src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:186-205 | src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:369-381 — before extracting anything, compare `src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs` and `src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:216` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (19–20 lines × 3) REDACTED:137— REDACTED:137-155 | REDACTED:223-242 | REDACTED:322-341 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `REDACTED:137` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (18 lines × 2) src/Foundation.Application.Web/Extensions/HttpRequestMessageExtensions.cs:43— src/Foundation.Application.Web/Extensions/HttpRequestMessageExtensions.cs:43-60 | src/Foundation.Application.Web/Extensions/HttpRequestMessageExtensions.cs:72-89 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (18–19 lines × 4) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:106— src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:106-123 | src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:95-112 | src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:85-102 | src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:126-144 — before extracting anything, compare `src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs` and `src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:106` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `Message` in one and `Domain.Message` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:126` calls `GetRoutingKey` and `src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:106` does not — after which the two agree again for 5 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (13–19 lines × 3) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:356— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:356-374 | src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:363-375 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:447-460 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs` and `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:356` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 4) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:222— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:222-238 | src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:331-347 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:264-280 | src/Queueing/InMemoryQueue.cs:347-363 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs` and `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:222` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (16 lines × 3) src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs:111— src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs:111-126 | src/Authentication.Application.Web/Basic/BasicAuthenticationHandler.cs:111-126 | src/Authentication.Application.Web/EasyAuth/EasyAuthAuthenticationHandler.cs:72-87 — before extracting anything, compare `src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs` and `src/Authentication.Application.Web/Basic/BasicAuthenticationHandler.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 91 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs:111` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15–17 lines × 7) src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs:214— src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs:214-228 | src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:156-171 | src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:149-164 | src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:200-216 | src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs:193-209 | src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs:206-222 | src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity}.cs:196-212 — before extracting anything, compare `src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs` and `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 49 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs:214` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (15 lines × 2) src/KeyValueStorage.Infrastructure.Azure/TableKeyValueStorage.cs:106— src/KeyValueStorage.Infrastructure.Azure/TableKeyValueStorage.cs:106-120 | src/KeyValueStorage.Infrastructure.Azure/TableKeyValueStorage.cs:127-141 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/KeyValueStorage.Infrastructure.Azure/TableKeyValueStorage.cs:106` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (15 lines × 4) src/KeyValueStorage.Infrastructure.LightningDb/LightningDbKeyValueStorage.cs:103— src/KeyValueStorage.Infrastructure.LightningDb/LightningDbKeyValueStorage.cs:103-117 | src/KeyValueStorage.Infrastructure.LightningDb/LightningDbKeyValueStorage.cs:121-135 | src/KeyValueStorage.Infrastructure.LightningDb/LightningDbKeyValueStorage.cs:139-153 | src/KeyValueStorage.Infrastructure.LightningDb/LightningDbKeyValueStorage.cs:157-171 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (12–16 lines × 2) src/Messaging.Application.Azure.SignalR/NaosExtensions.cs:43— src/Messaging.Application.Azure.SignalR/NaosExtensions.cs:43-58 | src/Messaging.Application.FileSystem/NaosExtensions.cs:49-60 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Messaging.Application.Azure.SignalR/NaosExtensions.cs:43` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (13 lines × 3) src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:219— src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:219-231 | src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:246-258 | src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:273-285 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
Duplicated block (13–14 lines × 2) src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:203— src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:203-215 | src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:172-185 — before extracting anything, compare `src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs` and `src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 90 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:203` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (10 lines × 3) src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs:38— src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs:38-47 | src/Authentication.Application.Web/Basic/BasicAuthenticationHandler.cs:38-47 | src/Authentication.Application.Web/EasyAuth/EasyAuthAuthenticationHandler.cs:31-40 — before extracting anything, compare `src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs` and `src/Authentication.Application.Web/Basic/BasicAuthenticationHandler.cs` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 91 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs:38` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11–12 lines × 4) src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:42— src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:42-52 | src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:69-79 | src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:91-101 | src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:164-175 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:42` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 3) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:54— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:54-64 | src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:60-70 | src/Queueing/InMemoryQueue.cs:47-57 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs` and `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:54` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10–11 lines × 4) src/Foundation.Domain.Repositories/Decorators/RepositoryDomainEventsDecorator.cs:87— src/Foundation.Domain.Repositories/Decorators/RepositoryDomainEventsDecorator.cs:87-96 | src/Foundation.Domain.Repositories/Decorators/RepositoryDomainEventsDecorator.cs:100-109 | src/Foundation.Domain.Repositories/Decorators/RepositoryDomainEventsDecorator.cs:113-122 | src/Foundation.Domain.Repositories/Decorators/RepositoryDomainEventsDecorator.cs:131-141 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Domain.Repositories/Decorators/RepositoryDomainEventsDecorator.cs:87` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (10–11 lines × 2) src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/IncludeIf.cs:18— src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/IncludeIf.cs:18-27 | src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/IncludeIf.cs:48-58 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/IncludeIf.cs:18` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9–10 lines × 5) src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:45— src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:45-53 | src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:72-80 | src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:94-102 | src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:167-176 | src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:225-233 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:45` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (8–10 lines × 2) src/Commands.Application/NaosExtensions.cs:21— src/Commands.Application/NaosExtensions.cs:21-30 | src/Messaging.Application/NaosExtensions.cs:19-26 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/Commands.Application/NaosExtensions.cs:21` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
Duplicated block (9–10 lines × 2) src/Commands.Application.Web/Middleware/Extensions/MediatorDispatcherCommandRequestExtension.cs:31— src/Commands.Application.Web/Middleware/Extensions/MediatorDispatcherCommandRequestExtension.cs:31-40 | src/Commands.Application.Web/Middleware/Extensions/MediatorDispatcherCommandRequestExtension.cs:64-72 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Commands.Application.Web/Middleware/Extensions/MediatorDispatcherCommandRequestExtension.cs:31` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 4) REDACTED:71— REDACTED:71-79 | REDACTED:137-145 | REDACTED:223-231 | REDACTED:322-330 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `REDACTED:147` calls `Append`, `BuildOrderingSelect`, `BuildPagingSelect` and `REDACTED:81` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6–9 lines × 2) src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:156— src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:156-164 | src/Queueing/InMemoryQueue.cs:93-98 — before extracting anything, compare `src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs` and `src/Queueing/InMemoryQueue.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 74 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:156` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
Duplicated block (8–9 lines × 2) src/Commands.Application.Web/Middleware/Extensions/QueueDispatcherCommandRequestExtension.cs:47— src/Commands.Application.Web/Middleware/Extensions/QueueDispatcherCommandRequestExtension.cs:47-54 | src/Commands.Application.Web/Middleware/Extensions/QueueDispatcherCommandRequestExtension.cs:67-75 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Commands.Application.Web/Middleware/Extensions/QueueDispatcherCommandRequestExtension.cs:47` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Commands.Application.Web/Middleware/Extensions/QueueDispatcherCommandRequestExtension.cs:76` calls `LogInformation` and `src/Commands.Application.Web/Middleware/Extensions/QueueDispatcherCommandRequestExtension.cs:56` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7–8 lines × 4) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:57— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:57-63 | src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:63-69 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:60-67 | src/Queueing/InMemoryQueue.cs:50-56 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs` and `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:57` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:59` calls `GetType`, `PrettyName`, `GetRoutingKey` and `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:63` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7–8 lines × 2) src/Authentication.Application.Web/Basic/BasicAuthenticationHandler.cs:44— src/Authentication.Application.Web/Basic/BasicAuthenticationHandler.cs:44-51 | src/Authentication.Application.Web/Basic/BasicAuthenticationHandler.cs:100-106 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Authentication.Application.Web/Basic/BasicAuthenticationHandler.cs:44` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 5) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:209— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:209-214 | src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:218-223 | src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:322-327 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:251-256 | src/Queueing/InMemoryQueue.cs:338-343 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs` and `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:209` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (5 lines × 4) src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:173— src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:173-177 | src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:167-171 | src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:205-209 | src/Queueing/InMemoryQueue.cs:171-175 — before extracting anything, compare `src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs` and `src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs` as WHOLE FILES: this scan already matched 9 separate duplicated blocks between them, totalling at least 101 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
Duplicated block (5 lines × 3) src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:96— src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:96-100 | src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:111-115 | src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:135-139 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:96` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:118` calls `WriteAsync`, `AnyContext` and `src/Operations.Application.Web/Controllers/NaosOperationsHealthController.cs:142` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (27 lines × 2) src/Operations.Infrastructure.Mongo/NaosExtensions.cs:19— src/Operations.Infrastructure.Mongo/NaosExtensions.cs:19-45 | src/Tracing.Infrastructure.Mongo/NaosExtensions.cs:19-45 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (84 lines × 2) src/Foundation.Domain.Repositories/GenericRepository.cs:18— src/Foundation.Domain.Repositories/GenericRepository.cs:18-146 | src/Foundation.Domain.Repositories/ReadOnlyGenericRepository.cs:18-101 — before extracting anything, compare `src/Foundation.Domain.Repositories/GenericRepository.cs` and `src/Foundation.Domain.Repositories/ReadOnlyGenericRepository.cs` as WHOLE FILES: 92% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (29 lines × 2) src/Operations.Application/CamelCasedJsonFormatter.cs:21— src/Operations.Application/CamelCasedJsonFormatter.cs:21-58 | src/Operations.Infrastructure.Mongo/CamelCasedMongoDBJsonFormatter.cs:22-50 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (7 lines × 5) src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs:125— src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs:125-131 | src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:82-88 | src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:76-82 | src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:120-126 | src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs:116-122 — before extracting anything, compare `src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs` and `src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 49 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
End-of-life runtime: .NET netcoreapp3.1 tests/UnitTests/UnitTests.csproj:4— tests/UnitTests/UnitTests.csproj declares .NET netcoreapp3.1 as this project's target framework, and .NET Core 3.1 LTS, support ended 2022-12-13. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2022-12-13 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
Hollow method — returns a constant without doing the work src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs:352— `AddContainsFromExpression` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
Condition was already decided — an earlier guard makes this test constant src/Foundation.Utilities/Expando/PropertyBag.cs:313— Control only reaches here when `type == typeof(float)` is false, because the guard on line 298 exits otherwise. This test is therefore always false and everything it guards is unreachable. Implement the distinction that was intended, or delete the test.
P12 · CI test-gate honesty· Coverage collected but not gated · ×1
Coverage collected but not gated — CI collects a coverage report but no step enforces a minimum — coverage could halve and CI stays green. Add a step that fails the build when coverage drops below a floor (your coverage tool's minimum-threshold flag, or a coverage-gate action) so the number guards something. What was searched, so you can tell an absence from a miss: this repository's CI files AND its coverage configuration — the well-known coverage and test-runner config files, read at the repository root and inside workspace package directories two levels down, so a floor declared beside the tests rather than in the pipeline is credited — matched against the threshold settings this check knows by name. A floor set in your coverage service's web UI rather than in a committed file, or under a setting whose name is not one of those, is not seen here.
S1 · Web-Security Posture· The crypto stream is used against the mode it was opened with · ×1
The crypto stream is used against the mode it was opened with src/Foundation.Utilities/EncryptionHelper.cs:99— Here `Write` is called on a `CryptoStream` opened with `CryptoStreamMode.Read`. A `CryptoStream` is one-directional by construction: `CryptoStreamMode.Read` leaves `CanWrite` false and `CryptoStreamMode.Write` leaves `CanRead` false, and the mismatched call throws `NotSupportedException` before a single byte reaches the transform. So this encrypt/decrypt routine can never succeed for any input — every caller gets an exception, or, where a broad `catch` swallows it, silently gets nothing back and believes the data was protected or recovered. Open the stream for the direction the code uses it in: `CryptoStreamMode.Write` when the routine writes bytes or text INTO the stream and reads the result off the underlying `MemoryStream`, `CryptoStreamMode.Read` when it reads the transformed bytes OUT of the stream — and add a round-trip test (`Decrypt(Encrypt(x)) == x`) that exercises this overload, which is the test that would have caught it.
SC1 · Supply-chain hygiene· NuGet dependencies are not locked · ×1
NuGet dependencies are not locked — No packages.lock.json and no central package management — restores aren't reproducible or pinned (SSDF PW.4.4). Enable <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> (commit the lockfile) or adopt Directory.Packages.props. Advisory — never scored.
Blocking `FileStorageMessageBroker.GetFileContents` inside an `async` method src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:146— `FileStorageMessageBroker.GetFileContents` is a synchronous helper that blocks (`Thread.Sleep`): called from an `async` method it parks the thread exactly as the inline call would. Make the helper `async` and `await` it (`await Task.Delay`, `SemaphoreSlim.WaitAsync`, a `TaskCompletionSource` instead of the poll).
async void method: RunSchedulerAsync src/JobScheduling.Application/JobSchedulerHostedService.cs:70— `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
X18 · Disposal-pattern correctness· Disposable created and abandoned in the method that made it · ×1
Disposable created and abandoned in the method that made it src/Foundation.Utilities/StreamHelper.cs:48— `sw` is a `StreamWriter`, which implements `IDisposable`, and it is created here (line 48). Every use of it in `ToStream` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var sw = …;`), which releases it at the end of the scope on every path including a throw.
X5 · Nullable reference types· Null guard scopes only part of the work it protects · ×1
Null guard scopes only part of the work it protects src/Foundation.Utilities/Expando/PropertyBag.cs:119— This method contradicts itself about `value`: line 72 tests it for null before doing anything with it — the author's own statement that null is an input this code expects — but that `if` scopes only the block beneath it, and line 119 then dereferences `value` as `value.GetType` AFTER the block has closed, where the guard no longer applies. A null `value` skips the guarded body and reaches that line anyway, throwing NullReferenceException on exactly the input the guard was written for. If the dereference belongs to the guarded work, move it inside the block; if `value` truly cannot be null by then, the guard above is misleading and should go.
Orphaned file src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Foundation.Utilities/Retry.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Messaging.Infrastructure.Azure/ServiceBus/ServiceBusMessageBroker.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Queueing/InMemoryQueue.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Commands.Application.Web/CommandRequestOptionsExtensions.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/KeyValueStorage.Infrastructure.Azure/TableKeyValueStorage.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/FileStorage.Infrastructure.Ssh/SshNetFileStorage.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Foundation.Application.Web/Extensions/HttpRequestMessageExtensions.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file GlobalSuppressions.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Foundation.Utilities/Expando/Expando.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file REDACTED:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V3/CosmosSqlProviderV3.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Application.Web/NaosExtensions.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Foundation.Utilities/Expando/PropertyBag.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/KeyValueStorage.Infrastructure.FileStorage/FileStorageKeyValueStorage.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Orphaned file src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:1— No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
Interpolated log message defeats structured logging src/Application/HttpClientBuilderExtensions.cs:53— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Application/HttpClientBuilderExtensions.cs:63— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Application.Web/Controllers/NaosReadOnlyGenericRepositoryControllerBase.cs:42— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Application.Web/Client/Handlers/HttpClientLogHandler.cs:115— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Application.Web/Filters/OperationCancelledExceptionFilterAttribute.cs:31— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Domain/Events/Handlers/EntityInsertDomainEventHandler.cs:20— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Domain/Events/Handlers/EntityUpdateDomainEventHandler.cs:20— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:28— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:152— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:201— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:24— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:146— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs:194— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:185— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:207— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:232— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V2/CosmosSqlProviderV2.cs:247— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Provider/V3/CosmosSqlProviderV3.cs:299— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Infrastructure.Azure.LogAnalytics/Repositories/LogAnalyticsRepository.cs:46— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Foundation.Infrastructure.Azure.LogAnalytics/Repositories/LogAnalyticsRepository.cs:86— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Messaging/Domain/Handlers/DummyMessageHandler.cs:34— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Messaging/Domain/Handlers/EchoEntityMessageHandler.cs:26— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Messaging/Domain/Handlers/EchoMessageHandler.cs:34— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Messaging/Domain/Handlers/EntityMessageHandler.cs:33— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Interpolated log message defeats structured logging src/Messaging.Infrastructure.RabbitMQ/RabbitMQMessageBroker.cs:94— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
+ 15 more in this group — see findings.md.
P2 · Observability· Console output used as the logging channel · ×29
Console output used as the logging channel src/Foundation.Application.Web/Console/Commands/OpenBrowserConsoleCommandEventHandler.cs:52— `src/Foundation.Application.Web/Console/Commands/OpenBrowserConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 52 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs:26— `src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 26 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs:33— `src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 33 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs:42— `src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 42 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs:48— `src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 48 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs:57— `src/JobScheduling.Application/Console/JobSchedulerConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 57 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Messaging.Application/Console/MessagingConsoleCommandEventHandler.cs:27— `src/Messaging.Application/Console/MessagingConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 27 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Messaging.Application/Console/MessagingConsoleCommandEventHandler.cs:32— `src/Messaging.Application/Console/MessagingConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 32 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Queueing.Application/Console/QueueingConsoleCommandEventHandler.cs:26— `src/Queueing.Application/Console/QueueingConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 26 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Queueing.Application/Console/QueueingConsoleCommandEventHandler.cs:56— `src/Queueing.Application/Console/QueueingConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 56 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Foundation.Console/App/InteractiveConsoleHostedService.cs:39— `src/Foundation.Console/App/InteractiveConsoleHostedService.cs` reports through `Console.Write…` at line 39 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Foundation.Console/App/InteractiveConsoleHostedService.cs:57— `src/Foundation.Console/App/InteractiveConsoleHostedService.cs` reports through `Console.Write…` at line 57 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Foundation.Console/App/InteractiveConsoleHostedService.cs:92— `src/Foundation.Console/App/InteractiveConsoleHostedService.cs` reports through `Console.Write…` at line 92 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Foundation.Console/App/InteractiveConsoleHostedService.cs:108— `src/Foundation.Console/App/InteractiveConsoleHostedService.cs` reports through `Console.Write…` at line 108 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Foundation.Console/App/InteractiveConsoleHostedService.cs:120— `src/Foundation.Console/App/InteractiveConsoleHostedService.cs` reports through `Console.Write…` at line 120 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Foundation.Console/App/InteractiveConsoleHostedService.cs:127— `src/Foundation.Console/App/InteractiveConsoleHostedService.cs` reports through `Console.Write…` at line 127 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Foundation.Console/App/InteractiveConsoleHostedService.cs:128— `src/Foundation.Console/App/InteractiveConsoleHostedService.cs` reports through `Console.Write…` at line 128 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Foundation.Console/Commands/EchoConsoleCommandEventHandler.cs:28— `src/Foundation.Console/Commands/EchoConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 28 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Foundation.Console/Commands/ExitConsoleCommandEventHandler.cs:34— `src/Foundation.Console/Commands/ExitConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 34 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Foundation.Console/Commands/HistoryConsoleCommandEventHandler.cs:16— `src/Foundation.Console/Commands/HistoryConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 16 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs:24— `src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 24 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs:25— `src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 25 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs:26— `src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 26 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs:27— `src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 27 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs:28— `src/Foundation.Console/Commands/ProcessConsoleCommandEventHandler.cs` reports through `Console.Write…` at line 28 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Duplicated predicate src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs:215— `!take.HasValue && defaultTakeSize.HasValue` appears character-identically in 2 files — src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs, src/Foundation.Infrastructure.Documents.Sqlite/Provider/SqliteBuilder.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs:114— `!timeout.HasValue || timeout.Value.Ticks == 0` appears character-identically in 2 files — src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs, src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Queueing/InMemoryQueue.cs:347— `autoComplete && !item.IsAbandoned && !item.IsCompleted` appears character-identically in 4 files — src/Queueing.Infrastructure.Azure/ServiceBus/AzureServiceBusQueue.cs, src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs, src/Queueing.Infrastructure.RabbitMQ/RabbitMQQueue.cs, src/Queueing/InMemoryQueue.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Extensions/SkipIf.cs:12— `condition == true && count.HasValue && count.Value > 0` appears character-identically in 2 files — src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Extensions/SkipIf.cs, src/Foundation.Infrastructure.Azure.Cosmos/Repositories/Extensions/TakeIf.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Foundation.Domain.Repositories/Decorators/RepositorySpecificationDecorator.cs:51— `entity != null && this.specification.IsSatisfiedBy(entity)` appears character-identically in 2 files — src/Foundation.Domain.Repositories/Decorators/RepositorySpecificationDecorator.cs, src/Foundation.Domain.Repositories/Decorators/RepositoryStateSoftDeleteDecorator.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:121— `entity.Id.IsDefault() || !await this.ExistsAsync(entity.Id).AnyContext()` appears character-identically in 5 files — src/Foundation.Domain.Repositories.Documents/DocumentRepository.cs, src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs, src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs, src/Foundation.Infrastructure.Mongo/Repositories/MongoRepository{TEntity,TDestination}.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs:133— `entity.Message?.Length > 5 && entity.Message.Take(6).All(char.IsUpper)` appears character-identically in 2 files — src/Operations.Application.Web/Controllers/NaosOperationsLogEventsController.cs, src/Operations.Application.Web/Controllers/NaosOperationsLogTracesController.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Queueing/InMemoryQueue.cs:332— `linkedCancellationToken.IsCancellationRequested || item == null` appears character-identically in 2 files — src/Queueing.Infrastructure.Azure/Storage/AzureStorageQueue.cs, src/Queueing/InMemoryQueue.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs:172— `message.Properties.ContainsKey("TraceId") && message.Properties.ContainsKey("SpanId")` appears character-identically in 2 files — src/Messaging.Infrastructure.Azure.SignalR/SignalRServerlessMessageBroker.cs, src/Messaging.Infrastructure.FileSystem/FileStorageMessageBroker.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Foundation.Criteria/CriteriaExtensions.cs:36— `metaDataValue != null && metaDataValue.Equals(value, StringComparison.OrdinalIgnoreCase)` appears character-identically in 2 files — src/Foundation.ContentTypes/ContentTypeExtensions.cs, src/Foundation.Criteria/CriteriaExtensions.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/OrderByIf.cs:19— `options?.Order == null && options?.Orders.IsNullOrEmpty() == true` appears character-identically in 3 files — src/Foundation.Infrastructure.EntityFramework/Repositories/Extensions/OrderByIf.cs, src/Foundation.Infrastructure.Mongo/Repositories/Extensions/IFindFluentExtensions.cs, src/Foundation.Infrastructure.Mongo/Repositories/Extensions/OrderByIf.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity,TDestination}.cs:94— `options?.Skip.HasValue == true && options.Skip.Value > 0` appears character-identically in 2 files — src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity,TDestination}.cs, src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity,TDestination}.cs:99— `options?.Take.HasValue == true && options.Take.Value > 0` appears character-identically in 2 files — src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity,TDestination}.cs, src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs:191— `searchPattern != null && wildcardPos >= 0` appears character-identically in 3 files — src/FileStorage.Infrastructure.Azure/AzureBlobFileStorage.cs, src/FileStorage.Infrastructure.Azure/AzureFileShareStorage.cs, src/FileStorage.Infrastructure.Ssh/SshNetFileStorage.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Foundation.Application.Web/Extensions/HttpRequestMessageExtensions.cs:293— `source == null || key.IsNullOrEmpty() || (value.IsNullOrEmpty() && !allowEmptyValue)` appears character-identically in 3 files — src/Foundation.Application.Web/Extensions/HttpRequestMessageExtensions.cs, src/Foundation.Application.Web/Extensions/HttpResponseExtensions.cs, src/Foundation.Application.Web/Extensions/HttpResponseMessageExtensions.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Foundation.Application.Web/Extensions/HttpRequestMessageExtensions.cs:156— `source == null || source.Headers == null` appears character-identically in 2 files — src/Foundation.Application.Web/Extensions/HttpRequestMessageExtensions.cs, src/Foundation.Application.Web/Extensions/HttpResponseMessageExtensions.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs:220— `take.Value > maxTakeSize && maxTakeSize.HasValue` appears character-identically in 2 files — src/Foundation.Infrastructure.Documents.SqlServer/Provider/SqlBuilder.cs, src/Foundation.Infrastructure.Documents.Sqlite/Provider/SqliteBuilder.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Tracing.Domain/Model/LogTrace.cs:79— `this.EndTime.HasValue && this.StartTime.HasValue` appears character-identically in 2 files — src/Tracing.Domain/Model/LogTrace.cs, src/Tracing.Domain/Model/Span/Span.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity,TDestination}.cs:56— `this.Options.Mapper != null && result != null` appears character-identically in 2 files — src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity,TDestination}.cs, src/Foundation.Domain.Repositories/InMemory/InMemoryRepository{TEntity}.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs:128— `this.Options.PublishEvents && this.Options.Mediator != null` appears character-identically in 6 files — src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity,TDestination}.cs, src/Foundation.Infrastructure.Azure.Cosmos/Repositories/CosmosSqlRepository{TEntity}.cs, src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs, src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs:38— `this.Request.Host.Host.SafeEquals("localhost") && this.Options.IgnoreLocal` appears character-identically in 3 files — src/Authentication.Application.Web/ApiKey/ApiKeyAuthenticationHandler.cs, src/Authentication.Application.Web/Basic/BasicAuthenticationHandler.cs, src/Authentication.Application.Web/EasyAuth/EasyAuthAuthenticationHandler.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Messaging.Infrastructure.RabbitMQ/RabbitMQProvider.cs:38— `this.connection?.IsOpen == true && !this.disposed` appears character-identically in 2 files — src/Messaging.Infrastructure.RabbitMQ/RabbitMQProvider.cs, src/Queueing.Infrastructure.RabbitMQ/RabbitMQProvider.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs:286— `typeof(TEntity).GetProperty("Id")?.PropertyType == typeof(Guid) && value?.GetType() == typeof(string)` appears character-identically in 2 files — src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity,TDestination}.cs, src/Foundation.Infrastructure.EntityFramework/Repositories/EntityFrameworkRepository{TEntity}.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
DM2 · Strongly-typed ids· Primitive id on a domain type · ×21
Primitive id on a domain type: DomainEventBase.EventId src/Foundation.Domain/Events/DomainEventBase.cs:34— `DomainEventBase.EventId` is a raw `Guid` — give it a strongly-typed id: a dedicated single-field type wrapping the `Guid`, in whatever form your language spells that.
Primitive id on a domain type: DomainEventBase.CorrelationId src/Foundation.Domain/Events/DomainEventBase.cs:42— `DomainEventBase.CorrelationId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: TenantEntity.TenantId src/Foundation.Domain/Model/TenantEntity.cs:14— `TenantEntity.TenantId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: Message.CorrelationId src/Messaging/Domain/Model/Message.cs:58— `Message.CorrelationId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: LogEvent.Key src/Operations.Domain/Logging/Model/LogEvent.cs:36— `LogEvent.Key` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: LogEvent.CorrelationId src/Operations.Domain/Logging/Model/LogEvent.cs:46— `LogEvent.CorrelationId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: LogEvent.TrackId src/Operations.Domain/Logging/Model/LogEvent.cs:58— `LogEvent.TrackId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: Command.CorrelationId src/Commands.Domain/Model/Command.cs:26— `Command.CorrelationId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: QueueItem.CorrelationId src/Queueing/Domain/Model/QueueItem.cs:29— `QueueItem.CorrelationId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: QueueItem.TraceId src/Queueing/Domain/Model/QueueItem.cs:31— `QueueItem.TraceId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: QueueItem.SpanId src/Queueing/Domain/Model/QueueItem.cs:33— `QueueItem.SpanId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: LogTrace.Key src/Tracing.Domain/Model/LogTrace.cs:36— `LogTrace.Key` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: LogTrace.CorrelationId src/Tracing.Domain/Model/LogTrace.cs:46— `LogTrace.CorrelationId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: LogTrace.TrackId src/Tracing.Domain/Model/LogTrace.cs:58— `LogTrace.TrackId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: LogTrace.TraceId src/Tracing.Domain/Model/LogTrace.cs:62— `LogTrace.TraceId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: LogTrace.SpanId src/Tracing.Domain/Model/LogTrace.cs:64— `LogTrace.SpanId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: LogTrace.ParentSpanId src/Tracing.Domain/Model/LogTrace.cs:66— `LogTrace.ParentSpanId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: Span.TraceId src/Tracing.Domain/Model/Span/Span.cs:29— `Span.TraceId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: Span.SpanId src/Tracing.Domain/Model/Span/Span.cs:34— `Span.SpanId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: Span.ParentSpanId src/Tracing.Domain/Model/Span/Span.cs:36— `Span.ParentSpanId` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Primitive id on a domain type: Span.LogKey src/Tracing.Domain/Model/Span/Span.cs:40— `Span.LogKey` is a raw `String` — give it a strongly-typed id: a dedicated single-field type wrapping the `String`, in whatever form your language spells that.
Mutable entity: QueueItem src/Queueing/Domain/Model/QueueItem.cs:8— `QueueItem` exposes publicly writable state (CorrelationId, TraceId, SpanId, Data, EnqueuedDate, RenewedDate, and 4 more).
Mutable entity: LogTrace src/Tracing.Domain/Model/LogTrace.cs:10— `LogTrace` exposes publicly writable state (Id, Level, Key, Environment, Message, Timestamp, and 20 more).
Mutable entity: Span src/Tracing.Domain/Model/Span/Span.cs:10— `Span` exposes publicly writable state (LogKey).
X23 · Unguarded diagnostic materialisation· Diagnostic log message is built whether or not it is wanted · ×7
Diagnostic log message is built whether or not it is wanted src/Commands.Application/Handlers/BaseCommandHandler.cs:105— `LogDebug` at line 105 is called with an argument built by `behaviors.Select(e => e.GetType().PrettyName())` (line 105), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because LogDebug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region.
Diagnostic log message is built whether or not it is wanted src/Commands.Application/Handlers/BaseCommandHandler.cs:123— `LogDebug` at line 123 is called with an argument built by `behaviors.Select(e => e.GetType().PrettyName())` (line 123), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because LogDebug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region.
Diagnostic log message is built whether or not it is wanted src/Filtering.Application/Web/FilterContextFactory.cs:107— `LogDebug` at line 107 is called with an argument built by `result.Select(c => c.ToString())` (line 107), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because LogDebug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region.
Diagnostic log message is built whether or not it is wanted src/Filtering.Application/Web/FilterContextFactory.cs:138— `LogDebug` at line 138 is called with an argument built by `result.Select(o => o.ToString())` (line 138), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because LogDebug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region.
Diagnostic log message is built whether or not it is wanted src/Tracing.Domain/Events/SpanEndedLoggerDomainEventHandler.cs:58— `LogDebug` at line 58 is called with an argument built by `string.Join("|", notification.Span.Tags.Select(t => $"{t.Key}={t.Value}"))` (line 58), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because LogDebug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region.
Diagnostic log message is built whether or not it is wanted src/Commands.Application.Web/Middleware/CommandRequestMiddleware.cs:119— `LogDebug` at line 119 is called with an argument built by `extensions.Select(e => e.GetType().PrettyName())` (line 119), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because LogDebug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region.
Diagnostic log message is built whether or not it is wanted src/Commands.Application.Web/Middleware/CommandRequestMiddleware.cs:143— `LogDebug` at line 143 is called with an argument built by `extensions.Select(e => e.GetType().PrettyName())` (line 143), whose cost grows with the collection it walks. C# evaluates a call's arguments BEFORE entering the method, so that join/projection runs in full every time this line is reached — and then the level check inside the logger discards the string it produced, because LogDebug is a level a shipped configuration normally leaves off. Nothing here decides beforehand whether the message is wanted: no `IsEnabled` test, no debug flag, no conditional-compilation region.
Pass-through layer src/Foundation.Serialization/Serializers/RijndaelSerializer.cs:139— IndisposableStream: all 5 public methods forward their arguments unchanged to stream and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call stream directly, or give the layer a job.
Pass-through layer src/Operations.Application/LoggingAdapter.cs:6— LoggingAdapter: all 3 public methods forward their arguments unchanged to adaptee and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call adaptee directly, or give the layer a job.
Pass-through layer src/Operations.Application/LoggingAdapter{T}.cs:6— LoggingAdapter: all 3 public methods forward their arguments unchanged to adaptee and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call adaptee directly, or give the layer a job.
Pass-through layer src/Queueing/Domain/Decorators/FileStorageQueueDecorator.cs:7— FileStorageQueueDecorator: all 11 public methods forward their arguments unchanged to inner and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call inner directly, or give the layer a job.
Fat interface: IQueueItem<TData> (19 members) src/Queueing/Domain/Model/IQueueItem.cs:7— `IQueueItem<TData>` declares 19 members: `Id`, `CorrelationId`, `TraceId`, `SpanId`, `Data`, `IsCompleted`, `IsAbandoned`, `EnqueuedDate`, `RenewedDate`, `DequeuedDate`, `Attempts`, `ProcessingTime`, `TotalTime`, `Properties`, `MarkAbandoned`, `MarkCompleted`, `RenewLockAsync`, `AbandonAsync`, `CompleteAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: ISpan (25 members) src/Tracing.Domain/Model/ISpan.cs:7— `ISpan` declares 25 members: `OperationName`, `TraceId`, `SpanId`, `ParentSpanId`, `Kind`, `LogKey`, `Status`, `IsSampled`, `StatusDescription`, `StartTime`, `EndTime`, `Tags`, `Logs`, `Duration`, `Start`, `End`, `WithOperationName`, `WithLogKey`, `SetSpanId`, `WithTag`, `WithTags`, `SetStatus`, `SetSampled`, `AddLog`, `AddLog`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. Those 25 declarations carry 24 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 24 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
Fat interface: IDocumentProvider<T> (17 members) src/Foundation.Domain.Repositories.Documents/Provider/IDocumentProvider.cs:9— `IDocumentProvider<T>` declares 17 members under just 9 distinct name(s): `CountAsync`, `CountAsync`, `ResetAsync`, `ExistsAsync`, `UpsertAsync`, `Upsert`, `UpsertAsync`, `LoadKeysAsync`, `LoadKeysAsync`, `LoadDataAsync`, `LoadDataAsync`, `LoadDataAsync`, `LoadValuesAsync`, `LoadValuesAsync`, `LoadValuesAsync`, `DeleteAsync`, `DeleteAsync`. Counted as the author wrote them — a property is ONE member and its get/set accessors are not counted separately, and an event counts once. That is an OVERLOAD SET, not 17 separate responsibilities: a caller binds to 9 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 17 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
D34 · Knowledge Freshness· Most significant orphaned file · ×3
Most significant orphaned file src/Foundation.ContentTypes/ContentType.cs:1— One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
Most significant orphaned file src/Foundation.Utilities/Expressions/ExpressionExtensions.cs:1— One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
Most significant orphaned file REDACTED:1— One of the orphaned files carrying the most lost knowledge — ranked by size weighted by the file's role in the codebase, the same weighting behind the score above, so core code outranks equally large plumbing. A reasonable place to start a read-through before the aggregate risk above bites.
ED3 · Event naming· Event not named in past tense · ×3
Event not named in past tense: EntityDeleteDomainEvent src/Foundation.Domain/Events/EntityDeleteDomainEvent.cs:3— `EntityDeleteDomainEvent` reads as an instruction, not a fact that happened. Events describe something that already occurred — name them in the past tense (e.g. `OrderPlaced`, `PaymentCaptured`) so the ubiquitous language stays clear.
Event not named in past tense: EntityInsertDomainEvent src/Foundation.Domain/Events/EntityInsertDomainEvent.cs:3— `EntityInsertDomainEvent` reads as an instruction, not a fact that happened. Events describe something that already occurred — name them in the past tense (e.g. `OrderPlaced`, `PaymentCaptured`) so the ubiquitous language stays clear.
Event not named in past tense: EntityUpdateDomainEvent src/Foundation.Domain/Events/EntityUpdateDomainEvent.cs:3— `EntityUpdateDomainEvent` reads as an instruction, not a fact that happened. Events describe something that already occurred — name them in the past tense (e.g. `OrderPlaced`, `PaymentCaptured`) so the ubiquitous language stays clear.
Silent fallback default in catch src/FileStorage/Utility/PathHelper.cs:59— `GetDataDirectory` swallows every exception into `return null;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
Silent fallback default in catch REDACTED:61— `Verify` swallows `the exception` into `return false;` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
redundant comment tests/UnitTests/KeyValueStorage/KeyValueStorageBaseTests.cs:162— "Id is not a valid name, causes cosmos errors (ignored)" — delete - generated by an analyzer restating Id's invalidness
D28 · Secrets (history)· Rotate the exposed credentials · ×1
Dormant codebase — 271 of 271 significant files have no living knowledge — the codebase as a whole is dormant, not 271 separate risks. Counted over 271 of the 883 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over. Re-engage owners or document before change.
DM8 · Value-object opportunities· Primitive data clump · ×1
Primitive data clump: [orderdescending, skip, take] src/Foundation.Domain.Repositories.Documents/Provider/IDocumentProvider.cs:32— The parameters [orderdescending, skip, take] travel together across 8 signatures and were confirmed as a coherent concept by the model — that's a missing value object. Extracting them into one type (e.g. `Address`, `Money`, `Coordinate`) removes repetition, prevents argument-order mistakes, and gives the concept a home for its rules.
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
README/code drift README.md:191— README advertises a microservices architecture, but the repo is a single project with no service manifests — searched for: `microservice`, `service-mesh`, `istio`. Each was matched case- and separator-insensitively against file and directory NAMES anywhere in the tree, and against the CONTENTS of manifest and configuration files (package.json and other *.json, *.csproj, *.props, *.sln/*.slnx, *.yml, *.toml, *.config, tool configs such as eslint.config.js, Dockerfile); the README's own prose never counts, so a claim is never refuted by merely being made. Nothing outside that search was read — a footprint living only in a submodule, in a file type not listed here, or under a name none of those terms matches is not seen, and this row is then wrong.
P12 · CI test-gate honesty· Sleep-based test synchronization · ×1
Sleep-based test synchronization — 17 Task.Delay/Thread.Sleep call(s) in test code synchronize with background work by sleeping — a known flakiness precursor on slow runners. Prefer polling with a deadline or completion signals.
No changelog — No CHANGELOG/HISTORY/RELEASES file — what shipped when isn't easy to reconstruct for support or audit. (Versioning/tagging makes releases traceable, but a changelog records the what.)
OIDC metadata fetched over HTTP src/Authentication.Application.Web/NaosExtensions.cs:106— `RequireHttpsMetadata = false` allows the OIDC discovery doc to be fetched over plain HTTP. Safe for loopback-only fetches (Aspire / on-host); risky for any other path.
No security response headers detected — None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. (−2.0 on this card.)
No app-layer HTTPS enforcement detected — No UseHttpsRedirection/UseHsts and no reverse-proxy signal — transport security is unverified at the app layer. (−2.0 on this card.)
Secure cookie flags not detected src/Authentication.Application.Web/NaosExtensions.cs:98— No CookieSecurePolicy/HttpOnly/SameSite configuration found. (−1.5 on this card; skip if the app sets no cookies.)
X2 · Cancellation propagation· Not all async methods take a CancellationToken · ×1
Not all async methods take a CancellationToken — Only 207/549 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
Nullable reference types not enabled everywhere — 0/4 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
Skipped (documented): FindAllAsync_WithNotSpecification_Test tests/Sample.IntegrationTests/Customers/Domain/Repositories/OrderRepositoryTests.cs:150— Skipped with a documented reason — a deferral, not lazy debt: expression mapping issue
Skipped (documented): FindAllAsync_WithTenantExtension_Test tests/Sample.IntegrationTests/Inventory/Domain/Repositories/ReplenishmentRepositoryTests.cs:76— Skipped with a documented reason — a deferral, not lazy debt: unresolved expression mapping issue
Skipped (documented): ResponseTest tests/Sample.IntegrationTests/RootControllerTests.cs:12— Skipped with a documented reason — a deferral, not lazy debt: testhost not found
Skipped (documented): Benchmark tests/Foundation.UnitTests/Serialization/Base64SerializerTests.cs:32— Skipped with a documented reason — a deferral, not lazy debt: Skip benchmarks for now
Skipped (documented): Benchmark tests/Foundation.UnitTests/Serialization/BsonDataSerializerTests.cs:32— Skipped with a documented reason — a deferral, not lazy debt: Skip benchmarks for now
Skipped (documented): Benchmark tests/Foundation.UnitTests/Serialization/CsvSerializerTests.cs:20— Skipped with a documented reason — a deferral, not lazy debt: Skip benchmarks for now
Skipped (documented): Benchmark tests/Foundation.UnitTests/Serialization/HexSerializerTests.cs:32— Skipped with a documented reason — a deferral, not lazy debt: Skip benchmarks for now
Skipped (documented): Benchmark tests/Foundation.UnitTests/Serialization/JsonNetSerializerTests.cs:32— Skipped with a documented reason — a deferral, not lazy debt: Skip benchmarks for now
Skipped (documented): Benchmark tests/Foundation.UnitTests/Serialization/MessagePackSerializerTests.cs:32— Skipped with a documented reason — a deferral, not lazy debt: Skip benchmarks for now
Off the main sequence: Abstractions src/Foundation.Abstractions/Abstractions.csproj:1— Abstractions: abstractness 0.11, instability 0.07, distance 0.82 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Off the main sequence: Operations.Abstractions src/Operations.Abstractions/Operations.Abstractions.csproj:1— Operations.Abstractions: abstractness 0.00, instability 0.20, distance 0.80 — the shape a shared-kernel / building-block library has BY DESIGN — concrete and widely depended-on is what makes it useful, and this dimension does not penalise it (the distance is reported for completeness, not as a defect). Worth a look only if it has grown past one coherent kernel into an everything-bucket.
Foundation.Domain.EventSourcing: 2 contract type(s) expose producer-owned ids/enums — In Foundation.Domain.EventSourcing, 2 contract type(s) (IEventStore, InMemoryEventStore) expose strong-typed ids/value objects (EventResult); a serialized contract could expose the underlying primitive instead. Advisory — a deliberate strong-ID style is fine.
D8 · Code Coverage· Coverage read from a committed report · ×1
Coverage read from a committed report — Line coverage 15.1% — read from a committed opencover report (tests/Foundation.UnitTests/coverage.opencover.xml); the in-image collector couldn't run the suite (commonly external-service dependencies). A real measurement, but from a committed artifact rather than a fresh in-image run.
Appendix B — Reproduction & audit trail
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
nuget: not applicable — nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan
trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 2 file(s) — `src/Configuration.Application.Web/NaosExtensions.cs`, `src/Foundation.Logging/LoggerExtensions.cs` — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
none (no readable dependency manifest): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Python pyproject.toml/requirements.txt (pip/uv/Poetry), a Swift Package.swift/Package.resolved, a Cargo manifest, a Go module (go.mod/go.sum), a Gradle version catalogue, a Maven POM, an sbt build (build.sbt), composer.json, package.json, a Dart pubspec.yaml, an Elixir mix.exs/mix.lock (Hex), a rebar.config / erlang.mk DEPS (Hex), a Ruby Gemfile/Gemfile.lock or .gemspec (Bundler/RubyGems) — not scanned yet).
0
—
Run 01a16149-af09-7742-8cbd-10a0c127f8f4 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Issues: 197 · Warnings: 1052 · Recommendations: 497 · Info: 73 — Appendix A · all findings · full markdown report.
Generated by Watchdog — deterministic code-health analysis. 22-10-2026 @ 01:46 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.