Public report of yuliskov/SmartTube, published 24 October 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.10.5). Watchdog signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 24 October 2026, 04:25 UTC · Survey ID cd_ef161c46ff964382a4d943247331280a

yuliskov/SmartTube

Measured 24 October 2026, 04:20 UTC, at code version 168e484

No regression since the last survey

A regression is a drop of 0.5 points or more in the score, or of 2.5 or more out of 10 in a dimension, since the last survey.

CAI score 53out of 100 Adequate
CriticalWeakAdequateStrongExemplary
Up 1 since the last survey

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A large codebase: 308,722 lines of product code in 35 projects, tests not counted · Estimated rebuild effort: about 2.3 person-years · Weakest lens: Security and Compliance, 46

Findings by how serious they are

13 critical 446 serious 70 minor

13 dimensions are left out of the score. For each one, Watchdog either couldn't measure it in this code, or found no evidence of the safeguard it looks for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Watchdog
Producer
Canine Development
Analyzer
Watchdog engine 1.0.0
Measured
24 October 2026, 04:20 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds Watchdog. It is open to any tool that implements it, and today Watchdog is the only one that does.

The score is deterministic, which means the same code always gets the same score. Watchdog works it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

57of 61 dimensions measured by tools. The other 4 are advisory notes from an AI model, which explain the code but don't count towards the score.
516of 529 findings point to an exact file and line, so you can open each one in the code. The other 13 concern the repository as a whole, such as missing documentation.
61dimensions across 6 lenses, read from 308,722 lines of product code in 35 projects.
Chapters

Executive summary

yuliskov/SmartTube scores 53 out of 100 and is rated Adequate, while four of its six lenses score higher still: Architecture at 98, rated Exemplary, and Performance at 67, Code Health at 65 and Maturity at 61, all rated Adequate.

The score is lower than those four because the weakest lens counts most, and here that is Security and Compliance, which scores 46 and is rated Weak. Its Secrets (history) dimension scores 1 out of 10, and until that reaches 4, Security and Compliance can't be rated higher than Adequate. The first actions are to resolve the 9 REDACTED finding(s) in Secrets (history) and to add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing, and if Security and Compliance rose to 70, the score would rise from 53 to about 58.

13 findings are critical: nine in Secrets (history) and four in Static Analysis (SAST).

Watchdog couldn't measure 12 dimensions in this code, among them Code Coverage, Test Reliability and Dependency Hygiene, so they are left out of the score. The product code is 308,722 lines, which would take an estimated 2.3 person-years, around €340,000, to rebuild.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Security and Compliance 46 · counts for 46%Production Readiness 49 · counts for 25%Maturity 61 · counts for 14%Code Health 65 · counts for 8%Performance 67 · counts for 4%Architecture 98 · counts for 2%

If Security and Compliance rose from 46 to 70, the lowest score rated Strong, the score would rise from 53 to about 58.

Code composition: what the lines of code are
Product code 88%Tests 12%
New since the last survey: 9 findings

These 9 critical or serious findings weren't in the previous survey, on 10 October 2026.

  • Cognitive Complexity · ErrorFixerController.onLongBuffering (cognitive 16) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java
  • Code Duplication · Duplicated block (15 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java
  • Test Quality · No assertions: testParseSmoothStreamingManifest exoplayer-amzn-2.10.6/library/smoothstreaming/src/test/java/com/google/android/exoplayer2/source/smoothstreaming/manifest/SsManifestParserTest.java
  • Test Quality · No assertions: staticDownloadHelperForSmoothStreaming_doesNotThrow exoplayer-amzn-2.10.6/library/smoothstreaming/src/test/java/com/google/android/exoplayer2/source/smoothstreaming/offline/DownloadHelperTest.java
  • Test Quality · No assertions: getSteamKeys_isCompatibleWithSsManifestFilter exoplayer-amzn-2.10.6/library/smoothstreaming/src/test/java/com/google/android/exoplayer2/source/smoothstreaming/SsMediaPeriodTest.java
  • Churn × Complexity Hotspots · Hotspot: exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/DefaultSabrChunkSource.java exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/DefaultSabrChunkSource.java
  • Churn × Complexity Hotspots · Hotspot: exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/parser/SabrProcessor.java exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/parser/SabrProcessor.java
  • Churn × Complexity Hotspots · Repeated repair: common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoStateController.java common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoStateController.java
  • Supply-chain Provenance & Signing · REDACTED

Watchdog compares every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 181 findings

These 181 critical or serious findings were in the previous survey, on 10 October 2026, and are gone from this one. The first 100 are listed here.

  • Test Quality · No assertions: buildAndClear_assertDefaultValues exoplayer-amzn-2.10.6/extensions/cast/src/test/java/com/google/android/exoplayer2/ext/cast/MediaItemTest.java
  • Test Quality · No assertions: buildMediaItem_assertDefaultValues exoplayer-amzn-2.10.6/extensions/cast/src/test/java/com/google/android/exoplayer2/ext/cast/MediaItemTest.java
  • Test Quality · No assertions: testDownloadRenewReleaseKey exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/drm/OfflineLicenseHelperTest.java
  • Test Quality · No assertions: testBinaryElement exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/DefaultEbmlReaderTest.java
  • Test Quality · No assertions: testFloatElementEightBytes exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/DefaultEbmlReaderTest.java
  • Test Quality · No assertions: testFloatElementFourBytes exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/DefaultEbmlReaderTest.java
  • Test Quality · No assertions: testMasterElement exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/DefaultEbmlReaderTest.java
  • Test Quality · No assertions: testMasterElementEmpty exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/DefaultEbmlReaderTest.java
  • Test Quality · No assertions: testStringElement exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/DefaultEbmlReaderTest.java
  • Test Quality · No assertions: testStringElementEmpty exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/DefaultEbmlReaderTest.java
  • Test Quality · No assertions: testStringElementWithZeroPadding exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/DefaultEbmlReaderTest.java
  • Test Quality · No assertions: testUnsignedIntegerElement exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/DefaultEbmlReaderTest.java
  • Test Quality · No assertions: testUnsignedIntegerElementLarge exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/DefaultEbmlReaderTest.java
  • Test Quality · No assertions: testUnsignedIntegerElementTooLargeBecomesNegative exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/DefaultEbmlReaderTest.java
  • Test Quality · No assertions: testReadVarint exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/VarintReaderTest.java
  • Test Quality · No assertions: testReadVarintFlaky exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/VarintReaderTest.java
  • Test Quality · No assertions: testStz2Parsing16BitFieldSize exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mp4/AtomParsersTest.java
  • Test Quality · No assertions: testStz2Parsing4BitFieldSize exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mp4/AtomParsersTest.java
  • Test Quality · No assertions: testStz2Parsing8BitFieldSize exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mp4/AtomParsersTest.java
  • Test Quality · No assertions: testReadGranuleOfLastPage exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/ogg/DefaultOggSeekerTest.java
  • Test Quality · No assertions: testSeeking exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/ogg/DefaultOggSeekerTest.java
  • Test Quality · No assertions: testReadDiscardContinuedPacketAtStart exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/ogg/OggPacketTest.java
  • Test Quality · No assertions: testReadPacketWithZeroSizeTerminator exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/ogg/OggPacketTest.java
  • Test Quality · No assertions: testReadZeroSizedPacketsAtEndOfStream exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/ogg/OggPacketTest.java
  • Test Quality · No assertions: mergeRequest_nonExistingDownload_createsNewDownload exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/offline/ActionFileUpgradeUtilTest.java
  • Test Quality · No assertions: upgradeAndDelete_createsDownloads exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/offline/ActionFileUpgradeUtilTest.java
  • Test Quality · No assertions: addAndGetDownload_nonExistingId_returnsTheSameDownload exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/offline/DefaultDownloadIndexTest.java
  • Test Quality · No assertions: setSingleDownloadStopReason_notTerminalState_doesNotSetStopReason exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/offline/DefaultDownloadIndexTest.java
  • Test Quality · No assertions: setSingleDownloadStopReason_setReason exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/offline/DefaultDownloadIndexTest.java
  • Test Quality · No assertions: setSingleDownloadStopReason_setReasonToNone exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/offline/DefaultDownloadIndexTest.java
  • Test Quality · No assertions: setStopReason_notTerminalState_doesNotSetStopReason exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/offline/DefaultDownloadIndexTest.java
  • Test Quality · No assertions: setStopReason_setReason exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/offline/DefaultDownloadIndexTest.java
  • Test Quality · No assertions: setStopReason_setReasonToNone exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/offline/DefaultDownloadIndexTest.java
  • Test Quality · No assertions: mergeRequest_completedWithStopReason_becomesStopped exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/offline/DownloadManagerTest.java
  • Test Quality · No assertions: mergeRequest_failed_becomesQueued exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/offline/DownloadManagerTest.java
  • Test Quality · No assertions: mergeRequest_removing_becomesRestarting exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/offline/DownloadManagerTest.java
  • Test Quality · No assertions: mergeRequest_stopped_staysStopped exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/offline/DownloadManagerTest.java
  • Test Quality · No assertions: testMergeRequest_withSameRequest exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/offline/DownloadRequestTest.java
  • Test Quality · No assertions: testCopy exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestTest.java
  • Test Quality · No assertions: testCopySameAdaptationIndexButDifferentPeriod exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestTest.java
  • Test Quality · No assertions: testCopySkipPeriod exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestTest.java
  • Test Quality · No assertions: testMerge exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/manifest/RangedUriTest.java
  • Test Quality · No assertions: testMergeUnbounded exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/manifest/RangedUriTest.java
  • Test Quality · No assertions: testMergeWithBaseUri exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/manifest/RangedUriTest.java
  • Test Quality · No assertions: testNonMerge exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/manifest/RangedUriTest.java
  • Test Quality · No assertions: testIso8601ParserParse exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/DashMediaSourceTest.java
  • Test Quality · No assertions: audioStillUsesSabrContainerPost exoplayer-amzn-2.10.6/library/sabr/src/test/java/com/google/android/exoplayer2/source/sabr/DefaultSabrChunkSourceTest.java
  • Test Quality · No assertions: textWithoutContainerMimeTypeUsesCaptionGet exoplayer-amzn-2.10.6/library/sabr/src/test/java/com/google/android/exoplayer2/source/sabr/DefaultSabrChunkSourceTest.java
  • Test Quality · No assertions: ttmlUsesCaptionGetInsteadOfSabrContainer exoplayer-amzn-2.10.6/library/sabr/src/test/java/com/google/android/exoplayer2/source/sabr/DefaultSabrChunkSourceTest.java
  • Test Quality · No assertions: videoStillUsesSabrContainerPost exoplayer-amzn-2.10.6/library/sabr/src/test/java/com/google/android/exoplayer2/source/sabr/DefaultSabrChunkSourceTest.java
  • Test Quality · No assertions: webvttUsesCaptionGetInsteadOfSabrContainer exoplayer-amzn-2.10.6/library/sabr/src/test/java/com/google/android/exoplayer2/source/sabr/DefaultSabrChunkSourceTest.java
  • Test Quality · No assertions: testMergingDynamicTimelines exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/MergingMediaSourceTest.java
  • Test Quality · No assertions: testMergingStaticTimelines exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/MergingMediaSourceTest.java
  • Test Quality · No assertions: testAdvanceToEnd exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/SampleQueueTest.java
  • Test Quality · No assertions: testAdvanceToEndRetainsUnassignedData exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/SampleQueueTest.java
  • Test Quality · No assertions: testDiscardUpstream exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/SampleQueueTest.java
  • Test Quality · No assertions: testDiscardUpstreamAfterRead exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/SampleQueueTest.java
  • Test Quality · No assertions: testDiscardUpstreamBeforeRead exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/SampleQueueTest.java
  • Test Quality · No assertions: testDiscardUpstreamMulti exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/SampleQueueTest.java
  • Test Quality · No assertions: testReadFormatDeduplicated exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/SampleQueueTest.java
  • Test Quality · No assertions: testReadMultiSamplesTwice exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/SampleQueueTest.java
  • Test Quality · No assertions: testReadSingleSamples exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/SampleQueueTest.java
  • Test Quality · No assertions: testReadWithoutWrite exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/SampleQueueTest.java
  • Test Quality · No assertions: testResetReleasesAllocations exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/SampleQueueTest.java
  • Test Quality · No assertions: testSetSampleOffset exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/SampleQueueTest.java
  • Test Quality · No assertions: testSplice exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/SampleQueueTest.java
  • Test Quality · No assertions: testSpliceAfterRead exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/SampleQueueTest.java
  • Test Quality · No assertions: testSpliceWithSampleOffset exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/SampleQueueTest.java
  • Test Quality · No assertions: testDefaultShuffleOrder exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/ShuffleOrderTest.java
  • Test Quality · No assertions: testUnshuffledShuffleOrder exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/ShuffleOrderTest.java
  • Test Quality · No assertions: testGetInputLimit exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/CssParserTest.java
  • Test Quality · No assertions: testMultiplePropertiesInBlock exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/CssParserTest.java
  • Test Quality · No assertions: testParseMethodMultipleRulesInBlockInput exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/CssParserTest.java
  • Test Quality · No assertions: testParseMethodSimpleInput exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/CssParserTest.java
  • Test Quality · No assertions: testRgbaColorExpression exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/CssParserTest.java
  • Test Quality · No assertions: testSkipWhitespacesAndComments exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/CssParserTest.java
  • Test Quality · No assertions: testNoCueSample exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/Mp4WebvttDecoderTest.java
  • Test Quality · No assertions: testSingleCueSample exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/Mp4WebvttDecoderTest.java
  • Test Quality · No assertions: testTwoCuesSample exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/Mp4WebvttDecoderTest.java
  • Test Quality · No assertions: testNestedSubtitleEventIndices exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/WebvttSubtitleTest.java
  • Test Quality · No assertions: testNestedSubtitleEventTimes exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/WebvttSubtitleTest.java
  • Test Quality · No assertions: testNestedSubtitleText exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/WebvttSubtitleTest.java
  • Test Quality · No assertions: testOverlappingSubtitleEventIndices exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/WebvttSubtitleTest.java
  • Test Quality · No assertions: testOverlappingSubtitleEventTimes exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/WebvttSubtitleTest.java
  • Test Quality · No assertions: testOverlappingSubtitleText exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/WebvttSubtitleTest.java
  • Test Quality · No assertions: testSimpleSubtitleEventIndices exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/WebvttSubtitleTest.java
  • Test Quality · No assertions: testSimpleSubtitleEventTimes exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/WebvttSubtitleTest.java
  • Test Quality · No assertions: testSimpleSubtitleText exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/text/webvtt/WebvttSubtitleTest.java
  • Test Quality · No assertions: selectAudioTracks_withinCapabilities_andDifferentLanguage_selectsFirstTrack exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/trackselection/DefaultTrackSelectorTest.java
  • Test Quality · No assertions: selectAudioTracks_withinCapabilities_andSameLanguage_selectsHigherBitrate exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/trackselection/DefaultTrackSelectorTest.java
  • Test Quality · No assertions: testSelectPreferredAudioTrackMultipleRenderers exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/trackselection/DefaultTrackSelectorTest.java
  • Test Quality · No assertions: testSelectPreferredTextTrackMultipleRenderers exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/trackselection/DefaultTrackSelectorTest.java
  • Test Quality · No assertions: testSelectTracksExceedingCapabilitiesPreferLowerNumChannelBeforeSampleRate exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/trackselection/DefaultTrackSelectorTest.java
  • Test Quality · No assertions: testSelectTracksExceedingCapabilitiesPreferLowerSampleRateBeforeBitrate exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/trackselection/DefaultTrackSelectorTest.java
  • Test Quality · No assertions: testSelectTracksExceedingCapabilitiesSelectLowerBitrate exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/trackselection/DefaultTrackSelectorTest.java
  • Test Quality · No assertions: testSelectTracksExceedingCapabilitiesSelectLowerNumChannel exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/trackselection/DefaultTrackSelectorTest.java
  • Test Quality · No assertions: testSelectTracksExceedingCapabilitiesSelectLowerSampleRate exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/trackselection/DefaultTrackSelectorTest.java
  • Test Quality · No assertions: testSelectTracksPreferHigherNumChannelBeforeSampleRate exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/trackselection/DefaultTrackSelectorTest.java
  • Test Quality · No assertions: testSelectTracksPreferHigherSampleRateBeforeBitrate exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/trackselection/DefaultTrackSelectorTest.java
  • Test Quality · No assertions: testSelectTracksPreferTrackWithinCapabilities exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/trackselection/DefaultTrackSelectorTest.java
Rebuild cost: about €340,000 · Estimate
Cost to rebuild€110,000 to €560,000, for 1,874 to 5,944 hours of work, about 2.3 person-years for 1 to 5 engineers
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.7 at a score of 53. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeLarge: 308,722 lines of product code

How the estimate is made: Watchdog prices the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Resolve the 9 REDACTED finding(s) in Secrets (history) — start with REDACTED (6), REDACTED (2), REDACTED.
Raises the score by about 5 points · Low effort · Secrets (history)
2
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Raises the score by about 4 points · Medium effort · Security & performance tooling
3
Resolve the 1 No ADRs found finding(s) in ADR Quality.
Raises the score by about 2 points · Low effort · ADR Quality

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €340,000 to build again, about 2.3 person-years of work. Its weakest lens is Security and Compliance, at 46 (Weak). Security and Compliance is about how well the product is protected, and how it handles personal data. Because the weakest lens counts most in the score, work on Security and Compliance also moves the score most.
Based on: the rebuild estimate · the Security and Compliance grade · how much each lens counts
What to do: Start with the Security and Compliance actions in Top priorities.
If you do one thing first · First action
Resolve the 9 REDACTED finding(s) in Secrets (history). Of all the actions in this report, it raises the score most for the work it takes: about 5 points for low effort, because it clears the 9 Secrets (history) findings. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort

Architecture — module dependency graph

Project dependencies, layered top-to-bottom; arrows show direction. Any dashed red edge points upward or sideways — a layering smell or cycle. A clean layered graph has none.

arch codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00 codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00 codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:chatkit codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:chatkit codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:common codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:common codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:filepicker-lib codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:filepicker-lib codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:common->codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:filepicker-lib codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:fragment-1.1.0 0 codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:common->codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:fragment-1.1.0 codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:leanbackassistant codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:leanbackassistant codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:common->codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:leanbackassistant codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:slidableactivity codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:slidableactivity codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:common->codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:slidableactivity codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:doubletapplayerview codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:doubletapplayerview codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:filepicker-lib->codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:fragment-1.1.0 codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:leanback-1.0.0 0 codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:leanback-1.0.0->codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:fragment-1.1.0 codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:leanbackassistant->codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:leanback-1.0.0 codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:slidableactivity->codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:fragment-1.1.0 codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:smarttubetv codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:smarttubetv codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:smarttubetv->codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:chatkit codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:smarttubetv->codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:common codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:smarttubetv->codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:doubletapplayerview codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:smarttubetv->codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:fragment-1.1.0 codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:smarttubetv->codehealth-iso-102feb6236bc4783baf53d3e2a0f8d00:leanback-1.0.0 exoplayer-amzn-2.10.6 6 exoplayer-amzn-2.10.6:extensions:cast 6:extensions:cast exoplayer-amzn-2.10.6:extensions:cronet 6:extensions:cronet exoplayer-amzn-2.10.6:extensions:ffmpeg 6:extensions:ffmpeg exoplayer-amzn-2.10.6:extensions:flac 6:extensions:flac exoplayer-amzn-2.10.6:extensions:gvr 6:extensions:gvr exoplayer-amzn-2.10.6:extensions:ima 6:extensions:ima exoplayer-amzn-2.10.6:extensions:jobdispatcher 6:extensions:jobdispatcher exoplayer-amzn-2.10.6:extensions:leanback 6:extensions:leanback exoplayer-amzn-2.10.6:extensions:mediasession 6:extensions:mediasession __more__ +15 more projects

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

217 modules, with 738 dependencies between them. 5 loops run through 45 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 177 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 androidx.fragment.app2 androidx.leanback.widget3 com.google.android.exoplayer2.decoder4 com.liskovsoft.smartyoutubetv2.common.app.models.data5 androidx.leanback.app6 com.google.android.exoplayer2.mediacodec7 com.google.android.exoplayer2.metadata8 com.google.android.exoplayer2.text9 com.google.android.exoplayer2.extractor10 com.google.android.exoplayer2.video11 com.google.android.exoplayer2.source.chunk12 com.google.android.exoplayer2.trackselection13 com.google.android.exoplayer2.offline14 com.google.android.exoplayer2.source15 com.google.android.exoplayer2.util16 com.google.android.exoplayer2.upstream17 com.google.android.exoplayer2.drm18 com.google.android.exoplayer2.audio19 com.google.android.exoplayer2.analytics20 com.google.android.exoplayer221 com.google.android.exoplayer2.extractor.mp422 com.google.android.exoplayer2.source.dash23 com.google.android.exoplayer2.source.sabr24 com.google.android.exoplayer2.ui25 com.liskovsoft.smartyoutubetv2.common.exoplayer.selector26 com.google.android.exoplayer2.source.hls27 com.liskovsoft.smartyoutubetv2.common.app.models.playback.ui28 com.liskovsoft.smartyoutubetv2.common.exoplayer.other29 com.liskovsoft.smartyoutubetv2.common.exoplayer.controller30 com.liskovsoft.smartyoutubetv2.common.prefs31 com.liskovsoft.smartyoutubetv2.common.misc32 com.liskovsoft.smartyoutubetv2.common.app.views33 com.liskovsoft.smartyoutubetv2.tv.ui.common34 com.liskovsoft.smartyoutubetv2.common.app.presenters.base35 com.liskovsoft.smartyoutubetv2.tv.ui.browse.video36 com.liskovsoft.smartyoutubetv2.tv.ui.search.tags.vineyard37 com.liskovsoft.smartyoutubetv2.common.app.presenters38 com.liskovsoft.smartyoutubetv2.common.app.models.playback.controllers39 com.liskovsoft.smartyoutubetv2.tv.ui.playback40 com.liskovsoft.smartyoutubetv2.tv.ui.search.tags
1 androidx.fragment.app
2 androidx.leanback.widget
3 com.google.android.exoplayer2.decoder
4 com.liskovsoft.smartyoutubetv2.common.app.models.data
5 androidx.leanback.app12183
6 com.google.android.exoplayer2.mediacodec21236
7 com.google.android.exoplayer2.metadata16
8 com.google.android.exoplayer2.text45
9 com.google.android.exoplayer2.extractor2312
10 com.google.android.exoplayer2.video33524
11 com.google.android.exoplayer2.source.chunk212812514
12 com.google.android.exoplayer2.trackselection17194819
13 com.google.android.exoplayer2.offline10841423
14 com.google.android.exoplayer2.source8197156158
15 com.google.android.exoplayer2.util12134121210
16 com.google.android.exoplayer2.upstream8
17 com.google.android.exoplayer2.drm23
18 com.google.android.exoplayer2.audio7311816
19 com.google.android.exoplayer2.analytics232211211415
20 com.google.android.exoplayer23177101931111012134
21 com.google.android.exoplayer2.extractor.mp44221134
22 com.google.android.exoplayer2.source.dash116114116131114
23 com.google.android.exoplayer2.source.sabr115941411613
24 com.google.android.exoplayer2.ui115721129
25 com.liskovsoft.smartyoutubetv2.common.exoplayer.selector533
26 com.google.android.exoplayer2.source.hls2220942248285121
27 com.liskovsoft.smartyoutubetv2.common.app.models.playback.ui1
28 com.liskovsoft.smartyoutubetv2.common.exoplayer.other22135210241
29 com.liskovsoft.smartyoutubetv2.common.exoplayer.controller2223311
30 com.liskovsoft.smartyoutubetv2.common.prefs21121
31 com.liskovsoft.smartyoutubetv2.common.misc11111324
32 com.liskovsoft.smartyoutubetv2.common.app.views8111
33 com.liskovsoft.smartyoutubetv2.tv.ui.common112
34 com.liskovsoft.smartyoutubetv2.common.app.presenters.base24311
35 com.liskovsoft.smartyoutubetv2.tv.ui.browse.video219133
36 com.liskovsoft.smartyoutubetv2.tv.ui.search.tags.vineyard521
37 com.liskovsoft.smartyoutubetv2.common.app.presenters12129111
38 com.liskovsoft.smartyoutubetv2.common.app.models.playback.controllers1159231
39 com.liskovsoft.smartyoutubetv2.tv.ui.playback1131612313231
40 com.liskovsoft.smartyoutubetv2.tv.ui.search.tags1211111
Uses a module listed above itPart of a loopThe module itself
1 androidx.fragment.app2 androidx.leanback.widget3 com.google.android.exoplayer2.decoder4 com.liskovsoft.smartyoutubetv2.common.app.models.data5 androidx.leanback.app6 com.google.android.exoplayer2.mediacodec7 com.google.android.exoplayer2.metadata8 com.google.android.exoplayer2.text9 com.google.android.exoplayer2.extractor10 com.google.android.exoplayer2.video11 com.google.android.exoplayer2.source.chunk12 com.google.android.exoplayer2.trackselection13 com.google.android.exoplayer2.offline14 com.google.android.exoplayer2.source15 com.google.android.exoplayer2.util16 com.google.android.exoplayer2.upstream17 com.google.android.exoplayer2.drm18 com.google.android.exoplayer2.audio19 com.google.android.exoplayer2.analytics20 com.google.android.exoplayer221 com.google.android.exoplayer2.extractor.mp422 com.google.android.exoplayer2.source.dash23 com.google.android.exoplayer2.source.sabr24 com.google.android.exoplayer2.ui25 com.liskovsoft.smartyoutubetv2.common.exoplayer.selector26 com.google.android.exoplayer2.source.hls27 com.liskovsoft.smartyoutubetv2.common.app.models.playback.ui28 com.liskovsoft.smartyoutubetv2.common.exoplayer.other29 com.liskovsoft.smartyoutubetv2.common.exoplayer.controller30 com.liskovsoft.smartyoutubetv2.common.prefs31 com.liskovsoft.smartyoutubetv2.common.misc32 com.liskovsoft.smartyoutubetv2.common.app.views33 com.liskovsoft.smartyoutubetv2.tv.ui.common34 com.liskovsoft.smartyoutubetv2.common.app.presenters.base35 com.liskovsoft.smartyoutubetv2.tv.ui.browse.video36 com.liskovsoft.smartyoutubetv2.tv.ui.search.tags.vineyard37 com.liskovsoft.smartyoutubetv2.common.app.presenters38 com.liskovsoft.smartyoutubetv2.common.app.models.playback.controllers39 com.liskovsoft.smartyoutubetv2.tv.ui.playback40 com.liskovsoft.smartyoutubetv2.tv.ui.search.tagsandroidx.fragment.app1androidx.leanback.widget2com.google.android.exoplayer2.decoder3com.liskovsoft.smartyoutubetv2.common.app.models.data4androidx.leanback.app5com.google.android.exoplayer2.mediacodec6com.google.android.exoplayer2.metadata7com.google.android.exoplayer2.text8com.google.android.exoplayer2.extractor9com.google.android.exoplayer2.video10com.google.android.exoplayer2.source.chunk11com.google.android.exoplayer2.trackselection12com.google.android.exoplayer2.offline13com.google.android.exoplayer2.source14com.google.android.exoplayer2.util15com.google.android.exoplayer2.upstream16com.google.android.exoplayer2.drm17com.google.android.exoplayer2.audio18com.google.android.exoplayer2.analytics19com.google.android.exoplayer220com.google.android.exoplayer2.extractor.mp421com.google.android.exoplayer2.source.dash22com.google.android.exoplayer2.source.sabr23com.google.android.exoplayer2.ui24com.liskovsoft.smartyoutubetv2.common.exoplayer.selector25com.google.android.exoplayer2.source.hls26com.liskovsoft.smartyoutubetv2.common.app.models.playback.ui27com.liskovsoft.smartyoutubetv2.common.exoplayer.other28com.liskovsoft.smartyoutubetv2.common.exoplayer.controller29com.liskovsoft.smartyoutubetv2.common.prefs30com.liskovsoft.smartyoutubetv2.common.misc31com.liskovsoft.smartyoutubetv2.common.app.views32com.liskovsoft.smartyoutubetv2.tv.ui.common33com.liskovsoft.smartyoutubetv2.common.app.presenters.base34com.liskovsoft.smartyoutubetv2.tv.ui.browse.video35com.liskovsoft.smartyoutubetv2.tv.ui.search.tags.vineyard36com.liskovsoft.smartyoutubetv2.common.app.presenters37com.liskovsoft.smartyoutubetv2.common.app.models.playback.controllers38com.liskovsoft.smartyoutubetv2.tv.ui.playback39com.liskovsoft.smartyoutubetv2.tv.ui.search.tags4012183212361645231233524212812514171948191084142381971561581213412121082373118162322112114153177101931111012134422113411611411613111411594141161311572112953322209422482851211221352102412223311211211111132481111122431121913352112129111115923111316123132311211111+177 more modules (most-connected shown)

At a glance — Code Health · 65% · Adequate · gated by X5 ·

At a glance — Architecture · 98% · Exemplary ·

At a glance — Maturity · 61% · Adequate · gated by M2 ·

At a glance — Readiness · 49% · Weak · gated by P3 ·

At a glance — Security · 46% · Weak · gated by D28, D29 ·

At a glance — Performance · 67% · Adequate ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A05:2025 — Injection17High / Critical
A07:2025 — Authentication Failures10High / Critical
A03:2025 — Software Supply Chain Failures4Medium

Roadmap

Begin by resolving the nine secrets found in history, prioritizing REDACTED, and addressing the 154 test cases lacking assertions, starting with ExoPlayerTest.java. Next, integrate a SAST step into the CI pipeline to automatically block security regressions. Finally, document the disaster recovery RTO and RPO with a tested restore procedure and create the first architectural decision record.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Resolve the 9 REDACTED finding(s) in Secrets (history) — start with REDACTED (6), REDACTED (2), REDACTED.+4.9 ptsLowSecrets (history)
Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.+3.8 ptsMediumSecurity & performance tooling
Resolve the 1 No ADRs found finding(s) in ADR Quality.+1.9 ptsLowADR Quality
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED.+1.8 ptsLowStatic Analysis (SAST)
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED.+1.8 ptsLowStatic Analysis (SAST)
Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED.+1.8 ptsLowStatic Analysis (SAST)
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing.+1.4 ptsLowSupply-chain Provenance & Signing
Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing.+1.4 ptsLowSupply-chain Provenance & Signing

File quality

Per-file score 0–10 — a quality signature. Of 167 files carrying findings, judged against the Production bar: 1% slop · 53% mixed · 46% near-clean.

FileScoreBandWorst signal
REDACTED3.6SlopStatic Analysis (SAST): High: REDACTED
REDACTED4.5MixedSecrets (history): REDACTED: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.8MixedStatic Analysis (SAST): Medium: REDACTED
smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/other/VideoPlayerGlue.java5.9MixedCyclomatic Complexity: VideoPlayerGlue.onCreatePrimaryActions (cyclomatic 17)
slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java6.0MixedExplicit Debt: TodoComment
common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoLoaderController.java6.0MixedExplicit Debt: TodoComment
common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java6.0MixedExplicit Debt: TodoComment
leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java6.0MixedExplicit Debt: TodoComment
common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java6.0MixedExplicit Debt: TodoComment
common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/VideoGroup.java6.0MixedExplicit Debt: TodoComment
smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java6.0MixedExplicit Debt: TodoComment
common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/GDriveBackupManager.java6.7MixedExplicit Debt: TodoComment
common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/MediaServiceManager.java7.0MixedGod Classes: TooManyMethods: MediaServiceManager
exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/ts/AdtsReaderTest.java7.0MixedTest Quality: No assertions: testAdtsDataOnly
exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/offline/DownloadManagerTest.java7.0MixedTest Quality: No assertions: downloadNotCancelRemove
exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/ExoPlayerTest.java7.0MixedTest Quality: No assertions: removingLoopingLastPeriodFromPlaylistDoesNotThrow
smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java7.0MixedCyclomatic Complexity: MultipleRowsFragment.update (cyclomatic 16)
exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/source/ConcatenatingMediaSourceTest.java7.0MixedTest Quality: No assertions: testChildSourceWithLazyPreparationOnlyPreparesSourceOnce
common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/SuggestionsController.java7.0MixedCyclomatic Complexity: SuggestionsController.appendSuggestions (cyclomatic 18)

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 13

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 446

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 70

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 13

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

Watchdog is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. 57 of 61 evaluated dimensions are computed purely by tools and static analysis (confidence 1.0); 4 documentation/naming judgement(s) are LLM-assisted and labelled advisory. Overall confidence is 0.9 — the weighted average across measured dimensions; it falls as more of the score leans on LLM-assisted judgement and rises when it's fully tool-backed.

Every figure here is one of three kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact; ◐ Advisory — an LLM prose judgement. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10; ◐ Sampled · advisory marks an LLM verdict over a bounded sample — advisory, never a deterministic measurement.

What we checked — 61 dimensions across the health lenses
D1D2D3D4D5D6D9D10D13D14D15D17D19D20D21D22D26D27D28D29D34D35D36D44AX10AX3AX4AX6IC1M1M2M3M4P1P10P3P5P6PF2X1X12X13X14X15X16X17X18X19X20X21X22X23X24X25X26X27X28X29X3X30X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 516 of 529 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it — Roslyn, git, a scanner, or (for a handful of documentation/naming dimensions) an LLM labelled sampled · advisory — not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Watchdog duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic
LLM (sampled · advisory)Documentation quality, ADR conformance, naming — sampled over a bounded sample; advisory, never a deterministic measurementLocal LLM◐ LLM · sampled · advisory

Every finding is locatable in findings.md. Run 01a16c23-56cf-7bf5-b033-a18fc18b5fef.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: test source is present (.java) but the built-in coverage collector has no runner for this repository's ecosystem — so this suite was never executed by it. Not scored — this is a gap in the analyzer's language coverage, not a defect in the repo. To have real coverage read, produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures. You can widen what we reach: optional: produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures — then the real number is read on the next scan.
  • D11 Test Reliability — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.java) and this repository declares a JVM test suite (repository root, Gradle), but it was not re-run: the analyzer environment could not run it. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
  • D12 Dependency Hygiene — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Not scored — 38 Maven/Gradle manifest(s) were read, stating a version for 40 dependency(ies) and leaving 0 to a parent or an imported BOM, but no build resolved the dependency graph, so the outdated signal was not established. NOT a finding that these dependencies are current or healthy.
  • D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-maintainer repository — bus factor is not applicable (41 contributor(s) across 1057 commit(s) sampled, automation and bot accounts excluded). One of them holds 90% of the history; the other 40 hold 0.2% each on average, below the 5% at which there is somebody to hand the work to. That is a single maintainer with drive-by contributors, not a team whose knowledge has concentrated — so the bus factor is not applicable and there is nothing here for the owner to act on.
  • AXR1 Runtime accessibility — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Boot via AndroidApp (smarttubetv). the Android app did not build — `./gradlew :smarttubetv:assembleDebug` exited 1: Build failed with an exception. * What went wrong: Could not open settings generic class cache for settings file 'settings.gradle' (/tmp/codeheal…; runtime evidence skipped (launch chosen because smarttubetv/build.gradle applies the Android application plugin and gradlew builds it).
  • C1 Data Protection — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These personal data controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks personal data controls.
  • C2 Access Controls — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • C3 Audit Trail — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These audit controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks audit controls.
  • C4 Data Retention — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These retention controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks retention controls.
  • C5 Data-Subject Rights — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These data-subject rights controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks data-subject rights controls.
  • GD1 Unfinished & placeholder code — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and no C#, F#, JavaScript/TypeScript, Dart, Ruby or Scala was found, and this repository's Java, Kotlin, c, cpp is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • P1 CI/CD gates — measured, with a gap in what it reached — Watchdog measured this, but not all of it. What it did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. A CI pipeline exists and the word "test" appears, but no explicit test-runner invocation (your stack's test command, or a test job) was matched — so either the gate runs tests through a step this pass could not recognise, or "test" is incidental here (a path, "latest", a reporter). Which of the two it is cannot be settled from this dimension's evidence; the coverage dimensions report whether a suite exists at all. You can widen what we reach: name the test runner explicitly in the pipeline step (your stack's test command, or a job named for the suite) so the gate is unambiguous to a reader and to this pass.
  • S1 Web-Security Posture — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These web-security controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks web-security controls.
  • X2 Cancellation propagation — not measured this run — Watchdog could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Go, PHP, Dart, Kotlin, Ruby, Scala, Java, Python and Rust source only, and no C# was loaded, and no named async function in this repository's JavaScript/TypeScript, nor any Go, PHP or Dart function or Kotlin suspend function, makes a request that can be cancelled (fetch, axios, ky, ofetch; net/http, net.Dial; amphp; Dio; Ktor, OkHttp), so there is nothing to judge, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

Watchdog assesses the repository exactly as committed, and only the repository. By design it does not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D9 Test Distribution: The test-pyramid shape is inferred from project/folder naming and references, with a single test host bucketed per-file by its path tier and content signals — a suite that names tiers unconventionally and gives no per-file signal can still be mis-bucketed.
  • D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
  • D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D19 Documentation Quality: Documentation quality is judged by an LLM over a bounded sample of docs — it reads what is written, not whether the docs match the running system, and it is advisory, not a measurement. Its critique rows are drawn from a closed category vocabulary and each row means the same thing in every run, so two scans can be compared row by row; the SET that fires is still a sample, and does not repeat exactly. Measured on one frozen input, six scans at one engine SHA: 2-5 critique rows per scan, 8 distinct rows across the six, 3 of those 8 seen in only one scan. So a D19 row is evidence about the documentation, but a COUNT of D19 rows is not a quantity — never read a change in it as an improvement or a regression.
  • D20 ADR Quality: ADR quality is an LLM read of the decision records present — it cannot know about decisions made and never recorded, and its verdict is sampled and advisory.
  • D21 Naming Consistency: Naming quality is an LLM judgement over a bounded sample — it assesses clarity/consistency of the names it sees, not domain-correctness, and is advisory.
  • D22 Internal API Consistency: API-surface coherence is an LLM judgement over a sample of the public surface — consistency of intent across the whole API is approximated, not exhaustively verified.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • M4 Documentation accuracy: Onboarding quality is an LLM read of the docs/setup present — it cannot run the onboarding or measure how long a real new joiner takes; the verdict is sampled and advisory.
  • P5 DR & Backup: Backup/restore and disaster-recovery readiness is judged from in-repo evidence — a config that exists is not a tested restore, so the absence of positive evidence is reported as "not evidenced", never scored as present.
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

The LLM boundary

LLM-set scores this run (4): D19, D21, D22, M4 (model: Local LLM). For these, a model reads a bounded sample and sets the numeric score; each names its own sample and method on its card. They are sampled and advisory by design: they vary at the margins between runs and are never a deterministic measurement. Every other score in this report is tool-computed at confidence 1.0.

Dimensions

D1 · Cyclomatic Complexity6.9 / 10Adequate✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.9 / 10 · rule-coverage 100% · ceiling Prevented

20 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was RemoteController.processCommand at 62.

RemoteController.processCommand (cyclomatic 62)common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/RemoteController.java:272
ErrorFixerController.applyEngineErrorAction (cyclomatic 34)common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java:225
TrackSelectorManager.filterByLanguage (cyclomatic 33)common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorManager.java:597
ViewDragHelper.shouldInterceptTouchEvent (cyclomatic 31)slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:891
ViewDragHelper.processTouchEvent (cyclomatic 29)slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:1009

+ 15 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 4 bodies over 30 down to 30 or less in Cyclomatic Complexity — start with RemoteController.processCommand (cyclomatic 62), ErrorFixerController.applyEngineErrorAction (cyclomatic 34), TrackSelectorManager.filterByLanguage (cyclomatic 33). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 4 together lifts Cyclomatic Complexity from 6.9 to about 7.7/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.
  2. Enforce Cyclomatic Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity6.2 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.2 / 10 · rule-coverage 100% · ceiling Prevented

34 method(s) exceeded the cognitive complexity threshold of 15; the worst was RemoteController.processCommand at 87.

RemoteController.processCommand (cognitive 87)common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/RemoteController.java:272
TrackSelectorManager.filterByLanguage (cognitive 69)common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorManager.java:597
TrackSelectorManager.findBestMatch (cognitive 66)common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorManager.java:466
ViewDragHelper.processTouchEvent (cognitive 55)slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:1009
AppPreferenceManager.initMultiSelectListPreference (cognitive 52)smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/AppPreferenceManager.java:189

+ 29 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 3 bodies over 60 down to 60 or less in Cognitive Complexity — start with RemoteController.processCommand (cognitive 87), TrackSelectorManager.filterByLanguage (cognitive 69), TrackSelectorManager.findBestMatch (cognitive 66). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 3 together lifts Cognitive Complexity from 6.2 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.
  2. Enforce Cognitive Complexity in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes9.3 / 10Stronggated by 68 serious findings✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.3 / 10 · rule-coverage 100% · ceiling Prevented

68 god class(es) detected.

TooManyMethods: PlaybackFragment · ×39smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/PlaybackFragment.java:100
ClassTooLong: PlaybackFragment · ×15smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/PlaybackFragment.java:100
FileTooLong: playback/PlaybackFragment.java · ×12smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/PlaybackFragment.java
MethodTooLong: RemoteController.processCommand · ×2common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/RemoteController.java:272

What to do

  1. Resolve the 39 TooManyMethods finding(s) in God Classes — start with PlaybackFragment.java, PlayerTweaksData.java, PlayerData.java. — One of this dimension's main actionable groups (39 warning-level).
  2. Resolve the 15 ClassTooLong finding(s) in God Classes — start with PlaybackFragment.java, AppDialogUtil.java, BrowsePresenter.java. — One of this dimension's main actionable groups (15 warning-level).
  3. Resolve the 12 FileTooLong finding(s) in God Classes — start with PlaybackFragment.java, Utils.java, AppDialogUtil.java. — One of this dimension's main actionable groups (12 warning-level).
  4. Enforce God Classes in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication9.8 / 10Stronggated by 98 serious findings✓ Tool-verified

What it measures: Copy-pasted code that should be shared instead.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), density-scored per KLoC of production code. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Verified

94 duplicated block group(s) detected. A further 4 rows report members as variants of one another; they aggregate block groups already counted above and are not themselves counted.

Duplicated block (8 lines × 2) · ×12common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/SectionMenuPresenter.java:108
Duplicated block (11 lines × 2) · ×8common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/GoogleSignInPresenter.java:64
Duplicated block (6 lines × 2) · ×8common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java:431
Duplicated block (7 lines × 2) · ×7common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AboutSettingsPresenter.java:135
Duplicated block (5 lines × 2) · ×7common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/SectionMenuPresenter.java:303

+ 31 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 12 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with SectionMenuPresenter.java (2), ChatPreferenceDialogFragment.java (2), DoubleTapPlayerAdapter.kt (2). — One of this dimension's main actionable groups (12 warning-level).
  2. Resolve the 8 Duplicated block (11 lines × 2) finding(s) in Code Duplication — start with MultipleRowsFragment.java (2), GoogleSignInPresenter.java, ActionHelpers.java. — One of this dimension's main actionable groups (8 warning-level).
  3. Resolve the 8 Duplicated block (6 lines × 2) finding(s) in Code Duplication — start with PlayerUIController.java, LiveDashManifestParser.java, AppDialogUtil.java. — One of this dimension's main actionable groups (8 warning-level).
  4. Enforce Code Duplication in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

35 production modules (Gradle), 0 dependency cycle(s), 0 unstable depended-on module(s). Read from the build's own module declarations; edges a convention plugin adds from buildSrc or build-logic are not visible there; 0 module(s) off the main sequence, with abstractness counted on 6 of the 35 (the rest declare no modelled class or interface, export only macros, declare types in source no model reads, or have no source directory of their own).

✓ On the Gold path — maintain.

Detailed fixes: d5_recommendation.md.

D6 · Cohesion (LCOM4)9.8 / 10Stronggated by 3 serious findings✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Verified

3 of 154 classes have LCOM4 above 3.

Low cohesion: VideoPlayerGlue (LCOM4 8) · ×3smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/other/VideoPlayerGlue.java:79

What to do

  1. Resolve the 3 Low cohesion finding(s) in Cohesion (LCOM4) — start with VideoPlayerGlue.java, MediaServiceManager.java, SearchTagsFragmentBase.java. — One of this dimension's main actionable groups (3 warning-level).
  2. Enforce Cohesion (LCOM4) in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Verified — provenance only; does not change the score.

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D9 · Test Distribution10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the test suite has a healthy mix of unit / integration / end-to-end tests.

Method: Test projects classified (Unit/Integration/BDD/E2E) from compiled metadata; test methods counted exhaustively across projects with placement-agnostic disk fallback. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

1421 test methods: 1421 unit, 0 integration, 0 BDD, 0 e2e.

✓ On the Gold path — maintain.

Detailed fixes: d9_recommendation.md.

D10 · Test Quality8.4 / 10Strong✓ Tool-verified

What it measures: Whether the tests truly assert behaviour rather than just running the code.

Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.4 / 10 · rule-coverage 100% · ceiling Prevented

4 skipped (4 with a documented reason), 154 zero-assertion, no mocking-framework packages referenced (hand-written doubles or no mocking) across 1421 tests.

No assertions: testGetCastTimelinePersistsDuration · ×154exoplayer-amzn-2.10.6/extensions/cast/src/test/java/com/google/android/exoplayer2/ext/cast/CastTimelineTrackerTest.java:42
Test project verifies nothing: ffmpeg · ×4exoplayer-amzn-2.10.6/extensions/ffmpeg/src/test/java/com/google/android/exoplayer2/ext/ffmpeg/DefaultRenderersFactoryTest.java:29
Skipped (documented): testSaveAndLoadActionFile · ×4exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/offline/DownloadManagerDashTest.java:114

What to do

  1. Resolve the 154 No assertions finding(s) in Test Quality — start with ExoPlayerTest.java (17), DownloadManagerTest.java (12), AdtsReaderTest.java (11). — One of this dimension's main actionable groups (154 warning-level).
  2. Resolve the 4 Test project verifies nothing finding(s) in Test Quality — start with DefaultRenderersFactoryTest.java (3), DefaultDataSourceTest.java. — One of this dimension's main actionable groups (4 warning-level).
  3. Enforce Test Quality in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · REDACTED Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

REDACTED scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 2 declared JVM dependency artifact(s) use a banned license. Licences were resolved from the POMs Maven Central publishes, over the coordinates this repository's 38 Maven/Gradle manifest(s) declare with a version resolvable from the manifest itself — the same declaration-site closure this analysis reads for dependency currency. The JVM has no lockfile a checkout is guaranteed to carry, so this is deliberately NOT the transitive closure. A further 17 coordinate(s) are not published to Maven Central — another repository (Google's Maven hosts androidx), a SNAPSHOT, or a private artifact — so their licences are not readable from here and they are outside this verdict.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots9.4 / 10Stronggated by 7 serious findings✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 9.4 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java (37×34=1258); exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/DefaultSabrChunkSource.java (11×18=198); exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/parser/SabrProcessor.java (3×29=87) Repeated repair below the complexity floor: common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/MotherActivity.java (8 of 10 changes were fixes); common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/ScreensaverManager.java (4 of 6 changes were fixes); common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoStateController.java (3 of 5 changes were fixes)

Repeated repair: common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/MotherActivity.java · ×4common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/MotherActivity.java:133
Hotspot: common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java · ×3common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java:225

What to do

  1. Resolve the 4 Repeated repair finding(s) in Churn × Complexity Hotspots — start with MotherActivity.java, ScreensaverManager.java, VideoStateController.java. — One of this dimension's main actionable groups (4 warning-level).
  2. Resolve the 3 Hotspot finding(s) in Churn × Complexity Hotspots — start with ErrorFixerController.java, DefaultSabrChunkSource.java, SabrProcessor.java. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt10.0 / 10Stronggated by 23 serious findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

23 deducted task-comment markers across 308722 LoC (0.0/KLoC) → score 10.0. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

TodoComment · ×22common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/VideoGroup.java:444
FixmeCommentcommon/src/main/java/com/liskovsoft/smartyoutubetv2/common/proxy/WebProxyDialog.java:58

What to do

  1. Resolve the 22 TodoComment finding(s) in Explicit Debt — start with LiveDashManifestParser.java (11), ChannelsProvider.java (3), VideoGroup.java. — One of this dimension's main actionable groups (22 warning-level).
  2. Resolve the 1 FixmeComment finding(s) in Explicit Debt — start with WebProxyDialog.java. — One of this dimension's main actionable groups (1 warning-level).
  3. Enforce Explicit Debt in CI to reach Verified (currently Documented). — Hardens enforcement from Documented toward Prevented — provenance only; does not change the score.

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation QualityStrong◐ Sampled · advisory

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic doc sample (READMEs plus first 25 architecture docs), with two-pass stability filtering. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Strong / 10 · rule-coverage 100% · ceiling Documented

The repository's root README is a strong overview (announcing an unknown malware incident and the one-time-code-access security model plus how to revoke access), with a dedicated SmartTube section that begins with ✅ Features and ends at the clip marker. The architecture/design docs are empty; all 32 READMEs document their own directories rather than the repository as a whole, so the missing-overview, missing-installation, and missing-usage findings apply only to the root README (which is not shown). Internal jargon appears in the one-time-code-access security note but does not dominate the text. The repository is a collection of directory-level READMEs for extensions such as IMA, Firebase JobDispatcher, Leanback, MediaSession, OkHttp, Opus, RTMP, and VP9. Each extension's README documents the directory it belongs to rather than the project itself, so its own overview, installation, usage, or contribution guidance is not judged here. The documentation is well-structured with clear headings (Getting the extension; Using the extension) and links, but there are no architecture/design docs and no single document covers the project's scope, installation, or licensing.

What to do

  1. Improve Documentation Quality — currently 7.4/10. — The repository's root README is a strong overview (announcing an unknown malware incident and the one-time-code-access security model plus how to revoke access), with a dedicated SmartTube section that begins with ✅ Features and ends at the clip marker. The architecture/design docs are empty; all 32 READMEs document their own directories rather than the repository as a whole, so the missing-overview, missing-installation, and missing-usage findings apply only to the root README (which is not shown). Internal jargon appears in the one-time-code-access security note but does not dominate the text. The repository is a collection of directory-level READMEs for extensions such as IMA, Firebase JobDispatcher, Leanback, MediaSession, OkHttp, Opus, RTMP, and VP9. Each extension's README documents the directory it belongs to rather than the project itself, so its own overview, installation, usage, or contribution guidance is not judged here. The documentation is well-structured with clear headings (Getting the extension; Using the extension) and links, but there are no architecture/design docs and no single document covers the project's scope, installation, or licensing.

Detailed fixes: d19_recommendation.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Per-ADR judgment by language model at low temperature with two-pass stability; confidence is share of ADRs evaluated; enforcement-field presence detected deterministically. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs found

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D21 · Naming ConsistencyExemplary◐ Sampled · advisory

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Judged by language model at low temperature (0.0-0.1) on a deterministic random symbol sample (fixed size, not exhaustive), with disclosed confidence band. Advisory, sampled.

Maturity: Documented → Verified → Prevented · effective Exemplary / 10 · rule-coverage 100% · ceiling Verified

0 naming inconsistencies across 0 sampled symbols.

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md.

D22 · Internal API ConsistencyWeak◐ Sampled · advisory

What it measures: Whether the internal API surface is consistent and coherent.

Method: Judged by language model at low temperature over a sample of the public API surface (IsPackable or .Contracts types). Sampled, advisory; confidence discounted by model uncertainty.

Maturity: Documented → Verified → Prevented · effective Weak / 10 · rule-coverage 100% · ceiling Verified

3 API inconsistencies across 11 exposed types.

Duplicate listener interfaces with inconsistent method signatures. SlidrListener and OnPanelSlideListener expose nearly identical lifecycle events (open, close, slide, state change) but differ in return types (e.g., SlidrListener.onSlideClosed returns boolean, OnPanelSlideListener.onClosed returns void) and naming conventions (onSlideClosed vs onClosed). This forces users to choose between two nearly identical interfaces with subtle behavioral differences.
SlidrListenerAdapter duplicates the method signatures of SlidrListener exactly, acting as a pass-through or default implementation. While adapters are common, having a separate adapter class that mirrors the interface exactly without adding default behavior or extending it suggests a lack of default methods in the interface itself (Java 7/8 compatibility issue perhaps), but it creates redundancy in the public API surface.
Ambiguous distinction between abort() and cancel(). In Android's ViewDragHelper, cancel() typically cancels the current drag/settle operation, while abort() might imply a more forceful termination. However, without clear documentation or distinct behavioral signatures in the API surface, these two methods appear to serve overlapping purposes of stopping the current interaction, leading to potential misuse.

What to do

  1. Resolve the 1 Duplicate listener interfaces with inconsistent method signatures.… finding(s) in Internal API Consistency. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 SlidrListenerAdapter duplicates the method signatures of SlidrListener… finding(s) in Internal API Consistency. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 Ambiguous distinction between abort() and cancel(). In Android's… finding(s) in Internal API Consistency. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d22_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion8.6 / 10Strong✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic, LLM-independent.

Maturity: Documented → Verified → Prevented · effective 8.6 / 10 · rule-coverage 100% · ceiling Documented

2 of 29 build units (Gradle) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion

What to do

  1. Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D27 · Navigability9.8 / 10Exemplary✓ Tool-verified

What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.

Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.

Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Documented

76 % of calls cross a namespace and 4 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: small — navigation cost is tolerated.

✓ On the Gold path — maintain.

Detailed fixes: d27_recommendation.md.

D28 · Secrets (history)1.0 / 10Critical✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 1.0 / 10 · rule-coverage 100% · ceiling Documented

9 finding(s): 0 critical, 9 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED
REDACTED

What to do

  1. Resolve the 9 REDACTED finding(s) in Secrets (history) — start with REDACTED (6), REDACTED (2), REDACTED. — One of this dimension's main actionable groups (9 issue-level).
  2. Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

D29 · Static Analysis (SAST)2.5 / 10Weak✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 2.5 / 10 · rule-coverage 100% · ceiling Documented

17 finding(s): 0 critical, 4 high, 13 medium, 0 low. Separately, one or more rules could not re-parse an embedded snippet in 2 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

+ 1 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  2. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  3. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D34 · Knowledge Freshness10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

Every significant source file has living knowledge — recently and meaningfully worked. Counted over 277 of the 561 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

✓ On the Gold path — maintain.

Detailed fixes: d34_recommendation.md.

D35 · Change Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No strong hidden change-coupling between production files.

✓ On the Gold path — maintain.

Detailed fixes: d35_recommendation.md.

D36 · Supply-chain Provenance & Signing5.0 / 10Adequate✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 5.0 / 10 · rule-coverage 100% · ceiling Documented

2/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).
  3. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D44 · Platform End-of-Life10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 36 platform declaration(s) and 41 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

✓ On the Gold path — maintain.

Detailed fixes: d44_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX10 · Code composition9.8 / 10Exemplary✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

What to do

  • The domain core is a small share of production code, but most of the rest matched no layer vocabulary at all — so this is not yet an anemic-domain finding. The namespace/path convention could not place that code, which makes the composition above a statement about the naming, not about the design. Name the layers (or check that the repository's conventions differ from the ones this check knows) before reading a thin domain into it.
AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX6 · Interface segregation9.9 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

  • `AudioSink` declares 21 abstract methods: `configure`, `disableTunneling`, `enableTunnelingV21`, `flush`, `getCurrentPositionUs`, `getPlaybackParameters`, `handleBuffer`, `handleDiscontinuity`, `hasPendingData`, `isEnded`, `pause`, `play`, `playToEndOfStream`, `reset`, `setAudioAttributes`, `setAudioSessionId`, `setAuxEffectInfo`, `setListener`, `setPlaybackParameters`, `setVolume`, `supportsOutput`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/audio/AudioSink.java:52
  • `ExoMediaDrm<T>` declares 16 abstract methods: `closeSession`, `createMediaCrypto`, `getKeyRequest`, `getPropertyByteArray`, `getPropertyString`, `getProvisionRequest`, `openSession`, `provideKeyResponse`, `provideProvisionResponse`, `queryKeyStatus`, `release`, `restoreKeys`, `setOnEventListener`, `setOnKeyStatusChangeListener`, `setPropertyByteArray`, `setPropertyString`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/drm/ExoMediaDrm.java:34
  • `TrackSelection` declares 16 abstract methods under just 15 distinct name(s): `blacklist`, `disable`, `enable`, `evaluateQueueSize`, `getFormat`, `getIndexInTrackGroup`, `getSelectedFormat`, `getSelectedIndex`, `getSelectedIndexInTrackGroup`, `getSelectionData`, `getSelectionReason`, `getTrackGroup`, `indexOf`, `indexOf`, `length`, `onPlaybackSpeed`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface. — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/trackselection/TrackSelection.java:38
  • `Cache` declares 17 abstract methods: `addListener`, `applyContentMetadataMutations`, `commitFile`, `getCacheSpace`, `getCachedLength`, `getCachedSpans`, `getContentMetadata`, `getKeys`, `getUid`, `isCached`, `release`, `releaseHoleSpan`, `removeListener`, `removeSpan`, `startFile`, `startReadWrite`, `startReadWriteNonBlocking`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/Cache.java:28
  • `Player` declares 55 abstract methods: `addListener`, `getApplicationLooper`, `getAudioComponent`, `getBufferedPercentage`, `getBufferedPosition`, `getContentBufferedPosition`, `getContentDuration`, `getContentPosition`, `getCurrentAdGroupIndex`, `getCurrentAdIndexInAdGroup`, `getCurrentManifest`, `getCurrentPeriodIndex`, `getCurrentPosition`, `getCurrentTag`, `getCurrentTimeline`, `getCurrentTrackGroups`, `getCurrentTrackSelections`, `getCurrentWindowIndex`, `getDuration`, `getMetadataComponent`, `getNextWindowIndex`, `getPlayWhenReady`, `getPlaybackError`, `getPlaybackParameters`, `getPlaybackState`, `getPlaybackSuppressionReason`, `getPreviousWindowIndex`, `getRendererCount`, `getRendererType`, `getRepeatMode`, `getShuffleModeEnabled`, `getTextComponent`, `getTotalBufferedDuration`, `getVideoComponent`, `hasNext`, `hasPrevious`, `isCurrentWindowDynamic`, `isCurrentWindowSeekable`, `isLoading`, `isPlaying`, and 15 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 55 declarations carry 52 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 52 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/Player.java:60
  • `VideoComponent` declares 17 abstract methods: `addVideoListener`, `clearCameraMotionListener`, `clearVideoFrameMetadataListener`, `clearVideoSurface`, `clearVideoSurface`, `clearVideoSurfaceHolder`, `clearVideoSurfaceView`, `clearVideoTextureView`, `getVideoScalingMode`, `removeVideoListener`, `setCameraMotionListener`, `setVideoFrameMetadataListener`, `setVideoScalingMode`, `setVideoSurface`, `setVideoSurfaceHolder`, `setVideoSurfaceView`, `setVideoTextureView`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 17 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/Player.java:146
  • `Renderer` declares 21 abstract methods: `disable`, `enable`, `getCapabilities`, `getMediaClock`, `getReadingPositionUs`, `getState`, `getStream`, `getTrackType`, `hasReadStreamToEnd`, `isCurrentStreamFinal`, `isEnded`, `isReady`, `maybeThrowStreamError`, `render`, `replaceStream`, `reset`, `resetPosition`, `setCurrentStreamFinal`, `setIndex`, `start`, `stop`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/Renderer.java:36
  • `PlayerEngine` declares 42 abstract methods: `blockEngine`, `containsMedia`, `getAudioFormat`, `getAudioFormats`, `getDurationMs`, `getPitch`, `getPlayWhenReady`, `getPositionMs`, `getResizeMode`, `getSpeed`, `getSubtitleFormat`, `getSubtitleFormats`, `getVideoFormat`, `getVideoFormats`, `getVolume`, `isEngineBlocked`, `isEngineInitialized`, `isInPIPMode`, `isLoading`, `isPlaying`, `openDash`, `openDash`, `openDashUrl`, `openHlsUrl`, `openMerged`, `openMerged`, `openSabr`, `openUrlList`, `reloadPlayback`, `restartEngine`, `setAspectRatio`, `setFormat`, `setPitch`, `setPlayWhenReady`, `setPositionMs`, `setResizeMode`, `setRotationAngle`, `setSpeed`, `setVideoFlipEnabled`, `setVideoGravity`, and 2 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 42 declarations carry 40 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 40 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/manager/PlayerEngine.java:9
  • `PlayerUI` declares 28 abstract methods: `clearSuggestions`, `focusSuggestedItem`, `focusSuggestedItem`, `getButtonState`, `getSuggestionsByIndex`, `getSuggestionsIndex`, `isControlsShown`, `isOverlayShown`, `isSuggestionsEmpty`, `isSuggestionsShown`, `loadStoryboard`, `removeSuggestions`, `resetSuggestedPosition`, `setButtonState`, `setChannelIcon`, `setChatReceiver`, `setNextTitle`, `setSeekBarSegments`, `setSeekPreviewTitle`, `setTitle`, `showControls`, `showDebugInfo`, `showOverlay`, `showProgressBar`, `showSubtitles`, `showSuggestions`, `updateEndingTime`, `updateSuggestions`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 28 declarations carry 27 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 27 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces. — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/manager/PlayerUI.java:10

What to do

  • Split fat interfaces into focused role-interfaces so clients depend only on what they use.
  • Where the width is an overload set rather than separate responsibilities, collapse the overloads instead — segregating those relieves no caller.
IC1 · Incompleteness & stubs8.5 / 10Strong✓ Tool-verified

Other · Code Health — Unfinished work detected by code SHAPE, not keywords, in this repository's Java: methods that only throw a "not implemented" exception, methods that take inputs and return a constant or do nothing, dead `if (false)` branches, and skeleton classes most of whose methods are holes.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

  • `encode` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/parser/ump/UMPEncoder.java:4
  • `onKeyUpShortPress` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in. — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/util/LongPressHandler.java:45
  • A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something. (×4) — exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/offline/DownloadManagerDashTest.java:112, exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/offline/DownloadServiceDashTest.java:156, exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/offline/DownloadServiceDashTest.java:167, …
  • `onFadeInComplete` has an empty body — confirm it's an intentional no-op and not an unfinished method. — leanback-1.0.0/src/main/java/androidx/leanback/app/PlaybackSupportFragment.java:196
  • `onFadeOutComplete` has an empty body — confirm it's an intentional no-op and not an unfinished method. — leanback-1.0.0/src/main/java/androidx/leanback/app/PlaybackSupportFragment.java:199

What to do

  • Finish or delete the unfinished stubs (functions that throw "not implemented", or whose body is empty or a bare constant) — they are dead surface that looks live.
  • Clear the softer debt: re-enable or delete @Disabled/@Ignore tests, decide whether each empty method or UnsupportedOperationException is deliberate (and say so in a comment), and replace @SuppressWarnings("all") with targeted, justified suppressions.
M1 · Documentation (README)8.2 / 10Strong✓ Tool-verified

Maturity · Maturity — Whether the repo and its projects have a README, and whether it's substantive and current.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
  • Add an 'Architecture' / 'How it works' section to the root README — the high-level shape.
  • Add a README to the 9 of 37 project(s) that lack one — worth up to 0.5 pts.
M2 · Architecture documentation0.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
  • No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
  • Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repo is organised deliberately — src/test separation and consistent project naming.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy9.1 / 10Exemplary◐ Sampled · advisory

Maturity · Maturity — Whether the README actually describes the code that exists (LLM-judged, advisory).

Method: Judged by language model at low temperature: README accuracy versus actual projects, within a disclosed tolerance. Advisory, not a measured number.

  • doubletapplayerview/README.md links to `github/preview_gif.gif`, but `doubletapplayerview/github/preview_gif.gif` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — doubletapplayerview/README.md:6
  • filepicker-lib/README.md links to `ss/main.png`, but `filepicker-lib/ss/main.png` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — filepicker-lib/README.md:5
  • exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md documents the environment variable `FFMPEG_EXT_PATH`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md:28
  • exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md documents the environment variable `HOST_PLATFORM`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md:41
  • exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md documents the environment variable `COMMON_OPTIONS`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md:52
  • exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md documents the environment variable `APP_ABI`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md:110
  • exoplayer-amzn-2.10.6/extensions/flac/README.md documents the environment variable `EXOPLAYER_ROOT`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — exoplayer-amzn-2.10.6/extensions/flac/README.md:27
  • exoplayer-amzn-2.10.6/extensions/flac/README.md documents the environment variable `FLAC_EXT_PATH`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — exoplayer-amzn-2.10.6/extensions/flac/README.md:28
  • exoplayer-amzn-2.10.6/extensions/opus/README.md documents the environment variable `EXOPLAYER_ROOT`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — exoplayer-amzn-2.10.6/extensions/opus/README.md:27
  • exoplayer-amzn-2.10.6/extensions/opus/README.md documents the environment variable `OPUS_EXT_PATH`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — exoplayer-amzn-2.10.6/extensions/opus/README.md:28
  • exoplayer-amzn-2.10.6/extensions/vp9/README.md documents the environment variable `EXOPLAYER_ROOT`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — exoplayer-amzn-2.10.6/extensions/vp9/README.md:27
  • exoplayer-amzn-2.10.6/extensions/vp9/README.md documents the environment variable `VP9_EXT_PATH`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong. — exoplayer-amzn-2.10.6/extensions/vp9/README.md:28

What to do

  • Reconcile the README with reality: doubletapplayerview/README.md links to `github/preview_gif.gif`, but `doubletapplayerview/github/preview_gif.gif` does not exist; filepicker-lib/README.md links to `ss/main.png`, but `filepicker-lib/ss/main.png` does not exist; exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md documents the environment variable `FFMPEG_EXT_PATH`, but no code, script or configuration file names it; exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md documents the environment variable `HOST_PLATFORM`, but no code, script or configuration file names it; exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md documents the environment variable `COMMON_OPTIONS`, but no code, script or configuration file names it.
P1 · CI/CD gates8.5 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

What to do

  • Run the test suite in CI via an explicit runner step (`./gradlew test` for the toolchain this pipeline already uses) and gate merges on it.
P10 · Library API & versioning6.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.

Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.

  • No explicit version was found for the Maven/Gradle library declared by `build.gradle`. This check read a `<version>` in pom.xml, or `version` in build.gradle(.kts) or gradle.properties, and a CHANGELOG/CHANGES/HISTORY/NEWS/RELEASES file with a semver heading, or release tooling (changesets, release-please, semantic-release, goreleaser, cargo-release, bump2version, standard-version, git-cliff) in the library's directory or at the repository root, or a semver release tag (or a Drupal `8.x-1.2` release tag) in the repository. A version computed where none of those can see is invisible here. A published library needs explicit semantic versioning so consumers can reason about breaking changes. — slidableactivity/build.gradle

What to do

  • Declare the version where the ecosystem expects it, or keep a CHANGELOG with semver release headings, and follow semver for breaking changes.
P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 10847 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.

What to do

  • Add a SAST step to CI running what this repository's stack ships: spotbugs with find-sec-bugs — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P5 · DR & Backup4.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether disaster recovery is planned and codified — backups, geo-recovery, RTO/RPO, persistence guarantees — from IaC + container manifests + docs, never the live cloud.

Method: Filesystem scan: disaster recovery, backup, geo-recovery, RTO/RPO, persistence guarantees from IaC, manifests, and docs. Exhaustive, deterministic, never a live environment.

What to do

  • Document RTO/RPO and a tested restore procedure (a backup config alone isn't disaster recovery).
P6 · Release Hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

PF2 · Allocation hygiene6.7 / 10Adequate✓ Tool-verified

Readiness · Performance — Whether the code is written to minimise allocations so it doesn't pressure its host's memory manager — buffer/slice views over copies, object pooling, stack or value-type allocation, and buffer writers. Reward-only: credited where present, never penalised where a simpler style is fine.

Method: Production-source scan: density (per 1k LoC) of allocation-aware APIs — in .NET Span/Memory, ArrayPool/ObjectPool, stackalloc, ValueTask, value-type structs, IBufferWriter, string.Create, SkipLocalsInit; off .NET, with comments and strings blanked, Go's sync.Pool, preallocated slices/maps, Grow, strconv.Append* and buf[:0] reuse; the JVM's NIO buffer views, MemorySegment, primitive collections, pools and literal presizes (plus Kotlin primitive arrays and value classes, Scala AnyVal and @specialized); Swift's reserveCapacity, ContiguousArray, withUnsafe* access and ~Copyable. Activated off .NET on the same floor (400 lines, and benchmarks or 8 uses); Rust and garbage-collected scripting languages are not applicable. Reward-only. Deterministic, syntax/text detection.

What to do

  • Raise allocation-aware density on the hot paths — currently 475 use(s) across 344,665 production line(s) (~1.4/1k). More of the idioms below on the allocation-heavy paths climbs this toward 10.
  • Java: on hot paths, work through buffer views (ByteBuffer/LongBuffer slices, MemorySegment) instead of copies, avoid boxing with primitive collections (fastutil, Eclipse Collections, HPPC, Trove), presize collections and StringBuilders, and pool expensive buffers (Netty's pooled allocator, commons-pool).
  • Kotlin: on hot paths, use primitive arrays (IntArray, LongArray …) and @JvmInline value classes instead of boxed values, primitive collections (androidx.collection, fastutil) instead of boxed ones, and presize collections and StringBuilders.
X1 · Async correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

X14 · Bypassable address classification10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a hand-rolled public/private IP check can be walked past — a method that unwraps IPv4-mapped IPv6 but returns the opposite verdict for the same host written as IPv4-compatible, 6to4 or NAT64.

Method: Roslyn syntax + semantics: methods that unwrap IPv4-mapped IPv6 and hand-roll IPv4 range carve-outs, checked for whether the IPv6 branch also accounts for the IPv4-compatible, 6to4 and NAT64 embeddings. Deterministic, provable per finding. Advisory.

X15 · Unvalidated length from an untrusted reader2.4 / 10Critical✓ Tool-verified

Other · Security — Whether a length read out of the stream being parsed is bounded before it is allocated or read — an unchecked count taken from the input lets the input choose the allocation.

Method: Roslyn syntax + semantics: integer lengths read from a BinaryReader and spent on a bulk read or an array allocation, checked for any comparison or bounding call on the value anywhere in the method. Deterministic, provable per finding. Advisory.

  • `entryCount` is read from the bytes being parsed at line 536 (`readInt`), then used to size a `new String[]` at line 537 — and nowhere in its scope is `entryCount` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `entryCount` against the bytes actually remaining and a maximum the format allows before allocating. — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/extractor/mp4/AtomParsers.java:537
  • `entryCount` is read from the bytes being parsed at line 991 (`readUnsignedIntToInt`), then used to size a `new long[]` at line 992 — and nowhere in its scope is `entryCount` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `entryCount` against the bytes actually remaining and a maximum the format allows before allocating. — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/extractor/mp4/AtomParsers.java:992
  • `subFrameCount` is read from the bytes being parsed at line 55 (`readInt`), then used to size a `new Id3Frame[]` at line 56 — and nowhere in its scope is `subFrameCount` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `subFrameCount` against the bytes actually remaining and a maximum the format allows before allocating. — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/metadata/id3/ChapterTocFrame.java:56
  • `subFrameCount` is read from the bytes being parsed at line 64 (`readInt`), then used to size a `new Id3Frame[]` at line 65 — and nowhere in its scope is `subFrameCount` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `subFrameCount` against the bytes actually remaining and a maximum the format allows before allocating. — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/metadata/id3/ChapterFrame.java:65
  • `dataLength` is read from the bytes being parsed at line 101 (`readInt`), then used to size a `new byte[]` at line 104 — and nowhere in its scope is `dataLength` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `dataLength` against the bytes actually remaining and a maximum the format allows before allocating. — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/offline/ActionFile.java:104

What to do

  • Each finding names the read that takes the length from the input and the site that spends it, and states that the value is never compared in between. Confirm from the two, then bound the length against the remaining stream before using it.
X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X17 · Uncapped recursion over a caller-supplied document10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether a walk that recurses through a JSON/XML tree handed in by its caller bounds how deep it will go — an uncapped walk lets the document's nesting choose the stack depth, and the resulting StackOverflowException cannot be caught.

Method: Roslyn syntax + semantics: methods that take a JSON/XML document node and call themselves with a child of it, reachable from an externally-callable member of the same type that accepts a document, checked for any depth parameter, descent counter or threaded arithmetic anywhere in the walk. On a repository with no .NET source it reads TypeScript off the engine’s own token stream (test, vendored, generated and minified paths and `.d.ts` not) with the same rule: a function or method with a parameter typed as a document value — `unknown`, `any`, `object`, `Record<string, unknown|any>`, a JSON alias (`JsonValue`, `JSONObject`, …) or a DOM node global the file does not rebind — that calls itself (bare, or through `this` for a method, or hands itself to a call over the value as in `value.map(walk)`) with something it took out of that value and never through an ancestor accessor such as `closest()` or `parentElement`, that is exported or reached from an exported function (a public method of the same exported class) taking such a value, and that names no depth, level, nesting, recursion, remaining or budget anywhere and threads no `+`/`-` arithmetic through a self-call. Plain JavaScript is not read: with no annotation nothing tells a parsed document from a tree the code built itself. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

X19 · Unrestored process-global state3.5 / 10Weak✓ Tool-verified

Other · Code Health — Whether a method that temporarily changes state belonging to the whole process — the working directory, an environment variable — puts it back on EVERY path: a restore reached only when nothing throws leaks the change to the rest of the process.

Method: Roslyn syntax + semantics: method bodies that write the process working directory or an environment variable and write it back in the same body, checked for whether that restore sits in a `finally`/`catch` or only on the straight-line path. On a repository with no .NET source the same rule reads production JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not): `process.chdir`, `process.env.NAME =`/`["NAME"] =` and `delete process.env.NAME`, and Deno’s `Deno.chdir`/`Deno.env.set`/`Deno.env.delete`, paired per function body (a nested function or arrow is its own body, and module top-level code is none), where the last write puts back a local the body captured from the same global or deletes a variable the first write set, with at least one statement between them; a write in a `catch`/`finally` of that body silences it. Deterministic, provable per finding. Advisory.

  • `setWebProxyAPI19Plus` changes state that belongs to the whole JVM and changes it back at the end of the same body — the `http.proxyHost` system property (set at line 243, cleared at line 287) and the `http.proxyPort` system property (set at line 244, cleared at line 288) and the `https.proxyHost` system property (set at line 245, cleared at line 289) and the `https.proxyPort` system property (set at line 246, cleared at line 290) and the `http.proxyUser` system property (set at line 251, cleared at line 294) and the `http.proxyPassword` system property (set at line 252, cleared at line 295) and the `https.proxyUser` system property (set at line 253, cleared at line 296) and the `https.proxyPassword` system property (set at line 254, cleared at line 297) — which says the change was meant to last no longer than this call. But the restore is an ordinary statement on the straight-line path, not a `finally`, so it is skipped by any exception thrown in between: the JVM then keeps the overwritten value for the rest of its life, and every later property lookup, formatter, date conversion or console write in ANY class reads it. That failure is silent and remote from its cause — the method that breaks is not the method that moved the value. The window is not private while it is open either: system properties, the default `Locale` and `TimeZone` and the standard streams are per-JVM, not per-thread, so a concurrent thread reads the moved value too. The durable fix is not to widen the restore but to stop mutating the global: pass the value to the operation that needs it — an explicit `Locale` to `String.format`/`NumberFormat`/`DateTimeFormatter`, a `ZoneId` to `java.time`, the setting to the component that reads the property, a `PrintStream` to the code that writes, `ProcessBuilder.environment()`/`directory()` for a child. Where the global genuinely must move, wrap it `try`/`finally` so the restore runs on every path. — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/proxy/ProxyManager.java:215

What to do

  • Each finding names the statement that changes the JVM-global value and the statement that puts it back. Confirm from the two that nothing between them is protected — then prefer removing the mutation over widening the restore: a `Locale`, a `ZoneId` or a setting passed to the operation that needs it (`String.format(Locale.ROOT, …)`, `DateTimeFormatter.withZone`, `ProcessBuilder.environment()`) is scoped to that operation, which is what the save-and-restore was trying to approximate. Where the global genuinely must move, a `try`/`finally` is the least that makes the restore unconditional. In Kotlin the same holds for a system property, the default `Locale` or `TimeZone` and `System.out`: pass the value to the operation (`"%.2f".format(Locale.ROOT, …)`, a `ZoneId`) rather than moving the global.
X20 · Mistyped argument guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `NullPointerException` (Java, Kotlin, Scala), `ArgumentError.notNull` (Dart) or `ArgumentNullException` (F#'s `nullArg`) tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements controlled by an `if`, whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`). Deterministic, provable per finding. Advisory.

X21 · Side-effecting pattern guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.

Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.

X22 · Contradicted release guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back.

Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.

Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.

X25 · Inert configuration knob10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.

Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.

X26 · Unsynchronised callback handoff10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.

Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.

X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an enhanced `for` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is iterating invalidates the fail-fast iterator it is holding, so the next `next()` throws `ConcurrentModificationException` and the remaining elements are never seen. Whether a `for (x in c)` or `c.forEach { … }` leaves the collection it is walking alone — a `mutableListOf`/`ArrayList`, `mutableMapOf`/`HashMap` or `mutableSetOf`/`HashSet` is a `java.util` collection on the JVM and is walked by its own fail-fast iterator, so a body that adds to or removes from the very collection the loop is walking makes the next step throw `ConcurrentModificationException` and the remaining elements are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

X3 · Exception handling7.5 / 10Strong✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×4) — chatkit/src/main/java/com/stfalcon/chatkit/messages/MessageInput.java:264, exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CachedContentIndex.java:325, exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/util/EGLSurfaceTexture.java:192, …
  • `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/MediaStoreFile.kt:387
  • `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×3) — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/audio/AudioTrackPositionTracker.java:682, exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/util/AmazonQuirks.java:144, slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:67
  • `catch (RuntimeException)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×2) — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/metadata/emsg/EventMessageDecoder.java:55, exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/util/Util.java:1460

What to do

  • Swallowed exception (empty catch)
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X5 · Nullable reference types2.0 / 10Critical✓ Tool-verified

Other · Code Health — Whether Java packages are null-marked and not undermined by heavy nullness suppression — a package under `@NullMarked` (or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, or a NullAway/Checker Framework configuration naming it) makes an unannotated reference exclude null, and `@SuppressWarnings("NullAway")`, `("nullness")`, `("null")` and `castToNonNull(…)` are what silence it.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • 0/211 of this repository's Java package directories are under a non-null default: a `package-info.java` declaring `@NullMarked` (JSpecify) or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, `@DefaultQualifier(NonNull.class)`; a `module-info.java` declaring `@NullMarked`; every type in it `@NullMarked`; or a build that runs NullAway with the package in `AnnotatedPackages`, or the Checker Framework's `NullnessChecker`. Elsewhere every reference admits null and no checker warns on the dereference that throws a `NullPointerException`.

What to do

  • Declare the default where Java declares it: `@NullMarked` (org.jspecify.annotations) in each package's `package-info.java`, or once in `module-info.java`, and run NullAway (Error Prone) or the Checker Framework so the declaration is enforced. Then annotate the real exceptions `@Nullable` and resolve the suppressions rather than adding to them: a `@SuppressWarnings("NullAway")` or `castToNonNull(x)` on a value the checker could show to be null is a `NullPointerException` waiting for the path that makes it true — where the value genuinely cannot be null, say something the checker can see instead (a null check, `Objects.requireNonNull`, a non-null field initialised in the constructor).

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health65%Adequate — gated by X5Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Architecture98%ExemplaryStrongest area.
Maturity61%Adequate — gated by M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness49%Weak — gated by P3Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security46%Weak — gated by D28, D29Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance67%AdequateAcceptable, with room to improve.
Unscored — 2 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • X10 Duplicated predicate — 25 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X7 Silent fallback defaults — 3 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 4 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • C3 Audit Trail — Not assessed: these audit controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C4 Data Retention — Not assessed: these retention controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks retention controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C5 Data-Subject Rights — Not assessed: these data-subject rights controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks data-subject rights controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • P4 Deployment & Rollback — not evidenced — no deploy/rollback/approval signal in the repo; absence of evidence is not evidence of a manual release
Not included — 53 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AC7 A11y enforcement — No web markup found — accessibility is not applicable to this repository.
  • AX1 Captive dependencies — Not applicable: this repository's Java imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's; this repository's Kotlin imports no dependency-injection container and defines no container of its own — nothing that both registers and resolves bindings, and nothing that names two lifetimes — so nothing holds one lifetime's instance while handing out another's.
  • AX2 Stateful singletons — No container singleton was found, so there is no shared instance for concurrent requests to race on. No class in this Java code is a Spring, JSR-330 or CDI singleton bean. No class in this Kotlin code is a Spring, JSR-330 or CDI singleton bean.
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — no test/production split to check
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • AXR1 Runtime accessibility — the Android app did not build — `./gradlew :smarttubetv:assembleDebug` exited 1: Build failed with an exception. * What went wrong: Could not open settings generic class cache for settings file 'settings.gradle' (/tmp/codeheal…; runtime evidence skipped (launch chosen because smarttubetv/build.gradle applies the Android application plugin and gradlew builds it) This is a statement about this run, not a statement about your application: nothing here says the app is inaccessible, only that it was never run.
  • C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • D11 Test Reliability — Test reliability not included — the .java suite was found but not re-run
  • D12 Dependency Hygiene — Not scored — 38 Maven/Gradle manifest(s) were read, stating a version for 40 dependency(ies) and leaving 0 to a parent or an imported BOM, but no build resolved the dependency graph, so the outdated signal was not established. NOT a finding that these dependencies are current or healthy.
  • D16 Bus Factor — single-maintainer repository — bus factor is not applicable
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ projects each declaring an entity of their own. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — No inline comments to assess — comment value is not applicable here.
  • D25 ADR Conformance — no ADRs to check
  • D30 Dependency Vulnerabilities — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) — not scanned yet).
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D39 IL Efficiency — D39 measures the IL emitted by a .NET build; this repository has no .NET solution or project files, so the dimension does not apply.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D43 Malicious Dependencies — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) — not scanned yet).
  • D7 Architectural Integrity — no checkable ADRs, and no project-reference graph for the cycle pass to read — so this dimension makes no claim about dependency cycles in either direction (where this repository's language has an import-cycle lens, cycles are reported there). Architectural integrity not assessed
  • D8 Code Coverage — Coverage not included — suite not readable by the collector
  • DM1 Domain Modelling — not scored — this repository shows only 1 of the 3 signals this lens looks for (99 value object(s))
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
  • P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • P2 Observability — This repository's JVM source (29 module(s), 1399 file(s) read) declares no entry point and bootstraps no server, and nothing here deploys a service — it is a library, run inside whatever hosts it, so production observability (structured logging, tracing/metrics, health checks) is N/A. If it grows a binary or a service, the dimension reactivates.
  • P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the JVM source, so there is no service whose uptime a failing dependency could take down
  • P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
  • P9 Domain vs controller coverage — no coverage report found on disk — produce a coverage report in a standard format (JaCoCo XML — the Gradle `jacocoTestReport` task) and commit it — a hosted scan measures a clone of the repository, so a report that exists only in a working tree, a CI runner's or your own, never reaches it; the artefact is commonly gitignored, so `git add -f` that one file (or un-ignore its path) and commit it alongside the code it measures, or wire coverage collection into CI, to enable this cross-layer check
  • PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `@Benchmark` in a Java, Kotlin or Scala file importing JMH or kotlinx-benchmark, Jetpack Benchmark's `measureRepeated` in a file importing androidx.benchmark, or JMH/kotlinx-benchmark/androidx.benchmark in a pom.xml, Gradle or sbt build, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
  • PF3 Async & latency hygiene — Not applicable: this repository declares no async functions, so there is no asynchronous code for a blocking call to stall.
  • S1 Web-Security Posture — Not assessed: these web-security controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks web-security controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • X2 Cancellation propagation — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X4 Structured logging — This check asks whether log calls keep a message's values apart from its text, which needs a logger that can carry them as fields. This repository's Java was read, and it logs through none that an assembled message defeats: java.util.logging's level methods, log4j 1, commons-logging, JBoss Logging and Flogger take one finished message (as log4net does in C#), or it makes no call through a named logger at all. Calls made through SLF4J or log4j 2 (`org.slf4j.Logger`, `org.apache.logging.log4j.Logger`, Lombok's `@Slf4j`) would be judged.
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 13 finding(s)
D28 · Secrets (history) · REDACTED · ×9
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
Serious — 446 finding(s)
D10 · Test Quality · No assertions · ×154
  • No assertions: testGetCastTimelinePersistsDuration exoplayer-amzn-2.10.6/extensions/cast/src/test/java/com/google/android/exoplayer2/ext/cast/CastTimelineTrackerTest.java:42 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testCallbackFromPreviousRequest exoplayer-amzn-2.10.6/extensions/cronet/src/test/java/com/google/android/exoplayer2/ext/cronet/CronetDataSourceTest.java:163 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: createRenderers_instantiatesVpxRenderer exoplayer-amzn-2.10.6/extensions/ffmpeg/src/test/java/com/google/android/exoplayer2/ext/ffmpeg/DefaultRenderersFactoryTest.java:29 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: createRenderers_instantiatesVpxRenderer exoplayer-amzn-2.10.6/extensions/flac/src/test/java/com/google/android/exoplayer2/ext/flac/DefaultRenderersFactoryTest.java:29 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testStartAfterRelease exoplayer-amzn-2.10.6/extensions/ima/src/test/java/com/google/android/exoplayer2/ext/ima/ImaAdsLoaderTest.java:151 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testStartAndCallbacksAfterRelease exoplayer-amzn-2.10.6/extensions/ima/src/test/java/com/google/android/exoplayer2/ext/ima/ImaAdsLoaderTest.java:158 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: createRenderers_instantiatesVpxRenderer exoplayer-amzn-2.10.6/extensions/opus/src/test/java/com/google/android/exoplayer2/ext/opus/DefaultRenderersFactoryTest.java:29 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: openRtmpDataSpec_instantiatesRtmpDataSourceViaReflection exoplayer-amzn-2.10.6/extensions/rtmp/src/test/java/com/google/android/exoplayer2/ext/rtmp/DefaultDataSourceTest.java:32 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: createRenderers_instantiatesVpxRenderer exoplayer-amzn-2.10.6/extensions/vp9/src/test/java/com/google/android/exoplayer2/ext/vp9/DefaultRenderersFactoryTest.java:29 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: handlesBufferAfterReset exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/audio/DefaultAudioSinkTest.java:78 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: handlesBufferAfterReset_withFormatChange exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/audio/DefaultAudioSinkTest.java:103 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: handlesSpecializedAudioProcessorArray exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/audio/DefaultAudioSinkTest.java:71 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testExtractingNarrowBandSamples exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/amr/AmrExtractorTest.java:181 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testExtractingNarrowBandSamples_withSeeking exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/amr/AmrExtractorTest.java:193 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testExtractingWideBandSamples exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/amr/AmrExtractorTest.java:187 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testExtractingWideBandSamples_withSeeking exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/amr/AmrExtractorTest.java:199 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testSample exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/flv/FlvExtractorTest.java:28 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testMkvSample exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/MatroskaExtractorTest.java:28 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testWebmSubsampleEncryption exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/MatroskaExtractorTest.java:33 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testWebmSubsampleEncryptionWithAltrefFrames exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mkv/MatroskaExtractorTest.java:39 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testMp3Sample exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mp3/Mp3ExtractorTest.java:28 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testTrimmedMp3Sample exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mp3/Mp3ExtractorTest.java:33 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testSample exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mp4/FragmentedMp4ExtractorTest.java:33 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testSampleSeekable exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mp4/FragmentedMp4ExtractorTest.java:39 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testSampleWithSeiPayloadParsing exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/extractor/mp4/FragmentedMp4ExtractorTest.java:45 — This method's body runs code, and no assertion was recognised in it. Recognised: JUnit's assertion methods (assertEquals, assertTrue, assertInstanceOf, assertThrows, assertThrowsExactly, assertTimeoutPreemptively, assertAll and the rest of JUnit 5's list), assertThat (AssertJ, Hamcrest, Truth), fail, Mockito's verify and the `assert` statement, in the test body and in helper methods of the test's own class or an in-repository base class, followed three calls deep. Verification through a helper on another object or in another class, through a custom matcher library, or through a harness that fails by throwing under some other name is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • + 129 more in this group — see findings.md.
D3 · God Classes · TooManyMethods · ×39
  • TooManyMethods: PlaybackFragment smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/PlaybackFragment.java:100 — TooManyMethods — 132 methods. The bar is 30 methods; this is 102 over it, 4.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PlayerTweaksData common/src/main/java/com/liskovsoft/smartyoutubetv2/common/prefs/PlayerTweaksData.java:13 — TooManyMethods — 129 methods. The bar is 30 methods; this is 99 over it, 4.30× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PlayerData common/src/main/java/com/liskovsoft/smartyoutubetv2/common/prefs/PlayerData.java:30 — TooManyMethods — 125 methods. The bar is 30 methods; this is 95 over it, 4.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Utils common/src/main/java/com/liskovsoft/smartyoutubetv2/common/utils/Utils.java:111 — TooManyMethods — 106 methods. The bar is 30 methods; this is 76 over it, 3.53× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: GeneralData common/src/main/java/com/liskovsoft/smartyoutubetv2/common/prefs/GeneralData.java:15 — TooManyMethods — 104 methods. The bar is 30 methods; this is 74 over it, 3.47× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: EmbedPlayerView smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/embedplayer/EmbedPlayerView.java:36 — TooManyMethods — 95 methods. The bar is 30 methods; this is 65 over it, 3.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: BrowsePresenter common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/BrowsePresenter.java:60 — TooManyMethods — 94 methods. The bar is 30 methods; this is 64 over it, 3.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: Video common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/Video.java:36 — TooManyMethods — 88 methods. The bar is 30 methods; this is 58 over it, 2.93× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PlayerUIController common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java:51 — TooManyMethods — 68 methods. The bar is 30 methods; this is 38 over it, 2.27× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: BasePlayerController common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/BasePlayerController.java:39 — TooManyMethods — 64 methods. The bar is 30 methods; this is 34 over it, 2.13× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: VideoStateController common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoStateController.java:23 — TooManyMethods — 61 methods. The bar is 30 methods; this is 31 over it, 2.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: AppDialogUtil common/src/main/java/com/liskovsoft/smartyoutubetv2/common/utils/AppDialogUtil.java:65 — TooManyMethods — 59 methods. The bar is 30 methods; this is 29 over it, 1.97× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: MainUIData common/src/main/java/com/liskovsoft/smartyoutubetv2/common/prefs/MainUIData.java:20 — TooManyMethods — 58 methods. The bar is 30 methods; this is 28 over it, 1.93× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: PlaybackPresenter common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/PlaybackPresenter.java:37 — TooManyMethods — 57 methods. The bar is 30 methods; this is 27 over it, 1.90× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ExoPlayerController common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/controller/ExoPlayerController.java:45 — TooManyMethods — 56 methods. The bar is 30 methods; this is 26 over it, 1.87× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: VideoMenuPresenter common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/VideoMenuPresenter.java:45 — TooManyMethods — 53 methods. The bar is 30 methods; this is 23 over it, 1.77× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: SuggestionsController common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/SuggestionsController.java:40 — TooManyMethods — 51 methods. The bar is 30 methods; this is 21 over it, 1.70× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: DebugInfoManager common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/other/DebugInfoManager.java:60 — TooManyMethods — 51 methods. The bar is 30 methods; this is 21 over it, 1.70× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ViewDragHelper slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:26 — TooManyMethods — 50 methods. The bar is 30 methods; this is 20 over it, 1.67× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: VideoGroup common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/VideoGroup.java:18 — TooManyMethods — 49 methods. The bar is 30 methods; this is 19 over it, 1.63× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: ViewManager common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/views/ViewManager.java:37 — TooManyMethods — 47 methods. The bar is 30 methods; this is 17 over it, 1.57× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: TrackSelectorManager common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorManager.java:38 — TooManyMethods — 43 methods. The bar is 30 methods; this is 13 over it, 1.43× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: SimpleMediaItem common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/SimpleMediaItem.java:7 — TooManyMethods — 42 methods. The bar is 30 methods; this is 12 over it, 1.40× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: AppDialogPresenter common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/AppDialogPresenter.java:19 — TooManyMethods — 41 methods. The bar is 30 methods; this is 11 over it, 1.37× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: BrowseFragment smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/BrowseFragment.java:48 — TooManyMethods — 40 methods. The bar is 30 methods; this is 10 over it, 1.33× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • + 14 more in this group — see findings.md.
D17 · Explicit Debt · TodoComment · ×22
  • TodoComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/VideoGroup.java:444 — // TODO: remove the hack someday. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoLoaderController.java:314 — // TODO: SABR live not implemented yet — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java:783 — // TODO: move out somehow — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:78 — // TODO: modified — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:88 — // TODO: modified — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:91 — // TODO: modified — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:94 — // TODO: modified — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:133 — // TODO: modified — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:136 — // TODO: modified — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:140 — // TODO: modified — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:143 — // TODO: modified — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:150 — // TODO: modified — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:157 — // TODO: modified — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:160 — // TODO: modified — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/GDriveBackupManager.java:242 — // TODO: don't hard code ids. show all existed. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:71 — // TODO: tv input service component name — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:184 — // TODO: update api — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:213 — // TODO: delete api — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:869 — // TODO: Add versioned support here for transformed views. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/presenter/IconHeaderItemPresenter.java:93 — // TODO: This is a temporary fix. Remove me when leanback onCreateViewHolder no longer sets the — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java:298 — // TODO: Do we need to restore position on second group? — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/AppDialogFragment.java:200 — // TODO — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D3 · God Classes · ClassTooLong · ×15
  • ClassTooLong: PlaybackFragment smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/PlaybackFragment.java:100 — ClassTooLong — 867 significant lines (blank, comment-only and punctuation-only lines excluded), 132 methods. The bar is 400 significant lines; this is 467 over it, 2.17× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: AppDialogUtil common/src/main/java/com/liskovsoft/smartyoutubetv2/common/utils/AppDialogUtil.java:65 — ClassTooLong — 745 significant lines (blank, comment-only and punctuation-only lines excluded), 59 methods. The bar is 400 significant lines; this is 345 over it, 1.86× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: BrowsePresenter common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/BrowsePresenter.java:60 — ClassTooLong — 717 significant lines (blank, comment-only and punctuation-only lines excluded), 94 methods. The bar is 400 significant lines; this is 317 over it, 1.79× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: PlayerUIController common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java:51 — ClassTooLong — 715 significant lines (blank, comment-only and punctuation-only lines excluded), 68 methods. The bar is 400 significant lines; this is 315 over it, 1.79× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: Utils common/src/main/java/com/liskovsoft/smartyoutubetv2/common/utils/Utils.java:111 — ClassTooLong — 713 significant lines (blank, comment-only and punctuation-only lines excluded), 106 methods. The bar is 400 significant lines; this is 313 over it, 1.78× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: VideoMenuPresenter common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/VideoMenuPresenter.java:45 — ClassTooLong — 641 significant lines (blank, comment-only and punctuation-only lines excluded), 53 methods. The bar is 400 significant lines; this is 241 over it, 1.60× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: ViewDragHelper slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:26 — ClassTooLong — 623 significant lines (blank, comment-only and punctuation-only lines excluded), 50 methods. The bar is 400 significant lines; this is 223 over it, 1.56× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: Video common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/Video.java:36 — ClassTooLong — 548 significant lines (blank, comment-only and punctuation-only lines excluded), 88 methods. The bar is 400 significant lines; this is 148 over it, 1.37× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: GeneralSettingsPresenter common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/GeneralSettingsPresenter.java:43 — ClassTooLong — 524 significant lines (blank, comment-only and punctuation-only lines excluded), 24 methods. The bar is 400 significant lines; this is 124 over it, 1.31× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: PlayerTweaksData common/src/main/java/com/liskovsoft/smartyoutubetv2/common/prefs/PlayerTweaksData.java:13 — ClassTooLong — 510 significant lines (blank, comment-only and punctuation-only lines excluded), 129 methods. The bar is 400 significant lines; this is 110 over it, 1.28× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: SuggestionsController common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/SuggestionsController.java:40 — ClassTooLong — 471 significant lines (blank, comment-only and punctuation-only lines excluded), 51 methods. The bar is 400 significant lines; this is 71 over it, 1.18× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: SliderPanel slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:19 — ClassTooLong — 449 significant lines (blank, comment-only and punctuation-only lines excluded), 15 methods. The bar is 400 significant lines; this is 49 over it, 1.12× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: PlayerSettingsPresenter common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/PlayerSettingsPresenter.java:28 — ClassTooLong — 436 significant lines (blank, comment-only and punctuation-only lines excluded), 25 methods. The bar is 400 significant lines; this is 36 over it, 1.09× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: GeneralData common/src/main/java/com/liskovsoft/smartyoutubetv2/common/prefs/GeneralData.java:15 — ClassTooLong — 416 significant lines (blank, comment-only and punctuation-only lines excluded), 104 methods. The bar is 400 significant lines; this is 16 over it, 1.04× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: TrackSelectorManager common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorManager.java:38 — ClassTooLong — 411 significant lines (blank, comment-only and punctuation-only lines excluded), 43 methods. The bar is 400 significant lines; this is 11 over it, 1.03× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D3 · God Classes · FileTooLong · ×12
  • FileTooLong: playback/PlaybackFragment.java smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/PlaybackFragment.java — FileTooLong — 957 significant lines (blank, comment-only and punctuation-only lines excluded), about 91% of them inside a single declaration: PlaybackFragment (100-1658). The bar is 500 significant lines; this is 457 over it, 1.91× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: utils/Utils.java common/src/main/java/com/liskovsoft/smartyoutubetv2/common/utils/Utils.java — FileTooLong — 817 significant lines (blank, comment-only and punctuation-only lines excluded), about 87% of them inside a single declaration: Utils (111-1362). The bar is 500 significant lines; this is 317 over it, 1.63× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: utils/AppDialogUtil.java common/src/main/java/com/liskovsoft/smartyoutubetv2/common/utils/AppDialogUtil.java — FileTooLong — 803 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: AppDialogUtil (65-1226). The bar is 500 significant lines; this is 303 over it, 1.61× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: presenters/BrowsePresenter.java common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/BrowsePresenter.java — FileTooLong — 770 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: BrowsePresenter (60-1235). The bar is 500 significant lines; this is 270 over it, 1.54× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: controllers/PlayerUIController.java common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java — FileTooLong — 761 significant lines (blank, comment-only and punctuation-only lines excluded), about 94% of them inside a single declaration: PlayerUIController (51-1182). The bar is 500 significant lines; this is 261 over it, 1.52× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: menu/VideoMenuPresenter.java common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/VideoMenuPresenter.java — FileTooLong — 682 significant lines (blank, comment-only and punctuation-only lines excluded), about 94% of them inside a single declaration: VideoMenuPresenter (45-1080). The bar is 500 significant lines; this is 182 over it, 1.36× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: util/ViewDragHelper.java slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java — FileTooLong — 637 significant lines (blank, comment-only and punctuation-only lines excluded), about 98% of them inside a single declaration: ViewDragHelper (26-1403). The bar is 500 significant lines; this is 137 over it, 1.27× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: prefs/PlayerData.java common/src/main/java/com/liskovsoft/smartyoutubetv2/common/prefs/PlayerData.java — FileTooLong — 576 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 76 over it, 1.15× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: data/Video.java common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/Video.java — FileTooLong — 575 significant lines (blank, comment-only and punctuation-only lines excluded), about 95% of them inside a single declaration: Video (36-981). The bar is 500 significant lines; this is 75 over it, 1.15× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: settings/GeneralSettingsPresenter.java common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/GeneralSettingsPresenter.java — FileTooLong — 562 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: GeneralSettingsPresenter (43-813). The bar is 500 significant lines; this is 62 over it, 1.12× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: prefs/PlayerTweaksData.java common/src/main/java/com/liskovsoft/smartyoutubetv2/common/prefs/PlayerTweaksData.java — FileTooLong — 519 significant lines (blank, comment-only and punctuation-only lines excluded), about 98% of them inside a single declaration: PlayerTweaksData (13-811). The bar is 500 significant lines; this is 19 over it, 1.04× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: controllers/SuggestionsController.java common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/SuggestionsController.java — FileTooLong — 505 significant lines (blank, comment-only and punctuation-only lines excluded), about 93% of them inside a single declaration: SuggestionsController (40-883). The bar is 500 significant lines; this is 5 over it, 1.01× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×12
  • Duplicated block (8 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/SectionMenuPresenter.java:108 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/SectionMenuPresenter.java:108-115 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/VideoMenuPresenter.java:186-193 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/SectionMenuPresenter.java:108` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/SectionMenuPresenter.java:135 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/SectionMenuPresenter.java:135-142 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/VideoMenuPresenter.java:207-214 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/SectionMenuPresenter.java:135` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/DeArrowSettingsPresenter.java:64 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/DeArrowSettingsPresenter.java:64-71 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/MainUISettingsPresenter.java:290-297 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (8 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:139 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:139-146 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:156-163 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:139` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/ChatPreferenceDialogFragment.java:51 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/ChatPreferenceDialogFragment.java:51-58 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/CommentsPreferenceDialogFragment.java:75-82 — before extracting anything, compare `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/ChatPreferenceDialogFragment.java` and `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/CommentsPreferenceDialogFragment.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (8 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/ChatPreferenceDialogFragment.java:39 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/ChatPreferenceDialogFragment.java:39-46 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/CommentsPreferenceDialogFragment.java:63-70 — before extracting anything, compare `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/ChatPreferenceDialogFragment.java` and `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/CommentsPreferenceDialogFragment.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (8 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/BasePlayerController.java:365 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/BasePlayerController.java:365-372 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/base/BasePresenter.java:321-328 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/LanguageSettingsPresenter.java:39 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/LanguageSettingsPresenter.java:39-46 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/UIScaleSettingsPresenter.java:35-42 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (8 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/DeArrowProcessor.java:29 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/DeArrowProcessor.java:29-36 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/UnlocalizedTitleProcessor.java:31-38 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (8 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/actions/ChannelAction.java:13 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/actions/ChannelAction.java:13-20 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/actions/SearchAction.java:10-17 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (8 lines × 2) doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerAdapter.kt:138 — doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerAdapter.kt:138-145 | doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerViewImpl.kt:167-174 — before extracting anything, compare `doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerAdapter.kt` and `doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerViewImpl.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 38 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerAdapter.kt:147 — doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerAdapter.kt:147-154 | doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerViewImpl.kt:176-183 — before extracting anything, compare `doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerAdapter.kt` and `doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerViewImpl.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 38 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×8
  • Duplicated block (11 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/GoogleSignInPresenter.java:64 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/GoogleSignInPresenter.java:64-74 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/YTSignInPresenter.java:70-80 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/GoogleSignInPresenter.java:64` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/actions/ActionHelpers.java:46 — leanback-1.0.0/src/main/java/androidx/leanback/widget/PlaybackControlsRow.java:757-767 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/actions/ActionHelpers.java:46-56 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: `R` names `androidx.leanback.R` in one and `com.liskovsoft.smartyoutubetv2.tv.R` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (11 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java:65 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java:65-75 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/VideoGridFragment.java:58-68 — before extracting anything, compare `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java` and `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/VideoGridFragment.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java:65` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:185 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:185-195 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/search/tags/SearchTagsFragment.java:416-426 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:185` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:250 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:250-260 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/PlaybackFragment.java:1400-1410 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:250` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:246` calls `isEmpty` and `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/PlaybackFragment.java:1397` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/AccountSelectionPresenter.java:146 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/AccountSelectionPresenter.java:146-156 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AccountSettingsPresenter.java:175-185 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/PlaybackFragment.java:999 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/PlaybackFragment.java:999-1009 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/embedplayer/EmbedPlayerView.java:309-319 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (11 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/ChatPreferenceDialogFragment.java:26 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/ChatPreferenceDialogFragment.java:26-36 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/CommentsPreferenceDialogFragment.java:50-60 — before extracting anything, compare `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/ChatPreferenceDialogFragment.java` and `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/CommentsPreferenceDialogFragment.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×8
  • Duplicated block (6 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java:431 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java:431-436 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java:458-463 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java:431` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:162 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:162-170 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:276-281 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:162` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/utils/AppDialogUtil.java:470 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/utils/AppDialogUtil.java:470-475 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/utils/AppDialogUtil.java:552-557 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/utils/AppDialogUtil.java:470` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/actions/ActionHelpers.java:38 — leanback-1.0.0/src/main/java/androidx/leanback/widget/PlaybackControlsRow.java:740-745 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/actions/ActionHelpers.java:38-43 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `leanback-1.0.0/src/main/java/androidx/leanback/widget/PlaybackControlsRow.java:740` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (6 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/ChatPreferenceDialogFragment.java:61 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/ChatPreferenceDialogFragment.java:61-66 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/CommentsPreferenceDialogFragment.java:89-94 — before extracting anything, compare `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/ChatPreferenceDialogFragment.java` and `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/CommentsPreferenceDialogFragment.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (6 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/MotherActivity.java:253 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/MotherActivity.java:253-258 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/BrowseActivity.java:25-30 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (6 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:105 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:105-110 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/PlaybackFragment.java:734-739 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (6 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/vineyard/videoview/VideoCardView.java:147 — leanback-1.0.0/src/main/java/androidx/leanback/widget/ImageCardView.java:353-358 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/vineyard/videoview/VideoCardView.java:147-152 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×7
  • Duplicated block (7 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AboutSettingsPresenter.java:135 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AboutSettingsPresenter.java:135-141 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AboutSettingsPresenter.java:174-180 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AboutSettingsPresenter.java:135` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AboutSettingsPresenter.java:87 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AboutSettingsPresenter.java:87-93 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AboutSimpleSettingsPresenter.java:51-57 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (7 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/errors/DashDefaultLoadErrorHandlingPolicy.java:32 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/errors/DashDefaultLoadErrorHandlingPolicy.java:32-38 | exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/upstream/DefaultLoadErrorHandlingPolicy.java:87-93 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/upstream/DefaultLoadErrorHandlingPolicy.java:87` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/presenter/ChannelCardPresenter.java:136 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/presenter/ChannelCardPresenter.java:136-142 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/presenter/SearchFieldPresenter.java:102-108 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/service/VideoStateService.java:46 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/service/VideoStateService.java:46-52 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/service/SidebarService.java:39-45 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/track/MediaTrack.java:59 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/track/MediaTrack.java:59-65 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/track/VideoTrack.java:64-70 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (7 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/adddevice/AddDeviceActivity.java:9 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/adddevice/AddDeviceActivity.java:9-15 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/signin/SignInActivity.java:9-15 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×7
  • Duplicated block (5 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/SectionMenuPresenter.java:303 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/SectionMenuPresenter.java:303-307 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/VideoMenuPresenter.java:1075-1079 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/SectionMenuPresenter.java:303` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AccountSettingsPresenter.java:168 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AccountSettingsPresenter.java:168-172 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/GeneralSettingsPresenter.java:562-566 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AccountSettingsPresenter.java:168` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/DeArrowSettingsPresenter.java:47 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/DeArrowSettingsPresenter.java:47-51 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/MainUISettingsPresenter.java:178-182 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/DeArrowSettingsPresenter.java:47` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/DeArrowSettingsPresenter.java:54 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/DeArrowSettingsPresenter.java:54-58 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/MainUISettingsPresenter.java:185-189 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (5 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:152 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:152-156 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:270-274 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:152` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/StringListPreferenceDialogFragment.java:66 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/StringListPreferenceDialogFragment.java:66-70 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/mod/leanback/preference/LeanbackListPreferenceDialogFragment.java:304-308 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (5 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/GDriveBackupManager.java:190 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/GDriveBackupManager.java:190-194 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/GDriveBackupManager.java:223-227 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/GDriveBackupManager.java:190` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×6
  • Duplicated block (10 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AboutSettingsPresenter.java:194 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AboutSettingsPresenter.java:194-203 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AboutSimpleSettingsPresenter.java:68-77 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (10 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/MainUISettingsPresenter.java:229 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/MainUISettingsPresenter.java:229-238 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/UIScaleSettingsPresenter.java:60-69 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/MainUISettingsPresenter.java:229` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/SuggestionsController.java:103 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/SuggestionsController.java:103-112 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/BrowsePresenter.java:482-491 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (10 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/errors/DashDefaultLoadErrorHandlingPolicy.java:17 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/errors/DashDefaultLoadErrorHandlingPolicy.java:17-26 | exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/upstream/DefaultLoadErrorHandlingPolicy.java:69-78 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/upstream/DefaultLoadErrorHandlingPolicy.java:69` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:76 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:76-85 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/VideoGridFragment.java:80-89 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (10 lines × 2) doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerAdapter.kt:167 — doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerAdapter.kt:167-176 | doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerViewImpl.kt:195-204 — before extracting anything, compare `doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerAdapter.kt` and `doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerViewImpl.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 38 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerAdapter.kt:163` calls `onSingleTap` and `doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerViewImpl.kt:191` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×6
  • Swallowed exception (caught, then discarded) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/MediaStoreFile.kt:387 — `catch (e: Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/audio/AudioTrackPositionTracker.java:682 — `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/metadata/emsg/EventMessageDecoder.java:55 — `catch (RuntimeException)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/util/Util.java:1460 — `catch (RuntimeException)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/util/AmazonQuirks.java:144 — `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:67 — `catch (Exception)` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×5
  • Duplicated block (12 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java:205 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java:205-216 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java:222-233 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java:205` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/LanguageSettingsPresenter.java:51 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/LanguageSettingsPresenter.java:51-62 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/LanguageSettingsPresenter.java:77-88 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/LanguageSettingsPresenter.java:51` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/BackupAndRestoreManager.java:237 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/BackupAndRestoreManager.java:237-248 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/GDriveBackupManager.java:264-275 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (12 lines × 2) slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:164 — slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:164-175 | slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:591-602 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:164` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (12 lines × 2) doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerAdapter.kt:178 — doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerAdapter.kt:178-189 | doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerViewImpl.kt:206-217 — before extracting anything, compare `doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerAdapter.kt` and `doubletapplayerview/src/main/java/com/github/vkay94/dtpv/DoubleTapPlayerViewImpl.kt` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 38 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
X15 · Unvalidated length from an untrusted reader · Length read from the parsed input is spent without ever being bounded · ×5
  • Length read from the parsed input is spent without ever being bounded exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/extractor/mp4/AtomParsers.java:537 — `entryCount` is read from the bytes being parsed at line 536 (`readInt`), then used to size a `new String[]` at line 537 — and nowhere in its scope is `entryCount` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `entryCount` against the bytes actually remaining and a maximum the format allows before allocating.
  • Length read from the parsed input is spent without ever being bounded exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/extractor/mp4/AtomParsers.java:992 — `entryCount` is read from the bytes being parsed at line 991 (`readUnsignedIntToInt`), then used to size a `new long[]` at line 992 — and nowhere in its scope is `entryCount` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `entryCount` against the bytes actually remaining and a maximum the format allows before allocating.
  • Length read from the parsed input is spent without ever being bounded exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/metadata/id3/ChapterTocFrame.java:56 — `subFrameCount` is read from the bytes being parsed at line 55 (`readInt`), then used to size a `new Id3Frame[]` at line 56 — and nowhere in its scope is `subFrameCount` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `subFrameCount` against the bytes actually remaining and a maximum the format allows before allocating.
  • Length read from the parsed input is spent without ever being bounded exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/metadata/id3/ChapterFrame.java:65 — `subFrameCount` is read from the bytes being parsed at line 64 (`readInt`), then used to size a `new Id3Frame[]` at line 65 — and nowhere in its scope is `subFrameCount` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `subFrameCount` against the bytes actually remaining and a maximum the format allows before allocating.
  • Length read from the parsed input is spent without ever being bounded exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/offline/ActionFile.java:104 — `dataLength` is read from the bytes being parsed at line 101 (`readInt`), then used to size a `new byte[]` at line 104 — and nowhere in its scope is `dataLength` bounded from above — compared to a limit, clamped, or checked against the input that remains (a zero or sign test, or the loop that counts up to it, bounds nothing). Whoever wrote those bytes therefore chooses the allocation directly: a 32-bit length asks for up to 2 GiB before a single byte of the payload is known to exist, which either exhausts the heap with an `OutOfMemoryError` or, negative, throws `NegativeArraySizeException` out of a parser whose failure path was written for malformed input, not for hostile input. Bound `dataLength` against the bytes actually remaining and a maximum the format allows before allocating.
D10 · Test Quality · Test project verifies nothing · ×4
  • Test project verifies nothing: ffmpeg exoplayer-amzn-2.10.6/extensions/ffmpeg/src/test/java/com/google/android/exoplayer2/ext/ffmpeg/DefaultRenderersFactoryTest.java:29 — No conventional assertion call was detected in 1 of 1 tests in `ffmpeg` — the project as a whole, not one method. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a suite that genuinely checks nothing. If it is the latter, this project passes unconditionally and cannot fail.
  • Test project verifies nothing: opus exoplayer-amzn-2.10.6/extensions/opus/src/test/java/com/google/android/exoplayer2/ext/opus/DefaultRenderersFactoryTest.java:29 — No conventional assertion call was detected in 1 of 1 tests in `opus` — the project as a whole, not one method. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a suite that genuinely checks nothing. If it is the latter, this project passes unconditionally and cannot fail.
  • Test project verifies nothing: rtmp exoplayer-amzn-2.10.6/extensions/rtmp/src/test/java/com/google/android/exoplayer2/ext/rtmp/DefaultDataSourceTest.java:32 — No conventional assertion call was detected in 1 of 1 tests in `rtmp` — the project as a whole, not one method. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a suite that genuinely checks nothing. If it is the latter, this project passes unconditionally and cannot fail.
  • Test project verifies nothing: vp9 exoplayer-amzn-2.10.6/extensions/vp9/src/test/java/com/google/android/exoplayer2/ext/vp9/DefaultRenderersFactoryTest.java:29 — No conventional assertion call was detected in 1 of 1 tests in `vp9` — the project as a whole, not one method. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a suite that genuinely checks nothing. If it is the latter, this project passes unconditionally and cannot fail.
D15 · Churn × Complexity Hotspots · Repeated repair · ×4
  • Repeated repair: common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/MotherActivity.java common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/MotherActivity.java:133 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/MotherActivity.java changed 10 times in last 90 days and 8 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 6 (its worst body is MotherActivity.dispatchKeyEvent at line 133), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “screensaver suspend fix: improve blocked mode handling”; “Revert screensaver suspend fix (temporary, conflicts with constant dimming feature)”; “screensaver suspend fix: reeset back state on back dialog gesture”; “fix not interested menu item disappered afer watching a video; another fix when the screensaver manager blocks device from sleep”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 05:56:12 +03:00' --until='2026-10-24 05:56:12 +03:00' --full-history --no-merges -- common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/MotherActivity.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/ScreensaverManager.java common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/ScreensaverManager.java:232 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/ScreensaverManager.java changed 6 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 11 (its worst body is ScreensaverManager.showHideDimming at line 232), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “screensaver suspend fix: improve blocked mode handling”; “screensaver suspend fix: upd prevent flicker”; “screensaver suspend fix: prevent flicker from hideDimOverlay() when constant dimming is on”; “fix: release screensaver suppression when SmartTube pauses”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 05:56:12 +03:00' --until='2026-10-24 05:56:12 +03:00' --full-history --no-merges -- common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/ScreensaverManager.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoStateController.java common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoStateController.java:324 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoStateController.java changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 12 (its worst body is VideoStateController.onSpeedClicked at line 324), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix: disable fullscreen for Android Auto and update SharedModules”; “VolumeBooster: increase drift fix interval to 5 minutes”; “Player: Live Stream Latency Mitigator: fix numeric button seek”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 05:56:12 +03:00' --until='2026-10-24 05:56:12 +03:00' --full-history --no-merges -- common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoStateController.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/manifest/SabrManifestParser.java exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/manifest/SabrManifestParser.java:576 — exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/manifest/SabrManifestParser.java changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 13 (its worst body is SabrManifestParser.getSampleMimeType at line 576), UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “Fix SABR subtitle loading for external caption files”; “player: error fixer: fix hanged clients”; “Fix SABR playback and CDN routing @Jupiops”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 05:56:12 +03:00' --until='2026-10-24 05:56:12 +03:00' --full-history --no-merges -- exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/manifest/SabrManifestParser.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×4
  • Duplicated block (15 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java:168 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java:168-182 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java:203-217 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java:184` calls `instance`, `reloadPlayerResponse` and `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java:220` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (15 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/ChannelPresenter.java:244 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/ChannelPresenter.java:244-258 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/ChannelUploadsPresenter.java:198-212 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
  • Duplicated block (15 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/ChannelPresenter.java:261 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/ChannelPresenter.java:261-275 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/ChannelUploadsPresenter.java:219-233 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/ChannelPresenter.java:261` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/proxy/PasswdURI.java:29 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/proxy/PasswdURI.java:29-43 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/proxy/PasswdURI.java:46-60 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×4
  • Duplicated block (9 lines × 2) slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:943 — slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:943-951 | slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:1073-1081 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:943` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/layout/TouchHorizontalGridView.java:37 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/layout/TouchHorizontalGridView.java:37-45 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/layout/TouchVerticalGridView.java:39-47 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/layout/TouchHorizontalGridView.java:37` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/mod/surface/SurfaceViewWrapper.java:51 — leanback-1.0.0/src/main/java/androidx/leanback/app/VideoSupportFragment.java:77-85 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/mod/surface/SurfaceViewWrapper.java:51-59 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (9 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:355 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:355-363 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/VideoGridFragment.java:280-288 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:355` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
X3 · Exception handling · Swallowed exception (empty catch) · ×4
  • Swallowed exception (empty catch) chatkit/src/main/java/com/stfalcon/chatkit/messages/MessageInput.java:264 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CachedContentIndex.java:325 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/util/EGLSurfaceTexture.java:192 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
  • Swallowed exception (empty catch) filepicker-lib/src/main/java/arte/programar/materialfile/ui/FilePickerActivity.java:130 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
D15 · Churn × Complexity Hotspots · Hotspot · ×3
  • Hotspot: common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java:225 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java changed 37 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 34 in ErrorFixerController.applyEngineErrorAction at line 225. 13 of those changes were fix/bug commits, and the other 24 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 05:56:12 +03:00' --until='2026-10-24 05:56:12 +03:00' --full-history --no-merges -- common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/DefaultSabrChunkSource.java exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/DefaultSabrChunkSource.java:278 — exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/DefaultSabrChunkSource.java changed 11 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in DefaultSabrChunkSource.getNextChunk at line 278. 6 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 05:56:12 +03:00' --until='2026-10-24 05:56:12 +03:00' --full-history --no-merges -- exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/DefaultSabrChunkSource.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/parser/SabrProcessor.java exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/parser/SabrProcessor.java:157 — exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/parser/SabrProcessor.java changed 3 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 29 in SabrProcessor.processMediaHeader at line 157. 2 of those changes were fix/bug commits, so the churn is repair rather than feature work. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-07-26..2026-10-24, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-07-26 05:56:12 +03:00' --until='2026-10-24 05:56:12 +03:00' --full-history --no-merges -- exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/parser/SabrProcessor.java`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×3
  • Duplicated block (16 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/ChannelPresenter.java:114 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/ChannelPresenter.java:114-129 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/SearchPresenter.java:247-262 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (16 lines × 2) slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:892 — slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:892-907 | slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:1010-1025 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:892` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (16 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/versions/selector/backport/Definition.java:26 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/versions/selector/backport/Definition.java:26-41 | exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/trackselection/TrackSelection.java:56-257 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/trackselection/TrackSelection.java:56` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×3
  • Duplicated block (13 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/ZipHelper.java:62 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/ZipHelper.java:62-74 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/ZipHelper2.java:46-58 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/ZipHelper.java:62` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:914 — slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:914-926 | slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:1032-1044 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:914` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:1046` calls `findTopChildUnder`, `tryCaptureViewForDrag` and `slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:927` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (13 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/DeArrowProcessor.java:76 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/DeArrowProcessor.java:76-88 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/UnlocalizedTitleProcessor.java:79-91 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×3
  • Duplicated block (6 lines × 3) slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:162 — slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:162-167 | slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:251-256 | slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:589-594 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (6 lines × 3) slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:333 — slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:333-338 | slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:413-418 | slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:493-498 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
  • Duplicated block (6 lines × 3) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java:375 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java:375-380 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java:385-390 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/VideoGridFragment.java:219-224 — before extracting anything, compare `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java` and `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/VideoGridFragment.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
D6 · Cohesion (LCOM4) · Low cohesion · ×3
  • Low cohesion: VideoPlayerGlue (LCOM4 8) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/other/VideoPlayerGlue.java:79 — VideoPlayerGlue's methods fall into 8 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 8 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: MediaServiceManager (LCOM4 5) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/MediaServiceManager.java:43 — MediaServiceManager's methods fall into 5 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 5 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: SearchTagsFragmentBase (LCOM4 4) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/search/tags/vineyard/SearchTagsFragmentBase.java:44 — SearchTagsFragmentBase's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
D3 · God Classes · MethodTooLong · ×2
  • MethodTooLong: RemoteController.processCommand common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/RemoteController.java:272 — MethodTooLong — processCommand runs 182 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 82 over it, 1.82× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PlayerSettingsPresenter.appendDeveloperCategory common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/PlayerSettingsPresenter.java:493 — MethodTooLong — appendDeveloperCategory runs 122 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 22 over it, 1.22× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D4 · Code Duplication · Duplicated block (21 lines × 2) · ×2
  • Duplicated block (21 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/mod/EventsOverridePlaybackFragment.java:82 — leanback-1.0.0/src/main/java/androidx/leanback/app/PlaybackSupportFragment.java:459-479 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/mod/EventsOverridePlaybackFragment.java:82-102 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `leanback-1.0.0/src/main/java/androidx/leanback/app/PlaybackSupportFragment.java:459` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (21 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/marqueetextview/HeaderMarqueeTextView.java:11 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/marqueetextview/HeaderMarqueeTextView.java:11-31 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/marqueetextviewcompat/HeaderMarqueeTextViewCompat.java:12-32 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (20 lines × 3) · ×2
  • Duplicated block (20 lines × 3) slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:205 — slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:205-224 | slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:289-308 | slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:637-656 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (20 lines × 3) slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:369 — slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:369-388 | slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:449-468 | slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:544-563 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×2
  • Duplicated block (14 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/VideoGroup.java:111 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/VideoGroup.java:111-124 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/VideoGroup.java:132-145 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (14 lines × 2) leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:486 — leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:486-499 | leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:526-539 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:486` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (13 lines × 3) · ×2
  • Duplicated block (13 lines × 3) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/BrowsePresenter.java:866 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/BrowsePresenter.java:866-878 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/SearchPresenter.java:192-204 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/SearchPresenter.java:230-242 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/BrowsePresenter.java:866` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 3) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/ChannelUploadsPresenter.java:302 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/ChannelUploadsPresenter.java:302-314 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/MediaServiceManager.java:156-168 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/MediaServiceManager.java:226-238 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/ChannelUploadsPresenter.java:302` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D1 · Cyclomatic Complexity · RemoteController.processCommand (cyclomatic 62) · ×1
  • RemoteController.processCommand (cyclomatic 62) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/RemoteController.java:272 — RemoteController.processCommand has cyclomatic complexity 62 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ErrorFixerController.applyEngineErrorAction (cyclomatic 34) · ×1
  • ErrorFixerController.applyEngineErrorAction (cyclomatic 34) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java:225 — ErrorFixerController.applyEngineErrorAction has cyclomatic complexity 34 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · TrackSelectorManager.filterByLanguage (cyclomatic 33) · ×1
  • TrackSelectorManager.filterByLanguage (cyclomatic 33) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorManager.java:597 — TrackSelectorManager.filterByLanguage has cyclomatic complexity 33 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ViewDragHelper.shouldInterceptTouchEvent (cyclomatic 31) · ×1
  • ViewDragHelper.shouldInterceptTouchEvent (cyclomatic 31) slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:891 — ViewDragHelper.shouldInterceptTouchEvent has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ViewDragHelper.processTouchEvent (cyclomatic 29) · ×1
  • ViewDragHelper.processTouchEvent (cyclomatic 29) slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:1009 — ViewDragHelper.processTouchEvent has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · User.equals (cyclomatic 28) · ×1
  • User.equals (cyclomatic 28) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/search/vineyard/User.java:85 — User.equals has cyclomatic complexity 28 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · TrackSelectorManager.findBestMatch (cyclomatic 27) · ×1
  • TrackSelectorManager.findBestMatch (cyclomatic 27) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorManager.java:466 — TrackSelectorManager.findBestMatch has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · VideoLoaderController.applyPlaybackMode (cyclomatic 26) · ×1
  • VideoLoaderController.applyPlaybackMode (cyclomatic 26) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoLoaderController.java:403 — VideoLoaderController.applyPlaybackMode has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PlayerUIController.onButtonClicked (cyclomatic 22) · ×1
  • PlayerUIController.onButtonClicked (cyclomatic 22) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java:576 — PlayerUIController.onButtonClicked has cyclomatic complexity 22 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · EventsOverridePlaybackFragment.onInterceptInputEvent (cyclomatic 21) · ×1
  • EventsOverridePlaybackFragment.onInterceptInputEvent (cyclomatic 21) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/mod/EventsOverridePlaybackFragment.java:34 — EventsOverridePlaybackFragment.onInterceptInputEvent has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GeneralSettingsPresenter.appendKeyRemappingCategory (cyclomatic 19) · ×1
  • GeneralSettingsPresenter.appendKeyRemappingCategory (cyclomatic 19) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/GeneralSettingsPresenter.java:324 — GeneralSettingsPresenter.appendKeyRemappingCategory has cyclomatic complexity 19 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · ProxyManager.setWebProxyAPI19Plus (cyclomatic 19) · ×1
  • ProxyManager.setWebProxyAPI19Plus (cyclomatic 19) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/proxy/ProxyManager.java:215 — ProxyManager.setWebProxyAPI19Plus has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SuggestionsController.appendSuggestions (cyclomatic 18) · ×1
  • SuggestionsController.appendSuggestions (cyclomatic 18) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/SuggestionsController.java:363 — SuggestionsController.appendSuggestions has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · SplashPresenter.initIntentChain (cyclomatic 18) · ×1
  • SplashPresenter.initIntentChain (cyclomatic 18) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/SplashPresenter.java:193 — SplashPresenter.initIntentChain has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · VideoPlayerGlue.onCreatePrimaryActions (cyclomatic 17) · ×1
  • VideoPlayerGlue.onCreatePrimaryActions (cyclomatic 17) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/other/VideoPlayerGlue.java:140 — VideoPlayerGlue.onCreatePrimaryActions has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · Video.fromString (cyclomatic 17) · ×1
  • Video.fromString (cyclomatic 17) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/Video.java:382 — Video.fromString has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · VideoLoaderController.processFormatInfo (cyclomatic 17) · ×1
  • VideoLoaderController.processFormatInfo (cyclomatic 17) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoLoaderController.java:268 — VideoLoaderController.processFormatInfo has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SharedPreferencesHelper.restoreFromXml (cyclomatic 17) · ×1
  • SharedPreferencesHelper.restoreFromXml (cyclomatic 17) REDACTED:99 — SharedPreferencesHelper.restoreFromXml has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MultipleRowsFragment.update (cyclomatic 16) · ×1
  • MultipleRowsFragment.update (cyclomatic 16) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:207 — MultipleRowsFragment.update has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · PlayerKeyTranslator.initActionMapping (cyclomatic 16) · ×1
  • PlayerKeyTranslator.initActionMapping (cyclomatic 16) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/PlayerKeyTranslator.java:99 — PlayerKeyTranslator.initActionMapping has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D17 · Explicit Debt · FixmeComment · ×1
  • FixmeComment common/src/main/java/com/liskovsoft/smartyoutubetv2/common/proxy/WebProxyDialog.java:58 — // FIXME: If user hit cancel in dialog, proxy remains enabled. — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D2 · Cognitive Complexity · RemoteController.processCommand (cognitive 87) · ×1
  • RemoteController.processCommand (cognitive 87) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/RemoteController.java:272 — RemoteController.processCommand has cognitive complexity 87 (threshold 15). Drivers by points: if/else 33 (64 pts), ternaries 3 (9 pts), boolean chains 6, loops 1 (4 pts), match/switch 3 (4 pts) (nesting depth added 41). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · TrackSelectorManager.filterByLanguage (cognitive 69) · ×1
  • TrackSelectorManager.filterByLanguage (cognitive 69) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorManager.java:597 — TrackSelectorManager.filterByLanguage has cognitive complexity 69 (threshold 15). Drivers by points: if/else 20 (54 pts), boolean chains 9, loops 2 (4 pts), ternaries 1 (2 pts) (nesting depth added 37). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TrackSelectorManager.findBestMatch (cognitive 66) · ×1
  • TrackSelectorManager.findBestMatch (cognitive 66) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorManager.java:466 — TrackSelectorManager.findBestMatch has cognitive complexity 66 (threshold 15). Drivers by points: if/else 17 (54 pts), boolean chains 7, loops 2 (5 pts) (nesting depth added 40). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ViewDragHelper.processTouchEvent (cognitive 55) · ×1
  • ViewDragHelper.processTouchEvent (cognitive 55) slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:1009 — ViewDragHelper.processTouchEvent has cognitive complexity 55 (threshold 15). Drivers by points: if/else 18 (45 pts), loops 2 (6 pts), boolean chains 3, match/switch 1 (nesting depth added 31). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AppPreferenceManager.initMultiSelectListPreference (cognitive 52) · ×1
  • AppPreferenceManager.initMultiSelectListPreference (cognitive 52) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/AppPreferenceManager.java:189 — AppPreferenceManager.initMultiSelectListPreference has cognitive complexity 52 (threshold 15). Drivers by points: if/else 8 (35 pts), loops 4 (17 pts) (nesting depth added 40). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · ViewDragHelper.shouldInterceptTouchEvent (cognitive 45) · ×1
  • ViewDragHelper.shouldInterceptTouchEvent (cognitive 45) slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:891 — ViewDragHelper.shouldInterceptTouchEvent has cognitive complexity 45 (threshold 15). Drivers by points: if/else 14 (33 pts), boolean chains 9, loops 1 (2 pts), match/switch 1 (nesting depth added 20). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ErrorFixerController.applyEngineErrorAction (cognitive 45) · ×1
  • ErrorFixerController.applyEngineErrorAction (cognitive 45) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java:225 — ErrorFixerController.applyEngineErrorAction has cognitive complexity 45 (threshold 15). Drivers by points: if/else 26 (33 pts), boolean chains 11, ternaries 1 (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · User.equals (cognitive 34) · ×1
  • User.equals (cognitive 34) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/search/vineyard/User.java:85 — User.equals has cognitive complexity 34 (threshold 15). Drivers by points: if/else 18, ternaries 8 (15 pts), boolean chains 1 (nesting depth added 7). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · VideoLoaderController.applyPlaybackMode (cognitive 32) · ×1
  • VideoLoaderController.applyPlaybackMode (cognitive 32) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoLoaderController.java:403 — VideoLoaderController.applyPlaybackMode has cognitive complexity 32 (threshold 15). Drivers by points: if/else 14 (23 pts), boolean chains 8, match/switch 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SuggestionsController.appendSuggestions (cognitive 29) · ×1
  • SuggestionsController.appendSuggestions (cognitive 29) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/SuggestionsController.java:363 — SuggestionsController.appendSuggestions has cognitive complexity 29 (threshold 15). Drivers by points: if/else 11 (21 pts), boolean chains 5, ternaries 1 (2 pts), loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ChannelsProvider.addWatchNextContinue (cognitive 27) · ×1
  • ChannelsProvider.addWatchNextContinue (cognitive 27) leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:92 — ChannelsProvider.addWatchNextContinue has cognitive complexity 27 (threshold 15). Drivers by points: if/else 9 (23 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 15). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · DisplaySyncHelper.syncDisplayMode (cognitive 24) · ×1
  • DisplaySyncHelper.syncDisplayMode (cognitive 24) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/autoframerate/internal/DisplaySyncHelper.java:369 — DisplaySyncHelper.syncDisplayMode has cognitive complexity 24 (threshold 15). Drivers by points: if/else 10 (19 pts), boolean chains 3, ternaries 1 (2 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GridFragmentHelper.findRelatedAdapter (cognitive 23) · ×1
  • GridFragmentHelper.findRelatedAdapter (cognitive 23) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/GridFragmentHelper.java:134 — GridFragmentHelper.findRelatedAdapter has cognitive complexity 23 (threshold 15). Drivers by points: if/else 6 (15 pts), ternaries 2 (4 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 12). To reduce it, flatten the nesting: this score is depth rather than breadth — most of its points come from checks stacked inside one another, so the work sits several levels in. Invert each enclosing check into an early exit (a return, or the language's equivalent) so the happy path stays at one level, and where a level cannot be exited early, lift the block it encloses into its own named function.
D2 · Cognitive Complexity · MultipleRowsFragment.update (cognitive 23) · ×1
  • MultipleRowsFragment.update (cognitive 23) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:207 — MultipleRowsFragment.update has cognitive complexity 23 (threshold 15). Drivers by points: if/else 15 (19 pts), boolean chains 2, ternaries 1 (2 pts) (nesting depth added 5). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · ProxyManager.setWebProxyAPI19Plus (cognitive 23) · ×1
  • ProxyManager.setWebProxyAPI19Plus (cognitive 23) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/proxy/ProxyManager.java:215 — ProxyManager.setWebProxyAPI19Plus has cognitive complexity 23 (threshold 15). Drivers by points: if/else 7 (11 pts), boolean chains 5, loops 2 (3 pts), ternaries 3, match/switch 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SplashPresenter.initIntentChain (cognitive 22) · ×1
  • SplashPresenter.initIntentChain (cognitive 22) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/SplashPresenter.java:193 — SplashPresenter.initIntentChain has cognitive complexity 22 (threshold 15). Drivers by points: if/else 14 (17 pts), boolean chains 2, loops 1 (2 pts), error handling 1 (nesting depth added 4). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · PlayerUIController.onButtonClicked (cognitive 21) · ×1
  • PlayerUIController.onButtonClicked (cognitive 21) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/PlayerUIController.java:576 — PlayerUIController.onButtonClicked has cognitive complexity 21 (threshold 15). Drivers by points: if/else 21. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · VideoLoaderController.processFormatInfo (cognitive 20) · ×1
  • VideoLoaderController.processFormatInfo (cognitive 20) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoLoaderController.java:268 — VideoLoaderController.processFormatInfo has cognitive complexity 20 (threshold 15). Drivers by points: if/else 12 (14 pts), boolean chains 6 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · EventsOverridePlaybackFragment.onInterceptInputEvent (cognitive 19) · ×1
  • EventsOverridePlaybackFragment.onInterceptInputEvent (cognitive 19) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/mod/EventsOverridePlaybackFragment.java:34 — EventsOverridePlaybackFragment.onInterceptInputEvent has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (18 pts), match/switch 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SharedPreferencesHelper.restoreFromXml (cognitive 19) · ×1
  • SharedPreferencesHelper.restoreFromXml (cognitive 19) REDACTED:99 — SharedPreferencesHelper.restoreFromXml has cognitive complexity 19 (threshold 15). Drivers by points: if/else 5 (9 pts), loops 2 (4 pts), match/switch 1 (2 pts), ternaries 1 (2 pts), boolean chains 1, error handling 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GeneralSettingsPresenter.appendKeyRemappingCategory (cognitive 18) · ×1
  • GeneralSettingsPresenter.appendKeyRemappingCategory (cognitive 18) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/GeneralSettingsPresenter.java:324 — GeneralSettingsPresenter.appendKeyRemappingCategory has cognitive complexity 18 (threshold 15). Drivers by points: ternaries 18. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · PlaybackFragment.updateSuggestions (cognitive 17) · ×1
  • PlaybackFragment.updateSuggestions (cognitive 17) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/PlaybackFragment.java:1374 — PlaybackFragment.updateSuggestions has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (13 pts), boolean chains 2, ternaries 1 (2 pts) (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ViewDragHelper.continueSettling (cognitive 17) · ×1
  • ViewDragHelper.continueSettling (cognitive 17) slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:671 — ViewDragHelper.continueSettling has cognitive complexity 17 (threshold 15). Drivers by points: if/else 8 (15 pts), boolean chains 2 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SponsorBlockController.findMatchedSegments (cognitive 17) · ×1
  • SponsorBlockController.findMatchedSegments (cognitive 17) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/SponsorBlockController.java:350 — SponsorBlockController.findMatchedSegments has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (14 pts), boolean chains 2, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ChannelGroupMenuProvider.showGroupDialog (cognitive 17) · ×1
  • ChannelGroupMenuProvider.showGroupDialog (cognitive 17) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/providers/channelgroup/ChannelGroupMenuProvider.java:68 — ChannelGroupMenuProvider.showGroupDialog has cognitive complexity 17 (threshold 15). Drivers by points: if/else 10 (11 pts), boolean chains 3, ternaries 1 (2 pts), loops 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · UhdHelper.setPreferredDisplayModeId (cognitive 17) · ×1
  • UhdHelper.setPreferredDisplayModeId (cognitive 17) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/autoframerate/internal/UhdHelper.java:342 — UhdHelper.setPreferredDisplayModeId has cognitive complexity 17 (threshold 15). Drivers by points: if/else 9 (10 pts), ternaries 1 (3 pts), boolean chains 2, error handling 1, loops 1 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · AppDialogActivity.handleNavigation (cognitive 16) · ×1
  • AppDialogActivity.handleNavigation (cognitive 16) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/AppDialogActivity.java:68 — AppDialogActivity.handleNavigation has cognitive complexity 16 (threshold 15). Drivers by points: if/else 7 (12 pts), boolean chains 4 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · VideoPlayerGlue.onCreatePrimaryActions (cognitive 16) · ×1
  • VideoPlayerGlue.onCreatePrimaryActions (cognitive 16) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/other/VideoPlayerGlue.java:140 — VideoPlayerGlue.onCreatePrimaryActions has cognitive complexity 16 (threshold 15). Drivers by points: if/else 16. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · Video.fromString (cognitive 16) · ×1
  • Video.fromString (cognitive 16) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/Video.java:382 — Video.fromString has cognitive complexity 16 (threshold 15). Drivers by points: if/else 16. To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · ErrorFixerController.onLongBuffering (cognitive 16) · ×1
  • ErrorFixerController.onLongBuffering (cognitive 16) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/ErrorFixerController.java:47 — ErrorFixerController.onLongBuffering has cognitive complexity 16 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 4 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SuggestionsController.getPreviousFromGroup (cognitive 16) · ×1
  • SuggestionsController.getPreviousFromGroup (cognitive 16) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/SuggestionsController.java:318 — SuggestionsController.getPreviousFromGroup has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (11 pts), loops 1 (3 pts), boolean chains 2 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SubtitleManager.forceCenterAlignment (cognitive 16) · ×1
  • SubtitleManager.forceCenterAlignment (cognitive 16) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/other/SubtitleManager.java:98 — SubtitleManager.forceCenterAlignment has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (8 pts), ternaries 2 (6 pts), boolean chains 1, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LiveDashManifestParser.recreateMissingSegments (cognitive 16) · ×1
  • LiveDashManifestParser.recreateMissingSegments (cognitive 16) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/LiveDashManifestParser.java:173 — LiveDashManifestParser.recreateMissingSegments has cognitive complexity 16 (threshold 15). Drivers by points: if/else 8, boolean chains 4, ternaries 2 (3 pts), loops 1 (nesting depth added 1). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · LoadingManager.showLoading (cognitive 16) · ×1
  • LoadingManager.showLoading (cognitive 16) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/utils/LoadingManager.java:25 — LoadingManager.showLoading has cognitive complexity 16 (threshold 15). Drivers by points: if/else 11 (16 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D22 · Internal API Consistency · Duplicate listener interfaces with inconsistent method signatures. SlidrListener and OnPanelSlideListener expose nearly identical lifecycle events (open, close, slide, state change) but differ in return types (e.g., SlidrListener.onSlideClosed returns boolean, OnPanelSlideListener.onClosed returns void) and naming conventions (onSlideClosed vs onClosed). This forces users to choose between two nearly identical interfaces with subtle behavioral differences. · ×1
  • Duplicate listener interfaces with inconsistent method signatures. SlidrListener and OnPanelSlideListener expose nearly identical lifecycle events (open, close, slide, state change) but differ in return types (e.g., SlidrListener.onSlideClosed returns boolean, OnPanelSlideListener.onClosed returns void) and naming conventions (onSlideClosed vs onClosed). This forces users to choose between two nearly identical interfaces with subtle behavioral differences. — Unify into a single interface (e.g., SlidrListener) and standardize return types (likely void for all callbacks unless cancellation is explicitly required, in which case document it clearly). Remove OnPanelSlideListener or deprecate it in favor of the unified interface. (signatures: SlidrListener.onSlideChange(percent: float) | SlidrListener.onSlideClosed(): boolean | SlidrListener.onSlideOpened(): void | SlidrListener.onSlideStateChanged(state: int) | OnPanelSlideListener.onClosed(): void | OnPanelSlideListener.onOpened(): void | OnPanelSlideListener.onSlideChange(percent: float) | OnPanelSlideListener.onStateChanged(state: int))
D22 · Internal API Consistency · SlidrListenerAdapter duplicates the method signatures of SlidrListener exactly, acting as a pass-through or default implementation. While adapters are common, having a separate adapter class that mirrors the interface exactly without adding default behavior or extending it suggests a lack of default methods in the interface itself (Java 7/8 compatibility issue perhaps), but it creates redundancy in the public API surface. · ×1
  • SlidrListenerAdapter duplicates the method signatures of SlidrListener exactly, acting as a pass-through or default implementation. While adapters are common, having a separate adapter class that mirrors the interface exactly without adding default behavior or extending it suggests a lack of default methods in the interface itself (Java 7/8 compatibility issue perhaps), but it creates redundancy in the public API surface. — If Java 8+ is supported, convert SlidrListener to an interface with default methods to eliminate the need for SlidrListenerAdapter. If Java 7 compatibility is required, consider if the adapter is necessary in the public API or if it can be internal. (signatures: SlidrListenerAdapter.onSlideChange(percent: float) | SlidrListenerAdapter.onSlideClosed(): boolean | SlidrListenerAdapter.onSlideOpened(): void | SlidrListenerAdapter.onSlideStateChanged(state: int))
D22 · Internal API Consistency · Ambiguous distinction between abort() and cancel(). In Android's ViewDragHelper, cancel() typically cancels the current drag/settle operation, while abort() might imply a more forceful termination. However, without clear documentation or distinct behavioral signatures in the API surface, these two methods appear to serve overlapping purposes of stopping the current interaction, leading to potential misuse. · ×1
  • Ambiguous distinction between abort() and cancel(). In Android's ViewDragHelper, cancel() typically cancels the current drag/settle operation, while abort() might imply a more forceful termination. However, without clear documentation or distinct behavioral signatures in the API surface, these two methods appear to serve overlapping purposes of stopping the current interaction, leading to potential misuse. — Clarify the distinct use cases for abort() vs cancel() in documentation. If they are functionally equivalent in most contexts, consider deprecating one to reduce API confusion. (signatures: ViewDragHelper.abort(): void | ViewDragHelper.cancel(): void)
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Near-duplicate member pair (38 shared lines) · ×1
  • Near-duplicate member pair (38 shared lines) slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:891 — slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:891-1001 | slidableactivity/src/main/java/com/r0adkll/slidr/util/ViewDragHelper.java:1009-1140 — These two members are variants of one another: 38 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Edited copy of a member (14 corresponding lines) · ×1
  • Edited copy of a member (14 corresponding lines) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/MainUISettingsPresenter.java:225 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/MainUISettingsPresenter.java:225-238 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/UIScaleSettingsPresenter.java:56-69 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (24 corresponding lines) · ×1
  • Edited copy of a member (24 corresponding lines) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorUtil.java:305 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorUtil.java:305-334 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorUtil.java:336-360 — These two members are one piece of code written twice and then edited apart: 24 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (4 members, 50+ identical tokens) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/vineyard/IconCardView.java:81 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/vineyard/IconCardView.java:81-94 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/vineyard/LoadingCardView.java:58-69 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/vineyard/TagCardView.java:61-74 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/vineyard/videoview/VideoCardView.java:117-127 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Duplicated block (24–25 lines × 2) · ×1
  • Duplicated block (24–25 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/mod/surface/SurfaceViewWrapper.java:21 — leanback-1.0.0/src/main/java/androidx/leanback/app/VideoSupportFragment.java:45-69 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/playback/mod/surface/SurfaceViewWrapper.java:21-44 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (22 lines × 2) · ×1
  • Duplicated block (22 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorUtil.java:313 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorUtil.java:313-334 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorUtil.java:339-360 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/selector/TrackSelectorUtil.java:313` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (11–18 lines × 3) · ×1
  • Duplicated block (11–18 lines × 3) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/Video.java:390 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/Video.java:390-407 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/Video.java:413-423 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/data/Video.java:429-443 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×1
  • Duplicated block (17 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/BackupAndRestoreHelper.java:237 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/BackupAndRestoreHelper.java:237-253 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/BackupAndRestoreHelper.java:257-273 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/BackupAndRestoreHelper.java:237` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16–17 lines × 2) · ×1
  • Duplicated block (16–17 lines × 2) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/vineyard/videoview/VideoCardView.java:81 — leanback-1.0.0/src/main/java/androidx/leanback/widget/ImageCardView.java:193-209 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/vineyard/videoview/VideoCardView.java:81-96 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: `R` names `androidx.leanback.R` in one and `com.liskovsoft.smartyoutubetv2.tv.R` in another — different types that share a simple name, which is why the text matched. A single extracted unit cannot be given a parameter type that fits both, so unifying those types (or introducing a shared abstraction over them) is the step that has to come BEFORE the extraction above; if they are deliberately separate, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (12–13 lines × 2) · ×1
  • Duplicated block (12–13 lines × 2) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/BackupSettingsPresenter.java:100 — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/BackupSettingsPresenter.java:100-112 | common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/BackupSettingsPresenter.java:132-143 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/BackupSettingsPresenter.java:100` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (11–13 lines × 2) · ×1
  • Duplicated block (11–13 lines × 2) slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:335 — slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:335-345 | slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:495-507 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `slidableactivity/src/main/java/com/r0adkll/slidr/widget/SliderPanel.java:335` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9–12 lines × 4) · ×1
  • Duplicated block (9–12 lines × 4) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/vineyard/IconCardView.java:83 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/vineyard/IconCardView.java:83-94 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/vineyard/LoadingCardView.java:59-69 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/vineyard/TagCardView.java:63-74 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/widgets/vineyard/videoview/VideoCardView.java:119-127 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (11–12 lines × 2) · ×1
  • Duplicated block (11–12 lines × 2) leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:98 — leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:98-109 | leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:195-205 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:98` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (7–8 lines × 2) · ×1
  • Duplicated block (7–8 lines × 2) leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:265 — leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:265-272 | leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:396-402 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/ChannelsProvider.java:265` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (26 lines × 2) · ×1
  • Duplicated block (26 lines × 2) filepicker-lib/src/main/java/arte/programar/materialfile/ui/OnItemClickListener.java:1 — filepicker-lib/src/main/java/arte/programar/materialfile/ui/OnItemClickListener.java:1-29 | filepicker-lib/src/main/java/arte/programar/materialfile/ui/ThrottleClickListener.java:1-26 — before extracting anything, compare `filepicker-lib/src/main/java/arte/programar/materialfile/ui/OnItemClickListener.java` and `filepicker-lib/src/main/java/arte/programar/materialfile/ui/ThrottleClickListener.java` as WHOLE FILES: 100% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `filepicker-lib/src/main/java/arte/programar/materialfile/ui/OnItemClickListener.java:1` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15 lines × 4) · ×1
  • Duplicated block (15 lines × 4) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/ChatPreference.java:11 — exoplayer-amzn-2.10.6/library/ui/src/main/java/com/google/android/exoplayer2/ui/PlaybackControlView.java:1-53 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/ChatPreference.java:11-33 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/CommentsPreference.java:11-33 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/StringListPreference.java:8-22 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 4 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 4 times. Read the line range as the matched WINDOW rather than a finished unit: at `exoplayer-amzn-2.10.6/library/ui/src/main/java/com/google/android/exoplayer2/ui/PlaybackControlView.java:1` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×1
  • Duplicated block (7 lines × 3) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java:398 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java:398-404 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:329-336 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/VideoGridFragment.java:255-261 — before extracting anything, compare `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java` and `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/VideoGridFragment.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×1
  • Duplicated block (8 lines × 3) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java:410 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java:410-417 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultipleRowsFragment.java:342-349 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/VideoGridFragment.java:267-274 — before extracting anything, compare `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java` and `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/VideoGridFragment.java` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/browse/video/MultiVideoGridFragment.java:410` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (5 lines × 3) · ×1
  • Duplicated block (5 lines × 3) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/channel/ChannelActivity.java:12 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/channel/ChannelActivity.java:12-16 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/channeluploads/ChannelUploadsActivity.java:12-16 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/search/tags/SearchTagsActivity.java:13-18 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
D4 · Code Duplication · Duplicated block (10 lines × 4) · ×1
  • Duplicated block (10 lines × 4) smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/RadioListPreferenceDialogFragment.java:23 — smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/RadioListPreferenceDialogFragment.java:23-32 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/dialogs/other/StringListPreferenceDialogFragment.java:19-28 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/mod/leanback/preference/LeanbackListPreferenceDialogFragment.java:69-78 | smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/mod/leanback/preference/LeanbackListPreferenceDialogFragment.java:80-89 — there are 4 copies across 3 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 4 sites; resolving a subset leaves the remainder to drift apart. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
IC1 · Incompleteness & stubs · Empty method body · ×1
  • Empty method body — does nothing with its inputs exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/parser/ump/UMPEncoder.java:4 — `encode` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
IC1 · Incompleteness & stubs · Hollow method · ×1
  • Hollow method — returns a constant without doing the work smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/util/LongPressHandler.java:45 — `onKeyUpShortPress` looks like it should compute a result but its body just returns a constant — a placeholder return that was never filled in.
X19 · Unrestored process-global state · Process-global state is restored only on the happy path · ×1
  • Process-global state is restored only on the happy path common/src/main/java/com/liskovsoft/smartyoutubetv2/common/proxy/ProxyManager.java:215 — `setWebProxyAPI19Plus` changes state that belongs to the whole JVM and changes it back at the end of the same body — the `http.proxyHost` system property (set at line 243, cleared at line 287) and the `http.proxyPort` system property (set at line 244, cleared at line 288) and the `https.proxyHost` system property (set at line 245, cleared at line 289) and the `https.proxyPort` system property (set at line 246, cleared at line 290) and the `http.proxyUser` system property (set at line 251, cleared at line 294) and the `http.proxyPassword` system property (set at line 252, cleared at line 295) and the `https.proxyUser` system property (set at line 253, cleared at line 296) and the `https.proxyPassword` system property (set at line 254, cleared at line 297) — which says the change was meant to last no longer than this call. But the restore is an ordinary statement on the straight-line path, not a `finally`, so it is skipped by any exception thrown in between: the JVM then keeps the overwritten value for the rest of its life, and every later property lookup, formatter, date conversion or console write in ANY class reads it. That failure is silent and remote from its cause — the method that breaks is not the method that moved the value. The window is not private while it is open either: system properties, the default `Locale` and `TimeZone` and the standard streams are per-JVM, not per-thread, so a concurrent thread reads the moved value too. The durable fix is not to widen the restore but to stop mutating the global: pass the value to the operation that needs it — an explicit `Locale` to `String.format`/`NumberFormat`/`DateTimeFormatter`, a `ZoneId` to `java.time`, the setting to the component that reads the property, a `PrintStream` to the code that writes, `ProcessBuilder.environment()`/`directory()` for a child. Where the global genuinely must move, wrap it `try`/`finally` so the restore runs on every path.
Minor — 66 finding(s)
X10 · Duplicated predicate · Duplicated predicate · ×25
  • Duplicated predicate exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/extractor/mp4/FragmentedMp4Extractor.java:441 — `!containerAtoms.isEmpty() && containerAtoms.peek().endPosition == atomEndPosition` appears character-identically in 2 files — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/extractor/mp4/FragmentedMp4Extractor.java, exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/extractor/mp4/Mp4Extractor.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/UrlTemplate.java:145 — `!formatTag.endsWith("d") && !formatTag.endsWith("x")` appears character-identically in 2 files — exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/UrlTemplate.java, exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/manifest/UrlTemplate.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate exoplayer-amzn-2.10.6/extensions/vp9/src/main/java/com/google/android/exoplayer2/ext/vp9/LibvpxVideoRenderer.java:944 — `!isStarted || positionUs == initialPositionUs` appears character-identically in 2 files — exoplayer-amzn-2.10.6/extensions/vp9/src/main/java/com/google/android/exoplayer2/ext/vp9/LibvpxVideoRenderer.java, exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/video/MediaCodecVideoRenderer.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/DashMediaSource.java:977 — `!livePresentationDelayOverridesManifest && manifest.suggestedPresentationDelayMs != C.TIME_UNSET` appears character-identically in 2 files — exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/DashMediaSource.java, exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/SabrMediaSource.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate leanback-1.0.0/src/main/java/androidx/leanback/app/ProgressBarManager.java:31 — `!mEnableProgressBar || (!mUserProvidedProgressBar && rootView == null)` appears character-identically in 2 files — leanback-1.0.0/src/main/java/androidx/leanback/app/ProgressBarManager.java, smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/mod/leanback/misc/ProgressBarManager.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/SectionMenuPresenter.java:215 — `!mIsReturnToBackgroundVideoEnabled || !PlaybackPresenter.instance(getContext()).isRunningInBackground()` appears character-identically in 2 files — common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/SectionMenuPresenter.java, common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/VideoMenuPresenter.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate leanback-1.0.0/src/main/java/androidx/leanback/widget/SingleRow.java:107 — `!oneColumnMode && checkAppendOverLimit(toLimit)` appears character-identically in 2 files — leanback-1.0.0/src/main/java/androidx/leanback/widget/SingleRow.java, leanback-1.0.0/src/main/java/androidx/leanback/widget/StaggeredGrid.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate leanback-1.0.0/src/main/java/androidx/leanback/widget/SingleRow.java:74 — `!oneColumnMode && checkPrependOverLimit(toLimit)` appears character-identically in 2 files — leanback-1.0.0/src/main/java/androidx/leanback/widget/SingleRow.java, leanback-1.0.0/src/main/java/androidx/leanback/widget/StaggeredGrid.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate exoplayer-amzn-2.10.6/extensions/vp9/src/main/java/com/google/android/exoplayer2/ext/vp9/LibvpxVideoRenderer.java:933 — `!renderedFirstFrame || (isStarted && shouldForceRenderOutputBuffer(earlyUs, elapsedRealtimeNowUs - lastRenderTimeUs))` appears character-identically in 2 files — exoplayer-amzn-2.10.6/extensions/vp9/src/main/java/com/google/android/exoplayer2/ext/vp9/LibvpxVideoRenderer.java, exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/video/MediaCodecVideoRenderer.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate exoplayer-amzn-2.10.6/extensions/mediasession/src/main/java/com/google/android/exoplayer2/ext/mediasession/MediaSessionConnector.java:822 — `!timeline.isEmpty() && !player.isPlayingAd()` appears character-identically in 4 files — exoplayer-amzn-2.10.6/extensions/mediasession/src/main/java/com/google/android/exoplayer2/ext/mediasession/MediaSessionConnector.java, exoplayer-amzn-2.10.6/extensions/mediasession/src/main/java/com/google/android/exoplayer2/ext/mediasession/TimelineQueueNavigator.java, exoplayer-amzn-2.10.6/library/ui/src/main/java/com/google/android/exoplayer2/ui/PlayerControlView.java, exoplayer-amzn-2.10.6/library/ui/src/main/java/com/google/android/exoplayer2/ui/PlayerNotificationManager.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate leanback-1.0.0/src/main/java/androidx/leanback/widget/DetailsOverviewSharedElementHelper.java:189 — `(activity == null && !TextUtils.isEmpty(sharedElementName)) || (activity != null && TextUtils.isEmpty(sharedElementName))` appears character-identically in 2 files — leanback-1.0.0/src/main/java/androidx/leanback/widget/DetailsOverviewSharedElementHelper.java, leanback-1.0.0/src/main/java/androidx/leanback/widget/FullWidthDetailsOverviewSharedElementHelper.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/DashMediaPeriod.java:384 — `(streams[i] instanceof EmbeddedSampleStream) && ((EmbeddedSampleStream) streams[i]).parent == streams[primaryStreamIndex]` appears character-identically in 2 files — exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/DashMediaPeriod.java, exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/SabrMediaPeriod.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/extractor/ts/SeiReader.java:51 — `MimeTypes.APPLICATION_CEA608.equals(channelMimeType) || MimeTypes.APPLICATION_CEA708.equals(channelMimeType)` appears character-identically in 2 files — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/extractor/ts/SeiReader.java, exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/extractor/ts/UserDataReader.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/DefaultDashChunkSource.java:796 — `MimeTypes.isText(mimeType) || MimeTypes.APPLICATION_TTML.equals(mimeType)` appears character-identically in 2 files — exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/DefaultDashChunkSource.java, exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/DefaultSabrChunkSource.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser.java:1312 — `MimeTypes.isText(mimeType) || MimeTypes.APPLICATION_TTML.equals(mimeType) || MimeTypes.APPLICATION_MP4VTT.equals(mimeType) || MimeTypes.APPL…` appears character-identically in 3 files — exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser.java, exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser2.java, exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/manifest/SabrManifestParser.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/UpdateChannelsJobService.java:36 — `VERSION.SDK_INT >= 23 && GlobalPreferences.instance(context).isChannelsServiceEnabled()` appears character-identically in 2 files — leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/UpdateChannelsJobService.java, leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/UpdateChannelsWorker.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate leanback-1.0.0/src/main/java/androidx/leanback/widget/DetailsOverviewSharedElementHelper.java:193 — `activity == mActivityToRunTransition && TextUtils.equals(sharedElementName, mSharedElementName)` appears character-identically in 2 files — leanback-1.0.0/src/main/java/androidx/leanback/widget/DetailsOverviewSharedElementHelper.java, leanback-1.0.0/src/main/java/androidx/leanback/widget/FullWidthDetailsOverviewSharedElementHelper.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/audio/MediaCodecAudioRenderer.java:688 — `allowFirstBufferPositionDiscontinuity && !buffer.isDecodeOnly()` appears character-identically in 2 files — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/audio/MediaCodecAudioRenderer.java, exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/audio/SimpleDecoderAudioRenderer.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/DefaultDashChunkSource.java:443 — `blacklistDurationMs != C.TIME_UNSET && trackSelection.blacklist(trackSelection.indexOf(chunk.trackFormat), blacklistDurationMs)` appears character-identically in 2 files — exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/DefaultDashChunkSource.java, exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/DefaultSabrChunkSource.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/text/ttml/TtmlStyle.java:92 — `bold == UNSPECIFIED && italic == UNSPECIFIED` appears character-identically in 2 files — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/text/ttml/TtmlStyle.java, exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/text/webvtt/WebvttCssStyle.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/extractor/ogg/VorbisBitArray.java:125 — `byteOffset >= 0 && (byteOffset < byteLimit || (byteOffset == byteLimit && bitOffset == 0))` appears character-identically in 3 files — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/extractor/ogg/VorbisBitArray.java, exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/util/ParsableBitArray.java, exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/util/ParsableNalUnitBitArray.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate leanback-1.0.0/src/main/java/androidx/leanback/media/PlaybackBannerControlGlue.java:456 — `canPlay && mPlaybackSpeed != PLAYBACK_SPEED_NORMAL` appears character-identically in 2 files — leanback-1.0.0/src/main/java/androidx/leanback/media/PlaybackBannerControlGlue.java, leanback-1.0.0/src/main/java/androidx/leanback/media/PlaybackControlGlue.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/extractor/ts/PsExtractor.java:166 — `canReadDuration && !durationReader.isDurationReadFinished()` appears character-identically in 2 files — exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/extractor/ts/PsExtractor.java, exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/extractor/ts/TsExtractor.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate leanback-1.0.0/src/main/java/androidx/leanback/widget/PlaybackTransportRowPresenter.java:237 — `childIndex < 0 || childIndex >= mThumbsBar.getChildCount()` appears character-identically in 2 files — leanback-1.0.0/src/main/java/androidx/leanback/widget/PlaybackTransportRowPresenter.java, smarttubetv/src/main/java/com/liskovsoft/smartyoutubetv2/tv/ui/mod/leanback/playerglue/tweaks/PlaybackTransportRowPresenter.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser.java:1296 — `codecs.contains("eia608") || codecs.contains("cea608")` appears character-identically in 3 files — exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser.java, exoplayer-amzn-2.10.6/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser2.java, exoplayer-amzn-2.10.6/library/sabr/src/main/java/com/google/android/exoplayer2/source/sabr/manifest/SabrManifestParser.java. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
M4 · Documentation accuracy · README/code drift · ×12
  • README/code drift doubletapplayerview/README.md:6 — doubletapplayerview/README.md links to `github/preview_gif.gif`, but `doubletapplayerview/github/preview_gif.gif` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift filepicker-lib/README.md:5 — filepicker-lib/README.md links to `ss/main.png`, but `filepicker-lib/ss/main.png` does not exist. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md:28 — exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md documents the environment variable `FFMPEG_EXT_PATH`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md:41 — exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md documents the environment variable `HOST_PLATFORM`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md:52 — exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md documents the environment variable `COMMON_OPTIONS`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md:110 — exoplayer-amzn-2.10.6/extensions/ffmpeg/README.md documents the environment variable `APP_ABI`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift exoplayer-amzn-2.10.6/extensions/flac/README.md:27 — exoplayer-amzn-2.10.6/extensions/flac/README.md documents the environment variable `EXOPLAYER_ROOT`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift exoplayer-amzn-2.10.6/extensions/flac/README.md:28 — exoplayer-amzn-2.10.6/extensions/flac/README.md documents the environment variable `FLAC_EXT_PATH`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift exoplayer-amzn-2.10.6/extensions/opus/README.md:27 — exoplayer-amzn-2.10.6/extensions/opus/README.md documents the environment variable `EXOPLAYER_ROOT`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift exoplayer-amzn-2.10.6/extensions/opus/README.md:28 — exoplayer-amzn-2.10.6/extensions/opus/README.md documents the environment variable `OPUS_EXT_PATH`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift exoplayer-amzn-2.10.6/extensions/vp9/README.md:27 — exoplayer-amzn-2.10.6/extensions/vp9/README.md documents the environment variable `EXOPLAYER_ROOT`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
  • README/code drift exoplayer-amzn-2.10.6/extensions/vp9/README.md:28 — exoplayer-amzn-2.10.6/extensions/vp9/README.md documents the environment variable `VP9_EXT_PATH`, but no code, script or configuration file names it. Checked without a model against the repository: its files and folders, the scripts and dependencies of every package.json, the projects, namespaces, package references and target frameworks of the .NET build, the SDK and Node pins, and the identifiers of every file that is not a document; the documents' own text never counts. A footprint generated at build time, read only by a platform, or living outside this repository is not seen, and this row is then wrong.
AX6 · Interface segregation · Fat interface · ×9
  • Fat interface: AudioSink (21 abstract methods) exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/audio/AudioSink.java:52 — `AudioSink` declares 21 abstract methods: `configure`, `disableTunneling`, `enableTunnelingV21`, `flush`, `getCurrentPositionUs`, `getPlaybackParameters`, `handleBuffer`, `handleDiscontinuity`, `hasPendingData`, `isEnded`, `pause`, `play`, `playToEndOfStream`, `reset`, `setAudioAttributes`, `setAudioSessionId`, `setAuxEffectInfo`, `setListener`, `setPlaybackParameters`, `setVolume`, `supportsOutput`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: ExoMediaDrm<T> (16 abstract methods) exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/drm/ExoMediaDrm.java:34 — `ExoMediaDrm<T>` declares 16 abstract methods: `closeSession`, `createMediaCrypto`, `getKeyRequest`, `getPropertyByteArray`, `getPropertyString`, `getProvisionRequest`, `openSession`, `provideKeyResponse`, `provideProvisionResponse`, `queryKeyStatus`, `release`, `restoreKeys`, `setOnEventListener`, `setOnKeyStatusChangeListener`, `setPropertyByteArray`, `setPropertyString`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: TrackSelection (16 abstract methods) exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/trackselection/TrackSelection.java:38 — `TrackSelection` declares 16 abstract methods under just 15 distinct name(s): `blacklist`, `disable`, `enable`, `evaluateQueueSize`, `getFormat`, `getIndexInTrackGroup`, `getSelectedFormat`, `getSelectedIndex`, `getSelectedIndexInTrackGroup`, `getSelectionData`, `getSelectionReason`, `getTrackGroup`, `indexOf`, `indexOf`, `length`, `onPlaybackSpeed`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. That is an OVERLOAD SET, not 16 separate responsibilities: a caller binds to 15 operation(s) and uses the overload it selected, so the Interface-Segregation harm does NOT apply on the caller's side and splitting this into role-interfaces would scatter one operation without relieving anything. The burden that does remain is the IMPLEMENTER's — all 16 signatures must be written and kept in step. Reduce it by collapsing overloads (optional or default parameters, or an options object) rather than by segregating the interface.
  • Fat interface: Cache (17 abstract methods) exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/Cache.java:28 — `Cache` declares 17 abstract methods: `addListener`, `applyContentMetadataMutations`, `commitFile`, `getCacheSpace`, `getCachedLength`, `getCachedSpans`, `getContentMetadata`, `getKeys`, `getUid`, `isCached`, `release`, `releaseHoleSpan`, `removeListener`, `removeSpan`, `startFile`, `startReadWrite`, `startReadWriteNonBlocking`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: Player (55 abstract methods) exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/Player.java:60 — `Player` declares 55 abstract methods: `addListener`, `getApplicationLooper`, `getAudioComponent`, `getBufferedPercentage`, `getBufferedPosition`, `getContentBufferedPosition`, `getContentDuration`, `getContentPosition`, `getCurrentAdGroupIndex`, `getCurrentAdIndexInAdGroup`, `getCurrentManifest`, `getCurrentPeriodIndex`, `getCurrentPosition`, `getCurrentTag`, `getCurrentTimeline`, `getCurrentTrackGroups`, `getCurrentTrackSelections`, `getCurrentWindowIndex`, `getDuration`, `getMetadataComponent`, `getNextWindowIndex`, `getPlayWhenReady`, `getPlaybackError`, `getPlaybackParameters`, `getPlaybackState`, `getPlaybackSuppressionReason`, `getPreviousWindowIndex`, `getRendererCount`, `getRendererType`, `getRepeatMode`, `getShuffleModeEnabled`, `getTextComponent`, `getTotalBufferedDuration`, `getVideoComponent`, `hasNext`, `hasPrevious`, `isCurrentWindowDynamic`, `isCurrentWindowSeekable`, `isLoading`, `isPlaying`, and 15 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 55 declarations carry 52 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 52 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: VideoComponent (17 abstract methods) exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/Player.java:146 — `VideoComponent` declares 17 abstract methods: `addVideoListener`, `clearCameraMotionListener`, `clearVideoFrameMetadataListener`, `clearVideoSurface`, `clearVideoSurface`, `clearVideoSurfaceHolder`, `clearVideoSurfaceView`, `clearVideoTextureView`, `getVideoScalingMode`, `removeVideoListener`, `setCameraMotionListener`, `setVideoFrameMetadataListener`, `setVideoScalingMode`, `setVideoSurface`, `setVideoSurfaceHolder`, `setVideoSurfaceView`, `setVideoTextureView`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 17 declarations carry 16 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 16 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: Renderer (21 abstract methods) exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/Renderer.java:36 — `Renderer` declares 21 abstract methods: `disable`, `enable`, `getCapabilities`, `getMediaClock`, `getReadingPositionUs`, `getState`, `getStream`, `getTrackType`, `hasReadStreamToEnd`, `isCurrentStreamFinal`, `isEnded`, `isReady`, `maybeThrowStreamError`, `render`, `replaceStream`, `reset`, `resetPosition`, `setCurrentStreamFinal`, `setIndex`, `start`, `stop`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: PlayerEngine (42 abstract methods) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/manager/PlayerEngine.java:9 — `PlayerEngine` declares 42 abstract methods: `blockEngine`, `containsMedia`, `getAudioFormat`, `getAudioFormats`, `getDurationMs`, `getPitch`, `getPlayWhenReady`, `getPositionMs`, `getResizeMode`, `getSpeed`, `getSubtitleFormat`, `getSubtitleFormats`, `getVideoFormat`, `getVideoFormats`, `getVolume`, `isEngineBlocked`, `isEngineInitialized`, `isInPIPMode`, `isLoading`, `isPlaying`, `openDash`, `openDash`, `openDashUrl`, `openHlsUrl`, `openMerged`, `openMerged`, `openSabr`, `openUrlList`, `reloadPlayback`, `restartEngine`, `setAspectRatio`, `setFormat`, `setPitch`, `setPlayWhenReady`, `setPositionMs`, `setResizeMode`, `setRotationAngle`, `setSpeed`, `setVideoFlipEnabled`, `setVideoGravity`, and 2 more. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 42 declarations carry 40 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 40 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
  • Fat interface: PlayerUI (28 abstract methods) common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/manager/PlayerUI.java:10 — `PlayerUI` declares 28 abstract methods: `clearSuggestions`, `focusSuggestedItem`, `focusSuggestedItem`, `getButtonState`, `getSuggestionsByIndex`, `getSuggestionsIndex`, `isControlsShown`, `isOverlayShown`, `isSuggestionsEmpty`, `isSuggestionsShown`, `loadStoryboard`, `removeSuggestions`, `resetSuggestedPosition`, `setButtonState`, `setChannelIcon`, `setChatReceiver`, `setNextTitle`, `setSeekBarSegments`, `setSeekPreviewTitle`, `setTitle`, `showControls`, `showDebugInfo`, `showOverlay`, `showProgressBar`, `showSubtitles`, `showSuggestions`, `updateEndingTime`, `updateSuggestions`. Counted over its ABSTRACT methods, once per signature; `default`, `static` and `private` methods and constants are not counted, because no implementer is forced to write them. Those 28 declarations carry 27 distinct name(s), so part of the width is overloading rather than separate responsibilities — but 27 operations clears the >15 bar on its own, so the row is about responsibilities, not signatures. A wide interface forces every implementer and caller to depend on methods they don't use (the Interface-Segregation 'I' in SOLID). Split it into focused role-interfaces.
IC1 · Incompleteness & stubs · Disabled test · ×4
  • Disabled test exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/offline/DownloadManagerDashTest.java:112 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/offline/DownloadServiceDashTest.java:156 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/offline/DownloadServiceDashTest.java:167 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
  • Disabled test exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/offline/DownloadServiceDashTest.java:181 — A test is skipped/ignored — coverage that looks present but never runs. Re-enable it or delete it so the green run means something.
IC1 · Incompleteness & stubs · Empty method body · ×2
  • Empty method body leanback-1.0.0/src/main/java/androidx/leanback/app/PlaybackSupportFragment.java:196 — `onFadeInComplete` has an empty body — confirm it's an intentional no-op and not an unfinished method.
  • Empty method body leanback-1.0.0/src/main/java/androidx/leanback/app/PlaybackSupportFragment.java:199 — `onFadeOutComplete` has an empty body — confirm it's an intentional no-op and not an unfinished method.
X7 · Silent fallback defaults · Silent fallback default on parse failure · ×2
  • Silent fallback default on parse failure exoplayer-amzn-2.10.6/extensions/cronet/src/main/java/com/google/android/exoplayer2/ext/cronet/CronetEngineWrapper.java:244 — `compareVersionStrings` returns `0` when `NumberFormatException` is thrown, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the Javadoc, and the row stops firing.
  • Silent fallback default on parse failure common/src/main/java/com/liskovsoft/smartyoutubetv2/common/utils/IntentExtractor.java:331 — `parseTimeStr` returns `-1` when `NumberFormatException` is thrown, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the Javadoc, and the row stops firing.
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`.
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1
  • Projects may be oversized for their cohesion — 2 of 29 project(s) overshoot their size bounds, lowering Project Cohesion to 8.6/10. The most over is `common` (38193 LoC, 249 module-visible types across 37 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D28 · Secrets (history) · Rotate the exposed credentials · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation · No architecture diagram/doc · ×1
  • No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
P10 · Library API & versioning · No explicit versioning · ×1
  • No explicit versioning slidableactivity/build.gradle — No explicit version was found for the Maven/Gradle library declared by `build.gradle`. This check read a `<version>` in pom.xml, or `version` in build.gradle(.kts) or gradle.properties, and a CHANGELOG/CHANGES/HISTORY/NEWS/RELEASES file with a semver heading, or release tooling (changesets, release-please, semantic-release, goreleaser, cargo-release, bump2version, standard-version, git-cliff) in the library's directory or at the repository root, or a semver release tag (or a Drupal `8.x-1.2` release tag) in the repository. A version computed where none of those can see is invisible here. A published library needs explicit semantic versioning so consumers can reason about breaking changes.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST — No static application security testing detected. For this repository's stack, add spotbugs with find-sec-bugs (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 10847 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
X5 · Nullable reference types · Java packages are not null-marked everywhere · ×1
  • Java packages are not null-marked everywhere — 0/211 of this repository's Java package directories are under a non-null default: a `package-info.java` declaring `@NullMarked` (JSpecify) or `@NonNullApi`, `@ParametersAreNonnullByDefault`, `@NonNullByDefault`, `@DefaultQualifier(NonNull.class)`; a `module-info.java` declaring `@NullMarked`; every type in it `@NullMarked`; or a build that runs NullAway with the package in `AnnotatedPackages`, or the Checker Framework's `NullnessChecker`. Elsewhere every reference admits null and no checker warns on the dereference that throws a `NullPointerException`.
X7 · Silent fallback defaults · Silent fallback default in catch · ×1
  • Silent fallback default in catch exoplayer-amzn-2.10.6/library/core/src/main/java/com/google/android/exoplayer2/audio/AudioTrackPositionTracker.java:682 — `getAudioSWLatencies` swallows every exception into `return 0` — a data error becomes a silent behavior change with no trail. Log the failure or let it propagate. If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment in the catch or in the Javadoc, and the row stops firing.
Minor — 4 finding(s)
D10 · Test Quality · Skipped (documented) · ×4
  • Skipped (documented): testSaveAndLoadActionFile exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/offline/DownloadManagerDashTest.java:114 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Ignore
  • Skipped (documented): testMultipleDownloadRequest exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/offline/DownloadServiceDashTest.java:158 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Ignore
  • Skipped (documented): testRemoveAction exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/offline/DownloadServiceDashTest.java:169 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Ignore
  • Skipped (documented): testRemoveBeforeDownloadComplete exoplayer-amzn-2.10.6/library/dash/src/test/java/com/google/android/exoplayer2/source/dash/offline/DownloadServiceDashTest.java:183 — Skipped with a documented reason — a deferral, not lazy debt: switched off by @Ignore

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-6f05db78d5f54ac6ba0678673f732ba7/history.json --exit-code 0 --source .15artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/watchdog-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-6f05db78d5f54ac6ba0678673f732ba7/tree.json --exit-code 0 --source .1artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/watchdog-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off .17artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesnone (dependency manifest found, not scanned for vulnerabilities here)—none (dependency manifest found, not scanned for vulnerabilities here): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) — not scanned yet).0—
D31 · IaC & Container Securitytrivy—trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.0—
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciesnone (dependency manifest found, not scanned for vulnerabilities here)—none (dependency manifest found, not scanned for vulnerabilities here): not applicable — Not scored — no dependency manifest in a supported ecosystem was read for this repository. A gap in the analyzer's language coverage, NOT a finding that the repository is free of vulnerable dependencies (a Gradle build (build.gradle/build.gradle.kts) — not scanned yet).0—

Run 01a16c23-56cf-7bf5-b033-a18fc18b5fef · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md