{"$schema":"https://json.schemastore.org/sarif-2.1.0.json","version":"2.1.0","runs":[{"tool":{"driver":{"name":"codehealth","informationUri":"https://codehealth.canine.dev","rules":[{"id":"D5","name":"Coupling","shortDescription":{"text":"Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D5"},{"id":"D6","name":"Cohesion (LCOM4)","shortDescription":{"text":"Cohesion (LCOM4)"},"helpUri":"https://codehealth.canine.dev/dimensions/D6"},{"id":"D8","name":"Code Coverage","shortDescription":{"text":"Code Coverage"},"helpUri":"https://codehealth.canine.dev/dimensions/D8"},{"id":"D9","name":"Test Distribution","shortDescription":{"text":"Test Distribution"},"helpUri":"https://codehealth.canine.dev/dimensions/D9"},{"id":"D10","name":"Test Quality","shortDescription":{"text":"Test Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D10"},{"id":"D11","name":"Test Reliability","shortDescription":{"text":"Test Reliability"},"helpUri":"https://codehealth.canine.dev/dimensions/D11"},{"id":"D12","name":"Dependency Hygiene","shortDescription":{"text":"Dependency Hygiene"},"helpUri":"https://codehealth.canine.dev/dimensions/D12"},{"id":"D13","name":"Secret Scanning","shortDescription":{"text":"Secret Scanning"},"helpUri":"https://codehealth.canine.dev/dimensions/D13","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"]}},{"id":"D16","name":"Bus Factor","shortDescription":{"text":"Bus Factor"},"helpUri":"https://codehealth.canine.dev/dimensions/D16"},{"id":"D17","name":"Explicit Debt","shortDescription":{"text":"Explicit Debt"},"helpUri":"https://codehealth.canine.dev/dimensions/D17"},{"id":"D18","name":"Solution Shape","shortDescription":{"text":"Solution Shape"},"helpUri":"https://codehealth.canine.dev/dimensions/D18"},{"id":"D19","name":"Documentation Quality","shortDescription":{"text":"Documentation Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D19"},{"id":"D20","name":"ADR Quality","shortDescription":{"text":"ADR Quality"},"helpUri":"https://codehealth.canine.dev/dimensions/D20"},{"id":"D21","name":"Naming Consistency","shortDescription":{"text":"Naming Consistency"},"helpUri":"https://codehealth.canine.dev/dimensions/D21"},{"id":"D24","name":"Comment Value","shortDescription":{"text":"Comment Value"},"helpUri":"https://codehealth.canine.dev/dimensions/D24"},{"id":"D26","name":"Project Cohesion","shortDescription":{"text":"Project Cohesion"},"helpUri":"https://codehealth.canine.dev/dimensions/D26"},{"id":"D28","name":"Secrets (history)","shortDescription":{"text":"Secrets (history)"},"helpUri":"https://codehealth.canine.dev/dimensions/D28","relationships":[{"target":{"id":"CWE-798","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-259","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-798","CWE-259"]}},{"id":"D29","name":"Static Analysis (SAST)","shortDescription":{"text":"Static Analysis (SAST)"},"helpUri":"https://codehealth.canine.dev/dimensions/D29","relationships":[{"target":{"id":"CWE-79","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-89","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-78","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-94","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]},{"target":{"id":"CWE-77","toolComponent":{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d"}},"kinds":["relevant"]}],"properties":{"cwe":["CWE-79","CWE-89","CWE-78","CWE-94","CWE-77"]}},{"id":"D34","name":"Knowledge Freshness","shortDescription":{"text":"Knowledge Freshness"},"helpUri":"https://codehealth.canine.dev/dimensions/D34"},{"id":"D35","name":"Change Coupling","shortDescription":{"text":"Change Coupling"},"helpUri":"https://codehealth.canine.dev/dimensions/D35"}]}},"results":[{"ruleId":"D8","level":"warning","message":{"text":"Coverage not measured \u2014 test suite did not build: Coverage NOT MEASURED: this repository did not build in our analyzer environment (a C#/MSBuild compiler error), so no coverage could be collected. It is excluded from the score rather than counted as a near-zero defect. We did not read WHERE the failing diagnostic is, so this does not claim the fault is in your test code \u2014 a repository written for an older SDK band can compile for you and not for us. Run \u0060dotnet build\u0060 on this commit; if it succeeds, the gap is ours. Committing the Cobertura/OpenCover/lcov report your CI already produces also lets us measure real coverage without building anything."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"62e63e619c28f057e129f2997c965d32a457366a9ce18ca019ffb6bdfba85c99"}},{"ruleId":"D11","level":"warning","message":{"text":"Test reliability not measured \u2014 no test run produced results: Test reliability NOT MEASURED: the test run produced no results for any test tier, so no test ever ran and flakiness could not be exercised. The cause could not be attributed, so it is excluded from the score rather than read as an absence of tests."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"7d83a505f7fa19aeeece76141ae1e468d77e2a3fea2e88604b8140ebad47a6fe"}},{"ruleId":"D16","level":"warning","message":{"text":"dormant codebase \u2014 no living knowledge left to concentrate: Every one of the 22 significant source file(s) was last meaningfully changed so long ago that no living knowledge remains, so there is no concentration to measure \u2014 the bus factor is not scored. This is not a clean bill: nobody currently holds working knowledge of this code (see D34 Knowledge Freshness)."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"569d55ea5cb0330f13c125b289d07e5abdfcceac947a2c2645277937942e7d5f"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Http/HttpServerTransactionDelegateTests.cs"},"region":{"startLine":54}}}],"partialFingerprints":{"codehealthFindingId/v1":"47f5007c02c5d2270d1d9f7797e7f2213f1300b456fc062c0b29be25a1438d18"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Net/SchedulerTests.cs"},"region":{"startLine":7}}}],"partialFingerprints":{"codehealthFindingId/v1":"8fed65bb647a3a3e7ea98de9a8ca018c7fd7817176d7181d1b4b0ac4a8629dfb"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Net/ServerTests.cs"},"region":{"startLine":15}}}],"partialFingerprints":{"codehealthFindingId/v1":"fd1d26f41621fd8ae865d362dac1a805b40c352698ca262d276eca302f5d2707"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Net/SocketTests.cs"},"region":{"startLine":10}}}],"partialFingerprints":{"codehealthFindingId/v1":"77698c49d7c6cd584437709f1d26c6586aec50db09e9c570b408656152c503ce"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX test sync also \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Http/HttpServerTransactionDelegateTests.cs"},"region":{"startLine":242}}}],"partialFingerprints":{"codehealthFindingId/v1":"3131743e18f7395d2b6a337741644bfee52040542bcf82269af90b370cf38e73"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX do copy? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Http/Mocks.cs"},"region":{"startLine":23}}}],"partialFingerprints":{"codehealthFindingId/v1":"c717fb808decd6efd064d9dc8fbf52e47a6b0e8b87211670578c35e43199ed22"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX do copy? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Http/Mocks.cs"},"region":{"startLine":140}}}],"partialFingerprints":{"codehealthFindingId/v1":"1354458936502b21c301b27ebcb33536b454ee7c0e68f3f4dbdea3754fd51606"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX rename \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Http/Mocks.cs"},"region":{"startLine":186}}}],"partialFingerprints":{"codehealthFindingId/v1":"c7151bf9cc785461645f859f2a578587ff4f7e294f08ed452bacfbf019f0c8c0"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX perhaps should concat current.Data with an enumerable that throws \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Http/Transaction/RequestAccumulator.cs"},"region":{"startLine":36}}}],"partialFingerprints":{"codehealthFindingId/v1":"60fef1c53b928488ca71431d0bc17411e492653c7665a8aacd6cd6ed77119986"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX determine based on request info \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Http/Transaction/TransactionInput.cs"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"4b7cc13bab20da7f403ba4688c01c3eeb967ae4058b1b55b2d91cd1ca4a4dbd0"}},{"ruleId":"D17","level":"warning","message":{"text":"CommentedOutCode: 5 consecutive commented-code lines"},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Net/Delegates/SocketDelegate.cs"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"072849242865f75b5bbbc1855608ccf39ba5d8242b6dabb866c808eaa7eade29"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX pull out to somewhere else \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Net/NetTests.cs"},"region":{"startLine":351}}}],"partialFingerprints":{"codehealthFindingId/v1":"e76d024c834e90d1e96e1a1c85781440c63c35d792c1f60d25c07463065c3abb"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX disabled \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Net/SchedulerTests.cs"},"region":{"startLine":107}}}],"partialFingerprints":{"codehealthFindingId/v1":"dd721203859cd6688f5ce56e5a3ae3dbd5c47833e799f0eaf9ce40339a2a2b5e"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX disabled \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Net/SchedulerTests.cs"},"region":{"startLine":118}}}],"partialFingerprints":{"codehealthFindingId/v1":"2831abc3bace7de59362912bd16e4b047c8dba97eed6086a82f583215957d3b7"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO eventually it would probably be nice to support a fire-and-forget use-case: \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Net/SocketTests.cs"},"region":{"startLine":252}}}],"partialFingerprints":{"codehealthFindingId/v1":"242a0d94f15c5b943d4d334ed100e08f8a8fb3091ac2752630f99474f4a6c0d0"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX this maybe is kinda wrong. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Http/DataSubject.cs"},"region":{"startLine":30}}}],"partialFingerprints":{"codehealthFindingId/v1":"b3f638084b5db7811246735dc48fe7e5a6c0598eaff2fec470b1dcb9ef448d63"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX maybe we should have our own allocator? i don\u0027t know. maybe the runtime is good \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Http/DataSubject.cs"},"region":{"startLine":100}}}],"partialFingerprints":{"codehealthFindingId/v1":"0e754dbdd8ef853bfc4dabc5fc3602971555f9b578c7d1ba15493caefa68661b"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX don\u0027t reallocate every time \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Http/HttpResponseHeaderRenderer.cs"},"region":{"startLine":20}}}],"partialFingerprints":{"codehealthFindingId/v1":"ff4679b25ba2c9aeb9297afc759e6b33c12ff54d503320763c8fe9c0b21f8404"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX freelist \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Http/HttpServer.cs"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"40e427bdaa8a30b7cb10b135e1599874ceb64aab4d28421c5bdf509e3d37e5de"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX test this behavior \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Http/HttpServerSocketDelegate.cs"},"region":{"startLine":43}}}],"partialFingerprints":{"codehealthFindingId/v1":"9ff08ae3cf8155b03d0992084beff9a8df7df4b9e25dd1661563127d5c7504aa"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX return self to freelist \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Http/HttpServerTransactionDelegate.cs"},"region":{"startLine":68}}}],"partialFingerprints":{"codehealthFindingId/v1":"68366ee6de2de294d2b65e438e7c0b9eea96c5a2f7fb55f4468e3feac04c5081"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX what to do? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Http/HttpServerTransactionDelegate.cs"},"region":{"startLine":101}}}],"partialFingerprints":{"codehealthFindingId/v1":"abba13dd4b35ab419a1a5b4819381e4652af5bbedcf8c9dfae7406e0a2bbc8f0"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX still need to better account for Connection: close. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Http/HttpServerTransactionDelegate.cs"},"region":{"startLine":110}}}],"partialFingerprints":{"codehealthFindingId/v1":"e7a76c04d13231d91b8cd7ebb61be044278497038b7be573115a53a7ffb1a1a4"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX there is no cancel. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Http/OutputQueue.cs"},"region":{"startLine":71}}}],"partialFingerprints":{"codehealthFindingId/v1":"57a36fb2fe358e935e245cd99bd3cf84dc977f3e26f309b204bc2ffa48847e94"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX all of this should live in HTTP Machine \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Http/Parsing/ParserHandler.cs"},"region":{"startLine":6}}}],"partialFingerprints":{"codehealthFindingId/v1":"625a084a6ae14a3f0be2a02684cdc0866e21e9b35a6bc487998f5ebf3945af04"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX can we defer this check to the parser? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Http/Parsing/ParserHandler.cs"},"region":{"startLine":118}}}],"partialFingerprints":{"codehealthFindingId/v1":"9fd29e4559e5c8996d866b427d1fcf702228525e200d5462f0b7cb3ba59d830d"}},{"ruleId":"D17","level":"error","message":{"text":"EmptyCatchBlock: empty catch block \u2014 the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Narrow the catch to the exception you actually expect, record it through whatever this codebase already uses to report problems, or \u2014 where swallowing really is correct, as it often is on a teardown/dispose path where throwing would mask the original failure \u2014 write down WHY in a comment on the catch. The comment has to give the reason: a note that only restates the swallow (\u0022ignored\u0022, \u0022do nothing\u0022) is read as no explanation at all and leaves this row in place. Any of the three makes the decision reviewable; all three clear this row."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Net/Server/KayakServer.cs"},"region":{"startLine":141}}}],"partialFingerprints":{"codehealthFindingId/v1":"f936cc8f04f971c7da2895c220f033c366f1a513ca825246d2d712c3d2179e20"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX copy! could optimize here? \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Net/Socket/KayakSocket.cs"},"region":{"startLine":236}}}],"partialFingerprints":{"codehealthFindingId/v1":"e23f1de764d61c1eb190de93b1a4bba584f32ed000c0c33118ef68df31527766"}},{"ruleId":"D17","level":"warning","message":{"text":"XxxComment: // XXX \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"KayakExamples/Program.cs"},"region":{"startLine":96}}}],"partialFingerprints":{"codehealthFindingId/v1":"87e5052f2483d626d6179df9eda610de13f5f9154f5316c44d047db97cf3fd40"}},{"ruleId":"D17","level":"warning","message":{"text":"TodoComment: // TODO: place an upper limit on the size of the buffer. \u2014 source code is not a task system: move the work to your tracker and leave a reference instead (e.g. \u0060// REF: #123\u0060), so the task is planned where tasks live and the ticket links back to the code."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"KayakExamples/Program.cs"},"region":{"startLine":195}}}],"partialFingerprints":{"codehealthFindingId/v1":"e2370b604eb3dc88eae1b2705255a3ff88613c81cfaf22cb515e42ac8e2f1e0a"}},{"ruleId":"D17","level":"error","message":{"text":"NoWarnInCsproj: 1591 \u2014 this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or \u2014 if some occurrences really are legitimate \u2014 narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Kayak.csproj"},"region":{"startLine":31}}}],"partialFingerprints":{"codehealthFindingId/v1":"3aeab4b5edebea9eaf4179dd9ae6073e6d511b3ce7dedc44146d3101f481c678"}},{"ruleId":"D17","level":"error","message":{"text":"NoWarnInCsproj: 1591 \u2014 this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or \u2014 if some occurrences really are legitimate \u2014 narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Kayak.csproj"},"region":{"startLine":41}}}],"partialFingerprints":{"codehealthFindingId/v1":"29c072bad3799c89055bf94b25c22ebcb98984b0333d30cf1cc75a34010c3f62"}},{"ruleId":"D20","level":"note","message":{"text":"No ADRs found: No ADRs found at common paths; consider documenting architectural decisions in Docs/ADL/ or similar."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"d2bea044ff79d7d275f5a91a6e2f548586178eaf480274c33960ad020c854631"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022HTTP/1.0\u0022 \u2014 delete - HTTP/1.0 already says this"},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Tests/Http/Transaction/TransactionTestCases.cs"},"region":{"startLine":22}}}],"partialFingerprints":{"codehealthFindingId/v1":"b7f9b60e27256176589e620f55f2a0c562f3f394f34ee6bde1b9efb7fdc47120"}},{"ruleId":"D24","level":"note","message":{"text":"redundant comment: \u0022janky!\u0022 \u2014 remove - generated by the codegen stub, not a human reason"},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Extensions/Trace.cs"},"region":{"startLine":45}}}],"partialFingerprints":{"codehealthFindingId/v1":"09cd90c2452e27bc29fcec24d0012290e9913ca45b1141219c199e2f15c49299"}},{"ruleId":"D34","level":"note","message":{"text":"Dormant codebase: 22 of 22 significant files have no living knowledge \u2014 the codebase as a whole is dormant, not 22 separate risks. Re-engage owners or document before change."},"locations":[],"partialFingerprints":{"codehealthFindingId/v1":"4c69f1e54b7dd6fe9029dd02df6ba8f8145b789f2f18dbdaa086c40ded49dba6"}},{"ruleId":"D34","level":"note","message":{"text":"Largest orphaned file: One of the largest files with no living knowledge remaining \u2014 a reasonable place to start a read-through before the aggregate risk above bites."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"tools/KayakDocs/Markdown.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"2388fcaafffedd3c7d670e4beac7bd05058c26355cf10c04f72cdc395c0bc2bf"}},{"ruleId":"D34","level":"note","message":{"text":"Largest orphaned file: One of the largest files with no living knowledge remaining \u2014 a reasonable place to start a read-through before the aggregate risk above bites."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak.Cli/Options.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"222125edd6e45abddee47b9192da6e619e7cadff4216643884b22769e6d999ab"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: KayakScheduler.cs \u2194 KayakServer.cs: \u0060Kayak/Net/KayakScheduler.cs\u0060 and \u0060Kayak/Net/Server/KayakServer.cs\u0060 change together 71% of the time (15 of the 21 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder \u2014 so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Net/KayakScheduler.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"5ef2e14ed2580a909d3c9af907c953acc79ef984d3001c9cbd68637f1ae31733"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: KayakScheduler.cs \u2194 KayakSocket.cs: \u0060Kayak/Net/KayakScheduler.cs\u0060 and \u0060Kayak/Net/Socket/KayakSocket.cs\u0060 change together 62% of the time (13 of the 21 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder \u2014 so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Net/KayakScheduler.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"bed045b616d7a6cd4ffa00de992158915ac9e9b32fb720c28378d254182b792c"}},{"ruleId":"D35","level":"warning","message":{"text":"Change coupling: HttpServerSocketDelegate.cs \u2194 HttpServerTransactionDelegate.cs: \u0060Kayak/Http/HttpServerSocketDelegate.cs\u0060 and \u0060Kayak/Http/HttpServerTransactionDelegate.cs\u0060 change together 60% of the time (6 of the 10 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package \u2014 so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking."},"locations":[{"physicalLocation":{"artifactLocation":{"uri":"Kayak/Http/HttpServerSocketDelegate.cs"},"region":{"startLine":1}}}],"partialFingerprints":{"codehealthFindingId/v1":"cda0548279f8a1bc6a617bf95b7d5193763db21395a7c6a79d50b100f68b4fc9"}}],"taxonomies":[{"name":"CWE","guid":"c3a2b1d0-7f3e-4b2a-9c1d-5e6f7a8b9c0d","organization":"MITRE","informationUri":"https://cwe.mitre.org/","isComprehensive":false,"shortDescription":{"text":"The MITRE Common Weakness Enumeration (CWE)."},"taxa":[{"id":"CWE-259","guid":"ae9ad959-fbb6-9d5e-892d-3dca66da0b69","name":"Use of Hard-coded Password","shortDescription":{"text":"Use of Hard-coded Password"},"helpUri":"https://cwe.mitre.org/data/definitions/259.html"},{"id":"CWE-77","guid":"332c8ade-6612-9f56-a06b-d8d90b1a8750","name":"Command Injection","shortDescription":{"text":"Command Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/77.html"},{"id":"CWE-78","guid":"2e31ceaf-c7ae-2e5e-9661-cfb1362789cf","name":"OS Command Injection","shortDescription":{"text":"OS Command Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/78.html"},{"id":"CWE-79","guid":"fd45580b-e8c4-fc5e-8c2f-aa8fab0b4dbf","name":"Cross-site Scripting (XSS)","shortDescription":{"text":"Cross-site Scripting (XSS)"},"helpUri":"https://cwe.mitre.org/data/definitions/79.html"},{"id":"CWE-798","guid":"5e8f057d-fee3-995a-a0cb-9fc5b0d174d1","name":"Use of Hard-coded Credentials","shortDescription":{"text":"Use of Hard-coded Credentials"},"helpUri":"https://cwe.mitre.org/data/definitions/798.html"},{"id":"CWE-89","guid":"6d08fdad-37eb-c150-bbf0-d7d946863407","name":"SQL Injection","shortDescription":{"text":"SQL Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/89.html"},{"id":"CWE-94","guid":"75e7f50c-6c2f-dd52-bf40-bf6c52b861fd","name":"Code Injection","shortDescription":{"text":"Code Injection"},"helpUri":"https://cwe.mitre.org/data/definitions/94.html"}]}],"properties":{"codehealthPublication":{"public":true,"notice":"This is the PUBLIC form of this artifact. Findings are listed in full, but the details of SECURITY findings \u2014 which rule fired, in which file, on which line, and how to fix it \u2014 are deliberately withheld, and any secret-scanner results are excluded entirely. Where detail is absent here it was REMOVED FOR PUBLICATION; it is not missing from the analysis. The complete artifact is available from the repository owner.","securityFindingsRedacted":0,"secretScannerRunsExcluded":0}}}]}